Re: Looking for mentor

2016-04-24 Thread Mark Thomas
On 23/04/2016 04:01, Abdessamed MANSOURI wrote:
> I saw your modification on the code, but i really didn't understand the
> idea behind it, in previous days, i tried to debug it, but really i didn't
> figure where is the problem, if you have time, just explain to what you
> have done :)

The fix isn't right yet.

What I am trying to do is detect when async has been started in
Servlet.service() and then an exception is thrown before
Servlet.service() exists. In that case, we need to trigger Async error
handling.

The problem, as you have observed elsewhere, is that in some cases
onError() is called twice. Current I added code the ErrorReportValve to
trigger onError() but the criteria I used are not selective enough. I
either need find better criteria or more the test. I'm currently leaning
towards moving the test.

Mark


> 
> 2016-04-20 11:34 GMT+01:00 Mark Thomas :
> 
>> On 19/04/2016 23:44, Abdessamed MANSOURI wrote:
>>> I think, i just have to write a simple test case which is pretty similair
>>> to TestAsyncContextImpl.testListeners, or not?? :)
>>
>> Correct. You are heading in the right direction.
>>
>> You can use the existing test cases in TestAsyncContextImpl and the test
>> case provided in Bug 59219 as a guide.
>>
>> There should be a lot of code in TestAsyncContextImpl you can re-use
>> and/or extend slightly to do what you need.
>>
>> Don't worry about your first proposal being perfect. Get something that
>> works and we can provide you with feedback. Also, don't worry if you get
>> a lot of feedback and you end up changing most or even all of your
>> patch. The first patch I proposed was completely unrecognisable by the
>> time it actually made it into the Tomcat code base.
>>
>> Mark
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Looking for mentor

2016-04-22 Thread Abdessamed MANSOURI
I saw your modification on the code, but i really didn't understand the
idea behind it, in previous days, i tried to debug it, but really i didn't
figure where is the problem, if you have time, just explain to what you
have done :)

2016-04-20 11:34 GMT+01:00 Mark Thomas :

> On 19/04/2016 23:44, Abdessamed MANSOURI wrote:
> > I think, i just have to write a simple test case which is pretty similair
> > to TestAsyncContextImpl.testListeners, or not?? :)
>
> Correct. You are heading in the right direction.
>
> You can use the existing test cases in TestAsyncContextImpl and the test
> case provided in Bug 59219 as a guide.
>
> There should be a lot of code in TestAsyncContextImpl you can re-use
> and/or extend slightly to do what you need.
>
> Don't worry about your first proposal being perfect. Get something that
> works and we can provide you with feedback. Also, don't worry if you get
> a lot of feedback and you end up changing most or even all of your
> patch. The first patch I proposed was completely unrecognisable by the
> time it actually made it into the Tomcat code base.
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Looking for mentor

2016-04-20 Thread Mark Thomas
On 19/04/2016 23:44, Abdessamed MANSOURI wrote:
> I think, i just have to write a simple test case which is pretty similair
> to TestAsyncContextImpl.testListeners, or not?? :)

Correct. You are heading in the right direction.

You can use the existing test cases in TestAsyncContextImpl and the test
case provided in Bug 59219 as a guide.

There should be a lot of code in TestAsyncContextImpl you can re-use
and/or extend slightly to do what you need.

Don't worry about your first proposal being perfect. Get something that
works and we can provide you with feedback. Also, don't worry if you get
a lot of feedback and you end up changing most or even all of your
patch. The first patch I proposed was completely unrecognisable by the
time it actually made it into the Tomcat code base.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Looking for mentor

2016-04-19 Thread Abdessamed MANSOURI
I think, i just have to write a simple test case which is pretty similair
to TestAsyncContextImpl.testListeners, or not?? :)


Re: Looking for mentor

2016-04-19 Thread Abdessamed MANSOURI
I'm seeing how you write unit test by reading the written unit test, i
think, i should inherit TomcatBaseTest then use getTomcatInstance to get a
Tomcat instance, then add the servlet to the context, then launching
getUrl, and then how do i can know test the bug, do i should test it
returned response from the servlet against expected one, or another thing??
:)


Re: Looking for mentor

2016-04-19 Thread Abdessamed MANSOURI
correct me, if i'm wrong, plz :)

2016-04-19 22:58 GMT+01:00 Abdessamed MANSOURI :

> I'm seeing how you write unit test by reading the written unit test, i
> think, i should inherit TomcatBaseTest then use getTomcatInstance to get a
> Tomcat instance, then add the servlet to the context, then launching
> getUrl, and then how do i can know test the bug, do i should test it
> returned response from the servlet against expected one, or another thing??
> :)
>


Re: Looking for mentor

2016-04-19 Thread Abdessamed MANSOURI
Yes, why not, since the past two days i were configuring my VM to run
Ubuntu on my Windows 7, until today i finished (maybe because i'm not
expert), the problem were when launch catalina jpda start, i can't listen
on port 8000 (i tried to add rule in firewall but didn't work), so i
changed it to default JPDA port 1044, and now it works fine :)

Thank you for your caring, so nice from you :)

2016-04-19 8:56 GMT+01:00 Mark Thomas :

> On 17/04/2016 19:27, Abdessamed MANSOURI wrote:
> > Thank you so much, its so nice from you :)
>
> Another idea for somewhere to get started...
>
> I recently fixed bug 59219. That included a stand-alone test case but I
> didn't port that test case into the Tomcat unit tests. Porting that test
> case could be a great place to start getting involved.
>
> Mark
>
>
> >
> > 2016-04-17 15:36 GMT+01:00 Mark Thomas :
> >
> >> On 17/04/2016 11:34, Abdessamed MANSOURI wrote:
> >>> Guys, inside Tomcat source, there's many packages (Catalina, Jasper,
> >>> Tomcat, Juli, Coyote) what these packages stand for?? ( i want to
> >>> understand basic Tomcat architecture) :)
> >>
> >> It is for Tomcat 6 and while the detail has changed the high-level
> >> structure hasn't.
> >>
> >>
> https://www.packtpub.com/networking-and-servers/tomcat-6-developers-guide
> >>
> >> Catalina - The Servlet engine
> >> Coyote   - The HTTP, HTTP/2 and AJP I/O code
> >> EL   - The UEL implementation
> >> Jasper   - The JSP engine
> >> JULI - Internal logging framework
> >> Tomcat   - Various utility packages, low-level I/O code and the
> >>  WebSocket implementation
> >> Naming   - JNDI code
> >>
> >> Mark
> >>
> >>
> >>>
> >>> Thank you all.
> >>>
> >>> 2016-04-16 22:46 GMT+01:00 Abdessamed MANSOURI :
> >>>
>  Martin, i just have 2 computers (laptop and desktop), i don't use
> >> desktop
>  too much, so in past i tried many JVM implementations, i wanted to see
>  performance for each one, but today, when i launched unit tests, i
> >> forget
>  about changing it to OpenJDK, so at the end i figured that i used J9
> :)
> 
>  Mark, okey, i will try my best :)
> 
>  Thank you all for your time.
> 
>  2016-04-16 20:44 GMT+01:00 Mark Thomas :
> 
> > On 16/04/2016 20:34, Abdessamed MANSOURI wrote:
> >> Thank you for your response and your time, i checkouted svn trunk
> and
> > built
> >> Tomcat successfully, its works fine, i also run ant test, for unit
> > testing,
> >> but it ended with some errors (i've used IBM J9), now i completed
> this
> >> step, what do you suggests me to do now?? :)
> >
> > You could investigate those unit test failures to see why they
> >> happened.
> >
> > You could look at one of the open bugs or enhancement requests and
> try
> > producing a patch. Some possible starting point are:
> > - https://bz.apache.org/bugzilla/show_bug.cgi?id=57892
> > - https://bz.apache.org/bugzilla/show_bug.cgi?id=44787
> > - https://bz.apache.org/bugzilla/show_bug.cgi?id=47214
> > - https://bz.apache.org/bugzilla/show_bug.cgi?id=52952
> >
> >> I can't find Tomcat on Jira, why?? :)
> >
> > Because the Tomcat project uses Bugzilla, not Jira.
> >
> > Mark
> >
> >
> >>
> >> Thank you for your time again.
> >>
> >> 2016-04-16 16:25 GMT+01:00 Mark Thomas :
> >>
> >>> On 15/04/2016 17:59, Abdessamed MANSOURI wrote:
>  Hello all,
> 
>  I'm newcomer and i want to contribute to Tomcat developement, i
> have
> > some
>  free time (alots of time), so i want to be useful in this world
> >> better
> >>> than
>  sleeping all the day, so i'm looking for applying Apache mentoring
> >>> program,
>  i'm not guru in Java but not totaly a newbie, so i want to try all
> >> my
> >>> best
>  to help you guys, who want to be my mentor??
> >>>
> >>> Welcome to the Tomcat development community. Feel free to ask any
> >>> questions you have on this list.
> >>>
>  Note : i still student, but i'm not looking to do Tomcat as my
> final
>  project (i already have a final project), i wan't to help you (as
> >> much
> >>> as i
>  can).
> 
>  Thank you all for your time.
> >>>
> >>> The first step is to make sure you can build Tomcat locally. Follow
> >> the
> >>> instructions in [1] to checkout the latest Tomcat source and and
> >> build
> > it.
> >>>
> >>> Note that the URL you'll need to checkout Tomcat trunk is:
> >>> https://svn.apache.org/viewvc/tomcat/trunk
> >>>
> >>> If you have any questions, just ask.
> >>>
> >>> Mark
> >>>
> >>>
> >>> [1]
> > https://svn.apache.org/viewvc/tomcat/trunk/BUILDING.txt?view=markup
> >>>
> >>>
> >>>
> 

Re: Looking for mentor

2016-04-19 Thread Mark Thomas
On 17/04/2016 19:27, Abdessamed MANSOURI wrote:
> Thank you so much, its so nice from you :)

Another idea for somewhere to get started...

I recently fixed bug 59219. That included a stand-alone test case but I
didn't port that test case into the Tomcat unit tests. Porting that test
case could be a great place to start getting involved.

Mark


> 
> 2016-04-17 15:36 GMT+01:00 Mark Thomas :
> 
>> On 17/04/2016 11:34, Abdessamed MANSOURI wrote:
>>> Guys, inside Tomcat source, there's many packages (Catalina, Jasper,
>>> Tomcat, Juli, Coyote) what these packages stand for?? ( i want to
>>> understand basic Tomcat architecture) :)
>>
>> It is for Tomcat 6 and while the detail has changed the high-level
>> structure hasn't.
>>
>> https://www.packtpub.com/networking-and-servers/tomcat-6-developers-guide
>>
>> Catalina - The Servlet engine
>> Coyote   - The HTTP, HTTP/2 and AJP I/O code
>> EL   - The UEL implementation
>> Jasper   - The JSP engine
>> JULI - Internal logging framework
>> Tomcat   - Various utility packages, low-level I/O code and the
>>  WebSocket implementation
>> Naming   - JNDI code
>>
>> Mark
>>
>>
>>>
>>> Thank you all.
>>>
>>> 2016-04-16 22:46 GMT+01:00 Abdessamed MANSOURI :
>>>
 Martin, i just have 2 computers (laptop and desktop), i don't use
>> desktop
 too much, so in past i tried many JVM implementations, i wanted to see
 performance for each one, but today, when i launched unit tests, i
>> forget
 about changing it to OpenJDK, so at the end i figured that i used J9 :)

 Mark, okey, i will try my best :)

 Thank you all for your time.

 2016-04-16 20:44 GMT+01:00 Mark Thomas :

> On 16/04/2016 20:34, Abdessamed MANSOURI wrote:
>> Thank you for your response and your time, i checkouted svn trunk and
> built
>> Tomcat successfully, its works fine, i also run ant test, for unit
> testing,
>> but it ended with some errors (i've used IBM J9), now i completed this
>> step, what do you suggests me to do now?? :)
>
> You could investigate those unit test failures to see why they
>> happened.
>
> You could look at one of the open bugs or enhancement requests and try
> producing a patch. Some possible starting point are:
> - https://bz.apache.org/bugzilla/show_bug.cgi?id=57892
> - https://bz.apache.org/bugzilla/show_bug.cgi?id=44787
> - https://bz.apache.org/bugzilla/show_bug.cgi?id=47214
> - https://bz.apache.org/bugzilla/show_bug.cgi?id=52952
>
>> I can't find Tomcat on Jira, why?? :)
>
> Because the Tomcat project uses Bugzilla, not Jira.
>
> Mark
>
>
>>
>> Thank you for your time again.
>>
>> 2016-04-16 16:25 GMT+01:00 Mark Thomas :
>>
>>> On 15/04/2016 17:59, Abdessamed MANSOURI wrote:
 Hello all,

 I'm newcomer and i want to contribute to Tomcat developement, i have
> some
 free time (alots of time), so i want to be useful in this world
>> better
>>> than
 sleeping all the day, so i'm looking for applying Apache mentoring
>>> program,
 i'm not guru in Java but not totaly a newbie, so i want to try all
>> my
>>> best
 to help you guys, who want to be my mentor??
>>>
>>> Welcome to the Tomcat development community. Feel free to ask any
>>> questions you have on this list.
>>>
 Note : i still student, but i'm not looking to do Tomcat as my final
 project (i already have a final project), i wan't to help you (as
>> much
>>> as i
 can).

 Thank you all for your time.
>>>
>>> The first step is to make sure you can build Tomcat locally. Follow
>> the
>>> instructions in [1] to checkout the latest Tomcat source and and
>> build
> it.
>>>
>>> Note that the URL you'll need to checkout Tomcat trunk is:
>>> https://svn.apache.org/viewvc/tomcat/trunk
>>>
>>> If you have any questions, just ask.
>>>
>>> Mark
>>>
>>>
>>> [1]
> https://svn.apache.org/viewvc/tomcat/trunk/BUILDING.txt?view=markup
>>>
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>>
>>>
>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

>>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>
> 


-
To 

Re: Looking for mentor

2016-04-17 Thread Abdessamed MANSOURI
Thank you so much, its so nice from you :)

2016-04-17 15:36 GMT+01:00 Mark Thomas :

> On 17/04/2016 11:34, Abdessamed MANSOURI wrote:
> > Guys, inside Tomcat source, there's many packages (Catalina, Jasper,
> > Tomcat, Juli, Coyote) what these packages stand for?? ( i want to
> > understand basic Tomcat architecture) :)
>
> It is for Tomcat 6 and while the detail has changed the high-level
> structure hasn't.
>
> https://www.packtpub.com/networking-and-servers/tomcat-6-developers-guide
>
> Catalina - The Servlet engine
> Coyote   - The HTTP, HTTP/2 and AJP I/O code
> EL   - The UEL implementation
> Jasper   - The JSP engine
> JULI - Internal logging framework
> Tomcat   - Various utility packages, low-level I/O code and the
>  WebSocket implementation
> Naming   - JNDI code
>
> Mark
>
>
> >
> > Thank you all.
> >
> > 2016-04-16 22:46 GMT+01:00 Abdessamed MANSOURI :
> >
> >> Martin, i just have 2 computers (laptop and desktop), i don't use
> desktop
> >> too much, so in past i tried many JVM implementations, i wanted to see
> >> performance for each one, but today, when i launched unit tests, i
> forget
> >> about changing it to OpenJDK, so at the end i figured that i used J9 :)
> >>
> >> Mark, okey, i will try my best :)
> >>
> >> Thank you all for your time.
> >>
> >> 2016-04-16 20:44 GMT+01:00 Mark Thomas :
> >>
> >>> On 16/04/2016 20:34, Abdessamed MANSOURI wrote:
>  Thank you for your response and your time, i checkouted svn trunk and
> >>> built
>  Tomcat successfully, its works fine, i also run ant test, for unit
> >>> testing,
>  but it ended with some errors (i've used IBM J9), now i completed this
>  step, what do you suggests me to do now?? :)
> >>>
> >>> You could investigate those unit test failures to see why they
> happened.
> >>>
> >>> You could look at one of the open bugs or enhancement requests and try
> >>> producing a patch. Some possible starting point are:
> >>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=57892
> >>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=44787
> >>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=47214
> >>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=52952
> >>>
>  I can't find Tomcat on Jira, why?? :)
> >>>
> >>> Because the Tomcat project uses Bugzilla, not Jira.
> >>>
> >>> Mark
> >>>
> >>>
> 
>  Thank you for your time again.
> 
>  2016-04-16 16:25 GMT+01:00 Mark Thomas :
> 
> > On 15/04/2016 17:59, Abdessamed MANSOURI wrote:
> >> Hello all,
> >>
> >> I'm newcomer and i want to contribute to Tomcat developement, i have
> >>> some
> >> free time (alots of time), so i want to be useful in this world
> better
> > than
> >> sleeping all the day, so i'm looking for applying Apache mentoring
> > program,
> >> i'm not guru in Java but not totaly a newbie, so i want to try all
> my
> > best
> >> to help you guys, who want to be my mentor??
> >
> > Welcome to the Tomcat development community. Feel free to ask any
> > questions you have on this list.
> >
> >> Note : i still student, but i'm not looking to do Tomcat as my final
> >> project (i already have a final project), i wan't to help you (as
> much
> > as i
> >> can).
> >>
> >> Thank you all for your time.
> >
> > The first step is to make sure you can build Tomcat locally. Follow
> the
> > instructions in [1] to checkout the latest Tomcat source and and
> build
> >>> it.
> >
> > Note that the URL you'll need to checkout Tomcat trunk is:
> > https://svn.apache.org/viewvc/tomcat/trunk
> >
> > If you have any questions, just ask.
> >
> > Mark
> >
> >
> > [1]
> >>> https://svn.apache.org/viewvc/tomcat/trunk/BUILDING.txt?view=markup
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> >
> 
> >>>
> >>>
> >>> -
> >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >>> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>>
> >>>
> >>
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Looking for mentor

2016-04-17 Thread Mark Thomas
On 17/04/2016 11:34, Abdessamed MANSOURI wrote:
> Guys, inside Tomcat source, there's many packages (Catalina, Jasper,
> Tomcat, Juli, Coyote) what these packages stand for?? ( i want to
> understand basic Tomcat architecture) :)

It is for Tomcat 6 and while the detail has changed the high-level
structure hasn't.

https://www.packtpub.com/networking-and-servers/tomcat-6-developers-guide

Catalina - The Servlet engine
Coyote   - The HTTP, HTTP/2 and AJP I/O code
EL   - The UEL implementation
Jasper   - The JSP engine
JULI - Internal logging framework
Tomcat   - Various utility packages, low-level I/O code and the
 WebSocket implementation
Naming   - JNDI code

Mark


> 
> Thank you all.
> 
> 2016-04-16 22:46 GMT+01:00 Abdessamed MANSOURI :
> 
>> Martin, i just have 2 computers (laptop and desktop), i don't use desktop
>> too much, so in past i tried many JVM implementations, i wanted to see
>> performance for each one, but today, when i launched unit tests, i forget
>> about changing it to OpenJDK, so at the end i figured that i used J9 :)
>>
>> Mark, okey, i will try my best :)
>>
>> Thank you all for your time.
>>
>> 2016-04-16 20:44 GMT+01:00 Mark Thomas :
>>
>>> On 16/04/2016 20:34, Abdessamed MANSOURI wrote:
 Thank you for your response and your time, i checkouted svn trunk and
>>> built
 Tomcat successfully, its works fine, i also run ant test, for unit
>>> testing,
 but it ended with some errors (i've used IBM J9), now i completed this
 step, what do you suggests me to do now?? :)
>>>
>>> You could investigate those unit test failures to see why they happened.
>>>
>>> You could look at one of the open bugs or enhancement requests and try
>>> producing a patch. Some possible starting point are:
>>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=57892
>>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=44787
>>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=47214
>>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=52952
>>>
 I can't find Tomcat on Jira, why?? :)
>>>
>>> Because the Tomcat project uses Bugzilla, not Jira.
>>>
>>> Mark
>>>
>>>

 Thank you for your time again.

 2016-04-16 16:25 GMT+01:00 Mark Thomas :

> On 15/04/2016 17:59, Abdessamed MANSOURI wrote:
>> Hello all,
>>
>> I'm newcomer and i want to contribute to Tomcat developement, i have
>>> some
>> free time (alots of time), so i want to be useful in this world better
> than
>> sleeping all the day, so i'm looking for applying Apache mentoring
> program,
>> i'm not guru in Java but not totaly a newbie, so i want to try all my
> best
>> to help you guys, who want to be my mentor??
>
> Welcome to the Tomcat development community. Feel free to ask any
> questions you have on this list.
>
>> Note : i still student, but i'm not looking to do Tomcat as my final
>> project (i already have a final project), i wan't to help you (as much
> as i
>> can).
>>
>> Thank you all for your time.
>
> The first step is to make sure you can build Tomcat locally. Follow the
> instructions in [1] to checkout the latest Tomcat source and and build
>>> it.
>
> Note that the URL you'll need to checkout Tomcat trunk is:
> https://svn.apache.org/viewvc/tomcat/trunk
>
> If you have any questions, just ask.
>
> Mark
>
>
> [1]
>>> https://svn.apache.org/viewvc/tomcat/trunk/BUILDING.txt?view=markup
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

>>>
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>>
>>>
>>
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Looking for mentor

2016-04-17 Thread Abdessamed MANSOURI
Guys, inside Tomcat source, there's many packages (Catalina, Jasper,
Tomcat, Juli, Coyote) what these packages stand for?? ( i want to
understand basic Tomcat architecture) :)

Thank you all.

2016-04-16 22:46 GMT+01:00 Abdessamed MANSOURI :

> Martin, i just have 2 computers (laptop and desktop), i don't use desktop
> too much, so in past i tried many JVM implementations, i wanted to see
> performance for each one, but today, when i launched unit tests, i forget
> about changing it to OpenJDK, so at the end i figured that i used J9 :)
>
> Mark, okey, i will try my best :)
>
> Thank you all for your time.
>
> 2016-04-16 20:44 GMT+01:00 Mark Thomas :
>
>> On 16/04/2016 20:34, Abdessamed MANSOURI wrote:
>> > Thank you for your response and your time, i checkouted svn trunk and
>> built
>> > Tomcat successfully, its works fine, i also run ant test, for unit
>> testing,
>> > but it ended with some errors (i've used IBM J9), now i completed this
>> > step, what do you suggests me to do now?? :)
>>
>> You could investigate those unit test failures to see why they happened.
>>
>> You could look at one of the open bugs or enhancement requests and try
>> producing a patch. Some possible starting point are:
>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=57892
>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=44787
>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=47214
>> - https://bz.apache.org/bugzilla/show_bug.cgi?id=52952
>>
>> > I can't find Tomcat on Jira, why?? :)
>>
>> Because the Tomcat project uses Bugzilla, not Jira.
>>
>> Mark
>>
>>
>> >
>> > Thank you for your time again.
>> >
>> > 2016-04-16 16:25 GMT+01:00 Mark Thomas :
>> >
>> >> On 15/04/2016 17:59, Abdessamed MANSOURI wrote:
>> >>> Hello all,
>> >>>
>> >>> I'm newcomer and i want to contribute to Tomcat developement, i have
>> some
>> >>> free time (alots of time), so i want to be useful in this world better
>> >> than
>> >>> sleeping all the day, so i'm looking for applying Apache mentoring
>> >> program,
>> >>> i'm not guru in Java but not totaly a newbie, so i want to try all my
>> >> best
>> >>> to help you guys, who want to be my mentor??
>> >>
>> >> Welcome to the Tomcat development community. Feel free to ask any
>> >> questions you have on this list.
>> >>
>> >>> Note : i still student, but i'm not looking to do Tomcat as my final
>> >>> project (i already have a final project), i wan't to help you (as much
>> >> as i
>> >>> can).
>> >>>
>> >>> Thank you all for your time.
>> >>
>> >> The first step is to make sure you can build Tomcat locally. Follow the
>> >> instructions in [1] to checkout the latest Tomcat source and and build
>> it.
>> >>
>> >> Note that the URL you'll need to checkout Tomcat trunk is:
>> >> https://svn.apache.org/viewvc/tomcat/trunk
>> >>
>> >> If you have any questions, just ask.
>> >>
>> >> Mark
>> >>
>> >>
>> >> [1]
>> https://svn.apache.org/viewvc/tomcat/trunk/BUILDING.txt?view=markup
>> >>
>> >>
>> >> -
>> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> >> For additional commands, e-mail: dev-h...@tomcat.apache.org
>> >>
>> >>
>> >
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>
>


Re: Looking for mentor

2016-04-16 Thread Abdessamed MANSOURI
Martin, i just have 2 computers (laptop and desktop), i don't use desktop
too much, so in past i tried many JVM implementations, i wanted to see
performance for each one, but today, when i launched unit tests, i forget
about changing it to OpenJDK, so at the end i figured that i used J9 :)

Mark, okey, i will try my best :)

Thank you all for your time.

2016-04-16 20:44 GMT+01:00 Mark Thomas :

> On 16/04/2016 20:34, Abdessamed MANSOURI wrote:
> > Thank you for your response and your time, i checkouted svn trunk and
> built
> > Tomcat successfully, its works fine, i also run ant test, for unit
> testing,
> > but it ended with some errors (i've used IBM J9), now i completed this
> > step, what do you suggests me to do now?? :)
>
> You could investigate those unit test failures to see why they happened.
>
> You could look at one of the open bugs or enhancement requests and try
> producing a patch. Some possible starting point are:
> - https://bz.apache.org/bugzilla/show_bug.cgi?id=57892
> - https://bz.apache.org/bugzilla/show_bug.cgi?id=44787
> - https://bz.apache.org/bugzilla/show_bug.cgi?id=47214
> - https://bz.apache.org/bugzilla/show_bug.cgi?id=52952
>
> > I can't find Tomcat on Jira, why?? :)
>
> Because the Tomcat project uses Bugzilla, not Jira.
>
> Mark
>
>
> >
> > Thank you for your time again.
> >
> > 2016-04-16 16:25 GMT+01:00 Mark Thomas :
> >
> >> On 15/04/2016 17:59, Abdessamed MANSOURI wrote:
> >>> Hello all,
> >>>
> >>> I'm newcomer and i want to contribute to Tomcat developement, i have
> some
> >>> free time (alots of time), so i want to be useful in this world better
> >> than
> >>> sleeping all the day, so i'm looking for applying Apache mentoring
> >> program,
> >>> i'm not guru in Java but not totaly a newbie, so i want to try all my
> >> best
> >>> to help you guys, who want to be my mentor??
> >>
> >> Welcome to the Tomcat development community. Feel free to ask any
> >> questions you have on this list.
> >>
> >>> Note : i still student, but i'm not looking to do Tomcat as my final
> >>> project (i already have a final project), i wan't to help you (as much
> >> as i
> >>> can).
> >>>
> >>> Thank you all for your time.
> >>
> >> The first step is to make sure you can build Tomcat locally. Follow the
> >> instructions in [1] to checkout the latest Tomcat source and and build
> it.
> >>
> >> Note that the URL you'll need to checkout Tomcat trunk is:
> >> https://svn.apache.org/viewvc/tomcat/trunk
> >>
> >> If you have any questions, just ask.
> >>
> >> Mark
> >>
> >>
> >> [1] https://svn.apache.org/viewvc/tomcat/trunk/BUILDING.txt?view=markup
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>
> >>
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Looking for mentor

2016-04-16 Thread Mark Thomas
On 16/04/2016 20:34, Abdessamed MANSOURI wrote:
> Thank you for your response and your time, i checkouted svn trunk and built
> Tomcat successfully, its works fine, i also run ant test, for unit testing,
> but it ended with some errors (i've used IBM J9), now i completed this
> step, what do you suggests me to do now?? :)

You could investigate those unit test failures to see why they happened.

You could look at one of the open bugs or enhancement requests and try
producing a patch. Some possible starting point are:
- https://bz.apache.org/bugzilla/show_bug.cgi?id=57892
- https://bz.apache.org/bugzilla/show_bug.cgi?id=44787
- https://bz.apache.org/bugzilla/show_bug.cgi?id=47214
- https://bz.apache.org/bugzilla/show_bug.cgi?id=52952

> I can't find Tomcat on Jira, why?? :)

Because the Tomcat project uses Bugzilla, not Jira.

Mark


> 
> Thank you for your time again.
> 
> 2016-04-16 16:25 GMT+01:00 Mark Thomas :
> 
>> On 15/04/2016 17:59, Abdessamed MANSOURI wrote:
>>> Hello all,
>>>
>>> I'm newcomer and i want to contribute to Tomcat developement, i have some
>>> free time (alots of time), so i want to be useful in this world better
>> than
>>> sleeping all the day, so i'm looking for applying Apache mentoring
>> program,
>>> i'm not guru in Java but not totaly a newbie, so i want to try all my
>> best
>>> to help you guys, who want to be my mentor??
>>
>> Welcome to the Tomcat development community. Feel free to ask any
>> questions you have on this list.
>>
>>> Note : i still student, but i'm not looking to do Tomcat as my final
>>> project (i already have a final project), i wan't to help you (as much
>> as i
>>> can).
>>>
>>> Thank you all for your time.
>>
>> The first step is to make sure you can build Tomcat locally. Follow the
>> instructions in [1] to checkout the latest Tomcat source and and build it.
>>
>> Note that the URL you'll need to checkout Tomcat trunk is:
>> https://svn.apache.org/viewvc/tomcat/trunk
>>
>> If you have any questions, just ask.
>>
>> Mark
>>
>>
>> [1] https://svn.apache.org/viewvc/tomcat/trunk/BUILDING.txt?view=markup
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Looking for mentor

2016-04-16 Thread Martin Grigorov
Hi,

On Sat, Apr 16, 2016 at 9:34 PM, Abdessamed MANSOURI 
wrote:

> Thank you for your response and your time, i checkouted svn trunk and built
> Tomcat successfully, its works fine, i also run ant test, for unit testing,
> but it ended with some errors (i've used IBM J9), now i completed this
> step, what do you suggests me to do now?? :)
>

Out of curiosity: Why do you use J9 ?
I guess your first task could be to make all Tomcat tests running on J9 ;-)


>
> I can't find Tomcat on Jira, why?? :)
>

Tomcat is using Bugzilla.
Check http://tomcat.apache.org/bugreport.html


>
> Thank you for your time again.
>
> 2016-04-16 16:25 GMT+01:00 Mark Thomas :
>
> > On 15/04/2016 17:59, Abdessamed MANSOURI wrote:
> > > Hello all,
> > >
> > > I'm newcomer and i want to contribute to Tomcat developement, i have
> some
> > > free time (alots of time), so i want to be useful in this world better
> > than
> > > sleeping all the day, so i'm looking for applying Apache mentoring
> > program,
> > > i'm not guru in Java but not totaly a newbie, so i want to try all my
> > best
> > > to help you guys, who want to be my mentor??
> >
> > Welcome to the Tomcat development community. Feel free to ask any
> > questions you have on this list.
> >
> > > Note : i still student, but i'm not looking to do Tomcat as my final
> > > project (i already have a final project), i wan't to help you (as much
> > as i
> > > can).
> > >
> > > Thank you all for your time.
> >
> > The first step is to make sure you can build Tomcat locally. Follow the
> > instructions in [1] to checkout the latest Tomcat source and and build
> it.
> >
> > Note that the URL you'll need to checkout Tomcat trunk is:
> > https://svn.apache.org/viewvc/tomcat/trunk
> >
> > If you have any questions, just ask.
> >
> > Mark
> >
> >
> > [1] https://svn.apache.org/viewvc/tomcat/trunk/BUILDING.txt?view=markup
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> >
>


Re: Looking for mentor

2016-04-16 Thread Abdessamed MANSOURI
Thank you for your response and your time, i checkouted svn trunk and built
Tomcat successfully, its works fine, i also run ant test, for unit testing,
but it ended with some errors (i've used IBM J9), now i completed this
step, what do you suggests me to do now?? :)

I can't find Tomcat on Jira, why?? :)

Thank you for your time again.

2016-04-16 16:25 GMT+01:00 Mark Thomas :

> On 15/04/2016 17:59, Abdessamed MANSOURI wrote:
> > Hello all,
> >
> > I'm newcomer and i want to contribute to Tomcat developement, i have some
> > free time (alots of time), so i want to be useful in this world better
> than
> > sleeping all the day, so i'm looking for applying Apache mentoring
> program,
> > i'm not guru in Java but not totaly a newbie, so i want to try all my
> best
> > to help you guys, who want to be my mentor??
>
> Welcome to the Tomcat development community. Feel free to ask any
> questions you have on this list.
>
> > Note : i still student, but i'm not looking to do Tomcat as my final
> > project (i already have a final project), i wan't to help you (as much
> as i
> > can).
> >
> > Thank you all for your time.
>
> The first step is to make sure you can build Tomcat locally. Follow the
> instructions in [1] to checkout the latest Tomcat source and and build it.
>
> Note that the URL you'll need to checkout Tomcat trunk is:
> https://svn.apache.org/viewvc/tomcat/trunk
>
> If you have any questions, just ask.
>
> Mark
>
>
> [1] https://svn.apache.org/viewvc/tomcat/trunk/BUILDING.txt?view=markup
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Looking for mentor

2016-04-16 Thread Mark Thomas
On 15/04/2016 17:59, Abdessamed MANSOURI wrote:
> Hello all,
> 
> I'm newcomer and i want to contribute to Tomcat developement, i have some
> free time (alots of time), so i want to be useful in this world better than
> sleeping all the day, so i'm looking for applying Apache mentoring program,
> i'm not guru in Java but not totaly a newbie, so i want to try all my best
> to help you guys, who want to be my mentor??

Welcome to the Tomcat development community. Feel free to ask any
questions you have on this list.

> Note : i still student, but i'm not looking to do Tomcat as my final
> project (i already have a final project), i wan't to help you (as much as i
> can).
> 
> Thank you all for your time.

The first step is to make sure you can build Tomcat locally. Follow the
instructions in [1] to checkout the latest Tomcat source and and build it.

Note that the URL you'll need to checkout Tomcat trunk is:
https://svn.apache.org/viewvc/tomcat/trunk

If you have any questions, just ask.

Mark


[1] https://svn.apache.org/viewvc/tomcat/trunk/BUILDING.txt?view=markup


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Looking for mentor

2016-04-15 Thread Abdessamed MANSOURI
Hello all,

I'm newcomer and i want to contribute to Tomcat developement, i have some
free time (alots of time), so i want to be useful in this world better than
sleeping all the day, so i'm looking for applying Apache mentoring program,
i'm not guru in Java but not totaly a newbie, so i want to try all my best
to help you guys, who want to be my mentor??

Note : i still student, but i'm not looking to do Tomcat as my final
project (i already have a final project), i wan't to help you (as much as i
can).

Thank you all for your time.