Re: TCK Failed Was: Tomcat 5.5.18-beta preview
Dies Koper wrote: Hello Filip, In my application I used a pageContext.include which once threw a JasperException (ServletException) while it was supposed to (according to the spec) propagate the IOException as-is. I noticed that setting the deployment init param in conf\web.xml to false made it propagate the IOException correctly. Apparently JspServletWrapper checks this flag and decides to handle exceptions differently depending on this value. I did not look further into it as my problem is resolved, but I have been wondering why it would do this and whether to bring it up here. It's development. Indeed, it seems to be the reason: the original exception gets wrapped for nicer error reporting purposes. If development mode is off, then the original exception will be passed, so the test should then work. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: TCK Failed Was: Tomcat 5.5.18-beta preview
Filip Hanik - Dev Lists wrote: I'm still running the tests, I had some funky results come up when I turned off development, and I am re-running the tests to make sure it wasn't me screwing it up This is not really related, but where's the 5.5.18 build ? Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: TCK Failed Was: Tomcat 5.5.18-beta preview
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: I'm still running the tests, I had some funky results come up when I turned off development, and I am re-running the tests to make sure it wasn't me screwing it up This is not really related, but where's the 5.5.18 build ? http://people.apache.org/~fhanik/v5.5.18-beta/ Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: TCK Failed Was: Tomcat 5.5.18-beta preview
ok, development=false took care of the three errors, the TCK now runs error free for the first run, any subsequent runs I get about 50 or so errors. If I delete the contents of the work directory, it again runs error free, I'll do some investigations to see if its an actual issue Filip Remy Maucherat wrote: Dies Koper wrote: Hello Filip, In my application I used a pageContext.include which once threw a JasperException (ServletException) while it was supposed to (according to the spec) propagate the IOException as-is. I noticed that setting the deployment init param in conf\web.xml to false made it propagate the IOException correctly. Apparently JspServletWrapper checks this flag and decides to handle exceptions differently depending on this value. I did not look further into it as my problem is resolved, but I have been wondering why it would do this and whether to bring it up here. It's development. Indeed, it seems to be the reason: the original exception gets wrapped for nicer error reporting purposes. If development mode is off, then the original exception will be passed, so the test should then work. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: TCK Failed Was: Tomcat 5.5.18-beta preview
Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: I'm still running the tests, I had some funky results come up when I turned off development, and I am re-running the tests to make sure it wasn't me screwing it up This is not really related, but where's the 5.5.18 build ? http://people.apache.org/~fhanik/v5.5.18-beta/ Ok, thanks. There's something wrong with the .exe file size (it's about 2x as big as it should be). Maybe you're using a recent NSIS version (you should be using 2.0.0, newer versions tend to do crap when selecting files - I added workarounds so that it does not happen with Tomcat 6, but for 5.5, there are issues). Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: TCK Failed Was: Tomcat 5.5.18-beta preview
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: I'm still running the tests, I had some funky results come up when I turned off development, and I am re-running the tests to make sure it wasn't me screwing it up This is not really related, but where's the 5.5.18 build ? http://people.apache.org/~fhanik/v5.5.18-beta/ Ok, thanks. There's something wrong with the .exe file size (it's about 2x as big as it should be). Maybe you're using a recent NSIS version (you should be using 2.0.0, newer versions tend to do crap when selecting files - I added workarounds so that it does not happen with Tomcat 6, but for 5.5, there are issues). ok, will downgrade Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
TCK Failed Was: Tomcat 5.5.18-beta preview
Looks like the TCK is expecting a IOException, and not a runtime jasper exception when you have invalid TLD files is one of the errors. --- Test FAILED. Exception thrown by forwardedresource, but was not an instance of IOException Type thrown: org.apache.jasper.JasperException --- ERROR: Exception at: ERROR: com.sun.ts.tests.common.webclient.TestFailureException: Test FAILED! at com.sun.ts.tests.common.webclient.WebTestCase.execute(WebTestCase.java:168) at com.sun.ts.tests.common.webclient.BaseUrlClient.invoke(BaseUrlClient.java:378) at com.sun.ts.tests.jsp.api.javax_servlet.jsp.pagecontext.URLClient.pageContextForwardIOExceptionTest(URLClient.java:166) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at com.sun.ts.lib.harness.EETest.run(EETest.java:473) at com.sun.ts.lib.harness.EETest.getPropsReady(EETest.java:370) at com.sun.ts.lib.harness.EETest.run(EETest.java:229) at com.sun.ts.tests.jsp.api.javax_servlet.jsp.pagecontext.URLClient.main(URLClient.java:26) --- java.lang.RuntimeException: org.apache.jasper.JasperException: /WEB-INF/tags/negativeFragmentRtexprvalue.tag(6,1) Cannot specify both 'fragment' and 'type' attributes. If 'fragment' is present, 'type' is fixed as 'javax.servlet.jsp.tagext. JspFragment' at org.apache.jasper.compiler.ImplicitTagLibraryInfo.getTagFile(ImplicitTagLibraryInfo.java:129) at org.apache.jasper.compiler.Parser.parseCustomTag(Parser.java:1315) at org.apache.jasper.compiler.Parser.parseElements(Parser.java:1573) at org.apache.jasper.compiler.Parser.parse(Parser.java:126) at org.apache.jasper.compiler.ParserController.doParse(ParserController.java:211) at org.apache.jasper.compiler.ParserController.parse(ParserController.java:100) at org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:155) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:295) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:276) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:264) at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:563) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:305) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:314) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:264) at javax.servlet.http.HttpServlet.service(HttpServlet.java:802) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869) at org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java :664) at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527) at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80) at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684) at java.lang.Thread.run(Thread.java:595) java.lang.RuntimeException: org.apache.jasper.JasperException: /WEB-INF/tags/negativeFragmentType.tag(6,1) Cannot specif y both 'fragment' and 'type' attributes. If 'fragment' is present, 'type' is fixed as 'javax.servlet.jsp.tagext.JspFrag ment' at org.apache.jasper.compiler.ImplicitTagLibraryInfo.getTagFile(ImplicitTagLibraryInfo.java:129) at org.apache.jasper.compiler.Parser.parseCustomTag(Parser.java:1315) at org.apache.jasper.compiler.Parser.parseElements(Parser.java:1573) at org.apache.jasper.compiler.Parser.parse(Parser.java:126) at org.apache.jasper.compiler.ParserController.doParse(ParserController.java:211) at org.apache.jasper.compiler.ParserController.parse(ParserController.java:100) at
Re: TCK Failed Was: Tomcat 5.5.18-beta preview
Filip Hanik - Dev Lists wrote: in hindsight I think its ok to let these slip Probably. The first thing to check is if it's required somewhere in the specification for that (and if it's required, well ... lol). The main problem is that IOE is a checked exception, so there's a throws clause which would trickle down quite a bit in the code. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: TCK Failed Was: Tomcat 5.5.18-beta preview
Hello Filip, In my application I used a pageContext.include which once threw a JasperException (ServletException) while it was supposed to (according to the spec) propagate the IOException as-is. I noticed that setting the deployment init param in conf\web.xml to false made it propagate the IOException correctly. Apparently JspServletWrapper checks this flag and decides to handle exceptions differently depending on this value. I did not look further into it as my problem is resolved, but I have been wondering why it would do this and whether to bring it up here. Regards, Dies Filip Hanik - Dev Lists wrote: Looks like the TCK is expecting a IOException, and not a runtime jasper exception when you have invalid TLD files is one of the errors. --- Test FAILED. Exception thrown by forwardedresource, but was not an instance of IOException Type thrown: org.apache.jasper.JasperException --- ERROR: Exception at: ERROR: com.sun.ts.tests.common.webclient.TestFailureException: Test FAILED! at com.sun.ts.tests.common.webclient.WebTestCase.execute(WebTestCase.java:168) at com.sun.ts.tests.common.webclient.BaseUrlClient.invoke(BaseUrlClient.java:378) at com.sun.ts.tests.jsp.api.javax_servlet.jsp.pagecontext.URLClient.pageContextForwardIOExceptionTest(URLClient.java:166) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at com.sun.ts.lib.harness.EETest.run(EETest.java:473) at com.sun.ts.lib.harness.EETest.getPropsReady(EETest.java:370) at com.sun.ts.lib.harness.EETest.run(EETest.java:229) at com.sun.ts.tests.jsp.api.javax_servlet.jsp.pagecontext.URLClient.main(URLClient.java:26) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
