Re: removing empty stubs in tc-native trunk
Jean-Frederic, On 6/15/15 7:27 AM, jean-frederic clere wrote: > We have empty stubs in tc-native when openssl isn't detected, are those > still needed? > > With NIO and NIO2 connectors we don't need native when we aren't using SSL. > > Comments? Having #ifdef'd some of those stubs myself, the idea was to make it so you wouldn't crash the JVM if you called a native method from the Java side of things. Those stubs are (obviously) no-ops but can protect the user from bringing-down the server if they try to e.g. enable SSL with OpenSSL was not built-in. I would recommend leaving them in, though it might be cleaner to do it in another way (I'm not sure how, though). -chris signature.asc Description: OpenPGP digital signature
Re: removing empty stubs in tc-native trunk
On 15/06/2015 12:39, jean-frederic clere wrote: > On 06/15/2015 01:32 PM, Mark Thomas wrote: >> On 15/06/2015 12:27, jean-frederic clere wrote: >>> Hi, >>> >>> We have empty stubs in tc-native when openssl isn't detected, are those >>> still needed? >> >> Yes, if we want to be able to support the APR/native connector without >> OpenSSL. >> >>> With NIO and NIO2 connectors we don't need native when we aren't >>> using SSL. >>> >>> Comments? >> >> I don't know how useful APR/native is without OpenSSL. I suspect not >> very. >> >> I'm not against dropping the stubs but it probably needs wider >> consultation that just the dev list. > > OK I will keep and add missing (if any) in my port. If it is a lot of work (for possibly no benefit) I wouldn't object to them being removed. Cheers, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: removing empty stubs in tc-native trunk
2015-06-15 13:32 GMT+02:00 Mark Thomas : > On 15/06/2015 12:27, jean-frederic clere wrote: > > Hi, > > > > We have empty stubs in tc-native when openssl isn't detected, are those > > still needed? > > Yes, if we want to be able to support the APR/native connector without > OpenSSL. > > > With NIO and NIO2 connectors we don't need native when we aren't using > SSL. > > > > Comments? > > I don't know how useful APR/native is without OpenSSL. I suspect not very. > > I'm not against dropping the stubs but it probably needs wider > consultation that just the dev list. > > It was probably an export thing originally, maybe for the Windows build. I don't really remember. Anyway, I don't think it is useful at all, Linux builds from distributions have it, etc. Rémy
Re: removing empty stubs in tc-native trunk
On 06/15/2015 01:32 PM, Mark Thomas wrote: On 15/06/2015 12:27, jean-frederic clere wrote: Hi, We have empty stubs in tc-native when openssl isn't detected, are those still needed? Yes, if we want to be able to support the APR/native connector without OpenSSL. With NIO and NIO2 connectors we don't need native when we aren't using SSL. Comments? I don't know how useful APR/native is without OpenSSL. I suspect not very. I'm not against dropping the stubs but it probably needs wider consultation that just the dev list. OK I will keep and add missing (if any) in my port. Cheers Jean-Frederic Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: removing empty stubs in tc-native trunk
On 15/06/2015 12:27, jean-frederic clere wrote: > Hi, > > We have empty stubs in tc-native when openssl isn't detected, are those > still needed? Yes, if we want to be able to support the APR/native connector without OpenSSL. > With NIO and NIO2 connectors we don't need native when we aren't using SSL. > > Comments? I don't know how useful APR/native is without OpenSSL. I suspect not very. I'm not against dropping the stubs but it probably needs wider consultation that just the dev list. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
removing empty stubs in tc-native trunk
Hi, We have empty stubs in tc-native when openssl isn't detected, are those still needed? With NIO and NIO2 connectors we don't need native when we aren't using SSL. Comments? Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
