Re: svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt
I thought this proposal was that at digester-configuration-time, trying to add the same rule twice would raise an exception. IIUC you are talking about digester-runtime behavior which I think everyone thinks is now fine. I'm not really familiar with digester but wondered how practical is is to recognize duplicate rules. thanks david jencks On Feb 12, 2008, at 4:42 PM, Tim Funk wrote: In that case - that would revert the functionality which caused the issue to arrive in the first place. The original bug had a problem because they had the same listener class declared multiple times and it was only being fired once. The fix was to log a duplicate listener message on the user config error. It turns out that WebRuleSet was also adding the same item twice. (accidently) and so the duplicate message was being. So if the digester rules are changed to ignore dups - the original bug fix would then be invalid and the user would again silently wonder why only one instance is being used. -Tim jean-frederic clere wrote: Tim Funk wrote: Not sure if I understand the question, the problem is our use of digester. We had 2 listener rules being created and each called addListener. So when an a listener was found - it was being processed twice. Yes. My idea was to prevent add twice the same rule in Digester additionally to the actual fix. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt
Tim Funk wrote: Not sure if I understand the question, the problem is our use of digester. We had 2 listener rules being created and each called addListener. So when an a listener was found - it was being processed twice. Yes. My idea was to prevent add twice the same rule in Digester additionally to the actual fix. Cheers Jean-Frederic (Or was I missing something?) -Tim jean-frederic clere wrote: [EMAIL PROTECTED] wrote: Author: funkman Date: Tue Feb 12 08:27:45 2008 New Revision: 620848 URL: http://svn.apache.org/viewvc?rev=620848view=rev Log: addition of dupl listener removal and a vote Won't it be possible to prevent the addition in the Digester instead? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt
In that case - that would revert the functionality which caused the issue to arrive in the first place. The original bug had a problem because they had the same listener class declared multiple times and it was only being fired once. The fix was to log a duplicate listener message on the user config error. It turns out that WebRuleSet was also adding the same item twice. (accidently) and so the duplicate message was being. So if the digester rules are changed to ignore dups - the original bug fix would then be invalid and the user would again silently wonder why only one instance is being used. -Tim jean-frederic clere wrote: Tim Funk wrote: Not sure if I understand the question, the problem is our use of digester. We had 2 listener rules being created and each called addListener. So when an a listener was found - it was being processed twice. Yes. My idea was to prevent add twice the same rule in Digester additionally to the actual fix. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt
Hi Tim, +1 WebRuleSet LL 250 digester.addCallMethod(prefix + web-app/listener/listener- class, addApplicationListener, 0); digester.addRule(prefix + web-app/jsp-config, jspConfig); digester.addCallMethod(prefix + web-app/jsp-config/jsp- property-group/url-pattern, addJspMapping, 0); # Remove this... digester.addCallMethod(prefix + web-app/listener/listener- class, addApplicationListener, 0); We must also change this at tomcat 5.x.x code base (LL 240) Peter Am 12.02.2008 um 19:44 schrieb Tim Funk: Not sure if I understand the question, the problem is our use of digester. We had 2 listener rules being created and each called addListener. So when an a listener was found - it was being processed twice. (Or was I missing something?) -Tim jean-frederic clere wrote: [EMAIL PROTECTED] wrote: Author: funkman Date: Tue Feb 12 08:27:45 2008 New Revision: 620848 URL: http://svn.apache.org/viewvc?rev=620848view=rev Log: addition of dupl listener removal and a vote Won't it be possible to prevent the addition in the Digester instead? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt
Not sure if I understand the question, the problem is our use of digester. We had 2 listener rules being created and each called addListener. So when an a listener was found - it was being processed twice. (Or was I missing something?) -Tim jean-frederic clere wrote: [EMAIL PROTECTED] wrote: Author: funkman Date: Tue Feb 12 08:27:45 2008 New Revision: 620848 URL: http://svn.apache.org/viewvc?rev=620848view=rev Log: addition of dupl listener removal and a vote Won't it be possible to prevent the addition in the Digester instead? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt
[EMAIL PROTECTED] wrote: Author: funkman Date: Tue Feb 12 08:27:45 2008 New Revision: 620848 URL: http://svn.apache.org/viewvc?rev=620848view=rev Log: addition of dupl listener removal and a vote Won't it be possible to prevent the addition in the Digester instead? Cheers Jean-Frederic Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=620848r1=620847r2=620848view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Feb 12 08:27:45 2008 @@ -88,5 +88,11 @@ * ExtendedAccessLogValve cs-uri not print empty querystring http://svn.apache.org/viewvc?rev=620778view=rev - +1: pero + +1: pero,funkman + + +* Remove duplicate listner additions + http://svn.apache.org/viewvc?rev=620844view=rev + +1: funkman -1: + - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r620848 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: funkman Date: Tue Feb 12 08:27:45 2008 New Revision: 620848 URL: http://svn.apache.org/viewvc?rev=620848view=rev Log: addition of dupl listener removal and a vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=620848r1=620847r2=620848view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Feb 12 08:27:45 2008 @@ -88,5 +88,11 @@ * ExtendedAccessLogValve cs-uri not print empty querystring http://svn.apache.org/viewvc?rev=620778view=rev - +1: pero + +1: pero,funkman + + +* Remove duplicate listner additions + http://svn.apache.org/viewvc?rev=620844view=rev + +1: funkman -1: + - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
