Re: Another 8.0.0 milestone release

2019-01-23 Thread David Blevins
Thank you for volunteering, Cesar.

Roberto, you did the last 8.0.0-M1 release.  Do you want to take the lead and 
pull in Cesar (on the list of course) and get some binaries we can vote on 
tomorrow?  We can yank the MP support in Plus and Plume and hold that for 
8.0.0-next.

I'd say skip the previews and go straight to vote.  Everyone is 
enthusiastically supportive.

Timeline wise, it takes 72 hours for a vote, 24 hours for things to replication 
across the mirror system.  So that's 4 days.  If we want something ready to go 
the morning of the 29th, we need vote up Friday Morning at the very latest.

If we do pull this off, it'll be fantastic as 8.0.0-M1 was October.  Since then 
we've had 40 new contributors and more commits than we've ever had... in the 
entire history... of the project... ever. :)

Let's get our hard work released!


-- 
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

> On Jan 22, 2019, at 7:16 PM, César Hernández Mendoza  
> wrote:
> 
> I have never done a TomEE release but I'm willing to learn during 8.0.0-M2
> release :)
> 
> El mar., 22 ene. 2019 a las 19:59, David Blevins ()
> escribió:
> 
>> There are plans to launch start.microprofile.io on January 29th.  We have
>> a lot more MicroProfile support in master than we do in 8.0.0-M1.
>> 
>> What do we think about shooting out an 8.0.0-M2 asap and ensuring it's in
>> the server list for start.microprofile.io?
>> 
>> 
>> --
>> David Blevins
>> http://twitter.com/dblevins
>> http://www.tomitribe.com
>> 
>> 
> 
> -- 
> Atentamente:
> César Hernández Mendoza.



Re: Ejemplos en Español

2019-01-23 Thread David Blevins
> On Jan 23, 2019, at 1:19 PM, César Hernández Mendoza  
> wrote:
>> ... an upper case variable name :)
> 
> I really sorry about that horrible typo, somehow it passes under the
> commits and reviews.

There's nothing to be sorry for -- I thought it was funny :)  Besides, here is 
the nature of open source:

10 people are in a room each with a bag of rice
1 of them gives you his bag of rice
Theres one small rock in the rice, so he apologizes
The person accepting says "it's ok"

The typical status quo in this story:

 - The only person who did anything good is apologizing
 - The only person taking some is the one issuing forgiveness
 - The 9 people who did nothing offer no apology or ask for forgiveness

I always do my best to make sure this status quo is *not* the case.  So I will 
once again say, thank YOU Cesar :)  A harmless rock in an overall generous and 
rare gift is nothing.

If others want to help, I will help them do so and thank them properly like 
anyone who gets a gift :)

> I can keep pushing forward the improvements and keep hearing feedback is
> always a good way to know and fix the direction ... like, for example, the
> Upper case variable I added XD.

I already ran out of time to hack, but if you want to try another update that 
makes the url and title "Ejemplos" for the Spanish page, that'd be awesome.  We 
could publish with the way it is, but the trick is we won't be able to delete 
that directory if we do.

Good logic for this could be some new method in `Configuration` where we could 
define say

public static Lang[] getLanguages() {
return new Lang[] {
new Lang("es", "Ejemplos", /* any future page names could be in the 
constructor */),
new Lang("fr", "Exemples")
};
}

The languages would still be discovered automatically and default to 
"examples", etc., but there'd be some way for someone to come in and provide 
and override it to provide that fine touch.

Another improvement that can easily come later is perhaps inside the asciidoc 
or markdown, there could be

  - a "title_es" header next to the "title" header so people could provide a 
translated page name for the description in the index.
  - a "name_es" so people could supply a file name in the URL so pages like 
"alternate-descriptors.html" become "descriptores-alternativos.html" (or 
whatever the right translation is :)

I think people seeing we go the extra mile will really encourage contribution.

There's such a strong latino community (Spanish and Portuguese) I can easily 
imagine new examples coming in first in Spanish or Portuguese :)  A little 
leadership there and it would be a great way to show the latino community how 
strong it really is, and bring some pride from a friendly bit of 
English/Spanish/Portuguese competition :)


-David

> 
> El mié., 23 ene. 2019 a las 14:23, David Blevins ()
> escribió:
> 
>> Working on it now!
>> 
>> Off topic: My OCD is scaring even myself.  You've got 7 commits, 9 changed
>> files, 700 new lines of code and in under 20 seconds of pulling everything
>> into my IDE my eyes lock in on and cannot stop staring at the one place you
>> used an upper case variable name :)
>> 
>> -
>> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/VersionIndex.java#L65
>> 
>> I was only digging because I wanted to change "Examples" to "Ejemplos" and
>> I kinda felt bad for giving you too much feedback already.
>> 
>> Seriously, something is wrong with me :)
>> 
>> 
>> 
>> --
>> David Blevins
>> http://twitter.com/dblevins
>> http://www.tomitribe.com
>> 
>>> On Jan 23, 2019, at 7:45 AM, César Hernández Mendoza <
>> cesargu...@gmail.com> wrote:
>>> 
>>> Hi,
>>> Can some of the committers please redeploy TomEE  website,
>>> http://tomee.apache.org/docs.html still doesn't show the translation
>>> language available and https://issues.apache.org/jira/browse/TOMEE-2444
>> is
>>> still marked as Open.
>>> 
>>> El vie., 18 ene. 2019 a las 10:04, César Hernández Mendoza (<
>>> cesargu...@gmail.com>) escribió:
>>> 
 The PR was merged, can someone of the JIRA admins please move forward
>> the
 ticket?
 https://issues.apache.org/jira/browse/TOMEE-2444 and also redeploy
 tomee website.
 
 El mié., 16 ene. 2019 a las 18:18, Bruno Baptista (>> )
 escribió:
 
> Hi César,
> 
> The PR looks ok to me.
> 
> Thanks!
> 
> Bruno Baptista
> https://twitter.com/brunobat_
> 
> 
> On 16/01/19 23:44, César Hernández Mendoza wrote:
>> Hi!
>> 
>> I updated the code and now the PR is ready for review.
>> https://github.com/apache/tomee-site-generator/pull/16
>> 
>> @Bruno: I fixed the issue that was causing the test failure you
> identified.
>> @David: I implement your proposal of removing "en" to the path of the
>> default language (English).
>> 
>> 
>> El lun., 14 ene. 2019 a las 21:09, César Hernández Mendoza (<
>>

Re: How can i help?

2019-01-23 Thread Fausto Arredondo
Thank you.
 I'll work on it then.

El mié., 23 de ene. de 2019 a la(s) 15:56, César Hernández Mendoza (
cesargu...@gmail.com) escribió:

> We don't have a deadline for it, but for rules to follow I recommend you to
> check the recommended workflow we the contributors and committers use:
> http://tomee.apache.org/community/contributing/workflow.html
>
>
>
> El mié., 23 ene. 2019 a las 15:33, Fausto Arredondo (<
> fausto.arr...@gmail.com>) escribió:
>
> > Hi Cesar,
> > Thank you.
> > Ok, my JIRA username is "ivandev"
> >
> > Do we have a deadline for this issues or some rules to follow ?
> >
> >
> >
> > El mié., 23 de ene. de 2019 a la(s) 15:11, César Hernández Mendoza (
> > cesargu...@gmail.com) escribió:
> >
> > > @Fausto:
> > >
> > > Excellent!, I created https://issues.apache.org/jira/browse/TOMEE-2459
> .
> > > Notice that since the ticket is a clone from another ticket, it
> preserves
> > > the Assignee.
> > >
> > > Can you please provide your JIRA username so an admin can update the
> > > Assignee. If you haven't created an account on JIRA you can follow your
> > > setup here: http://tomee.apache.org/community/
> > >
> > > If you have any further question(s), we will be more than happy to help
> > you
> > > :)
> > >
> > > El mié., 23 ene. 2019 a las 13:44, Fausto Arredondo (<
> > > fausto.arr...@gmail.com>) escribió:
> > >
> > > > Hi Cesar,
> > > >
> > > > Ok , no problem I'll just work on the translation and ask for a  PR
> for
> > > > translating into Spanish , this one is ok ?
> > > >
> > > >
> > https://github.com/apache/tomee/tree/master/examples/access-timeout-meta
> > > >
> > > > Thanks.
> > > >
> > > > El mié., 23 de ene. de 2019 a la(s) 13:22, César Hernández Mendoza (
> > > > cesargu...@gmail.com) escribió:
> > > >
> > > > > Hola Fausto,
> > > > >
> > > > > I have a PR with the instruction for translating into Spanish (or
> any
> > > > > language) the examples Readme files, check the following link:
> > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/tomee/blob/1a2bc55df2070d6dc27d8a46a506f287071c19e4/examples/README.adoc#translation
> > > > >
> > > > > Yes, I can create a JIRA for you, for reference we can just clone
> > > > > TOMEE-2452 [1] and change the content according to the Readme
> file(s)
> > > you
> > > > > want to translate.
> > > > > What I can't do is to assign tickets because I don't have, yet, the
> > > > > permissions.
> > > > >
> > > > > From the current list of Examples [2], which one would you like to
> > > > > translate first?
> > > > >
> > > > > [1] https://issues.apache.org/jira/browse/TOMEE-2452
> > > > > [2] https://github.com/apache/tomee/tree/master/examples
> > > > >
> > > > >
> > > > > El mié., 23 ene. 2019 a las 12:33, Fausto Arredondo (<
> > > > > fausto.arr...@gmail.com>) escribió:
> > > > >
> > > > > > Hi Cesar,
> > > > > >
> > > > > > How can i start translating in Spanish? You will assign one JIRA
> to
> > > me
> > > > ?
> > > > > >
> > > > > > Thanks .
> > > > > >
> > > > > > El lun., 21 de ene. de 2019 a la(s) 10:56, César Hernández
> Mendoza
> > (
> > > > > > cesargu...@gmail.com) escribió:
> > > > > >
> > > > > > > Hi Fausto!
> > > > > > > We currently have a couple of Epics targeted for new
> > contributors,
> > > > > > > please check for instance:
> > > > > > >
> > > > > > > Generation of MP examples:
> > > > > > > https://issues.apache.org/jira/browse/TOMEE-2285
> > > > > > > Improving documentation:
> > > > > > https://issues.apache.org/jira/browse/TOMEE-2369
> > > > > > > Translation into other languages the examples. This is the one
> > for
> > > > > > Spanish
> > > > > > > but feel free to create the Main Task for another language:
> > > > > > > https://issues.apache.org/jira/browse/TOMEE-2442
> > > > > > >
> > > > > > > If you have some other Idea or you come up with a question just
> > > shout
> > > > > in
> > > > > > > the list!
> > > > > > >
> > > > > > >
> > > > > > > El sáb., 19 ene. 2019 a las 10:33, Fausto Arredondo (<
> > > > > > > fausto.arr...@gmail.com>) escribió:
> > > > > > >
> > > > > > > > Hello ,
> > > > > > > >
> > > > > > > > I'm very excited to be part of this community, please tell me
> > how
> > > > > can i
> > > > > > > > help you ?
> > > > > > > >
> > > > > > > > I'm a Java developer , i`ve been working on TI  for the last
> 4
> > > > years
> > > > > .
> > > > > > > >
> > > > > > > > Know  about Java JMS, Spring , WebServices REST / SOAP ,JPA ,
> > > EJB ,
> > > > > > CDI ,
> > > > > > > > Infinispan , AMQ
> > > > > > > > ServiceMix .
> > > > > > > >
> > > > > > > > Servers : Weblogic , Payara
> > > > > > > >
> > > > > > > > I 'm preparing myself to become a Java Architect , i do not
> > have
> > > > any
> > > > > > > > certifications yet.
> > > > > > > >
> > > > > > > > I  like to learn by reading and seeing others developers
> code.
> > > > > > > >
> > > > > > > > I like to participate on big or small interesting projects.
> > > > > > > >
> > > > > > > > Thank you hope to hear from you soon,
> > > > > > > >

Re: How can i help?

2019-01-23 Thread César Hernández Mendoza
We don't have a deadline for it, but for rules to follow I recommend you to
check the recommended workflow we the contributors and committers use:
http://tomee.apache.org/community/contributing/workflow.html



El mié., 23 ene. 2019 a las 15:33, Fausto Arredondo (<
fausto.arr...@gmail.com>) escribió:

> Hi Cesar,
> Thank you.
> Ok, my JIRA username is "ivandev"
>
> Do we have a deadline for this issues or some rules to follow ?
>
>
>
> El mié., 23 de ene. de 2019 a la(s) 15:11, César Hernández Mendoza (
> cesargu...@gmail.com) escribió:
>
> > @Fausto:
> >
> > Excellent!, I created https://issues.apache.org/jira/browse/TOMEE-2459.
> > Notice that since the ticket is a clone from another ticket, it preserves
> > the Assignee.
> >
> > Can you please provide your JIRA username so an admin can update the
> > Assignee. If you haven't created an account on JIRA you can follow your
> > setup here: http://tomee.apache.org/community/
> >
> > If you have any further question(s), we will be more than happy to help
> you
> > :)
> >
> > El mié., 23 ene. 2019 a las 13:44, Fausto Arredondo (<
> > fausto.arr...@gmail.com>) escribió:
> >
> > > Hi Cesar,
> > >
> > > Ok , no problem I'll just work on the translation and ask for a  PR for
> > > translating into Spanish , this one is ok ?
> > >
> > >
> https://github.com/apache/tomee/tree/master/examples/access-timeout-meta
> > >
> > > Thanks.
> > >
> > > El mié., 23 de ene. de 2019 a la(s) 13:22, César Hernández Mendoza (
> > > cesargu...@gmail.com) escribió:
> > >
> > > > Hola Fausto,
> > > >
> > > > I have a PR with the instruction for translating into Spanish (or any
> > > > language) the examples Readme files, check the following link:
> > > >
> > > >
> > >
> >
> https://github.com/apache/tomee/blob/1a2bc55df2070d6dc27d8a46a506f287071c19e4/examples/README.adoc#translation
> > > >
> > > > Yes, I can create a JIRA for you, for reference we can just clone
> > > > TOMEE-2452 [1] and change the content according to the Readme file(s)
> > you
> > > > want to translate.
> > > > What I can't do is to assign tickets because I don't have, yet, the
> > > > permissions.
> > > >
> > > > From the current list of Examples [2], which one would you like to
> > > > translate first?
> > > >
> > > > [1] https://issues.apache.org/jira/browse/TOMEE-2452
> > > > [2] https://github.com/apache/tomee/tree/master/examples
> > > >
> > > >
> > > > El mié., 23 ene. 2019 a las 12:33, Fausto Arredondo (<
> > > > fausto.arr...@gmail.com>) escribió:
> > > >
> > > > > Hi Cesar,
> > > > >
> > > > > How can i start translating in Spanish? You will assign one JIRA to
> > me
> > > ?
> > > > >
> > > > > Thanks .
> > > > >
> > > > > El lun., 21 de ene. de 2019 a la(s) 10:56, César Hernández Mendoza
> (
> > > > > cesargu...@gmail.com) escribió:
> > > > >
> > > > > > Hi Fausto!
> > > > > > We currently have a couple of Epics targeted for new
> contributors,
> > > > > > please check for instance:
> > > > > >
> > > > > > Generation of MP examples:
> > > > > > https://issues.apache.org/jira/browse/TOMEE-2285
> > > > > > Improving documentation:
> > > > > https://issues.apache.org/jira/browse/TOMEE-2369
> > > > > > Translation into other languages the examples. This is the one
> for
> > > > > Spanish
> > > > > > but feel free to create the Main Task for another language:
> > > > > > https://issues.apache.org/jira/browse/TOMEE-2442
> > > > > >
> > > > > > If you have some other Idea or you come up with a question just
> > shout
> > > > in
> > > > > > the list!
> > > > > >
> > > > > >
> > > > > > El sáb., 19 ene. 2019 a las 10:33, Fausto Arredondo (<
> > > > > > fausto.arr...@gmail.com>) escribió:
> > > > > >
> > > > > > > Hello ,
> > > > > > >
> > > > > > > I'm very excited to be part of this community, please tell me
> how
> > > > can i
> > > > > > > help you ?
> > > > > > >
> > > > > > > I'm a Java developer , i`ve been working on TI  for the last 4
> > > years
> > > > .
> > > > > > >
> > > > > > > Know  about Java JMS, Spring , WebServices REST / SOAP ,JPA ,
> > EJB ,
> > > > > CDI ,
> > > > > > > Infinispan , AMQ
> > > > > > > ServiceMix .
> > > > > > >
> > > > > > > Servers : Weblogic , Payara
> > > > > > >
> > > > > > > I 'm preparing myself to become a Java Architect , i do not
> have
> > > any
> > > > > > > certifications yet.
> > > > > > >
> > > > > > > I  like to learn by reading and seeing others developers code.
> > > > > > >
> > > > > > > I like to participate on big or small interesting projects.
> > > > > > >
> > > > > > > Thank you hope to hear from you soon,
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Atentamente:
> > > > > > César Hernández Mendoza.
> > > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Atentamente:
> > > > César Hernández Mendoza.
> > > >
> > >
> >
> >
> > --
> > Atentamente:
> > César Hernández Mendoza.
> >
>


-- 
Atentamente:
César Hernández Mendoza.


Re: Ejemplos en Español

2019-01-23 Thread Richard Monson-Haefel
That's not OCD. That's like Sherlock Holmes level of observation!

On Wed, Jan 23, 2019 at 2:23 PM David Blevins 
wrote:

> Working on it now!
>
> Off topic: My OCD is scaring even myself.  You've got 7 commits, 9 changed
> files, 700 new lines of code and in under 20 seconds of pulling everything
> into my IDE my eyes lock in on and cannot stop staring at the one place you
> used an upper case variable name :)
>
>  -
> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/VersionIndex.java#L65
>
> I was only digging because I wanted to change "Examples" to "Ejemplos" and
> I kinda felt bad for giving you too much feedback already.
>
> Seriously, something is wrong with me :)
>
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
> > On Jan 23, 2019, at 7:45 AM, César Hernández Mendoza <
> cesargu...@gmail.com> wrote:
> >
> > Hi,
> > Can some of the committers please redeploy TomEE  website,
> > http://tomee.apache.org/docs.html still doesn't show the translation
> > language available and https://issues.apache.org/jira/browse/TOMEE-2444
> is
> > still marked as Open.
> >
> > El vie., 18 ene. 2019 a las 10:04, César Hernández Mendoza (<
> > cesargu...@gmail.com>) escribió:
> >
> >> The PR was merged, can someone of the JIRA admins please move forward
> the
> >> ticket?
> >> https://issues.apache.org/jira/browse/TOMEE-2444 and also redeploy
> >> tomee website.
> >>
> >> El mié., 16 ene. 2019 a las 18:18, Bruno Baptista ( >)
> >> escribió:
> >>
> >>> Hi César,
> >>>
> >>> The PR looks ok to me.
> >>>
> >>> Thanks!
> >>>
> >>> Bruno Baptista
> >>> https://twitter.com/brunobat_
> >>>
> >>>
> >>> On 16/01/19 23:44, César Hernández Mendoza wrote:
>  Hi!
> 
>  I updated the code and now the PR is ready for review.
>  https://github.com/apache/tomee-site-generator/pull/16
> 
>  @Bruno: I fixed the issue that was causing the test failure you
> >>> identified.
>  @David: I implement your proposal of removing "en" to the path of the
>  default language (English).
> 
> 
>  El lun., 14 ene. 2019 a las 21:09, César Hernández Mendoza (<
>  cesargu...@gmail.com>) escribió:
> 
> > Thank you for the feedback,
> >
> >  site navigation has links to /latest/examples/ and similar -- people
> >>> were
> >> issuing PRs for broken links in headers, footers, menues, all dec
> and
> >> they're finally (hopefully) settled.
> > That's a good point, I was not aware of this /latest/examples/
> >>> reference
> > inside the docs and website. I only updated the doc.html page.
> >
> > We don't have direct access to the second svn, so I don't know of any
> >>> way
> >> to avoid doubling the size of that second repo.
> > I don't follow you entirely on this one. So far my understanding is
> >>> that
> > the process for building the site is divided into three major steps:
> >
> > 1) Download all the branches  into: tomee-site-generator/repos
> > 2) Copy from /repos folder all the branches
> > into: tomee-site-generator/target/jbake/content
> > 3) Bake the tomee-site-generator/target/jbake/content folder
> structure
> > to generate the final website
> > in: tomee-site-generator/target/site-1.0-SNAPSHOT
> >
> > My PR only touches step 2) without duplicating the content of the
> > documentation in English. I added /en  to standardize in the code the
> > indexing process that also is performed on step 2) to generate the
> > index.htmll per documentation Category, and Language on each Branch:
> >
> > --tomee-site-generator/target/jbake/content/tomee-8.0
> > - en
> >  |--examples
> > - es
> >  |--examples
> > - index.adoc
> >
> >
> > Tomorrow I'm going to analyze how to remove /en from the website
> >>> structure.
> >
> >
> > El lun., 14 ene. 2019 a las 17:45, David Blevins (<
> >>> david.blev...@gmail.com>)
> > escribió:
> >
> >> Little feedback on my side of the fence.  Can we avoid adding "en"
> to
> >>> the
> >> path of the default language?
> >>
> >> Couple small reasons:
> >>
> >>  - site navigation has links to /latest/examples/ and similar --
> >>> people
> >> were issuing PRs for broken links in headers, footers, menues, all
> >>> dec and
> >> they're finally (hopefully) settled.
> >>
> >>  - everything is in svn, the tomee-8.0 dir alone is 133M, and the
> >>> site
> >> overall is 1.7G.  The initial push took a few hours to sync and
> moving
> >> everything into an 'en/' directory will double the size.  The
> process
> >> actually involves one svn synching to another svn.  We don't have
> >>> direct
> >> access to the second svn, so I don't know of any way to avoid
> >>> doubling the
> >> size of that second repo.
> >>
> >>
> >> --
> >> David Blevins
> >> ht

Re: How can i help?

2019-01-23 Thread Fausto Arredondo
Hi Cesar,
Thank you.
Ok, my JIRA username is "ivandev"

Do we have a deadline for this issues or some rules to follow ?



El mié., 23 de ene. de 2019 a la(s) 15:11, César Hernández Mendoza (
cesargu...@gmail.com) escribió:

> @Fausto:
>
> Excellent!, I created https://issues.apache.org/jira/browse/TOMEE-2459.
> Notice that since the ticket is a clone from another ticket, it preserves
> the Assignee.
>
> Can you please provide your JIRA username so an admin can update the
> Assignee. If you haven't created an account on JIRA you can follow your
> setup here: http://tomee.apache.org/community/
>
> If you have any further question(s), we will be more than happy to help you
> :)
>
> El mié., 23 ene. 2019 a las 13:44, Fausto Arredondo (<
> fausto.arr...@gmail.com>) escribió:
>
> > Hi Cesar,
> >
> > Ok , no problem I'll just work on the translation and ask for a  PR for
> > translating into Spanish , this one is ok ?
> >
> > https://github.com/apache/tomee/tree/master/examples/access-timeout-meta
> >
> > Thanks.
> >
> > El mié., 23 de ene. de 2019 a la(s) 13:22, César Hernández Mendoza (
> > cesargu...@gmail.com) escribió:
> >
> > > Hola Fausto,
> > >
> > > I have a PR with the instruction for translating into Spanish (or any
> > > language) the examples Readme files, check the following link:
> > >
> > >
> >
> https://github.com/apache/tomee/blob/1a2bc55df2070d6dc27d8a46a506f287071c19e4/examples/README.adoc#translation
> > >
> > > Yes, I can create a JIRA for you, for reference we can just clone
> > > TOMEE-2452 [1] and change the content according to the Readme file(s)
> you
> > > want to translate.
> > > What I can't do is to assign tickets because I don't have, yet, the
> > > permissions.
> > >
> > > From the current list of Examples [2], which one would you like to
> > > translate first?
> > >
> > > [1] https://issues.apache.org/jira/browse/TOMEE-2452
> > > [2] https://github.com/apache/tomee/tree/master/examples
> > >
> > >
> > > El mié., 23 ene. 2019 a las 12:33, Fausto Arredondo (<
> > > fausto.arr...@gmail.com>) escribió:
> > >
> > > > Hi Cesar,
> > > >
> > > > How can i start translating in Spanish? You will assign one JIRA to
> me
> > ?
> > > >
> > > > Thanks .
> > > >
> > > > El lun., 21 de ene. de 2019 a la(s) 10:56, César Hernández Mendoza (
> > > > cesargu...@gmail.com) escribió:
> > > >
> > > > > Hi Fausto!
> > > > > We currently have a couple of Epics targeted for new contributors,
> > > > > please check for instance:
> > > > >
> > > > > Generation of MP examples:
> > > > > https://issues.apache.org/jira/browse/TOMEE-2285
> > > > > Improving documentation:
> > > > https://issues.apache.org/jira/browse/TOMEE-2369
> > > > > Translation into other languages the examples. This is the one for
> > > > Spanish
> > > > > but feel free to create the Main Task for another language:
> > > > > https://issues.apache.org/jira/browse/TOMEE-2442
> > > > >
> > > > > If you have some other Idea or you come up with a question just
> shout
> > > in
> > > > > the list!
> > > > >
> > > > >
> > > > > El sáb., 19 ene. 2019 a las 10:33, Fausto Arredondo (<
> > > > > fausto.arr...@gmail.com>) escribió:
> > > > >
> > > > > > Hello ,
> > > > > >
> > > > > > I'm very excited to be part of this community, please tell me how
> > > can i
> > > > > > help you ?
> > > > > >
> > > > > > I'm a Java developer , i`ve been working on TI  for the last 4
> > years
> > > .
> > > > > >
> > > > > > Know  about Java JMS, Spring , WebServices REST / SOAP ,JPA ,
> EJB ,
> > > > CDI ,
> > > > > > Infinispan , AMQ
> > > > > > ServiceMix .
> > > > > >
> > > > > > Servers : Weblogic , Payara
> > > > > >
> > > > > > I 'm preparing myself to become a Java Architect , i do not have
> > any
> > > > > > certifications yet.
> > > > > >
> > > > > > I  like to learn by reading and seeing others developers code.
> > > > > >
> > > > > > I like to participate on big or small interesting projects.
> > > > > >
> > > > > > Thank you hope to hear from you soon,
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Atentamente:
> > > > > César Hernández Mendoza.
> > > > >
> > > >
> > >
> > >
> > > --
> > > Atentamente:
> > > César Hernández Mendoza.
> > >
> >
>
>
> --
> Atentamente:
> César Hernández Mendoza.
>


Re: Ejemplos en Español

2019-01-23 Thread César Hernández Mendoza
>
> Working on it now!

Thank you.


> ... an upper case variable name :)

I really sorry about that horrible typo, somehow it passes under the
commits and reviews.

 I kinda felt bad for giving you too much feedback already.

I think the approach of incremental improvements is been a good approach
here because I see the website  as a green field for learning, migration,
implementation of new features along with the website development process.

I can keep pushing forward the improvements and keep hearing feedback is
always a good way to know and fix the direction ... like, for example, the
Upper case variable I added XD.



El mié., 23 ene. 2019 a las 14:23, David Blevins ()
escribió:

> Working on it now!
>
> Off topic: My OCD is scaring even myself.  You've got 7 commits, 9 changed
> files, 700 new lines of code and in under 20 seconds of pulling everything
> into my IDE my eyes lock in on and cannot stop staring at the one place you
> used an upper case variable name :)
>
>  -
> https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/VersionIndex.java#L65
>
> I was only digging because I wanted to change "Examples" to "Ejemplos" and
> I kinda felt bad for giving you too much feedback already.
>
> Seriously, something is wrong with me :)
>
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
> > On Jan 23, 2019, at 7:45 AM, César Hernández Mendoza <
> cesargu...@gmail.com> wrote:
> >
> > Hi,
> > Can some of the committers please redeploy TomEE  website,
> > http://tomee.apache.org/docs.html still doesn't show the translation
> > language available and https://issues.apache.org/jira/browse/TOMEE-2444
> is
> > still marked as Open.
> >
> > El vie., 18 ene. 2019 a las 10:04, César Hernández Mendoza (<
> > cesargu...@gmail.com>) escribió:
> >
> >> The PR was merged, can someone of the JIRA admins please move forward
> the
> >> ticket?
> >> https://issues.apache.org/jira/browse/TOMEE-2444 and also redeploy
> >> tomee website.
> >>
> >> El mié., 16 ene. 2019 a las 18:18, Bruno Baptista ( >)
> >> escribió:
> >>
> >>> Hi César,
> >>>
> >>> The PR looks ok to me.
> >>>
> >>> Thanks!
> >>>
> >>> Bruno Baptista
> >>> https://twitter.com/brunobat_
> >>>
> >>>
> >>> On 16/01/19 23:44, César Hernández Mendoza wrote:
>  Hi!
> 
>  I updated the code and now the PR is ready for review.
>  https://github.com/apache/tomee-site-generator/pull/16
> 
>  @Bruno: I fixed the issue that was causing the test failure you
> >>> identified.
>  @David: I implement your proposal of removing "en" to the path of the
>  default language (English).
> 
> 
>  El lun., 14 ene. 2019 a las 21:09, César Hernández Mendoza (<
>  cesargu...@gmail.com>) escribió:
> 
> > Thank you for the feedback,
> >
> >  site navigation has links to /latest/examples/ and similar -- people
> >>> were
> >> issuing PRs for broken links in headers, footers, menues, all dec
> and
> >> they're finally (hopefully) settled.
> > That's a good point, I was not aware of this /latest/examples/
> >>> reference
> > inside the docs and website. I only updated the doc.html page.
> >
> > We don't have direct access to the second svn, so I don't know of any
> >>> way
> >> to avoid doubling the size of that second repo.
> > I don't follow you entirely on this one. So far my understanding is
> >>> that
> > the process for building the site is divided into three major steps:
> >
> > 1) Download all the branches  into: tomee-site-generator/repos
> > 2) Copy from /repos folder all the branches
> > into: tomee-site-generator/target/jbake/content
> > 3) Bake the tomee-site-generator/target/jbake/content folder
> structure
> > to generate the final website
> > in: tomee-site-generator/target/site-1.0-SNAPSHOT
> >
> > My PR only touches step 2) without duplicating the content of the
> > documentation in English. I added /en  to standardize in the code the
> > indexing process that also is performed on step 2) to generate the
> > index.htmll per documentation Category, and Language on each Branch:
> >
> > --tomee-site-generator/target/jbake/content/tomee-8.0
> > - en
> >  |--examples
> > - es
> >  |--examples
> > - index.adoc
> >
> >
> > Tomorrow I'm going to analyze how to remove /en from the website
> >>> structure.
> >
> >
> > El lun., 14 ene. 2019 a las 17:45, David Blevins (<
> >>> david.blev...@gmail.com>)
> > escribió:
> >
> >> Little feedback on my side of the fence.  Can we avoid adding "en"
> to
> >>> the
> >> path of the default language?
> >>
> >> Couple small reasons:
> >>
> >>  - site navigation has links to /latest/examples/ and similar --
> >>> people
> >> were issuing PRs for broken links in headers, footers, menues, all
> >>> dec and
> >

Re: How can i help?

2019-01-23 Thread César Hernández Mendoza
@Fausto:

Excellent!, I created https://issues.apache.org/jira/browse/TOMEE-2459.
Notice that since the ticket is a clone from another ticket, it preserves
the Assignee.

Can you please provide your JIRA username so an admin can update the
Assignee. If you haven't created an account on JIRA you can follow your
setup here: http://tomee.apache.org/community/

If you have any further question(s), we will be more than happy to help you
:)

El mié., 23 ene. 2019 a las 13:44, Fausto Arredondo (<
fausto.arr...@gmail.com>) escribió:

> Hi Cesar,
>
> Ok , no problem I'll just work on the translation and ask for a  PR for
> translating into Spanish , this one is ok ?
>
> https://github.com/apache/tomee/tree/master/examples/access-timeout-meta
>
> Thanks.
>
> El mié., 23 de ene. de 2019 a la(s) 13:22, César Hernández Mendoza (
> cesargu...@gmail.com) escribió:
>
> > Hola Fausto,
> >
> > I have a PR with the instruction for translating into Spanish (or any
> > language) the examples Readme files, check the following link:
> >
> >
> https://github.com/apache/tomee/blob/1a2bc55df2070d6dc27d8a46a506f287071c19e4/examples/README.adoc#translation
> >
> > Yes, I can create a JIRA for you, for reference we can just clone
> > TOMEE-2452 [1] and change the content according to the Readme file(s) you
> > want to translate.
> > What I can't do is to assign tickets because I don't have, yet, the
> > permissions.
> >
> > From the current list of Examples [2], which one would you like to
> > translate first?
> >
> > [1] https://issues.apache.org/jira/browse/TOMEE-2452
> > [2] https://github.com/apache/tomee/tree/master/examples
> >
> >
> > El mié., 23 ene. 2019 a las 12:33, Fausto Arredondo (<
> > fausto.arr...@gmail.com>) escribió:
> >
> > > Hi Cesar,
> > >
> > > How can i start translating in Spanish? You will assign one JIRA to me
> ?
> > >
> > > Thanks .
> > >
> > > El lun., 21 de ene. de 2019 a la(s) 10:56, César Hernández Mendoza (
> > > cesargu...@gmail.com) escribió:
> > >
> > > > Hi Fausto!
> > > > We currently have a couple of Epics targeted for new contributors,
> > > > please check for instance:
> > > >
> > > > Generation of MP examples:
> > > > https://issues.apache.org/jira/browse/TOMEE-2285
> > > > Improving documentation:
> > > https://issues.apache.org/jira/browse/TOMEE-2369
> > > > Translation into other languages the examples. This is the one for
> > > Spanish
> > > > but feel free to create the Main Task for another language:
> > > > https://issues.apache.org/jira/browse/TOMEE-2442
> > > >
> > > > If you have some other Idea or you come up with a question just shout
> > in
> > > > the list!
> > > >
> > > >
> > > > El sáb., 19 ene. 2019 a las 10:33, Fausto Arredondo (<
> > > > fausto.arr...@gmail.com>) escribió:
> > > >
> > > > > Hello ,
> > > > >
> > > > > I'm very excited to be part of this community, please tell me how
> > can i
> > > > > help you ?
> > > > >
> > > > > I'm a Java developer , i`ve been working on TI  for the last 4
> years
> > .
> > > > >
> > > > > Know  about Java JMS, Spring , WebServices REST / SOAP ,JPA , EJB ,
> > > CDI ,
> > > > > Infinispan , AMQ
> > > > > ServiceMix .
> > > > >
> > > > > Servers : Weblogic , Payara
> > > > >
> > > > > I 'm preparing myself to become a Java Architect , i do not have
> any
> > > > > certifications yet.
> > > > >
> > > > > I  like to learn by reading and seeing others developers code.
> > > > >
> > > > > I like to participate on big or small interesting projects.
> > > > >
> > > > > Thank you hope to hear from you soon,
> > > > >
> > > >
> > > >
> > > > --
> > > > Atentamente:
> > > > César Hernández Mendoza.
> > > >
> > >
> >
> >
> > --
> > Atentamente:
> > César Hernández Mendoza.
> >
>


-- 
Atentamente:
César Hernández Mendoza.


Re: Ejemplos en Español

2019-01-23 Thread David Blevins
Working on it now!

Off topic: My OCD is scaring even myself.  You've got 7 commits, 9 changed 
files, 700 new lines of code and in under 20 seconds of pulling everything into 
my IDE my eyes lock in on and cannot stop staring at the one place you used an 
upper case variable name :)

 - 
https://github.com/apache/tomee-site-generator/blob/master/src/main/java/org/apache/tomee/website/VersionIndex.java#L65

I was only digging because I wanted to change "Examples" to "Ejemplos" and I 
kinda felt bad for giving you too much feedback already.

Seriously, something is wrong with me :)



-- 
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

> On Jan 23, 2019, at 7:45 AM, César Hernández Mendoza  
> wrote:
> 
> Hi,
> Can some of the committers please redeploy TomEE  website,
> http://tomee.apache.org/docs.html still doesn't show the translation
> language available and https://issues.apache.org/jira/browse/TOMEE-2444 is
> still marked as Open.
> 
> El vie., 18 ene. 2019 a las 10:04, César Hernández Mendoza (<
> cesargu...@gmail.com>) escribió:
> 
>> The PR was merged, can someone of the JIRA admins please move forward the
>> ticket?
>> https://issues.apache.org/jira/browse/TOMEE-2444 and also redeploy
>> tomee website.
>> 
>> El mié., 16 ene. 2019 a las 18:18, Bruno Baptista ()
>> escribió:
>> 
>>> Hi César,
>>> 
>>> The PR looks ok to me.
>>> 
>>> Thanks!
>>> 
>>> Bruno Baptista
>>> https://twitter.com/brunobat_
>>> 
>>> 
>>> On 16/01/19 23:44, César Hernández Mendoza wrote:
 Hi!
 
 I updated the code and now the PR is ready for review.
 https://github.com/apache/tomee-site-generator/pull/16
 
 @Bruno: I fixed the issue that was causing the test failure you
>>> identified.
 @David: I implement your proposal of removing "en" to the path of the
 default language (English).
 
 
 El lun., 14 ene. 2019 a las 21:09, César Hernández Mendoza (<
 cesargu...@gmail.com>) escribió:
 
> Thank you for the feedback,
> 
>  site navigation has links to /latest/examples/ and similar -- people
>>> were
>> issuing PRs for broken links in headers, footers, menues, all dec and
>> they're finally (hopefully) settled.
> That's a good point, I was not aware of this /latest/examples/
>>> reference
> inside the docs and website. I only updated the doc.html page.
> 
> We don't have direct access to the second svn, so I don't know of any
>>> way
>> to avoid doubling the size of that second repo.
> I don't follow you entirely on this one. So far my understanding is
>>> that
> the process for building the site is divided into three major steps:
> 
> 1) Download all the branches  into: tomee-site-generator/repos
> 2) Copy from /repos folder all the branches
> into: tomee-site-generator/target/jbake/content
> 3) Bake the tomee-site-generator/target/jbake/content folder  structure
> to generate the final website
> in: tomee-site-generator/target/site-1.0-SNAPSHOT
> 
> My PR only touches step 2) without duplicating the content of the
> documentation in English. I added /en  to standardize in the code the
> indexing process that also is performed on step 2) to generate the
> index.htmll per documentation Category, and Language on each Branch:
> 
> --tomee-site-generator/target/jbake/content/tomee-8.0
> - en
>  |--examples
> - es
>  |--examples
> - index.adoc
> 
> 
> Tomorrow I'm going to analyze how to remove /en from the website
>>> structure.
> 
> 
> El lun., 14 ene. 2019 a las 17:45, David Blevins (<
>>> david.blev...@gmail.com>)
> escribió:
> 
>> Little feedback on my side of the fence.  Can we avoid adding "en" to
>>> the
>> path of the default language?
>> 
>> Couple small reasons:
>> 
>>  - site navigation has links to /latest/examples/ and similar --
>>> people
>> were issuing PRs for broken links in headers, footers, menues, all
>>> dec and
>> they're finally (hopefully) settled.
>> 
>>  - everything is in svn, the tomee-8.0 dir alone is 133M, and the
>>> site
>> overall is 1.7G.  The initial push took a few hours to sync and moving
>> everything into an 'en/' directory will double the size.  The process
>> actually involves one svn synching to another svn.  We don't have
>>> direct
>> access to the second svn, so I don't know of any way to avoid
>>> doubling the
>> size of that second repo.
>> 
>> 
>> --
>> David Blevins
>> http://twitter.com/dblevins
>> http://www.tomitribe.com
>> 
>>> On Jan 14, 2019, at 12:57 PM, César Hernández Mendoza <
>> cesargu...@gmail.com> wrote:
>>> Thanks Bruno.
>>> I'm working on fixing that test and will be back with an updated PR
>>> when
>>> ready.
>>> 
>>> El lun., 14 ene. 2019 a las 5:33, Bruno Baptista (<
>>> bruno...@gmail.com>)
>>>

Re: How can i help?

2019-01-23 Thread Fausto Arredondo
Hi Cesar,

Ok , no problem I'll just work on the translation and ask for a  PR for
translating into Spanish , this one is ok ?

https://github.com/apache/tomee/tree/master/examples/access-timeout-meta

Thanks.

El mié., 23 de ene. de 2019 a la(s) 13:22, César Hernández Mendoza (
cesargu...@gmail.com) escribió:

> Hola Fausto,
>
> I have a PR with the instruction for translating into Spanish (or any
> language) the examples Readme files, check the following link:
>
> https://github.com/apache/tomee/blob/1a2bc55df2070d6dc27d8a46a506f287071c19e4/examples/README.adoc#translation
>
> Yes, I can create a JIRA for you, for reference we can just clone
> TOMEE-2452 [1] and change the content according to the Readme file(s) you
> want to translate.
> What I can't do is to assign tickets because I don't have, yet, the
> permissions.
>
> From the current list of Examples [2], which one would you like to
> translate first?
>
> [1] https://issues.apache.org/jira/browse/TOMEE-2452
> [2] https://github.com/apache/tomee/tree/master/examples
>
>
> El mié., 23 ene. 2019 a las 12:33, Fausto Arredondo (<
> fausto.arr...@gmail.com>) escribió:
>
> > Hi Cesar,
> >
> > How can i start translating in Spanish? You will assign one JIRA to me ?
> >
> > Thanks .
> >
> > El lun., 21 de ene. de 2019 a la(s) 10:56, César Hernández Mendoza (
> > cesargu...@gmail.com) escribió:
> >
> > > Hi Fausto!
> > > We currently have a couple of Epics targeted for new contributors,
> > > please check for instance:
> > >
> > > Generation of MP examples:
> > > https://issues.apache.org/jira/browse/TOMEE-2285
> > > Improving documentation:
> > https://issues.apache.org/jira/browse/TOMEE-2369
> > > Translation into other languages the examples. This is the one for
> > Spanish
> > > but feel free to create the Main Task for another language:
> > > https://issues.apache.org/jira/browse/TOMEE-2442
> > >
> > > If you have some other Idea or you come up with a question just shout
> in
> > > the list!
> > >
> > >
> > > El sáb., 19 ene. 2019 a las 10:33, Fausto Arredondo (<
> > > fausto.arr...@gmail.com>) escribió:
> > >
> > > > Hello ,
> > > >
> > > > I'm very excited to be part of this community, please tell me how
> can i
> > > > help you ?
> > > >
> > > > I'm a Java developer , i`ve been working on TI  for the last 4 years
> .
> > > >
> > > > Know  about Java JMS, Spring , WebServices REST / SOAP ,JPA , EJB ,
> > CDI ,
> > > > Infinispan , AMQ
> > > > ServiceMix .
> > > >
> > > > Servers : Weblogic , Payara
> > > >
> > > > I 'm preparing myself to become a Java Architect , i do not have any
> > > > certifications yet.
> > > >
> > > > I  like to learn by reading and seeing others developers code.
> > > >
> > > > I like to participate on big or small interesting projects.
> > > >
> > > > Thank you hope to hear from you soon,
> > > >
> > >
> > >
> > > --
> > > Atentamente:
> > > César Hernández Mendoza.
> > >
> >
>
>
> --
> Atentamente:
> César Hernández Mendoza.
>


Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread Roberto Cortez
I’ll try to have a look into the issue.

Are you positive that the apps are being deployed correctly? I think there are 
a few cases where there is a silent error and the app fails to deploy hence, 
you see the 404. If you have REST endpoints going deployed, it is easy to see 
if these are ok, since they show up in the log when deployed. Can you confirm?

> On 23 Jan 2019, at 18:32, j4fm  wrote:
> 
> So progress is good, I feel like it's close to working with MP.  Took the
> SystemInstance parent failover line out and now it's dependent on this issue
> being resolved https://issues.apache.org/jira/browse/TOMEE-2458 which was
> why it was put in the first place.  I've worked around by adding all the
> context dependencies to common.loader which is not ideal with the amount of
> dependencies that would then affect all other webapps in TomEE.
> 
> I will keep an eye out for the OpenAPI bump.
> 
> Now I'm at:
> 
> Every context deploys successfully but webapps are inaccessible (404 error)
> because of an issue with doFilter on the contextbean we have.  It's a
> convertException on the invoke.
> 
> I believe I had similar to this a while back with the TomEE MP edition and
> you mentioned to set geronimo.opentracing.filter.active=false.  So I set
> that, and the error is gone but still leaves me with 404 not found... just
> no errors at all that I can find.  I get the impression it's almost working.
> 
> 
> 
> --
> Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html



Re: How can i help?

2019-01-23 Thread César Hernández Mendoza
Hola Fausto,

I have a PR with the instruction for translating into Spanish (or any
language) the examples Readme files, check the following link:
https://github.com/apache/tomee/blob/1a2bc55df2070d6dc27d8a46a506f287071c19e4/examples/README.adoc#translation

Yes, I can create a JIRA for you, for reference we can just clone
TOMEE-2452 [1] and change the content according to the Readme file(s) you
want to translate.
What I can't do is to assign tickets because I don't have, yet, the
permissions.

>From the current list of Examples [2], which one would you like to
translate first?

[1] https://issues.apache.org/jira/browse/TOMEE-2452
[2] https://github.com/apache/tomee/tree/master/examples


El mié., 23 ene. 2019 a las 12:33, Fausto Arredondo (<
fausto.arr...@gmail.com>) escribió:

> Hi Cesar,
>
> How can i start translating in Spanish? You will assign one JIRA to me ?
>
> Thanks .
>
> El lun., 21 de ene. de 2019 a la(s) 10:56, César Hernández Mendoza (
> cesargu...@gmail.com) escribió:
>
> > Hi Fausto!
> > We currently have a couple of Epics targeted for new contributors,
> > please check for instance:
> >
> > Generation of MP examples:
> > https://issues.apache.org/jira/browse/TOMEE-2285
> > Improving documentation:
> https://issues.apache.org/jira/browse/TOMEE-2369
> > Translation into other languages the examples. This is the one for
> Spanish
> > but feel free to create the Main Task for another language:
> > https://issues.apache.org/jira/browse/TOMEE-2442
> >
> > If you have some other Idea or you come up with a question just shout in
> > the list!
> >
> >
> > El sáb., 19 ene. 2019 a las 10:33, Fausto Arredondo (<
> > fausto.arr...@gmail.com>) escribió:
> >
> > > Hello ,
> > >
> > > I'm very excited to be part of this community, please tell me how can i
> > > help you ?
> > >
> > > I'm a Java developer , i`ve been working on TI  for the last 4 years .
> > >
> > > Know  about Java JMS, Spring , WebServices REST / SOAP ,JPA , EJB ,
> CDI ,
> > > Infinispan , AMQ
> > > ServiceMix .
> > >
> > > Servers : Weblogic , Payara
> > >
> > > I 'm preparing myself to become a Java Architect , i do not have any
> > > certifications yet.
> > >
> > > I  like to learn by reading and seeing others developers code.
> > >
> > > I like to participate on big or small interesting projects.
> > >
> > > Thank you hope to hear from you soon,
> > >
> >
> >
> > --
> > Atentamente:
> > César Hernández Mendoza.
> >
>


-- 
Atentamente:
César Hernández Mendoza.


Re: How can i help?

2019-01-23 Thread Fausto Arredondo
Hi Cesar,

How can i start translating in Spanish? You will assign one JIRA to me ?

Thanks .

El lun., 21 de ene. de 2019 a la(s) 10:56, César Hernández Mendoza (
cesargu...@gmail.com) escribió:

> Hi Fausto!
> We currently have a couple of Epics targeted for new contributors,
> please check for instance:
>
> Generation of MP examples:
> https://issues.apache.org/jira/browse/TOMEE-2285
> Improving documentation: https://issues.apache.org/jira/browse/TOMEE-2369
> Translation into other languages the examples. This is the one for Spanish
> but feel free to create the Main Task for another language:
> https://issues.apache.org/jira/browse/TOMEE-2442
>
> If you have some other Idea or you come up with a question just shout in
> the list!
>
>
> El sáb., 19 ene. 2019 a las 10:33, Fausto Arredondo (<
> fausto.arr...@gmail.com>) escribió:
>
> > Hello ,
> >
> > I'm very excited to be part of this community, please tell me how can i
> > help you ?
> >
> > I'm a Java developer , i`ve been working on TI  for the last 4 years .
> >
> > Know  about Java JMS, Spring , WebServices REST / SOAP ,JPA , EJB , CDI ,
> > Infinispan , AMQ
> > ServiceMix .
> >
> > Servers : Weblogic , Payara
> >
> > I 'm preparing myself to become a Java Architect , i do not have any
> > certifications yet.
> >
> > I  like to learn by reading and seeing others developers code.
> >
> > I like to participate on big or small interesting projects.
> >
> > Thank you hope to hear from you soon,
> >
>
>
> --
> Atentamente:
> César Hernández Mendoza.
>


Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread j4fm
So progress is good, I feel like it's close to working with MP.  Took the
SystemInstance parent failover line out and now it's dependent on this issue
being resolved https://issues.apache.org/jira/browse/TOMEE-2458 which was
why it was put in the first place.  I've worked around by adding all the
context dependencies to common.loader which is not ideal with the amount of
dependencies that would then affect all other webapps in TomEE.

I will keep an eye out for the OpenAPI bump.

Now I'm at:

Every context deploys successfully but webapps are inaccessible (404 error)
because of an issue with doFilter on the contextbean we have.  It's a
convertException on the invoke.

I believe I had similar to this a while back with the TomEE MP edition and
you mentioned to set geronimo.opentracing.filter.active=false.  So I set
that, and the error is gone but still leaves me with 404 not found... just
no errors at all that I can find.  I get the impression it's almost working.



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html


Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread Roberto Cortez
Yes, OpenAPI made the fix:
https://github.com/apache/geronimo-openapi/commit/7ceee65e0b489f4847f4015aa71a3d7b6958b402
 


We still need to wait for a release or bump to use the SNAPSHOT version.

> On 23 Jan 2019, at 16:07, j4fm  wrote:
> 
> On this specific service, there is the following:
> 
> @Path("/")
> @GET
> public Response doGetRoot() {
> …
> }
> 
> Followed by paths with actual values just like you said.  It would be good
> for OpenAPI to provide a fix, I will see if I can test changing it in source
> directly tonight by just changing "/", to "".
> 
> 
> 
> 
> 
> --
> Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html



Re: Another 8.0.0 milestone release

2019-01-23 Thread Wiesner, Martin
Hi all,

+1 


Pls, also keep the release of 7.1.x (x=1) in mind, as the Java 11 
out-of-the-box experience is crucial for many users in the community.

Best Martin
—
https://twitter.com/mawiesne 



smime.p7s
Description: S/MIME cryptographic signature


Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread j4fm
On this specific service, there is the following:

@Path("/")
@GET
public Response doGetRoot() {
…
}

Followed by paths with actual values just like you said.  It would be good
for OpenAPI to provide a fix, I will see if I can test changing it in source
directly tonight by just changing "/", to "".





--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html


Re: Ejemplos en Español

2019-01-23 Thread César Hernández Mendoza
Hi,
Can some of the committers please redeploy TomEE  website,
http://tomee.apache.org/docs.html still doesn't show the translation
language available and https://issues.apache.org/jira/browse/TOMEE-2444 is
still marked as Open.

El vie., 18 ene. 2019 a las 10:04, César Hernández Mendoza (<
cesargu...@gmail.com>) escribió:

> The PR was merged, can someone of the JIRA admins please move forward the
> ticket?
> https://issues.apache.org/jira/browse/TOMEE-2444 and also redeploy
> tomee website.
>
> El mié., 16 ene. 2019 a las 18:18, Bruno Baptista ()
> escribió:
>
>> Hi César,
>>
>> The PR looks ok to me.
>>
>> Thanks!
>>
>> Bruno Baptista
>> https://twitter.com/brunobat_
>>
>>
>> On 16/01/19 23:44, César Hernández Mendoza wrote:
>> > Hi!
>> >
>> > I updated the code and now the PR is ready for review.
>> > https://github.com/apache/tomee-site-generator/pull/16
>> >
>> > @Bruno: I fixed the issue that was causing the test failure you
>> identified.
>> > @David: I implement your proposal of removing "en" to the path of the
>> > default language (English).
>> >
>> >
>> > El lun., 14 ene. 2019 a las 21:09, César Hernández Mendoza (<
>> > cesargu...@gmail.com>) escribió:
>> >
>> >> Thank you for the feedback,
>> >>
>> >>   site navigation has links to /latest/examples/ and similar -- people
>> were
>> >>> issuing PRs for broken links in headers, footers, menues, all dec and
>> >>> they're finally (hopefully) settled.
>> >> That's a good point, I was not aware of this /latest/examples/
>> reference
>> >> inside the docs and website. I only updated the doc.html page.
>> >>
>> >> We don't have direct access to the second svn, so I don't know of any
>> way
>> >>> to avoid doubling the size of that second repo.
>> >> I don't follow you entirely on this one. So far my understanding is
>> that
>> >> the process for building the site is divided into three major steps:
>> >>
>> >> 1) Download all the branches  into: tomee-site-generator/repos
>> >> 2) Copy from /repos folder all the branches
>> >> into: tomee-site-generator/target/jbake/content
>> >> 3) Bake the tomee-site-generator/target/jbake/content folder  structure
>> >> to generate the final website
>> >> in: tomee-site-generator/target/site-1.0-SNAPSHOT
>> >>
>> >> My PR only touches step 2) without duplicating the content of the
>> >> documentation in English. I added /en  to standardize in the code the
>> >> indexing process that also is performed on step 2) to generate the
>> >> index.htmll per documentation Category, and Language on each Branch:
>> >>
>> >> --tomee-site-generator/target/jbake/content/tomee-8.0
>> >> - en
>> >>   |--examples
>> >> - es
>> >>   |--examples
>> >> - index.adoc
>> >>
>> >>
>> >> Tomorrow I'm going to analyze how to remove /en from the website
>> structure.
>> >>
>> >>
>> >> El lun., 14 ene. 2019 a las 17:45, David Blevins (<
>> david.blev...@gmail.com>)
>> >> escribió:
>> >>
>> >>> Little feedback on my side of the fence.  Can we avoid adding "en" to
>> the
>> >>> path of the default language?
>> >>>
>> >>> Couple small reasons:
>> >>>
>> >>>   - site navigation has links to /latest/examples/ and similar --
>> people
>> >>> were issuing PRs for broken links in headers, footers, menues, all
>> dec and
>> >>> they're finally (hopefully) settled.
>> >>>
>> >>>   - everything is in svn, the tomee-8.0 dir alone is 133M, and the
>> site
>> >>> overall is 1.7G.  The initial push took a few hours to sync and moving
>> >>> everything into an 'en/' directory will double the size.  The process
>> >>> actually involves one svn synching to another svn.  We don't have
>> direct
>> >>> access to the second svn, so I don't know of any way to avoid
>> doubling the
>> >>> size of that second repo.
>> >>>
>> >>>
>> >>> --
>> >>> David Blevins
>> >>> http://twitter.com/dblevins
>> >>> http://www.tomitribe.com
>> >>>
>>  On Jan 14, 2019, at 12:57 PM, César Hernández Mendoza <
>> >>> cesargu...@gmail.com> wrote:
>>  Thanks Bruno.
>>  I'm working on fixing that test and will be back with an updated PR
>> when
>>  ready.
>> 
>>  El lun., 14 ene. 2019 a las 5:33, Bruno Baptista (<
>> bruno...@gmail.com>)
>>  escribió:
>> 
>> > Hi César,
>> >
>> > I've reviewed the PR and found an error:
>> >
>> >
>> > Tests in error:
>> >testProcess(org.apache.tomee.website.GroupedIndexTest):
>> > java.io.FileNotFoundException:
>> > /tmp/temp5520959884794493991dir/en/examples/index.html (No such
>> file or
>> > directory)
>> >
>> > Tests run: 9, Failures: 0, Errors: 1, Skipped: 0
>> >
>> > [INFO]
>> >
>> >>>
>> 
>> > [INFO] BUILD FAILURE
>> > [INFO]
>> >
>> >>>
>> 
>> > Left a comment in the PR.
>> >
>> > Cheers
>> >
>> > Bruno Baptista
>> > https://twitter.com/brunobat_
>>

Re: Another 8.0.0 milestone release

2019-01-23 Thread Ivan Junckes Filho
+1

On Wed, Jan 23, 2019 at 11:56 AM Frankie  wrote:

> I like the idea.
> +1
>
> Frankie
>
>
>
> --
> Sent from:
> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>


Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread Roberto Cortez
I believe this is caused when you have a @Path parent element with just a "/" 
value and then methods with @Path and and actual value.I think the fix needs to 
be done on the OpenAPI side, or just remove the "/“ from the @Path parent 
element, but that involves changing app code. 

I’ve created this PR to OpenAPI: 
https://github.com/apache/geronimo-openapi/pull/10 
. Let’s see what happens.

Thank you!

Cheers,
Roberto

> On 23 Jan 2019, at 14:27, j4fm  wrote:
> 
> FYI, as you mentioned, I also see OpenAPI annotation index out of bounds.  If
> you would like me to test out any fix for it, I can do that immediately...
> 
> /Caused by: java.lang.StringIndexOutOfBoundsException: begin 1, end 0,
> length 1
> at java.base/java.lang.String.checkBoundsBeginEnd(String.java:3319)
> at java.base/java.lang.String.substring(String.java:1874)
> at
> org.apache.geronimo.microprofile.openapi.impl.processor.AnnotationProcessor.lambda$buildPath$77(AnnotationProcessor.java:450)/
> 
> 
> 
> --
> Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html



Re: JakartaEE TCK

2019-01-23 Thread César Hernández Mendoza
> Where do we say to run the tests against a specific version of TomEE?

I'm blocked at this point too. Once the UI is open I don't know what to
open or how to properly create the javaee_web_profile filter.

El mié., 23 ene. 2019 a las 8:32, Bruno Baptista ()
escribió:

> Hi César,
>
> Thanks for this email. I was not aware of this UI.
>
> I managed to make it work but I think I'm missing something Where do
> we say to run the tests against a specific version of TomEE? This seems
> to ignore the TomEE-TCK project.
>
> Cheers
>
> Bruno Baptista
> https://twitter.com/brunobat_
>
>
> On 22/01/19 16:01, César Hernández Mendoza wrote:
> > I'm getting closer (hopefully) to visualize the test on the JT Harness
> UI.
> > Following Jean-Louis and Gurkan direction this is where I'm so far:
> >
> > cd  /Users/cesar/juniverse/ee8tck/javaeetck/bin
> > ./ant gui
> >
> > On the JT Harness UI, clicked: File->Open->TestSuite
> > and opened the folder: /Users/cesar/juniverse/ee8tck/javaeetck/src
> >
> > On the JT Harness UI, Selected: View-> Filter -> ConfigureFilters
> > I couldn't create a new filter so I ended up updating the Custom filter
> > with the following data:
> > Keywords -> Match (Expression): javaee_web_profile
> > Click Apply and then Ok.
> >
> > The Pi chard updated  slowly and the total amount of test cases is: 47219
> >
> > This number of test cases differs from the one Gurkan mentioned ("17517
> > tests for Web Profile"), so either I'm not opening the right folder or
> I'm
> > not applying correctly the filter .. or both.
> >
> >
> >
> >
> > El mar., 22 ene. 2019 a las 3:30, Bruno Baptista ()
> > escribió:
> >
> >> Hi Guys,
> >>
> >> I wonder were can I find the full list of test executions, like this one
> >> for EJB:
> >>
> >> ./runtests --web tomee-plume
> >> com.sun.ts.tests.ejb30.bb.localaccess.statelessclient
> >>
> >> That way we could prioritize and start working working on specific
> fixes.
> >>
> >> Cheers
> >>
> >> Bruno Baptista
> >> https://twitter.com/brunobat_
> >>
> >>
> >> On 21/01/19 22:20, Jean-Louis Monteiro wrote:
> >>> Ant will automatically look for a build.xml file.
> >>>
> >>> `ant gui` will therefor look for the build.xml file and then look for a
> >>> target with the name `gui` and run it.
> >>> --
> >>> Jean-Louis Monteiro
> >>> http://twitter.com/jlouismonteiro
> >>> http://www.tomitribe.com
> >>>
> >>>
> >>> On Mon, Jan 21, 2019 at 10:16 PM César Hernández Mendoza <
> >>> cesargu...@gmail.com> wrote:
> >>>
>  Thank you for the reply, I have the following question now:
> 
> - Go to bin/ folder of TCK
> 
>  Done:
>  cd  /Users/cesar/juniverse/ee8tck/javaeetck/bin
> 
>  - Run ant gui
> 
> Where and how I execute the ant gui? I see
>  https://github.com/eclipse-ee4j/jakartaee-tck/issues/26 was closed
> but
> >> I
>  couldn't find any information on the wiki.
> 
>  This is the content of my bin/ folder of TCK:
>  $ ls -A1
> ?/
> build.xml
> certificates/
> client_policy.append
> harness.policy
> java.policy
> jaxrpc-url-props.dat
> jaxws-url-props.dat
> jws-url-props.dat
> ldap.ldif
> login.config
> server_policy.append
> sig-test-pkg-list.txt
> sig-test-pkg-list_se8.txt
> sig-test-pkg-list_se9.txt
> sig-test.map
> sig-test_se8.map
> sig-test_se8.map.orig
> sig-test_se9.map
> ts.java.security
> ts.jte
> ts.jte.bak
> ts.jte.jdk9
> ts.jte.orig
> ts.jtx
> tssql.stmt
> version
> webservices-url-props.dat
> xml/
> 
>  I see there are some options [1] [2] to have an ant gui but I'm not
> >> sure if
>  you are referring something different.
> 
>  [1] http://www.placidsystems.com/virtualant/doc/guioverview.aspx
>  [2] http://antelope.tigris.org/
> 
> 
> 
>  El lun., 21 ene. 2019 a las 14:40, Gurkan Erdogdu (<
> cgerdo...@gmail.com
> >>> )
>  escribió:
> 
> > I think we need to run tests with javaee_webprofile keyword filter.
> >> There
> > is also a GUI to run/see the tests. You can run it with :
> >
> >  - Go to bin/ folder of TCK
> >  - Run ant gui
> >  - You need to create a custom filter configuration with keyword
> >  javaee_web_profile
> >
> > When I filter, there exists 17517 tests for Web Profile.
> >
> > On Mon, Jan 21, 2019 at 9:50 PM César Hernández Mendoza <
> > cesargu...@gmail.com> wrote:
> >
> >> @Gurkan
> >> Thanks for the update.
> >>
> >> @List I appreciate pointers/opinions in these two questions:
> >> After reading the readme, I wonder if there is a proper way to split
>  the
> >> entire set of tests in sub sets?
> >> My questions arise when I try to think how we can spread the work
> > mentioned
> >> in Stage 2 and S

Re: JakartaEE TCK

2019-01-23 Thread Bruno Baptista

Hi César,

Thanks for this email. I was not aware of this UI.

I managed to make it work but I think I'm missing something Where do 
we say to run the tests against a specific version of TomEE? This seems 
to ignore the TomEE-TCK project.


Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 22/01/19 16:01, César Hernández Mendoza wrote:

I'm getting closer (hopefully) to visualize the test on the JT Harness UI.
Following Jean-Louis and Gurkan direction this is where I'm so far:

cd  /Users/cesar/juniverse/ee8tck/javaeetck/bin
./ant gui

On the JT Harness UI, clicked: File->Open->TestSuite
and opened the folder: /Users/cesar/juniverse/ee8tck/javaeetck/src

On the JT Harness UI, Selected: View-> Filter -> ConfigureFilters
I couldn't create a new filter so I ended up updating the Custom filter
with the following data:
Keywords -> Match (Expression): javaee_web_profile
Click Apply and then Ok.

The Pi chard updated  slowly and the total amount of test cases is: 47219

This number of test cases differs from the one Gurkan mentioned ("17517
tests for Web Profile"), so either I'm not opening the right folder or I'm
not applying correctly the filter .. or both.




El mar., 22 ene. 2019 a las 3:30, Bruno Baptista ()
escribió:


Hi Guys,

I wonder were can I find the full list of test executions, like this one
for EJB:

./runtests --web tomee-plume
com.sun.ts.tests.ejb30.bb.localaccess.statelessclient

That way we could prioritize and start working working on specific fixes.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 21/01/19 22:20, Jean-Louis Monteiro wrote:

Ant will automatically look for a build.xml file.

`ant gui` will therefor look for the build.xml file and then look for a
target with the name `gui` and run it.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Jan 21, 2019 at 10:16 PM César Hernández Mendoza <
cesargu...@gmail.com> wrote:


Thank you for the reply, I have the following question now:

   - Go to bin/ folder of TCK

Done:
cd  /Users/cesar/juniverse/ee8tck/javaeetck/bin

- Run ant gui

   Where and how I execute the ant gui? I see
https://github.com/eclipse-ee4j/jakartaee-tck/issues/26 was closed but

I

couldn't find any information on the wiki.

This is the content of my bin/ folder of TCK:
$ ls -A1
   ?/
   build.xml
   certificates/
   client_policy.append
   harness.policy
   java.policy
   jaxrpc-url-props.dat
   jaxws-url-props.dat
   jws-url-props.dat
   ldap.ldif
   login.config
   server_policy.append
   sig-test-pkg-list.txt
   sig-test-pkg-list_se8.txt
   sig-test-pkg-list_se9.txt
   sig-test.map
   sig-test_se8.map
   sig-test_se8.map.orig
   sig-test_se9.map
   ts.java.security
   ts.jte
   ts.jte.bak
   ts.jte.jdk9
   ts.jte.orig
   ts.jtx
   tssql.stmt
   version
   webservices-url-props.dat
   xml/

I see there are some options [1] [2] to have an ant gui but I'm not

sure if

you are referring something different.

[1] http://www.placidsystems.com/virtualant/doc/guioverview.aspx
[2] http://antelope.tigris.org/



El lun., 21 ene. 2019 a las 14:40, Gurkan Erdogdu (
)

escribió:


I think we need to run tests with javaee_webprofile keyword filter.

There

is also a GUI to run/see the tests. You can run it with :

 - Go to bin/ folder of TCK
 - Run ant gui
 - You need to create a custom filter configuration with keyword
 javaee_web_profile

When I filter, there exists 17517 tests for Web Profile.

On Mon, Jan 21, 2019 at 9:50 PM César Hernández Mendoza <
cesargu...@gmail.com> wrote:


@Gurkan
Thanks for the update.

@List I appreciate pointers/opinions in these two questions:
After reading the readme, I wonder if there is a proper way to split

the

entire set of tests in sub sets?
My questions arise when I try to think how we can spread the work

mentioned

in Stage 2 and Stage 3 from the readme.
I think having a shared document with status mapped to this sub sets

can

be

useful as a reference to people trying to find areas to help. What do

you

think?


El vie., 18 ene. 2019 a las 2:41, Gurkan Erdogdu (<

cgerdo...@gmail.com

)

escribió:


Hi Cesar

My environment is macOS

Before updating, I received the following error when I run the

following

command from tomee-tck and also got some dev/tomee-tck/./target/lib

is

not

directory errors etc.

./runtests --web tomee-plume
com.sun.ts.tests.ejb30.bb.localaccess.statelessclient

[INFO]




[ERROR] Failed to execute goal
org.codehaus.gmaven:gmaven-plugin:1.5:execute (setup-environment) on
project openejb-tck: java.lang.Exception: Expected one file to be

included

into path; dir=/dev/tomee-tck/./target/lib,

includes=openejb-lite*.jar,

excludes=null -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to

execute

goal org.codehaus.gmaven:gmaven-plugin:1.5:execute

(setup-environment)

on

project openejb-tck: java.lang.Exception: Expected one fil

Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread j4fm
FYI, as you mentioned, I also see OpenAPI annotation index out of bounds.  If
you would like me to test out any fix for it, I can do that immediately...

/Caused by: java.lang.StringIndexOutOfBoundsException: begin 1, end 0,
length 1
at java.base/java.lang.String.checkBoundsBeginEnd(String.java:3319)
at java.base/java.lang.String.substring(String.java:1874)
at
org.apache.geronimo.microprofile.openapi.impl.processor.AnnotationProcessor.lambda$buildPath$77(AnnotationProcessor.java:450)/



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html


Re: Another 8.0.0 milestone release

2019-01-23 Thread Frankie
I like the idea.
+1

Frankie



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html


Re: Another 8.0.0 milestone release

2019-01-23 Thread Bruno Baptista

+1

Bruno Baptista
https://twitter.com/brunobat_


On 23/01/19 01:59, David Blevins wrote:

There are plans to launch start.microprofile.io on January 29th.  We have a lot 
more MicroProfile support in master than we do in 8.0.0-M1.

What do we think about shooting out an 8.0.0-M2 asap and ensuring it's in the 
server list for start.microprofile.io?




Re: OpenTracing - nullpointer OpenTracingFilter

2019-01-23 Thread Ivan Junckes Filho
Good news, this is not happening in the master. I will close the ticket and
wait for the release.

On Wed, Jan 23, 2019 at 11:16 AM Ivan Junckes Filho 
wrote:

> This is the ticket:
> https://issues.apache.org/jira/browse/TOMEE-2457
>
> This looks like a release blocker in my opinion. I will check the master
> and see how it behaves.
>
> On Tue, Jan 22, 2019 at 3:53 PM Roberto Cortez 
> wrote:
>
>> Hi Ivan,
>>
>> Can you please provide a test case that reproduces the issue? Thank you!
>>
>> Cheers,
>> Roberto
>>
>> > On 22 Jan 2019, at 16:07, Romain Manni-Bucau 
>> wrote:
>> >
>> > Long story short, the MP impl assume CDI is active, if not then tomee
>> but
>> > disable the MP impl.
>> > For us it means disabling also the servlet container initializers. It
>> can
>> > be done in OpenEJBContextConfig or - likely good - implementing a
>> > contextual ConfigSource (reading AppContext#properties for instance) and
>> > forcing geronimo.opentracing.filter.active to false for the webapp (not
>> > globally). Setting the system property you should get the same behavior
>> but
>> > it will be global so some app will not get tracing.
>> > In other word it is the core work tomee must do: integration :).
>> >
>> > Romain Manni-Bucau
>> > @rmannibucau  |  Blog
>> >  | Old Blog
>> >  | Github <
>> https://github.com/rmannibucau> |
>> > LinkedIn  | Book
>> > <
>> https://www.packtpub.com/application-development/java-ee-8-high-performance
>> >
>> >
>> >
>> > Le mar. 22 janv. 2019 à 17:03, Ivan Junckes Filho <
>> ivanjunc...@gmail.com> a
>> > écrit :
>> >
>> >> When you say it is a bug in CDI support of TomEE, could you please be
>> more
>> >> specific? Of course if you are aware of what it could be·
>> >>
>> >> On Tue, Jan 22, 2019 at 12:50 PM Romain Manni-Bucau <
>> rmannibu...@gmail.com>
>> >> wrote:
>> >>
>> >>> Hmm, we can add a check in the filter and fail the deployment but at
>> the
>> >>> end it is a bug in CDI support of TomEE so likely saner to fix it in
>> TomEE,
>> >>> right?
>> >>>
>> >>> Romain Manni-Bucau
>> >>> @rmannibucau  |  Blog
>> >>>  | Old Blog
>> >>>  | Github
>> >>>  | LinkedIn
>> >>>  | Book
>> >>> <
>> https://www.packtpub.com/application-development/java-ee-8-high-performance
>> >
>> >>>
>> >>>
>> >>> Le mar. 22 janv. 2019 à 15:37, Ivan Junckes Filho <
>> ivanjunc...@gmail.com>
>> >>> a écrit :
>> >>>
>>  I would say if the extension was not executed for some reason that we
>>  need to know why, we need to make sure the filter doesn't throw that
>>  exception or completely ignore the filter logic right?
>> 
>>  On Tue, Jan 22, 2019 at 12:08 PM Romain Manni-Bucau <
>>  rmannibu...@gmail.com> wrote:
>> 
>> > Hi Ivan,
>> >
>> > This means the opentracing extension was not executed for the app:
>> >
>> https://github.com/apache/geronimo-opentracing/blob/master/geronimo-opentracing/src/main/java/org/apache/geronimo/microprofile/opentracing/microprofile/cdi/OpenTracingExtension.java#L125
>> >
>> > Romain Manni-Bucau
>> > @rmannibucau  |  Blog
>> >  | Old Blog
>> >  | Github
>> >  | LinkedIn
>> >  | Book
>> > <
>> https://www.packtpub.com/application-development/java-ee-8-high-performance
>> >
>> >
>> >
>> > Le mar. 22 janv. 2019 à 14:39, Ivan Junckes Filho <
>> > ivanjunc...@gmail.com> a écrit :
>> >
>> >> Hey guys, I would like some help with an opentracing issue. I am
>> not
>> >> sure if it was already fixed or not. It was happening on version
>> 1.0.0,
>> >> current M1 release of TomEE 8.
>> >>
>> >> There is a nullpointer happening in OpenTracingFilter and it seems
>> to
>> >> be because this injection is null.
>> >>
>> >> @Inject
>> >> private GeronimoOpenTracingConfig config;
>> >>
>> >> So this line throws the null pointer:
>> >>
>> >> skipDefaultTags =
>> Boolean.parseBoolean(config.read("filter.forcedTracing.skipDefaultTags",
>> "false"));
>> >>
>> >> Anyone can help with this?
>> >>
>> >> Logs are attached.
>> >>
>> >>
>> >>
>>
>>


Re: OpenTracing - nullpointer OpenTracingFilter

2019-01-23 Thread Ivan Junckes Filho
This is the ticket:
https://issues.apache.org/jira/browse/TOMEE-2457

This looks like a release blocker in my opinion. I will check the master
and see how it behaves.

On Tue, Jan 22, 2019 at 3:53 PM Roberto Cortez  wrote:

> Hi Ivan,
>
> Can you please provide a test case that reproduces the issue? Thank you!
>
> Cheers,
> Roberto
>
> > On 22 Jan 2019, at 16:07, Romain Manni-Bucau 
> wrote:
> >
> > Long story short, the MP impl assume CDI is active, if not then tomee but
> > disable the MP impl.
> > For us it means disabling also the servlet container initializers. It can
> > be done in OpenEJBContextConfig or - likely good - implementing a
> > contextual ConfigSource (reading AppContext#properties for instance) and
> > forcing geronimo.opentracing.filter.active to false for the webapp (not
> > globally). Setting the system property you should get the same behavior
> but
> > it will be global so some app will not get tracing.
> > In other word it is the core work tomee must do: integration :).
> >
> > Romain Manni-Bucau
> > @rmannibucau  |  Blog
> >  | Old Blog
> >  | Github <
> https://github.com/rmannibucau> |
> > LinkedIn  | Book
> > <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
> >
> >
> > Le mar. 22 janv. 2019 à 17:03, Ivan Junckes Filho 
> a
> > écrit :
> >
> >> When you say it is a bug in CDI support of TomEE, could you please be
> more
> >> specific? Of course if you are aware of what it could be·
> >>
> >> On Tue, Jan 22, 2019 at 12:50 PM Romain Manni-Bucau <
> rmannibu...@gmail.com>
> >> wrote:
> >>
> >>> Hmm, we can add a check in the filter and fail the deployment but at
> the
> >>> end it is a bug in CDI support of TomEE so likely saner to fix it in
> TomEE,
> >>> right?
> >>>
> >>> Romain Manni-Bucau
> >>> @rmannibucau  |  Blog
> >>>  | Old Blog
> >>>  | Github
> >>>  | LinkedIn
> >>>  | Book
> >>> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
> >>>
> >>>
> >>> Le mar. 22 janv. 2019 à 15:37, Ivan Junckes Filho <
> ivanjunc...@gmail.com>
> >>> a écrit :
> >>>
>  I would say if the extension was not executed for some reason that we
>  need to know why, we need to make sure the filter doesn't throw that
>  exception or completely ignore the filter logic right?
> 
>  On Tue, Jan 22, 2019 at 12:08 PM Romain Manni-Bucau <
>  rmannibu...@gmail.com> wrote:
> 
> > Hi Ivan,
> >
> > This means the opentracing extension was not executed for the app:
> >
> https://github.com/apache/geronimo-opentracing/blob/master/geronimo-opentracing/src/main/java/org/apache/geronimo/microprofile/opentracing/microprofile/cdi/OpenTracingExtension.java#L125
> >
> > Romain Manni-Bucau
> > @rmannibucau  |  Blog
> >  | Old Blog
> >  | Github
> >  | LinkedIn
> >  | Book
> > <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
> >
> >
> > Le mar. 22 janv. 2019 à 14:39, Ivan Junckes Filho <
> > ivanjunc...@gmail.com> a écrit :
> >
> >> Hey guys, I would like some help with an opentracing issue. I am not
> >> sure if it was already fixed or not. It was happening on version
> 1.0.0,
> >> current M1 release of TomEE 8.
> >>
> >> There is a nullpointer happening in OpenTracingFilter and it seems
> to
> >> be because this injection is null.
> >>
> >> @Inject
> >> private GeronimoOpenTracingConfig config;
> >>
> >> So this line throws the null pointer:
> >>
> >> skipDefaultTags =
> Boolean.parseBoolean(config.read("filter.forcedTracing.skipDefaultTags",
> "false"));
> >>
> >> Anyone can help with this?
> >>
> >> Logs are attached.
> >>
> >>
> >>
>
>


Re: Another 8.0.0 milestone release

2019-01-23 Thread Otávio Gonçalves de Santana
+1

On Wed, Jan 23, 2019 at 8:48 AM Roberto Cortez 
wrote:

> There are a few MP issues that we need to sort out regarding plume and
> plus (if we want to push MP into plus and plume). I’ll explain those in the
> other thread. We need to fix them or drop plus and plume support for this
> release.
>
> > On 23 Jan 2019, at 10:14, Daniel Cunha  wrote:
> >
> > Sounds good to me as well.
> > +1
> >
> > Em qua, 23 de jan de 2019 às 05:46, Gurkan Erdogdu 
> > escreveu:
> >
> >> +1
> >> Gurkan
> >>
> >> On Wed, Jan 23, 2019 at 10:17 AM Jean-Louis Monteiro <
> >> jlmonte...@tomitribe.com> wrote:
> >>
> >>> Sounds good to me.
> >>>
> >>> Le mer. 23 janv. 2019 à 04:23, César Hernández Mendoza <
> >>> cesargu...@gmail.com>
> >>> a écrit :
> >>>
>  I have never done a TomEE release but I'm willing to learn during
> >>> 8.0.0-M2
>  release :)
> 
>  El mar., 22 ene. 2019 a las 19:59, David Blevins (<
> >>> david.blev...@gmail.com
> > )
>  escribió:
> 
> > There are plans to launch start.microprofile.io on January 29th.  We
>  have
> > a lot more MicroProfile support in master than we do in 8.0.0-M1.
> >
> > What do we think about shooting out an 8.0.0-M2 asap and ensuring
> >> it's
> >>> in
> > the server list for start.microprofile.io?
> >
> >
> > --
> > David Blevins
> > http://twitter.com/dblevins
> > http://www.tomitribe.com
> >
> >
> 
>  --
>  Atentamente:
>  César Hernández Mendoza.
> 
> >>>
> >>
> >
> >
> > --
> > Daniel "soro" Cunha
> > https://twitter.com/dvlc_
>
>


Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread Bruno Baptista

Hi Roberto,

I'll take a look at the PR.

Cheers.

Bruno Baptista
https://twitter.com/brunobat_


On 23/01/19 11:30, Roberto Cortez wrote:

Hi folks,

Let me try to give a full overview on what I have been working on in the last 
couple of days. Progress has been a bit slow unfortunately, due to the amount 
of combinations and tests that I have to run every time I do a change. On the 
other hand, I know understand way better how TomEE does the deployment :) 
Anyway, I’m starting to question myself if I’m going in the right direction.

MP EAR Support:
MP CDI Extensions, or any CDI Extension is always loaded if found in the classpath 
via the ServiceLoader. For WAR this works fine. On EAR, CDI Deployment is deferred 
because it may be contained in the Webapp and not on the EJB jars, and EJB jars are 
deployed first (TOMEE-189 and TOMEE-722). Until now, we didn’t rely on CDI to load 
any of the server features, so this was fine. With MP, we added the ability to 
include / exclude additional urls to be included in the CDI scanner 
(https://github.com/apache/tomee/commit/021b9ca8d01a78f5b7ee3438f30fd8901ff60d5b 
).

The issue here is that we now need to load only the build in CDI features, 
while deferring the internal / possible CDI beans contained in the EAR file. 
This might be a possible solution:
https://github.com/apache/tomee/commit/c6397e26e191f717b96934f2e279acfe320451b9 
.

Servlet / MP Rest endpoint clashing:
If an existent app is only using servlets and has a servlet mapping to the root 
context or /*, MP endpoints will override the context root with a REST path and the 
servlet will 404. This has nothing to do with MP itself, if you write an app with a 
servlet mapping to /* and add a REST endpoint to /, the REST endpoint takes 
precedence and you are unable to reach the servlet. My concern here is that someone 
out there might run into this and we break their app with the new version of TomEE. 
This should probably do the trick: 
https://github.com/apache/tomee/commit/4ade980c56276a2ad4f2df921e12314e38e881cf 


Tomcat TomEE Webapp (with Plus and Plume)
Deployment of the TomEE Webapp in Tomcat with MP was also not working. This was 
because CDI scanning for the TomEE web app was disabled by default (since we didn’t 
rely on any CDI services before). Also, the web.xml was marked as metadata complete, 
which also skips any annotation deployment processing. I’m a little concern with the 
change here due to the previous comment that it might affect TomEE embedded, but so 
far it seemed fine: 
https://github.com/apache/tomee/commit/e55760d0e230612de7f99b7c4940b1305456dbaf 


ApplicationComposer on Arquillian Remote
Right now, I was not able to have this working. This is because 
ApplicationComposer, when using CDI, you manually state in the annotation which 
CDI beans are required. In this case, any additional Bean scanning is skipped. 
Again, we probably need to adjust it to also include the container provided CDI 
beans.

RestEndpoint / OpenAPI
I’ve run into a StringIndexOutOfBoundsException when OpenAPI is processing REST 
annotations. I’m now looking into that. Not sure if it might be a bug in 
OpenAPI implementation or something else.

Well, this is it for now. Sorry for the long email. All the work has been done 
in this PR:
https://github.com/apache/tomee/pull/304/ 


It would definitely need a few set of eyes to review it.

Thank you!

Cheers,
Roberto


On 23 Jan 2019, at 11:28, Roberto Cortez  wrote:

We introduced a couple of new properties to allows additional jars to be added 
in the DeploymentLoader, so they can be scanned.

This was done here:
https://github.com/apache/tomee/commit/021b9ca8d01a78f5b7ee3438f30fd8901ff60d5b 


What you probably need to do is have your custom classloader to also load the 
mp specific libraries, so they can be also scanned.

Yes, I’ve run into multiple other issues. I’m going to send an email about it, 
next. I think we can make it, we just need to validate if these changes make 
sense and if they are right.

Thank you,
Roberto


On 23 Jan 2019, at 10:55, j4fm  wrote:

Okay, so digging into this loader, there is this line:

SystemInstance.get().setComponent(ParentClassLoaderFinder.class, fallback ->
MyClassLoader._getOrCreateInstance(parent));

Commenting it out seems to make it play nicely with MP but brakes the class
loading of the webapps when openejb's scanning annotations.

So am currently looking at other solutions to make both work.  I think this
is something that can be solved but am suspecting there is a chance

Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread Roberto Cortez
Hi folks,

Let me try to give a full overview on what I have been working on in the last 
couple of days. Progress has been a bit slow unfortunately, due to the amount 
of combinations and tests that I have to run every time I do a change. On the 
other hand, I know understand way better how TomEE does the deployment :) 
Anyway, I’m starting to question myself if I’m going in the right direction.

MP EAR Support:
MP CDI Extensions, or any CDI Extension is always loaded if found in the 
classpath via the ServiceLoader. For WAR this works fine. On EAR, CDI 
Deployment is deferred because it may be contained in the Webapp and not on the 
EJB jars, and EJB jars are deployed first (TOMEE-189 and TOMEE-722). Until now, 
we didn’t rely on CDI to load any of the server features, so this was fine. 
With MP, we added the ability to include / exclude additional urls to be 
included in the CDI scanner 
(https://github.com/apache/tomee/commit/021b9ca8d01a78f5b7ee3438f30fd8901ff60d5b
 
).

The issue here is that we now need to load only the build in CDI features, 
while deferring the internal / possible CDI beans contained in the EAR file. 
This might be a possible solution:
https://github.com/apache/tomee/commit/c6397e26e191f717b96934f2e279acfe320451b9 
.

Servlet / MP Rest endpoint clashing:
If an existent app is only using servlets and has a servlet mapping to the root 
context or /*, MP endpoints will override the context root with a REST path and 
the servlet will 404. This has nothing to do with MP itself, if you write an 
app with a servlet mapping to /* and add a REST endpoint to /, the REST 
endpoint takes precedence and you are unable to reach the servlet. My concern 
here is that someone out there might run into this and we break their app with 
the new version of TomEE. This should probably do the trick: 
https://github.com/apache/tomee/commit/4ade980c56276a2ad4f2df921e12314e38e881cf 


Tomcat TomEE Webapp (with Plus and Plume)
Deployment of the TomEE Webapp in Tomcat with MP was also not working. This was 
because CDI scanning for the TomEE web app was disabled by default (since we 
didn’t rely on any CDI services before). Also, the web.xml was marked as 
metadata complete, which also skips any annotation deployment processing. I’m a 
little concern with the change here due to the previous comment that it might 
affect TomEE embedded, but so far it seemed fine: 
https://github.com/apache/tomee/commit/e55760d0e230612de7f99b7c4940b1305456dbaf 


ApplicationComposer on Arquillian Remote
Right now, I was not able to have this working. This is because 
ApplicationComposer, when using CDI, you manually state in the annotation which 
CDI beans are required. In this case, any additional Bean scanning is skipped. 
Again, we probably need to adjust it to also include the container provided CDI 
beans.

RestEndpoint / OpenAPI
I’ve run into a StringIndexOutOfBoundsException when OpenAPI is processing REST 
annotations. I’m now looking into that. Not sure if it might be a bug in 
OpenAPI implementation or something else.

Well, this is it for now. Sorry for the long email. All the work has been done 
in this PR:
https://github.com/apache/tomee/pull/304/ 


It would definitely need a few set of eyes to review it. 

Thank you!

Cheers,
Roberto

> On 23 Jan 2019, at 11:28, Roberto Cortez  wrote:
> 
> We introduced a couple of new properties to allows additional jars to be 
> added in the DeploymentLoader, so they can be scanned.
> 
> This was done here:
> https://github.com/apache/tomee/commit/021b9ca8d01a78f5b7ee3438f30fd8901ff60d5b
>  
> 
> 
> What you probably need to do is have your custom classloader to also load the 
> mp specific libraries, so they can be also scanned.
> 
> Yes, I’ve run into multiple other issues. I’m going to send an email about 
> it, next. I think we can make it, we just need to validate if these changes 
> make sense and if they are right.
> 
> Thank you,
> Roberto
> 
>> On 23 Jan 2019, at 10:55, j4fm  wrote:
>> 
>> Okay, so digging into this loader, there is this line:
>> 
>> SystemInstance.get().setComponent(ParentClassLoaderFinder.class, fallback ->
>> MyClassLoader._getOrCreateInstance(parent));
>> 
>> Commenting it out seems to make it play nicely with MP but brakes the class
>> loading of the webapps when openejb's scanning annotations.
>> 
>> So am currently looking at other solutions to make both work.  I think this
>> is something that can be solved but am suspecting there is a chance there is
>> a bug with openejb not using the correct class loa

Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread Roberto Cortez
We introduced a couple of new properties to allows additional jars to be added 
in the DeploymentLoader, so they can be scanned.

This was done here:
https://github.com/apache/tomee/commit/021b9ca8d01a78f5b7ee3438f30fd8901ff60d5b 


What you probably need to do is have your custom classloader to also load the 
mp specific libraries, so they can be also scanned.

Yes, I’ve run into multiple other issues. I’m going to send an email about it, 
next. I think we can make it, we just need to validate if these changes make 
sense and if they are right.

Thank you,
Roberto

> On 23 Jan 2019, at 10:55, j4fm  wrote:
> 
> Okay, so digging into this loader, there is this line:
> 
> SystemInstance.get().setComponent(ParentClassLoaderFinder.class, fallback ->
> MyClassLoader._getOrCreateInstance(parent));
> 
> Commenting it out seems to make it play nicely with MP but brakes the class
> loading of the webapps when openejb's scanning annotations.
> 
> So am currently looking at other solutions to make both work.  I think this
> is something that can be solved but am suspecting there is a chance there is
> a bug with openejb not using the correct class loaders for the webapps. 
> Trying some things.
> 
> Are you still finding issues with MP in Plus with the test cases failing? 
> Is there anything else blocking having MP in Plus for M2 release?  I don't
> want to become a blocker for that, will know today if this class loading
> issue can be solved or a bug.  It would be really great if M2 could have MP
> in Plus but understand how tight it is.
> 
> 
> 
> --
> Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html



Re: MicroProfile Integration in Plus and Plume

2019-01-23 Thread j4fm
Okay, so digging into this loader, there is this line:

SystemInstance.get().setComponent(ParentClassLoaderFinder.class, fallback ->
MyClassLoader._getOrCreateInstance(parent));

Commenting it out seems to make it play nicely with MP but brakes the class
loading of the webapps when openejb's scanning annotations.

So am currently looking at other solutions to make both work.  I think this
is something that can be solved but am suspecting there is a chance there is
a bug with openejb not using the correct class loaders for the webapps. 
Trying some things.

Are you still finding issues with MP in Plus with the test cases failing? 
Is there anything else blocking having MP in Plus for M2 release?  I don't
want to become a blocker for that, will know today if this class loading
issue can be solved or a bug.  It would be really great if M2 could have MP
in Plus but understand how tight it is.



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html


Re: Another 8.0.0 milestone release

2019-01-23 Thread Roberto Cortez
There are a few MP issues that we need to sort out regarding plume and plus (if 
we want to push MP into plus and plume). I’ll explain those in the other 
thread. We need to fix them or drop plus and plume support for this release.

> On 23 Jan 2019, at 10:14, Daniel Cunha  wrote:
> 
> Sounds good to me as well.
> +1
> 
> Em qua, 23 de jan de 2019 às 05:46, Gurkan Erdogdu 
> escreveu:
> 
>> +1
>> Gurkan
>> 
>> On Wed, Jan 23, 2019 at 10:17 AM Jean-Louis Monteiro <
>> jlmonte...@tomitribe.com> wrote:
>> 
>>> Sounds good to me.
>>> 
>>> Le mer. 23 janv. 2019 à 04:23, César Hernández Mendoza <
>>> cesargu...@gmail.com>
>>> a écrit :
>>> 
 I have never done a TomEE release but I'm willing to learn during
>>> 8.0.0-M2
 release :)
 
 El mar., 22 ene. 2019 a las 19:59, David Blevins (<
>>> david.blev...@gmail.com
> )
 escribió:
 
> There are plans to launch start.microprofile.io on January 29th.  We
 have
> a lot more MicroProfile support in master than we do in 8.0.0-M1.
> 
> What do we think about shooting out an 8.0.0-M2 asap and ensuring
>> it's
>>> in
> the server list for start.microprofile.io?
> 
> 
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
> 
> 
 
 --
 Atentamente:
 César Hernández Mendoza.
 
>>> 
>> 
> 
> 
> -- 
> Daniel "soro" Cunha
> https://twitter.com/dvlc_



Re: Another 8.0.0 milestone release

2019-01-23 Thread Daniel Cunha
Sounds good to me as well.
+1

Em qua, 23 de jan de 2019 às 05:46, Gurkan Erdogdu 
escreveu:

> +1
> Gurkan
>
> On Wed, Jan 23, 2019 at 10:17 AM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
> > Sounds good to me.
> >
> > Le mer. 23 janv. 2019 à 04:23, César Hernández Mendoza <
> > cesargu...@gmail.com>
> > a écrit :
> >
> > > I have never done a TomEE release but I'm willing to learn during
> > 8.0.0-M2
> > > release :)
> > >
> > > El mar., 22 ene. 2019 a las 19:59, David Blevins (<
> > david.blev...@gmail.com
> > > >)
> > > escribió:
> > >
> > > > There are plans to launch start.microprofile.io on January 29th.  We
> > > have
> > > > a lot more MicroProfile support in master than we do in 8.0.0-M1.
> > > >
> > > > What do we think about shooting out an 8.0.0-M2 asap and ensuring
> it's
> > in
> > > > the server list for start.microprofile.io?
> > > >
> > > >
> > > > --
> > > > David Blevins
> > > > http://twitter.com/dblevins
> > > > http://www.tomitribe.com
> > > >
> > > >
> > >
> > > --
> > > Atentamente:
> > > César Hernández Mendoza.
> > >
> >
>


-- 
Daniel "soro" Cunha
https://twitter.com/dvlc_


Re: Looking for review on PR

2019-01-23 Thread Bruno Baptista

Hi Doychin,

The test passes but I don't know if the changes are subverting the 
original purpose of the test.


Let's wait for some more feedback on that.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 23/01/19 09:34, Doychin Bondzhev wrote:

I've added new commit to PR
https://github.com/apache/tomee/pull/360


On 21.1.2019 г. 18:14, brunobat [via TomEE & OpenEJB] wrote:

Sure Doychin,

Looking forward for that update.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 21/01/19 15:10, Doychin Bondzhev wrote:

> Hi Bruno,
>
> I think I found why AutoConnectionTrackerTest fails.
>
> In some cases GC is not fast enough to place leaked references into
> ReferenceQueue. When setEnvironment is called right after GC there is
> a small chance that some references did not manage to get to
> referenceQueue on time for the check that queue is empty. In order to
> test that theory I added small delay and second poll to the queue and
> suddenly I got reference.
>
> I will update my PR about AutoConnectionTracker and
> AutoConnectionTrackerTest with new changes.
>
> If you don't like the way I did the delay I'm open to suggestions.
>
> Have a nice day.
>
> On 20.1.2019 г. 14:13, brunobat [via TomEE & OpenEJB] wrote:
>> Hi Doychin,
>>
>> I've run all the tests on the merge of the 5 PRs.
>>
>> I encountered 2 errors. They might be transient ones. Can you please
>> take a look?
>>
>>
>> arquillian-tomee-jms-tests
>> [ERROR]   EnvEntryTest.test:105 » EJB The bean encountered a
>> non-application exception; ...
>>
>> openejb-core
>> [ERROR] AutoConnectionTrackerTest.test:203->assertLogs:209 Detected
>> abandoned connection expected:<1> but was:<0>
>>
>>
>> Cheers
>>
>> Bruno Baptista
>> https://twitter.com/brunobat_
>>
>>
>> On 18/01/19 18:32, Bruno Baptista wrote:
>>
>> >
>> > Hi Doychin,
>> >
>> > Thanks for the contribution!
>> >
>> > I've approved a couple and left comments in 2 others.
>> >
>> > Will run all the tests when I get home.
>> >
>> > Cheers
>> >
>> > Bruno Baptista
>> > https://twitter.com/brunobat_
>> >
>> >
>> > On 18/01/19 17:46, Bruno Baptista wrote:
>> >>
>> >> Hi Doychin,
>> >>
>> >> I'll have a look.
>> >>
>> >> Cheers
>> >>
>> >> Bruno Baptista
>> >> https://twitter.com/brunobat_
>> >>
>> >>
>> >> On 18/01/19 17:41, Doychin Bondzhev wrote:
>> >>>
>> >>> Hi guys,
>> >>>
>> >>> Can some one take a look at following PR's?
>> >>>
>> >>> Startup and shutdown fixes - TOMEE-2454
>> >>> 
>> >>> increase the time to wait for sweeps.
>> >>> 
>> >>> Make observers more CDI like. This will make the commented 
test to

>> >>> work. 
>> >>> Issue is closed and TomEE uses more recent version
>> >>> 
>> >>> Cleanup test code and also minor changes in the tested class.
>> >>> 
>> >>>
>> >>> thanks
>> >>> --
>> >>> Doychin Bondzhev
>> >>> dSoft-Bulgaria Ltd.
>> >>> PowerPro - billing & provisioning solution for Service providers
>> >>> http://www.dsoft-bg.com/
>> >>> Mobile: +359888243116
>>
>>
>> 


>> If you reply to this email, your message will be added to the
>> discussion below:
>> 
http://tomee-openejb.979440.n4.nabble.com/Looking-for-review-on-PR-tp4687577p4687596.html 


>>
>> To start a new topic under TomEE Dev, email
>> [hidden email] 
>> To unsubscribe from TomEE Dev, click here
>> <
>> NAML
>> 
 


>>
>
>
> --
> Doychin Bondzhev
> dSoft-Bulgaria Ltd.
> PowerPro - billing & provisioning solution for Service providers
> http://www.dsoft-bg.com/
> Mobile: +359888243116



If you reply to this email, your message will be added to the 
discussion below:
http://tomee-openejb.979440.n4.nabble.com/Looking-for-review-on-PR-tp4687577p4687604.html 

To start a new topic under TomEE Dev, email 
ml+s979440n982480...@n4.nabble.com
To unsubscribe from TomEE Dev, click here 
.
NAML 


PR review and merge

2019-01-23 Thread Bruno Baptista

Hi,

Can one of the committers please take a look at these PRs?

https://github.com/apache/tomee/pull/377
https://github.com/apache/tomee/pull/376
https://github.com/apache/tomee/pull/375
https://github.com/apache/tomee/pull/370
https://github.com/apache/tomee/pull/366
https://github.com/apache/tomee/pull/363
https://github.com/apache/tomee/pull/362
https://github.com/apache/tomee/pull/361

Cheers

--
Bruno Baptista
https://twitter.com/brunobat_




Re: Looking for review on PR

2019-01-23 Thread Doychin Bondzhev

I've added new commit to PR
https://github.com/apache/tomee/pull/360


On 21.1.2019 г. 18:14, brunobat [via TomEE & OpenEJB] wrote:

Sure Doychin,

Looking forward for that update.

Cheers

Bruno Baptista
https://twitter.com/brunobat_


On 21/01/19 15:10, Doychin Bondzhev wrote:

> Hi Bruno,
>
> I think I found why AutoConnectionTrackerTest fails.
>
> In some cases GC is not fast enough to place leaked references into
> ReferenceQueue. When setEnvironment is called right after GC there is
> a small chance that some references did not manage to get to
> referenceQueue on time for the check that queue is empty. In order to
> test that theory I added small delay and second poll to the queue and
> suddenly I got reference.
>
> I will update my PR about AutoConnectionTracker and
> AutoConnectionTrackerTest with new changes.
>
> If you don't like the way I did the delay I'm open to suggestions.
>
> Have a nice day.
>
> On 20.1.2019 г. 14:13, brunobat [via TomEE & OpenEJB] wrote:
>> Hi Doychin,
>>
>> I've run all the tests on the merge of the 5 PRs.
>>
>> I encountered 2 errors. They might be transient ones. Can you please
>> take a look?
>>
>>
>> arquillian-tomee-jms-tests
>> [ERROR]   EnvEntryTest.test:105 » EJB The bean encountered a
>> non-application exception; ...
>>
>> openejb-core
>> [ERROR] AutoConnectionTrackerTest.test:203->assertLogs:209 Detected
>> abandoned connection expected:<1> but was:<0>
>>
>>
>> Cheers
>>
>> Bruno Baptista
>> https://twitter.com/brunobat_
>>
>>
>> On 18/01/19 18:32, Bruno Baptista wrote:
>>
>> >
>> > Hi Doychin,
>> >
>> > Thanks for the contribution!
>> >
>> > I've approved a couple and left comments in 2 others.
>> >
>> > Will run all the tests when I get home.
>> >
>> > Cheers
>> >
>> > Bruno Baptista
>> > https://twitter.com/brunobat_
>> >
>> >
>> > On 18/01/19 17:46, Bruno Baptista wrote:
>> >>
>> >> Hi Doychin,
>> >>
>> >> I'll have a look.
>> >>
>> >> Cheers
>> >>
>> >> Bruno Baptista
>> >> https://twitter.com/brunobat_
>> >>
>> >>
>> >> On 18/01/19 17:41, Doychin Bondzhev wrote:
>> >>>
>> >>> Hi guys,
>> >>>
>> >>> Can some one take a look at following PR's?
>> >>>
>> >>> Startup and shutdown fixes - TOMEE-2454
>> >>> 
>> >>> increase the time to wait for sweeps.
>> >>> 
>> >>> Make observers more CDI like. This will make the commented test to
>> >>> work. 
>> >>> Issue is closed and TomEE uses more recent version
>> >>> 
>> >>> Cleanup test code and also minor changes in the tested class.
>> >>> 
>> >>>
>> >>> thanks
>> >>> --
>> >>> Doychin Bondzhev
>> >>> dSoft-Bulgaria Ltd.
>> >>> PowerPro - billing & provisioning solution for Service providers
>> >>> http://www.dsoft-bg.com/
>> >>> Mobile: +359888243116
>>
>>
>> 


>> If you reply to this email, your message will be added to the
>> discussion below:
>> 
http://tomee-openejb.979440.n4.nabble.com/Looking-for-review-on-PR-tp4687577p4687596.html 


>>
>> To start a new topic under TomEE Dev, email
>> [hidden email] 
>> To unsubscribe from TomEE Dev, click here
>> <
>> NAML
>> 
 




>>
>
>
> --
> Doychin Bondzhev
> dSoft-Bulgaria Ltd.
> PowerPro - billing & provisioning solution for Service providers
> http://www.dsoft-bg.com/
> Mobile: +359888243116



If you reply to this email, your message will be added to the 
discussion below:
http://tomee-openejb.979440.n4.nabble.com/Looking-for-review-on-PR-tp4687577p4687604.html 

To start a new topic under TomEE Dev, email 
ml+s979440n982480...@n4.nabble.com
To unsubscribe from TomEE Dev, click here 
.
NAML 
 




--
Doychin Bondzhev
dSoft-Bulgaria Ltd.
PowerPro - billing & provisioning solution for Service providers
http://www.dsoft-bg.com/
Mobile: +359888243116

<>

smime.p7s
Description: S/MIME Cryptographic Signature


Re: Another 8.0.0 milestone release

2019-01-23 Thread Gurkan Erdogdu
+1
Gurkan

On Wed, Jan 23, 2019 at 10:17 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:

> Sounds good to me.
>
> Le mer. 23 janv. 2019 à 04:23, César Hernández Mendoza <
> cesargu...@gmail.com>
> a écrit :
>
> > I have never done a TomEE release but I'm willing to learn during
> 8.0.0-M2
> > release :)
> >
> > El mar., 22 ene. 2019 a las 19:59, David Blevins (<
> david.blev...@gmail.com
> > >)
> > escribió:
> >
> > > There are plans to launch start.microprofile.io on January 29th.  We
> > have
> > > a lot more MicroProfile support in master than we do in 8.0.0-M1.
> > >
> > > What do we think about shooting out an 8.0.0-M2 asap and ensuring it's
> in
> > > the server list for start.microprofile.io?
> > >
> > >
> > > --
> > > David Blevins
> > > http://twitter.com/dblevins
> > > http://www.tomitribe.com
> > >
> > >
> >
> > --
> > Atentamente:
> > César Hernández Mendoza.
> >
>