Re: PR#521 - Translation of the examples/simple-cdi-interceptor to Portuguese.
Hello , Marco Ferreira and I reviewed and approved you PR. I believe one of the committers can move this forwards. Thank you . -- Daniel Dias dos Santos Java Developer SouJava & JCP Member GitHub: https://github.com/Daniel-Dos Linkedin: www.linkedin.com/in/danieldiasjava Twitter: http://twitter.com/danieldiasjava Em qui, 18 de jul de 2019 às 23:44, Gabriel Ferreira escreveu: > > Hey guys, I opened this pull request: > https://github.com/apache/tomee/pull/521 > about this task https://issues.apache.org/jira/browse/TOMEE-2580 > Thank you ;)
[GitHub] [tomee] robinsonvs commented on a change in pull request #525: TOMEE-2583 - add translate in PT to examples/datasource-versioning
robinsonvs commented on a change in pull request #525: TOMEE-2583 - add translate in PT to examples/datasource-versioning URL: https://github.com/apache/tomee/pull/525#discussion_r307862695 ## File path: examples/datasource-versioning/README_pt.adoc ## @@ -0,0 +1,403 @@ +:index-group: Unrevised +:jbake-type: page +:jbake-status: status=published += Versionamento de DataSource + +Este exemplo mostra como usar DataSources com versão do mesmo provedor usando o atributo classpath. + +== Configuração + +A configuração do DataSource pode ser feita de várias maneiras e aqui nós mostramos +dois métodos comuns na forma de testes unitários. Antes de começarmos, se você +der uma olhada no pom.xml e procurar por maven-dependencia-plugin em uso, você verá que nós puxamos em dois Review comment: I comment on commit, sorry, I'm nervous, it's my first open source pull request This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] robinsonvs commented on a change in pull request #525: TOMEE-2583 - add translate in PT to examples/datasource-versioning
robinsonvs commented on a change in pull request #525: TOMEE-2583 - add translate in PT to examples/datasource-versioning URL: https://github.com/apache/tomee/pull/525#discussion_r307858320 ## File path: examples/datasource-versioning/README_pt.adoc ## @@ -0,0 +1,403 @@ +:index-group: Unrevised +:jbake-type: page +:jbake-status: status=published += Versionamento de DataSource + +Este exemplo mostra como usar DataSources com versão do mesmo provedor usando o atributo classpath. + +== Configuração + +A configuração do DataSource pode ser feita de várias maneiras e aqui nós mostramos +dois métodos comuns na forma de testes unitários. Antes de começarmos, se você +der uma olhada no pom.xml e procurar por maven-dependencia-plugin em uso, você verá que nós puxamos em dois Review comment: Hi Marco, I fix the mistake, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [tomee] marcoantoniobferreira commented on a change in pull request #525: TOMEE-2583 - add translate in PT to examples/datasource-versioning
marcoantoniobferreira commented on a change in pull request #525: TOMEE-2583 - add translate in PT to examples/datasource-versioning URL: https://github.com/apache/tomee/pull/525#discussion_r307853002 ## File path: examples/datasource-versioning/README_pt.adoc ## @@ -0,0 +1,403 @@ +:index-group: Unrevised +:jbake-type: page +:jbake-status: status=published += Versionamento de DataSource + +Este exemplo mostra como usar DataSources com versão do mesmo provedor usando o atributo classpath. + +== Configuração + +A configuração do DataSource pode ser feita de várias maneiras e aqui nós mostramos +dois métodos comuns na forma de testes unitários. Antes de começarmos, se você +der uma olhada no pom.xml e procurar por maven-dependencia-plugin em uso, você verá que nós puxamos em dois Review comment: In this sentence "e procurar por maven-dependencia-plugin em uso", i think that makes more sense like that "e procurar pelo uso do maven-depedency-plugin" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Java 11 - continuing work
Done. New snapshot binaries uploaded. JIRA ticket and subtasks created - at least what I had in mind for now. I'll continue to add more on the flow. Building TCK and I'll be running over the weekend or beginning of next week. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Jul 26, 2019 at 5:57 PM David Blevins wrote: > > On Jul 26, 2019, at 6:09 AM, Jean-Louis Monteiro < > jlmonte...@tomitribe.com> wrote: > > > > Yeah, first build green also on buildbot. Let's merge this one and > continue > > the work. > > https://ci.apache.org/builders/tomee-java11-take2-ubuntu-jvm8/builds/0 > > +1 to merge from me. > > If it's a step forward or sideways and no steps back, I'm all for it. > Definitely preferred to branches that live for weeks or months. > > > -David > >
Re: Java 11 - continuing work
> On Jul 26, 2019, at 6:09 AM, Jean-Louis Monteiro > wrote: > > Yeah, first build green also on buildbot. Let's merge this one and continue > the work. > https://ci.apache.org/builders/tomee-java11-take2-ubuntu-jvm8/builds/0 +1 to merge from me. If it's a step forward or sideways and no steps back, I'm all for it. Definitely preferred to branches that live for weeks or months. -David
[GitHub] [tomee] jeanouii merged pull request #523: Java11 initial work for TOMEE-2584 TOMEE-2600 TOMEE-2601
jeanouii merged pull request #523: Java11 initial work for TOMEE-2584 TOMEE-2600 TOMEE-2601 URL: https://github.com/apache/tomee/pull/523 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Java 11 - continuing work
Yeah, first build green also on buildbot. Let's merge this one and continue
the work.
https://ci.apache.org/builders/tomee-java11-take2-ubuntu-jvm8/builds/0
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Fri, Jul 26, 2019 at 1:22 PM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:
> FYI, on my local machine, the build is green in that branch.
> So if buildbot is green, I'll go ahead and merge it unless someone objects.
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Fri, Jul 26, 2019 at 12:49 PM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
>> yes, it's a good step
>>
>> --
>> Jean-Louis Monteiro
>> http://twitter.com/jlouismonteiro
>> http://www.tomitribe.com
>>
>>
>> On Fri, Jul 26, 2019 at 12:49 PM Jonathan Gallimore <
>> jonathan.gallim...@gmail.com> wrote:
>>
>>> A JDK8 build, JDK11 test config would require more work, but I'll try and
>>> give it a shot. At least we have the JDK8 build, which should help check
>>> if
>>> anything breaks.
>>>
>>> Jon
>>>
>>> On Fri, Jul 26, 2019 at 11:26 AM Jean-Louis Monteiro <
>>> jlmonte...@tomitribe.com> wrote:
>>>
>>> > Hey Jon,
>>> >
>>> > Thanks so much for the help and the update. Definitely helps.
>>> > On the Java 11 builder, we would need to keep building with JDK 8 and
>>> run
>>> > with Java 11.
>>> >
>>> > Currently, it's configured to also build with Java 11 which does not
>>> work
>>> > or would require more work.
>>> >
>>> > --
>>> > Jean-Louis Monteiro
>>> > http://twitter.com/jlouismonteiro
>>> > http://www.tomitribe.com
>>> >
>>> >
>>> > On Fri, Jul 26, 2019 at 12:18 PM Jonathan Gallimore <
>>> > jonathan.gallim...@gmail.com> wrote:
>>> >
>>> > > Thanks for the update JL. I'm just wiring up builds for your branch
>>> now:
>>> > >
>>> > > c['builders'].append(tomee_trunk_win())
>>> > >
>>> >
>>> c['builders'].append(slicker_than_butter_builder("tomee-trunk-ubuntu-jvm8",
>>> > > "master", "latest1.8", "-Xmx1536m"))
>>> > >
>>> > >
>>> > >
>>> > >
>>> >
>>> *c['builders'].append(slicker_than_butter_builder("tomee-java11-take2-ubuntu-jvm8",
>>> > > "java11-take2", "latest1.8",
>>> > >
>>> > >
>>> >
>>> "-Xmx1536m"))c['builders'].append(slicker_than_butter_builder("tomee-java11-take2-ubuntu-jvm11",
>>> > > "java11-take2", "latest11",
>>> > >
>>> > >
>>> >
>>> "-Xmx1536m"))*c['builders'].append(slicker_than_butter_builder("tomee-7.1.x-ubuntu-jvm8",
>>> > > "tomee-7.1.x", "latest1.8", "-Xmx1536m"))
>>> > >
>>> >
>>> c['builders'].append(slicker_than_butter_builder("tomee-7.0.x-ubuntu-jvm8",
>>> > > "tomee-7.0.x", "latest1.8", "-Xmx1536m"))
>>> > >
>>> c['builders'].append(slicker_than_butter_builder("tomee-7.0.x-ubuntu",
>>> > > "tomee-7.0.x", "latest1.7", "-Xmx1536m -XX:PermSize=128m
>>> > > -XX:MaxPermSize=768m -XX:ReservedCodeCacheSize=96m -Xss1024k"))
>>> > >
>>> c['builders'].append(slicker_than_butter_builder("tomee-1.7.x-ubuntu",
>>> > > "tomee-1.7.x", "latest1.7", "-Xmx1024m -XX:PermSize=96m
>>> > > -XX:MaxPermSize=384m -XX:ReservedCodeCacheSize=96m -Xss1024k"))
>>> > >
>>> > > Here's the JDK8 build of your branch:
>>> > > https://ci.apache.org/builders/tomee-java11-take2-ubuntu-jvm8
>>> > > And JDK11:
>>> > https://ci.apache.org/builders/tomee-java11-take2-ubuntu-jvm11
>>> > >
>>> > > I've kicked off builds for both. I have terribly connectivity at the
>>> > > moment, but I'll keep an eye out on how these get on.
>>> > >
>>> > > Jon
>>> > >
>>> > > On Fri, Jul 26, 2019 at 9:50 AM Jean-Louis Monteiro <
>>> > > jlmonte...@tomitribe.com> wrote:
>>> > >
>>> > > > Hi guys,
>>> > > >
>>> > > > I think I have done good progress. Most of the build is passing
>>> with
>>> > Java
>>> > > > 11.
>>> > > > With Java 8, there should not be any backward compatibility issues
>>> as I
>>> > > > tested locally.
>>> > > >
>>> > > > I don't want to stack the PR so it becomes a huge PR and we are
>>> afraid
>>> > to
>>> > > > merge it.
>>> > > > Any issue if I merge the current one and get a new snapshot
>>> deployed?
>>> > > >
>>> > > > If something is broken with Java 8, I can either revert or fix very
>>> > quick
>>> > > > afterwards.
>>> > > >
>>> > > > Thoughts?
>>> > > > PR is https://github.com/apache/tomee/pull/523
>>> > > >
>>> > > > I also would like to run Jakarta EE 8 TCK with both Java 8 and
>>> Java 11
>>> > so
>>> > > > we get a view of were we are.
>>> > > >
>>> > > > I have a couple of tickets and tasks that I gonna file into JIRA
>>> today
>>> > > >
>>> > > > --
>>> > > > Jean-Louis Monteiro
>>> > > > http://twitter.com/jlouismonteiro
>>> > > > http://www.tomitribe.com
>>> > > >
>>> > > >
>>> > > > On Tue, Jul 23, 2019 at 4:30 PM Jean-Louis Monteiro <
>>> > > > jlmonte...@tomitribe.com> wrote:
>>> > > >
>>> > > > > I ended up throwing all the PR away and starting from scratch
>>> again.
>>> > > > > There were too many changes and I did not know anymore what they
>>> were
>>> > > > for.
>>> > > > >
>>> > > > > Went with a different
Traslation into pt-br of examples/datasource-versioning
Hi folks, i translated into portuguese the examples/datasource-versioning PR: https://github.com/apache/tomee/pull/525 JIRA Ticket: https://issues.apache.org/jira/browse/TOMEE-2583 Needs review, thanks! Robinson Severo
[GitHub] [tomee] robinsonvs opened a new pull request #525: add translate in PT to datasource-versioning
robinsonvs opened a new pull request #525: add translate in PT to datasource-versioning URL: https://github.com/apache/tomee/pull/525 ticket of Jira = https://issues.apache.org/jira/browse/TOMEE-2583 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: Java 11 - continuing work
FYI, on my local machine, the build is green in that branch.
So if buildbot is green, I'll go ahead and merge it unless someone objects.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Fri, Jul 26, 2019 at 12:49 PM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:
> yes, it's a good step
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Fri, Jul 26, 2019 at 12:49 PM Jonathan Gallimore <
> jonathan.gallim...@gmail.com> wrote:
>
>> A JDK8 build, JDK11 test config would require more work, but I'll try and
>> give it a shot. At least we have the JDK8 build, which should help check
>> if
>> anything breaks.
>>
>> Jon
>>
>> On Fri, Jul 26, 2019 at 11:26 AM Jean-Louis Monteiro <
>> jlmonte...@tomitribe.com> wrote:
>>
>> > Hey Jon,
>> >
>> > Thanks so much for the help and the update. Definitely helps.
>> > On the Java 11 builder, we would need to keep building with JDK 8 and
>> run
>> > with Java 11.
>> >
>> > Currently, it's configured to also build with Java 11 which does not
>> work
>> > or would require more work.
>> >
>> > --
>> > Jean-Louis Monteiro
>> > http://twitter.com/jlouismonteiro
>> > http://www.tomitribe.com
>> >
>> >
>> > On Fri, Jul 26, 2019 at 12:18 PM Jonathan Gallimore <
>> > jonathan.gallim...@gmail.com> wrote:
>> >
>> > > Thanks for the update JL. I'm just wiring up builds for your branch
>> now:
>> > >
>> > > c['builders'].append(tomee_trunk_win())
>> > >
>> >
>> c['builders'].append(slicker_than_butter_builder("tomee-trunk-ubuntu-jvm8",
>> > > "master", "latest1.8", "-Xmx1536m"))
>> > >
>> > >
>> > >
>> > >
>> >
>> *c['builders'].append(slicker_than_butter_builder("tomee-java11-take2-ubuntu-jvm8",
>> > > "java11-take2", "latest1.8",
>> > >
>> > >
>> >
>> "-Xmx1536m"))c['builders'].append(slicker_than_butter_builder("tomee-java11-take2-ubuntu-jvm11",
>> > > "java11-take2", "latest11",
>> > >
>> > >
>> >
>> "-Xmx1536m"))*c['builders'].append(slicker_than_butter_builder("tomee-7.1.x-ubuntu-jvm8",
>> > > "tomee-7.1.x", "latest1.8", "-Xmx1536m"))
>> > >
>> >
>> c['builders'].append(slicker_than_butter_builder("tomee-7.0.x-ubuntu-jvm8",
>> > > "tomee-7.0.x", "latest1.8", "-Xmx1536m"))
>> > > c['builders'].append(slicker_than_butter_builder("tomee-7.0.x-ubuntu",
>> > > "tomee-7.0.x", "latest1.7", "-Xmx1536m -XX:PermSize=128m
>> > > -XX:MaxPermSize=768m -XX:ReservedCodeCacheSize=96m -Xss1024k"))
>> > > c['builders'].append(slicker_than_butter_builder("tomee-1.7.x-ubuntu",
>> > > "tomee-1.7.x", "latest1.7", "-Xmx1024m -XX:PermSize=96m
>> > > -XX:MaxPermSize=384m -XX:ReservedCodeCacheSize=96m -Xss1024k"))
>> > >
>> > > Here's the JDK8 build of your branch:
>> > > https://ci.apache.org/builders/tomee-java11-take2-ubuntu-jvm8
>> > > And JDK11:
>> > https://ci.apache.org/builders/tomee-java11-take2-ubuntu-jvm11
>> > >
>> > > I've kicked off builds for both. I have terribly connectivity at the
>> > > moment, but I'll keep an eye out on how these get on.
>> > >
>> > > Jon
>> > >
>> > > On Fri, Jul 26, 2019 at 9:50 AM Jean-Louis Monteiro <
>> > > jlmonte...@tomitribe.com> wrote:
>> > >
>> > > > Hi guys,
>> > > >
>> > > > I think I have done good progress. Most of the build is passing with
>> > Java
>> > > > 11.
>> > > > With Java 8, there should not be any backward compatibility issues
>> as I
>> > > > tested locally.
>> > > >
>> > > > I don't want to stack the PR so it becomes a huge PR and we are
>> afraid
>> > to
>> > > > merge it.
>> > > > Any issue if I merge the current one and get a new snapshot
>> deployed?
>> > > >
>> > > > If something is broken with Java 8, I can either revert or fix very
>> > quick
>> > > > afterwards.
>> > > >
>> > > > Thoughts?
>> > > > PR is https://github.com/apache/tomee/pull/523
>> > > >
>> > > > I also would like to run Jakarta EE 8 TCK with both Java 8 and Java
>> 11
>> > so
>> > > > we get a view of were we are.
>> > > >
>> > > > I have a couple of tickets and tasks that I gonna file into JIRA
>> today
>> > > >
>> > > > --
>> > > > Jean-Louis Monteiro
>> > > > http://twitter.com/jlouismonteiro
>> > > > http://www.tomitribe.com
>> > > >
>> > > >
>> > > > On Tue, Jul 23, 2019 at 4:30 PM Jean-Louis Monteiro <
>> > > > jlmonte...@tomitribe.com> wrote:
>> > > >
>> > > > > I ended up throwing all the PR away and starting from scratch
>> again.
>> > > > > There were too many changes and I did not know anymore what they
>> were
>> > > > for.
>> > > > >
>> > > > > Went with a different approach to see if it works better.
>> > > > > On master, we introduced some garbage by the way, not sure why but
>> > > we'll
>> > > > > have to fix some pom stuff because I suspect we have too much
>> stuff
>> > in
>> > > > the
>> > > > > binaries.
>> > > > > --
>> > > > > Jean-Louis Monteiro
>> > > > > http://twitter.com/jlouismonteiro
>> > > > > http://www.tomitribe.com
>> > > > >
>> > > > >
>> > > > > On Tue, Jul 23, 2019 at 3:28 PM Jean-Louis Monteiro <
>> > > > > jlmonte...@tomitribe.com>
Re: Java 11 - continuing work
yes, it's a good step
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Fri, Jul 26, 2019 at 12:49 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:
> A JDK8 build, JDK11 test config would require more work, but I'll try and
> give it a shot. At least we have the JDK8 build, which should help check if
> anything breaks.
>
> Jon
>
> On Fri, Jul 26, 2019 at 11:26 AM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
> > Hey Jon,
> >
> > Thanks so much for the help and the update. Definitely helps.
> > On the Java 11 builder, we would need to keep building with JDK 8 and run
> > with Java 11.
> >
> > Currently, it's configured to also build with Java 11 which does not work
> > or would require more work.
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Fri, Jul 26, 2019 at 12:18 PM Jonathan Gallimore <
> > jonathan.gallim...@gmail.com> wrote:
> >
> > > Thanks for the update JL. I'm just wiring up builds for your branch
> now:
> > >
> > > c['builders'].append(tomee_trunk_win())
> > >
> >
> c['builders'].append(slicker_than_butter_builder("tomee-trunk-ubuntu-jvm8",
> > > "master", "latest1.8", "-Xmx1536m"))
> > >
> > >
> > >
> > >
> >
> *c['builders'].append(slicker_than_butter_builder("tomee-java11-take2-ubuntu-jvm8",
> > > "java11-take2", "latest1.8",
> > >
> > >
> >
> "-Xmx1536m"))c['builders'].append(slicker_than_butter_builder("tomee-java11-take2-ubuntu-jvm11",
> > > "java11-take2", "latest11",
> > >
> > >
> >
> "-Xmx1536m"))*c['builders'].append(slicker_than_butter_builder("tomee-7.1.x-ubuntu-jvm8",
> > > "tomee-7.1.x", "latest1.8", "-Xmx1536m"))
> > >
> >
> c['builders'].append(slicker_than_butter_builder("tomee-7.0.x-ubuntu-jvm8",
> > > "tomee-7.0.x", "latest1.8", "-Xmx1536m"))
> > > c['builders'].append(slicker_than_butter_builder("tomee-7.0.x-ubuntu",
> > > "tomee-7.0.x", "latest1.7", "-Xmx1536m -XX:PermSize=128m
> > > -XX:MaxPermSize=768m -XX:ReservedCodeCacheSize=96m -Xss1024k"))
> > > c['builders'].append(slicker_than_butter_builder("tomee-1.7.x-ubuntu",
> > > "tomee-1.7.x", "latest1.7", "-Xmx1024m -XX:PermSize=96m
> > > -XX:MaxPermSize=384m -XX:ReservedCodeCacheSize=96m -Xss1024k"))
> > >
> > > Here's the JDK8 build of your branch:
> > > https://ci.apache.org/builders/tomee-java11-take2-ubuntu-jvm8
> > > And JDK11:
> > https://ci.apache.org/builders/tomee-java11-take2-ubuntu-jvm11
> > >
> > > I've kicked off builds for both. I have terribly connectivity at the
> > > moment, but I'll keep an eye out on how these get on.
> > >
> > > Jon
> > >
> > > On Fri, Jul 26, 2019 at 9:50 AM Jean-Louis Monteiro <
> > > jlmonte...@tomitribe.com> wrote:
> > >
> > > > Hi guys,
> > > >
> > > > I think I have done good progress. Most of the build is passing with
> > Java
> > > > 11.
> > > > With Java 8, there should not be any backward compatibility issues
> as I
> > > > tested locally.
> > > >
> > > > I don't want to stack the PR so it becomes a huge PR and we are
> afraid
> > to
> > > > merge it.
> > > > Any issue if I merge the current one and get a new snapshot deployed?
> > > >
> > > > If something is broken with Java 8, I can either revert or fix very
> > quick
> > > > afterwards.
> > > >
> > > > Thoughts?
> > > > PR is https://github.com/apache/tomee/pull/523
> > > >
> > > > I also would like to run Jakarta EE 8 TCK with both Java 8 and Java
> 11
> > so
> > > > we get a view of were we are.
> > > >
> > > > I have a couple of tickets and tasks that I gonna file into JIRA
> today
> > > >
> > > > --
> > > > Jean-Louis Monteiro
> > > > http://twitter.com/jlouismonteiro
> > > > http://www.tomitribe.com
> > > >
> > > >
> > > > On Tue, Jul 23, 2019 at 4:30 PM Jean-Louis Monteiro <
> > > > jlmonte...@tomitribe.com> wrote:
> > > >
> > > > > I ended up throwing all the PR away and starting from scratch
> again.
> > > > > There were too many changes and I did not know anymore what they
> were
> > > > for.
> > > > >
> > > > > Went with a different approach to see if it works better.
> > > > > On master, we introduced some garbage by the way, not sure why but
> > > we'll
> > > > > have to fix some pom stuff because I suspect we have too much stuff
> > in
> > > > the
> > > > > binaries.
> > > > > --
> > > > > Jean-Louis Monteiro
> > > > > http://twitter.com/jlouismonteiro
> > > > > http://www.tomitribe.com
> > > > >
> > > > >
> > > > > On Tue, Jul 23, 2019 at 3:28 PM Jean-Louis Monteiro <
> > > > > jlmonte...@tomitribe.com> wrote:
> > > > >
> > > > >> Hey David,
> > > > >>
> > > > >> Thanks for the feedback.
> > > > >> I already removed some of them. It has some side effects that I
> > still
> > > > >> need to investigate. For instance, removing soap-api, makes the
> > > > >> UniverseTest to fail. The Geronimo service locator seems to mess
> up
> > > the
> > > > >> test.
> > > > >>
> > > > >>
> > > > >>
> > > > >> --
> > > > >> Jean-Louis Monteiro
> > > > >> http://twitter.com/jlouismonteiro
> > >
Re: Java 11 - continuing work
A JDK8 build, JDK11 test config would require more work, but I'll try and
give it a shot. At least we have the JDK8 build, which should help check if
anything breaks.
Jon
On Fri, Jul 26, 2019 at 11:26 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:
> Hey Jon,
>
> Thanks so much for the help and the update. Definitely helps.
> On the Java 11 builder, we would need to keep building with JDK 8 and run
> with Java 11.
>
> Currently, it's configured to also build with Java 11 which does not work
> or would require more work.
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Fri, Jul 26, 2019 at 12:18 PM Jonathan Gallimore <
> jonathan.gallim...@gmail.com> wrote:
>
> > Thanks for the update JL. I'm just wiring up builds for your branch now:
> >
> > c['builders'].append(tomee_trunk_win())
> >
> c['builders'].append(slicker_than_butter_builder("tomee-trunk-ubuntu-jvm8",
> > "master", "latest1.8", "-Xmx1536m"))
> >
> >
> >
> >
> *c['builders'].append(slicker_than_butter_builder("tomee-java11-take2-ubuntu-jvm8",
> > "java11-take2", "latest1.8",
> >
> >
> "-Xmx1536m"))c['builders'].append(slicker_than_butter_builder("tomee-java11-take2-ubuntu-jvm11",
> > "java11-take2", "latest11",
> >
> >
> "-Xmx1536m"))*c['builders'].append(slicker_than_butter_builder("tomee-7.1.x-ubuntu-jvm8",
> > "tomee-7.1.x", "latest1.8", "-Xmx1536m"))
> >
> c['builders'].append(slicker_than_butter_builder("tomee-7.0.x-ubuntu-jvm8",
> > "tomee-7.0.x", "latest1.8", "-Xmx1536m"))
> > c['builders'].append(slicker_than_butter_builder("tomee-7.0.x-ubuntu",
> > "tomee-7.0.x", "latest1.7", "-Xmx1536m -XX:PermSize=128m
> > -XX:MaxPermSize=768m -XX:ReservedCodeCacheSize=96m -Xss1024k"))
> > c['builders'].append(slicker_than_butter_builder("tomee-1.7.x-ubuntu",
> > "tomee-1.7.x", "latest1.7", "-Xmx1024m -XX:PermSize=96m
> > -XX:MaxPermSize=384m -XX:ReservedCodeCacheSize=96m -Xss1024k"))
> >
> > Here's the JDK8 build of your branch:
> > https://ci.apache.org/builders/tomee-java11-take2-ubuntu-jvm8
> > And JDK11:
> https://ci.apache.org/builders/tomee-java11-take2-ubuntu-jvm11
> >
> > I've kicked off builds for both. I have terribly connectivity at the
> > moment, but I'll keep an eye out on how these get on.
> >
> > Jon
> >
> > On Fri, Jul 26, 2019 at 9:50 AM Jean-Louis Monteiro <
> > jlmonte...@tomitribe.com> wrote:
> >
> > > Hi guys,
> > >
> > > I think I have done good progress. Most of the build is passing with
> Java
> > > 11.
> > > With Java 8, there should not be any backward compatibility issues as I
> > > tested locally.
> > >
> > > I don't want to stack the PR so it becomes a huge PR and we are afraid
> to
> > > merge it.
> > > Any issue if I merge the current one and get a new snapshot deployed?
> > >
> > > If something is broken with Java 8, I can either revert or fix very
> quick
> > > afterwards.
> > >
> > > Thoughts?
> > > PR is https://github.com/apache/tomee/pull/523
> > >
> > > I also would like to run Jakarta EE 8 TCK with both Java 8 and Java 11
> so
> > > we get a view of were we are.
> > >
> > > I have a couple of tickets and tasks that I gonna file into JIRA today
> > >
> > > --
> > > Jean-Louis Monteiro
> > > http://twitter.com/jlouismonteiro
> > > http://www.tomitribe.com
> > >
> > >
> > > On Tue, Jul 23, 2019 at 4:30 PM Jean-Louis Monteiro <
> > > jlmonte...@tomitribe.com> wrote:
> > >
> > > > I ended up throwing all the PR away and starting from scratch again.
> > > > There were too many changes and I did not know anymore what they were
> > > for.
> > > >
> > > > Went with a different approach to see if it works better.
> > > > On master, we introduced some garbage by the way, not sure why but
> > we'll
> > > > have to fix some pom stuff because I suspect we have too much stuff
> in
> > > the
> > > > binaries.
> > > > --
> > > > Jean-Louis Monteiro
> > > > http://twitter.com/jlouismonteiro
> > > > http://www.tomitribe.com
> > > >
> > > >
> > > > On Tue, Jul 23, 2019 at 3:28 PM Jean-Louis Monteiro <
> > > > jlmonte...@tomitribe.com> wrote:
> > > >
> > > >> Hey David,
> > > >>
> > > >> Thanks for the feedback.
> > > >> I already removed some of them. It has some side effects that I
> still
> > > >> need to investigate. For instance, removing soap-api, makes the
> > > >> UniverseTest to fail. The Geronimo service locator seems to mess up
> > the
> > > >> test.
> > > >>
> > > >>
> > > >>
> > > >> --
> > > >> Jean-Louis Monteiro
> > > >> http://twitter.com/jlouismonteiro
> > > >> http://www.tomitribe.com
> > > >>
> > > >>
> > > >> On Tue, Jul 23, 2019 at 3:11 PM David Blevins <
> > david.blev...@gmail.com>
> > > >> wrote:
> > > >>
> > > >>> > On Jul 23, 2019, at 5:46 AM, Jonathan Gallimore <
> > > >>> jonathan.gallim...@gmail.com> wrote:
> > > >>> >
> > > >>> > I did a build on master and on the branch. The "plus" artifact
> for
> > > the
> > > >>> > branch has the following library diffs compared with master:
> > > >>>
> > > >>> Thanks!
> > > >>>
> > > >>> >
Re: Java 11 - continuing work
Hey Jon,
Thanks so much for the help and the update. Definitely helps.
On the Java 11 builder, we would need to keep building with JDK 8 and run
with Java 11.
Currently, it's configured to also build with Java 11 which does not work
or would require more work.
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com
On Fri, Jul 26, 2019 at 12:18 PM Jonathan Gallimore <
jonathan.gallim...@gmail.com> wrote:
> Thanks for the update JL. I'm just wiring up builds for your branch now:
>
> c['builders'].append(tomee_trunk_win())
> c['builders'].append(slicker_than_butter_builder("tomee-trunk-ubuntu-jvm8",
> "master", "latest1.8", "-Xmx1536m"))
>
>
>
> *c['builders'].append(slicker_than_butter_builder("tomee-java11-take2-ubuntu-jvm8",
> "java11-take2", "latest1.8",
>
> "-Xmx1536m"))c['builders'].append(slicker_than_butter_builder("tomee-java11-take2-ubuntu-jvm11",
> "java11-take2", "latest11",
>
> "-Xmx1536m"))*c['builders'].append(slicker_than_butter_builder("tomee-7.1.x-ubuntu-jvm8",
> "tomee-7.1.x", "latest1.8", "-Xmx1536m"))
> c['builders'].append(slicker_than_butter_builder("tomee-7.0.x-ubuntu-jvm8",
> "tomee-7.0.x", "latest1.8", "-Xmx1536m"))
> c['builders'].append(slicker_than_butter_builder("tomee-7.0.x-ubuntu",
> "tomee-7.0.x", "latest1.7", "-Xmx1536m -XX:PermSize=128m
> -XX:MaxPermSize=768m -XX:ReservedCodeCacheSize=96m -Xss1024k"))
> c['builders'].append(slicker_than_butter_builder("tomee-1.7.x-ubuntu",
> "tomee-1.7.x", "latest1.7", "-Xmx1024m -XX:PermSize=96m
> -XX:MaxPermSize=384m -XX:ReservedCodeCacheSize=96m -Xss1024k"))
>
> Here's the JDK8 build of your branch:
> https://ci.apache.org/builders/tomee-java11-take2-ubuntu-jvm8
> And JDK11: https://ci.apache.org/builders/tomee-java11-take2-ubuntu-jvm11
>
> I've kicked off builds for both. I have terribly connectivity at the
> moment, but I'll keep an eye out on how these get on.
>
> Jon
>
> On Fri, Jul 26, 2019 at 9:50 AM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
> > Hi guys,
> >
> > I think I have done good progress. Most of the build is passing with Java
> > 11.
> > With Java 8, there should not be any backward compatibility issues as I
> > tested locally.
> >
> > I don't want to stack the PR so it becomes a huge PR and we are afraid to
> > merge it.
> > Any issue if I merge the current one and get a new snapshot deployed?
> >
> > If something is broken with Java 8, I can either revert or fix very quick
> > afterwards.
> >
> > Thoughts?
> > PR is https://github.com/apache/tomee/pull/523
> >
> > I also would like to run Jakarta EE 8 TCK with both Java 8 and Java 11 so
> > we get a view of were we are.
> >
> > I have a couple of tickets and tasks that I gonna file into JIRA today
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Tue, Jul 23, 2019 at 4:30 PM Jean-Louis Monteiro <
> > jlmonte...@tomitribe.com> wrote:
> >
> > > I ended up throwing all the PR away and starting from scratch again.
> > > There were too many changes and I did not know anymore what they were
> > for.
> > >
> > > Went with a different approach to see if it works better.
> > > On master, we introduced some garbage by the way, not sure why but
> we'll
> > > have to fix some pom stuff because I suspect we have too much stuff in
> > the
> > > binaries.
> > > --
> > > Jean-Louis Monteiro
> > > http://twitter.com/jlouismonteiro
> > > http://www.tomitribe.com
> > >
> > >
> > > On Tue, Jul 23, 2019 at 3:28 PM Jean-Louis Monteiro <
> > > jlmonte...@tomitribe.com> wrote:
> > >
> > >> Hey David,
> > >>
> > >> Thanks for the feedback.
> > >> I already removed some of them. It has some side effects that I still
> > >> need to investigate. For instance, removing soap-api, makes the
> > >> UniverseTest to fail. The Geronimo service locator seems to mess up
> the
> > >> test.
> > >>
> > >>
> > >>
> > >> --
> > >> Jean-Louis Monteiro
> > >> http://twitter.com/jlouismonteiro
> > >> http://www.tomitribe.com
> > >>
> > >>
> > >> On Tue, Jul 23, 2019 at 3:11 PM David Blevins <
> david.blev...@gmail.com>
> > >> wrote:
> > >>
> > >>> > On Jul 23, 2019, at 5:46 AM, Jonathan Gallimore <
> > >>> jonathan.gallim...@gmail.com> wrote:
> > >>> >
> > >>> > I did a build on master and on the branch. The "plus" artifact for
> > the
> > >>> > branch has the following library diffs compared with master:
> > >>>
> > >>> Thanks!
> > >>>
> > >>> > +jacorb-3.9
> > >>> > +jacorb-omgapi-3.9
> > >>> > +jboss-rmi-api_1.0_spec-1.0.6.Final
> > >>>
> > >>> These should be cut out as we do not actually implement the
> CORBA/IIOP
> > >>> and CSIv2 code required by the full profile.
> > >>>
> > >>> > +jakartax.activation-api-1.2.1
> > >>> > +javax.activation-1.2.0
> > >>> > +javax.activation-api-1.2.0
> > >>> > +javax.xml.soap-api-1.4.0
> > >>> > +management-api-3.0.0-b012
> > >>>
> > >>> The Geronimo versions of these should already be in our javaee-api
> jar.
> > >>>
> > >>>
> > >>> -David
> > >>>
> > >>>
> >
Re: Java 11 - continuing work
Thanks for the update JL. I'm just wiring up builds for your branch now:
c['builders'].append(tomee_trunk_win())
c['builders'].append(slicker_than_butter_builder("tomee-trunk-ubuntu-jvm8",
"master", "latest1.8", "-Xmx1536m"))
*c['builders'].append(slicker_than_butter_builder("tomee-java11-take2-ubuntu-jvm8",
"java11-take2", "latest1.8",
"-Xmx1536m"))c['builders'].append(slicker_than_butter_builder("tomee-java11-take2-ubuntu-jvm11",
"java11-take2", "latest11",
"-Xmx1536m"))*c['builders'].append(slicker_than_butter_builder("tomee-7.1.x-ubuntu-jvm8",
"tomee-7.1.x", "latest1.8", "-Xmx1536m"))
c['builders'].append(slicker_than_butter_builder("tomee-7.0.x-ubuntu-jvm8",
"tomee-7.0.x", "latest1.8", "-Xmx1536m"))
c['builders'].append(slicker_than_butter_builder("tomee-7.0.x-ubuntu",
"tomee-7.0.x", "latest1.7", "-Xmx1536m -XX:PermSize=128m
-XX:MaxPermSize=768m -XX:ReservedCodeCacheSize=96m -Xss1024k"))
c['builders'].append(slicker_than_butter_builder("tomee-1.7.x-ubuntu",
"tomee-1.7.x", "latest1.7", "-Xmx1024m -XX:PermSize=96m
-XX:MaxPermSize=384m -XX:ReservedCodeCacheSize=96m -Xss1024k"))
Here's the JDK8 build of your branch:
https://ci.apache.org/builders/tomee-java11-take2-ubuntu-jvm8
And JDK11: https://ci.apache.org/builders/tomee-java11-take2-ubuntu-jvm11
I've kicked off builds for both. I have terribly connectivity at the
moment, but I'll keep an eye out on how these get on.
Jon
On Fri, Jul 26, 2019 at 9:50 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:
> Hi guys,
>
> I think I have done good progress. Most of the build is passing with Java
> 11.
> With Java 8, there should not be any backward compatibility issues as I
> tested locally.
>
> I don't want to stack the PR so it becomes a huge PR and we are afraid to
> merge it.
> Any issue if I merge the current one and get a new snapshot deployed?
>
> If something is broken with Java 8, I can either revert or fix very quick
> afterwards.
>
> Thoughts?
> PR is https://github.com/apache/tomee/pull/523
>
> I also would like to run Jakarta EE 8 TCK with both Java 8 and Java 11 so
> we get a view of were we are.
>
> I have a couple of tickets and tasks that I gonna file into JIRA today
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Tue, Jul 23, 2019 at 4:30 PM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
> > I ended up throwing all the PR away and starting from scratch again.
> > There were too many changes and I did not know anymore what they were
> for.
> >
> > Went with a different approach to see if it works better.
> > On master, we introduced some garbage by the way, not sure why but we'll
> > have to fix some pom stuff because I suspect we have too much stuff in
> the
> > binaries.
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Tue, Jul 23, 2019 at 3:28 PM Jean-Louis Monteiro <
> > jlmonte...@tomitribe.com> wrote:
> >
> >> Hey David,
> >>
> >> Thanks for the feedback.
> >> I already removed some of them. It has some side effects that I still
> >> need to investigate. For instance, removing soap-api, makes the
> >> UniverseTest to fail. The Geronimo service locator seems to mess up the
> >> test.
> >>
> >>
> >>
> >> --
> >> Jean-Louis Monteiro
> >> http://twitter.com/jlouismonteiro
> >> http://www.tomitribe.com
> >>
> >>
> >> On Tue, Jul 23, 2019 at 3:11 PM David Blevins
> >> wrote:
> >>
> >>> > On Jul 23, 2019, at 5:46 AM, Jonathan Gallimore <
> >>> jonathan.gallim...@gmail.com> wrote:
> >>> >
> >>> > I did a build on master and on the branch. The "plus" artifact for
> the
> >>> > branch has the following library diffs compared with master:
> >>>
> >>> Thanks!
> >>>
> >>> > +jacorb-3.9
> >>> > +jacorb-omgapi-3.9
> >>> > +jboss-rmi-api_1.0_spec-1.0.6.Final
> >>>
> >>> These should be cut out as we do not actually implement the CORBA/IIOP
> >>> and CSIv2 code required by the full profile.
> >>>
> >>> > +jakartax.activation-api-1.2.1
> >>> > +javax.activation-1.2.0
> >>> > +javax.activation-api-1.2.0
> >>> > +javax.xml.soap-api-1.4.0
> >>> > +management-api-3.0.0-b012
> >>>
> >>> The Geronimo versions of these should already be in our javaee-api jar.
> >>>
> >>>
> >>> -David
> >>>
> >>>
>
Re: Java 11 - continuing work
Hi guys, I think I have done good progress. Most of the build is passing with Java 11. With Java 8, there should not be any backward compatibility issues as I tested locally. I don't want to stack the PR so it becomes a huge PR and we are afraid to merge it. Any issue if I merge the current one and get a new snapshot deployed? If something is broken with Java 8, I can either revert or fix very quick afterwards. Thoughts? PR is https://github.com/apache/tomee/pull/523 I also would like to run Jakarta EE 8 TCK with both Java 8 and Java 11 so we get a view of were we are. I have a couple of tickets and tasks that I gonna file into JIRA today -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Tue, Jul 23, 2019 at 4:30 PM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > I ended up throwing all the PR away and starting from scratch again. > There were too many changes and I did not know anymore what they were for. > > Went with a different approach to see if it works better. > On master, we introduced some garbage by the way, not sure why but we'll > have to fix some pom stuff because I suspect we have too much stuff in the > binaries. > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Tue, Jul 23, 2019 at 3:28 PM Jean-Louis Monteiro < > jlmonte...@tomitribe.com> wrote: > >> Hey David, >> >> Thanks for the feedback. >> I already removed some of them. It has some side effects that I still >> need to investigate. For instance, removing soap-api, makes the >> UniverseTest to fail. The Geronimo service locator seems to mess up the >> test. >> >> >> >> -- >> Jean-Louis Monteiro >> http://twitter.com/jlouismonteiro >> http://www.tomitribe.com >> >> >> On Tue, Jul 23, 2019 at 3:11 PM David Blevins >> wrote: >> >>> > On Jul 23, 2019, at 5:46 AM, Jonathan Gallimore < >>> jonathan.gallim...@gmail.com> wrote: >>> > >>> > I did a build on master and on the branch. The "plus" artifact for the >>> > branch has the following library diffs compared with master: >>> >>> Thanks! >>> >>> > +jacorb-3.9 >>> > +jacorb-omgapi-3.9 >>> > +jboss-rmi-api_1.0_spec-1.0.6.Final >>> >>> These should be cut out as we do not actually implement the CORBA/IIOP >>> and CSIv2 code required by the full profile. >>> >>> > +jakartax.activation-api-1.2.1 >>> > +javax.activation-1.2.0 >>> > +javax.activation-api-1.2.0 >>> > +javax.xml.soap-api-1.4.0 >>> > +management-api-3.0.0-b012 >>> >>> The Geronimo versions of these should already be in our javaee-api jar. >>> >>> >>> -David >>> >>>
