Hey Jon, Thanks so much for the help and the update. Definitely helps. On the Java 11 builder, we would need to keep building with JDK 8 and run with Java 11.
Currently, it's configured to also build with Java 11 which does not work or would require more work. -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Fri, Jul 26, 2019 at 12:18 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Thanks for the update JL. I'm just wiring up builds for your branch now: > > c['builders'].append(tomee_trunk_win()) > c['builders'].append(slicker_than_butter_builder("tomee-trunk-ubuntu-jvm8", > "master", "latest1.8", "-Xmx1536m")) > > > > *c['builders'].append(slicker_than_butter_builder("tomee-java11-take2-ubuntu-jvm8", > "java11-take2", "latest1.8", > > "-Xmx1536m"))c['builders'].append(slicker_than_butter_builder("tomee-java11-take2-ubuntu-jvm11", > "java11-take2", "latest11", > > "-Xmx1536m"))*c['builders'].append(slicker_than_butter_builder("tomee-7.1.x-ubuntu-jvm8", > "tomee-7.1.x", "latest1.8", "-Xmx1536m")) > c['builders'].append(slicker_than_butter_builder("tomee-7.0.x-ubuntu-jvm8", > "tomee-7.0.x", "latest1.8", "-Xmx1536m")) > c['builders'].append(slicker_than_butter_builder("tomee-7.0.x-ubuntu", > "tomee-7.0.x", "latest1.7", "-Xmx1536m -XX:PermSize=128m > -XX:MaxPermSize=768m -XX:ReservedCodeCacheSize=96m -Xss1024k")) > c['builders'].append(slicker_than_butter_builder("tomee-1.7.x-ubuntu", > "tomee-1.7.x", "latest1.7", "-Xmx1024m -XX:PermSize=96m > -XX:MaxPermSize=384m -XX:ReservedCodeCacheSize=96m -Xss1024k")) > > Here's the JDK8 build of your branch: > https://ci.apache.org/builders/tomee-java11-take2-ubuntu-jvm8 > And JDK11: https://ci.apache.org/builders/tomee-java11-take2-ubuntu-jvm11 > > I've kicked off builds for both. I have terribly connectivity at the > moment, but I'll keep an eye out on how these get on. > > Jon > > On Fri, Jul 26, 2019 at 9:50 AM Jean-Louis Monteiro < > jlmonte...@tomitribe.com> wrote: > > > Hi guys, > > > > I think I have done good progress. Most of the build is passing with Java > > 11. > > With Java 8, there should not be any backward compatibility issues as I > > tested locally. > > > > I don't want to stack the PR so it becomes a huge PR and we are afraid to > > merge it. > > Any issue if I merge the current one and get a new snapshot deployed? > > > > If something is broken with Java 8, I can either revert or fix very quick > > afterwards. > > > > Thoughts? > > PR is https://github.com/apache/tomee/pull/523 > > > > I also would like to run Jakarta EE 8 TCK with both Java 8 and Java 11 so > > we get a view of were we are. > > > > I have a couple of tickets and tasks that I gonna file into JIRA today > > > > -- > > Jean-Louis Monteiro > > http://twitter.com/jlouismonteiro > > http://www.tomitribe.com > > > > > > On Tue, Jul 23, 2019 at 4:30 PM Jean-Louis Monteiro < > > jlmonte...@tomitribe.com> wrote: > > > > > I ended up throwing all the PR away and starting from scratch again. > > > There were too many changes and I did not know anymore what they were > > for. > > > > > > Went with a different approach to see if it works better. > > > On master, we introduced some garbage by the way, not sure why but > we'll > > > have to fix some pom stuff because I suspect we have too much stuff in > > the > > > binaries. > > > -- > > > Jean-Louis Monteiro > > > http://twitter.com/jlouismonteiro > > > http://www.tomitribe.com > > > > > > > > > On Tue, Jul 23, 2019 at 3:28 PM Jean-Louis Monteiro < > > > jlmonte...@tomitribe.com> wrote: > > > > > >> Hey David, > > >> > > >> Thanks for the feedback. > > >> I already removed some of them. It has some side effects that I still > > >> need to investigate. For instance, removing soap-api, makes the > > >> UniverseTest to fail. The Geronimo service locator seems to mess up > the > > >> test. > > >> > > >> > > >> > > >> -- > > >> Jean-Louis Monteiro > > >> http://twitter.com/jlouismonteiro > > >> http://www.tomitribe.com > > >> > > >> > > >> On Tue, Jul 23, 2019 at 3:11 PM David Blevins < > david.blev...@gmail.com> > > >> wrote: > > >> > > >>> > On Jul 23, 2019, at 5:46 AM, Jonathan Gallimore < > > >>> jonathan.gallim...@gmail.com> wrote: > > >>> > > > >>> > I did a build on master and on the branch. The "plus" artifact for > > the > > >>> > branch has the following library diffs compared with master: > > >>> > > >>> Thanks! > > >>> > > >>> > +jacorb-3.9 > > >>> > +jacorb-omgapi-3.9 > > >>> > +jboss-rmi-api_1.0_spec-1.0.6.Final > > >>> > > >>> These should be cut out as we do not actually implement the > CORBA/IIOP > > >>> and CSIv2 code required by the full profile. > > >>> > > >>> > +jakartax.activation-api-1.2.1 > > >>> > +javax.activation-1.2.0 > > >>> > +javax.activation-api-1.2.0 > > >>> > +javax.xml.soap-api-1.4.0 > > >>> > +management-api-3.0.0-b012 > > >>> > > >>> The Geronimo versions of these should already be in our javaee-api > jar. > > >>> > > >>> > > >>> -David > > >>> > > >>> > > >
