Re: tomee-patch release staging?

[David Blevins]

I was wrong :)  We did need that.  I was supposed to click release on that one 
as it contained the patched bval from the M3 release.

I've quickly replaced it, so things are all fine.  Mental note to use the same 
staging repo should we need to do that again -- which we hopefully won't any 
time soon.


-David


> On Aug 4, 2019, at 11:40 PM, Mark Struberg  wrote:
> 
> Done.
> 
> LieGrue,
> strub
> 
> 
>> Am 05.08.2019 um 08:28 schrieb David Blevins :
>> 
>> Go ahead and drop it.  Thank you!
>> 
>> Good catch.
>> 
>> -- 
>> David Blevins
>> http://twitter.com/dblevins
>> http://www.tomitribe.com
>> 
>>> On Aug 4, 2019, at 11:15 PM, Mark Struberg  
>>> wrote:
>>> 
>>> Good morning!
>>> 
>>> While releasing Johnzon-1.1.13 I stumbled across a TomEE staging repo from 
>>> May
>>> https://repository.apache.org/content/repositories/orgapachetomee-1134
>>> 
>>> Can we drop this, or is it still needed?
>>> 
>>> LieGrue,
>>> strub
>> 
> 

Re: Wrong m3 bval dep?

[Jean-Louis Monteiro]

Thx

Le lun. 5 août 2019 à 20:14, David Blevins  a
écrit :

> Build running with the MP-JWT Bean Validation feature removed and stock
> bval library.
>
>  - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1145
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
> > On Aug 5, 2019, at 8:40 AM, Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
> >
> > Build is back to green
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Mon, Aug 5, 2019 at 3:21 PM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com>
> > wrote:
> >
> >> Thanks David.
> >> New build ...
> >> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1143
> >>
> >>
> >> --
> >> Jean-Louis Monteiro
> >> http://twitter.com/jlouismonteiro
> >> http://www.tomitribe.com
> >>
> >>
> >> On Mon, Aug 5, 2019 at 3:20 PM David Blevins 
> >> wrote:
> >>
>  On Aug 5, 2019, at 6:14 AM, Jean-Louis Monteiro <
> >>> jlmonte...@tomitribe.com> wrote:
> 
>  I fixed it a while back, but when I reverted last week, I reverted the
> >>> fix
>  as well.
>  Sorry about that, I'll fix now.
> >>>
> >>> No apologies necessary.  As the saying goes, the only people who don't
> >>> break the build are those who do nothing :)
> >>>
> >>> So congratulations is the better sentiment :)
> >>>
> >>>
> >>> -David
> >>>
>  On Mon, Aug 5, 2019 at 3:12 PM David Blevins  >
>  wrote:
> 
> > First step would be to get the build passing again.  There are
> failures
> > which are not related to bean validation.
> >
> > Once those are fixed and our build is green again, I'll do the work
> to
> > disable the feature I added that needs a modified BVal.  I hesitate
> to
> >>> do
> > it now because the build isn't passing now for unrelated reasons and
> > disabling and changing the BVal version won't fix it.
> >
> > Looks like it broke with this commit:
> >
> > -
> >
> >>>
> https://github.com/apache/tomee/commit/77bc9450c70326194437a83e10f526c14ed3fa75
> > - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
> >
> >
> > --
> > David Blevins
> > http://twitter.com/dblevins
> > http://www.tomitribe.com
> >
> >> On Aug 5, 2019, at 5:55 AM, Jean-Louis Monteiro <
> > jlmonte...@tomitribe.com> wrote:
> >>
> >> Just looked at it today.
> >> Looks like the build has
> >>
> >> 
> >> org.apache.tomee.patch
> >> bval-jsr
> >> 2.0.2-69c36fa8-1
> >> 
> >> But available from maven central is
> >>
> >>
> >> Should we update to one of those?
> >> Should we go to the official final?
> >>
> >> Can you guys give some hints so I can fix it?
> >>
> >>
> >> --
> >> Jean-Louis Monteiro
> >> http://twitter.com/jlouismonteiro
> >> http://www.tomitribe.com
> >>
> >>
> >> On Sat, Aug 3, 2019 at 2:59 AM David Blevins <
> david.blev...@gmail.com
> 
> > wrote:
> >>> On Aug 2, 2019, at 4:19 PM, David Blevins  >
> > wrote:
> >>>
> >>> We can delete/disable the feature as well.  I don't want to be the
> >>> guy
> > holding up the show.
> >>
> >> Dug in to take this route as it's all around simpler.  It looks,
> > however, the build has been failing since the 12th and it's all the
> JWT
> > code.
> >>
> >> -
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
> >> -
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1137
> >>
> >> I unfortunately don't have time to "shave the yak" so to speak.  I'm
> > writing a Github App to implement checks on the 37 Jakarta EE
> > specifications that all need to go up for vote in the next two weeks
> or
> > there will be no Jakarta EE 8 by CodeOne.  This includes the Bean
> > Validation specification, tck, itself.
> >>
> >> Jean-Louis, looks like this is related to the commit and revert you
> > might have done.  We had a pass on the 26th, which I suspect is right
> > before you did the revert.
> >>
> >> -
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1136
> >>
> >> If you can reinstate the fix, I'll go ahead and disable the fancy
> > JWT/BeanValidation feature.
> >>
> >>
> >> -David
> >>
> >
> >
> >>>
> >>>
>
>

Re: Translate to portuguese: examples/spring-data-proxy-meta

[Cesar Hernandez]

Thanks Daniel,
+1, the contribution is ready to move forward by committers.

El sáb., 3 ago. 2019 a las 8:16, Daniel Dias Dos Santos (<
daniel.dias.analist...@gmail.com>) escribió:

> HI,
>
> I create an PR  = https://github.com/apache/tomee/pull/528  .
>
> Needs review .
>
> thanks .
> --
> Daniel Dias dos Santos
> Java Developer
> SouJava & JCP Member
> GitHub: https://github.com/Daniel-Dos
> Linkedin: www.linkedin.com/in/danieldiasjava
> Twitter: http://twitter.com/danieldiasjava
>
> Em qui, 1 de ago de 2019 às 23:58, Daniel Dias Dos Santos
>  escreveu:
> >
> > I created the JIRA [1] to translate the doc of
> examples/spring-data-proxy-meta
> >
> > Can some of the JIRA admins please assign the ticket to my username =
> > danieldiasjava
> >
> > [1] https://issues.apache.org/jira/browse/TOMEE-2608
> > --
> > Daniel Dias dos Santos
> > Java Developer
> > SouJava & JCP Member
> > GitHub: https://github.com/Daniel-Dos
> > Linkedin: www.linkedin.com/in/danieldiasjava
> > Twitter: http://twitter.com/danieldiasjava
>


-- 
Atentamente:
César Hernández.

Re: Traslation into pt-br of examples/tomee-jms-portability

[Cesar Hernandez]

Thanks Robinson and Daniel,
+1.
@Committers, please move forward this contribution.

El dom., 28 jul. 2019 a las 9:43, Daniel Dias Dos Santos (<
daniel.dias.analist...@gmail.com>) escribió:

> Hello ,
>
>  I reviewed and approved you PR.
> I believe one of the committers can move this forwards.
>
> Thank you .
> --
> Daniel Dias dos Santos
> Java Developer
> SouJava & JCP Member
> GitHub: https://github.com/Daniel-Dos
> Linkedin: www.linkedin.com/in/danieldiasjava
> Twitter: http://twitter.com/danieldiasjava
>
> Em dom, 28 de jul de 2019 às 02:47, Robinson Severo
>  escreveu:
> >
> > Hi folks,
> > i translated into portuguese the examples/datasource-versioning
> > PR:   https://github.com/apache/tomee/pull/526
> > JIRA Ticket:   https://issues.apache.org/jira/browse/TOMEE-2602
> >
> > Needs review, thanks!
>


-- 
Atentamente:
César Hernández.

Re: Traslation into pt-br of examples/concurrency-utils

[Cesar Hernandez]

Thanks Marco and Daniel.
+1.
@Commiters please move forward this contribution.

El jue., 1 ago. 2019 a las 22:21, Marco Ferreira (<
marcoantoniobferre...@gmail.com>) escribió:

> Thanks Daniel!
>
> On Thu, 1 Aug 2019 at 20:27, Daniel Dias Dos Santos <
> daniel.dias.analist...@gmail.com> wrote:
>
> > HI Marco,
> >
> > I review you PR .
> >
> > Thanks for Translate.
> >
> > can some committer take the PR forward
> > --
> > Daniel Dias dos Santos
> > Java Developer
> > SouJava & JCP Member
> > GitHub: https://github.com/Daniel-Dos
> > Linkedin: www.linkedin.com/in/danieldiasjava
> > Twitter: http://twitter.com/danieldiasjava
> >
> > Em sex, 26 de jul de 2019 às 00:48, Marco Ferreira
> >  escreveu:
> > >
> > > Hi folks,
> > > i translated into portuguese the examples/concurrency-utils.
> > > PR: https://github.com/apache/tomee/pull/524
> > > JIRA Ticket: https://issues.apache.org/jira/browse/TOMEE-2581
> > >
> > > Needs review, thanks!
> > >
> > > --
> > > AAte
> > >
> > > Atenciosamente,
> > >
> > > Marco Ferreira
> > > [image: https://]about.me/m.ferreira
> > > <
> >
> https://about.me/m.ferreira?promo=email_sig_source=product_medium=email_sig_campaign=gmail_api
> > >
> >
>
>
> --
> AAte
>
> Atenciosamente,
>
> Marco Ferreira
> [image: https://]about.me/m.ferreira
> <
> https://about.me/m.ferreira?promo=email_sig_source=product_medium=email_sig_campaign=gmail_api
> >
>


-- 
Atentamente:
César Hernández.

Re: PR#521 - Translation of the examples/simple-cdi-interceptor to Portuguese.

[Cesar Hernandez]

Thanks, Grabriel for the PR and Daniel for the review.
+1.

@committers, can you please move forward this contribution?.

El vie., 26 jul. 2019 a las 20:32, Daniel Dias Dos Santos (<
daniel.dias.analist...@gmail.com>) escribió:

> Hello ,
>
> Marco Ferreira and I reviewed and approved you PR.
> I believe one of the committers can move this forwards.
>
> Thank you .
> --
> Daniel Dias dos Santos
> Java Developer
> SouJava & JCP Member
> GitHub: https://github.com/Daniel-Dos
> Linkedin: www.linkedin.com/in/danieldiasjava
> Twitter: http://twitter.com/danieldiasjava
>
> Em qui, 18 de jul de 2019 às 23:44, Gabriel Ferreira
>  escreveu:
> >
> > Hey guys, I opened this pull request:
> > https://github.com/apache/tomee/pull/521
> > about this task https://issues.apache.org/jira/browse/TOMEE-2580
> > Thank you ;)
>


-- 
Atentamente:
César Hernández.

Re: Upgrade BVal to official (not patched) one

[David Blevins]

Hi Thomas,

I pushed 2.0.1 as that's the last version that doesn't have the regression 
BVAL-174.

Once the build passes, would you like the honor to submit a patch to upgrade to 
2.0.3?  The primary thing is we need someone to either delete or fix the 
failing example.  Ideally there would also be an update to its README that 
talks about the change in behavior.

Is that something you'd be willing to contribute?


-- 
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

> On Aug 5, 2019, at 11:16 AM, Thomas Andraschko  
> wrote:
> 
> I would like to release 2.0.3, as it contains some fixes and performance
> boosts, if you are ok with using the official bval
> 
> Jean-Louis Monteiro  schrieb am Mo., 5. Aug.
> 2019, 18:24:
> 
>> Following up on this thread.
>> What version would you recommend?
>> 
>> On Maven central we have
>> https://search.maven.org/search?q=g:org.apache.bval
>> I believe it's 2.0.2 but wanted to double check
>> 
>> 
>> --
>> Jean-Louis Monteiro
>> http://twitter.com/jlouismonteiro
>> http://www.tomitribe.com
>> 
>> 
>> On Mon, Jul 29, 2019 at 10:20 AM Thomas Andraschko <
>> andraschko.tho...@gmail.com> wrote:
>> 
>>> Hi,
>>> 
>>> there were some "possible issues" with bval in the last months,
>> especially:
>>> 
>>> https://issues.apache.org/jira/browse/BVAL-174
>>> (also see https://www.mail-archive.com/dev@bval.apache.org/msg01042.html
>> )
>>> 
>>> and
>>> 
>>> https://issues.apache.org/jira/projects/BVAL/issues/BVAL-175
>>> 
>>> both are no issues from our perspective @bval side (please feel free to
>>> join the discussions there).
>>> 
>>> I would really like to see the bval upgrade for the next milestone or
>> even
>>> the final release.
>>> If you are ok with the upgrade, we would prepare a bval release.
>>> 
>>> It's a big boost in the startup performance and with those changes, we
>>> almost have the same startup time as with 7.x.
>>> 
>>> Best regards,
>>> Thomas
>>> 
>> 

Re: Upgrade BVal to official (not patched) one

[Thomas Andraschko]

I would like to release 2.0.3, as it contains some fixes and performance
boosts, if you are ok with using the official bval

Jean-Louis Monteiro  schrieb am Mo., 5. Aug.
2019, 18:24:

> Following up on this thread.
> What version would you recommend?
>
> On Maven central we have
> https://search.maven.org/search?q=g:org.apache.bval
> I believe it's 2.0.2 but wanted to double check
>
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Mon, Jul 29, 2019 at 10:20 AM Thomas Andraschko <
> andraschko.tho...@gmail.com> wrote:
>
> > Hi,
> >
> > there were some "possible issues" with bval in the last months,
> especially:
> >
> > https://issues.apache.org/jira/browse/BVAL-174
> > (also see https://www.mail-archive.com/dev@bval.apache.org/msg01042.html
> )
> >
> > and
> >
> > https://issues.apache.org/jira/projects/BVAL/issues/BVAL-175
> >
> > both are no issues from our perspective @bval side (please feel free to
> > join the discussions there).
> >
> > I would really like to see the bval upgrade for the next milestone or
> even
> > the final release.
> > If you are ok with the upgrade, we would prepare a bval release.
> >
> > It's a big boost in the startup performance and with those changes, we
> > almost have the same startup time as with 7.x.
> >
> > Best regards,
> > Thomas
> >
>

[GitHub] [tomee] cesarhernandezgt commented on issue #526: TOMEE-2602 - add translate in PT to examples/tomee-jms-portability

[GitBox]

cesarhernandezgt commented on issue #526: TOMEE-2602 - add translate in PT to 
examples/tomee-jms-portability
URL: https://github.com/apache/tomee/pull/526#issuecomment-518342112
 
 
   Thanks, @robinsonvs  for the contribution and @Daniel-Dos for the review!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Wrong m3 bval dep?

[David Blevins]

Build running with the MP-JWT Bean Validation feature removed and stock bval 
library.

 - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1145


-- 
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

> On Aug 5, 2019, at 8:40 AM, Jean-Louis Monteiro  
> wrote:
> 
> Build is back to green
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
> 
> 
> On Mon, Aug 5, 2019 at 3:21 PM Jean-Louis Monteiro 
> wrote:
> 
>> Thanks David.
>> New build ...
>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1143
>> 
>> 
>> --
>> Jean-Louis Monteiro
>> http://twitter.com/jlouismonteiro
>> http://www.tomitribe.com
>> 
>> 
>> On Mon, Aug 5, 2019 at 3:20 PM David Blevins 
>> wrote:
>> 
 On Aug 5, 2019, at 6:14 AM, Jean-Louis Monteiro <
>>> jlmonte...@tomitribe.com> wrote:
 
 I fixed it a while back, but when I reverted last week, I reverted the
>>> fix
 as well.
 Sorry about that, I'll fix now.
>>> 
>>> No apologies necessary.  As the saying goes, the only people who don't
>>> break the build are those who do nothing :)
>>> 
>>> So congratulations is the better sentiment :)
>>> 
>>> 
>>> -David
>>> 
 On Mon, Aug 5, 2019 at 3:12 PM David Blevins 
 wrote:
 
> First step would be to get the build passing again.  There are failures
> which are not related to bean validation.
> 
> Once those are fixed and our build is green again, I'll do the work to
> disable the feature I added that needs a modified BVal.  I hesitate to
>>> do
> it now because the build isn't passing now for unrelated reasons and
> disabling and changing the BVal version won't fix it.
> 
> Looks like it broke with this commit:
> 
> -
> 
>>> https://github.com/apache/tomee/commit/77bc9450c70326194437a83e10f526c14ed3fa75
> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
> 
> 
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
> 
>> On Aug 5, 2019, at 5:55 AM, Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>> 
>> Just looked at it today.
>> Looks like the build has
>> 
>> 
>> org.apache.tomee.patch
>> bval-jsr
>> 2.0.2-69c36fa8-1
>> 
>> But available from maven central is
>> 
>> 
>> Should we update to one of those?
>> Should we go to the official final?
>> 
>> Can you guys give some hints so I can fix it?
>> 
>> 
>> --
>> Jean-Louis Monteiro
>> http://twitter.com/jlouismonteiro
>> http://www.tomitribe.com
>> 
>> 
>> On Sat, Aug 3, 2019 at 2:59 AM David Blevins >>> 
> wrote:
>>> On Aug 2, 2019, at 4:19 PM, David Blevins 
> wrote:
>>> 
>>> We can delete/disable the feature as well.  I don't want to be the
>>> guy
> holding up the show.
>> 
>> Dug in to take this route as it's all around simpler.  It looks,
> however, the build has been failing since the 12th and it's all the JWT
> code.
>> 
>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1137
>> 
>> I unfortunately don't have time to "shave the yak" so to speak.  I'm
> writing a Github App to implement checks on the 37 Jakarta EE
> specifications that all need to go up for vote in the next two weeks or
> there will be no Jakarta EE 8 by CodeOne.  This includes the Bean
> Validation specification, tck, itself.
>> 
>> Jean-Louis, looks like this is related to the commit and revert you
> might have done.  We had a pass on the 26th, which I suspect is right
> before you did the revert.
>> 
>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1136
>> 
>> If you can reinstate the fix, I'll go ahead and disable the fancy
> JWT/BeanValidation feature.
>> 
>> 
>> -David
>> 
> 
> 
>>> 
>>> 

Re: Traslation into pt-br of examples/datasource-versioning

[Cesar Hernandez]

Thanks, Robinson for your first contribution to the Apache TomEE project!

I assigned the JIRA ticket to you, no further action from your side needs
it at this stage.
But feel free to keep updating the mailing list with work in progress,
ideas, questions, etc. Happy to see how the community keeps growing.
Thanks, Marco and Daniel for the Portugues PR review.

Can some of the committer please move forward this contribution?

El sáb., 27 jul. 2019 a las 3:00, Marco Ferreira (<
marcoantoniobferre...@gmail.com>) escribió:

> Hi Robinson,
> thanks for your contribution.
> Some commiter can move this forwards? Thanks!
>
> On Fri, 26 Jul 2019 at 08:35, Robinson Severo 
> wrote:
>
> > Hi folks,
> > i translated into portuguese the examples/datasource-versioning
> > PR:  https://github.com/apache/tomee/pull/525
> > JIRA Ticket:  https://issues.apache.org/jira/browse/TOMEE-2583
> >
> > Needs review, thanks!
> >
> > Robinson Severo
> >
>
>
> --
> AAte
>
> Atenciosamente,
>
> Marco Ferreira
> [image: https://]about.me/m.ferreira
> <
> https://about.me/m.ferreira?promo=email_sig_source=product_medium=email_sig_campaign=gmail_api
> >
>


-- 
Atentamente:
César Hernández.

Re: Assing to TOMEE-2457

[Cesar Hernandez]

Thanks, Richard for the update.
I closed the duplicated: https://issues.apache.org/jira/browse/TOMEE-2457
And assigned: https://issues.apache.org/jira/browse/TOMEE-2496 to you
Gabriel.


El lun., 5 ago. 2019 a las 11:13, Richard Monson-Haefel (<
monsonhae...@gmail.com>) escribió:

> It's not unassigned. So please take it over if you want. I didn't have time
> to work on it.
>
> On Tue, Jul 16, 2019 at 4:39 AM Gabriel Ferreira 
> wrote:
>
> > Sorry I just noticed that there is an equal task here
> > https://issues.apache.org/jira/browse/TOMEE-2496 attributed to Richard
> > Monson-Haefel.
> >
> > I will search for another :)
> >
> > Em ter, 16 de jul de 2019 às 06:35, Gabriel Ferreira <
> gabree...@gmail.com>
> > escreveu:
> >
> > > Hey guys,
> > > I have worked on translating the examples.
> > > So I thought about trying to solve some code problem.
> > > Can someone assign me to this task ?
> > > https://issues.apache.org/jira/browse/TOMEE-2457
> > >
> > > thank you
> > >
> > >
> > >
> >
>
>
> --
> Richard Monson-Haefel
> https://twitter.com/rmonson
> https://www.linkedin.com/in/monsonhaefel/
>


-- 
Atentamente:
César Hernández.

[GitHub] [tomee] cesarhernandezgt commented on issue #525: TOMEE-2583 - add translate in PT to examples/datasource-versioning

[GitBox]

cesarhernandezgt commented on issue #525: TOMEE-2583 - add translate in PT to 
examples/datasource-versioning
URL: https://github.com/apache/tomee/pull/525#issuecomment-518323492
 
 
   Nice job @robinsonvs 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Assing to TOMEE-2457

[Richard Monson-Haefel]

It's not unassigned. So please take it over if you want. I didn't have time
to work on it.

On Tue, Jul 16, 2019 at 4:39 AM Gabriel Ferreira 
wrote:

> Sorry I just noticed that there is an equal task here
> https://issues.apache.org/jira/browse/TOMEE-2496 attributed to Richard
> Monson-Haefel.
>
> I will search for another :)
>
> Em ter, 16 de jul de 2019 às 06:35, Gabriel Ferreira 
> escreveu:
>
> > Hey guys,
> > I have worked on translating the examples.
> > So I thought about trying to solve some code problem.
> > Can someone assign me to this task ?
> > https://issues.apache.org/jira/browse/TOMEE-2457
> >
> > thank you
> >
> >
> >
>


-- 
Richard Monson-Haefel
https://twitter.com/rmonson
https://www.linkedin.com/in/monsonhaefel/

PR for TOMEE-1395

[David Salter]

Hi,

I’ve noticed that TOMEE-1395 has an old patch against it that hasn’t been 
merged. This is in the simple-mdb-with-descriptor example.

As this is an old patch, I’ve created a PR that will fix the package name.

https://github.com/apache/tomee/pull/531 


Thanks.

David.

[GitHub] [tomee] davidsalter opened a new pull request #531: TOMEE-1395 Invalid package on simple-mdb-with-descriptor

[GitBox]

davidsalter opened a new pull request #531: TOMEE-1395 Invalid package on 
simple-mdb-with-descriptor
URL: https://github.com/apache/tomee/pull/531
 
 
   Changed the package name of the test to correspond to the directory
   structure.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Wrong m3 bval dep?

[Jean-Louis Monteiro]

This repo is no more available btw
https://repository.apache.org/content/repositories/orgapachetomee-1134/

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Aug 5, 2019 at 5:40 PM Jean-Louis Monteiro 
wrote:

> Build is back to green
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Mon, Aug 5, 2019 at 3:21 PM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
>> Thanks David.
>> New build ...
>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1143
>>
>>
>> --
>> Jean-Louis Monteiro
>> http://twitter.com/jlouismonteiro
>> http://www.tomitribe.com
>>
>>
>> On Mon, Aug 5, 2019 at 3:20 PM David Blevins 
>> wrote:
>>
>>> > On Aug 5, 2019, at 6:14 AM, Jean-Louis Monteiro <
>>> jlmonte...@tomitribe.com> wrote:
>>> >
>>> > I fixed it a while back, but when I reverted last week, I reverted the
>>> fix
>>> > as well.
>>> > Sorry about that, I'll fix now.
>>>
>>> No apologies necessary.  As the saying goes, the only people who don't
>>> break the build are those who do nothing :)
>>>
>>> So congratulations is the better sentiment :)
>>>
>>>
>>> -David
>>>
>>> > On Mon, Aug 5, 2019 at 3:12 PM David Blevins 
>>> > wrote:
>>> >
>>> >> First step would be to get the build passing again.  There are
>>> failures
>>> >> which are not related to bean validation.
>>> >>
>>> >> Once those are fixed and our build is green again, I'll do the work to
>>> >> disable the feature I added that needs a modified BVal.  I hesitate
>>> to do
>>> >> it now because the build isn't passing now for unrelated reasons and
>>> >> disabling and changing the BVal version won't fix it.
>>> >>
>>> >> Looks like it broke with this commit:
>>> >>
>>> >> -
>>> >>
>>> https://github.com/apache/tomee/commit/77bc9450c70326194437a83e10f526c14ed3fa75
>>> >> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
>>> >>
>>> >>
>>> >> --
>>> >> David Blevins
>>> >> http://twitter.com/dblevins
>>> >> http://www.tomitribe.com
>>> >>
>>> >>> On Aug 5, 2019, at 5:55 AM, Jean-Louis Monteiro <
>>> >> jlmonte...@tomitribe.com> wrote:
>>> >>>
>>> >>> Just looked at it today.
>>> >>> Looks like the build has
>>> >>>
>>> >>> 
>>> >>>  org.apache.tomee.patch
>>> >>>  bval-jsr
>>> >>>  2.0.2-69c36fa8-1
>>> >>> 
>>> >>> But available from maven central is
>>> >>>
>>> >>>
>>> >>> Should we update to one of those?
>>> >>> Should we go to the official final?
>>> >>>
>>> >>> Can you guys give some hints so I can fix it?
>>> >>>
>>> >>>
>>> >>> --
>>> >>> Jean-Louis Monteiro
>>> >>> http://twitter.com/jlouismonteiro
>>> >>> http://www.tomitribe.com
>>> >>>
>>> >>>
>>> >>> On Sat, Aug 3, 2019 at 2:59 AM David Blevins <
>>> david.blev...@gmail.com>
>>> >> wrote:
>>>  On Aug 2, 2019, at 4:19 PM, David Blevins 
>>> >> wrote:
>>> 
>>>  We can delete/disable the feature as well.  I don't want to be the
>>> guy
>>> >> holding up the show.
>>> >>>
>>> >>> Dug in to take this route as it's all around simpler.  It looks,
>>> >> however, the build has been failing since the 12th and it's all the
>>> JWT
>>> >> code.
>>> >>>
>>> >>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
>>> >>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1137
>>> >>>
>>> >>> I unfortunately don't have time to "shave the yak" so to speak.  I'm
>>> >> writing a Github App to implement checks on the 37 Jakarta EE
>>> >> specifications that all need to go up for vote in the next two weeks
>>> or
>>> >> there will be no Jakarta EE 8 by CodeOne.  This includes the Bean
>>> >> Validation specification, tck, itself.
>>> >>>
>>> >>> Jean-Louis, looks like this is related to the commit and revert you
>>> >> might have done.  We had a pass on the 26th, which I suspect is right
>>> >> before you did the revert.
>>> >>>
>>> >>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1136
>>> >>>
>>> >>> If you can reinstate the fix, I'll go ahead and disable the fancy
>>> >> JWT/BeanValidation feature.
>>> >>>
>>> >>>
>>> >>> -David
>>> >>>
>>> >>
>>> >>
>>>
>>>

Re: Upgrade BVal to official (not patched) one

[Jean-Louis Monteiro]

Following up on this thread.
What version would you recommend?

On Maven central we have https://search.maven.org/search?q=g:org.apache.bval
I believe it's 2.0.2 but wanted to double check


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Jul 29, 2019 at 10:20 AM Thomas Andraschko <
andraschko.tho...@gmail.com> wrote:

> Hi,
>
> there were some "possible issues" with bval in the last months, especially:
>
> https://issues.apache.org/jira/browse/BVAL-174
> (also see https://www.mail-archive.com/dev@bval.apache.org/msg01042.html)
>
> and
>
> https://issues.apache.org/jira/projects/BVAL/issues/BVAL-175
>
> both are no issues from our perspective @bval side (please feel free to
> join the discussions there).
>
> I would really like to see the bval upgrade for the next milestone or even
> the final release.
> If you are ok with the upgrade, we would prepare a bval release.
>
> It's a big boost in the startup performance and with those changes, we
> almost have the same startup time as with 7.x.
>
> Best regards,
> Thomas
>

TomEE 8 / Jakarta EE 8 / Derby No Class Def Found

[Jean-Louis Monteiro]

Hi,

I had a look at https://issues.apache.org/jira/browse/TOMEE-2604
I pushed a fix.

I just ran a TomEE deploy and I'll run a new TCK run whenever possibe
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com

Re: Wrong m3 bval dep?

[Jean-Louis Monteiro]

Build is back to green
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Aug 5, 2019 at 3:21 PM Jean-Louis Monteiro 
wrote:

> Thanks David.
> New build ...
> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1143
>
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Mon, Aug 5, 2019 at 3:20 PM David Blevins 
> wrote:
>
>> > On Aug 5, 2019, at 6:14 AM, Jean-Louis Monteiro <
>> jlmonte...@tomitribe.com> wrote:
>> >
>> > I fixed it a while back, but when I reverted last week, I reverted the
>> fix
>> > as well.
>> > Sorry about that, I'll fix now.
>>
>> No apologies necessary.  As the saying goes, the only people who don't
>> break the build are those who do nothing :)
>>
>> So congratulations is the better sentiment :)
>>
>>
>> -David
>>
>> > On Mon, Aug 5, 2019 at 3:12 PM David Blevins 
>> > wrote:
>> >
>> >> First step would be to get the build passing again.  There are failures
>> >> which are not related to bean validation.
>> >>
>> >> Once those are fixed and our build is green again, I'll do the work to
>> >> disable the feature I added that needs a modified BVal.  I hesitate to
>> do
>> >> it now because the build isn't passing now for unrelated reasons and
>> >> disabling and changing the BVal version won't fix it.
>> >>
>> >> Looks like it broke with this commit:
>> >>
>> >> -
>> >>
>> https://github.com/apache/tomee/commit/77bc9450c70326194437a83e10f526c14ed3fa75
>> >> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
>> >>
>> >>
>> >> --
>> >> David Blevins
>> >> http://twitter.com/dblevins
>> >> http://www.tomitribe.com
>> >>
>> >>> On Aug 5, 2019, at 5:55 AM, Jean-Louis Monteiro <
>> >> jlmonte...@tomitribe.com> wrote:
>> >>>
>> >>> Just looked at it today.
>> >>> Looks like the build has
>> >>>
>> >>> 
>> >>>  org.apache.tomee.patch
>> >>>  bval-jsr
>> >>>  2.0.2-69c36fa8-1
>> >>> 
>> >>> But available from maven central is
>> >>>
>> >>>
>> >>> Should we update to one of those?
>> >>> Should we go to the official final?
>> >>>
>> >>> Can you guys give some hints so I can fix it?
>> >>>
>> >>>
>> >>> --
>> >>> Jean-Louis Monteiro
>> >>> http://twitter.com/jlouismonteiro
>> >>> http://www.tomitribe.com
>> >>>
>> >>>
>> >>> On Sat, Aug 3, 2019 at 2:59 AM David Blevins > >
>> >> wrote:
>>  On Aug 2, 2019, at 4:19 PM, David Blevins 
>> >> wrote:
>> 
>>  We can delete/disable the feature as well.  I don't want to be the
>> guy
>> >> holding up the show.
>> >>>
>> >>> Dug in to take this route as it's all around simpler.  It looks,
>> >> however, the build has been failing since the 12th and it's all the JWT
>> >> code.
>> >>>
>> >>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
>> >>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1137
>> >>>
>> >>> I unfortunately don't have time to "shave the yak" so to speak.  I'm
>> >> writing a Github App to implement checks on the 37 Jakarta EE
>> >> specifications that all need to go up for vote in the next two weeks or
>> >> there will be no Jakarta EE 8 by CodeOne.  This includes the Bean
>> >> Validation specification, tck, itself.
>> >>>
>> >>> Jean-Louis, looks like this is related to the commit and revert you
>> >> might have done.  We had a pass on the 26th, which I suspect is right
>> >> before you did the revert.
>> >>>
>> >>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1136
>> >>>
>> >>> If you can reinstate the fix, I'll go ahead and disable the fancy
>> >> JWT/BeanValidation feature.
>> >>>
>> >>>
>> >>> -David
>> >>>
>> >>
>> >>
>>
>>

Re: JKS Keystore ?

[David Salter]

Hi,

I’ve created a PR for this:

https://github.com/apache/tomee/pull/530 


Let me know if it looks ok.

Thanks.

David.


> On 5 Aug 2019, at 14:31, Jonathan Gallimore  
> wrote:
> 
> Certainly sounds good - can't see any reason why that would be an issue.
> Can you send a PR if you haven't already?
> 
> Cheers
> 
> Jon
> 
> On Mon, Aug 5, 2019 at 1:52 PM David Salter 
> wrote:
> 
>> Hi,
>> 
>> I’m looking at https://issues.apache.org/jira/browse/TOMEE-2586 <
>> https://issues.apache.org/jira/browse/TOMEE-2586> which is to make one of
>> the samples work on Java 11.
>> 
>> I’ve got a fix for this on Java 11 by specifying the keystore type as
>> JKS.  Is this ok for this example given that its a complete Java example?
>> When using JKS, the sample works correctly on Java 8 and Java 11.
>> 
>> Ta.
>> 
>> David.

[GitHub] [tomee] davidsalter opened a new pull request #530: TOMEE-2586 Fix examples/webservices-ws-security to work on Java 11

[GitBox]

davidsalter opened a new pull request #530: TOMEE-2586 Fix 
examples/webservices-ws-security to work on Java 11
URL: https://github.com/apache/tomee/pull/530
 
 
   Changed the keystore to be in JKS format so it works with both Java 8
   and Java 11.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5

[Cees Bos]

Hi Jon,

Thanks for push.
Locally I am not able to reproduce the issue we saw earlier.

I tried a local build with the latest changes, that looks good (but as said I 
was not able to produce the issue).

I found these 2 items while look similar:
https://stackoverflow.com/questions/10525231/maven-snapshot-jar-file-names-not-consistent-using-maven-assembly-in-manifest-fi?noredirect=1=1
https://stackoverflow.com/questions/2516860/maven-how-to-create-assembly-with-snapshot-artifacts-without-timestamps-file-na

Once a new SNAPSHOT build is available I will validate that.
Otherwise we might have to look at the option mentioned in the stackoverflow 
links, that provides a possible solution for all situations, not only javamail 
as implemented now.

With regards,
Cees



From: Jonathan Gallimore 
Sent: Monday, August 5, 2019 15:30
To: dev@tomee.apache.org 
Subject: Re: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5

Just tried pushing a patch, which *seemed* to work ok here. Can you give it
a try?

Cheers

Jon

On Mon, Aug 5, 2019 at 10:07 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:

> Grrr
>
> No idea what Maven is doing.
> Thanks for having a look again. I tried locally and it was working fine.
>
> --
> Jean-Louis Monteiro
> https://urldefense.proofpoint.com/v2/url?u=http-3A__twitter.com_jlouismonteiro=DwIFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=bMuYy3fZLQOHBDPs3K_IOSL_maTcwANPuDjTLdZllQQ=f3sSyQCfYgt1CafvKOqZkr5GsmU6XOv72kzxVO3quHI=
> https://urldefense.proofpoint.com/v2/url?u=http-3A__www.tomitribe.com=DwIFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=bMuYy3fZLQOHBDPs3K_IOSL_maTcwANPuDjTLdZllQQ=kA7mES8ADNCmmKWK_wCghVYW_ghgNxolPmoQBjZ9U2A=
>
>
> On Mon, Aug 5, 2019 at 10:51 AM Cees Bos  wrote:
>
> > Hi Jean-Louis,
> >
> >
> >
> > I downloaded
> >
> https://urldefense.proofpoint.com/v2/url?u=https-3A__repository.apache.org_content_repositories_snapshots_org_apache_tomee_apache-2Dtomee_8.0.0-2DSNAPSHOT_apache-2Dtomee-2D8.0.0-2D20190805.041822-2D288-2Dplus.tar.gz=DwIFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=bMuYy3fZLQOHBDPs3K_IOSL_maTcwANPuDjTLdZllQQ=uCSk0KoLald4ESV2rHpstS1D9gOdmx3x25FJomyXU7Q=
> > (build on August 5th).
> >
> > That is still having duplicate jars for mail:
> >
> >
> >
> >- geronimo-javamail_1.5_mail-1.0.0-20190802.101725-2.jar
> >- geronimo-javamail_1.5_mail-1.0.0-SNAPSHOT.jar
> >
> >
> >
> > Same issue is also there for the spec jar:
> >
> >- geronimo-javamail_1.5_spec-1.0.0-20190802.101602-6.jar
> >- geronimo-javamail_1.5_spec-1.0.0-SNAPSHOT.jar
> >
> >
> > I loaded the TomEE project in IntelliJ. IntelliJ transforms SNAPSHOT in
> to
> > a version jar as well.  (see screenshot attached)
> > I don't know all details of Maven and the just plugins, but it looks like
> > it uses a version jar at the moment it resolves SNAPSHOT.
> > During the creation of deliverable one of the 2 jars has to be skipped,
> to
> > ship only 1 jar, I think.
> >
> >
> >
> > With kind regards,
> > Cees
> >
> >
> >
> > *From:* Jean-Louis Monteiro 
> > *Sent:* vrijdag 2 augustus 2019 15:59
> > *To:* Cees Bos 
> > *Cc:* dev@tomee.apache.org; d...@geronimo.apache.org
> > *Subject:* Re: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5
> >
> >
> >
> > Hi Cees,
> >
> >
> >
> > I just pushed some changes to fix this issue and also did a deploy of a
> > new set of snapshots.
> >
> > I just ran a new build with a deploy at the end and I'll check whenever
> > it's done.
> >
> >
> >
> > I would appreciate if you can have a look at the drop and give it a try
> if
> > you can.
> >
> > I'll be running some TCK later tonight and try to follow up over here.
> >
> >
> >
> >
> > --
> >
> > Jean-Louis Monteiro
> > https://urldefense.proofpoint.com/v2/url?u=http-3A__twitter.com_jlouismonteiro=DwIFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=bMuYy3fZLQOHBDPs3K_IOSL_maTcwANPuDjTLdZllQQ=f3sSyQCfYgt1CafvKOqZkr5GsmU6XOv72kzxVO3quHI=
> > <
> https://urldefense.proofpoint.com/v2/url?u=http-3A__twitter.com_jlouismonteiro=DwMFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JywqLxwqoQuFD0gDhriOxWv6idVb46D_N1lgi3bcaBQ=UORE2qtZmk8xhW8CIkH_9mnz5QCpkCDP8MmYBshpR4Q=
> >
> > https://urldefense.proofpoint.com/v2/url?u=http-3A__www.tomitribe.com=DwIFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=bMuYy3fZLQOHBDPs3K_IOSL_maTcwANPuDjTLdZllQQ=kA7mES8ADNCmmKWK_wCghVYW_ghgNxolPmoQBjZ9U2A=
> > <
> https://urldefense.proofpoint.com/v2/url?u=http-3A__www.tomitribe.com_=DwMFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JywqLxwqoQuFD0gDhriOxWv6idVb46D_N1lgi3bcaBQ=pLS-SKz5xFpARR9wdELuhf8Bbv7_D-4kZVHhdMOQ4NI=
> >
> >
> >
> >
> >
> >
> > On Fri, Aug 2, 2019 at 12:13 PM Jean-Louis Monteiro <
> > jlmonte...@tomitribe.com> wrote:
> >
> > Hi,
> >
> >
> >
> > First of, thanks for the feedback and trying it.
> >
> > I ran a build and 

Re: JKS Keystore ?

[David Salter]

Thanks,

I’ll get the PR completed now.  Can you assign TOMEE-2586 to me ?

Thanks.

David.

> On 5 Aug 2019, at 14:31, Jonathan Gallimore  
> wrote:
> 
> Certainly sounds good - can't see any reason why that would be an issue.
> Can you send a PR if you haven't already?
> 
> Cheers
> 
> Jon
> 
> On Mon, Aug 5, 2019 at 1:52 PM David Salter 
> wrote:
> 
>> Hi,
>> 
>> I’m looking at https://issues.apache.org/jira/browse/TOMEE-2586 <
>> https://issues.apache.org/jira/browse/TOMEE-2586> which is to make one of
>> the samples work on Java 11.
>> 
>> I’ve got a fix for this on Java 11 by specifying the keystore type as
>> JKS.  Is this ok for this example given that its a complete Java example?
>> When using JKS, the sample works correctly on Java 8 and Java 11.
>> 
>> Ta.
>> 
>> David.

Re: JKS Keystore ?

[Jonathan Gallimore]

Certainly sounds good - can't see any reason why that would be an issue.
Can you send a PR if you haven't already?

Cheers

Jon

On Mon, Aug 5, 2019 at 1:52 PM David Salter 
wrote:

> Hi,
>
> I’m looking at https://issues.apache.org/jira/browse/TOMEE-2586 <
> https://issues.apache.org/jira/browse/TOMEE-2586> which is to make one of
> the samples work on Java 11.
>
> I’ve got a fix for this on Java 11 by specifying the keystore type as
> JKS.  Is this ok for this example given that its a complete Java example?
> When using JKS, the sample works correctly on Java 8 and Java 11.
>
> Ta.
>
> David.

Re: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5

[Jonathan Gallimore]

Just tried pushing a patch, which *seemed* to work ok here. Can you give it
a try?

Cheers

Jon

On Mon, Aug 5, 2019 at 10:07 AM Jean-Louis Monteiro <
jlmonte...@tomitribe.com> wrote:

> Grrr
>
> No idea what Maven is doing.
> Thanks for having a look again. I tried locally and it was working fine.
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Mon, Aug 5, 2019 at 10:51 AM Cees Bos  wrote:
>
> > Hi Jean-Louis,
> >
> >
> >
> > I downloaded
> >
> https://repository.apache.org/content/repositories/snapshots/org/apache/tomee/apache-tomee/8.0.0-SNAPSHOT/apache-tomee-8.0.0-20190805.041822-288-plus.tar.gz
> > (build on August 5th).
> >
> > That is still having duplicate jars for mail:
> >
> >
> >
> >- geronimo-javamail_1.5_mail-1.0.0-20190802.101725-2.jar
> >- geronimo-javamail_1.5_mail-1.0.0-SNAPSHOT.jar
> >
> >
> >
> > Same issue is also there for the spec jar:
> >
> >- geronimo-javamail_1.5_spec-1.0.0-20190802.101602-6.jar
> >- geronimo-javamail_1.5_spec-1.0.0-SNAPSHOT.jar
> >
> >
> > I loaded the TomEE project in IntelliJ. IntelliJ transforms SNAPSHOT in
> to
> > a version jar as well.  (see screenshot attached)
> > I don't know all details of Maven and the just plugins, but it looks like
> > it uses a version jar at the moment it resolves SNAPSHOT.
> > During the creation of deliverable one of the 2 jars has to be skipped,
> to
> > ship only 1 jar, I think.
> >
> >
> >
> > With kind regards,
> > Cees
> >
> >
> >
> > *From:* Jean-Louis Monteiro 
> > *Sent:* vrijdag 2 augustus 2019 15:59
> > *To:* Cees Bos 
> > *Cc:* dev@tomee.apache.org; d...@geronimo.apache.org
> > *Subject:* Re: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5
> >
> >
> >
> > Hi Cees,
> >
> >
> >
> > I just pushed some changes to fix this issue and also did a deploy of a
> > new set of snapshots.
> >
> > I just ran a new build with a deploy at the end and I'll check whenever
> > it's done.
> >
> >
> >
> > I would appreciate if you can have a look at the drop and give it a try
> if
> > you can.
> >
> > I'll be running some TCK later tonight and try to follow up over here.
> >
> >
> >
> >
> > --
> >
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > <
> https://urldefense.proofpoint.com/v2/url?u=http-3A__twitter.com_jlouismonteiro=DwMFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JywqLxwqoQuFD0gDhriOxWv6idVb46D_N1lgi3bcaBQ=UORE2qtZmk8xhW8CIkH_9mnz5QCpkCDP8MmYBshpR4Q=
> >
> > http://www.tomitribe.com
> > <
> https://urldefense.proofpoint.com/v2/url?u=http-3A__www.tomitribe.com_=DwMFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JywqLxwqoQuFD0gDhriOxWv6idVb46D_N1lgi3bcaBQ=pLS-SKz5xFpARR9wdELuhf8Bbv7_D-4kZVHhdMOQ4NI=
> >
> >
> >
> >
> >
> >
> > On Fri, Aug 2, 2019 at 12:13 PM Jean-Louis Monteiro <
> > jlmonte...@tomitribe.com> wrote:
> >
> > Hi,
> >
> >
> >
> > First of, thanks for the feedback and trying it.
> >
> > I ran a build and deploy this morning, but did not get a chance to check
> > it.
> >
> >
> >
> > I'll investigate and see why Maven is pulling the timestamp version + the
> > SNAPSHOT version.
> >
> >
> >
> > JLouis
> >
> >
> > --
> >
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > <
> https://urldefense.proofpoint.com/v2/url?u=http-3A__twitter.com_jlouismonteiro=DwMFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JywqLxwqoQuFD0gDhriOxWv6idVb46D_N1lgi3bcaBQ=UORE2qtZmk8xhW8CIkH_9mnz5QCpkCDP8MmYBshpR4Q=
> >
> > http://www.tomitribe.com
> > <
> https://urldefense.proofpoint.com/v2/url?u=http-3A__www.tomitribe.com_=DwMFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JywqLxwqoQuFD0gDhriOxWv6idVb46D_N1lgi3bcaBQ=pLS-SKz5xFpARR9wdELuhf8Bbv7_D-4kZVHhdMOQ4NI=
> >
> >
> >
> >
> >
> >
> > On Fri, Aug 2, 2019 at 12:06 PM Cees Bos  wrote:
> >
> > Hi Jean-Louis,
> >
> > In the latest TomEE 8 SNAPSHOT there are 2 jars in the zip:
> >
> >
> https://repository.apache.org/content/repositories/snapshots/org/apache/tomee/apache-tomee/8.0.0-SNAPSHOT/apache-tomee-8.0.0-20190802.094733-284-plus.tar.gz
> > <
> https://urldefense.proofpoint.com/v2/url?u=https-3A__repository.apache.org_content_repositories_snapshots_org_apache_tomee_apache-2Dtomee_8.0.0-2DSNAPSHOT_apache-2Dtomee-2D8.0.0-2D20190802.094733-2D284-2Dplus.tar.gz=DwMFaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JywqLxwqoQuFD0gDhriOxWv6idVb46D_N1lgi3bcaBQ=JBz9KFiZlrplq1Kr7IVZnajWx9VkxSTsR91_f8gWMzA=
> >
> >
> > lib/geronimo-javamail_1.5_mail-1.0.0-201908.12351.jar
> > lib/geronimo-javamail_1.5_mail-1.0.0-SNAPSHOT.jar
> >
> > Due to that our custom code fails, as it expects only 1 jar to see if we
> > do a search on ' geronimo-javamail_1.5_mail*'.
> >
> > Is it intended that we have 2 same jars in the TomEE zip now (see
> > attachment/screenshot)?
> >
> > With kind regards,
> > Cees
> >
> > -Original Message-
> > From: Jean-Louis Monteiro 
> > Sent: donderdag 1 augustus 2019 

Re: Wrong m3 bval dep?

[Jean-Louis Monteiro]

Thanks David.
New build ...
https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1143


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Aug 5, 2019 at 3:20 PM David Blevins  wrote:

> > On Aug 5, 2019, at 6:14 AM, Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
> >
> > I fixed it a while back, but when I reverted last week, I reverted the
> fix
> > as well.
> > Sorry about that, I'll fix now.
>
> No apologies necessary.  As the saying goes, the only people who don't
> break the build are those who do nothing :)
>
> So congratulations is the better sentiment :)
>
>
> -David
>
> > On Mon, Aug 5, 2019 at 3:12 PM David Blevins 
> > wrote:
> >
> >> First step would be to get the build passing again.  There are failures
> >> which are not related to bean validation.
> >>
> >> Once those are fixed and our build is green again, I'll do the work to
> >> disable the feature I added that needs a modified BVal.  I hesitate to
> do
> >> it now because the build isn't passing now for unrelated reasons and
> >> disabling and changing the BVal version won't fix it.
> >>
> >> Looks like it broke with this commit:
> >>
> >> -
> >>
> https://github.com/apache/tomee/commit/77bc9450c70326194437a83e10f526c14ed3fa75
> >> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
> >>
> >>
> >> --
> >> David Blevins
> >> http://twitter.com/dblevins
> >> http://www.tomitribe.com
> >>
> >>> On Aug 5, 2019, at 5:55 AM, Jean-Louis Monteiro <
> >> jlmonte...@tomitribe.com> wrote:
> >>>
> >>> Just looked at it today.
> >>> Looks like the build has
> >>>
> >>> 
> >>>  org.apache.tomee.patch
> >>>  bval-jsr
> >>>  2.0.2-69c36fa8-1
> >>> 
> >>> But available from maven central is
> >>>
> >>>
> >>> Should we update to one of those?
> >>> Should we go to the official final?
> >>>
> >>> Can you guys give some hints so I can fix it?
> >>>
> >>>
> >>> --
> >>> Jean-Louis Monteiro
> >>> http://twitter.com/jlouismonteiro
> >>> http://www.tomitribe.com
> >>>
> >>>
> >>> On Sat, Aug 3, 2019 at 2:59 AM David Blevins 
> >> wrote:
>  On Aug 2, 2019, at 4:19 PM, David Blevins 
> >> wrote:
> 
>  We can delete/disable the feature as well.  I don't want to be the guy
> >> holding up the show.
> >>>
> >>> Dug in to take this route as it's all around simpler.  It looks,
> >> however, the build has been failing since the 12th and it's all the JWT
> >> code.
> >>>
> >>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
> >>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1137
> >>>
> >>> I unfortunately don't have time to "shave the yak" so to speak.  I'm
> >> writing a Github App to implement checks on the 37 Jakarta EE
> >> specifications that all need to go up for vote in the next two weeks or
> >> there will be no Jakarta EE 8 by CodeOne.  This includes the Bean
> >> Validation specification, tck, itself.
> >>>
> >>> Jean-Louis, looks like this is related to the commit and revert you
> >> might have done.  We had a pass on the 26th, which I suspect is right
> >> before you did the revert.
> >>>
> >>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1136
> >>>
> >>> If you can reinstate the fix, I'll go ahead and disable the fancy
> >> JWT/BeanValidation feature.
> >>>
> >>>
> >>> -David
> >>>
> >>
> >>
>
>

Re: Wrong m3 bval dep?

[David Blevins]

> On Aug 5, 2019, at 6:14 AM, Jean-Louis Monteiro  
> wrote:
> 
> I fixed it a while back, but when I reverted last week, I reverted the fix
> as well.
> Sorry about that, I'll fix now.

No apologies necessary.  As the saying goes, the only people who don't break 
the build are those who do nothing :)

So congratulations is the better sentiment :)


-David

> On Mon, Aug 5, 2019 at 3:12 PM David Blevins 
> wrote:
> 
>> First step would be to get the build passing again.  There are failures
>> which are not related to bean validation.
>> 
>> Once those are fixed and our build is green again, I'll do the work to
>> disable the feature I added that needs a modified BVal.  I hesitate to do
>> it now because the build isn't passing now for unrelated reasons and
>> disabling and changing the BVal version won't fix it.
>> 
>> Looks like it broke with this commit:
>> 
>> -
>> https://github.com/apache/tomee/commit/77bc9450c70326194437a83e10f526c14ed3fa75
>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
>> 
>> 
>> --
>> David Blevins
>> http://twitter.com/dblevins
>> http://www.tomitribe.com
>> 
>>> On Aug 5, 2019, at 5:55 AM, Jean-Louis Monteiro <
>> jlmonte...@tomitribe.com> wrote:
>>> 
>>> Just looked at it today.
>>> Looks like the build has
>>> 
>>> 
>>>  org.apache.tomee.patch
>>>  bval-jsr
>>>  2.0.2-69c36fa8-1
>>> 
>>> But available from maven central is
>>> 
>>> 
>>> Should we update to one of those?
>>> Should we go to the official final?
>>> 
>>> Can you guys give some hints so I can fix it?
>>> 
>>> 
>>> --
>>> Jean-Louis Monteiro
>>> http://twitter.com/jlouismonteiro
>>> http://www.tomitribe.com
>>> 
>>> 
>>> On Sat, Aug 3, 2019 at 2:59 AM David Blevins 
>> wrote:
 On Aug 2, 2019, at 4:19 PM, David Blevins 
>> wrote:
 
 We can delete/disable the feature as well.  I don't want to be the guy
>> holding up the show.
>>> 
>>> Dug in to take this route as it's all around simpler.  It looks,
>> however, the build has been failing since the 12th and it's all the JWT
>> code.
>>> 
>>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
>>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1137
>>> 
>>> I unfortunately don't have time to "shave the yak" so to speak.  I'm
>> writing a Github App to implement checks on the 37 Jakarta EE
>> specifications that all need to go up for vote in the next two weeks or
>> there will be no Jakarta EE 8 by CodeOne.  This includes the Bean
>> Validation specification, tck, itself.
>>> 
>>> Jean-Louis, looks like this is related to the commit and revert you
>> might have done.  We had a pass on the 26th, which I suspect is right
>> before you did the revert.
>>> 
>>> - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1136
>>> 
>>> If you can reinstate the fix, I'll go ahead and disable the fancy
>> JWT/BeanValidation feature.
>>> 
>>> 
>>> -David
>>> 
>> 
>> 

Re: Wrong m3 bval dep?

[Jean-Louis Monteiro]

Pushed
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Aug 5, 2019 at 3:14 PM Jean-Louis Monteiro 
wrote:

> I fixed it a while back, but when I reverted last week, I reverted the fix
> as well.
> Sorry about that, I'll fix now.
>
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
>
>
> On Mon, Aug 5, 2019 at 3:12 PM David Blevins 
> wrote:
>
>> First step would be to get the build passing again.  There are failures
>> which are not related to bean validation.
>>
>> Once those are fixed and our build is green again, I'll do the work to
>> disable the feature I added that needs a modified BVal.  I hesitate to do
>> it now because the build isn't passing now for unrelated reasons and
>> disabling and changing the BVal version won't fix it.
>>
>> Looks like it broke with this commit:
>>
>>  -
>> https://github.com/apache/tomee/commit/77bc9450c70326194437a83e10f526c14ed3fa75
>>  - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
>>
>>
>> --
>> David Blevins
>> http://twitter.com/dblevins
>> http://www.tomitribe.com
>>
>> > On Aug 5, 2019, at 5:55 AM, Jean-Louis Monteiro <
>> jlmonte...@tomitribe.com> wrote:
>> >
>> > Just looked at it today.
>> > Looks like the build has
>> >
>> > 
>> >   org.apache.tomee.patch
>> >   bval-jsr
>> >   2.0.2-69c36fa8-1
>> > 
>> > But available from maven central is
>> >
>> >
>> > Should we update to one of those?
>> > Should we go to the official final?
>> >
>> > Can you guys give some hints so I can fix it?
>> >
>> >
>> > --
>> > Jean-Louis Monteiro
>> > http://twitter.com/jlouismonteiro
>> > http://www.tomitribe.com
>> >
>> >
>> > On Sat, Aug 3, 2019 at 2:59 AM David Blevins 
>> wrote:
>> > > On Aug 2, 2019, at 4:19 PM, David Blevins 
>> wrote:
>> > >
>> > > We can delete/disable the feature as well.  I don't want to be the
>> guy holding up the show.
>> >
>> > Dug in to take this route as it's all around simpler.  It looks,
>> however, the build has been failing since the 12th and it's all the JWT
>> code.
>> >
>> >  - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
>> >  - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1137
>> >
>> > I unfortunately don't have time to "shave the yak" so to speak.  I'm
>> writing a Github App to implement checks on the 37 Jakarta EE
>> specifications that all need to go up for vote in the next two weeks or
>> there will be no Jakarta EE 8 by CodeOne.  This includes the Bean
>> Validation specification, tck, itself.
>> >
>> > Jean-Louis, looks like this is related to the commit and revert you
>> might have done.  We had a pass on the 26th, which I suspect is right
>> before you did the revert.
>> >
>> >  - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1136
>> >
>> > If you can reinstate the fix, I'll go ahead and disable the fancy
>> JWT/BeanValidation feature.
>> >
>> >
>> > -David
>> >
>>
>>

Re: Wrong m3 bval dep?

[Jean-Louis Monteiro]

I fixed it a while back, but when I reverted last week, I reverted the fix
as well.
Sorry about that, I'll fix now.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Aug 5, 2019 at 3:12 PM David Blevins 
wrote:

> First step would be to get the build passing again.  There are failures
> which are not related to bean validation.
>
> Once those are fixed and our build is green again, I'll do the work to
> disable the feature I added that needs a modified BVal.  I hesitate to do
> it now because the build isn't passing now for unrelated reasons and
> disabling and changing the BVal version won't fix it.
>
> Looks like it broke with this commit:
>
>  -
> https://github.com/apache/tomee/commit/77bc9450c70326194437a83e10f526c14ed3fa75
>  - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
>
>
> --
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
>
> > On Aug 5, 2019, at 5:55 AM, Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
> >
> > Just looked at it today.
> > Looks like the build has
> >
> > 
> >   org.apache.tomee.patch
> >   bval-jsr
> >   2.0.2-69c36fa8-1
> > 
> > But available from maven central is
> >
> >
> > Should we update to one of those?
> > Should we go to the official final?
> >
> > Can you guys give some hints so I can fix it?
> >
> >
> > --
> > Jean-Louis Monteiro
> > http://twitter.com/jlouismonteiro
> > http://www.tomitribe.com
> >
> >
> > On Sat, Aug 3, 2019 at 2:59 AM David Blevins 
> wrote:
> > > On Aug 2, 2019, at 4:19 PM, David Blevins 
> wrote:
> > >
> > > We can delete/disable the feature as well.  I don't want to be the guy
> holding up the show.
> >
> > Dug in to take this route as it's all around simpler.  It looks,
> however, the build has been failing since the 12th and it's all the JWT
> code.
> >
> >  - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
> >  - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1137
> >
> > I unfortunately don't have time to "shave the yak" so to speak.  I'm
> writing a Github App to implement checks on the 37 Jakarta EE
> specifications that all need to go up for vote in the next two weeks or
> there will be no Jakarta EE 8 by CodeOne.  This includes the Bean
> Validation specification, tck, itself.
> >
> > Jean-Louis, looks like this is related to the commit and revert you
> might have done.  We had a pass on the 26th, which I suspect is right
> before you did the revert.
> >
> >  - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1136
> >
> > If you can reinstate the fix, I'll go ahead and disable the fancy
> JWT/BeanValidation feature.
> >
> >
> > -David
> >
>
>

Re: Wrong m3 bval dep?

[David Blevins]

First step would be to get the build passing again.  There are failures which 
are not related to bean validation.

Once those are fixed and our build is green again, I'll do the work to disable 
the feature I added that needs a modified BVal.  I hesitate to do it now 
because the build isn't passing now for unrelated reasons and disabling and 
changing the BVal version won't fix it.

Looks like it broke with this commit:

 - 
https://github.com/apache/tomee/commit/77bc9450c70326194437a83e10f526c14ed3fa75
 - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130


-- 
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

> On Aug 5, 2019, at 5:55 AM, Jean-Louis Monteiro  
> wrote:
> 
> Just looked at it today.
> Looks like the build has 
> 
> 
>   org.apache.tomee.patch
>   bval-jsr
>   2.0.2-69c36fa8-1
> 
> But available from maven central is
> 
> 
> Should we update to one of those?
> Should we go to the official final?
> 
> Can you guys give some hints so I can fix it?
> 
> 
> --
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> http://www.tomitribe.com
> 
> 
> On Sat, Aug 3, 2019 at 2:59 AM David Blevins  wrote:
> > On Aug 2, 2019, at 4:19 PM, David Blevins  wrote:
> > 
> > We can delete/disable the feature as well.  I don't want to be the guy 
> > holding up the show.
> 
> Dug in to take this route as it's all around simpler.  It looks, however, the 
> build has been failing since the 12th and it's all the JWT code.  
> 
>  - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
>  - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1137
> 
> I unfortunately don't have time to "shave the yak" so to speak.  I'm writing 
> a Github App to implement checks on the 37 Jakarta EE specifications that all 
> need to go up for vote in the next two weeks or there will be no Jakarta EE 8 
> by CodeOne.  This includes the Bean Validation specification, tck, itself.
> 
> Jean-Louis, looks like this is related to the commit and revert you might 
> have done.  We had a pass on the 26th, which I suspect is right before you 
> did the revert.
> 
>  - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1136
> 
> If you can reinstate the fix, I'll go ahead and disable the fancy 
> JWT/BeanValidation feature.
> 
> 
> -David
> 

Re: Wrong m3 bval dep?

[Jean-Louis Monteiro]

Just looked at it today.
Looks like the build has


  org.apache.tomee.patch
  bval-jsr
  2.0.2-69c36fa8-1


But available from maven central is
[image: image.png]

Should we update to one of those?
Should we go to the official final?

Can you guys give some hints so I can fix it?


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Sat, Aug 3, 2019 at 2:59 AM David Blevins 
wrote:

> > On Aug 2, 2019, at 4:19 PM, David Blevins 
> wrote:
> >
> > We can delete/disable the feature as well.  I don't want to be the guy
> holding up the show.
>
> Dug in to take this route as it's all around simpler.  It looks, however,
> the build has been failing since the 12th and it's all the JWT code.
>
>  - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1130
>  - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1137
>
> I unfortunately don't have time to "shave the yak" so to speak.  I'm
> writing a Github App to implement checks on the 37 Jakarta EE
> specifications that all need to go up for vote in the next two weeks or
> there will be no Jakarta EE 8 by CodeOne.  This includes the Bean
> Validation specification, tck, itself.
>
> Jean-Louis, looks like this is related to the commit and revert you might
> have done.  We had a pass on the 26th, which I suspect is right before you
> did the revert.
>
>  - https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/1136
>
> If you can reinstate the fix, I'll go ahead and disable the fancy
> JWT/BeanValidation feature.
>
>
> -David
>
>

JKS Keystore ?

[David Salter]

Hi,

I’m looking at https://issues.apache.org/jira/browse/TOMEE-2586 
 which is to make one of the 
samples work on Java 11.

I’ve got a fix for this on Java 11 by specifying the keystore type as JKS.  Is 
this ok for this example given that its a complete Java example?  When using 
JKS, the sample works correctly on Java 8 and Java 11.

Ta.

David.

Re: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5

[Jean-Louis Monteiro]

Grrr

No idea what Maven is doing.
Thanks for having a look again. I tried locally and it was working fine.

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Aug 5, 2019 at 10:51 AM Cees Bos  wrote:

> Hi Jean-Louis,
>
>
>
> I downloaded
> https://repository.apache.org/content/repositories/snapshots/org/apache/tomee/apache-tomee/8.0.0-SNAPSHOT/apache-tomee-8.0.0-20190805.041822-288-plus.tar.gz
> (build on August 5th).
>
> That is still having duplicate jars for mail:
>
>
>
>- geronimo-javamail_1.5_mail-1.0.0-20190802.101725-2.jar
>- geronimo-javamail_1.5_mail-1.0.0-SNAPSHOT.jar
>
>
>
> Same issue is also there for the spec jar:
>
>- geronimo-javamail_1.5_spec-1.0.0-20190802.101602-6.jar
>- geronimo-javamail_1.5_spec-1.0.0-SNAPSHOT.jar
>
>
> I loaded the TomEE project in IntelliJ. IntelliJ transforms SNAPSHOT in to
> a version jar as well.  (see screenshot attached)
> I don't know all details of Maven and the just plugins, but it looks like
> it uses a version jar at the moment it resolves SNAPSHOT.
> During the creation of deliverable one of the 2 jars has to be skipped, to
> ship only 1 jar, I think.
>
>
>
> With kind regards,
> Cees
>
>
>
> *From:* Jean-Louis Monteiro 
> *Sent:* vrijdag 2 augustus 2019 15:59
> *To:* Cees Bos 
> *Cc:* dev@tomee.apache.org; d...@geronimo.apache.org
> *Subject:* Re: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5
>
>
>
> Hi Cees,
>
>
>
> I just pushed some changes to fix this issue and also did a deploy of a
> new set of snapshots.
>
> I just ran a new build with a deploy at the end and I'll check whenever
> it's done.
>
>
>
> I would appreciate if you can have a look at the drop and give it a try if
> you can.
>
> I'll be running some TCK later tonight and try to follow up over here.
>
>
>
>
> --
>
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> 
> http://www.tomitribe.com
> 
>
>
>
>
>
> On Fri, Aug 2, 2019 at 12:13 PM Jean-Louis Monteiro <
> jlmonte...@tomitribe.com> wrote:
>
> Hi,
>
>
>
> First of, thanks for the feedback and trying it.
>
> I ran a build and deploy this morning, but did not get a chance to check
> it.
>
>
>
> I'll investigate and see why Maven is pulling the timestamp version + the
> SNAPSHOT version.
>
>
>
> JLouis
>
>
> --
>
> Jean-Louis Monteiro
> http://twitter.com/jlouismonteiro
> 
> http://www.tomitribe.com
> 
>
>
>
>
>
> On Fri, Aug 2, 2019 at 12:06 PM Cees Bos  wrote:
>
> Hi Jean-Louis,
>
> In the latest TomEE 8 SNAPSHOT there are 2 jars in the zip:
>
> https://repository.apache.org/content/repositories/snapshots/org/apache/tomee/apache-tomee/8.0.0-SNAPSHOT/apache-tomee-8.0.0-20190802.094733-284-plus.tar.gz
> 
>
> lib/geronimo-javamail_1.5_mail-1.0.0-201908.12351.jar
> lib/geronimo-javamail_1.5_mail-1.0.0-SNAPSHOT.jar
>
> Due to that our custom code fails, as it expects only 1 jar to see if we
> do a search on ' geronimo-javamail_1.5_mail*'.
>
> Is it intended that we have 2 same jars in the TomEE zip now (see
> attachment/screenshot)?
>
> With kind regards,
> Cees
>
> -Original Message-
> From: Jean-Louis Monteiro 
> Sent: donderdag 1 augustus 2019 14:42
> To: dev@tomee.apache.org; d...@geronimo.apache.org
> Subject: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5
>
> Hey TomEE and Geronimo folks,
>
> I built and deployed 1.5 SNAPSHOT of JavaMail API and provider.
> I also did the integration in TomEE with the snapshots.
>
> I am currently running Jakarta EE TCK to see where we are at.
> I'll be pushing setup changes shortly.
>
> This is related to
> 

RE: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5

[Cees Bos]

Hi Jean-Louis,

I downloaded 
https://repository.apache.org/content/repositories/snapshots/org/apache/tomee/apache-tomee/8.0.0-SNAPSHOT/apache-tomee-8.0.0-20190805.041822-288-plus.tar.gz
 (build on August 5th).
That is still having duplicate jars for mail:


  *   geronimo-javamail_1.5_mail-1.0.0-20190802.101725-2.jar
  *   geronimo-javamail_1.5_mail-1.0.0-SNAPSHOT.jar

Same issue is also there for the spec jar:

  *   geronimo-javamail_1.5_spec-1.0.0-20190802.101602-6.jar
  *   geronimo-javamail_1.5_spec-1.0.0-SNAPSHOT.jar

I loaded the TomEE project in IntelliJ. IntelliJ transforms SNAPSHOT in to a 
version jar as well.  (see screenshot attached)
I don't know all details of Maven and the just plugins, but it looks like it 
uses a version jar at the moment it resolves SNAPSHOT.
During the creation of deliverable one of the 2 jars has to be skipped, to ship 
only 1 jar, I think.

With kind regards,
Cees

From: Jean-Louis Monteiro 
Sent: vrijdag 2 augustus 2019 15:59
To: Cees Bos 
Cc: dev@tomee.apache.org; d...@geronimo.apache.org
Subject: Re: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5

Hi Cees,

I just pushed some changes to fix this issue and also did a deploy of a new set 
of snapshots.
I just ran a new build with a deploy at the end and I'll check whenever it's 
done.

I would appreciate if you can have a look at the drop and give it a try if you 
can.
I'll be running some TCK later tonight and try to follow up over here.


--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Aug 2, 2019 at 12:13 PM Jean-Louis Monteiro 
mailto:jlmonte...@tomitribe.com>> wrote:
Hi,

First of, thanks for the feedback and trying it.
I ran a build and deploy this morning, but did not get a chance to check it.

I'll investigate and see why Maven is pulling the timestamp version + the 
SNAPSHOT version.

JLouis

--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Fri, Aug 2, 2019 at 12:06 PM Cees Bos 
mailto:c...@opentext.com>> wrote:
Hi Jean-Louis,

In the latest TomEE 8 SNAPSHOT there are 2 jars in the zip:
https://repository.apache.org/content/repositories/snapshots/org/apache/tomee/apache-tomee/8.0.0-SNAPSHOT/apache-tomee-8.0.0-20190802.094733-284-plus.tar.gz

lib/geronimo-javamail_1.5_mail-1.0.0-201908.12351.jar
lib/geronimo-javamail_1.5_mail-1.0.0-SNAPSHOT.jar

Due to that our custom code fails, as it expects only 1 jar to see if we do a 
search on ' geronimo-javamail_1.5_mail*'.

Is it intended that we have 2 same jars in the TomEE zip now (see 
attachment/screenshot)?

With kind regards,
Cees

-Original Message-
From: Jean-Louis Monteiro 
mailto:jlmonte...@tomitribe.com>>
Sent: donderdag 1 augustus 2019 14:42
To: dev@tomee.apache.org; 
d...@geronimo.apache.org
Subject: [EXTERNAL] - TomEE 8 / Jakarta EE 8 / JavaMail 1.5

Hey TomEE and Geronimo folks,

I built and deployed 1.5 SNAPSHOT of JavaMail API and provider.
I also did the integration in TomEE with the snapshots.

I am currently running Jakarta EE TCK to see where we are at.
I'll be pushing setup changes shortly.

This is related to 
https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_TOMEE-2D2606=DwIBaQ=ZgVRmm3mf2P1-XDAyDsu4A=B2emKdiFYccjWBoInpxt6-t02i8YM3yYUrogo-heqv4=JfY1XGOMYbbqdAL-4njzykYMfGKHf7PL5CP6oVljRKo=qFbGTsyNi09mx2cf2XhB-g27ZWKs_ryQXB2ui0pjFLk=

If that looks quite well, I will do a release of both this week if possible
--
Jean-Louis Monteiro

Re: JIRA cleanup

[Jean-Louis Monteiro]

Good point. Thanks Mark
--
Jean-Louis Monteiro
http://twitter.com/jlouismonteiro
http://www.tomitribe.com


On Mon, Aug 5, 2019 at 8:32 AM Mark Struberg 
wrote:

> I've now at least moved the open ones from M3 to M4.
>
> LieGrue,
> strub
>
>
> > Am 05.08.2019 um 08:16 schrieb Mark Struberg  >:
> >
> > another thing I noticed.
> >
> >
> > 8.0.0-M3 got released, but the JIRA version still has many open tickets
> on this version.
> > I suggest to move all those to 8.0.0-M4 and close all resolved tickets
> and mark M3 as released.
> >
> > Who want's to do it?
> >
> > LieGrue,
> > strub
>
>

Re: tomee-patch release staging?

[Mark Struberg]

Done.

LieGrue,
strub


> Am 05.08.2019 um 08:28 schrieb David Blevins :
> 
> Go ahead and drop it.  Thank you!
> 
> Good catch.
> 
> -- 
> David Blevins
> http://twitter.com/dblevins
> http://www.tomitribe.com
> 
>> On Aug 4, 2019, at 11:15 PM, Mark Struberg  wrote:
>> 
>> Good morning!
>> 
>> While releasing Johnzon-1.1.13 I stumbled across a TomEE staging repo from 
>> May
>> https://repository.apache.org/content/repositories/orgapachetomee-1134
>> 
>> Can we drop this, or is it still needed?
>> 
>> LieGrue,
>> strub
> 

Re: JIRA cleanup

[Mark Struberg]

I've now at least moved the open ones from M3 to M4.

LieGrue,
strub


> Am 05.08.2019 um 08:16 schrieb Mark Struberg :
> 
> another thing I noticed.
> 
> 
> 8.0.0-M3 got released, but the JIRA version still has many open tickets on 
> this version.
> I suggest to move all those to 8.0.0-M4 and close all resolved tickets and 
> mark M3 as released.
> 
> Who want's to do it?
> 
> LieGrue,
> strub

Re: tomee-patch release staging?

[David Blevins]

Go ahead and drop it.  Thank you!

Good catch.

-- 
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

> On Aug 4, 2019, at 11:15 PM, Mark Struberg  wrote:
> 
> Good morning!
> 
> While releasing Johnzon-1.1.13 I stumbled across a TomEE staging repo from May
> https://repository.apache.org/content/repositories/orgapachetomee-1134
> 
> Can we drop this, or is it still needed?
> 
> LieGrue,
> strub

JIRA cleanup

[Mark Struberg]

another thing I noticed.


8.0.0-M3 got released, but the JIRA version still has many open tickets on this 
version.
I suggest to move all those to 8.0.0-M4 and close all resolved tickets and mark 
M3 as released.

Who want's to do it?

LieGrue,
strub

tomee-patch release staging?

[Mark Struberg]

Good morning!

While releasing Johnzon-1.1.13 I stumbled across a TomEE staging repo from May
https://repository.apache.org/content/repositories/orgapachetomee-1134

Can we drop this, or is it still needed?

LieGrue,
strub