[GitHub] [tomee] rzo1 commented on pull request #830: TOMEE-3647
rzo1 commented on pull request #830: URL: https://github.com/apache/tomee/pull/830#issuecomment-1081389255 We can do either. Master will fail with most of the examples anyway due to outdated dependencies without jakarta modifier /classifier. I agree, that it is a bit of a pain to ship something in unknown waters my comment aims for only one thing: we should not forget it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] cesarhernandezgt commented on pull request #830: TOMEE-3647
cesarhernandezgt commented on pull request #830: URL: https://github.com/apache/tomee/pull/830#issuecomment-1081335916 > @cesarhernandezgt lgtm. We should probably bring this to master / 9.x as well. Hi @rzo1 , I tried today to apply the patch to master (9.x) but maybe we can stabilize the first master branch since I haven't been able to have a successful build even by skipping all the tests. wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] sultan commented on pull request #828: TOMEE-3871 - TomEE Plume is missing BatchEE / JCS Cache
sultan commented on pull request #828: URL: https://github.com/apache/tomee/pull/828#issuecomment-1081054794 nice to read ! 1) i learned that a setup installer for TomEE "like eclipse oomph" (cherry pick modules) is not possible, as it breaks TCK rules. unless we want a parallel non TCK certified TomEE (meh) 2) i thought like @rmannibucau at first with "per functionalities" LIB folders (like others EE servers) but this would make TomEE harder to configure / extend. (where do user put their jars !?) 3) there could be "per functionalities" uber or shaded jars to ease remove and replace implementations by others. but i wonder if i did read that current project policy is to avoid shading/uber. 4) there could be a common POM between plus and plume to help fill the gaps/ease maintenance. 5) there could be an external tool to modify a dezipped certified TomEE to change its implementation jars. the only one i think i can currently help on is n°4 (common plus-plume pom) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] dblevins commented on pull request #828: TOMEE-3871 - TomEE Plume is missing BatchEE / JCS Cache
dblevins commented on pull request #828: URL: https://github.com/apache/tomee/pull/828#issuecomment-1081014317 Here's the list message on the name and motivation for Plume: - https://lists.apache.org/thread/tkpfjlzv70y8kzz5f905qj9vs95b34rw "a version of TomEE Plus with Mojarra and EclipseLink. Tentatively called it "TomEE Plume" which stands for TomEE PLUs, Mojarra, Eclipselink (PLU.M.E)." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] sultan commented on pull request #828: TOMEE-3871 - TomEE Plume is missing BatchEE / JCS Cache
sultan commented on pull request #828: URL: https://github.com/apache/tomee/pull/828#issuecomment-1081002793 does this need a mailing list vote from committers ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] rzo1 merged pull request #826: TOMEE-3872 - Update Hibernate Integration to 5.6.7
rzo1 merged pull request #826: URL: https://github.com/apache/tomee/pull/826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] rzo1 commented on pull request #826: TOMEE-3872 - Update Hibernate Integration to 5.6.7
rzo1 commented on pull request #826: URL: https://github.com/apache/tomee/pull/826#issuecomment-1080947816 Rebased and squased into one commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] rzo1 edited a comment on pull request #826: TOMEE-3872 - Update Hibernate Integration to 5.6.7
rzo1 edited a comment on pull request #826: URL: https://github.com/apache/tomee/pull/826#issuecomment-1080560470 [**Full** build is **green** now! ](https://ci-builds.apache.org/job/Tomee/job/TOMEE-3872/13/)Think, we can go ahead with this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [tomee] rzo1 commented on pull request #826: TOMEE-3872 - Update Hibernate Integration to 5.6.7
rzo1 commented on pull request #826: URL: https://github.com/apache/tomee/pull/826#issuecomment-1080560470 **Full** build is **green** now! Think, we can go ahead with this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: TOMEE-3846 flavors comparison page
As we merged the comparision page, we should now tackle: https://github.com/apache/tomee/pull/828 There was a discussion regarding the original intentions of plume. If we agree, that "Those distributions are supposed to be the same minus the JPA and JSF providers.", then we should go a-head and merge it + port it to master. Gruß Richard Am Freitag, dem 25.03.2022 um 11:29 +0100 schrieb Swell: > Thanks for your kind feedback. > > @Richard, I'll gladly change Tomee Plume pom to include BatchEE, PR : > in > progress with a blocker i can also resolve. > > @David, about the flavors page, i think your suggestions are simpler > and > better, applied them on names consistency and added a table of > implementations. > > what need for this list of implementations ? > * For my students => My usual scenario is that i need to remind them > of > what is provided by Tomee vs other servers. "they dont need HK2 nor > Jersey > if they have the Plus flavor." > * For the general web site visitors => I wonder if people would > prefer perf > metrics and tck results, rather than comparing what is provided by > Tomee vs > others. provided a web capture just for fun : > https://issues.apache.org/jira/secure/attachment/13041580/image-2022-03-25-11-18-14-708.png > > i still believe the list of implementations is needed to know what > Tomee > provides, but David's suggestion is clearer. > here is the current version of the web page in the PR : > https://issues.apache.org/jira/secure/attachment/13041581/image-2022-03-25-11-19-03-406.png > > On Fri, 25 Mar 2022 at 06:18, Zowalla, Richard < > richard.zowa...@hs-heilbronn.de> wrote: > > > Hi all, > > > > Thanks for your mail and your work in making the page more clear, > > Swell! Your work is very much appreciated. > > > > > > > Total side note to the wider dev list, we really need to get > > > JBatch > > > into Plume! Those distributions are supposed to be the same > > > minus > > > the JPA and JSF providers. > > > > I created TOMEE-3871 [1] for this one. > > > > @Swell Let me know, if you like to provide a PR for master / tomee- > > 8.x > > branch to fix it. We can then assign you the Jira :) > > > > It basically boils down to adding "batchee-jbatch" (runtime) to the > > "tomee-plume-webapp". The references in the "boms" are then > > automatically re-generated, if you conduct a quick build: > > > > mvn -U -Pquick -DskipTests -Dsurefire.useFile=false > > -DdisableXmlReport=true -DuniqueVersion=false -ff -Dassemble > > -DfailIfNoTests=false clean install > > > > If you are unsure how to proceed with it, feel free to ask. We are > > happy to help. > > > > Gruß > > Richard > > > > [1] https://issues.apache.org/jira/browse/TOMEE-3871 > > > > Am Donnerstag, dem 24.03.2022 um 11:48 -0700 schrieb David Blevins: > > > > On Mar 19, 2022, at 2:30 AM, Swell > > > > wrote: > > > > > > > > Regarding Tomee website : one web page mislead me to believe > > > > that > > > > Tomee Plus > > > > includes Tomee Plume, and it made it hard for me to understand > > > > why > > > > my > > > > webapp was not loading. > > > > > > > > I believe it could mislead others and its why I wanted to > > > > suggest > > > > some > > > > changes on its content to better show the delta between > > > > flavors. > > > > > > > > Currently the flavors page does not differentiate between Micro > > > > and > > > > Web > > > > profiles, nor does it tell Plume includes EclipseLink when Plus > > > > does not. > > > > > > > > I took time to write a page I believe could be usefull to Tomee > > > > users, a > > > > screenshot is linked below, the visitors could benefit from my > > > > additional > > > > table for synthesis of deltas. > > > > > > > > > > https://issues.apache.org/jira/secure/attachment/13041318/image-2022-03-18-20-36-25-938.png > > > Hi Swell, > > > > > > Thank you so much for taking the time to put so much thought into > > > this work. We are truly lucky :) > > > > > > I love that you included the MicroProfile detail, that was > > > definitely > > > missing and badly needed. As the table is quite large already, > > > that > > > terse summary at the top is a very nice improvement and likely to > > > help people see the big picture significantly faster. > > > > > > In the first table, I like the way you used "Jakarta JSF > > > Implementation" and list the implementations by name. For > > > consistency, can we use that same approach for the line > > > above? Instead of it saying "EclipseLink" and having a > > > checkmark, > > > could we also have it say "Jakarta Persistence (JPA) > > > Implementation" > > > and then put "OpenJPA, OpenJPA, EcliseLink, OpenJPA" in > > > there? We > > > can do that in both the top and bottom tables. > > > > > > On listing OpenEJB in the bottom table. I think it's fine I'm > > > not > > > the best judge of what people think is useful information as I've > > > been working on the project too long and everything is > > > "obvious." Do > > > you find it
Re: TomEE 9.x - from javax to jakarta namespace
Heyho, the ZIP created for TOMEE-3879 looks good to me. It has +x set. Perhaps it looses the info during extraction in our code. Can you give a pointer, which tests are suspected to be impacted by it? Gruß Richard Am Samstag, dem 26.03.2022 um 10:40 +0100 schrieb Jean-Louis Monteiro: > Awesome, divide and conquer. > > Trying to add a bit more... > This one might be small for someone with some spare cycles. > > https://issues.apache.org/jira/browse/TOMEE-3879 > > > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Sat, Mar 26, 2022 at 5:35 AM David Blevins < > david.blev...@gmail.com> > wrote: > > > > On Mar 24, 2022, at 2:28 AM, Jean-Louis Monteiro < > > jlmonte...@tomitribe.com> wrote: > > > We can now divide and conquer. An issue has been created > > > https://issues.apache.org/jira/browse/TOMEE-3862 > > > We are going to add as many small tasks as possible so people can > > > pick > > and > > > contribute in parallel. > > > > Thanks for that JIRA. I saw an easy one I could do and went a head > > and > > knocked it out :) > > > > - > > https://github.com/apache/tomee/commit/6e37ec02ca60fe955a3a909d761e09aa5a506978 > > > > That yanks 1 minute out of the build on my machine. > > > > > > -David > > > > > > > On Tue, Mar 22, 2022 at 1:59 PM Jean-Louis Monteiro < > > > jlmonte...@tomitribe.com> wrote: > > > > > > > Hi, > > > > > > > > I've been working for quite a long time on TomEE 9.x, and it's > > > > been more > > > > challenging and painful than I was expecting. I thought it > > > > would be > > good to > > > > give you some sort of status. > > > > > > > > I created a PR for the work. As a reminder, since Java EE moved > > > > to > > Eclipse > > > > to become Jakarta EE, we had a switch from javax.* namespace to > > jakarta.* > > > > namespace. This is an impacting change, since all applications > > > > and > > > > applications servers are built on top of it. > > > > > > > > In TomEE, we decided to do that change in TomEE. We had > > > > previously a > > > > bytecode change approach like an application could do. It > > > > worked and we > > > > were able to get certified. But it had a lot of limitations, so > > > > we had > > to > > > > do the migration in the code and fix all compatibility issues. > > > > > > > > Here is the PR https://github.com/apache/tomee/pull/814 > > > > It has 90+ commits and nearly 5000 files touched (added, > > > > removed, > > > > updated). I understand it's a lot and it makes it almost > > > > impossible to > > > > review. But I did not see much approaches in this scenario to > > > > create > > > > smaller PRs. > > > > > > > > I created a Jenkins build though available at > > > > https://ci-builds.apache.org/job/Tomee/job/master-build-quick-9.x/ > > > > > > > > It makes it possible to track the progress. There have been > > > > steps > > forward > > > > and steps backward. > > > > > > > > All the code does not sit under TomEE, we use a bunch of third > > > > party > > > > projects and libraries. I have been able to contribute, publish > > > > jakarta > > > > compatible versions and get releases for some of them (Jakarta > > > > EE APIs > > Uber > > > > jar, Geronimo Connectors and Transaction Manager, Geronimo > > > > Config, > > Health, > > > > Metrics, OpenTracing, OpenAPI. OpenJPA, BVal, and OpenWebBeans > > > > will be > > > > released soon. > > > > > > > > The big parts is CXF, and ActiveMQ. I had to get them done in > > > > TomEE and > > > > update all group/artifact ids. It's under deps, alongside with > > > > SXC, > > DBCP, > > > > and others. > > > > > > > > In terms of removal, I tried to remove old stuff like SAAJ Axis > > > > 1 > > > > integration, JAX RPC, Management J2EE and a couple of other old > > > > things. > > > > > > > > A lot of other libraries got updated to their latest version > > > > when > > > > available in the new jakarta namespace. > > > > > > > > I'm starting to get all the build stable and many modules are > > > > passing > > now, > > > > including all CXF webservices, OpenEJB Core, and others. I can > > > > get a > > build > > > > and run TomEE. > > > > > > > > Goal is to get a green build asap so we can start working on > > > > TCK. > > > > The "quick" build is now green. Working on the full build. > > > > > > > > I'll soon be creating a branch for TomEE 8.x maintenance and > > > > merge the > > PR. > > > > I'm hoping we can then have small PRs or at least more people > > > > working in > > > > parallel. > > > > > > > > -- > > > > Jean-Louis Monteiro > > > > http://twitter.com/jlouismonteiro > > > > http://www.tomitribe.com > > > > smime.p7s Description: S/MIME cryptographic signature
[GitHub] [tomee-site-generator] rzo1 merged pull request #36: TOMEE-3846 fixed tomee flavors comparison page
rzo1 merged pull request #36: URL: https://github.com/apache/tomee-site-generator/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomee.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
