Re: ASM 6 in Master and 1.7.x
I've backported the changes to OWB 1.2.x and 1.7.x. I'll give these a check with Java 9 and then I'll send those PRs and move on to the OpenJPA. Then I'll start the release. Jon On Tue, Mar 6, 2018 at 11:52 AM, Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Cool, thanks Mark. Looks like I might have a few updates to do :-) > > Jon > > On Tue, Mar 6, 2018 at 11:51 AM, Mark Struberg <strub...@yahoo.de.invalid> > wrote: > >> Hi Jon! >> >> Txs for updating and looking forward for the OWB patch. >> Btw, we also might update OpenJPA. It also uses xbean-asm5 >> >> LieGrue, >> strub >> >> >> > Am 06.03.2018 um 10:22 schrieb Romain Manni-Bucau < >> rmannibu...@gmail.com>: >> > >> > +1, thanks Jon. >> > >> > >> > Romain Manni-Bucau >> > @rmannibucau <https://twitter.com/rmannibucau> | Blog >> > <https://rmannibucau.metawerx.net/> | Old Blog >> > <http://rmannibucau.wordpress.com> | Github < >> https://github.com/rmannibucau> | >> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book >> > <https://www.packtpub.com/application-development/java-ee-8- >> high-performance> >> > >> > 2018-03-06 10:17 GMT+01:00 Jonathan Gallimore < >> jonathan.gallim...@gmail.com> >> > : >> > >> >> Hi >> >> >> >> I applied a change to move to ASM 6 in master and 1.7.x (actually >> >> backported from TomEE 8 - thanks Mark!). For those wondering what all >> this >> >> is about, this change allows classes compiled with Java 9 to scanned. >> >> However, this led to two versions of xbean asm being included in the >> binary >> >> as OpenWebBeans was using the previous version. >> >> >> >> For now, I have backed that out, and I'll see if I can apply the >> >> appropriate patches to OpenWebBeans contribute those and see if I can >> >> re-apply these changes over here. >> >> >> >> Jon >> >> >> >> >
Re: ASM 6 in Master and 1.7.x
Cool, thanks Mark. Looks like I might have a few updates to do :-) Jon On Tue, Mar 6, 2018 at 11:51 AM, Mark Struberg <strub...@yahoo.de.invalid> wrote: > Hi Jon! > > Txs for updating and looking forward for the OWB patch. > Btw, we also might update OpenJPA. It also uses xbean-asm5 > > LieGrue, > strub > > > > Am 06.03.2018 um 10:22 schrieb Romain Manni-Bucau <rmannibu...@gmail.com > >: > > > > +1, thanks Jon. > > > > > > Romain Manni-Bucau > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > <https://rmannibucau.metawerx.net/> | Old Blog > > <http://rmannibucau.wordpress.com> | Github <https://github.com/ > rmannibucau> | > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > > <https://www.packtpub.com/application-development/java- > ee-8-high-performance> > > > > 2018-03-06 10:17 GMT+01:00 Jonathan Gallimore < > jonathan.gallim...@gmail.com> > > : > > > >> Hi > >> > >> I applied a change to move to ASM 6 in master and 1.7.x (actually > >> backported from TomEE 8 - thanks Mark!). For those wondering what all > this > >> is about, this change allows classes compiled with Java 9 to scanned. > >> However, this led to two versions of xbean asm being included in the > binary > >> as OpenWebBeans was using the previous version. > >> > >> For now, I have backed that out, and I'll see if I can apply the > >> appropriate patches to OpenWebBeans contribute those and see if I can > >> re-apply these changes over here. > >> > >> Jon > >> > >
Re: ASM 6 in Master and 1.7.x
Hi Jon! Txs for updating and looking forward for the OWB patch. Btw, we also might update OpenJPA. It also uses xbean-asm5 LieGrue, strub > Am 06.03.2018 um 10:22 schrieb Romain Manni-Bucau <rmannibu...@gmail.com>: > > +1, thanks Jon. > > > Romain Manni-Bucau > @rmannibucau <https://twitter.com/rmannibucau> | Blog > <https://rmannibucau.metawerx.net/> | Old Blog > <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > <https://www.packtpub.com/application-development/java-ee-8-high-performance> > > 2018-03-06 10:17 GMT+01:00 Jonathan Gallimore <jonathan.gallim...@gmail.com> > : > >> Hi >> >> I applied a change to move to ASM 6 in master and 1.7.x (actually >> backported from TomEE 8 - thanks Mark!). For those wondering what all this >> is about, this change allows classes compiled with Java 9 to scanned. >> However, this led to two versions of xbean asm being included in the binary >> as OpenWebBeans was using the previous version. >> >> For now, I have backed that out, and I'll see if I can apply the >> appropriate patches to OpenWebBeans contribute those and see if I can >> re-apply these changes over here. >> >> Jon >>
Re: ASM 6 in Master and 1.7.x
+1, thanks Jon. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> 2018-03-06 10:17 GMT+01:00 Jonathan Gallimore <jonathan.gallim...@gmail.com> : > Hi > > I applied a change to move to ASM 6 in master and 1.7.x (actually > backported from TomEE 8 - thanks Mark!). For those wondering what all this > is about, this change allows classes compiled with Java 9 to scanned. > However, this led to two versions of xbean asm being included in the binary > as OpenWebBeans was using the previous version. > > For now, I have backed that out, and I'll see if I can apply the > appropriate patches to OpenWebBeans contribute those and see if I can > re-apply these changes over here. > > Jon >
ASM 6 in Master and 1.7.x
Hi I applied a change to move to ASM 6 in master and 1.7.x (actually backported from TomEE 8 - thanks Mark!). For those wondering what all this is about, this change allows classes compiled with Java 9 to scanned. However, this led to two versions of xbean asm being included in the binary as OpenWebBeans was using the previous version. For now, I have backed that out, and I'll see if I can apply the appropriate patches to OpenWebBeans contribute those and see if I can re-apply these changes over here. Jon