[GitHub] twill pull request #39: (TWILL-225) Refactor TwillPreprer to allow configura...
GitHub user chtyim opened a pull request: https://github.com/apache/twill/pull/39 (TWILL-225) Refactor TwillPreprer to allow configurations affecting a⦠â¦pplication behavior overridable per TwillPreprer You can merge this pull request into a Git repository by running: $ git pull https://github.com/chtyim/twill feature/TWILL-225 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/39.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #39 commit babc2e1b6598319956b4333d3c3ef2ca3400a13c Author: Terence Yim Date: 2017-03-19T01:31:57Z (TWILL-225) Refactor TwillPreprer to allow configurations affecting application behavior overridable per TwillPreprer --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TWILL-225) Allow using different configurations per application submission
[ https://issues.apache.org/jira/browse/TWILL-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933329#comment-15933329 ] ASF GitHub Bot commented on TWILL-225: -- GitHub user chtyim opened a pull request: https://github.com/apache/twill/pull/39 (TWILL-225) Refactor TwillPreprer to allow configurations affecting a… …pplication behavior overridable per TwillPreprer You can merge this pull request into a Git repository by running: $ git pull https://github.com/chtyim/twill feature/TWILL-225 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/39.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #39 commit babc2e1b6598319956b4333d3c3ef2ca3400a13c Author: Terence Yim Date: 2017-03-19T01:31:57Z (TWILL-225) Refactor TwillPreprer to allow configurations affecting application behavior overridable per TwillPreprer > Allow using different configurations per application submission > --- > > Key: TWILL-225 > URL: https://issues.apache.org/jira/browse/TWILL-225 > Project: Apache Twill > Issue Type: Improvement >Reporter: Terence Yim >Assignee: Terence Yim > Fix For: 0.11.0 > > > Currently there are couple configurations that can be provided via the hadoop > {{Configuration}} object to the {{YarnTwillRunnerService}}. However, those > configurations are global (same for all app launched through the same > {{TwillRunnerService}}). It would be better if the {{TwillPreparer}} exposes > method to alter the configuration for a given app submission. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TWILL-225) Allow using different configurations per application submission
[ https://issues.apache.org/jira/browse/TWILL-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933443#comment-15933443 ] Yuliya Feldman commented on TWILL-225: -- [~chtyim] Great idea, otherwise it has to be pretty much TwillRunnerService per "run" with any modification to Configuration object > Allow using different configurations per application submission > --- > > Key: TWILL-225 > URL: https://issues.apache.org/jira/browse/TWILL-225 > Project: Apache Twill > Issue Type: Improvement >Reporter: Terence Yim >Assignee: Terence Yim > Fix For: 0.11.0 > > > Currently there are couple configurations that can be provided via the hadoop > {{Configuration}} object to the {{YarnTwillRunnerService}}. However, those > configurations are global (same for all app launched through the same > {{TwillRunnerService}}). It would be better if the {{TwillPreparer}} exposes > method to alter the configuration for a given app submission. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] twill pull request #39: (TWILL-225) Refactor TwillPreprer to allow configura...
Github user yufeldman commented on a diff in the pull request: https://github.com/apache/twill/pull/39#discussion_r107004427 --- Diff: twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java --- @@ -155,25 +153,16 @@ public String apply(Class cls) { private ClassAcceptor classAcceptor; private final Map maxRetries = Maps.newHashMap(); - YarnTwillPreparer(YarnConfiguration yarnConfig, TwillSpecification twillSpec, RunId runId, -YarnAppClient yarnAppClient, String zkConnectString, Location appLocation, Set twillClassPaths, + YarnTwillPreparer(Configuration config, TwillSpecification twillSpec, RunId runId, --- End diff -- Any particular reason to switch to Configuration from YarnConfiguration? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TWILL-225) Allow using different configurations per application submission
[ https://issues.apache.org/jira/browse/TWILL-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933457#comment-15933457 ] ASF GitHub Bot commented on TWILL-225: -- Github user yufeldman commented on a diff in the pull request: https://github.com/apache/twill/pull/39#discussion_r107004427 --- Diff: twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java --- @@ -155,25 +153,16 @@ public String apply(Class cls) { private ClassAcceptor classAcceptor; private final Map maxRetries = Maps.newHashMap(); - YarnTwillPreparer(YarnConfiguration yarnConfig, TwillSpecification twillSpec, RunId runId, -YarnAppClient yarnAppClient, String zkConnectString, Location appLocation, Set twillClassPaths, + YarnTwillPreparer(Configuration config, TwillSpecification twillSpec, RunId runId, --- End diff -- Any particular reason to switch to Configuration from YarnConfiguration? > Allow using different configurations per application submission > --- > > Key: TWILL-225 > URL: https://issues.apache.org/jira/browse/TWILL-225 > Project: Apache Twill > Issue Type: Improvement >Reporter: Terence Yim >Assignee: Terence Yim > Fix For: 0.11.0 > > > Currently there are couple configurations that can be provided via the hadoop > {{Configuration}} object to the {{YarnTwillRunnerService}}. However, those > configurations are global (same for all app launched through the same > {{TwillRunnerService}}). It would be better if the {{TwillPreparer}} exposes > method to alter the configuration for a given app submission. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] twill pull request #39: (TWILL-225) Refactor TwillPreprer to allow configura...
Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/39#discussion_r10700 --- Diff: twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java --- @@ -155,25 +153,16 @@ public String apply(Class cls) { private ClassAcceptor classAcceptor; private final Map maxRetries = Maps.newHashMap(); - YarnTwillPreparer(YarnConfiguration yarnConfig, TwillSpecification twillSpec, RunId runId, -YarnAppClient yarnAppClient, String zkConnectString, Location appLocation, Set twillClassPaths, + YarnTwillPreparer(Configuration config, TwillSpecification twillSpec, RunId runId, --- End diff -- It's more generic. We actually not using any specific method from `YarnConfiguration` in this class. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (TWILL-225) Allow using different configurations per application submission
[ https://issues.apache.org/jira/browse/TWILL-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933482#comment-15933482 ] ASF GitHub Bot commented on TWILL-225: -- Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/39#discussion_r10700 --- Diff: twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java --- @@ -155,25 +153,16 @@ public String apply(Class cls) { private ClassAcceptor classAcceptor; private final Map maxRetries = Maps.newHashMap(); - YarnTwillPreparer(YarnConfiguration yarnConfig, TwillSpecification twillSpec, RunId runId, -YarnAppClient yarnAppClient, String zkConnectString, Location appLocation, Set twillClassPaths, + YarnTwillPreparer(Configuration config, TwillSpecification twillSpec, RunId runId, --- End diff -- It's more generic. We actually not using any specific method from `YarnConfiguration` in this class. > Allow using different configurations per application submission > --- > > Key: TWILL-225 > URL: https://issues.apache.org/jira/browse/TWILL-225 > Project: Apache Twill > Issue Type: Improvement >Reporter: Terence Yim >Assignee: Terence Yim > Fix For: 0.11.0 > > > Currently there are couple configurations that can be provided via the hadoop > {{Configuration}} object to the {{YarnTwillRunnerService}}. However, those > configurations are global (same for all app launched through the same > {{TwillRunnerService}}). It would be better if the {{TwillPreparer}} exposes > method to alter the configuration for a given app submission. -- This message was sent by Atlassian JIRA (v6.3.15#6346)