[GitHub] twill pull request #69: (TWILL-260) Upgrade version of zkclient - library th...
GitHub user yufeldman opened a pull request: https://github.com/apache/twill/pull/69 (TWILL-260) Upgrade version of zkclient - library that kafka is using. - current version of zkclient (0.3) that kafka_2.10 version 0.8.0 is using is buggy it does not handle well sasl authenticate and connected events fix was done in zkclient 0.7 - instead of more invasive change of upgrading kafka (API changes) zkclient upgrade should be rather painless and fix issues with inability to connect when sasl is enabled especially with fast network that creates race condition between sasl authentication and connected zk events You can merge this pull request into a Git repository by running: $ git pull https://github.com/yufeldman/twill TWILL-260 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/69.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #69 commit c808d4649430398332a2d9415a486f137b97f5f3 Author: Yuliya Feldman Date: 2018-07-13T22:24:16Z (TWILL-260) Upgrade version of zkclient - library that kafka is using. - current version of zkclient (0.3) that kafka_2.10 version 0.8.0 is using is buggy it does not handle well sasl authenticate and connected events fix was done in zkclient 0.7 - instead of more invasive change of upgrading kafka (API changes) zkclient upgrade should be rather painless and fix issues with inability to connect when sasl is enabled especially with fast network that creates race condition between sasl authentication and connected zk events ---
[GitHub] twill pull request #66: (TWILL-255) Incorrect logging after memory was adjus...
GitHub user yufeldman opened a pull request: https://github.com/apache/twill/pull/66 (TWILL-255) Incorrect logging after memory was adjusted. Does not sho⦠â¦w memory before adjustment You can merge this pull request into a Git repository by running: $ git pull https://github.com/yufeldman/twill branch-TWILL-255 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/66.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #66 commit 5617478fc2ebf315ada125e1d3242f53c8545987 Author: Yuliya Feldman Date: 2018-02-28T22:52:56Z (TWILL-255) Incorrect logging after memory was adjusted. Does not show memory before adjustment ---
[GitHub] twill pull request #55: (TWILL-237) Twill is using hdfs HAUtil api that is n...
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/twill/pull/55#discussion_r131224027
--- Diff:
twill-yarn/src/main/java/org/apache/twill/filesystem/FileContextLocationUtil.java
---
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.twill.filesystem;
+
+import com.google.common.base.Throwables;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hdfs.HAUtil;
+
+import java.lang.invoke.MethodHandle;
+import java.lang.invoke.MethodHandles;
+import java.lang.invoke.MethodType;
+import java.net.URI;
+
+/**
+ * Utility class.
+ */
+final class FileContextLocationUtil {
--- End diff --
Thank you for the final review. Addressed your comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill pull request #55: (TWILL-237) Twill is using hdfs HAUtil api that is n...
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/twill/pull/55#discussion_r124117726
--- Diff:
twill-yarn/src/main/java/org/apache/twill/filesystem/FileContextLocation.java
---
@@ -162,7 +163,8 @@ public URI toURI() {
// append "port" to the path URI, while the DistributedFileSystem
always use the cluster logical
// name, which doesn't allow having port in it.
URI uri = path.toUri();
-if (HAUtil.isLogicalUri(locationFactory.getConfiguration(), uri)) {
+
+if
(FileContextLocationUtil.useLogicalUri(locationFactory.getConfiguration(),
uri)) {
--- End diff --
I am not sure it is as simple as that. We may need to change equals() to
compare based on toURI() and not path or somehow make path and toURI() to be in
sync within that class, otherwise parts become inconsistent and I am not sure
unitTests failures in this case is the only issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill pull request #55: (TWILL-237) Twill is using hdfs HAUtil api that is n...
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/twill/pull/55#discussion_r124066342
--- Diff:
twill-yarn/src/main/java/org/apache/twill/filesystem/FileContextLocation.java
---
@@ -162,7 +163,8 @@ public URI toURI() {
// append "port" to the path URI, while the DistributedFileSystem
always use the cluster logical
// name, which doesn't allow having port in it.
URI uri = path.toUri();
-if (HAUtil.isLogicalUri(locationFactory.getConfiguration(), uri)) {
+
+if
(FileContextLocationUtil.useLogicalUri(locationFactory.getConfiguration(),
uri)) {
--- End diff --
Should we just get rid of the check in this case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill pull request #55: (TWILL-237) Twill is using hdfs HAUtil api that is n...
GitHub user yufeldman opened a pull request: https://github.com/apache/twill/pull/55 (TWILL-237) Twill is using hdfs HAUtil api that is nont-compatible wi⦠â¦th hadoop 2.8 + Use Java's MethodHandle (dynamic lang support) rather than Method (reflection) in FileContextLocationUtil + Expose static API rather than the handle itself You can merge this pull request into a Git repository by running: $ git pull https://github.com/yufeldman/twill branch-TWILL-237 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/55.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #55 commit fe615a3af55ec9fd29640f3c03cb56de36062d96 Author: Sudheesh Katkam Date: 2017-06-16T22:42:18Z (TWILL-237) Twill is using hdfs HAUtil api that is nont-compatible with hadoop 2.8 + Use Java's MethodHandle (dynamic lang support) rather than Method (reflection) in FileContextLocationUtil + Expose static API rather than the handle itself --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill pull request #39: (TWILL-225) Refactor TwillPreprer to allow configura...
Github user yufeldman commented on a diff in the pull request:
https://github.com/apache/twill/pull/39#discussion_r107004427
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -155,25 +153,16 @@ public String apply(Class cls) {
private ClassAcceptor classAcceptor;
private final Map maxRetries = Maps.newHashMap();
- YarnTwillPreparer(YarnConfiguration yarnConfig, TwillSpecification
twillSpec, RunId runId,
-YarnAppClient yarnAppClient, String zkConnectString,
Location appLocation, Set twillClassPaths,
+ YarnTwillPreparer(Configuration config, TwillSpecification twillSpec,
RunId runId,
--- End diff --
Any particular reason to switch to Configuration from YarnConfiguration?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] twill pull request #33: TWILL-216 Make ratio between total memory and on-hea...
Github user yufeldman commented on a diff in the pull request: https://github.com/apache/twill/pull/33#discussion_r101817212 --- Diff: twill-core/src/main/java/org/apache/twill/internal/json/TwillRuntimeSpecificationCodec.java --- @@ -94,6 +96,8 @@ public TwillRuntimeSpecification deserialize(JsonElement json, Type typeOfT, jsonObj.has(RM_SCHEDULER_ADDR) ? jsonObj.get(RM_SCHEDULER_ADDR).getAsString() : null, logLevels, - maxRetries); + maxRetries, + jsonObj.has(HEAP_RESERVED_MIN_RATIO) ? --- End diff -- sure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill pull request #33: TWILL-216 Make ratio between total memory and on-hea...
GitHub user yufeldman opened a pull request: https://github.com/apache/twill/pull/33 TWILL-216 Make ratio between total memory and on-heap memory configur⦠â¦able You can merge this pull request into a Git repository by running: $ git pull https://github.com/yufeldman/twill branch-TWILL-216 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/33.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #33 commit 6f721f696452bb6124cf5b53b285fe60db75ff03 Author: Yuliya Feldman Date: 2017-02-10T21:05:20Z TWILL-216 Make ratio between total memory and on-heap memory configurable --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] twill pull request #28: TWILL-210 Ability to handle FileSystems that do not ...
GitHub user yufeldman opened a pull request: https://github.com/apache/twill/pull/28 TWILL-210 Ability to handle FileSystems that do not have authority You can merge this pull request into a Git repository by running: $ git pull https://github.com/yufeldman/twill branch-TWILL-210 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/28.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #28 commit 9bae0e9671dae95407902461da9f9f41e0e135eb Author: Yuliya Feldman Date: 2017-01-27T22:49:58Z TWILL-210 Ability to handle FileSystems that do not have authority --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
