[jira] [Commented] (TWILL-238) Change TwillController restartInstances API
[ https://issues.apache.org/jira/browse/TWILL-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089212#comment-16089212 ] ASF GitHub Bot commented on TWILL-238: -- Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/56 > Change TwillController restartInstances API > --- > > Key: TWILL-238 > URL: https://issues.apache.org/jira/browse/TWILL-238 > Project: Apache Twill > Issue Type: Improvement > Components: api >Reporter: Filippov Sergey >Assignee: Filippov Sergey >Priority: Minor > Fix For: 0.12.0 > > > Lets change signature from Future restartInstances(String runnable, > int instanceId, int... moreInstanceIds) to Future > restartInstances(String runnable, Interger instanceId, Integer... > moreInstanceIds) so it will be easier to convert from collections to vararg -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TWILL-238) Change TwillController restartInstances API
[ https://issues.apache.org/jira/browse/TWILL-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089210#comment-16089210 ] ASF GitHub Bot commented on TWILL-238: -- Github user chtyim commented on the issue: https://github.com/apache/twill/pull/56 LGTM. > Change TwillController restartInstances API > --- > > Key: TWILL-238 > URL: https://issues.apache.org/jira/browse/TWILL-238 > Project: Apache Twill > Issue Type: Improvement > Components: api >Reporter: Filippov Sergey >Assignee: Filippov Sergey >Priority: Minor > Fix For: 0.12.0 > > > Lets change signature from Future restartInstances(String runnable, > int instanceId, int... moreInstanceIds) to Future > restartInstances(String runnable, Interger instanceId, Integer... > moreInstanceIds) so it will be easier to convert from collections to vararg -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TWILL-238) Change TwillController restartInstances API
[ https://issues.apache.org/jira/browse/TWILL-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087128#comment-16087128 ] ASF GitHub Bot commented on TWILL-238: -- Github user fonelor commented on a diff in the pull request: https://github.com/apache/twill/pull/56#discussion_r127425262 --- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java --- @@ -17,15 +17,14 @@ */ package org.apache.twill.api; -import org.apache.twill.api.logging.LogEntry; -import org.apache.twill.api.logging.LogHandler; -import org.apache.twill.discovery.Discoverable; -import org.apache.twill.discovery.ServiceDiscovered; - import java.util.Map; import java.util.Set; import java.util.concurrent.Future; import javax.annotation.Nullable; +import org.apache.twill.api.logging.LogEntry; --- End diff -- i've reverted reformatting changes > Change TwillController restartInstances API > --- > > Key: TWILL-238 > URL: https://issues.apache.org/jira/browse/TWILL-238 > Project: Apache Twill > Issue Type: Improvement > Components: api >Reporter: Filippov Sergey >Assignee: Filippov Sergey >Priority: Minor > Fix For: 0.12.0 > > > Lets change signature from Future restartInstances(String runnable, > int instanceId, int... moreInstanceIds) to Future > restartInstances(String runnable, Interger instanceId, Integer... > moreInstanceIds) so it will be easier to convert from collections to vararg -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TWILL-238) Change TwillController restartInstances API
[ https://issues.apache.org/jira/browse/TWILL-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087129#comment-16087129 ] ASF GitHub Bot commented on TWILL-238: -- Github user fonelor commented on the issue: https://github.com/apache/twill/pull/56 Reverted reformatting > Change TwillController restartInstances API > --- > > Key: TWILL-238 > URL: https://issues.apache.org/jira/browse/TWILL-238 > Project: Apache Twill > Issue Type: Improvement > Components: api >Reporter: Filippov Sergey >Assignee: Filippov Sergey >Priority: Minor > Fix For: 0.12.0 > > > Lets change signature from Future restartInstances(String runnable, > int instanceId, int... moreInstanceIds) to Future > restartInstances(String runnable, Interger instanceId, Integer... > moreInstanceIds) so it will be easier to convert from collections to vararg -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TWILL-238) Change TwillController restartInstances API
[ https://issues.apache.org/jira/browse/TWILL-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087024#comment-16087024 ] ASF GitHub Bot commented on TWILL-238: -- Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/56#discussion_r126296669 --- Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java --- @@ -17,15 +17,14 @@ */ package org.apache.twill.api; -import org.apache.twill.api.logging.LogEntry; -import org.apache.twill.api.logging.LogHandler; -import org.apache.twill.discovery.Discoverable; -import org.apache.twill.discovery.ServiceDiscovered; - import java.util.Map; import java.util.Set; import java.util.concurrent.Future; import javax.annotation.Nullable; +import org.apache.twill.api.logging.LogEntry; --- End diff -- Please don't rearrange the imports. You can use the ide profiles available in http://twill.apache.org/HowToContribute.html > Change TwillController restartInstances API > --- > > Key: TWILL-238 > URL: https://issues.apache.org/jira/browse/TWILL-238 > Project: Apache Twill > Issue Type: Improvement > Components: api >Reporter: Filippov Sergey >Assignee: Filippov Sergey >Priority: Minor > Fix For: 0.12.0 > > > Lets change signature from Future restartInstances(String runnable, > int instanceId, int... moreInstanceIds) to Future > restartInstances(String runnable, Interger instanceId, Integer... > moreInstanceIds) so it will be easier to convert from collections to vararg -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TWILL-238) Change TwillController restartInstances API
[ https://issues.apache.org/jira/browse/TWILL-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081816#comment-16081816 ] ASF GitHub Bot commented on TWILL-238: -- Github user fonelor commented on the issue: https://github.com/apache/twill/pull/56 Thank you, serranom, for your comment. Is there any way to set "right" order of imports in IDEA? I've imported settings from HowToContribute page, but it seems, that it still wants to move imports. > Change TwillController restartInstances API > --- > > Key: TWILL-238 > URL: https://issues.apache.org/jira/browse/TWILL-238 > Project: Apache Twill > Issue Type: Improvement > Components: api >Reporter: Filippov Sergey >Assignee: Filippov Sergey >Priority: Minor > Fix For: 0.12.0 > > > Lets change signature from Future restartInstances(String runnable, > int instanceId, int... moreInstanceIds) to Future > restartInstances(String runnable, Interger instanceId, Integer... > moreInstanceIds) so it will be easier to convert from collections to vararg -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TWILL-238) Change TwillController restartInstances API
[ https://issues.apache.org/jira/browse/TWILL-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079099#comment-16079099 ] ASF GitHub Bot commented on TWILL-238: -- GitHub user fonelor opened a pull request: https://github.com/apache/twill/pull/56 implemented issue TWILL-238: restart instances with Set of Integers Implemented https://issues.apache.org/jira/browse/TWILL-238 New method in TwillController to restart instances of runnable You can merge this pull request into a Git repository by running: $ git pull https://github.com/fonelor/twill feature/238_restartinstances_api Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/56.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #56 commit eb184e6aa727d93fce4e6e4e33c729eb09017750 Author: Sergey Filippov Date: 2017-07-08T11:24:22Z implemented issue TWILL-238: restart instances with Set of Integers > Change TwillController restartInstances API > --- > > Key: TWILL-238 > URL: https://issues.apache.org/jira/browse/TWILL-238 > Project: Apache Twill > Issue Type: Improvement > Components: api >Reporter: Filippov Sergey >Priority: Minor > > Lets change signature from Future restartInstances(String runnable, > int instanceId, int... moreInstanceIds) to Future > restartInstances(String runnable, Interger instanceId, Integer... > moreInstanceIds) so it will be easier to convert from collections to vararg -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TWILL-238) Change TwillController restartInstances API
[ https://issues.apache.org/jira/browse/TWILL-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078347#comment-16078347 ] Terence Yim commented on TWILL-238: --- Instead of changing, it is better to add one that takes Collection to maintain compatibility. > Change TwillController restartInstances API > --- > > Key: TWILL-238 > URL: https://issues.apache.org/jira/browse/TWILL-238 > Project: Apache Twill > Issue Type: Improvement > Components: api >Reporter: Filippov Sergey >Priority: Minor > > Lets change signature from Future restartInstances(String runnable, > int instanceId, int... moreInstanceIds) to Future > restartInstances(String runnable, Interger instanceId, Integer... > moreInstanceIds) so it will be easier to convert from collections to vararg -- This message was sent by Atlassian JIRA (v6.4.14#64029)
