Re: [DISCUSS] Allow external contributors to run CI without approval
Thanks for your support, I'll come up with a JIRA ticket to change this setting to "only requires approval first time". zhang junfan 于2023年9月8日周五 20:08写道： > +1. thanks jerqi. > > Best > Junfan Zhang > > 发件人: roryqi > 发送时间: Saturday, September 2, 2023 3:56:54 PM > 收件人: dev@uniffle.apache.org > 主题: [DISCUSS] Allow external contributors to run CI without approval > > Recent moves by Apache Infra have changed the policy on GitHub Actions from > "Only requires approval first time" to "Requires approval every time". I > think this is not friendly for getting folks involved in the project and > this increased the cost for committers to process the pull requests. Please > respond to this thread if you are in support of going back to "Only > requires approval the first time" or if you don't believe this is a good > idea please respond as well. Thanks, > Rory >
Re: [DISCUSS] Allow external contributors to run CI without approval
+1. thanks jerqi. Best Junfan Zhang 发件人: roryqi 发送时间: Saturday, September 2, 2023 3:56:54 PM 收件人: dev@uniffle.apache.org 主题: [DISCUSS] Allow external contributors to run CI without approval Recent moves by Apache Infra have changed the policy on GitHub Actions from "Only requires approval first time" to "Requires approval every time". I think this is not friendly for getting folks involved in the project and this increased the cost for committers to process the pull requests. Please respond to this thread if you are in support of going back to "Only requires approval the first time" or if you don't believe this is a good idea please respond as well. Thanks, Rory
Re: [DISCUSS] Allow external contributors to run CI without approval
+1, thanks roryqi roryqi 于2023年9月3日周日 21:36写道： > They're two things. We just want to reduce the Commiters' work by changing > the policy to "Only requires approval first time". Many contributors aren't > familiar with Github actions, too. Commiters also should notice that no > one abuse Github action. > > Xiang Chen 于2023年9月3日周日 16:33写道： > > > Hi~ > > > > As far as I know, if committers fork the project, normally. When the > > committers make changes to their own fork project, it will trigger their > > own project's github action. > > > > I myself often submit PR after validation of my fork project. Maybe they > > could do that in first commit too? > > > > On 2023/09/02 07:56:54 roryqi wrote: > > > Recent moves by Apache Infra have changed the policy on GitHub Actions > > from > > > "Only requires approval first time" to "Requires approval every time". > I > > > think this is not friendly for getting folks involved in the project > and > > > this increased the cost for committers to process the pull requests. > > Please > > > respond to this thread if you are in support of going back to "Only > > > requires approval the first time" or if you don't believe this is a > good > > > idea please respond as well. Thanks, > > > Rory > > > > > >
Re: [DISCUSS] Allow external contributors to run CI without approval
They're two things. We just want to reduce the Commiters' work by changing the policy to "Only requires approval first time". Many contributors aren't familiar with Github actions, too. Commiters also should notice that no one abuse Github action. Xiang Chen 于2023年9月3日周日 16:33写道： > Hi~ > > As far as I know, if committers fork the project, normally. When the > committers make changes to their own fork project, it will trigger their > own project's github action. > > I myself often submit PR after validation of my fork project. Maybe they > could do that in first commit too? > > On 2023/09/02 07:56:54 roryqi wrote: > > Recent moves by Apache Infra have changed the policy on GitHub Actions > from > > "Only requires approval first time" to "Requires approval every time". I > > think this is not friendly for getting folks involved in the project and > > this increased the cost for committers to process the pull requests. > Please > > respond to this thread if you are in support of going back to "Only > > requires approval the first time" or if you don't believe this is a good > > idea please respond as well. Thanks, > > Rory > > >
Re: [DISCUSS] Allow external contributors to run CI without approval
Hi~ As far as I know, if committers fork the project, normally. When the committers make changes to their own fork project, it will trigger their own project's github action. I myself often submit PR after validation of my fork project. Maybe they could do that in first commit too? On 2023/09/02 07:56:54 roryqi wrote: > Recent moves by Apache Infra have changed the policy on GitHub Actions from > "Only requires approval first time" to "Requires approval every time". I > think this is not friendly for getting folks involved in the project and > this increased the cost for committers to process the pull requests. Please > respond to this thread if you are in support of going back to "Only > requires approval the first time" or if you don't believe this is a good > idea please respond as well. Thanks, > Rory >
Re: [DISCUSS] Allow external contributors to run CI without approval
+1thanks rory On Sat, 02 Sep 2023 15:56:54 +0800 roryqi wrote Recent moves by Apache Infra have changed the policy on GitHub Actions from "Only requires approval first time" to "Requires approval every time". I think this is not friendly for getting folks involved in the project and this increased the cost for committers to process the pull requests. Please respond to this thread if you are in support of going back to "Only requires approval the first time" or if you don't believe this is a good idea please respond as well. Thanks, Rory
[DISCUSS] Allow external contributors to run CI without approval
Recent moves by Apache Infra have changed the policy on GitHub Actions from "Only requires approval first time" to "Requires approval every time". I think this is not friendly for getting folks involved in the project and this increased the cost for committers to process the pull requests. Please respond to this thread if you are in support of going back to "Only requires approval the first time" or if you don't believe this is a good idea please respond as well. Thanks, Rory
