Re: [DISCUSS] Can we improve the playground app project?

2019-02-26 Thread 申远
>
> 1. Default to use the public version but no local compile package, like
> `com.taobao.android:weex_sdk:0.20.3.0-beta`, that can be work on anywhere.


As local compiling is a feature, not a bug, and updating the default
version is painful as well. Maybe you should write version info in a
xml/json file, the code of playground will use the version specified if it
exists or local compiling if it not exists.

2. Adding XML parser to parse `app/src/main/res/xml/app_config.xml` which
> Weex Cli rely on it to modify package info.


No problem.

3. Adding logic to parser `.weex_plugin.json` the file which on the root
> path, it may content like this, `[ { "name": "WXLottie", "dependency":
> "org.asialee.weex:weexplugin:1.0.2" } ]`, and then you should put this
> plugin load into the grade building process.


The json parser is handled by *WeexPluginContainer.loadAll *if the format
and location of your json file is matched with *WeexPluginContainer*.  I
will just invoke *WeexPluginContainer.loadAll *instead.

BTW: *WeexPluginContainer.loadAll *iterates json file
under app/src/main/assets, not root path.


Best Regards,
YorkShen

申远


Dan  于2019年2月27日周三 下午12:09写道:

> There are three necessary features that need to be adapted:
>
> 1. Default to use the public version but no local compile package, like
> `com.taobao.android:weex_sdk:0.20.3.0-beta`, that can be work on anywhere.
> 2. Adding XML parser to parse `app/src/main/res/xml/app_config.xml` which
> Weex Cli rely on it to modify package info.
> 3. Adding logic to parser `.weex_plugin.json` the file which on the root
> path, it may content like this, `[ { "name": "WXLottie", "dependency":
> "org.asialee.weex:weexplugin:1.0.2" } ]`, and then you should put this
> plugin load into the grade building process.
>
> For testing your work has worked or not, you can create a template repo in
> your git, like this
> https://github.com/weex-templates/weex-playground-android, try the
> following command to put the template into your weex project:
>
> ```
> $ weex create 
> $ cd 
> $ weex platform add # android
> $ weex plugin add weex-plugin-lottie
> $ weex run android
> ```
>
> If it works fine, you can tell me, I will do the double check.
>
> Thanks,
> Dan
>
>
>
> 申远  于2019年2月27日周三 上午10:51写道:
>
> > I'd like to help you do the merge/rewrite of Android.
> >
> > Could you please list the feature you need? It seems like this two repos
> is
> > different in many ways, maybe cherry-pick is a better idea.
> >
> > Best Regards,
> > YorkShen
> >
> > 申远
> >
> >
> > Dan  于2019年2月26日周二 下午10:22写道:
> >
> > > Hi, all
> > >
> > > Recently I tried to upgrade the weexSDK version of android weex
> > playground
> > > app that I rely on in the Weex Cli, user can use `weex platform add
> > > android` to add this project into the workspace.
> > >
> > > Here's the template project which the Weex Cli rely on:
> > >
> > > [0] [Android Template](
> > > https://github.com/weex-templates/weex-playground-android.git)
> > > [1] [iOS Template](
> > > https://github.com/weex-templates/weex-playground-ios.git
> > > )
> > >
> > > I try to upgrade the weex SDK version thought to edit the `grade.build`
> > > file into the android project,  but I got failed cause some class has
> > been
> > > removed on the new weexSDK, such as `IWXDebugProxy`, `WXErrorCode` and
> so
> > > on.
> > >
> > > These two projects cannot be upgraded in time according to the changes
> of
> > > weexSDK, but the playground app on weexSDK project will be upgraded
> after
> > > the SDK changed, see:
> > >
> > > [0] (Android Playground project)[
> > >
> >
> https://github.com/apache/incubator-weex/tree/master/android/playground/app
> > > ].
> > > [1] (iOS Playground project)[
> > >
> >
> https://github.com/apache/incubator-weex/tree/master/android/playground/app
> > > ].
> > >
> > > Although the template project has some designs for the Weex Cli, I
> still
> > > think we can maintain these two projects in one project, just put some
> > > config logic into the playground app which maintained in the official
> > > project.
> > >
> > > I will create a pull request to merge the iOS playground app project,
> Is
> > > there anyone else who can help with the Android merge? I will list the
> > > corresponding modification points for the corresponding modification.
> > >
> > > Thanks,
> > > Dan
> > >
> >
>


Re: [DISCUSS] Can we improve the playground app project?

2019-02-26 Thread Dan
There are three necessary features that need to be adapted:

1. Default to use the public version but no local compile package, like
`com.taobao.android:weex_sdk:0.20.3.0-beta`, that can be work on anywhere.
2. Adding XML parser to parse `app/src/main/res/xml/app_config.xml` which
Weex Cli rely on it to modify package info.
3. Adding logic to parser `.weex_plugin.json` the file which on the root
path, it may content like this, `[ { "name": "WXLottie", "dependency":
"org.asialee.weex:weexplugin:1.0.2" } ]`, and then you should put this
plugin load into the grade building process.

For testing your work has worked or not, you can create a template repo in
your git, like this
https://github.com/weex-templates/weex-playground-android, try the
following command to put the template into your weex project:

```
$ weex create 
$ cd 
$ weex platform add # android
$ weex plugin add weex-plugin-lottie
$ weex run android
```

If it works fine, you can tell me, I will do the double check.

Thanks,
Dan



申远  于2019年2月27日周三 上午10:51写道:

> I'd like to help you do the merge/rewrite of Android.
>
> Could you please list the feature you need? It seems like this two repos is
> different in many ways, maybe cherry-pick is a better idea.
>
> Best Regards,
> YorkShen
>
> 申远
>
>
> Dan  于2019年2月26日周二 下午10:22写道:
>
> > Hi, all
> >
> > Recently I tried to upgrade the weexSDK version of android weex
> playground
> > app that I rely on in the Weex Cli, user can use `weex platform add
> > android` to add this project into the workspace.
> >
> > Here's the template project which the Weex Cli rely on:
> >
> > [0] [Android Template](
> > https://github.com/weex-templates/weex-playground-android.git)
> > [1] [iOS Template](
> > https://github.com/weex-templates/weex-playground-ios.git
> > )
> >
> > I try to upgrade the weex SDK version thought to edit the `grade.build`
> > file into the android project,  but I got failed cause some class has
> been
> > removed on the new weexSDK, such as `IWXDebugProxy`, `WXErrorCode` and so
> > on.
> >
> > These two projects cannot be upgraded in time according to the changes of
> > weexSDK, but the playground app on weexSDK project will be upgraded after
> > the SDK changed, see:
> >
> > [0] (Android Playground project)[
> >
> https://github.com/apache/incubator-weex/tree/master/android/playground/app
> > ].
> > [1] (iOS Playground project)[
> >
> https://github.com/apache/incubator-weex/tree/master/android/playground/app
> > ].
> >
> > Although the template project has some designs for the Weex Cli, I still
> > think we can maintain these two projects in one project, just put some
> > config logic into the playground app which maintained in the official
> > project.
> >
> > I will create a pull request to merge the iOS playground app project, Is
> > there anyone else who can help with the Android merge? I will list the
> > corresponding modification points for the corresponding modification.
> >
> > Thanks,
> > Dan
> >
>


Re: [DISCUSS] Can we improve the playground app project?

2019-02-26 Thread 申远
I'd like to help you do the merge/rewrite of Android.

Could you please list the feature you need? It seems like this two repos is
different in many ways, maybe cherry-pick is a better idea.

Best Regards,
YorkShen

申远


Dan  于2019年2月26日周二 下午10:22写道:

> Hi, all
>
> Recently I tried to upgrade the weexSDK version of android weex playground
> app that I rely on in the Weex Cli, user can use `weex platform add
> android` to add this project into the workspace.
>
> Here's the template project which the Weex Cli rely on:
>
> [0] [Android Template](
> https://github.com/weex-templates/weex-playground-android.git)
> [1] [iOS Template](
> https://github.com/weex-templates/weex-playground-ios.git
> )
>
> I try to upgrade the weex SDK version thought to edit the `grade.build`
> file into the android project,  but I got failed cause some class has been
> removed on the new weexSDK, such as `IWXDebugProxy`, `WXErrorCode` and so
> on.
>
> These two projects cannot be upgraded in time according to the changes of
> weexSDK, but the playground app on weexSDK project will be upgraded after
> the SDK changed, see:
>
> [0] (Android Playground project)[
> https://github.com/apache/incubator-weex/tree/master/android/playground/app
> ].
> [1] (iOS Playground project)[
> https://github.com/apache/incubator-weex/tree/master/android/playground/app
> ].
>
> Although the template project has some designs for the Weex Cli, I still
> think we can maintain these two projects in one project, just put some
> config logic into the playground app which maintained in the official
> project.
>
> I will create a pull request to merge the iOS playground app project, Is
> there anyone else who can help with the Android merge? I will list the
> corresponding modification points for the corresponding modification.
>
> Thanks,
> Dan
>