Re: Replacing div/ with div/div
On 11/5/07, Matej Knopp [EMAIL PROTECTED] wrote: Okay, I might have overlooked the *or* part with implicates that empty element shorthand should not be used for non-empty elements. Still this leaves us with 3 options. a) ignore things silently and then support lot of weird bugreport of user complaining that ajax is not working in firefox (because of the messed up DOM tree) b) fix the error for user (which is current behavior) c) throw an exception or warn user somehow If you will decide for option B, then please do it for all elements that are declared as non-EMPTY. tag/tag will be valid for all non-EMPTY elements in both HTML and XHTML. Now given that div/ might not actually be permitted in xhtml (though I'm still not 100% convinced) If you find any information that I might be wrong, then please tell me. Because it is not very logical to me too. I prefer to be wrong in this case. option c) could be better alternative to b), though I'd still insisted on doing it by default. However, we would need then some kind of mechanism that would allow us to suppress the behavior in case the document is actually an xml document and will be served as xml document. You might consider not supressing it since div/div is valid XML. Equal in XML yes. And yes, XHTML files are valid XML documents. However not all XML documents are valid XHTML files, even when using XHTML tag names. Which is kinda weird. Yes, it is weird. I was under impression that as long as you stick to the doctype (or xsd) all xml documents would be valid xhtml documents. No, not all rules can be fully expressed in DTD or even XML schema's. They only validate part of the rules. Yes, IE does not understand application/xml. And that is why I suspect that rule 4.3 exists. So that xhtml 1.0 could be server to IE, and the result would be equivalent as serving html 4.01. Ironically, IE doesn't have any problem with empty elements such as div/. That's because IE considers the DIV end tag optional, while in fact it is required.
Re: [VOTE] Release Wicket 1.3.0 release candidate 1
Even so, it's better to have a RC-2 than Beta-6 :) (beta5 - rc1) The community trusts more on release candidates than betas. :D On Nov 5, 2007 10:51 AM, Johan Compagner [EMAIL PROTECTED] wrote: really, do you think? i am pretty confident that rc1 can be promoted to GA :) johan On 11/5/07, Al Maw [EMAIL PROTECTED] wrote: [x] Release Apache Wicket 1.3.0-rc1 Yeah, go for it. It's a little bit disingenuous, because I'm sure we'll need an rc2 before we get a final release out, but hey. ;-) Regards, Al -- Bruno Borges blog.brunoborges.com.br +55 1185657739 The glory of great men should always be measured by the means they have used to acquire it. - Francois de La Rochefoucauld
Re: Future of the wicketframework.org domain
i find this idea nice, too Regards, Korbinian PS: if the cost of the domain is an issue, then dump me an email and ill pay these bucks - 10 euro / year is not an issue regarding a great piece of software IMHO... Bruno Borges schrieb: I'd like to suggest to turn wicketframework.org into a front door for all kind of Wicket information. Link to Wicket Stuff, tutorials, mailing list, Apache's website, etc. If you go to http://www.opencompositing.org/ you will see what I'm talking about. This website is about Compiz, Beryl and everything related with the 3D (AIGLX/Xgl) Linux environment. I think this would give new users an easy starting point to join Wicket. :) m2c On Nov 4, 2007 6:22 PM, Martijn Dashorst [EMAIL PROTECTED] wrote: On 11/4/07, Johan Compagner [EMAIL PROTECTED] wrote: I meant going yourself, not paying for me! But i have no problem if somebody is paying for me!! :) Neither do I, but I found the difference between keeping wicketfarmework.org alive (about 10-15 euros per year) in stark contrast to a ticket for ApacheCon (last year roughly 400 euros) :-) Martijn -- Buy Wicket in Action: http://manning.com/dashorst Apache Wicket 1.3.0-beta4 is released Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta4/
Re: Future of the wicketframework.org domain
Bruno Borges wrote: I'd like to suggest to turn wicketframework.org into a front door for all kind of Wicket information. Link to Wicket Stuff, tutorials, mailing list, Apache's website, etc. With all respect, I completely disagree with this suggestion. ;-) We most certainly do not want to fracture things into two web sites which will get out of sync, require two sets of news postings, have duplicate information that will potentially conflict, etc. etc. Having lots of different URLs and sites is very confusing for new users. Witness the old wiki getting out of date and confusing people. The only thing we need to put on secondary sites are: 1) The wiki. 2) Stuff that's not ASF-license compatible (wicketstuff). Err, I think that's it. wicket.apache.org is, and should continue to be, the front door. It already has all the links that you mention. If you don't think it's good enough at doing that job, feedback is welcome. Regarding what we should therefore do with wicketframework.org, I vote we just let it lapse. One fewer thing to manage and worry about. Regards, Al
Re: Future of the wicketframework.org domain
wicketframework.org would not provide useful information but links to the real websites... like opencompositing.org does :) On Nov 5, 2007 3:58 PM, Al Maw [EMAIL PROTECTED] wrote: Bruno Borges wrote: I'd like to suggest to turn wicketframework.org into a front door for all kind of Wicket information. Link to Wicket Stuff, tutorials, mailing list, Apache's website, etc. With all respect, I completely disagree with this suggestion. ;-) We most certainly do not want to fracture things into two web sites which will get out of sync, require two sets of news postings, have duplicate information that will potentially conflict, etc. etc. Having lots of different URLs and sites is very confusing for new users. Witness the old wiki getting out of date and confusing people. The only thing we need to put on secondary sites are: 1) The wiki. 2) Stuff that's not ASF-license compatible (wicketstuff). Err, I think that's it. wicket.apache.org is, and should continue to be, the front door. It already has all the links that you mention. If you don't think it's good enough at doing that job, feedback is welcome. Regarding what we should therefore do with wicketframework.org, I vote we just let it lapse. One fewer thing to manage and worry about. Regards, Al -- Bruno Borges blog.brunoborges.com.br +55 1185657739 The glory of great men should always be measured by the means they have used to acquire it. - Francois de La Rochefoucauld
Re: [VOTE] Release Wicket 1.3.0 release candidate 1
+0 (I don't have the time to test the release, but don't want to hold it back). The release does have your signature, so that's cool (just need to verify you are actually you). Martijn On 11/4/07, Frank Bille [EMAIL PROTECTED] wrote: Hi all, I have uploaded the artifacts to my p.a.o account. This is what I have tested: * Run mvn clean install on the distribution. Installs, no test failures. * Run RAT[1] on the release and checked the output. Nothing to notice. * Tried different things in the examples, like ajax, links, images, forms, guice and pub2. Nothing to notice. The releases has been signed with my GPG key, which you can find in the KEYS[2] file. It's still not signed by anyone (lazy me) Anyway, here you can find the distribution files: http://people.apache.org/~frankbille/releases/apache-wicket-1.3.0-rc1/dist/ http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.3.0-rc1/dist/ and here you can find the maven repo: http://people.apache.org/~frankbille/releases/apache-wicket-1.3.0-rc1/m2-repo/http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.3.0-rc1/m2-repo/ and here I have uploaded the RAT logs: http://people.apache.org/~frankbille/releases/apache-wicket-1.3.0-rc1/http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.3.0-rc1/ [ ] Release Apache Wicket 1.3.0-rc1 [ ] Don't release, because... Regards Frank [1]: http://code.google.com/p/arat/ [2]: http://svn.apache.org/repos/asf/wicket/common/KEYS -- Buy Wicket in Action: http://manning.com/dashorst Apache Wicket 1.3.0-beta4 is released Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta4/
Re: On resource bundles and component path's
I'll take a quick look (it's in my best interest too) Martijn On 11/5/07, Eelco Hillenius [EMAIL PROTECTED] wrote: On 11/4/07, Eelco Hillenius [EMAIL PROTECTED] wrote: On 10/28/07, Martijn Dashorst [EMAIL PROTECTED] wrote: Makes sense. And I see it works now perfectly. Thanks! Actually, it doesn't seem to work for me. I have DiscountsPage and UserPanel. The UserPanel is added to the page with id 'userPanel'. The user panel has wicket:message key=signed_in_as Matching signed_in_as in UserPanel.properties works, signed_in_as in DiscountPage.properties matches but userPanel.signed_in_as in DiscountsPage.properties does not. Anyone know why? The source is at http://wicketinaction.googlecode.com/svn/trunk/book-wicket-in-action, package wicket.in.action.chapter13.locdiscounts Sorry for pushing this. But if anyone with a little bit of time to spare could help me out, I could finally finish that friggin' chapter I'm working on. Basically, I want to know whether this is a bug I'm experiencing (possibly in my code), or whether I'm making the wrong assumption. Eelco -- Buy Wicket in Action: http://manning.com/dashorst Apache Wicket 1.3.0-beta4 is released Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta4/
Re: [VOTE] Release Wicket 1.3.0 release candidate 1
I've taken some time to test the release, but I get the following test failure on OS X, Java 4: [surefire] Running org.apache.wicket.markup.html.image.ImageTest [surefire] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0.037 sec FAILURE !! So that would be a -1? Martijn On 11/5/07, Martijn Dashorst [EMAIL PROTECTED] wrote: +0 (I don't have the time to test the release, but don't want to hold it back). The release does have your signature, so that's cool (just need to verify you are actually you). Martijn On 11/4/07, Frank Bille [EMAIL PROTECTED] wrote: Hi all, I have uploaded the artifacts to my p.a.o account. This is what I have tested: * Run mvn clean install on the distribution. Installs, no test failures. * Run RAT[1] on the release and checked the output. Nothing to notice. * Tried different things in the examples, like ajax, links, images, forms, guice and pub2. Nothing to notice. The releases has been signed with my GPG key, which you can find in the KEYS[2] file. It's still not signed by anyone (lazy me) Anyway, here you can find the distribution files: http://people.apache.org/~frankbille/releases/apache-wicket-1.3.0-rc1/dist/ http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.3.0-rc1/dist/ and here you can find the maven repo: http://people.apache.org/~frankbille/releases/apache-wicket-1.3.0-rc1/m2-repo/http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.3.0-rc1/m2-repo/ and here I have uploaded the RAT logs: http://people.apache.org/~frankbille/releases/apache-wicket-1.3.0-rc1/http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.3.0-rc1/ [ ] Release Apache Wicket 1.3.0-rc1 [ ] Don't release, because... Regards Frank [1]: http://code.google.com/p/arat/ [2]: http://svn.apache.org/repos/asf/wicket/common/KEYS -- Buy Wicket in Action: http://manning.com/dashorst Apache Wicket 1.3.0-beta4 is released Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta4/ -- Buy Wicket in Action: http://manning.com/dashorst Apache Wicket 1.3.0-beta4 is released Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta4/
Re: [VOTE] Release Wicket 1.3.0 release candidate 1
Hmm, thats weird. I have built on linux and as you know the release.shrequires a mvn and mvn4 ( 1.4). Så it should have been build and tested using the correct jre's. Can anyone shed some light on this failing test? I can't (apparantly) reproduce it. Frank On Nov 5, 2007 10:49 PM, Martijn Dashorst [EMAIL PROTECTED] wrote: I've taken some time to test the release, but I get the following test failure on OS X, Java 4: [surefire] Running org.apache.wicket.markup.html.image.ImageTest [surefire] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0.037 sec FAILURE !! So that would be a -1? Martijn On 11/5/07, Martijn Dashorst [EMAIL PROTECTED] wrote: +0 (I don't have the time to test the release, but don't want to hold it back). The release does have your signature, so that's cool (just need to verify you are actually you). Martijn On 11/4/07, Frank Bille [EMAIL PROTECTED] wrote: Hi all, I have uploaded the artifacts to my p.a.o account. This is what I have tested: * Run mvn clean install on the distribution. Installs, no test failures. * Run RAT[1] on the release and checked the output. Nothing to notice. * Tried different things in the examples, like ajax, links, images, forms, guice and pub2. Nothing to notice. The releases has been signed with my GPG key, which you can find in the KEYS[2] file. It's still not signed by anyone (lazy me) Anyway, here you can find the distribution files: http://people.apache.org/~frankbille/releases/apache-wicket-1.3.0-rc1/dist/http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.3.0-rc1/dist/ http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.3.0-rc1/dist/ and here you can find the maven repo: http://people.apache.org/~frankbille/releases/apache-wicket-1.3.0-rc1/m2-repo/http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.3.0-rc1/m2-repo/ http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.3.0-rc1/m2-repo/ and here I have uploaded the RAT logs: http://people.apache.org/~frankbille/releases/apache-wicket-1.3.0-rc1/http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.3.0-rc1/ http://people.apache.org/%7Efrankbille/releases/apache-wicket-1.3.0-rc1/ [ ] Release Apache Wicket 1.3.0-rc1 [ ] Don't release, because... Regards Frank [1]: http://code.google.com/p/arat/ [2]: http://svn.apache.org/repos/asf/wicket/common/KEYS -- Buy Wicket in Action: http://manning.com/dashorst Apache Wicket 1.3.0-beta4 is released Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta4/ -- Buy Wicket in Action: http://manning.com/dashorst Apache Wicket 1.3.0-beta4 is released Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0-beta4/
Re: svn commit: r592171 - in /wicket/trunk/jdk-1.4/wicket/src: main/java/org/apache/wicket/markup/html/image/resource/ test/java/org/apache/wicket/markup/html/form/imagebutton/ test/java/org/apache/wi
This fixes the build on my machine.
Martijn
On 11/5/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
Author: jcompagner
Date: Mon Nov 5 14:41:00 2007
New Revision: 592171
URL: http://svn.apache.org/viewvc?rev=592171view=rev
Log:
If the package resource was already loaded for the default locale then the
resource reference locale was not set the second time
Modified:
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/form/imagebutton/ImageButtonTest.java
wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/image/ImageTest.java
Modified:
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java?rev=592171r1=592170r2=592171view=diff
==
---
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
(original)
+++
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
Mon Nov 5 14:41:00 2007
@@ -181,6 +181,11 @@
// Then dereference the resource
resource = resourceReference.getResource();
+
+ if (resource instanceof PackageResource)
+ {
+
resourceReference.setLocale(((PackageResource)resource).getLocale());
+ }
}
}
@@ -254,8 +259,8 @@
Locale l = component.getLocale();
String s = component.getStyle();
if (resourceKind == null
- (!Objects.equal(locale, component.getLocale()) ||
!Objects.equal(style, component
- .getStyle(
+ (!Objects.equal(locale, component.getLocale()) ||
!Objects.equal(style,
+ component.getStyle(
{
// Get new component locale and style
locale = component.getLocale();
@@ -415,8 +420,7 @@
if (valueParser.matches())
{
final String imageReferenceName =
valueParser.getImageReferenceName();
- final String specification =
Strings.replaceHtmlEscapeNumber(valueParser
- .getSpecification());
+ final String specification =
Strings.replaceHtmlEscapeNumber(valueParser.getSpecification());
final String factoryName =
valueParser.getFactoryName();
final Application application =
component.getApplication();
@@ -429,8 +433,8 @@
{
// Resource not available yet, so
create it with factory and
// share via Application
- final Resource imageResource =
getResourceFactory(application, factoryName)
- .newResource(specification,
locale, style);
+ final Resource imageResource =
getResourceFactory(application, factoryName).newResource(
+ specification, locale, style);
application.getSharedResources().add(Application.class, imageReferenceName,
locale, style, imageResource);
}
Modified:
wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/form/imagebutton/ImageButtonTest.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/form/imagebutton/ImageButtonTest.java?rev=592171r1=592170r2=592171view=diff
==
---
wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/form/imagebutton/ImageButtonTest.java
(original)
+++
wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/form/imagebutton/ImageButtonTest.java
Mon Nov 5 14:41:00 2007
@@ -16,6 +16,8 @@
*/
package org.apache.wicket.markup.html.form.imagebutton;
+import java.util.Locale;
+
import org.apache.wicket.WicketTestCase;
/**
@@ -39,6 +41,8 @@
*/
public void test_1() throws Exception
{
+ Locale.setDefault(new Locale(en, US));
+
tester.startPage(Home.class);
Re: svn commit: r592171 - in /wicket/trunk/jdk-1.4/wicket/src: main/java/org/apache/wicket/markup/html/image/resource/ test/java/org/apache/wicket/markup/html/form/imagebutton/ test/java/org/apache/wi
Ok sounds good. I think we should rebuild the release then. The problem is
just that I can't do it until Wednesday.
Johan can I get you to commit that thing to the release branch as well?
(under releases)
Frank
On Nov 5, 2007 11:47 PM, Martijn Dashorst [EMAIL PROTECTED]
wrote:
This fixes the build on my machine.
Martijn
On 11/5/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
Author: jcompagner
Date: Mon Nov 5 14:41:00 2007
New Revision: 592171
URL: http://svn.apache.org/viewvc?rev=592171view=rev
Log:
If the package resource was already loaded for the default locale then
the resource reference locale was not set the second time
Modified:
wicket/trunk/jdk-1.4
/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
wicket/trunk/jdk-1.4
/wicket/src/test/java/org/apache/wicket/markup/html/form/imagebutton/ImageButtonTest.java
wicket/trunk/jdk-1.4
/wicket/src/test/java/org/apache/wicket/markup/html/image/ImageTest.java
Modified: wicket/trunk/jdk-1.4
/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java?rev=592171r1=592170r2=592171view=diff
==
---
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
(original)
+++
wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/image/resource/LocalizedImageResource.java
Mon Nov 5 14:41:00 2007
@@ -181,6 +181,11 @@
// Then dereference the resource
resource = resourceReference.getResource();
+
+ if (resource instanceof PackageResource)
+ {
+ resourceReference.setLocale
(((PackageResource)resource).getLocale());
+ }
}
}
@@ -254,8 +259,8 @@
Locale l = component.getLocale();
String s = component.getStyle();
if (resourceKind == null
- (!Objects.equal(locale, component.getLocale())
|| !Objects.equal(style, component
- .getStyle(
+ (!Objects.equal(locale, component.getLocale())
|| !Objects.equal(style,
+ component.getStyle(
{
// Get new component locale and style
locale = component.getLocale();
@@ -415,8 +420,7 @@
if (valueParser.matches())
{
final String imageReferenceName =
valueParser.getImageReferenceName();
- final String specification =
Strings.replaceHtmlEscapeNumber(valueParser
- .getSpecification());
+ final String specification =
Strings.replaceHtmlEscapeNumber(valueParser.getSpecification());
final String factoryName =
valueParser.getFactoryName();
final Application application =
component.getApplication();
@@ -429,8 +433,8 @@
{
// Resource not available yet,
so create it with factory and
// share via Application
- final Resource imageResource =
getResourceFactory(application, factoryName)
-
.newResource(specification, locale, style);
+ final Resource imageResource =
getResourceFactory(application, factoryName).newResource(
+ specification, locale,
style);
application.getSharedResources
().add(Application.class, imageReferenceName,
locale, style,
imageResource);
}
Modified: wicket/trunk/jdk-1.4
/wicket/src/test/java/org/apache/wicket/markup/html/form/imagebutton/ImageButtonTest.java
URL:
http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/form/imagebutton/ImageButtonTest.java?rev=592171r1=592170r2=592171view=diff
==
---
wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/form/imagebutton/ImageButtonTest.java
(original)
+++
wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/html/form/imagebutton/ImageButtonTest.java
Mon Nov 5 14:41:00 2007
@@ -16,6 +16,8 @@
*/
package org.apache.wicket.markup.html.form.imagebutton;
Re: [VOTE] Release Wicket 1.3.0 release candidate 1
On 11/5/07, Martijn Dashorst [EMAIL PROTECTED] wrote: Johan has fixed the code and the tests. However, he assured me that the test failure shouldn't cause problems in application code. I'm changing my vote to -1. I think shipping a release candidate with a test failure gives the wrong impression. Though the failures don't occur on most machines, I think we should take the high road and rebuild the release with the patch in. The patch can be taken from head and applied to the release branch. The release can then be recreated and the vote restarted. I agree. But I don't have time tomorrow to do it, so it will be Wednesday. Frank
