Re: [VOTE] Release Apache Wicket 9.9.1
This vote passes! Thank you all! On 07/04/22 23:16, Thomas Heigl wrote: LGTM! On Thu, Apr 7, 2022 at 10:21 PM Andrea Del Bene wrote: Here is what I would write in the 'New and noteworthy' section: New and noteworthy -- This hotfix reverts WICKET-6963 which causes MarkupException in some particular cases. (see https://lists.apache.org/thread/y0zthfw2on04sm9wpn60my3x53b8cb3n). In addition, this release updates Spring Core dependency to version 5.3.18 which provides a fix for Spring4shell vulnerability (CVE-2022-22965). NOTE: Wicket is NOT directly impacted by Spring4shell. Your application might be exposed to this vulnerability only if you use Spring web frameworks (i.e. Spring MVC and Spring WebFlux). On 07/04/22 08:33, Maxim Solodovnik wrote: +1 - signatures - local build - main app On Wed, 6 Apr 2022 at 02:50, Sven Meier wrote: +1 Sven On 05.04.22 16:47, Tobias Soloschenko wrote: +1 kind regards Tobias Am 05.04.2022 um 12:42 schrieb Thomas Heigl : +1 Ran our CI build and repeated stress tests on our staging environment. On Mon, Apr 4, 2022 at 11:07 PM Andrea Del Bene < an.delb...@gmail.com> wrote: This is a vote to release Apache Wicket 9.9.1 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote lasts for 72 hours minimum. [ ] Yes, release Apache Wicket 9.9.1 [ ] No, don't release Apache Wicket 9.9.1, because ... Distributions, changelog, keys and signatures can be found at: https://dist.apache.org/repos/dist/dev/wicket/9.9.1 Staging repository: https://repository.apache.org/content/repositories/orgapachewicket-1174/ The binaries are available in the above link, as are a staging repository for Maven. Typically the vote is on the source, but should you find a problem with one of the binaries, please let me know, I can re-roll them some way or the other. Staging git repository data: Repository: g...@github.com:bitstorm/wicket.git Branch: build/wicket-9.9.1 Release tag: rel/wicket-9.9.1 CHANGELOG for 9.9.1: ** Bug * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore * [WICKET-6965] - Memory leak in WicketEndpoint ** Improvement * [WICKET-6963] - (REVERTED) Use singletons for PanelMarkupSourcingStrategy
Re: [VOTE] Release Apache Wicket 9.9.1
LGTM! On Thu, Apr 7, 2022 at 10:21 PM Andrea Del Bene wrote: > Here is what I would write in the 'New and noteworthy' section: > > New and noteworthy > -- > > This hotfix reverts WICKET-6963 which causes MarkupException in some > particular cases. > (see https://lists.apache.org/thread/y0zthfw2on04sm9wpn60my3x53b8cb3n). > In addition, this release updates Spring Core dependency to version > 5.3.18 which provides a fix > for Spring4shell vulnerability (CVE-2022-22965). > > NOTE: Wicket is NOT directly impacted by Spring4shell. Your application > might be exposed to this > vulnerability only if you use Spring web frameworks (i.e. Spring MVC and > Spring WebFlux). > > On 07/04/22 08:33, Maxim Solodovnik wrote: > > +1 > > > > - signatures > > - local build > > - main app > > > > On Wed, 6 Apr 2022 at 02:50, Sven Meier wrote: > >> +1 > >> > >> Sven > >> > >> On 05.04.22 16:47, Tobias Soloschenko wrote: > >>> +1 > >>> > >>> kind regards > >>> > >>> Tobias > >>> > Am 05.04.2022 um 12:42 schrieb Thomas Heigl : > > +1 > > Ran our CI build and repeated stress tests on our staging environment. > > > On Mon, Apr 4, 2022 at 11:07 PM Andrea Del Bene < > an.delb...@gmail.com> > > wrote: > > > > This is a vote to release Apache Wicket 9.9.1 > > > > Please download the source distributions found in our staging area > > linked below. > > > > I have included the signatures for both the source archives. This > vote > > lasts for 72 hours minimum. > > > > [ ] Yes, release Apache Wicket 9.9.1 > > [ ] No, don't release Apache Wicket 9.9.1, because ... > > > > Distributions, changelog, keys and signatures can be found at: > > > > https://dist.apache.org/repos/dist/dev/wicket/9.9.1 > > > > Staging repository: > > > > > https://repository.apache.org/content/repositories/orgapachewicket-1174/ > > > > The binaries are available in the above link, as are a staging > > repository for Maven. Typically the vote is on the source, but should > > you find a problem with one of the binaries, please let me know, I > can > > re-roll them some way or the other. > > > > Staging git repository data: > > > > Repository: g...@github.com:bitstorm/wicket.git > > Branch: build/wicket-9.9.1 > > Release tag: rel/wicket-9.9.1 > > > > > > > > > > > CHANGELOG for 9.9.1: > > > > ** Bug > > > > * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore > > * [WICKET-6965] - Memory leak in WicketEndpoint > > > > ** Improvement > > > > * [WICKET-6963] - (REVERTED) Use singletons for > > PanelMarkupSourcingStrategy > > > > > > >
Re: [VOTE] Release Apache Wicket 9.9.1
Here is what I would write in the 'New and noteworthy' section: New and noteworthy -- This hotfix reverts WICKET-6963 which causes MarkupException in some particular cases. (see https://lists.apache.org/thread/y0zthfw2on04sm9wpn60my3x53b8cb3n). In addition, this release updates Spring Core dependency to version 5.3.18 which provides a fix for Spring4shell vulnerability (CVE-2022-22965). NOTE: Wicket is NOT directly impacted by Spring4shell. Your application might be exposed to this vulnerability only if you use Spring web frameworks (i.e. Spring MVC and Spring WebFlux). On 07/04/22 08:33, Maxim Solodovnik wrote: +1 - signatures - local build - main app On Wed, 6 Apr 2022 at 02:50, Sven Meier wrote: +1 Sven On 05.04.22 16:47, Tobias Soloschenko wrote: +1 kind regards Tobias Am 05.04.2022 um 12:42 schrieb Thomas Heigl : +1 Ran our CI build and repeated stress tests on our staging environment. On Mon, Apr 4, 2022 at 11:07 PM Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.9.1 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote lasts for 72 hours minimum. [ ] Yes, release Apache Wicket 9.9.1 [ ] No, don't release Apache Wicket 9.9.1, because ... Distributions, changelog, keys and signatures can be found at: https://dist.apache.org/repos/dist/dev/wicket/9.9.1 Staging repository: https://repository.apache.org/content/repositories/orgapachewicket-1174/ The binaries are available in the above link, as are a staging repository for Maven. Typically the vote is on the source, but should you find a problem with one of the binaries, please let me know, I can re-roll them some way or the other. Staging git repository data: Repository: g...@github.com:bitstorm/wicket.git Branch: build/wicket-9.9.1 Release tag: rel/wicket-9.9.1 CHANGELOG for 9.9.1: ** Bug * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore * [WICKET-6965] - Memory leak in WicketEndpoint ** Improvement * [WICKET-6963] - (REVERTED) Use singletons for PanelMarkupSourcingStrategy
Re: [VOTE] Release Apache Wicket 9.9.1
+1 - signatures - local build - main app On Wed, 6 Apr 2022 at 02:50, Sven Meier wrote: > > +1 > > Sven > > On 05.04.22 16:47, Tobias Soloschenko wrote: > > +1 > > > > kind regards > > > > Tobias > > > >> Am 05.04.2022 um 12:42 schrieb Thomas Heigl : > >> > >> +1 > >> > >> Ran our CI build and repeated stress tests on our staging environment. > >> > >>> On Mon, Apr 4, 2022 at 11:07 PM Andrea Del Bene > >>> wrote: > >>> > >>> This is a vote to release Apache Wicket 9.9.1 > >>> > >>> Please download the source distributions found in our staging area > >>> linked below. > >>> > >>> I have included the signatures for both the source archives. This vote > >>> lasts for 72 hours minimum. > >>> > >>> [ ] Yes, release Apache Wicket 9.9.1 > >>> [ ] No, don't release Apache Wicket 9.9.1, because ... > >>> > >>> Distributions, changelog, keys and signatures can be found at: > >>> > >>> https://dist.apache.org/repos/dist/dev/wicket/9.9.1 > >>> > >>> Staging repository: > >>> > >>> https://repository.apache.org/content/repositories/orgapachewicket-1174/ > >>> > >>> The binaries are available in the above link, as are a staging > >>> repository for Maven. Typically the vote is on the source, but should > >>> you find a problem with one of the binaries, please let me know, I can > >>> re-roll them some way or the other. > >>> > >>> Staging git repository data: > >>> > >>> Repository: g...@github.com:bitstorm/wicket.git > >>> Branch: build/wicket-9.9.1 > >>> Release tag: rel/wicket-9.9.1 > >>> > >>> > >>> > >>> > >>> CHANGELOG for 9.9.1: > >>> > >>> ** Bug > >>> > >>> * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore > >>> * [WICKET-6965] - Memory leak in WicketEndpoint > >>> > >>> ** Improvement > >>> > >>> * [WICKET-6963] - (REVERTED) Use singletons for > >>> PanelMarkupSourcingStrategy > >>> -- Best regards, Maxim
Re: [VOTE] Release Apache Wicket 9.9.1
+1 Sven On 05.04.22 16:47, Tobias Soloschenko wrote: +1 kind regards Tobias Am 05.04.2022 um 12:42 schrieb Thomas Heigl : +1 Ran our CI build and repeated stress tests on our staging environment. On Mon, Apr 4, 2022 at 11:07 PM Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.9.1 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote lasts for 72 hours minimum. [ ] Yes, release Apache Wicket 9.9.1 [ ] No, don't release Apache Wicket 9.9.1, because ... Distributions, changelog, keys and signatures can be found at: https://dist.apache.org/repos/dist/dev/wicket/9.9.1 Staging repository: https://repository.apache.org/content/repositories/orgapachewicket-1174/ The binaries are available in the above link, as are a staging repository for Maven. Typically the vote is on the source, but should you find a problem with one of the binaries, please let me know, I can re-roll them some way or the other. Staging git repository data: Repository: g...@github.com:bitstorm/wicket.git Branch: build/wicket-9.9.1 Release tag: rel/wicket-9.9.1 CHANGELOG for 9.9.1: ** Bug * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore * [WICKET-6965] - Memory leak in WicketEndpoint ** Improvement * [WICKET-6963] - (REVERTED) Use singletons for PanelMarkupSourcingStrategy
Re: [VOTE] Release Apache Wicket 9.9.1
+1 tested user guide examples On Tue, Apr 5, 2022 at 5:48 PM Ernesto Reinaldo Barreiro wrote: > + 1 > > On Tue, Apr 5, 2022 at 8:47 AM Tobias Soloschenko > wrote: > > > +1 > > > > kind regards > > > > Tobias > > > > > Am 05.04.2022 um 12:42 schrieb Thomas Heigl : > > > > > > +1 > > > > > > Ran our CI build and repeated stress tests on our staging environment. > > > > > >> On Mon, Apr 4, 2022 at 11:07 PM Andrea Del Bene > > > >> wrote: > > >> > > >> This is a vote to release Apache Wicket 9.9.1 > > >> > > >> Please download the source distributions found in our staging area > > >> linked below. > > >> > > >> I have included the signatures for both the source archives. This vote > > >> lasts for 72 hours minimum. > > >> > > >> [ ] Yes, release Apache Wicket 9.9.1 > > >> [ ] No, don't release Apache Wicket 9.9.1, because ... > > >> > > >> Distributions, changelog, keys and signatures can be found at: > > >> > > >> https://dist.apache.org/repos/dist/dev/wicket/9.9.1 > > >> > > >> Staging repository: > > >> > > >> > > https://repository.apache.org/content/repositories/orgapachewicket-1174/ > > >> > > >> The binaries are available in the above link, as are a staging > > >> repository for Maven. Typically the vote is on the source, but should > > >> you find a problem with one of the binaries, please let me know, I can > > >> re-roll them some way or the other. > > >> > > >> Staging git repository data: > > >> > > >> Repository: g...@github.com:bitstorm/wicket.git > > >> Branch: build/wicket-9.9.1 > > >> Release tag: rel/wicket-9.9.1 > > >> > > >> > > >> > > > >> > > >> CHANGELOG for 9.9.1: > > >> > > >> ** Bug > > >> > > >> * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore > > >> * [WICKET-6965] - Memory leak in WicketEndpoint > > >> > > >> ** Improvement > > >> > > >> * [WICKET-6963] - (REVERTED) Use singletons for > > >> PanelMarkupSourcingStrategy > > >> > > > > > -- > Regards - Ernesto Reinaldo Barreiro > -- Andrea Del Bene. Apache Wicket committer.
Re: [VOTE] Release Apache Wicket 9.9.1
+ 1 On Tue, Apr 5, 2022 at 8:47 AM Tobias Soloschenko wrote: > +1 > > kind regards > > Tobias > > > Am 05.04.2022 um 12:42 schrieb Thomas Heigl : > > > > +1 > > > > Ran our CI build and repeated stress tests on our staging environment. > > > >> On Mon, Apr 4, 2022 at 11:07 PM Andrea Del Bene > >> wrote: > >> > >> This is a vote to release Apache Wicket 9.9.1 > >> > >> Please download the source distributions found in our staging area > >> linked below. > >> > >> I have included the signatures for both the source archives. This vote > >> lasts for 72 hours minimum. > >> > >> [ ] Yes, release Apache Wicket 9.9.1 > >> [ ] No, don't release Apache Wicket 9.9.1, because ... > >> > >> Distributions, changelog, keys and signatures can be found at: > >> > >> https://dist.apache.org/repos/dist/dev/wicket/9.9.1 > >> > >> Staging repository: > >> > >> > https://repository.apache.org/content/repositories/orgapachewicket-1174/ > >> > >> The binaries are available in the above link, as are a staging > >> repository for Maven. Typically the vote is on the source, but should > >> you find a problem with one of the binaries, please let me know, I can > >> re-roll them some way or the other. > >> > >> Staging git repository data: > >> > >> Repository: g...@github.com:bitstorm/wicket.git > >> Branch: build/wicket-9.9.1 > >> Release tag: rel/wicket-9.9.1 > >> > >> > >> > >> > >> CHANGELOG for 9.9.1: > >> > >> ** Bug > >> > >> * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore > >> * [WICKET-6965] - Memory leak in WicketEndpoint > >> > >> ** Improvement > >> > >> * [WICKET-6963] - (REVERTED) Use singletons for > >> PanelMarkupSourcingStrategy > >> > -- Regards - Ernesto Reinaldo Barreiro
Re: [VOTE] Release Apache Wicket 9.9.1
+1 kind regards Tobias > Am 05.04.2022 um 12:42 schrieb Thomas Heigl : > > +1 > > Ran our CI build and repeated stress tests on our staging environment. > >> On Mon, Apr 4, 2022 at 11:07 PM Andrea Del Bene >> wrote: >> >> This is a vote to release Apache Wicket 9.9.1 >> >> Please download the source distributions found in our staging area >> linked below. >> >> I have included the signatures for both the source archives. This vote >> lasts for 72 hours minimum. >> >> [ ] Yes, release Apache Wicket 9.9.1 >> [ ] No, don't release Apache Wicket 9.9.1, because ... >> >> Distributions, changelog, keys and signatures can be found at: >> >> https://dist.apache.org/repos/dist/dev/wicket/9.9.1 >> >> Staging repository: >> >> https://repository.apache.org/content/repositories/orgapachewicket-1174/ >> >> The binaries are available in the above link, as are a staging >> repository for Maven. Typically the vote is on the source, but should >> you find a problem with one of the binaries, please let me know, I can >> re-roll them some way or the other. >> >> Staging git repository data: >> >> Repository: g...@github.com:bitstorm/wicket.git >> Branch: build/wicket-9.9.1 >> Release tag: rel/wicket-9.9.1 >> >> >> >> >> CHANGELOG for 9.9.1: >> >> ** Bug >> >> * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore >> * [WICKET-6965] - Memory leak in WicketEndpoint >> >> ** Improvement >> >> * [WICKET-6963] - (REVERTED) Use singletons for >> PanelMarkupSourcingStrategy >>
Re: [VOTE] Release Apache Wicket 9.9.1
+1 Ran our CI build and repeated stress tests on our staging environment. On Mon, Apr 4, 2022 at 11:07 PM Andrea Del Bene wrote: > This is a vote to release Apache Wicket 9.9.1 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source archives. This vote > lasts for 72 hours minimum. > > [ ] Yes, release Apache Wicket 9.9.1 > [ ] No, don't release Apache Wicket 9.9.1, because ... > > Distributions, changelog, keys and signatures can be found at: > > https://dist.apache.org/repos/dist/dev/wicket/9.9.1 > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachewicket-1174/ > > The binaries are available in the above link, as are a staging > repository for Maven. Typically the vote is on the source, but should > you find a problem with one of the binaries, please let me know, I can > re-roll them some way or the other. > > Staging git repository data: > > Repository: g...@github.com:bitstorm/wicket.git > Branch: build/wicket-9.9.1 > Release tag: rel/wicket-9.9.1 > > > > > CHANGELOG for 9.9.1: > > ** Bug > > * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore > * [WICKET-6965] - Memory leak in WicketEndpoint > > ** Improvement > > * [WICKET-6963] - (REVERTED) Use singletons for > PanelMarkupSourcingStrategy >
Re: [VOTE] Release Apache Wicket 9.9.1
+1. We will love to have your web socket fix ASAP as we have a release of our application just now. I have added sending asynchronous web socket messages but this we don't need just yet (we plan to use it in our next release in a few months). On Mon, Apr 4, 2022 at 11:12 AM Thomas Heigl wrote: > I just merged and cherry-picked the PR. > > From my perspective, 9.9.1 is good to release. > > Thomas > > On Mon, Apr 4, 2022 at 12:10 PM Thomas Heigl wrote: > > > I created a PR for this: https://github.com/apache/wicket/pull/507 > > > > I'll cherry-pick it onto 9.x when the PR is approved. > > > > Best, > > > > Thomas > > > > On Sun, Apr 3, 2022 at 10:42 PM Martin Grigorov > > wrote: > > > >> Hi, > >> > >> I won't be able to help in the next few days. Just go ahead and improve > it > >> the way you find good! > >> > >> Martin > >> > >> On Sun, Apr 3, 2022, 12:53 Thomas Heigl wrote: > >> > >> > I have to take back my +1. > >> > > >> > I found one more issue with WICKET-6965 while stress testing our > staging > >> > environment: > >> > > >> > > >> > > >> > https://issues.apache.org/jira/browse/WICKET-6965?focusedCommentId=17516488&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17516488 > >> > > >> > I think we should fix this before releasing 9.9.1. > >> > > >> > This websocket code seems to be quite hard to get right. > >> > > >> > Best, > >> > > >> > Thomas > >> > > >> > On Sat, Apr 2, 2022 at 11:34 AM Thomas Heigl > >> wrote: > >> > > >> > > +1 > >> > > > >> > > I think the changelog for WICKET-6963 should read "Revert: Use > >> singletons > >> > > for PanelMarkupSourcingStrategy", to make clear that it was > reverted. > >> > > > >> > > Thomas > >> > > > >> > > > >> > > On Fri, Apr 1, 2022 at 10:21 PM Andrea Del Bene < > an.delb...@gmail.com > >> > > >> > > wrote: > >> > > > >> > >> This is a vote to release Apache Wicket 9.9.1 > >> > >> > >> > >> Please download the source distributions found in our staging area > >> > >> linked below. > >> > >> > >> > >> I have included the signatures for both the source archives. This > >> vote > >> > >> lasts for 72 hours minimum. > >> > >> > >> > >> [ ] Yes, release Apache Wicket 9.9.1 > >> > >> [ ] No, don't release Apache Wicket 9.9.1, because ... > >> > >> > >> > >> Distributions, changelog, keys and signatures can be found at: > >> > >> > >> > >> https://dist.apache.org/repos/dist/dev/wicket/9.9.1 > >> > >> > >> > >> Staging repository: > >> > >> > >> > >> > >> > > >> > https://repository.apache.org/content/repositories/orgapachewicket-1172/ > >> > >> > >> > >> The binaries are available in the above link, as are a staging > >> > >> repository for Maven. Typically the vote is on the source, but > should > >> > >> you find a problem with one of the binaries, please let me know, I > >> can > >> > >> re-roll them some way or the other. > >> > >> > >> > >> Staging git repository data: > >> > >> > >> > >> Repository: g...@github.com:bitstorm/wicket.git > >> > >> Branch: build/wicket-9.9.1 > >> > >> Release tag: rel/wicket-9.9.1 > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> > >> CHANGELOG for 9.9.1: > >> > >> > >> > >> ** Bug > >> > >> > >> > >> * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore > >> > >> > >> > >> ** Improvement > >> > >> > >> > >> * [WICKET-6963] - Use singletons for > PanelMarkupSourcingStrategy > >> > >> > >> > >> > >> > > >> > > > -- Regards - Ernesto Reinaldo Barreiro
Re: [VOTE] Release Apache Wicket 9.9.1
I just merged and cherry-picked the PR. >From my perspective, 9.9.1 is good to release. Thomas On Mon, Apr 4, 2022 at 12:10 PM Thomas Heigl wrote: > I created a PR for this: https://github.com/apache/wicket/pull/507 > > I'll cherry-pick it onto 9.x when the PR is approved. > > Best, > > Thomas > > On Sun, Apr 3, 2022 at 10:42 PM Martin Grigorov > wrote: > >> Hi, >> >> I won't be able to help in the next few days. Just go ahead and improve it >> the way you find good! >> >> Martin >> >> On Sun, Apr 3, 2022, 12:53 Thomas Heigl wrote: >> >> > I have to take back my +1. >> > >> > I found one more issue with WICKET-6965 while stress testing our staging >> > environment: >> > >> > >> > >> https://issues.apache.org/jira/browse/WICKET-6965?focusedCommentId=17516488&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17516488 >> > >> > I think we should fix this before releasing 9.9.1. >> > >> > This websocket code seems to be quite hard to get right. >> > >> > Best, >> > >> > Thomas >> > >> > On Sat, Apr 2, 2022 at 11:34 AM Thomas Heigl >> wrote: >> > >> > > +1 >> > > >> > > I think the changelog for WICKET-6963 should read "Revert: Use >> singletons >> > > for PanelMarkupSourcingStrategy", to make clear that it was reverted. >> > > >> > > Thomas >> > > >> > > >> > > On Fri, Apr 1, 2022 at 10:21 PM Andrea Del Bene > > >> > > wrote: >> > > >> > >> This is a vote to release Apache Wicket 9.9.1 >> > >> >> > >> Please download the source distributions found in our staging area >> > >> linked below. >> > >> >> > >> I have included the signatures for both the source archives. This >> vote >> > >> lasts for 72 hours minimum. >> > >> >> > >> [ ] Yes, release Apache Wicket 9.9.1 >> > >> [ ] No, don't release Apache Wicket 9.9.1, because ... >> > >> >> > >> Distributions, changelog, keys and signatures can be found at: >> > >> >> > >> https://dist.apache.org/repos/dist/dev/wicket/9.9.1 >> > >> >> > >> Staging repository: >> > >> >> > >> >> > >> https://repository.apache.org/content/repositories/orgapachewicket-1172/ >> > >> >> > >> The binaries are available in the above link, as are a staging >> > >> repository for Maven. Typically the vote is on the source, but should >> > >> you find a problem with one of the binaries, please let me know, I >> can >> > >> re-roll them some way or the other. >> > >> >> > >> Staging git repository data: >> > >> >> > >> Repository: g...@github.com:bitstorm/wicket.git >> > >> Branch: build/wicket-9.9.1 >> > >> Release tag: rel/wicket-9.9.1 >> > >> >> > >> >> > >> >> >> > >> >> > >> CHANGELOG for 9.9.1: >> > >> >> > >> ** Bug >> > >> >> > >> * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore >> > >> >> > >> ** Improvement >> > >> >> > >> * [WICKET-6963] - Use singletons for PanelMarkupSourcingStrategy >> > >> >> > >> >> > >> >
Re: [VOTE] Release Apache Wicket 9.9.1
I created a PR for this: https://github.com/apache/wicket/pull/507 I'll cherry-pick it onto 9.x when the PR is approved. Best, Thomas On Sun, Apr 3, 2022 at 10:42 PM Martin Grigorov wrote: > Hi, > > I won't be able to help in the next few days. Just go ahead and improve it > the way you find good! > > Martin > > On Sun, Apr 3, 2022, 12:53 Thomas Heigl wrote: > > > I have to take back my +1. > > > > I found one more issue with WICKET-6965 while stress testing our staging > > environment: > > > > > > > https://issues.apache.org/jira/browse/WICKET-6965?focusedCommentId=17516488&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17516488 > > > > I think we should fix this before releasing 9.9.1. > > > > This websocket code seems to be quite hard to get right. > > > > Best, > > > > Thomas > > > > On Sat, Apr 2, 2022 at 11:34 AM Thomas Heigl > wrote: > > > > > +1 > > > > > > I think the changelog for WICKET-6963 should read "Revert: Use > singletons > > > for PanelMarkupSourcingStrategy", to make clear that it was reverted. > > > > > > Thomas > > > > > > > > > On Fri, Apr 1, 2022 at 10:21 PM Andrea Del Bene > > > wrote: > > > > > >> This is a vote to release Apache Wicket 9.9.1 > > >> > > >> Please download the source distributions found in our staging area > > >> linked below. > > >> > > >> I have included the signatures for both the source archives. This vote > > >> lasts for 72 hours minimum. > > >> > > >> [ ] Yes, release Apache Wicket 9.9.1 > > >> [ ] No, don't release Apache Wicket 9.9.1, because ... > > >> > > >> Distributions, changelog, keys and signatures can be found at: > > >> > > >> https://dist.apache.org/repos/dist/dev/wicket/9.9.1 > > >> > > >> Staging repository: > > >> > > >> > > https://repository.apache.org/content/repositories/orgapachewicket-1172/ > > >> > > >> The binaries are available in the above link, as are a staging > > >> repository for Maven. Typically the vote is on the source, but should > > >> you find a problem with one of the binaries, please let me know, I can > > >> re-roll them some way or the other. > > >> > > >> Staging git repository data: > > >> > > >> Repository: g...@github.com:bitstorm/wicket.git > > >> Branch: build/wicket-9.9.1 > > >> Release tag: rel/wicket-9.9.1 > > >> > > >> > > >> > > > >> > > >> CHANGELOG for 9.9.1: > > >> > > >> ** Bug > > >> > > >> * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore > > >> > > >> ** Improvement > > >> > > >> * [WICKET-6963] - Use singletons for PanelMarkupSourcingStrategy > > >> > > >> > > >
Re: [VOTE] Release Apache Wicket 9.9.1
Hi, I won't be able to help in the next few days. Just go ahead and improve it the way you find good! Martin On Sun, Apr 3, 2022, 12:53 Thomas Heigl wrote: > I have to take back my +1. > > I found one more issue with WICKET-6965 while stress testing our staging > environment: > > > https://issues.apache.org/jira/browse/WICKET-6965?focusedCommentId=17516488&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17516488 > > I think we should fix this before releasing 9.9.1. > > This websocket code seems to be quite hard to get right. > > Best, > > Thomas > > On Sat, Apr 2, 2022 at 11:34 AM Thomas Heigl wrote: > > > +1 > > > > I think the changelog for WICKET-6963 should read "Revert: Use singletons > > for PanelMarkupSourcingStrategy", to make clear that it was reverted. > > > > Thomas > > > > > > On Fri, Apr 1, 2022 at 10:21 PM Andrea Del Bene > > wrote: > > > >> This is a vote to release Apache Wicket 9.9.1 > >> > >> Please download the source distributions found in our staging area > >> linked below. > >> > >> I have included the signatures for both the source archives. This vote > >> lasts for 72 hours minimum. > >> > >> [ ] Yes, release Apache Wicket 9.9.1 > >> [ ] No, don't release Apache Wicket 9.9.1, because ... > >> > >> Distributions, changelog, keys and signatures can be found at: > >> > >> https://dist.apache.org/repos/dist/dev/wicket/9.9.1 > >> > >> Staging repository: > >> > >> > https://repository.apache.org/content/repositories/orgapachewicket-1172/ > >> > >> The binaries are available in the above link, as are a staging > >> repository for Maven. Typically the vote is on the source, but should > >> you find a problem with one of the binaries, please let me know, I can > >> re-roll them some way or the other. > >> > >> Staging git repository data: > >> > >> Repository: g...@github.com:bitstorm/wicket.git > >> Branch: build/wicket-9.9.1 > >> Release tag: rel/wicket-9.9.1 > >> > >> > >> > >> > >> CHANGELOG for 9.9.1: > >> > >> ** Bug > >> > >> * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore > >> > >> ** Improvement > >> > >> * [WICKET-6963] - Use singletons for PanelMarkupSourcingStrategy > >> > >> >
Re: [VOTE] Release Apache Wicket 9.9.1
I agree. Let's just take the time we need. On 03/04/22 12:53, Thomas Heigl wrote: I have to take back my +1. I found one more issue with WICKET-6965 while stress testing our staging environment: https://issues.apache.org/jira/browse/WICKET-6965?focusedCommentId=17516488&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17516488 I think we should fix this before releasing 9.9.1. This websocket code seems to be quite hard to get right. Best, Thomas On Sat, Apr 2, 2022 at 11:34 AM Thomas Heigl wrote: +1 I think the changelog for WICKET-6963 should read "Revert: Use singletons for PanelMarkupSourcingStrategy", to make clear that it was reverted. Thomas On Fri, Apr 1, 2022 at 10:21 PM Andrea Del Bene wrote: This is a vote to release Apache Wicket 9.9.1 Please download the source distributions found in our staging area linked below. I have included the signatures for both the source archives. This vote lasts for 72 hours minimum. [ ] Yes, release Apache Wicket 9.9.1 [ ] No, don't release Apache Wicket 9.9.1, because ... Distributions, changelog, keys and signatures can be found at: https://dist.apache.org/repos/dist/dev/wicket/9.9.1 Staging repository: https://repository.apache.org/content/repositories/orgapachewicket-1172/ The binaries are available in the above link, as are a staging repository for Maven. Typically the vote is on the source, but should you find a problem with one of the binaries, please let me know, I can re-roll them some way or the other. Staging git repository data: Repository: g...@github.com:bitstorm/wicket.git Branch: build/wicket-9.9.1 Release tag: rel/wicket-9.9.1 CHANGELOG for 9.9.1: ** Bug * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore ** Improvement * [WICKET-6963] - Use singletons for PanelMarkupSourcingStrategy
Re: [VOTE] Release Apache Wicket 9.9.1
I have to take back my +1. I found one more issue with WICKET-6965 while stress testing our staging environment: https://issues.apache.org/jira/browse/WICKET-6965?focusedCommentId=17516488&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17516488 I think we should fix this before releasing 9.9.1. This websocket code seems to be quite hard to get right. Best, Thomas On Sat, Apr 2, 2022 at 11:34 AM Thomas Heigl wrote: > +1 > > I think the changelog for WICKET-6963 should read "Revert: Use singletons > for PanelMarkupSourcingStrategy", to make clear that it was reverted. > > Thomas > > > On Fri, Apr 1, 2022 at 10:21 PM Andrea Del Bene > wrote: > >> This is a vote to release Apache Wicket 9.9.1 >> >> Please download the source distributions found in our staging area >> linked below. >> >> I have included the signatures for both the source archives. This vote >> lasts for 72 hours minimum. >> >> [ ] Yes, release Apache Wicket 9.9.1 >> [ ] No, don't release Apache Wicket 9.9.1, because ... >> >> Distributions, changelog, keys and signatures can be found at: >> >> https://dist.apache.org/repos/dist/dev/wicket/9.9.1 >> >> Staging repository: >> >> https://repository.apache.org/content/repositories/orgapachewicket-1172/ >> >> The binaries are available in the above link, as are a staging >> repository for Maven. Typically the vote is on the source, but should >> you find a problem with one of the binaries, please let me know, I can >> re-roll them some way or the other. >> >> Staging git repository data: >> >> Repository: g...@github.com:bitstorm/wicket.git >> Branch: build/wicket-9.9.1 >> Release tag: rel/wicket-9.9.1 >> >> >> >> >> CHANGELOG for 9.9.1: >> >> ** Bug >> >> * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore >> >> ** Improvement >> >> * [WICKET-6963] - Use singletons for PanelMarkupSourcingStrategy >> >>
Re: [VOTE] Release Apache Wicket 9.9.1
+1 I think the changelog for WICKET-6963 should read "Revert: Use singletons for PanelMarkupSourcingStrategy", to make clear that it was reverted. Thomas On Fri, Apr 1, 2022 at 10:21 PM Andrea Del Bene wrote: > This is a vote to release Apache Wicket 9.9.1 > > Please download the source distributions found in our staging area > linked below. > > I have included the signatures for both the source archives. This vote > lasts for 72 hours minimum. > > [ ] Yes, release Apache Wicket 9.9.1 > [ ] No, don't release Apache Wicket 9.9.1, because ... > > Distributions, changelog, keys and signatures can be found at: > > https://dist.apache.org/repos/dist/dev/wicket/9.9.1 > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachewicket-1172/ > > The binaries are available in the above link, as are a staging > repository for Maven. Typically the vote is on the source, but should > you find a problem with one of the binaries, please let me know, I can > re-roll them some way or the other. > > Staging git repository data: > > Repository: g...@github.com:bitstorm/wicket.git > Branch: build/wicket-9.9.1 > Release tag: rel/wicket-9.9.1 > > > > > CHANGELOG for 9.9.1: > > ** Bug > > * [WICKET-6966] - IndexOutOfBounds in InSessionPageStore > > ** Improvement > > * [WICKET-6963] - Use singletons for PanelMarkupSourcingStrategy > >
