Re: [vote] retry: release wicket 1.5-rc1

2011-01-19 Thread Martijn Dashorst
Not blocking but the README is out of date.

Martijn

On Tue, Jan 18, 2011 at 7:16 PM, Igor Vaynberg  wrote:
> this is the second vote to release wicket 1.5-rc1.
>
> all vote-blocking issues previously reported have been fixed
>
> branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1
> artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/
> maven repo: 
> https://repository.apache.org/content/repositories/orgapachewicket-044/
> changelog: 
> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310561&fixfor=12315483&sorter/field=issuekey&sorter/order=DESC
>
> this vote ends Friday, January 21 at 10:00am GMT-8
>
> please test the release and offer your vote
>
> cheers,
> -igor
>



-- 
Become a Wicket expert, learn from the best: http://wicketinaction.com


Re: [vote] retry: release wicket 1.5-rc1

2011-01-19 Thread Major Péter
I've clicked over my application and couldn't find any issue, so I'm 
(non-binding) +1.


Regards,
Peter

2011-01-18 19:16 keltezéssel, Igor Vaynberg írta:

this is the second vote to release wicket 1.5-rc1.

all vote-blocking issues previously reported have been fixed

branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1
artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/
maven repo: 
https://repository.apache.org/content/repositories/orgapachewicket-044/
changelog: 
https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310561&fixfor=12315483&sorter/field=issuekey&sorter/order=DESC

this vote ends Friday, January 21 at 10:00am GMT-8

please test the release and offer your vote

cheers,
-igor


Re: [vote] retry: release wicket 1.5-rc1

2011-01-19 Thread Martin Grigorov
+1

Checked the quickstart, random wicket-examples. No major issues.

Problems:
 - niceurl example doesn't load its css properly after some navigation
 at first load everything is ok but loading it later (after checking other
apps) for some reason is broken
 reproduced with Chrome 10.x and FF3.6.14pre (wasn't able to reproduce with
FF 4.0b10pre and Opera 11)

- multiupload fails with:
Caused by: java.lang.IllegalArgumentException: 'bytes' cannot be negative.
at org.apache.wicket.util.lang.Bytes.(Bytes.java:111)
at org.apache.wicket.util.lang.Bytes.bytes(Bytes.java:124)
at
org.apache.wicket.devutils.inspector.SessionSizeModel.load(SessionSizeModel.java:36)
at
org.apache.wicket.devutils.inspector.SessionSizeModel.load(SessionSizeModel.java:24)
at
org.apache.wicket.model.LoadableDetachableModel.getObject(LoadableDetachableModel.java:119)
at
org.apache.wicket.devutils.debugbar.SessionSizeDebugPanel$2.getObject(SessionSizeDebugPanel.java:75)
at
org.apache.wicket.devutils.debugbar.SessionSizeDebugPanel$2.getObject(SessionSizeDebugPanel.java:79)
at org.apache.wicket.Component.getDefaultModelObject(Component.java:1675)
at
org.apache.wicket.Component.getDefaultModelObjectAsString(Component.java:1702)
at
org.apache.wicket.markup.html.basic.Label.onComponentTagBody(Label.java:113)
at
org.apache.wicket.markup.html.panel.DefaultMarkupSourcingStrategy.onComponentTagBody(DefaultMarkupSourcingStrategy.java:69)
at org.apache.wicket.Component.internalRenderComponent(Component.java:2502)
...
there is something wrong in devutils ..
single file upload has no such problem

- authentication1 - the password field is not visible/rendered in Chrome
10.x and FF4 (ok in FF 3.6 and Opera 11)
reason: there is an strange attribute "hidden='1'" which causes that in
html5-ish browsers



2011/1/19 Major Péter 

> I've clicked over my application and couldn't find any issue, so I'm
> (non-binding) +1.
>
> Regards,
> Peter
>
> 2011-01-18 19:16 keltezéssel, Igor Vaynberg írta:
>
>  this is the second vote to release wicket 1.5-rc1.
>>
>> all vote-blocking issues previously reported have been fixed
>>
>> branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1
>> artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/
>> maven repo:
>> https://repository.apache.org/content/repositories/orgapachewicket-044/
>> changelog:
>> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310561&fixfor=12315483&sorter/field=issuekey&sorter/order=DESC
>>
>> this vote ends Friday, January 21 at 10:00am GMT-8
>>
>> please test the release and offer your vote
>>
>> cheers,
>> -igor
>>
>


Re: [vote] retry: release wicket 1.5-rc1

2011-01-19 Thread Gabriel Bucher

+1 (non-binding)...


Findings (I can also create jira issues for all of them, just let me know):
1) based on Migration Guide 1.5, TabbedPanel improvement:
'ITab.getPanel() now returns WebMarkupContainerWithAssociatedMarkup 
instead of Panel so it is now possible to create tabs using Fragments or 
Panels rather then just Panels.'


WebMarkupContainerWithAssociatedMarkup does not exists anymore and 
ITab.getPanel() returns Panel again. so it is no longer possible to use 
Fragments directly.


2) maven and artifactid 'wicket'
if I understood it correctly, wicket is a virtual package which combines 
wicket-core, wicket-util and wicket-request in one.


using maven 2.2.1 and if a do a mvn dependency:tree I get the following 
output

[INFO] +- org.apache.wicket:wicket:jar:1.5-RC1:compile
[INFO] |  +- org.apache.wicket:wicket-core:jar:1.5-RC1:compile
[INFO] |  +- org.apache.wicket:wicket-util:jar:1.5-RC1:compile
[INFO] |  \- org.apache.wicket:wicket-request:jar:1.5-RC1:compile

so I have now everything twice!

cheers,
gab


On 19/01/11 02:16, Igor Vaynberg wrote:

this is the second vote to release wicket 1.5-rc1.

all vote-blocking issues previously reported have been fixed

branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1
artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/
maven repo: 
https://repository.apache.org/content/repositories/orgapachewicket-044/
changelog: 
https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310561&fixfor=12315483&sorter/field=issuekey&sorter/order=DESC

this vote ends Friday, January 21 at 10:00am GMT-8

please test the release and offer your vote

cheers,
-igor

!DSPAM:4d35d91166687663790136!





Re: [vote] retry: release wicket 1.5-rc1

2011-01-20 Thread Juergen Donnerstag
> Findings (I can also create jira issues for all of them, just let me know):
> 1) based on Migration Guide 1.5, TabbedPanel improvement:
> 'ITab.getPanel() now returns WebMarkupContainerWithAssociatedMarkup instead
> of Panel so it is now possible to create tabs using Fragments or Panels
> rather then just Panels.'
>
> WebMarkupContainerWithAssociatedMarkup does not exists anymore and
> ITab.getPanel() returns Panel again. so it is no longer possible to use
> Fragments directly.
>

I kind try to fix that. There was no test case (or example) and from
the name getPanel() it wasn't obvious to me that Fragments can also be
an option. And you are right WebMarkupContainerWithAssociatedMarkup is
gone lately. The return type should than probably be
WebMarkupContainer as Panel or Fragment are now merely "mixins". A
Jira issue for that with a testcase or quickstart would be great.

-Juergen


Re: [vote] retry: release wicket 1.5-rc1

2011-01-20 Thread Martin Grigorov
On Thu, Jan 20, 2011 at 7:59 AM, Gabriel Bucher wrote:

> +1 (non-binding)...
>
>
> Findings (I can also create jira issues for all of them, just let me know):
> 1) based on Migration Guide 1.5, TabbedPanel improvement:
> 'ITab.getPanel() now returns WebMarkupContainerWithAssociatedMarkup instead
> of Panel so it is now possible to create tabs using Fragments or Panels
> rather then just Panels.'
>
> WebMarkupContainerWithAssociatedMarkup does not exists anymore and
> ITab.getPanel() returns Panel again. so it is no longer possible to use
> Fragments directly.
>
> 2) maven and artifactid 'wicket'
> if I understood it correctly, wicket is a virtual package which combines
> wicket-core, wicket-util and wicket-request in one.
>
> using maven 2.2.1 and if a do a mvn dependency:tree I get the following
> output
> [INFO] +- org.apache.wicket:wicket:jar:1.5-RC1:compile
> [INFO] |  +- org.apache.wicket:wicket-core:jar:1.5-RC1:compile
> [INFO] |  +- org.apache.wicket:wicket-util:jar:1.5-RC1:compile
> [INFO] |  \- org.apache.wicket:wicket-request:jar:1.5-RC1:compile
>
> so I have now everything twice!
>
Fixed
As a workaround you may declare dependency on 'wicket-core' instead of
'wicket'.

>
> cheers,
> gab
>
>
>
> On 19/01/11 02:16, Igor Vaynberg wrote:
>
>> this is the second vote to release wicket 1.5-rc1.
>>
>> all vote-blocking issues previously reported have been fixed
>>
>> branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1
>> artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/
>> maven repo:
>> https://repository.apache.org/content/repositories/orgapachewicket-044/
>> changelog:
>> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310561&fixfor=12315483&sorter/field=issuekey&sorter/order=DESC
>>
>> this vote ends Friday, January 21 at 10:00am GMT-8
>>
>> please test the release and offer your vote
>>
>> cheers,
>> -igor
>>
>> !DSPAM:4d35d91166687663790136!
>>
>>
>


Re: [vote] retry: release wicket 1.5-rc1

2011-01-20 Thread Martin Grigorov
On Wed, Jan 19, 2011 at 8:04 PM, Martin Grigorov wrote:

> +1
>
> Checked the quickstart, random wicket-examples. No major issues.
>
> Problems:
>  - niceurl example doesn't load its css properly after some navigation
>  at first load everything is ok but loading it later (after checking other
> apps) for some reason is broken
>  reproduced with Chrome 10.x and FF3.6.14pre (wasn't able to reproduce with
> FF 4.0b10pre and Opera 11)
>
hard to reproduce ...

>
> - multiupload fails with:
> Caused by: java.lang.IllegalArgumentException: 'bytes' cannot be negative.
>  at org.apache.wicket.util.lang.Bytes.(Bytes.java:111)
> at org.apache.wicket.util.lang.Bytes.bytes(Bytes.java:124)
>  at
> org.apache.wicket.devutils.inspector.SessionSizeModel.load(SessionSizeModel.java:36)
> at
> org.apache.wicket.devutils.inspector.SessionSizeModel.load(SessionSizeModel.java:24)
>  at
> org.apache.wicket.model.LoadableDetachableModel.getObject(LoadableDetachableModel.java:119)
> at
> org.apache.wicket.devutils.debugbar.SessionSizeDebugPanel$2.getObject(SessionSizeDebugPanel.java:75)
>  at
> org.apache.wicket.devutils.debugbar.SessionSizeDebugPanel$2.getObject(SessionSizeDebugPanel.java:79)
> at org.apache.wicket.Component.getDefaultModelObject(Component.java:1675)
>  at
> org.apache.wicket.Component.getDefaultModelObjectAsString(Component.java:1702)
> at
> org.apache.wicket.markup.html.basic.Label.onComponentTagBody(Label.java:113)
>  at
> org.apache.wicket.markup.html.panel.DefaultMarkupSourcingStrategy.onComponentTagBody(DefaultMarkupSourcingStrategy.java:69)
> at org.apache.wicket.Component.internalRenderComponent(Component.java:2502)
>  ...
> there is something wrong in devutils ..
> single file upload has no such problem
>
Fixed

>
> - authentication1 - the password field is not visible/rendered in Chrome
> 10.x and FF4 (ok in FF 3.6 and Opera 11)
> reason: there is an strange attribute "hidden='1'" which causes that in
> html5-ish browsers
>
Fixed

>
>
> 2011/1/19 Major Péter 
>
> I've clicked over my application and couldn't find any issue, so I'm
>> (non-binding) +1.
>>
>> Regards,
>> Peter
>>
>> 2011-01-18 19:16 keltezéssel, Igor Vaynberg írta:
>>
>>  this is the second vote to release wicket 1.5-rc1.
>>>
>>> all vote-blocking issues previously reported have been fixed
>>>
>>> branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1
>>> artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/
>>> maven repo:
>>> https://repository.apache.org/content/repositories/orgapachewicket-044/
>>> changelog:
>>> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310561&fixfor=12315483&sorter/field=issuekey&sorter/order=DESC
>>>
>>> this vote ends Friday, January 21 at 10:00am GMT-8
>>>
>>> please test the release and offer your vote
>>>
>>> cheers,
>>> -igor
>>>
>>
>


Re: [vote] retry: release wicket 1.5-rc1

2011-01-20 Thread Igor Vaynberg
erm. we should be creating jira issues for these so we can seem them
in the changelog. otherwise when we want to build rc2 it will look
like there were no changes made.

-igor

On Thu, Jan 20, 2011 at 1:42 AM, Martin Grigorov  wrote:
> On Wed, Jan 19, 2011 at 8:04 PM, Martin Grigorov wrote:
>
>> +1
>>
>> Checked the quickstart, random wicket-examples. No major issues.
>>
>> Problems:
>>  - niceurl example doesn't load its css properly after some navigation
>>  at first load everything is ok but loading it later (after checking other
>> apps) for some reason is broken
>>  reproduced with Chrome 10.x and FF3.6.14pre (wasn't able to reproduce with
>> FF 4.0b10pre and Opera 11)
>>
> hard to reproduce ...
>
>>
>> - multiupload fails with:
>> Caused by: java.lang.IllegalArgumentException: 'bytes' cannot be negative.
>>  at org.apache.wicket.util.lang.Bytes.(Bytes.java:111)
>> at org.apache.wicket.util.lang.Bytes.bytes(Bytes.java:124)
>>  at
>> org.apache.wicket.devutils.inspector.SessionSizeModel.load(SessionSizeModel.java:36)
>> at
>> org.apache.wicket.devutils.inspector.SessionSizeModel.load(SessionSizeModel.java:24)
>>  at
>> org.apache.wicket.model.LoadableDetachableModel.getObject(LoadableDetachableModel.java:119)
>> at
>> org.apache.wicket.devutils.debugbar.SessionSizeDebugPanel$2.getObject(SessionSizeDebugPanel.java:75)
>>  at
>> org.apache.wicket.devutils.debugbar.SessionSizeDebugPanel$2.getObject(SessionSizeDebugPanel.java:79)
>> at org.apache.wicket.Component.getDefaultModelObject(Component.java:1675)
>>  at
>> org.apache.wicket.Component.getDefaultModelObjectAsString(Component.java:1702)
>> at
>> org.apache.wicket.markup.html.basic.Label.onComponentTagBody(Label.java:113)
>>  at
>> org.apache.wicket.markup.html.panel.DefaultMarkupSourcingStrategy.onComponentTagBody(DefaultMarkupSourcingStrategy.java:69)
>> at org.apache.wicket.Component.internalRenderComponent(Component.java:2502)
>>  ...
>> there is something wrong in devutils ..
>> single file upload has no such problem
>>
> Fixed
>
>>
>> - authentication1 - the password field is not visible/rendered in Chrome
>> 10.x and FF4 (ok in FF 3.6 and Opera 11)
>> reason: there is an strange attribute "hidden='1'" which causes that in
>> html5-ish browsers
>>
> Fixed
>
>>
>>
>> 2011/1/19 Major Péter 
>>
>> I've clicked over my application and couldn't find any issue, so I'm
>>> (non-binding) +1.
>>>
>>> Regards,
>>> Peter
>>>
>>> 2011-01-18 19:16 keltezéssel, Igor Vaynberg írta:
>>>
>>>  this is the second vote to release wicket 1.5-rc1.

 all vote-blocking issues previously reported have been fixed

 branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1
 artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/
 maven repo:
 https://repository.apache.org/content/repositories/orgapachewicket-044/
 changelog:
 https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310561&fixfor=12315483&sorter/field=issuekey&sorter/order=DESC

 this vote ends Friday, January 21 at 10:00am GMT-8

 please test the release and offer your vote

 cheers,
 -igor

>>>
>>
>


Re: [vote] retry: release wicket 1.5-rc1

2011-01-20 Thread Jeremy Thomerson
On Thu, Jan 20, 2011 at 11:45 AM, Igor Vaynberg wrote:

> erm. we should be creating jira issues for these so we can seem them
> in the changelog. otherwise when we want to build rc2 it will look
> like there were no changes made.
>
> -igor
>

With all the top and bottom posting going on, it's hard to see which what
issues needed JIRAs.  Here's a summation of the issues in this thread (the
ones I saw, anyway) and their JIRAs.

NEED JIRA:
"fortify devutils" - http://svn.apache.org/viewvc?rev=1061176&view=rev
"Remove strange 'hidden' attribute of the password field." -
http://svn.apache.org/viewvc?rev=1061181&view=rev

ALREADY HAS JIRAL
Transitive dependencies - https://issues.apache.org/jira/browse/WICKET-3353

NEED OTHER ACTION:
README is out of date.


-- 
Jeremy Thomerson
http://wickettraining.com
*Need a CMS for Wicket?  Use Brix! http://brixcms.org*


Re: [vote] retry: release wicket 1.5-rc1

2011-01-21 Thread Igor Vaynberg
+1 to release

-igor


On Tue, Jan 18, 2011 at 10:16 AM, Igor Vaynberg  wrote:
> this is the second vote to release wicket 1.5-rc1.
>
> all vote-blocking issues previously reported have been fixed
>
> branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1
> artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/
> maven repo: 
> https://repository.apache.org/content/repositories/orgapachewicket-044/
> changelog: 
> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310561&fixfor=12315483&sorter/field=issuekey&sorter/order=DESC
>
> this vote ends Friday, January 21 at 10:00am GMT-8
>
> please test the release and offer your vote
>
> cheers,
> -igor
>


Re: [vote] retry: release wicket 1.5-rc1

2011-01-21 Thread Jeremy Thomerson
+1 to release

On Fri, Jan 21, 2011 at 4:10 PM, Igor Vaynberg wrote:

> +1 to release
>
> -igor
>
>
> On Tue, Jan 18, 2011 at 10:16 AM, Igor Vaynberg 
> wrote:
> > this is the second vote to release wicket 1.5-rc1.
> >
> > all vote-blocking issues previously reported have been fixed
> >
> > branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1
> > artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/
> > maven repo:
> https://repository.apache.org/content/repositories/orgapachewicket-044/
> > changelog:
> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310561&fixfor=12315483&sorter/field=issuekey&sorter/order=DESC
> >
> > this vote ends Friday, January 21 at 10:00am GMT-8
> >
> > please test the release and offer your vote
> >
> > cheers,
> > -igor
> >
>



-- 
Jeremy Thomerson
http://wickettraining.com
*Need a CMS for Wicket?  Use Brix! http://brixcms.org*


Re: [vote] retry: release wicket 1.5-rc1

2011-01-21 Thread Igor Vaynberg
the voting is now closed. the vote has passed with 3 binding +1 and 2
nonbinding +1

thank you for voting.

-igor

On Fri, Jan 21, 2011 at 2:21 PM, Jeremy Thomerson
 wrote:
> +1 to release
>
> On Fri, Jan 21, 2011 at 4:10 PM, Igor Vaynberg wrote:
>
>> +1 to release
>>
>> -igor
>>
>>
>> On Tue, Jan 18, 2011 at 10:16 AM, Igor Vaynberg 
>> wrote:
>> > this is the second vote to release wicket 1.5-rc1.
>> >
>> > all vote-blocking issues previously reported have been fixed
>> >
>> > branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1
>> > artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/
>> > maven repo:
>> https://repository.apache.org/content/repositories/orgapachewicket-044/
>> > changelog:
>> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310561&fixfor=12315483&sorter/field=issuekey&sorter/order=DESC
>> >
>> > this vote ends Friday, January 21 at 10:00am GMT-8
>> >
>> > please test the release and offer your vote
>> >
>> > cheers,
>> > -igor
>> >
>>
>
>
>
> --
> Jeremy Thomerson
> http://wickettraining.com
> *Need a CMS for Wicket?  Use Brix! http://brixcms.org*
>


Re: [vote] retry: release wicket 1.5-rc1

2011-01-21 Thread Eelco Hillenius
As far as I am concerned, that depends on this issue I just found:
https://issues.apache.org/jira/browse/WICKET-3363. If that's just a
problem with the example (probably the case, as the other localization
examples work fine), I am +1 for releasing. If internationalization is
broken, then I am -1.

As a side note, I saw this in the logs when looking at the nested example:

WARN  - aultMarkupSourcingStrategy - 1.4 to 1.5 migration issue: your
item component should be derived from AbstractItem. Item=[TreeItem
[Component id = 10]]

(and 'ault' probably needs to get rid of the 'u'?).

Eelco


On Fri, Jan 21, 2011 at 2:10 PM, Igor Vaynberg  wrote:
> +1 to release
>
> -igor
>
>
> On Tue, Jan 18, 2011 at 10:16 AM, Igor Vaynberg  
> wrote:
>> this is the second vote to release wicket 1.5-rc1.
>>
>> all vote-blocking issues previously reported have been fixed
>>
>> branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1
>> artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/
>> maven repo: 
>> https://repository.apache.org/content/repositories/orgapachewicket-044/
>> changelog: 
>> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310561&fixfor=12315483&sorter/field=issuekey&sorter/order=DESC
>>
>> this vote ends Friday, January 21 at 10:00am GMT-8
>>
>> please test the release and offer your vote
>>
>> cheers,
>> -igor
>>
>


Re: [vote] retry: release wicket 1.5-rc1

2011-01-21 Thread Igor Vaynberg
ault is the cut off DefaultMarkupSourcingStrategy

-igor

On Fri, Jan 21, 2011 at 2:52 PM, Eelco Hillenius
 wrote:
> As far as I am concerned, that depends on this issue I just found:
> https://issues.apache.org/jira/browse/WICKET-3363. If that's just a
> problem with the example (probably the case, as the other localization
> examples work fine), I am +1 for releasing. If internationalization is
> broken, then I am -1.
>
> As a side note, I saw this in the logs when looking at the nested example:
>
> WARN  - aultMarkupSourcingStrategy - 1.4 to 1.5 migration issue: your
> item component should be derived from AbstractItem. Item=[TreeItem
> [Component id = 10]]
>
> (and 'ault' probably needs to get rid of the 'u'?).
>
> Eelco
>
>
> On Fri, Jan 21, 2011 at 2:10 PM, Igor Vaynberg  
> wrote:
>> +1 to release
>>
>> -igor
>>
>>
>> On Tue, Jan 18, 2011 at 10:16 AM, Igor Vaynberg  
>> wrote:
>>> this is the second vote to release wicket 1.5-rc1.
>>>
>>> all vote-blocking issues previously reported have been fixed
>>>
>>> branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1
>>> artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/
>>> maven repo: 
>>> https://repository.apache.org/content/repositories/orgapachewicket-044/
>>> changelog: 
>>> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310561&fixfor=12315483&sorter/field=issuekey&sorter/order=DESC
>>>
>>> this vote ends Friday, January 21 at 10:00am GMT-8
>>>
>>> please test the release and offer your vote
>>>
>>> cheers,
>>> -igor
>>>
>>
>


Re: [vote] retry: release wicket 1.5-rc1

2011-01-21 Thread Eelco Hillenius
duh :-)

On Fri, Jan 21, 2011 at 2:58 PM, Igor Vaynberg  wrote:
> ault is the cut off DefaultMarkupSourcingStrategy
>
> -igor
>
> On Fri, Jan 21, 2011 at 2:52 PM, Eelco Hillenius
>  wrote:
>> As far as I am concerned, that depends on this issue I just found:
>> https://issues.apache.org/jira/browse/WICKET-3363. If that's just a
>> problem with the example (probably the case, as the other localization
>> examples work fine), I am +1 for releasing. If internationalization is
>> broken, then I am -1.
>>
>> As a side note, I saw this in the logs when looking at the nested example:
>>
>> WARN  - aultMarkupSourcingStrategy - 1.4 to 1.5 migration issue: your
>> item component should be derived from AbstractItem. Item=[TreeItem
>> [Component id = 10]]
>>
>> (and 'ault' probably needs to get rid of the 'u'?).
>>
>> Eelco
>>
>>
>> On Fri, Jan 21, 2011 at 2:10 PM, Igor Vaynberg  
>> wrote:
>>> +1 to release
>>>
>>> -igor
>>>
>>>
>>> On Tue, Jan 18, 2011 at 10:16 AM, Igor Vaynberg  
>>> wrote:
 this is the second vote to release wicket 1.5-rc1.

 all vote-blocking issues previously reported have been fixed

 branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.5-RC1
 artifacts: http://people.apache.org/~ivaynberg/wicket-1.5-RC1/
 maven repo: 
 https://repository.apache.org/content/repositories/orgapachewicket-044/
 changelog: 
 https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310561&fixfor=12315483&sorter/field=issuekey&sorter/order=DESC

 this vote ends Friday, January 21 at 10:00am GMT-8

 please test the release and offer your vote

 cheers,
 -igor

>>>
>>
>