date:20130424

Re: [Dev] What's the use of the new service called '/oauth2/authorize'

2013-04-24 Thread Johann Nallathamby

Hi Nirodha,

It was an existing endpoint in OAuth which we did not expose all this time
from APIM. It was there in IS. From APIM 1.4 we are planning to expose
this. This is used for Authorization grant type which is one of the 4 grant
types in OAuth2.0 core spec.

Will have a document on this ASAP.

Thanks,
Johann.

On Wed, Apr 24, 2013 at 7:25 PM, Nirodha Pramod  wrote:

> Hi Johan,
>
> What's the usage of this new service called "autherize" which is exposed
> as an built in API, AM 1.4.0 RC1 pack. Is there any documentation for this
> feature.
>
> thanks,
> Nirodha
>
> --
> *Nirodha Gallage*
> Senior Software Engineer, QA.
> Member of the Management Committee - QA Technologies
> WSO2 Inc.: http://wso2.com/
> Mobile: +94716429078
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Test failure in synapse 2.1.1-wso2v4 - core module

2013-04-24 Thread Sanjeewa Malalgoda

Hi Miyuru,
I fixed above issue as you mentioned. But please note that following 2
scenarios will not work because of removing "/" at the end.

   template = new URITemplate("/sanjeewa/{name,id}/*");
   assertTrue(template.matches("/sanjeewa/user,190/", var));

template = new URITemplate("/sanjeewa/*");
assertTrue(template.matches("/sanjeewa/", var));

Thanks.
Sanjeewa.

On Thu, Apr 25, 2013 at 8:14 AM, Miyuru Wanninayaka  wrote:

> This is because r153055 change done in URI template component
> @SanjeewaM, can you fix this? just tailing / of url need to ignore
>
> On Wed, Apr 24, 2013 at 11:00 PM, Malith Dhanushka wrote:
>
>> testBasicTemplateDispatch2  in URITemplateBasedDispatcherTest is failing.
>>
>> find the log,
>>
>> Running org.apache.synapse.rest.URITemplateBasedDispatcherTest
>> Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.152 sec
>> <<< FAILURE!
>> ...
>>
>> Tests run: 296, Failures: 1, Errors: 0, Skipped: 0
>>
>> [INFO]
>> 
>> [INFO] Reactor Summary:
>> [INFO]
>> [INFO] Apache Synapse - Secure vault . SUCCESS
>> [3.546s]
>> [INFO] Apache Synapse  SUCCESS
>> [1.221s]
>> [INFO] Apache Synapse - Commons classes .. SUCCESS
>> [5.395s]
>> [INFO] Apache Synapse - Transports ... SUCCESS
>> [0.855s]
>> [INFO] Apache Synapse - Non-blocking HTTP/s Transport  SUCCESS
>> [5.812s]
>> [INFO] Apache Synapse - PIPE Transport ... SUCCESS
>> [1.418s]
>> [INFO] Apache Synapse - VFS Transport  SUCCESS
>> [9.010s]
>> [INFO] Apache Synapse - Tasks classes  SUCCESS
>> [1.235s]
>> [INFO] Apache Synapse - Core . FAILURE
>> [1:52.998s]
>> [INFO] Apache Synapse - FIX Transport  SKIPPED
>> [INFO] Apache Synapse - Extensions ... SKIPPED
>> [INFO] Apache Synapse - Samples .. SKIPPED
>> [INFO] Apache Synapse - Patches .. SKIPPED
>> [INFO] Apache Synapse - Experimental code  SKIPPED
>> [INFO] Apache Synapse - Web Application .. SKIPPED
>> [INFO] Apache Synapse - Handler Module ... SKIPPED
>> [INFO] Apache Synapse - XAR Maven Plugin . SKIPPED
>> [INFO] Apache Synapse - Configuration Migrator ... SKIPPED
>> [INFO] Apache Synapse - Distribution . SKIPPED
>> [INFO] Apache Synapse - Package skeleton ZIP . SKIPPED
>> [INFO] Apache Synapse - Package archetype  SKIPPED
>> [INFO]
>> 
>> [INFO] BUILD FAILURE
>> [INFO]
>> 
>> [INFO] Total time: 2:22.610s
>> [INFO] Finished at: Wed Apr 24 22:30:51 IST 2013
>> [INFO] Final Memory: 110M/1224M
>> [INFO]
>> 
>> [ERROR] Failed to execute goal
>> org.apache.maven.plugins:maven-surefire-plugin:2.3:test (default-test) on
>> project synapse-core: There are test failures. -> [Help 1]
>>
>>
>> --
>> Malith Dhanushka
>>
>> Software Engineer
>> **
>> *WSO2, Inc. : wso2.com*
>> lean.enterprise.middleware.
>>
>> *Blog* :  mmalithh.blogspot.com
>> *Linked-i*n  :   http://lk.linkedin.com/in/malithd
>> *Twitter* :   https://twitter.com/MalithWD
>>
>> *Mobile*  : +94 716 506 693
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> Miyuru Wanninayaka
> Senior Software Engineer - WSO2 Inc
> +94-772099788




-- 
*Sanjeewa Malalgoda*
WSO2 Inc.
Mobile : +14084122175 | +94713068779

 blog
:http://sanjeewamalalgoda.blogspot.com/
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [Blocker] Semaphore not getting released on data bridge?

2013-04-24 Thread Nuwan Dias

Has this been looked into?


On Wed, Mar 13, 2013 at 10:44 AM, Tharindu Mathew  wrote:

> Hi Suho,
>
> This JIRA seems to be investigated thoroughly. Can you see whether this
> JIRA[0] is valid? I believe this is a blocker...
>
> [0] - https://wso2.org/jira/browse/APIMANAGER-992
>
> --
> Regards,
>
> Tharindu Mathew
>
> Associate Technical Lead, WSO2 BAM
> Member - Data Mgmt. Committee
>
> blog: http://tharindumathew.com/
> M: +9459908
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Nuwan Dias

Member, Management Committee - Solutions Technology Group
Software Engineer - WSO2, Inc. http://wso2.com
email : nuw...@wso2.com
Phone : +94 777 775 729
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Test failure in synapse 2.1.1-wso2v4 - core module

2013-04-24 Thread Miyuru Wanninayaka

This is because r153055 change done in URI template component
@SanjeewaM, can you fix this? just tailing / of url need to ignore

On Wed, Apr 24, 2013 at 11:00 PM, Malith Dhanushka  wrote:

> testBasicTemplateDispatch2  in URITemplateBasedDispatcherTest is failing.
>
> find the log,
>
> Running org.apache.synapse.rest.URITemplateBasedDispatcherTest
> Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.152 sec
> <<< FAILURE!
> ...
>
> Tests run: 296, Failures: 1, Errors: 0, Skipped: 0
>
> [INFO]
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Synapse - Secure vault . SUCCESS [3.546s]
> [INFO] Apache Synapse  SUCCESS [1.221s]
> [INFO] Apache Synapse - Commons classes .. SUCCESS [5.395s]
> [INFO] Apache Synapse - Transports ... SUCCESS [0.855s]
> [INFO] Apache Synapse - Non-blocking HTTP/s Transport  SUCCESS [5.812s]
> [INFO] Apache Synapse - PIPE Transport ... SUCCESS [1.418s]
> [INFO] Apache Synapse - VFS Transport  SUCCESS [9.010s]
> [INFO] Apache Synapse - Tasks classes  SUCCESS [1.235s]
> [INFO] Apache Synapse - Core . FAILURE
> [1:52.998s]
> [INFO] Apache Synapse - FIX Transport  SKIPPED
> [INFO] Apache Synapse - Extensions ... SKIPPED
> [INFO] Apache Synapse - Samples .. SKIPPED
> [INFO] Apache Synapse - Patches .. SKIPPED
> [INFO] Apache Synapse - Experimental code  SKIPPED
> [INFO] Apache Synapse - Web Application .. SKIPPED
> [INFO] Apache Synapse - Handler Module ... SKIPPED
> [INFO] Apache Synapse - XAR Maven Plugin . SKIPPED
> [INFO] Apache Synapse - Configuration Migrator ... SKIPPED
> [INFO] Apache Synapse - Distribution . SKIPPED
> [INFO] Apache Synapse - Package skeleton ZIP . SKIPPED
> [INFO] Apache Synapse - Package archetype  SKIPPED
> [INFO]
> 
> [INFO] BUILD FAILURE
> [INFO]
> 
> [INFO] Total time: 2:22.610s
> [INFO] Finished at: Wed Apr 24 22:30:51 IST 2013
> [INFO] Final Memory: 110M/1224M
> [INFO]
> 
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.3:test (default-test) on
> project synapse-core: There are test failures. -> [Help 1]
>
>
> --
> Malith Dhanushka
>
> Software Engineer
> **
> *WSO2, Inc. : wso2.com*
> lean.enterprise.middleware.
>
> *Blog* :  mmalithh.blogspot.com
> *Linked-i*n  :   http://lk.linkedin.com/in/malithd
> *Twitter* :   https://twitter.com/MalithWD
>
> *Mobile*  : +94 716 506 693
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Miyuru Wanninayaka
Senior Software Engineer - WSO2 Inc
+94-772099788
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] Test failure in synapse 2.1.1-wso2v4 - core module

2013-04-24 Thread Malith Dhanushka

testBasicTemplateDispatch2  in URITemplateBasedDispatcherTest is failing.

find the log,

Running org.apache.synapse.rest.URITemplateBasedDispatcherTest
Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.152 sec
<<< FAILURE!
...

Tests run: 296, Failures: 1, Errors: 0, Skipped: 0

[INFO]

[INFO] Reactor Summary:
[INFO]
[INFO] Apache Synapse - Secure vault . SUCCESS [3.546s]
[INFO] Apache Synapse  SUCCESS [1.221s]
[INFO] Apache Synapse - Commons classes .. SUCCESS [5.395s]
[INFO] Apache Synapse - Transports ... SUCCESS [0.855s]
[INFO] Apache Synapse - Non-blocking HTTP/s Transport  SUCCESS [5.812s]
[INFO] Apache Synapse - PIPE Transport ... SUCCESS [1.418s]
[INFO] Apache Synapse - VFS Transport  SUCCESS [9.010s]
[INFO] Apache Synapse - Tasks classes  SUCCESS [1.235s]
[INFO] Apache Synapse - Core . FAILURE
[1:52.998s]
[INFO] Apache Synapse - FIX Transport  SKIPPED
[INFO] Apache Synapse - Extensions ... SKIPPED
[INFO] Apache Synapse - Samples .. SKIPPED
[INFO] Apache Synapse - Patches .. SKIPPED
[INFO] Apache Synapse - Experimental code  SKIPPED
[INFO] Apache Synapse - Web Application .. SKIPPED
[INFO] Apache Synapse - Handler Module ... SKIPPED
[INFO] Apache Synapse - XAR Maven Plugin . SKIPPED
[INFO] Apache Synapse - Configuration Migrator ... SKIPPED
[INFO] Apache Synapse - Distribution . SKIPPED
[INFO] Apache Synapse - Package skeleton ZIP . SKIPPED
[INFO] Apache Synapse - Package archetype  SKIPPED
[INFO]

[INFO] BUILD FAILURE
[INFO]

[INFO] Total time: 2:22.610s
[INFO] Finished at: Wed Apr 24 22:30:51 IST 2013
[INFO] Final Memory: 110M/1224M
[INFO]

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.3:test (default-test) on
project synapse-core: There are test failures. -> [Help 1]


-- 
Malith Dhanushka

Software Engineer
**
*WSO2, Inc. : wso2.com*
lean.enterprise.middleware.

*Blog* :  mmalithh.blogspot.com
*Linked-i*n  :   http://lk.linkedin.com/in/malithd
*Twitter* :   https://twitter.com/MalithWD

*Mobile*  : +94 716 506 693
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] What's the use of the new service called '/oauth2/authorize'

2013-04-24 Thread Nuwan Bandara

Hi Nirodha,

Can you test APIM 1.4.0 for JWT Key generation, token api and
also compatibility with oracle (not oracle rac), I found few issues in
these areas. Also please test with a different port offset.

Regards,
/Nuwan




On Wed, Apr 24, 2013 at 7:25 PM, Nirodha Pramod  wrote:

> Hi Johan,
>
> What's the usage of this new service called "autherize" which is exposed
> as an built in API, AM 1.4.0 RC1 pack. Is there any documentation for this
> feature.
>
> thanks,
> Nirodha
>
> --
> *Nirodha Gallage*
> Senior Software Engineer, QA.
> Member of the Management Committee - QA Technologies
> WSO2 Inc.: http://wso2.com/
> Mobile: +94716429078
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
*Thanks & Regards,

Nuwan Bandara
Associate Technical Lead & Member, MC, Development Technologies
WSO2 Inc. - lean . enterprise . middleware |  http://wso2.com
blog : http://nuwanbando.com; email: nu...@wso2.com; phone: +94 11 763 9629
*

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] What's the use of the new service called '/oauth2/authorize'

2013-04-24 Thread Nirodha Pramod

Hi Johan,

What's the usage of this new service called "autherize" which is exposed as
an built in API, AM 1.4.0 RC1 pack. Is there any documentation for this
feature.

thanks,
Nirodha

-- 
*Nirodha Gallage*
Senior Software Engineer, QA.
Member of the Management Committee - QA Technologies
WSO2 Inc.: http://wso2.com/
Mobile: +94716429078
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] BPS Stalling at Startup Without any Errors

2013-04-24 Thread Isuru Haththotuwa

Hi,

experienced $subject in creating a BPS cartridge for Stratos 2. I get the
following log and the server startup hangs there.

[2013-04-24 18:10:42,184]  INFO
{org.wso2.carbon.humantask.core.internal.HumanTaskServiceComponent} -
Registering HumanTaskUIResourceProvider

(Complete log is attached)

Checked the bundle status for org.wso2.carbon.humantask_4.0.2, and it is in
ACTIVE state.

There are no errors in the logs. Any idea on what can be the issue here?

-- 
Thanks and Regards,

Isuru H.


bps.log
Description: Binary data
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] API Manager 1.4.0 Build - 24-04-2013

2013-04-24 Thread Nuwan Dias

Hi,

Please find the API Manager 1.4.0 build on 24-04-2013 from [1]. This has
some bug fixes on the RC1 pack. Plan is to do the RC2 next.

[1] - http://builder3.us1.wso2.org/builds/24-Apr-2013/

Thanks,
NuwanD.

-- 
Nuwan Dias

Software Engineer - WSO2, Inc. http://wso2.com
email : nuw...@wso2.com
Phone : +94 777 775 729
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Code Freeze for 4.1.2 Platform - 30th April 6:00 PM.

2013-04-24 Thread Sanjeewa Malalgoda

On Wed, Apr 24, 2013 at 4:18 PM, Kasun Weranga  wrote:

> Hi all,
>
> We are planing to do the $subject for BAM 2.3.0 release scheduled for May
> 3.
>
+1 API Manager 1.4.0 has same release schedule.

Thanks.
Sanjeewa.

>
> Thanks,
> KasunW.
>
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
*Sanjeewa Malalgoda*
WSO2 Inc.
Mobile : +14084122175 | +94713068779

 blog
:http://sanjeewamalalgoda.blogspot.com/
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] BAM profile version issue in ESB

2013-04-24 Thread Gihan Anuruddha

Created redmine task for this [1].

[1] - https://redmine.wso2.com/issues/1336

Thanks.
Gihan


On Wed, Apr 24, 2013 at 4:18 PM, Tharindu Mathew  wrote:

> Please capture these in red mine... so we do not lose track...
>
>
> On Wed, Apr 24, 2013 at 4:16 PM, Maninda Edirisooriya wrote:
>
>> On Wed, Apr 24, 2013 at 4:09 PM, Gihan Anuruddha  wrote:
>>
>>> Hi,
>>>
>>> We had internal BAM team discussion regarding this matter. We had
>>> identified two issues associated with this
>>> 1. Once profile details is update how do we update/change existing proxy
>>> services that used BAM profile details.
>>> 2. How we properly distribute BAM profile details across worker-manager
>>> separate environment.
>>>
>>> Since we don't have much time to attend this issue in BAM 2.3.0 release,
>>> we decide to address this in future releases.
>>>
>> +1. As this need time to implement and properly test.
>>
>>>
>>> Thanks.
>>>
>>> Gihan
>>>
>>>
>>> On Wed, Apr 24, 2013 at 3:44 PM, Maninda Edirisooriya 
>>> wrote:
>>>
 Hi Gihan,

 This is what I believe. As there is no way to edit or delete streams
 properly in BAM at present, the user should not be able to edit or delete a
 stream once created. Created streams should be shown as uneditable in UI.
 It will give the sense to the user that the created streams cannot be
 edited or deleted. It will be more inconvenient if the user edit an
 existing stream and face this problem. He will have no idea about the
 error. The exception will not appear immediately and will happen after he
 restart the server which will confuse the user more.

 *
 Maninda Edirisooriya*
 Software Engineer
 *WSO2, Inc.
 *lean.enterprise.middleware.

 *Blog* : http://maninda.blogspot.com/
 *Phone* : +94 777603226


 On Wed, Apr 24, 2013 at 3:15 PM, Gihan Anuruddha wrote:

> Hi Maninda,
>
> I think we can't block stream definition updating from user. It may
> cause some inconvenience in user point of view. What we can do that catch
> the
> "org.wso2.carbon.databridge.commons.exception.DifferentStreamDefinitionAlreadyDefinedException"
> exception and show proper error message regarding the version no. and user
> can decide the version no.
>
> WDYT?
>
> Thanks.
> Gihan
>
>
> On Wed, Apr 24, 2013 at 2:15 PM, Maninda Edirisooriya <
> mani...@wso2.com> wrote:
>
>> First, the main problem have to be fixed is to prevent a stream
>> (i.e., name + version) from getting updated once created. Then the user
>> have to create a new stream with a new version. Not getting updated in
>> Synapse XML is another problem. Actually it a kind of feature in ESB. So
>> let's ignore it for now. When a new stream version is created it is the
>> responsibility of the user to update the Synapse XML. As the old existing
>> stream cannot be modified, the given error will not come. If the user 
>> wants
>> to use the new stream version he has to explicitly do it.
>>
>> *
>> Maninda Edirisooriya*
>> Software Engineer
>> *WSO2, Inc.
>> *lean.enterprise.middleware.
>>
>> *Blog* : http://maninda.blogspot.com/
>> *Phone* : +94 777603226
>>
>>
>> On Wed, Apr 24, 2013 at 1:30 PM, Gihan Anuruddha wrote:
>>
>>> Hi,
>>>
>>> We can create BAM profiles in ESB after adding BAM Mediator feature
>>> to the ESB. In this BAM profiles
>>> you can add/update stream definitions. Currently once you update the
>>> existing stream definition version no. will not get incrementality 
>>> update
>>> automatically unless if you manually updated it. But sometimes users 
>>> forget
>>> to  update this once they did small changes to stream properties. Due to
>>> this; cassandra throws errors since it try to save another stream
>>> definition with same row id details (like stream1:1.0.0).
>>>
>>> We can add version auto incremental feature from Mediator agent side
>>> but the problem is what is the proper way. We can either increment micro
>>> version like 1.0.0, 1.0.1, 1.0.2 ... or major version like 1.0.0, 2.0.0,
>>> 3.0.0  . What is the best way to do?
>>>
>>>
>>> Thanks,
>>> Gihan
>>> --
>>> ---
>>> W.G. Gihan Anuruddha
>>> Senior Software Engineer | WSO2, Inc.
>>> M: +94772272595
>>>
>>> ___
>>> Dev mailing list
>>> Dev@wso2.org
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>
>
> --
> ---
> W.G. Gihan Anuruddha
> Senior Software Engineer | WSO2, Inc.
> M: +94772272595
>


>>>
>>>
>>> --
>>> ---
>>> W.G. Gihan Anuruddha
>>> Senior Software Engineer | WSO2, Inc.
>>> M: +94772272595
>>>
>>
>>
>
>
> --
> Regards,
>
> Tharindu Mathew
>
> Associate Technical Lead, WSO2 BAM
> Member - Data Mgmt

[Dev] Code Freeze for 4.1.2 Platform - 30th April 6:00 PM.

2013-04-24 Thread Kasun Weranga

Hi all,

We are planing to do the $subject for BAM 2.3.0 release scheduled for May
3.

Thanks,
KasunW.
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] BAM profile version issue in ESB

2013-04-24 Thread Tharindu Mathew

Please capture these in red mine... so we do not lose track...

On Wed, Apr 24, 2013 at 4:16 PM, Maninda Edirisooriya wrote:

> On Wed, Apr 24, 2013 at 4:09 PM, Gihan Anuruddha  wrote:
>
>> Hi,
>>
>> We had internal BAM team discussion regarding this matter. We had
>> identified two issues associated with this
>> 1. Once profile details is update how do we update/change existing proxy
>> services that used BAM profile details.
>> 2. How we properly distribute BAM profile details across worker-manager
>> separate environment.
>>
>> Since we don't have much time to attend this issue in BAM 2.3.0 release,
>> we decide to address this in future releases.
>>
> +1. As this need time to implement and properly test.
>
>>
>> Thanks.
>>
>> Gihan
>>
>>
>> On Wed, Apr 24, 2013 at 3:44 PM, Maninda Edirisooriya 
>> wrote:
>>
>>> Hi Gihan,
>>>
>>> This is what I believe. As there is no way to edit or delete streams
>>> properly in BAM at present, the user should not be able to edit or delete a
>>> stream once created. Created streams should be shown as uneditable in UI.
>>> It will give the sense to the user that the created streams cannot be
>>> edited or deleted. It will be more inconvenient if the user edit an
>>> existing stream and face this problem. He will have no idea about the
>>> error. The exception will not appear immediately and will happen after he
>>> restart the server which will confuse the user more.
>>>
>>> *
>>> Maninda Edirisooriya*
>>> Software Engineer
>>> *WSO2, Inc.
>>> *lean.enterprise.middleware.
>>>
>>> *Blog* : http://maninda.blogspot.com/
>>> *Phone* : +94 777603226
>>>
>>>
>>> On Wed, Apr 24, 2013 at 3:15 PM, Gihan Anuruddha  wrote:
>>>
 Hi Maninda,

 I think we can't block stream definition updating from user. It may
 cause some inconvenience in user point of view. What we can do that catch
 the
 "org.wso2.carbon.databridge.commons.exception.DifferentStreamDefinitionAlreadyDefinedException"
 exception and show proper error message regarding the version no. and user
 can decide the version no.

 WDYT?

 Thanks.
 Gihan


 On Wed, Apr 24, 2013 at 2:15 PM, Maninda Edirisooriya >>> > wrote:

> First, the main problem have to be fixed is to prevent a stream (i.e.,
> name + version) from getting updated once created. Then the user have to
> create a new stream with a new version. Not getting updated in Synapse XML
> is another problem. Actually it a kind of feature in ESB. So let's ignore
> it for now. When a new stream version is created it is the responsibility
> of the user to update the Synapse XML. As the old existing stream cannot 
> be
> modified, the given error will not come. If the user wants to use the new
> stream version he has to explicitly do it.
>
> *
> Maninda Edirisooriya*
> Software Engineer
> *WSO2, Inc.
> *lean.enterprise.middleware.
>
> *Blog* : http://maninda.blogspot.com/
> *Phone* : +94 777603226
>
>
> On Wed, Apr 24, 2013 at 1:30 PM, Gihan Anuruddha wrote:
>
>> Hi,
>>
>> We can create BAM profiles in ESB after adding BAM Mediator feature
>> to the ESB. In this BAM profiles
>> you can add/update stream definitions. Currently once you update the
>> existing stream definition version no. will not get incrementality update
>> automatically unless if you manually updated it. But sometimes users 
>> forget
>> to  update this once they did small changes to stream properties. Due to
>> this; cassandra throws errors since it try to save another stream
>> definition with same row id details (like stream1:1.0.0).
>>
>> We can add version auto incremental feature from Mediator agent side
>> but the problem is what is the proper way. We can either increment micro
>> version like 1.0.0, 1.0.1, 1.0.2 ... or major version like 1.0.0, 2.0.0,
>> 3.0.0  . What is the best way to do?
>>
>>
>> Thanks,
>> Gihan
>> --
>> ---
>> W.G. Gihan Anuruddha
>> Senior Software Engineer | WSO2, Inc.
>> M: +94772272595
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>


 --
 ---
 W.G. Gihan Anuruddha
 Senior Software Engineer | WSO2, Inc.
 M: +94772272595

>>>
>>>
>>
>>
>> --
>> ---
>> W.G. Gihan Anuruddha
>> Senior Software Engineer | WSO2, Inc.
>> M: +94772272595
>>
>
>


-- 
Regards,

Tharindu Mathew

Associate Technical Lead, WSO2 BAM
Member - Data Mgmt. Committee

blog: http://tharindumathew.com/
M: +9459908
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] BAM profile version issue in ESB

2013-04-24 Thread Maninda Edirisooriya

On Wed, Apr 24, 2013 at 4:09 PM, Gihan Anuruddha  wrote:

> Hi,
>
> We had internal BAM team discussion regarding this matter. We had
> identified two issues associated with this
> 1. Once profile details is update how do we update/change existing proxy
> services that used BAM profile details.
> 2. How we properly distribute BAM profile details across worker-manager
> separate environment.
>
> Since we don't have much time to attend this issue in BAM 2.3.0 release,
> we decide to address this in future releases.
>
+1. As this need time to implement and properly test.

>
> Thanks.
>
> Gihan
>
>
> On Wed, Apr 24, 2013 at 3:44 PM, Maninda Edirisooriya wrote:
>
>> Hi Gihan,
>>
>> This is what I believe. As there is no way to edit or delete streams
>> properly in BAM at present, the user should not be able to edit or delete a
>> stream once created. Created streams should be shown as uneditable in UI.
>> It will give the sense to the user that the created streams cannot be
>> edited or deleted. It will be more inconvenient if the user edit an
>> existing stream and face this problem. He will have no idea about the
>> error. The exception will not appear immediately and will happen after he
>> restart the server which will confuse the user more.
>>
>> *
>> Maninda Edirisooriya*
>> Software Engineer
>> *WSO2, Inc.
>> *lean.enterprise.middleware.
>>
>> *Blog* : http://maninda.blogspot.com/
>> *Phone* : +94 777603226
>>
>>
>> On Wed, Apr 24, 2013 at 3:15 PM, Gihan Anuruddha  wrote:
>>
>>> Hi Maninda,
>>>
>>> I think we can't block stream definition updating from user. It may
>>> cause some inconvenience in user point of view. What we can do that catch
>>> the
>>> "org.wso2.carbon.databridge.commons.exception.DifferentStreamDefinitionAlreadyDefinedException"
>>> exception and show proper error message regarding the version no. and user
>>> can decide the version no.
>>>
>>> WDYT?
>>>
>>> Thanks.
>>> Gihan
>>>
>>>
>>> On Wed, Apr 24, 2013 at 2:15 PM, Maninda Edirisooriya 
>>> wrote:
>>>
 First, the main problem have to be fixed is to prevent a stream (i.e.,
 name + version) from getting updated once created. Then the user have to
 create a new stream with a new version. Not getting updated in Synapse XML
 is another problem. Actually it a kind of feature in ESB. So let's ignore
 it for now. When a new stream version is created it is the responsibility
 of the user to update the Synapse XML. As the old existing stream cannot be
 modified, the given error will not come. If the user wants to use the new
 stream version he has to explicitly do it.

 *
 Maninda Edirisooriya*
 Software Engineer
 *WSO2, Inc.
 *lean.enterprise.middleware.

 *Blog* : http://maninda.blogspot.com/
 *Phone* : +94 777603226


 On Wed, Apr 24, 2013 at 1:30 PM, Gihan Anuruddha wrote:

> Hi,
>
> We can create BAM profiles in ESB after adding BAM Mediator feature to
> the ESB. In this BAM profiles
> you can add/update stream definitions. Currently once you update the
> existing stream definition version no. will not get incrementality update
> automatically unless if you manually updated it. But sometimes users 
> forget
> to  update this once they did small changes to stream properties. Due to
> this; cassandra throws errors since it try to save another stream
> definition with same row id details (like stream1:1.0.0).
>
> We can add version auto incremental feature from Mediator agent side
> but the problem is what is the proper way. We can either increment micro
> version like 1.0.0, 1.0.1, 1.0.2 ... or major version like 1.0.0, 2.0.0,
> 3.0.0  . What is the best way to do?
>
>
> Thanks,
> Gihan
> --
> ---
> W.G. Gihan Anuruddha
> Senior Software Engineer | WSO2, Inc.
> M: +94772272595
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>

>>>
>>>
>>> --
>>> ---
>>> W.G. Gihan Anuruddha
>>> Senior Software Engineer | WSO2, Inc.
>>> M: +94772272595
>>>
>>
>>
>
>
> --
> ---
> W.G. Gihan Anuruddha
> Senior Software Engineer | WSO2, Inc.
> M: +94772272595
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] BAM profile version issue in ESB

2013-04-24 Thread Gihan Anuruddha

Hi,

We had internal BAM team discussion regarding this matter. We had
identified two issues associated with this
1. Once profile details is update how do we update/change existing proxy
services that used BAM profile details.
2. How we properly distribute BAM profile details across worker-manager
separate environment.

Since we don't have much time to attend this issue in BAM 2.3.0 release, we
decide to address this in future releases.

Thanks.

Gihan

On Wed, Apr 24, 2013 at 3:44 PM, Maninda Edirisooriya wrote:

> Hi Gihan,
>
> This is what I believe. As there is no way to edit or delete streams
> properly in BAM at present, the user should not be able to edit or delete a
> stream once created. Created streams should be shown as uneditable in UI.
> It will give the sense to the user that the created streams cannot be
> edited or deleted. It will be more inconvenient if the user edit an
> existing stream and face this problem. He will have no idea about the
> error. The exception will not appear immediately and will happen after he
> restart the server which will confuse the user more.
>
> *
> Maninda Edirisooriya*
> Software Engineer
> *WSO2, Inc.
> *lean.enterprise.middleware.
>
> *Blog* : http://maninda.blogspot.com/
> *Phone* : +94 777603226
>
>
> On Wed, Apr 24, 2013 at 3:15 PM, Gihan Anuruddha  wrote:
>
>> Hi Maninda,
>>
>> I think we can't block stream definition updating from user. It may cause
>> some inconvenience in user point of view. What we can do that catch the
>> "org.wso2.carbon.databridge.commons.exception.DifferentStreamDefinitionAlreadyDefinedException"
>> exception and show proper error message regarding the version no. and user
>> can decide the version no.
>>
>> WDYT?
>>
>> Thanks.
>> Gihan
>>
>>
>> On Wed, Apr 24, 2013 at 2:15 PM, Maninda Edirisooriya 
>> wrote:
>>
>>> First, the main problem have to be fixed is to prevent a stream (i.e.,
>>> name + version) from getting updated once created. Then the user have to
>>> create a new stream with a new version. Not getting updated in Synapse XML
>>> is another problem. Actually it a kind of feature in ESB. So let's ignore
>>> it for now. When a new stream version is created it is the responsibility
>>> of the user to update the Synapse XML. As the old existing stream cannot be
>>> modified, the given error will not come. If the user wants to use the new
>>> stream version he has to explicitly do it.
>>>
>>> *
>>> Maninda Edirisooriya*
>>> Software Engineer
>>> *WSO2, Inc.
>>> *lean.enterprise.middleware.
>>>
>>> *Blog* : http://maninda.blogspot.com/
>>> *Phone* : +94 777603226
>>>
>>>
>>> On Wed, Apr 24, 2013 at 1:30 PM, Gihan Anuruddha  wrote:
>>>
 Hi,

 We can create BAM profiles in ESB after adding BAM Mediator feature to
 the ESB. In this BAM profiles
 you can add/update stream definitions. Currently once you update the
 existing stream definition version no. will not get incrementality update
 automatically unless if you manually updated it. But sometimes users forget
 to  update this once they did small changes to stream properties. Due to
 this; cassandra throws errors since it try to save another stream
 definition with same row id details (like stream1:1.0.0).

 We can add version auto incremental feature from Mediator agent side
 but the problem is what is the proper way. We can either increment micro
 version like 1.0.0, 1.0.1, 1.0.2 ... or major version like 1.0.0, 2.0.0,
 3.0.0  . What is the best way to do?

 Thanks,
 Gihan
 --
 ---
 W.G. Gihan Anuruddha
 Senior Software Engineer | WSO2, Inc.
 M: +94772272595

 ___
 Dev mailing list
 Dev@wso2.org
 http://wso2.org/cgi-bin/mailman/listinfo/dev

>>>
>>
>>
>> --
>> ---
>> W.G. Gihan Anuruddha
>> Senior Software Engineer | WSO2, Inc.
>> M: +94772272595
>>
>
>

-- 
---
W.G. Gihan Anuruddha
Senior Software Engineer | WSO2, Inc.
M: +94772272595
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Notes on Code Review for Stratos 2 Git Based Deployment Synchronizer

2013-04-24 Thread Pradeep Fernando

Hi,

- write/figure out how to write test cases.




On Wed, Apr 24, 2013 at 1:00 PM, Isuru Haththotuwa  wrote:

>
>- Complete the comments to generate java docs.
>- Stick to proper coding best practices (parenthesis for a single
>line, etc.
>- Remove c-style methods where possible.
>- Remove printStackTrace() statements.
>
> Please add anything that I have missed. I have sent the main architectural
> changes discussed to @architecture with subject 'Generalizing Git Based
> Deployment Synchronizer'.
> --
> Thanks and Regards,
>
> Isuru H.
>
>
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
*Pradeep Fernando*
Member, Management Committee - Platform & Cloud Technologies
Senior Software Engineer;WSO2 Inc.; http://wso2.com

blog: http://pradeepfernando.blogspot.com
m: +94776603662
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] BAM profile version issue in ESB

2013-04-24 Thread Maninda Edirisooriya

Hi Gihan,

This is what I believe. As there is no way to edit or delete streams
properly in BAM at present, the user should not be able to edit or delete a
stream once created. Created streams should be shown as uneditable in UI.
It will give the sense to the user that the created streams cannot be
edited or deleted. It will be more inconvenient if the user edit an
existing stream and face this problem. He will have no idea about the
error. The exception will not appear immediately and will happen after he
restart the server which will confuse the user more.

*
Maninda Edirisooriya*
Software Engineer
*WSO2, Inc.
*lean.enterprise.middleware.

*Blog* : http://maninda.blogspot.com/
*Phone* : +94 777603226


On Wed, Apr 24, 2013 at 3:15 PM, Gihan Anuruddha  wrote:

> Hi Maninda,
>
> I think we can't block stream definition updating from user. It may cause
> some inconvenience in user point of view. What we can do that catch the
> "org.wso2.carbon.databridge.commons.exception.DifferentStreamDefinitionAlreadyDefinedException"
> exception and show proper error message regarding the version no. and user
> can decide the version no.
>
> WDYT?
>
> Thanks.
> Gihan
>
>
> On Wed, Apr 24, 2013 at 2:15 PM, Maninda Edirisooriya wrote:
>
>> First, the main problem have to be fixed is to prevent a stream (i.e.,
>> name + version) from getting updated once created. Then the user have to
>> create a new stream with a new version. Not getting updated in Synapse XML
>> is another problem. Actually it a kind of feature in ESB. So let's ignore
>> it for now. When a new stream version is created it is the responsibility
>> of the user to update the Synapse XML. As the old existing stream cannot be
>> modified, the given error will not come. If the user wants to use the new
>> stream version he has to explicitly do it.
>>
>> *
>> Maninda Edirisooriya*
>> Software Engineer
>> *WSO2, Inc.
>> *lean.enterprise.middleware.
>>
>> *Blog* : http://maninda.blogspot.com/
>> *Phone* : +94 777603226
>>
>>
>> On Wed, Apr 24, 2013 at 1:30 PM, Gihan Anuruddha  wrote:
>>
>>> Hi,
>>>
>>> We can create BAM profiles in ESB after adding BAM Mediator feature to
>>> the ESB. In this BAM profiles
>>> you can add/update stream definitions. Currently once you update the
>>> existing stream definition version no. will not get incrementality update
>>> automatically unless if you manually updated it. But sometimes users forget
>>> to  update this once they did small changes to stream properties. Due to
>>> this; cassandra throws errors since it try to save another stream
>>> definition with same row id details (like stream1:1.0.0).
>>>
>>> We can add version auto incremental feature from Mediator agent side but
>>> the problem is what is the proper way. We can either increment micro
>>> version like 1.0.0, 1.0.1, 1.0.2 ... or major version like 1.0.0, 2.0.0,
>>> 3.0.0  . What is the best way to do?
>>>
>>>
>>> Thanks,
>>> Gihan
>>> --
>>> ---
>>> W.G. Gihan Anuruddha
>>> Senior Software Engineer | WSO2, Inc.
>>> M: +94772272595
>>>
>>> ___
>>> Dev mailing list
>>> Dev@wso2.org
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>
>
> --
> ---
> W.G. Gihan Anuruddha
> Senior Software Engineer | WSO2, Inc.
> M: +94772272595
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] BAM profile version issue in ESB

2013-04-24 Thread Gihan Anuruddha

Hi Maninda,

I think we can't block stream definition updating from user. It may cause
some inconvenience in user point of view. What we can do that catch the
"org.wso2.carbon.databridge.commons.exception.DifferentStreamDefinitionAlreadyDefinedException"
exception and show proper error message regarding the version no. and user
can decide the version no.

WDYT?

Thanks.
Gihan


On Wed, Apr 24, 2013 at 2:15 PM, Maninda Edirisooriya wrote:

> First, the main problem have to be fixed is to prevent a stream (i.e.,
> name + version) from getting updated once created. Then the user have to
> create a new stream with a new version. Not getting updated in Synapse XML
> is another problem. Actually it a kind of feature in ESB. So let's ignore
> it for now. When a new stream version is created it is the responsibility
> of the user to update the Synapse XML. As the old existing stream cannot be
> modified, the given error will not come. If the user wants to use the new
> stream version he has to explicitly do it.
>
> *
> Maninda Edirisooriya*
> Software Engineer
> *WSO2, Inc.
> *lean.enterprise.middleware.
>
> *Blog* : http://maninda.blogspot.com/
> *Phone* : +94 777603226
>
>
> On Wed, Apr 24, 2013 at 1:30 PM, Gihan Anuruddha  wrote:
>
>> Hi,
>>
>> We can create BAM profiles in ESB after adding BAM Mediator feature to
>> the ESB. In this BAM profiles
>> you can add/update stream definitions. Currently once you update the
>> existing stream definition version no. will not get incrementality update
>> automatically unless if you manually updated it. But sometimes users forget
>> to  update this once they did small changes to stream properties. Due to
>> this; cassandra throws errors since it try to save another stream
>> definition with same row id details (like stream1:1.0.0).
>>
>> We can add version auto incremental feature from Mediator agent side but
>> the problem is what is the proper way. We can either increment micro
>> version like 1.0.0, 1.0.1, 1.0.2 ... or major version like 1.0.0, 2.0.0,
>> 3.0.0  . What is the best way to do?
>>
>>
>> Thanks,
>> Gihan
>> --
>> ---
>> W.G. Gihan Anuruddha
>> Senior Software Engineer | WSO2, Inc.
>> M: +94772272595
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>


-- 
---
W.G. Gihan Anuruddha
Senior Software Engineer | WSO2, Inc.
M: +94772272595
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] BAM profile version issue in ESB

2013-04-24 Thread Maninda Edirisooriya

First, the main problem have to be fixed is to prevent a stream (i.e., name
+ version) from getting updated once created. Then the user have to create
a new stream with a new version. Not getting updated in Synapse XML is
another problem. Actually it a kind of feature in ESB. So let's ignore it
for now. When a new stream version is created it is the responsibility of
the user to update the Synapse XML. As the old existing stream cannot be
modified, the given error will not come. If the user wants to use the new
stream version he has to explicitly do it.

*
Maninda Edirisooriya*
Software Engineer
*WSO2, Inc.
*lean.enterprise.middleware.

*Blog* : http://maninda.blogspot.com/
*Phone* : +94 777603226


On Wed, Apr 24, 2013 at 1:30 PM, Gihan Anuruddha  wrote:

> Hi,
>
> We can create BAM profiles in ESB after adding BAM Mediator feature to the
> ESB. In this BAM profiles
> you can add/update stream definitions. Currently once you update the
> existing stream definition version no. will not get incrementality update
> automatically unless if you manually updated it. But sometimes users forget
> to  update this once they did small changes to stream properties. Due to
> this; cassandra throws errors since it try to save another stream
> definition with same row id details (like stream1:1.0.0).
>
> We can add version auto incremental feature from Mediator agent side but
> the problem is what is the proper way. We can either increment micro
> version like 1.0.0, 1.0.1, 1.0.2 ... or major version like 1.0.0, 2.0.0,
> 3.0.0  . What is the best way to do?
>
>
> Thanks,
> Gihan
> --
> ---
> W.G. Gihan Anuruddha
> Senior Software Engineer | WSO2, Inc.
> M: +94772272595
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] BAM profile version issue in ESB

2013-04-24 Thread Gihan Anuruddha

Hi,

We can create BAM profiles in ESB after adding BAM Mediator feature to the
ESB. In this BAM profiles
you can add/update stream definitions. Currently once you update the
existing stream definition version no. will not get incrementality update
automatically unless if you manually updated it. But sometimes users forget
to  update this once they did small changes to stream properties. Due to
this; cassandra throws errors since it try to save another stream
definition with same row id details (like stream1:1.0.0).

We can add version auto incremental feature from Mediator agent side but
the problem is what is the proper way. We can either increment micro
version like 1.0.0, 1.0.1, 1.0.2 ... or major version like 1.0.0, 2.0.0,
3.0.0  . What is the best way to do?


Thanks,
Gihan
-- 
---
W.G. Gihan Anuruddha
Senior Software Engineer | WSO2, Inc.
M: +94772272595
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [Commits] [Carbon-platform] svn commit r153055 - in carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template: . parser

2013-04-24 Thread Sanjeewa Malalgoda

Hi Miyuru,
Our uri template implementation do not not cover all scenarios mentioned in
uri-template specification. But according to uri-template
spec there
is no such explanation(like /{var} maps to /variable/ ). But in general
having / at the end of url is not an issue. What do you think?

Thanks,
Sanjeewa.

On Wed, Apr 24, 2013 at 12:43 PM, Miyuru Wanninayaka wrote:

> AFIU trailing / of a uri should not cause a issue and need to ignore
>
> /dictionary/d/dog/ == /dictionary/d/dog
>
>
> On Wed, Apr 24, 2013 at 12:34 PM, Sanjeewa Malalgoda wrote:
>
>> Hi Miyuru,
>> AFAIU  resource.setDispatcherHelper(new
>> URITemplateHelper("/dictionary/{char}/{word}")); means url should end with
>> variable named word(cannot have / at the end). If we need to
>> match "/dictionary/d/dog/" template definition should
>> be "/dictionary/{char}/{word}/". Did i missed something here?
>>
>> Thanks.
>> Sanjeewa.
>>
>>
>> On Wed, Apr 24, 2013 at 12:19 PM, Miyuru Wanninayaka wrote:
>>
>>> Hi Sanjeewa,
>>>
>>> This cause a test fail in synapse URITemplateBasedDispatcherTest
>>>
>>>  resource.setDispatcherHelper(new
>>> URITemplateHelper("/dictionary/{char}/{word}"));
>>> does not accept
>>>
>>> synCtx = getMessageContext(synapseConfig, false, "/dictionary/d/dog/",
>>> "GET");
>>>
>>> Note and training /
>>>
>>>
>>> -- Forwarded message --
>>> From: 
>>> Date: Fri, Jan 11, 2013 at 2:06 PM
>>> Subject: [Commits] [Carbon-platform] svn commit r153055 - in
>>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template:
>>> . parser
>>> To: comm...@wso2.org
>>>
>>>
>>> Author: sanjeewa
>>> Date: Fri Jan 11 14:06:54 2013
>>> New Revision: 153055
>>> URL: http://wso2.org/svn/browse/wso2?view=rev&revision=153055
>>>
>>> Log:
>>> adding improvements for uri template
>>>
>>> Modified:
>>>
>>>  
>>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/URITemplate.java
>>>
>>>  
>>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/parser/Node.java
>>>
>>> Modified:
>>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/URITemplate.java
>>> URL:
>>> http://wso2.org/svn/browse/wso2/carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/URITemplate.java?rev=153055&r1=153054&r2=153055&view=diff
>>>
>>> ==
>>> ---
>>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/URITemplate.java
>>>(original)
>>> +++
>>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/URITemplate.java
>>>Fri Jan 11 14:06:54 2013
>>> @@ -40,9 +40,9 @@
>>>  }
>>>
>>>  public boolean matches(String uri, Map variables) {
>>> -if (uri.endsWith("/") && uri.length() > 1) {
>>> +/* if (uri.endsWith("/") && uri.length() > 1) {
>>>  uri = uri.substring(0, uri.length() - 1);
>>> -}
>>> +}*/
>>>  return syntaxTree.matchAll(uri, variables) == uri.length();
>>>  }
>>>  }
>>>
>>> Modified:
>>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/parser/Node.java
>>> URL:
>>> http://wso2.org/svn/browse/wso2/carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/parser/Node.java?rev=153055&r1=153054&r2=153055&view=diff
>>>
>>> ==
>>> ---
>>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/parser/Node.java
>>>(original)
>>> +++
>>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/parser/Node.java
>>>Fri Jan 11 14:06:54 2013
>>> @@ -54,7 +54,8 @@
>>>  } else {
>>>  // We have more content in the URI to match
>>>  // But there aren't any nodes left to match against
>>> -return -1;
>>> +// return -1;
>>> +return matchLength;
>>>  }
>>>  } else if (matchLength == uriFragment.length() && next != null)
>>> {
>>>  // We have matched all the characters in the URI
>>> ___
>>> Commits mailing list
>>> comm...@wso2.org
>>> http://wso2.org/cgi-bin/mailman/listinfo/commits
>>>
>>>
>>>
>>> --
>>> Miyuru Wanninayaka
>>> Senior Software Engineer - WSO2 Inc
>>> +94-772099788
>>
>>
>>
>>
>> --
>> *Sanjeewa Malalgoda*
>> WSO2 Inc.
>> Mobile : +14084122175 | +94713068779
>>
>>  blog
>> :http://sanje

[Dev] Notes on Code Review for Stratos 2 Git Based Deployment Synchronizer

2013-04-24 Thread Isuru Haththotuwa

   - Complete the comments to generate java docs.
   - Stick to proper coding best practices (parenthesis for a single line,
   etc.
   - Remove c-style methods where possible.
   - Remove printStackTrace() statements.

Please add anything that I have missed. I have sent the main architectural
changes discussed to @architecture with subject 'Generalizing Git Based
Deployment Synchronizer'.
-- 
Thanks and Regards,

Isuru H.
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [Commits] [Carbon-platform] svn commit r153055 - in carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template: . parser

2013-04-24 Thread Miyuru Wanninayaka

AFIU trailing / of a uri should not cause a issue and need to ignore

/dictionary/d/dog/ == /dictionary/d/dog

On Wed, Apr 24, 2013 at 12:34 PM, Sanjeewa Malalgoda wrote:

> Hi Miyuru,
> AFAIU  resource.setDispatcherHelper(new
> URITemplateHelper("/dictionary/{char}/{word}")); means url should end with
> variable named word(cannot have / at the end). If we need to
> match "/dictionary/d/dog/" template definition should
> be "/dictionary/{char}/{word}/". Did i missed something here?
>
> Thanks.
> Sanjeewa.
>
>
> On Wed, Apr 24, 2013 at 12:19 PM, Miyuru Wanninayaka wrote:
>
>> Hi Sanjeewa,
>>
>> This cause a test fail in synapse URITemplateBasedDispatcherTest
>>
>>  resource.setDispatcherHelper(new
>> URITemplateHelper("/dictionary/{char}/{word}"));
>> does not accept
>>
>> synCtx = getMessageContext(synapseConfig, false, "/dictionary/d/dog/",
>> "GET");
>>
>> Note and training /
>>
>>
>> -- Forwarded message --
>> From: 
>> Date: Fri, Jan 11, 2013 at 2:06 PM
>> Subject: [Commits] [Carbon-platform] svn commit r153055 - in
>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template:
>> . parser
>> To: comm...@wso2.org
>>
>>
>> Author: sanjeewa
>> Date: Fri Jan 11 14:06:54 2013
>> New Revision: 153055
>> URL: http://wso2.org/svn/browse/wso2?view=rev&revision=153055
>>
>> Log:
>> adding improvements for uri template
>>
>> Modified:
>>
>>  
>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/URITemplate.java
>>
>>  
>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/parser/Node.java
>>
>> Modified:
>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/URITemplate.java
>> URL:
>> http://wso2.org/svn/browse/wso2/carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/URITemplate.java?rev=153055&r1=153054&r2=153055&view=diff
>>
>> ==
>> ---
>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/URITemplate.java
>>(original)
>> +++
>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/URITemplate.java
>>Fri Jan 11 14:06:54 2013
>> @@ -40,9 +40,9 @@
>>  }
>>
>>  public boolean matches(String uri, Map variables) {
>> -if (uri.endsWith("/") && uri.length() > 1) {
>> +/* if (uri.endsWith("/") && uri.length() > 1) {
>>  uri = uri.substring(0, uri.length() - 1);
>> -}
>> +}*/
>>  return syntaxTree.matchAll(uri, variables) == uri.length();
>>  }
>>  }
>>
>> Modified:
>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/parser/Node.java
>> URL:
>> http://wso2.org/svn/browse/wso2/carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/parser/Node.java?rev=153055&r1=153054&r2=153055&view=diff
>>
>> ==
>> ---
>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/parser/Node.java
>>(original)
>> +++
>> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/parser/Node.java
>>Fri Jan 11 14:06:54 2013
>> @@ -54,7 +54,8 @@
>>  } else {
>>  // We have more content in the URI to match
>>  // But there aren't any nodes left to match against
>> -return -1;
>> +// return -1;
>> +return matchLength;
>>  }
>>  } else if (matchLength == uriFragment.length() && next != null) {
>>  // We have matched all the characters in the URI
>> ___
>> Commits mailing list
>> comm...@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/commits
>>
>>
>>
>> --
>> Miyuru Wanninayaka
>> Senior Software Engineer - WSO2 Inc
>> +94-772099788
>
>
>
>
> --
> *Sanjeewa Malalgoda*
> WSO2 Inc.
> Mobile : +14084122175 | +94713068779
>
>  blog
> :http://sanjeewamalalgoda.blogspot.com/
>



-- 
Miyuru Wanninayaka
Senior Software Engineer - WSO2 Inc
+94-772099788
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [Commits] [Carbon-platform] svn commit r153055 - in carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template: . parser

2013-04-24 Thread Sanjeewa Malalgoda

Hi Miyuru,
AFAIU  resource.setDispatcherHelper(new
URITemplateHelper("/dictionary/{char}/{word}")); means url should end with
variable named word(cannot have / at the end). If we need to
match "/dictionary/d/dog/" template definition should
be "/dictionary/{char}/{word}/". Did i missed something here?

Thanks.
Sanjeewa.

On Wed, Apr 24, 2013 at 12:19 PM, Miyuru Wanninayaka wrote:

> Hi Sanjeewa,
>
> This cause a test fail in synapse URITemplateBasedDispatcherTest
>
>  resource.setDispatcherHelper(new
> URITemplateHelper("/dictionary/{char}/{word}"));
> does not accept
>
> synCtx = getMessageContext(synapseConfig, false, "/dictionary/d/dog/",
> "GET");
>
> Note and training /
>
>
> -- Forwarded message --
> From: 
> Date: Fri, Jan 11, 2013 at 2:06 PM
> Subject: [Commits] [Carbon-platform] svn commit r153055 - in
> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template:
> . parser
> To: comm...@wso2.org
>
>
> Author: sanjeewa
> Date: Fri Jan 11 14:06:54 2013
> New Revision: 153055
> URL: http://wso2.org/svn/browse/wso2?view=rev&revision=153055
>
> Log:
> adding improvements for uri template
>
> Modified:
>
>  
> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/URITemplate.java
>
>  
> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/parser/Node.java
>
> Modified:
> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/URITemplate.java
> URL:
> http://wso2.org/svn/browse/wso2/carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/URITemplate.java?rev=153055&r1=153054&r2=153055&view=diff
>
> ==
> ---
> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/URITemplate.java
>(original)
> +++
> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/URITemplate.java
>Fri Jan 11 14:06:54 2013
> @@ -40,9 +40,9 @@
>  }
>
>  public boolean matches(String uri, Map variables) {
> -if (uri.endsWith("/") && uri.length() > 1) {
> +/* if (uri.endsWith("/") && uri.length() > 1) {
>  uri = uri.substring(0, uri.length() - 1);
> -}
> +}*/
>  return syntaxTree.matchAll(uri, variables) == uri.length();
>  }
>  }
>
> Modified:
> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/parser/Node.java
> URL:
> http://wso2.org/svn/browse/wso2/carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/parser/Node.java?rev=153055&r1=153054&r2=153055&view=diff
>
> ==
> ---
> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/parser/Node.java
>(original)
> +++
> carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template/parser/Node.java
>Fri Jan 11 14:06:54 2013
> @@ -54,7 +54,8 @@
>  } else {
>  // We have more content in the URI to match
>  // But there aren't any nodes left to match against
> -return -1;
> +// return -1;
> +return matchLength;
>  }
>  } else if (matchLength == uriFragment.length() && next != null) {
>  // We have matched all the characters in the URI
> ___
> Commits mailing list
> comm...@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/commits
>
>
>
> --
> Miyuru Wanninayaka
> Senior Software Engineer - WSO2 Inc
> +94-772099788




-- 
*Sanjeewa Malalgoda*
WSO2 Inc.
Mobile : +14084122175 | +94713068779

 blog
:http://sanjeewamalalgoda.blogspot.com/
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] What's the use of the new service called '/oauth2/authorize'

Re: [Dev] Test failure in synapse 2.1.1-wso2v4 - core module

Re: [Dev] [Blocker] Semaphore not getting released on data bridge?

Re: [Dev] Test failure in synapse 2.1.1-wso2v4 - core module

[Dev] Test failure in synapse 2.1.1-wso2v4 - core module

Re: [Dev] What's the use of the new service called '/oauth2/authorize'

[Dev] What's the use of the new service called '/oauth2/authorize'

[Dev] BPS Stalling at Startup Without any Errors

[Dev] API Manager 1.4.0 Build - 24-04-2013

Re: [Dev] Code Freeze for 4.1.2 Platform - 30th April 6:00 PM.

Re: [Dev] BAM profile version issue in ESB

[Dev] Code Freeze for 4.1.2 Platform - 30th April 6:00 PM.

Re: [Dev] BAM profile version issue in ESB

Re: [Dev] BAM profile version issue in ESB

Re: [Dev] BAM profile version issue in ESB

Re: [Dev] Notes on Code Review for Stratos 2 Git Based Deployment Synchronizer

Re: [Dev] BAM profile version issue in ESB

Re: [Dev] BAM profile version issue in ESB

Re: [Dev] BAM profile version issue in ESB

[Dev] BAM profile version issue in ESB

Re: [Dev] [Commits] [Carbon-platform] svn commit r153055 - in carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template: . parser

[Dev] Notes on Code Review for Stratos 2 Git Based Deployment Synchronizer

Re: [Dev] [Commits] [Carbon-platform] svn commit r153055 - in carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template: . parser

Re: [Dev] [Commits] [Carbon-platform] svn commit r153055 - in carbon/platform/branches/4.0.0/dependencies/commons/uri-templates/1.6.3/src/main/java/org/wso2/uri/template: . parser

24 matches

Site Navigation

Mail list logo

Footer information