Re: [Dev] [Commits] [Git][Carbon-Governance] master: Removed server and comment rxts from governance layer. These rxt are G-Reg specific rxts. Hence these rxt will be bundled to G-Reg pack in product

2015-08-28 Thread Prasanna Dangalla
Hi Sagara,

Moved the server.rxt to the governance layer [1], [2].

[1] - https://github.com/wso2/carbon-governance/pull/82
[2] -
https://github.com/prasa7/product-greg/commit/f072d0798164038ec0c3c4e058dcdd1282c07f59

Thanks

On Sat, Aug 29, 2015 at 10:04 AM, Sagara Gunathunga sag...@wso2.com wrote:




 Specially if you look at DiscoveryAgentExecutorTask, it does not make any
 sense to have Server RXT under
  org.wso2.carbon.governance.es.extensions.feature module.

 Thanks !

 On Sat, Aug 29, 2015 at 9:57 AM, Sagara Gunathunga sag...@wso2.com
 wrote:


 Hi Prasanna,

 Comment RXT is specific to G-Reg hence it's ok to move but Server RXT
 should belong to governance layer, ATM there are number of features we
 implemented such as DiscoveryAgent and DiscoveryAgentTask in
 carbon-governance project but without server.rxt there is no mean to keep
 that code there, also conceptually Server RXT has number of  governance use
 cases but we just haven't implemented in 5.0.0.

 Can you please move back Server.rxt into carbon-governance project ?

 Thanks !

 On Wed, Jul 22, 2015 at 7:46 PM, git...@wso2.org wrote:

 Repository : https://github.com/wso2/carbon-governance

 On branch  : master
 Link   :
 https://github.com/wso2/carbon-governance/compare/ee0cb3f83b5784b2e169ca3d25464f96a7a47778...32da5d082967543b1d3abe1eb41609459c466ae9

 ---

 commit b99ab7c087e89615e16f52fcb66d63600d6d527c
 Author: prasa7 prasannadanga...@gmail.com
 Date:   Wed Jul 22 09:37:00 2015 +0530

 Removed server and comment rxts from governance layer.
 These rxt are G-Reg specific rxts. Hence these rxt will be bundled
 to G-Reg pack in product level(in
 org.wso2.registry.extension.server.feature).


 ---

 b99ab7c087e89615e16f52fcb66d63600d6d527c
  .../resources/p2.inf   |2 -
  .../resources/rxts/comment.rxt |   42 ---
  .../resources/rxts/server.rxt  |   77
 
  3 files changed, 0 insertions(+), 121 deletions(-)

 diff --git
 a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/p2.inf
 b/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/p2.inf
 index a5bb89d..f884525 100644
 ---
 a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/p2.inf
 +++
 b/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/p2.inf
 @@ -12,8 +12,6 @@
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../featur

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/wadl.rxt,target:${installFolder}/../../resources/rxts/wadl.rxt,overwrite:true);\

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/wsdl.rxt,target:${installFolder}/../../resources/rxts/wsdl.rxt,overwrite:true);\

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/soapservice.rxt,target:${installFolder}/../../resources/rxts/soapservice.rxt,overwrite:true);\

 -org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/comment.rxt,target:${installFolder}/../../resources/rxts/comment.rxt,overwrite:true);\

 -org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/server.rxt,target:${installFolder}/../../resources/rxts/server.rxt,overwrite:true);\

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxt.xsd,target:${installFolder}/../../resources/rxt.xsd,overwrite:true);\

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/service-ui-config.xsd,target:${installFolder}/../../resources/service-ui-config.xsd,overwrite:true);\

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/services-config.xml,target:${installFolder}/../../resources/services-config.xml,overwrite:true);\
 diff --git
 a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/rxts/comment.rxt
 b/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/rxts/comment.rxt
 deleted file mode 100644
 index 5e7df5a..000
 ---
 a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/rxts/comment.rxt
 +++ /dev/null
 @@ -1,42 +0,0 @@
 

Re: [Dev] [Commits] [Git][Carbon-Governance] master: Removed server and comment rxts from governance layer. These rxt are G-Reg specific rxts. Hence these rxt will be bundled to G-Reg pack in product

2015-08-28 Thread Sagara Gunathunga
Specially if you look at DiscoveryAgentExecutorTask, it does not make any
sense to have Server RXT under
 org.wso2.carbon.governance.es.extensions.feature module.

Thanks !
On Sat, Aug 29, 2015 at 9:57 AM, Sagara Gunathunga sag...@wso2.com wrote:


 Hi Prasanna,

 Comment RXT is specific to G-Reg hence it's ok to move but Server RXT
 should belong to governance layer, ATM there are number of features we
 implemented such as DiscoveryAgent and DiscoveryAgentTask in
 carbon-governance project but without server.rxt there is no mean to keep
 that code there, also conceptually Server RXT has number of  governance use
 cases but we just haven't implemented in 5.0.0.

 Can you please move back Server.rxt into carbon-governance project ?

 Thanks !

 On Wed, Jul 22, 2015 at 7:46 PM, git...@wso2.org wrote:

 Repository : https://github.com/wso2/carbon-governance

 On branch  : master
 Link   :
 https://github.com/wso2/carbon-governance/compare/ee0cb3f83b5784b2e169ca3d25464f96a7a47778...32da5d082967543b1d3abe1eb41609459c466ae9

 ---

 commit b99ab7c087e89615e16f52fcb66d63600d6d527c
 Author: prasa7 prasannadanga...@gmail.com
 Date:   Wed Jul 22 09:37:00 2015 +0530

 Removed server and comment rxts from governance layer.
 These rxt are G-Reg specific rxts. Hence these rxt will be bundled to
 G-Reg pack in product level(in org.wso2.registry.extension.server.feature).


 ---

 b99ab7c087e89615e16f52fcb66d63600d6d527c
  .../resources/p2.inf   |2 -
  .../resources/rxts/comment.rxt |   42 ---
  .../resources/rxts/server.rxt  |   77
 
  3 files changed, 0 insertions(+), 121 deletions(-)

 diff --git
 a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/p2.inf
 b/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/p2.inf
 index a5bb89d..f884525 100644
 ---
 a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/p2.inf
 +++
 b/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/p2.inf
 @@ -12,8 +12,6 @@
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../featur

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/wadl.rxt,target:${installFolder}/../../resources/rxts/wadl.rxt,overwrite:true);\

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/wsdl.rxt,target:${installFolder}/../../resources/rxts/wsdl.rxt,overwrite:true);\

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/soapservice.rxt,target:${installFolder}/../../resources/rxts/soapservice.rxt,overwrite:true);\

 -org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/comment.rxt,target:${installFolder}/../../resources/rxts/comment.rxt,overwrite:true);\

 -org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/server.rxt,target:${installFolder}/../../resources/rxts/server.rxt,overwrite:true);\

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxt.xsd,target:${installFolder}/../../resources/rxt.xsd,overwrite:true);\

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/service-ui-config.xsd,target:${installFolder}/../../resources/service-ui-config.xsd,overwrite:true);\

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/services-config.xml,target:${installFolder}/../../resources/services-config.xml,overwrite:true);\
 diff --git
 a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/rxts/comment.rxt
 b/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/rxts/comment.rxt
 deleted file mode 100644
 index 5e7df5a..000
 ---
 a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/rxts/comment.rxt
 +++ /dev/null
 @@ -1,42 +0,0 @@
 -artifactType type=application/vnd.wso2-comments+xml
 shortName=comments singularLabel=Comment pluralLabel=Comments
 hasNamespace=false iconSet=9
 -storagePath/publisher_comments/@{overview_hash}/storagePath
 -nameAttributeoverview_resourcepath/nameAttribute
 -ui
 -list
 -column 

Re: [Dev] [Commits] [Git][Carbon-Governance] master: Removed server and comment rxts from governance layer. These rxt are G-Reg specific rxts. Hence these rxt will be bundled to G-Reg pack in product

2015-08-28 Thread Sagara Gunathunga
Hi Prasanna,

Comment RXT is specific to G-Reg hence it's ok to move but Server RXT
should belong to governance layer, ATM there are number of features we
implemented such as DiscoveryAgent and DiscoveryAgentTask in
carbon-governance project but without server.rxt there is no mean to keep
that code there, also conceptually Server RXT has number of  governance use
cases but we just haven't implemented in 5.0.0.

Can you please move back Server.rxt into carbon-governance project ?

Thanks !

On Wed, Jul 22, 2015 at 7:46 PM, git...@wso2.org wrote:

 Repository : https://github.com/wso2/carbon-governance

 On branch  : master
 Link   :
 https://github.com/wso2/carbon-governance/compare/ee0cb3f83b5784b2e169ca3d25464f96a7a47778...32da5d082967543b1d3abe1eb41609459c466ae9

 ---

 commit b99ab7c087e89615e16f52fcb66d63600d6d527c
 Author: prasa7 prasannadanga...@gmail.com
 Date:   Wed Jul 22 09:37:00 2015 +0530

 Removed server and comment rxts from governance layer.
 These rxt are G-Reg specific rxts. Hence these rxt will be bundled to
 G-Reg pack in product level(in org.wso2.registry.extension.server.feature).


 ---

 b99ab7c087e89615e16f52fcb66d63600d6d527c
  .../resources/p2.inf   |2 -
  .../resources/rxts/comment.rxt |   42 ---
  .../resources/rxts/server.rxt  |   77
 
  3 files changed, 0 insertions(+), 121 deletions(-)

 diff --git
 a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/p2.inf
 b/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/p2.inf
 index a5bb89d..f884525 100644
 ---
 a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/p2.inf
 +++
 b/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/p2.inf
 @@ -12,8 +12,6 @@
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../featur

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/wadl.rxt,target:${installFolder}/../../resources/rxts/wadl.rxt,overwrite:true);\

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/wsdl.rxt,target:${installFolder}/../../resources/rxts/wsdl.rxt,overwrite:true);\

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/soapservice.rxt,target:${installFolder}/../../resources/rxts/soapservice.rxt,overwrite:true);\

 -org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/comment.rxt,target:${installFolder}/../../resources/rxts/comment.rxt,overwrite:true);\

 -org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxts/server.rxt,target:${installFolder}/../../resources/rxts/server.rxt,overwrite:true);\

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/rxt.xsd,target:${installFolder}/../../resources/rxt.xsd,overwrite:true);\

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/service-ui-config.xsd,target:${installFolder}/../../resources/service-ui-config.xsd,overwrite:true);\

  
 org.eclipse.equinox.p2.touchpoint.natives.copy(source:${installFolder}/../features/org.wso2.carbon.registry.extensions.server_${feature.version}/services-config.xml,target:${installFolder}/../../resources/services-config.xml,overwrite:true);\
 diff --git
 a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/rxts/comment.rxt
 b/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/rxts/comment.rxt
 deleted file mode 100644
 index 5e7df5a..000
 ---
 a/features/extensions/org.wso2.carbon.registry.extensions.server.feature/resources/rxts/comment.rxt
 +++ /dev/null
 @@ -1,42 +0,0 @@
 -artifactType type=application/vnd.wso2-comments+xml
 shortName=comments singularLabel=Comment pluralLabel=Comments
 hasNamespace=false iconSet=9
 -storagePath/publisher_comments/@{overview_hash}/storagePath
 -nameAttributeoverview_resourcepath/nameAttribute
 -ui
 -list
 -column name=resourcepath
 -data type=path value=overview_resourcepath
 href=/publisher_comments/@{overview_hash}/
 -/column
 -/list
 -/ui
 -content
 -table name=Overview
 -field type=text required=true path=true