[Dev] [Orbit] Please review the PR for Spark 1.3.0

[Niranda Perera]

Hi Sameera,

Could you please review this PR [1] for Spark 1.3.0.

this upgrades 1.2.1 to 1.3.0. this upgrade is done, because 1.3.0 comes
with some major API changes and we wanted to include those API changes
before the DAS (BAM) 3.0.0 alpha

cheers

[1] https://github.com/wso2/orbit/pull/83

-- 
*Niranda Perera*
Software Engineer, WSO2 Inc.
Mobile: +94-71-554-8430
Twitter: @n1r44 
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Niranda Perera]

Hi,

Kind reminder on this.

Best regards

Niranda Perera
Software Engineer, WSO2 Inc.
Mobile: +94-71-554-8430
Twitter: @n1r44
On Apr 14, 2015 19:17, "Niranda Perera"  wrote:

> Hi Sameera,
>
> Could you please review this PR [1] for Spark 1.3.0.
>
> this upgrades 1.2.1 to 1.3.0. this upgrade is done, because 1.3.0 comes
> with some major API changes and we wanted to include those API changes
> before the DAS (BAM) 3.0.0 alpha
>
> cheers
>
> [1] https://github.com/wso2/orbit/pull/83
>
> --
> *Niranda Perera*
> Software Engineer, WSO2 Inc.
> Mobile: +94-71-554-8430
> Twitter: @n1r44 
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Sameera Jayasoma]

Hi Niranda,

Does this include fragment-bundle/patch modification also?

Thanks,
Sameera.

On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera  wrote:

> Hi,
>
> Kind reminder on this.
>
> Best regards
>
> Niranda Perera
> Software Engineer, WSO2 Inc.
> Mobile: +94-71-554-8430
> Twitter: @n1r44
> On Apr 14, 2015 19:17, "Niranda Perera"  wrote:
>
>> Hi Sameera,
>>
>> Could you please review this PR [1] for Spark 1.3.0.
>>
>> this upgrades 1.2.1 to 1.3.0. this upgrade is done, because 1.3.0 comes
>> with some major API changes and we wanted to include those API changes
>> before the DAS (BAM) 3.0.0 alpha
>>
>> cheers
>>
>> [1] https://github.com/wso2/orbit/pull/83
>>
>> --
>> *Niranda Perera*
>> Software Engineer, WSO2 Inc.
>> Mobile: +94-71-554-8430
>> Twitter: @n1r44 
>>
>


-- 
Sameera Jayasoma,
Software Architect,

WSO2, Inc. (http://wso2.com)
email: same...@wso2.com
blog: http://blog.sameera.org
twitter: https://twitter.com/sameerajayasoma
flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
Mobile: 0094776364456

Lean . Enterprise . Middleware
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Niranda Perera]

Hi Sameera,

No its not. The patch is in org.wso2.analytics.spark.patch component. Its
still not committed to carbon - analytics

Rgds

On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma  wrote:

> Hi Niranda,
>
> Does this include fragment-bundle/patch modification also?
>
> Thanks,
> Sameera.
>
> On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera  wrote:
>
>> Hi,
>>
>> Kind reminder on this.
>>
>> Best regards
>>
>> Niranda Perera
>> Software Engineer, WSO2 Inc.
>> Mobile: +94-71-554-8430
>> Twitter: @n1r44
>> On Apr 14, 2015 19:17, "Niranda Perera"  wrote:
>>
>>> Hi Sameera,
>>>
>>> Could you please review this PR [1] for Spark 1.3.0.
>>>
>>> this upgrades 1.2.1 to 1.3.0. this upgrade is done, because 1.3.0 comes
>>> with some major API changes and we wanted to include those API changes
>>> before the DAS (BAM) 3.0.0 alpha
>>>
>>> cheers
>>>
>>> [1] https://github.com/wso2/orbit/pull/83
>>>
>>> --
>>> *Niranda Perera*
>>> Software Engineer, WSO2 Inc.
>>> Mobile: +94-71-554-8430
>>> Twitter: @n1r44 
>>>
>>
>
>
> --
> Sameera Jayasoma,
> Software Architect,
>
> WSO2, Inc. (http://wso2.com)
> email: same...@wso2.com
> blog: http://blog.sameera.org
> twitter: https://twitter.com/sameerajayasoma
> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
> Mobile: 0094776364456
>
> Lean . Enterprise . Middleware
>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Sameera Jayasoma]

I meant to say, do we need to add the patch.jar line to the spark bundle as
we've done in Tomcat bundle.

Thanks,
Sameera.

On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera  wrote:

> Hi Sameera,
>
> No its not. The patch is in org.wso2.analytics.spark.patch component. Its
> still not committed to carbon - analytics
>
> Rgds
>
> On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma  wrote:
>
>> Hi Niranda,
>>
>> Does this include fragment-bundle/patch modification also?
>>
>> Thanks,
>> Sameera.
>>
>> On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera  wrote:
>>
>>> Hi,
>>>
>>> Kind reminder on this.
>>>
>>> Best regards
>>>
>>> Niranda Perera
>>> Software Engineer, WSO2 Inc.
>>> Mobile: +94-71-554-8430
>>> Twitter: @n1r44
>>> On Apr 14, 2015 19:17, "Niranda Perera"  wrote:
>>>
 Hi Sameera,

 Could you please review this PR [1] for Spark 1.3.0.

 this upgrades 1.2.1 to 1.3.0. this upgrade is done, because 1.3.0 comes
 with some major API changes and we wanted to include those API changes
 before the DAS (BAM) 3.0.0 alpha

 cheers

 [1] https://github.com/wso2/orbit/pull/83

 --
 *Niranda Perera*
 Software Engineer, WSO2 Inc.
 Mobile: +94-71-554-8430
 Twitter: @n1r44 

>>>
>>
>>
>> --
>> Sameera Jayasoma,
>> Software Architect,
>>
>> WSO2, Inc. (http://wso2.com)
>> email: same...@wso2.com
>> blog: http://blog.sameera.org
>> twitter: https://twitter.com/sameerajayasoma
>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
>> Mobile: 0094776364456
>>
>> Lean . Enterprise . Middleware
>>
>>


-- 
Sameera Jayasoma,
Software Architect,

WSO2, Inc. (http://wso2.com)
email: same...@wso2.com
blog: http://blog.sameera.org
twitter: https://twitter.com/sameerajayasoma
flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
Mobile: 0094776364456

Lean . Enterprise . Middleware
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Anjana Fernando]

Niranda, yeah, we would have to put that part to be able to later patch it.
A sample can be found here [1].

[1] https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml

Cheers,
Anjana.

On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma  wrote:

> I meant to say, do we need to add the patch.jar line to the spark bundle
> as we've done in Tomcat bundle.
>
> Thanks,
> Sameera.
>
> On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera  wrote:
>
>> Hi Sameera,
>>
>> No its not. The patch is in org.wso2.analytics.spark.patch component. Its
>> still not committed to carbon - analytics
>>
>> Rgds
>>
>> On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma  wrote:
>>
>>> Hi Niranda,
>>>
>>> Does this include fragment-bundle/patch modification also?
>>>
>>> Thanks,
>>> Sameera.
>>>
>>> On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera 
>>> wrote:
>>>
 Hi,

 Kind reminder on this.

 Best regards

 Niranda Perera
 Software Engineer, WSO2 Inc.
 Mobile: +94-71-554-8430
 Twitter: @n1r44
 On Apr 14, 2015 19:17, "Niranda Perera"  wrote:

> Hi Sameera,
>
> Could you please review this PR [1] for Spark 1.3.0.
>
> this upgrades 1.2.1 to 1.3.0. this upgrade is done, because 1.3.0
> comes with some major API changes and we wanted to include those API
> changes before the DAS (BAM) 3.0.0 alpha
>
> cheers
>
> [1] https://github.com/wso2/orbit/pull/83
>
> --
> *Niranda Perera*
> Software Engineer, WSO2 Inc.
> Mobile: +94-71-554-8430
> Twitter: @n1r44 
>

>>>
>>>
>>> --
>>> Sameera Jayasoma,
>>> Software Architect,
>>>
>>> WSO2, Inc. (http://wso2.com)
>>> email: same...@wso2.com
>>> blog: http://blog.sameera.org
>>> twitter: https://twitter.com/sameerajayasoma
>>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
>>> Mobile: 0094776364456
>>>
>>> Lean . Enterprise . Middleware
>>>
>>>
>
>
> --
> Sameera Jayasoma,
> Software Architect,
>
> WSO2, Inc. (http://wso2.com)
> email: same...@wso2.com
> blog: http://blog.sameera.org
> twitter: https://twitter.com/sameerajayasoma
> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
> Mobile: 0094776364456
>
> Lean . Enterprise . Middleware
>
>


-- 
*Anjana Fernando*
Senior Technical Lead
WSO2 Inc. | http://wso2.com
lean . enterprise . middleware
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Niranda Perera]

oh. are you referring to the
patch.jar,.
line?
I did not include it in the orbit bundle.

but I checked the bundles in a fresh carbon server and it seems like the
patch gets attached successfully.
​
 Screenshot from 2015-04-17 16:20:15.png

​
I checked it with BAM pack also.

 tag, is it mandatory to be in the for the orbit bundle,
for the patch to get attached?

the patch pom is as follows
https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml





On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando  wrote:

> Niranda, yeah, we would have to put that part to be able to later patch
> it. A sample can be found here [1].
>
> [1] https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml
>
> Cheers,
> Anjana.
>
> On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma 
> wrote:
>
>> I meant to say, do we need to add the patch.jar line to the spark bundle
>> as we've done in Tomcat bundle.
>>
>> Thanks,
>> Sameera.
>>
>> On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera 
>> wrote:
>>
>>> Hi Sameera,
>>>
>>> No its not. The patch is in org.wso2.analytics.spark.patch component.
>>> Its still not committed to carbon - analytics
>>>
>>> Rgds
>>>
>>> On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma  wrote:
>>>
 Hi Niranda,

 Does this include fragment-bundle/patch modification also?

 Thanks,
 Sameera.

 On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera 
 wrote:

> Hi,
>
> Kind reminder on this.
>
> Best regards
>
> Niranda Perera
> Software Engineer, WSO2 Inc.
> Mobile: +94-71-554-8430
> Twitter: @n1r44
> On Apr 14, 2015 19:17, "Niranda Perera"  wrote:
>
>> Hi Sameera,
>>
>> Could you please review this PR [1] for Spark 1.3.0.
>>
>> this upgrades 1.2.1 to 1.3.0. this upgrade is done, because 1.3.0
>> comes with some major API changes and we wanted to include those API
>> changes before the DAS (BAM) 3.0.0 alpha
>>
>> cheers
>>
>> [1] https://github.com/wso2/orbit/pull/83
>>
>> --
>> *Niranda Perera*
>> Software Engineer, WSO2 Inc.
>> Mobile: +94-71-554-8430
>> Twitter: @n1r44 
>>
>


 --
 Sameera Jayasoma,
 Software Architect,

 WSO2, Inc. (http://wso2.com)
 email: same...@wso2.com
 blog: http://blog.sameera.org
 twitter: https://twitter.com/sameerajayasoma
 flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
 Mobile: 0094776364456

 Lean . Enterprise . Middleware


>>
>>
>> --
>> Sameera Jayasoma,
>> Software Architect,
>>
>> WSO2, Inc. (http://wso2.com)
>> email: same...@wso2.com
>> blog: http://blog.sameera.org
>> twitter: https://twitter.com/sameerajayasoma
>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
>> Mobile: 0094776364456
>>
>> Lean . Enterprise . Middleware
>>
>>
>
>
> --
> *Anjana Fernando*
> Senior Technical Lead
> WSO2 Inc. | http://wso2.com
> lean . enterprise . middleware
>



-- 
*Niranda Perera*
Software Engineer, WSO2 Inc.
Mobile: +94-71-554-8430
Twitter: @n1r44 
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Supun Sethunga]

Hi Sameera/Niranda,

With parallel to this, Im in the process of migrating the spark Ml-Lib and
spark streaming versions for product ML. Just wanted to clear myself,
shouldn't the export-package-version of all spark packages be 1.3.0.wso2v1,
rather than 1.3.0?

Thanks,
Supun

On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera  wrote:

> oh. are you referring to the
> patch.jar,.
> line?
> I did not include it in the orbit bundle.
>
> but I checked the bundles in a fresh carbon server and it seems like the
> patch gets attached successfully.
> ​
>  Screenshot from 2015-04-17 16:20:15.png
> 
> ​
> I checked it with BAM pack also.
>
>  tag, is it mandatory to be in the for the orbit bundle,
> for the patch to get attached?
>
> the patch pom is as follows
>
> https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml
>
>
>
>
>
> On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando  wrote:
>
>> Niranda, yeah, we would have to put that part to be able to later patch
>> it. A sample can be found here [1].
>>
>> [1]
>> https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml
>>
>> Cheers,
>> Anjana.
>>
>> On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma 
>> wrote:
>>
>>> I meant to say, do we need to add the patch.jar line to the spark bundle
>>> as we've done in Tomcat bundle.
>>>
>>> Thanks,
>>> Sameera.
>>>
>>> On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera 
>>> wrote:
>>>
 Hi Sameera,

 No its not. The patch is in org.wso2.analytics.spark.patch component.
 Its still not committed to carbon - analytics

 Rgds

 On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma  wrote:

> Hi Niranda,
>
> Does this include fragment-bundle/patch modification also?
>
> Thanks,
> Sameera.
>
> On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera 
> wrote:
>
>> Hi,
>>
>> Kind reminder on this.
>>
>> Best regards
>>
>> Niranda Perera
>> Software Engineer, WSO2 Inc.
>> Mobile: +94-71-554-8430
>> Twitter: @n1r44
>> On Apr 14, 2015 19:17, "Niranda Perera"  wrote:
>>
>>> Hi Sameera,
>>>
>>> Could you please review this PR [1] for Spark 1.3.0.
>>>
>>> this upgrades 1.2.1 to 1.3.0. this upgrade is done, because 1.3.0
>>> comes with some major API changes and we wanted to include those API
>>> changes before the DAS (BAM) 3.0.0 alpha
>>>
>>> cheers
>>>
>>> [1] https://github.com/wso2/orbit/pull/83
>>>
>>> --
>>> *Niranda Perera*
>>> Software Engineer, WSO2 Inc.
>>> Mobile: +94-71-554-8430
>>> Twitter: @n1r44 
>>>
>>
>
>
> --
> Sameera Jayasoma,
> Software Architect,
>
> WSO2, Inc. (http://wso2.com)
> email: same...@wso2.com
> blog: http://blog.sameera.org
> twitter: https://twitter.com/sameerajayasoma
> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
> Mobile: 0094776364456
>
> Lean . Enterprise . Middleware
>
>
>>>
>>>
>>> --
>>> Sameera Jayasoma,
>>> Software Architect,
>>>
>>> WSO2, Inc. (http://wso2.com)
>>> email: same...@wso2.com
>>> blog: http://blog.sameera.org
>>> twitter: https://twitter.com/sameerajayasoma
>>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
>>> Mobile: 0094776364456
>>>
>>> Lean . Enterprise . Middleware
>>>
>>>
>>
>>
>> --
>> *Anjana Fernando*
>> Senior Technical Lead
>> WSO2 Inc. | http://wso2.com
>> lean . enterprise . middleware
>>
>
>
>
> --
> *Niranda Perera*
> Software Engineer, WSO2 Inc.
> Mobile: +94-71-554-8430
> Twitter: @n1r44 
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
*Supun Sethunga*
Software Engineer
WSO2, Inc.
http://wso2.com/
lean | enterprise | middleware
Mobile : +94 716546324
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Niranda Perera]

Hi Sameera,

a kind reminder about this PR.

thank you

On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera  wrote:

> oh. are you referring to the
> patch.jar,.
> line?
> I did not include it in the orbit bundle.
>
> but I checked the bundles in a fresh carbon server and it seems like the
> patch gets attached successfully.
> ​
>  Screenshot from 2015-04-17 16:20:15.png
> 
> ​
> I checked it with BAM pack also.
>
>  tag, is it mandatory to be in the for the orbit bundle,
> for the patch to get attached?
>
> the patch pom is as follows
>
> https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml
>
>
>
>
>
> On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando  wrote:
>
>> Niranda, yeah, we would have to put that part to be able to later patch
>> it. A sample can be found here [1].
>>
>> [1]
>> https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml
>>
>> Cheers,
>> Anjana.
>>
>> On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma 
>> wrote:
>>
>>> I meant to say, do we need to add the patch.jar line to the spark bundle
>>> as we've done in Tomcat bundle.
>>>
>>> Thanks,
>>> Sameera.
>>>
>>> On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera 
>>> wrote:
>>>
 Hi Sameera,

 No its not. The patch is in org.wso2.analytics.spark.patch component.
 Its still not committed to carbon - analytics

 Rgds

 On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma  wrote:

> Hi Niranda,
>
> Does this include fragment-bundle/patch modification also?
>
> Thanks,
> Sameera.
>
> On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera 
> wrote:
>
>> Hi,
>>
>> Kind reminder on this.
>>
>> Best regards
>>
>> Niranda Perera
>> Software Engineer, WSO2 Inc.
>> Mobile: +94-71-554-8430
>> Twitter: @n1r44
>> On Apr 14, 2015 19:17, "Niranda Perera"  wrote:
>>
>>> Hi Sameera,
>>>
>>> Could you please review this PR [1] for Spark 1.3.0.
>>>
>>> this upgrades 1.2.1 to 1.3.0. this upgrade is done, because 1.3.0
>>> comes with some major API changes and we wanted to include those API
>>> changes before the DAS (BAM) 3.0.0 alpha
>>>
>>> cheers
>>>
>>> [1] https://github.com/wso2/orbit/pull/83
>>>
>>> --
>>> *Niranda Perera*
>>> Software Engineer, WSO2 Inc.
>>> Mobile: +94-71-554-8430
>>> Twitter: @n1r44 
>>>
>>
>
>
> --
> Sameera Jayasoma,
> Software Architect,
>
> WSO2, Inc. (http://wso2.com)
> email: same...@wso2.com
> blog: http://blog.sameera.org
> twitter: https://twitter.com/sameerajayasoma
> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
> Mobile: 0094776364456
>
> Lean . Enterprise . Middleware
>
>
>>>
>>>
>>> --
>>> Sameera Jayasoma,
>>> Software Architect,
>>>
>>> WSO2, Inc. (http://wso2.com)
>>> email: same...@wso2.com
>>> blog: http://blog.sameera.org
>>> twitter: https://twitter.com/sameerajayasoma
>>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
>>> Mobile: 0094776364456
>>>
>>> Lean . Enterprise . Middleware
>>>
>>>
>>
>>
>> --
>> *Anjana Fernando*
>> Senior Technical Lead
>> WSO2 Inc. | http://wso2.com
>> lean . enterprise . middleware
>>
>
>
>
> --
> *Niranda Perera*
> Software Engineer, WSO2 Inc.
> Mobile: +94-71-554-8430
> Twitter: @n1r44 
>



-- 
*Niranda Perera*
Software Engineer, WSO2 Inc.
Mobile: +94-71-554-8430
Twitter: @n1r44 
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Niranda Perera]

Hi Supun,

are you referring to this?

org.apache.spark.*;version="${spark.version}";-split-package:=merge-first


well, AFAIK what export-package does is, it exposes the org.apache.spark.*
classes in the OSGI environment. since we are not doing any patching for
the original classes, I dont think we have to change the version to
1.3.0.wso2v1

@sameera, pls correct me if I'm wrong.

rgds

On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga  wrote:

> Hi Sameera/Niranda,
>
> With parallel to this, Im in the process of migrating the spark Ml-Lib and
> spark streaming versions for product ML. Just wanted to clear myself,
> shouldn't the export-package-version of all spark packages be 1.3.0.wso2v1,
> rather than 1.3.0?
>
> Thanks,
> Supun
>
> On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera  wrote:
>
>> oh. are you referring to the
>> patch.jar,.
>> line?
>> I did not include it in the orbit bundle.
>>
>> but I checked the bundles in a fresh carbon server and it seems like the
>> patch gets attached successfully.
>> ​
>>  Screenshot from 2015-04-17 16:20:15.png
>> 
>> ​
>> I checked it with BAM pack also.
>>
>>  tag, is it mandatory to be in the for the orbit
>> bundle, for the patch to get attached?
>>
>> the patch pom is as follows
>>
>> https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml
>>
>>
>>
>>
>>
>> On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando  wrote:
>>
>>> Niranda, yeah, we would have to put that part to be able to later patch
>>> it. A sample can be found here [1].
>>>
>>> [1]
>>> https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml
>>>
>>> Cheers,
>>> Anjana.
>>>
>>> On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma 
>>> wrote:
>>>
 I meant to say, do we need to add the patch.jar line to the spark
 bundle as we've done in Tomcat bundle.

 Thanks,
 Sameera.

 On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera 
 wrote:

> Hi Sameera,
>
> No its not. The patch is in org.wso2.analytics.spark.patch component.
> Its still not committed to carbon - analytics
>
> Rgds
>
> On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma  wrote:
>
>> Hi Niranda,
>>
>> Does this include fragment-bundle/patch modification also?
>>
>> Thanks,
>> Sameera.
>>
>> On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera 
>> wrote:
>>
>>> Hi,
>>>
>>> Kind reminder on this.
>>>
>>> Best regards
>>>
>>> Niranda Perera
>>> Software Engineer, WSO2 Inc.
>>> Mobile: +94-71-554-8430
>>> Twitter: @n1r44
>>> On Apr 14, 2015 19:17, "Niranda Perera"  wrote:
>>>
 Hi Sameera,

 Could you please review this PR [1] for Spark 1.3.0.

 this upgrades 1.2.1 to 1.3.0. this upgrade is done, because 1.3.0
 comes with some major API changes and we wanted to include those API
 changes before the DAS (BAM) 3.0.0 alpha

 cheers

 [1] https://github.com/wso2/orbit/pull/83

 --
 *Niranda Perera*
 Software Engineer, WSO2 Inc.
 Mobile: +94-71-554-8430
 Twitter: @n1r44 

>>>
>>
>>
>> --
>> Sameera Jayasoma,
>> Software Architect,
>>
>> WSO2, Inc. (http://wso2.com)
>> email: same...@wso2.com
>> blog: http://blog.sameera.org
>> twitter: https://twitter.com/sameerajayasoma
>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
>> Mobile: 0094776364456
>>
>> Lean . Enterprise . Middleware
>>
>>


 --
 Sameera Jayasoma,
 Software Architect,

 WSO2, Inc. (http://wso2.com)
 email: same...@wso2.com
 blog: http://blog.sameera.org
 twitter: https://twitter.com/sameerajayasoma
 flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
 Mobile: 0094776364456

 Lean . Enterprise . Middleware


>>>
>>>
>>> --
>>> *Anjana Fernando*
>>> Senior Technical Lead
>>> WSO2 Inc. | http://wso2.com
>>> lean . enterprise . middleware
>>>
>>
>>
>>
>> --
>> *Niranda Perera*
>> Software Engineer, WSO2 Inc.
>> Mobile: +94-71-554-8430
>> Twitter: @n1r44 
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> *Supun Sethunga*
> Software Engineer
> WSO2, Inc.
> http://wso2.com/
> lean | enterprise | middleware
> Mobile : +94 716546324
>



-- 
*Niranda Perera*
Software Engineer, WSO2 Inc.
Mobile: +94-71-554-8430
Twitter: @n1r44 
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[KasunG Gajasinghe]

Hi Niranda,

The Bundle-Classpath tag is as mentioned above is required to over-ride the
classes in the original orbit bundle. Since both the orbit bundle, and
patched bundle have the same classes, we need to instruct to give
precedence to the patch.jar. Hence, the above tag is required.

The bundles will be resolved fine, but the over-riding may or may not
happen. So, can you add this tag? Further, there are some pending comments
in the PR.

Thanks.

On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera  wrote:

> Hi Supun,
>
> are you referring to this?
> 
> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
> 
>
> well, AFAIK what export-package does is, it exposes the org.apache.spark.*
> classes in the OSGI environment. since we are not doing any patching for
> the original classes, I dont think we have to change the version to
> 1.3.0.wso2v1
>
> @sameera, pls correct me if I'm wrong.
>
> rgds
>
> On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga  wrote:
>
>> Hi Sameera/Niranda,
>>
>> With parallel to this, Im in the process of migrating the spark Ml-Lib
>> and spark streaming versions for product ML. Just wanted to clear myself,
>> shouldn't the export-package-version of all spark packages be 1.3.0.wso2v1,
>> rather than 1.3.0?
>>
>> Thanks,
>> Supun
>>
>> On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera  wrote:
>>
>>> oh. are you referring to the
>>> patch.jar,.
>>> line?
>>> I did not include it in the orbit bundle.
>>>
>>> but I checked the bundles in a fresh carbon server and it seems like the
>>> patch gets attached successfully.
>>> ​
>>>  Screenshot from 2015-04-17 16:20:15.png
>>> 
>>> ​
>>> I checked it with BAM pack also.
>>>
>>>  tag, is it mandatory to be in the for the orbit
>>> bundle, for the patch to get attached?
>>>
>>> the patch pom is as follows
>>>
>>> https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml
>>>
>>>
>>>
>>>
>>>
>>> On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando 
>>> wrote:
>>>
 Niranda, yeah, we would have to put that part to be able to later patch
 it. A sample can be found here [1].

 [1]
 https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml

 Cheers,
 Anjana.

 On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma 
 wrote:

> I meant to say, do we need to add the patch.jar line to the spark
> bundle as we've done in Tomcat bundle.
>
> Thanks,
> Sameera.
>
> On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera 
> wrote:
>
>> Hi Sameera,
>>
>> No its not. The patch is in org.wso2.analytics.spark.patch component.
>> Its still not committed to carbon - analytics
>>
>> Rgds
>>
>> On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma 
>> wrote:
>>
>>> Hi Niranda,
>>>
>>> Does this include fragment-bundle/patch modification also?
>>>
>>> Thanks,
>>> Sameera.
>>>
>>> On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera 
>>> wrote:
>>>
 Hi,

 Kind reminder on this.

 Best regards

 Niranda Perera
 Software Engineer, WSO2 Inc.
 Mobile: +94-71-554-8430
 Twitter: @n1r44
 On Apr 14, 2015 19:17, "Niranda Perera"  wrote:

> Hi Sameera,
>
> Could you please review this PR [1] for Spark 1.3.0.
>
> this upgrades 1.2.1 to 1.3.0. this upgrade is done, because 1.3.0
> comes with some major API changes and we wanted to include those API
> changes before the DAS (BAM) 3.0.0 alpha
>
> cheers
>
> [1] https://github.com/wso2/orbit/pull/83
>
> --
> *Niranda Perera*
> Software Engineer, WSO2 Inc.
> Mobile: +94-71-554-8430
> Twitter: @n1r44 
>

>>>
>>>
>>> --
>>> Sameera Jayasoma,
>>> Software Architect,
>>>
>>> WSO2, Inc. (http://wso2.com)
>>> email: same...@wso2.com
>>> blog: http://blog.sameera.org
>>> twitter: https://twitter.com/sameerajayasoma
>>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
>>> Mobile: 0094776364456
>>>
>>> Lean . Enterprise . Middleware
>>>
>>>
>
>
> --
> Sameera Jayasoma,
> Software Architect,
>
> WSO2, Inc. (http://wso2.com)
> email: same...@wso2.com
> blog: http://blog.sameera.org
> twitter: https://twitter.com/sameerajayasoma
> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
> Mobile: 0094776364456
>
> Lean . Enterprise . Middleware
>
>


 --
 *Anjana Fernando*
 Senior Technical Lead
 WSO2 Inc. | http://wso2.com
 lean . enterprise

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Niranda Perera]

@Kasun thank you for the clarification

I have made the adjustments. can you please check it?

rgds

On Mon, Apr 27, 2015 at 11:16 AM, KasunG Gajasinghe  wrote:

> Hi Niranda,
>
> The Bundle-Classpath tag is as mentioned above is required to over-ride
> the classes in the original orbit bundle. Since both the orbit bundle, and
> patched bundle have the same classes, we need to instruct to give
> precedence to the patch.jar. Hence, the above tag is required.
>
> The bundles will be resolved fine, but the over-riding may or may not
> happen. So, can you add this tag? Further, there are some pending comments
> in the PR.
>
> Thanks.
>
> On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera  wrote:
>
>> Hi Supun,
>>
>> are you referring to this?
>> 
>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>> 
>>
>> well, AFAIK what export-package does is, it exposes the
>> org.apache.spark.* classes in the OSGI environment. since we are not doing
>> any patching for the original classes, I dont think we have to change the
>> version to 1.3.0.wso2v1
>>
>> @sameera, pls correct me if I'm wrong.
>>
>> rgds
>>
>> On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga  wrote:
>>
>>> Hi Sameera/Niranda,
>>>
>>> With parallel to this, Im in the process of migrating the spark Ml-Lib
>>> and spark streaming versions for product ML. Just wanted to clear myself,
>>> shouldn't the export-package-version of all spark packages be 1.3.0.wso2v1,
>>> rather than 1.3.0?
>>>
>>> Thanks,
>>> Supun
>>>
>>> On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera 
>>> wrote:
>>>
 oh. are you referring to the
 patch.jar,.
 line?
 I did not include it in the orbit bundle.

 but I checked the bundles in a fresh carbon server and it seems like
 the patch gets attached successfully.
 ​
  Screenshot from 2015-04-17 16:20:15.png
 
 ​
 I checked it with BAM pack also.

  tag, is it mandatory to be in the for the orbit
 bundle, for the patch to get attached?

 the patch pom is as follows

 https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml





 On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando 
 wrote:

> Niranda, yeah, we would have to put that part to be able to later
> patch it. A sample can be found here [1].
>
> [1]
> https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml
>
> Cheers,
> Anjana.
>
> On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma 
> wrote:
>
>> I meant to say, do we need to add the patch.jar line to the spark
>> bundle as we've done in Tomcat bundle.
>>
>> Thanks,
>> Sameera.
>>
>> On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera 
>> wrote:
>>
>>> Hi Sameera,
>>>
>>> No its not. The patch is in org.wso2.analytics.spark.patch
>>> component. Its still not committed to carbon - analytics
>>>
>>> Rgds
>>>
>>> On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma 
>>> wrote:
>>>
 Hi Niranda,

 Does this include fragment-bundle/patch modification also?

 Thanks,
 Sameera.

 On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera 
 wrote:

> Hi,
>
> Kind reminder on this.
>
> Best regards
>
> Niranda Perera
> Software Engineer, WSO2 Inc.
> Mobile: +94-71-554-8430
> Twitter: @n1r44
> On Apr 14, 2015 19:17, "Niranda Perera"  wrote:
>
>> Hi Sameera,
>>
>> Could you please review this PR [1] for Spark 1.3.0.
>>
>> this upgrades 1.2.1 to 1.3.0. this upgrade is done, because 1.3.0
>> comes with some major API changes and we wanted to include those API
>> changes before the DAS (BAM) 3.0.0 alpha
>>
>> cheers
>>
>> [1] https://github.com/wso2/orbit/pull/83
>>
>> --
>> *Niranda Perera*
>> Software Engineer, WSO2 Inc.
>> Mobile: +94-71-554-8430
>> Twitter: @n1r44 
>>
>


 --
 Sameera Jayasoma,
 Software Architect,

 WSO2, Inc. (http://wso2.com)
 email: same...@wso2.com
 blog: http://blog.sameera.org
 twitter: https://twitter.com/sameerajayasoma
 flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
 Mobile: 0094776364456

 Lean . Enterprise . Middleware


>>
>>
>> --
>> Sameera Jayasoma,
>> Software Architect,
>>
>> WSO2, Inc. (http://wso2.com)
>> email: same...@wso2.com
>> blog: http://b

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Kasun Gajasinghe]

Hi Niranda,

Can you also fix the import-packages to not have star imports with resolution 
optional?

Thanks. 

> On Apr 28, 2015, at 1:50 PM, Niranda Perera  wrote:
> 
> @Kasun thank you for the clarification 
> 
> I have made the adjustments. can you please check it? 
> 
> rgds
> 
>> On Mon, Apr 27, 2015 at 11:16 AM, KasunG Gajasinghe  wrote:
>> Hi Niranda,
>> 
>> The Bundle-Classpath tag is as mentioned above is required to over-ride the 
>> classes in the original orbit bundle. Since both the orbit bundle, and 
>> patched bundle have the same classes, we need to instruct to give precedence 
>> to the patch.jar. Hence, the above tag is required. 
>> 
>> The bundles will be resolved fine, but the over-riding may or may not 
>> happen. So, can you add this tag? Further, there are some pending comments 
>> in the PR.
>> 
>> Thanks.
>> 
>>> On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera  wrote:
>>> Hi Supun, 
>>> 
>>> are you referring to this?
>>> 
>>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>>> 
>>> 
>>> well, AFAIK what export-package does is, it exposes the org.apache.spark.* 
>>> classes in the OSGI environment. since we are not doing any patching for 
>>> the original classes, I dont think we have to change the version to 
>>> 1.3.0.wso2v1
>>> 
>>> @sameera, pls correct me if I'm wrong. 
>>> 
>>> rgds
>>> 
 On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga  wrote:
 Hi Sameera/Niranda,
 
 With parallel to this, Im in the process of migrating the spark Ml-Lib and 
 spark streaming versions for product ML. Just wanted to clear myself, 
 shouldn't the export-package-version of all spark packages be 
 1.3.0.wso2v1, rather than 1.3.0?
 
 Thanks,
 Supun
 
> On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera  wrote:
> oh. are you referring to the 
> patch.jar,. 
> line?
> I did not include it in the orbit bundle.
> 
> but I checked the bundles in a fresh carbon server and it seems like the 
> patch gets attached successfully.
> ​
>  Screenshot from 2015-04-17 16:20:15.png
> ​
> I checked it with BAM pack also. 
> 
>  tag, is it mandatory to be in the for the orbit 
> bundle, for the patch to get attached?
> 
> the patch pom is as follows 
> https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml
> 
> 
> 
> 
> 
>> On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando  wrote:
>> Niranda, yeah, we would have to put that part to be able to later patch 
>> it. A sample can be found here [1].
>> 
>> [1] 
>> https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml
>> 
>> Cheers,
>> Anjana.
>> 
>>> On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma  
>>> wrote:
>>> I meant to say, do we need to add the patch.jar line to the spark 
>>> bundle as we've done in Tomcat bundle.
>>> 
>>> Thanks,
>>> Sameera.
>>> 
 On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera  
 wrote:
 Hi Sameera,
 
 No its not. The patch is in org.wso2.analytics.spark.patch component. 
 Its still not committed to carbon - analytics
 
 Rgds
 
> On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma  wrote:
> Hi Niranda,
> 
> Does this include fragment-bundle/patch modification also?
> 
> Thanks,
> Sameera.
> 
>> On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera  
>> wrote:
>> Hi,
>> 
>> Kind reminder on this.
>> 
>> Best regards
>> 
>> Niranda Perera
>> Software Engineer, WSO2 Inc.
>> Mobile: +94-71-554-8430
>> Twitter: @n1r44
>> 
>>> On Apr 14, 2015 19:17, "Niranda Perera"  wrote:
>>> Hi Sameera, 
>>> 
>>> Could you please review this PR [1] for Spark 1.3.0. 
>>> 
>>> this upgrades 1.2.1 to 1.3.0. this upgrade is done, because 1.3.0 
>>> comes with some major API changes and we wanted to include those 
>>> API changes before the DAS (BAM) 3.0.0 alpha
>>> 
>>> cheers
>>> 
>>> [1] https://github.com/wso2/orbit/pull/83
>>> 
>>> -- 
>>> Niranda Perera
>>> Software Engineer, WSO2 Inc.
>>> Mobile: +94-71-554-8430
>>> Twitter: @n1r44
> 
> 
> 
> -- 
> Sameera Jayasoma,
> Software Architect,
> 
> WSO2, Inc. (http://wso2.com)
> email: same...@wso2.com
> blog: http://blog.sameera.org
> twitter: https://twitter.com/sameerajayasoma
> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
> Mobile: 0094776364456
> 
> Lean

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Niranda Perera]

Hi Kasun,

I did the changes. could you please check it now? thanks

rgds

On Tue, Apr 28, 2015 at 9:49 PM, Kasun Gajasinghe  wrote:

> Hi Niranda,
>
> Can you also fix the import-packages to not have star imports with
> resolution optional?
>
> Thanks.
>
> On Apr 28, 2015, at 1:50 PM, Niranda Perera  wrote:
>
> @Kasun thank you for the clarification
>
> I have made the adjustments. can you please check it?
>
> rgds
>
> On Mon, Apr 27, 2015 at 11:16 AM, KasunG Gajasinghe 
> wrote:
>
>> Hi Niranda,
>>
>> The Bundle-Classpath tag is as mentioned above is required to over-ride
>> the classes in the original orbit bundle. Since both the orbit bundle, and
>> patched bundle have the same classes, we need to instruct to give
>> precedence to the patch.jar. Hence, the above tag is required.
>>
>> The bundles will be resolved fine, but the over-riding may or may not
>> happen. So, can you add this tag? Further, there are some pending comments
>> in the PR.
>>
>> Thanks.
>>
>> On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera 
>> wrote:
>>
>>> Hi Supun,
>>>
>>> are you referring to this?
>>> 
>>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>>> 
>>>
>>> well, AFAIK what export-package does is, it exposes the
>>> org.apache.spark.* classes in the OSGI environment. since we are not doing
>>> any patching for the original classes, I dont think we have to change the
>>> version to 1.3.0.wso2v1
>>>
>>> @sameera, pls correct me if I'm wrong.
>>>
>>> rgds
>>>
>>> On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga  wrote:
>>>
 Hi Sameera/Niranda,

 With parallel to this, Im in the process of migrating the spark Ml-Lib
 and spark streaming versions for product ML. Just wanted to clear myself,
 shouldn't the export-package-version of all spark packages be 1.3.0.wso2v1,
 rather than 1.3.0?

 Thanks,
 Supun

 On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera 
 wrote:

> oh. are you referring to the
> patch.jar,.
> line?
> I did not include it in the orbit bundle.
>
> but I checked the bundles in a fresh carbon server and it seems like
> the patch gets attached successfully.
> ​
>  Screenshot from 2015-04-17 16:20:15.png
> 
> ​
> I checked it with BAM pack also.
>
>  tag, is it mandatory to be in the for the orbit
> bundle, for the patch to get attached?
>
> the patch pom is as follows
>
> https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml
>
>
>
>
>
> On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando 
> wrote:
>
>> Niranda, yeah, we would have to put that part to be able to later
>> patch it. A sample can be found here [1].
>>
>> [1]
>> https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml
>>
>> Cheers,
>> Anjana.
>>
>> On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma 
>> wrote:
>>
>>> I meant to say, do we need to add the patch.jar line to the spark
>>> bundle as we've done in Tomcat bundle.
>>>
>>> Thanks,
>>> Sameera.
>>>
>>> On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera 
>>> wrote:
>>>
 Hi Sameera,

 No its not. The patch is in org.wso2.analytics.spark.patch
 component. Its still not committed to carbon - analytics

 Rgds

 On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma 
 wrote:

> Hi Niranda,
>
> Does this include fragment-bundle/patch modification also?
>
> Thanks,
> Sameera.
>
> On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera 
> wrote:
>
>> Hi,
>>
>> Kind reminder on this.
>>
>> Best regards
>>
>> Niranda Perera
>> Software Engineer, WSO2 Inc.
>> Mobile: +94-71-554-8430
>> Twitter: @n1r44
>> On Apr 14, 2015 19:17, "Niranda Perera"  wrote:
>>
>>> Hi Sameera,
>>>
>>> Could you please review this PR [1] for Spark 1.3.0.
>>>
>>> this upgrades 1.2.1 to 1.3.0. this upgrade is done, because
>>> 1.3.0 comes with some major API changes and we wanted to include 
>>> those API
>>> changes before the DAS (BAM) 3.0.0 alpha
>>>
>>> cheers
>>>
>>> [1] https://github.com/wso2/orbit/pull/83
>>>
>>> --
>>> *Niranda Perera*
>>> Software Engineer, WSO2 Inc.
>>> Mobile: +94-71-554-8430
>>> Twitter: @n1r44 
>>>
>>
>
>
> --
> Sameera Jayasoma,
> Software Architect,
>
> WSO2,

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Supun Sethunga]

Hi Niranda,

are you referring to this?
> 
> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
> 


Yes exactly. My concern was, what if multiple versions of the same package
were in the same osgi environment..  I know its very highly unlikely, but
IF such a case happens, then I think spark (or any bundle) will pick up
only one of the versions.

Thanks,
Supun

On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera  wrote:

> Hi Supun,
>
> are you referring to this?
> 
> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
> 
>
> well, AFAIK what export-package does is, it exposes the org.apache.spark.*
> classes in the OSGI environment. since we are not doing any patching for
> the original classes, I dont think we have to change the version to
> 1.3.0.wso2v1
>
> @sameera, pls correct me if I'm wrong.
>
> rgds
>
> On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga  wrote:
>
>> Hi Sameera/Niranda,
>>
>> With parallel to this, Im in the process of migrating the spark Ml-Lib
>> and spark streaming versions for product ML. Just wanted to clear myself,
>> shouldn't the export-package-version of all spark packages be 1.3.0.wso2v1,
>> rather than 1.3.0?
>>
>> Thanks,
>> Supun
>>
>> On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera  wrote:
>>
>>> oh. are you referring to the
>>> patch.jar,.
>>> line?
>>> I did not include it in the orbit bundle.
>>>
>>> but I checked the bundles in a fresh carbon server and it seems like the
>>> patch gets attached successfully.
>>> ​
>>>  Screenshot from 2015-04-17 16:20:15.png
>>> 
>>> ​
>>> I checked it with BAM pack also.
>>>
>>>  tag, is it mandatory to be in the for the orbit
>>> bundle, for the patch to get attached?
>>>
>>> the patch pom is as follows
>>>
>>> https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml
>>>
>>>
>>>
>>>
>>>
>>> On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando 
>>> wrote:
>>>
 Niranda, yeah, we would have to put that part to be able to later patch
 it. A sample can be found here [1].

 [1]
 https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml

 Cheers,
 Anjana.

 On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma 
 wrote:

> I meant to say, do we need to add the patch.jar line to the spark
> bundle as we've done in Tomcat bundle.
>
> Thanks,
> Sameera.
>
> On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera 
> wrote:
>
>> Hi Sameera,
>>
>> No its not. The patch is in org.wso2.analytics.spark.patch component.
>> Its still not committed to carbon - analytics
>>
>> Rgds
>>
>> On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma 
>> wrote:
>>
>>> Hi Niranda,
>>>
>>> Does this include fragment-bundle/patch modification also?
>>>
>>> Thanks,
>>> Sameera.
>>>
>>> On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera 
>>> wrote:
>>>
 Hi,

 Kind reminder on this.

 Best regards

 Niranda Perera
 Software Engineer, WSO2 Inc.
 Mobile: +94-71-554-8430
 Twitter: @n1r44
 On Apr 14, 2015 19:17, "Niranda Perera"  wrote:

> Hi Sameera,
>
> Could you please review this PR [1] for Spark 1.3.0.
>
> this upgrades 1.2.1 to 1.3.0. this upgrade is done, because 1.3.0
> comes with some major API changes and we wanted to include those API
> changes before the DAS (BAM) 3.0.0 alpha
>
> cheers
>
> [1] https://github.com/wso2/orbit/pull/83
>
> --
> *Niranda Perera*
> Software Engineer, WSO2 Inc.
> Mobile: +94-71-554-8430
> Twitter: @n1r44 
>

>>>
>>>
>>> --
>>> Sameera Jayasoma,
>>> Software Architect,
>>>
>>> WSO2, Inc. (http://wso2.com)
>>> email: same...@wso2.com
>>> blog: http://blog.sameera.org
>>> twitter: https://twitter.com/sameerajayasoma
>>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
>>> Mobile: 0094776364456
>>>
>>> Lean . Enterprise . Middleware
>>>
>>>
>
>
> --
> Sameera Jayasoma,
> Software Architect,
>
> WSO2, Inc. (http://wso2.com)
> email: same...@wso2.com
> blog: http://blog.sameera.org
> twitter: https://twitter.com/sameerajayasoma
> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
> Mobile: 0094776364456
>
> Lean . Enterprise . Middleware
>
>


 --
 *Anjana Fernando*
 Senior Technical Lead
 WSO2 Inc. | http://wso2.com
 lean . enterprise . middleware

>>>
>>>
>>>
>>> --
>>> *Niranda Perera*
>>> Softwa

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Niranda Perera]

Hi Supun,

let me understand the scenario here.

say there are 2 OSGI bundle in the environment spark v 1.3.0 and spark v
1.2.1 and we have a component org.wso2.analytics.spark.core which imports
org.apache.spark version [1.2.1, 1.4.0).
then AFAIK in the OSGI environment, org.wso2.analytics.spark.core gets
wired to the latest version in the runtime.
@carbon team pls correct me if I'm wrong

but I do not think it has anything to do with the  tag in
the orbit bundle.

rgds

On Wed, Apr 29, 2015 at 10:22 AM, Supun Sethunga  wrote:

> Hi Niranda,
>
> are you referring to this?
>> 
>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>> 
>
>
> Yes exactly. My concern was, what if multiple versions of the same package
> were in the same osgi environment..  I know its very highly unlikely, but
> IF such a case happens, then I think spark (or any bundle) will pick up
> only one of the versions.
>
> Thanks,
> Supun
>
> On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera  wrote:
>
>> Hi Supun,
>>
>> are you referring to this?
>> 
>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>> 
>>
>> well, AFAIK what export-package does is, it exposes the
>> org.apache.spark.* classes in the OSGI environment. since we are not doing
>> any patching for the original classes, I dont think we have to change the
>> version to 1.3.0.wso2v1
>>
>> @sameera, pls correct me if I'm wrong.
>>
>> rgds
>>
>> On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga  wrote:
>>
>>> Hi Sameera/Niranda,
>>>
>>> With parallel to this, Im in the process of migrating the spark Ml-Lib
>>> and spark streaming versions for product ML. Just wanted to clear myself,
>>> shouldn't the export-package-version of all spark packages be 1.3.0.wso2v1,
>>> rather than 1.3.0?
>>>
>>> Thanks,
>>> Supun
>>>
>>> On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera 
>>> wrote:
>>>
 oh. are you referring to the
 patch.jar,.
 line?
 I did not include it in the orbit bundle.

 but I checked the bundles in a fresh carbon server and it seems like
 the patch gets attached successfully.
 ​
  Screenshot from 2015-04-17 16:20:15.png
 
 ​
 I checked it with BAM pack also.

  tag, is it mandatory to be in the for the orbit
 bundle, for the patch to get attached?

 the patch pom is as follows

 https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml





 On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando 
 wrote:

> Niranda, yeah, we would have to put that part to be able to later
> patch it. A sample can be found here [1].
>
> [1]
> https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml
>
> Cheers,
> Anjana.
>
> On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma 
> wrote:
>
>> I meant to say, do we need to add the patch.jar line to the spark
>> bundle as we've done in Tomcat bundle.
>>
>> Thanks,
>> Sameera.
>>
>> On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera 
>> wrote:
>>
>>> Hi Sameera,
>>>
>>> No its not. The patch is in org.wso2.analytics.spark.patch
>>> component. Its still not committed to carbon - analytics
>>>
>>> Rgds
>>>
>>> On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma 
>>> wrote:
>>>
 Hi Niranda,

 Does this include fragment-bundle/patch modification also?

 Thanks,
 Sameera.

 On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera 
 wrote:

> Hi,
>
> Kind reminder on this.
>
> Best regards
>
> Niranda Perera
> Software Engineer, WSO2 Inc.
> Mobile: +94-71-554-8430
> Twitter: @n1r44
> On Apr 14, 2015 19:17, "Niranda Perera"  wrote:
>
>> Hi Sameera,
>>
>> Could you please review this PR [1] for Spark 1.3.0.
>>
>> this upgrades 1.2.1 to 1.3.0. this upgrade is done, because 1.3.0
>> comes with some major API changes and we wanted to include those API
>> changes before the DAS (BAM) 3.0.0 alpha
>>
>> cheers
>>
>> [1] https://github.com/wso2/orbit/pull/83
>>
>> --
>> *Niranda Perera*
>> Software Engineer, WSO2 Inc.
>> Mobile: +94-71-554-8430
>> Twitter: @n1r44 
>>
>


 --
 Sameera Jayasoma,
 Software Architect,

 WSO2, Inc. (http://wso2.com)
 email: same...@wso2.com
 blog: http://blog.sameera.org
 twitter: https://twitter.com/sameerajayasoma
 flickr: http://www.flickr.com

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Niranda Perera]

Hi Kasun,

I've done the changes. But could you please hold this for the moment.

I came across with a bug. I will let you know once I cleared it out.

rgds

On Wed, Apr 29, 2015 at 9:49 AM, Niranda Perera  wrote:

> Hi Kasun,
>
> I did the changes. could you please check it now? thanks
>
> rgds
>
> On Tue, Apr 28, 2015 at 9:49 PM, Kasun Gajasinghe  wrote:
>
>> Hi Niranda,
>>
>> Can you also fix the import-packages to not have star imports with
>> resolution optional?
>>
>> Thanks.
>>
>> On Apr 28, 2015, at 1:50 PM, Niranda Perera  wrote:
>>
>> @Kasun thank you for the clarification
>>
>> I have made the adjustments. can you please check it?
>>
>> rgds
>>
>> On Mon, Apr 27, 2015 at 11:16 AM, KasunG Gajasinghe 
>> wrote:
>>
>>> Hi Niranda,
>>>
>>> The Bundle-Classpath tag is as mentioned above is required to over-ride
>>> the classes in the original orbit bundle. Since both the orbit bundle, and
>>> patched bundle have the same classes, we need to instruct to give
>>> precedence to the patch.jar. Hence, the above tag is required.
>>>
>>> The bundles will be resolved fine, but the over-riding may or may not
>>> happen. So, can you add this tag? Further, there are some pending comments
>>> in the PR.
>>>
>>> Thanks.
>>>
>>> On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera 
>>> wrote:
>>>
 Hi Supun,

 are you referring to this?
 

 org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
 

 well, AFAIK what export-package does is, it exposes the
 org.apache.spark.* classes in the OSGI environment. since we are not doing
 any patching for the original classes, I dont think we have to change the
 version to 1.3.0.wso2v1

 @sameera, pls correct me if I'm wrong.

 rgds

 On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga 
 wrote:

> Hi Sameera/Niranda,
>
> With parallel to this, Im in the process of migrating the spark Ml-Lib
> and spark streaming versions for product ML. Just wanted to clear myself,
> shouldn't the export-package-version of all spark packages be 
> 1.3.0.wso2v1,
> rather than 1.3.0?
>
> Thanks,
> Supun
>
> On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera 
> wrote:
>
>> oh. are you referring to the
>> patch.jar,.
>> line?
>> I did not include it in the orbit bundle.
>>
>> but I checked the bundles in a fresh carbon server and it seems like
>> the patch gets attached successfully.
>> ​
>>  Screenshot from 2015-04-17 16:20:15.png
>> 
>> ​
>> I checked it with BAM pack also.
>>
>>  tag, is it mandatory to be in the for the orbit
>> bundle, for the patch to get attached?
>>
>> the patch pom is as follows
>>
>> https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml
>>
>>
>>
>>
>>
>> On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando 
>> wrote:
>>
>>> Niranda, yeah, we would have to put that part to be able to later
>>> patch it. A sample can be found here [1].
>>>
>>> [1]
>>> https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml
>>>
>>> Cheers,
>>> Anjana.
>>>
>>> On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma 
>>> wrote:
>>>
 I meant to say, do we need to add the patch.jar line to the spark
 bundle as we've done in Tomcat bundle.

 Thanks,
 Sameera.

 On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera 
 wrote:

> Hi Sameera,
>
> No its not. The patch is in org.wso2.analytics.spark.patch
> component. Its still not committed to carbon - analytics
>
> Rgds
>
> On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma 
> wrote:
>
>> Hi Niranda,
>>
>> Does this include fragment-bundle/patch modification also?
>>
>> Thanks,
>> Sameera.
>>
>> On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera > > wrote:
>>
>>> Hi,
>>>
>>> Kind reminder on this.
>>>
>>> Best regards
>>>
>>> Niranda Perera
>>> Software Engineer, WSO2 Inc.
>>> Mobile: +94-71-554-8430
>>> Twitter: @n1r44
>>> On Apr 14, 2015 19:17, "Niranda Perera" 
>>> wrote:
>>>
 Hi Sameera,

 Could you please review this PR [1] for Spark 1.3.0.

 this upgrades 1.2.1 to 1.3.0. this upgrade is done, because
 1.3.0 comes with some major API changes and we wanted to include 
 those API
 changes before the DAS (BAM) 3.0.0 alpha

>>>

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[KasunG Gajasinghe]

Hi Niranda,

I believe the point Supun making is if there are two versions of spark
1.3.0 has made there way into a pack, then only one version will be picked
up. This is an unlikely scenario. But as a best practice, it'll be better
to export the exact version from now on.

On Wed, Apr 29, 2015 at 10:45 AM, Niranda Perera  wrote:

> Hi Supun,
>
> let me understand the scenario here.
>
> say there are 2 OSGI bundle in the environment spark v 1.3.0 and spark v
> 1.2.1 and we have a component org.wso2.analytics.spark.core which imports
> org.apache.spark version [1.2.1, 1.4.0).
> then AFAIK in the OSGI environment, org.wso2.analytics.spark.core gets
> wired to the latest version in the runtime.
> @carbon team pls correct me if I'm wrong
>
> but I do not think it has anything to do with the  tag in
> the orbit bundle.
>
> rgds
>
> On Wed, Apr 29, 2015 at 10:22 AM, Supun Sethunga  wrote:
>
>> Hi Niranda,
>>
>> are you referring to this?
>>> 
>>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>>> 
>>
>>
>> Yes exactly. My concern was, what if multiple versions of the same
>> package were in the same osgi environment..  I know its very highly
>> unlikely, but IF such a case happens, then I think spark (or any bundle)
>> will pick up only one of the versions.
>>
>> Thanks,
>> Supun
>>
>> On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera 
>> wrote:
>>
>>> Hi Supun,
>>>
>>> are you referring to this?
>>> 
>>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>>> 
>>>
>>> well, AFAIK what export-package does is, it exposes the
>>> org.apache.spark.* classes in the OSGI environment. since we are not doing
>>> any patching for the original classes, I dont think we have to change the
>>> version to 1.3.0.wso2v1
>>>
>>> @sameera, pls correct me if I'm wrong.
>>>
>>> rgds
>>>
>>> On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga  wrote:
>>>
 Hi Sameera/Niranda,

 With parallel to this, Im in the process of migrating the spark Ml-Lib
 and spark streaming versions for product ML. Just wanted to clear myself,
 shouldn't the export-package-version of all spark packages be 1.3.0.wso2v1,
 rather than 1.3.0?

 Thanks,
 Supun

 On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera 
 wrote:

> oh. are you referring to the
> patch.jar,.
> line?
> I did not include it in the orbit bundle.
>
> but I checked the bundles in a fresh carbon server and it seems like
> the patch gets attached successfully.
> ​
>  Screenshot from 2015-04-17 16:20:15.png
> 
> ​
> I checked it with BAM pack also.
>
>  tag, is it mandatory to be in the for the orbit
> bundle, for the patch to get attached?
>
> the patch pom is as follows
>
> https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml
>
>
>
>
>
> On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando 
> wrote:
>
>> Niranda, yeah, we would have to put that part to be able to later
>> patch it. A sample can be found here [1].
>>
>> [1]
>> https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml
>>
>> Cheers,
>> Anjana.
>>
>> On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma 
>> wrote:
>>
>>> I meant to say, do we need to add the patch.jar line to the spark
>>> bundle as we've done in Tomcat bundle.
>>>
>>> Thanks,
>>> Sameera.
>>>
>>> On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera 
>>> wrote:
>>>
 Hi Sameera,

 No its not. The patch is in org.wso2.analytics.spark.patch
 component. Its still not committed to carbon - analytics

 Rgds

 On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma 
 wrote:

> Hi Niranda,
>
> Does this include fragment-bundle/patch modification also?
>
> Thanks,
> Sameera.
>
> On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera 
> wrote:
>
>> Hi,
>>
>> Kind reminder on this.
>>
>> Best regards
>>
>> Niranda Perera
>> Software Engineer, WSO2 Inc.
>> Mobile: +94-71-554-8430
>> Twitter: @n1r44
>> On Apr 14, 2015 19:17, "Niranda Perera"  wrote:
>>
>>> Hi Sameera,
>>>
>>> Could you please review this PR [1] for Spark 1.3.0.
>>>
>>> this upgrades 1.2.1 to 1.3.0. this upgrade is done, because
>>> 1.3.0 comes with some major API changes and we wanted to include 
>>> those API
>>> changes before the DAS (BAM) 3.0.0 alpha
>>>
>>> cheers
>>>
>>> [1] https://github.com/w

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Niranda Perera]

Hi Kasun,

Could you please check this bundle again. I fix the issue, and it did not
affect the orbit bundle.

rgds

On Wed, Apr 29, 2015 at 5:00 PM, KasunG Gajasinghe  wrote:

> Hi Niranda,
>
> I believe the point Supun making is if there are two versions of spark
> 1.3.0 has made there way into a pack, then only one version will be picked
> up. This is an unlikely scenario. But as a best practice, it'll be better
> to export the exact version from now on.
>
> On Wed, Apr 29, 2015 at 10:45 AM, Niranda Perera  wrote:
>
>> Hi Supun,
>>
>> let me understand the scenario here.
>>
>> say there are 2 OSGI bundle in the environment spark v 1.3.0 and spark v
>> 1.2.1 and we have a component org.wso2.analytics.spark.core which imports
>> org.apache.spark version [1.2.1, 1.4.0).
>> then AFAIK in the OSGI environment, org.wso2.analytics.spark.core gets
>> wired to the latest version in the runtime.
>> @carbon team pls correct me if I'm wrong
>>
>> but I do not think it has anything to do with the  tag in
>> the orbit bundle.
>>
>> rgds
>>
>> On Wed, Apr 29, 2015 at 10:22 AM, Supun Sethunga  wrote:
>>
>>> Hi Niranda,
>>>
>>> are you referring to this?
 

 org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
 
>>>
>>>
>>> Yes exactly. My concern was, what if multiple versions of the same
>>> package were in the same osgi environment..  I know its very highly
>>> unlikely, but IF such a case happens, then I think spark (or any bundle)
>>> will pick up only one of the versions.
>>>
>>> Thanks,
>>> Supun
>>>
>>> On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera 
>>> wrote:
>>>
 Hi Supun,

 are you referring to this?
 

 org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
 

 well, AFAIK what export-package does is, it exposes the
 org.apache.spark.* classes in the OSGI environment. since we are not doing
 any patching for the original classes, I dont think we have to change the
 version to 1.3.0.wso2v1

 @sameera, pls correct me if I'm wrong.

 rgds

 On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga 
 wrote:

> Hi Sameera/Niranda,
>
> With parallel to this, Im in the process of migrating the spark Ml-Lib
> and spark streaming versions for product ML. Just wanted to clear myself,
> shouldn't the export-package-version of all spark packages be 
> 1.3.0.wso2v1,
> rather than 1.3.0?
>
> Thanks,
> Supun
>
> On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera 
> wrote:
>
>> oh. are you referring to the
>> patch.jar,.
>> line?
>> I did not include it in the orbit bundle.
>>
>> but I checked the bundles in a fresh carbon server and it seems like
>> the patch gets attached successfully.
>> ​
>>  Screenshot from 2015-04-17 16:20:15.png
>> 
>> ​
>> I checked it with BAM pack also.
>>
>>  tag, is it mandatory to be in the for the orbit
>> bundle, for the patch to get attached?
>>
>> the patch pom is as follows
>>
>> https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml
>>
>>
>>
>>
>>
>> On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando 
>> wrote:
>>
>>> Niranda, yeah, we would have to put that part to be able to later
>>> patch it. A sample can be found here [1].
>>>
>>> [1]
>>> https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml
>>>
>>> Cheers,
>>> Anjana.
>>>
>>> On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma 
>>> wrote:
>>>
 I meant to say, do we need to add the patch.jar line to the spark
 bundle as we've done in Tomcat bundle.

 Thanks,
 Sameera.

 On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera 
 wrote:

> Hi Sameera,
>
> No its not. The patch is in org.wso2.analytics.spark.patch
> component. Its still not committed to carbon - analytics
>
> Rgds
>
> On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma 
> wrote:
>
>> Hi Niranda,
>>
>> Does this include fragment-bundle/patch modification also?
>>
>> Thanks,
>> Sameera.
>>
>> On Thu, Apr 16, 2015 at 8:03 AM, Niranda Perera > > wrote:
>>
>>> Hi,
>>>
>>> Kind reminder on this.
>>>
>>> Best regards
>>>
>>> Niranda Perera
>>> Software Engineer, WSO2 Inc.
>>> Mobile: +94-71-554-8430
>>> Twitter: @n1r44
>>> On Apr 14, 2015 19:17, "Niranda Perera" 
>>> wrote:
>>>
 Hi Sameera,

>

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[KasunG Gajasinghe]

Hi Niranda,

Released the following orbit bundles. (finally! ;) )

spark-core_2.10
 spark-sql_2.10

@Maheshika, can you release these two orbit bundles. Please make sure to
use JDK 7 for  building.



On Tue, May 5, 2015 at 12:46 PM, Niranda Perera  wrote:

> Hi Kasun,
>
> Could you please check this bundle again. I fix the issue, and it did not
> affect the orbit bundle.
>
> rgds
>
> On Wed, Apr 29, 2015 at 5:00 PM, KasunG Gajasinghe 
> wrote:
>
>> Hi Niranda,
>>
>> I believe the point Supun making is if there are two versions of spark
>> 1.3.0 has made there way into a pack, then only one version will be picked
>> up. This is an unlikely scenario. But as a best practice, it'll be better
>> to export the exact version from now on.
>>
>> On Wed, Apr 29, 2015 at 10:45 AM, Niranda Perera 
>> wrote:
>>
>>> Hi Supun,
>>>
>>> let me understand the scenario here.
>>>
>>> say there are 2 OSGI bundle in the environment spark v 1.3.0 and spark v
>>> 1.2.1 and we have a component org.wso2.analytics.spark.core which imports
>>> org.apache.spark version [1.2.1, 1.4.0).
>>> then AFAIK in the OSGI environment, org.wso2.analytics.spark.core gets
>>> wired to the latest version in the runtime.
>>> @carbon team pls correct me if I'm wrong
>>>
>>> but I do not think it has anything to do with the  tag
>>> in the orbit bundle.
>>>
>>> rgds
>>>
>>> On Wed, Apr 29, 2015 at 10:22 AM, Supun Sethunga 
>>> wrote:
>>>
 Hi Niranda,

 are you referring to this?
> 
>
> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
> 


 Yes exactly. My concern was, what if multiple versions of the same
 package were in the same osgi environment..  I know its very highly
 unlikely, but IF such a case happens, then I think spark (or any bundle)
 will pick up only one of the versions.

 Thanks,
 Supun

 On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera 
 wrote:

> Hi Supun,
>
> are you referring to this?
> 
>
> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
> 
>
> well, AFAIK what export-package does is, it exposes the
> org.apache.spark.* classes in the OSGI environment. since we are not doing
> any patching for the original classes, I dont think we have to change the
> version to 1.3.0.wso2v1
>
> @sameera, pls correct me if I'm wrong.
>
> rgds
>
> On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga 
> wrote:
>
>> Hi Sameera/Niranda,
>>
>> With parallel to this, Im in the process of migrating the spark
>> Ml-Lib and spark streaming versions for product ML. Just wanted to clear
>> myself, shouldn't the export-package-version of all spark packages be
>> 1.3.0.wso2v1, rather than 1.3.0?
>>
>> Thanks,
>> Supun
>>
>> On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera 
>> wrote:
>>
>>> oh. are you referring to the
>>> patch.jar,.
>>> line?
>>> I did not include it in the orbit bundle.
>>>
>>> but I checked the bundles in a fresh carbon server and it seems like
>>> the patch gets attached successfully.
>>> ​
>>>  Screenshot from 2015-04-17 16:20:15.png
>>> 
>>> ​
>>> I checked it with BAM pack also.
>>>
>>>  tag, is it mandatory to be in the for the orbit
>>> bundle, for the patch to get attached?
>>>
>>> the patch pom is as follows
>>>
>>> https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml
>>>
>>>
>>>
>>>
>>>
>>> On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando 
>>> wrote:
>>>
 Niranda, yeah, we would have to put that part to be able to later
 patch it. A sample can be found here [1].

 [1]
 https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml

 Cheers,
 Anjana.

 On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma >>> > wrote:

> I meant to say, do we need to add the patch.jar line to the spark
> bundle as we've done in Tomcat bundle.
>
> Thanks,
> Sameera.
>
> On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera  > wrote:
>
>> Hi Sameera,
>>
>> No its not. The patch is in org.wso2.analytics.spark.patch
>> component. Its still not committed to carbon - analytics
>>
>> Rgds
>>
>> On Thu, Apr 16, 2015, 12:17 Sameera Jayasoma 
>> wrote:
>>
>>> Hi Niranda,
>>>
>>> Does this include fragment-bundle/patch modification also?
>>>
>>> Thanks,
>>> Sameera.
>>>
>>> On Thu, Apr 16, 2015 at 8:03 

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Maheshika Goonetilleke]

Hi Kasun

Both were deployed successfully.

On Tue, May 5, 2015 at 6:54 PM, KasunG Gajasinghe  wrote:

> Hi Niranda,
>
> Released the following orbit bundles. (finally! ;) )
>
> spark-core_2.10
>  spark-sql_2.10
>
> @Maheshika, can you release these two orbit bundles. Please make sure to
> use JDK 7 for  building.
>
>
>
> On Tue, May 5, 2015 at 12:46 PM, Niranda Perera  wrote:
>
>> Hi Kasun,
>>
>> Could you please check this bundle again. I fix the issue, and it did not
>> affect the orbit bundle.
>>
>> rgds
>>
>> On Wed, Apr 29, 2015 at 5:00 PM, KasunG Gajasinghe 
>> wrote:
>>
>>> Hi Niranda,
>>>
>>> I believe the point Supun making is if there are two versions of spark
>>> 1.3.0 has made there way into a pack, then only one version will be picked
>>> up. This is an unlikely scenario. But as a best practice, it'll be better
>>> to export the exact version from now on.
>>>
>>> On Wed, Apr 29, 2015 at 10:45 AM, Niranda Perera 
>>> wrote:
>>>
 Hi Supun,

 let me understand the scenario here.

 say there are 2 OSGI bundle in the environment spark v 1.3.0 and spark
 v 1.2.1 and we have a component org.wso2.analytics.spark.core which imports
 org.apache.spark version [1.2.1, 1.4.0).
 then AFAIK in the OSGI environment, org.wso2.analytics.spark.core gets
 wired to the latest version in the runtime.
 @carbon team pls correct me if I'm wrong

 but I do not think it has anything to do with the  tag
 in the orbit bundle.

 rgds

 On Wed, Apr 29, 2015 at 10:22 AM, Supun Sethunga 
 wrote:

> Hi Niranda,
>
> are you referring to this?
>> 
>>
>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>> 
>
>
> Yes exactly. My concern was, what if multiple versions of the same
> package were in the same osgi environment..  I know its very highly
> unlikely, but IF such a case happens, then I think spark (or any bundle)
> will pick up only one of the versions.
>
> Thanks,
> Supun
>
> On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera 
> wrote:
>
>> Hi Supun,
>>
>> are you referring to this?
>> 
>>
>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>> 
>>
>> well, AFAIK what export-package does is, it exposes the
>> org.apache.spark.* classes in the OSGI environment. since we are not 
>> doing
>> any patching for the original classes, I dont think we have to change the
>> version to 1.3.0.wso2v1
>>
>> @sameera, pls correct me if I'm wrong.
>>
>> rgds
>>
>> On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga 
>> wrote:
>>
>>> Hi Sameera/Niranda,
>>>
>>> With parallel to this, Im in the process of migrating the spark
>>> Ml-Lib and spark streaming versions for product ML. Just wanted to clear
>>> myself, shouldn't the export-package-version of all spark packages be
>>> 1.3.0.wso2v1, rather than 1.3.0?
>>>
>>> Thanks,
>>> Supun
>>>
>>> On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera 
>>> wrote:
>>>
 oh. are you referring to the
 patch.jar,.
 line?
 I did not include it in the orbit bundle.

 but I checked the bundles in a fresh carbon server and it seems
 like the patch gets attached successfully.
 ​
  Screenshot from 2015-04-17 16:20:15.png
 
 ​
 I checked it with BAM pack also.

  tag, is it mandatory to be in the for the orbit
 bundle, for the patch to get attached?

 the patch pom is as follows

 https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml





 On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando 
 wrote:

> Niranda, yeah, we would have to put that part to be able to later
> patch it. A sample can be found here [1].
>
> [1]
> https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml
>
> Cheers,
> Anjana.
>
> On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma <
> same...@wso2.com> wrote:
>
>> I meant to say, do we need to add the patch.jar line to the spark
>> bundle as we've done in Tomcat bundle.
>>
>> Thanks,
>> Sameera.
>>
>> On Thu, Apr 16, 2015 at 12:31 PM, Niranda Perera <
>> nira...@wso2.com> wrote:
>>
>>> Hi Sameera,
>>>
>>> No its not. The patch is in org.wso2.analytics.spark.patch
>>> component. Its still not committed to carbon - analytics
>>>
>>>

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Niranda Perera]

thanks Maheshika

On Thu, May 7, 2015 at 12:01 PM, Maheshika Goonetilleke 
wrote:

> Hi Kasun
>
> Both were deployed successfully.
>
> On Tue, May 5, 2015 at 6:54 PM, KasunG Gajasinghe  wrote:
>
>> Hi Niranda,
>>
>> Released the following orbit bundles. (finally! ;) )
>>
>> spark-core_2.10
>>  spark-sql_2.10
>>
>> @Maheshika, can you release these two orbit bundles. Please make sure to
>> use JDK 7 for  building.
>>
>>
>>
>> On Tue, May 5, 2015 at 12:46 PM, Niranda Perera  wrote:
>>
>>> Hi Kasun,
>>>
>>> Could you please check this bundle again. I fix the issue, and it did
>>> not affect the orbit bundle.
>>>
>>> rgds
>>>
>>> On Wed, Apr 29, 2015 at 5:00 PM, KasunG Gajasinghe 
>>> wrote:
>>>
 Hi Niranda,

 I believe the point Supun making is if there are two versions of spark
 1.3.0 has made there way into a pack, then only one version will be picked
 up. This is an unlikely scenario. But as a best practice, it'll be better
 to export the exact version from now on.

 On Wed, Apr 29, 2015 at 10:45 AM, Niranda Perera 
 wrote:

> Hi Supun,
>
> let me understand the scenario here.
>
> say there are 2 OSGI bundle in the environment spark v 1.3.0 and spark
> v 1.2.1 and we have a component org.wso2.analytics.spark.core which 
> imports
> org.apache.spark version [1.2.1, 1.4.0).
> then AFAIK in the OSGI environment, org.wso2.analytics.spark.core gets
> wired to the latest version in the runtime.
> @carbon team pls correct me if I'm wrong
>
> but I do not think it has anything to do with the  tag
> in the orbit bundle.
>
> rgds
>
> On Wed, Apr 29, 2015 at 10:22 AM, Supun Sethunga 
> wrote:
>
>> Hi Niranda,
>>
>> are you referring to this?
>>> 
>>>
>>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>>> 
>>
>>
>> Yes exactly. My concern was, what if multiple versions of the same
>> package were in the same osgi environment..  I know its very highly
>> unlikely, but IF such a case happens, then I think spark (or any bundle)
>> will pick up only one of the versions.
>>
>> Thanks,
>> Supun
>>
>> On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera 
>> wrote:
>>
>>> Hi Supun,
>>>
>>> are you referring to this?
>>> 
>>>
>>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>>> 
>>>
>>> well, AFAIK what export-package does is, it exposes the
>>> org.apache.spark.* classes in the OSGI environment. since we are not 
>>> doing
>>> any patching for the original classes, I dont think we have to change 
>>> the
>>> version to 1.3.0.wso2v1
>>>
>>> @sameera, pls correct me if I'm wrong.
>>>
>>> rgds
>>>
>>> On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga 
>>> wrote:
>>>
 Hi Sameera/Niranda,

 With parallel to this, Im in the process of migrating the spark
 Ml-Lib and spark streaming versions for product ML. Just wanted to 
 clear
 myself, shouldn't the export-package-version of all spark packages be
 1.3.0.wso2v1, rather than 1.3.0?

 Thanks,
 Supun

 On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera 
 wrote:

> oh. are you referring to the
> patch.jar,.
> line?
> I did not include it in the orbit bundle.
>
> but I checked the bundles in a fresh carbon server and it seems
> like the patch gets attached successfully.
> ​
>  Screenshot from 2015-04-17 16:20:15.png
> 
> ​
> I checked it with BAM pack also.
>
>  tag, is it mandatory to be in the for the orbit
> bundle, for the patch to get attached?
>
> the patch pom is as follows
>
> https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml
>
>
>
>
>
> On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando 
> wrote:
>
>> Niranda, yeah, we would have to put that part to be able to later
>> patch it. A sample can be found here [1].
>>
>> [1]
>> https://github.com/wso2/orbit/blob/master/tomcat/7.0.59.wso2v2/pom.xml
>>
>> Cheers,
>> Anjana.
>>
>> On Thu, Apr 16, 2015 at 3:00 PM, Sameera Jayasoma <
>> same...@wso2.com> wrote:
>>
>>> I meant to say, do we need to add the patch.jar line to the
>>> spark bundle as we've done in Tomcat bundle.
>>>
>>> Thanks,
>>> Sameera.
>>>
>>> On Thu, Apr 16, 2015 at 12

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Supun Sethunga]

Hi Kasun/Sameera

Can you please review and merge the PR [1]. This upgrades the spark-mllib
and spark-streaming versions to 1.3.0 (for ML), with parallel to the
spark-core version upgrade in BAM.

[1] https://github.com/wso2/orbit/pull/87

Thanks,
Supun

On Thu, May 7, 2015 at 12:02 PM, Niranda Perera  wrote:

> thanks Maheshika
>
> On Thu, May 7, 2015 at 12:01 PM, Maheshika Goonetilleke <
> mahesh...@wso2.com> wrote:
>
>> Hi Kasun
>>
>> Both were deployed successfully.
>>
>> On Tue, May 5, 2015 at 6:54 PM, KasunG Gajasinghe 
>> wrote:
>>
>>> Hi Niranda,
>>>
>>> Released the following orbit bundles. (finally! ;) )
>>>
>>> spark-core_2.10
>>>  spark-sql_2.10
>>>
>>> @Maheshika, can you release these two orbit bundles. Please make sure to
>>> use JDK 7 for  building.
>>>
>>>
>>>
>>> On Tue, May 5, 2015 at 12:46 PM, Niranda Perera 
>>> wrote:
>>>
 Hi Kasun,

 Could you please check this bundle again. I fix the issue, and it did
 not affect the orbit bundle.

 rgds

 On Wed, Apr 29, 2015 at 5:00 PM, KasunG Gajasinghe 
 wrote:

> Hi Niranda,
>
> I believe the point Supun making is if there are two versions of spark
> 1.3.0 has made there way into a pack, then only one version will be picked
> up. This is an unlikely scenario. But as a best practice, it'll be better
> to export the exact version from now on.
>
> On Wed, Apr 29, 2015 at 10:45 AM, Niranda Perera 
> wrote:
>
>> Hi Supun,
>>
>> let me understand the scenario here.
>>
>> say there are 2 OSGI bundle in the environment spark v 1.3.0 and
>> spark v 1.2.1 and we have a component org.wso2.analytics.spark.core which
>> imports org.apache.spark version [1.2.1, 1.4.0).
>> then AFAIK in the OSGI environment, org.wso2.analytics.spark.core
>> gets wired to the latest version in the runtime.
>> @carbon team pls correct me if I'm wrong
>>
>> but I do not think it has anything to do with the 
>> tag in the orbit bundle.
>>
>> rgds
>>
>> On Wed, Apr 29, 2015 at 10:22 AM, Supun Sethunga 
>> wrote:
>>
>>> Hi Niranda,
>>>
>>> are you referring to this?
 

 org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
 
>>>
>>>
>>> Yes exactly. My concern was, what if multiple versions of the same
>>> package were in the same osgi environment..  I know its very highly
>>> unlikely, but IF such a case happens, then I think spark (or any bundle)
>>> will pick up only one of the versions.
>>>
>>> Thanks,
>>> Supun
>>>
>>> On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera 
>>> wrote:
>>>
 Hi Supun,

 are you referring to this?
 

 org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
 

 well, AFAIK what export-package does is, it exposes the
 org.apache.spark.* classes in the OSGI environment. since we are not 
 doing
 any patching for the original classes, I dont think we have to change 
 the
 version to 1.3.0.wso2v1

 @sameera, pls correct me if I'm wrong.

 rgds

 On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga 
 wrote:

> Hi Sameera/Niranda,
>
> With parallel to this, Im in the process of migrating the spark
> Ml-Lib and spark streaming versions for product ML. Just wanted to 
> clear
> myself, shouldn't the export-package-version of all spark packages be
> 1.3.0.wso2v1, rather than 1.3.0?
>
> Thanks,
> Supun
>
> On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera 
> wrote:
>
>> oh. are you referring to the
>> patch.jar,.
>> line?
>> I did not include it in the orbit bundle.
>>
>> but I checked the bundles in a fresh carbon server and it seems
>> like the patch gets attached successfully.
>> ​
>>  Screenshot from 2015-04-17 16:20:15.png
>> 
>> ​
>> I checked it with BAM pack also.
>>
>>  tag, is it mandatory to be in the for the
>> orbit bundle, for the patch to get attached?
>>
>> the patch pom is as follows
>>
>> https://github.com/nirandaperera/carbon-analytics/blob/clustering%2B130%2BMT/components/analytics/analytics-processors/org.wso2.carbon.analytics.spark.patch/pom.xml
>>
>>
>>
>>
>>
>> On Thu, Apr 16, 2015 at 3:05 PM, Anjana Fernando > > wrote:
>>
>>> Niranda, yeah, we would have to put that part to be able to
>>> later patch it. A sample can be found here [1].
>>>
>>> [

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Jayanga Dissanayake]

Hi SupunS,

We reviewed the PR and found some issues in it.
1. all s are not in the correct format
2. in import package section you have used "*;resolution:=optional" which
is not recommended.
3. Export-Package section of breeze_2.10, it has some conflicting package
name entries

Please correct them and validate the pom file against the guidelines given
in [1] and resend a pull request.

[1]
https://docs.google.com/a/wso2.com/document/d/1I3nWPnG6139YobZzQWPFOUxYEmHxqf9ieWykmQupPtc/edit?usp=sharing

Thanks,
Jayanga.

*Jayanga Dissanayake*
Senior Software Engineer
WSO2 Inc. - http://wso2.com/
lean . enterprise . middleware
email: jaya...@wso2.com
mobile: +94772207259

On Thu, May 7, 2015 at 4:41 PM, Supun Sethunga  wrote:

> Hi Kasun/Sameera
>
> Can you please review and merge the PR [1]. This upgrades the spark-mllib
> and spark-streaming versions to 1.3.0 (for ML), with parallel to the
> spark-core version upgrade in BAM.
>
> [1] https://github.com/wso2/orbit/pull/87
>
> Thanks,
> Supun
>
> On Thu, May 7, 2015 at 12:02 PM, Niranda Perera  wrote:
>
>> thanks Maheshika
>>
>> On Thu, May 7, 2015 at 12:01 PM, Maheshika Goonetilleke <
>> mahesh...@wso2.com> wrote:
>>
>>> Hi Kasun
>>>
>>> Both were deployed successfully.
>>>
>>> On Tue, May 5, 2015 at 6:54 PM, KasunG Gajasinghe 
>>> wrote:
>>>
 Hi Niranda,

 Released the following orbit bundles. (finally! ;) )

 spark-core_2.10
  spark-sql_2.10

 @Maheshika, can you release these two orbit bundles. Please make sure
 to use JDK 7 for  building.



 On Tue, May 5, 2015 at 12:46 PM, Niranda Perera 
 wrote:

> Hi Kasun,
>
> Could you please check this bundle again. I fix the issue, and it did
> not affect the orbit bundle.
>
> rgds
>
> On Wed, Apr 29, 2015 at 5:00 PM, KasunG Gajasinghe 
> wrote:
>
>> Hi Niranda,
>>
>> I believe the point Supun making is if there are two versions of
>> spark 1.3.0 has made there way into a pack, then only one version will be
>> picked up. This is an unlikely scenario. But as a best practice, it'll be
>> better to export the exact version from now on.
>>
>> On Wed, Apr 29, 2015 at 10:45 AM, Niranda Perera 
>> wrote:
>>
>>> Hi Supun,
>>>
>>> let me understand the scenario here.
>>>
>>> say there are 2 OSGI bundle in the environment spark v 1.3.0 and
>>> spark v 1.2.1 and we have a component org.wso2.analytics.spark.core 
>>> which
>>> imports org.apache.spark version [1.2.1, 1.4.0).
>>> then AFAIK in the OSGI environment, org.wso2.analytics.spark.core
>>> gets wired to the latest version in the runtime.
>>> @carbon team pls correct me if I'm wrong
>>>
>>> but I do not think it has anything to do with the 
>>> tag in the orbit bundle.
>>>
>>> rgds
>>>
>>> On Wed, Apr 29, 2015 at 10:22 AM, Supun Sethunga 
>>> wrote:
>>>
 Hi Niranda,

 are you referring to this?
> 
>
> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
> 


 Yes exactly. My concern was, what if multiple versions of the same
 package were in the same osgi environment..  I know its very highly
 unlikely, but IF such a case happens, then I think spark (or any 
 bundle)
 will pick up only one of the versions.

 Thanks,
 Supun

 On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera 
 wrote:

> Hi Supun,
>
> are you referring to this?
> 
>
> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
> 
>
> well, AFAIK what export-package does is, it exposes the
> org.apache.spark.* classes in the OSGI environment. since we are not 
> doing
> any patching for the original classes, I dont think we have to change 
> the
> version to 1.3.0.wso2v1
>
> @sameera, pls correct me if I'm wrong.
>
> rgds
>
> On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga 
> wrote:
>
>> Hi Sameera/Niranda,
>>
>> With parallel to this, Im in the process of migrating the spark
>> Ml-Lib and spark streaming versions for product ML. Just wanted to 
>> clear
>> myself, shouldn't the export-package-version of all spark packages be
>> 1.3.0.wso2v1, rather than 1.3.0?
>>
>> Thanks,
>> Supun
>>
>> On Fri, Apr 17, 2015 at 4:39 PM, Niranda Perera > > wrote:
>>
>>> oh. are you referring to the
>>> patch.jar,.
>>> line?
>>> I did not include it in the orbit bundle.
>>>
>>> but I checked the bundles in a fresh carbon server and it seems
>>> like the patch gets attached

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Supun Sethunga]

Hi Jayanga,

Fixed (1) and (2). As per the offline discussion, (3) was concluded to be
OK, so left unchanged.

Can you please review and merge the resent PR [a].

[a] https://github.com/wso2/orbit/pull/87

Thanks,
Supun

On Thu, May 7, 2015 at 5:09 PM, Jayanga Dissanayake 
wrote:

> Hi SupunS,
>
> We reviewed the PR and found some issues in it.
> 1. all s are not in the correct format
> 2. in import package section you have used "*;resolution:=optional" which
> is not recommended.
> 3. Export-Package section of breeze_2.10, it has some conflicting package
> name entries
>
> Please correct them and validate the pom file against the guidelines given
> in [1] and resend a pull request.
>
> [1]
> https://docs.google.com/a/wso2.com/document/d/1I3nWPnG6139YobZzQWPFOUxYEmHxqf9ieWykmQupPtc/edit?usp=sharing
>
> Thanks,
> Jayanga.
>
> *Jayanga Dissanayake*
> Senior Software Engineer
> WSO2 Inc. - http://wso2.com/
> lean . enterprise . middleware
> email: jaya...@wso2.com
> mobile: +94772207259
>
> On Thu, May 7, 2015 at 4:41 PM, Supun Sethunga  wrote:
>
>> Hi Kasun/Sameera
>>
>> Can you please review and merge the PR [1]. This upgrades the spark-mllib
>> and spark-streaming versions to 1.3.0 (for ML), with parallel to the
>> spark-core version upgrade in BAM.
>>
>> [1] https://github.com/wso2/orbit/pull/87
>>
>> Thanks,
>> Supun
>>
>> On Thu, May 7, 2015 at 12:02 PM, Niranda Perera  wrote:
>>
>>> thanks Maheshika
>>>
>>> On Thu, May 7, 2015 at 12:01 PM, Maheshika Goonetilleke <
>>> mahesh...@wso2.com> wrote:
>>>
 Hi Kasun

 Both were deployed successfully.

 On Tue, May 5, 2015 at 6:54 PM, KasunG Gajasinghe 
 wrote:

> Hi Niranda,
>
> Released the following orbit bundles. (finally! ;) )
>
> spark-core_2.10
>  spark-sql_2.10
>
> @Maheshika, can you release these two orbit bundles. Please make sure
> to use JDK 7 for  building.
>
>
>
> On Tue, May 5, 2015 at 12:46 PM, Niranda Perera 
> wrote:
>
>> Hi Kasun,
>>
>> Could you please check this bundle again. I fix the issue, and it did
>> not affect the orbit bundle.
>>
>> rgds
>>
>> On Wed, Apr 29, 2015 at 5:00 PM, KasunG Gajasinghe 
>> wrote:
>>
>>> Hi Niranda,
>>>
>>> I believe the point Supun making is if there are two versions of
>>> spark 1.3.0 has made there way into a pack, then only one version will 
>>> be
>>> picked up. This is an unlikely scenario. But as a best practice, it'll 
>>> be
>>> better to export the exact version from now on.
>>>
>>> On Wed, Apr 29, 2015 at 10:45 AM, Niranda Perera 
>>> wrote:
>>>
 Hi Supun,

 let me understand the scenario here.

 say there are 2 OSGI bundle in the environment spark v 1.3.0 and
 spark v 1.2.1 and we have a component org.wso2.analytics.spark.core 
 which
 imports org.apache.spark version [1.2.1, 1.4.0).
 then AFAIK in the OSGI environment, org.wso2.analytics.spark.core
 gets wired to the latest version in the runtime.
 @carbon team pls correct me if I'm wrong

 but I do not think it has anything to do with the 
 tag in the orbit bundle.

 rgds

 On Wed, Apr 29, 2015 at 10:22 AM, Supun Sethunga 
 wrote:

> Hi Niranda,
>
> are you referring to this?
>> 
>>
>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>> 
>
>
> Yes exactly. My concern was, what if multiple versions of the same
> package were in the same osgi environment..  I know its very highly
> unlikely, but IF such a case happens, then I think spark (or any 
> bundle)
> will pick up only one of the versions.
>
> Thanks,
> Supun
>
> On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera  > wrote:
>
>> Hi Supun,
>>
>> are you referring to this?
>> 
>>
>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>> 
>>
>> well, AFAIK what export-package does is, it exposes the
>> org.apache.spark.* classes in the OSGI environment. since we are not 
>> doing
>> any patching for the original classes, I dont think we have to 
>> change the
>> version to 1.3.0.wso2v1
>>
>> @sameera, pls correct me if I'm wrong.
>>
>> rgds
>>
>> On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga 
>> wrote:
>>
>>> Hi Sameera/Niranda,
>>>
>>> With parallel to this, Im in the process of migrating the spark
>>> Ml-Lib and spark streaming versions for product ML. Just wanted to 
>>> clear
>>> myself, shouldn't the export-package-version of al

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Nirmal Fernando]

Can we get these PRs reviewed please?

On Thu, May 7, 2015 at 10:13 PM, Supun Sethunga  wrote:

> Hi Jayanga,
>
> Fixed (1) and (2). As per the offline discussion, (3) was concluded to be
> OK, so left unchanged.
>
> Can you please review and merge the resent PR [a].
>
> [a] https://github.com/wso2/orbit/pull/87
>
> Thanks,
> Supun
>
> On Thu, May 7, 2015 at 5:09 PM, Jayanga Dissanayake 
> wrote:
>
>> Hi SupunS,
>>
>> We reviewed the PR and found some issues in it.
>> 1. all s are not in the correct format
>> 2. in import package section you have used "*;resolution:=optional" which
>> is not recommended.
>> 3. Export-Package section of breeze_2.10, it has some conflicting package
>> name entries
>>
>> Please correct them and validate the pom file against the guidelines
>> given in [1] and resend a pull request.
>>
>> [1]
>> https://docs.google.com/a/wso2.com/document/d/1I3nWPnG6139YobZzQWPFOUxYEmHxqf9ieWykmQupPtc/edit?usp=sharing
>>
>> Thanks,
>> Jayanga.
>>
>> *Jayanga Dissanayake*
>> Senior Software Engineer
>> WSO2 Inc. - http://wso2.com/
>> lean . enterprise . middleware
>> email: jaya...@wso2.com
>> mobile: +94772207259
>>
>> On Thu, May 7, 2015 at 4:41 PM, Supun Sethunga  wrote:
>>
>>> Hi Kasun/Sameera
>>>
>>> Can you please review and merge the PR [1]. This upgrades the
>>> spark-mllib and spark-streaming versions to 1.3.0 (for ML), with parallel
>>> to the spark-core version upgrade in BAM.
>>>
>>> [1] https://github.com/wso2/orbit/pull/87
>>>
>>> Thanks,
>>> Supun
>>>
>>> On Thu, May 7, 2015 at 12:02 PM, Niranda Perera 
>>> wrote:
>>>
 thanks Maheshika

 On Thu, May 7, 2015 at 12:01 PM, Maheshika Goonetilleke <
 mahesh...@wso2.com> wrote:

> Hi Kasun
>
> Both were deployed successfully.
>
> On Tue, May 5, 2015 at 6:54 PM, KasunG Gajasinghe 
> wrote:
>
>> Hi Niranda,
>>
>> Released the following orbit bundles. (finally! ;) )
>>
>> spark-core_2.10
>>  spark-sql_2.10
>>
>> @Maheshika, can you release these two orbit bundles. Please make sure
>> to use JDK 7 for  building.
>>
>>
>>
>> On Tue, May 5, 2015 at 12:46 PM, Niranda Perera 
>> wrote:
>>
>>> Hi Kasun,
>>>
>>> Could you please check this bundle again. I fix the issue, and it
>>> did not affect the orbit bundle.
>>>
>>> rgds
>>>
>>> On Wed, Apr 29, 2015 at 5:00 PM, KasunG Gajasinghe 
>>> wrote:
>>>
 Hi Niranda,

 I believe the point Supun making is if there are two versions of
 spark 1.3.0 has made there way into a pack, then only one version will 
 be
 picked up. This is an unlikely scenario. But as a best practice, it'll 
 be
 better to export the exact version from now on.

 On Wed, Apr 29, 2015 at 10:45 AM, Niranda Perera 
 wrote:

> Hi Supun,
>
> let me understand the scenario here.
>
> say there are 2 OSGI bundle in the environment spark v 1.3.0 and
> spark v 1.2.1 and we have a component org.wso2.analytics.spark.core 
> which
> imports org.apache.spark version [1.2.1, 1.4.0).
> then AFAIK in the OSGI environment, org.wso2.analytics.spark.core
> gets wired to the latest version in the runtime.
> @carbon team pls correct me if I'm wrong
>
> but I do not think it has anything to do with the 
> tag in the orbit bundle.
>
> rgds
>
> On Wed, Apr 29, 2015 at 10:22 AM, Supun Sethunga 
> wrote:
>
>> Hi Niranda,
>>
>> are you referring to this?
>>> 
>>>
>>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>>> 
>>
>>
>> Yes exactly. My concern was, what if multiple versions of the
>> same package were in the same osgi environment..  I know its very 
>> highly
>> unlikely, but IF such a case happens, then I think spark (or any 
>> bundle)
>> will pick up only one of the versions.
>>
>> Thanks,
>> Supun
>>
>> On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera <
>> nira...@wso2.com> wrote:
>>
>>> Hi Supun,
>>>
>>> are you referring to this?
>>> 
>>>
>>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>>> 
>>>
>>> well, AFAIK what export-package does is, it exposes the
>>> org.apache.spark.* classes in the OSGI environment. since we are 
>>> not doing
>>> any patching for the original classes, I dont think we have to 
>>> change the
>>> version to 1.3.0.wso2v1
>>>
>>> @sameera, pls correct me if I'm wrong.
>>>
>>> rgds
>>>
>>> On Wed, Apr 22, 2015 at 9:06 AM, Supun Sethunga >

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Jayanga Dissanayake]

Hi Kasung,
Reviewed the poms in given PR.

Please merge.

Thanks,
Jayanga.

*Jayanga Dissanayake*
Senior Software Engineer
WSO2 Inc. - http://wso2.com/
lean . enterprise . middleware
email: jaya...@wso2.com
mobile: +94772207259

On Fri, May 8, 2015 at 2:36 PM, Nirmal Fernando  wrote:

> Can we get these PRs reviewed please?
>
> On Thu, May 7, 2015 at 10:13 PM, Supun Sethunga  wrote:
>
>> Hi Jayanga,
>>
>> Fixed (1) and (2). As per the offline discussion, (3) was concluded to be
>> OK, so left unchanged.
>>
>> Can you please review and merge the resent PR [a].
>>
>> [a] https://github.com/wso2/orbit/pull/87
>>
>> Thanks,
>> Supun
>>
>> On Thu, May 7, 2015 at 5:09 PM, Jayanga Dissanayake 
>> wrote:
>>
>>> Hi SupunS,
>>>
>>> We reviewed the PR and found some issues in it.
>>> 1. all s are not in the correct format
>>> 2. in import package section you have used "*;resolution:=optional"
>>> which is not recommended.
>>> 3. Export-Package section of breeze_2.10, it has some conflicting
>>> package name entries
>>>
>>> Please correct them and validate the pom file against the guidelines
>>> given in [1] and resend a pull request.
>>>
>>> [1]
>>> https://docs.google.com/a/wso2.com/document/d/1I3nWPnG6139YobZzQWPFOUxYEmHxqf9ieWykmQupPtc/edit?usp=sharing
>>>
>>> Thanks,
>>> Jayanga.
>>>
>>> *Jayanga Dissanayake*
>>> Senior Software Engineer
>>> WSO2 Inc. - http://wso2.com/
>>> lean . enterprise . middleware
>>> email: jaya...@wso2.com
>>> mobile: +94772207259
>>>
>>> On Thu, May 7, 2015 at 4:41 PM, Supun Sethunga  wrote:
>>>
 Hi Kasun/Sameera

 Can you please review and merge the PR [1]. This upgrades the
 spark-mllib and spark-streaming versions to 1.3.0 (for ML), with parallel
 to the spark-core version upgrade in BAM.

 [1] https://github.com/wso2/orbit/pull/87

 Thanks,
 Supun

 On Thu, May 7, 2015 at 12:02 PM, Niranda Perera 
 wrote:

> thanks Maheshika
>
> On Thu, May 7, 2015 at 12:01 PM, Maheshika Goonetilleke <
> mahesh...@wso2.com> wrote:
>
>> Hi Kasun
>>
>> Both were deployed successfully.
>>
>> On Tue, May 5, 2015 at 6:54 PM, KasunG Gajasinghe 
>> wrote:
>>
>>> Hi Niranda,
>>>
>>> Released the following orbit bundles. (finally! ;) )
>>>
>>> spark-core_2.10
>>>  spark-sql_2.10
>>>
>>> @Maheshika, can you release these two orbit bundles. Please make
>>> sure to use JDK 7 for  building.
>>>
>>>
>>>
>>> On Tue, May 5, 2015 at 12:46 PM, Niranda Perera 
>>> wrote:
>>>
 Hi Kasun,

 Could you please check this bundle again. I fix the issue, and it
 did not affect the orbit bundle.

 rgds

 On Wed, Apr 29, 2015 at 5:00 PM, KasunG Gajasinghe >>> > wrote:

> Hi Niranda,
>
> I believe the point Supun making is if there are two versions of
> spark 1.3.0 has made there way into a pack, then only one version 
> will be
> picked up. This is an unlikely scenario. But as a best practice, 
> it'll be
> better to export the exact version from now on.
>
> On Wed, Apr 29, 2015 at 10:45 AM, Niranda Perera  > wrote:
>
>> Hi Supun,
>>
>> let me understand the scenario here.
>>
>> say there are 2 OSGI bundle in the environment spark v 1.3.0 and
>> spark v 1.2.1 and we have a component org.wso2.analytics.spark.core 
>> which
>> imports org.apache.spark version [1.2.1, 1.4.0).
>> then AFAIK in the OSGI environment, org.wso2.analytics.spark.core
>> gets wired to the latest version in the runtime.
>> @carbon team pls correct me if I'm wrong
>>
>> but I do not think it has anything to do with the
>>  tag in the orbit bundle.
>>
>> rgds
>>
>> On Wed, Apr 29, 2015 at 10:22 AM, Supun Sethunga > > wrote:
>>
>>> Hi Niranda,
>>>
>>> are you referring to this?
 

 org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
 
>>>
>>>
>>> Yes exactly. My concern was, what if multiple versions of the
>>> same package were in the same osgi environment..  I know its very 
>>> highly
>>> unlikely, but IF such a case happens, then I think spark (or any 
>>> bundle)
>>> will pick up only one of the versions.
>>>
>>> Thanks,
>>> Supun
>>>
>>> On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera <
>>> nira...@wso2.com> wrote:
>>>
 Hi Supun,

 are you referring to this?
 

 org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
 

 well, AFAIK 

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Kasun Gajasinghe]

Pr merged. @maheshika, over to you. 

> On May 8, 2015, at 2:48 PM, Jayanga Dissanayake  wrote:
> 
> Hi Kasung,
> Reviewed the poms in given PR.
> 
> Please merge.
> 
> Thanks,
> Jayanga.
> 
> Jayanga Dissanayake
> Senior Software Engineer
> WSO2 Inc. - http://wso2.com/
> lean . enterprise . middleware
> email: jaya...@wso2.com
> mobile: +94772207259
> 
>> On Fri, May 8, 2015 at 2:36 PM, Nirmal Fernando  wrote:
>> Can we get these PRs reviewed please? 
>> 
>>> On Thu, May 7, 2015 at 10:13 PM, Supun Sethunga  wrote:
>>> Hi Jayanga,
>>> 
>>> Fixed (1) and (2). As per the offline discussion, (3) was concluded to be 
>>> OK, so left unchanged.
>>> 
>>> Can you please review and merge the resent PR [a].
>>> 
>>> [a] https://github.com/wso2/orbit/pull/87
>>> 
>>> Thanks,
>>> Supun
>>> 
 On Thu, May 7, 2015 at 5:09 PM, Jayanga Dissanayake  
 wrote:
 Hi SupunS,
 
 We reviewed the PR and found some issues in it.
 1. all s are not in the correct format
 2. in import package section you have used "*;resolution:=optional" which 
 is not recommended.
 3. Export-Package section of breeze_2.10, it has some conflicting package 
 name entries
 
 Please correct them and validate the pom file against the guidelines given 
 in [1] and resend a pull request. 
 
 [1] 
 https://docs.google.com/a/wso2.com/document/d/1I3nWPnG6139YobZzQWPFOUxYEmHxqf9ieWykmQupPtc/edit?usp=sharing
 
 Thanks,
 Jayanga.
 
 Jayanga Dissanayake
 Senior Software Engineer
 WSO2 Inc. - http://wso2.com/
 lean . enterprise . middleware
 email: jaya...@wso2.com
 mobile: +94772207259
 
> On Thu, May 7, 2015 at 4:41 PM, Supun Sethunga  wrote:
> Hi Kasun/Sameera
> 
> Can you please review and merge the PR [1]. This upgrades the spark-mllib 
> and spark-streaming versions to 1.3.0 (for ML), with parallel to the 
> spark-core version upgrade in BAM.
> 
> [1] https://github.com/wso2/orbit/pull/87
> 
> Thanks,
> Supun
> 
>> On Thu, May 7, 2015 at 12:02 PM, Niranda Perera  wrote:
>> thanks Maheshika
>> 
>>> On Thu, May 7, 2015 at 12:01 PM, Maheshika Goonetilleke 
>>>  wrote:
>>> Hi Kasun
>>> 
>>> Both were deployed successfully.
>>> 
 On Tue, May 5, 2015 at 6:54 PM, KasunG Gajasinghe  
 wrote:
 Hi Niranda,
 
 Released the following orbit bundles. (finally! ;) )
 
 spark-core_2.10
 spark-sql_2.10
 
 @Maheshika, can you release these two orbit bundles. Please make sure 
 to use JDK 7 for  building.
 
 
 
> On Tue, May 5, 2015 at 12:46 PM, Niranda Perera  
> wrote:
> Hi Kasun, 
> 
> Could you please check this bundle again. I fix the issue, and it did 
> not affect the orbit bundle. 
> 
> rgds 
> 
>> On Wed, Apr 29, 2015 at 5:00 PM, KasunG Gajasinghe  
>> wrote:
>> Hi Niranda,
>> 
>> I believe the point Supun making is if there are two versions of 
>> spark 1.3.0 has made there way into a pack, then only one version 
>> will be picked up. This is an unlikely scenario. But as a best 
>> practice, it'll be better to export the exact version from now on.
>> 
>>> On Wed, Apr 29, 2015 at 10:45 AM, Niranda Perera  
>>> wrote:
>>> Hi Supun, 
>>> 
>>> let me understand the scenario here. 
>>> 
>>> say there are 2 OSGI bundle in the environment spark v 1.3.0 and 
>>> spark v 1.2.1 and we have a component org.wso2.analytics.spark.core 
>>> which imports org.apache.spark version [1.2.1, 1.4.0).
>>> then AFAIK in the OSGI environment, org.wso2.analytics.spark.core 
>>> gets wired to the latest version in the runtime. 
>>> @carbon team pls correct me if I'm wrong
>>> 
>>> but I do not think it has anything to do with the  
>>> tag in the orbit bundle. 
>>> 
>>> rgds
>>> 
 On Wed, Apr 29, 2015 at 10:22 AM, Supun Sethunga  
 wrote:
 Hi Niranda,
 
> are you referring to this?
> 
> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
> 
 
 Yes exactly. My concern was, what if multiple versions of the same 
 package were in the same osgi environment..  I know its very 
 highly unlikely, but IF such a case happens, then I think spark 
 (or any bundle) will pick up only one of the versions.
 
 Thanks,
 Supun
 
> On Mon, Apr 27, 2015 at 10:55 AM, Niranda Perera 
>  wrote:
> Hi Supun, 
> 
> are you referring to this?
> 

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Nirmal Fernando]

Thanks Guys!

On Fri, May 8, 2015 at 7:42 PM, Kasun Gajasinghe  wrote:

> Pr merged. @maheshika, over to you.
>
> On May 8, 2015, at 2:48 PM, Jayanga Dissanayake  wrote:
>
> Hi Kasung,
> Reviewed the poms in given PR.
>
> Please merge.
>
> Thanks,
> Jayanga.
>
> *Jayanga Dissanayake*
> Senior Software Engineer
> WSO2 Inc. - http://wso2.com/
> lean . enterprise . middleware
> email: jaya...@wso2.com
> mobile: +94772207259
>
> On Fri, May 8, 2015 at 2:36 PM, Nirmal Fernando  wrote:
>
>> Can we get these PRs reviewed please?
>>
>> On Thu, May 7, 2015 at 10:13 PM, Supun Sethunga  wrote:
>>
>>> Hi Jayanga,
>>>
>>> Fixed (1) and (2). As per the offline discussion, (3) was concluded to
>>> be OK, so left unchanged.
>>>
>>> Can you please review and merge the resent PR [a].
>>>
>>> [a] https://github.com/wso2/orbit/pull/87
>>>
>>> Thanks,
>>> Supun
>>>
>>> On Thu, May 7, 2015 at 5:09 PM, Jayanga Dissanayake 
>>> wrote:
>>>
 Hi SupunS,

 We reviewed the PR and found some issues in it.
 1. all s are not in the correct format
 2. in import package section you have used "*;resolution:=optional"
 which is not recommended.
 3. Export-Package section of breeze_2.10, it has some conflicting
 package name entries

 Please correct them and validate the pom file against the guidelines
 given in [1] and resend a pull request.

 [1]
 https://docs.google.com/a/wso2.com/document/d/1I3nWPnG6139YobZzQWPFOUxYEmHxqf9ieWykmQupPtc/edit?usp=sharing

 Thanks,
 Jayanga.

 *Jayanga Dissanayake*
 Senior Software Engineer
 WSO2 Inc. - http://wso2.com/
 lean . enterprise . middleware
 email: jaya...@wso2.com
 mobile: +94772207259

 On Thu, May 7, 2015 at 4:41 PM, Supun Sethunga  wrote:

> Hi Kasun/Sameera
>
> Can you please review and merge the PR [1]. This upgrades the
> spark-mllib and spark-streaming versions to 1.3.0 (for ML), with parallel
> to the spark-core version upgrade in BAM.
>
> [1] https://github.com/wso2/orbit/pull/87
>
> Thanks,
> Supun
>
> On Thu, May 7, 2015 at 12:02 PM, Niranda Perera 
> wrote:
>
>> thanks Maheshika
>>
>> On Thu, May 7, 2015 at 12:01 PM, Maheshika Goonetilleke <
>> mahesh...@wso2.com> wrote:
>>
>>> Hi Kasun
>>>
>>> Both were deployed successfully.
>>>
>>> On Tue, May 5, 2015 at 6:54 PM, KasunG Gajasinghe 
>>> wrote:
>>>
 Hi Niranda,

 Released the following orbit bundles. (finally! ;) )

 spark-core_2.10
  spark-sql_2.10

 @Maheshika, can you release these two orbit bundles. Please make
 sure to use JDK 7 for  building.



 On Tue, May 5, 2015 at 12:46 PM, Niranda Perera 
 wrote:

> Hi Kasun,
>
> Could you please check this bundle again. I fix the issue, and it
> did not affect the orbit bundle.
>
> rgds
>
> On Wed, Apr 29, 2015 at 5:00 PM, KasunG Gajasinghe <
> kas...@wso2.com> wrote:
>
>> Hi Niranda,
>>
>> I believe the point Supun making is if there are two versions of
>> spark 1.3.0 has made there way into a pack, then only one version 
>> will be
>> picked up. This is an unlikely scenario. But as a best practice, 
>> it'll be
>> better to export the exact version from now on.
>>
>> On Wed, Apr 29, 2015 at 10:45 AM, Niranda Perera <
>> nira...@wso2.com> wrote:
>>
>>> Hi Supun,
>>>
>>> let me understand the scenario here.
>>>
>>> say there are 2 OSGI bundle in the environment spark v 1.3.0 and
>>> spark v 1.2.1 and we have a component org.wso2.analytics.spark.core 
>>> which
>>> imports org.apache.spark version [1.2.1, 1.4.0).
>>> then AFAIK in the OSGI environment,
>>> org.wso2.analytics.spark.core gets wired to the latest version in 
>>> the
>>> runtime.
>>> @carbon team pls correct me if I'm wrong
>>>
>>> but I do not think it has anything to do with the
>>>  tag in the orbit bundle.
>>>
>>> rgds
>>>
>>> On Wed, Apr 29, 2015 at 10:22 AM, Supun Sethunga <
>>> sup...@wso2.com> wrote:
>>>
 Hi Niranda,

 are you referring to this?
> 
>
> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
> 


 Yes exactly. My concern was, what if multiple versions of the
 same package were in the same osgi environment..  I know its very 
 highly
 unlikely, but IF such a case happens, then I think spark (or any 
 bundle)
 will pick up only one of the v

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Maheshika Goonetilleke]

Hi Nirmal

Deployed successfully.

On Sat, May 9, 2015 at 6:56 AM, Nirmal Fernando  wrote:

> Thanks Guys!
>
> On Fri, May 8, 2015 at 7:42 PM, Kasun Gajasinghe  wrote:
>
>> Pr merged. @maheshika, over to you.
>>
>> On May 8, 2015, at 2:48 PM, Jayanga Dissanayake  wrote:
>>
>> Hi Kasung,
>> Reviewed the poms in given PR.
>>
>> Please merge.
>>
>> Thanks,
>> Jayanga.
>>
>> *Jayanga Dissanayake*
>> Senior Software Engineer
>> WSO2 Inc. - http://wso2.com/
>> lean . enterprise . middleware
>> email: jaya...@wso2.com
>> mobile: +94772207259
>>
>> On Fri, May 8, 2015 at 2:36 PM, Nirmal Fernando  wrote:
>>
>>> Can we get these PRs reviewed please?
>>>
>>> On Thu, May 7, 2015 at 10:13 PM, Supun Sethunga  wrote:
>>>
 Hi Jayanga,

 Fixed (1) and (2). As per the offline discussion, (3) was concluded to
 be OK, so left unchanged.

 Can you please review and merge the resent PR [a].

 [a] https://github.com/wso2/orbit/pull/87

 Thanks,
 Supun

 On Thu, May 7, 2015 at 5:09 PM, Jayanga Dissanayake 
 wrote:

> Hi SupunS,
>
> We reviewed the PR and found some issues in it.
> 1. all s are not in the correct format
> 2. in import package section you have used "*;resolution:=optional"
> which is not recommended.
> 3. Export-Package section of breeze_2.10, it has some conflicting
> package name entries
>
> Please correct them and validate the pom file against the guidelines
> given in [1] and resend a pull request.
>
> [1]
> https://docs.google.com/a/wso2.com/document/d/1I3nWPnG6139YobZzQWPFOUxYEmHxqf9ieWykmQupPtc/edit?usp=sharing
>
> Thanks,
> Jayanga.
>
> *Jayanga Dissanayake*
> Senior Software Engineer
> WSO2 Inc. - http://wso2.com/
> lean . enterprise . middleware
> email: jaya...@wso2.com
> mobile: +94772207259
>
> On Thu, May 7, 2015 at 4:41 PM, Supun Sethunga 
> wrote:
>
>> Hi Kasun/Sameera
>>
>> Can you please review and merge the PR [1]. This upgrades the
>> spark-mllib and spark-streaming versions to 1.3.0 (for ML), with parallel
>> to the spark-core version upgrade in BAM.
>>
>> [1] https://github.com/wso2/orbit/pull/87
>>
>> Thanks,
>> Supun
>>
>> On Thu, May 7, 2015 at 12:02 PM, Niranda Perera 
>> wrote:
>>
>>> thanks Maheshika
>>>
>>> On Thu, May 7, 2015 at 12:01 PM, Maheshika Goonetilleke <
>>> mahesh...@wso2.com> wrote:
>>>
 Hi Kasun

 Both were deployed successfully.

 On Tue, May 5, 2015 at 6:54 PM, KasunG Gajasinghe 
 wrote:

> Hi Niranda,
>
> Released the following orbit bundles. (finally! ;) )
>
> spark-core_2.10
>  spark-sql_2.10
>
> @Maheshika, can you release these two orbit bundles. Please make
> sure to use JDK 7 for  building.
>
>
>
> On Tue, May 5, 2015 at 12:46 PM, Niranda Perera 
> wrote:
>
>> Hi Kasun,
>>
>> Could you please check this bundle again. I fix the issue, and it
>> did not affect the orbit bundle.
>>
>> rgds
>>
>> On Wed, Apr 29, 2015 at 5:00 PM, KasunG Gajasinghe <
>> kas...@wso2.com> wrote:
>>
>>> Hi Niranda,
>>>
>>> I believe the point Supun making is if there are two versions of
>>> spark 1.3.0 has made there way into a pack, then only one version 
>>> will be
>>> picked up. This is an unlikely scenario. But as a best practice, 
>>> it'll be
>>> better to export the exact version from now on.
>>>
>>> On Wed, Apr 29, 2015 at 10:45 AM, Niranda Perera <
>>> nira...@wso2.com> wrote:
>>>
 Hi Supun,

 let me understand the scenario here.

 say there are 2 OSGI bundle in the environment spark v 1.3.0
 and spark v 1.2.1 and we have a component 
 org.wso2.analytics.spark.core
 which imports org.apache.spark version [1.2.1, 1.4.0).
 then AFAIK in the OSGI environment,
 org.wso2.analytics.spark.core gets wired to the latest version in 
 the
 runtime.
 @carbon team pls correct me if I'm wrong

 but I do not think it has anything to do with the
  tag in the orbit bundle.

 rgds

 On Wed, Apr 29, 2015 at 10:22 AM, Supun Sethunga <
 sup...@wso2.com> wrote:

> Hi Niranda,
>
> are you referring to this?
>> 
>>
>> org.apache.spark.*;version="${spark.version}";-split-package:=merge-first
>> 
>
>
> Yes exactly. My concern was, what if mu

Re: [Dev] [Orbit] Please review the PR for Spark 1.3.0

[Nirmal Fernando]

Thanks!

On Sat, May 9, 2015 at 12:45 PM, Maheshika Goonetilleke 
wrote:

> Hi Nirmal
>
> Deployed successfully.
>
> On Sat, May 9, 2015 at 6:56 AM, Nirmal Fernando  wrote:
>
>> Thanks Guys!
>>
>> On Fri, May 8, 2015 at 7:42 PM, Kasun Gajasinghe  wrote:
>>
>>> Pr merged. @maheshika, over to you.
>>>
>>> On May 8, 2015, at 2:48 PM, Jayanga Dissanayake 
>>> wrote:
>>>
>>> Hi Kasung,
>>> Reviewed the poms in given PR.
>>>
>>> Please merge.
>>>
>>> Thanks,
>>> Jayanga.
>>>
>>> *Jayanga Dissanayake*
>>> Senior Software Engineer
>>> WSO2 Inc. - http://wso2.com/
>>> lean . enterprise . middleware
>>> email: jaya...@wso2.com
>>> mobile: +94772207259
>>>
>>> On Fri, May 8, 2015 at 2:36 PM, Nirmal Fernando  wrote:
>>>
 Can we get these PRs reviewed please?

 On Thu, May 7, 2015 at 10:13 PM, Supun Sethunga 
 wrote:

> Hi Jayanga,
>
> Fixed (1) and (2). As per the offline discussion, (3) was concluded to
> be OK, so left unchanged.
>
> Can you please review and merge the resent PR [a].
>
> [a] https://github.com/wso2/orbit/pull/87
>
> Thanks,
> Supun
>
> On Thu, May 7, 2015 at 5:09 PM, Jayanga Dissanayake 
> wrote:
>
>> Hi SupunS,
>>
>> We reviewed the PR and found some issues in it.
>> 1. all s are not in the correct format
>> 2. in import package section you have used "*;resolution:=optional"
>> which is not recommended.
>> 3. Export-Package section of breeze_2.10, it has some conflicting
>> package name entries
>>
>> Please correct them and validate the pom file against the guidelines
>> given in [1] and resend a pull request.
>>
>> [1]
>> https://docs.google.com/a/wso2.com/document/d/1I3nWPnG6139YobZzQWPFOUxYEmHxqf9ieWykmQupPtc/edit?usp=sharing
>>
>> Thanks,
>> Jayanga.
>>
>> *Jayanga Dissanayake*
>> Senior Software Engineer
>> WSO2 Inc. - http://wso2.com/
>> lean . enterprise . middleware
>> email: jaya...@wso2.com
>> mobile: +94772207259
>>
>> On Thu, May 7, 2015 at 4:41 PM, Supun Sethunga 
>> wrote:
>>
>>> Hi Kasun/Sameera
>>>
>>> Can you please review and merge the PR [1]. This upgrades the
>>> spark-mllib and spark-streaming versions to 1.3.0 (for ML), with 
>>> parallel
>>> to the spark-core version upgrade in BAM.
>>>
>>> [1] https://github.com/wso2/orbit/pull/87
>>>
>>> Thanks,
>>> Supun
>>>
>>> On Thu, May 7, 2015 at 12:02 PM, Niranda Perera 
>>> wrote:
>>>
 thanks Maheshika

 On Thu, May 7, 2015 at 12:01 PM, Maheshika Goonetilleke <
 mahesh...@wso2.com> wrote:

> Hi Kasun
>
> Both were deployed successfully.
>
> On Tue, May 5, 2015 at 6:54 PM, KasunG Gajasinghe  > wrote:
>
>> Hi Niranda,
>>
>> Released the following orbit bundles. (finally! ;) )
>>
>> spark-core_2.10
>>  spark-sql_2.10
>>
>> @Maheshika, can you release these two orbit bundles. Please make
>> sure to use JDK 7 for  building.
>>
>>
>>
>> On Tue, May 5, 2015 at 12:46 PM, Niranda Perera > > wrote:
>>
>>> Hi Kasun,
>>>
>>> Could you please check this bundle again. I fix the issue, and
>>> it did not affect the orbit bundle.
>>>
>>> rgds
>>>
>>> On Wed, Apr 29, 2015 at 5:00 PM, KasunG Gajasinghe <
>>> kas...@wso2.com> wrote:
>>>
 Hi Niranda,

 I believe the point Supun making is if there are two versions
 of spark 1.3.0 has made there way into a pack, then only one 
 version will
 be picked up. This is an unlikely scenario. But as a best 
 practice, it'll
 be better to export the exact version from now on.

 On Wed, Apr 29, 2015 at 10:45 AM, Niranda Perera <
 nira...@wso2.com> wrote:

> Hi Supun,
>
> let me understand the scenario here.
>
> say there are 2 OSGI bundle in the environment spark v 1.3.0
> and spark v 1.2.1 and we have a component 
> org.wso2.analytics.spark.core
> which imports org.apache.spark version [1.2.1, 1.4.0).
> then AFAIK in the OSGI environment,
> org.wso2.analytics.spark.core gets wired to the latest version in 
> the
> runtime.
> @carbon team pls correct me if I'm wrong
>
> but I do not think it has anything to do with the
>  tag in the orbit bundle.
>
> rgds
>
> On Wed, Apr 29, 2015 at 10:22 AM, Supun Sethunga <
> sup...@wso2.com> wrote:
>
>> Hi Niranda,
>