Re: [Dev] [UUF] UUF-Client renderFragment fails with warning "Content is empty."

2017-02-16 Thread Kasun Thennakoon 
Hi Chandana,

Thanks for the info, We will update the versions accordingly.

Thanks
~KasunTe

On Thu, Feb 16, 2017 at 6:11 PM, Chandana Napagoda 
wrote:

> HI Kasun/Roshan,
>
> This issue occurred since UUF M12 has not included some required fixes. So
> please use UUF M13 and uuf-common M5 version and fix which you have
> suggested is not required anymore.
>
> Regards,
> Chandana
>
> On Thu, Feb 16, 2017 at 4:05 PM, SajithAR Ariyarathna 
> wrote:
>
>> Hi Roshan,
>>
>> Thanks for the PR. I have put some comments, please have a look.
>>
>> Thanks.
>>
>> On Thu, Feb 16, 2017 at 3:01 PM, Roshan Wijesena  wrote:
>>
>>> It seems Kasun is right,
>>>
>>> the object "data" is by-default coming as html/text. so we don't need
>>> use it as 'data.html' .
>>>
>>> Since this is a blocker for APIM C5 - M1 release for now I have sent a
>>> pull request with a fix. Please review and merge.
>>>
>>> https://github.com/wso2/carbon-uuf-common/pull/41/files
>>>
>>>
>>> On Tue, Feb 14, 2017 at 10:42 AM, Kasun Thennakoon 
>>> wrote:
>>>
 Hi all,

 Experience the $subject when using UUF-Client for
 rendering hbs fragments.
 As I understand, the response of 
 *http://localhost:9090/publisher/fragments/{fragment-name}
  *contains
 an HTML string and in this line[1] it is looking for *.html* attribute
 in the response object when calling *pushContent* method. Which pass
 an *undefined *value.IMHO this is what cause to display no content in
 the target zone.


 [1]: https://github.com/wso2/carbon-uuf-common/blob/master/c
 omponents/org.wso2.carbon.uuf.common.foundation.ui/src/main/
 fragments/uuf-client/public/uuf-client/uuf-client.js#L226

 --
 *Kasun Thennakoon*
 Software Engineer
 WSO2, Inc.
 Mobile:+94 711661919

 ___
 Dev mailing list
 Dev@wso2.org
 http://wso2.org/cgi-bin/mailman/listinfo/dev


>>>
>>>
>>> --
>>> Roshan Wijesena.
>>> Senior Software Engineer-WSO2 Inc.
>>> Mobile: *+94719154640 <+94%2071%20915%204640>*
>>> Email: ros...@wso2.com
>>> *WSO2, Inc. :** wso2.com *
>>> lean.enterprise.middleware.
>>>
>>
>>
>>
>> --
>> Sajith Janaprasad Ariyarathna
>> Software Engineer; WSO2, Inc.;  http://wso2.com/
>> 
>>
>
>
>
> --
> *Chandana Napagoda*
> Associate Technical Lead
> WSO2 Inc. - http://wso2.org
>
> *Email  :  chand...@wso2.com **Mobile : +94718169299
> <+94%2071%20816%209299>*
>
> *Blog  :http://cnapagoda.blogspot.com 
> | http://chandana.napagoda.com *
>
> *Linkedin : http://www.linkedin.com/in/chandananapagoda
> *
>
>


-- 
*Kasun Thennakoon*
Software Engineer
WSO2, Inc.
Mobile:+94 711661919
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [UUF] UUF-Client renderFragment fails with warning "Content is empty."

2017-02-16 Thread Chandana Napagoda 
HI Kasun/Roshan,

This issue occurred since UUF M12 has not included some required fixes. So
please use UUF M13 and uuf-common M5 version and fix which you have
suggested is not required anymore.

Regards,
Chandana

On Thu, Feb 16, 2017 at 4:05 PM, SajithAR Ariyarathna 
wrote:

> Hi Roshan,
>
> Thanks for the PR. I have put some comments, please have a look.
>
> Thanks.
>
> On Thu, Feb 16, 2017 at 3:01 PM, Roshan Wijesena  wrote:
>
>> It seems Kasun is right,
>>
>> the object "data" is by-default coming as html/text. so we don't need use
>> it as 'data.html' .
>>
>> Since this is a blocker for APIM C5 - M1 release for now I have sent a
>> pull request with a fix. Please review and merge.
>>
>> https://github.com/wso2/carbon-uuf-common/pull/41/files
>>
>>
>> On Tue, Feb 14, 2017 at 10:42 AM, Kasun Thennakoon 
>> wrote:
>>
>>> Hi all,
>>>
>>> Experience the $subject when using UUF-Client for
>>> rendering hbs fragments.
>>> As I understand, the response of 
>>> *http://localhost:9090/publisher/fragments/{fragment-name}
>>>  *contains
>>> an HTML string and in this line[1] it is looking for *.html* attribute
>>> in the response object when calling *pushContent* method. Which pass an 
>>> *undefined
>>> *value.IMHO this is what cause to display no content in the target zone.
>>>
>>>
>>> [1]: https://github.com/wso2/carbon-uuf-common/blob/master/c
>>> omponents/org.wso2.carbon.uuf.common.foundation.ui/src/main/
>>> fragments/uuf-client/public/uuf-client/uuf-client.js#L226
>>>
>>> --
>>> *Kasun Thennakoon*
>>> Software Engineer
>>> WSO2, Inc.
>>> Mobile:+94 711661919
>>>
>>> ___
>>> Dev mailing list
>>> Dev@wso2.org
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>>
>> --
>> Roshan Wijesena.
>> Senior Software Engineer-WSO2 Inc.
>> Mobile: *+94719154640 <+94%2071%20915%204640>*
>> Email: ros...@wso2.com
>> *WSO2, Inc. :** wso2.com *
>> lean.enterprise.middleware.
>>
>
>
>
> --
> Sajith Janaprasad Ariyarathna
> Software Engineer; WSO2, Inc.;  http://wso2.com/
> 
>



-- 
*Chandana Napagoda*
Associate Technical Lead
WSO2 Inc. - http://wso2.org

*Email  :  chand...@wso2.com **Mobile : +94718169299*

*Blog  :http://cnapagoda.blogspot.com  |
http://chandana.napagoda.com *

*Linkedin : http://www.linkedin.com/in/chandananapagoda
*
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [UUF] UUF-Client renderFragment fails with warning "Content is empty."

2017-02-16 Thread SajithAR Ariyarathna 
Hi Roshan,

Thanks for the PR. I have put some comments, please have a look.

Thanks.

On Thu, Feb 16, 2017 at 3:01 PM, Roshan Wijesena  wrote:

> It seems Kasun is right,
>
> the object "data" is by-default coming as html/text. so we don't need use
> it as 'data.html' .
>
> Since this is a blocker for APIM C5 - M1 release for now I have sent a
> pull request with a fix. Please review and merge.
>
> https://github.com/wso2/carbon-uuf-common/pull/41/files
>
>
> On Tue, Feb 14, 2017 at 10:42 AM, Kasun Thennakoon 
> wrote:
>
>> Hi all,
>>
>> Experience the $subject when using UUF-Client for rendering hbs fragments.
>> As I understand, the response of 
>> *http://localhost:9090/publisher/fragments/{fragment-name}
>>  *contains
>> an HTML string and in this line[1] it is looking for *.html* attribute
>> in the response object when calling *pushContent* method. Which pass an 
>> *undefined
>> *value.IMHO this is what cause to display no content in the target zone.
>>
>>
>> [1]: https://github.com/wso2/carbon-uuf-common/blob/master/c
>> omponents/org.wso2.carbon.uuf.common.foundation.ui/src/main/
>> fragments/uuf-client/public/uuf-client/uuf-client.js#L226
>>
>> --
>> *Kasun Thennakoon*
>> Software Engineer
>> WSO2, Inc.
>> Mobile:+94 711661919
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> Roshan Wijesena.
> Senior Software Engineer-WSO2 Inc.
> Mobile: *+94719154640 <+94%2071%20915%204640>*
> Email: ros...@wso2.com
> *WSO2, Inc. :** wso2.com *
> lean.enterprise.middleware.
>



-- 
Sajith Janaprasad Ariyarathna
Software Engineer; WSO2, Inc.;  http://wso2.com/

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [UUF] UUF-Client renderFragment fails with warning "Content is empty."

2017-02-16 Thread Roshan Wijesena 
It seems Kasun is right,

the object "data" is by-default coming as html/text. so we don't need use
it as 'data.html' .

Since this is a blocker for APIM C5 - M1 release for now I have sent a pull
request with a fix. Please review and merge.

https://github.com/wso2/carbon-uuf-common/pull/41/files


On Tue, Feb 14, 2017 at 10:42 AM, Kasun Thennakoon  wrote:

> Hi all,
>
> Experience the $subject when using UUF-Client for rendering hbs fragments.
> As I understand, the response of 
> *http://localhost:9090/publisher/fragments/{fragment-name}
>  *contains
> an HTML string and in this line[1] it is looking for *.html* attribute in
> the response object when calling *pushContent* method. Which pass an 
> *undefined
> *value.IMHO this is what cause to display no content in the target zone.
>
>
> [1]: https://github.com/wso2/carbon-uuf-common/blob/master/
> components/org.wso2.carbon.uuf.common.foundation.ui/src/
> main/fragments/uuf-client/public/uuf-client/uuf-client.js#L226
>
> --
> *Kasun Thennakoon*
> Software Engineer
> WSO2, Inc.
> Mobile:+94 711661919
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Roshan Wijesena.
Senior Software Engineer-WSO2 Inc.
Mobile: *+94719154640*
Email: ros...@wso2.com
*WSO2, Inc. :** wso2.com *
lean.enterprise.middleware.
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] [UUF] UUF-Client renderFragment fails with warning "Content is empty."

2017-02-13 Thread Kasun Thennakoon 
Hi all,

Experience the $subject when using UUF-Client for rendering hbs fragments.
As I understand, the response of
*http://localhost:9090/publisher/fragments/{fragment-name}
 *contains an
HTML string and in this line[1] it is looking for *.html* attribute in the
response object when calling *pushContent* method. Which pass an *undefined
*value.IMHO this is what cause to display no content in the target zone.


[1]:
https://github.com/wso2/carbon-uuf-common/blob/master/components/org.wso2.carbon.uuf.common.foundation.ui/src/main/fragments/uuf-client/public/uuf-client/uuf-client.js#L226

-- 
*Kasun Thennakoon*
Software Engineer
WSO2, Inc.
Mobile:+94 711661919
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev