Re: [Dev] [SP] Lots of logs getting printed when matrices are enabled

2018-11-15 Thread Ramindu De Silva 
Hi all,

As per the offline discussion with Isuru, We will be convert the logs to be
debug logs[1]. Since an initial message (INFO
{org.wso2.carbon.metrics.core.config.model.JmxReporterConfig} - Creating
JMX reporter for Metrics with domain 'org.wso2.carbon.metrics') is getting
printed when the server is starting with metrics enabled.

Best regards,
ramindu.

On Fri, Nov 16, 2018 at 1:20 AM Ramindu De Silva  wrote:

> Hi all,
>
> Theres already a log as below "INFO
> {org.wso2.carbon.metrics.core.reporter.impl.AbstractReporter} - Started
> JDBC reporter for Metrics"
> Shouldnt that be enough?
>
> Best regards,
> Ramindu.
>
> On Thu, Nov 15, 2018 at 5:15 PM Sriskandarajah Suhothayan 
> wrote:
>
>> Yes, Can we just print just one log for all the JMX reporters.
>>
>> Suho
>>
>> On Thu, Nov 15, 2018 at 11:39 AM Isuru Perera  wrote:
>>
>>> Do you mean the following log?
>>>
>>> Started JMX reporter for Metrics
>>>
>>> It's supposed to be logged only at initialization time. However when
>>> changing the metric levels, the listening reporters are restarted (due to
>>> the way it's implemented). For example, the default JMX Reporter will not
>>> detect new metrics (when a metric is changing the status to enabled). We
>>> need to fix the code (to avoid printing many logs).
>>>
>>>
>>>
>>> On Tue, Nov 13, 2018 at 8:15 PM Ramindu De Silva 
>>> wrote:
>>>
 Hi All,

 Regarding the "Lots of log printed when matrices are enabled" issue
 [1]. When each an every metrics is starting[2], the log is getting printed
 when setting the metrics level. Should we make these logs [3] to debug 
 logs?


 1. https://github.com/wso2/product-sp/issues/873
 2.
 https://github.com/wso2/carbon-analytics/blob/b4a2bcf444d25031775a679bad76798d70ce7d5b/components/org.wso2.carbon.siddhi.metrics.core/src/main/java/org/wso2/carbon/siddhi/metrics/core/SiddhiThroughputMetric.java#L41
 3.
 https://github.com/ramindu90/carbon-metrics/blob/61c87c5360859c64217bcfa63f56b1c3fff32279/components/org.wso2.carbon.metrics.core/src/main/java/org/wso2/carbon/metrics/core/reporter/impl/AbstractReporter.java#L59

 Best Regards,
 Ramindu.

 --
 *Ramindu De Silva*
 Senior Software Engineer
 WSO2 Inc.: http://wso2.com
 lean.enterprise.middleware

 email: ramin...@wso2.com 
 mob: +94 719678895

>>>
>>>
>>> --
>>> Isuru Perera | Technical Lead | WSO2 Inc.
>>> Contact: +IsuruPereraWSO2 
>>> GET INTEGRATION AGILE
>>> Integration Agility for Digitally Driven Business
>>>
>> --
>> *S. Suhothayan* | Director | WSO2 Inc. 
>> (m) (+94) 779 756 757 | (e) s...@wso2.com | (t) @suhothayan
>> 
>> GET INTEGRATION AGILE
>> Integration Agility for Digitally Driven Business
>>
>
>
> --
> *Ramindu De Silva*
> Senior Software Engineer
> WSO2 Inc.: http://wso2.com
> lean.enterprise.middleware
>
> email: ramin...@wso2.com 
> mob: +94 719678895
>


-- 
*Ramindu De Silva*
Senior Software Engineer
WSO2 Inc.: http://wso2.com
lean.enterprise.middleware

email: ramin...@wso2.com 
mob: +94 719678895
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [SP] Lots of logs getting printed when matrices are enabled

2018-11-15 Thread Ramindu De Silva 
Hi all,

Theres already a log as below "INFO
{org.wso2.carbon.metrics.core.reporter.impl.AbstractReporter} - Started
JDBC reporter for Metrics"
Shouldnt that be enough?

Best regards,
Ramindu.

On Thu, Nov 15, 2018 at 5:15 PM Sriskandarajah Suhothayan 
wrote:

> Yes, Can we just print just one log for all the JMX reporters.
>
> Suho
>
> On Thu, Nov 15, 2018 at 11:39 AM Isuru Perera  wrote:
>
>> Do you mean the following log?
>>
>> Started JMX reporter for Metrics
>>
>> It's supposed to be logged only at initialization time. However when
>> changing the metric levels, the listening reporters are restarted (due to
>> the way it's implemented). For example, the default JMX Reporter will not
>> detect new metrics (when a metric is changing the status to enabled). We
>> need to fix the code (to avoid printing many logs).
>>
>>
>>
>> On Tue, Nov 13, 2018 at 8:15 PM Ramindu De Silva 
>> wrote:
>>
>>> Hi All,
>>>
>>> Regarding the "Lots of log printed when matrices are enabled" issue [1].
>>> When each an every metrics is starting[2], the log is getting printed when
>>> setting the metrics level. Should we make these logs [3] to debug logs?
>>>
>>>
>>> 1. https://github.com/wso2/product-sp/issues/873
>>> 2.
>>> https://github.com/wso2/carbon-analytics/blob/b4a2bcf444d25031775a679bad76798d70ce7d5b/components/org.wso2.carbon.siddhi.metrics.core/src/main/java/org/wso2/carbon/siddhi/metrics/core/SiddhiThroughputMetric.java#L41
>>> 3.
>>> https://github.com/ramindu90/carbon-metrics/blob/61c87c5360859c64217bcfa63f56b1c3fff32279/components/org.wso2.carbon.metrics.core/src/main/java/org/wso2/carbon/metrics/core/reporter/impl/AbstractReporter.java#L59
>>>
>>> Best Regards,
>>> Ramindu.
>>>
>>> --
>>> *Ramindu De Silva*
>>> Senior Software Engineer
>>> WSO2 Inc.: http://wso2.com
>>> lean.enterprise.middleware
>>>
>>> email: ramin...@wso2.com 
>>> mob: +94 719678895
>>>
>>
>>
>> --
>> Isuru Perera | Technical Lead | WSO2 Inc.
>> Contact: +IsuruPereraWSO2 
>> GET INTEGRATION AGILE
>> Integration Agility for Digitally Driven Business
>>
> --
> *S. Suhothayan* | Director | WSO2 Inc. 
> (m) (+94) 779 756 757 | (e) s...@wso2.com | (t) @suhothayan
> 
> GET INTEGRATION AGILE
> Integration Agility for Digitally Driven Business
>


-- 
*Ramindu De Silva*
Senior Software Engineer
WSO2 Inc.: http://wso2.com
lean.enterprise.middleware

email: ramin...@wso2.com 
mob: +94 719678895
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [SP] Lots of logs getting printed when matrices are enabled

2018-11-15 Thread Sriskandarajah Suhothayan 
Yes, Can we just print just one log for all the JMX reporters.

Suho

On Thu, Nov 15, 2018 at 11:39 AM Isuru Perera  wrote:

> Do you mean the following log?
>
> Started JMX reporter for Metrics
>
> It's supposed to be logged only at initialization time. However when
> changing the metric levels, the listening reporters are restarted (due to
> the way it's implemented). For example, the default JMX Reporter will not
> detect new metrics (when a metric is changing the status to enabled). We
> need to fix the code (to avoid printing many logs).
>
>
>
> On Tue, Nov 13, 2018 at 8:15 PM Ramindu De Silva 
> wrote:
>
>> Hi All,
>>
>> Regarding the "Lots of log printed when matrices are enabled" issue [1].
>> When each an every metrics is starting[2], the log is getting printed when
>> setting the metrics level. Should we make these logs [3] to debug logs?
>>
>>
>> 1. https://github.com/wso2/product-sp/issues/873
>> 2.
>> https://github.com/wso2/carbon-analytics/blob/b4a2bcf444d25031775a679bad76798d70ce7d5b/components/org.wso2.carbon.siddhi.metrics.core/src/main/java/org/wso2/carbon/siddhi/metrics/core/SiddhiThroughputMetric.java#L41
>> 3.
>> https://github.com/ramindu90/carbon-metrics/blob/61c87c5360859c64217bcfa63f56b1c3fff32279/components/org.wso2.carbon.metrics.core/src/main/java/org/wso2/carbon/metrics/core/reporter/impl/AbstractReporter.java#L59
>>
>> Best Regards,
>> Ramindu.
>>
>> --
>> *Ramindu De Silva*
>> Senior Software Engineer
>> WSO2 Inc.: http://wso2.com
>> lean.enterprise.middleware
>>
>> email: ramin...@wso2.com 
>> mob: +94 719678895
>>
>
>
> --
> Isuru Perera | Technical Lead | WSO2 Inc.
> Contact: +IsuruPereraWSO2 
> GET INTEGRATION AGILE
> Integration Agility for Digitally Driven Business
>
-- 
*S. Suhothayan* | Director | WSO2 Inc. 
(m) (+94) 779 756 757 | (e) s...@wso2.com | (t) @suhothayan

GET INTEGRATION AGILE
Integration Agility for Digitally Driven Business
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [SP] Lots of logs getting printed when matrices are enabled

2018-11-15 Thread Isuru Perera 
Do you mean the following log?

Started JMX reporter for Metrics

It's supposed to be logged only at initialization time. However when
changing the metric levels, the listening reporters are restarted (due to
the way it's implemented). For example, the default JMX Reporter will not
detect new metrics (when a metric is changing the status to enabled). We
need to fix the code (to avoid printing many logs).



On Tue, Nov 13, 2018 at 8:15 PM Ramindu De Silva  wrote:

> Hi All,
>
> Regarding the "Lots of log printed when matrices are enabled" issue [1].
> When each an every metrics is starting[2], the log is getting printed when
> setting the metrics level. Should we make these logs [3] to debug logs?
>
>
> 1. https://github.com/wso2/product-sp/issues/873
> 2.
> https://github.com/wso2/carbon-analytics/blob/b4a2bcf444d25031775a679bad76798d70ce7d5b/components/org.wso2.carbon.siddhi.metrics.core/src/main/java/org/wso2/carbon/siddhi/metrics/core/SiddhiThroughputMetric.java#L41
> 3.
> https://github.com/ramindu90/carbon-metrics/blob/61c87c5360859c64217bcfa63f56b1c3fff32279/components/org.wso2.carbon.metrics.core/src/main/java/org/wso2/carbon/metrics/core/reporter/impl/AbstractReporter.java#L59
>
> Best Regards,
> Ramindu.
>
> --
> *Ramindu De Silva*
> Senior Software Engineer
> WSO2 Inc.: http://wso2.com
> lean.enterprise.middleware
>
> email: ramin...@wso2.com 
> mob: +94 719678895
>


-- 
Isuru Perera | Technical Lead | WSO2 Inc.
Contact: +IsuruPereraWSO2 
GET INTEGRATION AGILE
Integration Agility for Digitally Driven Business
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev