Re: [Dev] Syntax Error in ESB 4.8.1 build.sh File
Yeah. We can add the validation to check whether all necessary files are available before continue with the docker image build process. Also when we building the template module we can just copy the template binary to the package folder as template module is part of the PPasS. That will be more easier for the user.For the other binaries I think it is better to provide the download URL in the read me file. Thanks, Gayan On Tue, Aug 25, 2015 at 9:39 AM, Lasindu Charith wrote: > Sure will do. > > On Tue, Aug 25, 2015 at 9:31 AM, Imesh Gunaratne wrote: > >> Thanks for the response Lasindu!! IMO it would be better if we can add >> few validations in the build.sh file to check whether necessary files are >> there before building the docker image. >> >> On Tue, Aug 25, 2015 at 7:50 AM, Lasindu Charith >> wrote: >> >>> >>> >>> On Tue, Aug 25, 2015 at 6:36 AM, Lasindu Charith >>> wrote: >>> Hi Imesh/Pubudu, Please find my comments inline. On Tue, Aug 25, 2015 at 12:31 AM, Pubudu Gunatilaka wrote: > Hi, > > build.sh file fails when there are no plugins in the {product/plugins} > folder. We need to change the scripts as well. > pushd ${wso2_product_plugin_path} cp * ${script_path}/plugins popd The above 'cp *" command will not fail if there are no files inside ' wso2_product_plugin_path'. But however it will fail if there's no ' wso2_product_plugin_path'or'script_path}/plugins'which I guess is not possible. >>> My-bad. It will say *"cp: cannot stat ‘*’: No such file or directory"* >>> which I think is ok since it acts as a warning. Building the docker image >>> requires these plugins (that's the reason to include them in buil.sh) and >>> shouldn't it log an error if the required files are not available? >>> >>> I don't think we should hide the errors by changing it to 'cp * >>> ${script_path}/plugins 2>>/dev/null' >>> >>> >>> I could see the same syntax errors in the other docker images as well. > Will do the needful. > > Thank you! > > On Mon, Aug 24, 2015 at 11:47 PM, Imesh Gunaratne > wrote: > >> One other problem I noticed with this build.sh file is that it does >> not copy the plugin files to plugins folder when executed with clean. >> >> On Mon, Aug 24, 2015 at 11:41 PM, Imesh Gunaratne >> wrote: >> >>> Hi, >>> >>> I found the following issue in ESB 4.8.1 build.sh file and fixed: >>> >>> echo "---" >>> - echo "Building" ${wso2_product_type^^} - ${wso2_product_version} >>> "template module" >>> + echo "Building" ${wso2_product_type} - ${wso2_product_version} >>> "template module" >>> echo "---" >>> >>> >>> https://github.com/wso2/product-private-paas/commit/f2f763e7612eeae1a1e211b1fd97a970b5c369f1 >>> >>> This in-fact will change the 'wso2_product_type' to uppercase. However it will not work with bash versions below v4.0. So it's ok to remove them for now. >>> >>> This will be a syntax error in mac since the default bash version is v3.x.x. > -- >>> *Imesh Gunaratne* >>> Senior Technical Lead >>> WSO2 Inc: http://wso2.com >>> T: +94 11 214 5345 M: +94 77 374 2057 >>> W: http://imesh.gunaratne.org >>> Lean . Enterprise . Middleware >>> >>> >> >> >> -- >> *Imesh Gunaratne* >> Senior Technical Lead >> WSO2 Inc: http://wso2.com >> T: +94 11 214 5345 M: +94 77 374 2057 >> W: http://imesh.gunaratne.org >> Lean . Enterprise . Middleware >> >> >> ___ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > > *Pubudu Gunatilaka* > Software Engineer > WSO2, Inc.: http://wso2.com > lean.enterprise.middleware > mobile: +94 77 4078049 > Thanks, -- *Lasindu Charith* Software Engineer, WSO2 Inc. Committer & PMC Member, Apache Stratos Mobile: +94714427192 | Web: blog.lasindu.com >>> >>> >>> >>> -- >>> *Lasindu Charith* >>> Software Engineer, WSO2 Inc. >>> Committer & PMC Member, Apache Stratos >>> Mobile: +94714427192 | Web: blog.lasindu.com >>> >> >> >> >> -- >> *Imesh Gunaratne* >> Senior Technical Lead >> WSO2 Inc: http://wso2.com >> T: +94 11 214 5345 M: +94 77 374 2057 >> W: http://imesh.gunaratne.org >> Lean . Enterprise . Middleware >> >> > > > -- > *Lasindu Charith* > Software Engineer, WSO2 Inc. > Committer & PMC Member, Apache Stratos > Mobile: +94714427192 | Web: blog.lasindu.com > > ___ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Gayan Gunarathne Technical Lead, WSO2 Inc. (http://wso2.com) Committer & PMC Member, Apache St
Re: [Dev] Syntax Error in ESB 4.8.1 build.sh File
Sure will do. On Tue, Aug 25, 2015 at 9:31 AM, Imesh Gunaratne wrote: > Thanks for the response Lasindu!! IMO it would be better if we can add few > validations in the build.sh file to check whether necessary files are there > before building the docker image. > > On Tue, Aug 25, 2015 at 7:50 AM, Lasindu Charith wrote: > >> >> >> On Tue, Aug 25, 2015 at 6:36 AM, Lasindu Charith >> wrote: >> >>> Hi Imesh/Pubudu, >>> >>> Please find my comments inline. >>> >>> On Tue, Aug 25, 2015 at 12:31 AM, Pubudu Gunatilaka >>> wrote: >>> Hi, build.sh file fails when there are no plugins in the {product/plugins} folder. We need to change the scripts as well. >>> pushd ${wso2_product_plugin_path} >>> cp * ${script_path}/plugins >>> popd >>> >>> The above 'cp *" command will not fail if there are no files inside ' >>> wso2_product_plugin_path'. But however it will fail if there's no ' >>> wso2_product_plugin_path'or'script_path}/plugins'which I guess is not >>> possible. >>> >>> >> My-bad. It will say *"cp: cannot stat ‘*’: No such file or directory"* >> which I think is ok since it acts as a warning. Building the docker image >> requires these plugins (that's the reason to include them in buil.sh) and >> shouldn't it log an error if the required files are not available? >> >> I don't think we should hide the errors by changing it to 'cp * >> ${script_path}/plugins 2>>/dev/null' >> >> >> I could see the same syntax errors in the other docker images as well. Will do the needful. Thank you! On Mon, Aug 24, 2015 at 11:47 PM, Imesh Gunaratne wrote: > One other problem I noticed with this build.sh file is that it does > not copy the plugin files to plugins folder when executed with clean. > > On Mon, Aug 24, 2015 at 11:41 PM, Imesh Gunaratne > wrote: > >> Hi, >> >> I found the following issue in ESB 4.8.1 build.sh file and fixed: >> >> echo "---" >> - echo "Building" ${wso2_product_type^^} - ${wso2_product_version} >> "template module" >> + echo "Building" ${wso2_product_type} - ${wso2_product_version} >> "template module" >> echo "---" >> >> >> https://github.com/wso2/product-private-paas/commit/f2f763e7612eeae1a1e211b1fd97a970b5c369f1 >> >> This in-fact will change the 'wso2_product_type' to uppercase. >>> However it will not work with bash versions below v4.0. >>> So it's ok to remove them for now. >>> >> >> >>> This will be a syntax error in mac since the default bash version is >>> v3.x.x. >>> >>> >>> -- >> *Imesh Gunaratne* >> Senior Technical Lead >> WSO2 Inc: http://wso2.com >> T: +94 11 214 5345 M: +94 77 374 2057 >> W: http://imesh.gunaratne.org >> Lean . Enterprise . Middleware >> >> > > > -- > *Imesh Gunaratne* > Senior Technical Lead > WSO2 Inc: http://wso2.com > T: +94 11 214 5345 M: +94 77 374 2057 > W: http://imesh.gunaratne.org > Lean . Enterprise . Middleware > > > ___ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- *Pubudu Gunatilaka* Software Engineer WSO2, Inc.: http://wso2.com lean.enterprise.middleware mobile: +94 77 4078049 >>> >>> >>> Thanks, >>> -- >>> *Lasindu Charith* >>> Software Engineer, WSO2 Inc. >>> Committer & PMC Member, Apache Stratos >>> Mobile: +94714427192 | Web: blog.lasindu.com >>> >> >> >> >> -- >> *Lasindu Charith* >> Software Engineer, WSO2 Inc. >> Committer & PMC Member, Apache Stratos >> Mobile: +94714427192 | Web: blog.lasindu.com >> > > > > -- > *Imesh Gunaratne* > Senior Technical Lead > WSO2 Inc: http://wso2.com > T: +94 11 214 5345 M: +94 77 374 2057 > W: http://imesh.gunaratne.org > Lean . Enterprise . Middleware > > -- *Lasindu Charith* Software Engineer, WSO2 Inc. Committer & PMC Member, Apache Stratos Mobile: +94714427192 | Web: blog.lasindu.com ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Syntax Error in ESB 4.8.1 build.sh File
Thanks for the response Lasindu!! IMO it would be better if we can add few validations in the build.sh file to check whether necessary files are there before building the docker image. On Tue, Aug 25, 2015 at 7:50 AM, Lasindu Charith wrote: > > > On Tue, Aug 25, 2015 at 6:36 AM, Lasindu Charith wrote: > >> Hi Imesh/Pubudu, >> >> Please find my comments inline. >> >> On Tue, Aug 25, 2015 at 12:31 AM, Pubudu Gunatilaka >> wrote: >> >>> Hi, >>> >>> build.sh file fails when there are no plugins in the {product/plugins} >>> folder. We need to change the scripts as well. >>> >> pushd ${wso2_product_plugin_path} >> cp * ${script_path}/plugins >> popd >> >> The above 'cp *" command will not fail if there are no files inside ' >> wso2_product_plugin_path'. But however it will fail if there's no ' >> wso2_product_plugin_path'or'script_path}/plugins'which I guess is not >> possible. >> >> > My-bad. It will say *"cp: cannot stat ‘*’: No such file or directory"* > which I think is ok since it acts as a warning. Building the docker image > requires these plugins (that's the reason to include them in buil.sh) and > shouldn't it log an error if the required files are not available? > > I don't think we should hide the errors by changing it to 'cp * > ${script_path}/plugins 2>>/dev/null' > > > I could see the same syntax errors in the other docker images as well. >>> Will do the needful. >>> >>> Thank you! >>> >>> On Mon, Aug 24, 2015 at 11:47 PM, Imesh Gunaratne >>> wrote: >>> One other problem I noticed with this build.sh file is that it does not copy the plugin files to plugins folder when executed with clean. On Mon, Aug 24, 2015 at 11:41 PM, Imesh Gunaratne wrote: > Hi, > > I found the following issue in ESB 4.8.1 build.sh file and fixed: > > echo "---" > - echo "Building" ${wso2_product_type^^} - ${wso2_product_version} > "template module" > + echo "Building" ${wso2_product_type} - ${wso2_product_version} > "template module" > echo "---" > > > https://github.com/wso2/product-private-paas/commit/f2f763e7612eeae1a1e211b1fd97a970b5c369f1 > > This in-fact will change the 'wso2_product_type' to uppercase. >> However it will not work with bash versions below v4.0. >> So it's ok to remove them for now. >> > > >> This will be a syntax error in mac since the default bash version is >> v3.x.x. >> >> >> >>> -- > *Imesh Gunaratne* > Senior Technical Lead > WSO2 Inc: http://wso2.com > T: +94 11 214 5345 M: +94 77 374 2057 > W: http://imesh.gunaratne.org > Lean . Enterprise . Middleware > > -- *Imesh Gunaratne* Senior Technical Lead WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: http://imesh.gunaratne.org Lean . Enterprise . Middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >>> -- >>> >>> *Pubudu Gunatilaka* >>> Software Engineer >>> WSO2, Inc.: http://wso2.com >>> lean.enterprise.middleware >>> mobile: +94 77 4078049 >>> >> >> >> Thanks, >> -- >> *Lasindu Charith* >> Software Engineer, WSO2 Inc. >> Committer & PMC Member, Apache Stratos >> Mobile: +94714427192 | Web: blog.lasindu.com >> > > > > -- > *Lasindu Charith* > Software Engineer, WSO2 Inc. > Committer & PMC Member, Apache Stratos > Mobile: +94714427192 | Web: blog.lasindu.com > -- *Imesh Gunaratne* Senior Technical Lead WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: http://imesh.gunaratne.org Lean . Enterprise . Middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Syntax Error in ESB 4.8.1 build.sh File
On Tue, Aug 25, 2015 at 6:36 AM, Lasindu Charith wrote: > Hi Imesh/Pubudu, > > Please find my comments inline. > > On Tue, Aug 25, 2015 at 12:31 AM, Pubudu Gunatilaka > wrote: > >> Hi, >> >> build.sh file fails when there are no plugins in the {product/plugins} >> folder. We need to change the scripts as well. >> > pushd ${wso2_product_plugin_path} > cp * ${script_path}/plugins > popd > > The above 'cp *" command will not fail if there are no files inside ' > wso2_product_plugin_path'. But however it will fail if there's no ' > wso2_product_plugin_path'or'script_path}/plugins'which I guess is not > possible. > > My-bad. It will say *"cp: cannot stat ‘*’: No such file or directory"* which I think is ok since it acts as a warning. Building the docker image requires these plugins (that's the reason to include them in buil.sh) and shouldn't it log an error if the required files are not available? I don't think we should hide the errors by changing it to 'cp * ${script_path}/plugins 2>>/dev/null' I could see the same syntax errors in the other docker images as well. Will >> do the needful. >> >> Thank you! >> >> On Mon, Aug 24, 2015 at 11:47 PM, Imesh Gunaratne wrote: >> >>> One other problem I noticed with this build.sh file is that it does not >>> copy the plugin files to plugins folder when executed with clean. >>> >>> On Mon, Aug 24, 2015 at 11:41 PM, Imesh Gunaratne >>> wrote: >>> Hi, I found the following issue in ESB 4.8.1 build.sh file and fixed: echo "---" - echo "Building" ${wso2_product_type^^} - ${wso2_product_version} "template module" + echo "Building" ${wso2_product_type} - ${wso2_product_version} "template module" echo "---" https://github.com/wso2/product-private-paas/commit/f2f763e7612eeae1a1e211b1fd97a970b5c369f1 This in-fact will change the 'wso2_product_type' to uppercase. However > it will not work with bash versions below v4.0. > So it's ok to remove them for now. > > This will be a syntax error in mac since the default bash version is > v3.x.x. > > > >> -- *Imesh Gunaratne* Senior Technical Lead WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: http://imesh.gunaratne.org Lean . Enterprise . Middleware >>> >>> >>> -- >>> *Imesh Gunaratne* >>> Senior Technical Lead >>> WSO2 Inc: http://wso2.com >>> T: +94 11 214 5345 M: +94 77 374 2057 >>> W: http://imesh.gunaratne.org >>> Lean . Enterprise . Middleware >>> >>> >>> ___ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> >> *Pubudu Gunatilaka* >> Software Engineer >> WSO2, Inc.: http://wso2.com >> lean.enterprise.middleware >> mobile: +94 77 4078049 >> > > > Thanks, > -- > *Lasindu Charith* > Software Engineer, WSO2 Inc. > Committer & PMC Member, Apache Stratos > Mobile: +94714427192 | Web: blog.lasindu.com > -- *Lasindu Charith* Software Engineer, WSO2 Inc. Committer & PMC Member, Apache Stratos Mobile: +94714427192 | Web: blog.lasindu.com ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Syntax Error in ESB 4.8.1 build.sh File
Hi Imesh/Pubudu, Please find my comments inline. On Tue, Aug 25, 2015 at 12:31 AM, Pubudu Gunatilaka wrote: > Hi, > > build.sh file fails when there are no plugins in the {product/plugins} > folder. We need to change the scripts as well. > pushd ${wso2_product_plugin_path} cp * ${script_path}/plugins popd The above 'cp *" command will not fail if there are no files inside ' wso2_product_plugin_path'. But however it will fail if there's no ' wso2_product_plugin_path'or'script_path}/plugins'which I guess is not possible. > I could see the same syntax errors in the other docker images as well. > Will do the needful. > > Thank you! > > On Mon, Aug 24, 2015 at 11:47 PM, Imesh Gunaratne wrote: > >> One other problem I noticed with this build.sh file is that it does not >> copy the plugin files to plugins folder when executed with clean. >> >> On Mon, Aug 24, 2015 at 11:41 PM, Imesh Gunaratne wrote: >> >>> Hi, >>> >>> I found the following issue in ESB 4.8.1 build.sh file and fixed: >>> >>> echo "---" >>> - echo "Building" ${wso2_product_type^^} - ${wso2_product_version} >>> "template module" >>> + echo "Building" ${wso2_product_type} - ${wso2_product_version} >>> "template module" >>> echo "---" >>> >>> >>> https://github.com/wso2/product-private-paas/commit/f2f763e7612eeae1a1e211b1fd97a970b5c369f1 >>> >>> This in-fact will change the 'wso2_product_type' to uppercase. However it will not work with bash versions below v4.0. So it's ok to remove them for now. > -- >>> *Imesh Gunaratne* >>> Senior Technical Lead >>> WSO2 Inc: http://wso2.com >>> T: +94 11 214 5345 M: +94 77 374 2057 >>> W: http://imesh.gunaratne.org >>> Lean . Enterprise . Middleware >>> >>> >> >> >> -- >> *Imesh Gunaratne* >> Senior Technical Lead >> WSO2 Inc: http://wso2.com >> T: +94 11 214 5345 M: +94 77 374 2057 >> W: http://imesh.gunaratne.org >> Lean . Enterprise . Middleware >> >> >> ___ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > > *Pubudu Gunatilaka* > Software Engineer > WSO2, Inc.: http://wso2.com > lean.enterprise.middleware > mobile: +94 77 4078049 > Thanks, -- *Lasindu Charith* Software Engineer, WSO2 Inc. Committer & PMC Member, Apache Stratos Mobile: +94714427192 | Web: blog.lasindu.com ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Syntax Error in ESB 4.8.1 build.sh File
Hi, build.sh file fails when there are no plugins in the {product/plugins} folder. We need to change the scripts as well. I could see the same syntax errors in the other docker images as well. Will do the needful. Thank you! On Mon, Aug 24, 2015 at 11:47 PM, Imesh Gunaratne wrote: > One other problem I noticed with this build.sh file is that it does not > copy the plugin files to plugins folder when executed with clean. > > On Mon, Aug 24, 2015 at 11:41 PM, Imesh Gunaratne wrote: > >> Hi, >> >> I found the following issue in ESB 4.8.1 build.sh file and fixed: >> >> echo "---" >> - echo "Building" ${wso2_product_type^^} - ${wso2_product_version} >> "template module" >> + echo "Building" ${wso2_product_type} - ${wso2_product_version} >> "template module" >> echo "---" >> >> >> https://github.com/wso2/product-private-paas/commit/f2f763e7612eeae1a1e211b1fd97a970b5c369f1 >> >> -- >> *Imesh Gunaratne* >> Senior Technical Lead >> WSO2 Inc: http://wso2.com >> T: +94 11 214 5345 M: +94 77 374 2057 >> W: http://imesh.gunaratne.org >> Lean . Enterprise . Middleware >> >> > > > -- > *Imesh Gunaratne* > Senior Technical Lead > WSO2 Inc: http://wso2.com > T: +94 11 214 5345 M: +94 77 374 2057 > W: http://imesh.gunaratne.org > Lean . Enterprise . Middleware > > > ___ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- *Pubudu Gunatilaka* Software Engineer WSO2, Inc.: http://wso2.com lean.enterprise.middleware mobile: +94 77 4078049 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Syntax Error in ESB 4.8.1 build.sh File
One other problem I noticed with this build.sh file is that it does not copy the plugin files to plugins folder when executed with clean. On Mon, Aug 24, 2015 at 11:41 PM, Imesh Gunaratne wrote: > Hi, > > I found the following issue in ESB 4.8.1 build.sh file and fixed: > > echo "---" > - echo "Building" ${wso2_product_type^^} - ${wso2_product_version} > "template module" > + echo "Building" ${wso2_product_type} - ${wso2_product_version} > "template module" > echo "---" > > > https://github.com/wso2/product-private-paas/commit/f2f763e7612eeae1a1e211b1fd97a970b5c369f1 > > -- > *Imesh Gunaratne* > Senior Technical Lead > WSO2 Inc: http://wso2.com > T: +94 11 214 5345 M: +94 77 374 2057 > W: http://imesh.gunaratne.org > Lean . Enterprise . Middleware > > -- *Imesh Gunaratne* Senior Technical Lead WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: http://imesh.gunaratne.org Lean . Enterprise . Middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev