[GitHub] zeppelin pull request #1808: [ZEPPELIN-1843] Error on invoking the REST API ...
GitHub user kavinkumarks opened a pull request: https://github.com/apache/zeppelin/pull/1808 [ZEPPELIN-1843] Error on invoking the REST API to run paragraph synchronously ### What is this PR for? This fixes the validation check of paragraph's note id to match with the Note instance id. ### What type of PR is it? Bug Fix ### Todos NA ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1843 ### How should this be tested? The run para synchronous REST API should be successful. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/kavinkumarks/zeppelin zeppelin-1843-run-para-sync-api-error Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1808.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1808 commit b5f29270ead7a065d440b8fbf2db590805d9 Author: Kavin Date: 2016-12-28T07:39:19Z Throw IAE only when the note id of the instance and paragraph's note id doesn't match. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1730 @tae-jun It's great feature! So, I would like to suggest one thing. Currently, the filter function in Zeppelin homepage doesn't work as expected and this issue is handled in [ZEPPELIN-1864](https://issues.apache.org/jira/browse/ZEPPELIN-1864). But, when using filter function, all icon is disappeared like below. ![z1736](https://cloud.githubusercontent.com/assets/8110458/21514983/d335bf50-cd0e-11e6-8297-a48bbacdf308.gif) At this time, I think It would be nice to show some icon next to note or folder if you don't mind. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1790: [ZEPPELIN-1845] InterpreterFactory.createOrGetI...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1790 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1784: [ZEPPELIN-1840] Allow fully qualified username ...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1784 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1805: [ZEPPELIN-1850] Introduce Webpack (front)
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1805 Tested `console.log` in dev and dist. It now works as expected. LGTM and merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1775 @khalidhuseynov Thanks for reply! > yeah that's good point, do you have something in mind regarding it? i was thinking whether it should be more of a mode switch (say different mode added in addition to report mode, etc) or just represent visually (say gray out editor background like when running note), or something else. We might use css transparent property to let user know this paragraphs are readonly like in running interpreters https://cloud.githubusercontent.com/assets/4968473/21513606/0624d15a-ccfe-11e6-826c-fe2a1feb79f3.png";> > thanks for testing, addressed under 50e1472. please check it out. I checked and works well! > actually we have issue regarding this one to have GitNotebookRepo as default repo, in that case we don't need to hide it i believe. Glad to hear that! Actually i want it to be default ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1736 Sorry, I've missed your review @Leemoonsoo If your note has only one paragraph and you checked that menu of paragraph, it normally works like your screenshot. Because that paragraph doesn't need some function like `Move up` and `Move down` and `Remove`. If you want to see all item, could you check middle paragraph menu after making three paragraph? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1805: [ZEPPELIN-1850] Introduce Webpack (front)
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1805 @Leemoonsoo ### Remove `console.log` in dist I missed it. Previously, grunt stripped all `console.log` using this config ``` uglify: { ... 'drop_console': true ... ``` So i added [strip-loader](https://github.com/yahoo/strip-loader) to achieve same behavior while building in 5e1696f ### About Size ``` ## before -rw-r--r-- 1 lambda staff 113K Dec 28 11:33 scripts.1546a550da5ec483.js ## after -rw-r--r-- 1 lambda staff 116K Dec 28 12:36 app.f4ebf1a368629b338f2d.js ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1775 @Leemoonsoo thanks for testing, right i could reproduce it. So in that case probably it shouldn't be allowed to change graph properties or pivot settings while viewing revisions, right? because otherwise it's changing `note.json` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1694: [ZEPPELIN-1718] Prevent anonymous user to set n...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1694 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1804: [ZEPPELIN-1578] notes list in customizing zeppelin hom...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1804 @soralee Thanks! Tested again and it's working well now like below. ![customnotehome](https://cloud.githubusercontent.com/assets/10060731/21512994/77e22eda-ccf6-11e6-912a-afb334a0a512.gif) @Leemoonsoo As an owner of this feature, could you take a look into if you're available? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1773: [DOCS] Add doc about zeppelin.notebook.public
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1773 Looks good! Thanks @zjffdu Merge into master if there are no more comments on this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1767: ZEPPELIN-1817 - Added documentation to Zeppelin's shir...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1767 @vinayshukla I think what @Leemoonsoo suggested was having only one documentation about this info. And IMO having detailed information to describe about "Authentication in Zeppelin", but it's not good idea put this all contents under "Overview". ![screen shot 2016-12-28 at 11 05 29 am](https://cloud.githubusercontent.com/assets/10060731/21512200/920d3a6a-cced-11e6-816a-8dd3e5f3d255.png) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1791: [ZEPPELIN-1847] fix: Copy only html when html f...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1791 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1801: ZEPPELIN-1844 Apache Ignite dependency upgrade ...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1801 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1798: ZEPPELIN-1853. Add README for livy interpreter
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1798 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1792: Change gitignore for font files
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1792 Merge into master if there are no further discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1730 @tae-jun Thanks for your great work! Merge if there are no more discussions :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1804: [ZEPPELIN-1578] notes list in customizing zeppelin hom...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1804 @AhyoungRyu I updated customHome.html and fixed your problem. Could you check again, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ZEPPELIN-1865) zeppelin-web build fails behind proxy
Nathaniel Meyer created ZEPPELIN-1865: - Summary: zeppelin-web build fails behind proxy Key: ZEPPELIN-1865 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1865 Project: Zeppelin Issue Type: Bug Components: zeppelin-server Affects Versions: 0.7.0 Environment: centos 6.7 on intranet server requiring proxy to access maven repo and npmjs registry Reporter: Nathaniel Meyer Priority: Minor maven proxy settings specified to node in zeppelin-web build do not carry over to bower or grunt as called in the postinstall script in package.json. expected behavior: successful build -- maven proxy settings are pushed down to all subsequent commands in the build script actual behavior: failed build -- maven proxy settings are passed to node install but not carried to postinstall actions Workaround: 1) for bower, add proxy config to ~/.bowerrc setting proxy and https-proxy 2) for grunt, export HTTP_PROXY environment variable before calling mvn -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1736 Tested again. And still not every items are displayed ![image](https://cloud.githubusercontent.com/assets/1540981/21507749/f6406426-cc2f-11e6-920d-79c9279061bd.png) @soralee could you check? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1805: [ZEPPELIN-1850] Introduce Webpack (front)
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1805 @1ambda Great improvement! Tested and it works well. One thing is, previously console.log() was printed only in dev mode. After this change, console.log() is printed both dev and dist. If it is not very difficult, can console.log() be muted in non-dev mode? Other than that, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1775 Tested this branch and found 1. select HEAD 2. and then switch to any revision. 3. change height of graph or change pivot setting 4. HEAD is changed by 3) @khalidhuseynov could you check scenario above? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1767: ZEPPELIN-1817 - Added documentation to Zeppelin's shir...
Github user vinayshukla commented on the issue: https://github.com/apache/zeppelin/pull/1767 @Leemoonsoo The CI failure is unrelated, the 2 files changed are template and markdown. Is there a way to re-trigger the CI? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...
GitHub user tae-jun reopened a pull request: https://github.com/apache/zeppelin/pull/1730 [ZEPPELIN-1736] Introduce trash & enable removing folder ### What is this PR for? ![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png) This PR introduces the trash! (which is essential, I think ^^;) I added basic operations of the trash: Added operations of trash * `Move` a folder to the trash * `Move` a note to the trash * `Restore` a folder * `Restore` a note * `Remove` a folder in the trash for good * `Remove` a note in the trash for good * `Empty` the trash * `Restore all` in the trash * `Move` a note to the trash from the notebook view * `Remove` a note to the trash for good from the notebook view * If there is a folder that has the same name, suffix current data rather than just merging(please see screenshot below!) ### What type of PR is it? [Feature] ### Future work Maybe it would be better if notebook view notices that a note is in the trash. ### What is the Jira issue? [ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736) ### How should this be tested? * Build this PR * Move some folders or notes to the trash * Restore them * Empty the trash * Restore all notes in the trash * Remove folders or notes in the trash * Remove a folder which has the same folder name in the trash ### Screenshots (if appropriate) ## Move, restore, remove a note from the main page ![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif) ## Move, restore, remove a folder from the main page ![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif) ## Move, remove a note from the notebook view ![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif) ## Restore, empty the trash ![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif) ## Suffix current date if the folder exists in the trash ![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif) ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1730.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1730 commit a010f8724329efe198bcb9406c8ed5892deea7d7 Author: Jun Kim Date: 2016-12-06T11:21:38Z Introduce trash & removing folder commit 6fc1846a044cc27ef5e5c69519b54cead25034a2 Author: Jun Kim Date: 2016-12-06T12:54:54Z Satisfy style check commit bf4641007ea209a44278514f0c5251b4a5732ac1 Author: Jun Kim Date: 2016-12-06T12:55:19Z Remove if note is in the trash from the notebook view commit 7ab945fbfef0da222e2291d32863931a81933edd Author: Jun Kim Date: 2016-12-07T17:12:51Z Use trash folder id provided by constant service commit b4f42b26f781c341a1d035e685024bef229370ba Author: Jun Kim Date: 2016-12-07T17:14:00Z Change âfor goodâ -> âpermanentlyâ commit 43cf08bac15f1e979a2ff6f1e1b7d21f9e07c62a Author: Jun Kim Date: 2016-12-07T17:15:51Z Make the order of the trash folder last commit 3490494a087f16e6d4b12101e829da571756e27f Author: Jun Kim Date: 2016-12-08T15:28:15Z Restore a folder without removed date commit d7131799c9f614a986400e8d9ee7830fb3d602a7 Author: Jun Kim Date: 2016-12-08T15:42:26Z Define isTrash function on notebook controller commit 25d7b8f633639b9335b7eefd22e53e7b9b8a9070 Author: Jun Kim Date: 2016-12-08T15:59:10Z Define notebook list button style commit cb84473046b40e229e5f95f00608805b676f6e06 Author: Jun Kim Date: 2016-12-08T16:03:39Z Fix stylecheck issue commit 2407844911184e6cd750d20b7ad76d5dd9c11a8e Author: Jun Kim Date: 2016-12-11T13:52:14Z Fix white space bug @marchpig addressed commit 5a33b176fc4d79fb47e033e438ed49c2c6b728dc Author: Jun Kim Date: 2016-12-11T14:07:37Z Change selenium test codes affected by chaging âremoveNoteâ button to âmoveToTrashâ commit 1381727174d38cd5103b63131bd26b2c7b2705c3 Author: Jun Kim Date: 2016-12-17T12:38:45Z Change remove permanently icons, remove folder conflict infix commit 35131b39307e25b024f86b1f71d403dbc7a69b34 Auth
[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...
Github user tae-jun closed the pull request at: https://github.com/apache/zeppelin/pull/1730 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1730 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1800: [ZEPPELIN-1855] cleanup temporary test folders ...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1800 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1803: [MINOR] fix: Initialize zeppelin var in visuali...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1803 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1802: [MINOR] fix: Validate before setting focus to p...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1802 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ZEPPELIN-1864) Improvement to show folder and note after searching note
Sora Lee created ZEPPELIN-1864: -- Summary: Improvement to show folder and note after searching note Key: ZEPPELIN-1864 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1864 Project: Zeppelin Issue Type: Improvement Reporter: Sora Lee Assignee: Sora Lee After searching note in Zeppelin Home, every note is shown by the form [FolderName/NoteName]. It would be nice to show folder icon and note icon separately. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1736 @Leemoonsoo I fixed the problem regarding not aligned text. Could you test and check again, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1736: [ZEPPELIN-1757] Menu of paragraph includes keyb...
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/1736 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1736: [ZEPPELIN-1757] Menu of paragraph includes keyb...
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/1736 [ZEPPELIN-1757] Menu of paragraph includes keyboard shortcut ### What is this PR for? Currently, keyboard shortcuts can be only seen by keyboard icon. It'll be very comfortable if keyboard shortcuts are showing the menu of paragraph. ### What type of PR is it? [Improvement] ### Todos - [x] Add the keyboard shortcut of Link this paragraph - [x] Update CI(Selelium) Test case ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1757 ### How should this be tested? Click to paragraph menu. I tested on Ubuntu. ### Screenshots (if appropriate) [before] ![screenshot from 2016-12-08 14-52-35](https://cloud.githubusercontent.com/assets/8110458/20999795/77b93d78-bd5a-11e6-9d15-0ea1995c2cf5.png) [after] ![image](https://cloud.githubusercontent.com/assets/8110458/21339558/a759e6e6-c6c3-11e6-920f-ebd264a60f0d.png) ![z1736](https://cloud.githubusercontent.com/assets/8110458/21339628/25222340-c6c4-11e6-824e-7ef059b90eb9.gif) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin ZEPPELIN-1757 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1736.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1736 commit 9ee5cc9f72f381be02d08b1cef02195b8156cfad Author: soralee Date: 2016-12-08T06:17:20Z [ZEPPELIN-1757] Menu of paragraph includes keyboard shortcut commit e5b6cc0f892678451dc0ddecff5fc642480ffe8c Author: soralee Date: 2016-12-08T06:19:57Z [ZEPPELIN-1757] Menu of paragraph includes keyboard shortcut commit 0b54bfdad92ff7e432602d14b496b41a2db001ac Author: soralee Date: 2016-12-13T06:37:36Z [ZEPPELIN-1757] changed CI test commit a8332886dfe90d01e4b2871d7685518b527175a0 Author: soralee Date: 2016-12-13T07:27:26Z [ZEPPELIN-1757] changed CI test commit 76c75b0ff2aec591fc6bae97a176bd1c8a86b35e Author: soralee Date: 2016-12-13T08:23:03Z [ZEPPELIN-1757] changed selenium CI test commit ff96071ec765c94ca1cdd213b47abe8207baa10c Author: soralee Date: 2016-12-13T09:08:19Z [ZEPPELIN-1757] changed selenium CI test commit b34a5b551beb0d332e6036caadbc7a8ba9b12a8b Author: soralee Date: 2016-12-13T11:29:39Z [ZEPPELIN-1757] changed selenium CI test commit cc84b08257f4123d241ff34a664e454c48fbaa8f Author: soralee Date: 2016-12-20T05:01:32Z [ZEPPELIN-1757] add shortcut key to tooltip and Link this paragraph commit cdd34ef7cbdfef810623b92a2e3192315092447a Author: soralee Date: 2016-12-20T07:42:16Z [ZEPPELIN-1757] update Selelium Test case commit 5b84f23ecef0dabff0aaf4da78580f620f83ef04 Author: soralee Date: 2016-12-27T06:07:59Z for aligned shortcut key text --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1806: [HOTFIX] [ZEPPELIN-1863] Travis Selenium CI fai...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1806 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1806: [HOTFIX] [ZEPPELIN-1863] Travis Selenium CI fail
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1806 @soralee CI is green now. Thanks for the quick fix! Merge into master as a hotfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1807: ZEPPELIN-1861 Support custom interpreter.sh script to ...
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1807 I have tested md for this new way but I didn't add that code because I didn't think it's good to add that example. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1807: ZEPPELIN-1861 Support custom interpreter.sh scr...
GitHub user jongyoul opened a pull request: https://github.com/apache/zeppelin/pull/1807 ZEPPELIN-1861 Support custom interpreter.sh script to run interpreter ### What is this PR for? Supporting custom interpreter.sh for an individual interpreter. Some interpreters doesn't need current complicated interpreter.sh and want to use custom RemoteInterpreterServer class to launch their interpreters. ### What type of PR is it? [Feature] ### Todos * [x] - Add new way to be able to run custom interpreter.sh ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1861 ### How should this be tested? Users can add ``` "runner": { "linux": "interpreter.sh", "win": "interpreter.cmd" } ``` in their interpreter-setting.json. This path is relative from `${INTERPRETER_DIR}/${INTERPRETER_NAME}` ### Screenshots (if appropriate) N/A ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-1861 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1807.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1807 commit dc8f74bf0c1a5b8560f35384796b7918345e0316 Author: Jongyoul Lee Date: 2016-12-27T08:06:58Z Added InterpreterRunner class for supporting custom runner path --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1806: [ZEPPELIN-1863] Travis Selenium CI fail
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/1806 [ZEPPELIN-1863] Travis Selenium CI fail ### What is this PR for? Currently, the Selenium CI test of Travis regarding every PR is failing. I think because it is after merging #1777 PR. Here is error log. ``` Caused by: org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"(//div[@ng-controller=\"ParagraphCtrl\"])[2]//div[@class=\"control ng-scope\"]//ul[@class=\"dropdown-menu\"]/li[1]"} Results : Tests in error: ZeppelinIT.testAngularRunParagraph:291 » NoSuchElement Unable to locate elemen... ``` ### What type of PR is it? [Bug Fix | Hot Fix] ### Todos * [ ] fix code regarding this problem ( I think there will be another problem except this error. ) ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1863 ### How should this be tested? - None ### Screenshots (if appropriate) - None ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin ZEPPELIN-1863 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1806.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1806 commit b7a8c0797f364a96bfe802e1bfe2fc11a3c5892d Author: soralee Date: 2016-12-27T07:42:20Z travis CI fail for ZeppelinIT.testAngularRunParagraph:291 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---