[GitHub] zeppelin issue #2240: ZEPPELIN-2386. Add parameter for check running current...
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2240
@Leemoonsoo Thanks for suggestion, the second approach works, but I didn't
find a way to take `InterpreterContext` automatically. Another scenario is that
user may do need to run the current paragraph. In the following code, I want to
rerun the current paragraph if user click the link.
```
println("%angular BindingTest_{{myVar}}_")
z.angularBind("myVar", 0)
z.angularWatch("myVar", "watcher_1", (before:Object, after:Object,
context:org.apache.zeppelin.interpreter.InterpreterContext)=>{
z.run("20170410-172601_2116783047")
})
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2250: [WIP][ZEPPELIN-2085] Interpret scala code in pa...
GitHub user DrIgor opened a pull request: https://github.com/apache/zeppelin/pull/2250 [WIP][ZEPPELIN-2085] Interpret scala code in paste mode ### What is this PR for? Don't split scala code to lines. Interpreter code becomes more and more complicated because some lines have to be executed together (companion objects, etc.). And still it doesn't handle all possibilities. I propose not to split interpreter input at all. I checked scala repl sources: repl paste mode interpret code without splitting. ### What type of PR is it? [Bug Fix | Improvement] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2085 ### How should this be tested? Try to run several code snippets attached to jira issue. See also https://issues.apache.org/jira/browse/ZEPPELIN-658 ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-2085 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2250.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2250 commit 8c4232439c6adad456520798f1d838f134ef310f Author: Igor Drozdov Date: 2017-03-20T14:16:22Z Interpret scala code as a single piece --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2223: [ZEPPELIN-2355] Livy cancel enhancements
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2223 Thanks @benoyantony will merge it if no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2250: [WIP][ZEPPELIN-2085] Interpret scala code in paste mod...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2250 Using paste mode would be better. We have so many if-else code to manipulate code which is already covered by paste mode. If we evaluate using paste mode, evaluation orders will be affected. If it doesn't matter or not that important, i think it's ok to use paste mode. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl+L' keyboard shortc...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2248 I added `command+L` and changed `Alt` and `Option` feature to flexibly remove some binding shortcut key. And, I updated the document as your comment. Could you review again @1ambda ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2133: [ZEPPELIN-1357,1892,1370][Umbrella] Text overlap in th...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2133 @Leemoonsoo Thanks for review! Right! Label would be better :+1: Let me update again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2251: [ZEPPELIN-2403] added interpreter property type...
GitHub user tinkoff-dwh opened a pull request: https://github.com/apache/zeppelin/pull/2251 [ZEPPELIN-2403] added interpreter property types ### What is this PR for? Added types to properties of interpreters. Those are types for properties customization. Properties must have the ability to customize the display (for example password). ### What type of PR is it? Feature ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2403 ### How should this be tested? Try new form (create, edit) of interpreter settings ### Screenshots (if appropriate) add  edit  view  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2403 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2251.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2251 commit 45f5f6276d731084b3873cb1885f684ab1449e68 Author: Tinkoff DWH Date: 2017-04-14T07:44:29Z ZEPPELIN-2403 added interpreter property types --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2252: [ZEPPELIN-1940] lint rule set is NOT applied at...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2252 [ZEPPELIN-1940] lint rule set is NOT applied at all. ### What is this PR for? eslint ruleset is NOT applied at all due to invalid `.eslintrc`. This PR includes - fixes which is automatically done by eslint (`eslint --fix src`) - modification in `.eslintrc`, `package.json` - while removing eslint conf in `gruntfile.js` As a result of this PR, we can have more strict and modernized rulesets which can help us to prevent bugs. ### What type of PR is it? [Improvement] ### Todos * [x] - Setup rules * [x] - Remove grunt eslint config * [x] - Ignore useless rules * [x] - Fix code for applied rules ### What is the Jira issue? [ZEPPELIN-1940](https://issues.apache.org/jira/browse/ZEPPELIN-1940) ### How should this be tested? - `cd zeppelin-web` - `npm run lint:once` ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-1940/apply-lint-rule-set Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2252.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2252 commit fcf7569c0b3eb2bbccb33ce531cee33e8ffdd950 Author: 1ambda <1am...@gmail.com> Date: 2017-04-14T00:40:25Z fix: Use eslint instead of grunt-eslint commit 1ee0af31976c2d104fedb9c00345ea0201a6eda1 Author: 1ambda <1am...@gmail.com> Date: 2017-04-14T00:40:51Z fix: Remove invalid visdev commit ff30ff0864c6dae7eff21f959b084176a6f6ac21 Author: 1ambda <1am...@gmail.com> Date: 2017-04-14T15:08:06Z fix: Set ignored, warn lint rules commit 2d80425af198beab28754e57cc467a9aed0e2818 Author: 1ambda <1am...@gmail.com> Date: 2017-04-14T15:19:51Z fix: ignore all rules commit 065801aad09160e69f12ea21ed3f449898b2beb5 Author: 1ambda <1am...@gmail.com> Date: 2017-04-14T15:24:15Z fix: yoda ``` /Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/handsontable/handsonHelper.js 160:49 error Expected literal to be on the right side of === yoda ``` commit 1f1862f74f41a981dbc5ec805dc690b9c993f7b9 Author: 1ambda <1am...@gmail.com> Date: 2017-04-14T15:25:44Z fix: no-mixed-spaces-and-tabs ``` /Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/builtins/visualization-piechart.js (3/0) â 79:2 Mixed spaces and tabs no-mixed-spaces-and-tabs â 80:2 Mixed spaces and tabs no-mixed-spaces-and-tabs â 81:2 Mixed spaces and tabs no-mixed-spaces-and-tabs ``` commit 139b28d96883b4056df8fce3a5ddd979900fae4e Author: 1ambda <1am...@gmail.com> Date: 2017-04-14T15:27:18Z fix: semi-spacing ``` /Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/search/result-list.controller.js (1/0) â 20:26 Unexpected whitespace before semicolon semi-spacing ``` commit deb679cd282db0e40c488a0ae2c31a5dca37f77c Author: 1ambda <1am...@gmail.com> Date: 2017-04-14T15:31:05Z fix: no-extra-boolean-cast ``` /Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/app.js (1/0) â 40:12 Redundant double negation no-extra-boolean-cast /Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/jobmanager/jobs/job.controller.js (2/0) â 58:18 Redundant double negation no-extra-boolean-cast â 90:18 Redundant double negation no-extra-boolean-cast ``` commit 8b540e230802490807f1d938baa30f4a3c75c727 Author: 1ambda <1am...@gmail.com> Date: 2017-04-14T15:35:15Z fix: object-property-newline ``` /Users/1ambda/github/apache/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js (7/0) â 45:26 Object properties must go on a new line if they aren't all on the same line object-property-newline â 46:24 Object properties must go on a new line if they aren't all on the same line object-property-newline â 46:40 Object properties must go on a new line if they aren't all on the same line object-property-newline â 71:38 Object properties must go on a new line if they aren't all on the same line object-property-newline â 76:36 Object properties must go on a new line if they aren't all on the same line object-property-newline â 89:36 Object properties must go on a new li
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2252 @AhyoungRyu Could you help review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2229 From my earlier comment, I'm interested in others thought on having very Hive specific logic in the generic JDBC interpreter? https://github.com/apache/zeppelin/pull/2229/files#r110512765 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2229: [Zeppelin 2367] Hive JDBC proxy user option should be ...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2229 Yes, I thought of few options but this was bit con --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2098: [ZEPPELIN-2217] AdvancedTransformation for Visu...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2098 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2249: ZEPPELIN-2356. Improvement for z.angularBind and z.ang...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2249 @zjffdu do you mind update corresponding docs, too? `docs/displaysystem/back-end-angular.md` And front-end expose angular display system apis. Do you think this guy need to support new api, too? `docs/displaysystem/front-end-angular.md` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2252 @AhyoungRyu Could you help review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2245: ZEPPELIN-2395. Refactor Input.java to make dynamic for...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2245 Looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2228: [ZEPPELIN-2365] button to create note into fold...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2240: ZEPPELIN-2386. Add parameter for check running current...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2240 Thanks for explain. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl/command+L' keyboar...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2248 Works as described. LGTM except 2 comments I left --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ZEPPELIN-2404) Prettify Interpreter Setting
Hoon Park created ZEPPELIN-2404:
---
Summary: Prettify Interpreter Setting
Key: ZEPPELIN-2404
URL: https://issues.apache.org/jira/browse/ZEPPELIN-2404
Project: Zeppelin
Issue Type: Bug
Reporter: Hoon Park
Prettify Interpreter Setting.
- doesn't provide useful presets. For example If user wants to create JDBC, we
can provide already configured {{mysql}}, {{postgres}}, and so on. Since they
requires many fields (classname, jar, ..), it would be nice if we can provide.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[GitHub] zeppelin issue #2248: [ZEPPELIN-2396] eliminate the 'ctrl/command+L' keyboar...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2248 @1ambda I just updated it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2252 @1ambda Great work! Quickly looked through the most of file changes and it looks good. Zeppelin web is getting bigger, everyone will feel the necessity of this kind of lint rule. btw I saw the below some warning msgs when I ran `npm run lint:once`, ``` $ npm run lint:once > zeppelin-web@0.0.0 lint:once /Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web > eslint src /Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web/src/app/notebook/notebook.controller.js 52:34 warning Unnecessary escape character: \/ no-useless-escape 52:44 warning Unnecessary escape character: \/ no-useless-escape 52:59 warning Unnecessary escape character: \/ no-useless-escape 52:69 warning Unnecessary escape character: \/ no-useless-escape /Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web/src/app/visualization/builtins/visualization-nvd3chart.js 131:37 warning Unexpected mix of '&&' and '||' no-mixed-operators 131:54 warning Unexpected mix of '&&' and '||' no-mixed-operators /Users/ahyoungryu/Dev/zeppelin-development/zeppelin-test/zeppelin-web/src/components/noteListDataFactory/noteList.datafactory.js 38:40 warning Unnecessary escape character: \/ no-useless-escape 38:45 warning Unnecessary escape character: \/ no-useless-escape â 8 problems (0 errors, 8 warnings) ``` Is there any particular reason for not fixing them? If you just worried about the side effect, I think it's okay with as is :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2236: [DOC] Improve documents related to Helium
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2236 Merge into master if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2252 @AhyoungRyu Thanks for detailed review! Those things are about regex and mixed boolean condition (without parens), so I am sure i can keep the original intention. ð.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2252: [ZEPPELIN-1940] lint rule set is NOT applied at all.
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2252 @1ambda Yeah makes sense. Looks GOOD to me ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
