[GitHub] zeppelin issue #2361: [ZEPPELIN-2131] Restrict `shift + arrow` key in focuse...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2361 @1ambda could you check uploaded `before/after` image files? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2358: [ZEPPELIN-2428] Improve `create new note` dialog style
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2358 About `clone note` and `create note`, both look good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2361: [ZEPPELIN-2131] Restrict `shift + arrow` key in...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2361 [ZEPPELIN-2131] Restrict `shift + arrow` key in focused cell ### What is this PR for? Selection of text in cell by Shift-Arrow should be restricted to focussed cell. ### What type of PR is it? [Improvement] ### Todos DONE ### What is the Jira issue? [ZEPPELIN-2131](https://issues.apache.org/jira/browse/ZEPPELIN-2131) ### How should this be tested? 1. Create multiple paragraphs. 2. Move cursors using `shift + arrow` (up, down) 3. Should keep focus on the current paragraph. ### Screenshots (if appropriate) Before ![Uploading image.pngâ¦]() After ![Uploading image.pngâ¦]() ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2131/restrict-shift-arrow-in-cell Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2361.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2361 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2360: [ZEPPELIN-2574] Improve `about` dialog style
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2360 Tested and LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2360: [ZEPPELIN-2574] Improve `about` dialog style
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2360 @1ambda Thanks for improving dialog! I'll test it out! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2359: [ZEPPELIN-2575] Improve `rename note` dialog style
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2359 @1ambda I'll test it out and give you a feedback! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2358: [ZEPPELIN-2428] Improve `create new note` dialog style
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2358 @1ambda Thanks for improving dialog! I'll test it out and give you a feedback! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2357: [ZEPPELIN-2429] Improve `import notebook` dialog style
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2357 @1ambda, Sure! Nice feature! Let me test it out! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2356: [ZEPPELIN-2460] Highlight active line in editor
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2356 Awesome @1ambda I love this feature. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2360: [ZEPPELIN-2574] Improve `about` dialog style
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2360 @soralee Could you help review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2356: [ZEPPELIN-2460] Highlight active line in editor
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2356 @zjffdu Could you help review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2359: [ZEPPELIN-2575] Improve `rename note` dialog style
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2359 @soralee Could you help review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2357: [ZEPPELIN-2429] Improve `import notebook` dialog style
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2357 @soralee Could you help review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2358: [ZEPPELIN-2428] Improve `create new note` dialog style
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2358 @soralee Could you help review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2356 [ZEPPELIN-2460] Highlight active line in editor ### What is this PR for? Highlight active line. ### What type of PR is it? [Improvement] ### Todos * [x] - Added ui-ace option * [x] - Fix css for paragraph control not to be overrided by active line ### What is the Jira issue? [ZEPPELIN-2460](https://issues.apache.org/jira/browse/ZEPPELIN-2460) ### How should this be tested? 1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart` 2. Open a note and write some text. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2460/highlight-active-line Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2356.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2356 commit 6424db580c922fac03a42620340f2239d029babe Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T18:40:40Z feat: Highlight active line in editor commit dfcb8aa8d5ad0c287bd110e3b154e5ab670481d9 Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T19:01:34Z fix: Control setting CSS not to overwrite active line commit 0366948fe750478fc3c4ce946ba0e0383728fa21 Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T21:51:03Z fix: Show single active line in a note commit ade9179598fdb5ab18b8cb8c00a5edc3b4c1fdd5 Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T21:55:18Z fix: Use blue-light color for active line commit bfa2fed75ab0d74ffec4d6b9b8eb69533e91dffe Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T13:59:43Z fix: Set active line when note is created commit e60f9a2efc80a27d489f24650a71f47ffd1aee89 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T20:48:16Z feat: Display title, control in the same line commit 087942b861ce02d15190e87c389e296db25e2a41 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T22:10:01Z fix: Use ng-if for title commit 2809093dcce946d0978620c52d3b591e5514a906 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T23:14:25Z fix: xpath for select, checkbox DOM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2356 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Adding a servlet to the zeppelin project
Hi all, I am writing a custom interpreter and it renders an html page which is consisted of a html form as the result. I also have written the servlet to handle the request from that html page and added it to the WEB-INF/web.xml file. But when I trigger the action, it gives me a 404 error mentioning that it's impossible to find the relevant servlet. The servlet is contained in a module outside of the zeppelin-web app module. (inside the zeppelin project of course) Here are the entries I added to my web.xml * UploadServlet org.apache.zeppelin.cep.servlets.FileUploadServlet UploadServlet /UploadServlet* Could you please let me know how to resolve this issue? Thanks and Regards! -- *Minudika Malshan*
[GitHub] zeppelin pull request #2353: [branch-0.7] missed try catch.
Github user cloverhearts closed the pull request at: https://github.com/apache/zeppelin/pull/2353 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2353: [branch-0.7] missed try catch.
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2353 merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2317: [ZEPPELIN-2493] Visualization class should throw an er...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2317 LGTM and merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2359: [ZEPPELIN-2575] Improve `rename note` dialog st...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2359 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2359: [ZEPPELIN-2575] Improve `rename note` dialog st...
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2359 [ZEPPELIN-2575] Improve `rename note` dialog style ### What is this PR for? Improve `rename notebook` dialog style. See the attached screenshots. ### What type of PR is it? [Improvement] ### Todos DONE ### What is the Jira issue? [ZEPPELIN-2575](https://issues.apache.org/jira/browse/ZEPPELIN-2575) ### How should this be tested? 1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart` 2. Run Zeppelin and open browser: `localhost:8080` 3. `rename notebook` functionality should work as like before. ### Screenshots (if appropriate) Before  After  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin improve-rename-dialog Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2359.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2359 commit ff9721aefd053455e9a7fb863e949d53a7df8734 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T02:32:39Z style: Reformat html commit d310174c11dd24745ff30e448136f373588df921 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T02:39:48Z feat: Style rename dialog body commit 0fa0caad806b39f514ebcd5f63a83a03c663d7e9 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T07:43:01Z fix: RAT issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2358: [ZEPPELIN-2428] Improve `create new note` dialo...
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2358 [ZEPPELIN-2428] Improve `create new note` dialog style ### What is this PR for? Improve `create new notebook` dialog style. See the attached screenshots. ### What type of PR is it? [Improvement] ### Todos DONE ### What is the Jira issue? [ZEPPELIN-2428](https://issues.apache.org/jira/browse/ZEPPELIN-2428) ### How should this be tested? 1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart` 2. Run Zeppelin and open browser: `localhost:8080` 3. `create new notebook` functionality should work as like before. ### Screenshots (if appropriate) Before   After   ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin improve-create-note-dialog Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2358.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2358 commit dddb5d9ef5371c299c6c8fa62fd2eeaef4cc401a Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T00:45:07Z style: Reformat note-name-dialog.html commit abe90c6744563f6c362ffe182970505941071663 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T01:04:43Z feat: Style modal-header commit 774c99eb0b7c342021823690a5d0e07868c1f5f5 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T01:11:12Z feat: style modal-footer for note name dialog commit c97d68feec2613653e8127745ed323509f671dd9 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T01:59:45Z refactor: format note-name-dialog commit d6f78d90caa79bb901b50e49b514a541821fa52b Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T02:07:49Z feat: label style for note name dialog commit 21fa982405b775384055697504dbbac7ed87ad18 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T02:15:08Z feat: Style panel desc commit 71ed709cc1d6fb72b51d3310f5eb7f5e5cf06e27 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T02:23:00Z feat: Style note name dialog modal-body commit c4981a996a4c61f90525c093b33b21e97a815dc4 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T07:42:32Z fix: RAT issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2358: [ZEPPELIN-2428] Improve `create new note` dialo...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2358 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2341: ZEPPELIN-2543: Add ability to change the log level at ...
Github user karuppayya commented on the issue: https://github.com/apache/zeppelin/pull/2341 @1ambda Thanks for the feedback. I had added API to Zeppelin rest API name space. Let me know if that is fine Also adding documentation was in my TODO list, done now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2317: [ZEPPELIN-2493] Visualization class should throw an er...
Github user tae-jun commented on the issue: https://github.com/apache/zeppelin/pull/2317 @1ambda Thanks for the review! ð I didn't know that you asked me to add a test ð¢ Was it added after the editing? But, since you said it is not necessary, I will just leave this PR ð Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2227: [ZEPPELIN-2359] Support Spell as Display
Github user echarles commented on the issue: https://github.com/apache/zeppelin/pull/2227 @1ambda I have added the log. Regarding you second comment, I am not sure what you mean. Is there something I should change? Is it not working as expected? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2317: [ZEPPELIN-2493] Visualization class should throw an er...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2317 Mostly about documentation. Not necessary to write a new test. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2341: ZEPPELIN-2543: Add ability to change the log level at ...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2341 IMO, we can add documentation for this API in http://zeppelin.apache.org/docs/0.7.1/rest-api/rest-configuration.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2356 [ZEPPELIN-2460] Highlight active line in editor ### What is this PR for? Highlight active line. ### What type of PR is it? [Improvement] ### Todos * [x] - Added ui-ace option * [x] - Fix css for paragraph control not to be overrided by active line ### What is the Jira issue? [ZEPPELIN-2460](https://issues.apache.org/jira/browse/ZEPPELIN-2460) ### How should this be tested? 1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart` 2. Open a note and write some text. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2460/highlight-active-line Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2356.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2356 commit 6424db580c922fac03a42620340f2239d029babe Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T18:40:40Z feat: Highlight active line in editor commit dfcb8aa8d5ad0c287bd110e3b154e5ab670481d9 Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T19:01:34Z fix: Control setting CSS not to overwrite active line commit 0366948fe750478fc3c4ce946ba0e0383728fa21 Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T21:51:03Z fix: Show single active line in a note commit ade9179598fdb5ab18b8cb8c00a5edc3b4c1fdd5 Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T21:55:18Z fix: Use blue-light color for active line --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2356 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2360: Improve about dialgo
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2360 Improve about dialgo ### What is this PR for? Improve `about` dialog style. See the attached screenshots. ### What type of PR is it? [Improvement] ### Todos DONE ### What is the Jira issue? [ZEPPELIN-2574](https://issues.apache.org/jira/browse/ZEPPELIN-2574) ### How should this be tested? 1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart` 2. Run Zeppelin and open browser: `localhost:8080` 3. Click the `About Zeppelin` button  ### Screenshots (if appropriate) Before  After  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin improve-about-dialgo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2360.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2360 commit 03619186b6c3518798d51aeb1318c5dfb978e499 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T00:10:05Z refactor: Move about related css into navbar.css commit 5dfc3bd473e3b53ace0b9457e13cbf47d0105154 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T00:31:42Z feat: style about dialog --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2359: [ZEPPELIN-2575] Improve `rename note` dialog st...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2359 [ZEPPELIN-2575] Improve `rename note` dialog style ### What is this PR for? Improve `rename notebook` dialog style. See the attached screenshots. ### What type of PR is it? [Improvement] ### Todos DONE ### What is the Jira issue? [ZEPPELIN-2575](https://issues.apache.org/jira/browse/ZEPPELIN-2575) ### How should this be tested? 1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart` 2. Run Zeppelin and open browser: `localhost:8080` 3. `rename notebook` functionality should work as like before. ### Screenshots (if appropriate) Before  After  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin improve-rename-dialog Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2359.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2359 commit ff9721aefd053455e9a7fb863e949d53a7df8734 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T02:32:39Z style: Reformat html commit d310174c11dd24745ff30e448136f373588df921 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T02:39:48Z feat: Style rename dialog body --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2358: [ZEPPELIN-2428] Improve `create new note` dialo...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2358 [ZEPPELIN-2428] Improve `create new note` dialog style ### What is this PR for? Improve `create new notebook` dialog style. See the attached screenshots. ### What type of PR is it? [Improvement] ### Todos DONE ### What is the Jira issue? [ZEPPELIN-2428](https://issues.apache.org/jira/browse/ZEPPELIN-2428) ### How should this be tested? 1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart` 2. Run Zeppelin and open browser: `localhost:8080` 3. `create new notebook` functionality should work as like before. ### Screenshots (if appropriate) Before After  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin improve-create-note-dialog Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2358.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2358 commit dddb5d9ef5371c299c6c8fa62fd2eeaef4cc401a Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T00:45:07Z style: Reformat note-name-dialog.html commit abe90c6744563f6c362ffe182970505941071663 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T01:04:43Z feat: Style modal-header commit 774c99eb0b7c342021823690a5d0e07868c1f5f5 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T01:11:12Z feat: style modal-footer for note name dialog commit c97d68feec2613653e8127745ed323509f671dd9 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T01:59:45Z refactor: format note-name-dialog commit d6f78d90caa79bb901b50e49b514a541821fa52b Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T02:07:49Z feat: label style for note name dialog commit 21fa982405b775384055697504dbbac7ed87ad18 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T02:15:08Z feat: Style panel desc commit 71ed709cc1d6fb72b51d3310f5eb7f5e5cf06e27 Author: 1ambda <1am...@gmail.com> Date: 2017-05-21T02:23:00Z feat: Style note name dialog modal-body --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ZEPPELIN-2574) Improve About Dialog Style
Hoon Park created ZEPPELIN-2574: --- Summary: Improve About Dialog Style Key: ZEPPELIN-2574 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2574 Project: Zeppelin Issue Type: Improvement Components: front-end Reporter: Hoon Park Improve About Dialog Style. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (ZEPPELIN-2575) Improve Rename Dialog Style
Hoon Park created ZEPPELIN-2575: --- Summary: Improve Rename Dialog Style Key: ZEPPELIN-2575 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2575 Project: Zeppelin Issue Type: Improvement Components: front-end Reporter: Hoon Park Improve Rename Dialog Style -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2356 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2356: [ZEPPELIN-2460] Highlight active line in editor
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2356 [ZEPPELIN-2460] Highlight active line in editor ### What is this PR for? Highlight active line. ### What type of PR is it? [Improvement] ### Todos * [x] - Added ui-ace option * [x] - Fix css for paragraph control not to be overrided by active line ### What is the Jira issue? [ZEPPELIN-2460](https://issues.apache.org/jira/browse/ZEPPELIN-2460) ### How should this be tested? 1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart` 2. Open a note and write some text. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2460/highlight-active-line Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2356.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2356 commit 6424db580c922fac03a42620340f2239d029babe Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T18:40:40Z feat: Highlight active line in editor commit dfcb8aa8d5ad0c287bd110e3b154e5ab670481d9 Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T19:01:34Z fix: Control setting CSS not to overwrite active line commit 0366948fe750478fc3c4ce946ba0e0383728fa21 Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T21:51:03Z fix: Show single active line in a note commit ade9179598fdb5ab18b8cb8c00a5edc3b4c1fdd5 Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T21:55:18Z fix: Use blue-light color for active line --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
