[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-06 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/3092
  
so we need to open a JIRA then?


---


[GitHub] zeppelin issue #3054: ZEPPELIN-3569. Improvement of FlinkInterpreter

2018-08-06 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/3054
  
this comment? 
https://github.com/apache/zeppelin/pull/3054#discussion_r200825969
it's in every file touched



---


[GitHub] zeppelin issue #3114: Update org.eclipse.jetty version to 9.4.11.v20180605 t...

2018-08-06 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/3114
  
@zjffdu @felixcheung  can you help review this.


---


[GitHub] zeppelin pull request #3114: Update org.eclipse.jetty version to 9.4.11.v201...

2018-08-06 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/3114

Update org.eclipse.jetty version to 9.4.11.v20180605 to avoid CVE issues

### What is this PR for?
Update org.eclipse.jetty version to 9.4.11.v20180605 to avoid CVE issues.

See https://dev.eclipse.org/mhonarc/lists/jetty-announce/msg00123.html for 
reported issues.


### What type of PR is it?
[Improvement]


### What is the Jira issue?
* [ZEPPELIN-3686](https://issues.apache.org/jira/browse/ZEPPELIN-3686)

### How should this be tested?
* CI should be green

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3686

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3114


commit 2c25a9a33aa6fd0660ea88312463e7282ec0
Author: Prabhjyot Singh 
Date:   2018-08-07T04:31:32Z

ZEPPELIN-3686: Update org.eclipse.jetty version to 9.4.11.v20180605 to 
avoid CVE issues

Change-Id: I78ab4fc3269173e0261de3211f46c885a533fefe




---


[jira] [Created] (ZEPPELIN-3686) Update org.eclipse.jetty version to 9.4.11.v20180605 to avoid CVE issues

2018-08-06 Thread Prabhjyot Singh (JIRA)
Prabhjyot Singh created ZEPPELIN-3686:
-

 Summary: Update org.eclipse.jetty version to 9.4.11.v20180605 to 
avoid CVE issues
 Key: ZEPPELIN-3686
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3686
 Project: Zeppelin
  Issue Type: Bug
Reporter: Prabhjyot Singh
Assignee: Prabhjyot Singh


Update org.eclipse.jetty version to 9.4.11.v20180605 to avoid CVE issues.

See https://dev.eclipse.org/mhonarc/lists/jetty-announce/msg00123.html for 
reported issues.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-06 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3092
  
Thanks @selvinsource for the investigation, the analysis seems correct to 
me. 


---


[GitHub] zeppelin issue #3054: ZEPPELIN-3569. Improvement of FlinkInterpreter

2018-08-06 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3054
  
CI pass, will merge if no more comments 


---


[GitHub] zeppelin issue #3111: [ZEPPELIN-3684] Remove cron job in ZeppelinRestApiTest...

2018-08-06 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3111
  
@egorklimov Did you configure travis ? 


---


[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-06 Thread selvinsource
Github user selvinsource commented on the issue:

https://github.com/apache/zeppelin/pull/3092
  
Found something that could cause the issue.
in beam/pom.xml there is
```2.0.0```

then 
 ``` 
beam-runners-flink_${scala.binary.version}```

But looking at
https://mvnrepository.com/artifact/org.apache.beam/beam-runners-flink
there isn't a beam-runners-flink_2_10 for beam version 2.0.0.

So even in Zeppelin 0.8.0 if you try to switch to scala 2.11 and run 
install -DskipTests -Pbeam you will get an error but perhaps that's something 
nobody ever tried (to compile beam on 2.11).

However after removing all profiles, that's the case now and a solution is 
needed.

Either the beam version is updated or the beam-runners flink can be 2_10 
even for scala 2.11.


@zjffdu what do you think about my analysis? Am I making sense?



---


[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-06 Thread selvinsource
Github user selvinsource commented on the issue:

https://github.com/apache/zeppelin/pull/3092
  
@zjffdu @mebelousov I sent you a comment before, please ignore, I thought 
that scio was only built for 2.10 but I noticed that changing scala version 
using the script does update the pom for scio to 2.11.

I still think is somehow related to 
https://issues.apache.org/jira/browse/ZEPPELIN-3557 as before people wouldn't 
build using profiles by default so there may be some issue uncovered now that 
all interpreters are built all the times.

In this PR I only changed beam/pom.xml to have a dependency on java 
interpreter, nothing was changed related to scio or scala versions.

Will investigate further but it would be good to know which options 
@mebelousov is using to build to re-create locally.



---


[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-06 Thread selvinsource
Github user selvinsource commented on the issue:

https://github.com/apache/zeppelin/pull/3092
  
@zjffdu 
the issue reported by @mebelousov may have been caused by 
https://issues.apache.org/jira/browse/ZEPPELIN-3557
and not this PR, as I only added in the beam interpreter the dependency on 
the java interpreter.

If you look at scio/pom.xml it has
```
  org.apache.zeppelin
  zeppelin-scio_2.10
  jar
  0.9.0-SNAPSHOT
  Zeppelin: Scio
  Zeppelin Scio support
```
So maven will always only build the 2.10 version for scio.

At the same time the beam/pom.xml
has dependency to
```
 
  org.apache.zeppelin
  zeppelin-scio_${scala.binary.version}
  ${project.version}

```
which do not exists for scala 2.11.

So the solution is either that scio is also built for 2.11 or beam to 
reference 2.10 no matter what the scala version is.

I think you never noticed it before because the beam interpreter was "opt 
in" so perhaps nobody noticed this as they only ever built the beam interpreter 
(-Pbeam) with scala 2.10 and not 2.11.

But now that all profiles have been removed as per ZEPPELIN-3557, the beam 
interpreter needs the correct scio version.



---


[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-06 Thread selvinsource
Github user selvinsource commented on the issue:

https://github.com/apache/zeppelin/pull/3092
  
@mebelousov 

If you see
https://travis-ci.org/selvinsource/zeppelin/builds/411153675
it seems fine with SCALA_VER="2.11".

What options are you running maven build with after the change of scala 
version? I could try to re-create in dev environment.



---


[GitHub] zeppelin issue #3107: [ZEPPELIN-3646] Add note for updating user permissions

2018-08-06 Thread egorklimov
Github user egorklimov commented on the issue:

https://github.com/apache/zeppelin/pull/3107
  
@felixcheung On other hand, risk of showing all notes may be greater, 
therefore I think that we should add this workaround, because everyone who is 
upgrading from any version less than 0.8.x will be faced with this problem, 
maybe instead of adding this note we could just add python script to project, 
but IMHO note is better.


---


[jira] [Created] (ZEPPELIN-3685) Graphs drawn incorrectly

2018-08-06 Thread Michael Williams (JIRA)
Michael Williams created ZEPPELIN-3685:
--

 Summary: Graphs drawn incorrectly
 Key: ZEPPELIN-3685
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3685
 Project: Zeppelin
  Issue Type: Bug
  Components: Interpreters
Affects Versions: 0.8.0
Reporter: Michael Williams
 Attachments: fig1.png, fig2.png, fig3.png

When plotting data, either using the Table display mode or the SQL interpreter, 
strange results sometimes occur.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] zeppelin pull request #3081: ZEPPELIN-3575. Add 'Copy Column Name' button in...

2018-08-06 Thread mebelousov
Github user mebelousov closed the pull request at:

https://github.com/apache/zeppelin/pull/3081


---


[GitHub] zeppelin issue #3081: ZEPPELIN-3575. Add 'Copy Column Name' button in visual...

2018-08-06 Thread mebelousov
Github user mebelousov commented on the issue:

https://github.com/apache/zeppelin/pull/3081
  
Will try to revert with tests.


---


[GitHub] zeppelin pull request #3113: [ZEPPELIN-3616] fix editor sections auto-collap...

2018-08-06 Thread Savalek
GitHub user Savalek opened a pull request:

https://github.com/apache/zeppelin/pull/3113

[ZEPPELIN-3616] fix editor sections auto-collapse

# Description
This PR change logic of add new event listener on frontend. Now then add 
new event listener, also added destroy listener. Destroy listener attach to 
some DOM element and then this element destroyed listener drop event listener. 
Since the old listeners were not deleted when changing the size of the 
paragraph / window, an error occurred. Because of this error, updating the text 
in the paragraph did not happen until the end.

## Info
 PR type: `Bug Fix` |  Jira issue: 
[`ZEPPELIN-3616`](https://issues.apache.org/jira/browse/ZEPPELIN-3616)

## Screenshots
### List of all resize event (after some time of work)
before (77 lis.)


![before](https://user-images.githubusercontent.com/30798933/43723409-421e44a0-99a0-11e8-8945-5d52e275ed02.png)

after (16 lis.)


![after](https://user-images.githubusercontent.com/30798933/43723425-4ce02a3e-99a0-11e8-96ee-59ac177945d4.png)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3616

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3113


commit a07b59e081fbf1d21cb3795c7e01f67e7b38daa7
Author: Savalek 
Date:   2018-08-06T13:29:22Z

[ZEPPELIN-3616] remove event if dom's element destroy




---


[GitHub] zeppelin pull request #3112: Branch 0.8

2018-08-06 Thread GioCorti80
GitHub user GioCorti80 opened a pull request:

https://github.com/apache/zeppelin/pull/3112

Branch 0.8

### What is this PR for?
Problem on command: docker pull apache/zeppelin


### What type of PR is it?
[Bug]
i receive this error: "Error response from daemon: manifest for 
apache/zeppelin:latest not found"

### Todos
* [ ] - Task

### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. 
[ZEPPELIN-533]

### How should this be tested?
* First time? Setup Travis CI as described on 
https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed 
behavior
* Outline any manual steps to test the PR here.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/zeppelin branch-0.8

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3112


commit 8219a37302aa81487d3ddfa6f10699e0a1657e4b
Author: mebelousov 
Date:   2018-01-23T12:39:00Z

[ZEPPELIN-3187] Remove doubles of settings in zeppelin-site.xml.template

### What is this PR for?
Remove doubles in zeppelin-site.xml.template

### What type of PR is it?
[Bug Fix ]

### What is the Jira issue?
* [ZEPPELIN-3187]

### How should this be tested?
* No need

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A

Author: mebelousov 

Closes #2741 from mebelousov/ZEPPELIN-3187 and squashes the following 
commits:

44d6d08 [mebelousov] Remove doubles of settings

(cherry picked from commit 08251226203107303785ffde458b074d47b13a6f)
Signed-off-by: Jeff Zhang 

commit 61d67a95a3f06a96c75a555be47704f49111e7a4
Author: Prabhjyot Singh 
Date:   2018-01-23T12:43:23Z

[ZEPPELIN-3185] Add profiles for adding dependencies for Hive and Phoenix

### What is this PR for?
This PR adds profiles for adding dependencies for Hive and Phoenix

### What type of PR is it?
[Improvement]

### What is the Jira issue?
* [ZEPPELIN-3185](https://issues.apache.org/jira/browse/ZEPPELIN-3185)

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?

Author: Prabhjyot Singh 

Closes #2740 from prabhjyotsingh/ZEPPELIN-3185 and squashes the following 
commits:

47dd05e [Prabhjyot Singh] append "jdbc-" to all the profiles
99eafde [Prabhjyot Singh] add profile for adding dependencies for hive and 
phoenix

(cherry picked from commit ed1947bb062472b999a722238a9c250f11894e54)
Signed-off-by: Prabhjyot Singh 

commit 68bf5f8058f5f5a625c21935c97d449a56acef84
Author: Nelson Costa 
Date:   2018-01-24T15:46:14Z

[ZEPPELIN-3189] NPE on paragraph run via API

### What is this PR for?
Bugfix over NPE when running REST API command to run paragraph 
synchronously.

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3189

### How should this be tested?
1. Build Zep (mvn clean package -DskipTests)
2. Start Zep
3. Run curl command in shell (curl -i -X POST 
http://localhost:8080/api/notebook/run/{noteId}/{paragraphId}

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N

Author: Nelson Costa 

Closes #2745 from necosta/zeppelin3189 and squashes the following commits:

9d1e2a569 [Nelson Costa] [ZEPPELIN-3189] NPE on paragraph run via API

(cherry picked from commit e7e9e19cf1be6ada5b5e8d56fc2a7d8809f85f79)
Signed-off-by: Lee moon soo 

commit ca87f7d4cc489a492772bbe85705c6a1826cc31a
Author: Jeff Zhang 
Date:   2017-07-17T05:02:09Z

ZEPPELIN-3111. Refactor SparkInterpreter

This is for the refactoring of SparkInterpreter. See design doc. 
https://docs.google.com/document/d/1AfGg3aGXonDyri1jrP4MMFT4Y4j3wpN1t8kL-GAKSUc/edit?usp=sharing

[Refactoring]

* [ ] - Task

* https://issues.apache.org/jira/browse/ZEPPELIN-3111

* 

[GitHub] zeppelin pull request #3111: testCronDisable fixed

2018-08-06 Thread egorklimov
GitHub user egorklimov opened a pull request:

https://github.com/apache/zeppelin/pull/3111

testCronDisable fixed

### What is this PR for?
`testCronDisable` in `ZeppelinRestApiTest` produce error:
```
09:15:51,001 ERROR org.quartz.core.ErrorLogger:2425 - Job (note.2DPJCQJGP 
threw an exception.
org.quartz.SchedulerException: Job threw an unhandled exception. [See 
nested exception: java.lang.NullPointerException]
at org.quartz.core.JobRunShell.run(JobRunShell.java:213)
at 
org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:573)
Caused by: java.lang.NullPointerException
at 
org.apache.zeppelin.notebook.Notebook$CronJob.execute(Notebook.java:925)
at org.quartz.core.JobRunShell.run(JobRunShell.java:202)
... 1 more
```
Because cron job is not removed

### What type of PR is it?
Bug Fix

### What is the Jira issue?
* issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-3684

### How should this be tested?
* Tested manually
* CI pass

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3684

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3111.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3111


commit 5abd8fbec740f9f6ba1ec060c44eba60098075a4
Author: egorklimov 
Date:   2018-08-06T11:39:25Z

testCronDisable fixed




---


[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

2018-08-06 Thread mebelousov
Github user mebelousov commented on the issue:

https://github.com/apache/zeppelin/pull/3092
  
Seems this PR broke build for scala 2.11

After execution of ` ./dev/change_scala_version.sh 2.11` I have got error 
```
[ERROR] Failed to execute goal on project zeppelin-beam: Could not resolve 
dependencies for project org.apache.zeppelin:zeppelin-beam:jar:0.9.0-SNAPSHOT: 
Could not find artifact 
org.apache.zeppelin:zeppelin-scio_2.10:jar:0.9.0-SNAPSHOT in apache.snapshots 
(http://repository.apache.org/snapshots) -> [Help 1]```

@selvinsource could check maven build?


---


[jira] [Created] (ZEPPELIN-3684) Remove cron job in ZeppelinRestApiTest.testCronDisable

2018-08-06 Thread George Klimov (JIRA)
George Klimov created ZEPPELIN-3684:
---

 Summary: Remove cron job in ZeppelinRestApiTest.testCronDisable
 Key: ZEPPELIN-3684
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3684
 Project: Zeppelin
  Issue Type: Improvement
  Components: zeppelin-server
Reporter: George Klimov
Assignee: George Klimov


{{testCronDisable}} in {{ZeppelinRestApiTest}} produce error:
{noformat}
09:15:51,001 ERROR org.quartz.core.ErrorLogger:2425 - Job (note.2DPJCQJGP threw 
an exception.
org.quartz.SchedulerException: Job threw an unhandled exception. [See nested 
exception: java.lang.NullPointerException]
at org.quartz.core.JobRunShell.run(JobRunShell.java:213)
at 
org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:573)
Caused by: java.lang.NullPointerException
at 
org.apache.zeppelin.notebook.Notebook$CronJob.execute(Notebook.java:925)
at org.quartz.core.JobRunShell.run(JobRunShell.java:202)
... 1 more
{noformat}
Because cron job is not removed



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)