[GitHub] [zeppelin] alexott commented on issue #3465: [ZEPPELIN-4355] Fix broken tests in master branch

[GitBox]

alexott commented on issue #3465: [ZEPPELIN-4355] Fix broken tests in master 
branch
URL: https://github.com/apache/zeppelin/pull/3465#issuecomment-536268689
 
 
   Maybe it makes sense to split fixes by JIRA?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[ANNOUNCE] Apache Zeppelin 0.8.2 released

[Jeff Zhang]

The Apache Zeppelin community is pleased to announce the availability of
the 0.8.2 release.

Zeppelin is a collaborative data analytics and visualization tool for
distributed, general-purpose data processing system such as Apache Spark,
Apache Flink, etc.

This is another minor release after the last minor release 0.8.1
The community put significant effort into improving Apache Zeppelin
since the last release. 26 patches for improvements and bug fixes.

We encourage you to download the latest release
fromhttp://zeppelin.apache.org/download.html
Release note is available
athttp://zeppelin.apache.org/releases/zeppelin-release-0.8.2.html

We welcome your help and feedback. For more information on the project and
how to get involved, visit our website at http://zeppelin.apache.org/

Thank you all users and contributors who have helped to improve Apache
Zeppelin.

Regards,
The Apache Zeppelin community

Re: Zeppelin Front-end rework

[Jeff Zhang]

Thanks Hsuan Lee, it is a great work, I will take a look at it and try it.

Hsuan Lee  于2019年9月29日周日 下午2:41写道：

> Hi, Zeppelin Team
>
> We created a proposal to rework the front end using latest Angular (8.0)
> ZEPPELIN-4321 
>
> We have made the repo public, this is the link
> .
>
> Most of the features have been completed, and we try our best to keep the
> compatibility with old API as much as possible.
>
> The frontend angular API has broke change and Helium is working in
> progress.
>
> You can follow the steps to make it working.
>
>1. Clone the repo $ git clone
>https://github.com/zeppelin-next/zeppelin-frontend-next.git.
>2. Start Zeppelin server.
>3. Create .env file in zeppelin-frontend-next folder, fill your zeppelin
>server address as following format.
>
>SERVER_PROXY=http://localhost:8080
>
>4. Run npm start to start dev server and navigate to
>http://localhost:4200.
>
> It will auto proxy zeppelin-server from the SERVER_PROXY to localhost:4200.
>
> I and  @vthink...@gmail.com   will continue to work
> for this, Hope to get feedback and contribute.
>
> Please keep the discussion here, in the mailing list.
>
> Looking forward to your opinions, any feedbacks are welcome.
>


-- 
Best Regards

Jeff Zhang

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework

[GitBox]

zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin 
Notebooks in vue.js framework
URL: https://github.com/apache/zeppelin/pull/3462#discussion_r329345147
 
 

 ##
 File path: zeppelin-web-vue/README.md
 ##
 @@ -0,0 +1,37 @@
+# zeppelin-studio
 
 Review comment:
   `studio` -> `notebook`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] malayhm commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework

[GitBox]

malayhm commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin 
Notebooks in vue.js framework
URL: https://github.com/apache/zeppelin/pull/3462#discussion_r329345230
 
 

 ##
 File path: zeppelin-web-vue/README.md
 ##
 @@ -0,0 +1,37 @@
+# zeppelin-studio
 
 Review comment:
   Fixed it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework

[GitBox]

zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js 
framework
URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-536273235
 
 
   @malayhm Still one error
   
   ```
   error: Operator '?' must be spaced (space-infix-ops) at 
src/components/Notebook/paragraphs/Editor.vue:112:39:
 110 | },
 111 | compiledMarkdown: function () {
   > 112 |   let withoutMdMark = this.mdValue? 
this.mdValue.replace('%md\n', '') : ''
 |   ^
 113 |   return marked(withoutMdMark, {
 114 | headerPrefix: 'toc_'
 115 |   })
   
   
   1 error found.
   1 error potentially fixable with the `--fix` option.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] malayhm commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework

[GitBox]

malayhm commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js 
framework
URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-536273525
 
 
   > @malayhm Still one error
   > 
   > ```
   > error: Operator '?' must be spaced (space-infix-ops) at 
src/components/Notebook/paragraphs/Editor.vue:112:39:
   >   110 | },
   >   111 | compiledMarkdown: function () {
   > > 112 |   let withoutMdMark = this.mdValue? 
this.mdValue.replace('%md\n', '') : ''
   >   |   ^
   >   113 |   return marked(withoutMdMark, {
   >   114 | headerPrefix: 'toc_'
   >   115 |   })
   > 
   > 
   > 1 error found.
   > 1 error potentially fixable with the `--fix` option.
   > ```
   
   Fixed it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework

[GitBox]

zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js 
framework
URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-536274353
 
 
   @malayhm I still only see blank page. Here's what I see, is it expected ? 
   ```
 App running at:
 - Local:   http://localhost:8081/
 - Network: unavailable
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] malayhm commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework

[GitBox]

malayhm commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js 
framework
URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-536274803
 
 
   > @malayhm I still only see blank page. Here's what I see, is it expected ?
   > 
   > ```
   >   App running at:
   >   - Local:   http://localhost:8081/
   >   - Network: unavailable
   > ```
   
   @zjffdu It should show you the Zeppelin Web Vue page. 
   When you start the dev server through `npm run serve`, does it show any 
error?
   Does this happen with the default settings of the .env file?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework

[GitBox]

zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js 
framework
URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-536274977
 
 
   No error displayed in log and web page, just blank page, only the above 
message `Network: unavailable` suspicious to me.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] malayhm commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework

[GitBox]

malayhm commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js 
framework
URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-536277667
 
 
   > No error displayed in log and web page, just blank page, only the above 
message `Network: unavailable` suspicious to me.
   
   @zjffdu When you run `npm run serve`, it should show:
   
   `App running at:
 - Local:   http://localhost:8081/ 
 - Network: http://192.168.0.101:8081/
   `
   Could you paste the screenshot of the command line output?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] malayhm edited a comment on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework

[GitBox]

malayhm edited a comment on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in 
vue.js framework
URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-536277667
 
 
   > No error displayed in log and web page, just blank page, only the above 
message `Network: unavailable` suspicious to me.
   
   @zjffdu When you run `npm run serve`, it should show:
   
   ```
   App running at:
 - Local:   http://localhost:8081/ 
 - Network: http://192.168.0.101:8081/
   ```
   Could you paste the screenshot of the command line output?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (ZEPPELIN-4359) Interpreter list is incorrect after recent changes in interpreter names

[Alex Ott (Jira)]

Alex Ott created ZEPPELIN-4359:
--

 Summary: Interpreter list is incorrect after recent changes in 
interpreter names
 Key: ZEPPELIN-4359
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4359
 Project: Zeppelin
  Issue Type: Bug
Reporter: Alex Ott


After recent changes in the interpreter artifact names, the list of Maven 
coordinates in the {{interpreter-list}} is incorrect.

P.S. I'll submit the PR after fixing names for Ignite interpreter



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [zeppelin] bhavikpatel9977 opened a new pull request #3468: [ZEPPELIN-4356] Zeppelin should stop/die/etc when can't create/access notebook repo

[GitBox]

bhavikpatel9977 opened a new pull request #3468: [ZEPPELIN-4356] Zeppelin 
should stop/die/etc when can't create/access notebook repo
URL: https://github.com/apache/zeppelin/pull/3468
 
 
   ### What is this PR for?
   Currently when Zeppelin can't create/access the notebook repo, Zeppelin 
stays up but returns MultiException; Instead it would be better to stop/die/etc.
   
   
   ### What type of PR is it?
   [Bug Fix | Improvement]
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-4356
   
   ### How should this be tested?
   CI Pass
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (ZEPPELIN-4360) Ignite Interpreter requires Scala 2.11

[Alex Ott (Jira)]

Alex Ott created ZEPPELIN-4360:
--

 Summary: Ignite Interpreter requires Scala 2.11
 Key: ZEPPELIN-4360
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4360
 Project: Zeppelin
  Issue Type: Bug
  Components: Interpreters
Affects Versions: 0.9.0
Reporter: Alex Ott


The {{ignite-scalar}} library is compiled with Scala 2.11, so when the Zeppelin 
is compiled with Scala 2.10,  interpreter is broken.

Here is dependency in {{ignite-scalar:2.3.0}}:

{noformat}

  org.scala-lang
  scala-library
  2.11.7
  compile

{noformat}




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3468: [ZEPPELIN-4356] Zeppelin should stop/die/etc when can't create/access notebook repo

[GitBox]

zjffdu commented on a change in pull request #3468: [ZEPPELIN-4356] Zeppelin 
should stop/die/etc when can't create/access notebook repo
URL: https://github.com/apache/zeppelin/pull/3468#discussion_r329351120
 
 

 ##
 File path: 
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepoSync.java
 ##
 @@ -39,6 +40,7 @@
 /**
  * Notebook repository sync with remote storage
  */
+@Immediate
 
 Review comment:
   What is this annotation used for ? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3468: [ZEPPELIN-4356] Zeppelin should stop/die/etc when can't create/access notebook repo

[GitBox]

zjffdu commented on a change in pull request #3468: [ZEPPELIN-4356] Zeppelin 
should stop/die/etc when can't create/access notebook repo
URL: https://github.com/apache/zeppelin/pull/3468#discussion_r329351154
 
 

 ##
 File path: 
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java
 ##
 @@ -105,74 +106,76 @@
   @Inject
   public ZeppelinServer() {
 InterpreterOutput.limit = 
conf.getInt(ConfVars.ZEPPELIN_INTERPRETER_OUTPUT_LIMIT);
-
 packages("org.apache.zeppelin.rest");
   }
 
-  public static void main(String[] args) throws InterruptedException {
+  public static void main(String[] args) throws Exception {
 final ZeppelinConfiguration conf = ZeppelinConfiguration.create();
 conf.setProperty("args", args);
 
 jettyWebServer = setupJettyServer(conf);
 
 ContextHandlerCollection contexts = new ContextHandlerCollection();
-jettyWebServer.setHandler(contexts);
-
-// Web UI
-final WebAppContext webApp = setupWebAppContext(contexts, conf);
+jettyWebServer.setHandler(contexts);
+// Web UI
+final WebAppContext webApp = setupWebAppContext(contexts, 
conf);
 
 sharedServiceLocator = 
ServiceLocatorFactory.getInstance().create("shared-locator");
 ServiceLocatorUtilities.enableImmediateScope(sharedServiceLocator);
+ServiceLocatorUtilities.addClasses(sharedServiceLocator,
+NotebookRepoSync.class,
+ImmediateErrorHandlerImpl.class);
+ImmediateErrorHandlerImpl handler = 
sharedServiceLocator.getService(ImmediateErrorHandlerImpl.class);
+
 ServiceLocatorUtilities.bind(
-sharedServiceLocator,
-new AbstractBinder() {
-  @Override
-  protected void configure() {
-Credentials credentials =
-new Credentials(
-conf.credentialsPersist(),
-conf.getCredentialsPath(),
-conf.getCredentialsEncryptKey());
-
-bindAsContract(InterpreterFactory.class).in(Singleton.class);
-
bindAsContract(NotebookRepoSync.class).to(NotebookRepo.class).in(Singleton.class);
-
bind(LuceneSearch.class).to(SearchService.class).in(Singleton.class);
-bindAsContract(Helium.class).in(Singleton.class);
-bind(conf).to(ZeppelinConfiguration.class);
-
bindAsContract(InterpreterSettingManager.class).in(Singleton.class);
-bindAsContract(InterpreterService.class).in(Singleton.class);
-bind(credentials).to(Credentials.class);
-bindAsContract(GsonProvider.class).in(Singleton.class);
-
bindAsContract(WebApplicationExceptionMapper.class).in(Singleton.class);
-bindAsContract(AdminService.class).in(Singleton.class);
-bindAsContract(AuthorizationService.class).to(Singleton.class);
-// TODO(jl): Will make it more beautiful
-if (!StringUtils.isBlank(conf.getShiroPath())) {
-  
bind(ShiroAuthenticationService.class).to(AuthenticationService.class).in(Singleton.class);
-} else {
-  // TODO(jl): Will be added more type
-  
bind(NoAuthenticationService.class).to(AuthenticationService.class).in(Singleton.class);
-}
-bindAsContract(HeliumBundleFactory.class).in(Singleton.class);
-bindAsContract(HeliumApplicationFactory.class).in(Singleton.class);
-bindAsContract(ConfigurationService.class).in(Singleton.class);
-bindAsContract(NotebookService.class).in(Singleton.class);
-bindAsContract(JobManagerService.class).in(Singleton.class);
-bindAsContract(Notebook.class).in(Singleton.class);
-bindAsContract(NotebookServer.class)
-.to(AngularObjectRegistryListener.class)
-.to(RemoteInterpreterProcessListener.class)
-.to(ApplicationEventListener.class)
-.to(NoteEventListener.class)
-.to(WebSocketServlet.class)
-.in(Singleton.class);
-if (conf.isZeppelinNotebookCronEnable()) {
-  
bind(QuartzSchedulerService.class).to(SchedulerService.class).in(Singleton.class);
-} else {
-  
bind(NoSchedulerService.class).to(SchedulerService.class).in(Singleton.class);
-}
-  }
-});
+sharedServiceLocator,
+new AbstractBinder() {
 
 Review comment:
   unnecessary format change ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on a change in pull request #3468: [ZEPPELIN-4356] Zeppelin should stop/die/etc when can't create/access notebook repo

[GitBox]

zjffdu commented on a change in pull request #3468: [ZEPPELIN-4356] Zeppelin 
should stop/die/etc when can't create/access notebook repo
URL: https://github.com/apache/zeppelin/pull/3468#discussion_r329351193
 
 

 ##
 File path: 
zeppelin-server/src/main/java/org/apache/zeppelin/server/ImmediateErrorHandlerImpl.java
 ##
 @@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zeppelin.server;
+
+import java.util.LinkedList;
+import java.util.List;
+
+import javax.inject.Singleton;
+
+import org.glassfish.hk2.api.ActiveDescriptor;
+import org.glassfish.hk2.utilities.ImmediateErrorHandler;
+
+/**
+ * ImmediateErrorHandlerImpl to catch exception
+ */
+@Singleton
+public class ImmediateErrorHandlerImpl implements ImmediateErrorHandler {
+private final List constructionErrors = new 
LinkedList();
+private final List destructionErrors = new 
LinkedList();
 
 Review comment:
   java code style issue, wrong indention


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework

[GitBox]

zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js 
framework
URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-536364149
 
 
   @malayhm I can get it work now. Here're several issues I found now.
   
   1. In the tab mode, the url is never changed when I open new note, this 
behavior is different from the current zeppelin web. Previously, user can share 
note via unique url, but in this vue design, how can i share note via link ?
   2. Sometimes, it never show the note content.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] prabhjyotsingh commented on a change in pull request #3468: [ZEPPELIN-4356] Zeppelin should stop/die/etc when can't create/access notebook repo

[GitBox]

prabhjyotsingh commented on a change in pull request #3468: [ZEPPELIN-4356] 
Zeppelin should stop/die/etc when can't create/access notebook repo
URL: https://github.com/apache/zeppelin/pull/3468#discussion_r329394589
 
 

 ##
 File path: 
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java
 ##
 @@ -105,74 +106,76 @@
   @Inject
   public ZeppelinServer() {
 InterpreterOutput.limit = 
conf.getInt(ConfVars.ZEPPELIN_INTERPRETER_OUTPUT_LIMIT);
-
 packages("org.apache.zeppelin.rest");
   }
 
-  public static void main(String[] args) throws InterruptedException {
+  public static void main(String[] args) throws Exception {
 final ZeppelinConfiguration conf = ZeppelinConfiguration.create();
 conf.setProperty("args", args);
 
 jettyWebServer = setupJettyServer(conf);
 
 ContextHandlerCollection contexts = new ContextHandlerCollection();
-jettyWebServer.setHandler(contexts);
-
-// Web UI
-final WebAppContext webApp = setupWebAppContext(contexts, conf);
+jettyWebServer.setHandler(contexts);
+// Web UI
+final WebAppContext webApp = setupWebAppContext(contexts, 
conf);
 
 sharedServiceLocator = 
ServiceLocatorFactory.getInstance().create("shared-locator");
 ServiceLocatorUtilities.enableImmediateScope(sharedServiceLocator);
+ServiceLocatorUtilities.addClasses(sharedServiceLocator,
+NotebookRepoSync.class,
+ImmediateErrorHandlerImpl.class);
+ImmediateErrorHandlerImpl handler = 
sharedServiceLocator.getService(ImmediateErrorHandlerImpl.class);
+
 ServiceLocatorUtilities.bind(
-sharedServiceLocator,
-new AbstractBinder() {
-  @Override
-  protected void configure() {
-Credentials credentials =
-new Credentials(
-conf.credentialsPersist(),
-conf.getCredentialsPath(),
-conf.getCredentialsEncryptKey());
-
-bindAsContract(InterpreterFactory.class).in(Singleton.class);
-
bindAsContract(NotebookRepoSync.class).to(NotebookRepo.class).in(Singleton.class);
-
bind(LuceneSearch.class).to(SearchService.class).in(Singleton.class);
-bindAsContract(Helium.class).in(Singleton.class);
-bind(conf).to(ZeppelinConfiguration.class);
-
bindAsContract(InterpreterSettingManager.class).in(Singleton.class);
-bindAsContract(InterpreterService.class).in(Singleton.class);
-bind(credentials).to(Credentials.class);
-bindAsContract(GsonProvider.class).in(Singleton.class);
-
bindAsContract(WebApplicationExceptionMapper.class).in(Singleton.class);
-bindAsContract(AdminService.class).in(Singleton.class);
-bindAsContract(AuthorizationService.class).to(Singleton.class);
-// TODO(jl): Will make it more beautiful
-if (!StringUtils.isBlank(conf.getShiroPath())) {
-  
bind(ShiroAuthenticationService.class).to(AuthenticationService.class).in(Singleton.class);
-} else {
-  // TODO(jl): Will be added more type
-  
bind(NoAuthenticationService.class).to(AuthenticationService.class).in(Singleton.class);
-}
-bindAsContract(HeliumBundleFactory.class).in(Singleton.class);
-bindAsContract(HeliumApplicationFactory.class).in(Singleton.class);
-bindAsContract(ConfigurationService.class).in(Singleton.class);
-bindAsContract(NotebookService.class).in(Singleton.class);
-bindAsContract(JobManagerService.class).in(Singleton.class);
-bindAsContract(Notebook.class).in(Singleton.class);
-bindAsContract(NotebookServer.class)
-.to(AngularObjectRegistryListener.class)
-.to(RemoteInterpreterProcessListener.class)
-.to(ApplicationEventListener.class)
-.to(NoteEventListener.class)
-.to(WebSocketServlet.class)
-.in(Singleton.class);
-if (conf.isZeppelinNotebookCronEnable()) {
-  
bind(QuartzSchedulerService.class).to(SchedulerService.class).in(Singleton.class);
-} else {
-  
bind(NoSchedulerService.class).to(SchedulerService.class).in(Singleton.class);
-}
-  }
-});
+sharedServiceLocator,
+new AbstractBinder() {
+  @Override
+  protected void configure() {
+Credentials credentials =
+new Credentials(
+conf.credentialsPersist(),
+conf.getCredentialsPath(),
+conf.getCredentialsEncryptKey());
+bindAsContract(InterpreterFactory.class).in(Singleton.class);
+bind(conf).to(ZeppelinConfiguration.class);
 
 Review comment:
   An

[GitHub] [zeppelin] prabhjyotsingh commented on a change in pull request #3468: [ZEPPELIN-4356] Zeppelin should stop/die/etc when can't create/access notebook repo

[GitBox]

prabhjyotsingh commented on a change in pull request #3468: [ZEPPELIN-4356] 
Zeppelin should stop/die/etc when can't create/access notebook repo
URL: https://github.com/apache/zeppelin/pull/3468#discussion_r329394102
 
 

 ##
 File path: 
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java
 ##
 @@ -244,6 +248,10 @@ public void contextDestroyed(ServletContextEvent 
servletContextEvent) {}
 LOG.info("Starting zeppelin server");
 try {
   jettyWebServer.start(); // Instantiates ZeppelinServer
+  List errorData = handler.waitForAtLeastOneConstructionError(5 
* 1000);
+  if(errorData.size() > 1 && errorData.get(1).getThrowable() != null) {
 
 Review comment:
   Should this be `>=1` or `>0`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] prabhjyotsingh commented on a change in pull request #3468: [ZEPPELIN-4356] Zeppelin should stop/die/etc when can't create/access notebook repo

[GitBox]

prabhjyotsingh commented on a change in pull request #3468: [ZEPPELIN-4356] 
Zeppelin should stop/die/etc when can't create/access notebook repo
URL: https://github.com/apache/zeppelin/pull/3468#discussion_r329394170
 
 

 ##
 File path: zeppelin-server/pom.xml
 ##
 @@ -169,6 +169,20 @@
   org.glassfish.jersey.inject
   jersey-hk2
   ${jersey.version}
+  
+
+  org.glassfish.hk2
+  hk2-api
+
+
+  org.glassfish.hk2.external
+  aopalliance-repackaged
+
+
+  org.glassfish.hk2
+  hk2-utils
+
+  
 
 Review comment:
   Is any of the pom.xml really required? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] prabhjyotsingh commented on a change in pull request #3468: [ZEPPELIN-4356] Zeppelin should stop/die/etc when can't create/access notebook repo

[GitBox]

prabhjyotsingh commented on a change in pull request #3468: [ZEPPELIN-4356] 
Zeppelin should stop/die/etc when can't create/access notebook repo
URL: https://github.com/apache/zeppelin/pull/3468#discussion_r329394436
 
 

 ##
 File path: 
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepoSync.java
 ##
 @@ -39,6 +40,7 @@
 /**
  * Notebook repository sync with remote storage
  */
+@Immediate
 
 Review comment:
   I think this can be removed, it's usually required at only one place. If you 
are doing it there ( 
`bindAsContract(NotebookRepoSync.class).to(NotebookRepo.class).in(Immediate.class);`
 ) then this becomes optional.
   And hence changes in pom.xml can be reverted.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] prabhjyotsingh commented on a change in pull request #3468: [ZEPPELIN-4356] Zeppelin should stop/die/etc when can't create/access notebook repo

[GitBox]

prabhjyotsingh commented on a change in pull request #3468: [ZEPPELIN-4356] 
Zeppelin should stop/die/etc when can't create/access notebook repo
URL: https://github.com/apache/zeppelin/pull/3468#discussion_r329394856
 
 

 ##
 File path: 
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java
 ##
 @@ -105,74 +106,76 @@
   @Inject
   public ZeppelinServer() {
 InterpreterOutput.limit = 
conf.getInt(ConfVars.ZEPPELIN_INTERPRETER_OUTPUT_LIMIT);
-
 packages("org.apache.zeppelin.rest");
   }
 
-  public static void main(String[] args) throws InterruptedException {
+  public static void main(String[] args) throws Exception {
 final ZeppelinConfiguration conf = ZeppelinConfiguration.create();
 conf.setProperty("args", args);
 
 jettyWebServer = setupJettyServer(conf);
 
 ContextHandlerCollection contexts = new ContextHandlerCollection();
-jettyWebServer.setHandler(contexts);
-
-// Web UI
-final WebAppContext webApp = setupWebAppContext(contexts, conf);
+jettyWebServer.setHandler(contexts);
+// Web UI
+final WebAppContext webApp = setupWebAppContext(contexts, 
conf);
 
 sharedServiceLocator = 
ServiceLocatorFactory.getInstance().create("shared-locator");
 ServiceLocatorUtilities.enableImmediateScope(sharedServiceLocator);
+ServiceLocatorUtilities.addClasses(sharedServiceLocator,
+NotebookRepoSync.class,
+ImmediateErrorHandlerImpl.class);
+ImmediateErrorHandlerImpl handler = 
sharedServiceLocator.getService(ImmediateErrorHandlerImpl.class);
+
 ServiceLocatorUtilities.bind(
-sharedServiceLocator,
-new AbstractBinder() {
-  @Override
-  protected void configure() {
-Credentials credentials =
-new Credentials(
-conf.credentialsPersist(),
-conf.getCredentialsPath(),
-conf.getCredentialsEncryptKey());
-
-bindAsContract(InterpreterFactory.class).in(Singleton.class);
-
bindAsContract(NotebookRepoSync.class).to(NotebookRepo.class).in(Singleton.class);
-
bind(LuceneSearch.class).to(SearchService.class).in(Singleton.class);
-bindAsContract(Helium.class).in(Singleton.class);
-bind(conf).to(ZeppelinConfiguration.class);
-
bindAsContract(InterpreterSettingManager.class).in(Singleton.class);
-bindAsContract(InterpreterService.class).in(Singleton.class);
-bind(credentials).to(Credentials.class);
-bindAsContract(GsonProvider.class).in(Singleton.class);
-
bindAsContract(WebApplicationExceptionMapper.class).in(Singleton.class);
-bindAsContract(AdminService.class).in(Singleton.class);
-bindAsContract(AuthorizationService.class).to(Singleton.class);
-// TODO(jl): Will make it more beautiful
-if (!StringUtils.isBlank(conf.getShiroPath())) {
-  
bind(ShiroAuthenticationService.class).to(AuthenticationService.class).in(Singleton.class);
-} else {
-  // TODO(jl): Will be added more type
-  
bind(NoAuthenticationService.class).to(AuthenticationService.class).in(Singleton.class);
-}
-bindAsContract(HeliumBundleFactory.class).in(Singleton.class);
-bindAsContract(HeliumApplicationFactory.class).in(Singleton.class);
-bindAsContract(ConfigurationService.class).in(Singleton.class);
-bindAsContract(NotebookService.class).in(Singleton.class);
-bindAsContract(JobManagerService.class).in(Singleton.class);
-bindAsContract(Notebook.class).in(Singleton.class);
-bindAsContract(NotebookServer.class)
-.to(AngularObjectRegistryListener.class)
-.to(RemoteInterpreterProcessListener.class)
-.to(ApplicationEventListener.class)
-.to(NoteEventListener.class)
-.to(WebSocketServlet.class)
-.in(Singleton.class);
-if (conf.isZeppelinNotebookCronEnable()) {
-  
bind(QuartzSchedulerService.class).to(SchedulerService.class).in(Singleton.class);
-} else {
-  
bind(NoSchedulerService.class).to(SchedulerService.class).in(Singleton.class);
-}
-  }
-});
+sharedServiceLocator,
+new AbstractBinder() {
+  @Override
+  protected void configure() {
+Credentials credentials =
+new Credentials(
+conf.credentialsPersist(),
+conf.getCredentialsPath(),
+conf.getCredentialsEncryptKey());
+bindAsContract(InterpreterFactory.class).in(Singleton.class);
+bind(conf).to(ZeppelinConfiguration.class);
+
bindAs

Re: Zeppelin Front-end rework

[Jongyoul Lee]

Wow!! Looks great!!

Thank you so much

2019년 9월 29일 (일) 오후 6:06, Jeff Zhang 님이 작성:

> Thanks Hsuan Lee, it is a great work, I will take a look at it and try it.
>
> Hsuan Lee  于2019年9月29日周日 下午2:41写道：
>
> > Hi, Zeppelin Team
> >
> > We created a proposal to rework the front end using latest Angular (8.0)
> > ZEPPELIN-4321 
> >
> > We have made the repo public, this is the link
> > .
> >
> > Most of the features have been completed, and we try our best to keep the
> > compatibility with old API as much as possible.
> >
> > The frontend angular API has broke change and Helium is working in
> > progress.
> >
> > You can follow the steps to make it working.
> >
> >1. Clone the repo $ git clone
> >https://github.com/zeppelin-next/zeppelin-frontend-next.git.
> >2. Start Zeppelin server.
> >3. Create .env file in zeppelin-frontend-next folder, fill your
> zeppelin
> >server address as following format.
> >
> >SERVER_PROXY=http://localhost:8080
> >
> >4. Run npm start to start dev server and navigate to
> >http://localhost:4200.
> >
> > It will auto proxy zeppelin-server from the SERVER_PROXY to
> localhost:4200.
> >
> > I and  @vthink...@gmail.com   will continue to work
> > for this, Hope to get feedback and contribute.
> >
> > Please keep the discussion here, in the mailing list.
> >
> > Looking forward to your opinions, any feedbacks are welcome.
> >
>
>
> --
> Best Regards
>
> Jeff Zhang
>


-- 
이종열, Jongyoul Lee, 李宗烈
http://madeng.net

Re: [ANNOUNCE] Apache Zeppelin 0.8.2 released

[Prabhjyot Singh]

Awesome!

Thank you so much Jeff for taking care of this.

Congratulations community.

On Sun, 29 Sep 2019, 2:15 pm Jeff Zhang,  wrote:

> The Apache Zeppelin community is pleased to announce the availability of
> the 0.8.2 release.
>
> Zeppelin is a collaborative data analytics and visualization tool for
> distributed, general-purpose data processing system such as Apache Spark,
> Apache Flink, etc.
>
> This is another minor release after the last minor release 0.8.1
> The community put significant effort into improving Apache Zeppelin since the 
> last release. 26 patches for improvements and bug fixes.
>
> We encourage you to download the latest release 
> fromhttp://zeppelin.apache.org/download.html
> Release note is available 
> athttp://zeppelin.apache.org/releases/zeppelin-release-0.8.2.html
>
> We welcome your help and feedback. For more information on the project and
> how to get involved, visit our website at http://zeppelin.apache.org/
>
> Thank you all users and contributors who have helped to improve Apache
> Zeppelin.
>
> Regards,
> The Apache Zeppelin community
>
>

[GitHub] [zeppelin] malayhm commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework

[GitBox]

malayhm commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js 
framework
URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-536401150
 
 
   > 1. In the tab mode, the url is never changed when I open new note, this 
behavior is different from the current zeppelin web. Previously, user can share 
note via unique url, but in this vue design, how can i share note via link ?
   
   Yes, this is a pending task.
   
   > 2. Sometimes, it never show the note content.
   
   Could you send the sample notebook or steps where it doesn't work?
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [zeppelin] malayhm edited a comment on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework

[GitBox]

malayhm edited a comment on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in 
vue.js framework
URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-536401150
 
 
   @zjffdu 
   > 1. In the tab mode, the url is never changed when I open new note, this 
behavior is different from the current zeppelin web. Previously, user can share 
note via unique url, but in this vue design, how can i share note via link ?
   
   Yes, this is a pending task.
   
   > 2. Sometimes, it never show the note content.
   
   Could you send the sample notebook or steps where it doesn't work?
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services