[GitHub] [zeppelin] Reamer commented on a diff in pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph
Reamer commented on code in PR #4361:
URL: https://github.com/apache/zeppelin/pull/4361#discussion_r852649523
##
zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-operator.interface.ts:
##
@@ -160,7 +160,7 @@ export enum OP {
/**
* [c-s]
* ask paragraph editor setting
- * @param magic magic keyword written in paragraph
+ * @param paragraphText magic keyword written in paragraph
Review Comment:
Please improve this part of the documentation.
My suggestion:
```
@param paragraphId paragraph id
@param paragraphText text of the paragraph
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api
zjffdu commented on code in PR #4362:
URL: https://github.com/apache/zeppelin/pull/4362#discussion_r852616747
##
zeppelin-client-examples/src/main/java/org/apache/zeppelin/client/examples/ZeppelinClientExample.java:
##
@@ -56,6 +56,8 @@ public static void main(String[] args) throws Exception {
"%python\nimport time\ntime.sleep(5)\nprint('done')");
zClient.submitParagraph(noteId, paragraphId2);
zClient.waitUtilParagraphRunning(noteId, paragraphId2);
+ // It's also ok here to call zClient.cancelNote(noteId);
Review Comment:
It looks like test for NotebookRestApi#stopNoteJobs is missing, it is better
to add test for it. Also need to revisit whether we need to add test for other
rest api methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api
zjffdu commented on code in PR #4362:
URL: https://github.com/apache/zeppelin/pull/4362#discussion_r852615303
##
zeppelin-client-examples/src/main/java/org/apache/zeppelin/client/examples/ZeppelinClientExample.java:
##
@@ -56,6 +56,8 @@ public static void main(String[] args) throws Exception {
"%python\nimport time\ntime.sleep(5)\nprint('done')");
zClient.submitParagraph(noteId, paragraphId2);
zClient.waitUtilParagraphRunning(noteId, paragraphId2);
+ // It's also ok here to call zClient.cancelNote(noteId);
Review Comment:
Need to add another test case for `cancelNote` instead of just leaving a
comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4360: [ZEPPELIN-5614] A JDBC interpreter property for disable setting tag for application of hive engines
zjffdu commented on code in PR #4360:
URL: https://github.com/apache/zeppelin/pull/4360#discussion_r852612929
##
jdbc/src/main/resources/interpreter-setting.json:
##
@@ -143,6 +143,13 @@
"defaultValue": "1000",
"description": "Query interval for hive statement",
"type": "number"
+ },
+ "zeppelin.jdbc.hive.tagged.engines.exclude": {
Review Comment:
Both places should update. There's one section about hive in `jdbc.md`,
https://zeppelin.apache.org/docs/0.10.1/interpreter/jdbc.html#apache-hive. BTW,
it looks like to we need to converge the hive related doc in these 2 places.
But it could be done in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] huage1994 opened a new pull request, #4362: [ZEPPELIN-5728] Absence of cancelNote method in Zeppelin Client Api
huage1994 opened a new pull request, #4362: URL: https://github.com/apache/zeppelin/pull/4362 ### What is this PR for? Currently there's a cancelParagraph method in zeppelin client api, however, there's no cancelNote method. PR is to add a cancelNote method in zeppelin client api. ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-5728 ### How should this be tested? * CI passed ### Screenshots (if appropriate) ### Questions: * Does the licenses files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (ZEPPELIN-5728) Absence of cancelNote method in Zeppelin Client Api
Eric Gao created ZEPPELIN-5728: -- Summary: Absence of cancelNote method in Zeppelin Client Api Key: ZEPPELIN-5728 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5728 Project: Zeppelin Issue Type: Improvement Reporter: Eric Gao Currently there's a cancelParagraph method in zeppelin client api, however, there's no cancelNote method. I will appreciate it if someone could add this method : ) https://github.com/apache/zeppelin/blob/master/zeppelin-client/src/main/java/org/apache/zeppelin/client/ZeppelinClient.java -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4360: [ZEPPELIN-5614] A JDBC interpreter property for disable setting tag for application of hive engines
huage1994 commented on code in PR #4360:
URL: https://github.com/apache/zeppelin/pull/4360#discussion_r852553473
##
jdbc/src/main/resources/interpreter-setting.json:
##
@@ -143,6 +143,13 @@
"defaultValue": "1000",
"description": "Query interval for hive statement",
"type": "number"
+ },
+ "zeppelin.jdbc.hive.tagged.engines.exclude": {
Review Comment:
> Also need to update `jdbc.md` for this new property.
Hi @zjffdu , This new property is only related to hive, should I put it into
`hive.md` ?
I didn't find a good place for this property in `jdbc.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4360: [ZEPPELIN-5614] A JDBC interpreter property for disable setting tag for application of hive engines
zjffdu commented on code in PR #4360:
URL: https://github.com/apache/zeppelin/pull/4360#discussion_r852185434
##
jdbc/src/main/resources/interpreter-setting.json:
##
@@ -143,6 +143,13 @@
"defaultValue": "1000",
"description": "Query interval for hive statement",
"type": "number"
+ },
+ "zeppelin.jdbc.hive.tagged.engines.exclude": {
Review Comment:
Also need to update `jdbc.md` for this new property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] jongyoul merged pull request #4350: Bump hadoop-common from 2.3.0 to 3.2.3 in /beam
jongyoul merged PR #4350: URL: https://github.com/apache/zeppelin/pull/4350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4350: Bump hadoop-common from 2.3.0 to 3.2.3 in /beam
jongyoul commented on PR #4350: URL: https://github.com/apache/zeppelin/pull/4350#issuecomment-1101320146 Will merge it to keep history -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul merged pull request #4357: MINOR Update asf.yaml to link with JIRA
jongyoul merged PR #4357: URL: https://github.com/apache/zeppelin/pull/4357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: GitHub Merging
> BTW, we also need to update the jira ticket if using github merge Ah ... I should keep it in mind. :-) 2022년 4월 7일 (목) 오후 4:15, Philipp Dallig 님이 작성: > Thanks, I will try this out. > > Am 07.04.22 um 04:28 schrieb Jeff Zhang: > > Jongyoul's right, I think both approaches work. BTW, we also need to > > update the jira ticket if using github merge > > > > On Wed, Apr 6, 2022 at 12:47 PM Jongyoul Lee wrote: > > > > Yeap. > > > > I just merged it with Github's "Squash and Merge" button. I also > > wonder > > which is better but I feel like both are ok but the disadvantage > > of Github > > button is that we couldn't cherry-pick to another branch > > automatically. > > > > I talked to Jeff about the same issue and we concluded both would > > be ok. > > > > Hope this helps, > > Jongyoul > > > > 2022년 3월 31일 (목) 오후 5:33, Philipp Dallig > > 님이 작성: > > > > > Hi Jeff and Jongyoul, > > > it seems that you have changed the way of merging pull requests > > into the > > > Zeppelin master branch. > > > > > > The following pull request > > > (https://github.com/apache/zeppelin/pull/4332) looks great in > GitHub > > > (marked as merged) and in the commit histroy > > > ( > > > > > > https://github.com/apache/zeppelin/commit/4b60f08bd0ad241a7b197d7165abbb7c066ec979 > ) > > > > > > with a link into the Apache JIRA. > > > > > > How did you achieve this? > > > > > > I failed with the pull request > > > https://github.com/apache/zeppelin/pull/4337 > > > > > > I merged the last pull requests with the > > `./dev/merge_zeppelin_pr.py` > > > script, but this script closes the pull requests, which does not > > look > > > good in GitHub. > > > > > > Best Regards > > > Philipp > > > > > > > > > > -- > > 이종열, Jongyoul Lee, 李宗烈 > > http://madeng.net > > > > > > > > -- > > Best Regards > > > > Jeff Zhang -- 이종열, Jongyoul Lee, 李宗烈 http://madeng.net
[GitHub] [zeppelin] jongyoul commented on pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph
jongyoul commented on PR #4361: URL: https://github.com/apache/zeppelin/pull/4361#issuecomment-1101312803 Will merge it soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jasmine-song commented on pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph
jasmine-song commented on PR #4361: URL: https://github.com/apache/zeppelin/pull/4361#issuecomment-1101291221 > Is t his PR related to a new UI only? yes, just zeppline-web-angular -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul commented on pull request #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph
jongyoul commented on PR #4361: URL: https://github.com/apache/zeppelin/pull/4361#issuecomment-1101283047 Is t his PR related to a new UI only? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] huage1994 commented on a diff in pull request #4308: [Zeppelin-5655] OSSNotebookRepo support version control.
huage1994 commented on code in PR #4308:
URL: https://github.com/apache/zeppelin/pull/4308#discussion_r851999215
##
zeppelin-plugins/notebookrepo/oss/src/main/java/org/apache/zeppelin/notebook/repo/OSSNotebookRepo.java:
##
@@ -17,43 +17,33 @@
package org.apache.zeppelin.notebook.repo;
-import com.aliyun.oss.OSS;
-import com.aliyun.oss.OSSClientBuilder;
-import com.aliyun.oss.model.CopyObjectRequest;
-import com.aliyun.oss.model.DeleteObjectsRequest;
-import com.aliyun.oss.model.ListObjectsRequest;
-import com.aliyun.oss.model.OSSObject;
-import com.aliyun.oss.model.OSSObjectSummary;
-import com.aliyun.oss.model.ObjectListing;
-import com.aliyun.oss.model.PutObjectRequest;
-import org.apache.commons.io.IOUtils;
import org.apache.zeppelin.conf.ZeppelinConfiguration;
import org.apache.zeppelin.notebook.Note;
import org.apache.zeppelin.notebook.NoteInfo;
+import org.apache.zeppelin.notebook.repo.storage.OSSOperator;
+import org.apache.zeppelin.notebook.repo.storage.RemoteStorageOperator;
import org.apache.zeppelin.user.AuthenticationInfo;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import java.io.ByteArrayInputStream;
+import java.io.File;
import java.io.IOException;
-import java.io.InputStream;
-import java.nio.charset.StandardCharsets;
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
+import java.util.*;
/**
* NotebookRepo for Aliyun OSS (https://cn.aliyun.com/product/oss)
*/
-public class OSSNotebookRepo implements NotebookRepo {
+public class OSSNotebookRepo implements NotebookRepoWithVersionControl {
private static final Logger LOGGER =
LoggerFactory.getLogger(OSSNotebookRepo.class);
- private OSS ossClient;
private String bucketName;
private String rootFolder;
+ private static int NOTE_MAX_VERSION_NUM;
Review Comment:
I have deleted `static`.
Firstly I wanted to use final `private final static int
NOTE_MAX_VERSION_NUM` , but found `final` cannot be used. Then I delete `final`
but didn't delete `static`. 😬
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] jasmine-song opened a new pull request, #4361: [ZEPPELIN-5682] SQL keywords are not highlighted in paragraph
jasmine-song opened a new pull request, #4361:
URL: https://github.com/apache/zeppelin/pull/4361
### What is this PR for?
When use the SQL statement in paragraph, some keywords are not highlighted
The reason is new web ui code bug(zeppeline-web-angular), front-end send the
parameter is 'magic', but back-end
receive the parameter is paragraphText, or else catch, don't return
editsetting
This PR modify the correct parameter
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-5682
### How should this be tested?
* CI passed
### Screenshots (if appropriate)
the back-end code is
` public void getEditorSetting(String noteId,
String paragraphText,
ServiceContext context,
ServiceCallback>
callback) throws IOException {
notebook.processNote(noteId,
note -> {
if (note == null) {
callback.onFailure(new NoteNotFoundException(noteId), context);
}
try {
Map settings =
notebook.getInterpreterSettingManager().
getEditorSetting(paragraphText, noteId);
callback.onSuccess(settings, context);
} catch (Exception e) {
callback.onFailure(new IOException("Fail to getEditorSetting", e),
context);
}
return null;
});
}`
### Questions:
* Does the licenses files need to update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
