[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2207 @zjffdu Yes, I will also reflect the namespace. Thank you for your advice :) . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/2207
apply to namespace on python
and zeppelin context name change
before
```
z = _zc = zeppelin context
```
to
```
z = __zeppelin__ = zeppelin context
```
same
```
z.input("title", "my title")
__zeppelin__.input("title", "my title")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2207 and tested environment. | | pyspark intp | python intp | |-||--| |python3 with matplotlib | O| O | |python2 with matplotlib | O | O | --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2207 Okay, Ci pass :) @felixcheung @zjffdu Could you please check on this pr? Thank you :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2207 I would like to merge this. This solves the problem of usability. I will merge this if I no longer have any opinion. Thank you :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2207 @zjffdu How to use is the same as the existing one. If I add a document, should I add something like __zeppelin__ or __spark__? What do you think? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2207: [Zeppelin-802] Support for Zeppelin Context redefiniti...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2207 will be merging if no further comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2257: [Branch-0.7] Fixes a build problem in Zeppelin ...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/2257
[Branch-0.7] Fixes a build problem in Zeppelin branch0.7.
Fixes a build problem in Zeppelin branch0.7.
Hotfix.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin
fix/branch-0.7-build-hotfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2257.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2257
commit a3a615c3bf0be92089d03105b0fad96a05b66940
Author: CloverHearts
Date: 2017-04-12T08:14:36Z
[Zeppelin-802] Support for Zeppelin Context redefinition on Python and
Pyspark
If you override the reserved word ZeppelinContext such as `z` in the python
language, the whole paragraph output problem occurred.
I have taken care to avoid this issue.
`z` == `_zc` == `zeppelin context`
Improvement
https://issues.apache.org/jira/browse/ZEPPELIN-802
The error should not occur in the following situations:
```
%python
z = 1
print("Hello Zeppelin")
```
```
%pyspark
z = 1
print("Hello Zeppelin")
```
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: CloverHearts
Author: cloverhearts
Closes #2207 from cloverhearts/ZEPPELIN-802-pyspark-zeppelin-context and
squashes the following commits:
cc986010 [CloverHearts] added completion on namespace
14695cb8 [CloverHearts] Recovering a member name that is not associated
with a namespace
31af92ab [CloverHearts] fix test case _zc to __zeppelin__
6697d677 [CloverHearts] apply to namespace and replace name _zc to
__zeppelin__
ca795cff [cloverhearts] replace output
1d372df4 [cloverhearts] change name logger
4e8435ac [CloverHearts] added test case on python
b6b804ad [CloverHearts] replace name zeppelin context on python
9fbf70d6 [CloverHearts] fix pyspark test case
987e2118 [CloverHearts] added test code
5da3d6ed [CloverHearts] replace name zeppelin context on pyspark
(cherry picked from commit 8d03920b9bec86dd8e2fc343d32749a08f501362)
Signed-off-by: CloverHearts
commit 2da0b423bb3075d6b960d2f8dbb5466f5f11b733
Author: CloverHearts
Date: 2017-04-17T13:39:08Z
fix branch-0.7 build error
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2278: [ZEPPELIN-2431] Corrected deletion of notes by ...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/2278
[ZEPPELIN-2431] Corrected deletion of notes by incorrect interpreter.json
### What is this PR for?
We sometimes can not delete a note, or we will be accompanied by an NPE for
deleting a note.
This problem occurs when:
When interpreter.json 's note binding is wrong, or there is a problem.
If you are configuring an interpreter that is not through zeppelin's user
interface.
As a result, it happens when synchronization of notes deletion and setting
retention is not normal.
Therefore, we should add handling for note deletion and exception handling
for nonexistent interpreter bindings.
It reduces the synchronization problem of interpreter.json.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2431
### How should this be tested?
1. zeppelin stop
2. edit con/interpreter.json and `interpreterBindings`
fix any notes or incorrect information.
for example
```
},
"interpreterBindings": {
"2CFS9YSM5": [
"2CFRR1D3TINVALIDINVALIDINVALID", <-- edit
"2CFZ1JKUR",
"2CEAJK1VW",
"2CGSESWBH",
"2CERNPGW5",
}
```
3. zeppelin start
4. You can try remove invalid interpreter bind note on web. (on example =
`2CFS9YSM5`)
result :
If the modifications to this PR are not reflected,
It will not be deleted or an error will appear on the server.
Also, the interpreterBindings information in interpreter.json does not
respond to delete events.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin
fix/invalidsyncInterpreterJson
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2278.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2278
commit 35da524cc00c40531072130424fb38419e4612f4
Author: CloverHearts
Date: 2017-04-24T07:16:47Z
notebook interpreter binding synchronization process
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2278: [ZEPPELIN-2431] Corrected deletion of notes by incorre...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2278 added screenshot --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2278: [ZEPPELIN-2431] Corrected deletion of notes by incorre...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2278 if no more opinions, i will merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2288: [ZEPPELIN-2452] block update paragraph event on...
GitHub user cloverhearts opened a pull request: https://github.com/apache/zeppelin/pull/2288 [ZEPPELIN-2452] block update paragraph event on revision mode ### What is this PR for? In revision mode using git-repository, by default all paragraphs must remain unmodifiable. However, we are currently performing an incorrect update. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2452 ### How should this be tested? 1. create note and modify to paragraph and version control commit on web 2. modify to paragraph and execute 3. open your 2 browser - one browser is HEAD, and other browser move to before commit 4. insert paragarph or modify and execute. check update ### Screenshots (if appropriate) problem  fixed (this pr)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloverhearts/zeppelin fix/invalidupdateonrevision Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2288.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2288 commit 19e747999146af56b803696561001977d786032d Author: CloverHearts Date: 2017-04-26T08:30:43Z block update paragraph event on revision mode --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2289: [ZEPPELIN-2452] Can not handle message in revis...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/2289
[ZEPPELIN-2452] Can not handle message in revision mode on web.
### What is this PR for?
Requests interpreter editor mode information in revision mode.
However, no information is needed in revision mode.
Produces misleading logs with misleading requests to the server.
```
ERROR [2017-04-26 18:07:48,718] ({qtp1273765644-60}
NotebookServer.java[onMessage]:383) - Can't handle message
java.lang.NullPointerException
ERROR [2017-04-26 18:07:49,081] ({qtp1273765644-109}
NotebookServer.java[onMessage]:383) - Can't handle message
java.lang.NullPointerException
ERROR [2017-04-26 18:07:49,083] ({qtp1273765644-14}
NotebookServer.java[onMessage]:383) - Can't handle message
java.lang.NullPointerException
```
This log is requested as many as the number of paragraphs contained in the
note.
### What type of PR is it?
Bug fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2452
### How should this be tested?
1. Create a git-repo based note. (Supported by default)
2. Modify the paragraph and commit.
3. Go to the committed revision.
4. Reload the page.
5. Check the server logs.
NotebookServer.java[onMessage]:383) - Can't handle message
java.lang.NullPointerException
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin
fix/incorrectcall-geteditorsetting-on-revisionmode
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2289.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2289
commit 8c77f769826d239bcfaf2ddf1ed6cf4771347b63
Author: CloverHearts
Date: 2017-04-26T09:10:18Z
fix call geteditorsetting
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2289: [ZEPPELIN-2452] Can not handle message in revision mod...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2289 @Leemoonsoo Okay :) i will --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2288: [ZEPPELIN-2452] block update paragraph event on...
Github user cloverhearts closed the pull request at: https://github.com/apache/zeppelin/pull/2288 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2288: [ZEPPELIN-2452] block update paragraph event on...
GitHub user cloverhearts reopened a pull request: https://github.com/apache/zeppelin/pull/2288 [ZEPPELIN-2452] block update paragraph event on revision mode ### What is this PR for? In revision mode using git-repository, by default all paragraphs must remain unmodifiable. However, we are currently performing an incorrect update. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2452 ### How should this be tested? 1. create note and modify to paragraph and version control commit on web 2. modify to paragraph and execute 3. open your 2 browser - one browser is HEAD, and other browser move to before commit 4. insert paragarph or modify and execute. check update ### Screenshots (if appropriate) problem  fixed (this pr)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloverhearts/zeppelin fix/invalidupdateonrevision Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2288.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2288 commit 19e747999146af56b803696561001977d786032d Author: CloverHearts Date: 2017-04-26T08:30:43Z block update paragraph event on revision mode --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2289: [ZEPPELIN-2452] Can not handle message in revis...
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/zeppelin/pull/2289
[ZEPPELIN-2452] Can not handle message in revision mode on web.
### What is this PR for?
Requests interpreter editor mode information in revision mode.
However, no information is needed in revision mode.
Produces misleading logs with misleading requests to the server.
```
ERROR [2017-04-26 18:07:48,718] ({qtp1273765644-60}
NotebookServer.java[onMessage]:383) - Can't handle message
java.lang.NullPointerException
ERROR [2017-04-26 18:07:49,081] ({qtp1273765644-109}
NotebookServer.java[onMessage]:383) - Can't handle message
java.lang.NullPointerException
ERROR [2017-04-26 18:07:49,083] ({qtp1273765644-14}
NotebookServer.java[onMessage]:383) - Can't handle message
java.lang.NullPointerException
```
This log is requested as many as the number of paragraphs contained in the
note.
### What type of PR is it?
Bug fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2452
### How should this be tested?
1. Create a git-repo based note. (Supported by default)
2. Modify the paragraph and commit.
3. Go to the committed revision.
4. Reload the page.
5. Check the server logs.
```
NotebookServer.java[onMessage]:383) - Can't handle message
java.lang.NullPointerException
```
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin
fix/incorrectcall-geteditorsetting-on-revisionmode
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2289.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2289
commit 8c77f769826d239bcfaf2ddf1ed6cf4771347b63
Author: CloverHearts
Date: 2017-04-26T09:10:18Z
fix call geteditorsetting
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2289: [ZEPPELIN-2452] Can not handle message in revis...
Github user cloverhearts closed the pull request at: https://github.com/apache/zeppelin/pull/2289 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2289: [ZEPPELIN-2452] Can not handle message in revision mod...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2289 @khalidhuseynov Thank you :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2289: [ZEPPELIN-2452] Can not handle message in revision mod...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2289 CI PASS :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2257: [Branch-0.7] Support for Zeppelin Context redef...
Github user cloverhearts closed the pull request at: https://github.com/apache/zeppelin/pull/2257 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1218: [Zeppelin-1213] Customize editor configuration
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1218 @hyonaldo Sorry, We can not support this feature on zeppelin. I do not care for this feature into master. It also differs from the current source in many ways. Re-implementation is required. I have no plans to reimplement this until now. Perhaps, if you want this feature. You can create an issue in our jira. (https://issues.apache.org/jira/browse/ZEPPELIN) Sorry, again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2288: [ZEPPELIN-2452] block update paragraph event on revisi...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2288 CI PASS :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2298: [ZEPPELIN-2466] Chart resize problem
GitHub user cloverhearts opened a pull request: https://github.com/apache/zeppelin/pull/2298 [ZEPPELIN-2466] Chart resize problem ### What is this PR for? If you change the size of the chart after changing the mode of the chart, The chart size is not reflected. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2466 ### How should this be tested? 1. resize for your browser. 2. chart toggle -> for example, bar chart -> table -> bar chart 3. and try resize for browser. ### Screenshots (if appropriate) bug  fixed  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloverhearts/zeppelin fix/resize-problem-chart Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2298.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2298 commit 1dcf660e95f49abac4156a0ee7026870c9f1606c Author: CloverHearts Date: 2017-04-28T07:06:34Z fix resize problem commit 13dee7630a28544633cf0312af2b0fec9948b542 Author: CloverHearts Date: 2017-04-28T07:11:49Z remove semi colon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2298: [ZEPPELIN-2466] Chart resize problem
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2298 more fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2298: [ZEPPELIN-2466] Chart resize problem
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2298 Fixed nvd3 basic resize event. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2289: [ZEPPELIN-2452] Can not handle message in revision mod...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2289 if no more opinions, i will merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2288: [ZEPPELIN-2452] block update paragraph event on revisi...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2288 if no more opinions, i will merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2298: [ZEPPELIN-2466] Chart resize problem
Github user cloverhearts closed the pull request at: https://github.com/apache/zeppelin/pull/2298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2298: [ZEPPELIN-2466] Chart resize problem
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2298 @1ambda Sorry for my late answer. Implementation changed. I will create a new PR. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2353: missing try catch
GitHub user cloverhearts opened a pull request: https://github.com/apache/zeppelin/pull/2353 missing try catch ### What is this PR for? Currently we can not build on branch-0.7 The cause is a missed try catch. So, I fixed this part. ### What type of PR is it? Hot Fix ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloverhearts/zeppelin missing-try-catch Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2353.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2353 commit 8a9ea5ce79cca0a7909fd2b6b6242fd3a0b272d4 Author: CloverHearts Date: 2017-05-19T10:24:31Z missing try catch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2353: [branch-0.7] missed try catch.
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2353 merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2353: [branch-0.7] missed try catch.
Github user cloverhearts closed the pull request at: https://github.com/apache/zeppelin/pull/2353 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2343 I will test on this pr. Thank you for greate feature. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2343 @tinkoff-dwh Sorry. My confirmation is late. I will left comment for results in until 12 hours. I'm sorry for wait. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2343 If there is no more comment on this, I will merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2393: [ZEPPELIN-2590] Convert jupyter's notebook to Zeppelin...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2393 @jongyoul Thank you, I am currently checking. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2509: [ZEPPELIN-2818] Improve to better rendering fro...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/2509
[ZEPPELIN-2818] Improve to better rendering from jupyter note
### What is this PR for?
Hi, zeppelin community.
Zeppelin currently has a way to use the Jupiter Note.
This is a great feature.
However, I have found that there are some problems with the way of showing.
I've improved this to increase the user experience.
Please check the screenshot for details.
### What type of PR is it?
Improvement
### Todos
- [x] added pre-render feature (markdown).
- [x] increased to many support type for output data.
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2818
### How should this be tested?
1. build jupyter module
`mvn clean package -DskipTests -pl 'zeppelin-jupyter' --am`
2. `cd zeppelin-jupyter/target`
3. `java -classpath zeppelin-jupyter-0.8.0-SNAPSHOT.jar
org.apache.zeppelin.jupyter.JupyterUtil -i {your ipynb note file
path!/getting_started.ipynb`
4. get a `note.json` and import to zeppelin on frontend!
5. enjoy
### Screenshots (if appropriate)
Before
After
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-2818
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2509.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2509
commit 6ce9935b9a919757d4d8f6bd1cdd6fa62d341282
Author: CloverHearts
Date: 2017-07-28T09:24:34Z
improving get output part
commit 4a51586036bfab9db38bd481d134f06ed3bf59c6
Author: CloverHearts
Date: 2017-07-28T10:33:39Z
implement markdown pre render
commit a56b6ffc65a70bdc39c23695133df89e747ef9e8
Author: CloverHearts
Date: 2017-07-28T10:39:05Z
fix checkstyle
commit 1e15581d1a5b335d776f56f19f330a5587505934
Author: CloverHearts
Date: 2017-07-28T12:19:01Z
improving reder feature
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2509: [ZEPPELIN-2818] Improve to better rendering from jupyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2509 @Leemoonsoo ## Original Markdown ``` --- keyword text --- red Sunsets, apples, and other red or reddish things. green Leaves, grass, frogs and other things it's not easy being. --- ``` ## Jupyter ``` keyword text red Sunsets, apples, and other red or reddish things. green Leaves, grass, frogs and other things it's not easy being. ``` ## Pagedown ``` keyword text âââ ââââââââ red Sunsets, apples, and other red or reddish things. ``` ## Markdown4j ``` keyword text red Sunsets, apples, and other red or reddish things. green Leaves, grass, frogs and other things it's not easy being. ``` I did some testing. And some of the Markdown documents I used as samples Sometimes there are grammars close to exceptions. When I checked in jupyter, If you try to apply a syntax close to the exception, The structure of the changed html document is most similar to Markdown4j. (actually, some element is little different) If the structure of the document is similar, it is easy to implement the same experience as Jupyter in `LooknFeel`, so I chose Markdown4j which showed the most similar results. one problem is that if you run the markdown paragraph with the default interpreter, some results may look different. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2510: [ZEPPELIN-2756] Support ansi escape code for colorizin...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2510 AWESOME! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2509: [ZEPPELIN-2818] Improve to better rendering from jupyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2509 I was Improved test case. and I was fixed command line bug. (https://github.com/apache/zeppelin/pull/2509/files#diff-fde78c9194e779309be4036e9a31904cR187) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2509: [ZEPPELIN-2818] Improve to better rendering from jupyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2509 And Zeppelin changed Markdown4j to the default interpreter Pegdown to rende. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2509: [ZEPPELIN-2818] Improve to better rendering from jupyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2509 https://travis-ci.org/cloverhearts/zeppelin ci pass :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2514: replace pegdown to markdown zeppelin interprete...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/2514
replace pegdown to markdown zeppelin interpreter
### What is this PR for?
I was change markdown render librarry for Jupyter note convertor.
currently, we can got a same result for markdown.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2824
### How should this be tested?
1. build jupyter module
`mvn clean package -DskipTests -pl 'zeppelin-jupyter' --am`
2. `cd zeppelin-jupyter/target`
3. `java -classpath zeppelin-jupyter-0.8.0-SNAPSHOT.jar
org.apache.zeppelin.jupyter.JupyterUtil -i {your ipynb note file
path!/getting_started.ipynb`
(good sample : [go to
sample](https://github.com/SciRuby/sciruby-notebooks/blob/master/getting_started.ipynb)
4. get a `note.json` and import to zeppelin on frontend!
5. enjoy
### Screenshots (if appropriate)
problem
after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-2824-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2514.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2514
commit 2e8b3326b6fe3fb017f78cdfd6cecf1135484706
Author: CloverHearts
Date: 2017-08-02T07:12:45Z
replace pegdown to markdown zeppelin interpreter
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2514: replace pegdown to markdown zeppelin interpreter
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2514 Sorry for the delay. @Leemoonsoo I will fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2514: replace pegdown to markdown zeppelin interpreter
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2514 https://travis-ci.org/cloverhearts/zeppelin ci pass :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2574: [ZEPPELIN-2921 : 0.7x] does not work conda envi...
GitHub user cloverhearts opened a pull request: https://github.com/apache/zeppelin/pull/2574 [ZEPPELIN-2921 : 0.7x] does not work conda environment in python interpreter ### What is this PR for? It seems that the environment of the python interpreter has changed to the py4j environment, causing problems with the library path and the default environment. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2921 ### How should this be tested? Please run the following command line for each paragraph. If the module such as scipy is normally imported, it is a success. `%python.conda create --name Hello6 python=2.7` `%python.conda activate Hello6` `%python.conda install seaborn pandas numpy scipy matplotlib` ``` %python import scipy as sp import seaborn as sns ``` `%python.conda deactivate` ### Screenshots (if appropriate) Before  After  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloverhearts/zeppelin fix/conda-interpreter-invalid-path-0.7 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2574.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2574 commit b287825358ff05347d9062d352485e5cf02d23d7 Author: CloverHearts Date: 2017-09-08T06:23:11Z add conda local env ---
[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2574 @1ambda Thank you, and i will more test :) ---
[GitHub] zeppelin pull request #2575: [ZEPPELIN-2921] does not work conda environment...
GitHub user cloverhearts opened a pull request: https://github.com/apache/zeppelin/pull/2575 [ZEPPELIN-2921] does not work conda environment in python interpreter ### What is this PR for? It seems that the environment of the python interpreter has changed to the py4j environment, causing problems with the library path and the default environment. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2921 ### How should this be tested? Please run the following command line for each paragraph. If the module such as scipy is normally imported, it is a success. `%python.conda create --name Hello6 python=2.7` `%python.conda activate Hello6` `%python.conda install seaborn pandas numpy scipy matplotlib` ``` %python import scipy as sp import seaborn as sns ``` `%python.conda deactivate` ### Screenshots (if appropriate) Before  After  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloverhearts/zeppelin fix/conda-interpreter-invalid-path-0.8 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2575.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2575 commit e2d2f53ec2de8c64d1df2cbf3e31ba7611509f74 Author: CloverHearts Date: 2017-09-08T06:23:11Z add conda local env commit a6b1a00a8cd944346a61484baf6b822b04d2a993 Author: CloverHearts Date: 2017-09-08T08:47:36Z keep python binary ---
[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2574 @1ambda I'll check it, thank you :) ---
[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2576 Tested :) Thank you for good fix. ---
[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2576 If there is no new comment, I will merge it. ---
[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2574 ``` Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 12.456 sec <<< FAILURE! - in org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest testStartStop(org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest) Time elapsed: 10.037 sec <<< FAILURE! java.lang.AssertionError: expected: but was: at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:144) at org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest.testStartStop(RemoteInterpreterServerTest.java:62) ``` This error occurs equally in other PRs and branches. It has been confirmed that it is not related to my changes. ---
[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2574 https://travis-ci.org/malayhm/zeppelin/jobs/272788659 https://travis-ci.org/1ambda/zeppelin/jobs/273195461 ---
[GitHub] zeppelin issue #2575: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2575 https://github.com/apache/zeppelin/pull/2574 same pr and different base branch ---
[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2574 @zjffdu @felixcheung Thank you for your opinions :) I was left my comment. Could you check this one? ---
[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2574 @zjffdu Thank you for your opinion, I present scenarios for environment changes using conda. Python version and module names are arbitrary, so do not worry. What is important is change in every environment. 1. Basically Zeppelin's python python: 2.71 installed library: (none) use to zeppelin ``` %python import sys print(sys.version) print(sys.path) ``` result ``` python version 2.7.1 %ZEPPELIN_HOME%/interpreter/python/lib:%PYTHON_HOME ``` ``` %python import myModule ``` result ``` no module myModule ``` 2. install conda and new python ``` %python.conda create --name python3 python=3.4 ``` ``` %python.conda activate python3 ``` ``` %python import sys print(sys.version) print(sys.path) ``` result ``` python version 3.4 %ZEPPELIN_HOME%/interpreter/python/lib:%PYTHON_HOME:%CONDA_ENV%/python3/lib ``` ``` %python import myModule ``` result ``` no module myModule ``` try again ``` %python.conda install myModule ``` ``` import myModule ``` result ``` imported. ``` 3. restore python environment ``` %python.conda deactivate ``` check for recovered to the original Zeppelin environment. ``` %python import sys print(sys.version) print(sys.path) ``` result ``` python version 2.7.1 %ZEPPELIN_HOME%/interpreter/python/lib:%PYTHON_HOME ``` ``` import myModule ``` result ``` no module myModule ``` All three must be supported by conda. 1. Support to installing and using the python library 2. Support to change the python version 3. Support to configuring non-python environments old zeppelin does works for this part(0.71). but, the Python Interpreter has changed significantly since 0.71. I guess missing the environment part for this. I modified it. python env set code (https://github.com/apache/zeppelin/blob/master/python/src/main/java/org/apache/zeppelin/python/PythonInterpreter.java#L151) ---
[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2574 I think we are worried about `conda interpreter` and coupling for` conda env name`. However, the conda env name is more important to the python interpreter than the conda interpreter. Also, the python interpreter should not query the conda interpreter for its own state. I think this misunderstanding is due to the member name `conda env name`. If I have any additional problems, I will change this to `virtualEnvName`. ---
[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2574 @zjffdu This change will work exactly as your request. There is only one python library path to be added. 1. If the user does not install python via conda. (If the user installs only the library) Zeppelin use to `zeppelin.python`. (Used in the original environment.) 2. If you install python via conda. (separate python from zeppelin.python) if when the conda environment is active, add to library path and replace to installed python via conda from zeppelin.python. Zeppelin to work in the new python environment. 3. The user disables the environment. (conda deactiavte) It is restored to the original zeppelin.python environment. ---
[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2574 @1ambda Currently there is a possibility that it will be structurally. However, if you store it in PythonCondaInterpreter, the problem is greatly aggravated. 1. PythonInterpreter needs to monitor PythonCondaInterpreter at all times. Â Â Â Â (Python Interpreter should check Conda's environment activation when restarting.) 2. Other configurations other than PythonCondaInterpreter If an interpreter is added (as you might have guessed), the Python Interpreter is in a situation where you need to constantly query for all other Interpreter environments. This will affect the life cycle of the Python Interpreter. ---
[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2574 I have a solution to remove conda related members from PythonInterpreter. also PythonCondaInterpreter will not have any members. However, it differs in focus from this PR. (The problem is that there are changes related to the start of the Python Interpreter.) This PR is intended to be used when the user changes the environment by installing new python while using conda. This also solves the Zeppelin Python Interpreter's infinite loop problem. ---
[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2574 In my opinion, allowing for fluctuations in the python environment is itself a problem. But zeppelin are supporting it. If it does not, then the semantics of conda activate and conda deactivate disappear. In fact, I also think that changing the python environment can be a problem. However, the current Zeppelin supports it, and a bug exists. This PR is a PR that solves the bug. ---
[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2574 @zjffdu @1ambda @felixcheung Thank you for your kind reply despite my lack of English. I hope this PR is merged. So, i will try to reflect your opinions as much as possible. Thank you. :) ---
[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2574 Thank you @1ambda @zjffdu @felixcheung I think my code with various purposes is distracting you. And, unfortunately, my English ability is difficult to describe in a sophisticated way. Therefore, I will share PR. In this PR, we will only deal with the wrong library installation of conda. Many thanks for your comments. ---
[GitHub] zeppelin pull request #2578: [ZEPPELIN-2921] does not work conda environment...
GitHub user cloverhearts opened a pull request: https://github.com/apache/zeppelin/pull/2578 [ZEPPELIN-2921] does not work conda environment in python interpreter ### What is this PR for? It seems that the environment of the python interpreter has changed to the py4j environment, causing problems with the library path and the default environment. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2921 ### How should this be tested? Please run the following command line for each paragraph. If the module such as scipy is normally imported, it is a success. `%python.conda create --name Hello6 python=2.7` `%python.conda activate Hello6` `%python.conda install seaborn pandas numpy scipy matplotlib` ``` %python import scipy as sp import seaborn as sns ``` `%python.conda deactivate` ### Screenshots (if appropriate) Before  After  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-2921 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2578.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2578 commit 8dfb33b1159695e109a696c38a3fd6a112a79e13 Author: CloverHearts Date: 2017-09-10T16:36:19Z replace conda install environment name ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2578 @1ambda @zjffdu @felixcheung Sorry. I divided the existing PR by the minimum function. Can you review this PR again? Thank you for your help :) ---
[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2574 I have separated this PR. I'm sorry for the confusion. https://github.com/apache/zeppelin/pull/2578 ---
[GitHub] zeppelin pull request #2574: [ZEPPELIN-2921 : 0.7x] does not work conda envi...
Github user cloverhearts closed the pull request at: https://github.com/apache/zeppelin/pull/2574 ---
[GitHub] zeppelin pull request #2575: [ZEPPELIN-2921] does not work conda environment...
Github user cloverhearts closed the pull request at: https://github.com/apache/zeppelin/pull/2575 ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2578 The problem of CI is irrelevant to this pr. ``` Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 12.462 sec <<< FAILURE! - in org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest testStartStop(org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest) Time elapsed: 10.043 sec <<< FAILURE! java.lang.AssertionError: expected: but was: at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:144) at org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest.testStartStop(RemoteInterpreterServerTest.java:62) ``` ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2578 @zjffdu Sure, Thank you :) ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2578 @1ambda okay :) ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2578 fixed test case and conda list feature ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2578 If there are no comments anymore, I will merge to master on this pr. ---
[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2578 @zjffdu Thank you a lot :) ---
[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2576 This is a hot-fix change. Therefore, they merge quickly. ---
[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2576 @felixcheung Thank you :) ---
[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2576 I will merge to master ---
[GitHub] zeppelin pull request #2583: Improved stability for conda interpreter.
GitHub user cloverhearts opened a pull request: https://github.com/apache/zeppelin/pull/2583 Improved stability for conda interpreter. ### What is this PR for? Currently, when configuring environment of conda interpreter, when configuring environment without installing python separately, The python interpreter may fall into an infinite loop. This PR solves that. ORIGINAL : #2574 ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2921 ### How should this be tested? ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloverhearts/zeppelin feat/keep-python-interpreter-cmd Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2583.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2583 commit 9d7739c66dcda0d0db1a264079ac17d82aba9edc Author: CloverHearts Date: 2017-09-12T08:53:04Z keep python interpreter cmd ---
[GitHub] zeppelin pull request #2583: Improved stability for conda interpreter.
Github user cloverhearts closed the pull request at: https://github.com/apache/zeppelin/pull/2583 ---
[GitHub] zeppelin issue #2707: [ZEPPELIN-3100] Upgrade node and npm version
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/2707 I was tested. Looks good :) Lgtm ---
Re: [VOTE] Release Apache Zeppelin 0.8.0 (RC5)
Awesome +1 On Wed, Jun 20, 2018 at 11:41 AM +0900, "Jeff Zhang" wrote: Hi folks, I propose the following RC to be released for the Apache Zeppelin 0.8.0 release. The commit id is adc2e63c1ff1f7690ba7b3c10984c8024e379a31 *https://git-wip-us.apache.org/repos/asf?p=zeppelin.git;a=commit;h=adc2e63c1ff1f7690ba7b3c10984c8024e379a31 * This corresponds to the tag: v0.8.0-rc5 The release archives (tgz), signature, and checksums are here *https://dist.apache.org/repos/dist/dev/zeppelin/zeppelin-0.8.0-rc5/ * The release candidate consists of the following source distribution archive zeppelin-0.8.0.tgz In addition, the following supplementary binary distributions are provided for user convenience at the same location zeppelin-0.8.0-bin-all.tgz zeppelin-0.8.0-bin-netinst.tgz The maven artifacts are here *https://repository.apache.org/content/repositories/orgapachezeppelin-1242/ * You can find the KEYS file here: https://dist.apache.org/repos/dist/release/zeppelin/KEYS Release notes available at https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316221&version=12339144 Vote will be open for next 72 hours (close at 8PM 22/June PDT). [ ] +1 approve [ ] 0 no opinion [ ] -1 disapprove (and reason why)
[GitHub] incubator-zeppelin pull request: ZEPPELIN-598 ] Dynamic loading fo...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/908
ZEPPELIN-598 ] Dynamic loading for Interpreter and API
### What is this PR for?
Use of external libraries that are included in the Roadmap,
The interpreter needs related to dynamic loading capabilities.
### What type of PR is it?
Feature
### Todos
* [x] - Dynamic load
* [x] - Modified according to feedback
(https://github.com/apache/incubator-zeppelin/pull/631)
### ScreenShots
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-598
### How should this be tested?
By annotating the interpreter setting items below, try using the
loadDynamicInterpreter method.
Or create a new interpreter loads created in the local Maven repository.
incubator-zeppelin/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
``` java
ZEPPELIN_INTERPRETERS("zeppelin.interpreters",
"org.apache.zeppelin.spark.SparkInterpreter,"
+ "org.apache.zeppelin.spark.PySparkInterpreter,"
+ "org.apache.zeppelin.spark.SparkSqlInterpreter,"
+ "org.apache.zeppelin.spark.DepInterpreter,"
+ "org.apache.zeppelin.markdown.Markdown,"
...
```
and API Call (load interpreter) example load markdown
```
Content-Type: application/json
```
```
POST http://127.0.0.1:8080/api/interpreter/load/md/markdown
{
"artifact":
"org.apache.zeppelin:zeppelin-markdown:0.6.0-incubating-SNAPSHOT",
"className": "org.apache.zeppelin.markdown.Markdown",
"repository": {
"url": "http://dl.bintray.com/spark-packages/maven";,
"snapshot" : true
}
}
```
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/incubator-zeppelin
feat/ZEPPELIN-598
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/908.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #908
commit 3d0a9d4c3781dce264b186aa862d8dddeb52518d
Author: CloverHearts
Date: 2016-05-22T05:42:48Z
Implement feat. dynamic load interpreter class
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-598 ] Dynamic loading fo...
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/908#issuecomment-220887799 Thank you @AhyoungRyu fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-598 ] Dynamic loading fo...
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/908#issuecomment-220896255 done. Please, to review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-598 ] Dynamic loading fo...
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/908#issuecomment-220908264 Thank you, for tested. @astroshim Please, retry test. I fixed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: move noteName method from main to...
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/910#issuecomment-220935392 LGTM. good fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-866] Hotfix - does not w...
GitHub user cloverhearts opened a pull request: https://github.com/apache/incubator-zeppelin/pull/911 ZEPPELIN-866] Hotfix - does not working search box on navbar. ### What is this PR for? When you type in the search box and start the search, The result is not exposed. Previously, it was working well. ### What type of PR is it? Hot Fix ### Todos * [x] - fixed bug on navbar.html and controller ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-866 ### How should this be tested? try to search action on navbar. ### Screenshots (if appropriate) before https://cloud.githubusercontent.com/assets/10525473/15469402/10713c64-2125-11e6-909d-cb375e7c31a4.png";> after https://cloud.githubusercontent.com/assets/10525473/15469411/1a6e0b0c-2125-11e6-9ade-e4147e7143d8.png";> ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloverhearts/incubator-zeppelin fixed/searchbar Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-zeppelin/pull/911.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #911 commit 4d06560e4d8fd02c32bd343de6950594094cae6d Author: CloverHearts Date: 2016-05-23T08:38:15Z Hotfix - dose not working search box on navbar. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-866] Hotfix - does not w...
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/911#issuecomment-220961717 @prabhjyotsingh I think that code would clean up the search box. It should not be deleted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-866] Hotfix - does not w...
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/911#issuecomment-220962612 @prabhjyotsingh Okay, i will look to this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-866] Hotfix - does not w...
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/911#issuecomment-220971230 @prabhjyotsingh You're all right. you're alright. this is code is bug and dead code. If active to code, the search becomes impossible. So I have deleted that code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-866] Hotfix - does not w...
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/911#issuecomment-221147514 @prabhjyotsingh fix done. Please, Can you feedback for this pr for me? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-866] Hotfix - does not w...
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/911#issuecomment-221152608 @astroshim Thank you for feed back. are you mean 'initial statement' is 'clean up on search box'? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-866] Hotfix - does not w...
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/911#issuecomment-221169927 Thank you for explaining, @astroshim @AhyoungRyu I agree too. But, This is must exist only for bug fixes at this PR. I will make it in the next PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: [MINOR] Remove redundant logic of...
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/909#issuecomment-221177604 LGTM! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: Update/shiro docs
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/907#issuecomment-221186335 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-598 ] Dynamic loading fo...
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/908#issuecomment-221471176 @felixcheung Thank you for a good opinion. For access control to the API... In my opinion, currently it is possible through the "Shiro" or "Basic Access Authentication". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-866] Hotfix - does not w...
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/911#issuecomment-221475061 @bzz can not access to '$ scope.searchTerm variable at navbar.html' in navbar.controller Code and nav are not currently operating normally. I did not find the PR of the problem, which seems to be a problem at some point. This can cause a lot of problems in the current navbar. For example https://github.com/apache/incubator-zeppelin/pull/912 I think we need to recover the ability to hotfix first. And it should retouching the navbar. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: [MINOR] switch location of interp...
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/913#issuecomment-221479057 Looks good. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: Change website menu caret color
Github user cloverhearts commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/915#issuecomment-221482677 Looks good +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
