[GitHub] zeppelin issue #2972: ZEPPELIN-3379. Refactoring of JDBC autocomplete.
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2972 Hi @anirbanch ! I have adopted PR to branch 0.8 and have created patch (can be founded in linked JIRA issue). You can apply patch and build jars. On your risks you can 1. Replace next files (from linked JIRA issue) $ZEPPELIN_HOME/interpreter/jdbc/zeppelin-jdbc-0.8.1-SNAPSHOT.jar $ZEPPELIN_HOME/interpreter/jdbc/postgresql-native-driver-sql.keywords $ZEPPELIN_HOME/lib/interpreter/zeppelin-interpreter-0.8.1-SNAPSHOT.jar 2. Set "completionSupport" to false in $ZEPPELIN_HOME/interpreter/jdbc/interpreter-setting.json also you can add `"completionKey": "TAB"` to editor key 3. Run Zeppelin. ---
[GitHub] zeppelin issue #3163: ZEPPELIN-2619. Save note in ${notename_noteid}.zpln in...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3163 @zjffdu No, I didn't see the popup with error explanation for user. I have tested a lot with Russian symbols. Seems that Zeppelin works fine. Thank you for this improvement. PR could be merged. ---
[GitHub] zeppelin issue #3179: [ZEPPELIN-3773] - add check permission on write.
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3179 @Savalek You're right. I fix my shiro.ini. But I still see a huge amount of background queries (up to 100 per second) connected with Helium. I can reproduce the issue in development mode. Tested on Ubuntu 16.04, Chromium (Version 69.0.3497.92) and Firefox Quantum 62.0 Check please. ---
[GitHub] zeppelin issue #3163: ZEPPELIN-2619. Save note in ${notename_noteid}.zpln in...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3163 @zjffdu, I'm back 1. I get IOException if folder name equals to "..". The same need for name "." (single dot). 1. Try to create 2 notes with the same path and name, then press "Move folder to Trash". On disk folder will be moved to trash, but note tree will contain bronen note link. 1. Still Trash button just renames note if it already in Trash. See first GIF. 1. In branch-0.8 only owners can rename note or change path, in your branch writers can change path and can trash note. (GIF2) 1. Note search (note-name-query form on main page) is broken. (GIF2) 1. Button "Clone this note" clones note to root folder. I expect cloning to the same folder. (GIF2)   ---
[GitHub] zeppelin pull request #3172: ZEPPELIN-3687. Fix IndexError in spark.pyspark ...
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/3172 ---
[GitHub] zeppelin issue #3179: [ZEPPELIN-3773] - add check permission on write.
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3179 @Savalek I see an infinite number of GET request like http://localhost:8080/api/helium/suggest/2DMKVSPYC/20180807-154514_2063688624 with response "401 Unauthorized" is case if user don't have permission for write. Could you fix? ---
[GitHub] zeppelin issue #3028: [ZEPPELIN-3549] Add to shiro.ini authorization for not...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3028 Will merge? ---
[GitHub] zeppelin issue #3163: ZEPPELIN-2619. Save note in ${notename_noteid}.zpln in...
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/3163
@zjffdu
- In note tree plus sing near folder must create note in this folder not at
root.
- It's seems double dots as folder name is still not fixed.
- Can we avoid CR/LF chars as names? Notes are created, but have "?" in
file system name.
- Need to limit the name length for 255 symbols. For long names user get
(tested on Ubuntu 16.04)
`Failed to create note.`
`IOException: Fail to create Note`
```python
import requests
import json
zeppelin_user, zeppelin_password = 'user1' , ''
zeppelin_host, zeppelin_port = 'localhost', 8080
class Izpepelin:
def __init__(self):
self.session = requests.Session()
self.session.auth = (zeppelin_user, zeppelin_password)
self.base_url = 'http://' + zeppelin_host + ':' + str(zeppelin_port)
def create_note(self, note_name):
body = {"name": note_name}
return self.session.post(self.base_url + '/api/notebook/', json =
body).json()
super_names = ['Folder1/../double dot' '''Folder1/New
line''',
'Folder1/']
for name in super_names:
zepp.create_note(name)
```
---
[GitHub] zeppelin issue #3163: ZEPPELIN-2619. Save note in ${notename_noteid}.zpln in...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3163 @zjffdu * Now usual note has tooltip "Move this note to trash" on trash button. Trashed note has tooltip "Remove this note permanently". * Trashed note must be deleted on "Trash" button click. * I know that noteId is unique. But what if somebody create "zpln" file in "notebook" folder and duplicate ID? ---
[GitHub] zeppelin issue #3163: ZEPPELIN-2619. Save note in ${notename_noteid}.zpln in...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3163 @zjffdu - Need change the behavior for button "Move note to Trash" for notes in Trash: - * Need show another tooltip - * And delete note, but not add another "~Trash" to note path - Please add check for doubles of note ID. It's good to add warning to log about second note with the same ID. I will continue testing. Please wait my approve :smiley: ---
[GitHub] zeppelin issue #3163: ZEPPELIN-2619. Save note in ${notename_noteid}.zpln in...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3163 @zjffdu - note can't be cloned - need to deny folder name as ".." (double dot), because of after restart note will be in another folder - note with only one empty paragraph doesn't have any paragraph after Zeppelin reload. ---
[GitHub] zeppelin issue #3172: ZEPPELIN-3687. Fix IndexError in spark.pyspark with em...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3172 @zjffdu it's really need to duplicate unit test from python interpreter? ---
[GitHub] zeppelin pull request #3172: ZEPPELIN-3687. Fix IndexError in spark.pyspark ...
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/3172 ZEPPELIN-3687. Fix IndexError in spark.pyspark with empty input (branch-0.8) ### What is this PR for? #3115 fix only python interpreter. For master branch is OK because spark.pyspark implements python interpreter, but spark in branch-0.8 has own python. ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-3687](https://issues.apache.org/jira/browse/ZEPPELIN-3687) ### How should this be tested? - CI pass In #3115 was added test. I think we can not duplicate test. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/TinkoffCreditSystems/zeppelin DW-17854_0.8 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3172.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3172 commit 00f6a0aea5814bf8e93b8b060ec423101bf3cca3 Author: Maxim Belousov Date: 2018-09-07T07:10:12Z ZEPPELIN-3687. Fix IndexError in spark.pyspark interpreter with empty input ---
[GitHub] zeppelin issue #3163: ZEPPELIN-2619. Save note in [Title].zpln instead of [N...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3163 @zjffdu I had a little test. - Create note with name "Folder/Name 1" - It was saved on disc correctly. - Try to edit note name: folder path is absent. ---
[GitHub] zeppelin issue #3141: Adding CSP header
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3141 @atomicpages thank you! How CSP header works simultaneously with X-Frame-Option? What if I want to allow content in iframes from more than one server? ---
[GitHub] zeppelin issue #3147: [ZEPPELIN-3726] Fix NPE for resourceList function "get...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3147 CI is green https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/416710567 ---
[GitHub] zeppelin pull request #3147: [ZEPPELIN-3726] Fix NPE for resourceList functi...
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/3147 [ZEPPELIN-3726] Fix NPE for resourceList function "getAllResourcesExcept". ### What is this PR for? Trivial fix for exclude NPE in org.apache.zeppelin.interpreter.InterpreterSettingManager#getAllResourcesExcept ### What type of PR is it? Bug Fix ### What is the Jira issue? [[ZEPPELIN-3726]](https://issues.apache.org/jira/browse/ZEPPELIN-3726) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/TinkoffCreditSystems/zeppelin DW-17923 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3147.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3147 commit 60a6d040a108ac1dad2b1142d931d9408ddccf26 Author: Maxim Belousov Date: 2018-08-15T16:20:48Z Fix possible NPE for resourceList function "getAllResourcesExcept". commit fa1b799c8733352395daba2d6afdee377fd05983 Author: Maxim Belousov Date: 2018-08-16T08:28:00Z Merge branch 'master' of https://github.com/apache/zeppelin ---
[GitHub] zeppelin pull request #2972: ZEPPELIN-3379. Refactoring of JDBC autocomplete...
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/2972 ---
[GitHub] zeppelin issue #2972: ZEPPELIN-3379. Refactoring of JDBC autocomplete.
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2972 Will revert when anyone could test this PR. ---
[GitHub] zeppelin issue #3118: [zeppelin-3693] Option to toggle chart settings of par...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3118 @saravsars I'm not sure that your feature will merge. How about to introduce new display mode? ---
[GitHub] zeppelin issue #3107: [ZEPPELIN-3646] Add note for updating user permissions
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3107 @felixcheung could you point out good place for code that will be helpful after the migration to new version? ---
[GitHub] zeppelin pull request #3081: ZEPPELIN-3575. Add 'Copy Column Name' button in...
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/3081 ---
[GitHub] zeppelin issue #3081: ZEPPELIN-3575. Add 'Copy Column Name' button in visual...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3081 Will try to revert with tests. ---
[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3092 Seems this PR broke build for scala 2.11 After execution of ` ./dev/change_scala_version.sh 2.11` I have got error ``` [ERROR] Failed to execute goal on project zeppelin-beam: Could not resolve dependencies for project org.apache.zeppelin:zeppelin-beam:jar:0.9.0-SNAPSHOT: Could not find artifact org.apache.zeppelin:zeppelin-scio_2.10:jar:0.9.0-SNAPSHOT in apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]``` @selvinsource could check maven build? ---
[GitHub] zeppelin issue #3065: ZEPPELIN-3617. Allow to specify saving resourceName as...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3065 @zjffdu Our team do not use actively ResourcePool. We only plan to use. ---
[GitHub] zeppelin issue #3065: ZEPPELIN-3617. Allow to specify saving resourceName as...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3065 @zjffdu First version with ResourcePool was released a month ago (thanks to you ;) ) Now is good moment to decide future limitations. ---
[GitHub] zeppelin issue #3065: ZEPPELIN-3617. Allow to specify saving resourceName as...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3065 @zjffdu WDYT? ---
[GitHub] zeppelin issue #3098: ZEPPELIN-3664
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3098 @fsteinle our team use authorization with parameter `activeDirectoryRealm.principalSuffix = @company.com` Thus email is not necessary. Could it possible to use mailNickName, for example? BTW, `userPrincipalName` is good. ---
[GitHub] zeppelin issue #3081: ZEPPELIN-3575. Add 'Copy Column Name' button in visual...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3081 @jongyoul I also haven't good idea to write small and useful test. It's possible to rewrite copyStringToClipboard as pass to function the column number and then put in clipboard column name, although it's not straightforward way. ---
[GitHub] zeppelin issue #3090: [ZEPPELIN-3645] Add LSP Protocol completion support
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3090 @felixcheung I agree that support of LSP in Zeppelin is unmature idea. Share please undesired cases with open ip and port. ---
[GitHub] zeppelin issue #3035: [ZEPPELIN-3553] Fix URLs on "Multi-user Support" page
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3035 @felixcheung Links are still broken in 0.9.0 and 0.8 docs. Could you check the reason? ---
[GitHub] zeppelin pull request #3081: ZEPPELIN-3575. Add 'Copy Column Name' button in...
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/3081 ZEPPELIN-3575. Add 'Copy Column Name' button in visualization table ### What is this PR for? Add button to drop-down list in visualization table to copy column name. I know that column name could be obtained in a different way, for example, by auto-complete. Nevertheless I think this feature is comfortable. ### What type of PR is it? Feature ### What is the Jira issue? [ZEPPELIN-3575](https://issues.apache.org/jira/browse/ZEPPELIN-3575) ### How should this be tested? * Manually ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3575 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3081.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3081 commit efa95b6ee19387b4aec02ab99cf313a06bb6618c Author: Maxim Belousov Date: 2018-07-18T13:10:51Z ZEPPELIN-3575 - Add 'Copy Column Name' button in visualization table ---
[GitHub] zeppelin issue #3065: ZEPPELIN-3617. Allow to specify saving resourceName as...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3065 @zjffdu Nice! How about adding to ResourcePool only if resourceName specified in paragraph properties? ---
[GitHub] zeppelin issue #2848: [Zeppelin-3307] - Improved shared browsing/editing for...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2848 @jongyoul I see next usecase. 10 users open the note, put client ID in dynamic form, refresh note, get and process data result. In this case getting of default note view is OK. That is in personal mode we may not save note updates. ---
[GitHub] zeppelin issue #2848: [Zeppelin-3307] - Improved shared browsing/editing for...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2848 @jongyoul As I understand personal mode allows users run paragraphs and have different views and different results due user chosen values in dynamic forms. I'm against the removal of personal mode. ---
[GitHub] zeppelin issue #2733: [ZEPPELIN-3175] Set ExecutorFactory 65536 in Scheduler...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2733 Hmm... It seems PR is actual for branch-0.8. I propose to wait somebody with this bug and then fix source code. ---
[GitHub] zeppelin issue #2708: [Zeppelin-3095] Fix UI when all paragraphs executing s...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2708 @jongyoul status is ready to merge to master =) I hope I will merge this PR to our fork of branch-0.8 and will confirm that works fine. This needs 1-2 months. ---
[GitHub] zeppelin pull request #3050: ZEPPELIN-3581. Add "type": "textarea" to "defau...
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/3050 ZEPPELIN-3581. Add "type": "textarea" to "default.statementPrecode" in interpreter-setting.json ### What is this PR for? Fix "interpreter-setting.json" for JDBC interpreter ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-3581](https://issues.apache.org/jira/browse/ZEPPELIN-3581) ### How should this be tested? * Check text area near the "default.statementPrecode" setting. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3581 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3050.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3050 commit 4b052ed6b88d77d1cbb6b5e3754c1fe9a7615e58 Author: Maxim Belousov Date: 2018-07-03T17:20:22Z Add "type": "textarea" to "default.statementPrecode" ---
[GitHub] zeppelin pull request #3048: [Docs] Update java version to 1.8
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/3048 [Docs] Update java version to 1.8 ### What is this PR for? This continues https://github.com/apache/zeppelin/pull/3029 (ZEPPELIN-621 - Bump Java version to Java 8) ### What type of PR is it? Bug Fix ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/TinkoffCreditSystems/zeppelin java1.8doc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3048.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3048 commit 877dcbbe81139b373d2998895469f27b414f74b6 Author: Maxim Belousov Date: 2018-07-03T10:33:34Z Update java version to 1.8 in docs This continues https://github.com/apache/zeppelin/pull/3029 ---
[GitHub] zeppelin issue #3035: [ZEPPELIN-3553] Fix URLs on "Multi-user Support" page
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3035 @felixcheung done ---
[GitHub] zeppelin issue #3024: [ZEPPELIN-3545] save all tables to ResourcePool
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3024 @zjffdu I support adding only selected table results to Resource Pool. As paragraph can have multiple results than I propose to add result level properties. ---
[GitHub] zeppelin issue #3039: ZEPPELIN-3348. Enable paragraph level properties
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3039 @zjffdu great powerful feature! When the parameters will be a lot, it will be not easy to find and write the parameter name. I wish it would be more user-friendly with drop-down panel. Also parameters must be explicitly displayed for easy debug as in your case. Does make sense to add some user functionality? ---
[GitHub] zeppelin issue #3024: [ZEPPELIN-3545] save all tables to ResourcePool
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3024 @zjffdu thank you about ResourcePool impoving. Share please your vision how it would be. For example, a paragraph has 5 table results. How user will define which of them would be added into ResourcePool? ---
[GitHub] zeppelin pull request #3035: [ZEPPELIN-3553] Fix URLs for "Notebook Permissi...
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/3035 [ZEPPELIN-3553] Fix URLs for "Notebook Permission" and "Shiro Authentic⦠### What is this PR for? On page Setup > Multi-user Support http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/setup/basics/multi_user_support.html there are two urls: * Shiro Authentication - http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/setup/setup/security/shiro_authentication.html * Notebook Permission - http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/setup/setup/security/notebook_authorization.html Need to remove one of the "setup" ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-3553](https://issues.apache.org/jira/browse/ZEPPELIN-3553) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3553 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3035.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3035 commit 100a2af06332411e69794c9e7a94c66227f54ef7 Author: mebelousov Date: 2018-06-19T13:38:10Z ZEPPELIN-3553 Fix URLs for "Notebook Permission" and "Shiro Authentication" ---
[GitHub] zeppelin issue #3027: [ZEPPELIN-2605] Import notebook has 1MB size limit but...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3027 @sanjaydasgupta thank you! LGTM ---
[GitHub] zeppelin pull request #3028: [ZEPPELIN-3549] Add to shiro.ini authorization ...
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/3028 [ZEPPELIN-3549] Add to shiro.ini authorization for notebook-repositories ### What is this PR for? Small improvement that users cannot change notebook repositories by default. ### What type of PR is it? Improvement ### What is the Jira issue? [ZEPPELIN-3549](https://issues.apache.org/jira/browse/ZEPPELIN-3549) ### How should this be tested? - Check correct ulr for `/api/notebook-repositories/**` ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3549 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3028.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3028 commit 567ac3fe0ddf8566e86f10225c4386b4b86724f3 Author: mebelousov Date: 2018-06-18T07:34:47Z ZEPPELIN-3549 Add to shiro.ini authorization for notebook-repositories ---
[GitHub] zeppelin issue #3003: [ZEPPELIN-3526] Zeppelin auth mechanisms (LDAP or pass...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/3003 @prabhjyotsingh I think it's good to document only one way for authentification. What do you think about it? ---
[GitHub] zeppelin issue #2996: ZEPPELIN-3521 Dynamic note form overlaps with paragrap...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2996 LGTM ---
[GitHub] zeppelin issue #2982: [ZEPPELIN-3492] The paragraph's table does not scroll ...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2982 I have tested. LGTM ---
[GitHub] zeppelin issue #2987: ZEPPELIN-3502 Make notebook dynamic forms title editab...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2987 @r-kamath I have tested. It's nice feature for global dynamic form. Thank you! ---
[GitHub] zeppelin pull request #2972: ZEPPELIN-3379. Refactoring of JDBC autocomplete...
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/2972 ZEPPELIN-3379. Refactoring of JDBC autocomplete. ### What is this PR for? Current implementation of autocomplete allows only completion in `schema.table.column` scenario. Such scenario exclude tables for default schema. The PR fixes the scenario with tables in default schema and alias processing. Also I want to add feature to complete columns for used tables in statement from blank cursor. The autocomplete was tested for Greenplum 4.3 (PostgreSQL), Oracle 11g, MySQL (Hive Metastore) and Hive. This PR is reopening of #2970 ### What type of PR is it? Improvement ### What is the Jira issue? [https://issues.apache.org/jira/browse/ZEPPELIN-3379](ZEPPELIN-3379) ### How should this be tested? * Manually * Tests pass ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3379 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2972.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2972 commit 10f70cedb49e7fa5c78c19a9bf29354eece6d090 Author: Maxim Belousov <mebelousov@...> Date: 2018-05-17T09:31:33Z ZEPPELIN-3379 Refactoring of SQL autocomplete commit 9a3a4874fd8be5c8e01db87b8f0ff158e8b34a7a Author: Maxim Belousov <mebelousov@...> Date: 2018-05-17T09:32:36Z Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-3379-JDBC commit 42d9decf761ed3fa52633565dc4363fb82e55b08 Author: Maxim Belousov <mebelousov@...> Date: 2018-05-17T09:51:55Z ZEPPELIN-3379 Removed double star from license test ---
[GitHub] zeppelin pull request #2970: ZEPPELIN-3379 Refactoring of JDBC autocomplete.
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/2970 ---
[GitHub] zeppelin pull request #2970: ZEPPELIN-3379 Refactoring of JDBC autocomplete.
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/2970 ZEPPELIN-3379 Refactoring of JDBC autocomplete. ### What is this PR for? Current implementation of autocomplete allows only completion in `schema.table.column` scenario. Such scenario exclude tables for default schema. The PR fixes the scenario with tables in default schema and alias processing. Also I want to add feature to complete columns for used tables in statement from blank cursor. The autocomplete was tested for Greenplum 4.3 (PostgreSQL), Oracle 11g, MySQL (Hive Metastore) and Hive. ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3379 ### How should this be tested? * Manually * Tests pass ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3379 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2970.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2970 commit f01f3fd63690cc86a8ed344d37d79bc83f209849 Author: mebelousov <mebelousov@...> Date: 2018-05-16T11:26:00Z ZEPPELIN-3379 Refactoring of JDBC autocomplete. ---
[GitHub] zeppelin issue #2930: ZEPPELIN-3414. branch-0.8 - download py4j from main re...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2930 Jeff, you are right. Need rework. ---
[GitHub] zeppelin pull request #2930: ZEPPELIN-3414. branch-0.8 - download py4j from ...
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/2930 ---
[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2925 @weand Thank you! Some addition to 2. Over time user may not belong to group. At first we could store cronExecutingRoles and in future it's to be good to check groups on the fly. ---
[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2925 @zjffdu This is your solution ;) I have tested your branch. Do we have uniform opinion that running document as the group is not good? ---
[GitHub] zeppelin pull request #2930: ZEPPELIN-3414. branch-0.8 - download py4j from ...
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/2930 ZEPPELIN-3414. branch-0.8 - download py4j from main repo ### What is this PR for? Now py4j-0.9.2 is downloaded from "pypi.python.org". Seems that "pypi.python.org" needs new version of OpenSSL. There are some troubles to build Zeppelin on old CentOS/RHEL because is not easy to update OpenSSL. It's good to change repo for py4j. ### What type of PR is it? Small Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3414 ### How should this be tested? * Tests pass ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3414 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2930.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2930 commit 82d03095f39a83ccf245aa4fa12a0e202d09a260 Author: mebelousov <mebelousov@...> Date: 2018-04-18T08:59:59Z ZEPPELIN-3414 Download py4j from main repo ---
[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2925 @weand cronExecutionUser is set to the user who set the cron string inside the note. @zjffdu I define groups in shiro.ini. The user sets groupname in owner field. Then the note runs on cron from this groupname.  ---
[GitHub] zeppelin issue #2848: [Zeppelin-3307] - Improved shared browsing/editing for...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2848 Zeppelin has websockets and two users can view a note simultaneously, but there is a bug. - Open the note in two tabs. - Write anything in first tab for second. - Wait for 10 seconds. - Repeat the last two steps several times. - Check that written code is lost. Thus paired coding is painful. Please review this PR. ---
[GitHub] zeppelin pull request #2907: ZEPPELIN-3347 Fix "PYTHONPATH" for spark.pyspar...
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/2907 ---
[GitHub] zeppelin issue #2615: [ZEPPELIN-1999][IMPROVEMENT] refactoring replacement c...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2615 @zjffdu replaceContext happens every call of jobRun() in RemoteInterpreterServer.java ---
[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2925 @zjffdu I have checked with group as owner. This is ok. Why do you think that use of owner is more secure than cronExecutingUser? ---
[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2925 Groups can be note owners. As I see `AuthenticationInfo` is not valid for internal shiro groups. How can I find the user which scheduled note? ---
[GitHub] zeppelin issue #2920: [ZEPPELIN-2679] JDBC. precode for session
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2920 @zjffdu Another repo and another PR, but the same error https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/365002216 ---
[GitHub] zeppelin pull request #2920: [ZEPPELIN-2679] JDBC. precode for session
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/2920 ---
[GitHub] zeppelin pull request #2920: [ZEPPELIN-2679] JDBC. precode for session
GitHub user mebelousov reopened a pull request:
https://github.com/apache/zeppelin/pull/2920
[ZEPPELIN-2679] JDBC. precode for session
### What is this PR for?
We have a precode for interpreter (all interpreters) which executes once
after start interpreter. With it we can create shared code that will be
available in the paragraph, create tables in the database and etc.
This precode for jdbc only which executes before run paragraph in same
session (sql). In this precode we can declare session variables that will be
available when you run paragraph (any sql which will be executed before the
paragraph). For example `set application_name='#{user};`
Previous discussion in #2442
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2679
### How should this be tested?
(jdbc interpreter, postgres)
1. set property **default.statementPrecode** `set
application_name='#{user}';`
2. run paragraph `select current_setting('application_name');`
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-2679
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2920.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2920
commit bd3d80952ca56e709379632318ba1193a17338ae
Author: Tinkoff DWH <tinkoff.dwh@...>
Date: 2017-06-23T11:58:20Z
[ZEPPELIN-2679] jdbc. precode for session
commit ae7a0d63966a1ddbf89292715221d041ecdc2b74
Author: Tinkoff DWH <tinkoff.dwh@...>
Date: 2017-06-26T04:14:11Z
[ZEPPELIN-2679] tests
commit 719d0a2fdf73a478c4475c8147da8d26646933ff
Author: isys.mreshetov <m.reshetov@...>
Date: 2017-06-29T04:35:10Z
ZEPPELIN-2679 docs
commit 7bba0db8ac7f28c7c35798e3292ec0e8dd08fde8
Author: tinkoff-dwh <tinkoff.dwh@...>
Date: 2018-03-13T09:49:56Z
ZEPPELIN-2679 rename session to statement
commit cd0d6ed5dc455bb58d551519732b274121df5198
Author: tinkoff-dwh <tinkoff.dwh@...>
Date: 2018-03-13T11:12:12Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2679
commit 07b41c5110430f3b13ca81088b29fa5eae3d0734
Author: tinkoff-dwh <tinkoff.dwh@...>
Date: 2018-03-13T12:15:49Z
ZEPPELIN-2679 rename test methods
commit f7529cabe9d68202b6c22f5162d527844d48ba4f
Author: tinkoff-dwh <tinkoff.dwh@...>
Date: 2018-03-14T05:28:21Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2679
# Conflicts:
# jdbc/src/test/java/org/apache/zeppelin/jdbc/JDBCInterpreterTest.java
commit 00aeabf5dcc9b78ce40482ae24aed41da373
Author: tinkoff-dwh <tinkoff.dwh@...>
Date: 2018-03-14T05:37:48Z
ZEPPELIN-2679 fix checkstyle
commit e9d36d2847b3c0246b7242c2d37b1ccd75a262ad
Author: mebelousov <mebelousov@...>
Date: 2018-04-09T06:49:31Z
Merge remote-tracking branch 'apache/master' into ZEPPELIN-2679
# Conflicts:
# jdbc/src/test/java/org/apache/zeppelin/jdbc/JDBCInterpreterTest.java
commit 11f89a590eb5e75830056e2692167cfc72c8124e
Author: mebelousov <mebelousov@...>
Date: 2018-04-09T09:45:56Z
ZEPPELIN-2679 Small fix in docs
---
[GitHub] zeppelin pull request #2920: [ZEPPELIN-2679] JDBC. precode for session
GitHub user mebelousov opened a pull request:
https://github.com/apache/zeppelin/pull/2920
[ZEPPELIN-2679] JDBC. precode for session
### What is this PR for?
We have a precode for interpreter (all interpreters) which executes once
after start interpreter. With it we can create shared code that will be
available in the paragraph, create tables in the database and etc.
This precode for jdbc only which executes before run paragraph in same
session (sql). In this precode we can declare session variables that will be
available when you run paragraph (any sql which will be executed before the
paragraph). For example `set application_name='#{user};`
Previous discussion in #2442
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2679
### How should this be tested?
(jdbc interpreter, postgres)
1. set property **default.statementPrecode** `set
application_name='#{user}';`
2. run paragraph `select current_setting('application_name');`
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-2679
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2920.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2920
commit bd3d80952ca56e709379632318ba1193a17338ae
Author: Tinkoff DWH <tinkoff.dwh@...>
Date: 2017-06-23T11:58:20Z
[ZEPPELIN-2679] jdbc. precode for session
commit ae7a0d63966a1ddbf89292715221d041ecdc2b74
Author: Tinkoff DWH <tinkoff.dwh@...>
Date: 2017-06-26T04:14:11Z
[ZEPPELIN-2679] tests
commit 719d0a2fdf73a478c4475c8147da8d26646933ff
Author: isys.mreshetov <m.reshetov@...>
Date: 2017-06-29T04:35:10Z
ZEPPELIN-2679 docs
commit 7bba0db8ac7f28c7c35798e3292ec0e8dd08fde8
Author: tinkoff-dwh <tinkoff.dwh@...>
Date: 2018-03-13T09:49:56Z
ZEPPELIN-2679 rename session to statement
commit cd0d6ed5dc455bb58d551519732b274121df5198
Author: tinkoff-dwh <tinkoff.dwh@...>
Date: 2018-03-13T11:12:12Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2679
commit 07b41c5110430f3b13ca81088b29fa5eae3d0734
Author: tinkoff-dwh <tinkoff.dwh@...>
Date: 2018-03-13T12:15:49Z
ZEPPELIN-2679 rename test methods
commit f7529cabe9d68202b6c22f5162d527844d48ba4f
Author: tinkoff-dwh <tinkoff.dwh@...>
Date: 2018-03-14T05:28:21Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2679
# Conflicts:
# jdbc/src/test/java/org/apache/zeppelin/jdbc/JDBCInterpreterTest.java
commit 00aeabf5dcc9b78ce40482ae24aed41da373
Author: tinkoff-dwh <tinkoff.dwh@...>
Date: 2018-03-14T05:37:48Z
ZEPPELIN-2679 fix checkstyle
commit e9d36d2847b3c0246b7242c2d37b1ccd75a262ad
Author: mebelousov <mebelousov@...>
Date: 2018-04-09T06:49:31Z
Merge remote-tracking branch 'apache/master' into ZEPPELIN-2679
# Conflicts:
# jdbc/src/test/java/org/apache/zeppelin/jdbc/JDBCInterpreterTest.java
commit 11f89a590eb5e75830056e2692167cfc72c8124e
Author: mebelousov <mebelousov@...>
Date: 2018-04-09T09:45:56Z
ZEPPELIN-2679 Small fix in docs
---
[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2442 Cache is clean now. I try to retrigger from both accounts. The result is the sameÑ ---
[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2442 @zjffdu I have retriggered several times. Travis fails with the same error on all jobs. ---
[GitHub] zeppelin pull request #2907: ZEPPELIN-3347 Fix "PYTHONPATH" for spark.pyspar...
GitHub user mebelousov opened a pull request:
https://github.com/apache/zeppelin/pull/2907
ZEPPELIN-3347 Fix "PYTHONPATH" for spark.pyspark in branch-0.8
### What is this PR for?
Use system PYTHONPATH in spark.pyspark interpreter, if PYTHONPATH already
exists in environment variables.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3347
### How should this be tested?
* Add some directories to PYTHONPATH
`export PYTHONPATH="/opt/python/dir1:/opt/python/dir2:$PYTHONPATH"`
* Build branch "ZEPPELIN-3347_0.8"
* Run in %spark.pyspark
```
import sys
print('\n'.join(sys.path))
```
* Check that the directories are in the output list.
Compare with the result in %python.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin
ZEPPELIN-3347_0.8
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2907.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2907
commit 8ada1e35dffabcb415e31c1e7232a9f24f2bed94
Author: mebelousov <mebelousov@...>
Date: 2018-04-03T14:07:08Z
ZEPPELIN-3347 Fix "PYTHONPATH" for spark.pyspark
---
[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2442 @zjffdu hooks are user defined code. We want to have opportunity to log the user sessions, to bind queries to notes. It can be possible only by force execution of special query before user queries, that is in precode. ---
[GitHub] zeppelin pull request #2896: ZEPPELIN-3347. Fix "PYTHONPATH" for spark.pyspa...
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/2896 ---
[GitHub] zeppelin issue #2896: ZEPPELIN-3347. Fix "PYTHONPATH" for spark.pyspark
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2896 @zjffdu has closed this issue in #2901 ---
[GitHub] zeppelin pull request #2896: ZEPPELIN-3347. Fix "PYTHONPATH" for spark.pyspa...
GitHub user mebelousov opened a pull request:
https://github.com/apache/zeppelin/pull/2896
ZEPPELIN-3347. Fix "PYTHONPATH" for spark.pyspark
### What is this PR for?
Use system PYTHONPATH in spark.pyspark interpreter, if PYTHONPATH already
exists in environment variables.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3347
### How should this be tested?
* Add some directories to PYTHONPATH
`export PYTHONPATH="/opt/python/dir1:/opt/python/dir2:$PYTHONPATH"`
* Build branch "ZEPPELIN-3347"
* Run in %spark.pyspark
```
import sys
print('\n'.join(sys.path))
```
* Check that the directories are in the output list.
Compare with the result in %python.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3347
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2896.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2896
commit 4dbb5718f189823d707853389614ad14e023ee64
Author: mebelousov <mebelousov@...>
Date: 2018-03-27T12:09:39Z
ZEPPELIN-3347 Fix "PYTHONPATH" if it already exists in env.
---
[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2442 @zjffdu The hooks as pre-code were discussed [previously ](https://github.com/apache/zeppelin/pull/2096#issuecomment-284220634) We want precode execute before pre-hook for easy finding the note. Meanwhile the hooks doesn't realized in JDBC interpreter. The JDBC interpreter allow to split query and precode must run before each statement in paragraph. Therefore the single way for precode for all interpreters looks unrealizable. The rename to `zeppelin.interpreter.precode` is good idea. Do this? ---
[GitHub] zeppelin pull request #2876: ZEPPELIN-3344. Revert comments in queries in JD...
GitHub user mebelousov reopened a pull request: https://github.com/apache/zeppelin/pull/2876 ZEPPELIN-3344. Revert comments in queries in JDBC interpreter ### What is this PR for? The original purpose of https://github.com/apache/zeppelin/pull/2158 was correct processing of ';'. This was done via full removing comments from code. Unfortunately Apache Phoenix uses hooks in comments https://forcedotcom.github.io/phoenix/#hintml. Thus we should not delete comments in scripts. There was discussion about comment rules for different databases (solr). The right way is keep style. Thus analysts can copy queries to another tool and can get same results and errors. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3344 ### How should this be tested? * Unit tests pass: testSplitSqlQueryWithComments and testSplitSqlQuery ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-3344 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2876.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2876 commit eed54c89216e4e07e4c82b82f6a740928969205d Author: mebelousov <mebelousov@...> Date: 2018-03-16T13:26:06Z ZEPPELIN-3344 Revert comments in JDBC interpreter commit 83c8e8faa5ba6b0e46ed51d530b2b3bae362d036 Author: mebelousov <mebelousov@...> Date: 2018-03-16T13:34:42Z ZEPPELIN-3344 Rename test commit 698040083ce53c449a11133e0e3dc14e6e21d138 Author: mebelousov <mebelousov@...> Date: 2018-03-20T05:57:02Z ZEPPELIN-3344 Fix checkstyle, add tests for comments ---
[GitHub] zeppelin pull request #2876: ZEPPELIN-3344. Revert comments in queries in JD...
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/2876 ---
[GitHub] zeppelin issue #2716: [ZEPPELIN-3123] Fix to create pid per each interpreter
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2716 @woowahan-jaehoon thank you! Perhaps #2780 will delete all unused pid files and you can add the port to the pid filename. ---
[GitHub] zeppelin issue #2852: [ZEPPELIN-3264] Notebook Snapshot feature.
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2852 Will the git storage allow to delete older snapshots? I see the scenario: every day create new snapshot and delete the oldest snapshot. ---
[GitHub] zeppelin pull request #2876: ZEPPELIN-3344. Revert comments in queries in JD...
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/2876 ZEPPELIN-3344. Revert comments in queries in JDBC interpreter ### What is this PR for? The original purpose of https://github.com/apache/zeppelin/pull/2158 was correct processing of ';'. This was done via full removing comments from code. Unfortunately Apache Phoenix uses hooks in comments https://forcedotcom.github.io/phoenix/#hintml. Thus we should not delete comments in scripts. There was discussion about comment rules for different databases (solr). The right way is keep style. Thus analysts can copy queries to another tool and can get same results and errors. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-3344] ### How should this be tested? * Unit tests pass: testSplitSqlQueryWithComments and testSplitSqlQuery ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-3344 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2876.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2876 commit eed54c89216e4e07e4c82b82f6a740928969205d Author: mebelousov <mebelousov@...> Date: 2018-03-16T13:26:06Z ZEPPELIN-3344 Revert comments in JDBC interpreter commit 83c8e8faa5ba6b0e46ed51d530b2b3bae362d036 Author: mebelousov <mebelousov@...> Date: 2018-03-16T13:34:42Z ZEPPELIN-3344 Rename test ---
[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2442 @zjffdu, you are right, sessionPrecode is renamed to statementPrecode. Since 0.8.0 I will recommend to run JDBC interpreter per note in isolated mode due to Interpreter Lifecycle Manager: the table results accumulate in ResourcePool and JVMs grow in size, but ILM will drop non-active JVMs. ---
[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/2442
@zjffdu @felixcheung
Every day our users run about 1000 queries in the Greenplum (open source
Postgres-based DB).
There is great need for binding the query to the user and/or to the note.
The precode `set application_name=#{noteId};` allows quickly find the note.
This precode must be set by Zeppelin administrator, business users will not
write any precode in each note for each jdbc-interpreter.
I believe the precode in JDBC interpreter is necessary feature for
entreprise users.
---
[GitHub] zeppelin issue #2716: [ZEPPELIN-3123] Fix to create pid per each interpreter
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2716 @woowahan-jaehoon , could you test `nohup` instead of `eval`? ---
[GitHub] zeppelin issue #2821: [ZEPPELIN-3271] Option for disabling scheduler
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2821 It's sufficient to have only `zeppelin.notebook.cron.folders`. If this parameter is set to `*` - scheduling can be in all folders. If `System/*, Testing/*` - only in those folders. Thus if one will copy notes from production to another Zeppelin server and will change `zeppelin.notebook.cron.folders` to specific folder, he could test and use this server without removing of cron in notes. ---
[GitHub] zeppelin issue #2821: [ZEPPELIN-3271] Option for disabling scheduler
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2821 @prabhjyotsingh , I dreamed about this feature: [dev mailing list](https://lists.apache.org/thread.html/eb13b9dbd4a57c5e1e93297d7bde012e7f975bd2a0eb2a2a18c2d0ce@)! Now I think it would be useful define folders in which notes can be scheduled. By default notes can be scheduled everywhere and the config parameter can limit scheduling to only special folders, for example "System/" or "Testing/". What do you think about such parameter? ---
[GitHub] zeppelin issue #2817: [ZEPPELIN-3264] Notebook Snapshot feature.
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2817 @SleepyThread thank you! This is a nice feature. If the PR will be approved it would be great to have next functionality: - limit the number of snapshots and/or life time of snapshot - create snapshot for each cron run ---
[GitHub] zeppelin issue #2782: [ZEPPELIN-2729] Paragraph numbering
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2782 I would prefer that the paragraph title is always added to the ToC as high-level section. ---
[GitHub] zeppelin issue #2801: ZEPPELIN-3159. Fixed Checkstyle errors and warnings in...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2801 Let's merge this. ---
[GitHub] zeppelin issue #2804: [DISCUSS] semicolons in javascript
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2804 @prabhjyotsingh it's great that one of PMC file such PR. A lot of tests show that JS works faster without syntax warnings. :+1: ---
[GitHub] zeppelin pull request #2752: [ZEPPELIN-3195] Remove the limit on the number ...
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/2752 ---
[GitHub] zeppelin issue #2752: [ZEPPELIN-3195] Remove the limit on the number of run ...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2752 @zjffdu @felixcheung What will we do with this bug? ---
[GitHub] zeppelin issue #2794: ZEPPELIN-3225: Add a bunch of missing annotations to A...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2794 Our team uses AD. I have tested. Seems that it works good. ---
[GitHub] zeppelin issue #2782: [ZEPPELIN-2729] Paragraph numbering
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2782 @Tagar there is "zeppelin-toc-spell" in the Helium packages. Now it supports only headers inside markdown interpreter. It will be good to bring new functions to "zeppelin-toc-spell".  ---
[GitHub] zeppelin issue #2782: [ZEPPELIN-2729] Paragraph numbering
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2782 @timovwb I also thought about good way to point on the right paragraph. How about to add new item in drop-down paragraph menu (like "Link this paragraph") that will form url for this paragraph in note? ---
[GitHub] zeppelin issue #2780: [ZEPPELIN-3215] Fix to remove pid of interpreter when ...
Github user mebelousov commented on the issue:
https://github.com/apache/zeppelin/pull/2780
@woowahan-jaehoon , thank you!
Can we remove `rm -f "${ZEPPELIN_PID}"` from "shutdown_hook"?
---
[GitHub] zeppelin issue #2752: [ZEPPELIN-3195] Remove the limit on the number of run ...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2752 I renewed docs: remove old "ZEPPELIN_INTERPRETERS" and added ZEPPELIN_INTERPRETER_MAX_POOL_SIZE. The default value for ZEPPELIN_INTERPRETER_MAX_POOL_SIZE remains 10. ---
[GitHub] zeppelin issue #2752: [ZEPPELIN-3195] Remove the limit on the number of run ...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2752 @felixcheung Where I could document about ZEPPELIN_INTERPRETER_MAX_POOL_SIZE? There is no such cases in documentation. Also I cannot imagine than Zeppelin administrator will go to documentation when users will complain that manual note run is OK but only 10 first paragraphs are done at cron. ---
[GitHub] zeppelin issue #2752: [ZEPPELIN-3195] Remove the limit on the number of run ...
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2752 It's not easy to understand that "ZEPPELIN_INTERPRETER_MAX_POOL_SIZE" affects the number of paragraphs executed at cron. I would be glad if nobody will meet this bug and no need to change zeppelin-site.xml to fix note scheduling. @zjffdu which number will be more appropriate? =) ---
[GitHub] zeppelin pull request #2752: [ZEPPELIN-3195] Remove the limit on the number ...
GitHub user mebelousov opened a pull request: https://github.com/apache/zeppelin/pull/2752 [ZEPPELIN-3195] Remove the limit on the number of run paragraphs at cron ### What is this PR for? Increase interpreter pool size for unlimit the number of paragraph that run at cron schedule. ### What type of PR is it? [Hot Fix] ### What is the Jira issue? *https://issues.apache.org/jira/browse/ZEPPELIN-3195 ### How should this be tested? * Create note with 15 paragraphs * Check that at cron will be executed only 10 paragraphs * Checkout this branch and rebuild app * Check that all paragraphs are executed at cron ### Questions: * Does the licenses files need update? NA * Is there breaking changes for older versions? NA * Does this needs documentation? NA You can merge this pull request into a Git repository by running: $ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-3195 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2752.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2752 commit 827054ce769b7c61ff8344c4df19f09ef5598e80 Author: mebelousov <mebelousov@...> Date: 2018-01-30T18:58:00Z ZEPPELIN-3195 Increase interpreter pool size ---
