[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Github user imamura-kaicho commented on the issue: https://github.com/apache/zeppelin/pull/2483 Not an issue, but had challenge when using mvn build. Current pom has wagon plugin to download py4j.zip from pypi, but under proxy, it didn't work. I tried with this options to change url, but it also failed. Finally, figured out my wagon plugin has problem when using proxy. https://issues.apache.org/jira/browse/MNG-5237 I added following in pom.xml and resolved. org.apache.maven.wagon wagon-http-lightweight 2.2 ---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2483 thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2483 CI passed https://travis-ci.org/nokia/zeppelin/builds/256876805 merge if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2483 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2483 @1ambda travis link: https://travis-ci.org/nokia/zeppelin/builds/256876805 I think that tests are not really "stable", I mean, they are time and context dependent. i.e. if one test doesn't clean properly it's execution env next test will fail selenium tests should be splitted to use less time. It will require time, sorry I do not have enough to contribute this fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2483 Sure. BTW, I couldn't find the Travis link. It seems that Github changed the URL in ![image](https://user-images.githubusercontent.com/4968473/28603185-a3690216-71fd-11e7-855c-808d8cd2019e.png) Can I get the Travis build link for this PR? Additionally, > it is incredibly annoying for contributors to have to "baby-sit" Travis to get a green CI here :-S Do you have any ideas for improving this situation? Any feedback or suggestion is welcome. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2483 I agree that this has got a really low priority, but could I kindly ask for review to keep this into master since it does not break anything and just add some added flexibility to the build? Thanks a lot in advance. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2483 added a small section under the mentioned `Md` file @1ambda please let me know if anything else is needed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2483 Is this enough place to describe build options? What do you think of? - http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/setup/basics/how_to_build.html#build-command-examples --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2483 @1ambda haven't found any specific section in docs mentioning settings in maven profiles... could you point me to a section that could be improved with this additions? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2483 Can we write docs to let the user know they can set these options using maven profile? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2483 should I do anything else to get this merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2483 B,T,W, it is incredibly annoying for contributors to have to "baby-sit" travis to get a green CI here :-S --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2483 rebased on top of master, removed a typo and removed `downloadRoot` parameter that turns out to be `deprecated` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2483 yes, :-) done! @felixcheung --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2483 yes of course @felixcheung , basically I'm exposing through maven properties the ability for users to customize where to download from certain packets that are normally downloaded from very specific internet resources. In this way one can build zeppelin from sources specifying faster or internal or more reliable addresses for those packages. You can note that this does not break anything but just expose some plugin capabilities to users and fallback to proper default one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---