ZooKeeper-trunk-solaris - Build # 395 - Failure
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/395/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 148842 lines...] [junit] 2012-11-28 10:52:23,522 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2012-11-28 10:52:23,522 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2012-11-28 10:52:23,522 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2012-11-28 10:52:23,522 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2012-11-28 10:52:23,523 [myid:] - INFO [main:ClientBase@427] - STOPPING server [junit] 2012-11-28 10:52:23,523 [myid:] - INFO [main:ZooKeeperServer@399] - shutting down [junit] 2012-11-28 10:52:23,523 [myid:] - INFO [main:SessionTrackerImpl@225] - Shutting down [junit] 2012-11-28 10:52:23,523 [myid:] - INFO [main:PrepRequestProcessor@733] - Shutting down [junit] 2012-11-28 10:52:23,524 [myid:] - INFO [main:SyncRequestProcessor@175] - Shutting down [junit] 2012-11-28 10:52:23,524 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@142] - PrepRequestProcessor exited loop! [junit] 2012-11-28 10:52:23,524 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@155] - SyncRequestProcessor exited! [junit] 2012-11-28 10:52:23,524 [myid:] - INFO [main:FinalRequestProcessor@411] - shutdown of request processor complete [junit] 2012-11-28 10:52:23,525 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2012-11-28 10:52:23,525 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[] [junit] 2012-11-28 10:52:23,526 [myid:] - INFO [main:ClientBase@420] - STARTING server [junit] 2012-11-28 10:52:23,526 [myid:] - INFO [main:ZooKeeperServer@147] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test3186579174569139712.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test3186579174569139712.junit.dir/version-2 [junit] 2012-11-28 10:52:23,527 [myid:] - INFO [main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2012-11-28 10:52:23,527 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test3186579174569139712.junit.dir/version-2/snapshot.b [junit] 2012-11-28 10:52:23,529 [myid:] - INFO [main:FileTxnSnapLog@270] - Snapshotting: 0xb to /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test3186579174569139712.junit.dir/version-2/snapshot.b [junit] 2012-11-28 10:52:23,530 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2012-11-28 10:52:23,531 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - Accepted socket connection from /127.0.0.1:35546 [junit] 2012-11-28 10:52:23,531 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@817] - Processing stat command from /127.0.0.1:35546 [junit] 2012-11-28 10:52:23,531 [myid:] - INFO [Thread-5:NIOServerCnxn$StatCommand@653] - Stat command output [junit] 2012-11-28 10:52:23,531 [myid:] - INFO [Thread-5:NIOServerCnxn@997] - Closed socket connection for client /127.0.0.1:35546 (no session established for client) [junit] 2012-11-28 10:52:23,532 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2012-11-28 10:52:23,533 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2012-11-28 10:52:23,533 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2012-11-28 10:52:23,533 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2012-11-28 10:52:23,533 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2012-11-28 10:52:23,533 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota [junit] 2012-11-28 10:52:23,533 [myid:] - INFO [main:ClientBase@457] - tearDown starting [junit] 2012-11-28 10:52:23,614 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@509] - EventThread shut down [junit] 2012-11-28 10:52:23,614 [myid:] - INFO [main:ZooKeeper@744] - Session: 0x13b46a566e0 closed [junit]
[jira] [Commented] (ZOOKEEPER-1590) Patch to add zk.updateServerList(newServerList) broke the build
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505365#comment-13505365
]
Hudson commented on ZOOKEEPER-1590:
---
Integrated in ZooKeeper-trunk #1757 (See
[https://builds.apache.org/job/ZooKeeper-trunk/1757/])
ZOOKEEPER-1590. Patch to add zk.updateServerList(newServerList) broke the
build (fpj via phunt) (Revision 1414556)
Result = SUCCESS
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1414556
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/docs/index.html
* /zookeeper/trunk/docs/index.pdf
* /zookeeper/trunk/docs/javaExample.html
* /zookeeper/trunk/docs/javaExample.pdf
* /zookeeper/trunk/docs/linkmap.html
* /zookeeper/trunk/docs/linkmap.pdf
* /zookeeper/trunk/docs/recipes.html
* /zookeeper/trunk/docs/recipes.pdf
* /zookeeper/trunk/docs/releasenotes.html
* /zookeeper/trunk/docs/releasenotes.pdf
* /zookeeper/trunk/docs/zookeeperAdmin.html
* /zookeeper/trunk/docs/zookeeperAdmin.pdf
* /zookeeper/trunk/docs/zookeeperHierarchicalQuorums.html
* /zookeeper/trunk/docs/zookeeperHierarchicalQuorums.pdf
* /zookeeper/trunk/docs/zookeeperInternals.html
* /zookeeper/trunk/docs/zookeeperInternals.pdf
* /zookeeper/trunk/docs/zookeeperJMX.html
* /zookeeper/trunk/docs/zookeeperJMX.pdf
* /zookeeper/trunk/docs/zookeeperObservers.html
* /zookeeper/trunk/docs/zookeeperObservers.pdf
* /zookeeper/trunk/docs/zookeeperOver.html
* /zookeeper/trunk/docs/zookeeperOver.pdf
* /zookeeper/trunk/docs/zookeeperProgrammers.html
* /zookeeper/trunk/docs/zookeeperProgrammers.pdf
* /zookeeper/trunk/docs/zookeeperQuotas.html
* /zookeeper/trunk/docs/zookeeperQuotas.pdf
* /zookeeper/trunk/docs/zookeeperStarted.html
* /zookeeper/trunk/docs/zookeeperStarted.pdf
* /zookeeper/trunk/docs/zookeeperTutorial.html
* /zookeeper/trunk/docs/zookeeperTutorial.pdf
*
/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
Patch to add zk.updateServerList(newServerList) broke the build
---
Key: ZOOKEEPER-1590
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1590
Project: ZooKeeper
Issue Type: Bug
Affects Versions: 3.5.0
Reporter: Flavio Junqueira
Assignee: Flavio Junqueira
Priority: Blocker
Fix For: 3.5.0
Attachments: ZOOKEEPER-1590.patch
Here is the related output of jenkins:
{noformat}
validate-xdocs:
[exec]
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml:578:5:
The element type para must be terminated by the matching end-tag /para.
[exec]
[exec] BUILD FAILED
[exec] /home/jenkins/tools/forrest/latest/main/targets/validate.xml:135:
Could not validate document
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
[exec]
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1474) Cannot build Zookeeper with IBM Java: use of Sun MXBean classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505364#comment-13505364 ] Hudson commented on ZOOKEEPER-1474: --- Integrated in ZooKeeper-trunk #1757 (See [https://builds.apache.org/job/ZooKeeper-trunk/1757/]) ZOOKEEPER-1474. Cannot build Zookeeper with IBM Java: use of Sun MXBean classes (Adalberto Medeiros via phunt) (Revision 1414566) Result = SUCCESS phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1414566 Files : * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/util/OSMXBean.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/OSMXBeanTest.java Cannot build Zookeeper with IBM Java: use of Sun MXBean classes --- Key: ZOOKEEPER-1474 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1474 Project: ZooKeeper Issue Type: Bug Components: build Affects Versions: 3.4.0, 3.4.3, 3.4.4, 3.4.5 Reporter: Adalberto Medeiros Assignee: Paulo Ricardo Paz Vital Labels: build Fix For: 3.5.0, 3.4.6 Attachments: zookeeper-1474.patch, zookeeper-1474-v2.patch, zookeeper-1474-v3.patch, ZOOKEEPER-1474-v4.patch, ZOOKEEPER-1474-v5.patch, ZOOKEEPER-1474-v6.patch zookeeper.server.NIOServerCnxn and zookeeper.server.NettyServerCnxn imports com.sun.management.UnixOperatingSystemMXBean . This OperatingSystemMXBean class is not implemented by IBM or open java. In my case, I need IBM Java so I can run zookeeper in Power ppc64 servers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital updated ZOOKEEPER-1564: --- Summary: Allow JUnit test build with IBM Java (was: Allow ClientBase.java build with IBM Java) Allow JUnit test build with IBM Java Key: ZOOKEEPER-1564 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1564 Project: ZooKeeper Issue Type: Improvement Components: tests Affects Versions: 3.4.4 Environment: Linux, RHEL 6.3, IBM Java 6 SR 11 Reporter: Paulo Ricardo Paz Vital Labels: test Fix For: 3.4.4 Attachments: zookeeper-1564.patch The org.apache.zookeeper.test.ClientBase class imports the com.sun.management.UnixOperatingSystemMXBean class, that fail to build when using IBM Java 6 SR 11. This issue is resolved by new class OSMXBean class proposed in JIRA's 1474. The class OSMXBean (org.apache.zookeeper.server.util.OSMXBean) is a wrapper for the implementation of com.sun.management.UnixOperatingSystemMXBean, and decides to use the SUN API or its own implementation depending on the runtime (vendor) used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital updated ZOOKEEPER-1564: --- Description: The org.apache.zookeeper.test.ClientBase, org.apache.zookeeper.test.ClientTest, org.apache.zookeeper.test.QuorumBase and org.apache.zookeeper.test.QuorumUtil classes import the com.sun.management.UnixOperatingSystemMXBean class, that fail to build when using IBM Java 6 SR 11. This issue is resolved by new class OSMXBean class proposed in JIRA's ZOOKEEPER-1474. The class OSMXBean (org.apache.zookeeper.server.util.OSMXBean) is a wrapper for the implementation of com.sun.management.UnixOperatingSystemMXBean, and decides to use the SUN API or its own implementation depending on the runtime (vendor) used. was: The org.apache.zookeeper.test.ClientBase class imports the com.sun.management.UnixOperatingSystemMXBean class, that fail to build when using IBM Java 6 SR 11. This issue is resolved by new class OSMXBean class proposed in JIRA's 1474. The class OSMXBean (org.apache.zookeeper.server.util.OSMXBean) is a wrapper for the implementation of com.sun.management.UnixOperatingSystemMXBean, and decides to use the SUN API or its own implementation depending on the runtime (vendor) used. Allow JUnit test build with IBM Java Key: ZOOKEEPER-1564 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1564 Project: ZooKeeper Issue Type: Improvement Components: tests Affects Versions: 3.4.4 Environment: Linux, RHEL 6.3, IBM Java 6 SR 11 Reporter: Paulo Ricardo Paz Vital Labels: test Fix For: 3.4.4 Attachments: zookeeper-1564.patch The org.apache.zookeeper.test.ClientBase, org.apache.zookeeper.test.ClientTest, org.apache.zookeeper.test.QuorumBase and org.apache.zookeeper.test.QuorumUtil classes import the com.sun.management.UnixOperatingSystemMXBean class, that fail to build when using IBM Java 6 SR 11. This issue is resolved by new class OSMXBean class proposed in JIRA's ZOOKEEPER-1474. The class OSMXBean (org.apache.zookeeper.server.util.OSMXBean) is a wrapper for the implementation of com.sun.management.UnixOperatingSystemMXBean, and decides to use the SUN API or its own implementation depending on the runtime (vendor) used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
ZooKeeper-trunk-WinVS2008 - Build # 598 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/598/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 108 lines...] [javac] Compiling 39 source files to f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\build\classes compile_jute_uptodate: compile_jute: [mkdir] Created dir: f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\java\generated [mkdir] Created dir: f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\generated [java] ../../zookeeper.jute Parsed Successfully [java] ../../zookeeper.jute Parsed Successfully [touch] Creating f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\java\generated\.generated BUILD SUCCESSFUL Total time: 22 seconds [ZooKeeper-trunk-WinVS2008] $ cmd /c call C:\Users\hudson\AppData\Local\Temp\hudson6492571916530585252.bat f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008set ZOOKEEPER_HOME=f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008msbuild trunk/src/c/zookeeper.sln /p:Configuration=Release Microsoft (R) Build Engine Version 3.5.30729.1 [Microsoft .NET Framework, Version 2.0.50727.4223] Copyright (C) Microsoft Corporation 2007. All rights reserved. Build started 11/28/2012 11:16:00 AM. Project f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln on node 0 (default targets). Building solution configuration Release|Win32. cl : Command line warning D9035: option 'Wp64' has been deprecated and will be removed in a future release f:\hudson\hudson-slave\workspace\zookeeper-trunk-winvs2008\trunk\src\c\src\addrvec.h(22): fatal error C1083: Cannot open include file: 'inttypes.h': No such file or directory .\src\zk_log.c(120): warning C4996: '_snprintf': This function or variable may be unsafe. Consider using _snprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. .\src\zk_log.c(134): warning C4996: 'getpid': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _getpid. See online help for details. .\src\zk_log.c(160): warning C4996: 'vsnprintf': This function or variable may be unsafe. Consider using vsnprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. f:\hudson\hudson-slave\workspace\zookeeper-trunk-winvs2008\trunk\src\c\src\addrvec.h(22): fatal error C1083: Cannot open include file: 'inttypes.h': No such file or directory f:\hudson\hudson-slave\workspace\zookeeper-trunk-winvs2008\trunk\src\c\src\addrvec.h(22): fatal error C1083: Cannot open include file: 'inttypes.h': No such file or directory Done Building Project f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln (default targets) -- FAILED. Build FAILED. f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln (default target) (1) - (zookeeper target) - cl : Command line warning D9035: option 'Wp64' has been deprecated and will be removed in a future release .\src\zk_log.c(120): warning C4996: '_snprintf': This function or variable may be unsafe. Consider using _snprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. .\src\zk_log.c(134): warning C4996: 'getpid': The POSIX name for this item is deprecated. Instead, use the ISO C++ conformant name: _getpid. See online help for details. .\src\zk_log.c(160): warning C4996: 'vsnprintf': This function or variable may be unsafe. Consider using vsnprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008\trunk\src\c\zookeeper.sln (default target) (1) - (zookeeper target) - f:\hudson\hudson-slave\workspace\zookeeper-trunk-winvs2008\trunk\src\c\src\addrvec.h(22): fatal error C1083: Cannot open include file: 'inttypes.h': No such file or directory f:\hudson\hudson-slave\workspace\zookeeper-trunk-winvs2008\trunk\src\c\src\addrvec.h(22): fatal error C1083: Cannot open include file: 'inttypes.h': No such file or directory f:\hudson\hudson-slave\workspace\zookeeper-trunk-winvs2008\trunk\src\c\src\addrvec.h(22): fatal error C1083: Cannot open include file: 'inttypes.h': No such file or directory 4 Warning(s) 3 Error(s) Time Elapsed 00:00:13.91 f:\hudson\hudson-slave\workspace\ZooKeeper-trunk-WinVS2008exit 1 Build step 'Execute Windows batch command' marked build as failure Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Updated] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital updated ZOOKEEPER-1564: --- Affects Version/s: 3.4.5 Allow JUnit test build with IBM Java Key: ZOOKEEPER-1564 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1564 Project: ZooKeeper Issue Type: Improvement Components: tests Affects Versions: 3.4.4, 3.4.5 Environment: Linux, RHEL 6.3, IBM Java 6 SR 11 Reporter: Paulo Ricardo Paz Vital Labels: test Fix For: 3.4.4, 3.4.5 Attachments: zookeeper-1564.patch The org.apache.zookeeper.test.ClientBase, org.apache.zookeeper.test.ClientTest, org.apache.zookeeper.test.QuorumBase and org.apache.zookeeper.test.QuorumUtil classes import the com.sun.management.UnixOperatingSystemMXBean class, that fail to build when using IBM Java 6 SR 11. This issue is resolved by new class OSMXBean class proposed in JIRA's ZOOKEEPER-1474. The class OSMXBean (org.apache.zookeeper.server.util.OSMXBean) is a wrapper for the implementation of com.sun.management.UnixOperatingSystemMXBean, and decides to use the SUN API or its own implementation depending on the runtime (vendor) used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital reassigned ZOOKEEPER-1564: -- Assignee: Paulo Ricardo Paz Vital Allow JUnit test build with IBM Java Key: ZOOKEEPER-1564 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1564 Project: ZooKeeper Issue Type: Improvement Components: tests Affects Versions: 3.4.4, 3.4.5 Environment: Linux, RHEL 6.3, IBM Java 6 SR 11 Reporter: Paulo Ricardo Paz Vital Assignee: Paulo Ricardo Paz Vital Labels: test Fix For: 3.4.4, 3.4.5 Attachments: zookeeper-1564.patch The org.apache.zookeeper.test.ClientBase, org.apache.zookeeper.test.ClientTest, org.apache.zookeeper.test.QuorumBase and org.apache.zookeeper.test.QuorumUtil classes import the com.sun.management.UnixOperatingSystemMXBean class, that fail to build when using IBM Java 6 SR 11. This issue is resolved by new class OSMXBean class proposed in JIRA's ZOOKEEPER-1474. The class OSMXBean (org.apache.zookeeper.server.util.OSMXBean) is a wrapper for the implementation of com.sun.management.UnixOperatingSystemMXBean, and decides to use the SUN API or its own implementation depending on the runtime (vendor) used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital updated ZOOKEEPER-1564: --- Fix Version/s: 3.4.5 Allow JUnit test build with IBM Java Key: ZOOKEEPER-1564 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1564 Project: ZooKeeper Issue Type: Improvement Components: tests Affects Versions: 3.4.4, 3.4.5 Environment: Linux, RHEL 6.3, IBM Java 6 SR 11 Reporter: Paulo Ricardo Paz Vital Labels: test Fix For: 3.4.4, 3.4.5 Attachments: zookeeper-1564.patch The org.apache.zookeeper.test.ClientBase, org.apache.zookeeper.test.ClientTest, org.apache.zookeeper.test.QuorumBase and org.apache.zookeeper.test.QuorumUtil classes import the com.sun.management.UnixOperatingSystemMXBean class, that fail to build when using IBM Java 6 SR 11. This issue is resolved by new class OSMXBean class proposed in JIRA's ZOOKEEPER-1474. The class OSMXBean (org.apache.zookeeper.server.util.OSMXBean) is a wrapper for the implementation of com.sun.management.UnixOperatingSystemMXBean, and decides to use the SUN API or its own implementation depending on the runtime (vendor) used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital updated ZOOKEEPER-1564: --- Attachment: ZOOKEEPER-1564-v2.patch Patch using the wrapper class OSMXBean added by fix of the issue ZK-1474. This patch was created upon trunk repository. Allow JUnit test build with IBM Java Key: ZOOKEEPER-1564 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1564 Project: ZooKeeper Issue Type: Improvement Components: tests Affects Versions: 3.4.4, 3.4.5 Environment: Linux, RHEL 6.3, IBM Java 6 SR 11 Reporter: Paulo Ricardo Paz Vital Assignee: Paulo Ricardo Paz Vital Labels: test Fix For: 3.4.4, 3.4.5 Attachments: zookeeper-1564.patch, ZOOKEEPER-1564-v2.patch The org.apache.zookeeper.test.ClientBase, org.apache.zookeeper.test.ClientTest, org.apache.zookeeper.test.QuorumBase and org.apache.zookeeper.test.QuorumUtil classes import the com.sun.management.UnixOperatingSystemMXBean class, that fail to build when using IBM Java 6 SR 11. This issue is resolved by new class OSMXBean class proposed in JIRA's ZOOKEEPER-1474. The class OSMXBean (org.apache.zookeeper.server.util.OSMXBean) is a wrapper for the implementation of com.sun.management.UnixOperatingSystemMXBean, and decides to use the SUN API or its own implementation depending on the runtime (vendor) used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ZOOKEEPER-1565) Allow ClientTest.java build with IBM Java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital resolved ZOOKEEPER-1565. Resolution: Duplicate Duplicate of ZOOKEEPER-1564 Allow ClientTest.java build with IBM Java - Key: ZOOKEEPER-1565 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1565 Project: ZooKeeper Issue Type: Improvement Components: tests Affects Versions: 3.4.4 Environment: Linux, RHEL 6.3, IBM Java 6 SR 11 Reporter: Paulo Ricardo Paz Vital Labels: test Fix For: 3.4.4 Attachments: zookeeper-1565.patch The org.apache.zookeeper.test.ClientTest class imports the com.sun.management.UnixOperatingSystemMXBean class, that fail to build when using IBM Java 6 SR 11. This issue is resolved by new class OSMXBean class proposed in JIRA's 1474. The class OSMXBean (org.apache.zookeeper.server.util.OSMXBean) is a wrapper for the implementation of com.sun.management.UnixOperatingSystemMXBean, and decides to use the SUN API or its own implementation depending on the runtime (vendor) used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ZOOKEEPER-1570) Allow QuorumBase.java build with IBM Java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital resolved ZOOKEEPER-1570. Resolution: Duplicate Duplicate of ZOOKEEPER-1564 Allow QuorumBase.java build with IBM Java - Key: ZOOKEEPER-1570 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1570 Project: ZooKeeper Issue Type: Improvement Components: tests Affects Versions: 3.4.4 Environment: Linux, RHEL 6.3, IBM Java 6 SR 11 Reporter: Paulo Ricardo Paz Vital Labels: test Fix For: 3.4.4 Attachments: zookeeper-1570.patch The org.apache.zookeeper.test.QuorumBase class imports the com.sun.management.UnixOperatingSystemMXBean class, that fail to build when using IBM Java 6 SR 11. This issue is resolved by new class OSMXBean class proposed in JIRA's 1474. The class OSMXBean (org.apache.zookeeper.server.util.OSMXBean) is a wrapper for the implementation of com.sun.management.UnixOperatingSystemMXBean, and decides to use the SUN API or its own implementation depending on the runtime (vendor) used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ZOOKEEPER-1571) Allow QuorumUtil.java build with IBM Java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paulo Ricardo Paz Vital resolved ZOOKEEPER-1571. Resolution: Duplicate Duplicate of ZOOKEEPER-1564 Allow QuorumUtil.java build with IBM Java - Key: ZOOKEEPER-1571 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1571 Project: ZooKeeper Issue Type: Improvement Components: tests Affects Versions: 3.4.4 Environment: Linux (x86_64), RHEL 6.3, IBM Java 6 SR 11 Reporter: Paulo Ricardo Paz Vital Labels: test Fix For: 3.4.4 Attachments: zookeeper-1571.patch The org.apache.zookeeper.test.QuorumUtil class imports the com.sun.management.UnixOperatingSystemMXBean class, that fail to build when using IBM Java 6 SR 11. This issue is resolved by new class OSMXBean class proposed in JIRA's 1474. The class OSMXBean (org.apache.zookeeper.server.util.OSMXBean) is a wrapper for the implementation of com.sun.management.UnixOperatingSystemMXBean, and decides to use the SUN API or its own implementation depending on the runtime (vendor) used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Success: ZOOKEEPER-1564 PreCommit Build #1274
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1564 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1274/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 196578 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12555147/ZOOKEEPER-1564-v2.patch [exec] against trunk revision 1414566. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 12 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1274//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1274//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1274//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 10q9EWJrS9 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 29 minutes 21 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-1564 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505383#comment-13505383 ] Hadoop QA commented on ZOOKEEPER-1564: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12555147/ZOOKEEPER-1564-v2.patch against trunk revision 1414566. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1274//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1274//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1274//console This message is automatically generated. Allow JUnit test build with IBM Java Key: ZOOKEEPER-1564 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1564 Project: ZooKeeper Issue Type: Improvement Components: tests Affects Versions: 3.4.4, 3.4.5 Environment: Linux, RHEL 6.3, IBM Java 6 SR 11 Reporter: Paulo Ricardo Paz Vital Assignee: Paulo Ricardo Paz Vital Labels: test Fix For: 3.4.4, 3.4.5 Attachments: zookeeper-1564.patch, ZOOKEEPER-1564-v2.patch The org.apache.zookeeper.test.ClientBase, org.apache.zookeeper.test.ClientTest, org.apache.zookeeper.test.QuorumBase and org.apache.zookeeper.test.QuorumUtil classes import the com.sun.management.UnixOperatingSystemMXBean class, that fail to build when using IBM Java 6 SR 11. This issue is resolved by new class OSMXBean class proposed in JIRA's ZOOKEEPER-1474. The class OSMXBean (org.apache.zookeeper.server.util.OSMXBean) is a wrapper for the implementation of com.sun.management.UnixOperatingSystemMXBean, and decides to use the SUN API or its own implementation depending on the runtime (vendor) used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1578) org.apache.zookeeper.server.quorum.Zab1_0Test failed due to hard code with 33556 port
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505413#comment-13505413 ] Li Ping Zhang commented on ZOOKEEPER-1578: -- By the way, can I have the honor to be the assignee to fix this issue? Thanks!:) org.apache.zookeeper.server.quorum.Zab1_0Test failed due to hard code with 33556 port - Key: ZOOKEEPER-1578 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1578 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.3 Reporter: Li Ping Zhang Labels: patch Original Estimate: 24h Remaining Estimate: 24h org.apache.zookeeper.server.quorum.Zab1_0Test was failed both with SUN JDK and open JDK. [junit] Running org.apache.zookeeper.server.quorum.Zab1_0Test [junit] Tests run: 8, Failures: 0, Errors: 1, Time elapsed: 18.334 sec [junit] Test org.apache.zookeeper.server.quorum.Zab1_0Test FAILED Zab1_0Test log: Zab1_0Test log: 2012-07-11 23:17:15,579 [myid:] - INFO [main:Leader@427] - Shutdown called java.lang.Exception: shutdown Leader! reason: end of test at org.apache.zookeeper.server.quorum.Leader.shutdown(Leader.java:427) at org.apache.zookeeper.server.quorum.Zab1_0Test.testLastAcceptedEpoch(Zab1_0Test.java:211) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:48) 2012-07-11 23:17:15,584 [myid:] - ERROR [main:Leader@139] - Couldn't bind to port 33556 java.net.BindException: Address already in use at java.net.PlainSocketImpl.bind(PlainSocketImpl.java:402) at java.net.ServerSocket.bind(ServerSocket.java:328) at java.net.ServerSocket.bind(ServerSocket.java:286) at org.apache.zookeeper.server.quorum.Leader.init(Leader.java:137) at org.apache.zookeeper.server.quorum.Zab1_0Test.createLeader(Zab1_0Test.java:810) at org.apache.zookeeper.server.quorum.Zab1_0Test.testLeaderInElectingFollowers(Zab1_0Test.java:224) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 2012-07-11 23:17:20,202 [myid:] - ERROR [LearnerHandler-bdvm039.svl.ibm.com/9.30.122.48:40153:LearnerHandler@559] - Unex pected exception causing shutdown while sock still open java.net.SocketTimeoutException: Read timed out at java.net.SocketInputStream.read(SocketInputStream.java:129) at java.io.BufferedInputStream.fill(BufferedInputStream.java:218) at java.io.BufferedInputStream.read(BufferedInputStream.java:237) at java.io.DataInputStream.readInt(DataInputStream.java:370) at org.apache.jute.BinaryInputArchive.readInt(BinaryInputArchive.java:63) at org.apache.zookeeper.server.quorum.QuorumPacket.deserialize(QuorumPacket.java:83) at org.apache.jute.BinaryInputArchive.readRecord(BinaryInputArchive.java:108) at org.apache.zookeeper.server.quorum.LearnerHandler.run(LearnerHandler.java:291) 2012-07-11 23:17:20,203 [myid:] - WARN [LearnerHandler-bdvm039.svl.ibm.com/9.30.122.48:40153:LearnerHandler@569] - *** GOODBYE bdvm039.svl.ibm.com/9.30.122.48:40153 2012-07-11 23:17:20,204 [myid:] - INFO [Thread-20:Leader@421] - Shutting down 2012-07-11 23:17:20,204 [myid:] - INFO [Thread-20:Leader@427] - Shutdown called java.lang.Exception: shutdown Leader! reason: lead ended this failure seems 33556 port is already used, but it is not in use with command check in fact. There is a hard code in unit test, we can improve it with code patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1578) org.apache.zookeeper.server.quorum.Zab1_0Test failed due to hard code with 33556 port
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505412#comment-13505412 ] Li Ping Zhang commented on ZOOKEEPER-1578: -- Dear Zookeeper committee, I have generated diff patches for3.4 branch and trunk, and all UT in both Open JDK and SUN JDK are passed, need I provide it? org.apache.zookeeper.server.quorum.Zab1_0Test failed due to hard code with 33556 port - Key: ZOOKEEPER-1578 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1578 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.3 Reporter: Li Ping Zhang Labels: patch Original Estimate: 24h Remaining Estimate: 24h org.apache.zookeeper.server.quorum.Zab1_0Test was failed both with SUN JDK and open JDK. [junit] Running org.apache.zookeeper.server.quorum.Zab1_0Test [junit] Tests run: 8, Failures: 0, Errors: 1, Time elapsed: 18.334 sec [junit] Test org.apache.zookeeper.server.quorum.Zab1_0Test FAILED Zab1_0Test log: Zab1_0Test log: 2012-07-11 23:17:15,579 [myid:] - INFO [main:Leader@427] - Shutdown called java.lang.Exception: shutdown Leader! reason: end of test at org.apache.zookeeper.server.quorum.Leader.shutdown(Leader.java:427) at org.apache.zookeeper.server.quorum.Zab1_0Test.testLastAcceptedEpoch(Zab1_0Test.java:211) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:48) 2012-07-11 23:17:15,584 [myid:] - ERROR [main:Leader@139] - Couldn't bind to port 33556 java.net.BindException: Address already in use at java.net.PlainSocketImpl.bind(PlainSocketImpl.java:402) at java.net.ServerSocket.bind(ServerSocket.java:328) at java.net.ServerSocket.bind(ServerSocket.java:286) at org.apache.zookeeper.server.quorum.Leader.init(Leader.java:137) at org.apache.zookeeper.server.quorum.Zab1_0Test.createLeader(Zab1_0Test.java:810) at org.apache.zookeeper.server.quorum.Zab1_0Test.testLeaderInElectingFollowers(Zab1_0Test.java:224) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 2012-07-11 23:17:20,202 [myid:] - ERROR [LearnerHandler-bdvm039.svl.ibm.com/9.30.122.48:40153:LearnerHandler@559] - Unex pected exception causing shutdown while sock still open java.net.SocketTimeoutException: Read timed out at java.net.SocketInputStream.read(SocketInputStream.java:129) at java.io.BufferedInputStream.fill(BufferedInputStream.java:218) at java.io.BufferedInputStream.read(BufferedInputStream.java:237) at java.io.DataInputStream.readInt(DataInputStream.java:370) at org.apache.jute.BinaryInputArchive.readInt(BinaryInputArchive.java:63) at org.apache.zookeeper.server.quorum.QuorumPacket.deserialize(QuorumPacket.java:83) at org.apache.jute.BinaryInputArchive.readRecord(BinaryInputArchive.java:108) at org.apache.zookeeper.server.quorum.LearnerHandler.run(LearnerHandler.java:291) 2012-07-11 23:17:20,203 [myid:] - WARN [LearnerHandler-bdvm039.svl.ibm.com/9.30.122.48:40153:LearnerHandler@569] - *** GOODBYE bdvm039.svl.ibm.com/9.30.122.48:40153 2012-07-11 23:17:20,204 [myid:] - INFO [Thread-20:Leader@421] - Shutting down 2012-07-11 23:17:20,204 [myid:] - INFO [Thread-20:Leader@427] - Shutdown called java.lang.Exception: shutdown Leader! reason: lead ended this failure seems 33556 port is already used, but it is not in use with command check in fact. There is a hard code in unit test, we can improve it with code patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1400) Allow logging via callback instead of raw FILE pointer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505568#comment-13505568 ] Hadoop QA commented on ZOOKEEPER-1400: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12533125/ZOOKEEPER-1400-1.patch against trunk revision 1414566. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 13 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1275//console This message is automatically generated. Allow logging via callback instead of raw FILE pointer -- Key: ZOOKEEPER-1400 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1400 Project: ZooKeeper Issue Type: Improvement Components: c client Affects Versions: 3.5.0 Environment: Linux Reporter: Marshall McMullen Assignee: Marshall McMullen Fix For: 3.5.0 Attachments: ZOOKEEPER-1400-1.patch, ZOOKEEPER-1400.patch The existing logging framework inside the C client uses a raw FILE*. Using a FILE* is very limiting and potentially dangerous. A safer alternative is to just provide a callback that the C client will call for each message. In our environment, we saw some really nasty issues with multiple threads all connecting to zookeeper via the C Client related to the use of a raw FILE*. Specifically, if the FILE * is closed and that file descriptor is reused by the kernel before the C client is notified then the C client will use it's static global logStream pointer for subsequent logging messages. That FILE* is now a loose cannon! In our environment, we saw zookeeper log messages ending up in other sockets and even in our core data path. Clearly this is dangerous. In our particular case, we'd omitted a call to zoo_set_log_stream(NULL) to notify C client that the FILE* has been closed. However, even with that bug fixed, there's still a race condition where log messages in flight may be sent before the C client is notified of the FILE closure, and the same problem can happen. Other issues we've seen involved multiple threads, wherein one would close the FILE*, and that's a global change that affects all threads connected within that process. That's a pretty nasty limitation as well. My proposed change is to allow setting a callback for log messages. A callback is used in preference to a raw FILE*. If no callback is set, then it will fallback to the existing FILE*. If that's not set, then it falls back to stderr as it always has. While refactoring this code, I removed the need for the double parens in all the LOG macros as that wasn't necessary and didn't fit with my new approach. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Failed: ZOOKEEPER-1400 PreCommit Build #1275
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1400 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1275/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 141 lines...] [exec] Hunk #56 FAILED at 2983. [exec] Hunk #57 FAILED at 3013. [exec] Hunk #58 FAILED at 3044. [exec] Hunk #59 succeeded at 3530 (offset 345 lines). [exec] Hunk #60 FAILED at 3204. [exec] Hunk #61 succeeded at 3822 with fuzz 1 (offset 340 lines). [exec] 26 out of 61 hunks FAILED -- saving rejects to file src/c/src/zookeeper.c.rej [exec] patching file src/c/tests/PthreadMocks.h [exec] patching file src/c/tests/TestOperations.cc [exec] patching file src/c/tests/Util.h [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12533125/ZOOKEEPER-1400-1.patch [exec] against trunk revision 1414566. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 13 new or modified tests. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1275//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] RYB4tKt2jf logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1568: exec returned: 1 Total time: 40 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1400 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-1568) multi should have a non-transaction version
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505588#comment-13505588 ] Jimmy Xiang commented on ZOOKEEPER-1568: I am hacking around this week. I will find out how much performance I can gain this way, if any. Yes, it is mainly for performance and convenience. As to fewer zk events, it may be just for our use case, assuming our node children changed handler doesn't have a chance to reset the watch soon enough. So if we create lots of children for one parent, we may get less node children changed events, theoretically. multi should have a non-transaction version --- Key: ZOOKEEPER-1568 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1568 Project: ZooKeeper Issue Type: Improvement Reporter: Jimmy Xiang Attachments: zk-1568_v1.patch Currently multi is transactional, i.e. all or none. However, sometimes, we don't want that. We want all operations to be executed. Even some operation(s) fails, it is ok. We just need to know the result of each operation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)
On Nov. 18, 2012, 4:10 p.m., Camille Fournier wrote: src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java, line 306 https://reviews.apache.org/r/8094/diff/1/?file=190875#file190875line306 Why make this a more restrictive type? Skye Wanderman-Milne wrote: If you look at ConsCommand or StatCommand in Commands.java, I clone the HashSet returned by getConnections(). I copied this code from the original 4lw's in NIOServerCnxn.java, including the comment that says clone should be faster than iteration ie give up the cnxns lock faster. The original code clones factory.cnxns directly, but since Commands is in a different package I have to use factory.getCommands(), so I changed the return type in order to use clone. I could avoid changing the return type by using a copy constructor instead of clone(), but I didn't want to change the command code based on the comment. FWIW, NettyServerCnxn uses a copy constructor instead of clone(), so maybe it's fine. You might not want to change this for b/w compat reasons, all else being equal. It's not part of the public api, however some teams interact with factories, esp in their test code, and changing this might cause problems for them. - Patrick --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8094/#review13547 --- On Nov. 16, 2012, 11:25 p.m., Skye Wanderman-Milne wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8094/ --- (Updated Nov. 16, 2012, 11:25 p.m.) Review request for zookeeper, Patrick Hunt, Camille Fournier, and Henry Robinson. Description --- See my comment in ZOOKEEPER-1346. This addresses bug ZOOKEEPER-1346. https://issues.apache.org/jira/browse/ZOOKEEPER-1346 Diffs - ivy.xml fadf4f4 src/java/main/org/apache/zookeeper/server/DataTree.java 0bb2317 src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 8b4c46b src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java eec2f2a src/java/main/org/apache/zookeeper/server/ServerCnxn.java 6dd509b src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java e5c6565 src/java/main/org/apache/zookeeper/server/ServerStats.java aa0d93f src/java/main/org/apache/zookeeper/server/SessionTracker.java 3535e1b src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 31f2785 src/java/main/org/apache/zookeeper/server/WatchManager.java 0e7c815 src/java/main/org/apache/zookeeper/server/ZKDatabase.java d6c0c05 src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 7bb7b2f src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 369e621 src/java/main/org/apache/zookeeper/server/ZooTrace.java ac14fe2 src/java/main/org/apache/zookeeper/server/admin/AdminServer.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/Command.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/CommandBase.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/CommandOutputter.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/Commands.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/JsonOutputter.java PRE-CREATION src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 3182419 src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 8665bac src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 42207e1 Diff: https://reviews.apache.org/r/8094/diff/ Testing --- unit tests Ran in standalone mode (only option right now) and manually tried out all the commands/links Thanks, Skye Wanderman-Milne
Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8094/#review13824 --- This looks good to me overall short of the following comments. src/java/main/org/apache/zookeeper/server/DataTree.java https://reviews.apache.org/r/8094/#comment29518 this doesn't need synchronization? src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java https://reviews.apache.org/r/8094/#comment29521 This needs to be configurable from the get go. src/java/main/org/apache/zookeeper/server/admin/AdminServer.java https://reviews.apache.org/r/8094/#comment29522 The base url should be configurable. src/java/main/org/apache/zookeeper/server/admin/AdminServer.java https://reviews.apache.org/r/8094/#comment29523 Even if we only support json initially, we should allow for other output formats to be supported eventually. Does this assumption limit us in any way going forward? i.e. is it ok to assume json output? Or should the user be somehow specifying this? - Patrick Hunt On Nov. 16, 2012, 11:25 p.m., Skye Wanderman-Milne wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8094/ --- (Updated Nov. 16, 2012, 11:25 p.m.) Review request for zookeeper, Patrick Hunt, Camille Fournier, and Henry Robinson. Description --- See my comment in ZOOKEEPER-1346. This addresses bug ZOOKEEPER-1346. https://issues.apache.org/jira/browse/ZOOKEEPER-1346 Diffs - ivy.xml fadf4f4 src/java/main/org/apache/zookeeper/server/DataTree.java 0bb2317 src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 8b4c46b src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java eec2f2a src/java/main/org/apache/zookeeper/server/ServerCnxn.java 6dd509b src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java e5c6565 src/java/main/org/apache/zookeeper/server/ServerStats.java aa0d93f src/java/main/org/apache/zookeeper/server/SessionTracker.java 3535e1b src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 31f2785 src/java/main/org/apache/zookeeper/server/WatchManager.java 0e7c815 src/java/main/org/apache/zookeeper/server/ZKDatabase.java d6c0c05 src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 7bb7b2f src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 369e621 src/java/main/org/apache/zookeeper/server/ZooTrace.java ac14fe2 src/java/main/org/apache/zookeeper/server/admin/AdminServer.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/Command.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/CommandBase.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/CommandOutputter.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/Commands.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/JsonOutputter.java PRE-CREATION src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 3182419 src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 8665bac src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 42207e1 Diff: https://reviews.apache.org/r/8094/diff/ Testing --- unit tests Ran in standalone mode (only option right now) and manually tried out all the commands/links Thanks, Skye Wanderman-Milne
Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)
On Nov. 18, 2012, 4:10 p.m., Camille Fournier wrote: src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java, line 306 https://reviews.apache.org/r/8094/diff/1/?file=190875#file190875line306 Why make this a more restrictive type? Skye Wanderman-Milne wrote: If you look at ConsCommand or StatCommand in Commands.java, I clone the HashSet returned by getConnections(). I copied this code from the original 4lw's in NIOServerCnxn.java, including the comment that says clone should be faster than iteration ie give up the cnxns lock faster. The original code clones factory.cnxns directly, but since Commands is in a different package I have to use factory.getCommands(), so I changed the return type in order to use clone. I could avoid changing the return type by using a copy constructor instead of clone(), but I didn't want to change the command code based on the comment. FWIW, NettyServerCnxn uses a copy constructor instead of clone(), so maybe it's fine. Patrick Hunt wrote: You might not want to change this for b/w compat reasons, all else being equal. It's not part of the public api, however some teams interact with factories, esp in their test code, and changing this might cause problems for them. I'll preserve the API and use a copy ctor instead of clone, then. - Skye --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8094/#review13547 --- On Nov. 16, 2012, 11:25 p.m., Skye Wanderman-Milne wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8094/ --- (Updated Nov. 16, 2012, 11:25 p.m.) Review request for zookeeper, Patrick Hunt, Camille Fournier, and Henry Robinson. Description --- See my comment in ZOOKEEPER-1346. This addresses bug ZOOKEEPER-1346. https://issues.apache.org/jira/browse/ZOOKEEPER-1346 Diffs - ivy.xml fadf4f4 src/java/main/org/apache/zookeeper/server/DataTree.java 0bb2317 src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 8b4c46b src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java eec2f2a src/java/main/org/apache/zookeeper/server/ServerCnxn.java 6dd509b src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java e5c6565 src/java/main/org/apache/zookeeper/server/ServerStats.java aa0d93f src/java/main/org/apache/zookeeper/server/SessionTracker.java 3535e1b src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 31f2785 src/java/main/org/apache/zookeeper/server/WatchManager.java 0e7c815 src/java/main/org/apache/zookeeper/server/ZKDatabase.java d6c0c05 src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 7bb7b2f src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 369e621 src/java/main/org/apache/zookeeper/server/ZooTrace.java ac14fe2 src/java/main/org/apache/zookeeper/server/admin/AdminServer.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/Command.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/CommandBase.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/CommandOutputter.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/Commands.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/JsonOutputter.java PRE-CREATION src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 3182419 src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 8665bac src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 42207e1 Diff: https://reviews.apache.org/r/8094/diff/ Testing --- unit tests Ran in standalone mode (only option right now) and manually tried out all the commands/links Thanks, Skye Wanderman-Milne
Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)
On Nov. 28, 2012, 6:19 p.m., Patrick Hunt wrote: src/java/main/org/apache/zookeeper/server/DataTree.java, line 1216 https://reviews.apache.org/r/8094/diff/1/?file=190874#file190874line1216 this doesn't need synchronization? I should be synchronizing and copying the HashSet values of the ephemerals map, yes. I'll fix this. On Nov. 28, 2012, 6:19 p.m., Patrick Hunt wrote: src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java, line 111 https://reviews.apache.org/r/8094/diff/1/?file=190885#file190885line111 This needs to be configurable from the get go. I'll add configuration options for the base URL, port, anything else I can think of. On Nov. 28, 2012, 6:19 p.m., Patrick Hunt wrote: src/java/main/org/apache/zookeeper/server/admin/AdminServer.java, line 98 https://reviews.apache.org/r/8094/diff/1/?file=190887#file190887line98 Even if we only support json initially, we should allow for other output formats to be supported eventually. Does this assumption limit us in any way going forward? i.e. is it ok to assume json output? Or should the user be somehow specifying this? In the next code review I'm going to add support for text (i.e. the original) output, as well as specifying the output format. - Skye --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8094/#review13824 --- On Nov. 16, 2012, 11:25 p.m., Skye Wanderman-Milne wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8094/ --- (Updated Nov. 16, 2012, 11:25 p.m.) Review request for zookeeper, Patrick Hunt, Camille Fournier, and Henry Robinson. Description --- See my comment in ZOOKEEPER-1346. This addresses bug ZOOKEEPER-1346. https://issues.apache.org/jira/browse/ZOOKEEPER-1346 Diffs - ivy.xml fadf4f4 src/java/main/org/apache/zookeeper/server/DataTree.java 0bb2317 src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 8b4c46b src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java eec2f2a src/java/main/org/apache/zookeeper/server/ServerCnxn.java 6dd509b src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java e5c6565 src/java/main/org/apache/zookeeper/server/ServerStats.java aa0d93f src/java/main/org/apache/zookeeper/server/SessionTracker.java 3535e1b src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 31f2785 src/java/main/org/apache/zookeeper/server/WatchManager.java 0e7c815 src/java/main/org/apache/zookeeper/server/ZKDatabase.java d6c0c05 src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 7bb7b2f src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 369e621 src/java/main/org/apache/zookeeper/server/ZooTrace.java ac14fe2 src/java/main/org/apache/zookeeper/server/admin/AdminServer.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/Command.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/CommandBase.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/CommandOutputter.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/Commands.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/JsonOutputter.java PRE-CREATION src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 3182419 src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 8665bac src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 42207e1 Diff: https://reviews.apache.org/r/8094/diff/ Testing --- unit tests Ran in standalone mode (only option right now) and manually tried out all the commands/links Thanks, Skye Wanderman-Milne
Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8094/#review13826 --- Looking good. src/java/main/org/apache/zookeeper/server/DataTree.java https://reviews.apache.org/r/8094/#comment29525 Good time to add some Javadoc to some of these public methods. src/java/main/org/apache/zookeeper/server/WatchManager.java https://reviews.apache.org/r/8094/#comment29526 I'm not a huge fan of calling these 'dump' - that always implies writing to a string or to stderr or similar. How about just 'getWatches' etc.? src/java/main/org/apache/zookeeper/server/WatchManager.java https://reviews.apache.org/r/8094/#comment29529 Nit: You're boxing the long every time you do a get or a put, you might as well make this a Long id instead. src/java/main/org/apache/zookeeper/server/WatchManager.java https://reviews.apache.org/r/8094/#comment29528 Nit: avoid the repeated lookup by id and make the HashSet a local variable, then do id2paths.put after the for loop. src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java https://reviews.apache.org/r/8094/#comment29530 Can you expand the TODO to be clearer about what you want to happen? It might not be you that fixes it, such is open source. src/java/main/org/apache/zookeeper/server/ZooTrace.java https://reviews.apache.org/r/8094/#comment29531 *If* this is used from multiple threads (is it?), it should be synchronized on the class lock, otherwise there's no guarantee that changes to traceMask are visible on other threads. src/java/main/org/apache/zookeeper/server/admin/AdminServer.java https://reviews.apache.org/r/8094/#comment29533 I prefer starting servers in a separate method outside of the constructor. That way you can always initialise variables of type AdminServer in their usual place without having to wait until you know you're ok with starting the server before you construct one. src/java/main/org/apache/zookeeper/server/admin/AdminServer.java https://reviews.apache.org/r/8094/#comment29532 LOG.warn(Problem starting AdminServer, e); Why don't you want to throw the exception? How can clients know if this worked or not? src/java/main/org/apache/zookeeper/server/admin/CommandBase.java https://reviews.apache.org/r/8094/#comment29541 Why String[]? Prefer ListString pretty much everywhere. You can use Arrays.asList(name1, name2) etc. to pass in names. src/java/main/org/apache/zookeeper/server/admin/CommandOutputter.java https://reviews.apache.org/r/8094/#comment29540 Outputter is a bit clumsy - would Writer work better? src/java/main/org/apache/zookeeper/server/admin/Commands.java https://reviews.apache.org/r/8094/#comment29535 You don't need this blank line src/java/main/org/apache/zookeeper/server/admin/Commands.java https://reviews.apache.org/r/8094/#comment29536 final static variables usually have capitalised names, so COMMANDS here, and PRIMARY_NAMES below. src/java/main/org/apache/zookeeper/server/admin/Commands.java https://reviews.apache.org/r/8094/#comment29538 Not sure we need this src/java/main/org/apache/zookeeper/server/admin/Commands.java https://reviews.apache.org/r/8094/#comment29542 These guys all need a short comment to explain what they do. src/java/main/org/apache/zookeeper/server/admin/Commands.java https://reviews.apache.org/r/8094/#comment29543 New line for second } src/java/main/org/apache/zookeeper/server/admin/Commands.java https://reviews.apache.org/r/8094/#comment29544 You can't lock on factory.getConnections(), since getConnections is entitled to return different objects on different invocations (e.g. what if it copied the cnxns object and returned the copy?) My suggestion: move this logic into ServerCnxnFactory and make it a public method that returns the ListMapString, Object. Same with the other places you follow a similar pattern. src/java/main/org/apache/zookeeper/server/admin/JsonOutputter.java https://reviews.apache.org/r/8094/#comment29545 printStackTrace is bad because it doesn't use the logging setup. Use LOG.warn(..., e) in all cases. src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java https://reviews.apache.org/r/8094/#comment29546 Remove this line (and the one above). Shouldn't this return an empty Map instead of null, in case this ever gets used? - Henry Robinson On Nov. 16, 2012, 11:25 p.m., Skye Wanderman-Milne wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8094/ --- (Updated Nov. 16, 2012, 11:25 p.m.) Review request for zookeeper, Patrick Hunt, Camille Fournier, and Henry Robinson. Description
Re: Review Request: ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)
On Nov. 18, 2012, 4:10 p.m., Camille Fournier wrote: src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java, line 306 https://reviews.apache.org/r/8094/diff/1/?file=190875#file190875line306 Why make this a more restrictive type? Skye Wanderman-Milne wrote: If you look at ConsCommand or StatCommand in Commands.java, I clone the HashSet returned by getConnections(). I copied this code from the original 4lw's in NIOServerCnxn.java, including the comment that says clone should be faster than iteration ie give up the cnxns lock faster. The original code clones factory.cnxns directly, but since Commands is in a different package I have to use factory.getCommands(), so I changed the return type in order to use clone. I could avoid changing the return type by using a copy constructor instead of clone(), but I didn't want to change the command code based on the comment. FWIW, NettyServerCnxn uses a copy constructor instead of clone(), so maybe it's fine. Patrick Hunt wrote: You might not want to change this for b/w compat reasons, all else being equal. It's not part of the public api, however some teams interact with factories, esp in their test code, and changing this might cause problems for them. Skye Wanderman-Milne wrote: I'll preserve the API and use a copy ctor instead of clone, then. Just saw this conversation - I suggest preserving the API but doing the work of the commands inside the ServerCnxnFactory. You might be able to avoid the copy completely this way. - Henry --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8094/#review13547 --- On Nov. 16, 2012, 11:25 p.m., Skye Wanderman-Milne wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8094/ --- (Updated Nov. 16, 2012, 11:25 p.m.) Review request for zookeeper, Patrick Hunt, Camille Fournier, and Henry Robinson. Description --- See my comment in ZOOKEEPER-1346. This addresses bug ZOOKEEPER-1346. https://issues.apache.org/jira/browse/ZOOKEEPER-1346 Diffs - ivy.xml fadf4f4 src/java/main/org/apache/zookeeper/server/DataTree.java 0bb2317 src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 8b4c46b src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java eec2f2a src/java/main/org/apache/zookeeper/server/ServerCnxn.java 6dd509b src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java e5c6565 src/java/main/org/apache/zookeeper/server/ServerStats.java aa0d93f src/java/main/org/apache/zookeeper/server/SessionTracker.java 3535e1b src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 31f2785 src/java/main/org/apache/zookeeper/server/WatchManager.java 0e7c815 src/java/main/org/apache/zookeeper/server/ZKDatabase.java d6c0c05 src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 7bb7b2f src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 369e621 src/java/main/org/apache/zookeeper/server/ZooTrace.java ac14fe2 src/java/main/org/apache/zookeeper/server/admin/AdminServer.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/Command.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/CommandBase.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/CommandOutputter.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/Commands.java PRE-CREATION src/java/main/org/apache/zookeeper/server/admin/JsonOutputter.java PRE-CREATION src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 3182419 src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 8665bac src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 42207e1 Diff: https://reviews.apache.org/r/8094/diff/ Testing --- unit tests Ran in standalone mode (only option right now) and manually tried out all the commands/links Thanks, Skye Wanderman-Milne
[jira] [Updated] (ZOOKEEPER-1568) multi should have a non-transaction version
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jimmy Xiang updated ZOOKEEPER-1568: --- Attachment: zk-1568_v2.patch Patch version 2 which supports async batch. multi should have a non-transaction version --- Key: ZOOKEEPER-1568 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1568 Project: ZooKeeper Issue Type: Improvement Reporter: Jimmy Xiang Attachments: zk-1568_v1.patch, zk-1568_v2.patch Currently multi is transactional, i.e. all or none. However, sometimes, we don't want that. We want all operations to be executed. Even some operation(s) fails, it is ok. We just need to know the result of each operation. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1477) Test failures with Java 7 on Mac OS X
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506057#comment-13506057
]
Roman Shaposhnik commented on ZOOKEEPER-1477:
-
Fedora 18 is not officially released yet, but over at Bigtop
(http://bigtop.apache.org) we run regular tests with the OS supplied JDK and
things have been really great on the following set of platforms:
http://bigtop01.cloudera.org:8080/view/Bigtop-trunk/job/Bigtop-trunk-packagetest/
FWIW: I believe that Fedora 17 comes with exactly the same version of JDK
1.7.0_09-icedtea.
Test failures with Java 7 on Mac OS X
-
Key: ZOOKEEPER-1477
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1477
Project: ZooKeeper
Issue Type: Bug
Components: server, tests
Affects Versions: 3.4.3
Environment: Mac OS X Lion (10.7.4)
Java version:
java version 1.7.0_04
Java(TM) SE Runtime Environment (build 1.7.0_04-b21)
Java HotSpot(TM) 64-Bit Server VM (build 23.0-b21, mixed mode)
Reporter: Diwaker Gupta
Fix For: 3.4.6
Attachments: with-ZK-1550.txt
I downloaded ZK 3.4.3 sources and ran {{ant test}}. Many of the tests failed,
including ZooKeeperTest. A common symptom was spurious
{{ConnectionLossException}}:
{code}
2012-06-01 12:01:23,420 [myid:] - INFO
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@54] - TEST METHOD FAILED
testDeleteRecursiveAsync
org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode
= ConnectionLoss for /
at
org.apache.zookeeper.KeeperException.create(KeeperException.java:99)
at
org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
at org.apache.zookeeper.ZooKeeper.setData(ZooKeeper.java:1246)
at
org.apache.zookeeper.ZooKeeperTest.testDeleteRecursiveAsync(ZooKeeperTest.java:77)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
... (snipped)
{code}
As background, I was actually investigating some non-deterministic failures
when using Netflix's Curator with Java 7 (see
https://github.com/Netflix/curator/issues/79). After a while, I figured I
should establish a clean ZK baseline first and realized it is actually a ZK
issue, not a Curator issue.
We are trying to migrate to Java 7 but this is a blocking issue for us right
now.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1477) Test failures with Java 7 on Mac OS X
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506227#comment-13506227
]
Patrick Hunt commented on ZOOKEEPER-1477:
-
Has anyone tried against 3.4.5? Do we have any insight whether this was also
happening with the 3.3 branch?
Test failures with Java 7 on Mac OS X
-
Key: ZOOKEEPER-1477
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1477
Project: ZooKeeper
Issue Type: Bug
Components: server, tests
Affects Versions: 3.4.3
Environment: Mac OS X Lion (10.7.4)
Java version:
java version 1.7.0_04
Java(TM) SE Runtime Environment (build 1.7.0_04-b21)
Java HotSpot(TM) 64-Bit Server VM (build 23.0-b21, mixed mode)
Reporter: Diwaker Gupta
Fix For: 3.4.6
Attachments: with-ZK-1550.txt
I downloaded ZK 3.4.3 sources and ran {{ant test}}. Many of the tests failed,
including ZooKeeperTest. A common symptom was spurious
{{ConnectionLossException}}:
{code}
2012-06-01 12:01:23,420 [myid:] - INFO
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@54] - TEST METHOD FAILED
testDeleteRecursiveAsync
org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode
= ConnectionLoss for /
at
org.apache.zookeeper.KeeperException.create(KeeperException.java:99)
at
org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
at org.apache.zookeeper.ZooKeeper.setData(ZooKeeper.java:1246)
at
org.apache.zookeeper.ZooKeeperTest.testDeleteRecursiveAsync(ZooKeeperTest.java:77)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
... (snipped)
{code}
As background, I was actually investigating some non-deterministic failures
when using Netflix's Curator with Java 7 (see
https://github.com/Netflix/curator/issues/79). After a while, I figured I
should establish a clean ZK baseline first and realized it is actually a ZK
issue, not a Curator issue.
We are trying to migrate to Java 7 but this is a blocking issue for us right
now.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1578) org.apache.zookeeper.server.quorum.Zab1_0Test failed due to hard code with 33556 port
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1578: Assignee: Li Ping Zhang org.apache.zookeeper.server.quorum.Zab1_0Test failed due to hard code with 33556 port - Key: ZOOKEEPER-1578 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1578 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.3 Reporter: Li Ping Zhang Assignee: Li Ping Zhang Labels: patch Original Estimate: 24h Remaining Estimate: 24h org.apache.zookeeper.server.quorum.Zab1_0Test was failed both with SUN JDK and open JDK. [junit] Running org.apache.zookeeper.server.quorum.Zab1_0Test [junit] Tests run: 8, Failures: 0, Errors: 1, Time elapsed: 18.334 sec [junit] Test org.apache.zookeeper.server.quorum.Zab1_0Test FAILED Zab1_0Test log: Zab1_0Test log: 2012-07-11 23:17:15,579 [myid:] - INFO [main:Leader@427] - Shutdown called java.lang.Exception: shutdown Leader! reason: end of test at org.apache.zookeeper.server.quorum.Leader.shutdown(Leader.java:427) at org.apache.zookeeper.server.quorum.Zab1_0Test.testLastAcceptedEpoch(Zab1_0Test.java:211) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:48) 2012-07-11 23:17:15,584 [myid:] - ERROR [main:Leader@139] - Couldn't bind to port 33556 java.net.BindException: Address already in use at java.net.PlainSocketImpl.bind(PlainSocketImpl.java:402) at java.net.ServerSocket.bind(ServerSocket.java:328) at java.net.ServerSocket.bind(ServerSocket.java:286) at org.apache.zookeeper.server.quorum.Leader.init(Leader.java:137) at org.apache.zookeeper.server.quorum.Zab1_0Test.createLeader(Zab1_0Test.java:810) at org.apache.zookeeper.server.quorum.Zab1_0Test.testLeaderInElectingFollowers(Zab1_0Test.java:224) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 2012-07-11 23:17:20,202 [myid:] - ERROR [LearnerHandler-bdvm039.svl.ibm.com/9.30.122.48:40153:LearnerHandler@559] - Unex pected exception causing shutdown while sock still open java.net.SocketTimeoutException: Read timed out at java.net.SocketInputStream.read(SocketInputStream.java:129) at java.io.BufferedInputStream.fill(BufferedInputStream.java:218) at java.io.BufferedInputStream.read(BufferedInputStream.java:237) at java.io.DataInputStream.readInt(DataInputStream.java:370) at org.apache.jute.BinaryInputArchive.readInt(BinaryInputArchive.java:63) at org.apache.zookeeper.server.quorum.QuorumPacket.deserialize(QuorumPacket.java:83) at org.apache.jute.BinaryInputArchive.readRecord(BinaryInputArchive.java:108) at org.apache.zookeeper.server.quorum.LearnerHandler.run(LearnerHandler.java:291) 2012-07-11 23:17:20,203 [myid:] - WARN [LearnerHandler-bdvm039.svl.ibm.com/9.30.122.48:40153:LearnerHandler@569] - *** GOODBYE bdvm039.svl.ibm.com/9.30.122.48:40153 2012-07-11 23:17:20,204 [myid:] - INFO [Thread-20:Leader@421] - Shutting down 2012-07-11 23:17:20,204 [myid:] - INFO [Thread-20:Leader@427] - Shutdown called java.lang.Exception: shutdown Leader! reason: lead ended this failure seems 33556 port is already used, but it is not in use with command check in fact. There is a hard code in unit test, we can improve it with code patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1584) Adding mvn-install target for deploying the zookeeper artifacts to .m2 repository.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1584: Fix Version/s: (was: 3.4.5) 3.4.6 Adding mvn-install target for deploying the zookeeper artifacts to .m2 repository. -- Key: ZOOKEEPER-1584 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1584 Project: ZooKeeper Issue Type: Bug Components: build Affects Versions: 3.4.3 Reporter: Ashish Singh Fix For: 3.4.3, 3.4.6 Attachments: ZOOKEEPER-1584.patch mvn install functionality for zookeeper distribution artifacts to .m2 is not present. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1572) Add an async interface for multi request
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1572: Fix Version/s: (was: 3.4.5) 3.4.6 Add an async interface for multi request Key: ZOOKEEPER-1572 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1572 Project: ZooKeeper Issue Type: Improvement Components: java client Reporter: Sijie Guo Assignee: Sijie Guo Fix For: 3.5.0, 3.4.6 Attachments: ZOOKEEPER-1572.diff, ZOOKEEPER-1572.diff Currently there is no async interface for multi request in ZooKeeper java client. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1564: Fix Version/s: (was: 3.4.5) 3.4.6 Allow JUnit test build with IBM Java Key: ZOOKEEPER-1564 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1564 Project: ZooKeeper Issue Type: Improvement Components: tests Affects Versions: 3.4.4, 3.4.5 Environment: Linux, RHEL 6.3, IBM Java 6 SR 11 Reporter: Paulo Ricardo Paz Vital Assignee: Paulo Ricardo Paz Vital Labels: test Fix For: 3.4.4, 3.4.6 Attachments: zookeeper-1564.patch, ZOOKEEPER-1564-v2.patch The org.apache.zookeeper.test.ClientBase, org.apache.zookeeper.test.ClientTest, org.apache.zookeeper.test.QuorumBase and org.apache.zookeeper.test.QuorumUtil classes import the com.sun.management.UnixOperatingSystemMXBean class, that fail to build when using IBM Java 6 SR 11. This issue is resolved by new class OSMXBean class proposed in JIRA's ZOOKEEPER-1474. The class OSMXBean (org.apache.zookeeper.server.util.OSMXBean) is a wrapper for the implementation of com.sun.management.UnixOperatingSystemMXBean, and decides to use the SUN API or its own implementation depending on the runtime (vendor) used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1564: Fix Version/s: (was: 3.4.4) 3.5.0 Allow JUnit test build with IBM Java Key: ZOOKEEPER-1564 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1564 Project: ZooKeeper Issue Type: Improvement Components: tests Affects Versions: 3.4.4, 3.5.0, 3.4.5 Environment: Linux, RHEL 6.3, IBM Java 6 SR 11 Reporter: Paulo Ricardo Paz Vital Assignee: Paulo Ricardo Paz Vital Labels: test Fix For: 3.5.0, 3.4.6 Attachments: zookeeper-1564.patch, ZOOKEEPER-1564-v2.patch The org.apache.zookeeper.test.ClientBase, org.apache.zookeeper.test.ClientTest, org.apache.zookeeper.test.QuorumBase and org.apache.zookeeper.test.QuorumUtil classes import the com.sun.management.UnixOperatingSystemMXBean class, that fail to build when using IBM Java 6 SR 11. This issue is resolved by new class OSMXBean class proposed in JIRA's ZOOKEEPER-1474. The class OSMXBean (org.apache.zookeeper.server.util.OSMXBean) is a wrapper for the implementation of com.sun.management.UnixOperatingSystemMXBean, and decides to use the SUN API or its own implementation depending on the runtime (vendor) used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1564) Allow JUnit test build with IBM Java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1564: Affects Version/s: 3.5.0 Allow JUnit test build with IBM Java Key: ZOOKEEPER-1564 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1564 Project: ZooKeeper Issue Type: Improvement Components: tests Affects Versions: 3.4.4, 3.5.0, 3.4.5 Environment: Linux, RHEL 6.3, IBM Java 6 SR 11 Reporter: Paulo Ricardo Paz Vital Assignee: Paulo Ricardo Paz Vital Labels: test Fix For: 3.5.0, 3.4.6 Attachments: zookeeper-1564.patch, ZOOKEEPER-1564-v2.patch The org.apache.zookeeper.test.ClientBase, org.apache.zookeeper.test.ClientTest, org.apache.zookeeper.test.QuorumBase and org.apache.zookeeper.test.QuorumUtil classes import the com.sun.management.UnixOperatingSystemMXBean class, that fail to build when using IBM Java 6 SR 11. This issue is resolved by new class OSMXBean class proposed in JIRA's ZOOKEEPER-1474. The class OSMXBean (org.apache.zookeeper.server.util.OSMXBean) is a wrapper for the implementation of com.sun.management.UnixOperatingSystemMXBean, and decides to use the SUN API or its own implementation depending on the runtime (vendor) used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-107: --- Attachment: ZOOKEEPER-107-28-NOV.patch Removed tabs and some trailing spaces Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Assignee: Alexander Shraer Fix For: 3.5.0 Attachments: SimpleAddition.rtf, zkreconfig-usenixatc-final.pdf, ZOOKEEPER-107-14-Oct.patch, ZOOKEEPER-107-15-Oct.patch, ZOOKEEPER-107-15-Oct-ver1.patch, ZOOKEEPER-107-15-Oct-ver2.patch, ZOOKEEPER-107-15-Oct-ver3.patch, ZOOKEEPER-107-1-Mar.patch, ZOOKEEPER-107-20-July.patch, ZOOKEEPER-107-21-July.patch, ZOOKEEPER-107-22-Apr.patch, ZOOKEEPER-107-23-SEP.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-NOV.patch, ZOOKEEPER-107-29-Feb.patch, ZOOKEEPER-107-3-Oct.patch, ZOOKEEPER-107-6-NOV-2.patch, ZOOKEEPER-107-7-NOV.patch, ZOOKEEPER-107-7-NOV-ver1.patch, ZOOKEEPER-107-7-NOV-ver2.patch, ZOOKEEPER-107-Aug-20.patch, ZOOKEEPER-107-Aug-20-ver1.patch, ZOOKEEPER-107-Aug-25.patch, zookeeper-3.4.0.jar, zookeeper-dev-fatjar.jar, zookeeper-reconfig-sep11.patch, zookeeper-reconfig-sep12.patch, zoo_replicated1.cfg, zoo_replicated1.members Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Failed: ZOOKEEPER-107 PreCommit Build #1276
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1276/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 548 lines...] [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12555318/ZOOKEEPER-107-28-NOV.patch [exec] against trunk revision 1414566. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 15 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] -1 javac. The patch appears to cause tar ant target to fail. [exec] [exec] -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1276//testReport/ [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1276//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] Gh2Sbmak0C logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1568: exec returned: 3 Total time: 1 minute 13 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-107 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Updated] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-107: --- Attachment: (was: ZOOKEEPER-107-28-NOV.patch) Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Assignee: Alexander Shraer Fix For: 3.5.0 Attachments: SimpleAddition.rtf, zkreconfig-usenixatc-final.pdf, ZOOKEEPER-107-14-Oct.patch, ZOOKEEPER-107-15-Oct.patch, ZOOKEEPER-107-15-Oct-ver1.patch, ZOOKEEPER-107-15-Oct-ver2.patch, ZOOKEEPER-107-15-Oct-ver3.patch, ZOOKEEPER-107-1-Mar.patch, ZOOKEEPER-107-20-July.patch, ZOOKEEPER-107-21-July.patch, ZOOKEEPER-107-22-Apr.patch, ZOOKEEPER-107-23-SEP.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-NOV-ver1.patch, ZOOKEEPER-107-29-Feb.patch, ZOOKEEPER-107-3-Oct.patch, ZOOKEEPER-107-6-NOV-2.patch, ZOOKEEPER-107-7-NOV.patch, ZOOKEEPER-107-7-NOV-ver1.patch, ZOOKEEPER-107-7-NOV-ver2.patch, ZOOKEEPER-107-Aug-20.patch, ZOOKEEPER-107-Aug-20-ver1.patch, ZOOKEEPER-107-Aug-25.patch, zookeeper-3.4.0.jar, zookeeper-dev-fatjar.jar, zookeeper-reconfig-sep11.patch, zookeeper-reconfig-sep12.patch, zoo_replicated1.cfg, zoo_replicated1.members Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506244#comment-13506244 ] Hadoop QA commented on ZOOKEEPER-107: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12555318/ZOOKEEPER-107-28-NOV.patch against trunk revision 1414566. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 15 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1276//testReport/ Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1276//console This message is automatically generated. Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Assignee: Alexander Shraer Fix For: 3.5.0 Attachments: SimpleAddition.rtf, zkreconfig-usenixatc-final.pdf, ZOOKEEPER-107-14-Oct.patch, ZOOKEEPER-107-15-Oct.patch, ZOOKEEPER-107-15-Oct-ver1.patch, ZOOKEEPER-107-15-Oct-ver2.patch, ZOOKEEPER-107-15-Oct-ver3.patch, ZOOKEEPER-107-1-Mar.patch, ZOOKEEPER-107-20-July.patch, ZOOKEEPER-107-21-July.patch, ZOOKEEPER-107-22-Apr.patch, ZOOKEEPER-107-23-SEP.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-NOV-ver1.patch, ZOOKEEPER-107-29-Feb.patch, ZOOKEEPER-107-3-Oct.patch, ZOOKEEPER-107-6-NOV-2.patch, ZOOKEEPER-107-7-NOV.patch, ZOOKEEPER-107-7-NOV-ver1.patch, ZOOKEEPER-107-7-NOV-ver2.patch, ZOOKEEPER-107-Aug-20.patch, ZOOKEEPER-107-Aug-20-ver1.patch, ZOOKEEPER-107-Aug-25.patch, zookeeper-3.4.0.jar, zookeeper-dev-fatjar.jar, zookeeper-reconfig-sep11.patch, zookeeper-reconfig-sep12.patch, zoo_replicated1.cfg, zoo_replicated1.members Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Failed: ZOOKEEPER-107 PreCommit Build #1277
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1277/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 523 lines...] [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12555320/ZOOKEEPER-107-28-NOV-ver1.patch [exec] against trunk revision 1414566. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 28 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] -1 javac. The patch appears to cause tar ant target to fail. [exec] [exec] -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1277//testReport/ [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1277//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] y844W4Eibt logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1568: exec returned: 3 Total time: 1 minute 10 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-107 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506250#comment-13506250 ] Hadoop QA commented on ZOOKEEPER-107: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12555320/ZOOKEEPER-107-28-NOV-ver1.patch against trunk revision 1414566. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 28 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1277//testReport/ Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1277//console This message is automatically generated. Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Assignee: Alexander Shraer Fix For: 3.5.0 Attachments: SimpleAddition.rtf, zkreconfig-usenixatc-final.pdf, ZOOKEEPER-107-14-Oct.patch, ZOOKEEPER-107-15-Oct.patch, ZOOKEEPER-107-15-Oct-ver1.patch, ZOOKEEPER-107-15-Oct-ver2.patch, ZOOKEEPER-107-15-Oct-ver3.patch, ZOOKEEPER-107-1-Mar.patch, ZOOKEEPER-107-20-July.patch, ZOOKEEPER-107-21-July.patch, ZOOKEEPER-107-22-Apr.patch, ZOOKEEPER-107-23-SEP.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-NOV-ver1.patch, ZOOKEEPER-107-29-Feb.patch, ZOOKEEPER-107-3-Oct.patch, ZOOKEEPER-107-6-NOV-2.patch, ZOOKEEPER-107-7-NOV.patch, ZOOKEEPER-107-7-NOV-ver1.patch, ZOOKEEPER-107-7-NOV-ver2.patch, ZOOKEEPER-107-Aug-20.patch, ZOOKEEPER-107-Aug-20-ver1.patch, ZOOKEEPER-107-Aug-25.patch, zookeeper-3.4.0.jar, zookeeper-dev-fatjar.jar, zookeeper-reconfig-sep11.patch, zookeeper-reconfig-sep12.patch, zoo_replicated1.cfg, zoo_replicated1.members Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-107: --- Attachment: (was: ZOOKEEPER-107-28-NOV-ver1.patch) Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Assignee: Alexander Shraer Fix For: 3.5.0 Attachments: SimpleAddition.rtf, zkreconfig-usenixatc-final.pdf, ZOOKEEPER-107-14-Oct.patch, ZOOKEEPER-107-15-Oct.patch, ZOOKEEPER-107-15-Oct-ver1.patch, ZOOKEEPER-107-15-Oct-ver2.patch, ZOOKEEPER-107-15-Oct-ver3.patch, ZOOKEEPER-107-1-Mar.patch, ZOOKEEPER-107-20-July.patch, ZOOKEEPER-107-21-July.patch, ZOOKEEPER-107-22-Apr.patch, ZOOKEEPER-107-23-SEP.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-NOV-ver2.patch, ZOOKEEPER-107-29-Feb.patch, ZOOKEEPER-107-3-Oct.patch, ZOOKEEPER-107-6-NOV-2.patch, ZOOKEEPER-107-7-NOV.patch, ZOOKEEPER-107-7-NOV-ver1.patch, ZOOKEEPER-107-7-NOV-ver2.patch, ZOOKEEPER-107-Aug-20.patch, ZOOKEEPER-107-Aug-20-ver1.patch, ZOOKEEPER-107-Aug-25.patch, zookeeper-3.4.0.jar, zookeeper-dev-fatjar.jar, zookeeper-reconfig-sep11.patch, zookeeper-reconfig-sep12.patch, zoo_replicated1.cfg, zoo_replicated1.members Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shraer updated ZOOKEEPER-107: --- Attachment: ZOOKEEPER-107-28-NOV-ver2.patch Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Assignee: Alexander Shraer Fix For: 3.5.0 Attachments: SimpleAddition.rtf, zkreconfig-usenixatc-final.pdf, ZOOKEEPER-107-14-Oct.patch, ZOOKEEPER-107-15-Oct.patch, ZOOKEEPER-107-15-Oct-ver1.patch, ZOOKEEPER-107-15-Oct-ver2.patch, ZOOKEEPER-107-15-Oct-ver3.patch, ZOOKEEPER-107-1-Mar.patch, ZOOKEEPER-107-20-July.patch, ZOOKEEPER-107-21-July.patch, ZOOKEEPER-107-22-Apr.patch, ZOOKEEPER-107-23-SEP.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-NOV-ver2.patch, ZOOKEEPER-107-29-Feb.patch, ZOOKEEPER-107-3-Oct.patch, ZOOKEEPER-107-6-NOV-2.patch, ZOOKEEPER-107-7-NOV.patch, ZOOKEEPER-107-7-NOV-ver1.patch, ZOOKEEPER-107-7-NOV-ver2.patch, ZOOKEEPER-107-Aug-20.patch, ZOOKEEPER-107-Aug-20-ver1.patch, ZOOKEEPER-107-Aug-25.patch, zookeeper-3.4.0.jar, zookeeper-dev-fatjar.jar, zookeeper-reconfig-sep11.patch, zookeeper-reconfig-sep12.patch, zoo_replicated1.cfg, zoo_replicated1.members Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
ZooKeeper_branch33_solaris - Build # 366 - Failure
See https://builds.apache.org/job/ZooKeeper_branch33_solaris/366/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 101397 lines...] [junit] 2012-11-29 06:57:29,907 - INFO [main:FileSnap@82] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test1278302358079986257.junit.dir/version-2/snapshot.0 [junit] 2012-11-29 06:57:29,909 - INFO [main:FileTxnSnapLog@256] - Snapshotting: b [junit] 2012-11-29 06:57:29,911 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2012-11-29 06:57:29,912 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - Accepted socket connection from /127.0.0.1:61687 [junit] 2012-11-29 06:57:29,912 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing stat command from /127.0.0.1:61687 [junit] 2012-11-29 06:57:29,913 - INFO [Thread-4:NIOServerCnxn$StatCommand@1153] - Stat command output [junit] 2012-11-29 06:57:29,914 - INFO [Thread-4:NIOServerCnxn@1435] - Closed socket connection for client /127.0.0.1:61687 (no session established for client) [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2012-11-29 06:57:29,916 - INFO [main:ClientBase@408] - STOPPING server [junit] 2012-11-29 06:57:29,917 - INFO [SyncThread:0:SyncRequestProcessor@151] - SyncRequestProcessor exited! [junit] 2012-11-29 06:57:29,917 - INFO [ProcessThread:-1:PrepRequestProcessor@128] - PrepRequestProcessor exited loop! [junit] 2012-11-29 06:57:29,918 - INFO [main:FinalRequestProcessor@370] - shutdown of request processor complete [junit] 2012-11-29 06:57:29,919 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] ensureOnly:[] [junit] 2012-11-29 06:57:29,920 - INFO [main:ClientBase@401] - STARTING server [junit] 2012-11-29 06:57:29,921 - INFO [main:ZooKeeperServer@154] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test1278302358079986257.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test1278302358079986257.junit.dir/version-2 [junit] 2012-11-29 06:57:29,921 - INFO [main:NIOServerCnxn$Factory@143] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2012-11-29 06:57:29,922 - INFO [main:FileSnap@82] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test1278302358079986257.junit.dir/version-2/snapshot.b [junit] 2012-11-29 06:57:29,925 - INFO [main:FileTxnSnapLog@256] - Snapshotting: b [junit] 2012-11-29 06:57:29,927 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2012-11-29 06:57:29,928 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - Accepted socket connection from /127.0.0.1:61689 [junit] 2012-11-29 06:57:29,928 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing stat command from /127.0.0.1:61689 [junit] 2012-11-29 06:57:29,929 - INFO [Thread-5:NIOServerCnxn$StatCommand@1153] - Stat command output [junit] 2012-11-29 06:57:29,930 - INFO [Thread-5:NIOServerCnxn@1435] - Closed socket connection for client /127.0.0.1:61689 (no session established for client) [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2012-11-29 06:57:29,933 - INFO [main:ClientBase@431] - tearDown starting [junit] 2012-11-29 06:57:29,933 - INFO [main:ClientBase@443] - fdcount after test is: 41 [junit] 2012-11-29 06:57:30,007 - INFO [SessionTracker:SessionTrackerImpl@161] - SessionTrackerImpl exited loop! [junit] 2012-11-29 06:57:30,007 - INFO [SessionTracker:SessionTrackerImpl@161] - SessionTrackerImpl exited loop! [junit] 2012-11-29 06:57:30,008 - INFO [main:ZooKeeper@544] - Session: 0x13b4af4b5bb closed [junit] 2012-11-29 06:57:30,008 - INFO [main-EventThread:ClientCnxn$EventThread@516] - EventThread shut down [junit]
Failed: ZOOKEEPER-107 PreCommit Build #1278
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1278/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 292068 lines...] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12555321/ZOOKEEPER-107-28-NOV-ver2.patch [exec] against trunk revision 1414566. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 28 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1278//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1278//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1278//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] m19COS9l19 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1568: exec returned: 1 Total time: 31 minutes 39 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-107 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506272#comment-13506272 ] Hadoop QA commented on ZOOKEEPER-107: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12555321/ZOOKEEPER-107-28-NOV-ver2.patch against trunk revision 1414566. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 28 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1278//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1278//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1278//console This message is automatically generated. Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Assignee: Alexander Shraer Fix For: 3.5.0 Attachments: SimpleAddition.rtf, zkreconfig-usenixatc-final.pdf, ZOOKEEPER-107-14-Oct.patch, ZOOKEEPER-107-15-Oct.patch, ZOOKEEPER-107-15-Oct-ver1.patch, ZOOKEEPER-107-15-Oct-ver2.patch, ZOOKEEPER-107-15-Oct-ver3.patch, ZOOKEEPER-107-1-Mar.patch, ZOOKEEPER-107-20-July.patch, ZOOKEEPER-107-21-July.patch, ZOOKEEPER-107-22-Apr.patch, ZOOKEEPER-107-23-SEP.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-NOV-ver2.patch, ZOOKEEPER-107-29-Feb.patch, ZOOKEEPER-107-3-Oct.patch, ZOOKEEPER-107-6-NOV-2.patch, ZOOKEEPER-107-7-NOV.patch, ZOOKEEPER-107-7-NOV-ver1.patch, ZOOKEEPER-107-7-NOV-ver2.patch, ZOOKEEPER-107-Aug-20.patch, ZOOKEEPER-107-Aug-20-ver1.patch, ZOOKEEPER-107-Aug-25.patch, zookeeper-3.4.0.jar, zookeeper-dev-fatjar.jar, zookeeper-reconfig-sep11.patch, zookeeper-reconfig-sep12.patch, zoo_replicated1.cfg, zoo_replicated1.members Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506275#comment-13506275 ] Alexander Shraer commented on ZOOKEEPER-107: Again, all tests passed but the report says -1 core tests. Anyone knows why this is happening ? Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Assignee: Alexander Shraer Fix For: 3.5.0 Attachments: SimpleAddition.rtf, zkreconfig-usenixatc-final.pdf, ZOOKEEPER-107-14-Oct.patch, ZOOKEEPER-107-15-Oct.patch, ZOOKEEPER-107-15-Oct-ver1.patch, ZOOKEEPER-107-15-Oct-ver2.patch, ZOOKEEPER-107-15-Oct-ver3.patch, ZOOKEEPER-107-1-Mar.patch, ZOOKEEPER-107-20-July.patch, ZOOKEEPER-107-21-July.patch, ZOOKEEPER-107-22-Apr.patch, ZOOKEEPER-107-23-SEP.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-NOV-ver2.patch, ZOOKEEPER-107-29-Feb.patch, ZOOKEEPER-107-3-Oct.patch, ZOOKEEPER-107-6-NOV-2.patch, ZOOKEEPER-107-7-NOV.patch, ZOOKEEPER-107-7-NOV-ver1.patch, ZOOKEEPER-107-7-NOV-ver2.patch, ZOOKEEPER-107-Aug-20.patch, ZOOKEEPER-107-Aug-20-ver1.patch, ZOOKEEPER-107-Aug-25.patch, zookeeper-3.4.0.jar, zookeeper-dev-fatjar.jar, zookeeper-reconfig-sep11.patch, zookeeper-reconfig-sep12.patch, zoo_replicated1.cfg, zoo_replicated1.members Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: Dynamic reconfiguration, see https://issues.apache.org/jira/browse/ZOOKEEPER-107
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6707/ --- (Updated Nov. 29, 2012, 7:12 a.m.) Review request for zookeeper. Changes --- Latest patch Description --- see https://issues.apache.org/jira/browse/ZOOKEEPER-107 Diffs (updated) - /src/c/include/proto.h 1415037 /src/c/include/zookeeper.h 1415037 /src/c/src/cli.c 1415037 /src/c/src/zookeeper.c 1415037 /src/java/main/org/apache/zookeeper/KeeperException.java 1415037 /src/java/main/org/apache/zookeeper/ZooDefs.java 1415037 /src/java/main/org/apache/zookeeper/ZooKeeper.java 1415037 /src/java/main/org/apache/zookeeper/ZooKeeperMain.java 1415037 /src/java/main/org/apache/zookeeper/cli/GetConfigCommand.java PRE-CREATION /src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java PRE-CREATION /src/java/main/org/apache/zookeeper/server/DataTree.java 1415037 /src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 1415037 /src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 1415037 /src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java 1415037 /src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1415037 /src/java/main/org/apache/zookeeper/server/Request.java 1415037 /src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java 1415037 /src/java/main/org/apache/zookeeper/server/TraceFormatter.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/Follower.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/Leader.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/Learner.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/Observer.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/QuorumBean.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java 1415037 /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumVerifier.java 1415037 /src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java PRE-CREATION /src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1415037 /src/java/test/org/apache/zookeeper/server/TruncateCorruptionTest.java 1415037 /src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 1415037 /src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java PRE-CREATION /src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 1415037 /src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 1415037 /src/java/test/org/apache/zookeeper/test/QuorumMajorityTest.java PRE-CREATION /src/java/test/org/apache/zookeeper/test/QuorumUtil.java 1415037 /src/java/test/org/apache/zookeeper/test/ReconfigTest.java PRE-CREATION /src/zookeeper.jute 1415037 Diff: https://reviews.apache.org/r/6707/diff/ Testing --- New test files were added: ReconfigTest, ReconfigRecoveryTest and QuorumMajorityTest. Many other tests were modified. Thanks, Alexander Shraer
[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506277#comment-13506277 ] Marshall McMullen commented on ZOOKEEPER-107: - The core tests includes both the Java tests and the C tests. If you look only at the java section, you'll think all the tests passed. In this case, if you click on the full output, you'll see: [exec] [exec] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/c/tests/TestReconfig.cc:571: Assertion: assertion failed [Expression: numClientsPerHost.at(i) = lowerboundClientsPerServer(numClients, numServers)] [exec] [exec] Failures !!! [exec] [exec] Run: 38 Failure total: 1 Failures: 1 Errors: 0 [exec] [exec] make: *** [run-check] Error 1 [exec] [exec] BUILD FAILED [exec] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1262: The following error occurred while executing this line: [exec] /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1272: exec returned: 2 Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Assignee: Alexander Shraer Fix For: 3.5.0 Attachments: SimpleAddition.rtf, zkreconfig-usenixatc-final.pdf, ZOOKEEPER-107-14-Oct.patch, ZOOKEEPER-107-15-Oct.patch, ZOOKEEPER-107-15-Oct-ver1.patch, ZOOKEEPER-107-15-Oct-ver2.patch, ZOOKEEPER-107-15-Oct-ver3.patch, ZOOKEEPER-107-1-Mar.patch, ZOOKEEPER-107-20-July.patch, ZOOKEEPER-107-21-July.patch, ZOOKEEPER-107-22-Apr.patch, ZOOKEEPER-107-23-SEP.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-NOV-ver2.patch, ZOOKEEPER-107-29-Feb.patch, ZOOKEEPER-107-3-Oct.patch, ZOOKEEPER-107-6-NOV-2.patch, ZOOKEEPER-107-7-NOV.patch, ZOOKEEPER-107-7-NOV-ver1.patch, ZOOKEEPER-107-7-NOV-ver2.patch, ZOOKEEPER-107-Aug-20.patch, ZOOKEEPER-107-Aug-20-ver1.patch, ZOOKEEPER-107-Aug-25.patch, zookeeper-3.4.0.jar, zookeeper-dev-fatjar.jar, zookeeper-reconfig-sep11.patch, zookeeper-reconfig-sep12.patch, zoo_replicated1.cfg, zoo_replicated1.members Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-107) Allow dynamic changes to server cluster membership
[ https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506287#comment-13506287 ] Alexander Shraer commented on ZOOKEEPER-107: Ah, you're right. Looking at this line (committed as part of our 1355), this is testing initial distribution of clients across servers, even before any rebalancing algorithm is invoked. Perhaps some random number generator problems ? On Wed, Nov 28, 2012 at 11:17 PM, Marshall McMullen (JIRA) Allow dynamic changes to server cluster membership -- Key: ZOOKEEPER-107 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Assignee: Alexander Shraer Fix For: 3.5.0 Attachments: SimpleAddition.rtf, zkreconfig-usenixatc-final.pdf, ZOOKEEPER-107-14-Oct.patch, ZOOKEEPER-107-15-Oct.patch, ZOOKEEPER-107-15-Oct-ver1.patch, ZOOKEEPER-107-15-Oct-ver2.patch, ZOOKEEPER-107-15-Oct-ver3.patch, ZOOKEEPER-107-1-Mar.patch, ZOOKEEPER-107-20-July.patch, ZOOKEEPER-107-21-July.patch, ZOOKEEPER-107-22-Apr.patch, ZOOKEEPER-107-23-SEP.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-28-NOV-ver2.patch, ZOOKEEPER-107-29-Feb.patch, ZOOKEEPER-107-3-Oct.patch, ZOOKEEPER-107-6-NOV-2.patch, ZOOKEEPER-107-7-NOV.patch, ZOOKEEPER-107-7-NOV-ver1.patch, ZOOKEEPER-107-7-NOV-ver2.patch, ZOOKEEPER-107-Aug-20.patch, ZOOKEEPER-107-Aug-20-ver1.patch, ZOOKEEPER-107-Aug-25.patch, zookeeper-3.4.0.jar, zookeeper-dev-fatjar.jar, zookeeper-reconfig-sep11.patch, zookeeper-reconfig-sep12.patch, zoo_replicated1.cfg, zoo_replicated1.members Currently cluster membership is statically defined, adding/removing hosts to/from the server cluster dynamically needs to be supported. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Build failed in Jenkins: bookkeeper-trunk #826
See https://builds.apache.org/job/bookkeeper-trunk/826/ -- Started by timer Building remotely on ubuntu5 in workspace https://builds.apache.org/job/bookkeeper-trunk/ws/ hudson.util.IOException2: remote file operation failed: https://builds.apache.org/job/bookkeeper-trunk/ws/ at hudson.remoting.Channel@4e9d8e4:ubuntu5 at hudson.FilePath.act(FilePath.java:848) at hudson.FilePath.act(FilePath.java:825) at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:743) at hudson.scm.SubversionSCM.checkout(SubversionSCM.java:685) at hudson.model.AbstractProject.checkout(AbstractProject.java:1324) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:676) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:88) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:581) at hudson.model.Run.execute(Run.java:1518) at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:477) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:236) Caused by: java.io.IOException: Remote call on ubuntu5 failed at hudson.remoting.Channel.call(Channel.java:674) at hudson.FilePath.act(FilePath.java:841) ... 11 more Caused by: java.lang.LinkageError: loader (instance of hudson/remoting/RemoteClassLoader): attempted duplicate class definition for name: hudson/model/Descriptor at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:634) at java.lang.ClassLoader.defineClass(ClassLoader.java:480) at hudson.remoting.RemoteClassLoader.loadClassFile(RemoteClassLoader.java:152) at hudson.remoting.RemoteClassLoader.findClass(RemoteClassLoader.java:131) at java.lang.ClassLoader.loadClass(ClassLoader.java:321) at java.lang.ClassLoader.loadClass(ClassLoader.java:266) at java.lang.Class.getDeclaredFields0(Native Method) at java.lang.Class.privateGetDeclaredFields(Class.java:2308) at java.lang.Class.getDeclaredField(Class.java:1897) at java.io.ObjectStreamClass.getDeclaredSUID(ObjectStreamClass.java:1624) at java.io.ObjectStreamClass.access$700(ObjectStreamClass.java:69) at java.io.ObjectStreamClass$2.run(ObjectStreamClass.java:442) at java.security.AccessController.doPrivileged(Native Method) at java.io.ObjectStreamClass.init(ObjectStreamClass.java:430) at java.io.ObjectStreamClass.lookup(ObjectStreamClass.java:327) at java.io.ObjectStreamClass.initNonProxy(ObjectStreamClass.java:564) at java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:1600) at java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1513) at java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:1600) at java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1513) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1749) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1346) at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:1963) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1887) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1770) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1346) at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:1963) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1887) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1770) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1346) at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:1963) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1887) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1770) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1346) at java.io.ObjectInputStream.readObject(ObjectInputStream.java:368) at hudson.remoting.UserRequest.deserialize(UserRequest.java:182) at hudson.remoting.UserRequest.perform(UserRequest.java:98) at hudson.remoting.UserRequest.perform(UserRequest.java:48) at hudson.remoting.Request$2.run(Request.java:326) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at
[jira] [Commented] (BOOKKEEPER-464) Provide an improved GC algorithm
[ https://issues.apache.org/jira/browse/BOOKKEEPER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505487#comment-13505487 ] Flavio Junqueira commented on BOOKKEEPER-464: - Unless I'm misunderstanding the meaning of zombie entries, the operations related to a ledger fragment in any given bookie need to be atomic. If a bookie starts replicating a ledger fragment because it has been added to the ensemble of ledger but it doesn't complete the replication process because, e.g., its disk becomes full, then we remove the partially replicated ledger fragment. If a bookie is notified that a ledger has been marked for deletion while it is replicating the ledger fragment, then it shouldn't delete the ledger fragment in the middle of the replication process. Perhaps we should have a sequencer thread in each bookie that enforces atomicity in the way I'm mentioning. Provide an improved GC algorithm Key: BOOKKEEPER-464 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-464 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-server Reporter: Sijie Guo Assignee: Fangmin Lv Fix For: 4.3.0 Attachments: BOOKKEEPER-464.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (BOOKKEEPER-486) BOOKKEEPER-440 introduced 1 findbugs warning.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly resolved BOOKKEEPER-486. --- Resolution: Fixed BOOKKEEPER-440 introduced 1 findbugs warning. - Key: BOOKKEEPER-486 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-486 Project: Bookkeeper Issue Type: Bug Components: hedwig-server Reporter: Sijie Guo Fix For: 4.2.0 One findbugs warning is introduced by BOOKKEEPER-440 in InMemorySubscriptionManager. And it seems that InMemorySubscriptionManager#readSubscriptionData doesn't work correctly based on backup memory map. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (BOOKKEEPER-486) BOOKKEEPER-440 introduced 1 findbugs warning.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly reopened BOOKKEEPER-486: --- BOOKKEEPER-440 introduced 1 findbugs warning. - Key: BOOKKEEPER-486 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-486 Project: Bookkeeper Issue Type: Bug Components: hedwig-server Reporter: Sijie Guo Fix For: 4.2.0 One findbugs warning is introduced by BOOKKEEPER-440 in InMemorySubscriptionManager. And it seems that InMemorySubscriptionManager#readSubscriptionData doesn't work correctly based on backup memory map. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (BOOKKEEPER-486) BOOKKEEPER-440 introduced 1 findbugs warning.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly resolved BOOKKEEPER-486. --- Resolution: Duplicate BOOKKEEPER-440 introduced 1 findbugs warning. - Key: BOOKKEEPER-486 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-486 Project: Bookkeeper Issue Type: Bug Components: hedwig-server Reporter: Sijie Guo Fix For: 4.2.0 One findbugs warning is introduced by BOOKKEEPER-440 in InMemorySubscriptionManager. And it seems that InMemorySubscriptionManager#readSubscriptionData doesn't work correctly based on backup memory map. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-464) Provide an improved GC algorithm
[
https://issues.apache.org/jira/browse/BOOKKEEPER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505739#comment-13505739
]
Sijie Guo commented on BOOKKEEPER-464:
--
{quote}
If a bookie starts replicating a ledger fragment because it has been added to
the ensemble of ledger but it doesn't complete the replication process because,
e.g., its disk becomes full, then we remove the partially replicated ledger
fragment.
{quote}
For replication, the sequence is that 1) we picked up a bookie to replicate
entries to it, and then 2) update the ledger ensemble only after those entries
are replicated. if there are failures happened between replicating and updating
ledger ensemble, those replicated entries will become zombies (not referenced
by any ledger ensemble).
I think I wrote a comment in BOOKKEEPER-249 (
https://issues.apache.org/jira/browse/BOOKKEEPER-249?focusedCommentId=13497139page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13497139
) to discuss all the possible cases causing zombie entries (also I gave my
understanding about zombie entry in that comment).
Provide an improved GC algorithm
Key: BOOKKEEPER-464
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-464
Project: Bookkeeper
Issue Type: Sub-task
Components: bookkeeper-server
Reporter: Sijie Guo
Assignee: Fangmin Lv
Fix For: 4.3.0
Attachments: BOOKKEEPER-464.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-249) Revisit garbage collection algorithm in Bookie server
[ https://issues.apache.org/jira/browse/BOOKKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505905#comment-13505905 ] Flavio Junqueira commented on BOOKKEEPER-249: - Here is a thought for dealing with zombie entries. We could keep for each bookie Bi, under '/ledgers/deleted/Bi', a znode containing the largest id (LL) of a ledger that the bookie has deleted. This way the bookie can check in each garbage-collection cycle if it has entries for a ledger L LL. In this case, the bookie deletes those ledgers. Let me give an example to illustrate. Say a bookie stores fragments for ledgers L1,L5,L6 and a client deletes L1 and L5. When it runs a gc cycle, it deletes L1 and L5 and writes to znode '/ledgers/deleted/Bi/Largest' the value L5. Eventually, another client deletes L6, the bookie deletes L6 and sets the data of '/ledgers/deleted/Bi/Largest' to L6. While checking the entries that it has stored, Bi finds that it has entries for a ledger with id smaller than 6, say L5, then it is safe to delete the entries. What do you think, Sijie? Revisit garbage collection algorithm in Bookie server - Key: BOOKKEEPER-249 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-249 Project: Bookkeeper Issue Type: Improvement Components: bookkeeper-server Reporter: Sijie Guo Fix For: 4.2.0 Attachments: gc_revisit.pdf Per discussion in BOOKKEEPER-181, it would be better to revisit garbage collection algorithm in bookie server. so create a subtask to focus on it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-464) Provide an improved GC algorithm
[ https://issues.apache.org/jira/browse/BOOKKEEPER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505906#comment-13505906 ] Flavio Junqueira commented on BOOKKEEPER-464: - Thanks, Sijie. I added a comment to BOOKKEEPER-249. Provide an improved GC algorithm Key: BOOKKEEPER-464 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-464 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-server Reporter: Sijie Guo Assignee: Fangmin Lv Fix For: 4.3.0 Attachments: BOOKKEEPER-464.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-249) Revisit garbage collection algorithm in Bookie server
[
https://issues.apache.org/jira/browse/BOOKKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506136#comment-13506136
]
Sijie Guo commented on BOOKKEEPER-249:
--
{quote}
Let me give an example to illustrate. Say a bookie stores fragments for ledgers
L1,L5,L6 and a client deletes L1 and L5. When it runs a gc cycle, it deletes L1
and L5 and writes to znode '/ledgers/deleted/Bi/Largest' the value L5.
Eventually, another client deletes L6, the bookie deletes L6 and sets the data
of '/ledgers/deleted/Bi/Largest' to L6. While checking the entries that it has
stored, Bi finds that it has entries for a ledger with id smaller than 6, say
L5, then it is safe to delete the entries.
{quote}
I don't think it was correct. since you could not guarantee the ledgers are
created in bookie in ledger id's order.
take you example:
1) at time T, we had L1, L5, L6 in a bookie. L1 and L5 is deleted.
2) a gc cycle is coming. L1 and L5 are deleted and 'Largest' znode is updated
to L5.
3) client of L2 is writing entries to this bookie now. L2 is created in this
bookie to stored its fragments.
4) next gc cycle is coming. this bookie would delete L2 even L2 hasn't been
deleted.
If I didn't understand your idea correctly, please correct me.
Revisit garbage collection algorithm in Bookie server
-
Key: BOOKKEEPER-249
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-249
Project: Bookkeeper
Issue Type: Improvement
Components: bookkeeper-server
Reporter: Sijie Guo
Fix For: 4.2.0
Attachments: gc_revisit.pdf
Per discussion in BOOKKEEPER-181, it would be better to revisit garbage
collection algorithm in bookie server. so create a subtask to focus on it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-457) Create a format command for Hedwig to cleanup its metadata.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-457: - Attachment: BOOKKEEPER-457.patch Attach a new patch addressing Ivan's comments. Create a format command for Hedwig to cleanup its metadata. --- Key: BOOKKEEPER-457 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-457 Project: Bookkeeper Issue Type: Bug Affects Versions: 4.1.0 Reporter: Sijie Guo Assignee: Sijie Guo Fix For: 4.2.0 Attachments: BOOKKEEPER-457.diff, BOOKKEEPER-457.patch Create a format command for Hedwig to cleanup metadata for a clean setup. similar as BOOKKEEPER-300. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.
On Nov. 27, 2012, 4:33 a.m., Sijie Guo wrote: great work, Fangmin. The patch looks good. Just had some minor comments, mostly about names and interface. Thanks sijie, will change the name and interface according to your comments. On Nov. 27, 2012, 4:33 a.m., Sijie Guo wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/SnapshotMap.java, line 32 https://reviews.apache.org/r/8141/diff/3/?file=222521#file222521line32 I am just thinking that since SnapshotMap is quite generic a class. Is it possible to move it to util package for public, not just mark it as public in meta package? I am open to this movement. I've thought about this, it's ok to put it to util, will move. On Nov. 27, 2012, 4:33 a.m., Sijie Guo wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java, line 139 https://reviews.apache.org/r/8141/diff/3/?file=222519#file222519line139 could you define -1 as constants? Yes will define. On Nov. 27, 2012, 4:33 a.m., Sijie Guo wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java, line 495 https://reviews.apache.org/r/8141/diff/3/?file=222517#file222517line495 initial is not a good method. Either you could the initialization work in the constructor of HierarchicalLedgerRangeIterator or initialize it lazily until call next(). Also, catch the exception and return null is also bad practice. I think a better practice is initialize it lazily and if there is not nodes under ledgerRootPath, hasNext return false. instead of returning a null iterator. If did that, you need throw IOException for hasNext interface. Good idea, will change, thanks. On Nov. 27, 2012, 4:33 a.m., Sijie Guo wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java, line 429 https://reviews.apache.org/r/8141/diff/3/?file=222513#file222513line429 since AbstractZkLedgerManager is an abstract class, I think an nop implementation of close is not necessary for it. Will remove. On Nov. 27, 2012, 4:33 a.m., Sijie Guo wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java, line 77 https://reviews.apache.org/r/8141/diff/3/?file=222511#file222511line77 if we failed to fetch a ledger range, do we need to continue? will a bad implementation of LedgerManager cause infinite loop? I think it was OK to break here. The current LedgerManager implementer will not lead to infinite loop, so it's both ok to continue or break, but you suggestion is reasonable, will break here. - Fangmin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/#review13763 --- On Nov. 21, 2012, 3:19 a.m., Fangmin Lv wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/ --- (Updated Nov. 21, 2012, 3:19 a.m.) Review request for bookkeeper. Description --- Main changes: 1. Refactor Garbage Collector Interface 2. Change LedgerManager#deleteLedger to versioned delete 3. Remove ActiveLedgerManager interface 4. Move some common functions to StringUtils and ZkUtils This addresses bug BOOKKEEPER-463. https://issues.apache.org/jira/browse/BOOKKEEPER-463 Diffs - bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 929be51 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollector.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java cecb74a bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java c3f5149 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java c8d2b21 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java eae1f37 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java 9dcb1b9 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java 542b498 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java e284776 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java 329e0a7 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java 3499a05 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java c86b884
Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.
On Nov. 28, 2012, 5:28 p.m., fpj wrote: here are some minor comments about the patch. I still want to think a bit more about the high-level approach taken here, though. Thanks Flavio, I will change the comments and method name according to your proposal, if there are problems about high-level approach, please tell me, thanks. On Nov. 28, 2012, 5:28 p.m., fpj wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java, line 103 https://reviews.apache.org/r/8141/diff/3/?file=222511#file222511line103 should we really just continue here or propagate the exception up? The current LedgerManager implementer will not lead to infinite loop, so it's both ok to continue or break, we do not need to propagate exception up, since next time, we will do the GC again, it's not a fatal exception. On Nov. 28, 2012, 5:28 p.m., fpj wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java, line 108 https://reviews.apache.org/r/8141/diff/3/?file=222511#file222511line108 if zkActiveLedgers is null, should we really silently move on? I don't understand the expected semantics here. Will remove this, we not need it anymore. On Nov. 28, 2012, 5:28 p.m., fpj wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java, line 52 https://reviews.apache.org/r/8141/diff/3/?file=222519#file222519line52 This change seems to be unrelated to this patch. I found the LedgerManager is an interface, we don't need the abstract keyword. Actually I found this when I change the 'deleteLedger' method to version control, this is not directly related to this patch, but I want to keep consistency. On Nov. 28, 2012, 5:28 p.m., fpj wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java, line 419 https://reviews.apache.org/r/8141/diff/3/?file=222513#file222513line419 another instance of continuing when something goes wrong. should we really just continue here? We can continue here, only when ledger node have a incorrect format will reach here, we just consider the ledger as a non-existent ledger, I think it's fine to do so. On Nov. 28, 2012, 5:28 p.m., fpj wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java, line 130 https://reviews.apache.org/r/8141/diff/3/?file=222519#file222519line130 why do we have this static class here? should we have a bookie.legdermanager package for all these related classes? From my aspect I think 'bookie.meta' = 'bookie.ledgermanager' package as you proposed. I can move this class out to meta package if necessary. - Fangmin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/#review13805 --- On Nov. 21, 2012, 3:19 a.m., Fangmin Lv wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/ --- (Updated Nov. 21, 2012, 3:19 a.m.) Review request for bookkeeper. Description --- Main changes: 1. Refactor Garbage Collector Interface 2. Change LedgerManager#deleteLedger to versioned delete 3. Remove ActiveLedgerManager interface 4. Move some common functions to StringUtils and ZkUtils This addresses bug BOOKKEEPER-463. https://issues.apache.org/jira/browse/BOOKKEEPER-463 Diffs - bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 929be51 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollector.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java cecb74a bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java c3f5149 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java c8d2b21 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java eae1f37 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java 9dcb1b9 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java 542b498 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java e284776 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java 329e0a7 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java 3499a05
Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.
On Nov. 28, 2012, 6:10 p.m., fpj wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java, line 87 https://reviews.apache.org/r/8141/diff/3/?file=222511#file222511line87 what are the case(s) in which end would be -1? Sorry, this scenario will only occur in the the MSLedgerManager which haven't been in yet. On Nov. 28, 2012, 6:10 p.m., fpj wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/StringUtils.java, line 100 https://reviews.apache.org/r/8141/diff/3/?file=222522#file222522line100 could you move the throws part to the next line? Yes, I will ,thanks. On Nov. 28, 2012, 6:10 p.m., fpj wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java, line 103 https://reviews.apache.org/r/8141/diff/3/?file=222513#file222513line103 all the cases I've seen in this patch use ANY version, so I was wondering about the motivation for the version input parameter and for deleting the znode. We want a versioned remove, but there will be a lot of other changes related to versioned remove which is not about GC, maybe we can fire another jira to track this, I will change back to deleteLedger in this patch. Thanks for point out. - Fangmin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/#review13823 --- On Nov. 21, 2012, 3:19 a.m., Fangmin Lv wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/ --- (Updated Nov. 21, 2012, 3:19 a.m.) Review request for bookkeeper. Description --- Main changes: 1. Refactor Garbage Collector Interface 2. Change LedgerManager#deleteLedger to versioned delete 3. Remove ActiveLedgerManager interface 4. Move some common functions to StringUtils and ZkUtils This addresses bug BOOKKEEPER-463. https://issues.apache.org/jira/browse/BOOKKEEPER-463 Diffs - bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 929be51 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollector.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java cecb74a bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java c3f5149 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java c8d2b21 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java eae1f37 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java 9dcb1b9 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java 542b498 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java e284776 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java 329e0a7 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java 3499a05 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java c86b884 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 30e2b83 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java a7fc247 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/SnapshotMap.java c222f05 bookkeeper-server/src/main/java/org/apache/bookkeeper/util/StringUtils.java 575e480 bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ZkUtils.java 4073450 bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java a24b1e2 bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 7ecf937 bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java cd0b91f Diff: https://reviews.apache.org/r/8141/diff/ Testing --- Thanks, Fangmin Lv
Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/#review13817 --- bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java https://reviews.apache.org/r/8141/#comment29498 The current LedgerManager implementer will not cause infinite loop, since each iterator will move to the next. But this is a good suggestion, we can break here. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java https://reviews.apache.org/r/8141/#comment29499 Will Change, thanks. bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java https://reviews.apache.org/r/8141/#comment29500 Ok, I will change, thanks. bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java https://reviews.apache.org/r/8141/#comment29501 Yes, will remove. bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java https://reviews.apache.org/r/8141/#comment29508 Thanks, will take your proposal bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java https://reviews.apache.org/r/8141/#comment29502 Good name. bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java https://reviews.apache.org/r/8141/#comment29503 Ok, I will bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java https://reviews.apache.org/r/8141/#comment29504 Yes, will check. bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/SnapshotMap.java https://reviews.apache.org/r/8141/#comment29505 Yes, I have thought about this, I think we can move it to util. bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java https://reviews.apache.org/r/8141/#comment29506 Yes, will change - Fangmin Lv On Nov. 21, 2012, 3:19 a.m., Fangmin Lv wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/ --- (Updated Nov. 21, 2012, 3:19 a.m.) Review request for bookkeeper. Description --- Main changes: 1. Refactor Garbage Collector Interface 2. Change LedgerManager#deleteLedger to versioned delete 3. Remove ActiveLedgerManager interface 4. Move some common functions to StringUtils and ZkUtils This addresses bug BOOKKEEPER-463. https://issues.apache.org/jira/browse/BOOKKEEPER-463 Diffs - bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 929be51 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollector.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java cecb74a bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java c3f5149 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java c8d2b21 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java eae1f37 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java 9dcb1b9 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java 542b498 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java e284776 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java 329e0a7 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java 3499a05 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java c86b884 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 30e2b83 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java a7fc247 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/SnapshotMap.java c222f05 bookkeeper-server/src/main/java/org/apache/bookkeeper/util/StringUtils.java 575e480 bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ZkUtils.java 4073450 bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java a24b1e2 bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 7ecf937 bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java cd0b91f Diff: https://reviews.apache.org/r/8141/diff/ Testing --- Thanks, Fangmin Lv
Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.
On Nov. 27, 2012, 4:33 a.m., Sijie Guo wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java, line 429 https://reviews.apache.org/r/8141/diff/3/?file=222513#file222513line429 since AbstractZkLedgerManager is an abstract class, I think an nop implementation of close is not necessary for it. Fangmin Lv wrote: Will remove. FlatLedgerManager and HierachicalLedgerManager need nothing to be closed, so I think it's better to use the same nop close in AbstractZkLedgerManager. - Fangmin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/#review13763 --- On Nov. 21, 2012, 3:19 a.m., Fangmin Lv wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/ --- (Updated Nov. 21, 2012, 3:19 a.m.) Review request for bookkeeper. Description --- Main changes: 1. Refactor Garbage Collector Interface 2. Change LedgerManager#deleteLedger to versioned delete 3. Remove ActiveLedgerManager interface 4. Move some common functions to StringUtils and ZkUtils This addresses bug BOOKKEEPER-463. https://issues.apache.org/jira/browse/BOOKKEEPER-463 Diffs - bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 929be51 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollector.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java cecb74a bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java c3f5149 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java c8d2b21 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java eae1f37 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java 9dcb1b9 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java 542b498 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java e284776 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java 329e0a7 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java 3499a05 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java c86b884 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 30e2b83 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java a7fc247 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/SnapshotMap.java c222f05 bookkeeper-server/src/main/java/org/apache/bookkeeper/util/StringUtils.java 575e480 bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ZkUtils.java 4073450 bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java a24b1e2 bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 7ecf937 bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java cd0b91f Diff: https://reviews.apache.org/r/8141/diff/ Testing --- Thanks, Fangmin Lv
Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.
On Nov. 28, 2012, 6:10 p.m., fpj wrote: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java, line 103 https://reviews.apache.org/r/8141/diff/3/?file=222513#file222513line103 all the cases I've seen in this patch use ANY version, so I was wondering about the motivation for the version input parameter and for deleting the znode. Fangmin Lv wrote: We want a versioned remove, but there will be a lot of other changes related to versioned remove which is not about GC, maybe we can fire another jira to track this, I will change back to deleteLedger in this patch. Thanks for point out. After consideration I think it's better to provide a way to versioned remove although we haven't used it in the current code. It's a better interface for the new code, we can change the old code if necessary in the future. - Fangmin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/#review13823 --- On Nov. 21, 2012, 3:19 a.m., Fangmin Lv wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/ --- (Updated Nov. 21, 2012, 3:19 a.m.) Review request for bookkeeper. Description --- Main changes: 1. Refactor Garbage Collector Interface 2. Change LedgerManager#deleteLedger to versioned delete 3. Remove ActiveLedgerManager interface 4. Move some common functions to StringUtils and ZkUtils This addresses bug BOOKKEEPER-463. https://issues.apache.org/jira/browse/BOOKKEEPER-463 Diffs - bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 929be51 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollector.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java cecb74a bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java c3f5149 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java c8d2b21 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java eae1f37 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java 9dcb1b9 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java 542b498 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java e284776 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java 329e0a7 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java 3499a05 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java c86b884 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 30e2b83 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java a7fc247 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/SnapshotMap.java c222f05 bookkeeper-server/src/main/java/org/apache/bookkeeper/util/StringUtils.java 575e480 bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ZkUtils.java 4073450 bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java a24b1e2 bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 7ecf937 bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java cd0b91f Diff: https://reviews.apache.org/r/8141/diff/ Testing --- Thanks, Fangmin Lv
[jira] [Updated] (BOOKKEEPER-389) add documentation for message filter.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-389: - Attachment: BOOKKEEPER-389.patch Attach a patch to document message filter features. add documentation for message filter. - Key: BOOKKEEPER-389 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-389 Project: Bookkeeper Issue Type: Sub-task Components: hedwig-client, hedwig-server Reporter: Sijie Guo Assignee: Sijie Guo Fix For: 4.2.0 Attachments: BOOKKEEPER-389.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-410) Hedwig client should remove message handler while closing subscription
[ https://issues.apache.org/jira/browse/BOOKKEEPER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506255#comment-13506255 ] Sijie Guo commented on BOOKKEEPER-410: -- I think after BOOKKEEPER-70, we had stopDelivery when closeSubscription. So I think it should already fix this issue described here. [~i0exception] Could you help double-checking about it? Hedwig client should remove message handler while closing subscription -- Key: BOOKKEEPER-410 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-410 Project: Bookkeeper Issue Type: Bug Components: hedwig-client, hedwig-server Affects Versions: 4.2.0 Reporter: Aniruddha Fix For: 4.2.0 The hedwig java client does not remove a message handler for the topic (by calling stopDelivery) when we close a subscription channel. Because of this, when a subscription request goes through with another message handler, the subscription goes fine, but we can't start delivery. The only reason for keeping the message handler is to support restartDelivery. We should change the way restart delivery is handled by storing the existing message handler in the SubscribeReconnectCallback and forcing the subscribe handler to use it when we restart delivery. This manifests as a bug in the region manager. When a topic moves from one hub to another and then returns to this hub, because the client still has a dangling MessageHandler, none of the subscriptions succeed because they can't start delivery. As an additional check, the region manager's client should not start delivery for a topic if there is an existing message handler. Any thoughts? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-389) add documentation for message filter.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506260#comment-13506260
]
Hadoop QA commented on BOOKKEEPER-389:
--
Testing JIRA BOOKKEEPER-389
WARNING: Running test-patch on a dirty local svn workspace
Patch a
href=/jira/secure/attachment/12555319/BOOKKEEPER-389.patch/jira/secure/attachment/12555319/BOOKKEEPER-389.patch/a
downloaded at Thu Nov 29 06:11:13 UTC 2012
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.{color:green}+1{color} the patch does not introduce any @author tags
.{color:green}+1{color} the patch does not introduce any tabs
.{color:red}-1{color} the patch contains 1 line(s) with trailing spaces
.{color:red}-1{color} the patch contains 1 line(s) longer than 120
characters
.{color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.{color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
.{color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
.{color:red}WARNING{color}: the current HEAD has 8 Javadoc warning(s)
{color:green}+1 COMPILE{color}
.{color:green}+1{color} HEAD compiles
.{color:green}+1{color} patch compiles
.{color:green}+1{color} the patch does not seem to introduce new javac
warnings
.{color:red}WARNING{color}: the current HEAD has 9 javac warning(s)
{color:green}+1 FINDBUGS{color}
.{color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
.{color:red}WARNING: the current HEAD has Findbugs warning(s), they should
be addressed ASAP{color}
{color:green}+1 TESTS{color}
.Tests run: 383
{color:green}+1 DISTRO{color}
.{color:green}+1{color} distro tarball builds with the patch
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/47/
add documentation for message filter.
-
Key: BOOKKEEPER-389
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-389
Project: Bookkeeper
Issue Type: Sub-task
Components: hedwig-client, hedwig-server
Reporter: Sijie Guo
Assignee: Sijie Guo
Fix For: 4.2.0
Attachments: BOOKKEEPER-389.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-351) asyncAddEntry should not throw an exception
[ https://issues.apache.org/jira/browse/BOOKKEEPER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506261#comment-13506261 ] Sijie Guo commented on BOOKKEEPER-351: -- [~merlimat] Is there any updates about this JIRA? asyncAddEntry should not throw an exception --- Key: BOOKKEEPER-351 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-351 Project: Bookkeeper Issue Type: Bug Affects Versions: 4.2.0 Reporter: Matteo Merli Assignee: Matteo Merli Priority: Minor Fix For: 4.2.0 Attachments: 0001-BOOKKEEPER-351-asyncAddEntry-should-not-throw-an-exc.patch There are cases where LedgerHandle.asyncAddEntry() fails with a RuntimeException that is thrown by executor.submit(). It should better invoke the callback with a failure result. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/ --- (Updated Nov. 29, 2012, 7:05 a.m.) Review request for bookkeeper. Changes --- Changes according to sijie and flavio's suggestion. Description --- Main changes: 1. Refactor Garbage Collector Interface 2. Change LedgerManager#deleteLedger to versioned delete 3. Remove ActiveLedgerManager interface 4. Move some common functions to StringUtils and ZkUtils This addresses bug BOOKKEEPER-463. https://issues.apache.org/jira/browse/BOOKKEEPER-463 Diffs (updated) - bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 929be51 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollector.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java cecb74a bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java c3f5149 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java c8d2b21 bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java eae1f37 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java 9dcb1b9 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java 542b498 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java e284776 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java 329e0a7 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java 3499a05 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java c86b884 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 30e2b83 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java a7fc247 bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/SnapshotMap.java c222f05 bookkeeper-server/src/main/java/org/apache/bookkeeper/util/SnapshotMap.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/util/StringUtils.java 575e480 bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ZkUtils.java 4073450 bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java a24b1e2 bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 7ecf937 bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java cd0b91f Diff: https://reviews.apache.org/r/8141/diff/ Testing --- Thanks, Fangmin Lv
[jira] [Updated] (BOOKKEEPER-463) Refactor garbage collection code for ease to plugin different GC algorithm.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv updated BOOKKEEPER-463: -- Attachment: BOOKKEEPER-463.patch Provide a new patch according to Sijie and Flavio's suggestion. Refactor garbage collection code for ease to plugin different GC algorithm. --- Key: BOOKKEEPER-463 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-463 Project: Bookkeeper Issue Type: Sub-task Components: bookkeeper-server Reporter: Sijie Guo Assignee: Fangmin Lv Fix For: 4.3.0 Attachments: BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch, BOOKKEEPER-463.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-399) Let hub server could configure write quorum from ack quorum.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-399: - Attachment: BOOKKEEPER-399.diff attach a patch to let hub server could configure write quorum and ack quorum. Let hub server could configure write quorum from ack quorum. Key: BOOKKEEPER-399 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-399 Project: Bookkeeper Issue Type: New Feature Components: hedwig-server Reporter: Sijie Guo Priority: Minor Fix For: 4.2.0 Attachments: BOOKKEEPER-399.diff since we support ack quorum in BOOKKEEPER-208, it would be better to let hub server could configure it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
