ZooKeeper_branch34_solaris - Build # 708 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch34_solaris/708/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 155874 lines...] [junit] 2013-11-14 09:10:25,132 [myid:] - INFO [Thread-4:NIOServerCnxn@997] - Closed socket connection for client /127.0.0.1:52020 (no session established for client) [junit] 2013-11-14 09:10:25,132 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-11-14 09:10:25,133 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-11-14 09:10:25,133 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-11-14 09:10:25,133 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-11-14 09:10:25,134 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-14 09:10:25,134 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-11-14 09:10:25,134 [myid:] - INFO [main:ZooKeeperServer@441] - shutting down [junit] 2013-11-14 09:10:25,135 [myid:] - INFO [main:SessionTrackerImpl@225] - Shutting down [junit] 2013-11-14 09:10:25,135 [myid:] - INFO [main:PrepRequestProcessor@761] - Shutting down [junit] 2013-11-14 09:10:25,135 [myid:] - INFO [main:SyncRequestProcessor@209] - Shutting down [junit] 2013-11-14 09:10:25,135 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop! [junit] 2013-11-14 09:10:25,135 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited! [junit] 2013-11-14 09:10:25,135 [myid:] - INFO [main:FinalRequestProcessor@415] - shutdown of request processor complete [junit] 2013-11-14 09:10:25,136 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-14 09:10:25,136 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[] [junit] 2013-11-14 09:10:25,137 [myid:] - INFO [main:ClientBase@414] - STARTING server [junit] 2013-11-14 09:10:25,137 [myid:] - INFO [main:ZooKeeperServer@162] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/trunk/build/test/tmp/test4245863175707207319.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/trunk/build/test/tmp/test4245863175707207319.junit.dir/version-2 [junit] 2013-11-14 09:10:25,138 [myid:] - INFO [main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-11-14 09:10:25,141 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-14 09:10:25,141 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - Accepted socket connection from /127.0.0.1:52022 [junit] 2013-11-14 09:10:25,142 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@817] - Processing stat command from /127.0.0.1:52022 [junit] 2013-11-14 09:10:25,142 [myid:] - INFO [Thread-5:NIOServerCnxn$StatCommand@653] - Stat command output [junit] 2013-11-14 09:10:25,142 [myid:] - INFO [Thread-5:NIOServerCnxn@997] - Closed socket connection for client /127.0.0.1:52022 (no session established for client) [junit] 2013-11-14 09:10:25,142 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-11-14 09:10:25,144 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-11-14 09:10:25,144 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-11-14 09:10:25,144 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-11-14 09:10:25,144 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-14 09:10:25,145 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota [junit] 2013-11-14 09:10:25,145 [myid:] - INFO [main:ClientBase@451] - tearDown starting [junit] 2013-11-14 09:10:25,226 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x14255e02f98 closed [junit] 2013-11-14 09:10:25,226 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@509] - EventThread shut down [junit] 2013-11-14 09:10:25,227 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-11-14 09:10:25,228 [myid:] - INFO [main:ZooKeeperServer@441] - shutting down [junit] 2013-11-14 09:10:25,228 [m
[jira] [Commented] (ZOOKEEPER-1808) Add version to FLE notifications for 3.4 branch
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822269#comment-13822269 ] Flavio Junqueira commented on ZOOKEEPER-1808: - [~rgs], can I get another +1 here, please? > Add version to FLE notifications for 3.4 branch > --- > > Key: ZOOKEEPER-1808 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1808 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, > ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, > ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch, ZOOKEEPER-1808.patch > > > Add version to notification messages so that we can differentiate messages > during rolling upgrades. This task is for the 3.4 branch only. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1519) Zookeeper Async calls can reference free()'d memory
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822272#comment-13822272 ] Flavio Junqueira commented on ZOOKEEPER-1519: - [~markgius], would you be able to propose a patch for the documentation? > Zookeeper Async calls can reference free()'d memory > --- > > Key: ZOOKEEPER-1519 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1519 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.3.3, 3.3.6 > Environment: Ubuntu 11.10, Ubuntu packaged Zookeeper 3.3.3 with some > backported fixes. >Reporter: Mark Gius >Assignee: Daniel Lescohier > Fix For: 3.4.6, 3.5.0 > > Attachments: zookeeper-1519.patch > > > zoo_acreate() and zoo_aset() take a char * argument for data and prepare a > call to zookeeper. This char * doesn't seem to be duplicated at any point, > making it possible that the caller of the asynchronous function might > potentially free() the char * argument before the zookeeper library completes > its request. This is unlikely to present a real problem unless the freed > memory is re-used before zookeeper consumes it. I've been unable to > reproduce this issue using pure C as a result. > However, ZKPython is a whole different story. Consider this snippet: > ok = zookeeper.acreate(handle, path, json.dumps(value), > acl, flags, callback) > assert ok == zookeeper.OK > In this snippet, json.dumps() allocates a string which is passed into the > acreate(). When acreate() returns, the zookeeper request has been > constructed with a pointer to the string allocated by json.dumps(). Also > when acreate() returns, that string is now referenced by 0 things (ZKPython > doesn't bump the refcount) and the string is eligible for garbage collection > and re-use. The Zookeeper request now has a pointer to dangerous freed > memory. > I've been seeing odd behavior in our development environments for some time > now, where it appeared as though two separate JSON payloads had been joined > together. Python has been allocating a new JSON string in the middle of the > old string that an incomplete zookeeper async call had not yet processed. > I am not sure if this is a behavior that should be documented, or if the C > binding implementation needs to be updated to create copies of the data > payload provided for aset and acreate. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (BOOKKEEPER-708) Shade protobuf library to avoid incompatible versions
[ https://issues.apache.org/jira/browse/BOOKKEEPER-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822278#comment-13822278 ] Steve Loughran commented on BOOKKEEPER-708: --- I you can provide a patch to update HDFS and link it to HADOOP-9991 I'll give it a look. Shading hides a problem that can still surface later -and we don't have an particular reason to stick to guava 11.0.2 that I'm aware of > Shade protobuf library to avoid incompatible versions > - > > Key: BOOKKEEPER-708 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-708 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-server >Reporter: Sijie Guo >Assignee: Ivan Kelly > Fix For: 4.3.0, 4.2.3 > > Attachments: 0001-BOOKKEEPER-708.patch > > > as offline discussion, we need to shade protobuf library for BKJM as hadoop > uses protobuf 2.5. > this is planned on version 4.2.3 and 4.3.0. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1786) ZooKeeper data model documentation is incorrect
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822279#comment-13822279
]
Flavio Junqueira commented on ZOOKEEPER-1786:
-
Thanks, Niraj. A couple of things:
# Please name the patch file "ZOOKEEPER-1786.patch".
# Please base it on the project root, not on trunk. The source file paths
should start with src/
# I think that with your patch we are covering:
{noformat}
c >= '\ud800' && c <= '\uf8ff'
|| c >= '\ufff0' && c <= '\u'
{noformat}
but not:
{noformat}
c > '\u' && c <= '\u001f'
|| c >= '\u007f' && c <= '\u009F'
{noformat}
Don't we need to cover those too? Am I missing anything?
> ZooKeeper data model documentation is incorrect
> ---
>
> Key: ZOOKEEPER-1786
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1786
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.4.6
>Reporter: Niraj Tolia
>Priority: Minor
> Fix For: 3.4.6, 3.5.0
>
> Attachments: data_model.patch
>
>
> When I look at
> https://zookeeper.apache.org/doc/trunk/zookeeperProgrammers.html#ch_zkDataModel,
> I see two things that seem wrong in terms of restricted characters:
> * \uXFFFE - \uX (where X is a digit 1 - E)
> * \uF - \uF
> These definitions are invalid characters in Java and aren't reflected in
> PathUtils either (or PathUtilsTest). In fact the code in PathUtils states:
> {code:borderStyle=solid}
> } else if (c > '\u' && c <= '\u001f'
> || c >= '\u007f' && c <= '\u009F'
> || c >= '\ud800' && c <= '\uf8ff'
> || c >= '\ufff0' && c <= '\u') {
> reason = "invalid charater @" + i;
> break;
> }
> {code}
> Unless I am missing something, this simple patch should fix the documentation
> problem:
> {code}
> Index: src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> ===
> --- src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> (revision 1530514)
> +++ src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> (working copy)
> @@ -139,8 +139,7 @@
>
> The following characters are not allowed: \ud800 - uF8FF,
> -\uFFF0 - u, \uXFFFE - \uX (where X is a digit 1 - E),
> \uF -
> -\uF.
> +\uFFF0 - u.
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
ZooKeeper-trunk-solaris - Build # 730 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/730/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 211091 lines...] [junit] 2013-11-14 09:44:08,014 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@219] - accept thread exitted run method [junit] 2013-11-14 09:44:08,015 [myid:] - INFO [main:ZooKeeperServer@428] - shutting down [junit] 2013-11-14 09:44:08,016 [myid:] - INFO [main:SessionTrackerImpl@183] - Shutting down [junit] 2013-11-14 09:44:08,016 [myid:] - INFO [main:PrepRequestProcessor@972] - Shutting down [junit] 2013-11-14 09:44:08,016 [myid:] - INFO [main:SyncRequestProcessor@190] - Shutting down [junit] 2013-11-14 09:44:08,016 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop! [junit] 2013-11-14 09:44:08,016 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@168] - SyncRequestProcessor exited! [junit] 2013-11-14 09:44:08,016 [myid:] - INFO [main:FinalRequestProcessor@442] - shutdown of request processor complete [junit] 2013-11-14 09:44:08,017 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-14 09:44:08,017 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[] [junit] 2013-11-14 09:44:08,018 [myid:] - INFO [main:ClientBase@414] - STARTING server [junit] 2013-11-14 09:44:08,019 [myid:] - INFO [main:ZooKeeperServer@149] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test1245239108740563353.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test1245239108740563353.junit.dir/version-2 [junit] 2013-11-14 09:44:08,020 [myid:] - INFO [main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 kB direct buffers. [junit] 2013-11-14 09:44:08,020 [myid:] - INFO [main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-11-14 09:44:08,021 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test1245239108740563353.junit.dir/version-2/snapshot.b [junit] 2013-11-14 09:44:08,024 [myid:] - INFO [main:FileTxnSnapLog@297] - Snapshotting: 0xb to /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test1245239108740563353.junit.dir/version-2/snapshot.b [junit] 2013-11-14 09:44:08,025 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-14 09:44:08,026 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:61720 [junit] 2013-11-14 09:44:08,026 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@828] - Processing stat command from /127.0.0.1:61720 [junit] 2013-11-14 09:44:08,027 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn$StatCommand@677] - Stat command output [junit] 2013-11-14 09:44:08,027 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@999] - Closed socket connection for client /127.0.0.1:61720 (no session established for client) [junit] 2013-11-14 09:44:08,027 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-11-14 09:44:08,029 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-11-14 09:44:08,029 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-11-14 09:44:08,029 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-11-14 09:44:08,029 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-14 09:44:08,030 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota [junit] 2013-11-14 09:44:08,030 [myid:] - INFO [main:ClientBase@451] - tearDown starting [junit] 2013-11-14 09:44:08,104 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down [junit] 2013-11-14 09:44:08,104 [myid:] - INFO [main:ZooKeeper@777] - Session: 0x14255ff0bec closed [junit] 2013-11-14 09:44:08,104 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-11-14 09:44:08,105 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServe
[jira] [Commented] (ZOOKEEPER-1798) Fix race condition in testNormalObserverRun
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822332#comment-13822332 ] Hudson commented on ZOOKEEPER-1798: --- SUCCESS: Integrated in ZooKeeper-trunk #2119 (See [https://builds.apache.org/job/ZooKeeper-trunk/2119/]) ZOOKEEPER-1798. Fix race condition in testNormalObserverRun (Part 2) (thawan, fpj via thawan) (thawan: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541810) * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java > Fix race condition in testNormalObserverRun > --- > > Key: ZOOKEEPER-1798 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1798 > Project: ZooKeeper > Issue Type: Bug >Reporter: Flavio Junqueira >Assignee: Thawan Kooburat >Priority: Blocker > Fix For: 3.4.6, 3.5.0 > > Attachments: TEST-org.apache.zookeeper.server.quorum.Zab1_0Test.txt, > ZOOKEEPER-1798-2.patch, ZOOKEEPER-1798-b3.4.patch, ZOOKEEPER-1798-b3.4.patch, > ZOOKEEPER-1798-b3.4.patch, ZOOKEEPER-1798.patch, ZOOKEEPER-1798.patch > > > This is the output messges: > > Testcase: testNormalObserverRun took 4.221 sec > FAILED > expected: but was: > junit.framework.AssertionFailedError: expected: but was: > at > org.apache.zookeeper.server.quorum.Zab1_0Test$8.converseWithObserver(Zab1_0Test.java:1118) > at > org.apache.zookeeper.server.quorum.Zab1_0Test.testObserverConversation(Zab1_0Test.java:546) > at > org.apache.zookeeper.server.quorum.Zab1_0Test.testNormalObserverRun(Zab1_0Test.java:994) > -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1549) Data inconsistency when follower is receiving a DIFF with a dirty snapshot
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822521#comment-13822521 ] Liping commented on ZOOKEEPER-1549: --- Hi Flavio Thanks for your quick response. But I do not understand. The ZK-1558 looks only avoid adding the uncommitted txnlog to snapshot file during leader startup. For ZK-1653, if the leaner crashed b/w takeSnapshot() and setCurrentEpoch() after receiving NEALEADER or UPTODATE qp, the leaner restart seems would still get the 'java.io.IOException: The current epoch, x, is older than the last zxid x' exception. Right? Could you please help to elaborate what I missed? Thanks a lot! Liping > Data inconsistency when follower is receiving a DIFF with a dirty snapshot > -- > > Key: ZOOKEEPER-1549 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1549 > Project: ZooKeeper > Issue Type: Bug > Components: quorum >Affects Versions: 3.4.3 >Reporter: Jacky007 >Assignee: Thawan Kooburat >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1549-3.4.patch, ZOOKEEPER-1549-learner.patch, > case.patch > > > the trunc code (from ZOOKEEPER-1154?) cannot work correct if the snapshot is > not correct. > here is scenario(similar to 1154): > Initial Condition > 1.Lets say there are three nodes in the ensemble A,B,C with A being the > leader > 2.The current epoch is 7. > 3.For simplicity of the example, lets say zxid is a two digit number, > with epoch being the first digit. > 4.The zxid is 73 > 5.All the nodes have seen the change 73 and have persistently logged it. > Step 1 > Request with zxid 74 is issued. The leader A writes it to the log but there > is a crash of the entire ensemble and B,C never write the change 74 to their > log. > Step 2 > A,B restart, A is elected as the new leader, and A will load data and take a > clean snapshot(change 74 is in it), then send diff to B, but B died before > sync with A. A died later. > Step 3 > B,C restart, A is still down > B,C form the quorum > B is the new leader. Lets say B minCommitLog is 71 and maxCommitLog is 73 > epoch is now 8, zxid is 80 > Request with zxid 81 is successful. On B, minCommitLog is now 71, > maxCommitLog is 81 > Step 4 > A starts up. It applies the change in request with zxid 74 to its in-memory > data tree > A contacts B to registerAsFollower and provides 74 as its ZxId > Since 71<=74<=81, B decides to send A the diff. > Problem: > The problem with the above sequence is that after truncate the log, A will > load the snapshot again which is not correct. > In 3.3 branch, FileTxnSnapLog.restore does not call listener(ZOOKEEPER-874), > the leader will send a snapshot to follower, it will not be a problem. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1810) Add version to FLE notifications for trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Germán Blanco updated ZOOKEEPER-1810: - Attachment: ZOOKEEPER-1810.patch patch following the suggestions in the thread. > Add version to FLE notifications for trunk > -- > > Key: ZOOKEEPER-1810 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1810 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Germán Blanco > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1810.patch > > > The same as ZOOKEEPER-1808 but for trunk. -- This message was sent by Atlassian JIRA (v6.1#6144)
Failed: ZOOKEEPER-1810 PreCommit Build #1765
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1810 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1765/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 537 lines...] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12613859/ZOOKEEPER-1810.patch [exec] against trunk revision 1541810. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 9 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] -1 javac. The patch appears to cause tar ant target to fail. [exec] [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1765//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1765//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1765//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 6ba950be0e11e5617198993483faa39ccf296792 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623: exec returned: 3 Total time: 2 minutes 51 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1810 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-1810) Add version to FLE notifications for trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822538#comment-13822538 ] Hadoop QA commented on ZOOKEEPER-1810: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12613859/ZOOKEEPER-1810.patch against trunk revision 1541810. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1765//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1765//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1765//console This message is automatically generated. > Add version to FLE notifications for trunk > -- > > Key: ZOOKEEPER-1810 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1810 > Project: ZooKeeper > Issue Type: Sub-task >Affects Versions: 3.5.0 >Reporter: Flavio Junqueira >Assignee: Germán Blanco > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1810.patch > > > The same as ZOOKEEPER-1808 but for trunk. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1810) Add version to FLE notifications for trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Germán Blanco updated ZOOKEEPER-1810: - Attachment: ZOOKEEPER-1810.patch The previous patch was missing some files. > Add version to FLE notifications for trunk > -- > > Key: ZOOKEEPER-1810 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1810 > Project: ZooKeeper > Issue Type: Sub-task >Affects Versions: 3.5.0 >Reporter: Flavio Junqueira >Assignee: Germán Blanco > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1810.patch, ZOOKEEPER-1810.patch > > > The same as ZOOKEEPER-1808 but for trunk. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1742) "make check" doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Germán Blanco updated ZOOKEEPER-1742: - Attachment: ZOOKEEPER-1742.patch This seems to work in Ubuntu and for me ZCONNECTIONLOSS and no messages sent sounds even nicer than the previous values in testCloseUnconnected1. Can anybody please tell why the values were ZOK and 1? > "make check" doesn't work on macos > -- > > Key: ZOOKEEPER-1742 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 > Project: ZooKeeper > Issue Type: Bug >Reporter: Flavio Junqueira >Assignee: Benjamin Reed > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, > ZOOKEEPER-1742.patch > > > There are two problems I have spotted when running "make check" with the C > client. First, it complains that the sleep call is not defined in two test > files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. > Including unistd.h works. The second problem is with linker options. It > complains that "--wrap" is not a valid. I'm not sure how to deal with this > one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1810) Add version to FLE notifications for trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822628#comment-13822628 ] Hadoop QA commented on ZOOKEEPER-1810: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12613868/ZOOKEEPER-1810.patch against trunk revision 1541810. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 21 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1767//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1767//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1767//console This message is automatically generated. > Add version to FLE notifications for trunk > -- > > Key: ZOOKEEPER-1810 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1810 > Project: ZooKeeper > Issue Type: Sub-task >Affects Versions: 3.5.0 >Reporter: Flavio Junqueira >Assignee: Germán Blanco > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1810.patch, ZOOKEEPER-1810.patch > > > The same as ZOOKEEPER-1808 but for trunk. -- This message was sent by Atlassian JIRA (v6.1#6144)
Success: ZOOKEEPER-1742 PreCommit Build #1766
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1766/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 290659 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12613870/ZOOKEEPER-1742.patch [exec] against trunk revision 1541810. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 24 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1766//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1766//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1766//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 9f81395ac4656cce043c18813bee313952595545 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 33 minutes 50 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-1742 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
Failed: ZOOKEEPER-1810 PreCommit Build #1767
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1810 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1767/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 269393 lines...] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12613868/ZOOKEEPER-1810.patch [exec] against trunk revision 1541810. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 21 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1767//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1767//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1767//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 60af89904b392a7e442a4b94fe30846f53abb6de logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623: exec returned: 2 Total time: 28 minutes 48 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Publish JUnit test result report is waiting for a checkpoint on PreCommit-ZOOKEEPER-Build #1766 Description set: ZOOKEEPER-1810 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 2 tests failed. FAILED: .org.apache.zookeeper.test.FLEBackwardElectionRoundTest Error Message: org.apache.zookeeper.test.FLEBackwardElectionRoundTest Stack Trace: java.lang.ClassNotFoundException: org.apache.zookeeper.test.FLEBackwardElectionRoundTest at java.net.URLClassLoader$1.run(URLClassLoader.java:202) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:190) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301) at java.lang.ClassLoader.loadClass(ClassLoader.java:247) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:169) FAILED: .org.apache.zookeeper.test.FLELostMessageTest Error Message: org.apache.zookeeper.test.FLELostMessageTest Stack Trace: java.lang.ClassNotFoundException: org.apache.zookeeper.test.FLELostMessageTest at java.net.URLClassLoader$1.run(URLClassLoader.java:202) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:190) at java.lang.ClassLoader.loadClass(ClassLoader.java:306) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301) at java.lang.ClassLoader.loadClass(ClassLoader.java:247) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:169)
[jira] [Commented] (ZOOKEEPER-1742) "make check" doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822633#comment-13822633 ] Hadoop QA commented on ZOOKEEPER-1742: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12613870/ZOOKEEPER-1742.patch against trunk revision 1541810. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 24 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1766//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1766//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1766//console This message is automatically generated. > "make check" doesn't work on macos > -- > > Key: ZOOKEEPER-1742 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.4.5, 3.5.0 >Reporter: Flavio Junqueira >Assignee: Benjamin Reed > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, > ZOOKEEPER-1742.patch > > > There are two problems I have spotted when running "make check" with the C > client. First, it complains that the sleep call is not defined in two test > files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. > Including unistd.h works. The second problem is with linker options. It > complains that "--wrap" is not a valid. I'm not sure how to deal with this > one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1786) ZooKeeper data model documentation is incorrect
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niraj Tolia updated ZOOKEEPER-1786:
---
Attachment: ZOOKEEPER-1786.patch
> ZooKeeper data model documentation is incorrect
> ---
>
> Key: ZOOKEEPER-1786
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1786
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.4.6
>Reporter: Niraj Tolia
>Priority: Minor
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1786.patch
>
>
> When I look at
> https://zookeeper.apache.org/doc/trunk/zookeeperProgrammers.html#ch_zkDataModel,
> I see two things that seem wrong in terms of restricted characters:
> * \uXFFFE - \uX (where X is a digit 1 - E)
> * \uF - \uF
> These definitions are invalid characters in Java and aren't reflected in
> PathUtils either (or PathUtilsTest). In fact the code in PathUtils states:
> {code:borderStyle=solid}
> } else if (c > '\u' && c <= '\u001f'
> || c >= '\u007f' && c <= '\u009F'
> || c >= '\ud800' && c <= '\uf8ff'
> || c >= '\ufff0' && c <= '\u') {
> reason = "invalid charater @" + i;
> break;
> }
> {code}
> Unless I am missing something, this simple patch should fix the documentation
> problem:
> {code}
> Index: src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> ===
> --- src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> (revision 1530514)
> +++ src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> (working copy)
> @@ -139,8 +139,7 @@
>
> The following characters are not allowed: \ud800 - uF8FF,
> -\uFFF0 - u, \uXFFFE - \uX (where X is a digit 1 - E),
> \uF -
> -\uF.
> +\uFFF0 - u.
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1786) ZooKeeper data model documentation is incorrect
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niraj Tolia updated ZOOKEEPER-1786:
---
Attachment: (was: data_model.patch)
> ZooKeeper data model documentation is incorrect
> ---
>
> Key: ZOOKEEPER-1786
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1786
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.4.6
>Reporter: Niraj Tolia
>Priority: Minor
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1786.patch
>
>
> When I look at
> https://zookeeper.apache.org/doc/trunk/zookeeperProgrammers.html#ch_zkDataModel,
> I see two things that seem wrong in terms of restricted characters:
> * \uXFFFE - \uX (where X is a digit 1 - E)
> * \uF - \uF
> These definitions are invalid characters in Java and aren't reflected in
> PathUtils either (or PathUtilsTest). In fact the code in PathUtils states:
> {code:borderStyle=solid}
> } else if (c > '\u' && c <= '\u001f'
> || c >= '\u007f' && c <= '\u009F'
> || c >= '\ud800' && c <= '\uf8ff'
> || c >= '\ufff0' && c <= '\u') {
> reason = "invalid charater @" + i;
> break;
> }
> {code}
> Unless I am missing something, this simple patch should fix the documentation
> problem:
> {code}
> Index: src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> ===
> --- src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> (revision 1530514)
> +++ src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> (working copy)
> @@ -139,8 +139,7 @@
>
> The following characters are not allowed: \ud800 - uF8FF,
> -\uFFF0 - u, \uXFFFE - \uX (where X is a digit 1 - E),
> \uF -
> -\uF.
> +\uFFF0 - u.
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1786) ZooKeeper data model documentation is incorrect
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822675#comment-13822675
]
Niraj Tolia commented on ZOOKEEPER-1786:
{quote}
Please name the patch file "ZOOKEEPER-1786.patch".
{quote}
Will do.
{quote}
Please base it on the project root, not on trunk. The source file paths should
start with src/
{quote}
Assuming you meant the inverse but yes, sure.
{quote}
I think that with your patch we are covering:
...
{quote}
The other exceptions you mentioned are already covered in the documentation but
just don't show up in the diff. Please see
https://zookeeper.apache.org/doc/trunk/zookeeperProgrammers.html#ch_zkDataModel
for the exceptions you referred to.
> ZooKeeper data model documentation is incorrect
> ---
>
> Key: ZOOKEEPER-1786
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1786
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.4.6
>Reporter: Niraj Tolia
>Priority: Minor
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1786.patch
>
>
> When I look at
> https://zookeeper.apache.org/doc/trunk/zookeeperProgrammers.html#ch_zkDataModel,
> I see two things that seem wrong in terms of restricted characters:
> * \uXFFFE - \uX (where X is a digit 1 - E)
> * \uF - \uF
> These definitions are invalid characters in Java and aren't reflected in
> PathUtils either (or PathUtilsTest). In fact the code in PathUtils states:
> {code:borderStyle=solid}
> } else if (c > '\u' && c <= '\u001f'
> || c >= '\u007f' && c <= '\u009F'
> || c >= '\ud800' && c <= '\uf8ff'
> || c >= '\ufff0' && c <= '\u') {
> reason = "invalid charater @" + i;
> break;
> }
> {code}
> Unless I am missing something, this simple patch should fix the documentation
> problem:
> {code}
> Index: src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> ===
> --- src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> (revision 1530514)
> +++ src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> (working copy)
> @@ -139,8 +139,7 @@
>
> The following characters are not allowed: \ud800 - uF8FF,
> -\uFFF0 - u, \uXFFFE - \uX (where X is a digit 1 - E),
> \uF -
> -\uF.
> +\uFFF0 - u.
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1786) ZooKeeper data model documentation is incorrect
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822685#comment-13822685
]
Flavio Junqueira commented on ZOOKEEPER-1786:
-
bq. Assuming you meant the inverse but yes, sure.
We are probably not using the same terminology here. For me, if the project
root is "/", then "/src" is the source folder. I think you got it, but if you
didn't, either ask or check other patches in different jiras.
bq. The other exceptions you mentioned are already covered in the documentation
but just don't show up in the diff.
Ok, thanks.
> ZooKeeper data model documentation is incorrect
> ---
>
> Key: ZOOKEEPER-1786
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1786
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.4.6
>Reporter: Niraj Tolia
>Priority: Minor
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1786.patch
>
>
> When I look at
> https://zookeeper.apache.org/doc/trunk/zookeeperProgrammers.html#ch_zkDataModel,
> I see two things that seem wrong in terms of restricted characters:
> * \uXFFFE - \uX (where X is a digit 1 - E)
> * \uF - \uF
> These definitions are invalid characters in Java and aren't reflected in
> PathUtils either (or PathUtilsTest). In fact the code in PathUtils states:
> {code:borderStyle=solid}
> } else if (c > '\u' && c <= '\u001f'
> || c >= '\u007f' && c <= '\u009F'
> || c >= '\ud800' && c <= '\uf8ff'
> || c >= '\ufff0' && c <= '\u') {
> reason = "invalid charater @" + i;
> break;
> }
> {code}
> Unless I am missing something, this simple patch should fix the documentation
> problem:
> {code}
> Index: src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> ===
> --- src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> (revision 1530514)
> +++ src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> (working copy)
> @@ -139,8 +139,7 @@
>
> The following characters are not allowed: \ud800 - uF8FF,
> -\uFFF0 - u, \uXFFFE - \uX (where X is a digit 1 - E),
> \uF -
> -\uF.
> +\uFFF0 - u.
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1810) Add version to FLE notifications for trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822784#comment-13822784 ] Germán Blanco commented on ZOOKEEPER-1810: -- This is strange. There is a new findbugs warning about the constructor of class Messenger in FastLeaderElection, but there were no changes in that constructor. And I think the core tests complains about the tests that have been moved from package org.apache.zookeeper.test to org.apache.zookeeper.server.quorum. > Add version to FLE notifications for trunk > -- > > Key: ZOOKEEPER-1810 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1810 > Project: ZooKeeper > Issue Type: Sub-task >Affects Versions: 3.5.0 >Reporter: Flavio Junqueira >Assignee: Germán Blanco > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1810.patch, ZOOKEEPER-1810.patch > > > The same as ZOOKEEPER-1808 but for trunk. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1810) Add version to FLE notifications for trunk
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822797#comment-13822797
]
Raul Gutierrez Segales commented on ZOOKEEPER-1810:
---
I think that:
{noformat}
+if(LOG.isInfoEnabled()){
+LOG.info("Backward compatibility mode (36
bits), server id: " + response.sid);
+}
{noformat}
can do without the LOG.isInfoEnabled since it's already called by LOG.info and
response.sid isn't computed (just a value accessed, so no savings).
> Add version to FLE notifications for trunk
> --
>
> Key: ZOOKEEPER-1810
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1810
> Project: ZooKeeper
> Issue Type: Sub-task
>Affects Versions: 3.5.0
>Reporter: Flavio Junqueira
>Assignee: Germán Blanco
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1810.patch, ZOOKEEPER-1810.patch
>
>
> The same as ZOOKEEPER-1808 but for trunk.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1810) Add version to FLE notifications for trunk
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822806#comment-13822806
]
Raul Gutierrez Segales commented on ZOOKEEPER-1810:
---
Extra newline in:
{noformat}
+public class FLELostMessageTest extends ZKTestCase {
+protected static final Logger LOG =
LoggerFactory.getLogger(FLELostMessageTest.class);
+
+
+int count;
{noformat}
Super nit in
src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java:
{noformat}
+cnxManagers[0].toSend(0l,
FLETestUtils.createMsg(ServerState.FOLLOWING.ordinal(), 0, 0, 1));
{noformat}
if the same Msg is created again and again, can't we just create it once and
reuse?
In :
{noformat}
+if (LOG.isDebugEnabled()) {
+LOG.debug("Receive new notification message.
My id = "
++ self.getId());
+}
{noformat}
no need for LOG.isDebugEnabled.
> Add version to FLE notifications for trunk
> --
>
> Key: ZOOKEEPER-1810
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1810
> Project: ZooKeeper
> Issue Type: Sub-task
>Affects Versions: 3.5.0
>Reporter: Flavio Junqueira
>Assignee: Germán Blanco
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1810.patch, ZOOKEEPER-1810.patch
>
>
> The same as ZOOKEEPER-1808 but for trunk.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1786) ZooKeeper data model documentation is incorrect
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822916#comment-13822916
]
Flavio Junqueira commented on ZOOKEEPER-1786:
-
+1, thanks, [~ntolia].
> ZooKeeper data model documentation is incorrect
> ---
>
> Key: ZOOKEEPER-1786
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1786
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.4.6
>Reporter: Niraj Tolia
>Priority: Minor
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1786.patch
>
>
> When I look at
> https://zookeeper.apache.org/doc/trunk/zookeeperProgrammers.html#ch_zkDataModel,
> I see two things that seem wrong in terms of restricted characters:
> * \uXFFFE - \uX (where X is a digit 1 - E)
> * \uF - \uF
> These definitions are invalid characters in Java and aren't reflected in
> PathUtils either (or PathUtilsTest). In fact the code in PathUtils states:
> {code:borderStyle=solid}
> } else if (c > '\u' && c <= '\u001f'
> || c >= '\u007f' && c <= '\u009F'
> || c >= '\ud800' && c <= '\uf8ff'
> || c >= '\ufff0' && c <= '\u') {
> reason = "invalid charater @" + i;
> break;
> }
> {code}
> Unless I am missing something, this simple patch should fix the documentation
> problem:
> {code}
> Index: src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> ===
> --- src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> (revision 1530514)
> +++ src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
> (working copy)
> @@ -139,8 +139,7 @@
>
> The following characters are not allowed: \ud800 - uF8FF,
> -\uFFF0 - u, \uXFFFE - \uX (where X is a digit 1 - E),
> \uF -
> -\uF.
> +\uFFF0 - u.
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1549) Data inconsistency when follower is receiving a DIFF with a dirty snapshot
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822931#comment-13822931 ] Flavio Junqueira commented on ZOOKEEPER-1549: - Here is my train of thought. I marked ZOOKEEPER-1653 as a duplicate because in my understanding the changes proposed here solve the problem described there. ZOOKEEPER-1558 solves the problem originally reported in this issue, but it does not solve all corner cases. We have left it for 3.5.0 for the reasons [~thawan] raised here previously. Since we are discussing in ZOOKEEPER-1549, I'm referring to the issue reported and discussed here. If you feel that ZOOKEEPER-1653 should be addressed and should be a blocker for 3.4.6, then we should discuss it there. But, please keep in mind that if we make it a blocker, it will delay the release even further. > Data inconsistency when follower is receiving a DIFF with a dirty snapshot > -- > > Key: ZOOKEEPER-1549 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1549 > Project: ZooKeeper > Issue Type: Bug > Components: quorum >Affects Versions: 3.4.3 >Reporter: Jacky007 >Assignee: Thawan Kooburat >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1549-3.4.patch, ZOOKEEPER-1549-learner.patch, > case.patch > > > the trunc code (from ZOOKEEPER-1154?) cannot work correct if the snapshot is > not correct. > here is scenario(similar to 1154): > Initial Condition > 1.Lets say there are three nodes in the ensemble A,B,C with A being the > leader > 2.The current epoch is 7. > 3.For simplicity of the example, lets say zxid is a two digit number, > with epoch being the first digit. > 4.The zxid is 73 > 5.All the nodes have seen the change 73 and have persistently logged it. > Step 1 > Request with zxid 74 is issued. The leader A writes it to the log but there > is a crash of the entire ensemble and B,C never write the change 74 to their > log. > Step 2 > A,B restart, A is elected as the new leader, and A will load data and take a > clean snapshot(change 74 is in it), then send diff to B, but B died before > sync with A. A died later. > Step 3 > B,C restart, A is still down > B,C form the quorum > B is the new leader. Lets say B minCommitLog is 71 and maxCommitLog is 73 > epoch is now 8, zxid is 80 > Request with zxid 81 is successful. On B, minCommitLog is now 71, > maxCommitLog is 81 > Step 4 > A starts up. It applies the change in request with zxid 74 to its in-memory > data tree > A contacts B to registerAsFollower and provides 74 as its ZxId > Since 71<=74<=81, B decides to send A the diff. > Problem: > The problem with the above sequence is that after truncate the log, A will > load the snapshot again which is not correct. > In 3.3 branch, FileTxnSnapLog.restore does not call listener(ZOOKEEPER-874), > the leader will send a snapshot to follower, it will not be a problem. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Reopened] (ZOOKEEPER-1653) zookeeper fails to start because of inconsistent epoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flavio Junqueira reopened ZOOKEEPER-1653:
-
Should this jira be a blocker for 3.4.6? [~michim]?
> zookeeper fails to start because of inconsistent epoch
> --
>
> Key: ZOOKEEPER-1653
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1653
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
>Affects Versions: 3.4.5, 3.5.0
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1653.patch, ZOOKEEPER-1653.patch
>
>
> It looks like QuorumPeer.loadDataBase() could fail if the server was
> restarted after zk.takeSnapshot() but before finishing
> self.setCurrentEpoch(newEpoch) in Learner.java.
> {code:java}
> case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
> zk.takeSnapshot();
> self.setCurrentEpoch(newEpoch); // <<< got restarted here
> snapshotTaken = true;
> writePacket(new QuorumPacket(Leader.ACK, newLeaderZxid, null, null),
> true);
> break;
> {code}
> The server fails to start because currentEpoch is still 1 but the last
> processed zkid from the snapshot has been updated.
> {noformat}
> 2013-02-20 13:45:02,733 5543 [pool-1-thread-1] ERROR
> org.apache.zookeeper.server.quorum.QuorumPeer - Unable to load database on
> disk
> java.io.IOException: The current epoch, 1, is older than the last zxid,
> 8589934592
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:439)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:413)
> ...
> {noformat}
> {noformat}
> $ find datadir
> datadir
> datadir/version-2
> datadir/version-2/currentEpoch.tmp
> datadir/version-2/acceptedEpoch
> datadir/version-2/snapshot.0
> datadir/version-2/currentEpoch
> datadir/version-2/snapshot.2
> $ cat datadir/version-2/currentEpoch.tmp
> 2%
> $ cat datadir/version-2/acceptedEpoch
> 2%
> $ cat datadir/version-2/currentEpoch
> 1%
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1653) zookeeper fails to start because of inconsistent epoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822971#comment-13822971
]
Michi Mutsuzaki commented on ZOOKEEPER-1653:
Yeah if ZOOKEEPER-1549 is not fixed in 3.4.6, we should fix this in 3.4.6. I'll
rebase and resubmit the patch.
> zookeeper fails to start because of inconsistent epoch
> --
>
> Key: ZOOKEEPER-1653
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1653
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
>Affects Versions: 3.4.5, 3.5.0
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1653.patch, ZOOKEEPER-1653.patch
>
>
> It looks like QuorumPeer.loadDataBase() could fail if the server was
> restarted after zk.takeSnapshot() but before finishing
> self.setCurrentEpoch(newEpoch) in Learner.java.
> {code:java}
> case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
> zk.takeSnapshot();
> self.setCurrentEpoch(newEpoch); // <<< got restarted here
> snapshotTaken = true;
> writePacket(new QuorumPacket(Leader.ACK, newLeaderZxid, null, null),
> true);
> break;
> {code}
> The server fails to start because currentEpoch is still 1 but the last
> processed zkid from the snapshot has been updated.
> {noformat}
> 2013-02-20 13:45:02,733 5543 [pool-1-thread-1] ERROR
> org.apache.zookeeper.server.quorum.QuorumPeer - Unable to load database on
> disk
> java.io.IOException: The current epoch, 1, is older than the last zxid,
> 8589934592
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:439)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:413)
> ...
> {noformat}
> {noformat}
> $ find datadir
> datadir
> datadir/version-2
> datadir/version-2/currentEpoch.tmp
> datadir/version-2/acceptedEpoch
> datadir/version-2/snapshot.0
> datadir/version-2/currentEpoch
> datadir/version-2/snapshot.2
> $ cat datadir/version-2/currentEpoch.tmp
> 2%
> $ cat datadir/version-2/acceptedEpoch
> 2%
> $ cat datadir/version-2/currentEpoch
> 1%
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1549) Data inconsistency when follower is receiving a DIFF with a dirty snapshot
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823018#comment-13823018 ] Liping commented on ZOOKEEPER-1549: --- Thanks for the clarification, Flavio Yeah, I would follow ZK-1653 for the related discussion if necessary. Michi just re-opened it for a 3.4.6 patch. Thanks for all of your help! > Data inconsistency when follower is receiving a DIFF with a dirty snapshot > -- > > Key: ZOOKEEPER-1549 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1549 > Project: ZooKeeper > Issue Type: Bug > Components: quorum >Affects Versions: 3.4.3 >Reporter: Jacky007 >Assignee: Thawan Kooburat >Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1549-3.4.patch, ZOOKEEPER-1549-learner.patch, > case.patch > > > the trunc code (from ZOOKEEPER-1154?) cannot work correct if the snapshot is > not correct. > here is scenario(similar to 1154): > Initial Condition > 1.Lets say there are three nodes in the ensemble A,B,C with A being the > leader > 2.The current epoch is 7. > 3.For simplicity of the example, lets say zxid is a two digit number, > with epoch being the first digit. > 4.The zxid is 73 > 5.All the nodes have seen the change 73 and have persistently logged it. > Step 1 > Request with zxid 74 is issued. The leader A writes it to the log but there > is a crash of the entire ensemble and B,C never write the change 74 to their > log. > Step 2 > A,B restart, A is elected as the new leader, and A will load data and take a > clean snapshot(change 74 is in it), then send diff to B, but B died before > sync with A. A died later. > Step 3 > B,C restart, A is still down > B,C form the quorum > B is the new leader. Lets say B minCommitLog is 71 and maxCommitLog is 73 > epoch is now 8, zxid is 80 > Request with zxid 81 is successful. On B, minCommitLog is now 71, > maxCommitLog is 81 > Step 4 > A starts up. It applies the change in request with zxid 74 to its in-memory > data tree > A contacts B to registerAsFollower and provides 74 as its ZxId > Since 71<=74<=81, B decides to send A the diff. > Problem: > The problem with the above sequence is that after truncate the log, A will > load the snapshot again which is not correct. > In 3.3 branch, FileTxnSnapLog.restore does not call listener(ZOOKEEPER-874), > the leader will send a snapshot to follower, it will not be a problem. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1653) zookeeper fails to start because of inconsistent epoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michi Mutsuzaki updated ZOOKEEPER-1653:
---
Attachment: ZOOKEEPER-1653.3.4.patch
This patch is for 3.4 branch.
> zookeeper fails to start because of inconsistent epoch
> --
>
> Key: ZOOKEEPER-1653
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1653
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
>Affects Versions: 3.4.5, 3.5.0
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1653.3.4.patch, ZOOKEEPER-1653.patch,
> ZOOKEEPER-1653.patch
>
>
> It looks like QuorumPeer.loadDataBase() could fail if the server was
> restarted after zk.takeSnapshot() but before finishing
> self.setCurrentEpoch(newEpoch) in Learner.java.
> {code:java}
> case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
> zk.takeSnapshot();
> self.setCurrentEpoch(newEpoch); // <<< got restarted here
> snapshotTaken = true;
> writePacket(new QuorumPacket(Leader.ACK, newLeaderZxid, null, null),
> true);
> break;
> {code}
> The server fails to start because currentEpoch is still 1 but the last
> processed zkid from the snapshot has been updated.
> {noformat}
> 2013-02-20 13:45:02,733 5543 [pool-1-thread-1] ERROR
> org.apache.zookeeper.server.quorum.QuorumPeer - Unable to load database on
> disk
> java.io.IOException: The current epoch, 1, is older than the last zxid,
> 8589934592
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:439)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:413)
> ...
> {noformat}
> {noformat}
> $ find datadir
> datadir
> datadir/version-2
> datadir/version-2/currentEpoch.tmp
> datadir/version-2/acceptedEpoch
> datadir/version-2/snapshot.0
> datadir/version-2/currentEpoch
> datadir/version-2/snapshot.2
> $ cat datadir/version-2/currentEpoch.tmp
> 2%
> $ cat datadir/version-2/acceptedEpoch
> 2%
> $ cat datadir/version-2/currentEpoch
> 1%
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1653) zookeeper fails to start because of inconsistent epoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michi Mutsuzaki updated ZOOKEEPER-1653:
---
Fix Version/s: (was: 3.5.0)
> zookeeper fails to start because of inconsistent epoch
> --
>
> Key: ZOOKEEPER-1653
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1653
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
>Affects Versions: 3.4.5
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1653.3.4.patch, ZOOKEEPER-1653.patch,
> ZOOKEEPER-1653.patch
>
>
> It looks like QuorumPeer.loadDataBase() could fail if the server was
> restarted after zk.takeSnapshot() but before finishing
> self.setCurrentEpoch(newEpoch) in Learner.java.
> {code:java}
> case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
> zk.takeSnapshot();
> self.setCurrentEpoch(newEpoch); // <<< got restarted here
> snapshotTaken = true;
> writePacket(new QuorumPacket(Leader.ACK, newLeaderZxid, null, null),
> true);
> break;
> {code}
> The server fails to start because currentEpoch is still 1 but the last
> processed zkid from the snapshot has been updated.
> {noformat}
> 2013-02-20 13:45:02,733 5543 [pool-1-thread-1] ERROR
> org.apache.zookeeper.server.quorum.QuorumPeer - Unable to load database on
> disk
> java.io.IOException: The current epoch, 1, is older than the last zxid,
> 8589934592
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:439)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:413)
> ...
> {noformat}
> {noformat}
> $ find datadir
> datadir
> datadir/version-2
> datadir/version-2/currentEpoch.tmp
> datadir/version-2/acceptedEpoch
> datadir/version-2/snapshot.0
> datadir/version-2/currentEpoch
> datadir/version-2/snapshot.2
> $ cat datadir/version-2/currentEpoch.tmp
> 2%
> $ cat datadir/version-2/acceptedEpoch
> 2%
> $ cat datadir/version-2/currentEpoch
> 1%
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1653) zookeeper fails to start because of inconsistent epoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michi Mutsuzaki updated ZOOKEEPER-1653:
---
Affects Version/s: (was: 3.5.0)
> zookeeper fails to start because of inconsistent epoch
> --
>
> Key: ZOOKEEPER-1653
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1653
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
>Affects Versions: 3.4.5
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1653.3.4.patch, ZOOKEEPER-1653.patch,
> ZOOKEEPER-1653.patch
>
>
> It looks like QuorumPeer.loadDataBase() could fail if the server was
> restarted after zk.takeSnapshot() but before finishing
> self.setCurrentEpoch(newEpoch) in Learner.java.
> {code:java}
> case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
> zk.takeSnapshot();
> self.setCurrentEpoch(newEpoch); // <<< got restarted here
> snapshotTaken = true;
> writePacket(new QuorumPacket(Leader.ACK, newLeaderZxid, null, null),
> true);
> break;
> {code}
> The server fails to start because currentEpoch is still 1 but the last
> processed zkid from the snapshot has been updated.
> {noformat}
> 2013-02-20 13:45:02,733 5543 [pool-1-thread-1] ERROR
> org.apache.zookeeper.server.quorum.QuorumPeer - Unable to load database on
> disk
> java.io.IOException: The current epoch, 1, is older than the last zxid,
> 8589934592
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:439)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:413)
> ...
> {noformat}
> {noformat}
> $ find datadir
> datadir
> datadir/version-2
> datadir/version-2/currentEpoch.tmp
> datadir/version-2/acceptedEpoch
> datadir/version-2/snapshot.0
> datadir/version-2/currentEpoch
> datadir/version-2/snapshot.2
> $ cat datadir/version-2/currentEpoch.tmp
> 2%
> $ cat datadir/version-2/acceptedEpoch
> 2%
> $ cat datadir/version-2/currentEpoch
> 1%
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1653) zookeeper fails to start because of inconsistent epoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michi Mutsuzaki updated ZOOKEEPER-1653:
---
Release Note: ZOOKEEPER-1549.patch should fix this issue in 3.5 branch.
(was: ZOOKEEPER-1549-3.4.patch should fix this issue.)
> zookeeper fails to start because of inconsistent epoch
> --
>
> Key: ZOOKEEPER-1653
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1653
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
>Affects Versions: 3.4.5
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1653.3.4.patch, ZOOKEEPER-1653.patch,
> ZOOKEEPER-1653.patch
>
>
> It looks like QuorumPeer.loadDataBase() could fail if the server was
> restarted after zk.takeSnapshot() but before finishing
> self.setCurrentEpoch(newEpoch) in Learner.java.
> {code:java}
> case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
> zk.takeSnapshot();
> self.setCurrentEpoch(newEpoch); // <<< got restarted here
> snapshotTaken = true;
> writePacket(new QuorumPacket(Leader.ACK, newLeaderZxid, null, null),
> true);
> break;
> {code}
> The server fails to start because currentEpoch is still 1 but the last
> processed zkid from the snapshot has been updated.
> {noformat}
> 2013-02-20 13:45:02,733 5543 [pool-1-thread-1] ERROR
> org.apache.zookeeper.server.quorum.QuorumPeer - Unable to load database on
> disk
> java.io.IOException: The current epoch, 1, is older than the last zxid,
> 8589934592
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:439)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:413)
> ...
> {noformat}
> {noformat}
> $ find datadir
> datadir
> datadir/version-2
> datadir/version-2/currentEpoch.tmp
> datadir/version-2/acceptedEpoch
> datadir/version-2/snapshot.0
> datadir/version-2/currentEpoch
> datadir/version-2/snapshot.2
> $ cat datadir/version-2/currentEpoch.tmp
> 2%
> $ cat datadir/version-2/acceptedEpoch
> 2%
> $ cat datadir/version-2/currentEpoch
> 1%
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
Failed: ZOOKEEPER-1653 PreCommit Build #1768
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1653 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1768/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 78 lines...] [exec] Hunk #3 FAILED at 50. [exec] Hunk #4 FAILED at 62. [exec] Hunk #5 succeeded at 677 (offset 2 lines). [exec] 2 out of 5 hunks FAILED -- saving rejects to file src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java.rej [exec] patching file src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java [exec] Hunk #1 succeeded at 24 with fuzz 2. [exec] Hunk #2 succeeded at 76 with fuzz 2 (offset 18 lines). [exec] Hunk #3 succeeded at 85 with fuzz 2 (offset 12 lines). [exec] Hunk #4 succeeded at 134 (offset 30 lines). [exec] Hunk #5 succeeded at 145 (offset 30 lines). [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12613962/ZOOKEEPER-1653.3.4.patch [exec] against trunk revision 1541810. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1768//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 6561aedfb817404d3087d37b9d2ac1329b656a9a logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623: exec returned: 1 Total time: 59 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1653 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-1653) zookeeper fails to start because of inconsistent epoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823076#comment-13823076
]
Hadoop QA commented on ZOOKEEPER-1653:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12613962/ZOOKEEPER-1653.3.4.patch
against trunk revision 1541810.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1768//console
This message is automatically generated.
> zookeeper fails to start because of inconsistent epoch
> --
>
> Key: ZOOKEEPER-1653
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1653
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
>Affects Versions: 3.4.5
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1653.3.4.patch, ZOOKEEPER-1653.patch,
> ZOOKEEPER-1653.patch
>
>
> It looks like QuorumPeer.loadDataBase() could fail if the server was
> restarted after zk.takeSnapshot() but before finishing
> self.setCurrentEpoch(newEpoch) in Learner.java.
> {code:java}
> case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
> zk.takeSnapshot();
> self.setCurrentEpoch(newEpoch); // <<< got restarted here
> snapshotTaken = true;
> writePacket(new QuorumPacket(Leader.ACK, newLeaderZxid, null, null),
> true);
> break;
> {code}
> The server fails to start because currentEpoch is still 1 but the last
> processed zkid from the snapshot has been updated.
> {noformat}
> 2013-02-20 13:45:02,733 5543 [pool-1-thread-1] ERROR
> org.apache.zookeeper.server.quorum.QuorumPeer - Unable to load database on
> disk
> java.io.IOException: The current epoch, 1, is older than the last zxid,
> 8589934592
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:439)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:413)
> ...
> {noformat}
> {noformat}
> $ find datadir
> datadir
> datadir/version-2
> datadir/version-2/currentEpoch.tmp
> datadir/version-2/acceptedEpoch
> datadir/version-2/snapshot.0
> datadir/version-2/currentEpoch
> datadir/version-2/snapshot.2
> $ cat datadir/version-2/currentEpoch.tmp
> 2%
> $ cat datadir/version-2/acceptedEpoch
> 2%
> $ cat datadir/version-2/currentEpoch
> 1%
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1810) Add version to FLE notifications for trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823276#comment-13823276 ] Germán Blanco commented on ZOOKEEPER-1810: -- Thank you for the comments [~rgs]! I will do the clean up. I don't know what you mean with the "Super nit" in: bq. Super nit in src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java: Is it that the line is too long? > Add version to FLE notifications for trunk > -- > > Key: ZOOKEEPER-1810 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1810 > Project: ZooKeeper > Issue Type: Sub-task >Affects Versions: 3.5.0 >Reporter: Flavio Junqueira >Assignee: Germán Blanco > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1810.patch, ZOOKEEPER-1810.patch > > > The same as ZOOKEEPER-1808 but for trunk. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1810) Add version to FLE notifications for trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823290#comment-13823290 ] Germán Blanco commented on ZOOKEEPER-1810: -- Ok, now I get it. I thought the next line belonged to the next comment. > Add version to FLE notifications for trunk > -- > > Key: ZOOKEEPER-1810 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1810 > Project: ZooKeeper > Issue Type: Sub-task >Affects Versions: 3.5.0 >Reporter: Flavio Junqueira >Assignee: Germán Blanco > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1810.patch, ZOOKEEPER-1810.patch > > > The same as ZOOKEEPER-1808 but for trunk. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1810) Add version to FLE notifications for trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823302#comment-13823302 ] Raul Gutierrez Segales commented on ZOOKEEPER-1810: --- Yeah - sorry that was a bit confusing. I guess - if it isn't too much of a hassle - reviewboards to make things a bit easier. > Add version to FLE notifications for trunk > -- > > Key: ZOOKEEPER-1810 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1810 > Project: ZooKeeper > Issue Type: Sub-task >Affects Versions: 3.5.0 >Reporter: Flavio Junqueira >Assignee: Germán Blanco > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1810.patch, ZOOKEEPER-1810.patch > > > The same as ZOOKEEPER-1808 but for trunk. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1810) Add version to FLE notifications for trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823303#comment-13823303 ] Raul Gutierrez Segales commented on ZOOKEEPER-1810: --- (I meant for future patches - we can keep on going with this one inside the ticket if it's easier.) > Add version to FLE notifications for trunk > -- > > Key: ZOOKEEPER-1810 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1810 > Project: ZooKeeper > Issue Type: Sub-task >Affects Versions: 3.5.0 >Reporter: Flavio Junqueira >Assignee: Germán Blanco > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1810.patch, ZOOKEEPER-1810.patch > > > The same as ZOOKEEPER-1808 but for trunk. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (ZOOKEEPER-1813) Zookeeper restart fails due to missing node from snapshot
Vinay created ZOOKEEPER-1813:
Summary: Zookeeper restart fails due to missing node from snapshot
Key: ZOOKEEPER-1813
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1813
Project: ZooKeeper
Issue Type: Bug
Affects Versions: 3.4.5, 3.5.0
Reporter: Vinay
Priority: Blocker
Due to following exception Zookeeper restart is failing
{noformat}java.io.IOException: Failed to process transaction type: 1 error:
KeeperErrorCode = NoNode for /test/subdir2/subdir2/subdir
at
org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:183)
at
org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:222)
at
org.apache.zookeeper.server.ZooKeeperServer.loadData(ZooKeeperServer.java:255)
at
org.apache.zookeeper.server.ZooKeeperServer.startdata(ZooKeeperServer.java:380)
at
org.apache.zookeeper.server.NIOServerCnxnFactory.startup(NIOServerCnxnFactory.java:748)
at
org.apache.zookeeper.server.ZooKeeperServerMain.runFromConfig(ZooKeeperServerMain.java:111)
at
org.apache.zookeeper.server.ZooKeeperServerMain.initializeAndRun(ZooKeeperServerMain.java:90)
at
org.apache.zookeeper.server.ZooKeeperServerMainTest$2.run(ZooKeeperServerMainTest.java:218)
Caused by: org.apache.zookeeper.KeeperException$NoNodeException:
KeeperErrorCode = NoNode for /test/subdir2/subdir2/subdir
at
org.apache.zookeeper.server.persistence.FileTxnSnapLog.processTransaction(FileTxnSnapLog.java:268)
at
org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:181)
... 7 more{noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1810) Add version to FLE notifications for trunk
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Germán Blanco updated ZOOKEEPER-1810:
-
Attachment: ZOOKEEPER-1810.patch
I think this covers the comments from [~rgs] and findbug warning issue.
Regarding "isDebugEnabled", my understanding is that this is required for
points in which there could be a drop in performance, but it doesn't make a big
difference in other points. I have understood also that there is a preference
for using "{}" in the logs instead of concatenating strings.
> Add version to FLE notifications for trunk
> --
>
> Key: ZOOKEEPER-1810
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1810
> Project: ZooKeeper
> Issue Type: Sub-task
>Affects Versions: 3.5.0
>Reporter: Flavio Junqueira
>Assignee: Germán Blanco
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1810.patch, ZOOKEEPER-1810.patch,
> ZOOKEEPER-1810.patch
>
>
> The same as ZOOKEEPER-1808 but for trunk.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1813) Zookeeper restart fails due to missing node from snapshot
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823356#comment-13823356
]
Vinay commented on ZOOKEEPER-1813:
--
Scenario :
1. There are so many nodes under /test/subdir1/subdir2
2. One node is created under /test/subdir2/subdir. here the zxid is say X;
3. Now snapshotting with zxid X. started due to reaching snapCount threshold.
4. Now before snapshot was still writing nodes under /test/subdir1/subdir2,
children nodes under /test/subdir2/subdir are created and deleted. (
/test/subdir2/subdir/file)
/test/subdir2/subdir also deleted.
5. When snapshot comes to write /test/subdir2 it will have no childs, same is
stored in snapshot.
6. Now if the Zk restarted while loading data tree, after loading snapshot,
there will be txn for create /test/subdir2/subdir/file, but there wont be
parent node, because it was already missed from snapshot. And restart fails.
> Zookeeper restart fails due to missing node from snapshot
> -
>
> Key: ZOOKEEPER-1813
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1813
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.4.5, 3.5.0
>Reporter: Vinay
>Priority: Blocker
>
> Due to following exception Zookeeper restart is failing
> {noformat}java.io.IOException: Failed to process transaction type: 1 error:
> KeeperErrorCode = NoNode for /test/subdir2/subdir2/subdir
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:183)
> at
> org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:222)
> at
> org.apache.zookeeper.server.ZooKeeperServer.loadData(ZooKeeperServer.java:255)
> at
> org.apache.zookeeper.server.ZooKeeperServer.startdata(ZooKeeperServer.java:380)
> at
> org.apache.zookeeper.server.NIOServerCnxnFactory.startup(NIOServerCnxnFactory.java:748)
> at
> org.apache.zookeeper.server.ZooKeeperServerMain.runFromConfig(ZooKeeperServerMain.java:111)
> at
> org.apache.zookeeper.server.ZooKeeperServerMain.initializeAndRun(ZooKeeperServerMain.java:90)
> at
> org.apache.zookeeper.server.ZooKeeperServerMainTest$2.run(ZooKeeperServerMainTest.java:218)
> Caused by: org.apache.zookeeper.KeeperException$NoNodeException:
> KeeperErrorCode = NoNode for /test/subdir2/subdir2/subdir
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.processTransaction(FileTxnSnapLog.java:268)
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:181)
> ... 7 more{noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1813) Zookeeper restart fails due to missing node from snapshot
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinay updated ZOOKEEPER-1813:
-
Attachment: ZOOKEEPER-1813-test.patch
Attaching a test, executed using debug points. Reproduced in both trunk and
3.4.5 versions.
> Zookeeper restart fails due to missing node from snapshot
> -
>
> Key: ZOOKEEPER-1813
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1813
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.4.5, 3.5.0
>Reporter: Vinay
>Priority: Blocker
> Attachments: ZOOKEEPER-1813-test.patch
>
>
> Due to following exception Zookeeper restart is failing
> {noformat}java.io.IOException: Failed to process transaction type: 1 error:
> KeeperErrorCode = NoNode for /test/subdir2/subdir2/subdir
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:183)
> at
> org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:222)
> at
> org.apache.zookeeper.server.ZooKeeperServer.loadData(ZooKeeperServer.java:255)
> at
> org.apache.zookeeper.server.ZooKeeperServer.startdata(ZooKeeperServer.java:380)
> at
> org.apache.zookeeper.server.NIOServerCnxnFactory.startup(NIOServerCnxnFactory.java:748)
> at
> org.apache.zookeeper.server.ZooKeeperServerMain.runFromConfig(ZooKeeperServerMain.java:111)
> at
> org.apache.zookeeper.server.ZooKeeperServerMain.initializeAndRun(ZooKeeperServerMain.java:90)
> at
> org.apache.zookeeper.server.ZooKeeperServerMainTest$2.run(ZooKeeperServerMainTest.java:218)
> Caused by: org.apache.zookeeper.KeeperException$NoNodeException:
> KeeperErrorCode = NoNode for /test/subdir2/subdir2/subdir
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.processTransaction(FileTxnSnapLog.java:268)
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:181)
> ... 7 more{noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
Review Request 15568: See ZOOKEEPER-1810
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15568/ --- Review request for zookeeper, fpj and Raul Gutierrez Segales. Bugs: ZOOKEEPER-1810 https://issues.apache.org/jira/browse/ZOOKEEPER-1810 Repository: zookeeper Description --- See ZOOKEEPER-1810 Diffs - ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1542171 ./src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 1542171 ./src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1542171 ./src/java/main/org/apache/zookeeper/server/quorum/Vote.java 1542171 ./src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java PRE-CREATION ./src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java PRE-CREATION ./src/java/test/org/apache/zookeeper/server/quorum/FLETestUtils.java PRE-CREATION ./src/java/test/org/apache/zookeeper/test/FLEBackwardElectionRoundTest.java 1542171 ./src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java 1542171 ./src/java/test/org/apache/zookeeper/test/FLENewEpochTest.java 1542171 ./src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 1542171 ./src/java/test/org/apache/zookeeper/test/FLETest.java 1542171 ./src/java/test/org/apache/zookeeper/test/FLETestUtils.java 1542171 ./src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java 1542171 ./src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java 1542171 Diff: https://reviews.apache.org/r/15568/diff/ Testing --- Test included. Thanks, German Blanco
[jira] [Updated] (ZOOKEEPER-1810) Add version to FLE notifications for trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Germán Blanco updated ZOOKEEPER-1810: - Attachment: ZOOKEEPER-1810.patch Some style changes. Review in [https://reviews.apache.org/r/15568/] > Add version to FLE notifications for trunk > -- > > Key: ZOOKEEPER-1810 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1810 > Project: ZooKeeper > Issue Type: Sub-task >Affects Versions: 3.5.0 >Reporter: Flavio Junqueira >Assignee: Germán Blanco > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1810.patch, ZOOKEEPER-1810.patch, > ZOOKEEPER-1810.patch, ZOOKEEPER-1810.patch > > > The same as ZOOKEEPER-1808 but for trunk. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1813) Zookeeper restart fails due to missing node from snapshot
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823364#comment-13823364
]
Thawan Kooburat commented on ZOOKEEPER-1813:
I believe this is similar issue as ZOOKEEPER-1573. In that case, I found that
it is a false positive. If the check is disable, the result after snapshot
restore is still a valid state of the system. I don't quite follow your
example but it seem to be similar that we can ignore the failure right?
Anyway the work around is to actually remove snapshot and txnlog for a given
server.
> Zookeeper restart fails due to missing node from snapshot
> -
>
> Key: ZOOKEEPER-1813
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1813
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.4.5, 3.5.0
>Reporter: Vinay
>Priority: Blocker
> Attachments: ZOOKEEPER-1813-test.patch
>
>
> Due to following exception Zookeeper restart is failing
> {noformat}java.io.IOException: Failed to process transaction type: 1 error:
> KeeperErrorCode = NoNode for /test/subdir2/subdir2/subdir
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:183)
> at
> org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:222)
> at
> org.apache.zookeeper.server.ZooKeeperServer.loadData(ZooKeeperServer.java:255)
> at
> org.apache.zookeeper.server.ZooKeeperServer.startdata(ZooKeeperServer.java:380)
> at
> org.apache.zookeeper.server.NIOServerCnxnFactory.startup(NIOServerCnxnFactory.java:748)
> at
> org.apache.zookeeper.server.ZooKeeperServerMain.runFromConfig(ZooKeeperServerMain.java:111)
> at
> org.apache.zookeeper.server.ZooKeeperServerMain.initializeAndRun(ZooKeeperServerMain.java:90)
> at
> org.apache.zookeeper.server.ZooKeeperServerMainTest$2.run(ZooKeeperServerMainTest.java:218)
> Caused by: org.apache.zookeeper.KeeperException$NoNodeException:
> KeeperErrorCode = NoNode for /test/subdir2/subdir2/subdir
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.processTransaction(FileTxnSnapLog.java:268)
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:181)
> ... 7 more{noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
ZooKeeper_branch33_solaris - Build # 707 - Failure
See https://builds.apache.org/job/ZooKeeper_branch33_solaris/707/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 102239 lines...] [junit] 2013-11-15 07:11:30,442 - INFO [main:ZooKeeperServer@154] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test4866945393166413801.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test4866945393166413801.junit.dir/version-2 [junit] 2013-11-15 07:11:30,443 - INFO [main:NIOServerCnxn$Factory@143] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-11-15 07:11:30,445 - INFO [main:FileSnap@82] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test4866945393166413801.junit.dir/version-2/snapshot.0 [junit] 2013-11-15 07:11:30,449 - INFO [main:FileTxnSnapLog@256] - Snapshotting: b [junit] 2013-11-15 07:11:30,451 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-15 07:11:30,452 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - Accepted socket connection from /127.0.0.1:46498 [junit] 2013-11-15 07:11:30,453 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing stat command from /127.0.0.1:46498 [junit] 2013-11-15 07:11:30,454 - INFO [Thread-4:NIOServerCnxn$StatCommand@1153] - Stat command output [junit] 2013-11-15 07:11:30,455 - INFO [Thread-4:NIOServerCnxn@1435] - Closed socket connection for client /127.0.0.1:46498 (no session established for client) [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-15 07:11:30,457 - INFO [main:ClientBase@408] - STOPPING server [junit] 2013-11-15 07:11:30,459 - INFO [ProcessThread:-1:PrepRequestProcessor@128] - PrepRequestProcessor exited loop! [junit] 2013-11-15 07:11:30,459 - INFO [SyncThread:0:SyncRequestProcessor@151] - SyncRequestProcessor exited! [junit] 2013-11-15 07:11:30,459 - INFO [main:FinalRequestProcessor@370] - shutdown of request processor complete [junit] 2013-11-15 07:11:30,460 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] ensureOnly:[] [junit] 2013-11-15 07:11:30,462 - INFO [main:ClientBase@401] - STARTING server [junit] 2013-11-15 07:11:30,463 - INFO [main:ZooKeeperServer@154] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test4866945393166413801.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test4866945393166413801.junit.dir/version-2 [junit] 2013-11-15 07:11:30,464 - INFO [main:NIOServerCnxn$Factory@143] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-11-15 07:11:30,465 - INFO [main:FileSnap@82] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test4866945393166413801.junit.dir/version-2/snapshot.b [junit] 2013-11-15 07:11:30,468 - INFO [main:FileTxnSnapLog@256] - Snapshotting: b [junit] 2013-11-15 07:11:30,470 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-15 07:11:30,471 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - Accepted socket connection from /127.0.0.1:46500 [junit] 2013-11-15 07:11:30,472 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing stat command from /127.0.0.1:46500 [junit] 2013-11-15 07:11:30,472 - INFO [Thread-5:NIOServerCnxn$StatCommand@1153] - Stat command output [junit] 2013-11-15 07:11:30,473 - INFO [Thread-5:NIOServerCnxn@1435] - Closed socket connection for client /127.0.0.1:46500 (no session established for client) [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-15 07:11:30,475 - INFO [main:Clie
[jira] [Commented] (ZOOKEEPER-1813) Zookeeper restart fails due to missing node from snapshot
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823384#comment-13823384
]
Vinay commented on ZOOKEEPER-1813:
--
Yes I agree that this is issue is same as ZOOKEEPER-1573.
bq. Anyway the work around is to actually remove snapshot and txnlog for a
given server.
This is Ok. but in production cluster, it would be better to avoid this
situation.
As you told removing the check only can solve the issue.
> Zookeeper restart fails due to missing node from snapshot
> -
>
> Key: ZOOKEEPER-1813
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1813
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.4.5, 3.5.0
>Reporter: Vinay
>Priority: Blocker
> Attachments: ZOOKEEPER-1813-test.patch
>
>
> Due to following exception Zookeeper restart is failing
> {noformat}java.io.IOException: Failed to process transaction type: 1 error:
> KeeperErrorCode = NoNode for /test/subdir2/subdir2/subdir
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:183)
> at
> org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:222)
> at
> org.apache.zookeeper.server.ZooKeeperServer.loadData(ZooKeeperServer.java:255)
> at
> org.apache.zookeeper.server.ZooKeeperServer.startdata(ZooKeeperServer.java:380)
> at
> org.apache.zookeeper.server.NIOServerCnxnFactory.startup(NIOServerCnxnFactory.java:748)
> at
> org.apache.zookeeper.server.ZooKeeperServerMain.runFromConfig(ZooKeeperServerMain.java:111)
> at
> org.apache.zookeeper.server.ZooKeeperServerMain.initializeAndRun(ZooKeeperServerMain.java:90)
> at
> org.apache.zookeeper.server.ZooKeeperServerMainTest$2.run(ZooKeeperServerMainTest.java:218)
> Caused by: org.apache.zookeeper.KeeperException$NoNodeException:
> KeeperErrorCode = NoNode for /test/subdir2/subdir2/subdir
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.processTransaction(FileTxnSnapLog.java:268)
> at
> org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:181)
> ... 7 more{noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
