[jira] [Commented] (ZOOKEEPER-1665) Support recursive deletion in multi
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825047#comment-13825047
]
Ted Yu commented on ZOOKEEPER-1665:
---
bq. and return without rollback the previously committed operations.
If this limitation cannot be lifted with reasonable effort, I can resolve this
JIRA.
> Support recursive deletion in multi
> ---
>
> Key: ZOOKEEPER-1665
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1665
> Project: ZooKeeper
> Issue Type: New Feature
>Reporter: Ted Yu
>
> Use case in HBase is that we need to recursively delete multiple subtrees:
> {code}
> ZKUtil.deleteChildrenRecursively(watcher, acquiredZnode);
> ZKUtil.deleteChildrenRecursively(watcher, reachedZnode);
> ZKUtil.deleteChildrenRecursively(watcher, abortZnode);
> {code}
> To achieve high consistency, it is desirable to use multi for the above
> operations.
> This JIRA adds support for recursive deletion in multi.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
Success: ZOOKEEPER-1573 PreCommit Build #1779
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1573 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1779/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 238165 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12614319/ZOOKEEPER-1573.patch [exec] against trunk revision 1542355. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1779//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1779//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1779//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] ece92a959f1af23ed87604888ff2e272dcf5df16 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 33 minutes 32 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-1573 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-1573) Unable to load database due to missing parent node
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825033#comment-13825033 ] Hadoop QA commented on ZOOKEEPER-1573: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614319/ZOOKEEPER-1573.patch against trunk revision 1542355. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1779//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1779//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1779//console This message is automatically generated. > Unable to load database due to missing parent node > -- > > Key: ZOOKEEPER-1573 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1573 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.4.3, 3.5.0 >Reporter: Thawan Kooburat > Attachments: ZOOKEEPER-1573.patch, ZOOKEEPER-1573.patch, > ZOOKEEPER-1573.patch, ZOOKEEPER-1573.patch > > > While replaying txnlog on data tree, the server has a code to detect missing > parent node. This code block was last modified as part of ZOOKEEPER-1333. In > our production, we found a case where this check is return false positive. > The sequence of txns is as follows: > zxid 1: create /prefix/a > zxid 2: create /prefix/a/b > zxid 3: delete /prefix/a/b > zxid 4: delete /prefix/a > The server start capturing snapshot at zxid 1. However, by the time it > traversing the data tree down to /prefix, txn 4 is already applied and > /prefix have no children. > When the server restore from snapshot, it process txnlog starting from zxid > 2. This txn generate missing parent error and the server refuse to start up. > The same check allow me to discover bug in ZOOKEEPER-1551, but I don't know > if we have any option beside removing this check to solve this issue. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1573) Unable to load database due to missing parent node
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinay updated ZOOKEEPER-1573: - Attachment: ZOOKEEPER-1573.patch Updated the last nit as well. removed the duplicate code in 3 places and moved to a method. > Unable to load database due to missing parent node > -- > > Key: ZOOKEEPER-1573 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1573 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.4.3, 3.5.0 >Reporter: Thawan Kooburat > Attachments: ZOOKEEPER-1573.patch, ZOOKEEPER-1573.patch, > ZOOKEEPER-1573.patch, ZOOKEEPER-1573.patch > > > While replaying txnlog on data tree, the server has a code to detect missing > parent node. This code block was last modified as part of ZOOKEEPER-1333. In > our production, we found a case where this check is return false positive. > The sequence of txns is as follows: > zxid 1: create /prefix/a > zxid 2: create /prefix/a/b > zxid 3: delete /prefix/a/b > zxid 4: delete /prefix/a > The server start capturing snapshot at zxid 1. However, by the time it > traversing the data tree down to /prefix, txn 4 is already applied and > /prefix have no children. > When the server restore from snapshot, it process txnlog starting from zxid > 2. This txn generate missing parent error and the server refuse to start up. > The same check allow me to discover bug in ZOOKEEPER-1551, but I don't know > if we have any option beside removing this check to solve this issue. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1573) Unable to load database due to missing parent node
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825014#comment-13825014
]
Raul Gutierrez Segales commented on ZOOKEEPER-1573:
---
Last nit (though feel free to ignore it since it refers to improving old code
as well):
{noformat}
+
+long start = System.currentTimeMillis();
+while (!connected) {
+long end = System.currentTimeMillis();
+if (end - start > 5000) {
+Assert.assertTrue("Could not connect with server in 5 seconds",
+false);
+}
+try {
+Thread.sleep(200);
+} catch (Exception e) {
+LOG.warn("Interrupted");
+}
+}
{noformat}
this is copy/pasted for two other tests as well - can we move it to a method
called waitConnected and call that instead? It'll make tests shorted and more
readable I think.
> Unable to load database due to missing parent node
> --
>
> Key: ZOOKEEPER-1573
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1573
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.4.3, 3.5.0
>Reporter: Thawan Kooburat
> Attachments: ZOOKEEPER-1573.patch, ZOOKEEPER-1573.patch,
> ZOOKEEPER-1573.patch
>
>
> While replaying txnlog on data tree, the server has a code to detect missing
> parent node. This code block was last modified as part of ZOOKEEPER-1333. In
> our production, we found a case where this check is return false positive.
> The sequence of txns is as follows:
> zxid 1: create /prefix/a
> zxid 2: create /prefix/a/b
> zxid 3: delete /prefix/a/b
> zxid 4: delete /prefix/a
> The server start capturing snapshot at zxid 1. However, by the time it
> traversing the data tree down to /prefix, txn 4 is already applied and
> /prefix have no children.
> When the server restore from snapshot, it process txnlog starting from zxid
> 2. This txn generate missing parent error and the server refuse to start up.
> The same check allow me to discover bug in ZOOKEEPER-1551, but I don't know
> if we have any option beside removing this check to solve this issue.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1573) Unable to load database due to missing parent node
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825005#comment-13825005 ] Hadoop QA commented on ZOOKEEPER-1573: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614308/ZOOKEEPER-1573.patch against trunk revision 1542355. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1778//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1778//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1778//console This message is automatically generated. > Unable to load database due to missing parent node > -- > > Key: ZOOKEEPER-1573 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1573 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.4.3, 3.5.0 >Reporter: Thawan Kooburat > Attachments: ZOOKEEPER-1573.patch, ZOOKEEPER-1573.patch, > ZOOKEEPER-1573.patch > > > While replaying txnlog on data tree, the server has a code to detect missing > parent node. This code block was last modified as part of ZOOKEEPER-1333. In > our production, we found a case where this check is return false positive. > The sequence of txns is as follows: > zxid 1: create /prefix/a > zxid 2: create /prefix/a/b > zxid 3: delete /prefix/a/b > zxid 4: delete /prefix/a > The server start capturing snapshot at zxid 1. However, by the time it > traversing the data tree down to /prefix, txn 4 is already applied and > /prefix have no children. > When the server restore from snapshot, it process txnlog starting from zxid > 2. This txn generate missing parent error and the server refuse to start up. > The same check allow me to discover bug in ZOOKEEPER-1551, but I don't know > if we have any option beside removing this check to solve this issue. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1573) Unable to load database due to missing parent node
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinay updated ZOOKEEPER-1573: - Attachment: ZOOKEEPER-1573.patch Updated the patch. I thought for zookeepeer max line length is 120 chars. Now wrapped all lines to 80 chars. Thanks for the review > Unable to load database due to missing parent node > -- > > Key: ZOOKEEPER-1573 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1573 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.4.3, 3.5.0 >Reporter: Thawan Kooburat > Attachments: ZOOKEEPER-1573.patch, ZOOKEEPER-1573.patch, > ZOOKEEPER-1573.patch > > > While replaying txnlog on data tree, the server has a code to detect missing > parent node. This code block was last modified as part of ZOOKEEPER-1333. In > our production, we found a case where this check is return false positive. > The sequence of txns is as follows: > zxid 1: create /prefix/a > zxid 2: create /prefix/a/b > zxid 3: delete /prefix/a/b > zxid 4: delete /prefix/a > The server start capturing snapshot at zxid 1. However, by the time it > traversing the data tree down to /prefix, txn 4 is already applied and > /prefix have no children. > When the server restore from snapshot, it process txnlog starting from zxid > 2. This txn generate missing parent error and the server refuse to start up. > The same check allow me to discover bug in ZOOKEEPER-1551, but I don't know > if we have any option beside removing this check to solve this issue. -- This message was sent by Atlassian JIRA (v6.1#6144)
ZooKeeper-3.4-WinVS2008_java - Build # 349 - Still Failing
See https://builds.apache.org/job/ZooKeeper-3.4-WinVS2008_java/349/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 187558 lines...] [junit] 2013-11-17 23:16:49,868 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-11-17 23:16:49,868 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@224] - NIOServerCnxn factory exited run method [junit] 2013-11-17 23:16:49,869 [myid:] - INFO [main:ZooKeeperServer@441] - shutting down [junit] 2013-11-17 23:16:49,869 [myid:] - INFO [main:SessionTrackerImpl@225] - Shutting down [junit] 2013-11-17 23:16:49,869 [myid:] - INFO [main:PrepRequestProcessor@761] - Shutting down [junit] 2013-11-17 23:16:49,869 [myid:] - INFO [main:SyncRequestProcessor@209] - Shutting down [junit] 2013-11-17 23:16:49,869 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop! [junit] 2013-11-17 23:16:49,870 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited! [junit] 2013-11-17 23:16:49,976 [myid:] - INFO [main:FinalRequestProcessor@415] - shutdown of request processor complete [junit] 2013-11-17 23:16:49,977 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-17 23:16:50,505 [myid:] - WARN [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1095] - Session 0x142685a2556 for server null, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused: no further information [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:567) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1074) [junit] 2013-11-17 23:16:50,976 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[] [junit] 2013-11-17 23:16:50,977 [myid:] - INFO [main:ClientBase@414] - STARTING server [junit] 2013-11-17 23:16:50,978 [myid:] - INFO [main:ZooKeeperServer@162] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir f:\hudson\hudson-slave\workspace\ZooKeeper-3.4-WinVS2008_java\branch-3.4\build\test\tmp\test6872627361852543400.junit.dir\version-2 snapdir f:\hudson\hudson-slave\workspace\ZooKeeper-3.4-WinVS2008_java\branch-3.4\build\test\tmp\test6872627361852543400.junit.dir\version-2 [junit] 2013-11-17 23:16:50,979 [myid:] - INFO [main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-11-17 23:16:51,000 [myid:] - INFO [SessionTracker:SessionTrackerImpl@162] - SessionTrackerImpl exited loop! [junit] 2013-11-17 23:16:50,999 [myid:] - INFO [SessionTracker:SessionTrackerImpl@162] - SessionTrackerImpl exited loop! [junit] 2013-11-17 23:16:51,081 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-17 23:16:51,082 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - Accepted socket connection from /127.0.0.1:49780 [junit] 2013-11-17 23:16:51,082 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@817] - Processing stat command from /127.0.0.1:49780 [junit] 2013-11-17 23:16:51,083 [myid:] - INFO [Thread-5:NIOServerCnxn$StatCommand@653] - Stat command output [junit] 2013-11-17 23:16:51,180 [myid:] - INFO [Thread-5:NIOServerCnxn@997] - Closed socket connection for client /127.0.0.1:49780 (no session established for client) [junit] 2013-11-17 23:16:51,180 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-11-17 23:16:51,182 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-11-17 23:16:51,182 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-11-17 23:16:51,280 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-11-17 23:16:51,280 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-17 23:16:51,280 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota [junit] 2013-11-17 23:16:51,280 [myid:] - INFO [main:ClientBase@451] - tearDown starting [junit] 2013-11-17 23:16:51,419 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x142685a2556 closed [junit] 2013-11-17 23:16:51,420 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-11-17 23:16:51,420 [myid:] -
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824972#comment-13824972 ] Raul Gutierrez Segales commented on ZOOKEEPER-1817: --- (of course, with the proper line wrap for > 80 chars). > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824970#comment-13824970
]
Raul Gutierrez Segales commented on ZOOKEEPER-1817:
---
One more nit (sorry [~fpj]) in:
{noformat}
-return "(" + id + ", " + Long.toHexString(zxid) + ", " +
Long.toHexString(peerEpoch) + ")";
+return "(" + id + ", "
+ + Long.toHexString(zxid)
+ + ", " + Long.toHexString(peerEpoch)
+ + ")";
{noformat}
should we encourage String.format instead of concatenation (as we do in LOG
statements with {})? I think this is more readable:
{noformat}
-return "(" + id + ", " + Long.toHexString(zxid) + ", " +
Long.toHexString(peerEpoch) + ")";
+return String.format("(%d, %s, %s)", id, Long.toHexString(zxid),
Long.toHexString(peerEpoch));
{noformat}
What do you think?
> Fix don't care for b3.4
> ---
>
> Key: ZOOKEEPER-1817
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>Priority: Blocker
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch
>
>
> See umbrella jira.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1573) Unable to load database due to missing parent node
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824934#comment-13824934
]
Raul Gutierrez Segales commented on ZOOKEEPER-1573:
---
Thanks for the quick update Vinay. A few more nits:
In:
{noformat}
+ * Snapshots are lazily created. So when a snapshot is in progress,
+ * there is a chance for later transactions to make to into the
snapshot.
+ * Then when the snapshot is restored, NONODE/NODEEXISTS errors
+ * could occur. It should be safe to ignore these.
{noformat}
I had a typo in my suggestion (sorry) - it should be: "...transactions to make
into the snapshot".
In:
{noformat}
+LOG.debug("Ignoring processTxn failure hdr: {}, error: {}, path:
{}", hdr.getType(), rc.err, rc.path);
{noformat}
the line is too long, maybe:
{noformat}
+LOG.debug("Ignoring processTxn failure hdr: {}, error: {}, path:
{}",
+ hdr.getType(), rc.err, rc.path);
{noformat}
In:
{noformat}
+Assert.assertTrue("waiting for server being up ",
ClientBase.waitForServerUp(HOSTPORT, CONNECTION_TIMEOUT));
{noformat}
line is too long. And this line appears again later on.
> Unable to load database due to missing parent node
> --
>
> Key: ZOOKEEPER-1573
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1573
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.4.3, 3.5.0
>Reporter: Thawan Kooburat
> Attachments: ZOOKEEPER-1573.patch, ZOOKEEPER-1573.patch
>
>
> While replaying txnlog on data tree, the server has a code to detect missing
> parent node. This code block was last modified as part of ZOOKEEPER-1333. In
> our production, we found a case where this check is return false positive.
> The sequence of txns is as follows:
> zxid 1: create /prefix/a
> zxid 2: create /prefix/a/b
> zxid 3: delete /prefix/a/b
> zxid 4: delete /prefix/a
> The server start capturing snapshot at zxid 1. However, by the time it
> traversing the data tree down to /prefix, txn 4 is already applied and
> /prefix have no children.
> When the server restore from snapshot, it process txnlog starting from zxid
> 2. This txn generate missing parent error and the server refuse to start up.
> The same check allow me to discover bug in ZOOKEEPER-1551, but I don't know
> if we have any option beside removing this check to solve this issue.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1573) Unable to load database due to missing parent node
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824841#comment-13824841 ] Hadoop QA commented on ZOOKEEPER-1573: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614286/ZOOKEEPER-1573.patch against trunk revision 1542355. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1777//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1777//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1777//console This message is automatically generated. > Unable to load database due to missing parent node > -- > > Key: ZOOKEEPER-1573 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1573 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.4.3, 3.5.0 >Reporter: Thawan Kooburat > Attachments: ZOOKEEPER-1573.patch, ZOOKEEPER-1573.patch > > > While replaying txnlog on data tree, the server has a code to detect missing > parent node. This code block was last modified as part of ZOOKEEPER-1333. In > our production, we found a case where this check is return false positive. > The sequence of txns is as follows: > zxid 1: create /prefix/a > zxid 2: create /prefix/a/b > zxid 3: delete /prefix/a/b > zxid 4: delete /prefix/a > The server start capturing snapshot at zxid 1. However, by the time it > traversing the data tree down to /prefix, txn 4 is already applied and > /prefix have no children. > When the server restore from snapshot, it process txnlog starting from zxid > 2. This txn generate missing parent error and the server refuse to start up. > The same check allow me to discover bug in ZOOKEEPER-1551, but I don't know > if we have any option beside removing this check to solve this issue. -- This message was sent by Atlassian JIRA (v6.1#6144)
Success: ZOOKEEPER-1573 PreCommit Build #1777
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1573 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1777/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 285539 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12614286/ZOOKEEPER-1573.patch [exec] against trunk revision 1542355. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1777//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1777//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1777//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 20635d91f9384a42bf3b906ef36d07525e3a3729 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 33 minutes 57 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-1573 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-1653) zookeeper fails to start because of inconsistent epoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824839#comment-13824839
]
Vinay commented on ZOOKEEPER-1653:
--
Apart from [~rgs] comments which are minor nits in Test,
+1 for changes in src.
> zookeeper fails to start because of inconsistent epoch
> --
>
> Key: ZOOKEEPER-1653
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1653
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
>Affects Versions: 3.4.5
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1653.3.4.patch, ZOOKEEPER-1653.3.4.patch,
> ZOOKEEPER-1653.patch, ZOOKEEPER-1653.patch
>
>
> It looks like QuorumPeer.loadDataBase() could fail if the server was
> restarted after zk.takeSnapshot() but before finishing
> self.setCurrentEpoch(newEpoch) in Learner.java.
> {code:java}
> case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
> zk.takeSnapshot();
> self.setCurrentEpoch(newEpoch); // <<< got restarted here
> snapshotTaken = true;
> writePacket(new QuorumPacket(Leader.ACK, newLeaderZxid, null, null),
> true);
> break;
> {code}
> The server fails to start because currentEpoch is still 1 but the last
> processed zkid from the snapshot has been updated.
> {noformat}
> 2013-02-20 13:45:02,733 5543 [pool-1-thread-1] ERROR
> org.apache.zookeeper.server.quorum.QuorumPeer - Unable to load database on
> disk
> java.io.IOException: The current epoch, 1, is older than the last zxid,
> 8589934592
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:439)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:413)
> ...
> {noformat}
> {noformat}
> $ find datadir
> datadir
> datadir/version-2
> datadir/version-2/currentEpoch.tmp
> datadir/version-2/acceptedEpoch
> datadir/version-2/snapshot.0
> datadir/version-2/currentEpoch
> datadir/version-2/snapshot.2
> $ cat datadir/version-2/currentEpoch.tmp
> 2%
> $ cat datadir/version-2/acceptedEpoch
> 2%
> $ cat datadir/version-2/currentEpoch
> 1%
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1573) Unable to load database due to missing parent node
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vinay updated ZOOKEEPER-1573: - Attachment: ZOOKEEPER-1573.patch Updated the patch with comments. Please review > Unable to load database due to missing parent node > -- > > Key: ZOOKEEPER-1573 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1573 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.4.3, 3.5.0 >Reporter: Thawan Kooburat > Attachments: ZOOKEEPER-1573.patch, ZOOKEEPER-1573.patch > > > While replaying txnlog on data tree, the server has a code to detect missing > parent node. This code block was last modified as part of ZOOKEEPER-1333. In > our production, we found a case where this check is return false positive. > The sequence of txns is as follows: > zxid 1: create /prefix/a > zxid 2: create /prefix/a/b > zxid 3: delete /prefix/a/b > zxid 4: delete /prefix/a > The server start capturing snapshot at zxid 1. However, by the time it > traversing the data tree down to /prefix, txn 4 is already applied and > /prefix have no children. > When the server restore from snapshot, it process txnlog starting from zxid > 2. This txn generate missing parent error and the server refuse to start up. > The same check allow me to discover bug in ZOOKEEPER-1551, but I don't know > if we have any option beside removing this check to solve this issue. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1019) zkfuse doesn't list dependency on boost in README
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824805#comment-13824805 ] Flavio Junqueira commented on ZOOKEEPER-1019: - [~phunt], if this patch is ready, could you +1 it, please? It looks fine to me. > zkfuse doesn't list dependency on boost in README > - > > Key: ZOOKEEPER-1019 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1019 > Project: ZooKeeper > Issue Type: Improvement > Components: contrib >Affects Versions: 3.4.0 >Reporter: Karel Vervaeke >Assignee: Raul Gutierrez Segales > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-1019 > > Original Estimate: 5m > Remaining Estimate: 5m > > The README.txt under contrib/fuse doesn't list boost under Development build > libraries< -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) "make check" doesn't work on macos
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824802#comment-13824802
]
Flavio Junqueira commented on ZOOKEEPER-1742:
-
The patch for 3.4 seems to work fine, just a couple of things I wanted to run
by you. When I run autoreconf, I'm getting a bunch warning:
{noformat}
Makefile.am:81: warning: wildcard ${srcdir}/tests/*.cc: non-POSIX variable name
Makefile.am:81: (probably a GNU make extension)
Makefile.am:81: warning: wildcard ${srcdir}/tests/*.h: non-POSIX variable name
Makefile.am:81: (probably a GNU make extension)
Makefile.am:92: warning: shell cat ${srcdir}/tests/wrappers.opt: non-POSIX
variable name
Makefile.am:92: (probably a GNU make extension)
Makefile.am:105: warning: shell cat ${srcdir}/tests/wrappers-mt.opt: non-POSIX
variable name
Makefile.am:105: (probably a GNU make extension)
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libhashtable.la':
linking libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:16: while processing Libtool library 'libhashtable.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzkmt.la': linking
libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:48: while processing Libtool library 'libzkmt.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzkmt_test.la':
linking libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:16: while processing Libtool library 'libzkmt_test.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzkst.la': linking
libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:16: while processing Libtool library 'libzkst.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzkst_test.la':
linking libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:16: while processing Libtool library 'libzkst_test.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzookeeper_mt.la':
linking libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:53: while processing Libtool library 'libzookeeper_mt.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzookeeper_st.la':
linking libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:35: while processing Libtool library 'libzookeeper_st.la'
{noformat}
Is this expected?
Also, there are these two error messages that seem to be harmless, but they are
there:
{noformat}
cat: ./tests/wrappers.opt: No such file or directory
cat: ./tests/wrappers-mt.opt: No such file or directory
{noformat}
> "make check" doesn't work on macos
> --
>
> Key: ZOOKEEPER-1742
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.4.5, 3.5.0
>Reporter: Flavio Junqueira
>Assignee: Benjamin Reed
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch,
> ZOOKEEPER-1742.patch
>
>
> There are two problems I have spotted when running "make check" with the C
> client. First, it complains that the sleep call is not defined in two test
> files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc.
> Including unistd.h works. The second problem is with linker options. It
> complains that "--wrap" is not a valid. I'm not sure how to deal with this
> one yet, since I'm not sure why we are using it.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Comment Edited] (ZOOKEEPER-1742) "make check" doesn't work on macos
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824802#comment-13824802
]
Flavio Junqueira edited comment on ZOOKEEPER-1742 at 11/17/13 11:36 AM:
The patch for 3.4 seems to work fine, just a couple of things I wanted to run
by you. When I run autoreconf, I'm getting a bunch warnings:
{noformat}
Makefile.am:81: warning: wildcard ${srcdir}/tests/*.cc: non-POSIX variable name
Makefile.am:81: (probably a GNU make extension)
Makefile.am:81: warning: wildcard ${srcdir}/tests/*.h: non-POSIX variable name
Makefile.am:81: (probably a GNU make extension)
Makefile.am:92: warning: shell cat ${srcdir}/tests/wrappers.opt: non-POSIX
variable name
Makefile.am:92: (probably a GNU make extension)
Makefile.am:105: warning: shell cat ${srcdir}/tests/wrappers-mt.opt: non-POSIX
variable name
Makefile.am:105: (probably a GNU make extension)
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libhashtable.la':
linking libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:16: while processing Libtool library 'libhashtable.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzkmt.la': linking
libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:48: while processing Libtool library 'libzkmt.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzkmt_test.la':
linking libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:16: while processing Libtool library 'libzkmt_test.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzkst.la': linking
libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:16: while processing Libtool library 'libzkst.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzkst_test.la':
linking libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:16: while processing Libtool library 'libzkst_test.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzookeeper_mt.la':
linking libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:53: while processing Libtool library 'libzookeeper_mt.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzookeeper_st.la':
linking libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:35: while processing Libtool library 'libzookeeper_st.la'
{noformat}
Is this expected?
Also, there are these two error messages that seem to be harmless, but they are
there:
{noformat}
cat: ./tests/wrappers.opt: No such file or directory
cat: ./tests/wrappers-mt.opt: No such file or directory
{noformat}
was (Author: fpj):
The patch for 3.4 seems to work fine, just a couple of things I wanted to run
by you. When I run autoreconf, I'm getting a bunch warning:
{noformat}
Makefile.am:81: warning: wildcard ${srcdir}/tests/*.cc: non-POSIX variable name
Makefile.am:81: (probably a GNU make extension)
Makefile.am:81: warning: wildcard ${srcdir}/tests/*.h: non-POSIX variable name
Makefile.am:81: (probably a GNU make extension)
Makefile.am:92: warning: shell cat ${srcdir}/tests/wrappers.opt: non-POSIX
variable name
Makefile.am:92: (probably a GNU make extension)
Makefile.am:105: warning: shell cat ${srcdir}/tests/wrappers-mt.opt: non-POSIX
variable name
Makefile.am:105: (probably a GNU make extension)
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libhashtable.la':
linking libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:16: while processing Libtool library 'libhashtable.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzkmt.la': linking
libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:48: while processing Libtool library 'libzkmt.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzkmt_test.la':
linking libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: archiver requires 'AM_PROG_AR'
in 'configure.ac'
Makefile.am:16: while processing Libtool library 'libzkmt_test.la'
/opt/local/share/automake-1.13/am/ltlibrary.am: warning: 'libzkst.la': linking
libtool libraries using a non-POSIX
/opt/local/share/automake-1.13/am/ltlibrary.am: a
[jira] [Updated] (ZOOKEEPER-1742) "make check" doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated ZOOKEEPER-1742: Assignee: Germán Blanco (was: Benjamin Reed) > "make check" doesn't work on macos > -- > > Key: ZOOKEEPER-1742 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.4.5, 3.5.0 >Reporter: Flavio Junqueira >Assignee: Germán Blanco > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, > ZOOKEEPER-1742.patch > > > There are two problems I have spotted when running "make check" with the C > client. First, it complains that the sleep call is not defined in two test > files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. > Including unistd.h works. The second problem is with linker options. It > complains that "--wrap" is not a valid. I'm not sure how to deal with this > one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1622) session ids will be negative in the year 2022
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824801#comment-13824801
]
Flavio Junqueira commented on ZOOKEEPER-1622:
-
[~phunt], is this a +1 for you?
> session ids will be negative in the year 2022
> -
>
> Key: ZOOKEEPER-1622
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1622
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.4.0, 3.5.0
>Reporter: Eric Newton
>Assignee: Eric Newton
>Priority: Trivial
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1622.patch
>
>
> Someone decided to use a large number for their myid file. This cause
> session ids to go negative, and our software (Apache Accumulo) did not handle
> this very well. While diagnosing the problem, I noticed this in SessionImpl:
> {noformat}
>public static long initializeNextSession(long id) {
> long nextSid = 0;
> nextSid = (System.currentTimeMillis() << 24) >> 8;
> nextSid = nextSid | (id <<56);
> return nextSid;
> }
> {noformat}
> When the 40th bit in System.currentTimeMillis() is a one, sign extension will
> fill the upper 8 bytes of nextSid, and id will not make the session id
> unique. I recommend changing the right shift to the logical shift:
> {noformat}
>public static long initializeNextSession(long id) {
> long nextSid = 0;
> nextSid = (System.currentTimeMillis() << 24) >>> 8;
> nextSid = nextSid | (id <<56);
> return nextSid;
> }
> {noformat}
> But, we have until the year 2022 before we have to worry about it.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824784#comment-13824784 ] Hadoop QA commented on ZOOKEEPER-1817: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614277/ZOOKEEPER-1817.patch against trunk revision 1542355. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1776//console This message is automatically generated. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
Failed: ZOOKEEPER-1817 PreCommit Build #1776
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1776/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 68 lines...] [exec] [exec] patching file src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java [exec] Hunk #1 succeeded at 67 (offset 1 line). [exec] Hunk #2 succeeded at 637 with fuzz 2 (offset 20 lines). [exec] Hunk #3 succeeded at 923 (offset 20 lines). [exec] Hunk #4 succeeded at 942 (offset 20 lines). [exec] patching file src/java/main/org/apache/zookeeper/server/quorum/Vote.java [exec] Hunk #1 FAILED at 125. [exec] 1 out of 1 hunk FAILED -- saving rejects to file src/java/main/org/apache/zookeeper/server/quorum/Vote.java.rej [exec] patching file src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12614277/ZOOKEEPER-1817.patch [exec] against trunk revision 1542355. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1776//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 0478ed4fa2774c8cdd9a016e587501ad2f3d6e7a logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623: exec returned: 1 Total time: 1 minute 3 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1817 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Updated] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated ZOOKEEPER-1817: Attachment: ZOOKEEPER-1817.patch Fixed according to Raul's comments. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
ZooKeeper-trunk-solaris - Build # 733 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/733/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 203878 lines...] [junit] 2013-11-17 09:34:58,035 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@219] - accept thread exitted run method [junit] 2013-11-17 09:34:58,036 [myid:] - INFO [main:ZooKeeperServer@428] - shutting down [junit] 2013-11-17 09:34:58,036 [myid:] - INFO [main:SessionTrackerImpl@183] - Shutting down [junit] 2013-11-17 09:34:58,036 [myid:] - INFO [main:PrepRequestProcessor@972] - Shutting down [junit] 2013-11-17 09:34:58,036 [myid:] - INFO [main:SyncRequestProcessor@190] - Shutting down [junit] 2013-11-17 09:34:58,036 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop! [junit] 2013-11-17 09:34:58,037 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@168] - SyncRequestProcessor exited! [junit] 2013-11-17 09:34:58,037 [myid:] - INFO [main:FinalRequestProcessor@442] - shutdown of request processor complete [junit] 2013-11-17 09:34:58,038 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-17 09:34:58,038 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[] [junit] 2013-11-17 09:34:58,039 [myid:] - INFO [main:ClientBase@414] - STARTING server [junit] 2013-11-17 09:34:58,039 [myid:] - INFO [main:ZooKeeperServer@149] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test6675902296585718352.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test6675902296585718352.junit.dir/version-2 [junit] 2013-11-17 09:34:58,040 [myid:] - INFO [main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 kB direct buffers. [junit] 2013-11-17 09:34:58,040 [myid:] - INFO [main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-11-17 09:34:58,041 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test6675902296585718352.junit.dir/version-2/snapshot.b [junit] 2013-11-17 09:34:58,044 [myid:] - INFO [main:FileTxnSnapLog@297] - Snapshotting: 0xb to /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test6675902296585718352.junit.dir/version-2/snapshot.b [junit] 2013-11-17 09:34:58,045 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-17 09:34:58,046 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:36619 [junit] 2013-11-17 09:34:58,047 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@828] - Processing stat command from /127.0.0.1:36619 [junit] 2013-11-17 09:34:58,047 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn$StatCommand@677] - Stat command output [junit] 2013-11-17 09:34:58,047 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@999] - Closed socket connection for client /127.0.0.1:36619 (no session established for client) [junit] 2013-11-17 09:34:58,047 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-11-17 09:34:58,049 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-11-17 09:34:58,049 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-11-17 09:34:58,049 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-11-17 09:34:58,049 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-17 09:34:58,050 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota [junit] 2013-11-17 09:34:58,050 [myid:] - INFO [main:ClientBase@451] - tearDown starting [junit] 2013-11-17 09:34:58,113 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down [junit] 2013-11-17 09:34:58,113 [myid:] - INFO [main:ZooKeeper@777] - Session: 0x1426569bb95 closed [junit] 2013-11-17 09:34:58,114 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-11-17 09:34:58,114 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServe
ZooKeeper_branch34_solaris - Build # 711 - Failure
See https://builds.apache.org/job/ZooKeeper_branch34_solaris/711/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 155734 lines...] [junit] 2013-11-17 08:58:44,412 [myid:] - INFO [Thread-4:NIOServerCnxn@997] - Closed socket connection for client /127.0.0.1:59875 (no session established for client) [junit] 2013-11-17 08:58:44,413 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-11-17 08:58:44,414 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-11-17 08:58:44,414 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-11-17 08:58:44,414 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-11-17 08:58:44,414 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-17 08:58:44,415 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-11-17 08:58:44,416 [myid:] - INFO [main:ZooKeeperServer@441] - shutting down [junit] 2013-11-17 08:58:44,416 [myid:] - INFO [main:SessionTrackerImpl@225] - Shutting down [junit] 2013-11-17 08:58:44,416 [myid:] - INFO [main:PrepRequestProcessor@761] - Shutting down [junit] 2013-11-17 08:58:44,416 [myid:] - INFO [main:SyncRequestProcessor@209] - Shutting down [junit] 2013-11-17 08:58:44,416 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop! [junit] 2013-11-17 08:58:44,416 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited! [junit] 2013-11-17 08:58:44,417 [myid:] - INFO [main:FinalRequestProcessor@415] - shutdown of request processor complete [junit] 2013-11-17 08:58:44,417 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-17 08:58:44,418 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[] [junit] 2013-11-17 08:58:44,418 [myid:] - INFO [main:ClientBase@414] - STARTING server [junit] 2013-11-17 08:58:44,419 [myid:] - INFO [main:ZooKeeperServer@162] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/trunk/build/test/tmp/test5876276911799722079.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/trunk/build/test/tmp/test5876276911799722079.junit.dir/version-2 [junit] 2013-11-17 08:58:44,419 [myid:] - INFO [main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-11-17 08:58:44,423 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-17 08:58:44,423 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - Accepted socket connection from /127.0.0.1:59877 [junit] 2013-11-17 08:58:44,424 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@817] - Processing stat command from /127.0.0.1:59877 [junit] 2013-11-17 08:58:44,424 [myid:] - INFO [Thread-5:NIOServerCnxn$StatCommand@653] - Stat command output [junit] 2013-11-17 08:58:44,425 [myid:] - INFO [Thread-5:NIOServerCnxn@997] - Closed socket connection for client /127.0.0.1:59877 (no session established for client) [junit] 2013-11-17 08:58:44,426 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-11-17 08:58:44,427 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-11-17 08:58:44,427 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-11-17 08:58:44,427 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-11-17 08:58:44,427 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-17 08:58:44,428 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota [junit] 2013-11-17 08:58:44,428 [myid:] - INFO [main:ClientBase@451] - tearDown starting [junit] 2013-11-17 08:58:44,484 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x142654890cc closed [junit] 2013-11-17 08:58:44,484 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@509] - EventThread shut down [junit] 2013-11-17 08:58:44,485 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-11-17 08:58:44,486 [myid:] - INFO [main:ZooKeeperServer@441] - shutting down [junit] 2013-11-17 08:58:44,487 [m
