ZooKeeper_branch34_solaris - Build # 715 - Failure
See https://builds.apache.org/job/ZooKeeper_branch34_solaris/715/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 155137 lines...] [junit] 2013-11-21 07:57:46,544 [myid:] - INFO [Thread-4:NIOServerCnxn@997] - Closed socket connection for client /127.0.0.1:54018 (no session established for client) [junit] 2013-11-21 07:57:46,544 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-11-21 07:57:46,545 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-11-21 07:57:46,545 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-11-21 07:57:46,546 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-11-21 07:57:46,546 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-21 07:57:46,546 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-11-21 07:57:46,546 [myid:] - INFO [main:ZooKeeperServer@441] - shutting down [junit] 2013-11-21 07:57:46,547 [myid:] - INFO [main:SessionTrackerImpl@225] - Shutting down [junit] 2013-11-21 07:57:46,547 [myid:] - INFO [main:PrepRequestProcessor@761] - Shutting down [junit] 2013-11-21 07:57:46,547 [myid:] - INFO [main:SyncRequestProcessor@209] - Shutting down [junit] 2013-11-21 07:57:46,547 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop! [junit] 2013-11-21 07:57:46,547 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited! [junit] 2013-11-21 07:57:46,547 [myid:] - INFO [main:FinalRequestProcessor@415] - shutdown of request processor complete [junit] 2013-11-21 07:57:46,548 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-21 07:57:46,548 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[] [junit] 2013-11-21 07:57:46,549 [myid:] - INFO [main:ClientBase@414] - STARTING server [junit] 2013-11-21 07:57:46,549 [myid:] - INFO [main:ZooKeeperServer@162] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/trunk/build/test/tmp/test1173583376075065053.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/trunk/build/test/tmp/test1173583376075065053.junit.dir/version-2 [junit] 2013-11-21 07:57:46,550 [myid:] - INFO [main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-11-21 07:57:46,553 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-21 07:57:46,553 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - Accepted socket connection from /127.0.0.1:54020 [junit] 2013-11-21 07:57:46,553 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@817] - Processing stat command from /127.0.0.1:54020 [junit] 2013-11-21 07:57:46,553 [myid:] - INFO [Thread-5:NIOServerCnxn$StatCommand@653] - Stat command output [junit] 2013-11-21 07:57:46,554 [myid:] - INFO [Thread-5:NIOServerCnxn@997] - Closed socket connection for client /127.0.0.1:54020 (no session established for client) [junit] 2013-11-21 07:57:46,554 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-11-21 07:57:46,555 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-11-21 07:57:46,555 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-11-21 07:57:46,555 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-11-21 07:57:46,555 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-21 07:57:46,556 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota [junit] 2013-11-21 07:57:46,556 [myid:] - INFO [main:ClientBase@451] - tearDown starting [junit] 2013-11-21 07:57:46,635 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@509] - EventThread shut down [junit] 2013-11-21 07:57:46,635 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x14279aa3228 closed [junit] 2013-11-21 07:57:46,635 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-11-21 07:57:46,636 [myid:] - INFO [main:ZooKeeperServer@441] - shutting down [junit] 2013-11-21 07:57:46,636 [m
ZooKeeper-trunk-solaris - Build # 737 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/737/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 207116 lines...] [junit] 2013-11-21 09:10:12,000 [myid:] - INFO [main:SessionTrackerImpl@183] - Shutting down [junit] 2013-11-21 09:10:12,000 [myid:] - INFO [main:PrepRequestProcessor@972] - Shutting down [junit] 2013-11-21 09:10:12,000 [myid:] - INFO [main:SyncRequestProcessor@190] - Shutting down [junit] 2013-11-21 09:10:12,000 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop! [junit] 2013-11-21 09:10:12,001 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@168] - SyncRequestProcessor exited! [junit] 2013-11-21 09:10:12,001 [myid:] - INFO [main:FinalRequestProcessor@442] - shutdown of request processor complete [junit] 2013-11-21 09:10:12,001 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-21 09:10:12,002 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[] [junit] 2013-11-21 09:10:12,002 [myid:] - INFO [SessionTracker:SessionTrackerImpl@134] - SessionTrackerImpl exited loop! [junit] 2013-11-21 09:10:12,002 [myid:] - INFO [SessionTracker:SessionTrackerImpl@134] - SessionTrackerImpl exited loop! [junit] 2013-11-21 09:10:12,003 [myid:] - INFO [main:ClientBase@414] - STARTING server [junit] 2013-11-21 09:10:12,003 [myid:] - INFO [main:ZooKeeperServer@149] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test5493100954404616030.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test5493100954404616030.junit.dir/version-2 [junit] 2013-11-21 09:10:12,004 [myid:] - INFO [main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 kB direct buffers. [junit] 2013-11-21 09:10:12,004 [myid:] - INFO [main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-11-21 09:10:12,005 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test5493100954404616030.junit.dir/version-2/snapshot.b [junit] 2013-11-21 09:10:12,008 [myid:] - INFO [main:FileTxnSnapLog@297] - Snapshotting: 0xb to /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test5493100954404616030.junit.dir/version-2/snapshot.b [junit] 2013-11-21 09:10:12,009 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-21 09:10:12,009 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:64999 [junit] 2013-11-21 09:10:12,010 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@828] - Processing stat command from /127.0.0.1:64999 [junit] 2013-11-21 09:10:12,010 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn$StatCommand@677] - Stat command output [junit] 2013-11-21 09:10:12,011 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@999] - Closed socket connection for client /127.0.0.1:64999 (no session established for client) [junit] 2013-11-21 09:10:12,011 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-11-21 09:10:12,012 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-11-21 09:10:12,012 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-11-21 09:10:12,012 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-11-21 09:10:12,013 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-21 09:10:12,013 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota [junit] 2013-11-21 09:10:12,013 [myid:] - INFO [main:ClientBase@451] - tearDown starting [junit] 2013-11-21 09:10:12,083 [myid:] - INFO [main:ZooKeeper@777] - Session: 0x14279ec806a closed [junit] 2013-11-21 09:10:12,083 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down [junit] 2013-11-21 09:10:12,083 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-11-21 09:10:12,084 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] - selector
ZooKeeper-3.4-WinVS2008_java - Build # 353 - Still Failing
See https://builds.apache.org/job/ZooKeeper-3.4-WinVS2008_java/353/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 201128 lines...] [junit] at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) [junit] at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) [junit] at org.junit.runners.ParentRunner.run(ParentRunner.java:236) [junit] at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:518) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1052) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:906) [junit] 2013-11-21 10:18:41,488 [myid:] - INFO [main:ClientBase@451] - tearDown starting [junit] 2013-11-21 10:18:46,167 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x1427a2680090004 closed [junit] 2013-11-21 10:18:46,167 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@509] - EventThread shut down [junit] 2013-11-21 10:18:46,167 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-11-21 10:18:46,168 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@224] - NIOServerCnxn factory exited run method [junit] 2013-11-21 10:18:46,169 [myid:] - INFO [main:ZooKeeperServer@441] - shutting down [junit] 2013-11-21 10:18:46,184 [myid:] - INFO [main:SessionTrackerImpl@225] - Shutting down [junit] 2013-11-21 10:18:46,184 [myid:] - INFO [main:PrepRequestProcessor@761] - Shutting down [junit] 2013-11-21 10:18:46,184 [myid:] - INFO [main:SyncRequestProcessor@209] - Shutting down [junit] 2013-11-21 10:18:46,184 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop! [junit] 2013-11-21 10:18:46,184 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited! [junit] 2013-11-21 10:18:46,185 [myid:] - INFO [main:FinalRequestProcessor@415] - shutdown of request processor complete [junit] 2013-11-21 10:18:46,285 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-21 10:18:48,000 [myid:] - INFO [SessionTracker:SessionTrackerImpl@162] - SessionTrackerImpl exited loop! [junit] 2013-11-21 10:18:51,250 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-21 10:18:54,676 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-21 10:18:59,411 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-21 10:19:04,240 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-21 10:19:08,468 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-21 10:19:11,183 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-21 10:19:12,895 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-21 10:19:15,011 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-21 10:19:16,521 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-21 10:19:21,408 [myid:] - INFO [main:ZKTestCase$1@65] - FAILED testQuota [junit] org.junit.internal.runners.model.MultipleFailureException [junit] at org.junit.internal.runners.model.MultipleFailureException.assertEmpty(MultipleFailureException.java:23) [junit] at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:42) [junit] at org.junit.rules.TestWatchman$1.evaluate(TestWatchman.java:48) [junit] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:76) [junit] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50) [junit] at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193) [junit] at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52) [junit] at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191) [junit] at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42) [junit] at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184) [junit] at org.junit.runners.ParentRunner.run(ParentRunner.java:236) [junit] at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:518) [junit] at org.apache.tools.ant.taskdefs.o
[jira] [Updated] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-602: --- Attachment: ZOOKEEPER-602.patch > log all exceptions not caught by ZK threads > --- > > Key: ZOOKEEPER-602 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602 > Project: ZooKeeper > Issue Type: Bug > Components: java client, server >Affects Versions: 3.2.1 >Reporter: Patrick Hunt >Assignee: Rakesh R >Priority: Critical > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch > > > the java code should add a ThreadGroup exception handler that logs at ERROR > level any uncaught exceptions thrown by Thread run methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829070#comment-13829070 ] Hadoop QA commented on ZOOKEEPER-602: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615139/ZOOKEEPER-602.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1796//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1796//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1796//console This message is automatically generated. > log all exceptions not caught by ZK threads > --- > > Key: ZOOKEEPER-602 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602 > Project: ZooKeeper > Issue Type: Bug > Components: java client, server >Affects Versions: 3.2.1 >Reporter: Patrick Hunt >Assignee: Rakesh R >Priority: Critical > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch > > > the java code should add a ThreadGroup exception handler that logs at ERROR > level any uncaught exceptions thrown by Thread run methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-602: --- Attachment: ZOOKEEPER-602.patch > log all exceptions not caught by ZK threads > --- > > Key: ZOOKEEPER-602 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602 > Project: ZooKeeper > Issue Type: Bug > Components: java client, server >Affects Versions: 3.2.1 >Reporter: Patrick Hunt >Assignee: Rakesh R >Priority: Critical > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch > > > the java code should add a ThreadGroup exception handler that logs at ERROR > level any uncaught exceptions thrown by Thread run methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1653) zookeeper fails to start because of inconsistent epoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flavio Junqueira updated ZOOKEEPER-1653:
Priority: Blocker (was: Major)
> zookeeper fails to start because of inconsistent epoch
> --
>
> Key: ZOOKEEPER-1653
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1653
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
>Affects Versions: 3.4.5
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Blocker
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1653.3.4.patch, ZOOKEEPER-1653.3.4.patch,
> ZOOKEEPER-1653.patch, ZOOKEEPER-1653.patch
>
>
> It looks like QuorumPeer.loadDataBase() could fail if the server was
> restarted after zk.takeSnapshot() but before finishing
> self.setCurrentEpoch(newEpoch) in Learner.java.
> {code:java}
> case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
> zk.takeSnapshot();
> self.setCurrentEpoch(newEpoch); // <<< got restarted here
> snapshotTaken = true;
> writePacket(new QuorumPacket(Leader.ACK, newLeaderZxid, null, null),
> true);
> break;
> {code}
> The server fails to start because currentEpoch is still 1 but the last
> processed zkid from the snapshot has been updated.
> {noformat}
> 2013-02-20 13:45:02,733 5543 [pool-1-thread-1] ERROR
> org.apache.zookeeper.server.quorum.QuorumPeer - Unable to load database on
> disk
> java.io.IOException: The current epoch, 1, is older than the last zxid,
> 8589934592
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:439)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:413)
> ...
> {noformat}
> {noformat}
> $ find datadir
> datadir
> datadir/version-2
> datadir/version-2/currentEpoch.tmp
> datadir/version-2/acceptedEpoch
> datadir/version-2/snapshot.0
> datadir/version-2/currentEpoch
> datadir/version-2/snapshot.2
> $ cat datadir/version-2/currentEpoch.tmp
> 2%
> $ cat datadir/version-2/acceptedEpoch
> 2%
> $ cat datadir/version-2/currentEpoch
> 1%
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-602: --- Attachment: (was: ZOOKEEPER-602.patch) > log all exceptions not caught by ZK threads > --- > > Key: ZOOKEEPER-602 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602 > Project: ZooKeeper > Issue Type: Bug > Components: java client, server >Affects Versions: 3.2.1 >Reporter: Patrick Hunt >Assignee: Rakesh R >Priority: Critical > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch > > > the java code should add a ThreadGroup exception handler that logs at ERROR > level any uncaught exceptions thrown by Thread run methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-602: --- Attachment: (was: ZOOKEEPER-602.patch) > log all exceptions not caught by ZK threads > --- > > Key: ZOOKEEPER-602 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602 > Project: ZooKeeper > Issue Type: Bug > Components: java client, server >Affects Versions: 3.2.1 >Reporter: Patrick Hunt >Assignee: Rakesh R >Priority: Critical > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch > > > the java code should add a ThreadGroup exception handler that logs at ERROR > level any uncaught exceptions thrown by Thread run methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
Failed: ZOOKEEPER-602 PreCommit Build #1795
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-602 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1795/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 290439 lines...] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12615124/ZOOKEEPER-602.patch [exec] against trunk revision 1543281. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1795//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1795//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1795//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 054cc6419cb877d024a2c8a91e7165be3256ecaa logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623: exec returned: 1 Total time: 33 minutes 56 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-602 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-1653) zookeeper fails to start because of inconsistent epoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829473#comment-13829473
]
Vinay commented on ZOOKEEPER-1653:
--
Thanks rakesh for joining.
UpdatingEpoch file will be deleted when the snapshot loaded during startup, and
at that time currentEpoch will also be updated before deletion.
So by the time of next snapshot this file should not be there in any case.
> zookeeper fails to start because of inconsistent epoch
> --
>
> Key: ZOOKEEPER-1653
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1653
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
>Affects Versions: 3.4.5
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Blocker
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1653.3.4.patch, ZOOKEEPER-1653.3.4.patch,
> ZOOKEEPER-1653.patch, ZOOKEEPER-1653.patch
>
>
> It looks like QuorumPeer.loadDataBase() could fail if the server was
> restarted after zk.takeSnapshot() but before finishing
> self.setCurrentEpoch(newEpoch) in Learner.java.
> {code:java}
> case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
> zk.takeSnapshot();
> self.setCurrentEpoch(newEpoch); // <<< got restarted here
> snapshotTaken = true;
> writePacket(new QuorumPacket(Leader.ACK, newLeaderZxid, null, null),
> true);
> break;
> {code}
> The server fails to start because currentEpoch is still 1 but the last
> processed zkid from the snapshot has been updated.
> {noformat}
> 2013-02-20 13:45:02,733 5543 [pool-1-thread-1] ERROR
> org.apache.zookeeper.server.quorum.QuorumPeer - Unable to load database on
> disk
> java.io.IOException: The current epoch, 1, is older than the last zxid,
> 8589934592
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:439)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:413)
> ...
> {noformat}
> {noformat}
> $ find datadir
> datadir
> datadir/version-2
> datadir/version-2/currentEpoch.tmp
> datadir/version-2/acceptedEpoch
> datadir/version-2/snapshot.0
> datadir/version-2/currentEpoch
> datadir/version-2/snapshot.2
> $ cat datadir/version-2/currentEpoch.tmp
> 2%
> $ cat datadir/version-2/acceptedEpoch
> 2%
> $ cat datadir/version-2/currentEpoch
> 1%
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828903#comment-13828903 ] Hadoop QA commented on ZOOKEEPER-1817: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615112/ZOOKEEPER-1817.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1794//console This message is automatically generated. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, logs.tar.gz, logs2.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829000#comment-13829000 ] Hadoop QA commented on ZOOKEEPER-602: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615124/ZOOKEEPER-602.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1795//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1795//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1795//console This message is automatically generated. > log all exceptions not caught by ZK threads > --- > > Key: ZOOKEEPER-602 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602 > Project: ZooKeeper > Issue Type: Bug > Components: java client, server >Affects Versions: 3.2.1 >Reporter: Patrick Hunt >Assignee: Rakesh R >Priority: Critical > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch, ZOOKEEPER-602.patch > > > the java code should add a ThreadGroup exception handler that logs at ERROR > level any uncaught exceptions thrown by Thread run methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (ZOOKEEPER-1819) DeserializationPerfTest calls
Daniel Knightly created ZOOKEEPER-1819: -- Summary: DeserializationPerfTest calls Key: ZOOKEEPER-1819 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1819 Project: ZooKeeper Issue Type: Bug Components: tests Affects Versions: 3.5.0 Reporter: Daniel Knightly Priority: Minor Fix For: 3.5.0 The DeserializationPerfTest calls SerializationPerfTest.createNodes to create serialized nodes to deserialize. However 2 of the arguments, childcount and parentCVersion are switched in the call to the above method. This results in all tests unintentionally testing the same scenario. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1819) DeserializationPerfTest calls
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829491#comment-13829491
]
Daniel Knightly commented on ZOOKEEPER-1819:
The
SerializationPerfTest.createNodes(DataTree tree, String path, int depth,
int childcount, int parentCVersion, byte[] data)
method is called
SerializationPerfTest.createNodes(tree, "/", depth,
tree.getNode("/").stat.getCversion(), width, new byte[len]);
but should be
SerializationPerfTest.createNodes(tree, "/", depth, width,
tree.getNode("/").stat.getCversion(), new byte[len]);
> DeserializationPerfTest calls
> --
>
> Key: ZOOKEEPER-1819
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1819
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
>Affects Versions: 3.5.0
>Reporter: Daniel Knightly
>Priority: Minor
> Fix For: 3.5.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The DeserializationPerfTest calls
> SerializationPerfTest.createNodes to create serialized nodes to deserialize.
> However 2 of the arguments, childcount and parentCVersion are switched in the
> call to the above method. This results in all tests unintentionally testing
> the same scenario.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1819) DeserializationPerfTest calls
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829494#comment-13829494
]
Daniel Knightly commented on ZOOKEEPER-1819:
Index: src/java/test/org/apache/zookeeper/server/DeserializationPerfTest.java
===
--- src/java/test/org/apache/zookeeper/server/DeserializationPerfTest.java
(revision 1544262)
+++ src/java/test/org/apache/zookeeper/server/DeserializationPerfTest.java
(working copy)
@@ -40,7 +40,7 @@
int count;
{
DataTree tree = new DataTree();
-SerializationPerfTest.createNodes(tree, "/", depth,
tree.getNode("/").stat.getCversion(), width, new byte[len]);
+SerializationPerfTest.createNodes(tree, "/", depth, width,
tree.getNode("/").stat.getCversion(), new byte[len]);
count = tree.getNodeCount();
ByteArrayOutputStream baos = new ByteArrayOutputStream();
> DeserializationPerfTest calls
> --
>
> Key: ZOOKEEPER-1819
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1819
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
>Affects Versions: 3.5.0
>Reporter: Daniel Knightly
>Priority: Minor
> Fix For: 3.5.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The DeserializationPerfTest calls
> SerializationPerfTest.createNodes to create serialized nodes to deserialize.
> However 2 of the arguments, childcount and parentCVersion are switched in the
> call to the above method. This results in all tests unintentionally testing
> the same scenario.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Created] (ZOOKEEPER-1820) The artifact org.apache.zookeeper:zookeeper:pom:3.4.5 has no license specified.
mhd wrk created ZOOKEEPER-1820: -- Summary: The artifact org.apache.zookeeper:zookeeper:pom:3.4.5 has no license specified. Key: ZOOKEEPER-1820 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1820 Project: ZooKeeper Issue Type: Improvement Reporter: mhd wrk Priority: Minor We are using maven licensing pluging (org.linuxstuff.maven:licensing-maven-plugin) to check/enforce licensing requirements for our dependencies and noticed that zookeper doesn't include licensing terms in pom.xml which causes the plugin to report the above mentioned warning (see the summary). Is there any plan to add the license to pom.xml as well? -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1819) DeserializationPerfTest calls
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Knightly updated ZOOKEEPER-1819: --- Attachment: ZOOKEEPER-1819.patch > DeserializationPerfTest calls > -- > > Key: ZOOKEEPER-1819 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1819 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Daniel Knightly >Priority: Minor > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1819.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > The DeserializationPerfTest calls > SerializationPerfTest.createNodes to create serialized nodes to deserialize. > However 2 of the arguments, childcount and parentCVersion are switched in the > call to the above method. This results in all tests unintentionally testing > the same scenario. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1819) DeserializationPerfTest calls method with wrong arguments
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Knightly updated ZOOKEEPER-1819: --- Summary: DeserializationPerfTest calls method with wrong arguments (was: DeserializationPerfTest calls ) > DeserializationPerfTest calls method with wrong arguments > - > > Key: ZOOKEEPER-1819 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1819 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.5.0 >Reporter: Daniel Knightly >Priority: Minor > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1819.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > The DeserializationPerfTest calls > SerializationPerfTest.createNodes to create serialized nodes to deserialize. > However 2 of the arguments, childcount and parentCVersion are switched in the > call to the above method. This results in all tests unintentionally testing > the same scenario. -- This message was sent by Atlassian JIRA (v6.1#6144)
Failed: ZOOKEEPER-602 PreCommit Build #1796
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-602 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1796/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 292877 lines...] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12615139/ZOOKEEPER-602.patch [exec] against trunk revision 1543281. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1796//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1796//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1796//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 080d6fe928b0cf2861a51460b3e6c2a577cff1d8 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623: exec returned: 1 Total time: 33 minutes 1 second Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-602 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-1653) zookeeper fails to start because of inconsistent epoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829144#comment-13829144
]
Rakesh R commented on ZOOKEEPER-1653:
-
Good work [~michim]. I've just one comment.
In the patch, updating.createNewFile() api will return false and throws
IOException, when the QuorumPeer.UPDATING_EPOCH_FILENAME file already exists.
One possible case could be, say previously the system crashed before deleting
the file.
I think we should improve the check as follows:
{code}
if (!updating.exists() && !updating.createNewFile()) {
{code}
> zookeeper fails to start because of inconsistent epoch
> --
>
> Key: ZOOKEEPER-1653
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1653
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
>Affects Versions: 3.4.5
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Blocker
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1653.3.4.patch, ZOOKEEPER-1653.3.4.patch,
> ZOOKEEPER-1653.patch, ZOOKEEPER-1653.patch
>
>
> It looks like QuorumPeer.loadDataBase() could fail if the server was
> restarted after zk.takeSnapshot() but before finishing
> self.setCurrentEpoch(newEpoch) in Learner.java.
> {code:java}
> case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
> zk.takeSnapshot();
> self.setCurrentEpoch(newEpoch); // <<< got restarted here
> snapshotTaken = true;
> writePacket(new QuorumPacket(Leader.ACK, newLeaderZxid, null, null),
> true);
> break;
> {code}
> The server fails to start because currentEpoch is still 1 but the last
> processed zkid from the snapshot has been updated.
> {noformat}
> 2013-02-20 13:45:02,733 5543 [pool-1-thread-1] ERROR
> org.apache.zookeeper.server.quorum.QuorumPeer - Unable to load database on
> disk
> java.io.IOException: The current epoch, 1, is older than the last zxid,
> 8589934592
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:439)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:413)
> ...
> {noformat}
> {noformat}
> $ find datadir
> datadir
> datadir/version-2
> datadir/version-2/currentEpoch.tmp
> datadir/version-2/acceptedEpoch
> datadir/version-2/snapshot.0
> datadir/version-2/currentEpoch
> datadir/version-2/snapshot.2
> $ cat datadir/version-2/currentEpoch.tmp
> 2%
> $ cat datadir/version-2/acceptedEpoch
> 2%
> $ cat datadir/version-2/currentEpoch
> 1%
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
Failed: ZOOKEEPER-602 PreCommit Build #1797
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-602 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1797/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 297999 lines...] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12615143/ZOOKEEPER-602.patch [exec] against trunk revision 1543281. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1797//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1797//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1797//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 3ca3849abdfb1b02d19edb71dd0a9046932fa12c logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623: exec returned: 1 Total time: 28 minutes 24 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-602 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 1 tests failed. REGRESSION: org.apache.zookeeper.server.quorum.CommitProcessorTest.testNoCommitWorkers Error Message: null Stack Trace: junit.framework.AssertionFailedError at org.apache.zookeeper.server.quorum.CommitProcessorTest.testNoCommitWorkers(CommitProcessorTest.java:175)
[jira] [Updated] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-602: --- Attachment: ZOOKEEPER-602.patch > log all exceptions not caught by ZK threads > --- > > Key: ZOOKEEPER-602 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602 > Project: ZooKeeper > Issue Type: Bug > Components: java client, server >Affects Versions: 3.2.1 >Reporter: Patrick Hunt >Assignee: Rakesh R >Priority: Critical > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch > > > the java code should add a ThreadGroup exception handler that logs at ERROR > level any uncaught exceptions thrown by Thread run methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-602: --- Attachment: ZOOKEEPER-602.patch > log all exceptions not caught by ZK threads > --- > > Key: ZOOKEEPER-602 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602 > Project: ZooKeeper > Issue Type: Bug > Components: java client, server >Affects Versions: 3.2.1 >Reporter: Patrick Hunt >Assignee: Rakesh R >Priority: Critical > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch > > > the java code should add a ThreadGroup exception handler that logs at ERROR > level any uncaught exceptions thrown by Thread run methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829092#comment-13829092 ] Hadoop QA commented on ZOOKEEPER-602: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615143/ZOOKEEPER-602.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1797//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1797//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1797//console This message is automatically generated. > log all exceptions not caught by ZK threads > --- > > Key: ZOOKEEPER-602 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602 > Project: ZooKeeper > Issue Type: Bug > Components: java client, server >Affects Versions: 3.2.1 >Reporter: Patrick Hunt >Assignee: Rakesh R >Priority: Critical > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch > > > the java code should add a ThreadGroup exception handler that logs at ERROR > level any uncaught exceptions thrown by Thread run methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-602: --- Attachment: ZOOKEEPER-602.patch > log all exceptions not caught by ZK threads > --- > > Key: ZOOKEEPER-602 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602 > Project: ZooKeeper > Issue Type: Bug > Components: java client, server >Affects Versions: 3.2.1 >Reporter: Patrick Hunt >Priority: Critical > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch, ZOOKEEPER-602.patch > > > the java code should add a ThreadGroup exception handler that logs at ERROR > level any uncaught exceptions thrown by Thread run methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-602: --- Attachment: ZOOKEEPER-602.patch > log all exceptions not caught by ZK threads > --- > > Key: ZOOKEEPER-602 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602 > Project: ZooKeeper > Issue Type: Bug > Components: java client, server >Affects Versions: 3.2.1 >Reporter: Patrick Hunt >Priority: Critical > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch > > > the java code should add a ThreadGroup exception handler that logs at ERROR > level any uncaught exceptions thrown by Thread run methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
Success: ZOOKEEPER-602 PreCommit Build #1798
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-602 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1798/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 297974 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12615151/ZOOKEEPER-602.patch [exec] against trunk revision 1543281. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1798//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1798//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1798//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] fdf37b31e17dc85fee7714ff2f2ca085cb0096a4 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 32 minutes 46 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-602 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[
https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829232#comment-13829232
]
Raul Gutierrez Segales commented on ZOOKEEPER-602:
--
Two nits:
{noformat}
+class LearnerCnxAcceptor extends ZooKeeperThread{
{noformat}
space missing (ZooKeeperThread {)
Typo:
{noformat}
+// When there is no worker thread pool, do the work directly
+// and waiting for its completion
{noformat}
"and wait for its completion"
> log all exceptions not caught by ZK threads
> ---
>
> Key: ZOOKEEPER-602
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client, server
>Affects Versions: 3.2.1
>Reporter: Patrick Hunt
>Assignee: Rakesh R
>Priority: Critical
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch,
> ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch,
> ZOOKEEPER-602.patch
>
>
> the java code should add a ThreadGroup exception handler that logs at ERROR
> level any uncaught exceptions thrown by Thread run methods.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
Failed: ZOOKEEPER-1817 PreCommit Build #1794
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1794/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 84 lines...] [exec] Hunk #5 succeeded at 1626 (offset 424 lines). [exec] 4 out of 5 hunks FAILED -- saving rejects to file src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java.rej [exec] patching file src/java/main/org/apache/zookeeper/server/quorum/Vote.java [exec] Hunk #1 succeeded at 19 with fuzz 2. [exec] Hunk #2 FAILED at 128. [exec] 1 out of 2 hunks FAILED -- saving rejects to file src/java/main/org/apache/zookeeper/server/quorum/Vote.java.rej [exec] patching file src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java [exec] Hunk #1 FAILED at 20. [exec] 1 out of 1 hunk FAILED -- saving rejects to file src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java.rej [exec] patching file src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12615112/ZOOKEEPER-1817.patch [exec] against trunk revision 1543281. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1794//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] d9d8ca0f30f9dae97032e0dbd89d95e214f27a10 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623: exec returned: 1 Total time: 52 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1817 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829162#comment-13829162 ] Hadoop QA commented on ZOOKEEPER-602: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615151/ZOOKEEPER-602.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1798//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1798//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1798//console This message is automatically generated. > log all exceptions not caught by ZK threads > --- > > Key: ZOOKEEPER-602 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602 > Project: ZooKeeper > Issue Type: Bug > Components: java client, server >Affects Versions: 3.2.1 >Reporter: Patrick Hunt >Assignee: Rakesh R >Priority: Critical > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch > > > the java code should add a ThreadGroup exception handler that logs at ERROR > level any uncaught exceptions thrown by Thread run methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (ZOOKEEPER-1817) Fix don't care for b3.4
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Junqueira updated ZOOKEEPER-1817: Attachment: ZOOKEEPER-1817.patch Made some improvements on FLE and the test case, please make sure this is ok. > Fix don't care for b3.4 > --- > > Key: ZOOKEEPER-1817 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Flavio Junqueira >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.6 > > Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, > ZOOKEEPER-1817.patch, logs.tar.gz, logs2.tar.gz > > > See umbrella jira. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1430) add maven deploy support to the build
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829036#comment-13829036 ] Flavio Junqueira commented on ZOOKEEPER-1430: - [~gkesavan], I was wondering if there is any progress here. Thanks! > add maven deploy support to the build > - > > Key: ZOOKEEPER-1430 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1430 > Project: ZooKeeper > Issue Type: Task > Components: build >Affects Versions: 3.4.4, 3.5.0 >Reporter: Patrick Hunt >Assignee: Giridharan Kesavan >Priority: Blocker > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-1430-3.4.6-v4.patch, ZOOKEEPER-1430-3.4.patch, > ZOOKEEPER-1430-3.5.0-v4.patch, ZOOKEEPER-1430-V1.PATCH, > ZOOKEEPER-1430-V2.PATCH, ZOOKEEPER-1430-V3.patch, > ZOOKEEPER-1430-br34-V3.patch, ZOOKEEPER-1430.patch, ZOOKEEPER-1430.patch > > > Infra is phasing out the current mechanism we use to deploy maven artifacts. > We need to move to repository.apache.org (nexus). > In particular we need to ensure the following artifacts get published: > * zookeeper-3.x.y.jar > * zookeeper-3.x.y-sources.jar > * zookeeper-3.x.y-tests.jar > * zookeeper-3.x.y-javadoc.jar > In 3.4.4/3.4.5 we missed the tests jar which caused headaches for downstream > users, such as Hadoop. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1653) zookeeper fails to start because of inconsistent epoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829642#comment-13829642
]
Rakesh R commented on ZOOKEEPER-1653:
-
Hi vinay,
In the patch I could see a conditional deletion of 'UpdatingEpoch' file. Here
it will delete this file only when the following condition satifies. I was
thinking about a case, where the condition is not satified, now the file will
not be deleted and will affect the flow which I mentioned earlier. IMHO, it is
safe to have 'updating.exists()' check.
{code}
+if (epochOfZxid > currentEpoch && updating.exists()) {
//
+if (!updating.delete()) {
+throw new IOException("Failed to delete " +
+ updating.toString());
+}
+}
{code}
> zookeeper fails to start because of inconsistent epoch
> --
>
> Key: ZOOKEEPER-1653
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1653
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
>Affects Versions: 3.4.5
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Blocker
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1653.3.4.patch, ZOOKEEPER-1653.3.4.patch,
> ZOOKEEPER-1653.patch, ZOOKEEPER-1653.patch
>
>
> It looks like QuorumPeer.loadDataBase() could fail if the server was
> restarted after zk.takeSnapshot() but before finishing
> self.setCurrentEpoch(newEpoch) in Learner.java.
> {code:java}
> case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
> zk.takeSnapshot();
> self.setCurrentEpoch(newEpoch); // <<< got restarted here
> snapshotTaken = true;
> writePacket(new QuorumPacket(Leader.ACK, newLeaderZxid, null, null),
> true);
> break;
> {code}
> The server fails to start because currentEpoch is still 1 but the last
> processed zkid from the snapshot has been updated.
> {noformat}
> 2013-02-20 13:45:02,733 5543 [pool-1-thread-1] ERROR
> org.apache.zookeeper.server.quorum.QuorumPeer - Unable to load database on
> disk
> java.io.IOException: The current epoch, 1, is older than the last zxid,
> 8589934592
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:439)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:413)
> ...
> {noformat}
> {noformat}
> $ find datadir
> datadir
> datadir/version-2
> datadir/version-2/currentEpoch.tmp
> datadir/version-2/acceptedEpoch
> datadir/version-2/snapshot.0
> datadir/version-2/currentEpoch
> datadir/version-2/snapshot.2
> $ cat datadir/version-2/currentEpoch.tmp
> 2%
> $ cat datadir/version-2/acceptedEpoch
> 2%
> $ cat datadir/version-2/currentEpoch
> 1%
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1653) zookeeper fails to start because of inconsistent epoch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829648#comment-13829648
]
Vinay commented on ZOOKEEPER-1653:
--
Oh!! Yes. You are correct I missed it. If server crashes just after
{{self.setCurrentEpoch(newEpoch);}} then that is very much possible.
> zookeeper fails to start because of inconsistent epoch
> --
>
> Key: ZOOKEEPER-1653
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1653
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
>Affects Versions: 3.4.5
>Reporter: Michi Mutsuzaki
>Assignee: Michi Mutsuzaki
>Priority: Blocker
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1653.3.4.patch, ZOOKEEPER-1653.3.4.patch,
> ZOOKEEPER-1653.patch, ZOOKEEPER-1653.patch
>
>
> It looks like QuorumPeer.loadDataBase() could fail if the server was
> restarted after zk.takeSnapshot() but before finishing
> self.setCurrentEpoch(newEpoch) in Learner.java.
> {code:java}
> case Leader.NEWLEADER: // it will be NEWLEADER in v1.0
> zk.takeSnapshot();
> self.setCurrentEpoch(newEpoch); // <<< got restarted here
> snapshotTaken = true;
> writePacket(new QuorumPacket(Leader.ACK, newLeaderZxid, null, null),
> true);
> break;
> {code}
> The server fails to start because currentEpoch is still 1 but the last
> processed zkid from the snapshot has been updated.
> {noformat}
> 2013-02-20 13:45:02,733 5543 [pool-1-thread-1] ERROR
> org.apache.zookeeper.server.quorum.QuorumPeer - Unable to load database on
> disk
> java.io.IOException: The current epoch, 1, is older than the last zxid,
> 8589934592
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:439)
> at
> org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:413)
> ...
> {noformat}
> {noformat}
> $ find datadir
> datadir
> datadir/version-2
> datadir/version-2/currentEpoch.tmp
> datadir/version-2/acceptedEpoch
> datadir/version-2/snapshot.0
> datadir/version-2/currentEpoch
> datadir/version-2/snapshot.2
> $ cat datadir/version-2/currentEpoch.tmp
> 2%
> $ cat datadir/version-2/acceptedEpoch
> 2%
> $ cat datadir/version-2/currentEpoch
> 1%
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Updated] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-602: --- Attachment: ZOOKEEPER-602.patch > log all exceptions not caught by ZK threads > --- > > Key: ZOOKEEPER-602 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602 > Project: ZooKeeper > Issue Type: Bug > Components: java client, server >Affects Versions: 3.2.1 >Reporter: Patrick Hunt >Assignee: Rakesh R >Priority: Critical > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch, ZOOKEEPER-602.patch > > > the java code should add a ThreadGroup exception handler that logs at ERROR > level any uncaught exceptions thrown by Thread run methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829728#comment-13829728 ] Hadoop QA commented on ZOOKEEPER-602: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12615275/ZOOKEEPER-602.patch against trunk revision 1543281. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1799//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1799//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1799//console This message is automatically generated. > log all exceptions not caught by ZK threads > --- > > Key: ZOOKEEPER-602 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602 > Project: ZooKeeper > Issue Type: Bug > Components: java client, server >Affects Versions: 3.2.1 >Reporter: Patrick Hunt >Assignee: Rakesh R >Priority: Critical > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch, ZOOKEEPER-602.patch > > > the java code should add a ThreadGroup exception handler that logs at ERROR > level any uncaught exceptions thrown by Thread run methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
Success: ZOOKEEPER-602 PreCommit Build #1799
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-602 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1799/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 222360 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12615275/ZOOKEEPER-602.patch [exec] against trunk revision 1543281. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1799//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1799//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1799//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 8849b941f43dcc038bdd41819da48facecfcbc0f logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 34 minutes 34 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-602 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829735#comment-13829735 ] Rakesh R commented on ZOOKEEPER-602: Thank you [~rgs] for the review. Attached latest patch addressing the comments. > log all exceptions not caught by ZK threads > --- > > Key: ZOOKEEPER-602 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602 > Project: ZooKeeper > Issue Type: Bug > Components: java client, server >Affects Versions: 3.2.1 >Reporter: Patrick Hunt >Assignee: Rakesh R >Priority: Critical > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, > ZOOKEEPER-602.patch, ZOOKEEPER-602.patch > > > the java code should add a ThreadGroup exception handler that logs at ERROR > level any uncaught exceptions thrown by Thread run methods. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) "make check" doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829739#comment-13829739 ] Benjamin Reed commented on ZOOKEEPER-1742: -- this still fails for me on my mac. i think the time mocking doesn't seem to be working properly. > "make check" doesn't work on macos > -- > > Key: ZOOKEEPER-1742 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.4.5, 3.5.0 >Reporter: Flavio Junqueira >Assignee: Germán Blanco > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, > ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, > ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, > ZOOKEEPER-1742.patch > > > There are two problems I have spotted when running "make check" with the C > client. First, it complains that the sleep call is not defined in two test > files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. > Including unistd.h works. The second problem is with linker options. It > complains that "--wrap" is not a valid. I'm not sure how to deal with this > one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1817) Fix don't care for b3.4
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829741#comment-13829741
]
Germán Blanco commented on ZOOKEEPER-1817:
--
This works very well and it looks excellent overall.
However, I am starting to have doubts about this comparison in Vote.java:
{noformat}
+if (version == other.version) {
+return (id == other.id
+&& peerEpoch == other.peerEpoch);
+} else {
+return id == other.id;
+}
{noformat}
We know 3.4.5 peerEpoch has a different value than in the rest. But the
difference is there only for 3.4.5. I think this comparison should be a bit
different, and more in line with the use of backwards compatibility vote in
FastLeaderElection.java ...
{noformat}
ToSend notmsg;
if(n.version > 0x0) {
notmsg = new ToSend(
{noformat}
that would be "if one of the versions is 0x0 and the other is not, then don't
use peerEpoch. Otherwise use it" ...
{noformat}
+if ((version > 0x0) ^ (other.version > 0x0)) {
+return id == other.id;
+} else {
+return (id == other.id
+&& peerEpoch == other.peerEpoch);
+}
{noformat}
> Fix don't care for b3.4
> ---
>
> Key: ZOOKEEPER-1817
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1817
> Project: ZooKeeper
> Issue Type: Sub-task
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>Priority: Blocker
> Fix For: 3.4.6
>
> Attachments: ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch, ZOOKEEPER-1817.patch,
> ZOOKEEPER-1817.patch, logs.tar.gz, logs2.tar.gz
>
>
> See umbrella jira.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1742) "make check" doesn't work on macos
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829755#comment-13829755 ] Germán Blanco commented on ZOOKEEPER-1742: -- Hello [~breed], thank you very much for testing! It also fails for me on mac, even though it works in Ubuntu, but it is very difficult for me to find the origin of the problem. Could you please give me a few more details on this "time mocking" problem? Which function or module is it where there is time mocking involved? > "make check" doesn't work on macos > -- > > Key: ZOOKEEPER-1742 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.4.5, 3.5.0 >Reporter: Flavio Junqueira >Assignee: Germán Blanco > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, > ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch, > ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, ZOOKEEPER-1742.patch, > ZOOKEEPER-1742.patch > > > There are two problems I have spotted when running "make check" with the C > client. First, it complains that the sleep call is not defined in two test > files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. > Including unistd.h works. The second problem is with linker options. It > complains that "--wrap" is not a valid. I'm not sure how to deal with this > one yet, since I'm not sure why we are using it. -- This message was sent by Atlassian JIRA (v6.1#6144)
ZooKeeper_branch34_solaris - Build # 716 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch34_solaris/716/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 159087 lines...] [junit] 2013-11-22 07:56:17,937 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-11-22 07:56:17,937 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-11-22 07:56:17,937 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-11-22 07:56:17,937 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-22 07:56:17,938 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-11-22 07:56:17,938 [myid:] - INFO [main:ZooKeeperServer@441] - shutting down [junit] 2013-11-22 07:56:17,938 [myid:] - INFO [main:SessionTrackerImpl@225] - Shutting down [junit] 2013-11-22 07:56:17,938 [myid:] - INFO [main:PrepRequestProcessor@761] - Shutting down [junit] 2013-11-22 07:56:17,939 [myid:] - INFO [main:SyncRequestProcessor@209] - Shutting down [junit] 2013-11-22 07:56:17,939 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop! [junit] 2013-11-22 07:56:17,939 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@187] - SyncRequestProcessor exited! [junit] 2013-11-22 07:56:17,939 [myid:] - INFO [main:FinalRequestProcessor@415] - shutdown of request processor complete [junit] 2013-11-22 07:56:17,939 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-22 07:56:17,940 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[] [junit] 2013-11-22 07:56:17,941 [myid:] - INFO [main:ClientBase@414] - STARTING server [junit] 2013-11-22 07:56:17,941 [myid:] - INFO [main:ZooKeeperServer@162] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/trunk/build/test/tmp/test1478889443199103854.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch34_solaris/trunk/build/test/tmp/test1478889443199103854.junit.dir/version-2 [junit] 2013-11-22 07:56:17,941 [myid:] - INFO [main:NIOServerCnxnFactory@94] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-11-22 07:56:17,944 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-11-22 07:56:17,944 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@197] - Accepted socket connection from /127.0.0.1:49607 [junit] 2013-11-22 07:56:17,944 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@817] - Processing stat command from /127.0.0.1:49607 [junit] 2013-11-22 07:56:17,945 [myid:] - INFO [Thread-5:NIOServerCnxn$StatCommand@653] - Stat command output [junit] 2013-11-22 07:56:17,945 [myid:] - INFO [Thread-5:NIOServerCnxn@997] - Closed socket connection for client /127.0.0.1:49607 (no session established for client) [junit] 2013-11-22 07:56:17,945 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-11-22 07:56:17,946 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-11-22 07:56:17,946 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-11-22 07:56:17,946 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-11-22 07:56:17,946 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-11-22 07:56:17,947 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota [junit] 2013-11-22 07:56:17,947 [myid:] - INFO [main:ClientBase@451] - tearDown starting [junit] 2013-11-22 07:56:18,001 [myid:] - INFO [SessionTracker:SessionTrackerImpl@162] - SessionTrackerImpl exited loop! [junit] 2013-11-22 07:56:18,001 [myid:] - INFO [SessionTracker:SessionTrackerImpl@162] - SessionTrackerImpl exited loop! [junit] 2013-11-22 07:56:18,032 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@509] - EventThread shut down [junit] 2013-11-22 07:56:18,032 [myid:] - INFO [main:ZooKeeper@684] - Session: 0x1427ecf3402 closed [junit] 2013-11-22 07:56:18,033 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-11-22 07:56:18,033 [myid:] - INFO [main:ZooKeeperServer@441] - shutting down [junit] 2013-11-22 07:56:18,034 [myid:] - INFO [main:SessionTrackerImpl@225] -
