[jira] [Commented] (ZOOKEEPER-2110) Tyop fixes in the ZK documentation

2015-01-26 Thread Rakesh R (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14293063#comment-14293063
 ] 

Rakesh R commented on ZOOKEEPER-2110:
-

Thanks [~SEJeff] for the patch.

small typo: Can you change {{the responsability}} to {{the responsibility}}.

Apart from this +1

> Tyop fixes in the ZK documentation
> --
>
> Key: ZOOKEEPER-2110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2110
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.5.0
>Reporter: Jeffrey Schroeder
>Priority: Minor
> Attachments: ZOOKEEPER-2110.patch
>
>
> So as part of building an Aurora cluster ontop of Mesos, I wanted to learn 
> ZK. I spent an evening reading much of the ZK documentation and noticed many 
> grammatical or spelling errors. Being a good OSS citizen, I've went through 
> the effort to fix them and create a patch fixing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2110) Tyop fixes in the ZK documentation

2015-01-26 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292983#comment-14292983
 ] 

Hadoop QA commented on ZOOKEEPER-2110:
--

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12694702/ZOOKEEPER-2110.patch
  against trunk revision 1654608.

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2489//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2489//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2489//console

This message is automatically generated.

> Tyop fixes in the ZK documentation
> --
>
> Key: ZOOKEEPER-2110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2110
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.5.0
>Reporter: Jeffrey Schroeder
>Priority: Minor
> Attachments: ZOOKEEPER-2110.patch
>
>
> So as part of building an Aurora cluster ontop of Mesos, I wanted to learn 
> ZK. I spent an evening reading much of the ZK documentation and noticed many 
> grammatical or spelling errors. Being a good OSS citizen, I've went through 
> the effort to fix them and create a patch fixing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Success: ZOOKEEPER-2110 PreCommit Build #2489

2015-01-26 Thread Apache Jenkins Server 
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2110
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2489/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 348619 lines...]
 [exec] +1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12694702/ZOOKEEPER-2110.patch
 [exec]   against trunk revision 1654608.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2489//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2489//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2489//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 237595807d78e6a85a7a629fea4bf33c4e85df11 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 50 minutes 26 seconds
Archiving artifacts
Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2486
Archived 24 artifacts
Archive block size is 32768
Received 7 blocks and 33553045 bytes
Compression is 0.7%
Took 7.9 sec
Recording test results
Description set: ZOOKEEPER-2110
Email was triggered for: Success
Sending email for trigger: Success



###
## FAILED TESTS (if any) 
##
All tests passed

Re: Questions about my first contribution to ZK

2015-01-26 Thread Jeff Schroeder 
Perfect, see: https://issues.apache.org/jira/browse/ZOOKEEPER-2110

On Mon, Jan 26, 2015 at 11:04 AM, Hongchao Deng 
wrote:

> It's automatically built.
>
> - Hongchao Deng
>
>

-- 
Jeff Schroeder

Don't drink and derive, alcohol and analysis don't mix.
http://www.digitalprognosis.com

[jira] [Updated] (ZOOKEEPER-2110) Tyop fixes in the ZK documentation

2015-01-26 Thread Jeffrey Schroeder (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeffrey Schroeder updated ZOOKEEPER-2110:
-
Description: So as part of building an Aurora cluster ontop of Mesos, I 
wanted to learn ZK. I spent an evening reading much of the ZK documentation and 
noticed many grammatical or spelling errors. Being a good OSS citizen, I've 
went through the effort to fix them and create a patch fixing it.  (was: So as 
part of building an Aurora cluster ontop of Mesos, I wanted to learn ZK. I 
spent an evening reading much of the ZK documentation and notices many 
grammatical or spelling errors. Being a good OSS citizen, I've went through the 
effort to fix them and create a patch fixing it.)

> Tyop fixes in the ZK documentation
> --
>
> Key: ZOOKEEPER-2110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2110
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.5.0
>Reporter: Jeffrey Schroeder
>Priority: Minor
> Attachments: ZOOKEEPER-2110.patch
>
>
> So as part of building an Aurora cluster ontop of Mesos, I wanted to learn 
> ZK. I spent an evening reading much of the ZK documentation and noticed many 
> grammatical or spelling errors. Being a good OSS citizen, I've went through 
> the effort to fix them and create a patch fixing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2110) Tyop fixes in the ZK documentation

2015-01-26 Thread Jeffrey Schroeder (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeffrey Schroeder updated ZOOKEEPER-2110:
-
Attachment: ZOOKEEPER-2110.patch

Documentation grammatical and spelling tyop fixes.

> Tyop fixes in the ZK documentation
> --
>
> Key: ZOOKEEPER-2110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2110
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.5.0
>Reporter: Jeffrey Schroeder
>Priority: Minor
> Attachments: ZOOKEEPER-2110.patch
>
>
> So as part of building an Aurora cluster ontop of Mesos, I wanted to learn 
> ZK. I spent an evening reading much of the ZK documentation and notices many 
> grammatical or spelling errors. Being a good OSS citizen, I've went through 
> the effort to fix them and create a patch fixing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2110) Tyop fixes in the ZK documentation

2015-01-26 Thread Jeffrey Schroeder (JIRA) 
Jeffrey Schroeder created ZOOKEEPER-2110:


 Summary: Tyop fixes in the ZK documentation
 Key: ZOOKEEPER-2110
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2110
 Project: ZooKeeper
  Issue Type: Improvement
  Components: documentation
Reporter: Jeffrey Schroeder
Priority: Minor


So as part of building an Aurora cluster ontop of Mesos, I wanted to learn ZK. 
I spent an evening reading much of the ZK documentation and notices many 
grammatical or spelling errors. Being a good OSS citizen, I've went through the 
effort to fix them and create a patch fixing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-01-26 Thread Rakesh R 


> On Jan. 26, 2015, 5:32 p.m., Hongchao Deng wrote:
> > ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line 
> > 159
> > 
> >
> > Is there any race in listener between run() and shutdown()? Maybe some 
> > comments?
> 
> Rakesh R wrote:
> yes. I missed that part. How about making listener as 'volatile' ?
> 
> Hongchao Deng wrote:
> It's a problem called time-to-check-time-to-use.
> 
> Rakesh R wrote:
> Then will move the notification inside exception-handling block of each 
> thread. I'm just trying to avoid extra synchronized block. agree?

Adding one more point to the above. My intention to make listener=null is, the 
listener should not be invoked when the thread stops execution 
gracefully(through #shutdown call).


- Rakesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review69622
---


On Jan. 26, 2015, 2:12 p.m., Rakesh R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20071/
> ---
> 
> (Updated Jan. 26, 2015, 2:12 p.m.)
> 
> 
> Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille 
> Fournier.
> 
> 
> Bugs: ZOOKEEPER-1907
> https://issues.apache.org/jira/browse/ZOOKEEPER-1907
> 
> 
> Repository: zookeeper
> 
> 
> Description
> ---
> 
> Improve the thread handling mechanism by detecting if any of the critical 
> thread dies.
> Here the idea is to periodically checking the status of all the critical 
> threads in ZK server using DeathWatcherThread.
> 
> 
> Diffs
> -
> 
>   ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 
> 1654804 
>   ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1654804 
>   ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 
> 1654804 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1654804 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java 
> PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java
>  1654804 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java
>  1654804 
>   ./src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 
> 1654804 
>   ./src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java 1654804 
>   
> ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
>  1654804 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 
> 1654804 
>   ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1654804 
>   ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 
> 1654804 
> 
> Diff: https://reviews.apache.org/r/20071/diff/
> 
> 
> Testing
> ---
> 
> yet to be inlcuded
> 
> 
> Thanks,
> 
> Rakesh R
> 
>

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-01-26 Thread Rakesh R 


> On Jan. 26, 2015, 5:32 p.m., Hongchao Deng wrote:
> > ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line 
> > 159
> > 
> >
> > Is there any race in listener between run() and shutdown()? Maybe some 
> > comments?
> 
> Rakesh R wrote:
> yes. I missed that part. How about making listener as 'volatile' ?
> 
> Hongchao Deng wrote:
> It's a problem called time-to-check-time-to-use.

Then will move the notification inside exception-handling block of each thread. 
I'm just trying to avoid extra synchronized block. agree?


- Rakesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review69622
---


On Jan. 26, 2015, 2:12 p.m., Rakesh R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20071/
> ---
> 
> (Updated Jan. 26, 2015, 2:12 p.m.)
> 
> 
> Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille 
> Fournier.
> 
> 
> Bugs: ZOOKEEPER-1907
> https://issues.apache.org/jira/browse/ZOOKEEPER-1907
> 
> 
> Repository: zookeeper
> 
> 
> Description
> ---
> 
> Improve the thread handling mechanism by detecting if any of the critical 
> thread dies.
> Here the idea is to periodically checking the status of all the critical 
> threads in ZK server using DeathWatcherThread.
> 
> 
> Diffs
> -
> 
>   ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 
> 1654804 
>   ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1654804 
>   ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 
> 1654804 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1654804 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java 
> PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java
>  1654804 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java
>  1654804 
>   ./src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 
> 1654804 
>   ./src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java 1654804 
>   
> ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
>  1654804 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 
> 1654804 
>   ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1654804 
>   ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 
> 1654804 
> 
> Diff: https://reviews.apache.org/r/20071/diff/
> 
> 
> Testing
> ---
> 
> yet to be inlcuded
> 
> 
> Thanks,
> 
> Rakesh R
> 
>

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-01-26 Thread Hongchao Deng 


> On Jan. 26, 2015, 5:32 p.m., Hongchao Deng wrote:
> > ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line 
> > 159
> > 
> >
> > Is there any race in listener between run() and shutdown()? Maybe some 
> > comments?
> 
> Rakesh R wrote:
> yes. I missed that part. How about making listener as 'volatile' ?

It's a problem called time-to-check-time-to-use.


- Hongchao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review69622
---


On Jan. 26, 2015, 2:12 p.m., Rakesh R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20071/
> ---
> 
> (Updated Jan. 26, 2015, 2:12 p.m.)
> 
> 
> Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille 
> Fournier.
> 
> 
> Bugs: ZOOKEEPER-1907
> https://issues.apache.org/jira/browse/ZOOKEEPER-1907
> 
> 
> Repository: zookeeper
> 
> 
> Description
> ---
> 
> Improve the thread handling mechanism by detecting if any of the critical 
> thread dies.
> Here the idea is to periodically checking the status of all the critical 
> threads in ZK server using DeathWatcherThread.
> 
> 
> Diffs
> -
> 
>   ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 
> 1654804 
>   ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1654804 
>   ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 
> 1654804 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1654804 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java 
> PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java
>  1654804 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java
>  1654804 
>   ./src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 
> 1654804 
>   ./src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java 1654804 
>   
> ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
>  1654804 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 
> 1654804 
>   ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1654804 
>   ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 
> 1654804 
> 
> Diff: https://reviews.apache.org/r/20071/diff/
> 
> 
> Testing
> ---
> 
> yet to be inlcuded
> 
> 
> Thanks,
> 
> Rakesh R
> 
>

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-01-26 Thread Rakesh R 


> On Jan. 26, 2015, 5:32 p.m., Hongchao Deng wrote:
> > ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line 
> > 159
> > 
> >
> > Is there any race in listener between run() and shutdown()? Maybe some 
> > comments?

yes. I missed that part. How about making listener as 'volatile' ?


> On Jan. 26, 2015, 5:32 p.m., Hongchao Deng wrote:
> > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 430
> > 
> >
> > This should be a singleton, right?

yes, I will make it singleton.


> On Jan. 26, 2015, 5:32 p.m., Hongchao Deng wrote:
> > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java, 
> > line 33
> > 
> >
> > unexpectedError -> errorCode

ok


- Rakesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review69622
---


On Jan. 26, 2015, 2:12 p.m., Rakesh R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20071/
> ---
> 
> (Updated Jan. 26, 2015, 2:12 p.m.)
> 
> 
> Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille 
> Fournier.
> 
> 
> Bugs: ZOOKEEPER-1907
> https://issues.apache.org/jira/browse/ZOOKEEPER-1907
> 
> 
> Repository: zookeeper
> 
> 
> Description
> ---
> 
> Improve the thread handling mechanism by detecting if any of the critical 
> thread dies.
> Here the idea is to periodically checking the status of all the critical 
> threads in ZK server using DeathWatcherThread.
> 
> 
> Diffs
> -
> 
>   ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 
> 1654804 
>   ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1654804 
>   ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 
> 1654804 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1654804 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java 
> PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java
>  1654804 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java
>  1654804 
>   ./src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 
> 1654804 
>   ./src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java 1654804 
>   
> ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
>  1654804 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 
> 1654804 
>   ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1654804 
>   ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 
> 1654804 
> 
> Diff: https://reviews.apache.org/r/20071/diff/
> 
> 
> Testing
> ---
> 
> yet to be inlcuded
> 
> 
> Thanks,
> 
> Rakesh R
> 
>

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-01-26 Thread Hongchao Deng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/#review69622
---



./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java


Is there any race in listener between run() and shutdown()? Maybe some 
comments?



./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java


This should be a singleton, right?



./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java


unexpectedError -> errorCode


- Hongchao Deng


On Jan. 26, 2015, 2:12 p.m., Rakesh R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20071/
> ---
> 
> (Updated Jan. 26, 2015, 2:12 p.m.)
> 
> 
> Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille 
> Fournier.
> 
> 
> Bugs: ZOOKEEPER-1907
> https://issues.apache.org/jira/browse/ZOOKEEPER-1907
> 
> 
> Repository: zookeeper
> 
> 
> Description
> ---
> 
> Improve the thread handling mechanism by detecting if any of the critical 
> thread dies.
> Here the idea is to periodically checking the status of all the critical 
> threads in ZK server using DeathWatcherThread.
> 
> 
> Diffs
> -
> 
>   ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 
> 1654804 
>   ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1654804 
>   ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 
> 1654804 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1654804 
>   ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java 
> PRE-CREATION 
>   ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java
>  1654804 
>   ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 
> 1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java
>  1654804 
>   
> ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java
>  1654804 
>   ./src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 
> 1654804 
>   ./src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java 1654804 
>   
> ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
>  1654804 
>   ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 
> 1654804 
>   ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1654804 
>   ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 
> 1654804 
> 
> Diff: https://reviews.apache.org/r/20071/diff/
> 
> 
> Testing
> ---
> 
> yet to be inlcuded
> 
> 
> Thanks,
> 
> Rakesh R
> 
>

RE: Questions about my first contribution to ZK

2015-01-26 Thread Hongchao Deng 
It's automatically built.

- Hongchao Deng

> Date: Sun, 25 Jan 2015 23:40:33 -0600
> Subject: Re: Questions about my first contribution to ZK
> From: jeffschroe...@computer.org
> To: dev@zookeeper.apache.org
> 
> Right, as you can see in the diffstat, I modified those. What I'm asking is
> if a contribution patch I attach to a Jira issue should also include
> changes to the rendered html or if you have something that automatically
> builds those and checks them into svn.
> 
> Thanks for the pointers however!
> 
> On Sunday, January 25, 2015, Hongchao Deng  wrote:
> 
> > docs/ are generated docs.You might need to modify the files under
> > src/docs/src/documentation/content/xdocs/
> > See:
> > https://github.com/apache/zookeeper/tree/53b5aaf3cc942706c64e6d271ebbd76d7e5f7428/src/docs/src/documentation/content/xdocs
> >
> > - Hongchao Deng
> >
> > > Date: Sun, 25 Jan 2015 20:29:00 -0600
> > > Subject: Questions about my first contribution to ZK
> > > From: jeffschroe...@computer.org 
> > > To: dev@zookeeper.apache.org 
> > >
> > > Hi,
> > >
> > > So since I'm a few weeks out from starting on building a largish Mesos /
> > > Aurora cluster, I figured it made sense to read the ZK docs. I read
> > through
> > > all of the documentation linked on the homepages that exists under docs/
> > in
> > > the source tree and found a decent number of tyops or grammatical errors.
> > > I've fixed them and would like to contribute it back:
> > >
> > > $ svn diff | diffstat
> > >  recipes.xml|2 +-
> > >  releasenotes.xml   |2 +-
> > >  zookeeperAdmin.xml |2 +-
> > >  zookeeperInternals.xml |2 +-
> > >  zookeeperObservers.xml |2 +-
> > >  zookeeperOver.xml  |   10 +-
> > >  zookeeperTutorial.xml  |6 +++---
> > >  7 files changed, 13 insertions(+), 13 deletions(-)
> > >
> > > I noticed that the actual source is under src/docs/documentation... and
> > the
> > > rendered docs, both html and pdf, are under docs. So... As part of my
> > > contribution to update the source xml docs, do you expect me to send the
> > > rendered html and pdf files along with the same patch?
> > >
> > > Coming from projects like graphite[1] or salt[2], both of which I'm a
> > > co-maintainer of, we only keep the actual source documents in version
> > > control and have post-commit hooks build / render the documentation
> > > artifacts.
> > >
> > > [1] https://github.com/graphite-project -
> > > http://graphite.readthedocs.org/en/latest
> > > [2] https://github.com/saltstack/salt -
> > > http://salt.readthedocs.org/en/latest
> > >
> > >
> > > --
> > > Jeff Schroeder
> > >
> > > Don't drink and derive, alcohol and analysis don't mix.
> > > http://www.digitalprognosis.com
> >
> 
> 
> 
> -- 
> Text by Jeff, typos by iPhone

[jira] [Commented] (ZOOKEEPER-1907) Improve Thread handling

2015-01-26 Thread Rakesh R (JIRA) 

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291863#comment-14291863
 ] 

Rakesh R commented on ZOOKEEPER-1907:
-

Updated review ticket https://reviews.apache.org/r/20071 with new patch. 
Appreciate any comments. Thanks!

> Improve Thread handling
> ---
>
> Key: ZOOKEEPER-1907
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1907
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Rakesh R
>Assignee: Rakesh R
> Fix For: 3.5.1
>
> Attachments: ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, 
> ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, 
> ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch, ZOOKEEPER-1907.patch
>
>
> Server has many critical threads running and co-ordinating each other like  
> RequestProcessor chains et. When going through each threads, most of them 
> having the similar structure like:
> {code}
> public void run() {
> try {
>   while(running)
>// processing logic
>   }
> } catch (InterruptedException e) {
> LOG.error("Unexpected interruption", e);
> } catch (Exception e) {
> LOG.error("Unexpected exception", e);
> }
> LOG.info("...exited loop!");
> }
> {code}
> From the design I could see, there could be a chance of silently leaving the 
> thread by swallowing the exception. If this happens in the production, the 
> server would get hanged forever and would not be able to deliver its role. 
> Now its hard for the management tool to detect this.
> The idea of this JIRA is to discuss and imprv.
> Reference: [Community discussion 
> thread|http://mail-archives.apache.org/mod_mbox/zookeeper-user/201403.mbox/%3cc2496325850aa74c92aaf83aa9662d26458a1...@szxeml561-mbx.china.huawei.com%3E]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 20071: ZOOKEEPER-1907]-mprove the thread handling by detecting if any of the critical thread dies.

2015-01-26 Thread Rakesh R 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/
---

(Updated Jan. 26, 2015, 2:12 p.m.)


Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille 
Fournier.


Changes
---

Attached new patch where I've tried another better approach. Introduced 
ZooKeeperServerListener - will notify the critical resource(thread) failures 
and act upon. Appreciate any comments. Thanks!


Bugs: ZOOKEEPER-1907
https://issues.apache.org/jira/browse/ZOOKEEPER-1907


Repository: zookeeper


Description
---

Improve the thread handling mechanism by detecting if any of the critical 
thread dies.
Here the idea is to periodically checking the status of all the critical 
threads in ZK server using DeathWatcherThread.


Diffs (updated)
-

  ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION 
  ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1654804 
  ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1654804 
  ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 1654804 
  ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1654804 
  ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java 
PRE-CREATION 
  ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 
1654804 
  
./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
 1654804 
  
./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 
1654804 
  ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java 
1654804 
  ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 
1654804 
  ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java 
1654804 
  
./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java 
1654804 
  ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java 
1654804 
  
./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
 1654804 
  
./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java 
1654804 
  
./src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
 1654804 
  
./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
 1654804 
  
./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java 
1654804 
  
./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java
 1654804 
  ./src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 
1654804 
  ./src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java 1654804 
  
./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
 1654804 
  ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 
1654804 
  ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1654804 
  ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java 
1654804 

Diff: https://reviews.apache.org/r/20071/diff/


Testing
---

yet to be inlcuded


Thanks,

Rakesh R

[jira] [Created] (ZOOKEEPER-2109) Typo in src/c/src/load_gen.c

2015-01-26 Thread Emmanuel Bourg (JIRA) 
Emmanuel Bourg created ZOOKEEPER-2109:
-

 Summary: Typo in src/c/src/load_gen.c
 Key: ZOOKEEPER-2109
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2109
 Project: ZooKeeper
  Issue Type: Bug
Reporter: Emmanuel Bourg
Priority: Trivial


There is a minor typo in {{src/c/src/load_gen.c}}, "Succesfully" should be 
spelled "Successfully"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2108) Compilation error in ZkAdaptor.cc with GCC 4.7 or later

2015-01-26 Thread Emmanuel Bourg (JIRA) 
Emmanuel Bourg created ZOOKEEPER-2108:
-

 Summary: Compilation error in ZkAdaptor.cc with GCC 4.7 or later
 Key: ZOOKEEPER-2108
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2108
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.6
Reporter: Emmanuel Bourg
Priority: Minor


Hi,

Debian and Fedora have a patch fixing a compilation failure in ZkAdaptor.cc but 
it doesn't appear to be fixed in the upcoming version 3.5.0. This issue is 
similar to ZOOKEEPER-470 and ZOOKEEPER-1795.

The error is :
{code}
g++ -DHAVE_CONFIG_H -I. -I..   -D_FORTIFY_SOURCE=2 
-I/home/ebourg/packaging/zookeeper/src/contrib/zktreeutil/../../c/include 
-I/home/ebourg/packaging/zookeeper/src/contrib/zktreeutil/../../c/generated 
-I../include -I/usr/local/include -I/usr/include -I/usr/include/libxml2 -g -O2 
-fstack-protector-strong -Wformat -Werror=format-security -MT ZkAdaptor.o -MD 
-MP -MF .deps/ZkAdaptor.Tpo -c -o ZkAdaptor.o ZkAdaptor.cc
ZkAdaptor.cc: In member function ‘void 
zktreeutil::ZooKeeperAdapter::reconnect()’:
ZkAdaptor.cc:220:21: error: ‘sleep’ was not declared in this scope
 sleep (1);
{code}

This is fixed by including unistd.h in ZkAdaptor.cc or  ZkAdaptor.h

The Debian patch:
https://sources.debian.net/src/zookeeper/3.4.5%2Bdfsg-2/debian/patches/ftbfs-gcc-4.7.diff/

and the Fedora patch:
http://pkgs.fedoraproject.org/cgit/zookeeper.git/tree/zookeeper-3.4.5-zktreeutil-gcc.patch




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch35_jdk7 - Build # 184 - Failure

2015-01-26 Thread Apache Jenkins Server 
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/184/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 566423 lines...]
[junit] 2015-01-26 11:12:24,029 [myid:] - INFO  [main:ZooKeeperServer@443] 
- shutting down
[junit] 2015-01-26 11:12:24,029 [myid:] - INFO  
[main:SessionTrackerImpl@231] - Shutting down
[junit] 2015-01-26 11:12:24,029 [myid:] - INFO  
[main:PrepRequestProcessor@971] - Shutting down
[junit] 2015-01-26 11:12:24,029 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2015-01-26 11:12:24,029 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop!
[junit] 2015-01-26 11:12:24,029 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2015-01-26 11:12:24,029 [myid:] - INFO  
[main:FinalRequestProcessor@476] - shutdown of request processor complete
[junit] 2015-01-26 11:12:24,030 [myid:] - INFO  [main:MBeanRegistry@119] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree]
[junit] 2015-01-26 11:12:24,030 [myid:] - INFO  [main:MBeanRegistry@119] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port11221]
[junit] 2015-01-26 11:12:24,030 [myid:] - INFO  
[main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221
[junit] 2015-01-26 11:12:24,030 [myid:] - INFO  [main:JMXEnv@142] - 
ensureOnly:[]
[junit] 2015-01-26 11:12:24,033 [myid:] - INFO  [main:ClientBase@545] - 
fdcount after test is: 48 at start it was 34
[junit] 2015-01-26 11:12:24,033 [myid:] - INFO  [main:ClientBase@547] - 
sleeping for 20 secs
[junit] 2015-01-26 11:12:24,034 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testQuota
[junit] 2015-01-26 11:12:24,034 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testQuota
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.641 sec

test-core-java:

call-test-cppunit:

init:

check-cppunit-makefile:

create-cppunit-makefile:

init:

check-cppunit-configure:

create-cppunit-configure:
 [exec] configure.ac:37: warning: macro `AM_PATH_CPPUNIT' not found in 
library
 [exec] libtoolize: putting auxiliary files in `.'.
 [exec] libtoolize: copying file `./config.guess'
 [exec] libtoolize: copying file `./config.sub'
 [exec] libtoolize: copying file `./install-sh'
 [exec] libtoolize: copying file `./ltmain.sh'
 [exec] libtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to 
configure.ac and
 [exec] libtoolize: rerunning libtoolize, to keep the correct libtool 
macros in-tree.
 [exec] libtoolize: Consider adding `-I m4' to ACLOCAL_AMFLAGS in 
Makefile.am.
 [exec] configure.ac:37: warning: macro `AM_PATH_CPPUNIT' not found in 
library
 [exec] configure.ac:37: error: possibly undefined macro: AM_PATH_CPPUNIT
 [exec]   If this token and others are legitimate, please use 
m4_pattern_allow.
 [exec]   See the Autoconf documentation.
 [exec] autoreconf: /usr/bin/autoconf failed with exit status: 1

BUILD FAILED
/x1/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/build.xml:1422:
 The following error occurred while executing this line:
/x1/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/build.xml:1381:
 The following error occurred while executing this line:
/x1/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/build.xml:1368:
 The following error occurred while executing this line:
/x1/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/build.xml:1360:
 exec returned: 1

Total time: 59 minutes 17 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
All tests passed

ZooKeeper-trunk - Build # 2575 - Still Failing

2015-01-26 Thread Apache Jenkins Server 
See https://builds.apache.org/job/ZooKeeper-trunk/2575/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 2963 lines...]
   [clover] Updating existing database at 
'/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build/test/clover/db/zookeeper_coverage.db'.
   [clover] Processing files at 1.3 source level.
   [clover] 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/java/main/org/apache/zookeeper/KeeperException.java:318:24:unexpected
 token: Code
   [clover] 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/java/main/org/apache/zookeeper/KeeperException.java:318:24:unexpected
 token: Code
   [clover] ** Error(s) occurred and the instrumentation process can't continue.

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build.xml:1422: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build.xml:432: 
com.cenqua.clover.CloverException: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/java/main/org/apache/zookeeper/KeeperException.java:318:24:unexpected
 token: Code
at 
com.cenqua.clover.instr.Instrumenter.instrument(Instrumenter.java:155)
at 
org.apache.tools.ant.taskdefs.CloverCompilerAdapter.setJavac(CloverCompilerAdapter.java:339)
at org.apache.tools.ant.taskdefs.Javac.compile(Javac.java:1156)
at org.apache.tools.ant.taskdefs.Javac.execute(Javac.java:935)
at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at 
org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
at org.apache.tools.ant.Task.perform(Task.java:348)
at org.apache.tools.ant.Target.execute(Target.java:435)
at org.apache.tools.ant.Target.performTasks(Target.java:456)
at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393)
at 
org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:38)
at org.apache.tools.ant.Project.executeTargets(Project.java:1248)
at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:441)
at org.apache.tools.ant.taskdefs.CallTarget.execute(CallTarget.java:105)
at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at 
org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
at org.apache.tools.ant.Task.perform(Task.java:348)
at org.apache.tools.ant.Target.execute(Target.java:435)
at org.apache.tools.ant.Target.performTasks(Target.java:456)
at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393)
at org.apache.tools.ant.Project.executeTarget(Project.java:1364)
at 
org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
at org.apache.tools.ant.Project.executeTargets(Project.java:1248)
at org.apache.tools.ant.Main.runBuild(Main.java:851)
at org.apache.tools.ant.Main.startAnt(Main.java:235)
at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280)
at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109)

Total time: 5 seconds
Build step 'Execute shell' marked build as failure
[FINDBUGS] Skipping publisher since build result is FAILURE
[WARNINGS] Skipping publisher since build result is FAILURE
Archiving artifacts
Sending artifact delta relative to ZooKeeper-trunk #2531
Archived 3 artifacts
Archive block size is 32768
Received 0 blocks and 18057835 bytes
Compression is 0.0%
Took 4.8 sec
Recording fingerprints
Recording test results
Publishing Javadoc
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper-trunk-solaris - Build # 922 - Still Failing

2015-01-26 Thread Apache Jenkins Server 
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/922/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by timer
Building remotely on solaris1 (Solaris) in workspace 
/export/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris
Updating http://svn.apache.org/repos/asf/zookeeper/trunk at revision 
'2015-01-26T08:31:28.978 +'
At revision 1654738
Updating http://svn.apache.org/repos/asf/hadoop/nightly at revision 
'2015-01-26T08:31:28.978 +'
At revision 1654738
no change for http://svn.apache.org/repos/asf/zookeeper/trunk since the 
previous build
no change for http://svn.apache.org/repos/asf/hadoop/nightly since the previous 
build
No emails were triggered.
[locks-and-latches] Checking to see if we really have the locks
[locks-and-latches] Have all the locks, build can start
[ZooKeeper-trunk-solaris] $ /bin/bash /var/tmp/hudson6866206722575925674.sh
[trunk] $ 
/export/home/hudson/hudson-slave/tools/hudson.tasks.Ant_AntInstallation/ant-1.8.2/bin/ant
 "-DBUILD_ARGS=-Dfindbugs.home=${FINDBUGS_HOME} -Dforrest.home=${FORREST_HOME} 
-Djava5.home=${JAVA5_HOME}" -DBUILD_TARGETS=hudson-test-trunk 
-DANALYSIS_TARGETS=test "-DBUILD_FLAGS=-Dtest.junit.output.format=xml 
-Dtest.output=yes " -Dtest.output=yes -Dtest.junit.output.format=xml clean 
test-core-java
Error: JAVA_HOME is not defined correctly.
  We cannot execute /home/jenkins/tools/java/latest1.7/bin/java
Build step 'Invoke Ant' marked build as failure
[locks-and-latches] Releasing all the locks
[locks-and-latches] All the locks released
Recording test results
Email was triggered for: Failure
Sending email for trigger: Failure



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper-trunk-WinVS2008 - Build # 1692 - Still Failing

2015-01-26 Thread Apache Jenkins Server 
See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/1692/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 490 lines...]
at 
org.tmatesoft.svn.core.internal.wc16.SVNUpdateClient16.doUpdate(SVNUpdateClient16.java:364)
at 
org.tmatesoft.svn.core.internal.wc16.SVNUpdateClient16.doUpdate(SVNUpdateClient16.java:274)
at 
org.tmatesoft.svn.core.internal.wc2.old.SvnOldUpdate.run(SvnOldUpdate.java:27)
at 
org.tmatesoft.svn.core.internal.wc2.old.SvnOldUpdate.run(SvnOldUpdate.java:11)
at 
org.tmatesoft.svn.core.internal.wc2.SvnOperationRunner.run(SvnOperationRunner.java:20)
at 
org.tmatesoft.svn.core.wc2.SvnOperationFactory.run(SvnOperationFactory.java:1238)
at org.tmatesoft.svn.core.wc2.SvnOperation.run(SvnOperation.java:294)
at 
org.tmatesoft.svn.core.wc.SVNUpdateClient.doUpdate(SVNUpdateClient.java:311)
at 
org.tmatesoft.svn.core.wc.SVNUpdateClient.doUpdate(SVNUpdateClient.java:291)
at 
org.tmatesoft.svn.core.wc.SVNUpdateClient.doUpdate(SVNUpdateClient.java:387)
at 
hudson.scm.subversion.UpdateUpdater$TaskImpl.perform(UpdateUpdater.java:157)
... 15 more
Caused by: svn: E175002: REPORT /repos/asf/!svn/vcc/default failed
at 
org.tmatesoft.svn.core.SVNErrorMessage.create(SVNErrorMessage.java:208)
at 
org.tmatesoft.svn.core.SVNErrorMessage.create(SVNErrorMessage.java:154)
at 
org.tmatesoft.svn.core.SVNErrorMessage.create(SVNErrorMessage.java:97)
... 34 more
Caused by: org.tmatesoft.svn.core.SVNException: svn: E204899: REPORT request 
failed on '/repos/asf/!svn/vcc/default'
svn: E204899: Cannot rename file 
'F:/hudson/hudson-slave/workspace/ZooKeeper-trunk-WinVS2008/trunk/.svn/tmp/entries'
 to 
'F:/hudson/hudson-slave/workspace/ZooKeeper-trunk-WinVS2008/trunk/.svn/entries'
at 
org.tmatesoft.svn.core.internal.wc.SVNErrorManager.error(SVNErrorManager.java:64)
at 
org.tmatesoft.svn.core.internal.wc.SVNErrorManager.error(SVNErrorManager.java:51)
at 
org.tmatesoft.svn.core.internal.io.dav.http.HTTPConnection._request(HTTPConnection.java:771)
at 
org.tmatesoft.svn.core.internal.io.dav.http.HTTPConnection.request(HTTPConnection.java:382)
... 33 more
Caused by: svn: E204899: REPORT request failed on '/repos/asf/!svn/vcc/default'
at 
org.tmatesoft.svn.core.SVNErrorMessage.create(SVNErrorMessage.java:208)
at 
org.tmatesoft.svn.core.SVNErrorMessage.create(SVNErrorMessage.java:154)
at 
org.tmatesoft.svn.core.SVNErrorMessage.create(SVNErrorMessage.java:97)
at org.tmatesoft.svn.core.SVNErrorMessage.wrap(SVNErrorMessage.java:407)
... 35 more
Caused by: svn: E204899: Cannot rename file 
'F:/hudson/hudson-slave/workspace/ZooKeeper-trunk-WinVS2008/trunk/.svn/tmp/entries'
 to 
'F:/hudson/hudson-slave/workspace/ZooKeeper-trunk-WinVS2008/trunk/.svn/entries'
at 
org.tmatesoft.svn.core.SVNErrorMessage.create(SVNErrorMessage.java:208)
at 
org.tmatesoft.svn.core.SVNErrorMessage.create(SVNErrorMessage.java:189)
at 
org.tmatesoft.svn.core.SVNErrorMessage.create(SVNErrorMessage.java:141)
at 
org.tmatesoft.svn.core.internal.wc.SVNFileUtil.rename(SVNFileUtil.java:689)
at 
org.tmatesoft.svn.core.internal.wc.admin.SVNAdminArea14.saveEntries(SVNAdminArea14.java:635)
at 
org.tmatesoft.svn.core.internal.wc.admin.SVNAdminArea.modifyEntry(SVNAdminArea.java:866)
at 
org.tmatesoft.svn.core.internal.wc.SVNUpdateEditor.openRoot(SVNUpdateEditor.java:189)
at 
org.tmatesoft.svn.core.internal.wc.SVNCancellableEditor.openRoot(SVNCancellableEditor.java:60)
at 
org.tmatesoft.svn.core.internal.io.dav.handlers.DAVEditorHandler.startElement(DAVEditorHandler.java:288)
at 
org.tmatesoft.svn.core.internal.io.dav.handlers.BasicDAVHandler.startElement(BasicDAVHandler.java:89)
at 
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.startElement(Unknown
 Source)
at 
com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanStartElement(Unknown
 Source)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(Unknown
 Source)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(Unknown 
Source)
at 
com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(Unknown 
Source)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown
 Source)
at 
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(Unknown 
Source)
at 
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(Unknown 
Source)
at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(Unknown 
Source)
at 
com.sun.org.apache.xerces.internal.parsers.Abstract