[jira] [Commented] (ZOOKEEPER-2221) Zookeeper JettyAdminServer server should start on configured IP.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604098#comment-14604098
]
Rakesh R commented on ZOOKEEPER-2221:
-
Thanks [~surendrasingh] for the contribution. Few minor comments:
# Can we rename the property {{zookeeper.admin.address}} to
{{zookeeper.admin.serverAddress}} to sync with other configurations in
JettyAdminServer.java. I could see already we have a configuration for the port
its name is {{zookeeper.admin.serverPort}}
# Also, please move the new configuration reading logic to default
{{JettyAdminServer()}} constructor
Zookeeper JettyAdminServer server should start on configured IP.
Key: ZOOKEEPER-2221
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2221
Project: ZooKeeper
Issue Type: Bug
Components: quorum
Affects Versions: 3.5.0
Reporter: Surendra Singh Lilhore
Assignee: Surendra Singh Lilhore
Attachments: ZOOKEEPER-2221.patch
Currently JettyAdminServer starting on 0.0.0.0 IP. 0.0.0.0 means all IP
addresses on the local machine. So, if your webserver machine has two ip
addresses, 192.168.1.1(private) and 10.1.2.1(public), and you allow a
webserver daemon like apache to listen on 0.0.0.0, it will be reachable at
both of those IPs.
This is security issue. webserver should be accessible from only configured IP
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2170) Zookeeper is not logging as per the configuraiton in log4j.properties
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604010#comment-14604010
]
Arshad Mohammad commented on ZOOKEEPER-2170:
yes, i will provide patch soon
Zookeeper is not logging as per the configuraiton in log4j.properties
--
Key: ZOOKEEPER-2170
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2170
Project: ZooKeeper
Issue Type: Bug
Reporter: Arshad Mohammad
Assignee: Chris Nauroth
Fix For: 3.6.0
Attachments: ZOOKEEPER-2170.001.patch
In conf/log4j.properties default root logger is
{code}
zookeeper.root.logger=INFO, CONSOLE
{code}
Changing root logger to bellow value or any other value does not change
logging effect
{code}
zookeeper.root.logger=DEBUG, ROLLINGFILE
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2193) reconfig command completes even if parameter is wrong obviously
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604118#comment-14604118
]
Hudson commented on ZOOKEEPER-2193:
---
SUCCESS: Integrated in ZooKeeper-trunk #2739 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2739/])
ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously
(Yasuhito Fukuda via rgs) (rgs:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1687876)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
reconfig command completes even if parameter is wrong obviously
---
Key: ZOOKEEPER-2193
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2193
Project: ZooKeeper
Issue Type: Bug
Components: leaderElection, server
Affects Versions: 3.5.0
Environment: CentOS7 + Java7
Reporter: Yasuhito Fukuda
Assignee: Yasuhito Fukuda
Attachments: ZOOKEEPER-2193-v2.patch, ZOOKEEPER-2193-v3.patch,
ZOOKEEPER-2193-v4.patch, ZOOKEEPER-2193-v5.patch, ZOOKEEPER-2193-v6.patch,
ZOOKEEPER-2193-v7.patch, ZOOKEEPER-2193-v8.patch, ZOOKEEPER-2193.patch
Even if reconfig parameter is wrong, it was confirmed to complete.
refer to the following.
- Ensemble consists of four nodes
{noformat}
[zk: vm-101:2181(CONNECTED) 0] config
server.1=192.168.100.101:2888:3888:participant
server.2=192.168.100.102:2888:3888:participant
server.3=192.168.100.103:2888:3888:participant
server.4=192.168.100.104:2888:3888:participant
version=1
{noformat}
- add node by reconfig command
{noformat}
[zk: vm-101:2181(CONNECTED) 9] reconfig -add
server.5=192.168.100.104:2888:3888:participant;0.0.0.0:2181
Committed new configuration:
server.1=192.168.100.101:2888:3888:participant
server.2=192.168.100.102:2888:3888:participant
server.3=192.168.100.103:2888:3888:participant
server.4=192.168.100.104:2888:3888:participant
server.5=192.168.100.104:2888:3888:participant;0.0.0.0:2181
version=30007
{noformat}
server.4 and server.5 of the IP address is a duplicate.
In this state, reader election will not work properly.
Besides, it is assumed an ensemble will be undesirable state.
I think that need a parameter validation when reconfig.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2140) NettyServerCnxn and NIOServerCnxn code should be improved
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arshad Mohammad updated ZOOKEEPER-2140:
---
Attachment: ZOOKEEPER-2140-4.patch
NettyServerCnxn and NIOServerCnxn code should be improved
-
Key: ZOOKEEPER-2140
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2140
Project: ZooKeeper
Issue Type: Improvement
Reporter: Arshad Mohammad
Fix For: 3.6.0
Attachments: ZOOKEEPER-2140-1.patch, ZOOKEEPER-2140-2.patch,
ZOOKEEPER-2140-3.patch, ZOOKEEPER-2140-4.patch
Classes org.apache.zookeeper.server.NIOServerCnxn and
org.apache.zookeeper.server.NettyServerCnxn have following need and scope for
improvement
1) Duplicate code.
These two classes have around 250 line duplicate code. All the command
code is duplicated
2) Many improvement/bugFix done in one class but not done in other class.
These changes should be synced
For example
In NettyServerCnxn
{code}
// clone should be faster than iteration
// ie give up the cnxns lock faster
AbstractSetServerCnxn cnxns;
synchronized (factory.cnxns) {
cnxns = new HashSetServerCnxn(factory.cnxns);
}
for (ServerCnxn c : cnxns) {
c.dumpConnectionInfo(pw, false);
pw.println();
}
{code}
In NIOServerCnxn
{code}
for (ServerCnxn c : factory.cnxns) {
c.dumpConnectionInfo(pw, false);
pw.println();
}
{code}
3) NettyServerCnxn and NIOServerCnxn classes are bulky unnecessarily.
Command classes have altogether different functionality, the command classes
should go in different class files.
If this done it will be easy to add new command with minimal change to
existing classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2140) NettyServerCnxn and NIOServerCnxn code should be improved
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604223#comment-14604223
]
Hadoop QA commented on ZOOKEEPER-2140:
--
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12742328/ZOOKEEPER-2140-4.patch
against trunk revision 1687876.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2782//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2782//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2782//console
This message is automatically generated.
NettyServerCnxn and NIOServerCnxn code should be improved
-
Key: ZOOKEEPER-2140
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2140
Project: ZooKeeper
Issue Type: Improvement
Reporter: Arshad Mohammad
Fix For: 3.6.0
Attachments: ZOOKEEPER-2140-1.patch, ZOOKEEPER-2140-2.patch,
ZOOKEEPER-2140-3.patch, ZOOKEEPER-2140-4.patch
Classes org.apache.zookeeper.server.NIOServerCnxn and
org.apache.zookeeper.server.NettyServerCnxn have following need and scope for
improvement
1) Duplicate code.
These two classes have around 250 line duplicate code. All the command
code is duplicated
2) Many improvement/bugFix done in one class but not done in other class.
These changes should be synced
For example
In NettyServerCnxn
{code}
// clone should be faster than iteration
// ie give up the cnxns lock faster
AbstractSetServerCnxn cnxns;
synchronized (factory.cnxns) {
cnxns = new HashSetServerCnxn(factory.cnxns);
}
for (ServerCnxn c : cnxns) {
c.dumpConnectionInfo(pw, false);
pw.println();
}
{code}
In NIOServerCnxn
{code}
for (ServerCnxn c : factory.cnxns) {
c.dumpConnectionInfo(pw, false);
pw.println();
}
{code}
3) NettyServerCnxn and NIOServerCnxn classes are bulky unnecessarily.
Command classes have altogether different functionality, the command classes
should go in different class files.
If this done it will be easy to add new command with minimal change to
existing classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Success: ZOOKEEPER-2140 PreCommit Build #2782
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2140 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2782/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 375656 lines...] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12742328/ZOOKEEPER-2140-4.patch [exec] against trunk revision 1687876. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2782//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2782//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2782//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 403b3a4f9b5c3176970e0866f115dc5d89c72aeb logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 13 minutes 40 seconds Archiving artifacts Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2752 Archived 24 artifacts Archive block size is 32768 Received 5 blocks and 33655605 bytes Compression is 0.5% Took 11 sec Recording test results Description set: ZOOKEEPER-2140 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Updated] (ZOOKEEPER-2221) Zookeeper JettyAdminServer server should start on configured IP.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surendra Singh Lilhore updated ZOOKEEPER-2221: -- Attachment: (was: ZOOKEEPER-2221_1.patch) Zookeeper JettyAdminServer server should start on configured IP. Key: ZOOKEEPER-2221 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2221 Project: ZooKeeper Issue Type: Bug Components: quorum Affects Versions: 3.5.0 Reporter: Surendra Singh Lilhore Assignee: Surendra Singh Lilhore Attachments: ZOOKEEPER-2221.patch Currently JettyAdminServer starting on 0.0.0.0 IP. 0.0.0.0 means all IP addresses on the local machine. So, if your webserver machine has two ip addresses, 192.168.1.1(private) and 10.1.2.1(public), and you allow a webserver daemon like apache to listen on 0.0.0.0, it will be reachable at both of those IPs. This is security issue. webserver should be accessible from only configured IP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2221) Zookeeper JettyAdminServer server should start on configured IP.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surendra Singh Lilhore updated ZOOKEEPER-2221: -- Attachment: ZOOKEEPER-2221_1.patch Zookeeper JettyAdminServer server should start on configured IP. Key: ZOOKEEPER-2221 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2221 Project: ZooKeeper Issue Type: Bug Components: quorum Affects Versions: 3.5.0 Reporter: Surendra Singh Lilhore Assignee: Surendra Singh Lilhore Attachments: ZOOKEEPER-2221.patch, ZOOKEEPER-2221_1.patch Currently JettyAdminServer starting on 0.0.0.0 IP. 0.0.0.0 means all IP addresses on the local machine. So, if your webserver machine has two ip addresses, 192.168.1.1(private) and 10.1.2.1(public), and you allow a webserver daemon like apache to listen on 0.0.0.0, it will be reachable at both of those IPs. This is security issue. webserver should be accessible from only configured IP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ZOOKEEPER-2221) Zookeeper JettyAdminServer server should start on configured IP.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surendra Singh Lilhore updated ZOOKEEPER-2221: -- Attachment: ZOOKEEPER-2221_1.patch Thanks [~rgs] and [~rakeshr] for looking in to this issue. I fixed all the comments and attached new patch. please review. Zookeeper JettyAdminServer server should start on configured IP. Key: ZOOKEEPER-2221 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2221 Project: ZooKeeper Issue Type: Bug Components: quorum Affects Versions: 3.5.0 Reporter: Surendra Singh Lilhore Assignee: Surendra Singh Lilhore Attachments: ZOOKEEPER-2221.patch, ZOOKEEPER-2221_1.patch Currently JettyAdminServer starting on 0.0.0.0 IP. 0.0.0.0 means all IP addresses on the local machine. So, if your webserver machine has two ip addresses, 192.168.1.1(private) and 10.1.2.1(public), and you allow a webserver daemon like apache to listen on 0.0.0.0, it will be reachable at both of those IPs. This is security issue. webserver should be accessible from only configured IP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2221) Zookeeper JettyAdminServer server should start on configured IP.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604368#comment-14604368 ] Hadoop QA commented on ZOOKEEPER-2221: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12742351/ZOOKEEPER-2221_1.patch against trunk revision 1687876. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2783//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2783//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2783//console This message is automatically generated. Zookeeper JettyAdminServer server should start on configured IP. Key: ZOOKEEPER-2221 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2221 Project: ZooKeeper Issue Type: Bug Components: quorum Affects Versions: 3.5.0 Reporter: Surendra Singh Lilhore Assignee: Surendra Singh Lilhore Attachments: ZOOKEEPER-2221.patch, ZOOKEEPER-2221_1.patch Currently JettyAdminServer starting on 0.0.0.0 IP. 0.0.0.0 means all IP addresses on the local machine. So, if your webserver machine has two ip addresses, 192.168.1.1(private) and 10.1.2.1(public), and you allow a webserver daemon like apache to listen on 0.0.0.0, it will be reachable at both of those IPs. This is security issue. webserver should be accessible from only configured IP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Failed: ZOOKEEPER-2221 PreCommit Build #2783
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2221 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2783/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 372275 lines...] [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2783//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2783//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2783//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] a66ca83914408661a77b951907d48e93d5f84041 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1782: exec returned: 3 Total time: 8 minutes 31 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2782 Archived 7 artifacts Archive block size is 32768 Received 5 blocks and 407001 bytes Compression is 28.7% Took 6 sec Recording test results Description set: ZOOKEEPER-2221 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 1 tests failed. REGRESSION: org.apache.zookeeper.server.ZxidRolloverTest.testSimpleRolloverFollower Error Message: Did not connect Stack Trace: java.util.concurrent.TimeoutException: Did not connect at org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:133) at org.apache.zookeeper.server.ZxidRolloverTest.waitForClientsConnected(ZxidRolloverTest.java:79) at org.apache.zookeeper.server.ZxidRolloverTest.createNodes(ZxidRolloverTest.java:236) at org.apache.zookeeper.server.ZxidRolloverTest.testSimpleRolloverFollower(ZxidRolloverTest.java:262)
