date:20161106

[jira] [Commented] (ZOOKEEPER-2574) PurgeTxnLog can inadvertently delete required txn log files

2016-11-06 Thread Rakesh R (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643171#comment-15643171
 ] 

Rakesh R commented on ZOOKEEPER-2574:
-

Thank you [~abhishekrai]. I could see there are few more corrections required 
in the 
[zookeeperAdmin.html#The+Log+Directory|https://zookeeper.apache.org/doc/r3.4.9/zookeeperAdmin.html#The+Log+Directory],
 right?. I'd suggest you to read the {{ZooKeeper transaction log and snapshot}} 
related sections in the ZK docs and do necessary changes. Appreciate your time 
& efforts.

{code}
The Log Directory:

A new log file is started each time a snapshot is begun. The log file's suffix 
is the first zxid written to that log
{code}

Could you please create a pull request for the proposed patch, that will be 
used for code reviews and commits.

Hi [~fpj], [~phunt], [~rgs]. As part of this jira we have came across a 
situation {{"where snapshotting has happened multiple times without 
accompanying log rollover"}}, this is contradicting with the ZooKeeper docs. I 
think, this would be a serious concern in the view of disaster recovery 
scripts. If someone has written a script blindly following that "A new log file 
is started each time a snapshot is begun". It would be really helpful if you 
could pitch in and give your thoughts on this problem. Thanks!

> PurgeTxnLog can inadvertently delete required txn log files
> ---
>
> Key: ZOOKEEPER-2574
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2574
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.7, 3.4.8, 3.5.0, 3.5.1, 3.5.2
> Environment: Zookeeper 3.4.8, standalone, and 3-server quorum
>Reporter: Abhishek Rai
>Assignee: Abhishek Rai
>Priority: Blocker
> Fix For: 3.4.10, 3.5.3
>
> Attachments: ZOOKEEPER-2574.2.patch, ZOOKEEPER-2574.3.patch, 
> ZOOKEEPER-2574.4.patch, ZOOKEEPER-2574.5.patch, ZOOKEEPER-2574.6.patch, 
> ZOOKEEPER-2574.patch
>
>
> As part of the fix for ZOOKEEPER-1797, the call to 
> FileTxnSnapLog.getSnapshotLogs() was removed from PurgeTxnLog.java.  As a 
> result, some old-looking but required txn log files can be deleted, resulting 
> in data corruption or loss.
> For example, consider the following:
> 1. Configuration:
> autopurge.snapRetainCount=3
> 2. Following files exist:
> log.100 spans transactions from zxid=100 till zxid=140 (inclusive)
> snapshot.110 - snapshot as of zxid=110
> snapshot.120 - snapshot as of zxid=120
> snapshot.130 - snapshot as of zxid=130
> Above scenario is possible when snapshotting has happened multiple times but 
> without accompanying log rollover, which is possible if the server was 
> running as a learner.
> 3. PurgeTxnLog retains all snapshots but deletes log.100 because its zxid is 
> older than the zxid of the oldest snapshot (110).  This results in loss of 
> transactions in the range 131-140.
> Before the fix for ZOOKEEPER-1797, this was avoided by the call to 
> FileTxnSnapLog.getSnapshotLogs() which finds and retains the newest txn log 
> file with starting zxid < oldest retained snapshot's highest zxid.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-WinVS2008 - Build # 2317 - Still Failing

2016-11-06 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/2317/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 78 lines...]

ivy-retrieve:
[ivy:retrieve] :: Apache Ivy 2.4.0 - 20141213170938 :: 
http://ant.apache.org/ivy/ ::
[ivy:retrieve] :: loading settings :: file = 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\ivysettings.xml
[ivy:retrieve] :: resolving dependencies :: 
org.apache.zookeeper#zookeeper;3.6.0-SNAPSHOT
[ivy:retrieve]  confs: [default]
[ivy:retrieve]  found jline#jline;2.11 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-server;9.2.18.v20160721 in maven2
[ivy:retrieve]  found javax.servlet#javax.servlet-api;3.1.0 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-http;9.2.18.v20160721 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-util;9.2.18.v20160721 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-io;9.2.18.v20160721 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-servlet;9.2.18.v20160721 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-security;9.2.18.v20160721 in 
maven2
[ivy:retrieve]  found org.codehaus.jackson#jackson-mapper-asl;1.9.11 in maven2
[ivy:retrieve]  found org.codehaus.jackson#jackson-core-asl;1.9.11 in maven2
[ivy:retrieve]  found org.slf4j#slf4j-api;1.7.5 in maven2
[ivy:retrieve]  found org.slf4j#slf4j-log4j12;1.7.5 in maven2
[ivy:retrieve]  found commons-cli#commons-cli;1.2 in maven2
[ivy:retrieve]  found log4j#log4j;1.2.17 in maven2
[ivy:retrieve]  found io.netty#netty;3.10.5.Final in maven2
[ivy:retrieve]  found net.java.dev.javacc#javacc;5.0 in maven2
[ivy:retrieve] :: resolution report :: resolve 397ms :: artifacts dl 19ms
-
|  |modules||   artifacts   |
|   conf   | number| search|dwnlded|evicted|| number|dwnlded|
-
|  default |   16  |   0   |   0   |   0   ||   16  |   0   |
-
[ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
[ivy:retrieve]  confs: [default]
[ivy:retrieve]  16 artifacts copied, 0 already retrieved (4635kB/45ms)

generate_jute_parser:
[mkdir] Created dir: 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\build\jute_compiler\org\apache\jute\compiler\generated
[ivy:artifactproperty] DEPRECATED: 'ivy.conf.file' is deprecated, use 
'ivy.settings.file' instead
[ivy:artifactproperty] :: loading settings :: file = 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\ivysettings.xml
 [move] Moving 1 file to 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\build\lib
   [javacc] Java Compiler Compiler Version 5.0 (Parser Generator)
   [javacc] (type "javacc" with no arguments for help)
   [javacc] Reading from file 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\src\java\main\org\apache\jute\compiler\generated\rcc.jj
 . . .
   [javacc] File "TokenMgrError.java" does not exist.  Will create one.
   [javacc] File "ParseException.java" does not exist.  Will create one.
   [javacc] File "Token.java" does not exist.  Will create one.
   [javacc] File "SimpleCharStream.java" does not exist.  Will create one.
   [javacc] Parser generated successfully.

jute:

BUILD FAILED
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\build.xml:273: 
Unable to find a javac compiler;
com.sun.tools.javac.Main is not on the classpath.
Perhaps JAVA_HOME does not point to the JDK.
It is currently set to "C:\Program Files\Java\jre1.8.0_92"

Total time: 3 seconds
Build step 'Invoke Ant' marked build as failure
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2314) Improvements to SASL

2016-11-06 Thread jonny (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642853#comment-15642853
 ] 

jonny commented on ZOOKEEPER-2314:
--

hello,how to test this problem?

> Improvements to SASL
> 
>
> Key: ZOOKEEPER-2314
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2314
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.4.6, 3.5.1
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>Priority: Blocker
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> Points that occur to me right now:
> # The login object in ZooKeeperSaslClient is static, which means that if you 
> try to create another client for tests, the login object will be the first 
> one you've set for all runs. I've experienced this with 3.4.6.
> # There are a number of properties spread across the code that do not appear 
> in the docs. For example, zookeeper.allowSaslFailedClients isn't documented 
> afaict.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch34 - Build # 1712 - Still Failing

2016-11-06 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper_branch34/1712/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 1471 lines...]
[mkdir] Created dir: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/dist-maven
 [copy] Copying 1 file to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/dist-maven
 [copy] Copying 2 files to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/dist-maven
 [copy] Copying 1 file to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/dist-maven
 [copy] Copying 8 files to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/bin
 [copy] Copying 3 files to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/conf
 [copy] Copying 318 files to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/docs
 [copy] Copied 22 empty directories to 3 empty directories under 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/docs
 [copy] Copying 8 files to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT
 [copy] Copying 918 files to 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/src
 [copy] Copied 238 empty directories to 1 empty directory under 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT/src

tar:
  [tar] Building tar: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build/zookeeper-3.4.10-SNAPSHOT.tar.gz

check-for-findbugs:

findbugs:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build.xml:1481: 
java.lang.UnsupportedClassVersionError: 
edu/umd/cs/findbugs/anttask/FindBugsTask : Unsupported major.minor version 51.0
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClassCond(ClassLoader.java:631)
at java.lang.ClassLoader.defineClass(ClassLoader.java:615)
at 
org.apache.tools.ant.AntClassLoader.defineClassFromData(AntClassLoader.java:1149)
at 
org.apache.tools.ant.AntClassLoader.getClassFromStream(AntClassLoader.java:1320)
at 
org.apache.tools.ant.AntClassLoader.findClassInComponents(AntClassLoader.java:1376)
at 
org.apache.tools.ant.AntClassLoader.findClass(AntClassLoader.java:1337)
at 
org.apache.tools.ant.AntClassLoader.loadClass(AntClassLoader.java:1089)
at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:249)
at org.apache.tools.ant.taskdefs.Definer.addDefinition(Definer.java:579)
at org.apache.tools.ant.taskdefs.Definer.execute(Definer.java:237)
at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:293)
at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at 
org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
at org.apache.tools.ant.Task.perform(Task.java:348)
at org.apache.tools.ant.Target.execute(Target.java:435)
at org.apache.tools.ant.Target.performTasks(Target.java:456)
at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405)
at org.apache.tools.ant.Project.executeTarget(Project.java:1376)
at 
org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
at org.apache.tools.ant.Project.executeTargets(Project.java:1260)
at org.apache.tools.ant.Main.runBuild(Main.java:854)
at org.apache.tools.ant.Main.startAnt(Main.java:236)
at org.apache.tools.ant.launch.Launcher.run(Launcher.java:285)
at org.apache.tools.ant.launch.Launcher.main(Launcher.java:112)

Total time: 50 seconds
mv: cannot stat 'build/test/findbugs': No such file or directory
Build Failed
Build step 'Execute shell' marked build as failure
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

ZooKeeper-trunk-solaris - Build # 1375 - Still Failing

2016-11-06 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1375/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 448759 lines...]
[junit] 2016-11-06 21:06:39,296 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-11-06 21:06:39,296 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-11-06 21:06:39,297 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-11-06 21:06:39,298 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-11-06 21:06:39,298 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-11-06 21:06:39,298 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-11-06 21:06:39,298 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test4324159060360242404.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test4324159060360242404.junit.dir/version-2
[junit] 2016-11-06 21:06:39,299 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test4324159060360242404.junit.dir/version-2/snapshot.b
[junit] 2016-11-06 21:06:39,301 [myid:] - INFO  [main:FileTxnSnapLog@306] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test4324159060360242404.junit.dir/version-2/snapshot.b
[junit] 2016-11-06 21:06:39,302 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-11-06 21:06:39,302 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-11-06 21:06:39,303 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:38193
[junit] 2016-11-06 21:06:39,303 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:38193
[junit] 2016-11-06 21:06:39,304 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-11-06 21:06:39,304 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:38193 (no session established for client)
[junit] 2016-11-06 21:06:39,304 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-11-06 21:06:39,305 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-11-06 21:06:39,306 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-11-06 21:06:39,306 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-11-06 21:06:39,306 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-11-06 21:06:39,306 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 18046
[junit] 2016-11-06 21:06:39,306 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-11-06 21:06:39,307 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-11-06 21:06:39,307 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-11-06 21:06:39,382 [myid:] - INFO  [main:ZooKeeper@1315] - 
Session: 0x124b8717853 closed
[junit] 2016-11-06 21:06:39,382 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x124b8717853
[junit] 2016-11-06 21:06:39,382 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-11-06 21:06:39,383 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-11-06 21:06:39,383 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-11-06 21:06:39,383 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
-

[jira] [Resolved] (ZOOKEEPER-2624) Add test script for pull requests

2016-11-06 Thread Raul Gutierrez Segales (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Raul Gutierrez Segales resolved ZOOKEEPER-2624.
---
Resolution: Fixed

> Add test script for pull requests
> -
>
> Key: ZOOKEEPER-2624
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2624
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: scripts
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>
> We need a script similar to {{test-patch.sh}} to handle QA builds for pull 
> requests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2624) Add test script for pull requests

2016-11-06 Thread Raul Gutierrez Segales (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642378#comment-15642378
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-2624:
---

Merged:

https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=commitdiff;h=440e0923dd9e3be533a196fdd6ada960860ca7f6;hp=bcb07a09b06c91243ed244f04a71b8daf629e286

Thanks Flavio & Ben!

> Add test script for pull requests
> -
>
> Key: ZOOKEEPER-2624
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2624
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: scripts
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>
> We need a script similar to {{test-patch.sh}} to handle QA builds for pull 
> requests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [DISCUSS] QA github pre-commit queue

2016-11-06 Thread Raúl Gutiérrez Segalés

On 6 November 2016 at 11:54, Flavio Junqueira  wrote:

> ZOOKEEPER-2624 has been merged, thank Raul, Ben and Michael for reviewing.
>
> The QA for pull requests should be working for pull requests agains
> master, but let's keep an eye and polish any rough edges that might still
> be there.
>
> With ZOOKEEPER-2624 in, there is one last major decision we need to make
> to wrap this up. The pull request QA currently do not make a jira patch
> available. This is intentional because making it patch available will
> trigger the original Jira QA, which will be confusing because we will see a
> failure (I haven't tested, but I think that's what's going to happen). If
> we change the script to make the Jira patch available, then we need to
> either:
>
> 1- Disable the Jira QA altogether, which means that we will only have pull
> request QA available
> 2- Make the Jira QA script spot that there is a pull request available and
> not build it.
>
> I'm wondering if folks would be ok with only having patches submitted via
> pull requests or if we should continue to support the old Jira QA.
>

I am +1 on only having patches submitted via PRs, it's simpler to only have
to support one method. Thanks Flavio for making this happen!


-rgs

ZooKeeper-trunk-openjdk7 - Build # 1230 - Failure

2016-11-06 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1230/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 468880 lines...]
[junit] 2016-11-06 20:32:52,705 [myid:127.0.0.1:11222] - INFO  
[main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11222. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-11-06 20:32:52,705 [myid:127.0.0.1:11222] - WARN  
[main-SendThread(127.0.0.1:11222):ClientCnxn$SendThread@1235] - Session 
0x101ced1d504 for server 127.0.0.1/127.0.0.1:11222, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-11-06 20:32:52,991 [myid:127.0.0.1:11349] - INFO  
[main-SendThread(127.0.0.1:11349):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11349. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-11-06 20:32:52,992 [myid:127.0.0.1:11349] - WARN  
[main-SendThread(127.0.0.1:11349):ClientCnxn$SendThread@1235] - Session 
0x301ced6d658 for server 127.0.0.1/127.0.0.1:11349, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-11-06 20:33:42,914 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 24225
[junit] 2016-11-06 20:33:42,915 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 55
[junit] 2016-11-06 20:33:42,915 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testManyChildWatchersAutoReset
[junit] 2016-11-06 20:33:42,915 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-11-06 20:33:42,915 [myid:] - INFO  [ProcessThread(sid:0 
cport:13918)::PrepRequestProcessor@605] - Processed session termination for 
sessionid: 0x101ced02a9e
[junit] 2016-11-06 20:33:42,956 [myid:] - INFO  
[NIOWorkerThread-5:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port13918,name1=Connections,name2=127.0.0.1,name3=0x101ced02a9e]
[junit] 2016-11-06 20:33:42,956 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x101ced02a9e
[junit] 2016-11-06 20:33:42,956 [myid:] - INFO  [main:ZooKeeper@1315] - 
Session: 0x101ced02a9e closed
[junit] 2016-11-06 20:33:42,957 [myid:] - INFO  
[NIOWorkerThread-5:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:41448 which had sessionid 0x101ced02a9e
[junit] 2016-11-06 20:33:42,958 [myid:] - INFO  [ProcessThread(sid:0 
cport:13918)::PrepRequestProcessor@605] - Processed session termination for 
sessionid: 0x101ced02a9e0001
[junit] 2016-11-06 20:33:43,006 [myid:] - INFO  
[NIOWorkerThread-22:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port13918,name1=Connections,name2=127.0.0.1,name3=0x101ced02a9e0001]
[junit] 2016-11-06 20:33:43,006 [myid:] - INFO  
[NIOWorkerThread-22:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:41452 which had sessionid 0x101ced02a9e0001
[junit] 2016-11-06 20:33:43,007 [myid:] - INFO  [main:ZooKeeper@1315] - 
Session: 0x101ced02a9e0001 closed
[junit] 2016-11-06 20:33:43,007 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-11-06 20:33:43,007 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x101ced02a9e0001
[junit] 2016-11-06 20:33:43,008 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-11-06 20:33:43,009 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-11-06 20:33:43,010 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-11-06

[DISCUSS] QA github pre-commit queue

2016-11-06 Thread Flavio Junqueira

ZOOKEEPER-2624 has been merged, thank Raul, Ben and Michael for reviewing.

The QA for pull requests should be working for pull requests agains master, but 
let's keep an eye and polish any rough edges that might still be there.

With ZOOKEEPER-2624 in, there is one last major decision we need to make to 
wrap this up. The pull request QA currently do not make a jira patch available. 
This is intentional because making it patch available will trigger the original 
Jira QA, which will be confusing because we will see a failure (I haven't 
tested, but I think that's what's going to happen). If we change the script to 
make the Jira patch available, then we need to either:

1- Disable the Jira QA altogether, which means that we will only have pull 
request QA available
2- Make the Jira QA script spot that there is a pull request available and not 
build it.

I'm wondering if folks would be ok with only having patches submitted via pull 
requests or if we should continue to support the old Jira QA.

Thanks,
-Flavio

> On 02 Nov 2016, at 15:58, Flavio Junqueira  wrote:
> 
> Can I get reviews on ZOOKEEPER-2624/Pull Request #97, please? Once that gets 
> in, we will have pull request QA working.
> 
> Thanks,
> -Flavio
> 
>> On 31 Oct 2016, at 18:26, Edward Ribeiro  wrote:
>> 
>> My comments below:
>> 
>> On Mon, Oct 31, 2016 at 4:07 PM, Flavio Junqueira  wrote:
>> 
>>> 
>>> 
>> Feel free to contribute to my changes and suggest a different way in the
>>> jira. We can definitely work together on this, I just want to have this
>>> working soon.
>>> 
>> 
>> Ok. I don't want to slow down your current work in progress, so I will try
>> to see IF/WHAT I can contribute, but will let you know before hand. :)
>> 
>> 
>> 
>>> 
>>> The script is bash, not python.
>> 
>> 
>> Yup, in fact, I wrote the script with the intention of adding the option
>> of attaching the diff to the JIRA issue to zk-merge-pr.py tool. It woud be
>> for the sake of documeting the patch in the JIRA. Maybe I will create a new
>> issue proposing this once we have the other things sorted out, and only if
>> you guys think this is worth doing.
>> 
>> 
>> 
>>> It doesn't make it patch available mainly because if we make it patch
>>> available, then it will trigger the Jira QA, which will find no patch. It
>>> is a bit messy to trigger this second build, so I'm reluctant in doing it.
>>> I can see two options:
>>> 
>>> - Only do github pull requests, in which case "Patch Available" in our
>>> workflow means pull request available
>>> - Somehow detect that there is a pull request and no trigger the Jira QA
>>> 
>> 
>> IMHO, the the first option is less brittle and effective.
>> 
>> Edward
>

[jira] [Commented] (ZOOKEEPER-2624) Add test script for pull requests

2016-11-06 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642282#comment-15642282
 ] 

Hudson commented on ZOOKEEPER-2624:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3146 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3146/])
ZOOKEEPER-2624: Add test script for pull requests (rgs: rev 
440e0923dd9e3be533a196fdd6ada960860ca7f6)
* (add) src/java/test/bin/test-github-pr.sh
* (edit) build.xml


> Add test script for pull requests
> -
>
> Key: ZOOKEEPER-2624
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2624
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: scripts
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>
> We need a script similar to {{test-patch.sh}} to handle QA builds for pull 
> requests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk - Build # 3146 - Still Failing

2016-11-06 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper-trunk/3146/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 457402 lines...]
[junit] 2016-11-06 19:31:07,023 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-11-06 19:31:07,023 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2016-11-06 19:31:07,023 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2016-11-06 19:31:07,023 [myid:] - INFO  [ProcessThread(sid:0 
cport:14159)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop!
[junit] 2016-11-06 19:31:07,023 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port14159,name1=InMemoryDataTree]
[junit] 2016-11-06 19:31:07,024 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port14159]
[junit] 2016-11-06 19:31:07,024 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 14159
[junit] 2016-11-06 19:31:07,024 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-11-06 19:31:07,038 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 4824 at start it was 4824
[junit] 2016-11-06 19:31:07,038 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2016-11-06 19:31:07,038 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 101, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
507.601 sec, Thread: 2, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2016-11-06 19:31:07,074 [myid:127.0.0.1:13915] - INFO  
[main-SendThread(127.0.0.1:13915):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:13915. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-11-06 19:31:07,074 [myid:127.0.0.1:13915] - WARN  
[main-SendThread(127.0.0.1:13915):ClientCnxn$SendThread@1235] - Session 
0x100cb890f22 for server 127.0.0.1/127.0.0.1:13915, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-11-06 19:31:07,134 [myid:127.0.0.1:14036] - INFO  
[main-SendThread(127.0.0.1:14036):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:14036. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-11-06 19:31:07,134 [myid:127.0.0.1:14036] - WARN  
[main-SendThread(127.0.0.1:14036):ClientCnxn$SendThread@1235] - Session 
0x100cb8dbfae for server 127.0.0.1/127.0.0.1:14036, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-11-06 19:31:07,257 [myid:127.0.0.1:14042] - INFO  
[main-SendThread(127.0.0.1:14042):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:14042. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-11-06 19:31:07,258 [myid:127.0.0.1:14042] - WARN  
[main-SendThread(127.0.0.1:14042):ClientCnxn$SendThread@1235] - Session 
0x300cb8dc01c for server 127.0.0.1/127.0.0.1:14042, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] Running org.apache.zookeeper.server.ZxidRolloverTest in thread 5
[junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 
sec, Thread: 5, Class: org.apache.zookeeper.server.ZxidRolloverTest
[junit] Test org.apache.zookeeper.server.ZxidRolloverTest FAILED (timeout)

BUILD FAILED

ZooKeeper-trunk-WinVS2008 - Build # 2316 - Still Failing

2016-11-06 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/2316/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 78 lines...]

ivy-retrieve:
[ivy:retrieve] :: Apache Ivy 2.4.0 - 20141213170938 :: 
http://ant.apache.org/ivy/ ::
[ivy:retrieve] :: loading settings :: file = 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\ivysettings.xml
[ivy:retrieve] :: resolving dependencies :: 
org.apache.zookeeper#zookeeper;3.6.0-SNAPSHOT
[ivy:retrieve]  confs: [default]
[ivy:retrieve]  found jline#jline;2.11 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-server;9.2.18.v20160721 in maven2
[ivy:retrieve]  found javax.servlet#javax.servlet-api;3.1.0 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-http;9.2.18.v20160721 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-util;9.2.18.v20160721 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-io;9.2.18.v20160721 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-servlet;9.2.18.v20160721 in maven2
[ivy:retrieve]  found org.eclipse.jetty#jetty-security;9.2.18.v20160721 in 
maven2
[ivy:retrieve]  found org.codehaus.jackson#jackson-mapper-asl;1.9.11 in maven2
[ivy:retrieve]  found org.codehaus.jackson#jackson-core-asl;1.9.11 in maven2
[ivy:retrieve]  found org.slf4j#slf4j-api;1.7.5 in maven2
[ivy:retrieve]  found org.slf4j#slf4j-log4j12;1.7.5 in maven2
[ivy:retrieve]  found commons-cli#commons-cli;1.2 in maven2
[ivy:retrieve]  found log4j#log4j;1.2.17 in maven2
[ivy:retrieve]  found io.netty#netty;3.10.5.Final in maven2
[ivy:retrieve]  found net.java.dev.javacc#javacc;5.0 in maven2
[ivy:retrieve] :: resolution report :: resolve 426ms :: artifacts dl 23ms
-
|  |modules||   artifacts   |
|   conf   | number| search|dwnlded|evicted|| number|dwnlded|
-
|  default |   16  |   0   |   0   |   0   ||   16  |   0   |
-
[ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
[ivy:retrieve]  confs: [default]
[ivy:retrieve]  16 artifacts copied, 0 already retrieved (4635kB/46ms)

generate_jute_parser:
[mkdir] Created dir: 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\build\jute_compiler\org\apache\jute\compiler\generated
[ivy:artifactproperty] DEPRECATED: 'ivy.conf.file' is deprecated, use 
'ivy.settings.file' instead
[ivy:artifactproperty] :: loading settings :: file = 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\ivysettings.xml
 [move] Moving 1 file to 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\build\lib
   [javacc] Java Compiler Compiler Version 5.0 (Parser Generator)
   [javacc] (type "javacc" with no arguments for help)
   [javacc] Reading from file 
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\src\java\main\org\apache\jute\compiler\generated\rcc.jj
 . . .
   [javacc] File "TokenMgrError.java" does not exist.  Will create one.
   [javacc] File "ParseException.java" does not exist.  Will create one.
   [javacc] File "Token.java" does not exist.  Will create one.
   [javacc] File "SimpleCharStream.java" does not exist.  Will create one.
   [javacc] Parser generated successfully.

jute:

BUILD FAILED
f:\jenkins\jenkins-slave\workspace\ZooKeeper-trunk-WinVS2008\build.xml:273: 
Unable to find a javac compiler;
com.sun.tools.javac.Main is not on the classpath.
Perhaps JAVA_HOME does not point to the JDK.
It is currently set to "C:\Program Files\Java\jre1.8.0_92"

Total time: 3 seconds
Build step 'Invoke Ant' marked build as failure
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Updated] (ZOOKEEPER-2629) Clean up git pull request QA script

2016-11-06 Thread Flavio Junqueira (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Flavio Junqueira updated ZOOKEEPER-2629:

Priority: Minor  (was: Major)

> Clean up git pull request QA script
> ---
>
> Key: ZOOKEEPER-2629
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2629
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>Priority: Minor
>
> We have introduced a script for QA of pull requests on github in 
> ZOOKEEPER-2624. There is some cleanup left to do on the script, e.g., 
> indentation, consistency of brackets, etc. This jira to do this clean-up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2629) Clean up git pull request QA script

2016-11-06 Thread Flavio Junqueira (JIRA)

Flavio Junqueira created ZOOKEEPER-2629:
---

 Summary: Clean up git pull request QA script
 Key: ZOOKEEPER-2629
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2629
 Project: ZooKeeper
  Issue Type: Improvement
Reporter: Flavio Junqueira
Assignee: Flavio Junqueira


We have introduced a script for QA of pull requests on github in 
ZOOKEEPER-2624. There is some cleanup left to do on the script, e.g., 
indentation, consistency of brackets, etc. This jira to do this clean-up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2624) Add test script for pull requests

2016-11-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642108#comment-15642108
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2624:
---

Github user fpj commented on the issue:

https://github.com/apache/zookeeper/pull/97
  
The failures are the same as before: `@author` string in the script and new 
findbugs warnings due to jenkins upgrade. 


> Add test script for pull requests
> -
>
> Key: ZOOKEEPER-2624
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2624
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: scripts
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>
> We need a script similar to {{test-patch.sh}} to handle QA builds for pull 
> requests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #97: ZOOKEEPER-2624: Add test script for pull requests

2016-11-06 Thread fpj

Github user fpj commented on the issue:

https://github.com/apache/zookeeper/pull/97
  
The failures are the same as before: `@author` string in the script and new 
findbugs warnings due to jenkins upgrade. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

ZooKeeper_branch35_solaris - Build # 308 - Still Failing

2016-11-06 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper_branch35_solaris/308/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 488332 lines...]
[junit] 2016-11-06 17:22:45,046 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-11-06 17:22:45,046 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-11-06 17:22:45,047 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-11-06 17:22:45,047 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-11-06 17:22:45,048 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-11-06 17:22:45,048 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-11-06 17:22:45,048 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test1000442138125225826.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test1000442138125225826.junit.dir/version-2
[junit] 2016-11-06 17:22:45,049 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test1000442138125225826.junit.dir/version-2/snapshot.b
[junit] 2016-11-06 17:22:45,051 [myid:] - INFO  [main:FileTxnSnapLog@306] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/build/test/tmp/test1000442138125225826.junit.dir/version-2/snapshot.b
[junit] 2016-11-06 17:22:45,052 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-11-06 17:22:45,052 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-11-06 17:22:45,053 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:53069
[junit] 2016-11-06 17:22:45,053 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:53069
[junit] 2016-11-06 17:22:45,054 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-11-06 17:22:45,054 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:53069 (no session established for client)
[junit] 2016-11-06 17:22:45,054 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-11-06 17:22:45,055 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-11-06 17:22:45,056 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-11-06 17:22:45,056 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-11-06 17:22:45,056 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-11-06 17:22:45,056 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17683
[junit] 2016-11-06 17:22:45,056 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-11-06 17:22:45,056 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-11-06 17:22:45,057 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-11-06 17:22:45,132 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x124b7a47a77 closed
[junit] 2016-11-06 17:22:45,132 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x124b7a47a77
[junit] 2016-11-06 17:22:45,132 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-11-06 17:22:45,133 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-11-06 17:22:45,133 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-11-06 17:22:45,133 [myid:] - INFO

[GitHub] zookeeper pull request #99: ZOOKEEPER-2549 Add exception handling to sendRes...

2016-11-06 Thread yufeldman

Github user yufeldman commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/99#discussion_r86691087
  
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -716,7 +716,12 @@ public void process(WatchedEvent event) {
 // Convert WatchedEvent to a type that can be sent over the wire
 WatcherEvent e = event.getWrapper();
 
-sendResponse(h, e, "notification");
+try {
+sendResponse(h, e, "notification");
+} catch (IOException ex) {
+LOG.debug("Problem sending to " + getRemoteSocketAddress(), 
ex);
+close();
--- End diff --

I agree that it must be closing somewhere - just need to trace where


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

2016-11-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642098#comment-15642098
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2549:
---

Github user yufeldman commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/99#discussion_r86691087
  
--- Diff: src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java ---
@@ -716,7 +716,12 @@ public void process(WatchedEvent event) {
 // Convert WatchedEvent to a type that can be sent over the wire
 WatcherEvent e = event.getWrapper();
 
-sendResponse(h, e, "notification");
+try {
+sendResponse(h, e, "notification");
+} catch (IOException ex) {
+LOG.debug("Problem sending to " + getRemoteSocketAddress(), 
ex);
+close();
--- End diff --

I agree that it must be closing somewhere - just need to trace where


> As NettyServerCnxn.sendResponse() allows all the exception to bubble up it 
> can stop main ZK requests processing thread
> --
>
> Key: ZOOKEEPER-2549
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2549
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1
>Reporter: Yuliya Feldman
>Assignee: Yuliya Feldman
> Attachments: ZOOKEEPER-2549-2.patch, ZOOKEEPER-2549-3.patch, 
> ZOOKEEPER-2549-3.patch, ZOOKEEPER-2549.patch, ZOOKEEPER-2549.patch, 
> zookeeper-2549-1.patch
>
>
> As NettyServerCnxn.sendResponse() allows all the exception to bubble up it 
> can stop main ZK requests processing thread and make Zookeeper server look 
> like it is hanging, while it just can not process any request anymore.
> Idea is to catch all the exceptions in NettyServerCnxn.sendResponse() , 
> convert them to IOException and allow it propagating up



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2549) As NettyServerCnxn.sendResponse() allows all the exception to bubble up it can stop main ZK requests processing thread

2016-11-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642094#comment-15642094
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2549:
---

Github user yufeldman commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/99#discussion_r86691054
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java ---
@@ -842,7 +868,26 @@ private void addCnxn(NIOServerCnxn cnxn) {
 
 protected NIOServerCnxn createConnection(SocketChannel sock,
 SelectionKey sk, SelectorThread selectorThread) throws 
IOException {
-return new NIOServerCnxn(zkServer, sock, sk, this, selectorThread);
+
+NIOServerCnxn cnxn = null;
+
+if (serverCnxnClassCtr != null) {
--- End diff --

nothing is wrong with it per say - just overhead, as we will call 
"newInstance" on the constructor for every code path - test or not.


> As NettyServerCnxn.sendResponse() allows all the exception to bubble up it 
> can stop main ZK requests processing thread
> --
>
> Key: ZOOKEEPER-2549
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2549
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1
>Reporter: Yuliya Feldman
>Assignee: Yuliya Feldman
> Attachments: ZOOKEEPER-2549-2.patch, ZOOKEEPER-2549-3.patch, 
> ZOOKEEPER-2549-3.patch, ZOOKEEPER-2549.patch, ZOOKEEPER-2549.patch, 
> zookeeper-2549-1.patch
>
>
> As NettyServerCnxn.sendResponse() allows all the exception to bubble up it 
> can stop main ZK requests processing thread and make Zookeeper server look 
> like it is hanging, while it just can not process any request anymore.
> Idea is to catch all the exceptions in NettyServerCnxn.sendResponse() , 
> convert them to IOException and allow it propagating up



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

2016-11-06 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642088#comment-15642088
 ] 

Hadoop QA commented on ZOOKEEPER-2383:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12837652/ZOOKEEPER-2383.patch
  against trunk revision bcb07a09b06c91243ed244f04a71b8daf629e286.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 19 new Findbugs (version 
3.0.1) warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3527//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3527//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3527//console

This message is automatically generated.

> Startup race in ZooKeeperServer
> ---
>
> Key: ZOOKEEPER-2383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2383
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: jmx, server
>Affects Versions: 3.4.8
>Reporter: Steve Rowe
>Assignee: Rakesh R
>Priority: Blocker
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: TestZkStandaloneJMXRegistrationRaceConcurrent.java, 
> ZOOKEEPER-2383-br-3-4.patch, ZOOKEEPER-2383.patch, ZOOKEEPER-2383.patch, 
> ZOOKEEPER-2383.patch, ZOOKEEPER-2383.patch, 
> release-3.4.8-extra-logging.patch, zk-3.4.8-MBeanRegistry.log, 
> zk-3.4.8-NPE.log
>
>
> In attempting to upgrade Solr's ZooKeeper dependency from 3.4.6 to 3.4.8 
> (SOLR-8724) I ran into test failures where attempts to create a node in a 
> newly started standalone ZooKeeperServer were failing because of an assertion 
> in MBeanRegistry.
> ZooKeeperServer.startup() first sets up its request processor chain then 
> registers itself in JMX, but if a connection comes in before the server's JMX 
> registration happens, registration of the connection will fail because it 
> trips the assertion that (effectively) its parent (the server) has already 
> registered itself.
> {code:java|title=ZooKeeperServer.java}
> public synchronized void startup() {
> if (sessionTracker == null) {
> createSessionTracker();
> }
> startSessionTracker();
> setupRequestProcessors();
> registerJMX();
> state = State.RUNNING;
> notifyAll();
> }
> {code}
> {code:java|title=MBeanRegistry.java}
> public void register(ZKMBeanInfo bean, ZKMBeanInfo parent)
> throws JMException
> {
> assert bean != null;
> String path = null;
> if (parent != null) {
> path = mapBean2Path.get(parent);
> assert path != null;
> }
> {code}
> This problem appears to be new with ZK 3.4.8 - AFAIK Solr never had this 
> issue with ZK 3.4.6. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

2016-11-06 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642086#comment-15642086
 ] 

Hadoop QA commented on ZOOKEEPER-2383:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12837652/ZOOKEEPER-2383.patch
  against trunk revision bcb07a09b06c91243ed244f04a71b8daf629e286.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 19 new Findbugs (version 
3.0.1) warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3526//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3526//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3526//console

This message is automatically generated.

> Startup race in ZooKeeperServer
> ---
>
> Key: ZOOKEEPER-2383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2383
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: jmx, server
>Affects Versions: 3.4.8
>Reporter: Steve Rowe
>Assignee: Rakesh R
>Priority: Blocker
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: TestZkStandaloneJMXRegistrationRaceConcurrent.java, 
> ZOOKEEPER-2383-br-3-4.patch, ZOOKEEPER-2383.patch, ZOOKEEPER-2383.patch, 
> ZOOKEEPER-2383.patch, ZOOKEEPER-2383.patch, 
> release-3.4.8-extra-logging.patch, zk-3.4.8-MBeanRegistry.log, 
> zk-3.4.8-NPE.log
>
>
> In attempting to upgrade Solr's ZooKeeper dependency from 3.4.6 to 3.4.8 
> (SOLR-8724) I ran into test failures where attempts to create a node in a 
> newly started standalone ZooKeeperServer were failing because of an assertion 
> in MBeanRegistry.
> ZooKeeperServer.startup() first sets up its request processor chain then 
> registers itself in JMX, but if a connection comes in before the server's JMX 
> registration happens, registration of the connection will fail because it 
> trips the assertion that (effectively) its parent (the server) has already 
> registered itself.
> {code:java|title=ZooKeeperServer.java}
> public synchronized void startup() {
> if (sessionTracker == null) {
> createSessionTracker();
> }
> startSessionTracker();
> setupRequestProcessors();
> registerJMX();
> state = State.RUNNING;
> notifyAll();
> }
> {code}
> {code:java|title=MBeanRegistry.java}
> public void register(ZKMBeanInfo bean, ZKMBeanInfo parent)
> throws JMException
> {
> assert bean != null;
> String path = null;
> if (parent != null) {
> path = mapBean2Path.get(parent);
> assert path != null;
> }
> {code}
> This problem appears to be new with ZK 3.4.8 - AFAIK Solr never had this 
> issue with ZK 3.4.6. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-ZOOKEEPER-2383 PreCommit Build #3525

2016-11-06 Thread Apache Jenkins Server

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-ZOOKEEPER-2383
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3525/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 34 lines...]
open files  (-n) 6
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority  (-r) 0
stack size  (kbytes, -s) 8192
cpu time   (seconds, -t) unlimited
max user processes  (-u) 10240
virtual memory  (kbytes, -v) unlimited
file locks  (-x) unlimited
Buildfile: 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml

check-for-findbugs:

findbugs.check:

forrest.check:

hudson-test-patch:
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for ZOOKEEPER-ZOOKEEPER-2383.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] ZOOKEEPER-ZOOKEEPER-2383 is not "Patch Available".  Exiting.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
are the same file

BUILD SUCCESSFUL
Total time: 0 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: No artifacts found that match the file pattern 
"build/test/findbugs/newPatchFindbugsWarnings.html,patchprocess/*.txt,patchprocess/*Warnings.xml,build/test/test-cppunit/*.txt,build/tmp/zk.log".
 Configuration error?
ERROR: ‘build/test/findbugs/newPatchFindbugsWarnings.html’ doesn’t match 
anything: even ‘build’ doesn’t exist
Build step 'Archive the artifacts' changed build result to FAILURE
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2383
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Updated] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

2016-11-06 Thread Rakesh R (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rakesh R updated ZOOKEEPER-2383:

Attachment: ZOOKEEPER-2383.patch

Attached patch including test cases to verify the changs w.r.t 
{{NIOServerCnxn}}, {{NettyServerCnxn}}, {{flw commands}}.

Hi [~fpj], Created PR {{https://github.com/apache/zookeeper/pull/101}}, please 
take  look at this. Thanks!

> Startup race in ZooKeeperServer
> ---
>
> Key: ZOOKEEPER-2383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2383
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: jmx, server
>Affects Versions: 3.4.8
>Reporter: Steve Rowe
>Assignee: Rakesh R
>Priority: Blocker
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: TestZkStandaloneJMXRegistrationRaceConcurrent.java, 
> ZOOKEEPER-2383-br-3-4.patch, ZOOKEEPER-2383.patch, ZOOKEEPER-2383.patch, 
> ZOOKEEPER-2383.patch, ZOOKEEPER-2383.patch, 
> release-3.4.8-extra-logging.patch, zk-3.4.8-MBeanRegistry.log, 
> zk-3.4.8-NPE.log
>
>
> In attempting to upgrade Solr's ZooKeeper dependency from 3.4.6 to 3.4.8 
> (SOLR-8724) I ran into test failures where attempts to create a node in a 
> newly started standalone ZooKeeperServer were failing because of an assertion 
> in MBeanRegistry.
> ZooKeeperServer.startup() first sets up its request processor chain then 
> registers itself in JMX, but if a connection comes in before the server's JMX 
> registration happens, registration of the connection will fail because it 
> trips the assertion that (effectively) its parent (the server) has already 
> registered itself.
> {code:java|title=ZooKeeperServer.java}
> public synchronized void startup() {
> if (sessionTracker == null) {
> createSessionTracker();
> }
> startSessionTracker();
> setupRequestProcessors();
> registerJMX();
> state = State.RUNNING;
> notifyAll();
> }
> {code}
> {code:java|title=MBeanRegistry.java}
> public void register(ZKMBeanInfo bean, ZKMBeanInfo parent)
> throws JMException
> {
> assert bean != null;
> String path = null;
> if (parent != null) {
> path = mapBean2Path.get(parent);
> assert path != null;
> }
> {code}
> This problem appears to be new with ZK 3.4.8 - AFAIK Solr never had this 
> issue with ZK 3.4.6. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2383) Startup race in ZooKeeperServer

2016-11-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642047#comment-15642047
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2383:
---

GitHub user rakeshadr opened a pull request:

https://github.com/apache/zookeeper/pull/101

ZOOKEEPER-2383



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rakeshadr/zookeeper-1 ZK-2383

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #101


commit 401ce15e7cd1eeb0e8cef367bff53c1054ea17df
Author: Rakesh Radhakrishnan 
Date:   2016-11-06T16:24:53Z

ZOOKEEPER-2383




> Startup race in ZooKeeperServer
> ---
>
> Key: ZOOKEEPER-2383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2383
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: jmx, server
>Affects Versions: 3.4.8
>Reporter: Steve Rowe
>Assignee: Rakesh R
>Priority: Blocker
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
> Attachments: TestZkStandaloneJMXRegistrationRaceConcurrent.java, 
> ZOOKEEPER-2383-br-3-4.patch, ZOOKEEPER-2383.patch, ZOOKEEPER-2383.patch, 
> ZOOKEEPER-2383.patch, release-3.4.8-extra-logging.patch, 
> zk-3.4.8-MBeanRegistry.log, zk-3.4.8-NPE.log
>
>
> In attempting to upgrade Solr's ZooKeeper dependency from 3.4.6 to 3.4.8 
> (SOLR-8724) I ran into test failures where attempts to create a node in a 
> newly started standalone ZooKeeperServer were failing because of an assertion 
> in MBeanRegistry.
> ZooKeeperServer.startup() first sets up its request processor chain then 
> registers itself in JMX, but if a connection comes in before the server's JMX 
> registration happens, registration of the connection will fail because it 
> trips the assertion that (effectively) its parent (the server) has already 
> registered itself.
> {code:java|title=ZooKeeperServer.java}
> public synchronized void startup() {
> if (sessionTracker == null) {
> createSessionTracker();
> }
> startSessionTracker();
> setupRequestProcessors();
> registerJMX();
> state = State.RUNNING;
> notifyAll();
> }
> {code}
> {code:java|title=MBeanRegistry.java}
> public void register(ZKMBeanInfo bean, ZKMBeanInfo parent)
> throws JMException
> {
> assert bean != null;
> String path = null;
> if (parent != null) {
> path = mapBean2Path.get(parent);
> assert path != null;
> }
> {code}
> This problem appears to be new with ZK 3.4.8 - AFAIK Solr never had this 
> issue with ZK 3.4.6. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER- PreCommit Build #44

2016-11-06 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/44/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 26 lines...]
Done: 18
  Compressing objects
Done: 0
  Writing objects
Done: 31
  remote: Resolving deltas
  remote: Updating references
Merging refs/tags/changes/44
 > git rev-parse refs/tags/changes/44^{commit} # timeout=10
 > git merge 401ce15e7cd1eeb0e8cef367bff53c1054ea17df # timeout=10
 > git rev-parse master^{commit} # timeout=10
Checking out Revision 401ce15e7cd1eeb0e8cef367bff53c1054ea17df (master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 401ce15e7cd1eeb0e8cef367bff53c1054ea17df
 > git rev-parse origin/master^{commit} # timeout=10
 > git rev-list bcb07a09b06c91243ed244f04a71b8daf629e286 # timeout=10
No emails were triggered.
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[PreCommit-ZOOKEEPER-github-pr-build] $ /bin/bash 
/tmp/hudson4434468377928705716.sh
/home/jenkins/tools/java/latest1.7/bin/java
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
core file size  (blocks, -c) 0
data seg size   (kbytes, -d) unlimited
scheduling priority (-e) 0
file size   (blocks, -f) unlimited
pending signals (-i) 386178
max locked memory   (kbytes, -l) 64
max memory size (kbytes, -m) unlimited
open files  (-n) 6
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority  (-r) 0
stack size  (kbytes, -s) 8192
cpu time   (seconds, -t) unlimited
max user processes  (-u) 10240
virtual memory  (kbytes, -v) unlimited
file locks  (-x) unlimited
Buildfile: 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml

BUILD FAILED
Target "qa-test-pullrequest" does not exist in the project "ZooKeeper". 

Total time: 0 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[GitHub] zookeeper pull request #101: ZOOKEEPER-2383

2016-11-06 Thread rakeshadr

GitHub user rakeshadr opened a pull request:

https://github.com/apache/zookeeper/pull/101

ZOOKEEPER-2383



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rakeshadr/zookeeper-1 ZK-2383

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #101


commit 401ce15e7cd1eeb0e8cef367bff53c1054ea17df
Author: Rakesh Radhakrishnan 
Date:   2016-11-06T16:24:53Z

ZOOKEEPER-2383




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Failed: ZOOKEEPER- PreCommit Build #43

2016-11-06 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/43/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 456264 lines...]
 [exec] +1 tests included.  The patch appears to include 15 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] -1 findbugs.  The patch appears to introduce 19 new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/43//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/43//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/43//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] c955d792354478cd5d5bc5b272f5630bae7d3486 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1627:
 exec returned: 2

Total time: 18 minutes 16 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2624
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2624) Add test script for pull requests

2016-11-06 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642027#comment-15642027
 ] 

Hadoop QA commented on ZOOKEEPER-2624:
--

-1 overall.  GitHub Pull Request  Build
  

-1 @author.  The patch appears to contain 6 @author tags which the 
Zookeeper community has agreed to not allow in code contributions.

+1 tests included.  The patch appears to include 15 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 19 new Findbugs (version 
3.0.1) warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/43//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/43//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/43//console

This message is automatically generated.

> Add test script for pull requests
> -
>
> Key: ZOOKEEPER-2624
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2624
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: scripts
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>
> We need a script similar to {{test-patch.sh}} to handle QA builds for pull 
> requests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2624) Add test script for pull requests

2016-11-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642019#comment-15642019
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2624:
---

Github user breed commented on the issue:

https://github.com/apache/zookeeper/pull/97
  
agreed


> Add test script for pull requests
> -
>
> Key: ZOOKEEPER-2624
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2624
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: scripts
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>
> We need a script similar to {{test-patch.sh}} to handle QA builds for pull 
> requests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #97: ZOOKEEPER-2624: Add test script for pull requests

2016-11-06 Thread breed

Github user breed commented on the issue:

https://github.com/apache/zookeeper/pull/97
  
agreed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2624) Add test script for pull requests

2016-11-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642010#comment-15642010
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2624:
---

Github user fpj commented on the issue:

https://github.com/apache/zookeeper/pull/97
  
@breed @rgs1 let's get this in, I'll create a jira to cleanup the script. 
Note that a lot of the issues you pointed out are legacy from the other script, 
so we will probably want to address in both.


> Add test script for pull requests
> -
>
> Key: ZOOKEEPER-2624
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2624
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: scripts
>Reporter: Flavio Junqueira
>Assignee: Flavio Junqueira
>
> We need a script similar to {{test-patch.sh}} to handle QA builds for pull 
> requests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #97: ZOOKEEPER-2624: Add test script for pull requests

2016-11-06 Thread fpj

Github user fpj commented on the issue:

https://github.com/apache/zookeeper/pull/97
  
@breed @rgs1 let's get this in, I'll create a jira to cleanup the script. 
Note that a lot of the issues you pointed out are legacy from the other script, 
so we will probably want to address in both.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

ZooKeeper_branch35_openjdk7 - Build # 288 - Still Failing

2016-11-06 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/288/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 444986 lines...]
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-11-06 10:08:23,238 [myid:127.0.0.1:27501] - INFO  
[main-SendThread(127.0.0.1:27501):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:27501. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-11-06 10:08:23,238 [myid:127.0.0.1:27501] - WARN  
[main-SendThread(127.0.0.1:27501):ClientCnxn$SendThread@1235] - Session 
0x100883b0d2c for server 127.0.0.1/127.0.0.1:27501, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-11-06 10:08:23,771 [myid:127.0.0.1:27380] - INFO  
[main-SendThread(127.0.0.1:27380):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:27380. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-11-06 10:08:23,772 [myid:127.0.0.1:27380] - WARN  
[main-SendThread(127.0.0.1:27380):ClientCnxn$SendThread@1235] - Session 
0x1008837557b for server 127.0.0.1/127.0.0.1:27380, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-11-06 10:08:23,962 [myid:] - INFO  [ProcessThread(sid:0 
cport:27624)::PrepRequestProcessor@647] - Processed session termination for 
sessionid: 0x100883df3dd
[junit] 2016-11-06 10:08:23,965 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port27624,name1=Connections,name2=127.0.0.1,name3=0x100883df3dd]
[junit] 2016-11-06 10:08:23,965 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x100883df3dd
[junit] 2016-11-06 10:08:23,966 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x100883df3dd closed
[junit] 2016-11-06 10:08:23,966 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 67941
[junit] 2016-11-06 10:08:23,966 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 467
[junit] 2016-11-06 10:08:23,966 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2016-11-06 10:08:23,967 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-11-06 10:08:23,967 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-11-06 10:08:23,967 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:27624
[junit] 2016-11-06 10:08:23,973 [myid:] - INFO  [main:ZooKeeperServer@529] 
- shutting down
[junit] 2016-11-06 10:08:23,973 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-11-06 10:08:23,974 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-11-06 10:08:23,974 [myid:] - INFO  
[main:PrepRequestProcessor@965] - Shutting down
[junit] 2016-11-06 10:08:23,974 [myid:] - INFO  [ProcessThread(sid:0 
cport:27624)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop!
[junit] 2016-11-06 10:08:23,975 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-11-06 10:08:23,975 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2016-11-06 10:08:23,975 [myid:] - INFO  
[main:FinalRequestProcessor@479] - shutdown of request processor complete
[junit] 2016-11-06 10:08:23,976 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port27624,name1=InMemoryDataTree]
[junit] 2016-11-06 10:08:23,976 [myid:] - INFO  [main:MBeanRegistry@128] -

ZooKeeper_branch35_jdk7 - Build # 723 - Failure

2016-11-06 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/723/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 471355 lines...]
[junit] Tests run: 101, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
566.743 sec, Thread: 7, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2016-11-06 08:52:56,524 [myid:127.0.0.1:27380] - INFO  
[main-SendThread(127.0.0.1:27380):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:27380. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-11-06 08:52:56,524 [myid:127.0.0.1:27380] - WARN  
[main-SendThread(127.0.0.1:27380):ClientCnxn$SendThread@1235] - Session 
0x1033e1b348f for server 127.0.0.1/127.0.0.1:27380, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-11-06 08:52:56,761 [myid:127.0.0.1:27504] - INFO  
[main-SendThread(127.0.0.1:27504):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:27504. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-11-06 08:52:56,762 [myid:127.0.0.1:27504] - WARN  
[main-SendThread(127.0.0.1:27504):ClientCnxn$SendThread@1235] - Session 
0x2033e208df2 for server 127.0.0.1/127.0.0.1:27504, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-11-06 08:55:43,314 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 29463
[junit] 2016-11-06 08:55:43,314 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 55
[junit] 2016-11-06 08:55:43,314 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testManyChildWatchersAutoReset
[junit] 2016-11-06 08:55:43,315 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-11-06 08:55:43,317 [myid:] - INFO  [ProcessThread(sid:0 
cport:19304)::PrepRequestProcessor@647] - Processed session termination for 
sessionid: 0x1033e19134a
[junit] 2016-11-06 08:55:43,346 [myid:] - INFO  
[NIOWorkerThread-30:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port19304,name1=Connections,name2=127.0.0.1,name3=0x1033e19134a]
[junit] 2016-11-06 08:55:43,347 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x1033e19134a closed
[junit] 2016-11-06 08:55:43,347 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1033e19134a
[junit] 2016-11-06 08:55:43,347 [myid:] - INFO  
[NIOWorkerThread-30:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:37321 which had sessionid 0x1033e19134a
[junit] 2016-11-06 08:55:43,349 [myid:] - INFO  [ProcessThread(sid:0 
cport:19304)::PrepRequestProcessor@647] - Processed session termination for 
sessionid: 0x1033e19134a0001
[junit] 2016-11-06 08:55:43,374 [myid:] - INFO  
[NIOWorkerThread-17:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port19304,name1=Connections,name2=127.0.0.1,name3=0x1033e19134a0001]
[junit] 2016-11-06 08:55:43,374 [myid:] - INFO  
[NIOWorkerThread-17:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:37322 which had sessionid 0x1033e19134a0001
[junit] 2016-11-06 08:55:43,375 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x1033e19134a0001 closed
[junit] 2016-11-06 08:55:43,375 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-11-06 08:55:43,375 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1033e19134a0001
[junit] 2016-11-06 08:55:43,376 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:19304:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-11-06 08:55:43,376 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-11-06

ZooKeeper-trunk-solaris - Build # 1374 - Still Failing

2016-11-06 Thread Apache Jenkins Server

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1374/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 458240 lines...]
[junit] 2016-11-06 08:33:07,912 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-11-06 08:33:07,913 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-11-06 08:33:07,915 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-11-06 08:33:07,916 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-11-06 08:33:07,916 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-11-06 08:33:07,917 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-11-06 08:33:07,917 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test8679662328143858913.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test8679662328143858913.junit.dir/version-2
[junit] 2016-11-06 08:33:07,918 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test8679662328143858913.junit.dir/version-2/snapshot.b
[junit] 2016-11-06 08:33:07,920 [myid:] - INFO  [main:FileTxnSnapLog@306] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/build/test/tmp/test8679662328143858913.junit.dir/version-2/snapshot.b
[junit] 2016-11-06 08:33:07,922 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-11-06 08:33:07,922 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-11-06 08:33:07,922 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:60059
[junit] 2016-11-06 08:33:07,923 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:60059
[junit] 2016-11-06 08:33:07,923 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-11-06 08:33:07,923 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:60059 (no session established for client)
[junit] 2016-11-06 08:33:07,924 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-11-06 08:33:07,925 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-11-06 08:33:07,925 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-11-06 08:33:07,925 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-11-06 08:33:07,925 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-11-06 08:33:07,926 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17665
[junit] 2016-11-06 08:33:07,926 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-11-06 08:33:07,926 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-11-06 08:33:07,926 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-11-06 08:33:08,002 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x124b5bf99aa
[junit] 2016-11-06 08:33:08,002 [myid:] - INFO  [main:ZooKeeper@1315] - 
Session: 0x124b5bf99aa closed
[junit] 2016-11-06 08:33:08,003 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-11-06 08:33:08,003 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-11-06 08:33:08,003 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-11-06 08:33:08,003 [myid:] - INFO

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

2016-11-06 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15641347#comment-15641347
 ] 

Hadoop QA commented on ZOOKEEPER-2014:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12837643/ZOOKEEPER-2014.patch
  against trunk revision bcb07a09b06c91243ed244f04a71b8daf629e286.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 57 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 20 new Findbugs (version 
3.0.1) warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3524//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3524//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3524//console

This message is automatically generated.

> Only admin should be allowed to reconfig a cluster
> --
>
> Key: ZOOKEEPER-2014
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Raul Gutierrez Segales
>Assignee: Michael Han
>Priority: Blocker
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch
>
>
> ZOOKEEPER-107 introduces reconfiguration support via the reconfig() call. We 
> should, at the very least, ensure that only the Admin can reconfigure a 
> cluster. Perhaps restricting access to /zookeeper/config as well, though this 
> is debatable. Surely one could ensure Admin only access via an ACL, but that 
> would leave everyone who doesn't use ACLs unprotected. We could also force a 
> default ACL to make it a bit more consistent (maybe).
> Finally, making reconfig() only available to Admins means they have to run 
> with zookeeper.DigestAuthenticationProvider.superDigest (which I am not sure 
> if everyone does, or how would it work with other authentication providers). 
> Review board https://reviews.apache.org/r/51546/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER-2014 PreCommit Build #3524

2016-11-06 Thread Apache Jenkins Server

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3524/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 473553 lines...]
 [exec] +1 tests included.  The patch appears to include 57 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] -1 findbugs.  The patch appears to introduce 20 new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3524//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3524//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3524//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] b0fc0d7dc78c8477dccc3944c6f73624e7ad5e77 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1605: 
exec returned: 1

Total time: 18 minutes 19 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2014
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

2016-11-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15641319#comment-15641319
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2014:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/96
  
Thanks @breed and @rgs1 for your time and review feedback. Pull request, 
patch, and review board is now updated.


> Only admin should be allowed to reconfig a cluster
> --
>
> Key: ZOOKEEPER-2014
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Raul Gutierrez Segales
>Assignee: Michael Han
>Priority: Blocker
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch
>
>
> ZOOKEEPER-107 introduces reconfiguration support via the reconfig() call. We 
> should, at the very least, ensure that only the Admin can reconfigure a 
> cluster. Perhaps restricting access to /zookeeper/config as well, though this 
> is debatable. Surely one could ensure Admin only access via an ACL, but that 
> would leave everyone who doesn't use ACLs unprotected. We could also force a 
> default ACL to make it a bit more consistent (maybe).
> Finally, making reconfig() only available to Admins means they have to run 
> with zookeeper.DigestAuthenticationProvider.superDigest (which I am not sure 
> if everyone does, or how would it work with other authentication providers). 
> Review board https://reviews.apache.org/r/51546/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #96: ZOOKEEPER-2014: Only admin should be allowed to reconfi...

2016-11-06 Thread hanm

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/96
  
Thanks @breed and @rgs1 for your time and review feedback. Pull request, 
patch, and review board is now updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 51546: ZOOKEEPER-2014: Only admin should be allowed to reconfig a cluster

2016-11-06 Thread Michael Han


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51546/
---

(Updated Nov. 6, 2016, 7:02 a.m.)


Review request for zookeeper, fpj, Patrick Hunt, Raul Gutierrez Segales, and 
Alexander Shraer.


Changes
---

Update patch to address review comments from Ben and Raul.

Note - patch on JIRA and GIT PR is updated too, for the record.


Bugs: ZOOKEEPER-2014
https://issues.apache.org/jira/browse/ZOOKEEPER-2014


Repository: zookeeper-git


Description
---

Address various security concerns around reconfig feature (ZOOKEEPER-2014) to 
unblock 3.5.3 release.


Diffs (updated)
-

  build.xml 5328035 
  src/c/include/zookeeper.h 18a203d 
  src/c/tests/TestReconfigServer.cc 6a429ac 
  src/c/tests/ZooKeeperQuorumServer.h aa8b7cc 
  src/c/tests/ZooKeeperQuorumServer.cc 23392cd 
  src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 5a30da8 
  src/docs/src/documentation/content/xdocs/zookeeperReconfig.xml 7168a01 
  src/java/main/org/apache/zookeeper/ClientCnxn.java 12dd51c 
  src/java/main/org/apache/zookeeper/KeeperException.java a05f1ab 
  src/java/main/org/apache/zookeeper/ZooKeeper.java 1c9ed4e 
  src/java/main/org/apache/zookeeper/ZooKeeperMain.java c39395a 
  src/java/main/org/apache/zookeeper/admin/ZooKeeperAdmin.java PRE-CREATION 
  src/java/main/org/apache/zookeeper/cli/CliCommand.java 3d0a90b 
  src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java deb7914 
  src/java/main/org/apache/zookeeper/server/DataTree.java 4666578 
  src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java e275f9c 
  src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java d4f150b 
  src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 885a5e1 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 
24a4ec1 
  src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java bfe8588 
  src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java 109c1b5 
  src/java/test/org/apache/zookeeper/TestableZooKeeper.java 4d46fdf 
  src/java/test/org/apache/zookeeper/server/DataTreeTest.java d726643 
  src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 4debe74 
  src/java/test/org/apache/zookeeper/server/quorum/RaceConditionTest.java 
ef7f3df 
  src/java/test/org/apache/zookeeper/server/quorum/ReconfigBackupTest.java 
241af52 
  
src/java/test/org/apache/zookeeper/server/quorum/ReconfigDuringLeaderSyncTest.java
 301837d 
  
src/java/test/org/apache/zookeeper/server/quorum/ReconfigFailureCasesTest.java 
e7147b3 
  src/java/test/org/apache/zookeeper/server/quorum/ReconfigLegacyTest.java 
37bd8e4 
  src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java 
1f6ce1f 
  src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 6a01447 
  src/java/test/org/apache/zookeeper/test/ACLTest.java 9920fc4 
  src/java/test/org/apache/zookeeper/test/ReconfigExceptionTest.java 
PRE-CREATION 
  src/java/test/org/apache/zookeeper/test/ReconfigMisconfigTest.java 
PRE-CREATION 
  src/java/test/org/apache/zookeeper/test/ReconfigTest.java 248a754 
  src/java/test/org/apache/zookeeper/test/StandaloneTest.java 5c95280 

Diff: https://reviews.apache.org/r/51546/diff/


Testing
---


Thanks,

Michael Han

[jira] [Updated] (ZOOKEEPER-2014) Only admin should be allowed to reconfig a cluster

2016-11-06 Thread Michael Han (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han updated ZOOKEEPER-2014:
---
Attachment: ZOOKEEPER-2014.patch

Update patch for addressing review comments from Ben and Raul.

> Only admin should be allowed to reconfig a cluster
> --
>
> Key: ZOOKEEPER-2014
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2014
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.0
>Reporter: Raul Gutierrez Segales
>Assignee: Michael Han
>Priority: Blocker
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, ZOOKEEPER-2014.patch, 
> ZOOKEEPER-2014.patch
>
>
> ZOOKEEPER-107 introduces reconfiguration support via the reconfig() call. We 
> should, at the very least, ensure that only the Admin can reconfigure a 
> cluster. Perhaps restricting access to /zookeeper/config as well, though this 
> is debatable. Surely one could ensure Admin only access via an ACL, but that 
> would leave everyone who doesn't use ACLs unprotected. We could also force a 
> default ACL to make it a bit more consistent (maybe).
> Finally, making reconfig() only available to Admins means they have to run 
> with zookeeper.DigestAuthenticationProvider.superDigest (which I am not sure 
> if everyone does, or how would it work with other authentication providers). 
> Review board https://reviews.apache.org/r/51546/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Failed: ZOOKEEPER- PreCommit Build #42

2016-11-06 Thread Apache Jenkins Server

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/42/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 26 lines...]
Done: 65
  Compressing objects
Done: 243195
  Writing objects
Done: 69
  remote: Resolving deltas
  remote: Updating references
Merging refs/tags/changes/42
 > git rev-parse refs/tags/changes/42^{commit} # timeout=10
 > git merge c681cccfe88b1dad4c81490c3d6fe916b99f00ba # timeout=10
 > git rev-parse master^{commit} # timeout=10
Checking out Revision c681cccfe88b1dad4c81490c3d6fe916b99f00ba (master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f c681cccfe88b1dad4c81490c3d6fe916b99f00ba
 > git rev-parse origin/master^{commit} # timeout=10
 > git rev-list bcb07a09b06c91243ed244f04a71b8daf629e286 # timeout=10
No emails were triggered.
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[PreCommit-ZOOKEEPER-github-pr-build] $ /bin/bash 
/tmp/hudson672030888157426416.sh
/home/jenkins/tools/java/latest1.7/bin/java
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
core file size  (blocks, -c) 0
data seg size   (kbytes, -d) unlimited
scheduling priority (-e) 0
file size   (blocks, -f) unlimited
pending signals (-i) 386178
max locked memory   (kbytes, -l) 64
max memory size (kbytes, -m) unlimited
open files  (-n) 6
pipe size(512 bytes, -p) 8
POSIX message queues (bytes, -q) 819200
real-time priority  (-r) 0
stack size  (kbytes, -s) 8192
cpu time   (seconds, -t) unlimited
max user processes  (-u) 10240
virtual memory  (kbytes, -v) unlimited
file locks  (-x) unlimited
Buildfile: 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml

BUILD FAILED
Target "qa-test-pullrequest" does not exist in the project "ZooKeeper". 

Total time: 0 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
[description-setter] Could not determine description.
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2627) Remove ZRWSERVERFOUND from C client and replace handle_error with something more semantically explicit for r/w server reconnect.

2016-11-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15641257#comment-15641257
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2627:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/100
  
@rgs1 Sure, no need to rush this in.


> Remove ZRWSERVERFOUND from C client and replace handle_error with something 
> more semantically explicit for r/w server reconnect.
> 
>
> Key: ZOOKEEPER-2627
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2627
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.2
>Reporter: Michael Han
>Assignee: Michael Han
> Fix For: 3.5.3
>
> Attachments: ZOOKEEPER-2627.patch, ZOOKEEPER-2627.patch
>
>
> While working on ZOOKEEPER-2014, I noticed a discrepancy between Java and C 
> client regarding the error codes definition. There is a 
> {noformat}ZRWSERVERFOUND = -122{noformat} definition in C client which is not 
> present in Java client's KeeperException.Code definitions. 
> This discrepancy was introduced by ZOOKEEPER-827, where the C client logic 
> was simulating the Java client's logic when doing a read/write server search 
> while client is in read only mode. Once client finds a valid read/write 
> server, client will try to disconnect and reconnect with this read/write 
> server, as we always prefer r/w server in ro mode. The way Java client is 
> doing this disconnect/reconnect process is by throwing a 
> RWServerFoundException (instead of a KeeperException) to set the client in 
> disconnected state, then wait for client reconnect with r/w server address 
> set before throwing the exception. C client did similar but instead of having 
> an explicitly disconnect / clean up routine, the client was relying on 
> handle_error to do the job where ZRWSERVERFOUND was introduced.
> I propose we remove ZRWSERVERFOUND error code from C client and use an 
> explicit routine instead of handle_error when we do r/w server search in C 
> client for two reasons:
> * ZRWSERVERFOUND is not something ZK client users would need to know. It's a 
> pure implementation detail that's used to alter the connection state of the 
> client, and ZK client users have no desire nor need to handle such errors, as 
> R/W server scanning and connect is handled transparently by ZK client library.
> * To maintain consistency between Java and C client regarding error codes 
> definition. Without removing this from C client, we would need to replace 
> RWServerFoundException in Java client with a new KeeperException, and again 
> with the reason mentioned above, we don't need a KeeperException for this 
> because such implementation detail does not have to be exposed to end users 
> (unless, we provided alternative for users to opt-out automate R/W server 
> switching when in read only mode which we don't.).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zookeeper issue #100: ZOOKEEPER-2627:Remove ZRWSERVERFOUND from C client.

2016-11-06 Thread hanm

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/100
  
@rgs1 Sure, no need to rush this in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

46 matches

Mail list logo