ZOOKEEPER-2624 has been merged, thank Raul, Ben and Michael for reviewing. The QA for pull requests should be working for pull requests agains master, but let's keep an eye and polish any rough edges that might still be there.
With ZOOKEEPER-2624 in, there is one last major decision we need to make to wrap this up. The pull request QA currently do not make a jira patch available. This is intentional because making it patch available will trigger the original Jira QA, which will be confusing because we will see a failure (I haven't tested, but I think that's what's going to happen). If we change the script to make the Jira patch available, then we need to either: 1- Disable the Jira QA altogether, which means that we will only have pull request QA available 2- Make the Jira QA script spot that there is a pull request available and not build it. I'm wondering if folks would be ok with only having patches submitted via pull requests or if we should continue to support the old Jira QA. Thanks, -Flavio > On 02 Nov 2016, at 15:58, Flavio Junqueira <f...@apache.org> wrote: > > Can I get reviews on ZOOKEEPER-2624/Pull Request #97, please? Once that gets > in, we will have pull request QA working. > > Thanks, > -Flavio > >> On 31 Oct 2016, at 18:26, Edward Ribeiro <edward.ribe...@gmail.com> wrote: >> >> My comments below: >> >> On Mon, Oct 31, 2016 at 4:07 PM, Flavio Junqueira <f...@apache.org> wrote: >> >>> >>> >> Feel free to contribute to my changes and suggest a different way in the >>> jira. We can definitely work together on this, I just want to have this >>> working soon. >>> >> >> Ok. I don't want to slow down your current work in progress, so I will try >> to see IF/WHAT I can contribute, but will let you know before hand. :) >> >> >> >>> >>> The script is bash, not python. >> >> >> Yup, in fact, I wrote the script with the intention of adding the option >> of attaching the diff to the JIRA issue to zk-merge-pr.py tool. It woud be >> for the sake of documeting the patch in the JIRA. Maybe I will create a new >> issue proposing this once we have the other things sorted out, and only if >> you guys think this is worth doing. >> >> >> >>> It doesn't make it patch available mainly because if we make it patch >>> available, then it will trigger the Jira QA, which will find no patch. It >>> is a bit messy to trigger this second build, so I'm reluctant in doing it. >>> I can see two options: >>> >>> - Only do github pull requests, in which case "Patch Available" in our >>> workflow means pull request available >>> - Somehow detect that there is a pull request and no trigger the Jira QA >>> >> >> IMHO, the the first option is less brittle and effective. >> >> Edward >
