[jira] [Commented] (ZOOKEEPER-2471) Java Zookeeper Client incorrectly considers time spent sleeping as time spent connecting, potentially resulting in infinite reconnect loop

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136328#comment-16136328
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2471:
---

Github user nicktrav commented on the issue:

https://github.com/apache/zookeeper/pull/330
  
@DanBenediktson - I've been looking into writing a test for this patch, but 
I can't seem to replicate the case you speak about on the original ticket.

Specifically:

> The exact code path it goes through in this case is complicated, because 
there has to be a previously-closed socket still waiting in the selector 
(otherwise, the first timeout evaluation will not fail because "now" still 
hasn't been updated, and then the actual connect timeout will be applied in 
ClientCnxnSocket.doTransport()) so that select() will harvest the IO from the 
previous socket and updateNow(), resulting in the next loop through 
ClientCnxnSocket.SendThread.run() observing the spurious timeout and failing.

Are you able to provide some more details on how this client can get into 
this state? Walking through the code, I'm having difficulty understanding how 
the client can end up a reconnect loop.

We are keen to see this patch land as it would make a fix for 
ZOOKEEPER-2869 inherently safer.


> Java Zookeeper Client incorrectly considers time spent sleeping as time spent 
> connecting, potentially resulting in infinite reconnect loop
> --
>
> Key: ZOOKEEPER-2471
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2471
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.5.3
> Environment: all
>Reporter: Dan Benediktson
>Assignee: Dan Benediktson
> Attachments: ZOOKEEPER-2471.patch
>
>
> ClientCnxnSocket uses a member variable "now" to track the current time, and 
> lastSend / lastHeard variables to track socket liveness. Implementations, and 
> even ClientCnxn itself, are expected to call both updateNow() to reset "now" 
> to System.currentTimeMillis, and then call updateLastSend()/updateLastHeard() 
> on IO completions.
> This is a fragile contract, so it's not surprising that there's a bug 
> resulting from it: ClientCnxn.SendThread.run() calls updateLastSendAndHeard() 
> as soon as startConnect() returns, but it does not call updateNow() first. I 
> expect when this was written, either the expectation was that startConnect() 
> was an asynchronous operation and that updateNow() would have been called 
> very recently, or simply the requirement to call updateNow() was forgotten at 
> this point. As far as I can see, this bug has been present since the 
> "updateNow" method was first introduced in the distant past. As it turns out, 
> since startConnect() calls HostProvider.next(), which can sleep, quite a lot 
> of time can pass, leaving a big gap between "now" and now.
> If you are using very short session timeouts (one of our ZK ensembles has 
> many clients using a 1-second timeout), this is potentially disastrous, 
> because the sleep time may exceed the connection timeout itself, which can 
> potentially result in the Java client being stuck in a perpetual reconnect 
> loop. The exact code path it goes through in this case is complicated, 
> because there has to be a previously-closed socket still waiting in the 
> selector (otherwise, the first timeout evaluation will not fail because "now" 
> still hasn't been updated, and then the actual connect timeout will be 
> applied in ClientCnxnSocket.doTransport()) so that select() will harvest the 
> IO from the previous socket and updateNow(), resulting in the next loop 
> through ClientCnxnSocket.SendThread.run() observing the spurious timeout and 
> failing. In practice it does happen to us fairly frequently; we only got to 
> the bottom of the bug yesterday. Worse, when it does happen, the Zookeeper 
> client object is rendered unusable: it's stuck in a perpetual reconnect loop 
> where it keeps sleeping, opening a socket, and immediately closing it.
> I have a patch. Rather than calling updateNow() right after startConnect(), 
> my fix is to remove the "now" member variable and the updateNow() method 
> entirely, and to instead just call System.currentTimeMillis() whenever time 
> needs to be evaluated. I realize there is a benefit (aside from a trivial 
> micro-optimization not worth worrying about) to having the time be "fixed", 
> particularly for truth in the logging: if time is fixed by an updateNow() 
> call, then the log for a timeout will still show exactly the same value the 
> code reasoned about. However, this benefit is in my opinion not enough to 
> merit the fragility of the contract which led to this 

[GitHub] zookeeper issue #330: ZOOKEEPER-2471: ZK Java client should not count sleep ...

[nicktrav]

Github user nicktrav commented on the issue:

https://github.com/apache/zookeeper/pull/330
  
@DanBenediktson - I've been looking into writing a test for this patch, but 
I can't seem to replicate the case you speak about on the original ticket.

Specifically:

> The exact code path it goes through in this case is complicated, because 
there has to be a previously-closed socket still waiting in the selector 
(otherwise, the first timeout evaluation will not fail because "now" still 
hasn't been updated, and then the actual connect timeout will be applied in 
ClientCnxnSocket.doTransport()) so that select() will harvest the IO from the 
previous socket and updateNow(), resulting in the next loop through 
ClientCnxnSocket.SendThread.run() observing the spurious timeout and failing.

Are you able to provide some more details on how this client can get into 
this state? Walking through the code, I'm having difficulty understanding how 
the client can end up a reconnect loop.

We are keen to see this patch land as it would make a fix for 
ZOOKEEPER-2869 inherently safer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2879) Adding observers dynamically without server id

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136321#comment-16136321
 ] 

Michael Han commented on ZOOKEEPER-2879:


Session id is required to be unique across ensemble only if the session is 
global session; for local sessions I don't think there is a hard requirement 
for them to be unique since their scope is limited to each server that hosting 
the session. Because of this it seems we can only use this feature when local 
session is enabled.

> Adding observers dynamically without server id
> --
>
> Key: ZOOKEEPER-2879
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2879
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Affects Versions: 3.6.0
>Reporter: Fangmin Lv
>Assignee: Fangmin Lv
>
> Dynamic config requires observer has unique server id, which means we cannot 
> simply add observer with dynamic server id -1. For large observer cluster, 
> it's much more easier to add observer without unique server id if it doesn't 
> need to be promoted to participant. Also, it will make dynamic config more 
> efficient, we don't need to store and send the long list of observers during 
> re-config.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han updated ZOOKEEPER-1260:
---
Component/s: server

> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136266#comment-16136266
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1260:
---

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r134382180
  
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -931,7 +931,19 @@ server.3=zoo3:2888:3888
   feature. Default is "true"
 
   
-
+  
+audit.enabled
+
+(Java system property:
+zookeeper.audit.enabled)
+
+
+New in 3.5.3:
--- End diff --

This should be 3.5.4 at least. We've shipped 3.5.3 already :)


> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136267#comment-16136267
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1260:
---

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r134382249
  
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml 
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook/xml/simple/1.0/sdocbook.dtd;>
+
+  ZooKeeper Audit Logging
+  
+
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License. You 
may
+  obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0;>http://www.apache.org/licenses/LICENSE-2.0.
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an "AS IS"
+  BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express 
or
+  implied. See the License for the specific language governing 
permissions
+  and limitations under the License.
+
+
+
+This document contains information about Audit Logs in 
ZooKeeper.
+
+  
+  
+ZooKeeper Audit Logs
+Apache ZooKeeper supports audit logs form version 3.5.3. By 
default audit logs are disabled. To enable audit
+logs configure audit.enable=true in conf/zoo.cfg. Audit logs are not 
logged on all the ZooKeeper servers, but logged
+only on the servers where client is connected as depicted in bellow 
figure.
+
+
+
+
+
+The audit log captures the detailed information for the 
operations that are selected to be audited. The audit
+information is written as a set of key=value pairs for the following 
keys
--- End diff --

Nit: missing full stop after `following keys`


> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...

[hanm]

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r134382249
  
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml 
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook/xml/simple/1.0/sdocbook.dtd;>
+
+  ZooKeeper Audit Logging
+  
+
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License. You 
may
+  obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0;>http://www.apache.org/licenses/LICENSE-2.0.
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an "AS IS"
+  BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express 
or
+  implied. See the License for the specific language governing 
permissions
+  and limitations under the License.
+
+
+
+This document contains information about Audit Logs in 
ZooKeeper.
+
+  
+  
+ZooKeeper Audit Logs
+Apache ZooKeeper supports audit logs form version 3.5.3. By 
default audit logs are disabled. To enable audit
+logs configure audit.enable=true in conf/zoo.cfg. Audit logs are not 
logged on all the ZooKeeper servers, but logged
+only on the servers where client is connected as depicted in bellow 
figure.
+
+
+
+
+
+The audit log captures the detailed information for the 
operations that are selected to be audited. The audit
+information is written as a set of key=value pairs for the following 
keys
--- End diff --

Nit: missing full stop after `following keys`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...

[hanm]

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r134382180
  
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -931,7 +931,19 @@ server.3=zoo3:2888:3888
   feature. Default is "true"
 
   
-
+  
+audit.enabled
+
+(Java system property:
+zookeeper.audit.enabled)
+
+
+New in 3.5.3:
--- End diff --

This should be 3.5.4 at least. We've shipped 3.5.3 already :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136265#comment-16136265
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1260:
---

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r134382155
  
--- Diff: src/docs/src/documentation/content/xdocs/site.xml ---
@@ -52,6 +52,7 @@ See http://forrest.apache.org/docs/linking.html for more 
info.
   
   
   
+  
--- End diff --

Shouldn't this be something like `` rather than ` Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...

[hanm]

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r134382155
  
--- Diff: src/docs/src/documentation/content/xdocs/site.xml ---
@@ -52,6 +52,7 @@ See http://forrest.apache.org/docs/linking.html for more 
info.
   
   
   
+  
--- End diff --

Shouldn't this be something like `` rather than `

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136242#comment-16136242
 ] 

Michael Han commented on ZOOKEEPER-2845:


Thanks for the update, [~lvfangmin]. Good to know the patch is tested in prod 
environment!

> Data inconsistency issue due to retain database in leader election
> --
>
> Key: ZOOKEEPER-2845
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2845
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: quorum
>Affects Versions: 3.4.10, 3.5.3, 3.6.0
>Reporter: Fangmin Lv
>Assignee: Fangmin Lv
>Priority: Critical
>
> In ZOOKEEPER-2678, the ZKDatabase is retained to reduce the unavailable time 
> during leader election. In ZooKeeper ensemble, it's possible that the 
> snapshot is ahead of txn file (due to slow disk on the server, etc), or the 
> txn file is ahead of snapshot due to no commit message being received yet. 
> If snapshot is ahead of txn file, since the SyncRequestProcessor queue will 
> be drained during shutdown, the snapshot and txn file will keep consistent 
> before leader election happening, so this is not an issue.
> But if txn is ahead of snapshot, it's possible that the ensemble will have 
> data inconsistent issue, here is the simplified scenario to show the issue:
> Let's say we have a 3 servers in the ensemble, server A and B are followers, 
> and C is leader, and all the snapshot and txn are up to T0:
> 1. A new request reached to leader C to create Node N, and it's converted to 
> txn T1 
> 2. Txn T1 was synced to disk in C, but just before the proposal reaching out 
> to the followers, A and B restarted, so the T1 didn't exist in A and B
> 3. A and B formed a new quorum after restart, let's say B is the leader
> 4. C changed to looking state due to no enough followers, it will sync with 
> leader B with last Zxid T0, which will have an empty diff sync
> 5. Before C take snapshot it restarted, it replayed the txns on disk which 
> includes T1, now it will have Node N, but A and B doesn't have it.
> Also I included the a test case to reproduce this issue consistently. 
> We have a totally different RetainDB version which will avoid this issue by 
> doing consensus between snapshot and txn files before leader election, will 
> submit for review.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (ZOOKEEPER-2880) Rename README.txt to README.md

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han reassigned ZOOKEEPER-2880:
--

Assignee: Manoj Mallela

> Rename README.txt to README.md
> --
>
> Key: ZOOKEEPER-2880
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2880
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: other
>Reporter: Michael Han
>Assignee: Manoj Mallela
>Priority: Minor
>  Labels: newbie
>
> This task is to rename the README.txt to README.md so github can render the 
> mark downs. The added benefit is https://github.com/apache/zookeeper will 
> look cooler as we are adding more mark downs to the README file...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ZOOKEEPER-2880) Rename README.txt to README.md

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han updated ZOOKEEPER-2880:
---
Labels: newbie  (was: )

> Rename README.txt to README.md
> --
>
> Key: ZOOKEEPER-2880
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2880
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: other
>Reporter: Michael Han
>Priority: Minor
>  Labels: newbie
>
> This task is to rename the README.txt to README.md so github can render the 
> mark downs. The added benefit is https://github.com/apache/zookeeper will 
> look cooler as we are adding more mark downs to the README file...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2880) Rename README.txt to README.md

[Manoj Mallela (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136186#comment-16136186
 ] 

Manoj Mallela commented on ZOOKEEPER-2880:
--

[~hanm]: I would like to create a PR for this one, please assign this to me.

> Rename README.txt to README.md
> --
>
> Key: ZOOKEEPER-2880
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2880
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: other
>Reporter: Michael Han
>Priority: Minor
>
> This task is to rename the README.txt to README.md so github can render the 
> mark downs. The added benefit is https://github.com/apache/zookeeper will 
> look cooler as we are adding more mark downs to the README file...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[Discuss] Rename README.txt to README.md

[Michael Han]

Hi folks,

I propose we rename README.txt to README.md (ZOOKEEPER-2880
), so github can
render the mark downs which support better and richer formatting options
than txt file. There are lots of existing Apache projects (e.g. Spark,
Cassandra, ) use md file instead of txt file for README, and I am not
aware of any constraints that prevent us doing the same for ZooKeeper.

Please let me know if you have any concern for such a change.

-- 
Cheers
Michael.

[jira] [Created] (ZOOKEEPER-2880) Rename README.txt to README.md

[Michael Han (JIRA)]

Michael Han created ZOOKEEPER-2880:
--

 Summary: Rename README.txt to README.md
 Key: ZOOKEEPER-2880
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2880
 Project: ZooKeeper
  Issue Type: Improvement
  Components: other
Reporter: Michael Han
Priority: Minor


This task is to rename the README.txt to README.md so github can render the 
mark downs. The added benefit is https://github.com/apache/zookeeper will look 
cooler as we are adding more mark downs to the README file...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ZooKeeper-trunk-openjdk7 - Build # 1590 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1590/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 60.79 MB...]
[junit] 2017-08-22 01:17:56,109 [myid:127.0.0.1:19301] - INFO  
[main-SendThread(127.0.0.1:19301):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:19301. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-08-22 01:17:56,109 [myid:127.0.0.1:19301] - WARN  
[main-SendThread(127.0.0.1:19301):ClientCnxn$SendThread@1235] - Session 
0x1063271f26b for server 127.0.0.1/127.0.0.1:19301, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-08-22 01:17:56,182 [myid:127.0.0.1:19430] - INFO  
[main-SendThread(127.0.0.1:19430):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:19430. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-08-22 01:17:56,182 [myid:127.0.0.1:19430] - WARN  
[main-SendThread(127.0.0.1:19430):ClientCnxn$SendThread@1235] - Session 
0x3063274dcb1 for server 127.0.0.1/127.0.0.1:19430, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-08-22 01:17:56,240 [myid:127.0.0.1:19365] - INFO  
[main-SendThread(127.0.0.1:19365):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:19365. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-08-22 01:17:56,240 [myid:127.0.0.1:19365] - WARN  
[main-SendThread(127.0.0.1:19365):ClientCnxn$SendThread@1235] - Session 
0x10632729c38 for server 127.0.0.1/127.0.0.1:19365, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-08-22 01:17:56,468 [myid:] - INFO  [ProcessThread(sid:0 
cport:19547)::PrepRequestProcessor@614] - Processed session termination for 
sessionid: 0x10632781d65
[junit] 2017-08-22 01:17:56,469 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port19547,name1=Connections,name2=127.0.0.1,name3=0x10632781d65]
[junit] 2017-08-22 01:17:56,469 [myid:] - INFO  [main:ZooKeeper@1332] - 
Session: 0x10632781d65 closed
[junit] 2017-08-22 01:17:56,469 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x10632781d65
[junit] 2017-08-22 01:17:56,469 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 237339
[junit] 2017-08-22 01:17:56,470 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 2432
[junit] 2017-08-22 01:17:56,470 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-08-22 01:17:56,470 [myid:] - INFO  [main:ClientBase@601] - 
tearDown starting
[junit] 2017-08-22 01:17:56,470 [myid:] - INFO  [main:ClientBase@571] - 
STOPPING server
[junit] 2017-08-22 01:17:56,470 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:19547
[junit] 2017-08-22 01:17:56,479 [myid:] - INFO  [main:ZooKeeperServer@545] 
- shutting down
[junit] 2017-08-22 01:17:56,480 [myid:] - ERROR [main:ZooKeeperServer@509] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-08-22 01:17:56,480 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-08-22 01:17:56,481 [myid:] - INFO  
[main:PrepRequestProcessor@1010] - Shutting down
[junit] 

[jira] [Commented] (ZOOKEEPER-1985) Memory leak in C client

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136004#comment-16136004
 ] 

Michael Han commented on ZOOKEEPER-1985:


I think this is an important issue to fix.

[~desmondhe] Not sure if you are still working on this since it's been three 
years since you filed the issue, but just checking - will you be able to update 
the patch (if needed) and create a pull request to zookeeper git repo? See 
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute for more 
details on how to create pull request etc.

> Memory leak in C client
> ---
>
> Key: ZOOKEEPER-1985
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1985
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.4.6
>Reporter: desmondhe
>Assignee: desmondhe
>Priority: Critical
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1985.patch
>
>
> in the file zookeeper.c, most function call of "close_buffer_oarchive(, 
> 0)" shoud been instead by 
> close_buffer_oarchive(, rc < 0 ? 1 : 0); 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ZOOKEEPER-2867) an expired ZK session can be re-established

[Jun Rao (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jun Rao updated ZOOKEEPER-2867:
---
Attachment: 0.parsed_commit_log
1.parsed_commit_log
2.parsed_commit_log

[~hanm], attached please find the parsed commit log from ZK server 0, 1 and 2. 
If you grep for close on session 0x25cd1e82c110001, you will see it in broker 1 
and 2's commit log, but not on broker 0. Note that the timestamp in the commit 
log is PDT, which is 7 hours ahead of UTC time. All the log4j logs in this jira 
are using UTC time.

> an expired ZK session can be re-established
> ---
>
> Key: ZOOKEEPER-2867
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2867
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.10
>Reporter: Jun Rao
> Attachments: 0.parsed_commit_log, 1.parsed_commit_log, 
> 2.parsed_commit_log, zk.0.08-02, zk.0.08-02, zk.0.formatted, zk.1.08-02, 
> zk.1.08-02, zk.1.formatted, zk.2.08-02, zk.2.08-02
>
>
> Not sure if this is a real bug, but I found an instance when a ZK client 
> seems to be able to renew a session already expired by the ZK server.
> From ZK server log, session 25cd1e82c110001 was expired at 22:04:39.
> {code:java}
> June 27th 2017, 22:04:39.000  INFO
> org.apache.zookeeper.server.ZooKeeperServer Expiring session 
> 0x25cd1e82c110001, timeout of 12000ms exceeded
> June 27th 2017, 22:04:39.001  DEBUG   
> org.apache.zookeeper.server.quorum.Leader   Proposing:: 
> sessionid:0x25cd1e82c110001 type:closeSession cxid:0x0 zxid:0x20fc4 
> txntype:-11 reqpath:n/a
> June 27th 2017, 22:04:39.001  INFO
> org.apache.zookeeper.server.PrepRequestProcessorProcessed session 
> termination for sessionid: 0x25cd1e82c110001
> June 27th 2017, 22:04:39.001  DEBUG   
> org.apache.zookeeper.server.quorum.CommitProcessor  Processing request:: 
> sessionid:0x25cd1e82c110001 type:closeSession cxid:0x0 zxid:0x20fc4 
> txntype:-11 reqpath:n/a
> June 27th 2017, 22:05:20.324  INFO
> org.apache.zookeeper.server.quorum.Learner  Revalidating client: 
> 0x25cd1e82c110001
> June 27th 2017, 22:05:20.324  INFO
> org.apache.zookeeper.server.ZooKeeperServer Client attempting to renew 
> session 0x25cd1e82c110001 at /100.96.5.6:47618
> June 27th 2017, 22:05:20.325  INFO
> org.apache.zookeeper.server.ZooKeeperServer Established session 
> 0x25cd1e82c110001 with negotiated timeout 12000 for client /100.96.5.6:47618
> {code}
> From ZK client's log, it was able to renew the expired session on 22:05:20.
> {code:java}
> June 27th 2017, 22:05:18.590  INFOorg.apache.zookeeper.ClientCnxn Client 
> session timed out, have not heard from server in 4485ms for sessionid 
> 0x25cd1e82c110001, closing socket connection and attempting reconnect  0
> June 27th 2017, 22:05:18.590  WARNorg.apache.zookeeper.ClientCnxn Client 
> session timed out, have not heard from server in 4485ms for sessionid 
> 0x25cd1e82c110001  0
> June 27th 2017, 22:05:19.325  WARNorg.apache.zookeeper.ClientCnxn SASL 
> configuration failed: javax.security.auth.login.LoginException: No JAAS 
> configuration section named 'Client' was found in specified JAAS 
> configuration file: '/opt/confluent/etc/kafka/server_jaas.conf'. Will 
> continue connection to Zookeeper server without SASL authentication, if 
> Zookeeper server allows it. 0
> June 27th 2017, 22:05:19.326  INFOorg.apache.zookeeper.ClientCnxn Opening 
> socket connection to server 100.65.188.168/100.65.188.168:2181  0
> June 27th 2017, 22:05:20.324  INFOorg.apache.zookeeper.ClientCnxn Socket 
> connection established to 100.65.188.168/100.65.188.168:2181, initiating 
> session 0
> June 27th 2017, 22:05:20.327  INFOorg.apache.zookeeper.ClientCnxn Session 
> establishment complete on server 100.65.188.168/100.65.188.168:2181, 
> sessionid = 0x25cd1e82c110001, negotiated timeout = 12000  0
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ZOOKEEPER-1985) Memory leak in C client

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han updated ZOOKEEPER-1985:
---
Priority: Critical  (was: Minor)

> Memory leak in C client
> ---
>
> Key: ZOOKEEPER-1985
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1985
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.4.6
>Reporter: desmondhe
>Assignee: desmondhe
>Priority: Critical
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1985.patch
>
>
> in the file zookeeper.c, most function call of "close_buffer_oarchive(, 
> 0)" shoud been instead by 
> close_buffer_oarchive(, rc < 0 ? 1 : 0); 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ZooKeeper_branch34_jdk8 - Build # 1102 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1102/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 32.02 MB...]
[junit] 2017-08-21 23:09:18,559 [myid:] - INFO  
[main:PrepRequestProcessor@769] - Shutting down
[junit] 2017-08-21 23:09:18,559 [myid:] - INFO  
[main:SyncRequestProcessor@208] - Shutting down
[junit] 2017-08-21 23:09:18,559 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@144] - PrepRequestProcessor exited loop!
[junit] 2017-08-21 23:09:18,559 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited!
[junit] 2017-08-21 23:09:18,560 [myid:] - INFO  
[main:FinalRequestProcessor@403] - shutdown of request processor complete
[junit] 2017-08-21 23:09:18,560 [myid:] - INFO  
[main:FourLetterWordMain@65] - connecting to 127.0.0.1 11221
[junit] 2017-08-21 23:09:18,561 [myid:] - INFO  [main:JMXEnv@147] - 
ensureOnly:[]
[junit] 2017-08-21 23:09:18,562 [myid:] - INFO  [main:ClientBase@489] - 
STARTING server
[junit] 2017-08-21 23:09:18,562 [myid:] - INFO  [main:ClientBase@410] - 
CREATING server instance 127.0.0.1:11221
[junit] 2017-08-21 23:09:18,563 [myid:] - INFO  
[main:ServerCnxnFactory@116] - Using 
org.apache.zookeeper.server.NIOServerCnxnFactory as server connection factory
[junit] 2017-08-21 23:09:18,563 [myid:] - INFO  
[main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2017-08-21 23:09:18,563 [myid:] - INFO  [main:ClientBase@385] - 
STARTING server instance 127.0.0.1:11221
[junit] 2017-08-21 23:09:18,563 [myid:] - INFO  [main:ZooKeeperServer@173] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build/test/tmp/test8665906848958444575.junit.dir/version-2
 snapdir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build/test/tmp/test8665906848958444575.junit.dir/version-2
[junit] 2017-08-21 23:09:18,566 [myid:] - ERROR [main:ZooKeeperServer@468] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-08-21 23:09:18,566 [myid:] - INFO  
[main:FourLetterWordMain@65] - connecting to 127.0.0.1 11221
[junit] 2017-08-21 23:09:18,567 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@215] - 
Accepted socket connection from /127.0.0.1:37639
[junit] 2017-08-21 23:09:18,568 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@892] - Processing 
stat command from /127.0.0.1:37639
[junit] 2017-08-21 23:09:18,568 [myid:] - INFO  
[Thread-4:NIOServerCnxn$StatCommand@683] - Stat command output
[junit] 2017-08-21 23:09:18,568 [myid:] - INFO  
[Thread-4:NIOServerCnxn@1040] - Closed socket connection for client 
/127.0.0.1:37639 (no session established for client)
[junit] 2017-08-21 23:09:18,569 [myid:] - INFO  [main:JMXEnv@230] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2017-08-21 23:09:18,571 [myid:] - INFO  [main:JMXEnv@247] - 
expect:InMemoryDataTree
[junit] 2017-08-21 23:09:18,571 [myid:] - INFO  [main:JMXEnv@251] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2017-08-21 23:09:18,571 [myid:] - INFO  [main:JMXEnv@247] - 
expect:StandaloneServer_port
[junit] 2017-08-21 23:09:18,572 [myid:] - INFO  [main:JMXEnv@251] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2017-08-21 23:09:18,572 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 35540
[junit] 2017-08-21 23:09:18,572 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20
[junit] 2017-08-21 23:09:18,573 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota
[junit] 2017-08-21 23:09:18,573 [myid:] - INFO  [main:ClientBase@566] - 
tearDown starting
[junit] 2017-08-21 23:09:18,641 [myid:] - INFO  [main:ZooKeeper@687] - 
Session: 0x103cd2c996d closed
[junit] 2017-08-21 23:09:18,641 [myid:] - INFO  [main:ClientBase@536] - 
STOPPING server
[junit] 2017-08-21 23:09:18,641 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@520] - EventThread shut down for 
session: 0x103cd2c996d
[junit] 2017-08-21 23:09:18,642 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@242] - 
NIOServerCnxn factory exited run method
[junit] 2017-08-21 23:09:18,642 [myid:] - INFO  [main:ZooKeeperServer@501] 
- shutting down
[junit] 2017-08-21 23:09:18,642 [myid:] - ERROR [main:ZooKeeperServer@468] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR 

ZooKeeper-trunk-openjdk7 - Build # 1589 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1589/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 56.91 MB...]
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2017-08-21 20:09:24,425 [myid:] - INFO  [New I/O boss 
#98:ClientCnxnSocketNetty@208] - channel is told closing
[junit] 2017-08-21 20:09:24,425 [myid:127.0.0.1:27380] - INFO  
[main-SendThread(127.0.0.1:27380):ClientCnxn$SendThread@1231] - channel for 
sessionid 0x10631500b2c is lost, closing socket connection and attempting 
reconnect
[junit] 2017-08-21 20:09:25,972 [myid:127.0.0.1:27380] - INFO  
[main-SendThread(127.0.0.1:27380):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:27380. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-08-21 20:09:25,973 [myid:] - INFO  [New I/O boss 
#98:ClientCnxnSocketNetty$1@127] - future isn't success, cause: {}
[junit] java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:27380
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2017-08-21 20:09:25,973 [myid:] - WARN  [New I/O boss 
#98:ClientCnxnSocketNetty$ZKClientHandler@439] - Exception caught: [id: 
0x86a78f99] EXCEPTION: java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:27380
[junit] java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:27380
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:739)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2017-08-21 20:09:25,974 [myid:] - INFO  [New I/O boss 
#98:ClientCnxnSocketNetty@208] - channel is told closing
[junit] 2017-08-21 20:09:25,974 [myid:127.0.0.1:27380] - INFO  

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135718#comment-16135718
 ] 

Hadoop QA commented on ZOOKEEPER-1260:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 2 new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/951//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/951//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/951//console

This message is automatically generated.

> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Failed: ZOOKEEPER- PreCommit Build #951

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/951/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 67.64 MB...]
 [exec] +1 tests included.  The patch appears to include 6 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] -1 findbugs.  The patch appears to introduce 2 new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/951//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/951//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/951//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 42c6107efdbdd3c46f2bb28d34baee9568e75c4b logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1649:
 exec returned: 2

Total time: 13 minutes 54 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-1260
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  org.apache.zookeeper.test.AsyncHammerTest.testHammer

Error Message:
null

Stack Trace:
junit.framework.AssertionFailedError
at 
org.apache.zookeeper.test.AsyncHammerTest.testHammer(AsyncHammerTest.java:185)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135623#comment-16135623
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1260:
---

GitHub user arshadmohammad opened a pull request:

https://github.com/apache/zookeeper/pull/338

ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

Audit logging in ZooKeeper Servers.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/arshadmohammad/zookeeper 
ZOOKEEPER-1260-AuditLog

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/338.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #338


commit 502fbf7b2127cc4cf8284d8ecc181ae47e02b2d6
Author: Mohammad Arshad 
Date:   2017-07-11T14:42:13Z

ZOOKEEPER-1260:Audit logging in ZooKeeper Servers.




> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...

[arshadmohammad]

GitHub user arshadmohammad opened a pull request:

https://github.com/apache/zookeeper/pull/338

ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

Audit logging in ZooKeeper Servers.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/arshadmohammad/zookeeper 
ZOOKEEPER-1260-AuditLog

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/338.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #338


commit 502fbf7b2127cc4cf8284d8ecc181ae47e02b2d6
Author: Mohammad Arshad 
Date:   2017-07-11T14:42:13Z

ZOOKEEPER-1260:Audit logging in ZooKeeper Servers.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2879) Adding observers dynamically without server id

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135594#comment-16135594
 ] 

Hadoop QA commented on ZOOKEEPER-2879:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/950//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/950//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/950//console

This message is automatically generated.

> Adding observers dynamically without server id
> --
>
> Key: ZOOKEEPER-2879
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2879
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Affects Versions: 3.6.0
>Reporter: Fangmin Lv
>Assignee: Fangmin Lv
>
> Dynamic config requires observer has unique server id, which means we cannot 
> simply add observer with dynamic server id -1. For large observer cluster, 
> it's much more easier to add observer without unique server id if it doesn't 
> need to be promoted to participant. Also, it will make dynamic config more 
> efficient, we don't need to store and send the long list of observers during 
> re-config.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Success: ZOOKEEPER- PreCommit Build #950

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/950/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 72.60 MB...]
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/950//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/950//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/950//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 5a5a7ca160c02d43a45afe3b1ccea5540f88aff2 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 20 minutes 59 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2879
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-2879) Adding observers dynamically without server id

[Dan Benediktson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135568#comment-16135568
 ] 

Dan Benediktson commented on ZOOKEEPER-2879:


It's also unclear to me what problem this feature is intended to solve.
- Efficiency of dynamic config should be completely unimportant: the cost of 
another < 100 bytes of configuration data per observer is vanishingly small. 
This doesn't seem to be the real goal, just an added benefit, but let's be 
clear that it isn't a benefit.
- The real goal seems to be ease of management, but I don't really understand 
that. Can you elaborate in what way it is easier to not have server IDs? FWIW, 
we operate dozens of ZK clusters, some of them with more than 50 members, so 
I'm not unfamiliar with the problems of managing "large" ZK ensembles, for some 
definition of large; having to assign unique server IDs isn't really one of 
them, at least at our scale.

> Adding observers dynamically without server id
> --
>
> Key: ZOOKEEPER-2879
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2879
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Affects Versions: 3.6.0
>Reporter: Fangmin Lv
>Assignee: Fangmin Lv
>
> Dynamic config requires observer has unique server id, which means we cannot 
> simply add observer with dynamic server id -1. For large observer cluster, 
> it's much more easier to add observer without unique server id if it doesn't 
> need to be promoted to participant. Also, it will make dynamic config more 
> efficient, we don't need to store and send the long list of observers during 
> re-config.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2845) Data inconsistency issue due to retain database in leader election

[Fangmin Lv (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135559#comment-16135559
 ] 

Fangmin Lv commented on ZOOKEEPER-2845:
---

The internal patch has been stabilized, which have been tested for a long time, 
we've rolled it out to one of the production environment last week. Joseph from 
our team will attach the patch here for review this week.

> Data inconsistency issue due to retain database in leader election
> --
>
> Key: ZOOKEEPER-2845
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2845
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: quorum
>Affects Versions: 3.4.10, 3.5.3, 3.6.0
>Reporter: Fangmin Lv
>Assignee: Fangmin Lv
>Priority: Critical
>
> In ZOOKEEPER-2678, the ZKDatabase is retained to reduce the unavailable time 
> during leader election. In ZooKeeper ensemble, it's possible that the 
> snapshot is ahead of txn file (due to slow disk on the server, etc), or the 
> txn file is ahead of snapshot due to no commit message being received yet. 
> If snapshot is ahead of txn file, since the SyncRequestProcessor queue will 
> be drained during shutdown, the snapshot and txn file will keep consistent 
> before leader election happening, so this is not an issue.
> But if txn is ahead of snapshot, it's possible that the ensemble will have 
> data inconsistent issue, here is the simplified scenario to show the issue:
> Let's say we have a 3 servers in the ensemble, server A and B are followers, 
> and C is leader, and all the snapshot and txn are up to T0:
> 1. A new request reached to leader C to create Node N, and it's converted to 
> txn T1 
> 2. Txn T1 was synced to disk in C, but just before the proposal reaching out 
> to the followers, A and B restarted, so the T1 didn't exist in A and B
> 3. A and B formed a new quorum after restart, let's say B is the leader
> 4. C changed to looking state due to no enough followers, it will sync with 
> leader B with last Zxid T0, which will have an empty diff sync
> 5. Before C take snapshot it restarted, it replayed the txns on disk which 
> includes T1, now it will have Node N, but A and B doesn't have it.
> Also I included the a test case to reproduce this issue consistently. 
> We have a totally different RetainDB version which will avoid this issue by 
> doing consensus between snapshot and txn files before leader election, will 
> submit for review.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2879) Adding observers dynamically without server id

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135548#comment-16135548
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2879:
---

GitHub user lvfangmin opened a pull request:

https://github.com/apache/zookeeper/pull/337

[ZOOKEEPER-2879] Adding observers dynamically without server id



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lvfangmin/zookeeper ZOOKEEPER-2879

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/337.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #337


commit 164ec347346126769d931433f3277ffe80227097
Author: Fangmin Lyu 
Date:   2017-08-21T18:05:46Z

[ZOOKEEPER-2879] Adding observers dynamically without server id




> Adding observers dynamically without server id
> --
>
> Key: ZOOKEEPER-2879
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2879
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Affects Versions: 3.6.0
>Reporter: Fangmin Lv
>Assignee: Fangmin Lv
>
> Dynamic config requires observer has unique server id, which means we cannot 
> simply add observer with dynamic server id -1. For large observer cluster, 
> it's much more easier to add observer without unique server id if it doesn't 
> need to be promoted to participant. Also, it will make dynamic config more 
> efficient, we don't need to store and send the long list of observers during 
> re-config.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zookeeper pull request #337: [ZOOKEEPER-2879] Adding observers dynamically w...

[lvfangmin]

GitHub user lvfangmin opened a pull request:

https://github.com/apache/zookeeper/pull/337

[ZOOKEEPER-2879] Adding observers dynamically without server id



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lvfangmin/zookeeper ZOOKEEPER-2879

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/337.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #337


commit 164ec347346126769d931433f3277ffe80227097
Author: Fangmin Lyu 
Date:   2017-08-21T18:05:46Z

[ZOOKEEPER-2879] Adding observers dynamically without server id




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ZOOKEEPER-2879) Adding observers dynamically without server id

[Dan Benediktson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135539#comment-16135539
 ] 

Dan Benediktson commented on ZOOKEEPER-2879:


IIRC, the unique server ID is also used as part of ensuring that the session 
IDs generated on any given server are guaranteed to be unique. If that is 
violated, you can see very strange behavior (refer to ZOOKEEPER-2504, where I 
submitted a patch for ensuring the leader permitted at most one server with a 
given ID at a time, to prevent that strange behavior).

> Adding observers dynamically without server id
> --
>
> Key: ZOOKEEPER-2879
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2879
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Affects Versions: 3.6.0
>Reporter: Fangmin Lv
>Assignee: Fangmin Lv
>
> Dynamic config requires observer has unique server id, which means we cannot 
> simply add observer with dynamic server id -1. For large observer cluster, 
> it's much more easier to add observer without unique server id if it doesn't 
> need to be promoted to participant. Also, it will make dynamic config more 
> efficient, we don't need to store and send the long list of observers during 
> re-config.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ZOOKEEPER-2879) Adding observers dynamically without server id

[Fangmin Lv (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fangmin Lv updated ZOOKEEPER-2879:
--
Description: Dynamic config requires observer has unique server id, which 
means we cannot simply add observer with dynamic server id -1. For large 
observer cluster, it's much more easier to add observer without unique server 
id if it doesn't need to be promoted to participant. Also, it will make dynamic 
config more efficient, we don't need to store and send the long list of 
observers during re-config.  (was: Dynamic config requires observer has unique 
server id, which means we cannot simply add observer with dynamic server id -1. 
For large observer cluster, it's much more easier to add
observer without unique server id if it doesn't need to be promoted to 
participant. Also, it will 
make dynamic config more efficient, we don't need to store and send the long 
list of observers 
during re-config.)

> Adding observers dynamically without server id
> --
>
> Key: ZOOKEEPER-2879
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2879
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: quorum
>Affects Versions: 3.6.0
>Reporter: Fangmin Lv
>Assignee: Fangmin Lv
>
> Dynamic config requires observer has unique server id, which means we cannot 
> simply add observer with dynamic server id -1. For large observer cluster, 
> it's much more easier to add observer without unique server id if it doesn't 
> need to be promoted to participant. Also, it will make dynamic config more 
> efficient, we don't need to store and send the long list of observers during 
> re-config.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZOOKEEPER-2879) Adding observers dynamically without server id

[Fangmin Lv (JIRA)]

Fangmin Lv created ZOOKEEPER-2879:
-

 Summary: Adding observers dynamically without server id
 Key: ZOOKEEPER-2879
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2879
 Project: ZooKeeper
  Issue Type: Improvement
  Components: quorum
Affects Versions: 3.6.0
Reporter: Fangmin Lv
Assignee: Fangmin Lv


Dynamic config requires observer has unique server id, which means we cannot 
simply add observer with dynamic server id -1. For large observer cluster, it's 
much more easier to add
observer without unique server id if it doesn't need to be promoted to 
participant. Also, it will 
make dynamic config more efficient, we don't need to store and send the long 
list of observers 
during re-config.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2860) Update sample server jaas config for kerberos auth

[Andrey (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135043#comment-16135043
 ] 

Andrey commented on ZOOKEEPER-2860:
---

I've created kerberos account and attached several SPN to it. (this is a valid 
setup). However when I tried to use sample configuration from the documentation 
i've got "Client not found in Kerberos database" error from Kerberos. That's 
because server was trying to acquire TGT, which is not required. And for TGT it 
needs service account, not SPN.

> Update sample server jaas config for kerberos auth
> --
>
> Key: ZOOKEEPER-2860
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2860
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: documentation
>Reporter: Andrey
>
> Currently sample server jaas configuration for kerberos contains:
> {code}
> principal="zookeeper/yourzkhostname"
> {code}
> Background on why "princinpal=SPN" and "isInitiator=true" won't work is here:
> https://dmdaa.wordpress.com/2010/03/27/the-impact-of-isinitiator-on-jaas-login-configuration-and-the-role-if-spn/
> Expected:
> {code}
>isInitiator=false
>principal="zookeeper/yourzkhostname";
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ZOOKEEPER-2858) Disable reverse DNS lookup for java client

[Andrey (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16135041#comment-16135041
 ] 

Andrey commented on ZOOKEEPER-2858:
---

Hmm.. Are you sure? It's in the "open" state and has "3.5.4, 3.6.0" fix 
versions.

> Disable reverse DNS lookup for java client
> --
>
> Key: ZOOKEEPER-2858
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2858
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: java client
>Affects Versions: 3.4.6
>Reporter: Andrey
>
> I have the following setup:
> - zookeeper server running in docker container
> - kerberos auth
> When client setup sasl connection it creates service principal name as:
> - "principalUserName+"/"+addr.getHostName()",
> where:
> - addr.getHostName is the reverse DNS of original server host.
> If zookeeper nodes will be deployed behind the firewall or software defined 
> network (the docker case), then reverse DNS host won't match original server 
> host. And this is done by design.
> If these hosts won't match, then principals won't match and Kerberos auth 
> will fail.
> Is it possible to introduce some configuration parameter to disable reverse 
> DNS lookups?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

ZooKeeper_branch35_jdk7 - Build # 1085 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/1085/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 67.73 MB...]
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-08-21 08:59:23,770 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testWatcherAutoResetWithLocal
[junit] 2017-08-21 08:59:23,770 [myid:127.0.0.1:16761] - WARN  
[main-SendThread(127.0.0.1:16761):ClientCnxn$SendThread@1235] - Session 
0x50182084989 for server 127.0.0.1/127.0.0.1:16761, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] Tests run: 103, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
777.94 sec, Thread: 3, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2017-08-21 08:59:23,990 [myid:127.0.0.1:16755] - INFO  
[main-SendThread(127.0.0.1:16755):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:16755. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-08-21 08:59:23,991 [myid:127.0.0.1:16755] - WARN  
[main-SendThread(127.0.0.1:16755):ClientCnxn$SendThread@1235] - Session 
0x3018208497f for server 127.0.0.1/127.0.0.1:16755, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-08-21 08:59:24,087 [myid:127.0.0.1:16731] - INFO  
[main-SendThread(127.0.0.1:16731):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:16731. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-08-21 08:59:24,087 [myid:127.0.0.1:16731] - WARN  
[main-SendThread(127.0.0.1:16731):ClientCnxn$SendThread@1235] - Session 
0x10182082344 for server 127.0.0.1/127.0.0.1:16731, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-08-21 08:59:24,169 [myid:127.0.0.1:16672] - INFO  
[main-SendThread(127.0.0.1:16672):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:16672. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-08-21 08:59:24,170 [myid:127.0.0.1:16672] - WARN  
[main-SendThread(127.0.0.1:16672):ClientCnxn$SendThread@1235] - Session 
0x10182036010 for server 127.0.0.1/127.0.0.1:16672, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-08-21 08:59:24,205 [myid:127.0.0.1:16749] - INFO  
[main-SendThread(127.0.0.1:16749):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:16749. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-08-21 08:59:24,205 [myid:127.0.0.1:16749] - WARN  
[main-SendThread(127.0.0.1:16749):ClientCnxn$SendThread@1235] - Session 
0x101820849830001 for server 127.0.0.1/127.0.0.1:16749, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 

[jira] [Created] (ZOOKEEPER-2878) some issues in c code of lock of recipes

[H Y (JIRA)]

H Y created ZOOKEEPER-2878:
--

 Summary: some issues in c code of lock of recipes 
 Key: ZOOKEEPER-2878
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2878
 Project: ZooKeeper
  Issue Type: Bug
  Components: recipes
Reporter: H Y
Priority: Minor


There are three issues in the c code of lock.
1, It not multi-thread safe, because  pmutex is the local mutex of 
zkr_lock_mutex_t, if there are more than one thread is calling zkr_lock_lock, 
it may watch children node fail(retry_zoowexists may return NOT ZOK, 'unable to 
watch my predecessor' will output. I suggest that changing the pmutex to global.
2,child_floor function is not correct, it should compare the sequence of the 
node.(zoo_lock.c, line145 should be 'if (strcmp((sorted_data[i] + 19), (element 
+ 19)) < 0)'
3, Logic mistaking in zkr_lock_operation of zoo_lock.c at line 256. mutex->id 
should be allocated by getName function. So, I think that we should delete from 
line 249 to 257.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)