ZooKeeper_branch35_jdk8 - Build # 956 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/956/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 60.88 KB...]
[junit] Running org.apache.zookeeper.test.SaslSuperUserTest in thread 5
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.114 sec, Thread: 5, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.391 sec, Thread: 3, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.687 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 3
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 5
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.079 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionTimeoutTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
5
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.096 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 5
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
12.794 sec, Thread: 3, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
161.39 sec, Thread: 2, Class: org.apache.zookeeper.test.RecoveryTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 2
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.737 sec, Thread: 3, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.288 sec, Thread: 2, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.059 sec, Thread: 2, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 2
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.591 sec, Thread: 3, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.042 sec, Thread: 2, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 3
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 2
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
21.421 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 5
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.116 sec, Thread: 5, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
114.951 sec, Thread: 6, Class: org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 6
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.363 sec, Thread: 5, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 5
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.086 sec, Thread: 5, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 5
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
18.229 sec, Thread: 3, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.148 sec, Thread: 3, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
21.964 sec, Thread: 2, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
15.136 sec, Thread: 5, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time 

[jira] [Updated] (ZOOKEEPER-3039) TxnLogToolkit uses Scanner badly

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3039:
--
Labels: pull-request-available  (was: )

> TxnLogToolkit uses Scanner badly
> 
>
> Key: ZOOKEEPER-3039
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3039
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.4, 3.6.0, 3.4.13
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> If more than 1 CRC error is found in the Txn log file, TxnLogToolkit fails to 
> get an answer for the second one, because it has already closed the Scanner 
> which was probably closed the input stream also, so exception is thrown:
> {noformat}
> ZooKeeper Transactional Log File with dbid 0 txnlog format version 2
> CRC ERROR - 4/5/18 5:16:05 AM PDT session 0x16295bafcc4 cxid 0x1 zxid 
> 0x10002 closeSession null
> Would you like to fix it (Yes/No/Abort) ? y
> CRC ERROR - 4/5/18 5:17:34 AM PDT session 0x26295bafcc9 cxid 0x0 zxid 
> 0x20001 closeSession null
> Would you like to fix it (Yes/No/Abort) ? Exception in thread "main" 
> java.util.NoSuchElementException
> at java.util.Scanner.throwFor(Scanner.java:862)
> at java.util.Scanner.next(Scanner.java:1371)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.askForFix(TxnLogToolkit.java:208)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.dump(TxnLogToolkit.java:175)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.main(TxnLogToolkit.java:101){noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #518: ZOOKEEPER-3039 TxnLogToolkit uses Scanner badly...

[anmolnar]

Github user anmolnar closed the pull request at:

https://github.com/apache/zookeeper/pull/518


---

ZooKeeper_branch34 - Build # 2337 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34/2337/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 126.21 KB...]
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
5.664 sec
[junit] Running org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.759 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedClientTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.566 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedServerTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.514 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.776 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.495 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.575 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.468 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.073 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.455 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.114 sec
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.58 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.857 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.585 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.307 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.539 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
7.989 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.297 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.085 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.794 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
28.282 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
6.222 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.563 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build.xml:1474: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build.xml:1382: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34/build.xml:1385: Tests 
failed!

Total time: 28 minutes 33 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss

Error Message:
expected:<1> but was:<2>

Stack Trace:
junit.framework.AssertionFailedError: expected:<1> but was:<2>
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss(QuorumPeerMainTest.java:1202)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)

ZooKeeper-trunk - Build # 20 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/20/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 170.51 KB...]
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.915 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.51 sec, Thread: 5, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 5
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.382 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionTimeoutTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
5
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.11 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 5
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
12.124 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 4
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.661 sec, Thread: 4, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 4
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.426 sec, Thread: 4, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 4
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.962 sec, Thread: 4, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.114 sec, Thread: 4, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
49.232 sec, Thread: 2, Class: org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.089 sec, Thread: 4, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 2
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
60.572 sec, Thread: 7, Class: org.apache.zookeeper.test.RecoveryTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 7
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.228 sec, Thread: 7, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 7
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
24.204 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 5
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.95 sec, Thread: 7, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 7
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.181 sec, Thread: 7, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 7
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
16.623 sec, Thread: 2, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.961 sec, Thread: 2, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
12.699 sec, Thread: 7, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
21.487 sec, Thread: 4, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
31.633 sec, Thread: 5, Class: org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
475.611 sec, Thread: 6, Class: org.apache.zookeeper.test.DisconnectedWatcherTest
[junit] Tests run: 104, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 

[GitHub] zookeeper pull request #518: ZOOKEEPER-3039 TxnLogToolkit uses Scanner badly...

[anmolnar]

Github user anmolnar closed the pull request at:

https://github.com/apache/zookeeper/pull/518


---

[GitHub] zookeeper issue #518: ZOOKEEPER-3039 TxnLogToolkit uses Scanner badly (3.4)

[phunt]

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/518
  
+1. Thanks @anmolnar please close this.


---

Failed: ZOOKEEPER- PreCommit Build #1673

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1673/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 40.60 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1673//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1673//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1673//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16471231 added to ZOOKEEPER-3039.
 [exec] Session logged out. Session was 
JSESSIONID=6D1BA6713A35BB3C693846EE94DE72B5.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1778:
 exec returned: 1

Total time: 51 minutes 56 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3039
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.EphemeralNodeDeletionTest.testEphemeralNodeDeletion

Error Message:
waiting for server 2 being up

Stack Trace:
junit.framework.AssertionFailedError: waiting for server 2 being up
at 
org.apache.zookeeper.server.quorum.EphemeralNodeDeletionTest.testEphemeralNodeDeletion(EphemeralNodeDeletionTest.java:79)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)

[jira] [Commented] (ZOOKEEPER-3039) TxnLogToolkit uses Scanner badly

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471231#comment-16471231
 ] 

Hadoop QA commented on ZOOKEEPER-3039:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1673//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1673//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1673//console

This message is automatically generated.

> TxnLogToolkit uses Scanner badly
> 
>
> Key: ZOOKEEPER-3039
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3039
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.4, 3.6.0, 3.4.13
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> If more than 1 CRC error is found in the Txn log file, TxnLogToolkit fails to 
> get an answer for the second one, because it has already closed the Scanner 
> which was probably closed the input stream also, so exception is thrown:
> {noformat}
> ZooKeeper Transactional Log File with dbid 0 txnlog format version 2
> CRC ERROR - 4/5/18 5:16:05 AM PDT session 0x16295bafcc4 cxid 0x1 zxid 
> 0x10002 closeSession null
> Would you like to fix it (Yes/No/Abort) ? y
> CRC ERROR - 4/5/18 5:17:34 AM PDT session 0x26295bafcc9 cxid 0x0 zxid 
> 0x20001 closeSession null
> Would you like to fix it (Yes/No/Abort) ? Exception in thread "main" 
> java.util.NoSuchElementException
> at java.util.Scanner.throwFor(Scanner.java:862)
> at java.util.Scanner.next(Scanner.java:1371)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.askForFix(TxnLogToolkit.java:208)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.dump(TxnLogToolkit.java:175)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.main(TxnLogToolkit.java:101){noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3040) flaky test EphemeralNodeDeletionTest

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471229#comment-16471229
 ] 

Patrick Hunt commented on ZOOKEEPER-3040:
-

Looks like this came into the codebase via ZOOKEEPER-2355

> flaky test EphemeralNodeDeletionTest
> 
>
> Key: ZOOKEEPER-3040
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3040
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 3.5.4, 3.6.0, 3.4.12
>Reporter: Patrick Hunt
>Assignee: Norbert Kalmar
>Priority: Major
> Fix For: 3.6.0, 3.4.13, 3.5.5
>
>
> Flakey test EphemeralNodeDeletionTest
> {noformat}
> java.lang.AssertionError: After session close ephemeral node must be deleted 
> expected null, but 
> was:<4294967302,4294967302,1525988536834,1525988536834,0,0,0,144127862257483776,1,0,4294967302
>  {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (ZOOKEEPER-3040) flaky test EphemeralNodeDeletionTest

[Andor Molnar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andor Molnar reassigned ZOOKEEPER-3040:
---

Assignee: Norbert Kalmar

> flaky test EphemeralNodeDeletionTest
> 
>
> Key: ZOOKEEPER-3040
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3040
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 3.5.4, 3.6.0, 3.4.12
>Reporter: Patrick Hunt
>Assignee: Norbert Kalmar
>Priority: Major
> Fix For: 3.6.0, 3.4.13, 3.5.5
>
>
> Flakey test EphemeralNodeDeletionTest
> {noformat}
> java.lang.AssertionError: After session close ephemeral node must be deleted 
> expected null, but 
> was:<4294967302,4294967302,1525988536834,1525988536834,0,0,0,144127862257483776,1,0,4294967302
>  {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3040) flaky test EphemeralNodeDeletionTest

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471223#comment-16471223
 ] 

Patrick Hunt commented on ZOOKEEPER-3040:
-

When someone fixes this could you look through the rest of the tests for 
similar problem wrt assumption?

> flaky test EphemeralNodeDeletionTest
> 
>
> Key: ZOOKEEPER-3040
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3040
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 3.5.4, 3.6.0, 3.4.12
>Reporter: Patrick Hunt
>Priority: Major
> Fix For: 3.6.0, 3.4.13, 3.5.5
>
>
> Flakey test EphemeralNodeDeletionTest
> {noformat}
> java.lang.AssertionError: After session close ephemeral node must be deleted 
> expected null, but 
> was:<4294967302,4294967302,1525988536834,1525988536834,0,0,0,144127862257483776,1,0,4294967302
>  {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3040) flaky test EphemeralNodeDeletionTest

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471222#comment-16471222
 ] 

Patrick Hunt commented on ZOOKEEPER-3040:
-

Looks like the test code is assuming the follower is up to date, which without 
a sync call might not be the case. Hence flakey. Please also verify that the 
zk.close is synchronous.

{noformat}
// close the session and newly created ephemeral node should be deleted
zk.close();

nodeAtFollower = followerZK.exists(nodePath, false);

// Problem 2: Before fix, after session close the ephemeral node
// was not getting deleted. But now after the fix after session close
// ephemeral node is getting deleted.
assertNull("After session close ephemeral node must be deleted",
nodeAtFollower);
{noformat}


> flaky test EphemeralNodeDeletionTest
> 
>
> Key: ZOOKEEPER-3040
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3040
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 3.5.4, 3.6.0, 3.4.12
>Reporter: Patrick Hunt
>Priority: Major
> Fix For: 3.6.0, 3.4.13, 3.5.5
>
>
> Flakey test EphemeralNodeDeletionTest
> {noformat}
> java.lang.AssertionError: After session close ephemeral node must be deleted 
> expected null, but 
> was:<4294967302,4294967302,1525988536834,1525988536834,0,0,0,144127862257483776,1,0,4294967302
>  {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ZOOKEEPER-3040) flaky test EphemeralNodeDeletionTest

[Patrick Hunt (JIRA)]

Patrick Hunt created ZOOKEEPER-3040:
---

 Summary: flaky test EphemeralNodeDeletionTest
 Key: ZOOKEEPER-3040
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3040
 Project: ZooKeeper
  Issue Type: Bug
  Components: tests
Affects Versions: 3.4.12, 3.5.4, 3.6.0
Reporter: Patrick Hunt
 Fix For: 3.6.0, 3.4.13, 3.5.5


Flakey test EphemeralNodeDeletionTest

{noformat}
java.lang.AssertionError: After session close ephemeral node must be deleted 
expected null, but 
was:<4294967302,4294967302,1525988536834,1525988536834,0,0,0,144127862257483776,1,0,4294967302
 {noformat}




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #518: ZOOKEEPER-3039 TxnLogToolkit uses Scanner badly

[anmolnar]

GitHub user anmolnar opened a pull request:

https://github.com/apache/zookeeper/pull/518

ZOOKEEPER-3039 TxnLogToolkit uses Scanner badly

Cherry-picked from master.
Resolved conflicts.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-3039_34

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/518.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #518


commit e36b1938948a726cbc22502a327ae446c91213b5
Author: Andor Molnar 
Date:   2018-05-10T20:14:24Z

ZOOKEEPER-3039: TxnLogToolkit uses Scanner badly

Fixed by creating a single Scanner for all queries in the main() method.

Author: Andor Molnar 

Reviewers: ph...@apache.org

Closes #517 from anmolnar/ZOOKEEPER-3039 and squashes the following commits:

a35e2e280 [Andor Molnar] ZOOKEEPER-3039. Optimize imports
a196443cb [Andor Molnar] ZOOKEEPER-3039. Use the same Scanner for all 
queries

Change-Id: Icf66888d4e6ad902615ed8ffde58a5a8fdd41237




---

[jira] [Resolved] (ZOOKEEPER-2971) Create release notes for 3.5.4

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt resolved ZOOKEEPER-2971.
-
Resolution: Fixed

I've captured this in the release notes for 3.5.4

> Create release notes for 3.5.4
> --
>
> Key: ZOOKEEPER-2971
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2971
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.5.3
>Reporter: Jordan Zimmerman
>Assignee: Patrick Hunt
>Priority: Blocker
> Fix For: 3.5.4
>
>
> ZOOKEEPER-2901 and ZOOKEEPER-2903 fix a serious bug with TTL nodes in 3.5.3. 
> The release notes for 3.5.4 should describe the problem and how it was 
> worked-around/fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3039) TxnLogToolkit uses Scanner badly

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471116#comment-16471116
 ] 

Hudson commented on ZOOKEEPER-3039:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #19 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/19/])
ZOOKEEPER-3039: TxnLogToolkit uses Scanner badly (phunt: rev 
2fa315b7d0ed65828479fcdcc9e76ca8552fba4a)
* (edit) 
src/java/test/org/apache/zookeeper/server/persistence/TxnLogToolkitTest.java
* (edit) 
src/java/main/org/apache/zookeeper/server/persistence/TxnLogToolkit.java


> TxnLogToolkit uses Scanner badly
> 
>
> Key: ZOOKEEPER-3039
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3039
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.4, 3.6.0, 3.4.13
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> If more than 1 CRC error is found in the Txn log file, TxnLogToolkit fails to 
> get an answer for the second one, because it has already closed the Scanner 
> which was probably closed the input stream also, so exception is thrown:
> {noformat}
> ZooKeeper Transactional Log File with dbid 0 txnlog format version 2
> CRC ERROR - 4/5/18 5:16:05 AM PDT session 0x16295bafcc4 cxid 0x1 zxid 
> 0x10002 closeSession null
> Would you like to fix it (Yes/No/Abort) ? y
> CRC ERROR - 4/5/18 5:17:34 AM PDT session 0x26295bafcc9 cxid 0x0 zxid 
> 0x20001 closeSession null
> Would you like to fix it (Yes/No/Abort) ? Exception in thread "main" 
> java.util.NoSuchElementException
> at java.util.Scanner.throwFor(Scanner.java:862)
> at java.util.Scanner.next(Scanner.java:1371)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.askForFix(TxnLogToolkit.java:208)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.dump(TxnLogToolkit.java:175)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.main(TxnLogToolkit.java:101){noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper-trunk - Build # 19 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/19/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 141.90 KB...]
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.855 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionTimeoutTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
4
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.11 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 4
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
12.294 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 5
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.821 sec, Thread: 5, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 5
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.655 sec, Thread: 5, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 5
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.759 sec, Thread: 5, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.072 sec, Thread: 5, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.972 sec, Thread: 5, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 5
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
28.548 sec, Thread: 4, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 4
[junit] Tests run: 104, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
422.249 sec, Thread: 2, Class: org.apache.zookeeper.test.NettyNettySuiteTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
13.487 sec, Thread: 5, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 5
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.574 sec, Thread: 5, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 5
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 2
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.578 sec, Thread: 5, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 5
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.15 sec, Thread: 5, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 5
[junit] Tests run: 104, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
430.207 sec, Thread: 7, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 7
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.193 sec, Thread: 7, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
23.292 sec, Thread: 4, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
15.378 sec, Thread: 5, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
32.526 sec, Thread: 2, Class: org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
563.352 sec, Thread: 1, Class: org.apache.zookeeper.test.DisconnectedWatcherTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
270.697 sec, Thread: 6, Class: org.apache.zookeeper.test.ReconfigTest
[junit] Running org.apache.zookeeper.server.quorum.StandaloneDisabledTest 
in thread 8
[junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 
sec, Thread: 8, Class: org.apache.zookeeper.server.quorum.StandaloneDisabledTest
[junit] Test org.apache.zookeeper.server.quorum.StandaloneDisabledTest 
FAILED (timeout)
[junit] Running org.apache.zookeeper.server.quorum.Zab1_0Test in thread 3
[junit] Tests run: 1, 

Failed: ZOOKEEPER-1636 PreCommit Build #3687

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1636
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3687/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 2.58 KB...]
forrest.check:

hudson-test-patch:
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Testing patch for ZOOKEEPER-1636.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
 [exec] ZOOKEEPER-1636 patch is being downloaded at Thu May 10 20:46:54 UTC 
2018 from
 [exec] 
http://issues.apache.org/jira/secure/attachment/12671215/ZOOKEEPER-1636.patch
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec]  Pre-build trunk to verify trunk stability and javac warnings
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] /home/jenkins/tools/ant/latest/bin/ant  -Djavac.args=-Xlint 
-Xmaxwarns 1000 -Djava5.home=/home/jenkins/tools/java5/latest/ 
-Dforrest.home=/home/jenkins/tools/forrest/latest/ -DZookeeperPatchProcess= 
clean tar > 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build@2/patchprocess/trunkJavacWarnings.txt
 2>&1
 [exec] 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build@2/src/java/test/bin/test-patch.sh:
 line 141: 15525 Killed  $ANT_HOME/bin/ant -Djavac.args="-Xlint 
-Xmaxwarns 1000" -Djava5.home=${JAVA5_HOME} -Dforrest.home=${FORREST_HOME} 
-DZookeeperPatchProcess= clean tar > $PATCH_DIR/trunkJavacWarnings.txt 2>&1
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build@2/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build@2/patchprocess'
 are the same file
 [exec] Trunk compilation is broken?
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build@2/build.xml:1716:
 exec returned: 1

Total time: 5 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3039
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2466) Client skips servers when trying to connect

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471086#comment-16471086
 ] 

Hadoop QA commented on ZOOKEEPER-2466:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12822864/ZOOKEEPER-2466.patch
  against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3681//console

This message is automatically generated.

> Client skips servers when trying to connect
> ---
>
> Key: ZOOKEEPER-2466
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2466
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Reporter: Flavio Junqueira
>Assignee: Michael Han
>Priority: Critical
> Fix For: 3.6.0, 3.5.5
>
> Attachments: ZOOKEEPER-2466.patch, ZOOKEEPER-2466.patch
>
>
> I've been looking at {{Zookeeper_simpleSystem::testFirstServerDown}} and I 
> observed the following behavior. The list of servers to connect contains two 
> servers, let's call them S1 and S2. The client never connects, but the odd 
> bit is the sequence of servers that the client tries to connect to:
> {noformat}
> S1
> S2
> S1
> S1
> S1
> 
> {noformat}
> It intrigued me that S2 is only tried once and never again. Checking the 
> code, here is what happens. Initially, {{zh->reconfig}} is 1, so in 
> {{zoo_cycle_next_server}} we return an address from 
> {{get_next_server_in_reconfig}}, which is taken from {{zh->addrs_new}} in 
> this test case. The attempt to connect fails, and {{handle_error}} is invoked 
> in the error handling path. {{handle_error}} actually invokes 
> {{addrvec_next}} which changes the address pointer to the next server on the 
> list.
> After two attempts, it decides that it has tried all servers in 
> {{zoo_cycle_next_server}} and sets {{zh->reconfig}} to zero. Once 
> {{zh->reconfig == 0}}, we have that each call to {{zoo_cycle_next_server}} 
> moves the address pointer to the next server in {{zh->addrs}}. But, given 
> that {{handle_error}} also moves the pointer to the next server, we end up 
> moving the pointer ahead twice upon every failed attempt to connect, which is 
> wrong.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2551) Remove Hadoop Logo from ZooKeeper documentation

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471085#comment-16471085
 ] 

Hadoop QA commented on ZOOKEEPER-2551:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12829255/ZOOKEEPER-2551-01.patch
  against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3684//console

This message is automatically generated.

> Remove Hadoop Logo from ZooKeeper documentation
> ---
>
> Key: ZOOKEEPER-2551
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2551
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: documentation
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.6.0, 3.5.5
>
> Attachments: ZOOKEEPER-2551-01.patch
>
>
> ZooKeeper documentation has hadoop logo on each page's header. There is no 
> significance to put the hadoop logo on ZooKeeper project. So hadoop  logo 
> should be removed from  Zookeeper  as  ZooKeeper is independent of hadoop 
> project, 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER-2551 PreCommit Build #3684

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2551
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3684/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 6.30 KB...]
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12829255/ZOOKEEPER-2551-01.patch
 [exec]   against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +0 tests included.  The patch appears to be a documentation 
patch that doesn't require tests.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3684//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16471085 added to ZOOKEEPER-2551.
 [exec] Session logged out. Session was 
JSESSIONID=6561BBEF537F99F68A618293DA03C133.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build@2/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build@2/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build@2/build.xml:1716:
 exec returned: 1

Total time: 45 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3039
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-910) Use SelectionKey.isXYZ() methods instead of complicated binary logic

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471084#comment-16471084
 ] 

Hadoop QA commented on ZOOKEEPER-910:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12642014/ZOOKEEPER-910.patch
  against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3683//console

This message is automatically generated.

> Use SelectionKey.isXYZ() methods instead of complicated binary logic
> 
>
> Key: ZOOKEEPER-910
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-910
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Thomas Koch
>Assignee: Michi Mutsuzaki
>Priority: Minor
> Fix For: 3.6.0, 3.5.5
>
> Attachments: ZOOKEEPER-910.patch
>
>
> The SelectionKey class provides methods to replace something like this
> (k.readyOps() & (SelectionKey.OP_READ | SelectionKey.OP_WRITE)) != 0
> with
> selectionKey.isReadable() || selectionKey.isWritable()
> It may be possible, that the first version saves a CPU cycle or two, but the 
> later version saves developer brain cycles which are much more expensive.
> I suppose that there are many more places in the server code where this 
> replacement could be done. I propose that whoever touches a code line like 
> this should make the replacement.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER-910 PreCommit Build #3683

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-910
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3683/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 5.72 KB...]
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12642014/ZOOKEEPER-910.patch
 [exec]   against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3683//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16471084 added to ZOOKEEPER-910.
 [exec] Session logged out. Session was 
JSESSIONID=A211585B22266C8416A632431E042286.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1716: 
exec returned: 1

Total time: 44 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3039
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

Failed: ZOOKEEPER-1971 PreCommit Build #3671

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1971
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3671/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 85.20 MB...]
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3671//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3671//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3671//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16471081 added to ZOOKEEPER-1971.
 [exec] Session logged out. Session was 
JSESSIONID=03CEC5DF462B7E2D58E9206006CA3DF7.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1716: 
exec returned: 1

Total time: 17 minutes 20 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3039
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

Failed: ZOOKEEPER-1856 PreCommit Build #3680

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1856
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3680/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 5.69 KB...]
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12634340/ZOOKEEPER-1856.patch
 [exec]   against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3680//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16471080 added to ZOOKEEPER-1856.
 [exec] Session logged out. Session was 
JSESSIONID=3FB8890B27F6517DCFB7DC91EA810ABB.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1716: 
exec returned: 1

Total time: 56 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3039
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-1971) Make JMX remote monitoring port configurable

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471081#comment-16471081
 ] 

Hadoop QA commented on ZOOKEEPER-1971:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12828907/ZOOKEEPER-1971-03.patch
  against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 2 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3671//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3671//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3671//console

This message is automatically generated.

> Make JMX remote monitoring port configurable
> 
>
> Key: ZOOKEEPER-1971
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1971
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.5.0
> Environment: All
>Reporter: Biju Nair
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.6.0, 3.5.5
>
> Attachments: GeneratedDoc-ZOOKEEPER-1971-03.pdf, 
> ZOOKEEPER-1971-01.patch, ZOOKEEPER-1971-02.patch, ZOOKEEPER-1971-03.patch, 
> zookeeperAdmin.pdf, zookeeperJMX.pdf
>
>
> This is a follow-up item from ZOOKEEPER-1948.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-1856) zookeeper C-client can fail to switch from a dead server in a 3+ server ensemble if the client only has a 2 server list.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471080#comment-16471080
 ] 

Hadoop QA commented on ZOOKEEPER-1856:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12634340/ZOOKEEPER-1856.patch
  against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3680//console

This message is automatically generated.

> zookeeper C-client can fail to switch from a dead server in a 3+ server 
> ensemble if the client only has a 2 server list.
> 
>
> Key: ZOOKEEPER-1856
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1856
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Reporter: Dutch T. Meyer
>Assignee: Michi Mutsuzaki
>Priority: Major
> Fix For: 3.6.0, 3.5.5
>
> Attachments: ZOOKEEPER-1856.patch
>
>
> If a client has a 2 server list, and is currently connected to the last 
> server in that list, and that server then goes offline, the addrvec_next() 
> call handle_error() will push the client to the start of the list and 
> terminate the connection.
> Then, the zoo_cycle_next_server() call in zookeeper_interest will be called 
> in response to the connection failure, and the client will cycle back to the 
> failed server.
> In this way, a client who has a list of only 2 servers can get stuck on the 
> one failed server.  This would only be an issue in an ensemble larger than 2 
> of course, because failing 1 out of 2 would lead to quorum loss anyway.
> There are other harmonics possible if every other server in the list is 
> failed, but this is simplest to reproduce in a 3 server ensemble where the 
> client only knows about 2 servers, one of which then fails.  There are 
> probably some elegant fixes here, but I think the simplest is to add a flag 
> to track whether a server has been accessed before, and if it hasn't, don't 
> call zoo_cycle_next_server() at the top of the zookeeper_interest() function.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-1350) Please make JMX registration optional in LearnerZooKeeperServer

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471078#comment-16471078
 ] 

Hadoop QA commented on ZOOKEEPER-1350:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12650322/ZOOKEEPER-1350-trunk.diff
  against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3679//console

This message is automatically generated.

> Please make JMX registration optional in LearnerZooKeeperServer
> ---
>
> Key: ZOOKEEPER-1350
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1350
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.4.0
>Reporter: Jordan Zimmerman
>Assignee: Jordan Zimmerman
>Priority: Major
> Fix For: 3.6.0, 3.5.5
>
> Attachments: ZOOKEEPER-1350-trunk.diff, ZOOKEEPER-1350.diff, 
> jmx_optional.diff, patch.txt
>
>
> LearnerZooKeeperServer has no option to disable JMX registrations. Curator 
> has a test ZK server cluster. Due to the intricacies of JMX, the 
> registrations cannot be easily undone. In order for the Curator Test cluster 
> to be re-usable in a testing session, JavaAssist ugliness was necessary to 
> make LearnerZooKeeperServer.registerJMX() and 
> LearnerZooKeeperServer.unregisterJMX() NOPs. 
> I suggest a simple System property.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER-1350 PreCommit Build #3679

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1350
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3679/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 5.60 KB...]
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12650322/ZOOKEEPER-1350-trunk.diff
 [exec]   against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3679//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16471078 added to ZOOKEEPER-1350.
 [exec] Session logged out. Session was 
JSESSIONID=371FBF85A85357A6353900299153A46B.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1716: 
exec returned: 1

Total time: 54 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3039
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2492) gethostname return error before Win32WSAStartup on windows.

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471075#comment-16471075
 ] 

Hadoop QA commented on ZOOKEEPER-2492:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12820929/ZOOKEEPER-2492.patch
  against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3667//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3667//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3667//console

This message is automatically generated.

> gethostname return error before Win32WSAStartup on windows.
> ---
>
> Key: ZOOKEEPER-2492
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2492
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
> Environment: windows
>Reporter: spooky000
>Assignee: spooky000
>Priority: Trivial
> Fix For: 3.6.0, 3.5.5
>
> Attachments: ZOOKEEPER-2492.patch, ZOOKEEPER-2492.patch, 
> ZOOKEEPER-2492.patch
>
>
> gethostname return error before Win32WSAStartup on windows.
> in log_env function.
> gethostname(buf, sizeof(buf));
> LOG_INFO(LOGCALLBACK(zh), "Client environment:host.name=%s", buf);
> buf will be uninitialized buffer.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER-2492 PreCommit Build #3667

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2492
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3667/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 85.68 MB...]
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3667//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3667//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3667//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16471075 added to ZOOKEEPER-2492.
 [exec] Session logged out. Session was 
JSESSIONID=0A16F70090D53A2C11D495F44F02A883.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess’ 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1716: 
exec returned: 2

Total time: 18 minutes 45 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3039
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss

Error Message:
expected:<1> but was:<2>

Stack Trace:
junit.framework.AssertionFailedError: expected:<1> but was:<2>
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss(QuorumPeerMainTest.java:969)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)

[jira] [Commented] (ZOOKEEPER-1919) Update the C implementation of removeWatches to have it match ZOOKEEPER-1910

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471074#comment-16471074
 ] 

Hadoop QA commented on ZOOKEEPER-1919:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12659496/ZOOKEEPER-1919.patch
  against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3677//console

This message is automatically generated.

> Update the C implementation of removeWatches to have it match ZOOKEEPER-1910
> 
>
> Key: ZOOKEEPER-1919
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1919
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.0
>Reporter: Raul Gutierrez Segales
>Assignee: Raul Gutierrez Segales
>Priority: Major
> Fix For: 3.6.0, 3.5.5
>
> Attachments: ZOOKEEPER-1919.patch, ZOOKEEPER-1919.patch
>
>
> See https://issues.apache.org/jira/browse/ZOOKEEPER-1910



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER-1919 PreCommit Build #3677

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1919
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3677/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 6.41 KB...]
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12659496/ZOOKEEPER-1919.patch
 [exec]   against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3677//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16471074 added to ZOOKEEPER-1919.
 [exec] Session logged out. Session was 
JSESSIONID=6F960974360B54C2856385C4B7705B6C.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1716: 
exec returned: 1

Total time: 42 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3039
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2097) Clarify security requirement for Exists request

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471071#comment-16471071
 ] 

Hadoop QA commented on ZOOKEEPER-2097:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12688439/ZOOKEEPER-2097.patch
  against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3674//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3674//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3674//console

This message is automatically generated.

> Clarify security requirement for Exists request
> ---
>
> Key: ZOOKEEPER-2097
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2097
> Project: ZooKeeper
>  Issue Type: Task
>Affects Versions: 3.4.6, 3.5.0
>Reporter: Ian Dimayuga
>Assignee: Ian Dimayuga
>Priority: Minor
> Fix For: 3.6.0, 3.5.5
>
> Attachments: ZOOKEEPER-2097.patch
>
>
> According to the [Programmer's 
> Guide|http://zookeeper.apache.org/doc/current/zookeeperProgrammers.html]:
> bq. Everyone implicitly has LOOKUP permission. This allows you to stat a 
> node, but nothing more. (The problem is, if you want to call zoo_exists() on 
> a node that doesn't exist, there is no permission to check.)
> This implies that Exists has no security requirement, so the existing comment 
> in FinalRequestProcessor
> {code}// TODO we need to figure out the security requirement for this!{code}
> can be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-1818) Fix don't care for trunk

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471068#comment-16471068
 ] 

Hadoop QA commented on ZOOKEEPER-1818:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12766285/ZOOKEEPER-1818.patch
  against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3675//console

This message is automatically generated.

> Fix don't care for trunk
> 
>
> Key: ZOOKEEPER-1818
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1818
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Flavio Junqueira
>Assignee: Germán Blanco
>Priority: Blocker
> Fix For: 3.6.0, 3.5.5
>
> Attachments: ZOOKEEPER-1818.patch
>
>
> See umbrella jira.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER-1818 PreCommit Build #3675

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1818
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3675/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 6.86 KB...]
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12766285/ZOOKEEPER-1818.patch
 [exec]   against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3675//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16471068 added to ZOOKEEPER-1818.
 [exec] Session logged out. Session was 
JSESSIONID=64C969128D815E41CE4096EB2CB88E81.
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
are the same file
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1716: 
exec returned: 1

Total time: 46 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3039
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2031) Support tagging a QuorumServer

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471058#comment-16471058
 ] 

Hadoop QA commented on ZOOKEEPER-2031:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12668943/ZOOKEEPER-2031-Additional.patch
  against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3670//console

This message is automatically generated.

> Support tagging a QuorumServer
> --
>
> Key: ZOOKEEPER-2031
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2031
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: some one
>Assignee: some one
>Priority: Major
> Fix For: 3.6.0, 3.5.5
>
> Attachments: ZOOKEEPER-2031-Additional.patch, ZOOKEEPER-2031.patch
>
>
> Currently ZooKeeper only allows using the server id which is an integer for 
> identifying servers. For my (unavoidable) use case, there may be concurrent 
> dynamic removes and adds of servers which may eventually have id collisions. 
> When this occurs, there is no good way to determine if the server (given an 
> id collision) that we want to remove is the right server.
> To support my use case, I propose that we add a tag field to the server 
> string.
> For my specific use case, this tag field will be used to store a uuid as a 
> string.
> So for example:
> server.1=127.0.0.1:1234:1236:participant;0.0.0.0:1237;743b9d23-85cb-45b1-8949-930fdabb21f0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER-2031 PreCommit Build #3670

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2031
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3670/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 5.76 KB...]
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12668943/ZOOKEEPER-2031-Additional.patch
 [exec]   against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3670//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16471058 added to ZOOKEEPER-2031.
 [exec] Session logged out. Session was 
JSESSIONID=5CF4D189EF2A8506B5D694B3BFFB0AE6.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1716: 
exec returned: 1

Total time: 1 minute 9 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3039
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2260) Paginated getChildren call

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471056#comment-16471056
 ] 

Hadoop QA commented on ZOOKEEPER-2260:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12777600/ZOOKEEPER-2260.patch
  against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 8 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3669//console

This message is automatically generated.

> Paginated getChildren call
> --
>
> Key: ZOOKEEPER-2260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2260
> Project: ZooKeeper
>  Issue Type: New Feature
>Affects Versions: 3.4.6, 3.5.0
>Reporter: Marco P.
>Assignee: Marco P.
>Priority: Major
>  Labels: api, features
> Fix For: 3.6.0, 3.5.5
>
> Attachments: ZOOKEEPER-2260.patch, ZOOKEEPER-2260.patch
>
>
> Add pagination support to the getChildren() call, allowing clients to iterate 
> over children N at the time.
> Motivations for this include:
>   - Getting out of a situation where so many children were created that 
> listing them exceeded the network buffer sizes (making it impossible to 
> recover by deleting)[1]
>  - More efficient traversal of nodes with large number of children [2]
> I do have a patch (for 3.4.6) we've been using successfully for a while, but 
> I suspect much more work is needed for this to be accepted. 
> [1] https://issues.apache.org/jira/browse/ZOOKEEPER-272
> [2] https://issues.apache.org/jira/browse/ZOOKEEPER-282



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER-2260 PreCommit Build #3669

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2260
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3669/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 7.23 KB...]
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12777600/ZOOKEEPER-2260.patch
 [exec]   against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 8 new or 
modified tests.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3669//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16471056 added to ZOOKEEPER-2260.
 [exec] Session logged out. Session was 
JSESSIONID=B6075500BE53240C286FBD01D284EF90.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1716: 
exec returned: 1

Total time: 1 minute 6 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3039
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

Failed: ZOOKEEPER-2277 PreCommit Build #3668

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2277
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3668/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 7.05 KB...]
 [exec] 
 [exec] 
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12771001/ZOOKEEPER-2277-02.patch
 [exec]   against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 2 new or 
modified tests.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3668//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16471055 added to ZOOKEEPER-2277.
 [exec] Session logged out. Session was 
JSESSIONID=3C18C706F5B564B119423CE3257230BF.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1716: 
exec returned: 1

Total time: 1 minute 16 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3039
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-2277) Zookeeper off-line snapshot and transaction log viewer

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471055#comment-16471055
 ] 

Hadoop QA commented on ZOOKEEPER-2277:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12771001/ZOOKEEPER-2277-02.patch
  against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 2 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3668//console

This message is automatically generated.

> Zookeeper off-line snapshot and transaction log viewer
> --
>
> Key: ZOOKEEPER-2277
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2277
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Mohammad Arshad
>Assignee: Mohammad Arshad
>Priority: Major
> Fix For: 3.6.0, 3.5.5
>
> Attachments: ZOOKEEPER-2277-01.patch, ZOOKEEPER-2277-02.patch
>
>
> {color:blue}Currently ZooKeeper provides utility java program to view the 
> snapshot and transaction off-line but these are not easy to use, also the 
> content is less understandable {color}
> In this improvement task I propose following functionality:
> 1) add zkTool.sh script to view snapshot and transaction.
> Usage: zkTool.sh -COMMAND 
> where COMMAND is one of:
> otv   off-line transaction viewer, prints ZooKeeper transaction log in text 
> format
> osv   off-line snapshot viewer, prints ZooKeeper snapshot in text format
> 2) otv command will give output as:
> {noformat}
> 9/4/15 4:37:04 PM IST session 0x1004d19fe6f0002 cxid  0x000c2c 
> (epoch=0,count=3116) zxid  0x010c49 (epoch=1,count=3145) create 
> path="/4da53875-b471-4ab1-9995-03889e73c0a3/node246",data="Quick brown fox 
> jumps over the lazy dog 
> ",acl{e1{perms="cdrwa",id{scheme="world",id="anyone"}}},ephemeral="true",parentCVersion="8"
> {noformat}
> It is mostly same as {{org.apache.zookeeper.server.LogFormatter}} with some 
> differences. 
> * epoch and count are separated from zxid. 
> * operations type will be written instead of code like createSession instead 
> -10. 
> * showing data. 
> * permissions are written in letters perms="cdrwa" instead of perms="31" same 
> as {{org.apache.zookeeper.cli.GetAclCommand}}. 
> * ephemeral="true" instead of  ephemeral="1"
> * etc.
> 3) osv command will give output as:
> {code}
> /67868d36-8bbf-4a8a-a076-f16810ac10de/node5410
>   cZxid = 0x010265 (epoch=1,count=613)
>   ctime = Fri Sep 04 16:35:58 IST 2015
>   mZxid = 0x010265 (epoch=1,count=613)
>   mtime = Fri Sep 04 16:35:58 IST 2015
>   pZxid = 0x010265 (epoch=1,count=613)
>   cversion = 0
>   dataVersion = 0
>   aclVersion = 0
>   ephemeralOwner = 0x1004d19fe6f0002
>   dataLength = 40
>   data = Quick brown fox jumps over the lazy dog
> {code}
> which is almost same as {{org.apache.zookeeper.server.SnapshotFormatter}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-1681) ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare the dep as optional

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471051#comment-16471051
 ] 

Hadoop QA commented on ZOOKEEPER-1681:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12665883/ZOOKEEPER-1681.patch
  against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3666//console

This message is automatically generated.

> ZooKeeper 3.4.x can optionally use netty for nio but the pom does not declare 
> the dep as optional
> -
>
> Key: ZOOKEEPER-1681
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1681
> Project: ZooKeeper
>  Issue Type: Improvement
>Affects Versions: 3.4.0, 3.4.1, 3.4.2, 3.4.4, 3.4.5
>Reporter: John Sirois
>Assignee: Stevo Slavic
>Priority: Major
> Fix For: 3.6.0, 3.5.5
>
> Attachments: ZOOKEEPER-1681.patch
>
>
> For example in 
> [3.4.5|http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom]
>  we see:
> {code}
> $ curl -sS 
> http://search.maven.org/remotecontent?filepath=org/apache/zookeeper/zookeeper/3.4.5/zookeeper-3.4.5.pom
>  | grep -B1 -A4 org.jboss.netty
> 
>   org.jboss.netty
>   netty
>   3.2.2.Final
>   compile
> 
> {code}
> As a consumer I can depend on zookeeper with an exclude for 
> org.jboss.netty#netty or I can let my transitive dep resolver pick a winner.  
> This might be fine, except for those who might be using a more modern netty 
> published under the newish io.netty groupId.  With this twist you get both 
> org.jboss.netty#netty;foo and io.netty#netty;bar on your classpath and 
> runtime errors ensue from incompatibilities. unless you add an exclude 
> against zookeeper (and clearly don't enable the zk netty nio handling.)
> I propose that this is a pom bug although this is debatable.  Clearly as 
> currently packaged zookeeper needs netty to compile, but I'd argue since it 
> does not need netty to run, either the scope should be provided or optional 
> or a zookeeper-netty lib should be broken out as an optional dependency and 
> this new dep published by zookeeper can have a proper compile dependency on 
> netty.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER-1681 PreCommit Build #3666

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1681
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3666/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 6.08 KB...]
 [exec] 
 [exec] -1 overall.  Here are the results of testing the latest attachment 
 [exec]   
http://issues.apache.org/jira/secure/attachment/12665883/ZOOKEEPER-1681.patch
 [exec]   against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] -1 patch.  The patch command could not apply the patch.
 [exec] 
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3666//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16471051 added to ZOOKEEPER-1681.
 [exec] Session logged out. Session was 
JSESSIONID=884A82779F71BBD9A3E99DB9B5F25B1C.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/patchprocess' 
are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1716: 
exec returned: 1

Total time: 1 minute 20 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] No prior successful build to compare, so performing full copy 
of artifacts
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3039
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Updated] (ZOOKEEPER-3039) TxnLogToolkit uses Scanner badly

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-3039:

Fix Version/s: 3.4.13
   3.6.0
   3.5.4

> TxnLogToolkit uses Scanner badly
> 
>
> Key: ZOOKEEPER-3039
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3039
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.4, 3.6.0, 3.4.13
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> If more than 1 CRC error is found in the Txn log file, TxnLogToolkit fails to 
> get an answer for the second one, because it has already closed the Scanner 
> which was probably closed the input stream also, so exception is thrown:
> {noformat}
> ZooKeeper Transactional Log File with dbid 0 txnlog format version 2
> CRC ERROR - 4/5/18 5:16:05 AM PDT session 0x16295bafcc4 cxid 0x1 zxid 
> 0x10002 closeSession null
> Would you like to fix it (Yes/No/Abort) ? y
> CRC ERROR - 4/5/18 5:17:34 AM PDT session 0x26295bafcc9 cxid 0x0 zxid 
> 0x20001 closeSession null
> Would you like to fix it (Yes/No/Abort) ? Exception in thread "main" 
> java.util.NoSuchElementException
> at java.util.Scanner.throwFor(Scanner.java:862)
> at java.util.Scanner.next(Scanner.java:1371)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.askForFix(TxnLogToolkit.java:208)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.dump(TxnLogToolkit.java:175)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.main(TxnLogToolkit.java:101){noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3039) TxnLogToolkit uses Scanner badly

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-3039:

Affects Version/s: 3.4.13

> TxnLogToolkit uses Scanner badly
> 
>
> Key: ZOOKEEPER-3039
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3039
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.4, 3.6.0, 3.4.13
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> If more than 1 CRC error is found in the Txn log file, TxnLogToolkit fails to 
> get an answer for the second one, because it has already closed the Scanner 
> which was probably closed the input stream also, so exception is thrown:
> {noformat}
> ZooKeeper Transactional Log File with dbid 0 txnlog format version 2
> CRC ERROR - 4/5/18 5:16:05 AM PDT session 0x16295bafcc4 cxid 0x1 zxid 
> 0x10002 closeSession null
> Would you like to fix it (Yes/No/Abort) ? y
> CRC ERROR - 4/5/18 5:17:34 AM PDT session 0x26295bafcc9 cxid 0x0 zxid 
> 0x20001 closeSession null
> Would you like to fix it (Yes/No/Abort) ? Exception in thread "main" 
> java.util.NoSuchElementException
> at java.util.Scanner.throwFor(Scanner.java:862)
> at java.util.Scanner.next(Scanner.java:1371)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.askForFix(TxnLogToolkit.java:208)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.dump(TxnLogToolkit.java:175)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.main(TxnLogToolkit.java:101){noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #517: ZOOKEEPER-3039 TxnLogToolkit uses Scanner badly

[phunt]

Github user phunt commented on the issue:

https://github.com/apache/zookeeper/pull/517
  
+1. I committed to 3.5 and master however it doesn't apply cleanly to 
branch-3.4. Please submit a separate PR.


---

[GitHub] zookeeper pull request #517: ZOOKEEPER-3039 TxnLogToolkit uses Scanner badly

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/517


---

[jira] [Commented] (ZOOKEEPER-1807) Observers spam each other creating connections to the election addr

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471020#comment-16471020
 ] 

Patrick Hunt commented on ZOOKEEPER-1807:
-

The test is failing occasionally, but at this point fairly rarely. I'm 
reclosing this given the fix is in, however if it shows up again please open a 
new JIRA.

> Observers spam each other creating connections to the election addr
> ---
>
> Key: ZOOKEEPER-1807
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1807
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Raul Gutierrez Segales
>Assignee: Alexander Shraer
>Priority: Blocker
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1807-alex.patch, ZOOKEEPER-1807-ver2.patch, 
> ZOOKEEPER-1807-ver3.patch, ZOOKEEPER-1807-ver4.patch, 
> ZOOKEEPER-1807-ver5.patch, ZOOKEEPER-1807-ver6.patch, 
> ZOOKEEPER-1807-ver7.patch, ZOOKEEPER-1807.patch, notifications-loop.png
>
>
> Hey [~shralex],
> I noticed today that my Observers are spamming each other trying to open 
> connections to the election port. I've got tons of these:
> {noformat}
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 9
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 10
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 6
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 12
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 14
> {noformat}
> and so and so on ad nauseam. 
> Now, looking around I found this inside FastLeaderElection.java from when you 
> committed ZOOKEEPER-107:
> {noformat}
>  private void sendNotifications() {
> -for (QuorumServer server : self.getVotingView().values()) {
> -long sid = server.id;
> -
> +for (long sid : self.getAllKnownServerIds()) {
> +QuorumVerifier qv = self.getQuorumVerifier();
> {noformat}
> Is that really desired? I suspect that is what's causing Observers to try to 
> connect to each other (as opposed as just connecting to participants). I'll 
> give it a try now and let you know. (Also, we use observer ids that are > 0, 
> and I saw some parts of the code that might not deal with that assumption - 
> so it could be that too..). 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ZOOKEEPER-1807) Observers spam each other creating connections to the election addr

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt resolved ZOOKEEPER-1807.
-
Resolution: Fixed

> Observers spam each other creating connections to the election addr
> ---
>
> Key: ZOOKEEPER-1807
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1807
> Project: ZooKeeper
>  Issue Type: Bug
>Reporter: Raul Gutierrez Segales
>Assignee: Alexander Shraer
>Priority: Blocker
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1807-alex.patch, ZOOKEEPER-1807-ver2.patch, 
> ZOOKEEPER-1807-ver3.patch, ZOOKEEPER-1807-ver4.patch, 
> ZOOKEEPER-1807-ver5.patch, ZOOKEEPER-1807-ver6.patch, 
> ZOOKEEPER-1807-ver7.patch, ZOOKEEPER-1807.patch, notifications-loop.png
>
>
> Hey [~shralex],
> I noticed today that my Observers are spamming each other trying to open 
> connections to the election port. I've got tons of these:
> {noformat}
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 9
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 10
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 6
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 12
> 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a 
> connection already for server 14
> {noformat}
> and so and so on ad nauseam. 
> Now, looking around I found this inside FastLeaderElection.java from when you 
> committed ZOOKEEPER-107:
> {noformat}
>  private void sendNotifications() {
> -for (QuorumServer server : self.getVotingView().values()) {
> -long sid = server.id;
> -
> +for (long sid : self.getAllKnownServerIds()) {
> +QuorumVerifier qv = self.getQuorumVerifier();
> {noformat}
> Is that really desired? I suspect that is what's causing Observers to try to 
> connect to each other (as opposed as just connecting to participants). I'll 
> give it a try now and let you know. (Also, we use observer ids that are > 0, 
> and I saw some parts of the code that might not deal with that assumption - 
> so it could be that too..). 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuthLearner...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/496
  
@lujiefsi Have you run the tests on your machine and was all green?
Maybe it's some flaky tests and you just need to trigger another build.


---

Success: ZOOKEEPER- PreCommit Build #1672

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1672/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 84.58 MB...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1672//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1672//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1672//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16470922 added to ZOOKEEPER-3039.
 [exec] Session logged out. Session was 
JSESSIONID=822156C028B0921EC096920BCB15A3E8.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 17 minutes 47 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3039
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-3039) TxnLogToolkit uses Scanner badly

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470922#comment-16470922
 ] 

Hadoop QA commented on ZOOKEEPER-3039:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1672//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1672//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1672//console

This message is automatically generated.

> TxnLogToolkit uses Scanner badly
> 
>
> Key: ZOOKEEPER-3039
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3039
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
>
> If more than 1 CRC error is found in the Txn log file, TxnLogToolkit fails to 
> get an answer for the second one, because it has already closed the Scanner 
> which was probably closed the input stream also, so exception is thrown:
> {noformat}
> ZooKeeper Transactional Log File with dbid 0 txnlog format version 2
> CRC ERROR - 4/5/18 5:16:05 AM PDT session 0x16295bafcc4 cxid 0x1 zxid 
> 0x10002 closeSession null
> Would you like to fix it (Yes/No/Abort) ? y
> CRC ERROR - 4/5/18 5:17:34 AM PDT session 0x26295bafcc9 cxid 0x0 zxid 
> 0x20001 closeSession null
> Would you like to fix it (Yes/No/Abort) ? Exception in thread "main" 
> java.util.NoSuchElementException
> at java.util.Scanner.throwFor(Scanner.java:862)
> at java.util.Scanner.next(Scanner.java:1371)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.askForFix(TxnLogToolkit.java:208)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.dump(TxnLogToolkit.java:175)
> at 
> org.apache.zookeeper.server.persistence.TxnLogToolkit.main(TxnLogToolkit.java:101){noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Discover LEADER from JMX

[Andor Molnar]

"in order to guess which is the leader I have to ask to all of the three
nodes in the cluster"

That's correct.

Regards,
Andor



On Thu, May 10, 2018 at 4:07 AM, Enrico Olivelli 
wrote:

> Il giorno mer 9 mag 2018 alle ore 20:24 Patrick Hunt  ha
> scritto:
>
> > iiuc what you are interested in the information is already available. The
> > beans have a "state" attribute which indicates following vs leading.
> >
> > Try attaching a jconsole to the running servers, use the "mbeans" tab and
> > open org.apache.ZooKeeperService -> replicatedserver -> replica ->
> > attributes, you'll see the "state" attribute there.
> >
>
>
> Patrick,
> I can't find this information.
> If I log into a "follower" I get this info only for the 'current replica'
>
> Example, I have three peers,  the first one is a "Follower", on JMX I have
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - ClientAddress
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - ElectionAddress
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - LearnerType
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - Name
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - QuorumAddress
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - State =
> following
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - ConfigVersion
> .
>
>
>
> for other peers I see only
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_2 - ClientAddress
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_2 - ElectionAddress
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_2 - LearnerType
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_2 - Name
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_2 - QuorumAddress
>
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_3 - ClientAddress
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_3 - ElectionAddress
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_3 - LearnerType
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_3 - Name
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_3 - QuorumAddress
>
>
> so quering only this server I cannot guess which is the current leader, the
> only information I can extract is:
> - I am a follower
> - We are a cluster of three
> - Every of the three is a PARTECIPANT (no observers)
>
> in order to guess which is the leader I have to ask to all of the three
> nodes in the cluster
>
> Am I missing something ? I am running 3.5.3-BETA
>
> Enrico
>
>
>
>
>
>
>
>
>
>
>
>
>
> >
> > Patrick
> >
> > On Wed, May 9, 2018 at 8:02 AM, Enrico Olivelli 
> > wrote:
> >
> > > Thank you Edward
> > >
> > > I will pack all together and send out a patch as soon as I have time.
> > > I am running 3.5 in production and given than an RC for 3.5.4 is going
> to
> > > be cut soon I will have to wait for 3.5.5 and I assume it won't be
> > > immediate.
> > >
> > > Cheers
> > > Enrico
> > >
> > > Il giorno mer 9 mag 2018 alle ore 14:37 Edward Ribeiro <
> > > edward.ribe...@gmail.com> ha scritto:
> > >
> > > > Sent before finishing the previous email. Only to complement, the
> > > > findLeader() could have been as below, but this change is only a
> nitty
> > > > detail and totally irrelevant to the questions you are asking. :)
> > > >
> > > > /**
> > > >  * Returns the address of the node we think is the leader.
> > > >  */
> > > > protected QuorumServer findLeader() {
> > > >
> > > > // Find the leader by id
> > > > long currentLeader = self.getCurrentVote().getId();
> > > >
> > > > QuorumServer leaderServer = self.getView().get(currentLeader);
> > > >
> > > > if (leaderServer == null) {
> > > > LOG.warn("Couldn't find the leader with id = {}",
> > currentLeader);
> > > > }
> > > > return leaderServer;
> > > > }
> > > >
> > > > Edward
> > > >
> > > > On Wed, May 9, 2018 at 9:29 AM, Edward Ribeiro <
> > edward.ribe...@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > Hi Enrico,
> > > > >
> > > > > Well, I am not an expert on QuorumPeer either (not an expert on
> > > anything,
> > > > > really), but maybe it's the variable and method below?
> > > > >
> > > > > - QuorumPeer --
> > > > >
> > > > > /**
> > > > >  * This is who I think the leader currently is.
> > > > >  */
> > > > > volatile private Vote currentVote;
> > > > >
> > > > > public synchronized Vote getCurrentVote(){
> > > > > return currentVote;
> > > > > }
> > > > >
> > > > > ---
> > > > >
> > > > >
> > > > > Then it's a matter of calling quorumPeer.getCurrentVote().getId()
> and
> > > > > quorumPeer.getServerState()?
> > > > >
> > > > > Btw, the Learner class has this handy method below (self is a
> > > > QuorumPeer):
> > > > >
> > > > >  Learner 
> > > > >
> > > > > /**
> > > > >  * Returns the address of the node we think is the leader.
> > > > >  

Re: Apache ZooKeeper meetup May 9th in Palo Alto?

[Srikanth Viswanathan]

Thanks for the presentations! Will the slides be posted somewhere?

On Thu, May 10, 2018, 09:36 Prasanth Mathialagan <
prasanthmathiala...@gmail.com> wrote:

> Gosh!! I missed it!! May be next time :)
>
> On Thu, May 10, 2018 at 8:24 AM, Andor Molnar  wrote:
>
> > Thanks everybody for joining.
> > It was great to see you folks in person and talk.
> >
> > Regards,
> > Andor
> >
> >
> >
> > On Wed, May 9, 2018 at 9:44 PM, Patrick Hunt  wrote:
> >
> > > On Wed, May 9, 2018 at 9:24 PM, Jeff Widman 
> wrote:
> > >
> > > > Many thanks to Patrick, Andor and the rest of the Cloudera team for
> > > hosting
> > > > us tonight. I appreciated the chance to compare notes with other
> users
> > > and
> > > > also discuss some of where the future of Zookeeper is heading.
> > > >
> > > >
> > > Thanks everyone for attending. It was great to see some old as well as
> > new
> > > faces.
> > >
> > >
> > > > Cheers,
> > > > Jeff
> > > >
> > > > PS: Apologies to the remote folks for the dead sound at the end--the
> > > > hangout connection to the conference room sound system died, and
> nobody
> > > in
> > > > the room knew how to reconnect it.
> > > >
> > > >
> > > Yea, sorry about that. IT did some magic to connect the hangout into
> the
> > > internal audio system of the room and I wasn't able to figure out the
> > codes
> > > they used.
> > >
> > > Regards,
> > >
> > > Patrick
> > >
> > >
> > > >
> > > > On Fri, Apr 27, 2018 at 6:40 PM, Srikanth Viswanathan <
> > > > srikant...@gmail.com>
> > > > wrote:
> > > >
> > > > > Confirming attendance from Seattle as well. Looking forward to the
> > > > > presentations. Particularly excited for the containers talk!
> > > > >
> > > > > On Thu, Apr 26, 2018, 10:29 Patrick Hunt  wrote:
> > > > >
> > > > > > Ok, great. I have two speakers already lined up: one on ZK and
> > > > containers
> > > > > > and another on ZK failure modes and recovery. If you haven't
> > reached
> > > > out
> > > > > to
> > > > > > me yet and you have something to talk about please LMK asap.
> > > > > >
> > > > > > I believe we will have video conference available but I'm not
> > > entirely
> > > > > sure
> > > > > > yet - I will try.
> > > > > >
> > > > > > I'll finalize things and send out a more detailed agenda.
> > > > > >
> > > > > > Regards,
> > > > > >
> > > > > > Patrick
> > > > > >
> > > > > > On Thu, Apr 26, 2018 at 1:33 AM, Shivam Goel <
> shivam@gmail.com
> > >
> > > > > wrote:
> > > > > >
> > > > > > > Count me in !!
> > > > > > >
> > > > > > > On Mon, Apr 23, 2018 at 10:08 AM Patrick Hunt <
> ph...@apache.org>
> > > > > wrote:
> > > > > > >
> > > > > > > > Hi folks. I am interested in hosting a ZooKeeper meetup May
> 9th
> > > in
> > > > > > > > Cloudera's Palo Alto offices. It's been a while since we last
> > got
> > > > > > > together,
> > > > > > > > lots of recent changes and some big plans, new additions to
> the
> > > PMC
> > > > > and
> > > > > > > > committer lists, new contributors.
> > > > > > > >
> > > > > > > > I was hoping to use the mailing lists to gauge interest.
> Please
> > > > reply
> > > > > > if
> > > > > > > > you
> > > > > > > > think you would be able to attend or would prefer a different
> > > date.
> > > > > > Also
> > > > > > > > let me know if there's something you would like to present to
> > the
> > > > > > group.
> > > > > > > > Food
> > > > > > > > and beer will be provided.
> > > > > > > >
> > > > > > > > Looking forward to hearing from everyone.
> > > > > > > >
> > > > > > > > Regards,
> > > > > > > >
> > > > > > > > Patrick
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > >
> > > > *Jeff Widman*
> > > > jeffwidman.com  | 740-WIDMAN-J
> (943-6265)
> > > > <><
> > > >
> > >
> >
>

Re: Apache ZooKeeper meetup May 9th in Palo Alto?

[Prasanth Mathialagan]

Gosh!! I missed it!! May be next time :)

On Thu, May 10, 2018 at 8:24 AM, Andor Molnar  wrote:

> Thanks everybody for joining.
> It was great to see you folks in person and talk.
>
> Regards,
> Andor
>
>
>
> On Wed, May 9, 2018 at 9:44 PM, Patrick Hunt  wrote:
>
> > On Wed, May 9, 2018 at 9:24 PM, Jeff Widman  wrote:
> >
> > > Many thanks to Patrick, Andor and the rest of the Cloudera team for
> > hosting
> > > us tonight. I appreciated the chance to compare notes with other users
> > and
> > > also discuss some of where the future of Zookeeper is heading.
> > >
> > >
> > Thanks everyone for attending. It was great to see some old as well as
> new
> > faces.
> >
> >
> > > Cheers,
> > > Jeff
> > >
> > > PS: Apologies to the remote folks for the dead sound at the end--the
> > > hangout connection to the conference room sound system died, and nobody
> > in
> > > the room knew how to reconnect it.
> > >
> > >
> > Yea, sorry about that. IT did some magic to connect the hangout into the
> > internal audio system of the room and I wasn't able to figure out the
> codes
> > they used.
> >
> > Regards,
> >
> > Patrick
> >
> >
> > >
> > > On Fri, Apr 27, 2018 at 6:40 PM, Srikanth Viswanathan <
> > > srikant...@gmail.com>
> > > wrote:
> > >
> > > > Confirming attendance from Seattle as well. Looking forward to the
> > > > presentations. Particularly excited for the containers talk!
> > > >
> > > > On Thu, Apr 26, 2018, 10:29 Patrick Hunt  wrote:
> > > >
> > > > > Ok, great. I have two speakers already lined up: one on ZK and
> > > containers
> > > > > and another on ZK failure modes and recovery. If you haven't
> reached
> > > out
> > > > to
> > > > > me yet and you have something to talk about please LMK asap.
> > > > >
> > > > > I believe we will have video conference available but I'm not
> > entirely
> > > > sure
> > > > > yet - I will try.
> > > > >
> > > > > I'll finalize things and send out a more detailed agenda.
> > > > >
> > > > > Regards,
> > > > >
> > > > > Patrick
> > > > >
> > > > > On Thu, Apr 26, 2018 at 1:33 AM, Shivam Goel  >
> > > > wrote:
> > > > >
> > > > > > Count me in !!
> > > > > >
> > > > > > On Mon, Apr 23, 2018 at 10:08 AM Patrick Hunt 
> > > > wrote:
> > > > > >
> > > > > > > Hi folks. I am interested in hosting a ZooKeeper meetup May 9th
> > in
> > > > > > > Cloudera's Palo Alto offices. It's been a while since we last
> got
> > > > > > together,
> > > > > > > lots of recent changes and some big plans, new additions to the
> > PMC
> > > > and
> > > > > > > committer lists, new contributors.
> > > > > > >
> > > > > > > I was hoping to use the mailing lists to gauge interest. Please
> > > reply
> > > > > if
> > > > > > > you
> > > > > > > think you would be able to attend or would prefer a different
> > date.
> > > > > Also
> > > > > > > let me know if there's something you would like to present to
> the
> > > > > group.
> > > > > > > Food
> > > > > > > and beer will be provided.
> > > > > > >
> > > > > > > Looking forward to hearing from everyone.
> > > > > > >
> > > > > > > Regards,
> > > > > > >
> > > > > > > Patrick
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > >
> > > *Jeff Widman*
> > > jeffwidman.com  | 740-WIDMAN-J (943-6265)
> > > <><
> > >
> >
>

Re: Apache ZooKeeper meetup May 9th in Palo Alto?

[Andor Molnar]

Thanks everybody for joining.
It was great to see you folks in person and talk.

Regards,
Andor



On Wed, May 9, 2018 at 9:44 PM, Patrick Hunt  wrote:

> On Wed, May 9, 2018 at 9:24 PM, Jeff Widman  wrote:
>
> > Many thanks to Patrick, Andor and the rest of the Cloudera team for
> hosting
> > us tonight. I appreciated the chance to compare notes with other users
> and
> > also discuss some of where the future of Zookeeper is heading.
> >
> >
> Thanks everyone for attending. It was great to see some old as well as new
> faces.
>
>
> > Cheers,
> > Jeff
> >
> > PS: Apologies to the remote folks for the dead sound at the end--the
> > hangout connection to the conference room sound system died, and nobody
> in
> > the room knew how to reconnect it.
> >
> >
> Yea, sorry about that. IT did some magic to connect the hangout into the
> internal audio system of the room and I wasn't able to figure out the codes
> they used.
>
> Regards,
>
> Patrick
>
>
> >
> > On Fri, Apr 27, 2018 at 6:40 PM, Srikanth Viswanathan <
> > srikant...@gmail.com>
> > wrote:
> >
> > > Confirming attendance from Seattle as well. Looking forward to the
> > > presentations. Particularly excited for the containers talk!
> > >
> > > On Thu, Apr 26, 2018, 10:29 Patrick Hunt  wrote:
> > >
> > > > Ok, great. I have two speakers already lined up: one on ZK and
> > containers
> > > > and another on ZK failure modes and recovery. If you haven't reached
> > out
> > > to
> > > > me yet and you have something to talk about please LMK asap.
> > > >
> > > > I believe we will have video conference available but I'm not
> entirely
> > > sure
> > > > yet - I will try.
> > > >
> > > > I'll finalize things and send out a more detailed agenda.
> > > >
> > > > Regards,
> > > >
> > > > Patrick
> > > >
> > > > On Thu, Apr 26, 2018 at 1:33 AM, Shivam Goel 
> > > wrote:
> > > >
> > > > > Count me in !!
> > > > >
> > > > > On Mon, Apr 23, 2018 at 10:08 AM Patrick Hunt 
> > > wrote:
> > > > >
> > > > > > Hi folks. I am interested in hosting a ZooKeeper meetup May 9th
> in
> > > > > > Cloudera's Palo Alto offices. It's been a while since we last got
> > > > > together,
> > > > > > lots of recent changes and some big plans, new additions to the
> PMC
> > > and
> > > > > > committer lists, new contributors.
> > > > > >
> > > > > > I was hoping to use the mailing lists to gauge interest. Please
> > reply
> > > > if
> > > > > > you
> > > > > > think you would be able to attend or would prefer a different
> date.
> > > > Also
> > > > > > let me know if there's something you would like to present to the
> > > > group.
> > > > > > Food
> > > > > > and beer will be provided.
> > > > > >
> > > > > > Looking forward to hearing from everyone.
> > > > > >
> > > > > > Regards,
> > > > > >
> > > > > > Patrick
> > > > > >
> > > > >
> > > >
> > >
> >
> >
> >
> > --
> >
> > *Jeff Widman*
> > jeffwidman.com  | 740-WIDMAN-J (943-6265)
> > <><
> >
>

Re: Name resolution in StaticHostProvider

[Andor Molnar]

Interesting idea. What difference you think it could make comparing to
checked?



On Wed, May 9, 2018 at 8:01 AM, Flavio Junqueira  wrote:

> I'm actually now wondering whether we should be using an unchecked
> exception instead. A lot of things have changed with exception handling
> since we wrote this code base initially. An unchecked exception would
> actually match better my current mental model of what that signature should
> look like.
>
> -Flavio
>
> > On 9 May 2018, at 16:44, Flavio Junqueira  wrote:
> >
> > I like the idea of indicating to the application that there is something
> wrong with the list of servers so that it has a chance to look into it.
> With the current code in `ClientCnxn`, we will log at warn level and hope
> that someone sees it, but we are not really stopping the client. Throwing
> might actually be an improvement as it will output a log message, but I'm
> now wondering if we should propagate it all the way to the application.
> Responding to myself, one reason for not doing it is that it is not a fatal
> error unless no server can be resolved.
> >
> > -Flavio
> >
> >> On 8 May 2018, at 16:06, Andor Molnar  wrote:
> >>
> >> Hi,
> >>
> >> Updating this thread, because the PR is still being review on GitHub.
> >>
> >> So, the reason why I refactored the original behaviour of
> >> StaticHostProvider is that I believe that it's trying to do something
> which
> >> is not its responsibility. Please tell me if there's a good historical
> >> reason for that.
> >>
> >> My approach is giving the user the following to options:
> >> 1- Use static IP addresses, if you don't want to deal with DNS
> resolution
> >> at all - we guarantee that no DNS logic will involved in this case at
> all.
> >> 2- Use DNS hostnames if you have a reliable DNS service for resolution
> >> (with HA, secondary servers, backups, etc.) - we must use DNS in the
> right
> >> way in this case e.g. do NOT cache IP address for a longer period that
> DNS
> >> server allows to and re-resolve after TTL expries, because it's
> mandatory
> >> by protocol.
> >>
> >> My 2 cents here:
> >> - the fix which was originally posted for re-resolution is a workaround
> and
> >> doesn't satisfy the requirement for #2,
> >> - the solution is already built-in in JDK and DNS clients in the right
> way
> >> - can't see a reason why we shouldn't use that
> >>
> >> I checked this in some other projects as well and found very similar
> >> approach in hadoop-common's SecurityUtil.java. It has 2 built-in plugins
> >> for that:
> >> - Standard resolver uses java's built-in getByName().
> >> - Qualified resolver still uses getByName(), but adds some logic to
> avoid
> >> incorrect re-resolutions and reverse IP lookups.
> >>
> >> Please let me know your thoughts.
> >>
> >> Regards,
> >> Andor
> >>
> >>
> >>
> >>
> >>
> >>
> >> On Tue, Mar 6, 2018 at 8:12 AM, Andor Molnar 
> wrote:
> >>
> >>> Hi Abe,
> >>>
> >>> Unfortunately we haven't got any feedback yet. What do you think of
> >>> implementing Option #3?
> >>>
> >>> Regards,
> >>> Andor
> >>>
> >>>
> >>> On Thu, Feb 22, 2018 at 6:06 PM, Andor Molnar 
> wrote:
> >>>
>  Did anybody happen to take a quick look by any chance?
> 
>  I don't want to push this too hard, because I know it's a time
> consuming
>  topic to think about, but this is a blocker in 3.5 which has been
> hanging
>  around for a while and any feedback would be extremely helpful to
> close it
>  quickly.
> 
>  Thanks,
>  Andor
> 
> 
> 
>  On Mon, Feb 19, 2018 at 12:18 PM, Andor Molnar 
>  wrote:
> 
> > Hi all,
> >
> > We need more eyes and brains on the following PR:
> >
> > https://github.com/apache/zookeeper/pull/451
> >
> > I added a comment few days ago about the way we currently do DNS name
> > resolution in this class and a suggestion on how we could simplify
> things a
> > little bit. We talked about it with Abe Fine, but we're a little bit
> unsure
> > and cannot get a conclusion. It would be extremely handy to get more
> > feedback from you.
> >
> > To add some colour to it, let me elaborate on the situation here:
> >
> > In general, the task that StaticHostProvider does is to get a list of
> > potentially unresolved InetSocketAddress objects, resolve them and
> iterate
> > over the resolved objects by calling next() method.
> >
> > *Option #1 (current logic)*
> > - Resolve addresses with getAllByName() which returns a list of IP
> > addresses associated with the address.
> > - Cache all these IP's, shuffle them and iterate over.
> > - If client is unable to connect to an IP, remove all IPs from the
> list
> > which the original servername was resolved to and re-resolve it.
> >
> > *Option #2 (getByName())*
> > - Resolve address with 

Re: Discover LEADER from JMX

[Patrick Hunt]

On Thu, May 10, 2018 at 4:07 AM, Enrico Olivelli 
wrote:

> Il giorno mer 9 mag 2018 alle ore 20:24 Patrick Hunt  ha
> scritto:
>
> > iiuc what you are interested in the information is already available. The
> > beans have a "state" attribute which indicates following vs leading.
> >
> > Try attaching a jconsole to the running servers, use the "mbeans" tab and
> > open org.apache.ZooKeeperService -> replicatedserver -> replica ->
> > attributes, you'll see the "state" attribute there.
> >
>
>
> Patrick,
> I can't find this information.
> If I log into a "follower" I get this info only for the 'current replica'
>
> Example, I have three peers,  the first one is a "Follower", on JMX I have
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - ClientAddress
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - ElectionAddress
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - LearnerType
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - Name
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - QuorumAddress
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - State =
> following
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - ConfigVersion
> .
>
>
>
> for other peers I see only
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_2 - ClientAddress
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_2 - ElectionAddress
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_2 - LearnerType
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_2 - Name
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_2 - QuorumAddress
>
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_3 - ClientAddress
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_3 - ElectionAddress
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_3 - LearnerType
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_3 - Name
> o.a.ZookKeeperService - ReplicatedServer_id1 - replica_3 - QuorumAddress
>
>
> so quering only this server I cannot guess which is the current leader, the
> only information I can extract is:
> - I am a follower
> - We are a cluster of three
> - Every of the three is a PARTECIPANT (no observers)
>
> in order to guess which is the leader I have to ask to all of the three
> nodes in the cluster
>
>
Yes.

Patrick


> Am I missing something ? I am running 3.5.3-BETA
>
> Enrico
>
>
>
>
>
>
>
>
>
>
>
>
>
> >
> > Patrick
> >
> > On Wed, May 9, 2018 at 8:02 AM, Enrico Olivelli 
> > wrote:
> >
> > > Thank you Edward
> > >
> > > I will pack all together and send out a patch as soon as I have time.
> > > I am running 3.5 in production and given than an RC for 3.5.4 is going
> to
> > > be cut soon I will have to wait for 3.5.5 and I assume it won't be
> > > immediate.
> > >
> > > Cheers
> > > Enrico
> > >
> > > Il giorno mer 9 mag 2018 alle ore 14:37 Edward Ribeiro <
> > > edward.ribe...@gmail.com> ha scritto:
> > >
> > > > Sent before finishing the previous email. Only to complement, the
> > > > findLeader() could have been as below, but this change is only a
> nitty
> > > > detail and totally irrelevant to the questions you are asking. :)
> > > >
> > > > /**
> > > >  * Returns the address of the node we think is the leader.
> > > >  */
> > > > protected QuorumServer findLeader() {
> > > >
> > > > // Find the leader by id
> > > > long currentLeader = self.getCurrentVote().getId();
> > > >
> > > > QuorumServer leaderServer = self.getView().get(currentLeader);
> > > >
> > > > if (leaderServer == null) {
> > > > LOG.warn("Couldn't find the leader with id = {}",
> > currentLeader);
> > > > }
> > > > return leaderServer;
> > > > }
> > > >
> > > > Edward
> > > >
> > > > On Wed, May 9, 2018 at 9:29 AM, Edward Ribeiro <
> > edward.ribe...@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > Hi Enrico,
> > > > >
> > > > > Well, I am not an expert on QuorumPeer either (not an expert on
> > > anything,
> > > > > really), but maybe it's the variable and method below?
> > > > >
> > > > > - QuorumPeer --
> > > > >
> > > > > /**
> > > > >  * This is who I think the leader currently is.
> > > > >  */
> > > > > volatile private Vote currentVote;
> > > > >
> > > > > public synchronized Vote getCurrentVote(){
> > > > > return currentVote;
> > > > > }
> > > > >
> > > > > ---
> > > > >
> > > > >
> > > > > Then it's a matter of calling quorumPeer.getCurrentVote().getId()
> and
> > > > > quorumPeer.getServerState()?
> > > > >
> > > > > Btw, the Learner class has this handy method below (self is a
> > > > QuorumPeer):
> > > > >
> > > > >  Learner 
> > > > >
> > > > > /**
> > > > >  * Returns the address of the node we think is the leader.
> > > > >  */
> > > > > protected QuorumServer findLeader() {
> > > > > QuorumServer leaderServer = null;
> > > > > 

[GitHub] zookeeper issue #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuthLearner...

[lujiefsi]

Github user lujiefsi commented on the issue:

https://github.com/apache/zookeeper/pull/496
  
are the failure related to this patch???


---

ZooKeeper_branch35_jdk8 - Build # 955 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/955/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 35.97 KB...]
[junit] Running org.apache.zookeeper.server.quorum.LocalPeerBeanTest in 
thread 2
[junit] Running org.apache.zookeeper.server.quorum.ProposalStatsTest in 
thread 8
[junit] Running org.apache.zookeeper.server.quorum.QuorumPeerConfigTest in 
thread 3
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.083 sec, Thread: 8, Class: 
org.apache.zookeeper.server.quorum.ProposalStatsTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.294 sec, Thread: 2, Class: 
org.apache.zookeeper.server.quorum.LocalPeerBeanTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.19 sec, Thread: 3, Class: 
org.apache.zookeeper.server.quorum.QuorumPeerConfigTest
[junit] Running org.apache.zookeeper.server.quorum.QuorumPeerTest in thread 
2
[junit] Running org.apache.zookeeper.server.quorum.QuorumPeerMainTest in 
thread 8
[junit] Running 
org.apache.zookeeper.server.quorum.QuorumRequestPipelineTest in thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.341 sec, Thread: 2, Class: org.apache.zookeeper.server.quorum.QuorumPeerTest
[junit] Running org.apache.zookeeper.server.quorum.QuorumServerTest in 
thread 2
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.083 sec, Thread: 2, Class: org.apache.zookeeper.server.quorum.QuorumServerTest
[junit] Running org.apache.zookeeper.server.quorum.RaceConditionTest in 
thread 2
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
6.159 sec, Thread: 7, Class: org.apache.zookeeper.server.quorum.LearnerTest
[junit] Running org.apache.zookeeper.server.quorum.ReconfigBackupTest in 
thread 7
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
15.347 sec, Thread: 6, Class: 
org.apache.zookeeper.server.quorum.CommitProcessorTest
[junit] Running 
org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest in thread 6
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
8.037 sec, Thread: 2, Class: 
org.apache.zookeeper.server.quorum.RaceConditionTest
[junit] Running org.apache.zookeeper.server.quorum.ReconfigFailureCasesTest 
in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
6.786 sec, Thread: 6, Class: 
org.apache.zookeeper.server.quorum.ReconfigDuringLeaderSyncTest
[junit] Running org.apache.zookeeper.server.quorum.ReconfigLegacyTest in 
thread 6
[junit] Tests run: 46, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
51.392 sec, Thread: 1, Class: org.apache.zookeeper.RemoveWatchesTest
[junit] Running org.apache.zookeeper.server.quorum.ReconfigRecoveryTest in 
thread 1
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
23.198 sec, Thread: 7, Class: 
org.apache.zookeeper.server.quorum.ReconfigBackupTest
[junit] Running 
org.apache.zookeeper.server.quorum.ReconfigRollingRestartCompatibilityTest in 
thread 7
[junit] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
52.119 sec, Thread: 4, Class: 
org.apache.zookeeper.server.ZooKeeperServerMainTest
[junit] Running org.apache.zookeeper.server.quorum.RemotePeerBeanTest in 
thread 4
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.097 sec, Thread: 4, Class: 
org.apache.zookeeper.server.quorum.RemotePeerBeanTest
[junit] Running org.apache.zookeeper.server.quorum.StandaloneDisabledTest 
in thread 4
[junit] Tests run: 30, Failures: 16, Errors: 16, Skipped: 0, Time elapsed: 
36.94 sec, Thread: 3, Class: 
org.apache.zookeeper.server.quorum.QuorumRequestPipelineTest
[junit] Tests run: 6, Failures: 4, Errors: 1, Skipped: 0, Time elapsed: 
28.925 sec, Thread: 1, Class: 
org.apache.zookeeper.server.quorum.ReconfigRecoveryTest
[junit] Running org.apache.zookeeper.server.quorum.ReconfigRecoveryTest in 
thread 1
[junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 
sec, Thread: 1, Class: org.apache.zookeeper.server.quorum.ReconfigRecoveryTest
[junit] Test org.apache.zookeeper.server.quorum.ReconfigRecoveryTest FAILED 
(crashed)
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
43.549 sec, Thread: 6, Class: 
org.apache.zookeeper.server.quorum.ReconfigLegacyTest
[junit] Running org.apache.zookeeper.server.quorum.ReconfigLegacyTest in 
thread 6
[junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 
sec, Thread: 6, Class: org.apache.zookeeper.server.quorum.ReconfigLegacyTest
[junit] Test org.apache.zookeeper.server.quorum.ReconfigLegacyTest FAILED 
(crashed)
[junit] Tests run: 14, Failures: 6, Errors: 2, Skipped: 

Re: Discover LEADER from JMX

[Enrico Olivelli]

Il giorno mer 9 mag 2018 alle ore 20:24 Patrick Hunt  ha
scritto:

> iiuc what you are interested in the information is already available. The
> beans have a "state" attribute which indicates following vs leading.
>
> Try attaching a jconsole to the running servers, use the "mbeans" tab and
> open org.apache.ZooKeeperService -> replicatedserver -> replica ->
> attributes, you'll see the "state" attribute there.
>


Patrick,
I can't find this information.
If I log into a "follower" I get this info only for the 'current replica'

Example, I have three peers,  the first one is a "Follower", on JMX I have
o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - ClientAddress
o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - ElectionAddress
o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - LearnerType
o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - Name
o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - QuorumAddress
o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - State = following
o.a.ZookKeeperService - ReplicatedServer_id1 - replica_1 - ConfigVersion
.



for other peers I see only
o.a.ZookKeeperService - ReplicatedServer_id1 - replica_2 - ClientAddress
o.a.ZookKeeperService - ReplicatedServer_id1 - replica_2 - ElectionAddress
o.a.ZookKeeperService - ReplicatedServer_id1 - replica_2 - LearnerType
o.a.ZookKeeperService - ReplicatedServer_id1 - replica_2 - Name
o.a.ZookKeeperService - ReplicatedServer_id1 - replica_2 - QuorumAddress

o.a.ZookKeeperService - ReplicatedServer_id1 - replica_3 - ClientAddress
o.a.ZookKeeperService - ReplicatedServer_id1 - replica_3 - ElectionAddress
o.a.ZookKeeperService - ReplicatedServer_id1 - replica_3 - LearnerType
o.a.ZookKeeperService - ReplicatedServer_id1 - replica_3 - Name
o.a.ZookKeeperService - ReplicatedServer_id1 - replica_3 - QuorumAddress


so quering only this server I cannot guess which is the current leader, the
only information I can extract is:
- I am a follower
- We are a cluster of three
- Every of the three is a PARTECIPANT (no observers)

in order to guess which is the leader I have to ask to all of the three
nodes in the cluster

Am I missing something ? I am running 3.5.3-BETA

Enrico













>
> Patrick
>
> On Wed, May 9, 2018 at 8:02 AM, Enrico Olivelli 
> wrote:
>
> > Thank you Edward
> >
> > I will pack all together and send out a patch as soon as I have time.
> > I am running 3.5 in production and given than an RC for 3.5.4 is going to
> > be cut soon I will have to wait for 3.5.5 and I assume it won't be
> > immediate.
> >
> > Cheers
> > Enrico
> >
> > Il giorno mer 9 mag 2018 alle ore 14:37 Edward Ribeiro <
> > edward.ribe...@gmail.com> ha scritto:
> >
> > > Sent before finishing the previous email. Only to complement, the
> > > findLeader() could have been as below, but this change is only a nitty
> > > detail and totally irrelevant to the questions you are asking. :)
> > >
> > > /**
> > >  * Returns the address of the node we think is the leader.
> > >  */
> > > protected QuorumServer findLeader() {
> > >
> > > // Find the leader by id
> > > long currentLeader = self.getCurrentVote().getId();
> > >
> > > QuorumServer leaderServer = self.getView().get(currentLeader);
> > >
> > > if (leaderServer == null) {
> > > LOG.warn("Couldn't find the leader with id = {}",
> currentLeader);
> > > }
> > > return leaderServer;
> > > }
> > >
> > > Edward
> > >
> > > On Wed, May 9, 2018 at 9:29 AM, Edward Ribeiro <
> edward.ribe...@gmail.com
> > >
> > > wrote:
> > >
> > > > Hi Enrico,
> > > >
> > > > Well, I am not an expert on QuorumPeer either (not an expert on
> > anything,
> > > > really), but maybe it's the variable and method below?
> > > >
> > > > - QuorumPeer --
> > > >
> > > > /**
> > > >  * This is who I think the leader currently is.
> > > >  */
> > > > volatile private Vote currentVote;
> > > >
> > > > public synchronized Vote getCurrentVote(){
> > > > return currentVote;
> > > > }
> > > >
> > > > ---
> > > >
> > > >
> > > > Then it's a matter of calling quorumPeer.getCurrentVote().getId() and
> > > > quorumPeer.getServerState()?
> > > >
> > > > Btw, the Learner class has this handy method below (self is a
> > > QuorumPeer):
> > > >
> > > >  Learner 
> > > >
> > > > /**
> > > >  * Returns the address of the node we think is the leader.
> > > >  */
> > > > protected QuorumServer findLeader() {
> > > > QuorumServer leaderServer = null;
> > > > // Find the leader by id
> > > > Vote current = self.getCurrentVote();
> > > > for (QuorumServer s : self.getView().values()) {
> > > > if (s.id == current.getId()) {
> > > > leaderServer = s;
> > > > break;
> > > > }
> > > > }
> > > > if (leaderServer == null) {
> > > > LOG.warn("Couldn't find the leader 

ZooKeeper_branch34_openjdk7 - Build # 1912 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1912/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 40.21 KB...]
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedServerTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.678 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.435 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.575 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.687 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.578 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.098 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.791 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.103 sec
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.908 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.889 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.924 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.344 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.733 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
9.665 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.573 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.108 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.57 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
29.412 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
15.968 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.739 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/build.xml:1382:
 The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_openjdk7/build.xml:1385:
 Tests failed!

Total time: 39 minutes 56 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Recording test results
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/
Setting OPENJDK_7_ON_UBUNTU_ONLY__HOME=/usr/lib/jvm/java-7-openjdk-amd64/



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss

Error Message:
expected:<1> but was:<2>

Stack Trace:
junit.framework.AssertionFailedError: expected:<1> but was:<2>
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss(QuorumPeerMainTest.java:1202)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)

Success: ZOOKEEPER- PreCommit Build #1671

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1671/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 85.40 MB...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 12 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1671//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1671//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1671//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16470163 added to ZOOKEEPER-3019.
 [exec] Session logged out. Session was 
JSESSIONID=6C0F9B585325F252806D6079B060867A.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 17 minutes 48 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3019
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470163#comment-16470163
 ] 

Hadoop QA commented on ZOOKEEPER-3019:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 12 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1671//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1671//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1671//console

This message is automatically generated.

> Add a metric to track number of slow fsyncs
> ---
>
> Key: ZOOKEEPER-3019
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: jmx, server
>Affects Versions: 3.5.3, 3.4.11, 3.6.0
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Major
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow 
> fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceeds 
> fsyncWarningThresholdMS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ZOOKEEPER-3037) Add JvmPauseMonitor to ZooKeeper

[Norbert Kalmar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norbert Kalmar updated ZOOKEEPER-3037:
--
Description: 
After a ZK crash, or client timeout sometimes it's hard to determine from the 
logs what happened. Knowing if ZK was responsive at the time would help a lot. 
For example, ZK might spend a lot of time waiting on GC (there is still some 
misconception that ZK is a storage). 

To help detect this, HADOOP already has a great tool called JVM Pause Monitor. 
(As the name suggest, it can be also used for monitoring, but it also helps 
post-mortem in a lot of cases). Basically it has a daemon that sleeps for one 
second, and if the sleep time exceeds the 1s by more than the threshold (1s: 
INFO, 10s: WARN by default - this can be configurable in our case, see below), 
it will alert/make a log entry. It can also monitor the time GC took.

The class implementing this is in HADOOP-common, but ZK should not depend on 
this package. Since this is a straightforward implementation, and in the past 
five years the few commits it had is nothing really serious, I think we could 
just copy this class in ZooKeeper, and introduce it as a configurable feature, 
by default it can be off.

The class:
https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java

Task:
- Create a class in ZK under contrib called JvmPauseMonitor. 
- Make feature configurable, by default: OFF
- Make sleep time and threshold time configurable
- Update documentation
- Add [current size of the heap OR % of heap used] in the log entry whenever 
sleep threshold had exceeded by a lot (10s)

  was:
After a ZK crash, or client timeout sometimes it's hard to determine from the 
logs what happened. Knowing if ZK was responsive at the time would help a lot. 
For example, ZK might spend a lot of time waiting on GC (there is still some 
misconception that ZK is a storage). 

To help detect this, HADOOP already has a great tool called JVM Pause Monitor. 
(As the name suggest, it can be also used for monitoring, but it also helps 
post-mortem in a lot of cases). Basically it has a daemon that sleeps for one 
second, and if the sleep time exceeds the 1s by more than the threshold (1s: 
INFO, 10s: WARN by default - this can be configurable in our case, see below), 
it will alert/make a log entry. It can also monitor the time GC took.

The class implementing this is in HADOOP-common, but ZK should not depend on 
this package. Since this is a straightforward implementation, and in the past 
five years the few commits it had is nothing really serious, I think we could 
just copy this class in ZooKeeper, and introduce it as a configurable feature, 
by default it can be off.

The class:
https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java

Task:
- Create a class in ZK under contrib called JvmPauseMonitor. 
- Make feature configurable, by default: OFF
- Make sleep time and threshold time configurable


> Add JvmPauseMonitor to ZooKeeper
> 
>
> Key: ZOOKEEPER-3037
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3037
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: contrib
>Affects Versions: 3.5.3, 3.4.12
>Reporter: Norbert Kalmar
>Assignee: Norbert Kalmar
>Priority: Minor
>
> After a ZK crash, or client timeout sometimes it's hard to determine from the 
> logs what happened. Knowing if ZK was responsive at the time would help a 
> lot. For example, ZK might spend a lot of time waiting on GC (there is still 
> some misconception that ZK is a storage). 
> To help detect this, HADOOP already has a great tool called JVM Pause 
> Monitor. (As the name suggest, it can be also used for monitoring, but it 
> also helps post-mortem in a lot of cases). Basically it has a daemon that 
> sleeps for one second, and if the sleep time exceeds the 1s by more than the 
> threshold (1s: INFO, 10s: WARN by default - this can be configurable in our 
> case, see below), it will alert/make a log entry. It can also monitor the 
> time GC took.
> The class implementing this is in HADOOP-common, but ZK should not depend on 
> this package. Since this is a straightforward implementation, and in the past 
> five years the few commits it had is nothing really serious, I think we could 
> just copy this class in ZooKeeper, and introduce it as a configurable 
> feature, by default it can be off.
> The class:
> https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
> Task:
> - Create a class in ZK under contrib called JvmPauseMonitor. 
> - Make feature configurable, by default: OFF
> - 

Re: [SUGGESTION] JvmPauseMonitor in ZooKeeper

[Norbert Kalmar]

I added the suggestions to the jira.

Thanks all!

On Thu, May 10, 2018 at 3:34 AM Prasanth Mathialagan <
prasanthmathiala...@gmail.com> wrote:

> Hi,
> This looks cool :) I have a suggestion. It would be nice if we could add
> the current size of the heap or (% of heap used) in the log entry whenever
> sleep threshold had exceeded a lot. It could be helpful.
>
> On Wed, May 9, 2018 at 11:26 AM, Patrick Hunt  wrote:
>
> > On Wed, May 9, 2018 at 11:11 AM, Norbert Kalmar 
> > wrote:
> >
> > > Thanks Patrick, great question.
> > > My understanding is that this tool not only shows if JVM spends too
> much
> > > time in GC, but if, for any other reason, there is a JVM pause (The
> tool
> > > only differentiates GC pause from all other pause). This could be slow
> > > fsync (although we do have logs for that) or even server/OS related.
> > >
> > > But again, this is just my interpretation. I will ask the source of the
> > > idea, what extra benefits this gives them over java GC log.
> > >
> > > I checked ZK, I don't see it enabled by default, but GC logging can be
> > set
> > > with JVM parameters easily, so that shouldn't be a key factor anyway.
> > >
> > >
> > I think that would be a useful change regardless - to make it on by
> default
> > I mean. Also some docs wrt our recommendations, how to troubleshoot,
> etc...
> > Adding a feature is useful, but ensuring people know about it and can
> use
> > it effectively is even more so.
> >
> > Regards,
> >
> > Patrick
> >
> >
> > > Regards,
> > > Norbert
> > >
> > > On Wed, May 9, 2018 at 7:57 PM Patrick Hunt  wrote:
> > >
> > > > Do you know why they did this rather than just enabling GC logging by
> > > > default? Why re-invent the wheel?
> > > >
> > > > I seem to remember seeing a push do enable GC logging by default a
> few
> > > > years ago. In particular around the time when the JVM added GC log
> > > rolling
> > > > as a feature. Here's an example:
> > > >
> > > > https://batmat.net/2016/10/17/always-enable-gc-logs-and-how-
> > > to-enable-logs-rotation-with-hotspot/
> > > > My understanding is that the overhead is so low that it's feasible to
> > do
> > > > this.
> > > >
> > > > Good improvement though regardless which way we go.
> > > >
> > > > Regards,
> > > >
> > > > Patrick
> > > >
> > > > On Wed, May 9, 2018 at 9:36 AM, Andor Molnar 
> > wrote:
> > > >
> > > > > +1 cool!
> > > > >
> > > > >
> > > > > On Wed, May 9, 2018 at 7:59 AM, Norbert Kalmar <
> nkal...@cloudera.com
> > >
> > > > > wrote:
> > > > >
> > > > > > Okay, thanks Ed, I created the Jira, will look into it soon :)
> > > > > > https://issues.apache.org/jira/browse/ZOOKEEPER-3037
> > > > > >
> > > > > > Regards,
> > > > > > Norbert
> > > > > >
> > > > > > On Wed, May 9, 2018 at 4:44 PM Edward Ribeiro <
> > > > edward.ribe...@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > +1. Sounds really nice to have feature. Let's open a ticket and
> > > open
> > > > a
> > > > > > PR.
> > > > > > > :)
> > > > > > >
> > > > > > > Ed
> > > > > > >
> > > > > > > Em qua, 9 de mai de 2018 11:15, Norbert Kalmar <
> > > nkal...@cloudera.com
> > > > >
> > > > > > > escreveu:
> > > > > > >
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > I just got a tip that we could improve on the logging in
> > > ZooKeeper.
> > > > > > > After a
> > > > > > > > ZK crash, or client timeout sometimes it's hard to determine
> > from
> > > > the
> > > > > > > logs
> > > > > > > > what happened. Knowing if ZK was responsive at the time would
> > > help
> > > > a
> > > > > > lot.
> > > > > > > > For example, ZK might spend a lot of time waiting on GC
> (there
> > is
> > > > > still
> > > > > > > > some misconception that ZK is a storage).
> > > > > > > >
> > > > > > > > To help detect this, HADOOP already has a great tool called
> JVM
> > > > Pause
> > > > > > > > Monitor. (As the name suggest, it can be also used for
> > > monitoring,
> > > > > but
> > > > > > it
> > > > > > > > also helps post-mortem in a lot of cases). Basically it has a
> > > > daemon
> > > > > > that
> > > > > > > > sleeps for one second, and if the sleep time exceeds the 1s
> by
> > > more
> > > > > > than
> > > > > > > > the threshold (1s: INFO, 10s: WARN by default - this can be
> > > > > > configurable
> > > > > > > in
> > > > > > > > our case, see below), it will alert/make a log entry. It can
> > also
> > > > > > monitor
> > > > > > > > the time GC took.
> > > > > > > >
> > > > > > > > Now, this class is in the HADOOP-common. I wouldn't want to
> > > depend
> > > > on
> > > > > > > > Hadoop-common because of this one feature/class (it is
> > actually a
> > > > > > single
> > > > > > > > class). Since this is a straightforward implementation, and
> in
> > > the
> > > > > past
> > > > > > > > five years the few commits it had is nothing really serious,
> I
> > > > think
> > > > > we
> > > > > > > > could just copy this class in ZooKeeper, and introduce it as
> a
> > > > 

[jira] [Commented] (ZOOKEEPER-3038) Cleanup some nitpicks in TTL implementation

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469974#comment-16469974
 ] 

Hudson commented on ZOOKEEPER-3038:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #18 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/18/])
ZOOKEEPER-3038: Cleanup some nitpicks in TTL implementation (phunt: rev 
6e64125f2aafc29253904c43ee44233c907e5fca)
* (add) src/java/main/org/apache/zookeeper/server/EphemeralTypeEmulate353.java
* (edit) src/java/main/org/apache/zookeeper/server/EphemeralType.java
* (edit) src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
* (delete) src/java/main/org/apache/zookeeper/server/OldEphemeralType.java
* (edit) src/java/test/org/apache/zookeeper/server/Emulate353TTLTest.java


> Cleanup some nitpicks in TTL implementation
> ---
>
> Key: ZOOKEEPER-3038
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3038
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.3
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> A few nitpicks which needs to be cleaned up:
> 1. Rename OldEphemeralType --> EphemeralTypeEmulate353
>  2. Remove unused method: getTTL()
> 3. Remove unused import from QuorumPeer
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2959) ignore accepted epoch and LEADERINFO ack from observers when a newly elected leader computes new epoch

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469973#comment-16469973
 ] 

Hudson commented on ZOOKEEPER-2959:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #18 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/18/])
ZOOKEEPER-2959: ignore accepted epoch and LEADERINFO ack from observers 
(ashraer: rev 088dfdf188663f6bad79b0e87b710737b318537d)
* (edit) src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java
* (edit) src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java
* (edit) src/java/main/org/apache/zookeeper/server/quorum/Leader.java
* (add) src/java/test/org/apache/zookeeper/server/quorum/ZabUtils.java
* (add) 
src/java/test/org/apache/zookeeper/server/quorum/LeaderWithObserverTest.java


> ignore accepted epoch and LEADERINFO ack from observers when a newly elected 
> leader computes new epoch
> --
>
> Key: ZOOKEEPER-2959
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2959
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.10, 3.5.3
>Reporter: xiangyq000
>Assignee: Bogdan Kanivets
>Priority: Blocker
> Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> Once the ZooKeeper cluster finishes the election for new leader, all learners 
> report their accepted epoch to the leader for the computation of new cluster 
> epoch.
> org.apache.zookeeper.server.quorum.Leader#getEpochToPropose
> {code:java}
> private final HashSet connectingFollowers = new HashSet();
> public long getEpochToPropose(long sid, long lastAcceptedEpoch) throws 
> InterruptedException, IOException {
> synchronized(connectingFollowers) {
> if (!waitingForNewEpoch) {
> return epoch;
> }
> if (lastAcceptedEpoch >= epoch) {
> epoch = lastAcceptedEpoch+1;
> }
> connectingFollowers.add(sid);
> QuorumVerifier verifier = self.getQuorumVerifier();
> if (connectingFollowers.contains(self.getId()) &&
> 
> verifier.containsQuorum(connectingFollowers)) {
> waitingForNewEpoch = false;
> self.setAcceptedEpoch(epoch);
> connectingFollowers.notifyAll();
> } else {
> long start = Time.currentElapsedTime();
> long cur = start;
> long end = start + self.getInitLimit()*self.getTickTime();
> while(waitingForNewEpoch && cur < end) {
> connectingFollowers.wait(end - cur);
> cur = Time.currentElapsedTime();
> }
> if (waitingForNewEpoch) {
> throw new InterruptedException("Timeout while waiting for 
> epoch from quorum");
> }
> }
> return epoch;
> }
> }
> {code}
> The computation will get an outcome once :
> # The leader has call method "getEpochToPropose"
> # The number of all reporters is greater than half of participants.
> The problem is, an observer server will also send its accepted epoch to the 
> leader, while this procedure treat observers as participants.
> Supposed that the cluster consists of 1 leader, 2 followers and 1 observer, 
> and now the leader and the observer have reported their accepted epochs while 
> neither of the followers has. Thus, the connectingFollowers set consists of 
> two elements, resulting in a size of 2, which is greater than half quorum, 
> namely, 2. Then QuorumVerifier#containsQuorum will return true, because it 
> does not check whether the elements of the parameter are participants.
> The same flaw exists in 
> org.apache.zookeeper.server.quorum.Leader#waitForEpochAck



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper-trunk - Build # 18 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/18/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 140.86 KB...]
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.466 sec, Thread: 2, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 5
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 2
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.731 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTimeoutTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
2
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.119 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 2
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
13.047 sec, Thread: 5, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 5
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.766 sec, Thread: 5, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
133.314 sec, Thread: 7, Class: org.apache.zookeeper.test.RecoveryTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 5
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 7
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.355 sec, Thread: 5, Class: org.apache.zookeeper.test.StatTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.242 sec, Thread: 7, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 7
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 5
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.071 sec, Thread: 7, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 7
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.753 sec, Thread: 5, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 5
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
18.773 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 2
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.11 sec, Thread: 2, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 2
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
4.624 sec, Thread: 2, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
102.803 sec, Thread: 4, Class: org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 4
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.094 sec, Thread: 4, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 4
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
20.19 sec, Thread: 7, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 7
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.138 sec, Thread: 7, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
22.214 sec, Thread: 5, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
20.807 sec, Thread: 4, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
33.873 sec, Thread: 2, Class: org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
280.887 sec, Thread: 6, Class: org.apache.zookeeper.test.ReconfigTest
[junit] Tests run: 104, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
564.093 sec, Thread: 1, Class: org.apache.zookeeper.test.NettyNettySuiteTest
[junit] Tests run: 104, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
560.713 sec, Thread: 8, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit]