[jira] [Commented] (ZOOKEEPER-3123) MetricsProvider Lifecycle in ZooKeeper Server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599613#comment-16599613 ] Hadoop QA commented on ZOOKEEPER-3123: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2112//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2112//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2112//console This message is automatically generated. > MetricsProvider Lifecycle in ZooKeeper Server > - > > Key: ZOOKEEPER-3123 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3123 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Affects Versions: 3.6.0 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 4.5h > Remaining Estimate: 0h > > This subtask is for the licefycle code of the configured MetricsProvider > inside ZooKeeper server, both standalone mode and quorum peer mode. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3136) Reduce log in ClientBase in case of ConnectException
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599609#comment-16599609
]
Hadoop QA commented on ZOOKEEPER-3136:
--
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2111//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2111//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2111//console
This message is automatically generated.
> Reduce log in ClientBase in case of ConnectException
>
>
> Key: ZOOKEEPER-3136
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3136
> Project: ZooKeeper
> Issue Type: Task
> Components: tests
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> While running tests you will always see spammy log lines like the ones below.
> As we are expecting the server to be up, it is not useful to log such
> stacktraces.
> The patch simply reduce the log in this specific case, because it adds no
> value and it is very annoying.
>
> {code:java}
> [junit] 2018-08-31 23:31:49,173 [myid:] - INFO [main:ClientBase@292] -
> server 127.0.0.1:11222 not up
> [junit] java.net.ConnectException: Connection refused (Connection refused)
> [junit] at java.net.PlainSocketImpl.socketConnect(Native Method)
> [junit] at
> java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
> [junit] at
> java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
> [junit] at
> java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
> [junit] at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
> [junit] at java.net.Socket.connect(Socket.java:589)
> [junit] at
> org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord(FourLetterWordMain.java:101)
> [junit] at
> org.apache.zookeeper.client.FourLetterWordMain.send4LetterWord(FourLetterWordMain.java:71)
> [junit] at
> org.apache.zookeeper.test.ClientBase.waitForServerUp(ClientBase.java:285)
> [junit] at
> org.apache.zookeeper.test.ClientBase.waitForServerUp(ClientBase.java:276)
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] zookeeper issue #601: ZOOKEEPER-3123 MetricsProvider Lifecycle in ZooKeeper ...
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/601 Seems there is an error on CI related to the patch. ---
[GitHub] zookeeper issue #614: ZOOKEEPER-3136 Reduce log in ClientBase in case of Con...
Github user eolivelli commented on the issue: https://github.com/apache/zookeeper/pull/614 @maoling I have addressed your comment ---
[GitHub] zookeeper pull request #593: [ZOOKEEPER-3111] Add socket buffer size option ...
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/593#discussion_r214507592
--- Diff: src/java/test/org/apache/zookeeper/server/SocketUtilTest.java ---
@@ -37,7 +37,7 @@ public void testSetSocketBufferSize() throws Exception {
Assert.assertEquals(initReceiveBufferSize,
s.getReceiveBufferSize());
// set NETWORK_BUFFER_SIZE
-int networkBufferSize = 1024 * 1024;
+int networkBufferSize = 32 * 1024;
SocketUtil.setNetworkBufferSize(networkBufferSize);
SocketUtil.setSocketBufferSize("test", s);
--- End diff --
Although it passed the test,but When do regression,it will also be a
flaky(you can see it by hitting it again and again).
could you plz look at it?
---
[GitHub] zookeeper pull request #593: [ZOOKEEPER-3111] Add socket buffer size option ...
Github user maoling commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/593#discussion_r214507553 --- Diff: src/java/main/org/apache/zookeeper/server/SocketUtil.java --- @@ -13,18 +31,18 @@ --- End diff -- some useless import? ---
[GitHub] zookeeper pull request #614: ZOOKEEPER-3136 Reduce log in ClientBase in case...
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/614#discussion_r214507696
--- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java ---
@@ -287,6 +288,9 @@ public static boolean waitForServerUp(String hp, long
timeout, boolean secure) {
!result.contains("READ-ONLY")) {
return true;
}
+} catch (ConnectException e) {
+// ignore as this is expected, do not log stacktrace
+LOG.info("server {} not up", hp);
} catch (IOException e) {
--- End diff --
Good idea, I will log e.toString(), this will provide class name as well
---
[GitHub] zookeeper pull request #614: ZOOKEEPER-3136 Reduce log in ClientBase in case...
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/614#discussion_r214506993
--- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java ---
@@ -287,6 +288,9 @@ public static boolean waitForServerUp(String hp, long
timeout, boolean secure) {
!result.contains("READ-ONLY")) {
return true;
}
+} catch (ConnectException e) {
+// ignore as this is expected, do not log stacktrace
+LOG.info("server {} not up", hp);
} catch (IOException e) {
--- End diff --
If printing the stacktraces is not very useful and annoying, Adding
`e.getMessage()` just to tell us what type of exception has happened is better?
---
