[GitHub] [zookeeper] eolivelli commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …

2019-05-12 Thread GitBox
eolivelli commented on issue #944: ZOOKEEPER-3388: Allow client port to support 
plaintext and encrypted …
URL: https://github.com/apache/zookeeper/pull/944#issuecomment-491698533
 
 
   Oh I am sorry I did not notice that in ZK we don't have  
netty-tcnative-boringssl yet.
   Are you using it in your fork or are you using the openssl libs provided by 
the SO?
   
   I am really fine to use boring-ssl static libs, this way we are sure about 
which version of the ssl lib ZK (client and server) is using
   
   The upgrade of netty-all is okay.
   
   I will finish the review of the patch as soon as possible



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] eolivelli commented on issue #940: ZOOKEEPER-3386: Add admin command to display voting view

2019-05-12 Thread GitBox
eolivelli commented on issue #940: ZOOKEEPER-3386: Add admin command to display 
voting view
URL: https://github.com/apache/zookeeper/pull/940#issuecomment-491696727
 
 
   @enixon sorry I was not clear.
   I am not taking about jmx (I also think it ia going to disappear some day)
   
   I am saying that we are going to serialize to json some internal data 
structure which be changed in the future and consumers of the API won't be able 
to understand the response.
   The final result also depends on the JSON marshaller, this may change in the 
future and we could break this new API without notice.
   
   Honestly I don't know how much the admin endpoint is to be considered an API.
   
   We should state it somewhere in docs.
   
   Anyway my proposal is to create a specific java class which modes the 
response (mostly a wrapper around the voting view), this way any refactor to 
the internals will show up in the admin endpoint code and we will see that we 
are changing the response we are serving to monitoring tools


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] enixon commented on issue #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …

2019-05-12 Thread GitBox
enixon commented on issue #944: ZOOKEEPER-3388: Allow client port to support 
plaintext and encrypted …
URL: https://github.com/apache/zookeeper/pull/944#issuecomment-491673561
 
 
   I've added netty-tcnative-boringssl to the maven/ant settings as suggested 
though I will admit that I'm not sure if what I've done is correct. Happy to 
leave it in or remove it depending on what's appropriate.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] enixon commented on a change in pull request #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …

2019-05-12 Thread GitBox
enixon commented on a change in pull request #944: ZOOKEEPER-3388: Allow client 
port to support plaintext and encrypted …
URL: https://github.com/apache/zookeeper/pull/944#discussion_r283152504
 
 

 ##
 File path: build.xml
 ##
 @@ -37,7 +37,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
 
 
 
-
+
 
 Review comment:
   Good catch! I'll fix up the pom.xml and see about bumping it to the latest 
netty: 4.1.36.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] enixon commented on a change in pull request #940: ZOOKEEPER-3386: Add admin command to display voting view

2019-05-12 Thread GitBox
enixon commented on a change in pull request #940: ZOOKEEPER-3386: Add admin 
command to display voting view
URL: https://github.com/apache/zookeeper/pull/940#discussion_r283152223
 
 

 ##
 File path: 
zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java
 ##
 @@ -573,5 +574,27 @@ public CommandResponse run(ZooKeeperServer zkServer, 
Map kwargs)
 }
 }
 
+/**
+ * Returns the current ensemble configuration information.
+ * It provides list of current voting members in the ensemble.
+ */
+public static class VotingViewCommand extends CommandBase {
+public VotingViewCommand() {
+super(Arrays.asList("voting_view"));
+}
+
+@Override
+public CommandResponse run(ZooKeeperServer zkServer, Map kwargs) {
+CommandResponse response = initializeResponse();
+if (zkServer instanceof QuorumZooKeeperServer) {
+QuorumPeer peer = ((QuorumZooKeeperServer) zkServer).self;
+response.put("current_config", peer.getVotingView());
 
 Review comment:
   That's a legitimate question and I don't know if I have the certain answer.
   
   My thoughts are that jmx is clearly awesome at two things:
   1. exposing internal feature flags and settings for review and alteration and
   2. the execution of commands that require parameters.
   
   The admin command is clearly awesome at one thing:
   1. presenting complicated diagnostic information.
   
   This feature easily falls into the second category (jmx is certainly not 
going to alter the voting view). I don't know enough about the history of the 
admin command to know if the division I outline above is the same as the one 
seen by the community. 
   
   The other thing on my mind is that some users of ZooKeeper will opt out of 
jmx entirely because of the security concerns about the library. It would be 
generous to not shut them and their managing frameworks out of certain auditing 
information.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Github & Jira notifications

2019-05-12 Thread Lars Francke
re: existing users
I'd expect they read this mailing list, and if they do they should see the
announcement that things change and need to re-subscribe, if they don't
follow the list anyway then...well nothing really lost.
I understand the concern but I'm afraid there's nothing we can do there. I
don't think it's trivial to automatically subscribe people to a new list,
we'd need to ask INFRA if it's even possible.

re: new users: Yes, as a new subscriber it's definitely VERY overwhelming
(especially the gitbox mails) and it's also nowadays almost unexpected
because most other projects (at least the ones I follow) have the
separation of mailing lists already

On Sun, May 12, 2019 at 6:28 PM Norbert Kalmar 
wrote:

> I agree we have a lot of "noise", as others, I have created the filters and
> since forgot about them.
> But it is overwhelming for a new subscriber, and filters always carry the
> dangers of false positive filtering. i.e. filter out someone's email.
> I think someone joining the dev-zookeeper mailing list is always a good
> thing, and we shouldn't scare them away :)
> For the existing users, I guess they would have to sign up for the new
> list.
>
> It would be nice, but I'm not even sure of all the dependent stuff (Patrick
> just mentioned marmail for example).
>
> Regards,
> Norbert
>
> On Sun, May 12, 2019 at 10:06 AM Lars Francke 
> wrote:
>
> > Sorry, I didn't mean to comment on the tracking sites in the VOTE thread.
> > That belongs here.
> >
> > Either way: Markmail etc. shouldn't be broken. Yes, they may take a while
> > before they index stuff but the "canonical" tracking site is
> > https://lists.apache.org and that indexes new stuff automatically
> anwyay.
> >
> > On Sun, May 12, 2019 at 9:55 AM Lars Francke 
> > wrote:
> >
> > > I'm subscribed to around 40-60 Apache Mailing lists. If the
> notifications
> > > were in a separate list I could just subscribe to what I want instead
> of
> > > creating 80 or so filters.
> > >
> > > I think I disagree, I don't have to create filters if the dev list only
> > > contains "discussions".
> > >
> > > Cheers,
> > > Lars
> > >
> > > On Sun, May 12, 2019 at 12:38 AM Patrick Hunt 
> wrote:
> > >
> > >> You're going to have to have a filter regardless. Why change now?
> Also,
> > if
> > >> you do change it, be sure to update all of the tracking sites such as
> > >> markmail (etc...), I find this invaluable.
> > >>
> > >> Regards,
> > >>
> > >> Patrick
> > >>
> > >> On Fri, May 10, 2019 at 1:18 AM Lars Francke 
> > >> wrote:
> > >>
> > >> > INFRA can do it all :)
> > >> >
> > >> > See for example this:
> > >> >  for Jira
> > >> >  for Github
> > >> >
> > >> > The necessary mailing lists can be created here <
> > >> > https://selfserve.apache.org/>
> > >> >
> > >> > I'd be happy to file the issues myself but it's better if it comes
> > from
> > >> a
> > >> > PMC member.
> > >> >
> > >> > Cheers,
> > >> > Lars
> > >> >
> > >> > On Fri, May 10, 2019 at 10:00 AM Andor Molnar
> > >> 
> > >> > wrote:
> > >> >
> > >> > > Hi Lars,
> > >> > >
> > >> > > Thank you for the hands, yes, indeed we are interested!
> > >> > > Currently I'm using all kind of magic filters to separate signal
> > from
> > >> > > noise.
> > >> > >
> > >> > > What do we need to do?
> > >> > >
> > >> > > Regards,
> > >> > > Andor
> > >> > >
> > >> > >
> > >> > >
> > >> > > On Fri, May 10, 2019 at 9:51 AM Lars Francke <
> > lars.fran...@gmail.com>
> > >> > > wrote:
> > >> > >
> > >> > > > Hi,
> > >> > > >
> > >> > > > I've recently subscribed to the dev mailinglist but am
> overwhelmed
> > >> by
> > >> > the
> > >> > > > number of github notifications and about to unsubscribe again.
> > >> > > >
> > >> > > > But maybe you're interested in moving the github & jira
> > >> notifications
> > >> > to
> > >> > > a
> > >> > > > different mailing list? I did a quick search for on the mailing
> > list
> > >> > > > archives but couldn't find another thread about it.
> > >> > > >
> > >> > > > The way we've done it at the Apache Training project now for
> > >> example is
> > >> > > to
> > >> > > > send all Github notifications to notifications@ and all Jira
> > >> messages
> > >> > to
> > >> > > > issues@ we only send Jira open and close mails to dev@
> > >> > > >
> > >> > > > This lowers the volume significantly and works just fine.
> > >> > > >
> > >> > > > Is this something you'd be interested in?
> > >> > > >
> > >> > > > Cheers,
> > >> > > > Lars
> > >> > > >
> > >> > >
> > >> >
> > >>
> > >
> >
>


Re: [VOTE] Separate mailing lists for Jira and Github/Gitbox notifications

2019-05-12 Thread Andor Molnár
Vote cancelled, because the discussion is still ongoing.

Please follow-up on the other thread.


Andor



On 5/12/19 18:10, Patrick Hunt wrote:
> For some reason the vote was started at the very same time as the discuss.
> Andor can you cancel this vote thread until the discussion happens? We
> typically allow 3+ days until consensus is reached on the discussion thread
> plus some buffer for things to settle before starting a vote.
>
> Patrick
>
> On Sun, May 12, 2019 at 9:06 AM Patrick Hunt  wrote:
>
>> How do they learn about new MLs? For example a new ZK specific ML, how
>> does that get added to the markmail tracker?
>>
>> Regards,
>>
>> Patrick
>>
>> On Sun, May 12, 2019 at 1:04 AM Lars Francke 
>> wrote:
>>
>>> Why does it break tracking sites? They index the ASF stuff automatically
>>> as
>>> far as I know.
>>>
>>> On Sun, May 12, 2019 at 12:40 AM Patrick Hunt  wrote:
>>>
 -1 - I don't see the benefit. EOD it's a filter. Why change now?

 Also it will break all the tracking sites such as markmail, which I find
 invaluable when providing feedback to people or trying to look something
 up.

 Patrick


 On Fri, May 10, 2019 at 7:38 AM Lars Francke 
 wrote:

> +1 non-binding.
>
> Thank you!
>
> On Fri, May 10, 2019, 12:48 Enrico Olivelli 
>>> wrote:
>> +1 (non binding)
>>
>> Enrico
>>
>> Il giorno ven 10 mag 2019 alle ore 12:41 Andor Molnar <
 an...@apache.org>
>> ha
>> scritto:
>>
>>> Hi dev team,
>>>
>>> Based on Lars' suggestions I propose the following email
>>> notification
>>> scheme for ZooKeeper:
>>> (same as HBase setup)
>>>
>>> Jira
>>> 
>>> Issue created -> dev@zookeeper.apache.org + issues@
>>> Everything else -> iss...@zookeeper.apache.org
>>>
>>> Github/Gitbox
>>> --
>>> All notifications sent to notificati...@zookeeper.apache.org
>>>
>>> issues@ and notifications@ mailing lists have to be created
>>> first.
>>> Please vote on the suggestion.
>>>
>>> Andor
>>>


[GitHub] [zookeeper] anmolnar commented on issue #843: ZOOKEEPER-3296: Explicitly closing the sslsocket when it failed handshake to prevent issue where peers cannot join quorum

2019-05-12 Thread GitBox
anmolnar commented on issue #843: ZOOKEEPER-3296: Explicitly closing the 
sslsocket when it failed handshake to prevent issue where peers cannot join 
quorum
URL: https://github.com/apache/zookeeper/pull/843#issuecomment-491621513
 
 
   @lvfangmin Thanks. I prefer to keep it at package level. The more strict, 
the better.
   Hope it won't make too much mess on the testing side.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] eolivelli commented on a change in pull request #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …

2019-05-12 Thread GitBox
eolivelli commented on a change in pull request #944: ZOOKEEPER-3388: Allow 
client port to support plaintext and encrypted …
URL: https://github.com/apache/zookeeper/pull/944#discussion_r283149522
 
 

 ##
 File path: build.xml
 ##
 @@ -37,7 +37,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
 
 
 
-
+
 
 Review comment:
   Please update Maven pom as well.
   
   What about moving to latest netty?
   I guess we should update boring ssl dependency as well


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] enixon opened a new pull request #944: ZOOKEEPER-3388: Allow client port to support plaintext and encrypted …

2019-05-12 Thread GitBox
enixon opened a new pull request #944: ZOOKEEPER-3388: Allow client port to 
support plaintext and encrypted …
URL: https://github.com/apache/zookeeper/pull/944
 
 
   …connections simultaneously


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (ZOOKEEPER-3388) Allow client port to support plaintext and encrypted connections simultaneously

2019-05-12 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-3388:
--
Labels: pull-request-available  (was: )

> Allow client port to support plaintext and encrypted connections 
> simultaneously
> ---
>
> Key: ZOOKEEPER-3388
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3388
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Priority: Minor
>  Labels: pull-request-available
>
> ZOOKEEPER-2125 extended the ZooKeeper server-side to handle encrypted client 
> connections by allowing the server to open a second client port (the secure 
> client port) to manage this new style of traffic. A server is able to handle 
> plaintext and encrypted clients simultaneously by managing each on their 
> respective ports. 
> When it comes time to get all clients connecting to your system to start 
> using encryption, this approach requires that they make two changes 
> simultaneously: altering their client properties to start use the secure 
> settings and altering the routing information that they provide in order to 
> know where to connect with the ensemble. If either is misconfigured then the 
> client is cut off from the ensemble. With a large deployment of clients that 
> are owned by a different teams and different tools, this presents a danger in 
> activating the feature. Ideally, the two changes could be staggered so that 
> first the encryption feature is activated and then the routing information is 
> changed in a subsequent phase.
> Allow the server connection factory managing the regular client port to 
> handle both plaintext and encrypted connections. This will be independent of 
> the operation of the server connection factory managing the secure client 
> port but similar settings ought to apply to both (e.g. cipher suites) to 
> maintain inter compatibility.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZOOKEEPER-3388) Allow client port to support plaintext and encrypted connections simultaneously

2019-05-12 Thread Brian Nixon (JIRA)
Brian Nixon created ZOOKEEPER-3388:
--

 Summary: Allow client port to support plaintext and encrypted 
connections simultaneously
 Key: ZOOKEEPER-3388
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3388
 Project: ZooKeeper
  Issue Type: Improvement
  Components: server
Affects Versions: 3.6.0
Reporter: Brian Nixon


ZOOKEEPER-2125 extended the ZooKeeper server-side to handle encrypted client 
connections by allowing the server to open a second client port (the secure 
client port) to manage this new style of traffic. A server is able to handle 
plaintext and encrypted clients simultaneously by managing each on their 
respective ports. 

When it comes time to get all clients connecting to your system to start using 
encryption, this approach requires that they make two changes simultaneously: 
altering their client properties to start use the secure settings and altering 
the routing information that they provide in order to know where to connect 
with the ensemble. If either is misconfigured then the client is cut off from 
the ensemble. With a large deployment of clients that are owned by a different 
teams and different tools, this presents a danger in activating the feature. 
Ideally, the two changes could be staggered so that first the encryption 
feature is activated and then the routing information is changed in a 
subsequent phase.

Allow the server connection factory managing the regular client port to handle 
both plaintext and encrypted connections. This will be independent of the 
operation of the server connection factory managing the secure client port but 
similar settings ought to apply to both (e.g. cipher suites) to maintain inter 
compatibility.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [VOTE] Apache ZooKeeper release 3.5.5 candidate 6

2019-05-12 Thread sandeep shrids
Hi,

+1
Performed the following checks on my ubuntu box:
- digests match
- verified ZK server (used bin tgz) in standalone mode using the zkCli.
- verified ZK servers(used bin tgz) in a replicated mode(3 instances) using
zkCli. Brought down a ZK server and verified the behavior using zkCli
- local build works fine on the source (mvn clean install)

This time used Oracle jdk with java version "1.8.0_211"

Regards,
Sandeep



On Fri, May 3, 2019 at 6:04 PM Andor Molnar  wrote:

> This is the first stable release of 3.5 branch: 3.5.5. It resolves 117
> issues, including Maven migration, Quorum TLS, TTL nodes and lots of other
> performance and stability improvements.
>
> The full release notes is available at:
>
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12343268
>
> *** Please download, test and vote by May 10th 2019, 23:59 UTC+0. ***
>
> Source files:
> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.5.5-rc6/
>
> Maven staging repos:
>
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/parent/3.5.5/
>
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper-jute/3.5.5/
>
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.5.5/
>
> The release candidate tag in git to be voted upon: release-3.5.5-rc6
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> http://www.apache.org/dist/zookeeper/KEYS
>
> Should we release this candidate?
>
>


[GitHub] [zookeeper] noarter opened a new pull request #943: Merge pull request #1 from apache/master

2019-05-12 Thread GitBox
noarter opened a new pull request #943: Merge pull request #1 from apache/master
URL: https://github.com/apache/zookeeper/pull/943
 
 
   git pull


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Github & Jira notifications

2019-05-12 Thread Norbert Kalmar
I agree we have a lot of "noise", as others, I have created the filters and
since forgot about them.
But it is overwhelming for a new subscriber, and filters always carry the
dangers of false positive filtering. i.e. filter out someone's email.
I think someone joining the dev-zookeeper mailing list is always a good
thing, and we shouldn't scare them away :)
For the existing users, I guess they would have to sign up for the new list.

It would be nice, but I'm not even sure of all the dependent stuff (Patrick
just mentioned marmail for example).

Regards,
Norbert

On Sun, May 12, 2019 at 10:06 AM Lars Francke 
wrote:

> Sorry, I didn't mean to comment on the tracking sites in the VOTE thread.
> That belongs here.
>
> Either way: Markmail etc. shouldn't be broken. Yes, they may take a while
> before they index stuff but the "canonical" tracking site is
> https://lists.apache.org and that indexes new stuff automatically anwyay.
>
> On Sun, May 12, 2019 at 9:55 AM Lars Francke 
> wrote:
>
> > I'm subscribed to around 40-60 Apache Mailing lists. If the notifications
> > were in a separate list I could just subscribe to what I want instead of
> > creating 80 or so filters.
> >
> > I think I disagree, I don't have to create filters if the dev list only
> > contains "discussions".
> >
> > Cheers,
> > Lars
> >
> > On Sun, May 12, 2019 at 12:38 AM Patrick Hunt  wrote:
> >
> >> You're going to have to have a filter regardless. Why change now? Also,
> if
> >> you do change it, be sure to update all of the tracking sites such as
> >> markmail (etc...), I find this invaluable.
> >>
> >> Regards,
> >>
> >> Patrick
> >>
> >> On Fri, May 10, 2019 at 1:18 AM Lars Francke 
> >> wrote:
> >>
> >> > INFRA can do it all :)
> >> >
> >> > See for example this:
> >> >  for Jira
> >> >  for Github
> >> >
> >> > The necessary mailing lists can be created here <
> >> > https://selfserve.apache.org/>
> >> >
> >> > I'd be happy to file the issues myself but it's better if it comes
> from
> >> a
> >> > PMC member.
> >> >
> >> > Cheers,
> >> > Lars
> >> >
> >> > On Fri, May 10, 2019 at 10:00 AM Andor Molnar
> >> 
> >> > wrote:
> >> >
> >> > > Hi Lars,
> >> > >
> >> > > Thank you for the hands, yes, indeed we are interested!
> >> > > Currently I'm using all kind of magic filters to separate signal
> from
> >> > > noise.
> >> > >
> >> > > What do we need to do?
> >> > >
> >> > > Regards,
> >> > > Andor
> >> > >
> >> > >
> >> > >
> >> > > On Fri, May 10, 2019 at 9:51 AM Lars Francke <
> lars.fran...@gmail.com>
> >> > > wrote:
> >> > >
> >> > > > Hi,
> >> > > >
> >> > > > I've recently subscribed to the dev mailinglist but am overwhelmed
> >> by
> >> > the
> >> > > > number of github notifications and about to unsubscribe again.
> >> > > >
> >> > > > But maybe you're interested in moving the github & jira
> >> notifications
> >> > to
> >> > > a
> >> > > > different mailing list? I did a quick search for on the mailing
> list
> >> > > > archives but couldn't find another thread about it.
> >> > > >
> >> > > > The way we've done it at the Apache Training project now for
> >> example is
> >> > > to
> >> > > > send all Github notifications to notifications@ and all Jira
> >> messages
> >> > to
> >> > > > issues@ we only send Jira open and close mails to dev@
> >> > > >
> >> > > > This lowers the volume significantly and works just fine.
> >> > > >
> >> > > > Is this something you'd be interested in?
> >> > > >
> >> > > > Cheers,
> >> > > > Lars
> >> > > >
> >> > >
> >> >
> >>
> >
>


Re: Github & Jira notifications

2019-05-12 Thread Patrick Hunt
Arg. I did the same thing. No worries. For some reason the vote was started
at the very same time as the discuss. That's an anti-pattern.

Secondly, what about all the existing users who have already subscribed to
the ML. Will they be auto-subscribed to the new lists? And I'm assuming
that they have setup filters which will now be invalid, requiring them to
set the filters up again? I'm not clear on the logistics/impact and it
seems like we are just shifting the burden to the existing folks.

Regards,

Patrick

On Sun, May 12, 2019 at 1:06 AM Lars Francke  wrote:

> Sorry, I didn't mean to comment on the tracking sites in the VOTE thread.
> That belongs here.
>
> Either way: Markmail etc. shouldn't be broken. Yes, they may take a while
> before they index stuff but the "canonical" tracking site is
> https://lists.apache.org and that indexes new stuff automatically anwyay.
>
> On Sun, May 12, 2019 at 9:55 AM Lars Francke 
> wrote:
>
> > I'm subscribed to around 40-60 Apache Mailing lists. If the notifications
> > were in a separate list I could just subscribe to what I want instead of
> > creating 80 or so filters.
> >
> > I think I disagree, I don't have to create filters if the dev list only
> > contains "discussions".
> >
> > Cheers,
> > Lars
> >
> > On Sun, May 12, 2019 at 12:38 AM Patrick Hunt  wrote:
> >
> >> You're going to have to have a filter regardless. Why change now? Also,
> if
> >> you do change it, be sure to update all of the tracking sites such as
> >> markmail (etc...), I find this invaluable.
> >>
> >> Regards,
> >>
> >> Patrick
> >>
> >> On Fri, May 10, 2019 at 1:18 AM Lars Francke 
> >> wrote:
> >>
> >> > INFRA can do it all :)
> >> >
> >> > See for example this:
> >> >  for Jira
> >> >  for Github
> >> >
> >> > The necessary mailing lists can be created here <
> >> > https://selfserve.apache.org/>
> >> >
> >> > I'd be happy to file the issues myself but it's better if it comes
> from
> >> a
> >> > PMC member.
> >> >
> >> > Cheers,
> >> > Lars
> >> >
> >> > On Fri, May 10, 2019 at 10:00 AM Andor Molnar
> >> 
> >> > wrote:
> >> >
> >> > > Hi Lars,
> >> > >
> >> > > Thank you for the hands, yes, indeed we are interested!
> >> > > Currently I'm using all kind of magic filters to separate signal
> from
> >> > > noise.
> >> > >
> >> > > What do we need to do?
> >> > >
> >> > > Regards,
> >> > > Andor
> >> > >
> >> > >
> >> > >
> >> > > On Fri, May 10, 2019 at 9:51 AM Lars Francke <
> lars.fran...@gmail.com>
> >> > > wrote:
> >> > >
> >> > > > Hi,
> >> > > >
> >> > > > I've recently subscribed to the dev mailinglist but am overwhelmed
> >> by
> >> > the
> >> > > > number of github notifications and about to unsubscribe again.
> >> > > >
> >> > > > But maybe you're interested in moving the github & jira
> >> notifications
> >> > to
> >> > > a
> >> > > > different mailing list? I did a quick search for on the mailing
> list
> >> > > > archives but couldn't find another thread about it.
> >> > > >
> >> > > > The way we've done it at the Apache Training project now for
> >> example is
> >> > > to
> >> > > > send all Github notifications to notifications@ and all Jira
> >> messages
> >> > to
> >> > > > issues@ we only send Jira open and close mails to dev@
> >> > > >
> >> > > > This lowers the volume significantly and works just fine.
> >> > > >
> >> > > > Is this something you'd be interested in?
> >> > > >
> >> > > > Cheers,
> >> > > > Lars
> >> > > >
> >> > >
> >> >
> >>
> >
>


Re: [VOTE] Separate mailing lists for Jira and Github/Gitbox notifications

2019-05-12 Thread Patrick Hunt
For some reason the vote was started at the very same time as the discuss.
Andor can you cancel this vote thread until the discussion happens? We
typically allow 3+ days until consensus is reached on the discussion thread
plus some buffer for things to settle before starting a vote.

Patrick

On Sun, May 12, 2019 at 9:06 AM Patrick Hunt  wrote:

> How do they learn about new MLs? For example a new ZK specific ML, how
> does that get added to the markmail tracker?
>
> Regards,
>
> Patrick
>
> On Sun, May 12, 2019 at 1:04 AM Lars Francke 
> wrote:
>
>> Why does it break tracking sites? They index the ASF stuff automatically
>> as
>> far as I know.
>>
>> On Sun, May 12, 2019 at 12:40 AM Patrick Hunt  wrote:
>>
>> > -1 - I don't see the benefit. EOD it's a filter. Why change now?
>> >
>> > Also it will break all the tracking sites such as markmail, which I find
>> > invaluable when providing feedback to people or trying to look something
>> > up.
>> >
>> > Patrick
>> >
>> >
>> > On Fri, May 10, 2019 at 7:38 AM Lars Francke 
>> > wrote:
>> >
>> > > +1 non-binding.
>> > >
>> > > Thank you!
>> > >
>> > > On Fri, May 10, 2019, 12:48 Enrico Olivelli 
>> wrote:
>> > >
>> > > > +1 (non binding)
>> > > >
>> > > > Enrico
>> > > >
>> > > > Il giorno ven 10 mag 2019 alle ore 12:41 Andor Molnar <
>> > an...@apache.org>
>> > > > ha
>> > > > scritto:
>> > > >
>> > > > > Hi dev team,
>> > > > >
>> > > > > Based on Lars' suggestions I propose the following email
>> notification
>> > > > > scheme for ZooKeeper:
>> > > > > (same as HBase setup)
>> > > > >
>> > > > > Jira
>> > > > > 
>> > > > > Issue created -> dev@zookeeper.apache.org + issues@
>> > > > > Everything else -> iss...@zookeeper.apache.org
>> > > > >
>> > > > > Github/Gitbox
>> > > > > --
>> > > > > All notifications sent to notificati...@zookeeper.apache.org
>> > > > >
>> > > > > issues@ and notifications@ mailing lists have to be created
>> first.
>> > > > >
>> > > > > Please vote on the suggestion.
>> > > > >
>> > > > > Andor
>> > > > >
>> > > >
>> > >
>> >
>>
>


Re: [VOTE] Separate mailing lists for Jira and Github/Gitbox notifications

2019-05-12 Thread Patrick Hunt
How do they learn about new MLs? For example a new ZK specific ML, how does
that get added to the markmail tracker?

Regards,

Patrick

On Sun, May 12, 2019 at 1:04 AM Lars Francke  wrote:

> Why does it break tracking sites? They index the ASF stuff automatically as
> far as I know.
>
> On Sun, May 12, 2019 at 12:40 AM Patrick Hunt  wrote:
>
> > -1 - I don't see the benefit. EOD it's a filter. Why change now?
> >
> > Also it will break all the tracking sites such as markmail, which I find
> > invaluable when providing feedback to people or trying to look something
> > up.
> >
> > Patrick
> >
> >
> > On Fri, May 10, 2019 at 7:38 AM Lars Francke 
> > wrote:
> >
> > > +1 non-binding.
> > >
> > > Thank you!
> > >
> > > On Fri, May 10, 2019, 12:48 Enrico Olivelli 
> wrote:
> > >
> > > > +1 (non binding)
> > > >
> > > > Enrico
> > > >
> > > > Il giorno ven 10 mag 2019 alle ore 12:41 Andor Molnar <
> > an...@apache.org>
> > > > ha
> > > > scritto:
> > > >
> > > > > Hi dev team,
> > > > >
> > > > > Based on Lars' suggestions I propose the following email
> notification
> > > > > scheme for ZooKeeper:
> > > > > (same as HBase setup)
> > > > >
> > > > > Jira
> > > > > 
> > > > > Issue created -> dev@zookeeper.apache.org + issues@
> > > > > Everything else -> iss...@zookeeper.apache.org
> > > > >
> > > > > Github/Gitbox
> > > > > --
> > > > > All notifications sent to notificati...@zookeeper.apache.org
> > > > >
> > > > > issues@ and notifications@ mailing lists have to be created first.
> > > > >
> > > > > Please vote on the suggestion.
> > > > >
> > > > > Andor
> > > > >
> > > >
> > >
> >
>


[jira] [Updated] (ZOOKEEPER-2565) listquota should display the quota even it is set on parent/child node

2019-05-12 Thread ASF GitHub Bot (JIRA)


 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-2565:
--
Labels: pull-request-available  (was: )

> listquota  should display the quota even it is set on parent/child node
> -
>
> Key: ZOOKEEPER-2565
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2565
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.5.1
>Reporter: Rakesh Kumar Singh
>Assignee: kevin.chen
>Priority: Minor
>  Labels: pull-request-available
>
> listquota  should display the quota even it is set on parent/child 
> node. As of now if we have a parent-child hierarchy for example n1->n2->n3 
> and quota is set for n2. If we try to get quota details on n1 and n3 using 
> listquota, it says no quota set but if try to set the quota on those nodes it 
> fails saying quota is already set on parent node...
> So listquota should fetch the quota set on any node in hierarchy with exact 
> path (on which quota is set) even though this api is called on any other node 
> in that hierarchy.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [zookeeper] maoling opened a new pull request #942: ZOOKEEPER-2565:listquota should display the quota even it is set on parent/child node

2019-05-12 Thread GitBox
maoling opened a new pull request #942: ZOOKEEPER-2565:listquota  should 
display the quota even it is set on parent/child node
URL: https://github.com/apache/zookeeper/pull/942
 
 
   - this is still a work in the progress,Plz don't review before removing the 
WIP tag.
   - more details in the 
[ZOOKEEPER-2565](https://issues.apache.org/jira/browse/ZOOKEEPER-2565)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] maoling opened a new pull request #917: ZOOKEEPER-3318:-[WIP]-Add a complete backup mechanism for zookeeper internal

2019-05-12 Thread GitBox
maoling opened a new pull request #917: ZOOKEEPER-3318:-[WIP]-Add a complete 
backup mechanism for zookeeper internal
URL: https://github.com/apache/zookeeper/pull/917
 
 
   - this is still a work in the progress,Plz don't review before removing the 
WIP tag.
   - more details in 
[ZOOKEEPER-3318](https://issues.apache.org/jira/browse/ZOOKEEPER-3318) 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [zookeeper] maoling closed pull request #917: ZOOKEEPER-3318:-[WIP]-Add a complete backup mechanism for zookeeper internal

2019-05-12 Thread GitBox
maoling closed pull request #917: ZOOKEEPER-3318:-[WIP]-Add a complete backup 
mechanism for zookeeper internal
URL: https://github.com/apache/zookeeper/pull/917
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Re: Github & Jira notifications

2019-05-12 Thread Lars Francke
Sorry, I didn't mean to comment on the tracking sites in the VOTE thread.
That belongs here.

Either way: Markmail etc. shouldn't be broken. Yes, they may take a while
before they index stuff but the "canonical" tracking site is
https://lists.apache.org and that indexes new stuff automatically anwyay.

On Sun, May 12, 2019 at 9:55 AM Lars Francke  wrote:

> I'm subscribed to around 40-60 Apache Mailing lists. If the notifications
> were in a separate list I could just subscribe to what I want instead of
> creating 80 or so filters.
>
> I think I disagree, I don't have to create filters if the dev list only
> contains "discussions".
>
> Cheers,
> Lars
>
> On Sun, May 12, 2019 at 12:38 AM Patrick Hunt  wrote:
>
>> You're going to have to have a filter regardless. Why change now? Also, if
>> you do change it, be sure to update all of the tracking sites such as
>> markmail (etc...), I find this invaluable.
>>
>> Regards,
>>
>> Patrick
>>
>> On Fri, May 10, 2019 at 1:18 AM Lars Francke 
>> wrote:
>>
>> > INFRA can do it all :)
>> >
>> > See for example this:
>> >  for Jira
>> >  for Github
>> >
>> > The necessary mailing lists can be created here <
>> > https://selfserve.apache.org/>
>> >
>> > I'd be happy to file the issues myself but it's better if it comes from
>> a
>> > PMC member.
>> >
>> > Cheers,
>> > Lars
>> >
>> > On Fri, May 10, 2019 at 10:00 AM Andor Molnar
>> 
>> > wrote:
>> >
>> > > Hi Lars,
>> > >
>> > > Thank you for the hands, yes, indeed we are interested!
>> > > Currently I'm using all kind of magic filters to separate signal from
>> > > noise.
>> > >
>> > > What do we need to do?
>> > >
>> > > Regards,
>> > > Andor
>> > >
>> > >
>> > >
>> > > On Fri, May 10, 2019 at 9:51 AM Lars Francke 
>> > > wrote:
>> > >
>> > > > Hi,
>> > > >
>> > > > I've recently subscribed to the dev mailinglist but am overwhelmed
>> by
>> > the
>> > > > number of github notifications and about to unsubscribe again.
>> > > >
>> > > > But maybe you're interested in moving the github & jira
>> notifications
>> > to
>> > > a
>> > > > different mailing list? I did a quick search for on the mailing list
>> > > > archives but couldn't find another thread about it.
>> > > >
>> > > > The way we've done it at the Apache Training project now for
>> example is
>> > > to
>> > > > send all Github notifications to notifications@ and all Jira
>> messages
>> > to
>> > > > issues@ we only send Jira open and close mails to dev@
>> > > >
>> > > > This lowers the volume significantly and works just fine.
>> > > >
>> > > > Is this something you'd be interested in?
>> > > >
>> > > > Cheers,
>> > > > Lars
>> > > >
>> > >
>> >
>>
>


Re: [VOTE] Separate mailing lists for Jira and Github/Gitbox notifications

2019-05-12 Thread Lars Francke
Why does it break tracking sites? They index the ASF stuff automatically as
far as I know.

On Sun, May 12, 2019 at 12:40 AM Patrick Hunt  wrote:

> -1 - I don't see the benefit. EOD it's a filter. Why change now?
>
> Also it will break all the tracking sites such as markmail, which I find
> invaluable when providing feedback to people or trying to look something
> up.
>
> Patrick
>
>
> On Fri, May 10, 2019 at 7:38 AM Lars Francke 
> wrote:
>
> > +1 non-binding.
> >
> > Thank you!
> >
> > On Fri, May 10, 2019, 12:48 Enrico Olivelli  wrote:
> >
> > > +1 (non binding)
> > >
> > > Enrico
> > >
> > > Il giorno ven 10 mag 2019 alle ore 12:41 Andor Molnar <
> an...@apache.org>
> > > ha
> > > scritto:
> > >
> > > > Hi dev team,
> > > >
> > > > Based on Lars' suggestions I propose the following email notification
> > > > scheme for ZooKeeper:
> > > > (same as HBase setup)
> > > >
> > > > Jira
> > > > 
> > > > Issue created -> dev@zookeeper.apache.org + issues@
> > > > Everything else -> iss...@zookeeper.apache.org
> > > >
> > > > Github/Gitbox
> > > > --
> > > > All notifications sent to notificati...@zookeeper.apache.org
> > > >
> > > > issues@ and notifications@ mailing lists have to be created first.
> > > >
> > > > Please vote on the suggestion.
> > > >
> > > > Andor
> > > >
> > >
> >
>


Re: Github & Jira notifications

2019-05-12 Thread Lars Francke
I'm subscribed to around 40-60 Apache Mailing lists. If the notifications
were in a separate list I could just subscribe to what I want instead of
creating 80 or so filters.

I think I disagree, I don't have to create filters if the dev list only
contains "discussions".

Cheers,
Lars

On Sun, May 12, 2019 at 12:38 AM Patrick Hunt  wrote:

> You're going to have to have a filter regardless. Why change now? Also, if
> you do change it, be sure to update all of the tracking sites such as
> markmail (etc...), I find this invaluable.
>
> Regards,
>
> Patrick
>
> On Fri, May 10, 2019 at 1:18 AM Lars Francke 
> wrote:
>
> > INFRA can do it all :)
> >
> > See for example this:
> >  for Jira
> >  for Github
> >
> > The necessary mailing lists can be created here <
> > https://selfserve.apache.org/>
> >
> > I'd be happy to file the issues myself but it's better if it comes from a
> > PMC member.
> >
> > Cheers,
> > Lars
> >
> > On Fri, May 10, 2019 at 10:00 AM Andor Molnar  >
> > wrote:
> >
> > > Hi Lars,
> > >
> > > Thank you for the hands, yes, indeed we are interested!
> > > Currently I'm using all kind of magic filters to separate signal from
> > > noise.
> > >
> > > What do we need to do?
> > >
> > > Regards,
> > > Andor
> > >
> > >
> > >
> > > On Fri, May 10, 2019 at 9:51 AM Lars Francke 
> > > wrote:
> > >
> > > > Hi,
> > > >
> > > > I've recently subscribed to the dev mailinglist but am overwhelmed by
> > the
> > > > number of github notifications and about to unsubscribe again.
> > > >
> > > > But maybe you're interested in moving the github & jira notifications
> > to
> > > a
> > > > different mailing list? I did a quick search for on the mailing list
> > > > archives but couldn't find another thread about it.
> > > >
> > > > The way we've done it at the Apache Training project now for example
> is
> > > to
> > > > send all Github notifications to notifications@ and all Jira
> messages
> > to
> > > > issues@ we only send Jira open and close mails to dev@
> > > >
> > > > This lowers the volume significantly and works just fine.
> > > >
> > > > Is this something you'd be interested in?
> > > >
> > > > Cheers,
> > > > Lars
> > > >
> > >
> >
>