[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289325#comment-16289325 ] Hadoop QA commented on ZOOKEEPER-2952: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1363//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1363//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1363//console This message is automatically generated. > Upgrade third party libraries to address vulnerabilities > > > Key: ZOOKEEPER-2952 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2952 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.3, 3.4.11, 3.6.0 >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Critical > Labels: dependencies, upgrade, vulnerabilities > Fix For: 3.5.4, 3.6.0, 3.4.12 > > > Hi, > I'm going to upgrade the following third party libraries in order to address > vulnerabilities found in them: > - io.netty:netty 3.10.5.Final -> 3.10.6.Final (CVE-2015-2156 (H), > CVE-2014-3488 (H), protobuf: CVE-2015-5237 (H), npn-api: CVE-2017-9735 (H), > CVE-1999-1198 (H), CVE-1999-1193 (H)) > - org.slf4j:slf4j-api 1.7.5 -> 1.7.25 > - log4j:log4j 1.2.16 -> 1.2.17 > Please review the list and let me know if you have any concerns or would like > to add more deps to upgrade. > Thanks, > Andor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289304#comment-16289304 ] Hadoop QA commented on ZOOKEEPER-2952: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1362//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1362//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1362//console This message is automatically generated. > Upgrade third party libraries to address vulnerabilities > > > Key: ZOOKEEPER-2952 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2952 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.3, 3.4.11, 3.6.0 >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Critical > Labels: dependencies, upgrade, vulnerabilities > Fix For: 3.5.4, 3.6.0, 3.4.12 > > > Hi, > I'm going to upgrade the following third party libraries in order to address > vulnerabilities found in them: > - io.netty:netty 3.10.5.Final -> 3.10.6.Final (CVE-2015-2156 (H), > CVE-2014-3488 (H), protobuf: CVE-2015-5237 (H), npn-api: CVE-2017-9735 (H), > CVE-1999-1198 (H), CVE-1999-1193 (H)) > - org.slf4j:slf4j-api 1.7.5 -> 1.7.25 > - log4j:log4j 1.2.16 -> 1.2.17 > Please review the list and let me know if you have any concerns or would like > to add more deps to upgrade. > Thanks, > Andor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289303#comment-16289303 ] Hadoop QA commented on ZOOKEEPER-2952: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1361//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1361//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1361//console This message is automatically generated. > Upgrade third party libraries to address vulnerabilities > > > Key: ZOOKEEPER-2952 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2952 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.3, 3.4.11, 3.6.0 >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Critical > Labels: dependencies, upgrade, vulnerabilities > Fix For: 3.5.4, 3.6.0, 3.4.12 > > > Hi, > I'm going to upgrade the following third party libraries in order to address > vulnerabilities found in them: > - io.netty:netty 3.10.5.Final -> 3.10.6.Final (CVE-2015-2156 (H), > CVE-2014-3488 (H), protobuf: CVE-2015-5237 (H), npn-api: CVE-2017-9735 (H), > CVE-1999-1198 (H), CVE-1999-1193 (H)) > - org.slf4j:slf4j-api 1.7.5 -> 1.7.25 > - log4j:log4j 1.2.16 -> 1.2.17 > Please review the list and let me know if you have any concerns or would like > to add more deps to upgrade. > Thanks, > Andor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289245#comment-16289245 ] Hadoop QA commented on ZOOKEEPER-2952: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1360//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1360//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1360//console This message is automatically generated. > Upgrade third party libraries to address vulnerabilities > > > Key: ZOOKEEPER-2952 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2952 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.3, 3.4.11, 3.6.0 >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Critical > Labels: dependencies, upgrade, vulnerabilities > Fix For: 3.5.4, 3.6.0, 3.4.12 > > > Hi, > I'm going to upgrade the following third party libraries in order to address > vulnerabilities found in them: > - io.netty:netty 3.10.5.Final -> 3.10.6.Final (CVE-2015-2156 (H), > CVE-2014-3488 (H), protobuf: CVE-2015-5237 (H), npn-api: CVE-2017-9735 (H), > CVE-1999-1198 (H), CVE-1999-1193 (H)) > - org.slf4j:slf4j-api 1.7.5 -> 1.7.25 > Please review the list and let me know if you have any concerns or would like > to add more deps to upgrade. > Thanks, > Andor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289186#comment-16289186 ] Hadoop QA commented on ZOOKEEPER-2893: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1359//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1359//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1359//console This message is automatically generated. > very poor choice of logging if client fails to connect to server > > > Key: ZOOKEEPER-2893 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2893 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.6 >Reporter: Paul Millar >Assignee: Andor Molnar > > We are using ZooKeeper in our project and have received reports that, when > suffering a networking problem, log files become flooded with messages like: > {quote} > 07 Sep 2017 08:22:00 (System) [] Session 0x45d3151be3600a9 for server null, > unexpected error, closing socket connection and attempting reconnect > java.net.NoRouteToHostException: No route to host > at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) > ~[na:1.8.0_131] > at > sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) > ~[na:1.8.0_131] > at > org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361) > ~[zookeeper-3.4.6.jar:3.4.6-1569965] > at > org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081) > ~[zookeeper-3.4.6.jar:3.4.6-1569965] > {quote} > Looking at the code that logs this message ({{ClientCnxn}}), there seems to > be quite a few problems here: > # the code logs a stack-trace, even though there is no bug here. In our > project, we treat all logged stack-traces as bugs, > # if the networking issue is not fixed promptly, the log files is flooded > with these message, > # The message is built using {{ClientCnxnSocket#getRemoteSocketAddress}}, yet > in this case, this does not provide the expected information (yielding > {{null}}), > # The log message fails to include a description of what actually went wrong. > (Additionally, the code uses string concatenation rather than templating when > building the message; however, this is an optimisation issue) > My suggestion is that this log entry is updated so that it doesn't log a > stack-trace, but does include some indication why the connection failed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2893) very poor choice of logging if client fails to connect to server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287649#comment-16287649 ] Hadoop QA commented on ZOOKEEPER-2893: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1340//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1340//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1340//console This message is automatically generated. > very poor choice of logging if client fails to connect to server > > > Key: ZOOKEEPER-2893 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2893 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.6 >Reporter: Paul Millar >Assignee: Andor Molnar > > We are using ZooKeeper in our project and have received reports that, when > suffering a networking problem, log files become flooded with messages like: > {quote} > 07 Sep 2017 08:22:00 (System) [] Session 0x45d3151be3600a9 for server null, > unexpected error, closing socket connection and attempting reconnect > java.net.NoRouteToHostException: No route to host > at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) > ~[na:1.8.0_131] > at > sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717) > ~[na:1.8.0_131] > at > org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361) > ~[zookeeper-3.4.6.jar:3.4.6-1569965] > at > org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081) > ~[zookeeper-3.4.6.jar:3.4.6-1569965] > {quote} > Looking at the code that logs this message ({{ClientCnxn}}), there seems to > be quite a few problems here: > # the code logs a stack-trace, even though there is no bug here. In our > project, we treat all logged stack-traces as bugs, > # if the networking issue is not fixed promptly, the log files is flooded > with these message, > # The message is built using {{ClientCnxnSocket#getRemoteSocketAddress}}, yet > in this case, this does not provide the expected information (yielding > {{null}}), > # The log message fails to include a description of what actually went wrong. > (Additionally, the code uses string concatenation rather than templating when > building the message; however, this is an optimisation issue) > My suggestion is that this log entry is updated so that it doesn't log a > stack-trace, but does include some indication why the connection failed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2952) Upgrade third party libraries to address vulnerabilities
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287559#comment-16287559 ] Hadoop QA commented on ZOOKEEPER-2952: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1339//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1339//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1339//console This message is automatically generated. > Upgrade third party libraries to address vulnerabilities > > > Key: ZOOKEEPER-2952 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2952 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.5.3, 3.4.11 >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Critical > Labels: dependencies, upgrade, vulnerabilities > Fix For: 3.5.4, 3.4.12 > > > Hi, > I'm going to upgrade the following third party libraries in order to address > vulnerabilities found in them: > - io.netty:netty 3.10.5.Final -> 3.10.6.Final (CVE-2015-2156 (H), > CVE-2014-3488 (H), protobuf: CVE-2015-5237 (H), npn-api: CVE-2017-9735 (H), > CVE-1999-1198 (H), CVE-1999-1193 (H)) > - org.slf4j:slf4j-api 1.7.5 -> 1.7.25 > Please review the list and let me know if you have any concerns or would like > to add more deps to upgrade. > Thanks, > Andor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2951) zkServer.cmd does not start when JAVA_HOME ends with a \
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285829#comment-16285829 ] Hadoop QA commented on ZOOKEEPER-2951: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1338//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1338//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1338//console This message is automatically generated. > zkServer.cmd does not start when JAVA_HOME ends with a \ > > > Key: ZOOKEEPER-2951 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2951 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.4.11 > Environment: windows 7 (not tested on other windows versions+ >Reporter: Jorg Heymans > > this is the output i get (apologies for the cut-off line endings) > {noformat} > C:\RC\Tools\zookeeper-3.4.11\bin>zkServer.cmd > call "c:\RC\jdk\jdk1.8.0_121\"\bin\java > "-Dzookeeper.log.dir=C:\RC\Tools\zookeeper-3.4.11\bin\.." > "-Dzookeeper.root.logger=INFO,CONSOLE" -cp > "C:\RC\Tools\zookeeper-3.4.11\bin\..\build\classes;C:\RC\Tools\zookeeper-3.4.11\bin\..\build\lib\*;C:\RC\Tools\zookeeper-3.4.11\bin\..\*;C:\RC\Tools\zookeeper- > 3.4.11\bin\..\lib\*;C:\RC\Tools\zookeeper-3.4.11\bin\..\conf" > org.apache.zookeeper.server.quorum.QuorumPeerMain > "C:\RC\Tools\zookeeper-3.4.11\bin\..\c > onf\zoo.cfg" > Usage: java [-options] class [args...] >(to execute a class) >or java [-options] -jar jarfile [args...] >(to execute a jar file) > where options include: > -d32 use a 32-bit data model if available > -d64 use a 64-bit data model if available > -server to select the "server" VM > The default VM is server. > -cp > -classpath > A ; separated list of directories, JAR archives, > and ZIP archives to search for class files. > -D= > set a system property > -verbose:[class|gc|jni] > enable verbose output > -version print product version and exit > -version: > Warning: this feature is deprecated and will be removed > in a future release. > require the specified version to run > -showversion print product version and continue > -jre-restrict-search | -no-jre-restrict-search > Warning: this feature is deprecated and will be removed > in a future release. > include/exclude user private JREs in the version search > -? -help print this help message > -Xprint help on non-standard options > -ea[:...|:] > -enableassertions[:...|:] > enable assertions with specified granularity > -da[:...|:] > -disableassertions[:...|:] > disable assertions with specified granularity > -esa | -enablesystemassertions > enable system assertions > -dsa | -disablesystemassertions > disable system assertions > -agentlib:[=] > load native agent library , e.g. -agentlib:hprof > see also, -agentlib:jdwp=help and -agentlib:hprof=help > -agentpath:[=] > load native agent library by full pathname > -javaagent:[=] > load Java programming language agent, see > java.lang.instrument > -splash: > show splash screen with specified image > See http://www.oracle.com/technetwork/java/javase/documentation/index.html > for more details. > endlocal > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285810#comment-16285810 ] Hadoop QA commented on ZOOKEEPER-2924: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 34 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1337//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1337//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1337//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2338) c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on fork/exec
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283094#comment-16283094 ] Hadoop QA commented on ZOOKEEPER-2338: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1336//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1336//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1336//console This message is automatically generated. > c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on > fork/exec > -- > > Key: ZOOKEEPER-2338 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2338 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.5.3, 3.4.11, 3.6.0 >Reporter: James DeFelice >Assignee: Radu Brumariu > Fix For: 3.5.4, 3.6.0 > > > I've observed socket FD leaks in Apache Mesos when using ZK to coordinate > master leadership: https://issues.apache.org/jira/browse/MESOS-4065 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2807) Flaky test: org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277625#comment-16277625 ] Hadoop QA commented on ZOOKEEPER-2807: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1333//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1333//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1333//console This message is automatically generated. > Flaky test: > org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged > - > > Key: ZOOKEEPER-2807 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2807 > Project: ZooKeeper > Issue Type: Bug >Reporter: Abraham Fine >Assignee: Abraham Fine > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2901) Session ID that is negative causes mis-calculation of Ephemeral Type
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276094#comment-16276094 ] Hadoop QA commented on ZOOKEEPER-2901: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1330//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1330//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1330//console This message is automatically generated. > Session ID that is negative causes mis-calculation of Ephemeral Type > > > Key: ZOOKEEPER-2901 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2901 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.3 > Environment: Running 3.5.3-beta in Docker container >Reporter: Mark Johnson >Assignee: Jordan Zimmerman >Priority: Blocker > > In the code that determines the EphemeralType it is looking at the owner > (which is the client ID or connection ID): > EphemeralType.java: >public static EphemeralType get(long ephemeralOwner) { >if (ephemeralOwner == CONTAINER_EPHEMERAL_OWNER) { >return CONTAINER; >} >if (ephemeralOwner < 0) { >return TTL; >} >return (ephemeralOwner == 0) ? VOID : NORMAL; >} > However my connection ID is: > header.getClientId(): -720548323429908480 > This causes the code to think this is a TTL Ephemeral node instead of a > NORMAL Ephemeral node. > This also explains why this is random - if my client ID is non-negative > then the node gets added correctly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2901) Session ID that is negative causes mis-calculation of Ephemeral Type
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276080#comment-16276080 ] Hadoop QA commented on ZOOKEEPER-2901: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1327//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1327//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1327//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1327//console This message is automatically generated. > Session ID that is negative causes mis-calculation of Ephemeral Type > > > Key: ZOOKEEPER-2901 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2901 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.3 > Environment: Running 3.5.3-beta in Docker container >Reporter: Mark Johnson >Assignee: Jordan Zimmerman >Priority: Blocker > > In the code that determines the EphemeralType it is looking at the owner > (which is the client ID or connection ID): > EphemeralType.java: >public static EphemeralType get(long ephemeralOwner) { >if (ephemeralOwner == CONTAINER_EPHEMERAL_OWNER) { >return CONTAINER; >} >if (ephemeralOwner < 0) { >return TTL; >} >return (ephemeralOwner == 0) ? VOID : NORMAL; >} > However my connection ID is: > header.getClientId(): -720548323429908480 > This causes the code to think this is a TTL Ephemeral node instead of a > NORMAL Ephemeral node. > This also explains why this is random - if my client ID is non-negative > then the node gets added correctly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16274321#comment-16274321 ] Hadoop QA commented on ZOOKEEPER-2939: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 13 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1326//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1326//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1326//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2915) Use "strict" conflict management in ivy
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273532#comment-16273532 ] Hadoop QA commented on ZOOKEEPER-2915: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1324//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1324//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1324//console This message is automatically generated. > Use "strict" conflict management in ivy > --- > > Key: ZOOKEEPER-2915 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2915 > Project: ZooKeeper > Issue Type: Improvement >Affects Versions: 3.4.11, 3.5.4, 3.6.0 >Reporter: Abraham Fine >Assignee: Abraham Fine > > Currently it is very difficult to tell exactly which dependencies make it > into the final classpath of zookeeper. We do not perform any conflict > resolution between the test and default classpaths (this has resulted in > strange behavior with the slf4j-log4j12 binding) and have no way of telling > if a change to the dependencies has altered the transitive dependencies > pulled down by the project. > Our dependency list is relatively small so we should use "strict" conflict > management (break the build when we try to pull two versions of the same > dependency) so we can exercise maximum control over the classpath. > Note: I also attempted to find a way to see if I could always prefer > transitive dependencies from the default configuration over those pulled by > the test configuration (to make sure that the zookeeper we test against has > the same dependencies as the one we ship) but this appears to be impossible > (or at least incredibly difficult) with ivy. Any opinions here would be > greatly appreciated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272252#comment-16272252 ] Hadoop QA commented on ZOOKEEPER-2924: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 34 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1323//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1323//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1323//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270928#comment-16270928 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 13 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1322//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1322//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1322//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270764#comment-16270764 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 13 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1321//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1321//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1321//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270704#comment-16270704 ] Hadoop QA commented on ZOOKEEPER-2924: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 34 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1320//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1320//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1320//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-236) SSL Support for Atomic Broadcast protocol
[ https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269397#comment-16269397 ] Hadoop QA commented on ZOOKEEPER-236: - +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 40 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1319//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1319//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1319//console This message is automatically generated. > SSL Support for Atomic Broadcast protocol > - > > Key: ZOOKEEPER-236 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-236 > Project: ZooKeeper > Issue Type: New Feature > Components: quorum, security, server >Reporter: Benjamin Reed >Assignee: Abraham Fine > Labels: ssl > > We should have the ability to use SSL to authenticate and encrypt the traffic > between ZooKeeper servers. For the most part this is a very easy change. We > would probably only want to support this for TCP based leader elections. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-236) SSL Support for Atomic Broadcast protocol
[ https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269292#comment-16269292 ] Hadoop QA commented on ZOOKEEPER-236: - -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 40 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1316//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1316//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1316//console This message is automatically generated. > SSL Support for Atomic Broadcast protocol > - > > Key: ZOOKEEPER-236 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-236 > Project: ZooKeeper > Issue Type: New Feature > Components: quorum, security, server >Reporter: Benjamin Reed >Assignee: Abraham Fine > Labels: ssl > > We should have the ability to use SSL to authenticate and encrypt the traffic > between ZooKeeper servers. For the most part this is a very easy change. We > would probably only want to support this for TCP based leader elections. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-236) SSL Support for Atomic Broadcast protocol
[ https://issues.apache.org/jira/browse/ZOOKEEPER-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269284#comment-16269284 ] Hadoop QA commented on ZOOKEEPER-236: - -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 40 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1317//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1317//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1317//console This message is automatically generated. > SSL Support for Atomic Broadcast protocol > - > > Key: ZOOKEEPER-236 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-236 > Project: ZooKeeper > Issue Type: New Feature > Components: quorum, security, server >Reporter: Benjamin Reed >Assignee: Abraham Fine > Labels: ssl > > We should have the ability to use SSL to authenticate and encrypt the traffic > between ZooKeeper servers. For the most part this is a very easy change. We > would probably only want to support this for TCP based leader elections. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269108#comment-16269108 ] Hadoop QA commented on ZOOKEEPER-2924: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 34 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1315//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1315//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1315//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2338) c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on fork/exec
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267818#comment-16267818 ] Hadoop QA commented on ZOOKEEPER-2338: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1314//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1314//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1314//console This message is automatically generated. > c bindings should create socket's with SOCK_CLOEXEC to avoid fd leaks on > fork/exec > -- > > Key: ZOOKEEPER-2338 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2338 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Reporter: James DeFelice > > I've observed socket FD leaks in Apache Mesos when using ZK to coordinate > master leadership: https://issues.apache.org/jira/browse/MESOS-4065 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2935) [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267676#comment-16267676 ] Hadoop QA commented on ZOOKEEPER-2935: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 58 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1312//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1312//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1312//console This message is automatically generated. > [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk > > > Key: ZOOKEEPER-2935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2935 > Project: ZooKeeper > Issue Type: Sub-task > Components: quorum, security >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2935) [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267674#comment-16267674 ] Hadoop QA commented on ZOOKEEPER-2935: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 58 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1313//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1313//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1313//console This message is automatically generated. > [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk > > > Key: ZOOKEEPER-2935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2935 > Project: ZooKeeper > Issue Type: Sub-task > Components: quorum, security >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2901) Session ID that is negative causes mis-calculation of Ephemeral Type
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16267512#comment-16267512 ] Hadoop QA commented on ZOOKEEPER-2901: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1310//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1310//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1310//console This message is automatically generated. > Session ID that is negative causes mis-calculation of Ephemeral Type > > > Key: ZOOKEEPER-2901 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2901 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.3 > Environment: Running 3.5.3-beta in Docker container >Reporter: Mark Johnson >Assignee: Jordan Zimmerman >Priority: Blocker > > In the code that determines the EphemeralType it is looking at the owner > (which is the client ID or connection ID): > EphemeralType.java: >public static EphemeralType get(long ephemeralOwner) { >if (ephemeralOwner == CONTAINER_EPHEMERAL_OWNER) { >return CONTAINER; >} >if (ephemeralOwner < 0) { >return TTL; >} >return (ephemeralOwner == 0) ? VOID : NORMAL; >} > However my connection ID is: > header.getClientId(): -720548323429908480 > This causes the code to think this is a TTL Ephemeral node instead of a > NORMAL Ephemeral node. > This also explains why this is random - if my client ID is non-negative > then the node gets added correctly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264209#comment-16264209 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 13 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1307//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1307//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1307//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264093#comment-16264093 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 13 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1306//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1306//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1306//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263300#comment-16263300 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1305//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1305//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1305//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261998#comment-16261998 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1304//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1304//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1304//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2935) [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261398#comment-16261398 ] Hadoop QA commented on ZOOKEEPER-2935: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 58 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1294//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1294//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1294//console This message is automatically generated. > [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk > > > Key: ZOOKEEPER-2935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2935 > Project: ZooKeeper > Issue Type: Sub-task > Components: quorum, security >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2849) Quorum port binding needs exponential back-off retry
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16261206#comment-16261206 ] Hadoop QA commented on ZOOKEEPER-2849: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 16 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1293//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1293//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1293//console This message is automatically generated. > Quorum port binding needs exponential back-off retry > > > Key: ZOOKEEPER-2849 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2849 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Affects Versions: 3.4.6, 3.5.3 >Reporter: Brian Lininger >Assignee: Brian Lininger >Priority: Minor > > Recently we upgraded the AWS instance type we use for running out ZooKeeper > nodes, and by doing so we're intermittently hitting an issue where ZooKeeper > cannot bind to the server election port because the IP is incorrect. This is > due to name resolution in Route53 not being in sync when ZooKeeper starts on > the more powerful EC2 instances. Currently in QuorumCnxManager.Listener, we > only attempt to bind 3 times with a 1s sleep between retries, which is not > long enough. > I'm proposing to change this to follow an exponential back-off type strategy > where each failed attempt causes a longer sleep between retry attempts. This > would allow for Zookeeper to gracefully recover when the host is > misconfigured, and subsequently corrected, without requiring the process to > be restarted while also minimizing the impact to the running instance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260789#comment-16260789 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1292//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1292//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1292//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260757#comment-16260757 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 13 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1291//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1291//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1291//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2807) Flaky test: org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260395#comment-16260395 ] Hadoop QA commented on ZOOKEEPER-2807: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1289//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1289//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1289//console This message is automatically generated. > Flaky test: > org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged > - > > Key: ZOOKEEPER-2807 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2807 > Project: ZooKeeper > Issue Type: Bug >Reporter: Abraham Fine >Assignee: Abraham Fine > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2807) Flaky test: org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260377#comment-16260377 ] Hadoop QA commented on ZOOKEEPER-2807: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1287//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1287//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1287//console This message is automatically generated. > Flaky test: > org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged > - > > Key: ZOOKEEPER-2807 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2807 > Project: ZooKeeper > Issue Type: Bug >Reporter: Abraham Fine >Assignee: Abraham Fine > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2807) Flaky test: org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16260378#comment-16260378 ] Hadoop QA commented on ZOOKEEPER-2807: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1288//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1288//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1288//console This message is automatically generated. > Flaky test: > org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged > - > > Key: ZOOKEEPER-2807 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2807 > Project: ZooKeeper > Issue Type: Bug >Reporter: Abraham Fine >Assignee: Abraham Fine > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258362#comment-16258362 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 10 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1286//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1286//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1286//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258354#comment-16258354 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 10 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1281//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1281//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1281//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258352#comment-16258352 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 10 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1284//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1284//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1284//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258351#comment-16258351 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 10 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1283//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1283//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1283//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258348#comment-16258348 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 10 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1282//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1282//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1282//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258349#comment-16258349 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 10 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1285//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1285//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1285//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258346#comment-16258346 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1279//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1279//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1279//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258345#comment-16258345 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1278//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1278//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1278//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258347#comment-16258347 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1280//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1280//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1280//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258341#comment-16258341 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1277//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1277//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1277//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258338#comment-16258338 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to cause Findbugs (version 3.0.1) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1276//testReport/ Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1276//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN > [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@376] - Unable to > read additional data from client sessionid 0x104cd7b190c, likely client > has closed socket > [junit]
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258337#comment-16258337 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1275//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1275//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1275//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258201#comment-16258201 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1273//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1273//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1273//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258202#comment-16258202 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1274//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1274//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1274//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258197#comment-16258197 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1271//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1271//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1271//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258196#comment-16258196 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1270//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1270//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1270//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258194#comment-16258194 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1272//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1272//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1272//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258192#comment-16258192 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1269//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1269//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1269//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2849) Quorum port binding needs exponential back-off retry
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257779#comment-16257779 ] Hadoop QA commented on ZOOKEEPER-2849: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 16 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1267//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1267//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1267//console This message is automatically generated. > Quorum port binding needs exponential back-off retry > > > Key: ZOOKEEPER-2849 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2849 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Affects Versions: 3.4.6, 3.5.3 >Reporter: Brian Lininger >Assignee: Brian Lininger >Priority: Minor > > Recently we upgraded the AWS instance type we use for running out ZooKeeper > nodes, and by doing so we're intermittently hitting an issue where ZooKeeper > cannot bind to the server election port because the IP is incorrect. This is > due to name resolution in Route53 not being in sync when ZooKeeper starts on > the more powerful EC2 instances. Currently in QuorumCnxManager.Listener, we > only attempt to bind 3 times with a 1s sleep between retries, which is not > long enough. > I'm proposing to change this to follow an exponential back-off type strategy > where each failed attempt causes a longer sleep between retry attempts. This > would allow for Zookeeper to gracefully recover when the host is > misconfigured, and subsequently corrected, without requiring the process to > be restarted while also minimizing the impact to the running instance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2849) Quorum port binding needs exponential back-off retry
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257778#comment-16257778 ] Hadoop QA commented on ZOOKEEPER-2849: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 16 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1266//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1266//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1266//console This message is automatically generated. > Quorum port binding needs exponential back-off retry > > > Key: ZOOKEEPER-2849 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2849 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Affects Versions: 3.4.6, 3.5.3 >Reporter: Brian Lininger >Assignee: Brian Lininger >Priority: Minor > > Recently we upgraded the AWS instance type we use for running out ZooKeeper > nodes, and by doing so we're intermittently hitting an issue where ZooKeeper > cannot bind to the server election port because the IP is incorrect. This is > due to name resolution in Route53 not being in sync when ZooKeeper starts on > the more powerful EC2 instances. Currently in QuorumCnxManager.Listener, we > only attempt to bind 3 times with a 1s sleep between retries, which is not > long enough. > I'm proposing to change this to follow an exponential back-off type strategy > where each failed attempt causes a longer sleep between retry attempts. This > would allow for Zookeeper to gracefully recover when the host is > misconfigured, and subsequently corrected, without requiring the process to > be restarted while also minimizing the impact to the running instance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257106#comment-16257106 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1254//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1254//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1254//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257095#comment-16257095 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1251//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1251//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1251//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257083#comment-16257083 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1253//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1253//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1253//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257084#comment-16257084 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1252//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1252//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1252//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257061#comment-16257061 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to cause Findbugs (version 3.0.1) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1250//testReport/ Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1250//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257060#comment-16257060 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1249//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1249//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1249//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256862#comment-16256862 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1248//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1248//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1248//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256854#comment-16256854 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1247//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1247//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1247//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256851#comment-16256851 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1243//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1243//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1243//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256848#comment-16256848 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1244//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1244//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1244//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256839#comment-16256839 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1246//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1246//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1246//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256838#comment-16256838 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1245//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1245//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1245//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256792#comment-16256792 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1238//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1238//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1238//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256790#comment-16256790 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1237//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1237//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1237//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256788#comment-16256788 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1242//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1242//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1242//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256787#comment-16256787 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1241//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1241//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1241//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256769#comment-16256769 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1240//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1240//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1240//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2924) Flaky Test: org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256767#comment-16256767 ] Hadoop QA commented on ZOOKEEPER-2924: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 33 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1239//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1239//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1239//console This message is automatically generated. > Flaky Test: > org.apache.zookeeper.test.LoadFromLogTest.testRestoreWithTransactionErrors > -- > > Key: ZOOKEEPER-2924 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2924 > Project: ZooKeeper > Issue Type: Bug > Components: server, tests >Reporter: Andor Molnar >Assignee: Andor Molnar > Labels: flaky, flaky-test > Fix For: 3.4.12 > > > From https://builds.apache.org/job/ZooKeeper_branch34_openjdk7/1682/ > Same issue happens in jdk8 and jdk9 builds as well. > Issue has already been fixed by > https://issues.apache.org/jira/browse/ZOOKEEPER-2484 , but I believe that the > root cause here is that test startup / cleanup code is included in the tests > instead of using try-finally block or Before-After methods. > As a consequence, when exception happens during test execution, ZK test > server doesn't get shutdown properly and still listening on the port bound to > the test class. > As mentioned above there could be 2 approaches to address this: > #1 Wrap cleanup code block with finally > #2 Use JUnit's Before-After methods for initialization and cleanup > Test where original issue happens: > {noformat} > ... > [junit] 2017-10-12 15:05:20,135 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8c zxid:0x8d > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,137 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8d zxid:0x8e > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,139 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8e zxid:0x8f > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,142 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x8f zxid:0x90 > txntype:-1 req$ > [junit] 2017-10-12 15:05:20,144 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:create cxid:0x90 zxid:0x91 > txntype:-1 req$ > [junit] 2017-10-12 15:05:30,479 [myid:] - INFO > [SessionTracker:ZooKeeperServer@354] - Expiring session 0x104cd7b190c, > timeout of 6000ms exceeded > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO [ProcessThread(sid:0 > cport:11221)::PrepRequestProcessor@653] - Got user-level KeeperException when > processing sessionid:0x104cd7b190c type:ping cxid:0xfffe > zxid:0xf$ > [junit] 2017-10-12 15:05:24,147 [myid:] - WARN > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c > [junit] 2017-10-12 15:05:32,996 [myid:] - INFO > [main-SendThread(127.0.0.1:11221):ClientCnxn$SendThread@1159] - Client > session timed out, have not heard from server in 4002ms for sessionid > 0x104cd7b190c, closing socket connectio$ > [junit] 2017-10-12 15:05:21,479 [myid:] - INFO > [SessionTracker:SessionTrackerImpl@163] - SessionTrackerImpl exited loop! > [junit] 2017-10-12 15:05:32,998 [myid:] - WARN >
[jira] [Commented] (ZOOKEEPER-2849) Quorum port binding needs exponential back-off retry
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256055#comment-16256055 ] Hadoop QA commented on ZOOKEEPER-2849: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 14 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1231//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1231//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1231//console This message is automatically generated. > Quorum port binding needs exponential back-off retry > > > Key: ZOOKEEPER-2849 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2849 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Affects Versions: 3.4.6, 3.5.3 >Reporter: Brian Lininger >Assignee: Brian Lininger >Priority: Minor > > Recently we upgraded the AWS instance type we use for running out ZooKeeper > nodes, and by doing so we're intermittently hitting an issue where ZooKeeper > cannot bind to the server election port because the IP is incorrect. This is > due to name resolution in Route53 not being in sync when ZooKeeper starts on > the more powerful EC2 instances. Currently in QuorumCnxManager.Listener, we > only attempt to bind 3 times with a 1s sleep between retries, which is not > long enough. > I'm proposing to change this to follow an exponential back-off type strategy > where each failed attempt causes a longer sleep between retry attempts. This > would allow for Zookeeper to gracefully recover when the host is > misconfigured, and subsequently corrected, without requiring the process to > be restarted while also minimizing the impact to the running instance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2849) Quorum port binding needs exponential back-off retry
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256053#comment-16256053 ] Hadoop QA commented on ZOOKEEPER-2849: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 14 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1235//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1235//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1235//console This message is automatically generated. > Quorum port binding needs exponential back-off retry > > > Key: ZOOKEEPER-2849 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2849 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Affects Versions: 3.4.6, 3.5.3 >Reporter: Brian Lininger >Assignee: Brian Lininger >Priority: Minor > > Recently we upgraded the AWS instance type we use for running out ZooKeeper > nodes, and by doing so we're intermittently hitting an issue where ZooKeeper > cannot bind to the server election port because the IP is incorrect. This is > due to name resolution in Route53 not being in sync when ZooKeeper starts on > the more powerful EC2 instances. Currently in QuorumCnxManager.Listener, we > only attempt to bind 3 times with a 1s sleep between retries, which is not > long enough. > I'm proposing to change this to follow an exponential back-off type strategy > where each failed attempt causes a longer sleep between retry attempts. This > would allow for Zookeeper to gracefully recover when the host is > misconfigured, and subsequently corrected, without requiring the process to > be restarted while also minimizing the impact to the running instance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2849) Quorum port binding needs exponential back-off retry
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256054#comment-16256054 ] Hadoop QA commented on ZOOKEEPER-2849: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 14 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1236//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1236//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1236//console This message is automatically generated. > Quorum port binding needs exponential back-off retry > > > Key: ZOOKEEPER-2849 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2849 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Affects Versions: 3.4.6, 3.5.3 >Reporter: Brian Lininger >Assignee: Brian Lininger >Priority: Minor > > Recently we upgraded the AWS instance type we use for running out ZooKeeper > nodes, and by doing so we're intermittently hitting an issue where ZooKeeper > cannot bind to the server election port because the IP is incorrect. This is > due to name resolution in Route53 not being in sync when ZooKeeper starts on > the more powerful EC2 instances. Currently in QuorumCnxManager.Listener, we > only attempt to bind 3 times with a 1s sleep between retries, which is not > long enough. > I'm proposing to change this to follow an exponential back-off type strategy > where each failed attempt causes a longer sleep between retry attempts. This > would allow for Zookeeper to gracefully recover when the host is > misconfigured, and subsequently corrected, without requiring the process to > be restarted while also minimizing the impact to the running instance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2849) Quorum port binding needs exponential back-off retry
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256040#comment-16256040 ] Hadoop QA commented on ZOOKEEPER-2849: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 14 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1232//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1232//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1232//console This message is automatically generated. > Quorum port binding needs exponential back-off retry > > > Key: ZOOKEEPER-2849 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2849 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Affects Versions: 3.4.6, 3.5.3 >Reporter: Brian Lininger >Assignee: Brian Lininger >Priority: Minor > > Recently we upgraded the AWS instance type we use for running out ZooKeeper > nodes, and by doing so we're intermittently hitting an issue where ZooKeeper > cannot bind to the server election port because the IP is incorrect. This is > due to name resolution in Route53 not being in sync when ZooKeeper starts on > the more powerful EC2 instances. Currently in QuorumCnxManager.Listener, we > only attempt to bind 3 times with a 1s sleep between retries, which is not > long enough. > I'm proposing to change this to follow an exponential back-off type strategy > where each failed attempt causes a longer sleep between retry attempts. This > would allow for Zookeeper to gracefully recover when the host is > misconfigured, and subsequently corrected, without requiring the process to > be restarted while also minimizing the impact to the running instance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2849) Quorum port binding needs exponential back-off retry
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256041#comment-16256041 ] Hadoop QA commented on ZOOKEEPER-2849: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 14 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1234//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1234//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1234//console This message is automatically generated. > Quorum port binding needs exponential back-off retry > > > Key: ZOOKEEPER-2849 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2849 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Affects Versions: 3.4.6, 3.5.3 >Reporter: Brian Lininger >Assignee: Brian Lininger >Priority: Minor > > Recently we upgraded the AWS instance type we use for running out ZooKeeper > nodes, and by doing so we're intermittently hitting an issue where ZooKeeper > cannot bind to the server election port because the IP is incorrect. This is > due to name resolution in Route53 not being in sync when ZooKeeper starts on > the more powerful EC2 instances. Currently in QuorumCnxManager.Listener, we > only attempt to bind 3 times with a 1s sleep between retries, which is not > long enough. > I'm proposing to change this to follow an exponential back-off type strategy > where each failed attempt causes a longer sleep between retry attempts. This > would allow for Zookeeper to gracefully recover when the host is > misconfigured, and subsequently corrected, without requiring the process to > be restarted while also minimizing the impact to the running instance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255960#comment-16255960 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1230//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1230//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1230//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255954#comment-16255954 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1229//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1229//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1229//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255949#comment-16255949 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1226//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1226//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1226//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255948#comment-16255948 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1228//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1228//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1228//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255946#comment-16255946 ] Hadoop QA commented on ZOOKEEPER-2939: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1225//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1225//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1225//console This message is automatically generated. > Deal with maxbuffer as it relates to proposals > -- > > Key: ZOOKEEPER-2939 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939 > Project: ZooKeeper > Issue Type: Sub-task > Components: jute, server >Reporter: Andor Molnar >Assignee: Andor Molnar > Fix For: 3.5.4, 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2849) Quorum port binding needs exponential back-off retry
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255753#comment-16255753 ] Hadoop QA commented on ZOOKEEPER-2849: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 14 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. -1 release audit. The applied patch generated 3 release audit warnings (more than the trunk's current 0 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1223//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1223//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1223//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1223//console This message is automatically generated. > Quorum port binding needs exponential back-off retry > > > Key: ZOOKEEPER-2849 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2849 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Affects Versions: 3.4.6, 3.5.3 >Reporter: Brian Lininger >Assignee: Brian Lininger >Priority: Minor > > Recently we upgraded the AWS instance type we use for running out ZooKeeper > nodes, and by doing so we're intermittently hitting an issue where ZooKeeper > cannot bind to the server election port because the IP is incorrect. This is > due to name resolution in Route53 not being in sync when ZooKeeper starts on > the more powerful EC2 instances. Currently in QuorumCnxManager.Listener, we > only attempt to bind 3 times with a 1s sleep between retries, which is not > long enough. > I'm proposing to change this to follow an exponential back-off type strategy > where each failed attempt causes a longer sleep between retry attempts. This > would allow for Zookeeper to gracefully recover when the host is > misconfigured, and subsequently corrected, without requiring the process to > be restarted while also minimizing the impact to the running instance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2849) Quorum port binding needs exponential back-off retry
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255750#comment-16255750 ] Hadoop QA commented on ZOOKEEPER-2849: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 14 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. -1 release audit. The applied patch generated 3 release audit warnings (more than the trunk's current 0 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1224//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1224//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1224//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1224//console This message is automatically generated. > Quorum port binding needs exponential back-off retry > > > Key: ZOOKEEPER-2849 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2849 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Affects Versions: 3.4.6, 3.5.3 >Reporter: Brian Lininger >Assignee: Brian Lininger >Priority: Minor > > Recently we upgraded the AWS instance type we use for running out ZooKeeper > nodes, and by doing so we're intermittently hitting an issue where ZooKeeper > cannot bind to the server election port because the IP is incorrect. This is > due to name resolution in Route53 not being in sync when ZooKeeper starts on > the more powerful EC2 instances. Currently in QuorumCnxManager.Listener, we > only attempt to bind 3 times with a 1s sleep between retries, which is not > long enough. > I'm proposing to change this to follow an exponential back-off type strategy > where each failed attempt causes a longer sleep between retry attempts. This > would allow for Zookeeper to gracefully recover when the host is > misconfigured, and subsequently corrected, without requiring the process to > be restarted while also minimizing the impact to the running instance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2849) Quorum port binding needs exponential back-off retry
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255748#comment-16255748 ] Hadoop QA commented on ZOOKEEPER-2849: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 14 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. -1 release audit. The applied patch generated 3 release audit warnings (more than the trunk's current 0 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1222//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1222//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1222//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1222//console This message is automatically generated. > Quorum port binding needs exponential back-off retry > > > Key: ZOOKEEPER-2849 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2849 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Affects Versions: 3.4.6, 3.5.3 >Reporter: Brian Lininger >Assignee: Brian Lininger >Priority: Minor > > Recently we upgraded the AWS instance type we use for running out ZooKeeper > nodes, and by doing so we're intermittently hitting an issue where ZooKeeper > cannot bind to the server election port because the IP is incorrect. This is > due to name resolution in Route53 not being in sync when ZooKeeper starts on > the more powerful EC2 instances. Currently in QuorumCnxManager.Listener, we > only attempt to bind 3 times with a 1s sleep between retries, which is not > long enough. > I'm proposing to change this to follow an exponential back-off type strategy > where each failed attempt causes a longer sleep between retry attempts. This > would allow for Zookeeper to gracefully recover when the host is > misconfigured, and subsequently corrected, without requiring the process to > be restarted while also minimizing the impact to the running instance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2849) Quorum port binding needs exponential back-off retry
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16255741#comment-16255741 ] Hadoop QA commented on ZOOKEEPER-2849: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 14 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. -1 release audit. The applied patch generated 3 release audit warnings (more than the trunk's current 0 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1221//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1221//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1221//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1221//console This message is automatically generated. > Quorum port binding needs exponential back-off retry > > > Key: ZOOKEEPER-2849 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2849 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Affects Versions: 3.4.6, 3.5.3 >Reporter: Brian Lininger >Assignee: Brian Lininger >Priority: Minor > > Recently we upgraded the AWS instance type we use for running out ZooKeeper > nodes, and by doing so we're intermittently hitting an issue where ZooKeeper > cannot bind to the server election port because the IP is incorrect. This is > due to name resolution in Route53 not being in sync when ZooKeeper starts on > the more powerful EC2 instances. Currently in QuorumCnxManager.Listener, we > only attempt to bind 3 times with a 1s sleep between retries, which is not > long enough. > I'm proposing to change this to follow an exponential back-off type strategy > where each failed attempt causes a longer sleep between retry attempts. This > would allow for Zookeeper to gracefully recover when the host is > misconfigured, and subsequently corrected, without requiring the process to > be restarted while also minimizing the impact to the running instance. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2935) [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254560#comment-16254560 ] Hadoop QA commented on ZOOKEEPER-2935: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 57 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1211//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1211//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1211//console This message is automatically generated. > [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk > > > Key: ZOOKEEPER-2935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2935 > Project: ZooKeeper > Issue Type: Sub-task > Components: quorum, security >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2935) [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254554#comment-16254554 ] Hadoop QA commented on ZOOKEEPER-2935: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 57 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1210//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1210//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1210//console This message is automatically generated. > [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk > > > Key: ZOOKEEPER-2935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2935 > Project: ZooKeeper > Issue Type: Sub-task > Components: quorum, security >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2935) [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254547#comment-16254547 ] Hadoop QA commented on ZOOKEEPER-2935: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 57 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1207//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1207//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1207//console This message is automatically generated. > [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk > > > Key: ZOOKEEPER-2935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2935 > Project: ZooKeeper > Issue Type: Sub-task > Components: quorum, security >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2935) [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254543#comment-16254543 ] Hadoop QA commented on ZOOKEEPER-2935: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 57 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1202//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1202//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1202//console This message is automatically generated. > [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk > > > Key: ZOOKEEPER-2935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2935 > Project: ZooKeeper > Issue Type: Sub-task > Components: quorum, security >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2935) [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254539#comment-16254539 ] Hadoop QA commented on ZOOKEEPER-2935: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 57 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1203//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1203//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1203//console This message is automatically generated. > [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk > > > Key: ZOOKEEPER-2935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2935 > Project: ZooKeeper > Issue Type: Sub-task > Components: quorum, security >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2935) [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254530#comment-16254530 ] Hadoop QA commented on ZOOKEEPER-2935: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 57 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1204//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1204//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1204//console This message is automatically generated. > [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk > > > Key: ZOOKEEPER-2935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2935 > Project: ZooKeeper > Issue Type: Sub-task > Components: quorum, security >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2935) [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254529#comment-16254529 ] Hadoop QA commented on ZOOKEEPER-2935: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 57 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1198//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1198//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1198//console This message is automatically generated. > [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk > > > Key: ZOOKEEPER-2935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2935 > Project: ZooKeeper > Issue Type: Sub-task > Components: quorum, security >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2935) [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254527#comment-16254527 ] Hadoop QA commented on ZOOKEEPER-2935: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 57 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1197//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1197//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1197//console This message is automatically generated. > [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk > > > Key: ZOOKEEPER-2935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2935 > Project: ZooKeeper > Issue Type: Sub-task > Components: quorum, security >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2935) [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254526#comment-16254526 ] Hadoop QA commented on ZOOKEEPER-2935: -- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 57 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1196//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1196//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1196//console This message is automatically generated. > [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk > > > Key: ZOOKEEPER-2935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2935 > Project: ZooKeeper > Issue Type: Sub-task > Components: quorum, security >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ZOOKEEPER-2935) [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254523#comment-16254523 ] Hadoop QA commented on ZOOKEEPER-2935: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 57 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1201//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1201//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1201//console This message is automatically generated. > [QP MutualAuth]: Port ZOOKEEPER-1045 implementation from branch-3.5 to trunk > > > Key: ZOOKEEPER-2935 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2935 > Project: ZooKeeper > Issue Type: Sub-task > Components: quorum, security >Reporter: Abraham Fine >Assignee: Abraham Fine > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)