[jira] [Commented] (ZOOKEEPER-1426) add version command to the zookeeper server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853456#comment-16853456 ] Hudson commented on ZOOKEEPER-1426: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #383 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/383/]) ZOOKEEPER-1426: add version command to the zookeeper server (andor: rev d3dbe787f37eb9e17402e4a3d55a441ca43b2160) * (edit) bin/zkServer.sh * (edit) zookeeper-server/src/test/resources/findbugsExcludeFile.xml * (edit) zookeeper-server/src/test/resources/test-scripts.sh * (edit) bin/zkServer-initialize.sh * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/version/util/VerGen.java > add version command to the zookeeper server > --- > > Key: ZOOKEEPER-1426 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426 > Project: ZooKeeper > Issue Type: Improvement > Components: scripts, server >Affects Versions: 3.3.5 >Reporter: Patrick Hunt >Assignee: Eli Reisman >Priority: Major > Labels: newbie, patch, pull-request-available > Fix For: 3.6.0 > > Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch, > ZOOKEEPER-1426-2.patch, ZOOKEEPER-1426-3.patch > > Time Spent: 3h > Remaining Estimate: 0h > > Add a version command to the zkServer.sh. > Hadoop does this by having a special main class: > org.apache.hadoop.util.VersionInfo > We could do something similar, hook it into our current version information > class (perhaps add main to that class). > Would also need to add a new "version" command to zkServer.sh that calls this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-1426) add version command to the zookeeper server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853413#comment-16853413 ] Hudson commented on ZOOKEEPER-1426: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #548 (See [https://builds.apache.org/job/ZooKeeper-trunk/548/]) ZOOKEEPER-1426: add version command to the zookeeper server (andor: rev d3dbe787f37eb9e17402e4a3d55a441ca43b2160) * (edit) bin/zkServer.sh * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/version/util/VerGen.java * (edit) zookeeper-server/src/test/resources/findbugsExcludeFile.xml * (edit) zookeeper-server/src/test/resources/test-scripts.sh * (edit) bin/zkServer-initialize.sh > add version command to the zookeeper server > --- > > Key: ZOOKEEPER-1426 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426 > Project: ZooKeeper > Issue Type: Improvement > Components: scripts, server >Affects Versions: 3.3.5 >Reporter: Patrick Hunt >Assignee: Eli Reisman >Priority: Major > Labels: newbie, patch, pull-request-available > Fix For: 3.6.0 > > Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch, > ZOOKEEPER-1426-2.patch, ZOOKEEPER-1426-3.patch > > Time Spent: 3h > Remaining Estimate: 0h > > Add a version command to the zkServer.sh. > Hadoop does this by having a special main class: > org.apache.hadoop.util.VersionInfo > We could do something similar, hook it into our current version information > class (perhaps add main to that class). > Would also need to add a new "version" command to zkServer.sh that calls this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3405) owasp flagging jackson-databind
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852452#comment-16852452 ] Hudson commented on ZOOKEEPER-3405: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #546 (See [https://builds.apache.org/job/ZooKeeper-trunk/546/]) ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP (nkalmar: rev ca4b12430ef579f67785146a195ebfed5ca73f39) * (edit) pom.xml * (edit) build.xml > owasp flagging jackson-databind > --- > > Key: ZOOKEEPER-3405 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3405 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.6.0, 3.5.5 >Reporter: Patrick Hunt >Assignee: Patrick Hunt >Priority: Critical > Labels: pull-request-available > Fix For: 3.6.0, 3.5.6 > > Time Spent: 1h > Remaining Estimate: 0h > > Owasp job is flagging jackson-databind for update: > CVE-2019-12086CWE-200 Information ExposureMedium(5.0) > jackson-databind-2.9.8.jar -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3405) owasp flagging jackson-databind
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852440#comment-16852440 ] Hudson commented on ZOOKEEPER-3405: --- FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #381 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/381/]) ZOOKEEPER-3405: Upgrade the version of Jackson-databind to address OWASP (nkalmar: rev ca4b12430ef579f67785146a195ebfed5ca73f39) * (edit) build.xml * (edit) pom.xml > owasp flagging jackson-databind > --- > > Key: ZOOKEEPER-3405 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3405 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.6.0, 3.5.5 >Reporter: Patrick Hunt >Assignee: Patrick Hunt >Priority: Critical > Labels: pull-request-available > Fix For: 3.6.0, 3.5.6 > > Time Spent: 1h > Remaining Estimate: 0h > > Owasp job is flagging jackson-databind for update: > CVE-2019-12086CWE-200 Information ExposureMedium(5.0) > jackson-databind-2.9.8.jar -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3382) Update Documentation: If you only have one storage device
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851368#comment-16851368
]
Hudson commented on ZOOKEEPER-3382:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #379 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/379/])
ZOOKEEPER-3382: Update Documentation: If you only have one storage (andor: rev
f7bdab002aa01677145654f8a1f93a45969d22cd)
* (edit) zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md
* (edit) zookeeper-docs/src/main/resources/markdown/zookeeperProgrammers.md
> Update Documentation: If you only have one storage device
> -
>
> Key: ZOOKEEPER-3382
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3382
> Project: ZooKeeper
> Issue Type: Improvement
> Components: documentation
>Affects Versions: 3.6.0, 3.5.5, 3.4.15
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {quote}
> If you only have one storage device, put trace files on NFS and increase the
> snapshotCount; it doesn't eliminate the problem, but it should mitigate it.
> {quote}
> 'trace files' are no longer available in ZooKeeper; remove mention of it.
> Also, there is no such configuration named 'snapshotCount'; update it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3382) Update Documentation: If you only have one storage device
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851096#comment-16851096
]
Hudson commented on ZOOKEEPER-3382:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #544 (See
[https://builds.apache.org/job/ZooKeeper-trunk/544/])
ZOOKEEPER-3382: Update Documentation: If you only have one storage (andor: rev
f7bdab002aa01677145654f8a1f93a45969d22cd)
* (edit) zookeeper-docs/src/main/resources/markdown/zookeeperProgrammers.md
* (edit) zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md
> Update Documentation: If you only have one storage device
> -
>
> Key: ZOOKEEPER-3382
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3382
> Project: ZooKeeper
> Issue Type: Improvement
> Components: documentation
>Affects Versions: 3.6.0, 3.5.5, 3.4.15
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {quote}
> If you only have one storage device, put trace files on NFS and increase the
> snapshotCount; it doesn't eliminate the problem, but it should mitigate it.
> {quote}
> 'trace files' are no longer available in ZooKeeper; remove mention of it.
> Also, there is no such configuration named 'snapshotCount'; update it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3401) Fix metric PROPOSAL_ACK_CREATION_LATENCY
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850298#comment-16850298 ] Hudson commented on ZOOKEEPER-3401: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #543 (See [https://builds.apache.org/job/ZooKeeper-trunk/543/]) ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY (nkalmar: rev bb94aa44de61bfb2ecd5bbd12b4eb390c2cf39c1) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/AckRequestProcessor.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerMetricsTest.java > Fix metric PROPOSAL_ACK_CREATION_LATENCY > > > Key: ZOOKEEPER-3401 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3401 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3404) BouncyCastle upgrade to 1.61 might cause flaky test issues
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850299#comment-16850299 ] Hudson commented on ZOOKEEPER-3404: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #543 (See [https://builds.apache.org/job/ZooKeeper-trunk/543/]) ZOOKEEPER-3404: Downgrade BouncyCastle to 1.60 (nkalmar: rev 78b3d1a8c1ea8453423682ad09675dfb1df04384) * (edit) build.xml * (edit) pom.xml > BouncyCastle upgrade to 1.61 might cause flaky test issues > -- > > Key: ZOOKEEPER-3404 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3404 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.6.0 >Reporter: Andor Molnar >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0, 3.5.6 > > Time Spent: 50m > Remaining Estimate: 0h > > I've seen a lot of test timeout errors with QuorumSSL tests since I upgraded > master to BouncyCastle 1.61 due to a Java 9 warning. The warning has been > reported by [~eolivelli] which we tried to solve by the upgrade, but the > warning message is still present so I don't see any harm in downgrading to > the previous version. > The timeout errors are very frequent with recent Java versions (11+) and > quite rare with Java 8. > I think it's worth a try to downgrade and see if tests will be in a better > shape. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3404) BouncyCastle upgrade to 1.61 might cause flaky test issues
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849883#comment-16849883 ] Hudson commented on ZOOKEEPER-3404: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #377 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/377/]) ZOOKEEPER-3404: Downgrade BouncyCastle to 1.60 (nkalmar: rev 78b3d1a8c1ea8453423682ad09675dfb1df04384) * (edit) pom.xml * (edit) build.xml > BouncyCastle upgrade to 1.61 might cause flaky test issues > -- > > Key: ZOOKEEPER-3404 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3404 > Project: ZooKeeper > Issue Type: Bug > Components: tests >Affects Versions: 3.6.0 >Reporter: Andor Molnar >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0, 3.5.6 > > Time Spent: 50m > Remaining Estimate: 0h > > I've seen a lot of test timeout errors with QuorumSSL tests since I upgraded > master to BouncyCastle 1.61 due to a Java 9 warning. The warning has been > reported by [~eolivelli] which we tried to solve by the upgrade, but the > warning message is still present so I don't see any harm in downgrading to > the previous version. > The timeout errors are very frequent with recent Java versions (11+) and > quite rare with Java 8. > I think it's worth a try to downgrade and see if tests will be in a better > shape. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3401) Fix metric PROPOSAL_ACK_CREATION_LATENCY
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849882#comment-16849882 ] Hudson commented on ZOOKEEPER-3401: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #377 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/377/]) ZOOKEEPER-3401: Fix metric PROPOSAL_ACK_CREATION_LATENCY (nkalmar: rev bb94aa44de61bfb2ecd5bbd12b4eb390c2cf39c1) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/AckRequestProcessor.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerMetricsTest.java > Fix metric PROPOSAL_ACK_CREATION_LATENCY > > > Key: ZOOKEEPER-3401 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3401 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3379) De-flaky test in Quorum Packet Metrics
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849288#comment-16849288 ] Hudson commented on ZOOKEEPER-3379: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #542 (See [https://builds.apache.org/job/ZooKeeper-trunk/542/]) ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics (andor: rev d713419bde97374a2d1b1cbe51fcb17b4416a196) * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerHandlerMetricsTest.java > De-flaky test in Quorum Packet Metrics > -- > > Key: ZOOKEEPER-3379 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3379 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 5h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3379) De-flaky test in Quorum Packet Metrics
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16849273#comment-16849273 ] Hudson commented on ZOOKEEPER-3379: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #376 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/376/]) ZOOKEEPER-3379: De-flaky test in Quorum Packet Metrics (andor: rev d713419bde97374a2d1b1cbe51fcb17b4416a196) * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerHandlerMetricsTest.java > De-flaky test in Quorum Packet Metrics > -- > > Key: ZOOKEEPER-3379 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3379 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 5h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3392) Add admin command to display last snapshot information
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848927#comment-16848927 ] Hudson commented on ZOOKEEPER-3392: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #541 (See [https://builds.apache.org/job/ZooKeeper-trunk/541/]) ZOOKEEPER-3392: Add admin command to display last snapshot information (nkalmar: rev ea8536982c39fd1127a4e6e7a8229b64a5798447) * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/admin/CommandsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/SnapShot.java * (add) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/SnapshotInfo.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileSnap.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java > Add admin command to display last snapshot information > -- > > Key: ZOOKEEPER-3392 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3392 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Basic systems to backup ZooKeeper data will maintain snapshot files of the > data tree. In order to understand the health of these systems, they need a > way to determine how in or out of date their files are to the current state > in the ensemble. > Add an admin command that exposes the zxid and timestamp of the last > saved/restored snapshot of the server. This will let such a backup system > know when it can update and when it is stale. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3392) Add admin command to display last snapshot information
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848909#comment-16848909 ] Hudson commented on ZOOKEEPER-3392: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #375 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/375/]) ZOOKEEPER-3392: Add admin command to display last snapshot information (nkalmar: rev ea8536982c39fd1127a4e6e7a8229b64a5798447) * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/admin/CommandsTest.java * (add) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/SnapshotInfo.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/SnapShot.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileSnap.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java > Add admin command to display last snapshot information > -- > > Key: ZOOKEEPER-3392 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3392 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Basic systems to backup ZooKeeper data will maintain snapshot files of the > data tree. In order to understand the health of these systems, they need a > way to determine how in or out of date their files are to the current state > in the ensemble. > Add an admin command that exposes the zxid and timestamp of the last > saved/restored snapshot of the server. This will let such a backup system > know when it can update and when it is stale. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3399) Remove logging in getGlobalOutstandingLimit for optimal performance.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848277#comment-16848277 ] Hudson commented on ZOOKEEPER-3399: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #373 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/373/]) ZOOKEEPER-3399: Remove logging in getGlobalOutstandingLimit for optimal (eolivelli: rev 968f5f365e53d0bcbbe0225cc382327badbd8380) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java > Remove logging in getGlobalOutstandingLimit for optimal performance. > > > Key: ZOOKEEPER-3399 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3399 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Michael Han >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Recently we have moved some of our production clusters to the top of the > trunk. One issue we found is a performance regression on read and write > latency on the clusters where the quorum is also serving traffic. The average > read latency increased by 50x, p99 read latency increased by 300x. > The root cause is a log statement introduced in ZOOKEEPER-3177 (PR711), where > we added a LOG.info statement in getGlobalOutstandingLimit. > getGlobalOutstandingLimit is on the critical code path for request processing > and for each request, it will be called twice (one at processing the packet, > one at finalizing the request response). This not only degrades performance > of the server, but also bloated the log file, when the QPS of a server is > high. > This only impacts clusters when the quorum (leader + follower) is serving > traffic. For clusters where only observers are serving traffic no impact is > observed. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3399) Remove logging in getGlobalOutstandingLimit for optimal performance.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848273#comment-16848273 ] Hudson commented on ZOOKEEPER-3399: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #538 (See [https://builds.apache.org/job/ZooKeeper-trunk/538/]) ZOOKEEPER-3399: Remove logging in getGlobalOutstandingLimit for optimal (eolivelli: rev 968f5f365e53d0bcbbe0225cc382327badbd8380) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java > Remove logging in getGlobalOutstandingLimit for optimal performance. > > > Key: ZOOKEEPER-3399 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3399 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Michael Han >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Recently we have moved some of our production clusters to the top of the > trunk. One issue we found is a performance regression on read and write > latency on the clusters where the quorum is also serving traffic. The average > read latency increased by 50x, p99 read latency increased by 300x. > The root cause is a log statement introduced in ZOOKEEPER-3177 (PR711), where > we added a LOG.info statement in getGlobalOutstandingLimit. > getGlobalOutstandingLimit is on the critical code path for request processing > and for each request, it will be called twice (one at processing the packet, > one at finalizing the request response). This not only degrades performance > of the server, but also bloated the log file, when the QPS of a server is > high. > This only impacts clusters when the quorum (leader + follower) is serving > traffic. For clusters where only observers are serving traffic no impact is > observed. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-2694) sync CLI command does not wait for result from server
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847063#comment-16847063
]
Hudson commented on ZOOKEEPER-2694:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #535 (See
[https://builds.apache.org/job/ZooKeeper-trunk/535/])
ZOOKEEPER-2694: sync CLI command does not wait for result from server (andor:
rev e2bb6e80f598415bba975edcff166ff1bd750340)
* (edit) zookeeper-server/src/test/java/org/apache/zookeeper/ZooKeeperTest.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java
> sync CLI command does not wait for result from server
> -
>
> Key: ZOOKEEPER-2694
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2694
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
>Affects Versions: 3.5.0
>Reporter: Mohammad Arshad
>Assignee: maoling
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.6
>
> Attachments: ZOOKEEPER-2694-01.patch
>
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> sync CLI command does not wait for result from server. It returns immediately
> after invoking the sync's asynchronous API.
> Executing bellow command does not give the expected result
> {{/bin/zkCli.sh -server host:port sync /}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-2694) sync CLI command does not wait for result from server
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847025#comment-16847025
]
Hudson commented on ZOOKEEPER-2694:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #370 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/370/])
ZOOKEEPER-2694: sync CLI command does not wait for result from server (andor:
rev e2bb6e80f598415bba975edcff166ff1bd750340)
* (edit) zookeeper-server/src/test/java/org/apache/zookeeper/ZooKeeperTest.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/cli/SyncCommand.java
> sync CLI command does not wait for result from server
> -
>
> Key: ZOOKEEPER-2694
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2694
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
>Affects Versions: 3.5.0
>Reporter: Mohammad Arshad
>Assignee: maoling
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.6
>
> Attachments: ZOOKEEPER-2694-01.patch
>
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> sync CLI command does not wait for result from server. It returns immediately
> after invoking the sync's asynchronous API.
> Executing bellow command does not give the expected result
> {{/bin/zkCli.sh -server host:port sync /}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3311) Allow a delay to the transaction log flush
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846072#comment-16846072 ] Hudson commented on ZOOKEEPER-3311: --- FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #368 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/368/]) ZOOKEEPER-3311: Allow a delay to the transaction log flush (eolivelli: rev cc431f70020b9a2028edcc61e41cff9ee85b078f) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerBean.java * (edit) zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerMXBean.java > Allow a delay to the transaction log flush > --- > > Key: ZOOKEEPER-3311 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3311 > Project: ZooKeeper > Issue Type: New Feature > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2h > Remaining Estimate: 0h > > The SyncRequestProcessor flushes writes to disk either when 1000 writes are > pending to be flushed or when the processor fails to retrieve another write > from its incoming queue. The "flush when queue empty" condition operates > poorly under many workloads as it can quickly degrade into flushing after > every write -- losing all benefits of batching and leading to a continuous > stream of flushes + fsyncs which overwhelm the underlying disk. > > A configurable flush delay would ensure flushes do not happen more frequently > than once every X milliseconds. This can be used in-place of or jointly with > batch size triggered flushes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3311) Allow a delay to the transaction log flush
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845987#comment-16845987 ] Hudson commented on ZOOKEEPER-3311: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #533 (See [https://builds.apache.org/job/ZooKeeper-trunk/533/]) ZOOKEEPER-3311: Allow a delay to the transaction log flush (eolivelli: rev cc431f70020b9a2028edcc61e41cff9ee85b078f) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerMXBean.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerBean.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java * (edit) zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md > Allow a delay to the transaction log flush > --- > > Key: ZOOKEEPER-3311 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3311 > Project: ZooKeeper > Issue Type: New Feature > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2h > Remaining Estimate: 0h > > The SyncRequestProcessor flushes writes to disk either when 1000 writes are > pending to be flushed or when the processor fails to retrieve another write > from its incoming queue. The "flush when queue empty" condition operates > poorly under many workloads as it can quickly degrade into flushing after > every write -- losing all benefits of batching and leading to a continuous > stream of flushes + fsyncs which overwhelm the underlying disk. > > A configurable flush delay would ensure flushes do not happen more frequently > than once every X milliseconds. This can be used in-place of or jointly with > batch size triggered flushes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3323) Add TxnSnapLog metrics
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845643#comment-16845643 ] Hudson commented on ZOOKEEPER-3323: --- FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #367 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/367/]) ZOOKEEPER-3323: Add TxnSnapLog metrics (fangmin: rev d08f51ad1514bfa512597b1ce4bbc2e8144be576) * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/persistence/FileTxnSnapLogMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java > Add TxnSnapLog metrics > -- > > Key: ZOOKEEPER-3323 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3323 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 4h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3323) Add TxnSnapLog metrics
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845516#comment-16845516 ] Hudson commented on ZOOKEEPER-3323: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #532 (See [https://builds.apache.org/job/ZooKeeper-trunk/532/]) ZOOKEEPER-3323: Add TxnSnapLog metrics (fangmin: rev d08f51ad1514bfa512597b1ce4bbc2e8144be576) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/persistence/FileTxnSnapLogMetricsTest.java > Add TxnSnapLog metrics > -- > > Key: ZOOKEEPER-3323 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3323 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 4h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-1425) add version command to the zookeeper client shell
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844453#comment-16844453 ] Hudson commented on ZOOKEEPER-1425: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #365 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/365/]) ZOOKEEPER-1425: add version command to the zookeeper client shell (eolivelli: rev af59be25c564d34c6620cd931cd84ef5200aa1b3) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeperMain.java * (add) zookeeper-server/src/main/java/org/apache/zookeeper/cli/VersionCommand.java > add version command to the zookeeper client shell > - > > Key: ZOOKEEPER-1425 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1425 > Project: ZooKeeper > Issue Type: Improvement > Components: java client, scripts >Reporter: Patrick Hunt >Assignee: maoling >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-1425.patch > > Time Spent: 40m > Remaining Estimate: 0h > > the client shell is missing a version command. Should return the version e.g. > "3.5.0" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3378) Set the quorum cnxn timeout independently from syncLimit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844454#comment-16844454 ] Hudson commented on ZOOKEEPER-3378: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #365 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/365/]) ZOOKEEPER-3378: Set the quorum cnxn timeout independently from syncLimit (eolivelli: rev 6e9802b440b0c706a035a25aafe40b28d25dfadc) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java * (edit) zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md > Set the quorum cnxn timeout independently from syncLimit > > > Key: ZOOKEEPER-3378 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3378 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 20m > Remaining Estimate: 0h > > If an ensemble requires a high sync limit to support a large data tree or > transaction rate, it can cause the QuorumCxnManager to hang over-long in > response to quorum events. Using the sync limit for this timeout is a > convenience in terms of keeping all failure detection mechanisms in sync but > it is not strictly required for correct behavior. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3378) Set the quorum cnxn timeout independently from syncLimit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844392#comment-16844392 ] Hudson commented on ZOOKEEPER-3378: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #530 (See [https://builds.apache.org/job/ZooKeeper-trunk/530/]) ZOOKEEPER-3378: Set the quorum cnxn timeout independently from syncLimit (eolivelli: rev 6e9802b440b0c706a035a25aafe40b28d25dfadc) * (edit) zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java > Set the quorum cnxn timeout independently from syncLimit > > > Key: ZOOKEEPER-3378 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3378 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 20m > Remaining Estimate: 0h > > If an ensemble requires a high sync limit to support a large data tree or > transaction rate, it can cause the QuorumCxnManager to hang over-long in > response to quorum events. Using the sync limit for this timeout is a > convenience in terms of keeping all failure detection mechanisms in sync but > it is not strictly required for correct behavior. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-1425) add version command to the zookeeper client shell
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844391#comment-16844391 ] Hudson commented on ZOOKEEPER-1425: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #530 (See [https://builds.apache.org/job/ZooKeeper-trunk/530/]) ZOOKEEPER-1425: add version command to the zookeeper client shell (eolivelli: rev af59be25c564d34c6620cd931cd84ef5200aa1b3) * (add) zookeeper-server/src/main/java/org/apache/zookeeper/cli/VersionCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ZooKeeperMain.java > add version command to the zookeeper client shell > - > > Key: ZOOKEEPER-1425 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1425 > Project: ZooKeeper > Issue Type: Improvement > Components: java client, scripts >Reporter: Patrick Hunt >Assignee: maoling >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-1425.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > the client shell is missing a version command. Should return the version e.g. > "3.5.0" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3263) Illegal reflective access in zookeer's kerberosUtil
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844390#comment-16844390
]
Hudson commented on ZOOKEEPER-3263:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #530 (See
[https://builds.apache.org/job/ZooKeeper-trunk/530/])
ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in (eolivelli: rev
777f0c15e73a8401a648c3cff93d20b3d3e4ee17)
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerHandlerMetricsTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/util/SerializeUtilsTest.java
* (edit) ivy.xml
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/ClientReconnectTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LeaderBeanTest.java
* (edit) zookeeper-server/pom.xml
* (edit) build.xml
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepRequestProcessorMetricsTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/ConnectionMetricsTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/FinalRequestProcessorTest.java
* (edit) zookeeper-docs/pom.xml
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/util/KerberosUtil.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerHandlerTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/RemotePeerBeanTest.java
* (edit) pom.xml
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LocalPeerBeanTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/WatchLeakTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java
> Illegal reflective access in zookeer's kerberosUtil
> ---
>
> Key: ZOOKEEPER-3263
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3263
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.13
>Reporter: Pradeep Bansal
>Assignee: Andor Molnar
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> I am using kafka 2.11-2.1.0 with Java 11. Kafka is using zookeeper-3.4.13.jar
> and when am running kafka-acl script to maange ACLs, I am getting below
> warning. Is there a way to resolve this?
> {{WARNING: An illegal reflective access operation has occurred WARNING:
> Illegal reflective access by org.apache.zookeeper.server.util.KerberosUtil
> (file://apache/kafka/kafka_2.11-2.1.0/libs/zookeeper-3.4.13.jar) to method
> sun.security.krb5.Config.getInstance() WARNING: Please consider reporting
> this to the maintainers of org.apache.zookeeper.server.util.KerberosUtil
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations WARNING: All illegal access operations will be
> denied in a future release}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3263) Illegal reflective access in zookeer's kerberosUtil
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844304#comment-16844304
]
Hudson commented on ZOOKEEPER-3263:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #364 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/364/])
ZOOKEEPER-3263: JAVA9/11 Warnings: Illegal reflective access in (eolivelli: rev
777f0c15e73a8401a648c3cff93d20b3d3e4ee17)
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerHandlerTest.java
* (edit) zookeeper-docs/pom.xml
* (edit) ivy.xml
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepRequestProcessorMetricsTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LeaderBeanTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/util/SerializeUtilsTest.java
* (edit) zookeeper-server/pom.xml
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/FinalRequestProcessorTest.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/util/KerberosUtil.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/WatchLeakTest.java
* (edit) pom.xml
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerHandlerMetricsTest.java
* (edit) build.xml
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/ClientReconnectTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/ConnectionMetricsTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LocalPeerBeanTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/RemotePeerBeanTest.java
> Illegal reflective access in zookeer's kerberosUtil
> ---
>
> Key: ZOOKEEPER-3263
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3263
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.13
>Reporter: Pradeep Bansal
>Assignee: Andor Molnar
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> I am using kafka 2.11-2.1.0 with Java 11. Kafka is using zookeeper-3.4.13.jar
> and when am running kafka-acl script to maange ACLs, I am getting below
> warning. Is there a way to resolve this?
> {{WARNING: An illegal reflective access operation has occurred WARNING:
> Illegal reflective access by org.apache.zookeeper.server.util.KerberosUtil
> (file://apache/kafka/kafka_2.11-2.1.0/libs/zookeeper-3.4.13.jar) to method
> sun.security.krb5.Config.getInstance() WARNING: Please consider reporting
> this to the maintainers of org.apache.zookeeper.server.util.KerberosUtil
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations WARNING: All illegal access operations will be
> denied in a future release}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3396) Flaky test in RestoreCommittedLogTest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16844016#comment-16844016 ] Hudson commented on ZOOKEEPER-3396: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #363 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/363/]) ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest (andor: rev 1264e9f2ba8e8724a9352387b22e784716816722) * (edit) zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/RestoreCommittedLogTest.java > Flaky test in RestoreCommittedLogTest > - > > Key: ZOOKEEPER-3396 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3396 > Project: ZooKeeper > Issue Type: Improvement > Components: tests >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 50m > Remaining Estimate: 0h > > The patch for ZOOKEEPER-3244 ([https://github.com/apache/zookeeper/pull/770)] > introduced a flaky test > RestoreCommittedLogTest::testRestoreCommittedLogWithSnapSize. > > Get it running consistently. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3396) Flaky test in RestoreCommittedLogTest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843927#comment-16843927 ] Hudson commented on ZOOKEEPER-3396: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #529 (See [https://builds.apache.org/job/ZooKeeper-trunk/529/]) ZOOKEEPER-3396: Flaky test in RestoreCommittedLogTest (andor: rev 1264e9f2ba8e8724a9352387b22e784716816722) * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/RestoreCommittedLogTest.java * (edit) zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md > Flaky test in RestoreCommittedLogTest > - > > Key: ZOOKEEPER-3396 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3396 > Project: ZooKeeper > Issue Type: Improvement > Components: tests >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 50m > Remaining Estimate: 0h > > The patch for ZOOKEEPER-3244 ([https://github.com/apache/zookeeper/pull/770)] > introduced a flaky test > RestoreCommittedLogTest::testRestoreCommittedLogWithSnapSize. > > Get it running consistently. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3237) Allow IPv6 wildcard address in peer config
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841667#comment-16841667 ] Hudson commented on ZOOKEEPER-3237: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #524 (See [https://builds.apache.org/job/ZooKeeper-trunk/524/]) ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config (andor: rev 7ca06c2cbb77695ec33a3d3d2f04e00563ad) * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumServerTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java > Allow IPv6 wildcard address in peer config > -- > > Key: ZOOKEEPER-3237 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3237 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2.5h > Remaining Estimate: 0h > > ZooKeeper allows a special exception for the IPv4 wildcard, 0.0.0.0, along > with the loopback addresses. Extend the same treatment to IPv6's wildcard, > [::]. Otherwise, reconfig will reject commands with the form [::]:. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3237) Allow IPv6 wildcard address in peer config
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841521#comment-16841521 ] Hudson commented on ZOOKEEPER-3237: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #359 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/359/]) ZOOKEEPER-3237: Allow IPv6 wildcard address in peer config (andor: rev 7ca06c2cbb77695ec33a3d3d2f04e00563ad) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumServerTest.java > Allow IPv6 wildcard address in peer config > -- > > Key: ZOOKEEPER-3237 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3237 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2.5h > Remaining Estimate: 0h > > ZooKeeper allows a special exception for the IPv4 wildcard, 0.0.0.0, along > with the loopback addresses. Extend the same treatment to IPv6's wildcard, > [::]. Otherwise, reconfig will reject commands with the form [::]:. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3353) Admin commands for showing initial settings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840477#comment-16840477 ] Hudson commented on ZOOKEEPER-3353: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #522 (See [https://builds.apache.org/job/ZooKeeper-trunk/522/]) ZOOKEEPER-3353: Admin commands for showing initial settings (andor: rev e45551fc7c691332ace7bff81926855e42ac2239) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerMain.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/CommandBase.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Command.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerConfig.java > Admin commands for showing initial settings > --- > > Key: ZOOKEEPER-3353 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3353 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > It can be useful as a sysadmin to know the settings that were initially used > to configure a given ZooKeeper server. Some of these can be read from the > process logs and others from the java args in the process description but if, > for example, the zoo.cfg file used when starting a process up is overwritten > without the process itself being restarted then it can be difficult to know > exactly what is currently being run on the jvm. > Produce admin commands (and four-letter commands) to answer these questions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3353) Admin commands for showing initial settings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840369#comment-16840369 ] Hudson commented on ZOOKEEPER-3353: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #356 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/356/]) ZOOKEEPER-3353: Admin commands for showing initial settings (andor: rev e45551fc7c691332ace7bff81926855e42ac2239) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Command.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/CommandBase.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerConfig.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerMain.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java > Admin commands for showing initial settings > --- > > Key: ZOOKEEPER-3353 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3353 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > It can be useful as a sysadmin to know the settings that were initially used > to configure a given ZooKeeper server. Some of these can be read from the > process logs and others from the java args in the process description but if, > for example, the zoo.cfg file used when starting a process up is overwritten > without the process itself being restarted then it can be difficult to know > exactly what is currently being run on the jvm. > Produce admin commands (and four-letter commands) to answer these questions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3244) Add option to snapshot based on log size
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839806#comment-16839806 ] Hudson commented on ZOOKEEPER-3244: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #520 (See [https://builds.apache.org/job/ZooKeeper-trunk/520/]) ZOOKEEPER-3244: Add option to snapshot based on log size (andor: rev 31e92e0a4f287ca840e0c9418e3a9b706e9721db) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/TxnLog.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/RestoreCommittedLogTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java > Add option to snapshot based on log size > > > Key: ZOOKEEPER-3244 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3244 > Project: ZooKeeper > Issue Type: New Feature > Components: server >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > Currently, ZooKeeper only takes snapshot based on the snap count. If the > workload on an ensemble includes large txns then we'll end up with large > amount data kept on disk, and might have a low disk space issue. > Add a maximum limit on the total size of the log files between each snapshot. > This will change the snap frequency, which means with the same snap retention > number a server will eat up less disk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3244) Add option to snapshot based on log size
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839761#comment-16839761 ] Hudson commented on ZOOKEEPER-3244: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #355 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/355/]) ZOOKEEPER-3244: Add option to snapshot based on log size (andor: rev 31e92e0a4f287ca840e0c9418e3a9b706e9721db) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/RestoreCommittedLogTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java * (edit) zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/TxnLog.java > Add option to snapshot based on log size > > > Key: ZOOKEEPER-3244 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3244 > Project: ZooKeeper > Issue Type: New Feature > Components: server >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > Currently, ZooKeeper only takes snapshot based on the snap count. If the > workload on an ensemble includes large txns then we'll end up with large > amount data kept on disk, and might have a low disk space issue. > Add a maximum limit on the total size of the log files between each snapshot. > This will change the snap frequency, which means with the same snap retention > number a server will eat up less disk. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3383) Improve prep processor metric accuracy and de-flaky unit test
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837271#comment-16837271 ] Hudson commented on ZOOKEEPER-3383: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #350 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/350/]) ZOOKEEPER-3383: Improve prep processor metric accuracy and de-flaky u… (andor: rev 4243b95f4c1a0c6c6e9a6d78a789fae647d43b20) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepRequestProcessorMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java > Improve prep processor metric accuracy and de-flaky unit test > - > > Key: ZOOKEEPER-3383 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3383 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3383) Improve prep processor metric accuracy and de-flaky unit test
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837207#comment-16837207 ] Hudson commented on ZOOKEEPER-3383: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #515 (See [https://builds.apache.org/job/ZooKeeper-trunk/515/]) ZOOKEEPER-3383: Improve prep processor metric accuracy and de-flaky u… (andor: rev 4243b95f4c1a0c6c6e9a6d78a789fae647d43b20) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepRequestProcessorMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java > Improve prep processor metric accuracy and de-flaky unit test > - > > Key: ZOOKEEPER-3383 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3383 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3364) Compile with strict options in order to check code quality
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835988#comment-16835988
]
Hudson commented on ZOOKEEPER-3364:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #348 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/348/])
ZOOKEEPER-3364: Compile with strict options in order to check code (andor: rev
999c834714aba859a96ba32d02e66fb63e70ab35)
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/auth/QuorumKerberosHostBasedAuthTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/CnxManagerTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/watch/WatcherOrBitSetTest.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatchManagerFactory.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/JUnit4ZKTestRunner.java
* (edit) pom.xml
* (edit) zookeeper-server/src/test/java/org/apache/zookeeper/ZKTestCase.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/ReconfigMisconfigTest.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/metric/AvgMinMaxCounter.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/ReconfigTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java
* (edit) zookeeper-contrib/pom.xml
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/metrics/impl/MetricsProviderBootstrap.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/auth/MiniKdc.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/FourLetterWordsTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/LoadFromLogTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/InvalidSnapshotTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/SyncCallTest.java
> Compile with strict options in order to check code quality
> --
>
> Key: ZOOKEEPER-3364
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3364
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> In order to dismiss old QA tests based on ant (ZOOKEEPER-3351) we have to
> enforce code quality by activating some falgs on javac at build time, namely:
>
> {code:java}
>
> -Werror
> -Xlint:deprecation
> -Xlint:unchecked
>
> -Xpkginfo:always
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3364) Compile with strict options in order to check code quality
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835937#comment-16835937
]
Hudson commented on ZOOKEEPER-3364:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #512 (See
[https://builds.apache.org/job/ZooKeeper-trunk/512/])
ZOOKEEPER-3364: Compile with strict options in order to check code (andor: rev
999c834714aba859a96ba32d02e66fb63e70ab35)
* (edit) zookeeper-contrib/pom.xml
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/metrics/impl/MetricsProviderBootstrap.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/watch/WatcherOrBitSetTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/auth/QuorumKerberosHostBasedAuthTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/SyncCallTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/CnxManagerTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/LoadFromLogTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/JUnit4ZKTestRunner.java
* (edit) zookeeper-server/src/test/java/org/apache/zookeeper/ZKTestCase.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/FourLetterWordsTest.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/metric/AvgMinMaxCounter.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/ReconfigTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/InvalidSnapshotTest.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatchManagerFactory.java
* (edit) pom.xml
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/auth/MiniKdc.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/ReconfigMisconfigTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java
> Compile with strict options in order to check code quality
> --
>
> Key: ZOOKEEPER-3364
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3364
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> In order to dismiss old QA tests based on ant (ZOOKEEPER-3351) we have to
> enforce code quality by activating some falgs on javac at build time, namely:
>
> {code:java}
>
> -Werror
> -Xlint:deprecation
> -Xlint:unchecked
>
> -Xpkginfo:always
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3362) Create a simple checkstyle file
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835936#comment-16835936 ] Hudson commented on ZOOKEEPER-3362: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #512 (See [https://builds.apache.org/job/ZooKeeper-trunk/512/]) ZOOKEEPER-3362: Create a simple checkstyle file (andor: rev cb36d5a95fca6bc098890bde517ba76901adf43a) * (edit) zookeeper-assembly/src/main/assembly/source-package.xml * (edit) .travis.yml * (add) checkstyle.xml * (edit) zookeeper-contrib/zookeeper-contrib-zooinspector/src/main/java/com/nitido/utils/toaster/Toaster.java * (add) checkstyleSuppressions.xml * (edit) zookeeper-client/zookeeper-client-c/pom.xml * (edit) pom.xml > Create a simple checkstyle file > --- > > Key: ZOOKEEPER-3362 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3362 > Project: ZooKeeper > Issue Type: Task > Components: build >Affects Versions: 3.6.0 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > Create a basic checkstyle file, in order to cover the minimal check on > @author tags. > This is needed in order to drop old ANT based precommit job (see > ZOOKEEPER-3351) > We will not remove legacy checkstyle configuration file in > zookeeper-server/src/test/resources/checkstyle.xml because it is referred by > ANT build.xml files (even if we are not actually using that target). > This task won't add a complete checkstyle configuration with usual checks > because it would imply almost a change at every .java in the codebase. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3362) Create a simple checkstyle file
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835914#comment-16835914 ] Hudson commented on ZOOKEEPER-3362: --- FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #347 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/347/]) ZOOKEEPER-3362: Create a simple checkstyle file (andor: rev cb36d5a95fca6bc098890bde517ba76901adf43a) * (edit) pom.xml * (edit) zookeeper-assembly/src/main/assembly/source-package.xml * (add) checkstyleSuppressions.xml * (edit) zookeeper-contrib/zookeeper-contrib-zooinspector/src/main/java/com/nitido/utils/toaster/Toaster.java * (add) checkstyle.xml * (edit) zookeeper-client/zookeeper-client-c/pom.xml * (edit) .travis.yml > Create a simple checkstyle file > --- > > Key: ZOOKEEPER-3362 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3362 > Project: ZooKeeper > Issue Type: Task > Components: build >Affects Versions: 3.6.0 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 3h 50m > Remaining Estimate: 0h > > Create a basic checkstyle file, in order to cover the minimal check on > @author tags. > This is needed in order to drop old ANT based precommit job (see > ZOOKEEPER-3351) > We will not remove legacy checkstyle configuration file in > zookeeper-server/src/test/resources/checkstyle.xml because it is referred by > ANT build.xml files (even if we are not actually using that target). > This task won't add a complete checkstyle configuration with usual checks > because it would imply almost a change at every .java in the codebase. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3331) Automatically add IP authorization for Netty connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834148#comment-16834148 ] Hudson commented on ZOOKEEPER-3331: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #509 (See [https://builds.apache.org/job/ZooKeeper-trunk/509/]) ZOOKEEPER-3331: Automatically add IP authorization for Netty connections (fangmin: rev c67760523492b8da033c7bc0ea3076ab4acf1a93) * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/ACLTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java > Automatically add IP authorization for Netty connections > > > Key: ZOOKEEPER-3331 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3331 > Project: ZooKeeper > Issue Type: New Feature > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > NIOServerCnxn automatically adds the client's address as an auth token under > the "ip" scheme. Extend that functionality to the NettyServerCnxn as well to > bring parity to the two approaches. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3305) Add Quorum Packet metrics
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834147#comment-16834147 ] Hudson commented on ZOOKEEPER-3305: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #509 (See [https://builds.apache.org/job/ZooKeeper-trunk/509/]) ZOOKEEPER-3305: Add Quorum Packet metrics (fangmin: rev 3a25fe4b6c07937dc6859cafd94f3532b3a0befe) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerHandlerMetricsTest.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerHandlerTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java > Add Quorum Packet metrics > - > > Key: ZOOKEEPER-3305 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3305 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 3h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3331) Automatically add IP authorization for Netty connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834132#comment-16834132 ] Hudson commented on ZOOKEEPER-3331: --- FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #344 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/344/]) ZOOKEEPER-3331: Automatically add IP authorization for Netty connections (fangmin: rev c67760523492b8da033c7bc0ea3076ab4acf1a93) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/ACLTest.java > Automatically add IP authorization for Netty connections > > > Key: ZOOKEEPER-3331 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3331 > Project: ZooKeeper > Issue Type: New Feature > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Priority: Trivial > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > NIOServerCnxn automatically adds the client's address as an auth token under > the "ip" scheme. Extend that functionality to the NettyServerCnxn as well to > bring parity to the two approaches. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3305) Add Quorum Packet metrics
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834131#comment-16834131 ] Hudson commented on ZOOKEEPER-3305: --- FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #344 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/344/]) ZOOKEEPER-3305: Add Quorum Packet metrics (fangmin: rev 3a25fe4b6c07937dc6859cafd94f3532b3a0befe) * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerHandlerTest.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerHandlerMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java > Add Quorum Packet metrics > - > > Key: ZOOKEEPER-3305 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3305 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 3h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3343) Add a new doc: zookeeperTools.md
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832854#comment-16832854 ] Hudson commented on ZOOKEEPER-3343: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #340 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/340/]) ZOOKEEPER-3343: Add a new doc:zookeeperTools.md (andor: rev b6e45c3676030e69f6b006c4f400c5e375a15d09) * (edit) zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md * (edit) zookeeper-docs/src/main/resources/markdown/index.md * (add) zookeeper-docs/src/main/resources/markdown/zookeeperTools.md > Add a new doc: zookeeperTools.md > > > Key: ZOOKEEPER-3343 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3343 > Project: ZooKeeper > Issue Type: New Feature > Components: documentation >Affects Versions: 3.5.4 >Reporter: maoling >Assignee: maoling >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 50m > Remaining Estimate: 0h > > write zookeeper tools[3.7], which includes the: > - list all usages of the shells under the zookeeper/bin. (e.g > zkTxnLogToolkit.sh,zkCleanup.sh) > - benchmark tool > - backup tool > - test tools:jepsen -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3360) Misprint in WriteLock javadoc
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832855#comment-16832855
]
Hudson commented on ZOOKEEPER-3360:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #340 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/340/])
ZOOKEEPER-3360: Misprint in javadoc (andor: rev
5e0bb11d3428fa3459140a3e935af49006e7f2c1)
* (edit)
zookeeper-recipes/zookeeper-recipes-lock/src/main/java/org/apache/zookeeper/recipes/lock/WriteLock.java
> Misprint in WriteLock javadoc
> -
>
> Key: ZOOKEEPER-3360
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3360
> Project: ZooKeeper
> Issue Type: Improvement
> Components: recipes
>Affects Versions: 3.5.5
> Environment: Any
>Reporter: Igor Rudenko
>Priority: Trivial
> Labels: newbie, pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {code:java}
> * @param acls the acls that you want to use for all the paths,
> {code}
> {code:java}
> public WriteLock(ZooKeeper zookeeper, String dir, List acl){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3350) Get rid of CommonNames
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832856#comment-16832856
]
Hudson commented on ZOOKEEPER-3350:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #340 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/340/])
ZOOKEEPER-3350: Remove CommonNames (andor: rev
bee2ef8da3c4a7a2a1925ac8fc5375a7dee702ae)
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/ObserverMasterTest.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/jmx/MBeanRegistry.java
* (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/JMXEnv.java
* (delete)
zookeeper-server/src/main/java/org/apache/zookeeper/jmx/CommonNames.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/QuorumMajorityTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/ReconfigTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/HierarchicalQuorumTest.java
> Get rid of CommonNames
> --
>
> Key: ZOOKEEPER-3350
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3350
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx
>Affects Versions: 3.5.4
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Inside {{CommonNames}} it says {{TODO: will get rid of it eventually.}}.
> However, I don't see the reason of such removal and since it came from over
> ten years ago I'd like to know whether it is still valid.
> cc [~phunt] [~anmolnar]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3350) Get rid of CommonNames
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832793#comment-16832793
]
Hudson commented on ZOOKEEPER-3350:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #505 (See
[https://builds.apache.org/job/ZooKeeper-trunk/505/])
ZOOKEEPER-3350: Remove CommonNames (andor: rev
bee2ef8da3c4a7a2a1925ac8fc5375a7dee702ae)
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/ObserverMasterTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/ReconfigTest.java
* (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/JMXEnv.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/QuorumMajorityTest.java
* (delete)
zookeeper-server/src/main/java/org/apache/zookeeper/jmx/CommonNames.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/jmx/MBeanRegistry.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/HierarchicalQuorumTest.java
> Get rid of CommonNames
> --
>
> Key: ZOOKEEPER-3350
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3350
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx
>Affects Versions: 3.5.4
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Inside {{CommonNames}} it says {{TODO: will get rid of it eventually.}}.
> However, I don't see the reason of such removal and since it came from over
> ten years ago I'd like to know whether it is still valid.
> cc [~phunt] [~anmolnar]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3343) Add a new doc: zookeeperTools.md
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832791#comment-16832791 ] Hudson commented on ZOOKEEPER-3343: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #505 (See [https://builds.apache.org/job/ZooKeeper-trunk/505/]) ZOOKEEPER-3343: Add a new doc:zookeeperTools.md (andor: rev b6e45c3676030e69f6b006c4f400c5e375a15d09) * (edit) zookeeper-docs/src/main/resources/markdown/index.md * (edit) zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md * (add) zookeeper-docs/src/main/resources/markdown/zookeeperTools.md > Add a new doc: zookeeperTools.md > > > Key: ZOOKEEPER-3343 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3343 > Project: ZooKeeper > Issue Type: New Feature > Components: documentation >Affects Versions: 3.5.4 >Reporter: maoling >Assignee: maoling >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 50m > Remaining Estimate: 0h > > write zookeeper tools[3.7], which includes the: > - list all usages of the shells under the zookeeper/bin. (e.g > zkTxnLogToolkit.sh,zkCleanup.sh) > - benchmark tool > - backup tool > - test tools:jepsen -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3360) Misprint in WriteLock javadoc
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832792#comment-16832792
]
Hudson commented on ZOOKEEPER-3360:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #505 (See
[https://builds.apache.org/job/ZooKeeper-trunk/505/])
ZOOKEEPER-3360: Misprint in javadoc (andor: rev
5e0bb11d3428fa3459140a3e935af49006e7f2c1)
* (edit)
zookeeper-recipes/zookeeper-recipes-lock/src/main/java/org/apache/zookeeper/recipes/lock/WriteLock.java
> Misprint in WriteLock javadoc
> -
>
> Key: ZOOKEEPER-3360
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3360
> Project: ZooKeeper
> Issue Type: Improvement
> Components: recipes
>Affects Versions: 3.5.5
> Environment: Any
>Reporter: Igor Rudenko
>Priority: Trivial
> Labels: newbie, pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {code:java}
> * @param acls the acls that you want to use for all the paths,
> {code}
> {code:java}
> public WriteLock(ZooKeeper zookeeper, String dir, List acl){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3319) Add metrics for follower and observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832157#comment-16832157 ] Hudson commented on ZOOKEEPER-3319: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #504 (See [https://builds.apache.org/job/ZooKeeper-trunk/504/]) ZOOKEEPER-3319: Add metrics for follower and observer (fangmin: rev 36bca12d5e70f96de4701aa2fd41979ff8128a1f) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Follower.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Observer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/SendAckRequestProcessor.java > Add metrics for follower and observer > - > > Key: ZOOKEEPER-3319 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3319 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3319) Add metrics for follower and observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832146#comment-16832146 ] Hudson commented on ZOOKEEPER-3319: --- FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #338 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/338/]) ZOOKEEPER-3319: Add metrics for follower and observer (fangmin: rev 36bca12d5e70f96de4701aa2fd41979ff8128a1f) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/SendAckRequestProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Follower.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Observer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/LearnerMetricsTest.java > Add metrics for follower and observer > - > > Key: ZOOKEEPER-3319 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3319 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3020) Review of SyncRequestProcessor
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830798#comment-16830798
]
Hudson commented on ZOOKEEPER-3020:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #502 (See
[https://builds.apache.org/job/ZooKeeper-trunk/502/])
ZOOKEEPER-3020: Review of SyncRequestProcessor (andor: rev
876aaf42ea721776b82633bb769f8813e881a444)
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java
> Review of SyncRequestProcessor
> --
>
> Key: ZOOKEEPER-3020
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3020
> Project: ZooKeeper
> Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER.3020.1.patch
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> # Use {{ArrayDeque}} instead of {{LinkedList}}
> # Use {{ThreadLocalRandom}} instead of {{Random}}
> # Remove the 'running' flag - use the {{Thread#join}} facility to detect if
> the thread has stopped running. Using a flag can cause race condition issues
> and is superfluous.
> # Make static final variable names in all caps
> # General cleanup
> {quote}
> This class is likely to be faster than Stack when used as a stack, and faster
> than LinkedList when used as a queue.
> {quote}
> https://docs.oracle.com/javase/7/docs/api/java/util/ArrayDeque.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3020) Review of SyncRequestProcessor
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830675#comment-16830675
]
Hudson commented on ZOOKEEPER-3020:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #335 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/335/])
ZOOKEEPER-3020: Review of SyncRequestProcessor (andor: rev
876aaf42ea721776b82633bb769f8813e881a444)
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/SyncRequestProcessor.java
> Review of SyncRequestProcessor
> --
>
> Key: ZOOKEEPER-3020
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3020
> Project: ZooKeeper
> Issue Type: Improvement
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Minor
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER.3020.1.patch
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> # Use {{ArrayDeque}} instead of {{LinkedList}}
> # Use {{ThreadLocalRandom}} instead of {{Random}}
> # Remove the 'running' flag - use the {{Thread#join}} facility to detect if
> the thread has stopped running. Using a flag can cause race condition issues
> and is superfluous.
> # Make static final variable names in all caps
> # General cleanup
> {quote}
> This class is likely to be faster than Stack when used as a stack, and faster
> than LinkedList when used as a queue.
> {quote}
> https://docs.oracle.com/javase/7/docs/api/java/util/ArrayDeque.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3306) Node may not accessible due the the inconsistent ACL reference map after SNAP sync
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829798#comment-16829798 ] Hudson commented on ZOOKEEPER-3306: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #334 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/334/]) ZOOKEEPER-3306: Fixing node not accessible issue due the inconsistent (andor: rev 46b2018dbe008e010462e0dc06ddb73981d19d2a) * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java > Node may not accessible due the the inconsistent ACL reference map after SNAP > sync > --- > > Key: ZOOKEEPER-3306 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3306 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.4, 3.6.0, 3.4.13 >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Critical > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > This is a new bug we found on production. > ZooKeeper uses ACL reference id and count to save the space in snapshot. > During fuzzy snapshot sync, the reference count may not be updated correctly > in case like the znode is already exist. > When ACL reference count reaches 0, it will be deleted from the system, but > actually there might be other nodes still using it. And when visiting a node > with the deleted ACL id, it will be rejected because it doesn't exist anymore. > Here is the detailed flow for one of the scenario here: > # Server A starts to have snap sync with leader > # After serializing the ACL map to Server A, there is a txn T1 to create a > node N1 with new ACL_1 which was not exist in ACL map > # On leader, after this txn, the ACL map will be ID1 -> (ACL_1, COUNT: 1), > and data tree N1 -> ID1 > # On server A, it will be empty ACL map, and N1 -> ID1 in fuzzy snapshot > # When replaying the txn T1, it will skip at the beginning since the node is > already exist, which leaves an empty ACL map, and N1 is referencing to a > non-exist ACL ID1 > # Node N1 will be not accessible because the ACL not exist, and if it became > leader later then all the write requests will be rejected as well with > marshalling error. > We're still working on the fix, suggestions are welcome. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3306) Node may not accessible due the the inconsistent ACL reference map after SNAP sync
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829568#comment-16829568 ] Hudson commented on ZOOKEEPER-3306: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #500 (See [https://builds.apache.org/job/ZooKeeper-trunk/500/]) ZOOKEEPER-3306: Fixing node not accessible issue due the inconsistent (andor: rev 46b2018dbe008e010462e0dc06ddb73981d19d2a) * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java > Node may not accessible due the the inconsistent ACL reference map after SNAP > sync > --- > > Key: ZOOKEEPER-3306 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3306 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.4, 3.6.0, 3.4.13 >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Critical > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > This is a new bug we found on production. > ZooKeeper uses ACL reference id and count to save the space in snapshot. > During fuzzy snapshot sync, the reference count may not be updated correctly > in case like the znode is already exist. > When ACL reference count reaches 0, it will be deleted from the system, but > actually there might be other nodes still using it. And when visiting a node > with the deleted ACL id, it will be rejected because it doesn't exist anymore. > Here is the detailed flow for one of the scenario here: > # Server A starts to have snap sync with leader > # After serializing the ACL map to Server A, there is a txn T1 to create a > node N1 with new ACL_1 which was not exist in ACL map > # On leader, after this txn, the ACL map will be ID1 -> (ACL_1, COUNT: 1), > and data tree N1 -> ID1 > # On server A, it will be empty ACL map, and N1 -> ID1 in fuzzy snapshot > # When replaying the txn T1, it will skip at the beginning since the node is > already exist, which leaves an empty ACL map, and N1 is referencing to a > non-exist ACL ID1 > # Node N1 will be not accessible because the ACL not exist, and if it became > leader later then all the write requests will be rejected as well with > marshalling error. > We're still working on the fix, suggestions are welcome. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3372) Cleanup pom.xml in order to let Maven clients import as few dependencies as possible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829567#comment-16829567 ] Hudson commented on ZOOKEEPER-3372: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #500 (See [https://builds.apache.org/job/ZooKeeper-trunk/500/]) ZOOKEEPER-3372: Cleanup pom.xml in order to let Maven clients import as (andor: rev b787770b9920a7ae99f9ed2dbe583ece1b2665cc) * (edit) zookeeper-contrib/zookeeper-contrib-zooinspector/pom.xml * (edit) zookeeper-recipes/pom.xml * (edit) .travis.yml * (edit) zookeeper-contrib/zookeeper-contrib-loggraph/pom.xml * (edit) pom.xml * (edit) zookeeper-recipes/zookeeper-recipes-election/pom.xml * (edit) zookeeper-docs/pom.xml * (edit) zookeeper-assembly/pom.xml * (edit) zookeeper-recipes/zookeeper-recipes-lock/pom.xml * (edit) zookeeper-recipes/zookeeper-recipes-queue/pom.xml * (edit) zookeeper-contrib/zookeeper-contrib-rest/pom.xml * (edit) zookeeper-assembly/src/main/assembly/bin-package.xml * (edit) zookeeper-server/pom.xml > Cleanup pom.xml in order to let Maven clients import as few dependencies as > possible > > > Key: ZOOKEEPER-3372 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3372 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.6.0, 3.5.5 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > ZooKeeper client application imports a lot of third party dependencies that > are automatically applied to maven client applications, that is applications > that are using the 'client'. > This task is to clean up the final resulting pom of the main artifact > consumed by "clients" as much as possible. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3372) Cleanup pom.xml in order to let Maven clients import as few dependencies as possible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829291#comment-16829291 ] Hudson commented on ZOOKEEPER-3372: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #333 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/333/]) ZOOKEEPER-3372: Cleanup pom.xml in order to let Maven clients import as (andor: rev b787770b9920a7ae99f9ed2dbe583ece1b2665cc) * (edit) zookeeper-contrib/zookeeper-contrib-rest/pom.xml * (edit) zookeeper-docs/pom.xml * (edit) zookeeper-contrib/zookeeper-contrib-loggraph/pom.xml * (edit) zookeeper-contrib/zookeeper-contrib-zooinspector/pom.xml * (edit) .travis.yml * (edit) zookeeper-assembly/src/main/assembly/bin-package.xml * (edit) zookeeper-recipes/zookeeper-recipes-queue/pom.xml * (edit) zookeeper-recipes/zookeeper-recipes-election/pom.xml * (edit) zookeeper-recipes/zookeeper-recipes-lock/pom.xml * (edit) zookeeper-assembly/pom.xml * (edit) zookeeper-recipes/pom.xml * (edit) pom.xml * (edit) zookeeper-server/pom.xml > Cleanup pom.xml in order to let Maven clients import as few dependencies as > possible > > > Key: ZOOKEEPER-3372 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3372 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.6.0, 3.5.5 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0, 3.5.5 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > ZooKeeper client application imports a lot of third party dependencies that > are automatically applied to maven client applications, that is applications > that are using the 'client'. > This task is to clean up the final resulting pom of the main artifact > consumed by "clients" as much as possible. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3268) Add commit processor metrics
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825799#comment-16825799 ] Hudson commented on ZOOKEEPER-3268: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #327 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/327/]) ZOOKEEPER-3268: Add commit processor metrics (fangmin: rev cb9727dc5b6f37984fef5f62473ae4064a9f15cb) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/CommitProcessorMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/CommitProcessor.java > Add commit processor metrics > > > Key: ZOOKEEPER-3268 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3268 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 7h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3268) Add commit processor metrics
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825663#comment-16825663 ] Hudson commented on ZOOKEEPER-3268: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #495 (See [https://builds.apache.org/job/ZooKeeper-trunk/495/]) ZOOKEEPER-3268: Add commit processor metrics (fangmin: rev cb9727dc5b6f37984fef5f62473ae4064a9f15cb) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/CommitProcessorMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/CommitProcessor.java > Add commit processor metrics > > > Key: ZOOKEEPER-3268 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3268 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 7h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3369) Maven release artifacts cleanup
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825536#comment-16825536 ] Hudson commented on ZOOKEEPER-3369: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #493 (See [https://builds.apache.org/job/ZooKeeper-trunk/493/]) ZOOKEEPER-3369: Maven release artifacts cleanup (andor: rev a2aecb9acc420c95f60b6649ffcbd4e0184cc0cd) * (edit) pom.xml * (edit) zookeeper-assembly/src/main/assembly/bin-package.xml * (add) zookeeper-server/src/main/resources/lib/netty-all-4.1.29.Final.LICENSE.txt * (edit) README.md * (edit) zookeeper-assembly/pom.xml * (edit) zookeeper-docs/pom.xml > Maven release artifacts cleanup > --- > > Key: ZOOKEEPER-3369 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3369 > Project: ZooKeeper > Issue Type: Improvement > Components: build >Affects Versions: 3.6.0, 3.5.5 >Reporter: Norbert Kalmar >Assignee: Norbert Kalmar >Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > - Change source tarball name from > zookeeper-3.5.5-source-package.tar.gz > to > apache-zookeeper-3.5.5.tar.gz > - After unpacking the tarballs the top level dir should match the archive's > name. > - missing api docs after mvn clean install and from binary package. Fix > readme on this: > "Full documentation for this release can also be found in docs/index.html" > Perhaps we should have a general README and a binary specific readme? > - Correct "The release artifact contains the following jar files in > "dist-maven" directory" - no dist-maven dir anymore. > - Include license file for netty-all-4.1.29.Final.jar -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3369) Maven release artifacts cleanup
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825525#comment-16825525 ] Hudson commented on ZOOKEEPER-3369: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #326 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/326/]) ZOOKEEPER-3369: Maven release artifacts cleanup (andor: rev a2aecb9acc420c95f60b6649ffcbd4e0184cc0cd) * (edit) README.md * (add) zookeeper-server/src/main/resources/lib/netty-all-4.1.29.Final.LICENSE.txt * (edit) zookeeper-assembly/pom.xml * (edit) pom.xml * (edit) zookeeper-docs/pom.xml * (edit) zookeeper-assembly/src/main/assembly/bin-package.xml > Maven release artifacts cleanup > --- > > Key: ZOOKEEPER-3369 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3369 > Project: ZooKeeper > Issue Type: Improvement > Components: build >Affects Versions: 3.6.0, 3.5.5 >Reporter: Norbert Kalmar >Assignee: Norbert Kalmar >Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > - Change source tarball name from > zookeeper-3.5.5-source-package.tar.gz > to > apache-zookeeper-3.5.5.tar.gz > - After unpacking the tarballs the top level dir should match the archive's > name. > - missing api docs after mvn clean install and from binary package. Fix > readme on this: > "Full documentation for this release can also be found in docs/index.html" > Perhaps we should have a general README and a binary specific readme? > - Correct "The release artifact contains the following jar files in > "dist-maven" directory" - no dist-maven dir anymore. > - Include license file for netty-all-4.1.29.Final.jar -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3326) Add session/connection related metrics
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823531#comment-16823531 ] Hudson commented on ZOOKEEPER-3326: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #490 (See [https://builds.apache.org/job/ZooKeeper-trunk/490/]) ZOOKEEPER-3326: Add session/connection related metrics (fangmin: rev d8db88914e7af7c11a2588be202d90b925791d31) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/ConnectionMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/SessionTrackerImpl.java > Add session/connection related metrics > -- > > Key: ZOOKEEPER-3326 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3326 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3326) Add session/connection related metrics
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823330#comment-16823330 ] Hudson commented on ZOOKEEPER-3326: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #323 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/323/]) ZOOKEEPER-3326: Add session/connection related metrics (fangmin: rev d8db88914e7af7c11a2588be202d90b925791d31) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/ConnectionMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/SessionTrackerImpl.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java > Add session/connection related metrics > -- > > Key: ZOOKEEPER-3326 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3326 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3037) Add JvmPauseMonitor to ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821463#comment-16821463 ] Hudson commented on ZOOKEEPER-3037: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #484 (See [https://builds.apache.org/job/ZooKeeper-trunk/484/]) ZOOKEEPER-3037: Add JVMPauseMonitor (andor: rev e9adf6ee09ef18258653d65c851fa84c3cd1a51d) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerConfig.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/ServerConfigTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerMain.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerMain.java * (add) zookeeper-server/src/main/java/org/apache/zookeeper/server/util/JvmPauseMonitor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/util/JvmPauseMonitorTest.java > Add JvmPauseMonitor to ZooKeeper > > > Key: ZOOKEEPER-3037 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3037 > Project: ZooKeeper > Issue Type: Improvement > Components: contrib >Affects Versions: 3.5.3, 3.4.12 >Reporter: Norbert Kalmar >Assignee: Norbert Kalmar >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > After a ZK crash, or client timeout sometimes it's hard to determine from the > logs what happened. Knowing if ZK was responsive at the time would help a > lot. For example, ZK might spend a lot of time waiting on GC (there is still > some misconception that ZK is a storage). > To help detect this, HADOOP already has a great tool called JVM Pause > Monitor. (As the name suggest, it can be also used for monitoring, but it > also helps post-mortem in a lot of cases). Basically it has a daemon that > sleeps for one second, and if the sleep time exceeds the 1s by more than the > threshold (1s: INFO, 10s: WARN by default - this can be configurable in our > case, see below), it will alert/make a log entry. It can also monitor the > time GC took. > The class implementing this is in HADOOP-common, but ZK should not depend on > this package. Since this is a straightforward implementation, and in the past > five years the few commits it had is nothing really serious, I think we could > just copy this class in ZooKeeper, and introduce it as a configurable > feature, by default it can be off. > The class: > https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java > Task: > - Create a class in ZK (under zookeeper/server/util/) called JvmPauseMonitor. > - Make feature configurable, by default: OFF > - Make sleep time and threshold time configurable > - Update documentation > - Add [current size of the heap OR % of heap used] in the log entry whenever > sleep threshold had exceeded by a lot (10s) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3037) Add JvmPauseMonitor to ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821415#comment-16821415 ] Hudson commented on ZOOKEEPER-3037: --- FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #318 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/318/]) ZOOKEEPER-3037: Add JVMPauseMonitor (andor: rev e9adf6ee09ef18258653d65c851fa84c3cd1a51d) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerMain.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/util/JvmPauseMonitorTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerMain.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java * (add) zookeeper-server/src/main/java/org/apache/zookeeper/server/util/JvmPauseMonitor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerConfig.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/ServerConfigTest.java > Add JvmPauseMonitor to ZooKeeper > > > Key: ZOOKEEPER-3037 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3037 > Project: ZooKeeper > Issue Type: Improvement > Components: contrib >Affects Versions: 3.5.3, 3.4.12 >Reporter: Norbert Kalmar >Assignee: Norbert Kalmar >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > After a ZK crash, or client timeout sometimes it's hard to determine from the > logs what happened. Knowing if ZK was responsive at the time would help a > lot. For example, ZK might spend a lot of time waiting on GC (there is still > some misconception that ZK is a storage). > To help detect this, HADOOP already has a great tool called JVM Pause > Monitor. (As the name suggest, it can be also used for monitoring, but it > also helps post-mortem in a lot of cases). Basically it has a daemon that > sleeps for one second, and if the sleep time exceeds the 1s by more than the > threshold (1s: INFO, 10s: WARN by default - this can be configurable in our > case, see below), it will alert/make a log entry. It can also monitor the > time GC took. > The class implementing this is in HADOOP-common, but ZK should not depend on > this package. Since this is a straightforward implementation, and in the past > five years the few commits it had is nothing really serious, I think we could > just copy this class in ZooKeeper, and introduce it as a configurable > feature, by default it can be off. > The class: > https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java > Task: > - Create a class in ZK (under zookeeper/server/util/) called JvmPauseMonitor. > - Make feature configurable, by default: OFF > - Make sleep time and threshold time configurable > - Update documentation > - Add [current size of the heap OR % of heap used] in the log entry whenever > sleep threshold had exceeded by a lot (10s) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3310) Add metrics for prep processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820194#comment-16820194 ] Hudson commented on ZOOKEEPER-3310: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #316 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/316/]) Revert "ZOOKEEPER-3310: Add metrics for prep processor" (andor: rev 8cc3d5e2a9b0900984f09b873aa810c563399069) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java * (delete) zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepRequestProcessorMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java ZOOKEEPER-3310: Add metrics for prep processor (andor: rev ff47fc3dfda3487ca3a5aca2ea16831b2aebc7e2) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepRequestProcessorMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java > Add metrics for prep processor > -- > > Key: ZOOKEEPER-3310 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3310 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 5.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3310) Add metrics for prep processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820088#comment-16820088 ] Hudson commented on ZOOKEEPER-3310: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #482 (See [https://builds.apache.org/job/ZooKeeper-trunk/482/]) Revert "ZOOKEEPER-3310: Add metrics for prep processor" (andor: rev 8cc3d5e2a9b0900984f09b873aa810c563399069) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java * (delete) zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepRequestProcessorMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java ZOOKEEPER-3310: Add metrics for prep processor (andor: rev ff47fc3dfda3487ca3a5aca2ea16831b2aebc7e2) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepRequestProcessorMetricsTest.java > Add metrics for prep processor > -- > > Key: ZOOKEEPER-3310 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3310 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 5.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3310) Add metrics for prep processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819876#comment-16819876 ] Hudson commented on ZOOKEEPER-3310: --- FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #315 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/315/]) ZOOKEEPER-3310: Add metrics for prep processor (andor: rev e57e7a371da9ba6161fa06c29683679f4271e346) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepRequestProcessorMetricsTest.java > Add metrics for prep processor > -- > > Key: ZOOKEEPER-3310 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3310 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 4h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3310) Add metrics for prep processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16819874#comment-16819874 ] Hudson commented on ZOOKEEPER-3310: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #481 (See [https://builds.apache.org/job/ZooKeeper-trunk/481/]) ZOOKEEPER-3310: Add metrics for prep processor (andor: rev e57e7a371da9ba6161fa06c29683679f4271e346) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepRequestProcessorMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java > Add metrics for prep processor > -- > > Key: ZOOKEEPER-3310 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3310 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 4h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3310) Add metrics for prep processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817457#comment-16817457 ] Hudson commented on ZOOKEEPER-3310: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #477 (See [https://builds.apache.org/job/ZooKeeper-trunk/477/]) Revert "ZOOKEEPER-3310: Add metrics for prep processor" (andor: rev 3d2a30f5fed9cc77f84c0d27d80020656f21fc06) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java * (delete) zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepRequestProcessorMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java > Add metrics for prep processor > -- > > Key: ZOOKEEPER-3310 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3310 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 4h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3310) Add metrics for prep processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817421#comment-16817421 ] Hudson commented on ZOOKEEPER-3310: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #312 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/312/]) Revert "ZOOKEEPER-3310: Add metrics for prep processor" (andor: rev 3d2a30f5fed9cc77f84c0d27d80020656f21fc06) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java * (delete) zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepRequestProcessorMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java > Add metrics for prep processor > -- > > Key: ZOOKEEPER-3310 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3310 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 4h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3310) Add metrics for prep processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817317#comment-16817317 ] Hudson commented on ZOOKEEPER-3310: --- FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #311 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/311/]) ZOOKEEPER-3310: Add metrics for prep processor (andor: rev bbc39c42bba74add9a625adca3ee52fb1cd02335) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepRequestProcessorMetricsTest.java > Add metrics for prep processor > -- > > Key: ZOOKEEPER-3310 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3310 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 3h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3310) Add metrics for prep processor
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817315#comment-16817315 ] Hudson commented on ZOOKEEPER-3310: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #476 (See [https://builds.apache.org/job/ZooKeeper-trunk/476/]) ZOOKEEPER-3310: Add metrics for prep processor (andor: rev bbc39c42bba74add9a625adca3ee52fb1cd02335) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/PrepRequestProcessorMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/Request.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java > Add metrics for prep processor > -- > > Key: ZOOKEEPER-3310 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3310 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 3h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3332) TxnLogToolkit should print multi transactions readably
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816811#comment-16816811
]
Hudson commented on ZOOKEEPER-3332:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #474 (See
[https://builds.apache.org/job/ZooKeeper-trunk/474/])
ZOOKEEPER-3332: TxnLogToolkit should print multi transactions readably (andor:
rev 4b01c9374586423a96cc8ba1cdf707fe77880cf9)
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/LogFormatter.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/TxnLogToolkit.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/TraceFormatter.java
> TxnLogToolkit should print multi transactions readably
> --
>
> Key: ZOOKEEPER-3332
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3332
> Project: ZooKeeper
> Issue Type: Improvement
>Reporter: Toshihiro Suzuki
>Assignee: maoling
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently, LogFormatter shows multi transactions like the following and it's
> not readable:
> {code:java}
> 3/23/19 7:35:21 AM UTC session 0x3699141c4080020 cxid 0x21 zxid 0x102d9
> multi
> v{s{1,#000292f726d73746f72652f5a4b524d5374617465526f6f742f524d5f5a4b5f46454e43494e475f4c4f434b00010001f0005776f726c640006616e796f6e651c},s{5,#000312f726d73746f72652f5a4b524d5374617465526f6f742f414d524d546f6b656e5365637265744d616e61676572526f6f7400012a108ffe0fffdff92fff15128fff5ff9a731174ffa8ff86ffb40009},s{2,#000292f726d73746f72652f5a4b524d5374617465526f6f742f524d5f5a4b5f46454e43494e475f4c4f434b}}
> {code}
> Like delete and setData as the following, LogFormatter should print multi
> transactions readably:
> {code:java}
> 3/22/19 7:20:48 AM UTC session 0x2699141c3f70022 cxid 0x885 zxid 0x102cc
> delete '/hbase-unsecure/region-in-transition/d6694b5f7ec2c45f6096fe373c8a34bc
> 3/22/19 7:20:50 AM UTC session 0x2699141c3f70024 cxid 0x47 zxid 0x102cd
> setData
> '/hbase-unsecure/region-in-transition/a9c6dac76ce74812196667ebc01dad51,#0001a726567696f6e7365727665723a313630323035617afffa42ff94ffe81f5042554684123f53595354454d2e434154414c4f472c2c313535333233313233393533352e61396336646163373663653734383132313936363637656263303164616435312e18ffe9ffa8ff98ffa2ff9a2d2228a1c633132362d6e6f6465342e7371756164726f6e2d6c6162732e636f6d10ff947d18ffcbff96ffa2ff9a2d,2
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3348) Make TxnLog and TxnLog Iterator Closable
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816810#comment-16816810 ] Hudson commented on ZOOKEEPER-3348: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #474 (See [https://builds.apache.org/job/ZooKeeper-trunk/474/]) ZOOKEEPER-3348: Make TxnLog and TxnLog Iterator Closable (andor: rev a6abb9315bd8309a98393b406ed9f593d4fa25f2) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/TxnLog.java > Make TxnLog and TxnLog Iterator Closable > > > Key: ZOOKEEPER-3348 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3348 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 40m > Remaining Estimate: 0h > > [https://docs.oracle.com/javase/7/docs/api/java/io/Closeable.html] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816812#comment-16816812
]
Hudson commented on ZOOKEEPER-3351:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #474 (See
[https://builds.apache.org/job/ZooKeeper-trunk/474/])
ZOOKEEPER-3351: Fix findBugs and rat check, add filename to sha (andor: rev
d719b68d5a1076f963a7c11722b384d506221f5c)
* (edit) pom.xml
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/Version.java
> Migrate qa-test-pullrequest ant task to maven
> -
>
> Key: ZOOKEEPER-3351
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3351
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.5.5
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> In order to drop ANT we have to migrate task qa-test-pullrequest to Maven.
> That task is currently called this way in ASF Jenkins:
> {code:java}
> #!/bin/bash
> set +x
> #export JAVA_HOME=/home/jenkins/tools/java/jdk1.7.0-64
> export ANT_HOME=/home/jenkins/tools/ant/apache-ant-1.9.9
> #export PATH=$PATH:$JAVA_HOME/bin:$ANT_HOME/bin:
> export PATH=$PATH:$LATEST1_8_HOME/bin:$ANT_HOME/bin:
> export PATCH_DIR=${WORKSPACE}/patchprocess
> if [ ! -e "$PATCH_DIR" ] ; then
> mkdir -p $PATCH_DIR
> fi
> pwd
> git status
> git rev-parse HEAD
> which java
> java -version
> ulimit -a
> env
> ${ANT_HOME}/bin/ant \
> -Dpatch.file=foobar \
> -Dscratch.dir=$PATCH_DIR \
> -Dps.cmd=/bin/ps \
> -Dwget.cmd=/usr/bin/wget \
> -Djiracli.cmd=/home/jenkins/tools/jiracli/latest/jira.sh \
> -Dgit.cmd=/usr/bin/git \
> -Dgrep.cmd=/bin/grep \
> -Dpatch.cmd=/usr/bin/patch \
> -Dfindbugs.home=/home/jenkins/tools/findbugs/latest/ \
> -Dforrest.home=/home/jenkins/tools/forrest/latest/ \
> -Djira.passwd= \
> -Djava5.home=/home/jenkins/tools/java5/latest/ \
> -Dcurl.cmd=/usr/bin/curl \
> -Dtest.junit.maxmem=2g \
> qa-test-pullrequest{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3143) Pluggable metrics system for ZooKeeper - Data Collection on Server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816809#comment-16816809 ] Hudson commented on ZOOKEEPER-3143: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #474 (See [https://builds.apache.org/job/ZooKeeper-trunk/474/]) ZOOKEEPER-3143: Pluggable metrics system for ZooKeeper - Data Collection (andor: rev f69ad1b0fed88da3c1b67fd73031e7248c0564f7) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/watch/WatcherCleanerTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/Zab1_0Test.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperCriticalThread.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/metrics/impl/NullMetricsProvider.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/metrics/Counter.java * (add) zookeeper-server/src/main/java/org/apache/zookeeper/metrics/impl/DefaultMetricsProvider.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/command/MonitorCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/metrics/MetricsProvider.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Follower.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/DataTreeTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/metrics/Summary.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/NonRecoverableErrorTest.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/metrics/MetricsUtils.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java * (add) zookeeper-server/src/main/java/org/apache/zookeeper/metrics/SummarySet.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/metrics/MetricsContext.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/watch/WatchManagerTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/ServerMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/auth/EnsembleAuthenticationProvider.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerMain.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatchManagerOptimized.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatchManager.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/metrics/BaseTestMetricsProvider.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/metric/SimpleCounter.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/metric/AvgMinMaxPercentileCounter.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/metric/AvgMinMaxPercentileCounterSet.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/metric/AvgMinMaxCounter.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/admin/CommandsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerConfig.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerMain.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/ZooKeeperCriticalThreadMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerStats.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/metric/AvgMinM
[jira] [Commented] (ZOOKEEPER-3348) Make TxnLog and TxnLog Iterator Closable
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816766#comment-16816766 ] Hudson commented on ZOOKEEPER-3348: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #308 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/308/]) ZOOKEEPER-3348: Make TxnLog and TxnLog Iterator Closable (andor: rev a6abb9315bd8309a98393b406ed9f593d4fa25f2) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/TxnLog.java > Make TxnLog and TxnLog Iterator Closable > > > Key: ZOOKEEPER-3348 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3348 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 40m > Remaining Estimate: 0h > > [https://docs.oracle.com/javase/7/docs/api/java/io/Closeable.html] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3332) TxnLogToolkit should print multi transactions readably
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816767#comment-16816767
]
Hudson commented on ZOOKEEPER-3332:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #308 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/308/])
ZOOKEEPER-3332: TxnLogToolkit should print multi transactions readably (andor:
rev 4b01c9374586423a96cc8ba1cdf707fe77880cf9)
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/TraceFormatter.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/LogFormatter.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/TxnLogToolkit.java
> TxnLogToolkit should print multi transactions readably
> --
>
> Key: ZOOKEEPER-3332
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3332
> Project: ZooKeeper
> Issue Type: Improvement
>Reporter: Toshihiro Suzuki
>Assignee: maoling
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently, LogFormatter shows multi transactions like the following and it's
> not readable:
> {code:java}
> 3/23/19 7:35:21 AM UTC session 0x3699141c4080020 cxid 0x21 zxid 0x102d9
> multi
> v{s{1,#000292f726d73746f72652f5a4b524d5374617465526f6f742f524d5f5a4b5f46454e43494e475f4c4f434b00010001f0005776f726c640006616e796f6e651c},s{5,#000312f726d73746f72652f5a4b524d5374617465526f6f742f414d524d546f6b656e5365637265744d616e61676572526f6f7400012a108ffe0fffdff92fff15128fff5ff9a731174ffa8ff86ffb40009},s{2,#000292f726d73746f72652f5a4b524d5374617465526f6f742f524d5f5a4b5f46454e43494e475f4c4f434b}}
> {code}
> Like delete and setData as the following, LogFormatter should print multi
> transactions readably:
> {code:java}
> 3/22/19 7:20:48 AM UTC session 0x2699141c3f70022 cxid 0x885 zxid 0x102cc
> delete '/hbase-unsecure/region-in-transition/d6694b5f7ec2c45f6096fe373c8a34bc
> 3/22/19 7:20:50 AM UTC session 0x2699141c3f70024 cxid 0x47 zxid 0x102cd
> setData
> '/hbase-unsecure/region-in-transition/a9c6dac76ce74812196667ebc01dad51,#0001a726567696f6e7365727665723a313630323035617afffa42ff94ffe81f5042554684123f53595354454d2e434154414c4f472c2c313535333233313233393533352e61396336646163373663653734383132313936363637656263303164616435312e18ffe9ffa8ff98ffa2ff9a2d2228a1c633132362d6e6f6465342e7371756164726f6e2d6c6162732e636f6d10ff947d18ffcbff96ffa2ff9a2d,2
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3143) Pluggable metrics system for ZooKeeper - Data Collection on Server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816765#comment-16816765 ] Hudson commented on ZOOKEEPER-3143: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #308 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/308/]) ZOOKEEPER-3143: Pluggable metrics system for ZooKeeper - Data Collection (andor: rev f69ad1b0fed88da3c1b67fd73031e7248c0564f7) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Follower.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/DataTreeTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/auth/EnsembleAuthenticationProvider.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/metric/AvgMinMaxCounter.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/metric/AvgMinMaxPercentileCounter.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerStats.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/metrics/MetricsContext.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxn.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/metric/AvgMinMaxCounterSet.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/ServerMetricsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/admin/CommandsTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/command/MonitorCommand.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LearnerHandler.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/ResponseCacheTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/metrics/impl/NullMetricsProvider.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/quorum/Zab1_0Test.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatchManager.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/metrics/BaseTestMetricsProvider.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/watch/WatchManagerTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerMain.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/metric/SimpleCounter.java * (add) zookeeper-server/src/test/java/org/apache/zookeeper/metrics/MetricsUtils.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/metrics/MetricsProvider.java * (add) zookeeper-server/src/main/java/org/apache/zookeeper/metrics/SummarySet.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatchManagerOptimized.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/metrics/Summary.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/admin/Commands.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerConfig.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperCriticalThread.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/metrics/Counter.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerMain.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/FinalRequestProcessor.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/watch/WatcherCleanerTest.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/NonRecoverableErrorTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Leader.java * (add) zookeeper-server/src/main/java/org/apache/zookeeper/metrics/impl/DefaultMetricsProvider.java
[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816768#comment-16816768
]
Hudson commented on ZOOKEEPER-3351:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #308 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/308/])
ZOOKEEPER-3351: Fix findBugs and rat check, add filename to sha (andor: rev
d719b68d5a1076f963a7c11722b384d506221f5c)
* (edit) pom.xml
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/Version.java
> Migrate qa-test-pullrequest ant task to maven
> -
>
> Key: ZOOKEEPER-3351
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3351
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.5.5
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> In order to drop ANT we have to migrate task qa-test-pullrequest to Maven.
> That task is currently called this way in ASF Jenkins:
> {code:java}
> #!/bin/bash
> set +x
> #export JAVA_HOME=/home/jenkins/tools/java/jdk1.7.0-64
> export ANT_HOME=/home/jenkins/tools/ant/apache-ant-1.9.9
> #export PATH=$PATH:$JAVA_HOME/bin:$ANT_HOME/bin:
> export PATH=$PATH:$LATEST1_8_HOME/bin:$ANT_HOME/bin:
> export PATCH_DIR=${WORKSPACE}/patchprocess
> if [ ! -e "$PATCH_DIR" ] ; then
> mkdir -p $PATCH_DIR
> fi
> pwd
> git status
> git rev-parse HEAD
> which java
> java -version
> ulimit -a
> env
> ${ANT_HOME}/bin/ant \
> -Dpatch.file=foobar \
> -Dscratch.dir=$PATCH_DIR \
> -Dps.cmd=/bin/ps \
> -Dwget.cmd=/usr/bin/wget \
> -Djiracli.cmd=/home/jenkins/tools/jiracli/latest/jira.sh \
> -Dgit.cmd=/usr/bin/git \
> -Dgrep.cmd=/bin/grep \
> -Dpatch.cmd=/usr/bin/patch \
> -Dfindbugs.home=/home/jenkins/tools/findbugs/latest/ \
> -Dforrest.home=/home/jenkins/tools/forrest/latest/ \
> -Djira.passwd= \
> -Djava5.home=/home/jenkins/tools/java5/latest/ \
> -Dcurl.cmd=/usr/bin/curl \
> -Dtest.junit.maxmem=2g \
> qa-test-pullrequest{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3324) Add read/write metrics for top level znodes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816399#comment-16816399 ] Hudson commented on ZOOKEEPER-3324: --- FAILURE: Integrated in Jenkins build Zookeeper-trunk-single-thread #307 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/307/]) ZOOKEEPER-3324: Add read/write metrics for top level znodes (andor: rev ff132ab9dd3dd83df1dbfae5bc9f0cc53f6a4d45) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/DataTreeTest.java > Add read/write metrics for top level znodes > --- > > Key: ZOOKEEPER-3324 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3324 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > These metrics provide bytes read from each branch under the root and bytes > written to each branch under the root. We use top level znodes not only to > manage applications that share an ensemble but also to organize data on a > dedicated ensemble. These metrics help us to do quota management, ACL > management, etc at the top znode level. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3324) Add read/write metrics for top level znodes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816174#comment-16816174 ] Hudson commented on ZOOKEEPER-3324: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #473 (See [https://builds.apache.org/job/ZooKeeper-trunk/473/]) ZOOKEEPER-3324: Add read/write metrics for top level znodes (andor: rev ff132ab9dd3dd83df1dbfae5bc9f0cc53f6a4d45) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/DataTreeTest.java > Add read/write metrics for top level znodes > --- > > Key: ZOOKEEPER-3324 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3324 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Reporter: Jie Huang >Assignee: Jie Huang >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > These metrics provide bytes read from each branch under the root and bytes > written to each branch under the root. We use top level znodes not only to > manage applications that share an ensemble but also to organize data on a > dedicated ensemble. These metrics help us to do quota management, ACL > management, etc at the top znode level. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3179) Add snapshot compression to reduce the disk IO
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814633#comment-16814633 ] Hudson commented on ZOOKEEPER-3179: --- SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #470 (See [https://builds.apache.org/job/ZooKeeper-trunk/470/]) ZOOKEEPER-3179: Add snapshot compression to reduce the disk IO (andor: rev 73cdd09051df33189351f7c42131724e3270eeac) * (edit) ivy.xml * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/persistence/SnapStreamTest.java * (add) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/SnapStream.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/SnapshotFormatter.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileSnap.java * (edit) build.xml * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/Util.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/ZooKeeperServerTest.java * (edit) zookeeper-server/pom.xml > Add snapshot compression to reduce the disk IO > -- > > Key: ZOOKEEPER-3179 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3179 > Project: ZooKeeper > Issue Type: Improvement >Reporter: Fangmin Lv >Assignee: Yisong Yue >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 4h 40m > Remaining Estimate: 0h > > When the snapshot becomes larger, the periodically snapshot after certain > number of txns will be more expensive. Which will in turn affect the maximum > throughput we can support within SLA, because of the disk contention between > snapshot and txn when they're on the same drive. > > With compression like zstd/snappy/gzip, the actual snapshot size could be > much smaller, the compress ratio depends on the actual data. It might make > the recovery time (loading from disk) faster in some cases, but will take > longer sometimes because of the extra time used to compress/decompress. > > Based on the production traffic, the performance various with different > compress method as well, that's why we provided different implementations, we > can select different compress method for different use cases. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3179) Add snapshot compression to reduce the disk IO
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814596#comment-16814596 ] Hudson commented on ZOOKEEPER-3179: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #305 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/305/]) ZOOKEEPER-3179: Add snapshot compression to reduce the disk IO (andor: rev 73cdd09051df33189351f7c42131724e3270eeac) * (add) zookeeper-server/src/test/java/org/apache/zookeeper/server/persistence/SnapStreamTest.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/server/ZooKeeperServerTest.java * (edit) build.xml * (edit) ivy.xml * (edit) zookeeper-server/pom.xml * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/SnapshotFormatter.java * (add) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/SnapStream.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/Util.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileSnap.java > Add snapshot compression to reduce the disk IO > -- > > Key: ZOOKEEPER-3179 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3179 > Project: ZooKeeper > Issue Type: Improvement >Reporter: Fangmin Lv >Assignee: Yisong Yue >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 4h 40m > Remaining Estimate: 0h > > When the snapshot becomes larger, the periodically snapshot after certain > number of txns will be more expensive. Which will in turn affect the maximum > throughput we can support within SLA, because of the disk contention between > snapshot and txn when they're on the same drive. > > With compression like zstd/snappy/gzip, the actual snapshot size could be > much smaller, the compress ratio depends on the actual data. It might make > the recovery time (loading from disk) faster in some cases, but will take > longer sometimes because of the extra time used to compress/decompress. > > Based on the production traffic, the performance various with different > compress method as well, that's why we provided different implementations, we > can select different compress method for different use cases. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3314) Document the possibility of MultiCallback receiving a null pointer
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813930#comment-16813930
]
Hudson commented on ZOOKEEPER-3314:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #469 (See
[https://builds.apache.org/job/ZooKeeper-trunk/469/])
ZOOKEEPER-3314: Document the possibility of MultiCallback receiving a (andor:
rev 9a7cebb96a8fe810fbeea18d911212076424feaa)
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/AsyncCallback.java
> Document the possibility of MultiCallback receiving a null pointer
> --
>
> Key: ZOOKEEPER-3314
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3314
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.7, 3.4.8, 3.4.9, 3.4.10, 3.5.0, 3.5.1, 3.5.2, 3.5.3,
> 3.4.11, 3.5.4, 3.4.12, 3.4.13
>Reporter: Steven McDonald
>Assignee: Steven McDonald
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Attachments:
> 0001-Document-the-case-where-opResults-is-null-in-multi-c.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> A {{MultiCallback}} can receive a null pointer on failure, rather than a list
> of {{org.apache.zookeeper.OpResult.ErrorResult}} as documented. This is
> evident from [the
> implementation|https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java#L689].
> This causes NullPointerExceptions in Kafka 2.1.x (see
> [KAFKA-7898|https://issues.apache.org/jira/browse/KAFKA-7898]). Kafka 2.0.x
> does not use the async multi interface, and Kafka 2.2.x handles the null
> pointer case.
> However, this is enough of a hazard that it should be documented. I have a
> patch for that which I will try to attach in a moment (JIRA won't allow me to
> attach it now for some reason).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3335) Improve the usage of Collections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813931#comment-16813931 ] Hudson commented on ZOOKEEPER-3335: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #469 (See [https://builds.apache.org/job/ZooKeeper-trunk/469/]) ZOOKEEPER-3335: Improve the usage of Collections (andor: rev 57e8318bc98dd3563085e08b0fcfcbc6a1c5fbcc) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocket.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/CommitProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNIO.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/RestoreCommittedLogTest.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java > Improve the usage of Collections > > > Key: ZOOKEEPER-3335 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3335 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2h > Remaining Estimate: 0h > > bq. This class is likely to be faster than Stack when used as a stack, and > faster than LinkedList when used as a queue. > https://docs.oracle.com/javase/7/docs/api/java/util/ArrayDeque.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3122) Verify build after maven migration and the end artifact
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813928#comment-16813928 ] Hudson commented on ZOOKEEPER-3122: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #469 (See [https://builds.apache.org/job/ZooKeeper-trunk/469/]) ZOOKEEPER-3122: fix files included in tarballs (andor: rev 1e8286faed13e8d8abb2d5205f99440853e4b47d) * (edit) zookeeper-assembly/src/main/assembly/bin-package.xml * (edit) zookeeper-assembly/src/main/assembly/source-package.xml ZOOKEEPER-3122: add missing pom to source tarball (andor: rev 915c6acaea3f5c01d26f0bff93d1897a4da3e32c) * (edit) zookeeper-assembly/src/main/assembly/source-package.xml > Verify build after maven migration and the end artifact > --- > > Key: ZOOKEEPER-3122 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3122 > Project: ZooKeeper > Issue Type: Sub-task > Components: build, scripts >Affects Versions: 3.6.0 >Reporter: Norbert Kalmar >Assignee: Norbert Kalmar >Priority: Major > Labels: pull-request-available > Fix For: 3.4.14 > > Time Spent: 11.5h > Remaining Estimate: 0h > > Verify maven build works as expected, scripts (release, precommit, jenkins, > reports etc) work with maven. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3341) Remove Superfluous ByteBuffer Duplicate
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813932#comment-16813932
]
Hudson commented on ZOOKEEPER-3341:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #469 (See
[https://builds.apache.org/job/ZooKeeper-trunk/469/])
ZOOKEEPER-3341: Remove Superfluous ByteBuffer Duplicate (andor: rev
6dc61adbe41c712fbce930e598b3556da54e0667)
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
> Remove Superfluous ByteBuffer Duplicate
> ---
>
> Key: ZOOKEEPER-3341
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3341
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {code:java|title=QuorumCnxManager.java}
> byte[] msgArray = new byte[length];
> din.readFully(msgArray, 0, length);
> ByteBuffer message = ByteBuffer.wrap(msgArray);
> addToRecvQueue(new Message(message.duplicate(), sid));
> {code}
> The {{message}} is being duplicated and the original is GC'ed. Just pass the
> {{message}}; do not bother with making a duplicate. I think this is a
> copy+paste bug.
> https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L1195-L1198
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3302) ZooKeeper C client does not compile on Fedora 29
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813927#comment-16813927
]
Hudson commented on ZOOKEEPER-3302:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #469 (See
[https://builds.apache.org/job/ZooKeeper-trunk/469/])
ZOOKEEPER-3302: ZooKeeper C client does not compile on Fedora 29 (andor: rev
450869006e0f62790e974305eb079e1b0450dbfd)
* (edit) zookeeper-client/zookeeper-client-c/src/cli.c
> ZooKeeper C client does not compile on Fedora 29
> -
>
> Key: ZOOKEEPER-3302
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3302
> Project: ZooKeeper
> Issue Type: Wish
> Components: c client
>Affects Versions: 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> I cannot build current master (git sha
> 372e713a9d2d9264417313e5d68e9437ffddd0f5) with Fedora 29
>
> {noformat}
> gcc --version
> gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2)
> {noformat}
>
> This is the error:
> {code:java}
> [exec] gcc -DHAVE_CONFIG_H -I.
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/include
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/tests
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/generated
> -Wall -Werror -Wdeclaration-after-statement -fprofile-arcs -ftest-coverage
> -g -O2 -D_GNU_SOURCE -MT cli.o -MD -MP -MF .deps/cli.Tpo -c -o cli.o `test -f
> 'src/cli.c' || echo
> '/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/'`src/cli.c
> [exec]
> /home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/src/cli.c:
> In function ‘main’:
> [exec]
> /home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/src/cli.c:689:9:
> error: ‘strncpy’ specified bound 1024 equals destination size
> [-Werror=stringop-truncation]
> [exec] strncpy(cmd, argv[2]+4, sizeof(cmd));
> [exec] ^~~~
> [exec] cc1: all warnings being treated as errors
> [exec] make: *** [Makefile:1155: cli.o] Error 1{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-2609) Add TTL Node APIs to C client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813929#comment-16813929 ] Hudson commented on ZOOKEEPER-2609: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #469 (See [https://builds.apache.org/job/ZooKeeper-trunk/469/]) ZOOKEEPER-2609: Add TTL Node APIs to C client (andor: rev 3b93f7671464bef1824288b13ee66dec547bb97e) * (edit) zookeeper-client/zookeeper-client-c/src/zookeeper.c * (edit) zookeeper-client/zookeeper-client-c/include/zookeeper.h * (edit) zookeeper-client/zookeeper-client-c/tests/zkServer.sh * (edit) zookeeper-client/zookeeper-client-c/src/cli.c * (edit) zookeeper-client/zookeeper-client-c/tests/TestClient.cc * (edit) zookeeper-client/zookeeper-client-c/include/proto.h > Add TTL Node APIs to C client > - > > Key: ZOOKEEPER-2609 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2609 > Project: ZooKeeper > Issue Type: Sub-task > Components: c client, java client, jute, server >Reporter: Jordan Zimmerman >Assignee: Balazs Meszaros >Priority: Major > Labels: pull-request-available, ttl_nodes > Fix For: 3.6.0, 3.5.6 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Need to update the C lib to have the TTL node option -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3335) Improve the usage of Collections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813840#comment-16813840 ] Hudson commented on ZOOKEEPER-3335: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #304 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/304/]) ZOOKEEPER-3335: Improve the usage of Collections (andor: rev 57e8318bc98dd3563085e08b0fcfcbc6a1c5fbcc) * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocket.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/ZKDatabase.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/CommitProcessor.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNIO.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/ZKUtil.java * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java * (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/RestoreCommittedLogTest.java > Improve the usage of Collections > > > Key: ZOOKEEPER-3335 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3335 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: David Mollitor >Assignee: David Mollitor >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 2h > Remaining Estimate: 0h > > bq. This class is likely to be faster than Stack when used as a stack, and > faster than LinkedList when used as a queue. > https://docs.oracle.com/javase/7/docs/api/java/util/ArrayDeque.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-2609) Add TTL Node APIs to C client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813838#comment-16813838 ] Hudson commented on ZOOKEEPER-2609: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #304 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/304/]) ZOOKEEPER-2609: Add TTL Node APIs to C client (andor: rev 3b93f7671464bef1824288b13ee66dec547bb97e) * (edit) zookeeper-client/zookeeper-client-c/src/zookeeper.c * (edit) zookeeper-client/zookeeper-client-c/tests/TestClient.cc * (edit) zookeeper-client/zookeeper-client-c/include/proto.h * (edit) zookeeper-client/zookeeper-client-c/include/zookeeper.h * (edit) zookeeper-client/zookeeper-client-c/src/cli.c * (edit) zookeeper-client/zookeeper-client-c/tests/zkServer.sh > Add TTL Node APIs to C client > - > > Key: ZOOKEEPER-2609 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2609 > Project: ZooKeeper > Issue Type: Sub-task > Components: c client, java client, jute, server >Reporter: Jordan Zimmerman >Assignee: Balazs Meszaros >Priority: Major > Labels: pull-request-available, ttl_nodes > Fix For: 3.6.0, 3.5.6 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Need to update the C lib to have the TTL node option -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3122) Verify build after maven migration and the end artifact
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813837#comment-16813837 ] Hudson commented on ZOOKEEPER-3122: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #304 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/304/]) ZOOKEEPER-3122: fix files included in tarballs (andor: rev 1e8286faed13e8d8abb2d5205f99440853e4b47d) * (edit) zookeeper-assembly/src/main/assembly/source-package.xml * (edit) zookeeper-assembly/src/main/assembly/bin-package.xml ZOOKEEPER-3122: add missing pom to source tarball (andor: rev 915c6acaea3f5c01d26f0bff93d1897a4da3e32c) * (edit) zookeeper-assembly/src/main/assembly/source-package.xml > Verify build after maven migration and the end artifact > --- > > Key: ZOOKEEPER-3122 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3122 > Project: ZooKeeper > Issue Type: Sub-task > Components: build, scripts >Affects Versions: 3.6.0 >Reporter: Norbert Kalmar >Assignee: Norbert Kalmar >Priority: Major > Labels: pull-request-available > Fix For: 3.4.14 > > Time Spent: 11.5h > Remaining Estimate: 0h > > Verify maven build works as expected, scripts (release, precommit, jenkins, > reports etc) work with maven. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3314) Document the possibility of MultiCallback receiving a null pointer
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813839#comment-16813839
]
Hudson commented on ZOOKEEPER-3314:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #304 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/304/])
ZOOKEEPER-3314: Document the possibility of MultiCallback receiving a (andor:
rev 9a7cebb96a8fe810fbeea18d911212076424feaa)
* (edit) zookeeper-server/src/main/java/org/apache/zookeeper/AsyncCallback.java
> Document the possibility of MultiCallback receiving a null pointer
> --
>
> Key: ZOOKEEPER-3314
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3314
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.7, 3.4.8, 3.4.9, 3.4.10, 3.5.0, 3.5.1, 3.5.2, 3.5.3,
> 3.4.11, 3.5.4, 3.4.12, 3.4.13
>Reporter: Steven McDonald
>Assignee: Steven McDonald
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Attachments:
> 0001-Document-the-case-where-opResults-is-null-in-multi-c.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> A {{MultiCallback}} can receive a null pointer on failure, rather than a list
> of {{org.apache.zookeeper.OpResult.ErrorResult}} as documented. This is
> evident from [the
> implementation|https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java#L689].
> This causes NullPointerExceptions in Kafka 2.1.x (see
> [KAFKA-7898|https://issues.apache.org/jira/browse/KAFKA-7898]). Kafka 2.0.x
> does not use the async multi interface, and Kafka 2.2.x handles the null
> pointer case.
> However, this is enough of a hazard that it should be documented. I have a
> patch for that which I will try to attach in a moment (JIRA won't allow me to
> attach it now for some reason).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3341) Remove Superfluous ByteBuffer Duplicate
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813841#comment-16813841
]
Hudson commented on ZOOKEEPER-3341:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #304 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/304/])
ZOOKEEPER-3341: Remove Superfluous ByteBuffer Duplicate (andor: rev
6dc61adbe41c712fbce930e598b3556da54e0667)
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
> Remove Superfluous ByteBuffer Duplicate
> ---
>
> Key: ZOOKEEPER-3341
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3341
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {code:java|title=QuorumCnxManager.java}
> byte[] msgArray = new byte[length];
> din.readFully(msgArray, 0, length);
> ByteBuffer message = ByteBuffer.wrap(msgArray);
> addToRecvQueue(new Message(message.duplicate(), sid));
> {code}
> The {{message}} is being duplicated and the original is GC'ed. Just pass the
> {{message}}; do not bother with making a duplicate. I think this is a
> copy+paste bug.
> https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L1195-L1198
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3302) ZooKeeper C client does not compile on Fedora 29
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813836#comment-16813836
]
Hudson commented on ZOOKEEPER-3302:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #304 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/304/])
ZOOKEEPER-3302: ZooKeeper C client does not compile on Fedora 29 (andor: rev
450869006e0f62790e974305eb079e1b0450dbfd)
* (edit) zookeeper-client/zookeeper-client-c/src/cli.c
> ZooKeeper C client does not compile on Fedora 29
> -
>
> Key: ZOOKEEPER-3302
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3302
> Project: ZooKeeper
> Issue Type: Wish
> Components: c client
>Affects Versions: 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Blocker
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> I cannot build current master (git sha
> 372e713a9d2d9264417313e5d68e9437ffddd0f5) with Fedora 29
>
> {noformat}
> gcc --version
> gcc (GCC) 8.3.1 20190223 (Red Hat 8.3.1-2)
> {noformat}
>
> This is the error:
> {code:java}
> [exec] gcc -DHAVE_CONFIG_H -I.
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/include
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/tests
> -I/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/generated
> -Wall -Werror -Wdeclaration-after-statement -fprofile-arcs -ftest-coverage
> -g -O2 -D_GNU_SOURCE -MT cli.o -MD -MP -MF .deps/cli.Tpo -c -o cli.o `test -f
> 'src/cli.c' || echo
> '/home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/'`src/cli.c
> [exec]
> /home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/src/cli.c:
> In function ‘main’:
> [exec]
> /home/eolivelli/dev/zookeeper/zookeeper-client/zookeeper-client-c/src/cli.c:689:9:
> error: ‘strncpy’ specified bound 1024 equals destination size
> [-Werror=stringop-truncation]
> [exec] strncpy(cmd, argv[2]+4, sizeof(cmd));
> [exec] ^~~~
> [exec] cc1: all warnings being treated as errors
> [exec] make: *** [Makefile:1155: cli.o] Error 1{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
