[jira] [Commented] (ZOOKEEPER-2379) recent commit broke findbugs qabot check
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181386#comment-15181386 ] Hudson commented on ZOOKEEPER-2379: --- FAILURE: Integrated in ZooKeeper-trunk #2841 (See [https://builds.apache.org/job/ZooKeeper-trunk/2841/]) ZOOKEEPER-2379: recent commit broke findbugs qabot check (rakeshr via cnauroth) (cnauroth: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1733679]) * trunk/CHANGES.txt * trunk/src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java > recent commit broke findbugs qabot check > > > Key: ZOOKEEPER-2379 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2379 > Project: ZooKeeper > Issue Type: Bug > Components: build >Affects Versions: 3.4.9, 3.5.2, 3.6.0 >Reporter: Patrick Hunt >Assignee: Rakesh R >Priority: Blocker > Fix For: 3.4.9, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2379.patch > > > A recent commit seems to have broken findbugs, looks like it's in > ZooKeeperSaslClient > see: > https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3075//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2373) Licenses section missing from pom file
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178662#comment-15178662
]
Hudson commented on ZOOKEEPER-2373:
---
FAILURE: Integrated in ZooKeeper-trunk #2840 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2840/])
ZOOKEEPER-2373 Licenses section missing from pom file - part 2 missed an added
file (phunt) (phunt:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1733525])
* trunk/src/pom.template
> Licenses section missing from pom file
> --
>
> Key: ZOOKEEPER-2373
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2373
> Project: ZooKeeper
> Issue Type: Improvement
>Reporter: Flavio Junqueira
>Assignee: Patrick Hunt
>Priority: Blocker
> Fix For: 3.4.9, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2373.patch
>
>
> The pom file here:
> https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.8/zookeeper-3.4.8.pom
> should have a section like this:
> {noformat}
>
>
> The Apache Software License, Version 2.0
> http://www.apache.org/licenses/LICENSE-2.0.txt
>
> repo
>
>
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2378) upgrade ivy to recent version
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178289#comment-15178289 ] Hudson commented on ZOOKEEPER-2378: --- FAILURE: Integrated in ZooKeeper-trunk #2838 (See [https://builds.apache.org/job/ZooKeeper-trunk/2838/]) ZOOKEEPER-2378 upgrade ivy to recent version (phunt) (phunt: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1733505]) * trunk/build.xml > upgrade ivy to recent version > - > > Key: ZOOKEEPER-2378 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2378 > Project: ZooKeeper > Issue Type: Improvement > Components: build >Affects Versions: 3.4.8, 3.5.1, 3.6.0 >Reporter: Patrick Hunt >Assignee: Patrick Hunt >Priority: Critical > Fix For: 3.4.9, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2378.patch > > > 2.4.0 is the current version. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2294) Ant target generate-clover-reports is broken
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178290#comment-15178290 ] Hudson commented on ZOOKEEPER-2294: --- FAILURE: Integrated in ZooKeeper-trunk #2838 (See [https://builds.apache.org/job/ZooKeeper-trunk/2838/]) ZOOKEEPER-2294 Ant target generate-clover-reports is broken (charlie via phunt) (phunt: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1733499]) * trunk/build.xml > Ant target generate-clover-reports is broken > > > Key: ZOOKEEPER-2294 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2294 > Project: ZooKeeper > Issue Type: Bug > Components: build >Reporter: Charlie Helin >Assignee: Charlie Helin > Fix For: 3.4.9, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2294.001.patch > > > It appears that the current implementation of 'generate-clover-reports' is > broken. > # It doesn't define the clover-report task > # The clover-report element is missing the proper clover db reference -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2373) Licenses section missing from pom file
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178291#comment-15178291
]
Hudson commented on ZOOKEEPER-2373:
---
FAILURE: Integrated in ZooKeeper-trunk #2838 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2838/])
ZOOKEEPER-2373 Licenses section missing from pom file (phunt) (phunt:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1733508])
* trunk/build.xml
> Licenses section missing from pom file
> --
>
> Key: ZOOKEEPER-2373
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2373
> Project: ZooKeeper
> Issue Type: Improvement
>Reporter: Flavio Junqueira
>Assignee: Patrick Hunt
>Priority: Blocker
> Fix For: 3.4.9, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2373.patch
>
>
> The pom file here:
> https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.8/zookeeper-3.4.8.pom
> should have a section like this:
> {noformat}
>
>
> The Apache Software License, Version 2.0
> http://www.apache.org/licenses/LICENSE-2.0.txt
>
> repo
>
>
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1604) remove rpm/deb/... packaging
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178069#comment-15178069 ] Hudson commented on ZOOKEEPER-1604: --- FAILURE: Integrated in ZooKeeper-trunk #2836 (See [https://builds.apache.org/job/ZooKeeper-trunk/2836/]) ZOOKEEPER-1604 remove rpm/deb/... packaging (cnauroth via phunt) (phunt: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1733489]) * trunk/README_packaging.txt * trunk/build.xml * trunk/ivy.xml * trunk/src/contrib/build-contrib.xml * trunk/src/contrib/build.xml * trunk/src/contrib/zkpython/build.xml * trunk/src/contrib/zkpython/ivy.xml * trunk/src/contrib/zkpython/src/packages * trunk/src/packages * trunk/src/recipes/build-recipes.xml * trunk/src/recipes/build.xml > remove rpm/deb/... packaging > > > Key: ZOOKEEPER-1604 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1604 > Project: ZooKeeper > Issue Type: Task > Components: build >Affects Versions: 3.3.0 >Reporter: Patrick Hunt >Assignee: Chris Nauroth > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-1604.001.patch, ZOOKEEPER-1604.patch > > > Remove rpm/deb/... packaging from our source repo. Now that BigTop is > available and fully supporting ZK it's no longer necessary for us to attempt > to include this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1991) zkServer.sh returns with a zero exit status when a ZooKeeper process is already running
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176367#comment-15176367 ] Hudson commented on ZOOKEEPER-1991: --- SUCCESS: Integrated in ZooKeeper-trunk #2835 (See [https://builds.apache.org/job/ZooKeeper-trunk/2835/]) ZOOKEEPER-1991 zkServer.sh returns with a zero exit status when a ZooKeeper process is already running (gsbiju via phunt) (phunt: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1733348]) * trunk/bin/zkServer.sh > zkServer.sh returns with a zero exit status when a ZooKeeper process is > already running > --- > > Key: ZOOKEEPER-1991 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1991 > Project: ZooKeeper > Issue Type: Bug > Components: scripts >Affects Versions: 3.4.6 >Reporter: Reed Wanderman-Milne >Assignee: Biju Nair >Priority: Minor > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-1991.patch > > > If ZooKeeper is started with zkServer.sh, and an error is shown that a > ZooKeeper process is already running, the command returns with an exit status > of 0, while it should end with a non-zero exit status. > Example: > $ bin/zkServer.sh start > JMX enabled by default > Using config: /home/reed/zookeeper/bin/../conf/zoo.cfg > Starting zookeeper ... already running as process 25063. > $ echo $? > 0 > This can make it difficult for automated scripts to check if creating a new > ZooKeeper process was successful, as it won't catch if a user accidentally > started it before. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2375) Prevent multiple initialization of login object in each ZooKeeperSaslClient instance
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175296#comment-15175296 ] Hudson commented on ZOOKEEPER-2375: --- SUCCESS: Integrated in ZooKeeper-trunk #2834 (See [https://builds.apache.org/job/ZooKeeper-trunk/2834/]) ZOOKEEPER-2375: Prevent multiple initialization of login object in each ZooKeeperSaslClient instance (yuemeng via rakeshr) (rakeshr: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1733221]) * trunk/CHANGES.txt * trunk/src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java > Prevent multiple initialization of login object in each ZooKeeperSaslClient > instance > > > Key: ZOOKEEPER-2375 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2375 > Project: ZooKeeper > Issue Type: Bug > Components: java client >Affects Versions: 3.4.6, 3.4.8, 3.5.0, 3.5.1 >Reporter: yuemeng >Priority: Blocker > Fix For: 3.4.9, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2375.patch, ZOOKEEPER-2375_01.patch, > ZOOKEEPER-2375_02.patch > > > If there are exist many ZooKeeperSaslClient instance in one process,each > ZooKeeperSaslClient instance will be call synchronize method( > createSaslClient),But each ZooKeeperSaslClient instance will be lock the > current object(that is say ,the synchronize only for lock it's own object) > ,but many instances can access the static variable login,the synchronize > can't prevent other threads access the static login object,it will be cause > more than one ZooKeeperSaslClient instances use the same login object,and > login.startThreadIfNeeded() will be called more than one times for same login > object。 > it wll cause problem: > ERROR | [Executor task launch worker-1-SendThread(fi1:24002)] | Exception > while trying to create SASL client: java.lang.IllegalThreadStateException | > org.apache.zookeeper.client.ZooKeeperSaslClient.createSaslClient(ZooKeeperSaslClient.java:305) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2243) Supported platforms is completely out of date
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137915#comment-15137915 ] Hudson commented on ZOOKEEPER-2243: --- FAILURE: Integrated in ZooKeeper-trunk #2833 (See [https://builds.apache.org/job/ZooKeeper-trunk/2833/]) ZOOKEEPER-2243: Supported platforms is completely out of date (cnauroth) (cnauroth: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1729259]) * trunk/CHANGES.txt * trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml > Supported platforms is completely out of date > - > > Key: ZOOKEEPER-2243 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2243 > Project: ZooKeeper > Issue Type: Bug >Reporter: Ivan Kelly >Assignee: Chris Nauroth > Fix For: 3.4.9, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2243-branch-3.4.001.patch, > ZOOKEEPER-2243.001.patch > > > http://zookeeper.apache.org/doc/r3.4.6/zookeeperAdmin.html#sc_supportedPlatforms > It refers to Solaris as Sun Solaris so it's at least 5 years out of date. > We should "support" the platforms that we are running zookeeper on regularly, > so I suggest paring it down to linux and windows (mac os doesn't really count > because people don't run it on servers anymore). Everything else should be > "may work, not supported, but will fix obvious bugs". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2360) Update commons collections version used by tests/releaseaudit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133478#comment-15133478 ] Hudson commented on ZOOKEEPER-2360: --- SUCCESS: Integrated in ZooKeeper-trunk #2832 (See [https://builds.apache.org/job/ZooKeeper-trunk/2832/]) ZOOKEEPER-2360: Update commons collections version used by tests/releaseaudit (phunt via cnauroth) (cnauroth: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1728577]) * trunk/CHANGES.txt * trunk/ivy.xml * trunk/src/contrib/zooinspector/ivy.xml > Update commons collections version used by tests/releaseaudit > - > > Key: ZOOKEEPER-2360 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2360 > Project: ZooKeeper > Issue Type: Bug > Components: build >Affects Versions: 3.4.7, 3.5.1 >Reporter: Patrick Hunt >Assignee: Patrick Hunt >Priority: Blocker > Fix For: 3.4.8, 3.5.2 > > Attachments: ZOOKEEPER-2360-branch34.patch, ZOOKEEPER-2360.patch, > ZOOKEEPER-2360.patch > > > I don't believe this affects us from a security perspective directly, however > it's something we should clean up in our next release. > Afaict the only commons we use for shipping/production code is commons-cli. > Our two release branches, 3.4 and 3.5, neither of them use > commons-collections. I looked at the binary release artifact and it doesn't > include the commons collections jar. > We do have a test that uses CollectionsUtils, but no shipping code. I > downloaded our 3.4 and 3.5 artifacts, this is all I see: > phunt:~/Downloads/zd/5/zookeeper-3.5.1-alpha$ grep -R > "org.apache.commons.collections" . > ./src/java/test/org/apache/zookeeper/RemoveWatchesTest.java:import > org.apache.commons.collections.CollectionUtils; > phunt:~/Downloads/zd/5/zookeeper-3.5.1-alpha$ > Also in our ivy file we have > rev="0.10" conf="releaseaudit->default"/> > rev="2.6" conf="releaseaudit->default"/> > rev="3.2.1" conf="releaseaudit->default"/> > So commons-collections is pulled in - but only for the release audit, which > is something we do as a build verification activity but not part of the > product itself. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2297) NPE is thrown while creating "key manager" and "trust manager"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15113580#comment-15113580 ] Hudson commented on ZOOKEEPER-2297: --- FAILURE: Integrated in ZooKeeper-trunk #2831 (See [https://builds.apache.org/job/ZooKeeper-trunk/2831/]) Revert ZOOKEEPER-2297 (rakeshr: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1726354]) * trunk/CHANGES.txt * trunk/src/java/main/org/apache/zookeeper/server/auth/ProviderRegistry.java * trunk/src/java/test/org/apache/zookeeper/test/SSLAuthTest.java * trunk/src/java/test/org/apache/zookeeper/test/SSLTest.java > NPE is thrown while creating "key manager" and "trust manager" > --- > > Key: ZOOKEEPER-2297 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2297 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.1 > Environment: Suse 11 sp 3 >Reporter: Anushri >Assignee: Arshad Mohammad >Priority: Blocker > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2297-01.patch, ZOOKEEPER-2297-02.patch, > ZOOKEEPER-2297-03.patch, ZOOKEEPER-2297-04.patch > > > NPE is thrown while creating "key manager" and "trust manager" , even though > the zk setup is in non-secure mode > bq. 2015-10-19 12:54:12,278 [myid:2] - ERROR [ProcessThread(sid:2 > cport:-1)::X509AuthenticationProvider@78] - Failed to create key manager > bq. org.apache.zookeeper.common.X509Exception$KeyManagerException: > java.lang.NullPointerException > at org.apache.zookeeper.common.X509Util.createKeyManager(X509Util.java:129) > at > org.apache.zookeeper.server.auth.X509AuthenticationProvider.(X509AuthenticationProvider.java:75) > at > org.apache.zookeeper.server.auth.ProviderRegistry.initialize(ProviderRegistry.java:42) > at > org.apache.zookeeper.server.auth.ProviderRegistry.getProvider(ProviderRegistry.java:68) > at > org.apache.zookeeper.server.PrepRequestProcessor.fixupACL(PrepRequestProcessor.java:952) > at > org.apache.zookeeper.server.PrepRequestProcessor.pRequest2Txn(PrepRequestProcessor.java:379) > at > org.apache.zookeeper.server.PrepRequestProcessor.pRequest(PrepRequestProcessor.java:716) > at > org.apache.zookeeper.server.PrepRequestProcessor.run(PrepRequestProcessor.java:144) > Caused by: java.lang.NullPointerException > at org.apache.zookeeper.common.X509Util.createKeyManager(X509Util.java:113) > ... 7 more > bq. 2015-10-19 12:54:12,279 [myid:2] - ERROR [ProcessThread(sid:2 > cport:-1)::X509AuthenticationProvider@90] - Failed to create trust manager > bq. org.apache.zookeeper.common.X509Exception$TrustManagerException: > java.lang.NullPointerException > at org.apache.zookeeper.common.X509Util.createTrustManager(X509Util.java:158) > at > org.apache.zookeeper.server.auth.X509AuthenticationProvider.(X509AuthenticationProvider.java:87) > at > org.apache.zookeeper.server.auth.ProviderRegistry.initialize(ProviderRegistry.java:42) > at > org.apache.zookeeper.server.auth.ProviderRegistry.getProvider(ProviderRegistry.java:68) > at > org.apache.zookeeper.server.PrepRequestProcessor.fixupACL(PrepRequestProcessor.java:952) > at > org.apache.zookeeper.server.PrepRequestProcessor.pRequest2Txn(PrepRequestProcessor.java:379) > at > org.apache.zookeeper.server.PrepRequestProcessor.pRequest(PrepRequestProcessor.java:716) > at > org.apache.zookeeper.server.PrepRequestProcessor.run(PrepRequestProcessor.java:144) > Caused by: java.lang.NullPointerException > at org.apache.zookeeper.common.X509Util.createTrustManager(X509Util.java:143) > ... 7 more -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2297) NPE is thrown while creating "key manager" and "trust manager"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110154#comment-15110154 ] Hudson commented on ZOOKEEPER-2297: --- FAILURE: Integrated in ZooKeeper-trunk #2830 (See [https://builds.apache.org/job/ZooKeeper-trunk/2830/]) ZOOKEEPER-2297: NPE is thrown while creating "key manager" and "trust manager" (Arshad Mohammad via rakeshr) (rakeshr: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1725872]) * trunk/CHANGES.txt * trunk/src/java/main/org/apache/zookeeper/server/auth/ProviderRegistry.java * trunk/src/java/test/org/apache/zookeeper/test/SSLAuthTest.java * trunk/src/java/test/org/apache/zookeeper/test/SSLTest.java > NPE is thrown while creating "key manager" and "trust manager" > --- > > Key: ZOOKEEPER-2297 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2297 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.1 > Environment: Suse 11 sp 3 >Reporter: Anushri >Assignee: Arshad Mohammad >Priority: Minor > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2297-01.patch, ZOOKEEPER-2297-02.patch, > ZOOKEEPER-2297-03.patch > > > NPE is thrown while creating "key manager" and "trust manager" , even though > the zk setup is in non-secure mode > bq. 2015-10-19 12:54:12,278 [myid:2] - ERROR [ProcessThread(sid:2 > cport:-1)::X509AuthenticationProvider@78] - Failed to create key manager > bq. org.apache.zookeeper.common.X509Exception$KeyManagerException: > java.lang.NullPointerException > at org.apache.zookeeper.common.X509Util.createKeyManager(X509Util.java:129) > at > org.apache.zookeeper.server.auth.X509AuthenticationProvider.(X509AuthenticationProvider.java:75) > at > org.apache.zookeeper.server.auth.ProviderRegistry.initialize(ProviderRegistry.java:42) > at > org.apache.zookeeper.server.auth.ProviderRegistry.getProvider(ProviderRegistry.java:68) > at > org.apache.zookeeper.server.PrepRequestProcessor.fixupACL(PrepRequestProcessor.java:952) > at > org.apache.zookeeper.server.PrepRequestProcessor.pRequest2Txn(PrepRequestProcessor.java:379) > at > org.apache.zookeeper.server.PrepRequestProcessor.pRequest(PrepRequestProcessor.java:716) > at > org.apache.zookeeper.server.PrepRequestProcessor.run(PrepRequestProcessor.java:144) > Caused by: java.lang.NullPointerException > at org.apache.zookeeper.common.X509Util.createKeyManager(X509Util.java:113) > ... 7 more > bq. 2015-10-19 12:54:12,279 [myid:2] - ERROR [ProcessThread(sid:2 > cport:-1)::X509AuthenticationProvider@90] - Failed to create trust manager > bq. org.apache.zookeeper.common.X509Exception$TrustManagerException: > java.lang.NullPointerException > at org.apache.zookeeper.common.X509Util.createTrustManager(X509Util.java:158) > at > org.apache.zookeeper.server.auth.X509AuthenticationProvider.(X509AuthenticationProvider.java:87) > at > org.apache.zookeeper.server.auth.ProviderRegistry.initialize(ProviderRegistry.java:42) > at > org.apache.zookeeper.server.auth.ProviderRegistry.getProvider(ProviderRegistry.java:68) > at > org.apache.zookeeper.server.PrepRequestProcessor.fixupACL(PrepRequestProcessor.java:952) > at > org.apache.zookeeper.server.PrepRequestProcessor.pRequest2Txn(PrepRequestProcessor.java:379) > at > org.apache.zookeeper.server.PrepRequestProcessor.pRequest(PrepRequestProcessor.java:716) > at > org.apache.zookeeper.server.PrepRequestProcessor.run(PrepRequestProcessor.java:144) > Caused by: java.lang.NullPointerException > at org.apache.zookeeper.common.X509Util.createTrustManager(X509Util.java:143) > ... 7 more -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-412) checkstyle target fails trunk build
[ https://issues.apache.org/jira/browse/ZOOKEEPER-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15058736#comment-15058736 ] Hudson commented on ZOOKEEPER-412: -- FAILURE: Integrated in ZooKeeper-trunk #2829 (See [https://builds.apache.org/job/ZooKeeper-trunk/2829/]) ZOOKEEPER-412: checkstyle target fails trunk build (Akihiro Suda via cnauroth) (cnauroth: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1720227]) * trunk/CHANGES.txt * trunk/build.xml * trunk/ivy.xml * trunk/src/java/test/checkstyle.xml > checkstyle target fails trunk build > --- > > Key: ZOOKEEPER-412 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-412 > Project: ZooKeeper > Issue Type: Bug >Reporter: Giridharan Kesavan >Assignee: Akihiro Suda > Fix For: 3.5.2 > > Attachments: ZOOKEEPER-412-v2.patch, ZOOKEEPER-412-v3.patch, > ZOOKEEPER-412.patch, checkstyle-errors-trunk-20151211.html.gz > > > BUILD FAILED > /home/hudson/hudson-slave/workspace/ZooKeeper-trunk/trunk/build.xml:865: > Unable to create a Checker: cannot initialize module PackageHtml - Unable to > instantiate PackageHtml > Tnx! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1029) C client bug in zookeeper_init (if bad hostname is given)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053646#comment-15053646 ] Hudson commented on ZOOKEEPER-1029: --- SUCCESS: Integrated in ZooKeeper-trunk #2828 (See [https://builds.apache.org/job/ZooKeeper-trunk/2828/]) ZOOKEEPER-1029: C client bug in zookeeper_init (if bad hostname is given) (fpj via cnauroth) (cnauroth: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1719528]) * trunk/CHANGES.txt * trunk/src/c/src/mt_adaptor.c * trunk/src/c/src/st_adaptor.c * trunk/src/c/src/zk_adaptor.h * trunk/src/c/src/zookeeper.c > C client bug in zookeeper_init (if bad hostname is given) > - > > Key: ZOOKEEPER-1029 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1029 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.3.2, 3.4.6, 3.5.0 >Reporter: Dheeraj Agrawal >Assignee: Flavio Junqueira >Priority: Blocker > Fix For: 3.4.7, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-1029-3.4.patch, ZOOKEEPER-1029-3.4.patch, > ZOOKEEPER-1029-3.4.patch, ZOOKEEPER-1029-3.4.patch, ZOOKEEPER-1029-3.4.patch, > ZOOKEEPER-1029-3.4.patch, ZOOKEEPER-1029-3.5.patch, ZOOKEEPER-1029-3.5.patch > > > If you give invalid hostname to zookeeper_init method, it's not able to > resolve it, and it tries to do the cleanup (free buffer/completion lists/etc) > . The adaptor_init() is not called for this code path, so the lock,cond > variables (for adaptor, completion lists) are not initialized. > As part of the cleanup it's trying to clean up some buffers and acquires > locks and unlocks (where the locks have not yet been initialized, so > unlocking fails) > lock_completion_list(>sent_requests); - pthread_mutex/cond not > initialized > tmp_list = zh->sent_requests; > zh->sent_requests.head = 0; > zh->sent_requests.last = 0; > unlock_completion_list(>sent_requests); trying to broadcast here > on uninitialized cond > It should do error checking to see if locking succeeds before unlocking it. > If Locking fails, then appropriate error handling has to be done. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2252) Random test case failure in org.apache.zookeeper.test.StaticHostProviderTest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15051684#comment-15051684
]
Hudson commented on ZOOKEEPER-2252:
---
FAILURE: Integrated in ZooKeeper-trunk #2827 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2827/])
ZOOKEEPER-2252: Random test case failure in
org.apache.zookeeper.test.StaticHostProviderTest (Timothy Ward via cnauroth)
(cnauroth:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1719204])
* trunk/CHANGES.txt
* trunk/src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java
> Random test case failure in org.apache.zookeeper.test.StaticHostProviderTest
>
>
> Key: ZOOKEEPER-2252
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2252
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Timothy Ward
>Priority: Minor
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZK-2252-try-repro-on-jenkins.patch,
> ZOOKEEPER-2252-02.patch, ZOOKEEPER-2252-03.patch, ZOOKEEPER-2252-04.patch,
> ZOOKEEPER-2252-05.patch, ZOOKEEPER-2252-06.patch
>
>
> Test
> {{org.apache.zookeeper.test.StaticHostProviderTest.testTwoInvalidHostAddresses()}}
> fails randomly.
> Refer bellow test ci buils:
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2827/testReport/
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2828/testReport/
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2830/testReport/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2340) JMX is disabled even if JMXDISABLE is false
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050212#comment-15050212 ] Hudson commented on ZOOKEEPER-2340: --- SUCCESS: Integrated in ZooKeeper-trunk #2826 (See [https://builds.apache.org/job/ZooKeeper-trunk/2826/]) ZOOKEEPER-2340: JMX is disabled even if JMXDISABLE is false (Arshad Mohammad via rgs) (rgs: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1719011]) * trunk/CHANGES.txt * trunk/bin/zkServer.sh > JMX is disabled even if JMXDISABLE is false > --- > > Key: ZOOKEEPER-2340 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2340 > Project: ZooKeeper > Issue Type: Bug >Reporter: neha >Assignee: Arshad Mohammad >Priority: Minor > Fix For: 3.4.8, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2340-01.patch > > > Currently, to enable jmx for zookeeper, need to comment the property > JMXDISABLE as JMXDISABLE=false continues to disable JMX. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2295) TGT refresh time logic is wrong
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048062#comment-15048062 ] Hudson commented on ZOOKEEPER-2295: --- FAILURE: Integrated in ZooKeeper-trunk #2825 (See [https://builds.apache.org/job/ZooKeeper-trunk/2825/]) ZOOKEEPER-2295: TGT refresh time logic is wrong (Arshad Mohammad via rgs) (rgs: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1718758]) * trunk/CHANGES.txt * trunk/src/java/main/org/apache/zookeeper/Login.java > TGT refresh time logic is wrong > --- > > Key: ZOOKEEPER-2295 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2295 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.4.7, 3.5.1 >Reporter: Arshad Mohammad >Assignee: Arshad Mohammad > Fix For: 3.4.8, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2295-01.patch, ZOOKEEPER-2295-02.patch, > ZOOKEEPER-2295-03.patch > > > When Kerberos is used as authentication mechanism some time TGT is getting > expired because it is not refreshed timely. > The scenario is as follow: > suppose now=8 (the current milliseconds) > next refresh time= 10 > TGT expire time= 9 > *Current behaviour:* Error is logged and TGT refresh thread exits. > *Expected behaviour:* TGT should be refreshed immediately(now) instead of > nextRefreshTime -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2336) Jenkins not working due to old SVN
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046382#comment-15046382
]
Hudson commented on ZOOKEEPER-2336:
---
SUCCESS: Integrated in ZooKeeper-trunk #2824 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2824/])
ZOOKEEPER-2336: Jenkins not working due to old SVN
(Akihiro Suda via rgs) (rgs:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1718511])
* trunk/src/java/test/bin/test-patch.sh
> Jenkins not working due to old SVN
> --
>
> Key: ZOOKEEPER-2336
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2336
> Project: ZooKeeper
> Issue Type: Test
> Components: build
>Reporter: Akihiro Suda
> Attachments: ZOOKEEPER-2336-v1.patch
>
>
> Jenkins seems not working since Build #2976 (Dec 6, 2015) due to SVN.
> https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2976/console
> {panel}
> [exec] svn: E155036: Please see the 'svn upgrade' command
> [exec] svn: E155036: The working copy at
> '/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk'
> [exec] is too old (format 10) to work with client version '1.8.8
> (r1568071)' (expects format 31). You need to upgrade the working copy first.
> [exec]
> {panel}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2311) assert in setup_random
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15044125#comment-15044125
]
Hudson commented on ZOOKEEPER-2311:
---
SUCCESS: Integrated in ZooKeeper-trunk #2820 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2820/])
ZOOKEEPER-2311: assert in setup_random
(Marshall McMullen via rgs) (rgs:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1718207])
* trunk/CHANGES.txt
* trunk/src/c/src/zookeeper.c
> assert in setup_random
> --
>
> Key: ZOOKEEPER-2311
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2311
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
>Affects Versions: 3.4.7, 3.5.1
>Reporter: Marshall McMullen
> Fix For: 3.4.8, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2311.patch, ZOOKEEPER-2311.patch
>
>
> We've started seeing an assert failing inside setup_random at line 537:
> {code}
> 528 static void setup_random()
> 529 {
> 530 #ifndef _WIN32 // TODO: better seed
> 531 int seed;
> 532 int fd = open("/dev/urandom", O_RDONLY);
> 533 if (fd == -1) {
> 534 seed = getpid();
> 535 } else {
> 536 int rc = read(fd, , sizeof(seed));
> 537 assert(rc == sizeof(seed));
> 538 close(fd);
> 539 }
> 540 srandom(seed);
> 541 srand48(seed);
> 542 #endif
> {code}
> The core files show:
> Program terminated with signal 6, Aborted.
> #0 0x7f9ff665a0d5 in raise () from /lib/x86_64-linux-gnu/libc.so.6
> #0 0x7f9ff665a0d5 in raise () from /lib/x86_64-linux-gnu/libc.so.6
> #1 0x7f9ff665d83b in abort () from /lib/x86_64-linux-gnu/libc.so.6
> #2 0x7f9ff6652d9e in ?? () from /lib/x86_64-linux-gnu/libc.so.6
> #3 0x7f9ff6652e42 in __assert_fail () from
> /lib/x86_64-linux-gnu/libc.so.6
> #4 0x7f9ff8e4070a in setup_random () at src/zookeeper.c:476
> #5 0x7f9ff8e40d76 in resolve_hosts (zh=0x7f9fe14de400,
> hosts_in=0x7f9fd700f400 "10.26.200.6:2181,10.26.200.7:2181,10.26.200.8:2181",
> avec=0x7f9fd87fab60) at src/zookeeper.c:730
> #6 0x7f9ff8e40e87 in update_addrs (zh=0x7f9fe14de400) at
> src/zookeeper.c:801
> #7 0x7f9ff8e44176 in zookeeper_interest (zh=0x7f9fe14de400,
> fd=0x7f9fd87fac4c, interest=0x7f9fd87fac50, tv=0x7f9fd87fac80) at
> src/zookeeper.c:1980
> #8 0x7f9ff8e553f5 in do_io (v=0x7f9fe14de400) at src/mt_adaptor.c:379
> #9 0x7f9ff804de9a in start_thread () from
> /lib/x86_64-linux-gnu/libpthread.so.0
> #10 0x7f9ff671738d in clone () from /lib/x86_64-linux-gnu/libc.so.6
> #11 0x in ?? ()
> I'm not sure what the underlying cause of this is... But POSIX always allows
> for a short read(2), and any program MUST check for short reads...
> Has anyone else encountered this issue? We are seeing it rather frequently
> which is concerning.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2306) Remove file delete duplicate code from test code
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15044160#comment-15044160
]
Hudson commented on ZOOKEEPER-2306:
---
SUCCESS: Integrated in ZooKeeper-trunk #2821 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2821/])
ZOOKEEPER-2306: Remove file delete duplicate code from test code
(Arshad Mohammad via rgs) (rgs:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1718212])
* trunk/CHANGES.txt
*
trunk/src/java/systest/org/apache/zookeeper/test/system/QuorumPeerInstance.java
* trunk/src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java
* trunk/src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java
* trunk/src/java/test/org/apache/zookeeper/test/ClientBase.java
* trunk/src/java/test/org/apache/zookeeper/test/TestUtils.java
> Remove file delete duplicate code from test code
> -
>
> Key: ZOOKEEPER-2306
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2306
> Project: ZooKeeper
> Issue Type: Improvement
> Components: tests
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2306-01.patch
>
>
> Code to delete a folder recursive is written in multiple test files.
> Following are the files containing the same piece of code.
> {code}
> src/java/systest/org/apache/zookeeper/test/system/QuorumPeerInstance.java
> src/java/test/org/apache/zookeeper/test/ClientBase.java
> src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java
> src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java
> {code}
> Remove duplicate code from these files
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2304) JMX ClientPort from ZooKeeperServerBean incorrect
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15044161#comment-15044161
]
Hudson commented on ZOOKEEPER-2304:
---
SUCCESS: Integrated in ZooKeeper-trunk #2821 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2821/])
ZOOKEEPER-2304: JMX ClientPort from ZooKeeperServerBean incorrect
(Arshad Mohammad via rgs) (rgs:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1718214])
* trunk/CHANGES.txt
* trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java
> JMX ClientPort from ZooKeeperServerBean incorrect
> -
>
> Key: ZOOKEEPER-2304
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2304
> Project: ZooKeeper
> Issue Type: Bug
> Components: jmx
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2304-01.patch
>
>
> The "ClientPort" property of
> {{org.apache.zookeeper.server.ZooKeeperServerBean}} returns incorrect value.
> It includes address also like 192.168.1.2:2183. It should return only port
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2300) Expose SecureClientPort and SecureClientAddress JMX properties
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1506#comment-1506
]
Hudson commented on ZOOKEEPER-2300:
---
FAILURE: Integrated in ZooKeeper-trunk #2823 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2823/])
ZOOKEEPER-2300: Expose SecureClientPort and SecureClientAddress JMX properties
(Arshad Mohammad via rgs) (rgs:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1718255])
* trunk/CHANGES.txt
* trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java
* trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServerMXBean.java
* trunk/src/java/test/org/apache/zookeeper/server/ZooKeeperServerBeanTest.java
> Expose SecureClientPort and SecureClientAddress JMX properties
> --
>
> Key: ZOOKEEPER-2300
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2300
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2300-01.patch
>
>
> ZooKeeper currently exposes ClientPort and ClientAddress JMX properties.
> Same way we should expose SecureClientPort and SecureClientAddress.
> The values for these two properties will be decided based on the configured
> value of secureClientPort and secureClientPortAddress
> The value of SecureClientPort will be:
> secureClientPort {color:blue}(if secureClientPort is configured){color}
> empty string {color:blue}(If secureClientPort is not configured){color}
> The value of SecureClientAddress will be:
> secureClientPortAddress:secureClientPort{color:blue}(if both
> secureClientPort and secureClientPortAddress are configured){color}
> 0.0.0.0:secureClientPort or 0:0:0:0:0:0:0:0:secureClientPort {color:blue}(if
> only secureClientPort is configured){color}
> empty string {color:blue}(If secureClientPort is not configured){color}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2299) NullPointerException in LocalPeerBean for ClientAddress
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15044402#comment-15044402 ] Hudson commented on ZOOKEEPER-2299: --- SUCCESS: Integrated in ZooKeeper-trunk #2822 (See [https://builds.apache.org/job/ZooKeeper-trunk/2822/]) ZOOKEEPER-2299: NullPointerException in LocalPeerBean for ClientAddress (Arshad Mohammad via rgs) (rgs: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1718253]) * trunk/CHANGES.txt * trunk/src/java/main/org/apache/zookeeper/server/quorum/LocalPeerBean.java * trunk/src/java/test/org/apache/zookeeper/server/quorum/LocalPeerBeanTest.java > NullPointerException in LocalPeerBean for ClientAddress > --- > > Key: ZOOKEEPER-2299 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2299 > Project: ZooKeeper > Issue Type: Bug > Components: jmx >Reporter: Arshad Mohammad >Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2299-01.patch > > > When clientPortAddress is not configured LocalPeerBean throws > NullPointerException. > *Expected Behavior:* > # When only clientPort is configured ClientAddress value should be > 0.0.0.0:clientPort or 0:0:0:0:0:0:0:0:clientPort > # When both clientPort clientPortAddress are configured then expected value > is clientPortAddress:clientPort -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2301) QuorumPeer does not listen on passed client IP in the constructor
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15044403#comment-15044403
]
Hudson commented on ZOOKEEPER-2301:
---
SUCCESS: Integrated in ZooKeeper-trunk #2822 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2822/])
ZOOKEEPER-2301: QuorumPeer does not listen on passed client IP in the
constructor
(Arshad Mohammad via rgs) (rgs:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1718251])
* trunk/CHANGES.txt
* trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
* trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTest.java
* trunk/src/java/test/org/apache/zookeeper/test/TruncateTest.java
> QuorumPeer does not listen on passed client IP in the constructor
> -
>
> Key: ZOOKEEPER-2301
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2301
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2301-01.patch, ZOOKEEPER-2301-02.patch,
> ZOOKEEPER-2301-03.patch
>
>
> QuorumPeer does not listen on passed client IP in the constructor, for client
> connection. It always listens on all IP(0.0.0.0 or 0:0:0:0:0:0:0:0). This
> happens only when QuorumPeer is created using any of the bellow constructors
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeer.QuorumPeer(Map
> quorumPeers, File snapDir,
> File logDir, int clientPort, int electionAlg,
> long myid, int tickTime, int initLimit, int syncLimit)
> {code}
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeer.QuorumPeer(Map
> quorumPeers, File snapDir,
> File logDir, int clientPort, int electionAlg,
> long myid, int tickTime, int initLimit, int syncLimit,
> QuorumVerifier quorumConfig)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2326) Include connected server address:port in log
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043535#comment-15043535
]
Hudson commented on ZOOKEEPER-2326:
---
FAILURE: Integrated in ZooKeeper-trunk #2818 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2818/])
ZOOKEEPER-2326: Include connected server address:port in log
(Arshad Mohammad via rgs) (rgs:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1718123])
* trunk/CHANGES.txt
* trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
> Include connected server address:port in log
>
>
> Key: ZOOKEEPER-2326
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2326
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Minor
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2326-01.patch
>
>
> Currently ZooKeeper client log contains blank myid as bellow
> {noformat}
> 2015-11-18 23:46:39,045 [myid:] - INFO
> [main-SendThread(192.168.1.3:2183):ClientCnxn$SendThread@1138] - Opening
> socket connection to server 192.168.1.3/192.168.1.3:2183. Will attempt to
> SASL-authenticate using Login Context section 'Client'
> 2015-11-18 23:46:40,387 [myid:] - WARN
> [main-SendThread(192.168.1.3:2183):ClientCnxn$SendThread@1206] - Client
> session timed out, have not heard from server in 1499ms for sessionid
> 0x29eb6510002
> 2015-11-18 23:46:40,387 [myid:] - INFO
> [main-SendThread(192.168.1.3:2183):ClientCnxn$SendThread@1254] - Client
> session timed out, have not heard from server in 1499ms for sessionid
> 0x29eb6510002, closing socket connection and attempting reconnect
> 2015-11-18 23:46:41,323 [myid:] - INFO
> [main-SendThread(192.168.1.3:2181):ZooKeeperSaslClient@235] - Client will use
> DIGEST-MD5 as SASL mechanism.
> {noformat}
> myid is blank. it is fine as at client side myid(serverid ) does not make any
> sense. But we can assign myid serverIP: port which will be a very helpful
> information in analysing the issues. So we after fix we can have log as bellow
> {noformat}
> 2015-11-19 03:51:27,254 [myid:192.168.1.3:2183] - INFO
> [main-SendThread(192.168.1.3:2183):Login@290] - successfully logged in.
> 2015-11-19 03:51:27,270 [myid:192.168.1.3:2183] - INFO
> [Thread-0:Login$1@124] - TGT refresh thread started.
> 2015-11-19 03:51:27,270 [myid:192.168.1.3:2183] - INFO
> [main-SendThread(192.168.1.3:2183):ZooKeeperSaslClient$1@297] - Client will
> use GSSAPI as SASL mechanism.
> 2015-11-19 03:51:27,270 [myid:192.168.1.3:2183] - INFO [Thread-0:Login@298]
> - TGT valid starting at:Thu Nov 19 03:51:27 IST 2015
> 2015-11-19 03:51:27,270 [myid:192.168.1.3:2183] - INFO [Thread-0:Login@299]
> - TGT expires: Thu Nov 19 03:53:27 IST 2015
> 2015-11-19 03:51:27,270 [myid:192.168.1.3:2183] - INFO
> [Thread-0:Login$1@178] - TGT refresh sleeping until: Thu Nov 19 03:53:05 IST
> 2015
> 2015-11-19 03:51:27,285 [myid:192.168.1.3:2183] - INFO
> [main-SendThread(192.168.1.3:2183):ClientCnxn$SendThread@1141] - Opening
> socket connection to server 192.168.1.3/192.168.1.3:2183. Will attempt to
> SASL-authenticate using Login Context section 'Client'
> 2015-11-19 03:51:27,301 [myid:192.168.1.3:2183] - INFO
> [main-SendThread(192.168.1.3:2183):ClientCnxn$SendThread@981] - Socket
> connection established, initiating session, client: /192.168.1.2:53117,
> server: 192.168.1.3/192.168.1.3:2183
> 2015-11-19 03:51:28,632 [myid:192.168.1.3:2183] - WARN
> [main-SendThread(192.168.1.3:2183):ClientCnxn$SendThread@1209] - Client
> session timed out, have not heard from server in 1333ms for sessionid 0x0
> 2015-11-19 03:51:28,632 [myid:192.168.1.3:2183] - INFO
> [main-SendThread(192.168.1.3:2183):ClientCnxn$SendThread@1257] - Client
> session timed out, have not heard from server in 1333ms for sessionid 0x0,
> closing socket connection and attempting reconnect
> 2015-11-19 03:51:29,147 [myid:192.168.1.3:2181] - INFO
> [main-SendThread(192.168.1.3:2181):ZooKeeperSaslClient$1@297] - Client will
> use GSSAPI as SASL mechanism.
> 2015-11-19 03:51:29,152 [myid:192.168.1.3:2181] - INFO
> [main-SendThread(192.168.1.3:2181):ClientCnxn$SendThread@1141] - Opening
> socket connection to server 192.168.1.3/192.168.1.3:2181. Will attempt to
> SASL-authenticate using Login Context section 'Client'
> 2015-11-19 03:51:29,154 [myid:192.168.1.3:2181] - INFO
> [main-SendThread(192.168.1.3:2181):ClientCnxn$SendThread@981] - Socket
> connection established, initiating session, client: /192.168.1.2:53118,
> server: 192.168.1.3/192.168.1.3:2181
> 2015-11-19 03:51:30,487 [myid:192.168.1.3:2181] - WARN
> [main-SendThread(192.168.1.3:2181):ClientCnxn$SendThread@1209] - Client
> session timed out,
[jira] [Commented] (ZOOKEEPER-2330) ZooKeeper close API does not close Login thread.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15043534#comment-15043534
]
Hudson commented on ZOOKEEPER-2330:
---
FAILURE: Integrated in ZooKeeper-trunk #2818 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2818/])
ZOOKEEPER-2330: ZooKeeper close API does not close Login thread
(Arshad Mohammad via rgs) (rgs:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1718121])
* trunk/CHANGES.txt
* trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
* trunk/src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java
> ZooKeeper close API does not close Login thread.
>
>
> Key: ZOOKEEPER-2330
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2330
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2330-01.patch
>
>
> When kerberos is used as authentication mechanism, one login thread runs in
> the background for ZooKeeper client as well ZooKeepr server.
> This problem is related to Zookeeper client and the scenario is as follows:
> # Main application connects to Zookeeper
> {code}
> ZooKeeper zooKeeper = new ZooKeeper(zookeeperConnectionString,
> sessionTimeout, this)
> {code}
> # Completes it is work with zookeeper
> # calls close() on zookeeper, and continues with rest of the application
> specific work
> Thread dump, taken after 3rd step, shows that login thread is still alive
> {code}
> "Thread-1" daemon prio=6 tid=0x04842c00 nid=0x1f04 waiting on condition
> [0x05b7f000]
>java.lang.Thread.State: TIMED_WAITING (sleeping)
> at java.lang.Thread.sleep(Native Method)
> at org.apache.zookeeper.Login$1.run(Login.java:180)
> at java.lang.Thread.run(Thread.java:722)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2329) Clear javac and javadoc warning from zookeeper
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15020767#comment-15020767
]
Hudson commented on ZOOKEEPER-2329:
---
SUCCESS: Integrated in ZooKeeper-trunk #2817 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2817/])
ZOOKEEPER-2329: Clear javac and javadoc warning from zookeeper
(Arshad Mohammad via rgs) (rgs:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1715590])
* trunk/CHANGES.txt
* trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java
* trunk/src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java
* trunk/src/java/main/org/apache/zookeeper/server/admin/AdminServer.java
* trunk/src/java/main/org/apache/zookeeper/server/admin/JettyAdminServer.java
* trunk/src/java/main/org/apache/zookeeper/server/util/KerberosUtil.java
* trunk/src/java/main/org/apache/zookeeper/server/util/OSMXBean.java
> Clear javac and javadoc warning from zookeeper
> --
>
> Key: ZOOKEEPER-2329
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2329
> Project: ZooKeeper
> Issue Type: Bug
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Minor
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2329-01.patch
>
>
> Currently ZooKeeper java code has 10 javac and 1 javadoc warning. These
> should be removed.
> *javac warnings*
> {noformat}
> [javac] Compiling 228 source files to D:\gitHome\zookeeperTrunk\build\classes
> [javac]
> D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\ZooKeeperMain.java:226:
> warning: [rawtypes] found raw type: List
> [javac] List args = new LinkedList();
> [javac] ^
> [javac] missing type arguments for generic class List
> [javac] where E is a type-variable:
> [javac] E extends Object declared in interface List
> [javac]
> D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\ZooKeeperMain.java:226:
> warning: [rawtypes] found raw type: LinkedList
> [javac] List args = new LinkedList();
> [javac] ^
> [javac] missing type arguments for generic class LinkedList
> [javac] where E is a type-variable:
> [javac] E extends Object declared in class LinkedList
> [javac]
> D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\ZooKeeperMain.java:233:
> warning: [unchecked] unchecked call to add(E) as a member of the raw type
> List
> [javac] args.add(value);
> [javac] ^
> [javac] where E is a type-variable:
> [javac] E extends Object declared in interface List
> [javac]
> D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\ZooKeeperMain.java:239:
> warning: [unchecked] unchecked conversion
> [javac] cmdArgs = args;
> [javac] ^
> [javac] required: List
> [javac] found:List
> [javac]
> D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\jmx\ManagedUtil.java:62:
> warning: [rawtypes] found raw type: Enumeration
> [javac] Enumeration enumer = r.getCurrentLoggers();
> [javac] ^
> [javac] missing type arguments for generic class Enumeration
> [javac] where E is a type-variable:
> [javac] E extends Object declared in interface Enumeration
> [javac]
> D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\server\admin\AdminServer.java:33:
> warning: [serial] serializable class AdminServerException has no definition
> of serialVersionUID
> [javac] public class AdminServerException extends Exception {
> [javac]^
> [javac]
> D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\server\admin\JettyAdminServer.java:142:
> warning: [serial] serializable class JettyAdminServer.CommandServlet has no
> definition of serialVersionUID
> [javac] private class CommandServlet extends HttpServlet {
> [javac] ^
> [javac]
> D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\server\util\KerberosUtil.java:39:
> warning: [rawtypes] found raw type: Class
> [javac] getInstanceMethod = classRef.getMethod("getInstance", new
> Class[0]);
> [javac] ^
> [javac] missing type arguments for generic class Class
> [javac] where T is a type-variable:
> [javac] T extends Object declared in class Class
> [javac]
> D:\gitHome\zookeeperTrunk\src\java\main\org\apache\zookeeper\server\util\KerberosUtil.java:42:
> warning: [rawtypes] found raw type: Class
> [javac] new Class[0]);
> [javac] ^
> [javac] missing type arguments for generic class Class
> [javac] where T is a
[jira] [Commented] (ZOOKEEPER-1371) Remove dependency on log4j in the source code.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15020733#comment-15020733 ] Hudson commented on ZOOKEEPER-1371: --- FAILURE: Integrated in ZooKeeper-trunk #2816 (See [https://builds.apache.org/job/ZooKeeper-trunk/2816/]) ZOOKEEPER-1371: Remove dependency on log4j in the source code (Arshad Mohammad via rgs) (rgs: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1715577]) * trunk/CHANGES.txt * trunk/build.xml * trunk/ivy.xml * trunk/src/contrib/loggraph/ivy.xml * trunk/src/contrib/rest/ivy.xml * trunk/src/contrib/zooinspector/ivy.xml * trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml * trunk/src/java/main/org/apache/zookeeper/Login.java * trunk/src/java/main/org/apache/zookeeper/Shell.java * trunk/src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java * trunk/src/java/main/org/apache/zookeeper/jmx/ManagedUtil.java * trunk/src/java/test/org/apache/zookeeper/server/ZxidRolloverTest.java * trunk/src/java/test/org/apache/zookeeper/test/FollowerResyncConcurrencyTest.java * trunk/src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java * trunk/src/java/test/org/apache/zookeeper/test/RestoreCommittedLogTest.java > Remove dependency on log4j in the source code. > -- > > Key: ZOOKEEPER-1371 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1371 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.4.0, 3.4.1, 3.4.2, 3.4.3 >Reporter: Mahadev konar >Assignee: Arshad Mohammad > Labels: patch > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-1371-05.patch, ZOOKEEPER-1371.patch, > ZOOKEEPER-1371.patch, ZOOKEEPER-1371.patch, ZOOKEEPER-1371.patch > > > ZOOKEEPER-850 added slf4j to ZK. We still depend on log4j in our codebase. We > should remove the dependency on log4j so that we can make logging pluggable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2229) Several four-letter words are undocumented.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000116#comment-15000116
]
Hudson commented on ZOOKEEPER-2229:
---
SUCCESS: Integrated in ZooKeeper-trunk #2814 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2814/])
ZOOKEEPER-2229: Several four-letter words are undocumented
(Chris Nauroth via rgs) (rgs:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1713774])
* trunk/CHANGES.txt
* trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
> Several four-letter words are undocumented.
> ---
>
> Key: ZOOKEEPER-2229
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2229
> Project: ZooKeeper
> Issue Type: Bug
> Components: documentation
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Fix For: 3.4.7, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2229.001.patch, ZOOKEEPER-2229.002.patch
>
>
> The {{isro}}, {{gtmk}} and {{stmk}} commands are not covered in the
> four-letter word documentation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2211) PurgeTxnLog does not correctly purge when snapshots and logs are at different locations
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14995846#comment-14995846 ] Hudson commented on ZOOKEEPER-2211: --- FAILURE: Integrated in ZooKeeper-trunk #2811 (See [https://builds.apache.org/job/ZooKeeper-trunk/2811/]) ZOOKEEPER-2211: PurgeTxnLog does not correctly purge when snapshots and logs are at different locations (Arshad Mohammad via rgs) (rgs: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1713296]) * trunk/CHANGES.txt * trunk/src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java * trunk/src/java/test/org/apache/zookeeper/server/PurgeTxnTest.java > PurgeTxnLog does not correctly purge when snapshots and logs are at different > locations > --- > > Key: ZOOKEEPER-2211 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2211 > Project: ZooKeeper > Issue Type: Bug > Components: scripts >Affects Versions: 3.4.6, 3.5.0 > Environment: Ubuntu 12.04, Java 1.7. >Reporter: Wesley Chow >Assignee: Arshad Mohammad > Fix For: 3.4.7, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2211-02.patch, ZOOKEEPER-2211-03.patch, > ZOOKEEPER-2211-04.patch, ZOOKEEPER-2211.patch > > > PurgeTxnLog does not work when snapshots and transaction logs are at > different file paths. The argument handling is buggy and only works when both > snap and datalog dirs are given, and datalog dir contains both logs and snaps > (snap is ignored). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2227) stmk four-letter word fails execution at server while reading trace mask argument.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14995848#comment-14995848
]
Hudson commented on ZOOKEEPER-2227:
---
FAILURE: Integrated in ZooKeeper-trunk #2811 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2811/])
ZOOKEEPER-2227: stmk four-letter word fails execution at server while
reading trace mask argument (Chris Nauroth via rgs) (rgs:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1713300])
* trunk/CHANGES.txt
* trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
* trunk/src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java
* trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java
> stmk four-letter word fails execution at server while reading trace mask
> argument.
> --
>
> Key: ZOOKEEPER-2227
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2227
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.3.0
>Reporter: Chris Nauroth
>Assignee: Chris Nauroth
> Fix For: 3.4.7, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2227-branch-3.4.002.patch,
> ZOOKEEPER-2227.001.patch, ZOOKEEPER-2227.002.patch
>
>
> When the server handles the {{stmk}} four-letter word, it attempts to read an
> 8-byte Java {{long}} from the request as the trace mask argument. The read
> fails, because the destination buffer's capacity is only 4 bytes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1853) zkCli.sh can't issue a CREATE command containing spaces in the data
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14995847#comment-14995847
]
Hudson commented on ZOOKEEPER-1853:
---
FAILURE: Integrated in ZooKeeper-trunk #2811 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2811/])
ZOOKEEPER-1853: zkCli.sh can't issue a CREATE command containing
spaces in the data (Ryan Lamore via rgs) (rgs:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1713303])
* trunk/.gitignore
* trunk/CHANGES.txt
* trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java
* trunk/src/java/test/org/apache/zookeeper/ZooKeeperTest.java
> zkCli.sh can't issue a CREATE command containing spaces in the data
> ---
>
> Key: ZOOKEEPER-1853
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1853
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
>Affects Versions: 3.4.6, 3.5.0
>Reporter: sekine coulibaly
>Assignee: Ryan Lamore
>Priority: Minor
> Labels: patch
> Fix For: 3.4.7, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-1853-branch-3.4.patch, ZOOKEEPER-1853.patch,
> ZOOKEEPER-1853.patch, ZOOKEEPER-1853.patch, ZkSpaceMan.java
>
>
> Execute the following command in zkCli.sh :
> create /contacts/1 {"country":"CA","name":"De La Salle"}
> The results is that only {"id":1,"fullname":"De is stored.
> The expected result is to have the full JSON payload stored.
> The CREATE command seems to be croped after the first space of the data
> payload. When issuing a create command, all arguments not being -s nor -e
> shall be treated as the actual data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2315) Change client connect zk service timeout log level from Info to Warn level
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14995872#comment-14995872
]
Hudson commented on ZOOKEEPER-2315:
---
FAILURE: Integrated in ZooKeeper-trunk #2812 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2812/])
ZOOKEEPER-2315: Change client connect zk service timeout log level from Info
to Warn level (Lin Yiqun via rgs) (rgs:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1713312])
* trunk/CHANGES.txt
* trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
> Change client connect zk service timeout log level from Info to Warn level
> --
>
> Key: ZOOKEEPER-2315
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2315
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
>Affects Versions: 3.4.6
>Reporter: Lin Yiqun
>Priority: Minor
> Fix For: 3.4.7, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2315.001.patch, ZOOKEEPER-2315.002.patch
>
>
> Recently my the resourmanager of my hadoop cluster is fail suddenly,so I
> look into the rsourcemanager log.But the log is not helpful for me to direct
> find the reson until I found the zk timeout info log record.
> {code}
> 2015-11-06 06:34:11,257 INFO
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerNode:
> Assigned container container_1446016482901_292094_01_000140 of capacity
> on host mofa2089:41361, which has 30 containers,
> used and available after
> allocation
> 2015-11-06 06:34:11,266 INFO org.apache.zookeeper.ClientCnxn: Unable to
> reconnect to ZooKeeper service, session 0x24f4fd5118e5c6e has expired,
> closing socket connection
> 2015-11-06 06:34:11,271 INFO
> org.apache.hadoop.yarn.server.resourcemanager.rmcontainer.RMContainerImpl:
> container_1446016482901_292094_01_000105 Container Transitioned from RUNNING
> to COMPLETED
> 2015-11-06 06:34:11,271 INFO
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSAppAttempt:
> Completed container: container_1446016482901_292094_01_000105 in state:
> COMPLETED event:FINISHED
> 2015-11-06 06:34:11,271 INFO
> org.apache.hadoop.yarn.server.resourcemanager.RMAuditLogger: USER=dongwei
> OPERATION=AM Released Container TARGET=SchedulerApp RESULT=SUCCESS
> APPID=application_1446016482901_292094
> CONTAINERID=container_1446016482901_292094_01_000105
> 2015-11-06 06:34:11,271 INFO
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerNode:
> Released container container_1446016482901_292094_01_000105 of capacity
> on host mofa010079:50991, which currently has 29
> containers, used and
> available, release resources=true
> 2015-11-06 06:34:11,271 INFO
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler:
> Application attempt appattempt_1446016482901_292094_01 released container
> container_1446016482901_292094_01_000105 on node: host: mofa010079:50991
> #containers=29 available= used= vCores:29> with event: FINISHED
> 2015-11-06 06:34:11,272 INFO
> org.apache.hadoop.yarn.server.resourcemanager.rmcontainer.RMContainerImpl:
> container_1446016482901_292094_01_000141 Container Transitioned from NEW to
> ALLOCATED
> 2015-11-06 06:34:11,272 INFO
> org.apache.hadoop.yarn.server.resourcemanager.RMAuditLogger: USER=dongwei
> OPERATION=AM Allocated ContainerTARGET=SchedulerApp
> RESULT=SUCCESS APPID=application_1446016482901_292094
> CONTAINERID=container_1446016482901_292094_01_000141
> 2015-11-06 06:34:11,272 INFO
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerNode:
> Assigned container container_1446016482901_292094_01_000141 of capacity
> on host mofa010079:50991, which has 30 containers,
> used and available after
> allocation
> 2015-11-06 06:34:11,295 WARN
> org.apache.hadoop.yarn.server.resourcemanager.amlauncher.ApplicationMasterLauncher:
>
> org.apache.hadoop.yarn.server.resourcemanager.amlauncher.ApplicationMasterLauncher$LauncherThread
> interrupted. Returning.
> 2015-11-06 06:34:11,296 INFO org.apache.hadoop.ipc.Server: Stopping server on
> 8032
> 2015-11-06 06:34:11,297 INFO org.apache.hadoop.ipc.Server: Stopping IPC
> Server Responder
> 2015-11-06 06:34:11,297 INFO org.apache.hadoop.ipc.Server: Stopping server on
> 8030
> 2015-11-06 06:34:11,297 INFO org.apache.hadoop.ipc.Server: Stopping IPC
> Server listener on 8032
> 2015-11-06 06:34:11,298 INFO org.apache.hadoop.ipc.Server: Stopping IPC
> Server Responder
> 2015-11-06 06:34:11,298 INFO
[jira] [Commented] (ZOOKEEPER-2240) Make the three-node minimum more explicit in documentation and on website
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14995892#comment-14995892 ] Hudson commented on ZOOKEEPER-2240: --- SUCCESS: Integrated in ZooKeeper-trunk #2813 (See [https://builds.apache.org/job/ZooKeeper-trunk/2813/]) ZOOKEEPER-2240: Make the three-node minimum more explicit in documentation and on website (Shawn Heisey via rgs) (rgs: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1713320]) * trunk/CHANGES.txt * trunk/docs/zookeeperAdmin.html * trunk/docs/zookeeperStarted.html > Make the three-node minimum more explicit in documentation and on website > - > > Key: ZOOKEEPER-2240 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2240 > Project: ZooKeeper > Issue Type: Improvement > Components: documentation >Reporter: Shawn Heisey >Assignee: Shawn Heisey >Priority: Trivial > Fix For: 3.4.7, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2240.patch, ZOOKEEPER-2240.patch > > > One of the most important parts of a production zookeeper deployment is the > three-node minimum requirement for fault tolerance ... but when I glance at > the website and the documentation, this requirement is difficult to actually > find. > It is buried deep in the admin documentation, in a sentence that says "Thus, > a deployment that consists of three machines can handle one failure, and a > deployment of five machines can handle two failures." Other parts of the > documentation hint at it, but nothing that I've seen comes out and explicitly > says it. > Ideally, documentation about this requirement would be in a location where it > can be easily pinpointed with a targeted URL, so I can point to ZK > documentation with a link and clearly tell SolrCloud users that this is a > real requirement. > If someone can point me to version control locations where I can check out or > clone the docs and the website, I'm happy to attempt a patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1872) QuorumPeer is not shutdown in few cases
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986972#comment-14986972 ] Hudson commented on ZOOKEEPER-1872: --- SUCCESS: Integrated in ZooKeeper-trunk #2810 (See [https://builds.apache.org/job/ZooKeeper-trunk/2810/]) ZOOKEEPER-1872: QuorumPeer is not shutdown in few cases (Rakesh R. via rgs) (rgs: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1712218]) * trunk/CHANGES.txt * trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java * trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java * trunk/src/java/test/org/apache/zookeeper/test/JMXEnv.java * trunk/src/java/test/org/apache/zookeeper/test/LeaderSessionTrackerTest.java * trunk/src/java/test/org/apache/zookeeper/test/QuorumTest.java > QuorumPeer is not shutdown in few cases > --- > > Key: ZOOKEEPER-1872 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1872 > Project: ZooKeeper > Issue Type: Sub-task >Reporter: Rakesh R >Assignee: Rakesh R > Labels: test > Fix For: 3.4.7, 3.5.2, 3.6.0 > > Attachments: LeaderSessionTrackerTest-output.txt, > ZOOKEEPER-1872.patch, ZOOKEEPER-1872.patch, ZOOKEEPER-1872.patch, > ZOOKEEPER-1872.patch, ZOOKEEPER-1872.patch, ZOOKEEPER-1872.patch, > ZOOKEEPER-1872.patch, ZOOKEEPER-1872.patch, ZOOKEEPER-1872.patch, > ZOOKEEPER-1872.patch, ZOOKEEPER-1872.patch, ZOOKEEPER-1872_br3_4.patch, > ZOOKEEPER-1872_br3_4.patch, stack-trace.txt > > > Few cases are leaving quorumpeer running after the test case execution. Needs > proper teardown for these. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2142) JMX ObjectName is incorrect for observers
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984210#comment-14984210 ] Hudson commented on ZOOKEEPER-2142: --- FAILURE: Integrated in ZooKeeper-trunk #2805 (See [https://builds.apache.org/job/ZooKeeper-trunk/2805/]) ZOOKEEPER-2142: JMX ObjectName is incorrect for observers (Edward Ribeiro via michim) (michim: [http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1711694]) * trunk/CHANGES.txt * trunk/src/java/main/org/apache/zookeeper/server/ObserverBean.java > JMX ObjectName is incorrect for observers > - > > Key: ZOOKEEPER-2142 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2142 > Project: ZooKeeper > Issue Type: Bug >Affects Versions: 3.4.6, 3.5.1 >Reporter: Karol Dudzinski >Assignee: Edward Ribeiro >Priority: Trivial > Fix For: 3.4.7, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2142, ZOOKEEPER-2142.2.patch > > > Observers show up in JMX as StandaloneServer rather than Observer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2302) Some test cases are not running because wrongly named
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979479#comment-14979479
]
Hudson commented on ZOOKEEPER-2302:
---
FAILURE: Integrated in ZooKeeper-trunk #2804 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2804/])
ZOOKEEPER-2302: Some test cases are not running because wrongly named (Arshad
Mohammad via fpj) (fpj:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1711151])
* trunk/CHANGES.txt
*
trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerConfigTest.java
* trunk/src/java/test/org/apache/zookeeper/server/quorum/RemotePeerBeanTest.java
*
trunk/src/java/test/org/apache/zookeeper/server/quorum/TestQuorumPeerConfig.java
* trunk/src/java/test/org/apache/zookeeper/server/quorum/TestRemotePeerBean.java
> Some test cases are not running because wrongly named
> -
>
> Key: ZOOKEEPER-2302
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2302
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2302-01.patch
>
>
> When run ZooKeeper test cases following two test classes never run because
> wrong naming convention is followed.
> {code}
> org.apache.zookeeper.server.quorum.TestQuorumPeerConfig
> org.apache.zookeeper.server.quorum.TestRemotePeerBean
> {code}
> Name of these test classes should be changed to
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfigTest
> org.apache.zookeeper.server.quorum.RemotePeerBeanTest
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1460) IPv6 literal address not supported for quorum members
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14962517#comment-14962517
]
Hudson commented on ZOOKEEPER-1460:
---
FAILURE: Integrated in ZooKeeper-trunk #2803 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2803/])
ZOOKEEPER-1460: IPv6 literal address not supported for quorum members (Joseph
Walton via cnauroth) (cnauroth:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1709293])
* trunk/CHANGES.txt
* trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
* trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumServerTest.java
> IPv6 literal address not supported for quorum members
> -
>
> Key: ZOOKEEPER-1460
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1460
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
>Affects Versions: 3.4.3
>Reporter: Chris Dolan
>Assignee: Joseph Walton
> Fix For: 3.5.2, 3.6.0
>
> Attachments:
> ZOOKEEPER-1460-accept-square-bracket-delimited-IPv6-literals.2.diff,
> ZOOKEEPER-1460-accept-square-bracket-delimited-IPv6-literals.diff,
> ZOOKEEPER-1460-for-3.5.0.patch, ZOOKEEPER-1460.003.patch
>
>
> Via code inspection, I see that the "server.nnn" configuration key does not
> support literal IPv6 addresses because the property value is split on ":". In
> v3.4.3, the problem is in QuorumPeerConfig:
> {noformat}
> String parts[] = value.split(":");
> InetSocketAddress addr = new InetSocketAddress(parts[0],
> Integer.parseInt(parts[1]));
> {noformat}
> In the current trunk
> (http://svn.apache.org/viewvc/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?view=markup)
> this code has been refactored into QuorumPeer.QuorumServer, but the bug
> remains:
> {noformat}
> String serverClientParts[] = addressStr.split(";");
> String serverParts[] = serverClientParts[0].split(":");
> addr = new InetSocketAddress(serverParts[0],
> Integer.parseInt(serverParts[1]));
> {noformat}
> This bug probably affects very few users because most will naturally use a
> hostname rather than a literal IP address. But given that IPv6 addresses are
> supported for clients via ZOOKEEPER-667 it seems that server support should
> be fixed too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2268) Zookeeper doc creation fails on windows
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942464#comment-14942464
]
Hudson commented on ZOOKEEPER-2268:
---
FAILURE: Integrated in ZooKeeper-trunk #2802 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2802/])
ZOOKEEPER-2268: Zookeeper doc creation fails on windows (Arshad Mohammad via
cnauroth) (cnauroth:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1706628])
* trunk/CHANGES.txt
* trunk/build.xml
> Zookeeper doc creation fails on windows
> ---
>
> Key: ZOOKEEPER-2268
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2268
> Project: ZooKeeper
> Issue Type: Bug
> Components: build
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.4.7, 3.5.2
>
> Attachments: ZOOKEEPER-2268-01.patch
>
>
> Zookeeper doc creation fails on windows with following error
> {code}
> D:\gitHome\zookeeper-trunk\build.xml:484: Execute failed:
> java.io.IOException: Cannot run program
> "C:\non-install\apache-forrest-0.9\bin\forrest"
> y "D:\gitHome\zookeeper-trunk\src\docs"): CreateProcess error=193, %1 is not
> a valid Win32 application
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2281) ZK Server startup fails if there are spaces in the JAVA_HOME path
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942465#comment-14942465
]
Hudson commented on ZOOKEEPER-2281:
---
FAILURE: Integrated in ZooKeeper-trunk #2802 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2802/])
ZOOKEEPER-2281: ZK Server startup fails if there are spaces in the JAVA_HOME
path (Neha Bathra via cnauroth) (cnauroth:
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1706631])
* trunk/CHANGES.txt
* trunk/bin/zkEnv.cmd
> ZK Server startup fails if there are spaces in the JAVA_HOME path
> -
>
> Key: ZOOKEEPER-2281
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2281
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Environment: Windows
>Reporter: neha
>Assignee: neha
>Priority: Minor
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2281-00.patch, ZOOKEEPER-2281-01.patch,
> ZOOKEEPER-2281-02.patch
>
>
> Zookeeper startup fails if there are spaces in the %JAVA_HOME% variable.
> {code}
> if not exist %JAVA_HOME%\bin\java.exe (
> echo Error: JAVA_HOME is incorrectly set.
> goto :eof
> )
> set JAVA=%JAVA_HOME%\bin\java
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2244) On Windows zookeeper fails to restart
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934524#comment-14934524
]
Hudson commented on ZOOKEEPER-2244:
---
FAILURE: Integrated in ZooKeeper-trunk #2801 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2801/])
ZOOKEEPER-2244: On Windows zookeeper fails to restart (Arshad Mohammad via
rakeshr) (rakeshr:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1705794)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/ReconfigLegacyTest.java
> On Windows zookeeper fails to restart
> -
>
> Key: ZOOKEEPER-2244
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Critical
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2244-01.patch, ZOOKEEPER-2244-02.patch,
> ZOOKEEPER-2244-03.patch, ZOOKEEPER-2244-04.patch, ZOOKEEPER-2244-05.patch,
> ZOOKEEPER-2244-06.patch, ZOOKEEPER-2244-07.patch, ZOOKEEPER-2244-09.patch
>
>
> This issue occurs in following scenario
> 1) configure server properties in zookeeper configuration file(zoo.cfg)
> example:
> {code}
> server.1=localhost:43222:43225:participant;0.0.0.0:43228
> server.2=localhost:43223:43226:participant;0.0.0.0:43229
> server.3=localhost:43224:43227:participant;0.0.0.0:43230
> {code}
> 2) start the servers on windows. All the servers started successfully
> 3) stop any of the server
> 4) try to start the stopped server. It fails with following error
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error
> processing D:SystemTestCasesZKServer1confzoo.cfg.dynamic.1
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2253) C asserts ordering of ping requests, while Java client does not
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14909487#comment-14909487 ] Hudson commented on ZOOKEEPER-2253: --- FAILURE: Integrated in ZooKeeper-trunk #2800 (See [https://builds.apache.org/job/ZooKeeper-trunk/2800/]) ZOOKEEPER-2253: C asserts ordering of ping requests, while Java client does not (Chris Chen via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1705482) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/c/src/zookeeper.c * /zookeeper/trunk/src/c/tests/TestOperations.cc > C asserts ordering of ping requests, while Java client does not > --- > > Key: ZOOKEEPER-2253 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2253 > Project: ZooKeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.5.0 >Reporter: Chris Chen > Attachments: ZOOKEEPER-2253.patch, ZOOKEEPER-2253.patch, > ZOOKEEPER-2253.patch, zookeeper-2253-3.4.patch > > > Affects C clients from 3.3 to trunk. > The Java client does not enforce ordering on ping requests. It merely updates > fields when a ping reply is received and schedules a new ping request when > necessary. > The C client actually enqueues the void response in the completion data > structure and pulls it off when it gets a response. > This sounds like an implementation detail (and it is, sort of), but if a > future server were to, say, send unsolicited ping replies to a client to > assert liveness, it would work fine against a Java client but would cause a C > client to fail the assertion in zookeeper_process, "assert(cptr)", line 2912, > zookeeper.c. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1803) Add description for pzxid in programmer's guide.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14907750#comment-14907750 ] Hudson commented on ZOOKEEPER-1803: --- FAILURE: Integrated in ZooKeeper-trunk #2799 (See [https://builds.apache.org/job/ZooKeeper-trunk/2799/]) ZOOKEEPER-1803: Add description for pzxid in programmer's guide(Arshad Mohammad via rakeshr) (rakeshr: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1705225) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml > Add description for pzxid in programmer's guide. > > > Key: ZOOKEEPER-1803 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1803 > Project: ZooKeeper > Issue Type: Bug > Components: documentation >Reporter: Leader Ni >Assignee: Arshad Mohammad > Fix For: 3.4.7, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-1803-02.patch, zookeeperProgrammers.html.patch > > > The Stat（org.apache.zookeeper.data.Stat） Structures has the filed pzxid, but > no document about it in programmer's > guide（http://zookeeper.apache.org/doc/r3.4.3/zookeeperProgrammers.html#sc_zkStatStructure） -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2279) QuorumPeer loadDataBase() error message is incorrect
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14907749#comment-14907749
]
Hudson commented on ZOOKEEPER-2279:
---
FAILURE: Integrated in ZooKeeper-trunk #2799 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2799/])
ZOOKEEPER-2279: QuorumPeer loadDataBase() error message is incorrect(Arshad
Mohammad via rakeshr) (rakeshr:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1705221)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
> QuorumPeer loadDataBase() error message is incorrect
> -
>
> Key: ZOOKEEPER-2279
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2279
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
>Affects Versions: 3.5.0, 3.5.1
>Reporter: sunhaitao
>Assignee: Arshad Mohammad
> Fix For: 3.4.7, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2279-01.patch
>
>
> in loadDataBase() method, the below info is incorrect.
> if (acceptedEpoch < currentEpoch) {
> throw new IOException("The current epoch, " +
> ZxidUtils.zxidToString(currentEpoch) + " is less than the accepted epoch, " +
> ZxidUtils.zxidToString(acceptedEpoch));
> }
> It should print:
> Change the message to ("The accepted epoch, " +
> ZxidUtils.zxidToString(acceptedEpoch) + " is less than the current epoch, " +
> ZxidUtils.zxidToString(currentEpoch)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2040) Server to log underlying cause of SASL connection problems
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740310#comment-14740310 ] Hudson commented on ZOOKEEPER-2040: --- SUCCESS: Integrated in ZooKeeper-trunk #2798 (See [https://builds.apache.org/job/ZooKeeper-trunk/2798/]) ZOOKEEPER-2040: Server to log underlying cause of SASL connection problems. (Steve Loughran via cnauroth) (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1702378) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java > Server to log underlying cause of SASL connection problems > -- > > Key: ZOOKEEPER-2040 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2040 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.6 >Reporter: Steve Loughran >Assignee: Steve Loughran > Fix For: 3.4.7, 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2040-log-SASL-errors-001.patch, > ZOOKEEPER-2040.002.patch > > > When you have SASL connectivity problems, you spend time staring at logs > —ideally logs with stack traces. > ZK server can help here by including the stack traces when there is a SASL > auth problem, rather than just giving the text of the exception. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2270) Allow MBeanRegistry to be overridden for better unit tests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738141#comment-14738141 ] Hudson commented on ZOOKEEPER-2270: --- SUCCESS: Integrated in ZooKeeper-trunk #2796 (See [https://builds.apache.org/job/ZooKeeper-trunk/2796/]) ZOOKEEPER-2270: Allow MBeanRegistry to be overridden for better unit tests (Jordan Zimmerman via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1702156) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/jmx/MBeanRegistry.java > Allow MBeanRegistry to be overridden for better unit tests > -- > > Key: ZOOKEEPER-2270 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2270 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Affects Versions: 3.4.6, 3.5.1 >Reporter: Jordan Zimmerman >Assignee: Jordan Zimmerman > Attachments: ZOOKEEPER-2270.2.patch, ZOOKEEPER-2270.patch > > > Apache Curator currently must use byte code re-writing to prevent the > MBeanRegistry from polluting the Platform MBeanServer. Provide a simple way > to avoid this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2269) NullPointerException in RemotePeerBean
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738198#comment-14738198
]
Hudson commented on ZOOKEEPER-2269:
---
SUCCESS: Integrated in ZooKeeper-trunk #2797 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2797/])
ZOOKEEPER-2269: NullPointerException in RemotePeerBean
(Arshad Mohammad via rgs) (rgs:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1702163)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/RemotePeerBean.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/TestRemotePeerBean.java
> NullPointerException in RemotePeerBean
> ---
>
> Key: ZOOKEEPER-2269
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2269
> Project: ZooKeeper
> Issue Type: Bug
> Components: jmx
>Affects Versions: 3.5.0
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2269-01.patch
>
>
> {code}org.apache.zookeeper.server.quorum.RemotePeerBean.getClientAddress(){code}
> throws NullPointerException when clientPort is not part of dynamic
> configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2264) Wrong error message when secureClientPortAddress is configured but secureClientPort is not configured
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14732500#comment-14732500
]
Hudson commented on ZOOKEEPER-2264:
---
SUCCESS: Integrated in ZooKeeper-trunk #2795 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2795/])
ZOOKEEPER-2264: Wrong error message when secureClientPortAddress is configured
but secureClientPort is not configured (Arshad Mohammad via rakeshr) (rakeshr:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1701505)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/TestQuorumPeerConfig.java
> Wrong error message when secureClientPortAddress is configured but
> secureClientPort is not configured
> --
>
> Key: ZOOKEEPER-2264
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2264
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>Priority: Minor
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2264-01.patch
>
>
> # Wrong error message when secureClientPortAddress is configured but
> secureClientPort is not configured.
> zookeeper throws IllegalArgumentException with error message
> {{clientPortAddress is set but clientPort is not set}} but should be
> {{secureClientPortAddress is set but secureClientPort is not set}}
> # There is another problem with the same code.
> value is assigned to local variable but null check is done on instance
> variable so we will never get error message for this scenario.
> {code}if (this.secureClientPortAddress != null) {{code}
> should be replaced with
> {code}if (secureClientPortAddress != null) {{code}
> # Above problem is there for clientPort scenario also. So we should replace
> {code}if (this.clientPortAddress != null) {{code}
> with
> {code}if (clientPortAddress != null) {{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2256) Zookeeper is not using specified JMX port in zkEnv.sh
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716082#comment-14716082
]
Hudson commented on ZOOKEEPER-2256:
---
SUCCESS: Integrated in ZooKeeper-trunk #2794 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2794/])
ZOOKEEPER-2256: Zookeeper is not using specified JMX port in zkEnv.sh(Arshad
Mohammad via rakeshr) (rakeshr:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1698058)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/bin/zkServer.sh
Zookeeper is not using specified JMX port in zkEnv.sh
-
Key: ZOOKEEPER-2256
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2256
Project: ZooKeeper
Issue Type: Bug
Affects Versions: 3.5.0
Reporter: Arshad Mohammad
Assignee: Arshad Mohammad
Priority: Minor
Fix For: 3.4.7, 3.5.2, 3.6.0
Attachments: ZOOKEEPER-2256-01.patch
Zookeeper is not using specified JMX port.
I put bellow entry in zkEnv.sh
{{export JMXPORT=12345}}
But zookeeper still uses random port for jmx.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1927) zkServer.sh fails to read dataDir (and others) from zoo.cfg on Solaris 10 (grep issue, manifests as FAILED TO WRITE PID).
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14710709#comment-14710709 ] Hudson commented on ZOOKEEPER-1927: --- FAILURE: Integrated in ZooKeeper-trunk #2793 (See [https://builds.apache.org/job/ZooKeeper-trunk/2793/]) ZOOKEEPER-1927: zkServer.sh fails to read dataDir (and others) from zoo.cfg on Solaris 10 (grep issue, manifests as FAILED TO WRITE PID) (Chris Nauroth via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1697551) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/bin/zkServer.sh zkServer.sh fails to read dataDir (and others) from zoo.cfg on Solaris 10 (grep issue, manifests as FAILED TO WRITE PID). --- Key: ZOOKEEPER-1927 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1927 Project: ZooKeeper Issue Type: Bug Components: scripts Affects Versions: 3.4.6 Environment: Solaris 5.10 Reporter: Ed Schmed Assignee: Chris Nauroth Fix For: 3.4.7, 3.5.2, 3.6.0 Attachments: ZOOKEEPER-1927-branch-3.4.002.patch, ZOOKEEPER-1927.001.patch, ZOOKEEPER-1927.002.patch Fails to write PID file with a permissions error, because the startup script fails to read the dataDir variable from zoo.cfg, and then tries to use the drive root ( / ) as the data dir. Tracked the problem down to line 84 of zkServer.sh: ZOO_DATADIR=$(grep ^[[:space:]]*dataDir $ZOOCFG | sed -e 's/.*=//') If i run just that line and point it right at the config file, ZOO_DATADIR is empty. If I remove [[:space:]]* from the grep: ZOO_DATADIR=$(grep ^dataDir $ZOOCFG | sed -e 's/.*=//') Then it works fine. (If I also make the same change on line 164 and 169) My regex skills are pretty bad, so I'm afraid to comment on why [[space]]* needs to be in there? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2245) SimpleSysTest test cases fails
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14708454#comment-14708454
]
Hudson commented on ZOOKEEPER-2245:
---
SUCCESS: Integrated in ZooKeeper-trunk #2792 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2792/])
ZOOKEEPER-2245: SimpleSysTest test cases fails
(Arshad Mohammad via rgs) (rgs:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1697227)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java
*
/zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/SimpleClient.java
SimpleSysTest test cases fails
--
Key: ZOOKEEPER-2245
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2245
Project: ZooKeeper
Issue Type: Bug
Affects Versions: 3.5.0
Reporter: Arshad Mohammad
Assignee: Arshad Mohammad
Fix For: 3.5.2
Attachments: ZOOKEEPER-2245-01.patch, ZOOKEEPER-2245-02.patch,
ZOOKEEPER-2245-03.patch, ZOOKEEPER-2245-04.patch
When {{org.apache.zookeeper.test.system.SimpleSysTest}} is run for in-memory
Zookeeper Servers, by specifying baseSysTest.fakeMachines=yes, it fails. Its
displays following errors
1:{code}
java.io.IOException:
org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Address
unresolved: 127.0.0.1:participant
at org.apache.zookeeper.server.quorum.Leader.lead(Leader.java:474)
at
org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:1077)
Caused by:
org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Address
unresolved: 127.0.0.1:participant
at
org.apache.zookeeper.server.quorum.QuorumPeer$QuorumServer.init(QuorumPeer.java:221)
{code}
2:
{code}
java.lang.NullPointerException
at
org.apache.zookeeper.test.system.BaseSysTest.tearDown(BaseSysTest.java:66)
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2239) JMX State from LocalPeerBean incorrect
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659960#comment-14659960 ] Hudson commented on ZOOKEEPER-2239: --- SUCCESS: Integrated in ZooKeeper-trunk #2776 (See [https://builds.apache.org/job/ZooKeeper-trunk/2776/]) ZOOKEEPER-2239: JMX State from LocalPeerBean incorrect (Kevin Lee via rgs) Signed-off-by: Raul Gutierrez S r...@itevenworks.net (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1694317) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LocalPeerBean.java JMX State from LocalPeerBean incorrect -- Key: ZOOKEEPER-2239 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2239 Project: ZooKeeper Issue Type: Bug Components: jmx Affects Versions: 3.4.6, 3.5.0, 3.5.1 Environment: All Reporter: Kevin Lee Fix For: 3.4.7, 3.5.2, 3.6.0 Attachments: ZOOKEEPER-2239.patch The State property of LocalPeerBean in package org.apache.zookeeper.server.quorum is returning the incorrect value. It is performing peer.getState() which is calling the getState() method on java.lang.Thread instead of getting the server state from org.apache.zookeeper.server.quorum.QuorumPeer. The Javadoc within LocalPeerMXBean.java states that it should be returning the server state as well. The fix is to call peer.getServerState() in the getState() method of LocalPeerBean instead of peer.getState().toString(). This will return the states defined in QuorumStats.Provider (unknown, leaderelection, leading, following, and observing). This issue prevents JMX monitoring of the Zookeeper server state. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2235) License update
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14644227#comment-14644227 ] Hudson commented on ZOOKEEPER-2235: --- SUCCESS: Integrated in ZooKeeper-trunk #2767 (See [https://builds.apache.org/job/ZooKeeper-trunk/2767/]) ZOOKEEPER-2235 License update (fpj via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1692989) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/build.xml * /zookeeper/trunk/src/LICENSE.txt * /zookeeper/trunk/src/NOTICE.txt * /zookeeper/trunk/src/java/lib/javacc.LICENSE.txt * /zookeeper/trunk/src/java/lib/servlet-api-2.5.LICENSE.txt * /zookeeper/trunk/src/java/lib/slf4j-1.7.5.LICENSE.txt License update -- Key: ZOOKEEPER-2235 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2235 Project: ZooKeeper Issue Type: Bug Affects Versions: 3.4.6, 3.5.0 Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.7, 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2235-3.4.patch, ZOOKEEPER-2235-3.5.patch, ZOOKEEPER-2235.patch, ZOOKEEPER-2235.patch, ZOOKEEPER-2235.patch, ZOOKEEPER-2235.patch, ZOOKEEPER-2235.patch, notice-dependencies.txt Updating license files and notice.txt as needed. Here is a list of the jars we are currently bundling with the release artifact with the corresponding license: # commons-cli-1.2.jar -- ASF # javacc.jar -- BSD license # jline-2.11.jar -- BSD license # servlet-api-2.5-20081211.jar - CDDL # jackson-core-asl-1.9.11.jar -- ALv2 # jetty-6.1.26.jar -- ALv2 # log4j-1.2.16.jar -- ALv2 # jackson-mapper-asl-1.9.11.jar -- ALv2 # jetty-util-6.1.26.jar -- ALv2 # netty-3.7.0.Final.jar -- ALv2 # slf4j-log4j12-1.7.5.jar -- MIT -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1423) 4lw and jmx should expose the size of the datadir/datalogdir
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14622141#comment-14622141 ] Hudson commented on ZOOKEEPER-1423: --- SUCCESS: Integrated in ZooKeeper-trunk #2749 (See [https://builds.apache.org/job/ZooKeeper-trunk/2749/]) ZOOKEEPER-1423: 4lw and jmx should expose the size of the datadir/datalogdir (Edward Ribeiro via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1690207) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ServerStats.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServerMXBean.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/admin/Commands.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/CommandExecutor.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/DirsCommand.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsQuorumTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java 4lw and jmx should expose the size of the datadir/datalogdir Key: ZOOKEEPER-1423 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423 Project: ZooKeeper Issue Type: Improvement Components: jmx Affects Versions: 3.5.0 Reporter: Patrick Hunt Assignee: Edward Ribeiro Labels: newbie Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.3.patch, ZOOKEEPER-1423.4.patch, ZOOKEEPER-1423.5.patch, ZOOKEEPER-1423.6.patch, ZOOKEEPER-1423.7.patch, ZOOKEEPER-1423.8.patch, ZOOKEEPER-1423.patch There are no metrics currently available on the size of the datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It would be good to expose these metrics through jmx/4lw such that monitoring can be done on the size. Would key ppl in on whether cleanup was actually running. In particular this could be monitored/alerted on by third party systems (nagios, ganglia and the like). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2223) support method-level JUnit testcase
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616493#comment-14616493 ] Hudson commented on ZOOKEEPER-2223: --- FAILURE: Integrated in ZooKeeper-trunk #2746 (See [https://builds.apache.org/job/ZooKeeper-trunk/2746/]) ZOOKEEPER-2223: support method-level JUnit testcase (Akihiro Suda via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1689571) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/build.xml * /zookeeper/trunk/ivy.xml * /zookeeper/trunk/src/contrib/rest/build.xml * /zookeeper/trunk/src/contrib/rest/ivy.xml * /zookeeper/trunk/src/contrib/rest/src/test/org/apache/zookeeper/server/jersey/Base.java * /zookeeper/trunk/src/contrib/rest/src/test/org/apache/zookeeper/server/jersey/CreateTest.java * /zookeeper/trunk/src/contrib/rest/src/test/org/apache/zookeeper/server/jersey/DeleteTest.java * /zookeeper/trunk/src/contrib/rest/src/test/org/apache/zookeeper/server/jersey/ExistsTest.java * /zookeeper/trunk/src/contrib/rest/src/test/org/apache/zookeeper/server/jersey/GetChildrenTest.java * /zookeeper/trunk/src/contrib/rest/src/test/org/apache/zookeeper/server/jersey/GetTest.java * /zookeeper/trunk/src/contrib/rest/src/test/org/apache/zookeeper/server/jersey/RootTest.java * /zookeeper/trunk/src/contrib/rest/src/test/org/apache/zookeeper/server/jersey/SessionTest.java * /zookeeper/trunk/src/contrib/rest/src/test/org/apache/zookeeper/server/jersey/SetTest.java * /zookeeper/trunk/src/contrib/rest/src/test/org/apache/zookeeper/server/jersey/WadlTest.java * /zookeeper/trunk/src/contrib/zooinspector/ivy.xml * /zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java * /zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/SimpleSysTest.java * /zookeeper/trunk/src/java/test/org/apache/jute/BinaryInputArchiveTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/ClientReconnectTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/CustomHostProviderTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/JUnit4ZKTestRunner.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/MultiResponseTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/MultiTransactionRecordTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/PortAssignmentTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/RemoveWatchesTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/VerGenTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/ZKParameterized.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/common/PathUtilsTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/common/TimeTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/DatadirCleanupManagerTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/NIOServerCnxnTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/NettyServerCnxnTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/WatchesPathReportTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/WatchesReportTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/WatchesSummaryTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/ZooKeeperServerConfTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/ZxidRolloverTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/admin/CommandResponseTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/FLETestUtils.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumRequestPipelineTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/WatchLeakTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/util/VerifyingFileFactoryTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientBase.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/JMXEnv.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/OSMXBeanTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/SessionInvalidationTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/StringUtilTest.java *
[jira] [Commented] (ZOOKEEPER-2224) Four letter command hangs when network is slow
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614210#comment-14614210 ] Hudson commented on ZOOKEEPER-2224: --- SUCCESS: Integrated in ZooKeeper-trunk #2744 (See [https://builds.apache.org/job/ZooKeeper-trunk/2744/]) ZOOKEEPER-2224: Four letter command hangs when network is slow (Arshad Mohammad via rakeshr) (rakeshr: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1689211) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java Four letter command hangs when network is slow -- Key: ZOOKEEPER-2224 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224 Project: ZooKeeper Issue Type: Bug Components: java client Reporter: Arshad Mohammad Assignee: Arshad Mohammad Priority: Minor Fix For: 3.4.7, 3.5.2, 3.6.0 Attachments: ZOOKEEPER-2224-01.patch, ZOOKEEPER-2224-02.patch, ZOOKEEPER-2224-03.patch, ZOOKEEPER-2224-04.patch Four letter command hangs when network is slow or network goes down in between the operation, and the application also, which calling this four letter command, hangs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2221) Zookeeper JettyAdminServer server should start on configured IP.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609914#comment-14609914 ] Hudson commented on ZOOKEEPER-2221: --- SUCCESS: Integrated in ZooKeeper-trunk #2742 (See [https://builds.apache.org/job/ZooKeeper-trunk/2742/]) ZOOKEEPER-2221: Zookeeper JettyAdminServer server should start on configured IP (Surendra Singh Lilhore via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1688505) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/admin/JettyAdminServer.java Zookeeper JettyAdminServer server should start on configured IP. Key: ZOOKEEPER-2221 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2221 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.5.0 Reporter: Surendra Singh Lilhore Assignee: Surendra Singh Lilhore Fix For: 3.5.2, 3.6.0 Attachments: ZOOKEEPER-2221.patch, ZOOKEEPER-2221.patch, ZOOKEEPER-2221.patch, ZOOKEEPER-2221.patch, ZOOKEEPER-2221_1.patch Currently JettyAdminServer starting on 0.0.0.0 IP. 0.0.0.0 means all IP addresses on the local machine. So, if your webserver machine has two ip addresses, 192.168.1.1(private) and 10.1.2.1(public), and you allow a webserver daemon like apache to listen on 0.0.0.0, it will be reachable at both of those IPs. This is security issue. webserver should be accessible from only configured IP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2140) NettyServerCnxn and NIOServerCnxn code should be improved
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605417#comment-14605417
]
Hudson commented on ZOOKEEPER-2140:
---
SUCCESS: Integrated in ZooKeeper-trunk #2741 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2741/])
ZOOKEEPER-2140: NettyServerCnxn and NIOServerCnxn code should be improved
(Arshad Mohammad via rgs) (rgs:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1688041)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ServerCnxn.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/AbstractFourLetterCommand.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/CnxnStatResetCommand.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/CommandExecutor.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/ConfCommand.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/ConsCommand.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/DumpCommand.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/EnvCommand.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/FourLetterCommands.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/IsroCommand.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/MonitorCommand.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/RuokCommand.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/SetTraceMaskCommand.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/StatCommand.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/StatResetCommand.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/TraceMaskCommand.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/command/WatchCommand.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java
NettyServerCnxn and NIOServerCnxn code should be improved
-
Key: ZOOKEEPER-2140
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2140
Project: ZooKeeper
Issue Type: Improvement
Reporter: Arshad Mohammad
Fix For: 3.6.0
Attachments: ZOOKEEPER-2140-1.patch, ZOOKEEPER-2140-2.patch,
ZOOKEEPER-2140-3.patch, ZOOKEEPER-2140-4.patch
Classes org.apache.zookeeper.server.NIOServerCnxn and
org.apache.zookeeper.server.NettyServerCnxn have following need and scope for
improvement
1) Duplicate code.
These two classes have around 250 line duplicate code. All the command
code is duplicated
2) Many improvement/bugFix done in one class but not done in other class.
These changes should be synced
For example
In NettyServerCnxn
{code}
// clone should be faster than iteration
// ie give up the cnxns lock faster
AbstractSetServerCnxn cnxns;
synchronized (factory.cnxns) {
cnxns = new HashSetServerCnxn(factory.cnxns);
}
for (ServerCnxn c : cnxns) {
c.dumpConnectionInfo(pw, false);
pw.println();
}
{code}
In NIOServerCnxn
{code}
for (ServerCnxn c : factory.cnxns) {
c.dumpConnectionInfo(pw, false);
pw.println();
}
{code}
3) NettyServerCnxn and NIOServerCnxn classes are bulky unnecessarily.
Command classes have altogether different functionality, the command classes
should go in different class files.
If this done it will be easy to add new command with minimal change to
existing classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2193) reconfig command completes even if parameter is wrong obviously
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604118#comment-14604118
]
Hudson commented on ZOOKEEPER-2193:
---
SUCCESS: Integrated in ZooKeeper-trunk #2739 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2739/])
ZOOKEEPER-2193: reconfig command completes even if parameter is wrong obviously
(Yasuhito Fukuda via rgs) (rgs:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1687876)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
reconfig command completes even if parameter is wrong obviously
---
Key: ZOOKEEPER-2193
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2193
Project: ZooKeeper
Issue Type: Bug
Components: leaderElection, server
Affects Versions: 3.5.0
Environment: CentOS7 + Java7
Reporter: Yasuhito Fukuda
Assignee: Yasuhito Fukuda
Attachments: ZOOKEEPER-2193-v2.patch, ZOOKEEPER-2193-v3.patch,
ZOOKEEPER-2193-v4.patch, ZOOKEEPER-2193-v5.patch, ZOOKEEPER-2193-v6.patch,
ZOOKEEPER-2193-v7.patch, ZOOKEEPER-2193-v8.patch, ZOOKEEPER-2193.patch
Even if reconfig parameter is wrong, it was confirmed to complete.
refer to the following.
- Ensemble consists of four nodes
{noformat}
[zk: vm-101:2181(CONNECTED) 0] config
server.1=192.168.100.101:2888:3888:participant
server.2=192.168.100.102:2888:3888:participant
server.3=192.168.100.103:2888:3888:participant
server.4=192.168.100.104:2888:3888:participant
version=1
{noformat}
- add node by reconfig command
{noformat}
[zk: vm-101:2181(CONNECTED) 9] reconfig -add
server.5=192.168.100.104:2888:3888:participant;0.0.0.0:2181
Committed new configuration:
server.1=192.168.100.101:2888:3888:participant
server.2=192.168.100.102:2888:3888:participant
server.3=192.168.100.103:2888:3888:participant
server.4=192.168.100.104:2888:3888:participant
server.5=192.168.100.104:2888:3888:participant;0.0.0.0:2181
version=30007
{noformat}
server.4 and server.5 of the IP address is a duplicate.
In this state, reader election will not work properly.
Besides, it is assumed an ensemble will be undesirable state.
I think that need a parameter validation when reconfig.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2210) clock_gettime is not available in os x
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14595750#comment-14595750
]
Hudson commented on ZOOKEEPER-2210:
---
SUCCESS: Integrated in ZooKeeper-trunk #2734 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2734/])
ZOOKEEPER-2210: clock_gettime is not available in OS X
(Michi Mutsuzaki via rgs) (rgs:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1686767)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/c/src/zookeeper.c
clock_gettime is not available in os x
--
Key: ZOOKEEPER-2210
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2210
Project: ZooKeeper
Issue Type: Bug
Components: c client
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Fix For: 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2210.patch, ZOOKEEPER-2210.patch
{noformat}
src/zookeeper.c:286:9: warning: implicit declaration of function
'clock_gettime' is invalid in C99 [-Wimplicit-function-declaration]
ret = clock_gettime(CLOCK_MONOTONIC, ts);
^
src/zookeeper.c:286:23: error: use of undeclared identifier 'CLOCK_MONOTONIC'
ret = clock_gettime(CLOCK_MONOTONIC, ts);
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2185) Run server with -XX:+HeapDumpOnOutOfMemoryError and -XX:OnOutOfMemoryError='kill %p'.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14593921#comment-14593921
]
Hudson commented on ZOOKEEPER-2185:
---
FAILURE: Integrated in ZooKeeper-trunk #2731 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2731/])
ZOOKEEPER-2185: Run server with -XX:+HeapDumpOnOutOfMemoryError and
-XX:OnOutOfMemoryError='kill %p' (Chris Nauroth via rgs) (rgs:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1686296)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/bin/zkServer.cmd
* /zookeeper/trunk/bin/zkServer.sh
* /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
Run server with -XX:+HeapDumpOnOutOfMemoryError and
-XX:OnOutOfMemoryError='kill %p'.
-
Key: ZOOKEEPER-2185
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2185
Project: ZooKeeper
Issue Type: Improvement
Components: documentation, scripts
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2185.001.patch
Continuing to run a server process after it runs out of memory can lead to
unexpected behavior. This issue proposes that we update scripts and
documentation to add these JVM options:
# {{-XX:+HeapDumpOnOutOfMemoryError}} for help with post-mortem analysis of
why the process ran out of memory.
# {{-XX:OnOutOfMemoryError='kill %p'}} to kill the JVM process, under the
assumption that a process monitor will restart it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2212) distributed race condition related to QV version
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14587866#comment-14587866
]
Hudson commented on ZOOKEEPER-2212:
---
FAILURE: Integrated in ZooKeeper-trunk #2728 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2728/])
ZOOKEEPER-2212: distributed race condition related to QV version
(Akihiro Suda via rgs) (rgs:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1685685)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
distributed race condition related to QV version
Key: ZOOKEEPER-2212
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2212
Project: ZooKeeper
Issue Type: Bug
Components: quorum
Affects Versions: 3.5.0
Reporter: Akihiro Suda
Assignee: Akihiro Suda
Priority: Critical
Fix For: 3.5.1, 3.6.0
Attachments:
0001-ZOOKEEPER-2212-distributed-race-condition-related-to.patch,
ZOOKEEPER-2212-v2.patch, ZOOKEEPER-2212-v3.patch
When a joiner is listed as an observer in an initial config,
the joiner should become a non-voting follower (not an observer) until
reconfig is triggered.
[(Link)|http://zookeeper.apache.org/doc/trunk/zookeeperReconfig.html#sc_reconfig_general]
I found a distributed race-condition situation where an observer keeps being
an observer and cannot become a non-voting follower.
This race condition happens when an observer receives an UPTODATE Quorum
Packet from the leader:2888/tcp *after* receiving a Notification FLE Packet
of which n.config version is larger than the observer's one from
leader:3888/tcp.
h4. Detail
* Problem: An observer cannot become a non-voting follower
* Cause: Cannot restart FLE
* Cause: In {{QuorumPeer.run()}}, cannot shutdown {{Observer}}
[(Link)|https://github.com/apache/zookeeper/blob/98a3cabfa279833b81908d72f1c10ee9f598a045/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java#L1014]
* Cause: In {{QuorumPeer.run()}}, cannot return from
{{Observer.observeLeader()}}
[(Link)|https://github.com/apache/zookeeper/blob/98a3cabfa279833b81908d72f1c10ee9f598a045/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java#L1010]
* Cause: In {{Observer.observeLeader()}}, {{Learner.syncWithLeader()}} does
not throw an exception of changes proposed in reconfig
[(Link)|https://github.com/apache/zookeeper/blob/98a3cabfa279833b81908d72f1c10ee9f598a045/src/java/main/org/apache/zookeeper/server/quorum/Observer.java#L79]
* Cause: In {{switch(qp.getType()) case UPTODATE}} of
{{Learner.syncWithLeader()}}
[(Link)|https://github.com/apache/zookeeper/blob/98a3cabfa279833b81908d72f1c10ee9f598a045/src/java/main/org/apache/zookeeper/server/quorum/Learner.java#L492-507],
{{QuorumPeer.processReconfig()}}
[(Link)|https://github.com/apache/zookeeper/blob/98a3cabfa279833b81908d72f1c10ee9f598a045/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java#L1644]returns
false with a log message like [2 setQuorumVerifier called with known or old
config 4294967296. Current version:
4294967296|https://github.com/osrg/earthquake/blob/v0.1/example/zk-found-bug.ether/example-output/3.REPRODUCED/zk2.log].
[(Link)|https://github.com/apache/zookeeper/blob/98a3cabfa279833b81908d72f1c10ee9f598a045/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java#L1369]
,
* Cause: The observer have already received a Notification
Packet({{n.config.version=4294967296}}) and invoked
{{QuorumPeer.processReconfig()}}
[(Link)|https://github.com/apache/zookeeper/blob/98a3cabfa279833b81908d72f1c10ee9f598a045/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java#L291-304]
h4. How I found this bug
I found this bug using [Earthquake|http://osrg.github.io/earthquake/], our
open-source dynamic model checker for real implementations of distributed
systems.
Earthquakes permutes C/Java function calls, Ethernet packets, and injected
fault events in various orders so as to find implementation-level bugs of the
distributed system.
When Earthquake finds a bug, Earthquake automatically records [the event
history|https://github.com/osrg/earthquake/blob/v0.1/example/zk-found-bug.ether/example-output/3.REPRODUCED/json]
and helps the user to analyze which permutation of events triggers the bug.
I analyzed Earthquake's event histories and found that the bug is triggered
when an observer receives an UPTODATE *after* receiving a specific kind of
FLE packet.
h4. How to reproduce this bug
You can also easily reproduce the bug using Earthquake.
I made a Docker container
[osrg/earthquake-zookeeper-2212|https://registry.hub.docker.com/u/osrg/earthquake-zookeeper-2212/]
on Docker hub:
{code}
[jira] [Commented] (ZOOKEEPER-706) large numbers of watches can cause session re-establishment to fail
[ https://issues.apache.org/jira/browse/ZOOKEEPER-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584554#comment-14584554 ] Hudson commented on ZOOKEEPER-706: -- FAILURE: Integrated in ZooKeeper-trunk #2725 (See [https://builds.apache.org/job/ZooKeeper-trunk/2725/]) ZOOKEEPER-706: Large numbers of watches can cause session re-establishment to fail (Chris Thunes via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1685200) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/DisconnectedWatcherTest.java large numbers of watches can cause session re-establishment to fail --- Key: ZOOKEEPER-706 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-706 Project: ZooKeeper Issue Type: Bug Components: c client, java client Affects Versions: 3.1.2, 3.2.2, 3.3.0 Reporter: Patrick Hunt Priority: Critical Fix For: 3.4.7, 3.5.2, 3.6.0 Attachments: ZOOKEEPER-706-branch-34.patch, ZOOKEEPER-706-branch-34.patch, ZOOKEEPER-706.patch, ZOOKEEPER-706.patch, ZOOKEEPER-706.patch If a client sets a large number of watches the set watches operation during session re-establishment can fail. for example: WARN [NIOServerCxn.Factory:22801:NIOServerCnxn@417] - Exception causing close of session 0xe727001201a4ee7c due to java.io.IOException: Len error 4348380 in this case the client was a web monitoring app and had set both data and child watches on 32k znodes. there are two issues I see here we need to fix: 1) handle this case properly (split up the set watches into multiple calls I guess...) 2) the session should have expired after the timeout. however we seem to consider any message from the client as re-setting the expiration on the server side. Probably we should only consider messages from the client that are sent during an established session, otherwise we can see this situation where the session is not established however the session is not expired either. Perhaps we should create another JIRA for this particular issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2214) Findbugs warning: LearnerHandler.packetToString Dead store to local variable
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584553#comment-14584553 ] Hudson commented on ZOOKEEPER-2214: --- FAILURE: Integrated in ZooKeeper-trunk #2725 (See [https://builds.apache.org/job/ZooKeeper-trunk/2725/]) ZOOKEEPER-2214: Findbugs warning: LearnerHandler.packetToString Dead store to local variable (Hongchao Deng via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1685167) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java Findbugs warning: LearnerHandler.packetToString Dead store to local variable Key: ZOOKEEPER-2214 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2214 Project: ZooKeeper Issue Type: Improvement Reporter: Hongchao Deng Assignee: Hongchao Deng Priority: Minor Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2214.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2213) Empty path in Set crashes server and prevents restart
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14583242#comment-14583242
]
Hudson commented on ZOOKEEPER-2213:
---
SUCCESS: Integrated in ZooKeeper-trunk #2724 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2724/])
ZOOKEEPER-2213: Empty path in Set crashes server and prevents restart
(Hongchao Deng via rgs) (rgs:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1684956)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java
Empty path in Set crashes server and prevents restart
-
Key: ZOOKEEPER-2213
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2213
Project: ZooKeeper
Issue Type: Bug
Components: server
Affects Versions: 3.4.5
Reporter: Brian Brazil
Assignee: Hongchao Deng
Priority: Blocker
Fix For: 3.4.7, 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2213-branch34.patch, ZOOKEEPER-2213.patch,
ZOOKEEPER-2213.patch, ZOOKEEPER-2213.patch, ZOOKEEPER-2213.patch
See https://github.com/samuel/go-zookeeper/issues/62
I've reproduced this on 3.4.5 with the code:
c, _, _ := zk.Connect([]string{127.0.0.1}, time.Second)
c.Set(, []byte{}, 0)
This crashes a local zookeeper 3.4.5 server:
2015-06-10 16:21:10,862 [myid:] - ERROR
[SyncThread:0:SyncRequestProcessor@151] - Severe unrecoverable error, exiting
java.lang.IllegalArgumentException: Invalid path
at
org.apache.zookeeper.common.PathTrie.findMaxPrefix(PathTrie.java:259)
at
org.apache.zookeeper.server.DataTree.getMaxPrefixWithQuota(DataTree.java:634)
at org.apache.zookeeper.server.DataTree.setData(DataTree.java:616)
at org.apache.zookeeper.server.DataTree.processTxn(DataTree.java:807)
at
org.apache.zookeeper.server.ZKDatabase.processTxn(ZKDatabase.java:329)
at
org.apache.zookeeper.server.ZooKeeperServer.processTxn(ZooKeeperServer.java:965)
at
org.apache.zookeeper.server.FinalRequestProcessor.processRequest(FinalRequestProcessor.java:116)
at
org.apache.zookeeper.server.SyncRequestProcessor.flush(SyncRequestProcessor.java:167)
at
org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:101)
On restart the zookeeper server crashes out:
2015-06-10 16:22:21,352 [myid:] - ERROR [main:ZooKeeperServerMain@54] -
Invalid arguments, exiting abnormally
java.lang.IllegalArgumentException: Invalid path
at
org.apache.zookeeper.common.PathTrie.findMaxPrefix(PathTrie.java:259)
at
org.apache.zookeeper.server.DataTree.getMaxPrefixWithQuota(DataTree.java:634)
at org.apache.zookeeper.server.DataTree.setData(DataTree.java:616)
at org.apache.zookeeper.server.DataTree.processTxn(DataTree.java:807)
at
org.apache.zookeeper.server.persistence.FileTxnSnapLog.processTransaction(FileTxnSnapLog.java:198)
at
org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:151)
at
org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:223)
at
org.apache.zookeeper.server.ZooKeeperServer.loadData(ZooKeeperServer.java:250)
at
org.apache.zookeeper.server.ZooKeeperServer.startdata(ZooKeeperServer.java:377)
at
org.apache.zookeeper.server.NIOServerCnxnFactory.startup(NIOServerCnxnFactory.java:122)
at
org.apache.zookeeper.server.ZooKeeperServerMain.runFromConfig(ZooKeeperServerMain.java:112)
at
org.apache.zookeeper.server.ZooKeeperServerMain.initializeAndRun(ZooKeeperServerMain.java:86)
at
org.apache.zookeeper.server.ZooKeeperServerMain.main(ZooKeeperServerMain.java:52)
at
org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:116)
at
org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:78)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2208) Log type of unexpected quorum packet in observer loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14576118#comment-14576118 ] Hudson commented on ZOOKEEPER-2208: --- SUCCESS: Integrated in ZooKeeper-trunk #2718 (See [https://builds.apache.org/job/ZooKeeper-trunk/2718/]) ZOOKEEPER-2208: Log type of unexpected quorum packet in observer loop (update CHANGES.txt) (Akihiro Suda via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1683851) * /zookeeper/trunk/CHANGES.txt ZOOKEEPER-2208: Log type of unexpected quorum packet in observer loop (Akihiro Suda via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1683850) * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Observer.java Log type of unexpected quorum packet in observer loop - Key: ZOOKEEPER-2208 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2208 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.5.0 Reporter: Akihiro Suda Assignee: Hitoshi Mitake Priority: Trivial Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2208.patch This patch lets the observer loop log the type of packet for debugging. This issue is tightly related to ZOOKEEPER-2205 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2206) Add missing packet types to LearnerHandler.packetToString()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14576115#comment-14576115 ] Hudson commented on ZOOKEEPER-2206: --- SUCCESS: Integrated in ZooKeeper-trunk #2718 (See [https://builds.apache.org/job/ZooKeeper-trunk/2718/]) ZOOKEEPER-2206: Add missing packet types to LearnerHandler.packetToString() (Hitoshi Mitake via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1683842) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java Add missing packet types to LearnerHandler.packetToString() --- Key: ZOOKEEPER-2206 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2206 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.5.0 Reporter: Hitoshi Mitake Assignee: Hitoshi Mitake Priority: Trivial Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2206.patch packetToString() is a method which is suitable for obtaining string representation of QuorumPacket. But it lacks some types of QuorumPacket. This patch adds the missing types and enhance the method for more friendly logging. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2205) Log type of unexpected quorum packet in learner handler loop
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14576116#comment-14576116 ] Hudson commented on ZOOKEEPER-2205: --- SUCCESS: Integrated in ZooKeeper-trunk #2718 (See [https://builds.apache.org/job/ZooKeeper-trunk/2718/]) ZOOKEEPER-2205: Log type of unexpected quorum packet in learner handler loop (Hitoshi Mitake via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1683833) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java Log type of unexpected quorum packet in learner handler loop Key: ZOOKEEPER-2205 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2205 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.4.6, 3.5.0 Reporter: Hitoshi Mitake Assignee: Hitoshi Mitake Priority: Trivial Fix For: 3.4.7, 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2205-v2.patch, ZOOKEEPER-2205-v3.patch, ZOOKEEPER-2205-v4.patch, ZOOKEEPER-2205.patch Current learner handler loop doesn't log anything when it receives unexpected type of quorum packet from learner. This patch lets the learner handler loop log the type of packet for defensive purpose. It would make debugging and trouble shooting a little bit easier. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2207) Enhance error logs with LearnerHandler.packetToString()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14576119#comment-14576119 ] Hudson commented on ZOOKEEPER-2207: --- SUCCESS: Integrated in ZooKeeper-trunk #2718 (See [https://builds.apache.org/job/ZooKeeper-trunk/2718/]) ZOOKEEPER-2207: Enhance error logs with LearnerHandler.packetToString() (Hitoshi Mitake via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1683848) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Follower.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Learner.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java Enhance error logs with LearnerHandler.packetToString() --- Key: ZOOKEEPER-2207 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2207 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.5.0 Reporter: Hitoshi Mitake Assignee: Hitoshi Mitake Priority: Trivial Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2207-v2.patch, ZOOKEEPER-2207.patch This patch enhances error logs related to unexpected types of QuorumPacket with LearnerHandler.packetToString(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2201) Network issues can cause cluster to hang due to near-deadlock
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14576117#comment-14576117
]
Hudson commented on ZOOKEEPER-2201:
---
SUCCESS: Integrated in ZooKeeper-trunk #2718 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2718/])
ZOOKEEPER-2201: Network issues can cause cluster to hang due to near-deadlock
(Donny Nadolny via rgs) (rgs:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1683878)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/DataTreeTest.java
Network issues can cause cluster to hang due to near-deadlock
-
Key: ZOOKEEPER-2201
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2201
Project: ZooKeeper
Issue Type: Bug
Affects Versions: 3.4.6, 3.5.0
Reporter: Donny Nadolny
Assignee: Donny Nadolny
Priority: Critical
Fix For: 3.4.7, 3.5.2, 3.6.0
Attachments: ZOOKEEPER-2201-branch-34.patch, ZOOKEEPER-2201.patch,
ZOOKEEPER-2201.patch, ZOOKEEPER-2201.patch, ZOOKEEPER-2201.patch,
ZOOKEEPER-2201.patch
{{DataTree.serializeNode}} synchronizes on the {{DataNode}} it is about to
serialize then writes it out via {{OutputArchive.writeRecord}}, potentially
to a network connection. Under default linux TCP settings, a network
connection where the other side completely disappears will hang (blocking on
the {{java.net.SocketOutputStream.socketWrite0}} call) for over 15 minutes.
During this time, any attempt to create/delete/modify the {{DataNode}} will
cause the leader to hang at the beginning of the request processor chain:
{noformat}
ProcessThread(sid:5 cport:-1): prio=10 tid=0x026f1800 nid=0x379c
waiting for monitor entry [0x7fe6c2a8c000]
java.lang.Thread.State: BLOCKED (on object monitor)
at
org.apache.zookeeper.server.PrepRequestProcessor.getRecordForPath(PrepRequestProcessor.java:163)
- waiting to lock 0xd4cd9e28 (a
org.apache.zookeeper.server.DataNode)
- locked 0xd2ef81d0 (a java.util.ArrayList)
at
org.apache.zookeeper.server.PrepRequestProcessor.pRequest2Txn(PrepRequestProcessor.java:345)
at
org.apache.zookeeper.server.PrepRequestProcessor.pRequest(PrepRequestProcessor.java:534)
at
org.apache.zookeeper.server.PrepRequestProcessor.run(PrepRequestProcessor.java:131)
{noformat}
Additionally, any attempt to send a snapshot to a follower or to disk will
hang.
Because the ping packets are sent by another thread which is unaffected,
followers never time out and become leader, even though the cluster will make
no progress until either the leader is killed or the TCP connection times
out. This isn't exactly a deadlock since it will resolve itself eventually,
but as mentioned above this will take 15 minutes with the default TCP retry
settings in linux.
A simple solution to this is: in {{DataTree.serializeNode}} we can take a
copy of the contents of the {{DataNode}} (as is done with its children) in
the synchronized block, then call {{writeRecord}} with the copy of the
{{DataNode}} outside of the original {{DataNode}} synchronized block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2194) Let DataNode.getChildren() return an unmodifiable view of its children set
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14574298#comment-14574298 ] Hudson commented on ZOOKEEPER-2194: --- SUCCESS: Integrated in ZooKeeper-trunk #2716 (See [https://builds.apache.org/job/ZooKeeper-trunk/2716/]) ZOOKEEPER-2194: Let DataNode.getChildren() return an unmodifiable view of its children set (Hitoshi Mitake via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1683587) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/DataNode.java Let DataNode.getChildren() return an unmodifiable view of its children set -- Key: ZOOKEEPER-2194 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2194 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.4.6, 3.5.0 Reporter: Hitoshi Mitake Assignee: Hitoshi Mitake Priority: Trivial Fix For: 3.4.7, 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2194-v2.patch, ZOOKEEPER-2194.patch Current DataNode.getChildren() directly returns a pointer of its private member, children. However, the member should be modified through addChild() and removeChild(). Callers of getChildren() shouldn't modify it directly. For preventing the direct modification by the callers, this patch lets getChildren() return an unmodifiable view of its children set. If the callers try to modify directly, runtime exception will be risen. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2204) LearnerSnapshotThrottlerTest.testHighContentionWithTimeout fails occasionally
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14574296#comment-14574296
]
Hudson commented on ZOOKEEPER-2204:
---
SUCCESS: Integrated in ZooKeeper-trunk #2716 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2716/])
ZOOKEEPER-2204: LearnerSnapshotThrottlerTest.testHighContentionWithTimeout
fails occasionally (Donny Nadolny via rgs) (rgs:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1683602)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/LearnerSnapshotThrottlerTest.java
LearnerSnapshotThrottlerTest.testHighContentionWithTimeout fails occasionally
-
Key: ZOOKEEPER-2204
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2204
Project: ZooKeeper
Issue Type: Test
Affects Versions: 3.5.0
Reporter: Donny Nadolny
Assignee: Donny Nadolny
Priority: Minor
Fix For: 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2204.patch, ZOOKEEPER-2204.patch
The {{LearnerSnapshotThrottler}} will only allow 2 concurrent snapshots to be
taken, and if there are already 2 snapshots in progress it will wait up to
200ms for one to complete. This isn't enough time for
{{testHighContentionWithTimeout}} to consistently pass - on a cold JVM
running just the one test I was able to get it to fail 3 times in around 50
runs. This 200ms timeout will be hit if there is a delay between a thread
calling {{LearnerSnapshot snap = throttler.beginSnapshot(false);}} and
{{throttler.endSnapshot();}}.
This also erroneously fails on the build server, see
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2747/testReport/org.apache.zookeeper.server.quorum/LearnerSnapshotThrottlerTest/testHighContentionWithTimeout/
for an example.
I have bumped the timeout up to 5 seconds (which should be more than enough
for warmup / gc pauses), as well as added logging to the {{catch (Exception
e)}} block to assist in debugging any future issues.
An alternate approach would be to separate out results gathered from the
threads, because although we only record true/false there are really three
outcomes:
1. The {{snapshotNumber}} was = 2, meaning the individual call operated
correctly
2. The {{snapshotNumber}} was 2, meaning the test should definitely fail
3. We were unable to snapshot in the time given, so we can't determine if we
should fail or pass (although if we have enough successes from #1 with no
failures from #2 maybe we would pass the test anyway).
Bumping up the timeout is easier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2163) Introduce new ZNode type: container
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14574297#comment-14574297
]
Hudson commented on ZOOKEEPER-2163:
---
SUCCESS: Integrated in ZooKeeper-trunk #2716 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2716/])
ZOOKEEPER-2163: Introduce new ZNode type: container
(Jordan Zimmerman via rgs) (rgs:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1683605)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
*
/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/CreateMode.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/MultiTransactionRecord.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/Op.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooDefs.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/CreateCommand.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ContainerManager.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/DataNode.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/DataTree.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/Request.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/TraceFormatter.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/CreateContainerTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CreateModeTest.java
* /zookeeper/trunk/src/zookeeper.jute
Introduce new ZNode type: container
---
Key: ZOOKEEPER-2163
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2163
Project: ZooKeeper
Issue Type: New Feature
Components: c client, java client, server
Affects Versions: 3.5.0
Reporter: Jordan Zimmerman
Assignee: Jordan Zimmerman
Fix For: 3.6.0
Attachments: zookeeper-2163.10.patch, zookeeper-2163.11.patch,
zookeeper-2163.12.patch, zookeeper-2163.13.patch, zookeeper-2163.14.patch,
zookeeper-2163.3.patch, zookeeper-2163.5.patch, zookeeper-2163.6.patch,
zookeeper-2163.7.patch, zookeeper-2163.8.patch, zookeeper-2163.9.patch
BACKGROUND
A recurring problem for ZooKeeper users is garbage collection of parent
nodes. Many recipes (e.g. locks, leaders, etc.) call for the creation of a
parent node under which participants create sequential nodes. When the
participant is done, it deletes its node. In practice, the ZooKeeper tree
begins to fill up with orphaned parent nodes that are no longer needed. The
ZooKeeper APIs don’t provide a way to clean these. Over time, ZooKeeper can
become unstable due to the number of these nodes.
CURRENT SOLUTIONS
===
Apache Curator has a workaround solution for this by providing the Reaper
class which runs in the background looking for orphaned parent nodes and
deleting them. This isn’t ideal and it would be better if ZooKeeper supported
this directly.
PROPOSAL
=
ZOOKEEPER-723 and ZOOKEEPER-834 have been proposed to allow EPHEMERAL nodes
to contain child nodes. This is not optimum as EPHEMERALs are tied to a
session and the general use case of parent nodes is for PERSISTENT nodes.
This proposal adds a new node type, CONTAINER. A CONTAINER node is the same
as a PERSISTENT node with the additional property that when its last child is
deleted, it is deleted (and CONTAINER nodes recursively up the tree are
deleted if empty).
CANONICAL USAGE
{code}
while ( true) { // or some reasonable limit
try {
zk.create(path, ...);
break;
} catch ( KeeperException.NoNodeException e ) {
try {
zk.createContainer(containerPath, ...);
} catch ( KeeperException.NodeExistsException ignore) {
}
}
}
{code}
--
This
[jira] [Commented] (ZOOKEEPER-2096) C client builds with incorrect error codes in VisualStudio 2010+
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570623#comment-14570623 ] Hudson commented on ZOOKEEPER-2096: --- SUCCESS: Integrated in ZooKeeper-trunk #2714 (See [https://builds.apache.org/job/ZooKeeper-trunk/2714/]) ZOOKEEPER-2096: C client builds with incorrect error codes in VisualStudio 2010+ (Vitaly Stakhovsky via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1683163) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/c/include/winconfig.h * /zookeeper/trunk/src/c/src/zookeeper.c C client builds with incorrect error codes in VisualStudio 2010+ Key: ZOOKEEPER-2096 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2096 Project: ZooKeeper Issue Type: Bug Components: build, c client Affects Versions: 3.4.6, 3.5.0 Environment: Windows MSVS 2010+ Reporter: Vitaly Stakhovsky Fix For: 3.4.7, 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2096.patch, ZOOKEEPER-2096.patch, ZOOKEEPER-2096.patch, ZOOKEEPER-2096.patch, ZOOKEEPER-2096.patch, ZOOKEEPER-2096.patch.branch34 Original Estimate: 1h Remaining Estimate: 1h It reports: warning C4005: 'EWOULDBLOCK' : macro redefinition warning C4005: 'EINPROGRESS' : macro redefinition In MSVS 2010+, these constants are now in errno.h. What's worse, they have different numeric values. Possible fix: In src/c/include/winconfig.h : #if _MSC_VER 1600 #define EWOULDBLOCK WSAEWOULDBLOCK #define EINPROGRESS WSAEINPROGRESS #endif -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2197) non-ascii character in FinalRequestProcessor.java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14568934#comment-14568934 ] Hudson commented on ZOOKEEPER-2197: --- SUCCESS: Integrated in ZooKeeper-trunk #2713 (See [https://builds.apache.org/job/ZooKeeper-trunk/2713/]) ZOOKEEPER-2197 non-ascii character in FinalRequestProcessor.java To be able to use utf-8 in .java source files we now use utf-8 encoding to build them (Michi Mutsuzaki via rgs). (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1683042) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/build.xml * /zookeeper/trunk/src/contrib/build-contrib.xml * /zookeeper/trunk/src/contrib/rest/build.xml * /zookeeper/trunk/src/contrib/zooinspector/build.xml * /zookeeper/trunk/src/recipes/build-recipes.xml * /zookeeper/trunk/src/recipes/election/build.xml * /zookeeper/trunk/src/recipes/lock/build.xml * /zookeeper/trunk/src/recipes/queue/build.xml non-ascii character in FinalRequestProcessor.java - Key: ZOOKEEPER-2197 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2197 Project: ZooKeeper Issue Type: Bug Reporter: Michi Mutsuzaki Assignee: Michi Mutsuzaki Priority: Minor Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch, ZOOKEEPER-2197.patch src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java:134: error: unmappable character for encoding ASCII [javac] // was not being queued ??? ZOOKEEPER-558) properly. This happens, for example, -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2178) Native client fails compilation on Windows.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14567000#comment-14567000 ] Hudson commented on ZOOKEEPER-2178: --- SUCCESS: Integrated in ZooKeeper-trunk #2711 (See [https://builds.apache.org/job/ZooKeeper-trunk/2711/]) ZOOKEEPER-2178 Native client fails compilation on Windows. (Chris Nauroth via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1682823) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/c/src/zookeeper.c Native client fails compilation on Windows. --- Key: ZOOKEEPER-2178 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2178 Project: ZooKeeper Issue Type: Bug Components: c client Affects Versions: 3.5.0 Environment: Windows Reporter: Chris Nauroth Assignee: Chris Nauroth Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2178.001.patch Due to several recent changes, the native client fails to compile on Windows: # ZOOKEEPER-827 (read-only mode) mismatched a function return type between the declaration and definition. # ZOOKEEPER-1626 (monotonic clock for tolerance to time adjustments) added an include of unistd.h, which does not exist on Windows. # Additionally, ZOOKEEPER-1626 did not implement a code path for accessing the Windows monotonic clock. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2198) Set default test.junit.threads to 1.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14566480#comment-14566480
]
Hudson commented on ZOOKEEPER-2198:
---
ABORTED: Integrated in ZooKeeper-trunk #2708 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2708/])
ZOOKEEPER-2198 Set default test.junit.threads to 1 (Chris Nauroth via michim)
(michim:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1682701)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/build.xml
* /zookeeper/trunk/src/java/test/bin/test-patch.sh
Set default test.junit.threads to 1.
Key: ZOOKEEPER-2198
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2198
Project: ZooKeeper
Issue Type: Bug
Components: build
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2198.001.patch
Some systems are seeing test failures under concurrent execution. This issue
proposes to change the default {{test.junit.threads}} to 1 so that those
environments continue to get consistent test runs. Jenkins and individual
developer environments can set multiple threads with a command line argument,
so most environments will still get the benefit of faster test runs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2189) multiple leaders can be elected when configs conflict
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14566479#comment-14566479 ] Hudson commented on ZOOKEEPER-2189: --- ABORTED: Integrated in ZooKeeper-trunk #2708 (See [https://builds.apache.org/job/ZooKeeper-trunk/2708/]) ZOOKEEPER-2189: QuorumCnxManager: use BufferedOutputStream for initial msg (Raul Gutierrez Segales via hdeng) (hdeng: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1682623) * /zookeeper/trunk/CHANGES.txt multiple leaders can be elected when configs conflict - Key: ZOOKEEPER-2189 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2189 Project: ZooKeeper Issue Type: Bug Components: leaderElection Affects Versions: 3.5.0 Reporter: Akihiro Suda This sequence leads the ensemble to a split-brain state: * Start server 1 (config=1:participant, 2:participant, 3:participant) * Start server 2 (config=1:participant, 2:participant, 3:participant) * 1 and 2 believe 2 is the leader * Start server 3 (config=1:observer, 2:observer, 3:participant) * 3 believes 3 is the leader, although 1 and 2 still believe 2 is the leader Such a split-brain ensemble is very unstable. Znodes can be lost easily: * Create some znodes on 2 * Restart 1 and 2 * 1, 2 and 3 can think 3 is the leader * znodes created on 2 are lost, as 1 and 2 sync with 3 I consider this behavior as a bug and that ZK should fail gracefully if a participant is listed as an observer in the config. In current implementation, ZK cannot detect such an invalid config, as FastLeaderElection.sendNotification() sends notifications to only voting members and hence there is no message from observers(1 and 2) to the new voter (3). I think FastLeaderElection.sendNotification() should send notifications to all the members and FastLeaderElection.Messenger.WorkerReceiver.run() should verify acks. Any thoughts? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2189) multiple leaders can be elected when configs conflict
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565932#comment-14565932 ] Hudson commented on ZOOKEEPER-2189: --- FAILURE: Integrated in ZooKeeper-trunk #2707 (See [https://builds.apache.org/job/ZooKeeper-trunk/2707/]) ZOOKEEPER-2189: QuorumCnxManager: use BufferedOutputStream for initial msg (Raul Gutierrez Segales via hdeng) (hdeng: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1682558) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java multiple leaders can be elected when configs conflict - Key: ZOOKEEPER-2189 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2189 Project: ZooKeeper Issue Type: Bug Components: leaderElection Affects Versions: 3.5.0 Reporter: Akihiro Suda This sequence leads the ensemble to a split-brain state: * Start server 1 (config=1:participant, 2:participant, 3:participant) * Start server 2 (config=1:participant, 2:participant, 3:participant) * 1 and 2 believe 2 is the leader * Start server 3 (config=1:observer, 2:observer, 3:participant) * 3 believes 3 is the leader, although 1 and 2 still believe 2 is the leader Such a split-brain ensemble is very unstable. Znodes can be lost easily: * Create some znodes on 2 * Restart 1 and 2 * 1, 2 and 3 can think 3 is the leader * znodes created on 2 are lost, as 1 and 2 sync with 3 I consider this behavior as a bug and that ZK should fail gracefully if a participant is listed as an observer in the config. In current implementation, ZK cannot detect such an invalid config, as FastLeaderElection.sendNotification() sends notifications to only voting members and hence there is no message from observers(1 and 2) to the new voter (3). I think FastLeaderElection.sendNotification() should send notifications to all the members and FastLeaderElection.Messenger.WorkerReceiver.run() should verify acks. Any thoughts? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2179) Typo in Watcher.java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565933#comment-14565933 ] Hudson commented on ZOOKEEPER-2179: --- FAILURE: Integrated in ZooKeeper-trunk #2707 (See [https://builds.apache.org/job/ZooKeeper-trunk/2707/]) ZOOKEEPER-2179: Typo in Watcher.java (Archana T via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1682539) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/Watcher.java Typo in Watcher.java Key: ZOOKEEPER-2179 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2179 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.4.5, 3.5.0 Reporter: Eunchan Kim Priority: Trivial Fix For: 3.4.7, 3.5.0, 3.6.0 Attachments: ZOOKEEPER-2179.patch at zookeeper/src/java/main/org/apache/zookeeper/Watcher.java, * implement. A ZooKeeper client will get various events from the ZooKeepr should be fixed to * implement. A ZooKeeper client will get various events from the ZooKeeper. (Zookeepr - Zookeeper) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2187) remove duplicated code between CreateRequest{,2}
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565931#comment-14565931
]
Hudson commented on ZOOKEEPER-2187:
---
FAILURE: Integrated in ZooKeeper-trunk #2707 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2707/])
ZOOKEEPER-2187: remove duplicated code between CreateRequest{,2}
(Raul Gutierrez Segales via hdeng) (hdeng:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1682521)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/c/src/zookeeper.c
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/MultiTransactionRecord.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
* /zookeeper/trunk/src/zookeeper.jute
remove duplicated code between CreateRequest{,2}
Key: ZOOKEEPER-2187
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2187
Project: ZooKeeper
Issue Type: Bug
Components: c client, java client, server
Reporter: Raul Gutierrez Segales
Assignee: Raul Gutierrez Segales
Priority: Minor
Fix For: 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2187.patch
To avoid cargo culting and reducing duplicated code we can merge most of
CreateRequest CreateRequest2 given that only the Response object is
actually different.
This will improve readability of the code plus make it less confusing for
people adding new opcodes in the future (i.e.: copying a request definition
vs reusing what's already there, etc.).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2191) Continue supporting prior Ant versions that don't implement the threads attribute for the JUnit task.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556009#comment-14556009 ] Hudson commented on ZOOKEEPER-2191: --- SUCCESS: Integrated in ZooKeeper-trunk #2699 (See [https://builds.apache.org/job/ZooKeeper-trunk/2699/]) ZOOKEEPER-2191: Continue supporting prior Ant versions that don't implement the threads attribute for the JUnit task (Chris Nauroth via rakeshr) (rakeshr: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1680994) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/README_packaging.txt * /zookeeper/trunk/build.xml Continue supporting prior Ant versions that don't implement the threads attribute for the JUnit task. - Key: ZOOKEEPER-2191 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2191 Project: ZooKeeper Issue Type: Improvement Components: build Reporter: Chris Nauroth Assignee: Chris Nauroth Fix For: 3.5.2, 3.6.0 Attachments: ZOOKEEPER-2191.001.patch, ZOOKEEPER-2191.002.patch ZOOKEEPER-2183 introduced usage of the threads attribute on the junit task call in build.xml to speed up test execution. This attribute is only available since Ant 1.9.4. However, we can continue to support older Ant versions by calling the antversion task and dispatching to a clone of our junit task call that doesn't use the threads attribute. Users of older Ant versions will get the slower single-process test execution. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2156) If JAVA_HOME is not set zk startup and fetching status command execution result misleads user.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552137#comment-14552137
]
Hudson commented on ZOOKEEPER-2156:
---
FAILURE: Integrated in ZooKeeper-trunk #2697 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2697/])
ZOOKEEPER-2156: If JAVA_HOME is not set zk startup and fetching status command
execution result misleads user (J.Andreina via rakeshr) (rakeshr:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1680471)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/bin/zkEnv.sh
If JAVA_HOME is not set zk startup and fetching status command execution
result misleads user.
--
Key: ZOOKEEPER-2156
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2156
Project: ZooKeeper
Issue Type: Bug
Components: scripts
Reporter: J.Andreina
Assignee: J.Andreina
Fix For: 3.5.2, 3.6.0
Attachments: ZOOKEEPER-2156.1.patch, ZOOKEEPER-2156.2.patch,
ZOOKEEPER-2156.3.patch, ZOOKEEPER-2156.4.patch, ZOOKEEPER-2156.5.patch
If JAVA_HOME is not set, zk startup and fetching status command execution
result misleads user.
1. Eventhough zk startup has failed since JAVA_HOME is not set , on CLI it
displays that zk STARTED.
{noformat}
#:~/Apr3rd/zookeeper-3.4.6/bin ./zkServer.sh start
JMX enabled by default
Using config: /home/REX/Apr3rd/zookeeper-3.4.6/bin/../conf/zoo.cfg
Starting zookeeper ... STARTED
{noformat}
2. Fetching zk status when JAVA_HOME is not set displays that process not
running .
{noformat}
#:~/Apr3rd/zookeeper-3.4.6/bin ./zkServer.sh status
JMX enabled by default
Using config: /home/REX/Apr3rd/zookeeper-3.4.6/bin/../conf/zoo.cfg
Error contacting service. It is probably not running.
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1077) C client lib doesn't build on Solaris
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14547847#comment-14547847 ] Hudson commented on ZOOKEEPER-1077: --- FAILURE: Integrated in ZooKeeper-trunk #2695 (See [https://builds.apache.org/job/ZooKeeper-trunk/2695/]) ZOOKEEPER-1077: C client lib doesn't build on Solaris (Chris Nauroth via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1679951) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/c/Makefile.am * /zookeeper/trunk/src/c/configure.ac * /zookeeper/trunk/src/c/src/zk_log.c * /zookeeper/trunk/src/c/src/zookeeper.c * /zookeeper/trunk/src/c/tests/LibCMocks.cc * /zookeeper/trunk/src/c/tests/wrappers.opt C client lib doesn't build on Solaris - Key: ZOOKEEPER-1077 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1077 Project: ZooKeeper Issue Type: Bug Components: build, c client Affects Versions: 3.3.4 Environment: uname -a: SunOS [redacted] 5.10 Generic_142910-17 i86pc i386 i86pc GNU toolchain (gcc 3.4.3, GNU Make etc.) Reporter: Tadeusz Andrzej Kadłubowski Assignee: Chris Nauroth Priority: Critical Fix For: 3.4.7, 3.5.2, 3.6.0 Attachments: ZOOKEEPER-1077-branch-3.4.002.patch, ZOOKEEPER-1077.001.patch, ZOOKEEPER-1077.002.patch, zookeeper.patch Hello, Some minor trouble with building ZooKeeper C client library on Sun^H^H^HOracle Solaris 5.10. 1. You need to link against -lnsl -lsocket 2. ctime_r needs a buffer size. The signature is: char *ctime_r(const time_t *clock, char *buf, int buflen) 3. In zk_log.c you need to manually cast pid_t to int (-Werror can be cumbersome ;) ) 4. getpwuid_r()returns pointer to struct passwd, which works as the last parameter on Linux. Solaris signature: struct passwd *getpwuid_r(uid_t uid, struct passwd *pwd, char *buffer, int buflen); Linux signature: int getpwuid_r(uid_t uid, struct passwd *pwd, char *buf, size_t buflen, struct passwd **result); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2190) In StandaloneDisabledTest, testReconfig() shouldn't take leaving servers as joining servers
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14545347#comment-14545347 ] Hudson commented on ZOOKEEPER-2190: --- FAILURE: Integrated in ZooKeeper-trunk #2692 (See [https://builds.apache.org/job/ZooKeeper-trunk/2692/]) ZOOKEEPER-2190 fix StandaloneDisabledTest#testReconfig In StandaloneDisabledTest, testReconfig() shouldn't take leaving servers as joining servers (Hongchao Deng via rgs). (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1679444) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java In StandaloneDisabledTest, testReconfig() shouldn't take leaving servers as joining servers --- Key: ZOOKEEPER-2190 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2190 Project: ZooKeeper Issue Type: Bug Components: tests Reporter: Hongchao Deng Assignee: Hongchao Deng Fix For: 3.5.2, 3.6.0 Attachments: ZOOKEEPER-2190.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2183) Concurrent Testing Processes and Port Assignments
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14545346#comment-14545346
]
Hudson commented on ZOOKEEPER-2183:
---
FAILURE: Integrated in ZooKeeper-trunk #2692 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2692/])
ZOOKEEPER-2183 Concurrent Testing Processes and Port Assignments (Chris Nauroth
via hdeng) (hdeng:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1679400)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/build.xml
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/PortAssignment.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/PortAssignmentTest.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/ZxidRolloverTest.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/WatchLeakTest.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/HierarchicalQuorumTest.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/NettyNettySuiteBase.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/NioNettySuiteBase.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/QuorumBase.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/QuorumUtil.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/TruncateTest.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/WatchEventWhenAutoResetTest.java
Concurrent Testing Processes and Port Assignments
-
Key: ZOOKEEPER-2183
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2183
Project: ZooKeeper
Issue Type: Improvement
Components: tests
Affects Versions: 3.5.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Fix For: 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2183.001.patch, ZOOKEEPER-2183.002.patch,
ZOOKEEPER-2183.003.patch, ZOOKEEPER-2183.004.patch, ZOOKEEPER-2183.005.patch,
threads-change.patch
Tests use {{PortAssignment#unique}} for assignment of the ports to bind
during tests. Currently, this method works by using a monotonically
increasing counter from a static starting point. Generally, this is
sufficient to achieve uniqueness within a single JVM process, but it does not
achieve uniqueness across multiple processes on the same host. This can
cause tests to get bind errors if there are multiple pre-commit jobs running
concurrently on the same Jenkins host. This also prevents running tests in
parallel to improve the speed of pre-commit runs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2126) Improve exit log messsage of EventThread and SendThread by adding SessionId
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14545345#comment-14545345
]
Hudson commented on ZOOKEEPER-2126:
---
FAILURE: Integrated in ZooKeeper-trunk #2692 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2692/])
ZOOKEEPER-2126 Improve exit log messsage of EventThread and SendThread by
adding SessionId (surendra singh lilhore via rakeshr) (rakeshr:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1679489)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java
Improve exit log messsage of EventThread and SendThread by adding SessionId
---
Key: ZOOKEEPER-2126
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2126
Project: ZooKeeper
Issue Type: Improvement
Components: java client
Affects Versions: 3.6.0
Reporter: zhihai xu
Assignee: surendra singh lilhore
Fix For: 3.4.7, 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2126.patch, ZOOKEEPER-2126_1.patch,
ZOOKEEPER-2126_2.patch
We saw the following out of order log when close Zookeeper client session.
{code}
2015-02-16 06:01:12,985 INFO org.apache.zookeeper.ZooKeeper: Session:
0x24b8df4044005d4 closed
.
2015-02-16 06:01:12,995 INFO org.apache.zookeeper.ClientCnxn: EventThread
shut down
{code}
This logs are very confusing if a new Zookeeper client session is created
between these two logs. We may think new Zookeeper client session shutdown it
EventThread instead of the old closed Zookeeper client session.
Should we wait for sendThread and eventThread died in the ClientCnxn.close?
We can add the following code in ClientCnxn.close.
{code}
sendThread.join(timeout);
eventThread.join(timeout);
{code}
with the change, we won't interleave old closed session with new session.
We can also create a new close API to support this so we won't affect the old
code if people use old close API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2186) QuorumCnxManager#receiveConnection may crash with random input
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14543531#comment-14543531
]
Hudson commented on ZOOKEEPER-2186:
---
SUCCESS: Integrated in ZooKeeper-trunk #2691 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2691/])
ZOOKEEPER-2186 QuorumCnxManager#receiveConnection may crash with random input
(rgs via michim) (michim:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1679313)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java
QuorumCnxManager#receiveConnection may crash with random input
--
Key: ZOOKEEPER-2186
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2186
Project: ZooKeeper
Issue Type: Bug
Components: server
Affects Versions: 3.4.6, 3.5.0
Reporter: Raul Gutierrez Segales
Assignee: Raul Gutierrez Segales
Fix For: 3.4.7, 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2186-v3.4.patch, ZOOKEEPER-2186.patch,
ZOOKEEPER-2186.patch, ZOOKEEPER-2186.patch
This will allocate an arbitrarily large byte buffer (and try to read it!):
{code}
public boolean receiveConnection(Socket sock) {
Long sid = null;
...
sid = din.readLong();
// next comes the #bytes in the remainder of the message
int num_remaining_bytes = din.readInt();
byte[] b = new byte[num_remaining_bytes];
// remove the remainder of the message from din
int num_read = din.read(b);
{code}
This will crash the QuorumCnxManager thread, so the cluster will keep going
but future elections might fail to converge (ditto for leaving/joining
members).
Patch coming up in a bit.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2182) Several test suites are not running during pre-commit, because their names do not end with Test.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537827#comment-14537827
]
Hudson commented on ZOOKEEPER-2182:
---
SUCCESS: Integrated in ZooKeeper-trunk #2688 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2688/])
ZOOKEEPER-2182 Several test suites are not running during pre-commit, because
their names do not end with Test. (Chris Nauroth via hdeng) (hdeng:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1678645)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/ReconfigFailureCases.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/ReconfigFailureCasesTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientRetry.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientRetryTest.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/WatchEventWhenAutoReset.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/WatchEventWhenAutoResetTest.java
Several test suites are not running during pre-commit, because their names do
not end with Test.
--
Key: ZOOKEEPER-2182
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2182
Project: ZooKeeper
Issue Type: Bug
Components: tests
Affects Versions: 3.5.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Fix For: 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2182.001.patch
In build.xml, the {{junit}} task definition uses an include pattern of
{{\*\*/\*$\{test.category\}Test.java}}. This is important so that we don't
accidentally try to run utility classes like {{PortAssignment}} or
{{TestableZooKeeper}} as if they were JUnit suites. However, several test
suites are misnamed so that they don't satisfy this pattern, and therefore
pre-commit hasn't been running them.
{{ClientRetry}}
{{ReconfigFailureCases}}
{{WatchEventWhenAutoReset}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2171) avoid reverse lookups in QuorumCnxManager
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537139#comment-14537139 ] Hudson commented on ZOOKEEPER-2171: --- SUCCESS: Integrated in ZooKeeper-trunk #2687 (See [https://builds.apache.org/job/ZooKeeper-trunk/2687/]) ZOOKEEPER-2171 avoid reverse lookups in QuorumCnxManager (rgs via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1678529) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/client/StaticHostProvider.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/common/HostNameUtils.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LocalPeerBean.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/RemotePeerBean.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java * /zookeeper/trunk/src/java/systest/org/apache/zookeeper/test/system/QuorumPeerInstance.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/common/HostNameUtilsTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ConnectStringParserTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReconfigTest.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java avoid reverse lookups in QuorumCnxManager - Key: ZOOKEEPER-2171 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2171 Project: ZooKeeper Issue Type: Bug Components: quorum Reporter: Raul Gutierrez Segales Assignee: Raul Gutierrez Segales Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2171.patch, ZOOKEEPER-2171.patch Apparently, ZOOKEEPER-107 (via a quick git-blame look) introduced a bunch of getHostName() calls in QCM. Besides the overhead, these can cause problems when mixed with failing/mis-configured DNS servers. It would be nice to reduce them, if that doesn't affect operational correctness. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2153) X509 Authentication Documentation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14532466#comment-14532466 ] Hudson commented on ZOOKEEPER-2153: --- FAILURE: Integrated in ZooKeeper-trunk #2684 (See [https://builds.apache.org/job/ZooKeeper-trunk/2684/]) ZOOKEEPER-2153 X509 Authentication Documentation (Ian Dimayuga via hdeng) (hdeng: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1678032) * /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml X509 Authentication Documentation - Key: ZOOKEEPER-2153 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2153 Project: ZooKeeper Issue Type: Sub-task Affects Versions: 3.5.0 Reporter: Hongchao Deng Assignee: Ian Dimayuga Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2153.patch, ZOOKEEPER-2153.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2176) Unclear error message should be info not error
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530397#comment-14530397
]
Hudson commented on ZOOKEEPER-2176:
---
FAILURE: Integrated in ZooKeeper-trunk #2683 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2683/])
ZOOKEEPER-2176 Unclear error message should be info not error (rgs via hdeng)
(hdeng: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1677865)
* /zookeeper/trunk/CHANGES.txt
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
Unclear error message should be info not error
--
Key: ZOOKEEPER-2176
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2176
Project: ZooKeeper
Issue Type: Improvement
Components: quorum
Affects Versions: 3.5.0
Reporter: Raul Gutierrez Segales
Assignee: Raul Gutierrez Segales
Fix For: 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2176.patch
Hi [~shralex],
Looking at the CI output of ZOOKEEPER-2163 I see this:
{noformat}
[exec] [junit] 2015-04-17 17:36:23,750 [myid:] - ERROR
[QuorumPeer[myid=4](plain=/0:0:0:0:0:0:0:0:11235)(secure=disabled):QuorumPeer@1394]
- writeToDisk == true but configFilename == null
{noformat}
Though looking at QuorumPeer#setQuorumVerifier I see:
{noformat}
if (configFilename != null) {
try {
String dynamicConfigFilename = makeDynamicConfigFilename(
qv.getVersion());
QuorumPeerConfig.writeDynamicConfig(
dynamicConfigFilename, qv, false);
QuorumPeerConfig.editStaticConfig(configFilename,
dynamicConfigFilename,
needEraseClientInfoFromStaticConfig());
} catch (IOException e) {
LOG.error(Error closing file: , e.getMessage());
}
} else {
LOG.error(writeToDisk == true but configFilename == null);
}
{noformat}
there's no proper error handling so I guess maybe we should just make it a
warning? Thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2153) X509 Authentication Documentation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530398#comment-14530398 ] Hudson commented on ZOOKEEPER-2153: --- FAILURE: Integrated in ZooKeeper-trunk #2683 (See [https://builds.apache.org/job/ZooKeeper-trunk/2683/]) ZOOKEEPER-2153 X509 Authentication Documentation (Ian Dimayuga via hdeng) (hdeng: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1677867) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml * /zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperProgrammers.xml X509 Authentication Documentation - Key: ZOOKEEPER-2153 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2153 Project: ZooKeeper Issue Type: Sub-task Affects Versions: 3.5.0 Reporter: Hongchao Deng Assignee: Ian Dimayuga Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2153.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2062) RemoveWatchesTest takes forever to run
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14528274#comment-14528274 ] Hudson commented on ZOOKEEPER-2062: --- SUCCESS: Integrated in ZooKeeper-trunk #2682 (See [https://builds.apache.org/job/ZooKeeper-trunk/2682/]) ZOOKEEPER-2062 RemoveWatchesTest takes forever to run (Chris Nauroth via rakeshr) (rakeshr: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1677724) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/test/org/apache/zookeeper/RemoveWatchesTest.java RemoveWatchesTest takes forever to run -- Key: ZOOKEEPER-2062 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2062 Project: ZooKeeper Issue Type: Bug Components: tests Affects Versions: 3.5.0 Reporter: Flavio Junqueira Assignee: Chris Nauroth Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2062.001.patch, ZOOKEEPER-2062.002.patch, ZOOKEEPER-2062.003.patch, ZOOKEEPER-2062.004.patch [junit] Running org.apache.zookeeper.RemoveWatchesTest [junit] Tests run: 46, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 306.188 sec -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2174) JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated with an expected exception.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526541#comment-14526541
]
Hudson commented on ZOOKEEPER-2174:
---
SUCCESS: Integrated in ZooKeeper-trunk #2681 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2681/])
ZOOKEEPER-2174 JUnit4ZKTestRunner logs test failure for all exceptions
JUnit4ZKTestRunner logs test failure for all exceptions, even if the test
method is annotated with an expected exception (Chris Nauroth via rgs). (rgs:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1677460)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/JUnit4ZKTestRunner.java
JUnit4ZKTestRunner logs test failure for all exceptions even if the test
method is annotated with an expected exception.
Key: ZOOKEEPER-2174
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
Project: ZooKeeper
Issue Type: Bug
Components: tests
Reporter: Chris Nauroth
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.4.7, 3.5.2, 3.6.0
Attachments: ZOOKEEPER-2174-branch-3.4.004.patch,
ZOOKEEPER-2174.001.patch, ZOOKEEPER-2174.002.patch, ZOOKEEPER-2174.003.patch,
ZOOKEEPER-2174.004.patch
{{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
exception is thrown, it logs a message stating that the test failed.
However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
indicate that an exception is the expected result, and thus the test passes.
The runner should be aware of expected exceptions and only log if an
unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2124) Allow Zookeeper version string to have underscore '_'
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526542#comment-14526542
]
Hudson commented on ZOOKEEPER-2124:
---
SUCCESS: Integrated in ZooKeeper-trunk #2681 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2681/])
ZOOKEEPER-2124 Allow Zookeeper version string to have underscore '_'
(Chris Nauroth via rgs) (rgs:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1677529)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/build.xml
* /zookeeper/trunk/src/contrib/zkpython/build.xml
Allow Zookeeper version string to have underscore '_'
-
Key: ZOOKEEPER-2124
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2124
Project: ZooKeeper
Issue Type: Bug
Affects Versions: 3.4.6
Reporter: Jerry He
Assignee: Chris Nauroth
Fix For: 3.4.7, 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2124.001.patch
Using Bigtop or other RPM build for Zookeeper, there is a problem with using
the hyphen '-' character in the version string:
{noformat}
[bigdata@bdvs1166 bigtop]$ gradle zookeeper-rpm
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy UP-TO-DATE
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes UP-TO-DATE
:buildSrc:jar UP-TO-DATE
:buildSrc:assemble UP-TO-DATE
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build UP-TO-DATE
:zookeeper_vardefines
:zookeeper-download
:zookeeper-tar
Copy /home/bigdata/bigtop/dl/zookeeper-3.4.6-IBM-1.tar.gz to
/home/bigdata/bigtop/build/zookeeper/tar/zookeeper-3.4.6-IBM-1.tar.gz
:zookeeper-srpm
error: line 64: Illegal char '-' in: Version: 3.4.6-IBM-1
:zookeeper-srpm FAILED
FAILURE: Build failed with an exception.
* Where:
Script '/home/bigdata/bigtop/packages.gradle' line: 462
* What went wrong:
Execution failed for task ':zookeeper-srpm'.
Process 'command 'rpmbuild'' finished with non-zero exit value 1
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or
--debug option to get more log output.
BUILD FAILED
{noformat}
Also, according to the
[rpm-maven-plugin|http://mojo.codehaus.org/rpm-maven-plugin/ident-params.html]
documentation:
{noformat}
version
The version number to use for the RPM package. By default, this is the
project version. This value cannot contain a dash (-) due to contraints in
the RPM file naming convention. Any specified value will be truncated at the
first dash
release
The release number of the RPM.
Beginning with release 2.0-beta-2, this is an optional parameter. By default,
the release will be generated from the modifier portion of the project
version using the following rules:
If no modifier exists, the release will be 1.
If the modifier ends with SNAPSHOT, the timestamp (in UTC) of the build will
be appended to end.
All instances of '-' in the modifier will be replaced with '_'.
If a modifier exists and does not end with SNAPSHOT, _1 will be appended to
end.
{noformat}
We should allow underscore '_' as part of the version string. e.g.
3.4.6_abc_1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2173) ZK startup failure should be handled with proper error message
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14516042#comment-14516042 ] Hudson commented on ZOOKEEPER-2173: --- SUCCESS: Integrated in ZooKeeper-trunk #2674 (See [https://builds.apache.org/job/ZooKeeper-trunk/2674/]) ZOOKEEPER-2173. ZK startup failure should be handled with proper error message (J.Andreina via camille) (camille: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1676359) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/bin/zkServer.sh ZK startup failure should be handled with proper error message -- Key: ZOOKEEPER-2173 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2173 Project: ZooKeeper Issue Type: Bug Reporter: J.Andreina Assignee: J.Andreina Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2173.1.patch If any failure during zk Startup (myid file does not exist), then still zk startup returns as successful (STARTED). ZK startup failure should be handled with proper error message -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1626) Zookeeper C client should be tolerant of clock adjustments
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491428#comment-14491428 ] Hudson commented on ZOOKEEPER-1626: --- SUCCESS: Integrated in ZooKeeper-trunk #2658 (See [https://builds.apache.org/job/ZooKeeper-trunk/2658/]) ZOOKEEPER-1626 Zookeeper C client should be tolerant of clock adjustments (Colin Patrick McCabe via michim) (michim: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1672934) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/c/Makefile.am * /zookeeper/trunk/src/c/configure.ac * /zookeeper/trunk/src/c/src/zookeeper.c * /zookeeper/trunk/src/c/tests/LibCMocks.cc * /zookeeper/trunk/src/c/tests/LibCSymTable.cc * /zookeeper/trunk/src/c/tests/LibCSymTable.h Zookeeper C client should be tolerant of clock adjustments --- Key: ZOOKEEPER-1626 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1626 Project: ZooKeeper Issue Type: Sub-task Components: c client Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-1366.001.patch, ZOOKEEPER-1366.002.patch, ZOOKEEPER-1366.003.patch, ZOOKEEPER-1366.004.patch, ZOOKEEPER-1366.006.patch, ZOOKEEPER-1366.007.patch, ZOOKEEPER-1626.patch The Zookeeper C client should use monotonic time when available, in order to be more tolerant of time adjustments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2029) Leader.LearnerCnxAcceptor should handle exceptions in run()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490925#comment-14490925 ] Hudson commented on ZOOKEEPER-2029: --- FAILURE: Integrated in ZooKeeper-trunk #2657 (See [https://builds.apache.org/job/ZooKeeper-trunk/2657/]) ZOOKEEPER-2029 Leader.LearnerCnxAcceptor should handle exceptions in run() (Rakesh R, Asad Saeed via hdeng) (hdeng: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1672751) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Leader.java Leader.LearnerCnxAcceptor should handle exceptions in run() --- Key: ZOOKEEPER-2029 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2029 Project: ZooKeeper Issue Type: Bug Components: quorum Affects Versions: 3.4.6 Reporter: Asad Saeed Assignee: Rakesh R Priority: Minor Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2029.patch Leader.LearnerCnxAcceptor swallows exceptions and shuts itself down. It should instead crash the Leader. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2157) Upgrade option should be removed from zkServer.sh usage
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14485086#comment-14485086
]
Hudson commented on ZOOKEEPER-2157:
---
FAILURE: Integrated in ZooKeeper-trunk #2654 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2654/])
ZOOKEEPER-2157 Upgrade option should be removed from zkServer.sh usage
(J.Andreina via hdeng) (hdeng:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1671889)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/bin/zkServer.sh
Upgrade option should be removed from zkServer.sh usage
---
Key: ZOOKEEPER-2157
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2157
Project: ZooKeeper
Issue Type: Bug
Reporter: J.Andreina
Assignee: J.Andreina
Priority: Minor
Fix For: 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2157.1.patch, ZOOKEEPER-2157.2.patch
Upgrade option should be removed from zkServer.sh usage from trunk code
Currently upgrade option is available in zkServer.sh usage , while upgrade
feature is already been removed from trunk.
{noformat}
#:~/March_1/zookeeper/bin ./zkServer.sh upgrade
ZooKeeper JMX enabled by default
Using config: /home/REX/March_1/zookeeper/bin/../conf/zoo.cfg
Usage: ./zkServer.sh [--config conf-dir]
{start|start-foreground|stop|restart|status|upgrade|print-cmd}
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
