[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/556 ---
[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....
GitHub user maoling reopened a pull request: https://github.com/apache/zookeeper/pull/556 ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics more details in [ZOOKEEPER-3074](https://issues.apache.org/jira/browse/ZOOKEEPER-3074) You can merge this pull request into a Git repository by running: $ git pull https://github.com/maoling/zookeeper ZOOKEEPER-3074 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/556.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #556 commit 9c0b04165f54d9d82292d20b98a8274ea5ed7357 Author: maoling Date: 2018-07-03T08:04:15Z ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics ---
[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....
Github user maoling closed the pull request at: https://github.com/apache/zookeeper/pull/556 ---
[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....
Github user maoling closed the pull request at: https://github.com/apache/zookeeper/pull/556 ---
[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....
GitHub user maoling reopened a pull request: https://github.com/apache/zookeeper/pull/556 ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics more details in [ZOOKEEPER-3074](https://issues.apache.org/jira/browse/ZOOKEEPER-3074) You can merge this pull request into a Git repository by running: $ git pull https://github.com/maoling/zookeeper ZOOKEEPER-3074 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/556.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #556 commit 9c0b04165f54d9d82292d20b98a8274ea5ed7357 Author: maoling Date: 2018-07-03T08:04:15Z ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics ---
[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....
Github user nkalmar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/556#discussion_r199726257
--- Diff: src/java/test/org/apache/zookeeper/server/ServerStatsTest.java ---
@@ -73,11 +73,11 @@ public void testLatencyMetrics() {
// Then ...
assertThat("Max latency check", 2000L,
-greaterThanOrEqualTo(serverStats.getMaxLatency()));
+lessThanOrEqualTo(serverStats.getMaxLatency()));
--- End diff --
Thanks for catching this and fixing it! The serverstats.getMaxLatency()
should of went in the "actual" parameter and the magic number as the
greaterThanOrEqualTo parameter. (I did this test. Sorry...)
But changing greater to less work just fine.
---
[GitHub] zookeeper pull request #556: ZOOKEEPER-3074:Flaky test:org.apache.zookeeper....
GitHub user maoling opened a pull request: https://github.com/apache/zookeeper/pull/556 ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics more details in [ZOOKEEPER-3074](https://issues.apache.org/jira/browse/ZOOKEEPER-3074) You can merge this pull request into a Git repository by running: $ git pull https://github.com/maoling/zookeeper ZOOKEEPER-3074 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/556.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #556 commit 9c0b04165f54d9d82292d20b98a8274ea5ed7357 Author: maoling Date: 2018-07-03T08:04:15Z ZOOKEEPER-3074:Flaky test:org.apache.zookeeper.server.ServerStatsTest.testLatencyMetrics ---
