[VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Benjamin Reed]

after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
this is a bug fix
release addressing 13 issues (two of them extremely critical) -- see the
release notes for details.

*** Please download, test and VOTE before the
*** vote closes 11pm pacific time, Tuesday, February 22.***

http://people.apache.org/~breed/zookeeper-3.3.2-candidate-0/

one thing that has not been fixed in this release is that the docs still
reference hadoop. this will be fixed in a future release.

should we release this?

ben

ps - give that this is the first release there is more than likely something
i missed and given the severity of issues addressed it would be nice to get
it out quickly. please review ASAP.

[VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Benjamin Reed]

(the previous email had the URL slightly incorrect)

after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
this is a bug fix
release addressing 13 issues (two of them extremely critical) -- see the
release notes for details.

*** Please download, test and VOTE before the
*** vote closes 11pm pacific time, Tuesday, February 22.***

http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/

one thing that has not been fixed in this release is that the docs still
reference hadoop. this will be fixed in a future release.

should we release this?

ben

ps - give that this is the first release there is more than likely something
i missed and given the severity of issues addressed it would be nice to get
it out quickly. please review ASAP.

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Flavio Junqueira]

Ben, I have a question. Even though the bookkeeper jar is there, build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails without it. Is it supposed to be this way?-FlavioOn Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:(the previous email had the URL slightly incorrect)after much struggle! i've created a candidate build for ZooKeeper 3.3.3.this is a bug fixrelease addressing 13 issues (two of them extremely critical) -- see therelease notes for details.*** Please download, test and VOTE before the*** vote closes 11pm pacific time, Tuesday, February 22.***http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/one thing that has not been fixed in this release is that the docs stillreference hadoop. this will be fixed in a future release.should we release this?benps - give that this is the first release there is more than likely somethingi missed and given the severity of issues addressed it would be nice to getit out quickly. please review ASAP. flaviojunqueira research scientist f...@yahoo-inc.comdirect +34 93-183-8828 avinguda diagonal 177, 8th floor, barcelona, 08018, esphone (408) 349 3300fax (408) 349 3301 

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Flavio Junqueira]

Hi again, I'm sorry for raising yet another point. I also wanted to point out that we have a few jiras marked as blocked not included in the current candidate. ZOOKEEPER-880 is one of them, and Vishal asked us to consider it for 3.3.3. I think that either we conclude that it is not a blocker and leave it marked for 3.4.0 as it is currently, or include it in 3.3.3. -FlavioOn Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:(the previous email had the URL slightly incorrect)after much struggle! i've created a candidate build for ZooKeeper 3.3.3.this is a bug fixrelease addressing 13 issues (two of them extremely critical) -- see therelease notes for details.*** Please download, test and VOTE before the*** vote closes 11pm pacific time, Tuesday, February 22.***http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/one thing that has not been fixed in this release is that the docs stillreference hadoop. this will be fixed in a future release.should we release this?benps - give that this is the first release there is more than likely somethingi missed and given the severity of issues addressed it would be nice to getit out quickly. please review ASAP. flaviojunqueira research scientist f...@yahoo-inc.comdirect +34 93-183-8828 avinguda diagonal 177, 8th floor, barcelona, 08018, esphone (408) 349 3300fax (408) 349 3301 

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Patrick Hunt]

FYI: if you make bulk changes (greater than 5 or so, typically this happens
during release time) to JIRA please do use the bulk change feature, and in
particular turn OFF email notification. Subsequently send out a single email
detailing the changes.

Patrick

On Mon, Feb 21, 2011 at 3:46 AM, Flavio Junqueira  wrote:

> Hi again, I'm sorry for raising yet another point. I also wanted to point
> out that we have a few jiras marked as blocked not included in the current
> candidate. ZOOKEEPER-880 is one of them, and Vishal asked us to consider it
> for 3.3.3. I think that either we conclude that it is not a blocker and
> leave it marked for 3.4.0 as it is currently, or include it in 3.3.3.
>
> -Flavio
>
> On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:
>
> (the previous email had the URL slightly incorrect)
>
> after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
> this is a bug fix
> release addressing 13 issues (two of them extremely critical) -- see the
> release notes for details.
>
> *** Please download, test and VOTE before the
> *** vote closes 11pm pacific time, Tuesday, February 22.***
>
> http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
>
> one thing that has not been fixed in this release is that the docs still
> reference hadoop. this will be fixed in a future release.
>
> should we release this?
>
> ben
>
> ps - give that this is the first release there is more than likely
> something
> i missed and given the severity of issues addressed it would be nice to get
> it out quickly. please review ASAP.
>
>
> *flavio*
> *junqueira*
>
> research scientist
>
> f...@yahoo-inc.com
> direct +34 93-183-8828
>
> avinguda diagonal 177, 8th floor, barcelona, 08018, es
> phone (408) 349 3300fax (408) 349 3301
>
>
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Patrick Hunt]

-1, in general looks good but I did notice a few things:

* the "zookeeper_version.h" file needs to be updated to version 3.3.3
* same with configure.ac (http://wiki.apache.org/hadoop/ZooKeeper/HowToRelease)
* the toplevel zk jar and all jars in dist-maven have not been signed,
they need to be

RAT passed so that's good.

Patrick

On Sat, Feb 19, 2011 at 6:27 AM, Benjamin Reed  wrote:
> (the previous email had the URL slightly incorrect)
>
> after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
> this is a bug fix
> release addressing 13 issues (two of them extremely critical) -- see the
> release notes for details.
>
> *** Please download, test and VOTE before the
> *** vote closes 11pm pacific time, Tuesday, February 22.***
>
> http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
>
> one thing that has not been fixed in this release is that the docs still
> reference hadoop. this will be fixed in a future release.
>
> should we release this?
>
> ben
>
> ps - give that this is the first release there is more than likely something
> i missed and given the severity of issues addressed it would be nice to get
> it out quickly. please review ASAP.
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Benjamin Reed]

pat, do you mind updating the building section of
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease
with
these three items. signing the jar files is very unclear in the original
doc. do i untar, sign, and retar? we don't do jarsigning?

i'll do an rc1 this evening.

ben

On Mon, Feb 21, 2011 at 11:55 PM, Patrick Hunt  wrote:

> -1, in general looks good but I did notice a few things:
>
> * the "zookeeper_version.h" file needs to be updated to version 3.3.3
> * same with configure.ac (
> http://wiki.apache.org/hadoop/ZooKeeper/HowToRelease)
> * the toplevel zk jar and all jars in dist-maven have not been signed,
> they need to be
>
> RAT passed so that's good.
>
> Patrick
>
> On Sat, Feb 19, 2011 at 6:27 AM, Benjamin Reed  wrote:
> > (the previous email had the URL slightly incorrect)
> >
> > after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
> > this is a bug fix
> > release addressing 13 issues (two of them extremely critical) -- see the
> > release notes for details.
> >
> > *** Please download, test and VOTE before the
> > *** vote closes 11pm pacific time, Tuesday, February 22.***
> >
> > http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
> >
> > one thing that has not been fixed in this release is that the docs still
> > reference hadoop. this will be fixed in a future release.
> >
> > should we release this?
> >
> > ben
> >
> > ps - give that this is the first release there is more than likely
> something
> > i missed and given the severity of issues addressed it would be nice to
> get
> > it out quickly. please review ASAP.
> >
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Benjamin Reed]

can you add this to the how to release wiki as well?

ben

On Mon, Feb 21, 2011 at 9:38 AM, Patrick Hunt  wrote:

> FYI: if you make bulk changes (greater than 5 or so, typically this happens
> during release time) to JIRA please do use the bulk change feature, and in
> particular turn OFF email notification. Subsequently send out a single email
> detailing the changes.
>
> Patrick
>
> On Mon, Feb 21, 2011 at 3:46 AM, Flavio Junqueira wrote:
>
>> Hi again, I'm sorry for raising yet another point. I also wanted to point
>> out that we have a few jiras marked as blocked not included in the current
>> candidate. ZOOKEEPER-880 is one of them, and Vishal asked us to consider it
>> for 3.3.3. I think that either we conclude that it is not a blocker and
>> leave it marked for 3.4.0 as it is currently, or include it in 3.3.3.
>>
>> -Flavio
>>
>> On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:
>>
>> (the previous email had the URL slightly incorrect)
>>
>> after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
>> this is a bug fix
>> release addressing 13 issues (two of them extremely critical) -- see the
>> release notes for details.
>>
>> *** Please download, test and VOTE before the
>> *** vote closes 11pm pacific time, Tuesday, February 22.***
>>
>> http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
>>
>> one thing that has not been fixed in this release is that the docs still
>> reference hadoop. this will be fixed in a future release.
>>
>> should we release this?
>>
>> ben
>>
>> ps - give that this is the first release there is more than likely
>> something
>> i missed and given the severity of issues addressed it would be nice to
>> get
>> it out quickly. please review ASAP.
>>
>>
>>   *flavio*
>> *junqueira*
>>
>> research scientist
>>
>> f...@yahoo-inc.com
>> direct +34 93-183-8828
>>
>> avinguda diagonal 177, 8th floor, barcelona, 08018, es
>> phone (408) 349 3300fax (408) 349 3301
>>
>>
>>
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Benjamin Reed]

i don't know why build-contrib.xml is missing. pat do you have any ideas?
ant tar should grab it right?

ben

On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira  wrote:

> Ben, I have a question. Even though the bookkeeper jar is there,
> build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails without
> it. Is it supposed to be this way?
>
> -Flavio
>
>
> On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:
>
> (the previous email had the URL slightly incorrect)
>
> after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
> this is a bug fix
> release addressing 13 issues (two of them extremely critical) -- see the
> release notes for details.
>
> *** Please download, test and VOTE before the
> *** vote closes 11pm pacific time, Tuesday, February 22.***
>
> http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
>
> one thing that has not been fixed in this release is that the docs still
> reference hadoop. this will be fixed in a future release.
>
> should we release this?
>
> ben
>
> ps - give that this is the first release there is more than likely
> something
> i missed and given the severity of issues addressed it would be nice to get
> it out quickly. please review ASAP.
>
>
> *flavio*
> *junqueira*
>
> research scientist
>
> f...@yahoo-inc.com
> direct +34 93-183-8828
>
> avinguda diagonal 177, 8th floor, barcelona, 08018, es
> phone (408) 349 3300fax (408) 349 3301
>
>
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Benjamin Reed]

i would like to get 880 in, but it is far from settled. the changes going in
for 880 and related patches could be destabilizing. as vishal points out,
one of the related patches isn't even committed to trunk yet.

ben

On Mon, Feb 21, 2011 at 3:46 AM, Flavio Junqueira  wrote:

> Hi again, I'm sorry for raising yet another point. I also wanted to point
> out that we have a few jiras marked as blocked not included in the current
> candidate. ZOOKEEPER-880 is one of them, and Vishal asked us to consider it
> for 3.3.3. I think that either we conclude that it is not a blocker and
> leave it marked for 3.4.0 as it is currently, or include it in 3.3.3.
>
> -Flavio
>
> On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:
>
> (the previous email had the URL slightly incorrect)
>
> after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
> this is a bug fix
> release addressing 13 issues (two of them extremely critical) -- see the
> release notes for details.
>
> *** Please download, test and VOTE before the
> *** vote closes 11pm pacific time, Tuesday, February 22.***
>
> http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
>
> one thing that has not been fixed in this release is that the docs still
> reference hadoop. this will be fixed in a future release.
>
> should we release this?
>
> ben
>
> ps - give that this is the first release there is more than likely
> something
> i missed and given the severity of issues addressed it would be nice to get
> it out quickly. please review ASAP.
>
>
> *flavio*
> *junqueira*
>
> research scientist
>
> f...@yahoo-inc.com
> direct +34 93-183-8828
>
> avinguda diagonal 177, 8th floor, barcelona, 08018, es
> phone (408) 349 3300fax (408) 349 3301
>
>
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Patrick Hunt]

Done. (hopefully this gives you some insight into why I've been
pushing for maven, not perfect but it does alot of this for you).

Patrick

On Tue, Feb 22, 2011 at 7:58 AM, Benjamin Reed  wrote:
> pat, do you mind updating the building section of
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease
> with
> these three items. signing the jar files is very unclear in the original
> doc. do i untar, sign, and retar? we don't do jarsigning?
>
> i'll do an rc1 this evening.
>
> ben
>
> On Mon, Feb 21, 2011 at 11:55 PM, Patrick Hunt  wrote:
>
>> -1, in general looks good but I did notice a few things:
>>
>> * the "zookeeper_version.h" file needs to be updated to version 3.3.3
>> * same with configure.ac (
>> http://wiki.apache.org/hadoop/ZooKeeper/HowToRelease)
>> * the toplevel zk jar and all jars in dist-maven have not been signed,
>> they need to be
>>
>> RAT passed so that's good.
>>
>> Patrick
>>
>> On Sat, Feb 19, 2011 at 6:27 AM, Benjamin Reed  wrote:
>> > (the previous email had the URL slightly incorrect)
>> >
>> > after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
>> > this is a bug fix
>> > release addressing 13 issues (two of them extremely critical) -- see the
>> > release notes for details.
>> >
>> > *** Please download, test and VOTE before the
>> > *** vote closes 11pm pacific time, Tuesday, February 22.***
>> >
>> > http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
>> >
>> > one thing that has not been fixed in this release is that the docs still
>> > reference hadoop. this will be fixed in a future release.
>> >
>> > should we release this?
>> >
>> > ben
>> >
>> > ps - give that this is the first release there is more than likely
>> something
>> > i missed and given the severity of issues addressed it would be nice to
>> get
>> > it out quickly. please review ASAP.
>> >
>>
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Patrick Hunt]

done

On Tue, Feb 22, 2011 at 7:59 AM, Benjamin Reed  wrote:
> can you add this to the how to release wiki as well?
>
> ben
>
> On Mon, Feb 21, 2011 at 9:38 AM, Patrick Hunt  wrote:
>
>> FYI: if you make bulk changes (greater than 5 or so, typically this happens
>> during release time) to JIRA please do use the bulk change feature, and in
>> particular turn OFF email notification. Subsequently send out a single email
>> detailing the changes.
>>
>> Patrick
>>
>> On Mon, Feb 21, 2011 at 3:46 AM, Flavio Junqueira wrote:
>>
>>> Hi again, I'm sorry for raising yet another point. I also wanted to point
>>> out that we have a few jiras marked as blocked not included in the current
>>> candidate. ZOOKEEPER-880 is one of them, and Vishal asked us to consider it
>>> for 3.3.3. I think that either we conclude that it is not a blocker and
>>> leave it marked for 3.4.0 as it is currently, or include it in 3.3.3.
>>>
>>> -Flavio
>>>
>>> On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:
>>>
>>> (the previous email had the URL slightly incorrect)
>>>
>>> after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
>>> this is a bug fix
>>> release addressing 13 issues (two of them extremely critical) -- see the
>>> release notes for details.
>>>
>>> *** Please download, test and VOTE before the
>>> *** vote closes 11pm pacific time, Tuesday, February 22.***
>>>
>>> http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
>>>
>>> one thing that has not been fixed in this release is that the docs still
>>> reference hadoop. this will be fixed in a future release.
>>>
>>> should we release this?
>>>
>>> ben
>>>
>>> ps - give that this is the first release there is more than likely
>>> something
>>> i missed and given the severity of issues addressed it would be nice to
>>> get
>>> it out quickly. please review ASAP.
>>>
>>>
>>>   *flavio*
>>> *junqueira*
>>>
>>> research scientist
>>>
>>> f...@yahoo-inc.com
>>> direct +34 93-183-8828
>>>
>>> avinguda diagonal 177, 8th floor, barcelona, 08018, es
>>> phone (408) 349 3300    fax (408) 349 3301
>>>
>>>
>>>
>>
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Patrick Hunt]

I think it's fine - it's in src/contrib not contrib.

On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed  wrote:

> i don't know why build-contrib.xml is missing. pat do you have any ideas?
> ant tar should grab it right?
>
> ben
>
>
> On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira wrote:
>
>> Ben, I have a question. Even though the bookkeeper jar is there,
>> build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails without
>> it. Is it supposed to be this way?
>>
>> -Flavio
>>
>>
>> On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:
>>
>> (the previous email had the URL slightly incorrect)
>>
>> after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
>> this is a bug fix
>> release addressing 13 issues (two of them extremely critical) -- see the
>> release notes for details.
>>
>> *** Please download, test and VOTE before the
>> *** vote closes 11pm pacific time, Tuesday, February 22.***
>>
>> http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
>>
>> one thing that has not been fixed in this release is that the docs still
>> reference hadoop. this will be fixed in a future release.
>>
>> should we release this?
>>
>> ben
>>
>> ps - give that this is the first release there is more than likely
>> something
>> i missed and given the severity of issues addressed it would be nice to
>> get
>> it out quickly. please review ASAP.
>>
>>
>>   *flavio*
>> *junqueira*
>>
>> research scientist
>>
>> f...@yahoo-inc.com
>> direct +34 93-183-8828
>>
>> avinguda diagonal 177, 8th floor, barcelona, 08018, es
>> phone (408) 349 3300fax (408) 349 3301
>>
>>
>>
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Flavio Junqueira]

I'm not sure why you say it is fine, Pat. If I try to compile with the candidate release, ant complains that build-contrib.xml is missing (and it is not where it is supposed to be). Compiling from trunk or one of the branches works fine, though.-FlavioOn Feb 22, 2011, at 6:04 PM, Patrick Hunt wrote:I think it's fine - it's in src/contrib not contrib.On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed  wrote:i don't know why build-contrib.xml is missing. pat do you have any ideas?ant tar should grab it right?benOn Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira wrote:Ben, I have a question. Even though the bookkeeper jar is there,build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails withoutit. Is it supposed to be this way?-FlavioOn Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:(the previous email had the URL slightly incorrect)after much struggle! i've created a candidate build for ZooKeeper 3.3.3.this is a bug fixrelease addressing 13 issues (two of them extremely critical) -- see therelease notes for details.*** Please download, test and VOTE before the*** vote closes 11pm pacific time, Tuesday, February 22.***http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/one thing that has not been fixed in this release is that the docs stillreference hadoop. this will be fixed in a future release.should we release this?benps - give that this is the first release there is more than likelysomethingi missed and given the severity of issues addressed it would be nice togetit out quickly. please review ASAP.  *flavio**junqueira*research scientistf...@yahoo-inc.comdirect +34 93-183-8828avinguda diagonal 177, 8th floor, barcelona, 08018, esphone (408) 349 3300    fax (408) 349 3301 flaviojunqueira research scientist f...@yahoo-inc.comdirect +34 93-183-8828 avinguda diagonal 177, 8th floor, barcelona, 08018, esphone (408) 349 3300fax (408) 349 3301 

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Mahadev Konar]

Ben/Vishal,
  Is there any possibility of getting ZOOKEEPER-880 in 3.3.3 release? The
Hbase guys had been asking for it.

thanks
mahadev

On Tue, Feb 22, 2011 at 9:38 AM, Flavio Junqueira  wrote:

> I'm not sure why you say it is fine, Pat. If I try to compile with the
> candidate release, ant complains that build-contrib.xml is missing (and it
> is not where it is supposed to be). Compiling from trunk or one of the
> branches works fine, though.
>
> -Flavio
>
> On Feb 22, 2011, at 6:04 PM, Patrick Hunt wrote:
>
> I think it's fine - it's in src/contrib not contrib.
>
> On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed  wrote:
>
> i don't know why build-contrib.xml is missing. pat do you have any ideas?
>
> ant tar should grab it right?
>
>
> ben
>
>
>
> On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira  >wrote:
>
>
> Ben, I have a question. Even though the bookkeeper jar is there,
>
> build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails without
>
> it. Is it supposed to be this way?
>
>
> -Flavio
>
>
>
> On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:
>
>
> (the previous email had the URL slightly incorrect)
>
>
> after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
>
> this is a bug fix
>
> release addressing 13 issues (two of them extremely critical) -- see the
>
> release notes for details.
>
>
> *** Please download, test and VOTE before the
>
> *** vote closes 11pm pacific time, Tuesday, February 22.***
>
>
> http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
>
>
> one thing that has not been fixed in this release is that the docs still
>
> reference hadoop. this will be fixed in a future release.
>
>
> should we release this?
>
>
> ben
>
>
> ps - give that this is the first release there is more than likely
>
> something
>
> i missed and given the severity of issues addressed it would be nice to
>
> get
>
> it out quickly. please review ASAP.
>
>
>
>  *flavio*
>
> *junqueira*
>
>
> research scientist
>
>
> f...@yahoo-inc.com
>
> direct +34 93-183-8828
>
>
> avinguda diagonal 177, 8th floor, barcelona, 08018, es
>
> phone (408) 349 3300fax (408) 349 3301
>
>
>
>
>
>
> *flavio*
> *junqueira*
>
> research scientist
>
> f...@yahoo-inc.com
> direct +34 93-183-8828
>
> avinguda diagonal 177, 8th floor, barcelona, 08018, es
> phone (408) 349 3300fax (408) 349 3301
>
>
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Vishal Kher]

Hi Mahadev,

I can certainly work on getting 880 in the release. I would like to know if
900 needs to go in 3.3.3 or not. If I remember correctly, merging patch for
880  failed when I tired last time because the fix for 900 was not committed
to 3.3.If 900 is not needed, then I can do the fix only for 880. Shouldn't
take that long. Note - without the fix for 900, QCM can block indefinitely.
This can cause serious problems during leader election (especially in a 3
node setup). Let me know.

-Vishal

btw, will there be another release before 3.4.0? We would like to have
patches to ZOOKEEPER-932and
ZOOKEEPER-975  released
soon as well.

On Tue, Feb 22, 2011 at 1:53 PM, Mahadev Konar  wrote:

> Ben/Vishal,
>   Is there any possibility of getting ZOOKEEPER-880 in 3.3.3 release? The
> Hbase guys had been asking for it.
>
> thanks
> mahadev
>
>
> On Tue, Feb 22, 2011 at 9:38 AM, Flavio Junqueira wrote:
>
>> I'm not sure why you say it is fine, Pat. If I try to compile with the
>> candidate release, ant complains that build-contrib.xml is missing (and it
>> is not where it is supposed to be). Compiling from trunk or one of the
>> branches works fine, though.
>>
>> -Flavio
>>
>> On Feb 22, 2011, at 6:04 PM, Patrick Hunt wrote:
>>
>> I think it's fine - it's in src/contrib not contrib.
>>
>> On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed 
>> wrote:
>>
>> i don't know why build-contrib.xml is missing. pat do you have any ideas?
>>
>> ant tar should grab it right?
>>
>>
>> ben
>>
>>
>>
>> On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira > >wrote:
>>
>>
>> Ben, I have a question. Even though the bookkeeper jar is there,
>>
>> build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails without
>>
>> it. Is it supposed to be this way?
>>
>>
>> -Flavio
>>
>>
>>
>> On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:
>>
>>
>> (the previous email had the URL slightly incorrect)
>>
>>
>> after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
>>
>> this is a bug fix
>>
>> release addressing 13 issues (two of them extremely critical) -- see the
>>
>> release notes for details.
>>
>>
>> *** Please download, test and VOTE before the
>>
>> *** vote closes 11pm pacific time, Tuesday, February 22.***
>>
>>
>> http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
>>
>>
>> one thing that has not been fixed in this release is that the docs still
>>
>> reference hadoop. this will be fixed in a future release.
>>
>>
>> should we release this?
>>
>>
>> ben
>>
>>
>> ps - give that this is the first release there is more than likely
>>
>> something
>>
>> i missed and given the severity of issues addressed it would be nice to
>>
>> get
>>
>> it out quickly. please review ASAP.
>>
>>
>>
>>  *flavio*
>>
>> *junqueira*
>>
>>
>> research scientist
>>
>>
>> f...@yahoo-inc.com
>>
>> direct +34 93-183-8828
>>
>>
>> avinguda diagonal 177, 8th floor, barcelona, 08018, es
>>
>> phone (408) 349 3300fax (408) 349 3301
>>
>>
>>
>>
>>
>>
>>   *flavio*
>> *junqueira*
>>
>> research scientist
>>
>> f...@yahoo-inc.com
>> direct +34 93-183-8828
>>
>> avinguda diagonal 177, 8th floor, barcelona, 08018, es
>> phone (408) 349 3300fax (408) 349 3301
>>
>>
>>
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Flavio Junqueira]

Hi Vishal, ZOOKEEPER-900 has been committed to trunk, but not to branch 3.3, correct? You have not uploaded a patch for ZOOKEEPER-900 branch 3.3, right?-FlavioOn Feb 22, 2011, at 10:09 PM, Vishal Kher wrote:Hi Mahadev,I can certainly work on getting 880 in the release. I would like to know if 900 needs to go in 3.3.3 or not. If I remember correctly, merging patch for 880  failed when I tired last time because the fix for 900 was not committed to 3.3.If 900 is not needed, then I can do the fix only for 880. Shouldn't take that long. Note - without the fix for 900, QCM can block indefinitely. This can cause serious problems during leader election (especially in a 3 node setup). Let me know. -Vishalbtw, will there be another release before 3.4.0? We would like to have patches to ZOOKEEPER-932 and ZOOKEEPER-975 released soon as well. On Tue, Feb 22, 2011 at 1:53 PM, Mahadev Konar  wrote: Ben/Vishal,  Is there any possibility of getting ZOOKEEPER-880 in 3.3.3 release? The Hbase guys had been asking for it.thanksmahadev On Tue, Feb 22, 2011 at 9:38 AM, Flavio Junqueira  wrote: I'm not sure why you say it is fine, Pat. If I try to compile with the candidate release, ant complains that build-contrib.xml is missing (and it is not where it is supposed to be). Compiling from trunk or one of the branches works fine, though. -FlavioOn Feb 22, 2011, at 6:04 PM, Patrick Hunt wrote:I think it's fine - it's in src/contrib not contrib. On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed  wrote:i don't know why build-contrib.xml is missing. pat do you have any ideas? ant tar should grab it right?ben On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira wrote: Ben, I have a question. Even though the bookkeeper jar is there,build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails without it. Is it supposed to be this way? -Flavio On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote: (the previous email had the URL slightly incorrect)after much struggle! i've created a candidate build for ZooKeeper 3.3.3. this is a bug fixrelease addressing 13 issues (two of them extremely critical) -- see the release notes for details. *** Please download, test and VOTE before the*** vote closes 11pm pacific time, Tuesday, February 22.*** http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/ one thing that has not been fixed in this release is that the docs still reference hadoop. this will be fixed in a future release. should we release this? benps - give that this is the first release there is more than likely somethingi missed and given the severity of issues addressed it would be nice to getit out quickly. please review ASAP.    *flavio*  *junqueira*research scientist f...@yahoo-inc.com direct +34 93-183-8828 avinguda diagonal 177, 8th floor, barcelona, 08018, esphone (408) 349 3300    fax (408) 349 3301  flaviojunqueira  research scientist f...@yahoo-inc.com direct +34 93-183-8828 avinguda diagonal 177, 8th floor, barcelona, 08018, es phone (408) 349 3300fax (408) 349 3301flaviojunqueira research scientist f...@yahoo-inc.comdirect +34 93-183-8828 avinguda diagonal 177, 8th floor, barcelona, 08018, esphone (408) 349 3300fax (408) 349 3301 

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Vishal Kher]

Hi Flavio,

I haven't posted a patch for for ZOOKEEPER-900 branch 3.3. I think the bug
was originally marked for 3.4.0.

On Tue, Feb 22, 2011 at 4:24 PM, Flavio Junqueira  wrote:

> Hi Vishal, ZOOKEEPER-900 has been committed to trunk, but not to branch
> 3.3, correct? You have not uploaded a patch for ZOOKEEPER-900 branch 3.3,
> right?
>
> -Flavio
>
> On Feb 22, 2011, at 10:09 PM, Vishal Kher wrote:
>
> Hi Mahadev,
>
> I can certainly work on getting 880 in the release. I would like to know if
> 900 needs to go in 3.3.3 or not. If I remember correctly, merging patch for
> 880  failed when I tired last time because the fix for 900 was not committed
> to 3.3.If 900 is not needed, then I can do the fix only for 880. Shouldn't
> take that long. Note - without the fix for 900, QCM can block indefinitely.
> This can cause serious problems during leader election (especially in a 3
> node setup). Let me know.
>
> -Vishal
>
> btw, will there be another release before 3.4.0? We would like to have
> patches to 
> ZOOKEEPER-932and
> ZOOKEEPER-975 released 
> soon as well.
>
> On Tue, Feb 22, 2011 at 1:53 PM, Mahadev Konar  wrote:
>
>> Ben/Vishal,
>>   Is there any possibility of getting ZOOKEEPER-880 in 3.3.3 release? The
>> Hbase guys had been asking for it.
>>
>> thanks
>> mahadev
>>
>>
>> On Tue, Feb 22, 2011 at 9:38 AM, Flavio Junqueira wrote:
>>
>>> I'm not sure why you say it is fine, Pat. If I try to compile with the
>>> candidate release, ant complains that build-contrib.xml is missing (and it
>>> is not where it is supposed to be). Compiling from trunk or one of the
>>> branches works fine, though.
>>>
>>> -Flavio
>>>
>>> On Feb 22, 2011, at 6:04 PM, Patrick Hunt wrote:
>>>
>>> I think it's fine - it's in src/contrib not contrib.
>>>
>>> On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed 
>>> wrote:
>>>
>>> i don't know why build-contrib.xml is missing. pat do you have any ideas?
>>>
>>> ant tar should grab it right?
>>>
>>>
>>> ben
>>>
>>>
>>>
>>> On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira >> >wrote:
>>>
>>>
>>> Ben, I have a question. Even though the bookkeeper jar is there,
>>>
>>> build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails without
>>>
>>> it. Is it supposed to be this way?
>>>
>>>
>>> -Flavio
>>>
>>>
>>>
>>> On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:
>>>
>>>
>>> (the previous email had the URL slightly incorrect)
>>>
>>>
>>> after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
>>>
>>> this is a bug fix
>>>
>>> release addressing 13 issues (two of them extremely critical) -- see the
>>>
>>> release notes for details.
>>>
>>>
>>> *** Please download, test and VOTE before the
>>>
>>> *** vote closes 11pm pacific time, Tuesday, February 22.***
>>>
>>>
>>> http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
>>>
>>>
>>> one thing that has not been fixed in this release is that the docs still
>>>
>>> reference hadoop. this will be fixed in a future release.
>>>
>>>
>>> should we release this?
>>>
>>>
>>> ben
>>>
>>>
>>> ps - give that this is the first release there is more than likely
>>>
>>> something
>>>
>>> i missed and given the severity of issues addressed it would be nice to
>>>
>>> get
>>>
>>> it out quickly. please review ASAP.
>>>
>>>
>>>
>>>  *flavio*
>>>
>>>  *junqueira*
>>>
>>>
>>> research scientist
>>>
>>>
>>> f...@yahoo-inc.com
>>>
>>> direct +34 93-183-8828
>>>
>>>
>>> avinguda diagonal 177, 8th floor, barcelona, 08018, es
>>>
>>> phone (408) 349 3300fax (408) 349 3301
>>>
>>>
>>>
>>>
>>>
>>>
>>>   *flavio*
>>> *junqueira*
>>>
>>> research scientist
>>>
>>> f...@yahoo-inc.com
>>> direct +34 93-183-8828
>>>
>>> avinguda diagonal 177, 8th floor, barcelona, 08018, es
>>> phone (408) 349 3300fax (408) 349 3301
>>>
>>> 
>>>
>>>
>>
>
> *flavio*
> *junqueira*
>
> research scientist
>
> f...@yahoo-inc.com
> direct +34 93-183-8828
>
> avinguda diagonal 177, 8th floor, barcelona, 08018, es
> phone (408) 349 3300fax (408) 349 3301
>
>
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Patrick Hunt]

On Tue, Feb 22, 2011 at 9:38 AM, Flavio Junqueira  wrote:

> I'm not sure why you say it is fine, Pat. If I try to compile with the
> candidate release, ant complains that build-contrib.xml is missing (and it
> is not where it is supposed to be). Compiling from trunk or one of the
> branches works fine, though.
>

Hi Flavio, can you be more specific? Because it's working fine for me:

cd zookeeper-3.3.3/src/contrib/bookkeeper
ant jar
...
jar:
 [echo] contrib: bookkeeper

BUILD SUCCESSFUL
Total time: 2 seconds



> -Flavio
>
> On Feb 22, 2011, at 6:04 PM, Patrick Hunt wrote:
>
> I think it's fine - it's in src/contrib not contrib.
>
> On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed  wrote:
>
> i don't know why build-contrib.xml is missing. pat do you have any ideas?
>
> ant tar should grab it right?
>
>
> ben
>
>
>
> On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira  >wrote:
>
>
> Ben, I have a question. Even though the bookkeeper jar is there,
>
> build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails without
>
> it. Is it supposed to be this way?
>
>
> -Flavio
>
>
>
> On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:
>
>
> (the previous email had the URL slightly incorrect)
>
>
> after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
>
> this is a bug fix
>
> release addressing 13 issues (two of them extremely critical) -- see the
>
> release notes for details.
>
>
> *** Please download, test and VOTE before the
>
> *** vote closes 11pm pacific time, Tuesday, February 22.***
>
>
> http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
>
>
> one thing that has not been fixed in this release is that the docs still
>
> reference hadoop. this will be fixed in a future release.
>
>
> should we release this?
>
>
> ben
>
>
> ps - give that this is the first release there is more than likely
>
> something
>
> i missed and given the severity of issues addressed it would be nice to
>
> get
>
> it out quickly. please review ASAP.
>
>
>
>  *flavio*
>
> *junqueira*
>
>
> research scientist
>
>
> f...@yahoo-inc.com
>
> direct +34 93-183-8828
>
>
> avinguda diagonal 177, 8th floor, barcelona, 08018, es
>
> phone (408) 349 3300fax (408) 349 3301
>
>
>
>
>
>
> *flavio*
> *junqueira*
>
> research scientist
>
> f...@yahoo-inc.com
> direct +34 93-183-8828
>
> avinguda diagonal 177, 8th floor, barcelona, 08018, es
> phone (408) 349 3300fax (408) 349 3301
>
>
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Mahadev Konar]

Hi Vishal,
  900 seems like a biigger change. I think just 880 should be fine, so that
folks dont hit the thread blow up issue. BTW, all depends on Ben if he is
willing to get 880 in 3.3.3 release. If not we'll have to wait for 3.4 or
another release  like 3.3.4 (which i personally would like to avoid).

thanks
mahadev

On Tue, Feb 22, 2011 at 1:09 PM, Vishal Kher  wrote:

> Hi Mahadev,
>
> I can certainly work on getting 880 in the release. I would like to know if
> 900 needs to go in 3.3.3 or not. If I remember correctly, merging patch for
> 880  failed when I tired last time because the fix for 900 was not committed
> to 3.3.If 900 is not needed, then I can do the fix only for 880. Shouldn't
> take that long. Note - without the fix for 900, QCM can block indefinitely.
> This can cause serious problems during leader election (especially in a 3
> node setup). Let me know.
>
> -Vishal
>
> btw, will there be another release before 3.4.0? We would like to have
> patches to 
> ZOOKEEPER-932and
> ZOOKEEPER-975 released 
> soon as well.
>
>
> On Tue, Feb 22, 2011 at 1:53 PM, Mahadev Konar  wrote:
>
>> Ben/Vishal,
>>   Is there any possibility of getting ZOOKEEPER-880 in 3.3.3 release? The
>> Hbase guys had been asking for it.
>>
>> thanks
>> mahadev
>>
>>
>> On Tue, Feb 22, 2011 at 9:38 AM, Flavio Junqueira wrote:
>>
>>> I'm not sure why you say it is fine, Pat. If I try to compile with the
>>> candidate release, ant complains that build-contrib.xml is missing (and it
>>> is not where it is supposed to be). Compiling from trunk or one of the
>>> branches works fine, though.
>>>
>>> -Flavio
>>>
>>> On Feb 22, 2011, at 6:04 PM, Patrick Hunt wrote:
>>>
>>> I think it's fine - it's in src/contrib not contrib.
>>>
>>> On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed 
>>> wrote:
>>>
>>> i don't know why build-contrib.xml is missing. pat do you have any ideas?
>>>
>>> ant tar should grab it right?
>>>
>>>
>>> ben
>>>
>>>
>>>
>>> On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira >> >wrote:
>>>
>>>
>>> Ben, I have a question. Even though the bookkeeper jar is there,
>>>
>>> build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails without
>>>
>>> it. Is it supposed to be this way?
>>>
>>>
>>> -Flavio
>>>
>>>
>>>
>>> On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:
>>>
>>>
>>> (the previous email had the URL slightly incorrect)
>>>
>>>
>>> after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
>>>
>>> this is a bug fix
>>>
>>> release addressing 13 issues (two of them extremely critical) -- see the
>>>
>>> release notes for details.
>>>
>>>
>>> *** Please download, test and VOTE before the
>>>
>>> *** vote closes 11pm pacific time, Tuesday, February 22.***
>>>
>>>
>>> http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
>>>
>>>
>>> one thing that has not been fixed in this release is that the docs still
>>>
>>> reference hadoop. this will be fixed in a future release.
>>>
>>>
>>> should we release this?
>>>
>>>
>>> ben
>>>
>>>
>>> ps - give that this is the first release there is more than likely
>>>
>>> something
>>>
>>> i missed and given the severity of issues addressed it would be nice to
>>>
>>> get
>>>
>>> it out quickly. please review ASAP.
>>>
>>>
>>>
>>>  *flavio*
>>>
>>>  *junqueira*
>>>
>>>
>>> research scientist
>>>
>>>
>>> f...@yahoo-inc.com
>>>
>>> direct +34 93-183-8828
>>>
>>>
>>> avinguda diagonal 177, 8th floor, barcelona, 08018, es
>>>
>>> phone (408) 349 3300fax (408) 349 3301
>>>
>>>
>>>
>>>
>>>
>>>
>>>   *flavio*
>>> *junqueira*
>>>
>>> research scientist
>>>
>>> f...@yahoo-inc.com
>>> direct +34 93-183-8828
>>>
>>> avinguda diagonal 177, 8th floor, barcelona, 08018, es
>>> phone (408) 349 3300fax (408) 349 3301
>>>
>>>
>>>
>>
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Benjamin Reed]

sorry i didn't respond earlier. i've been off the grid today. (tahoe) since
i have to roll a new release anyway. i'd be glad to put it in. i just don't
want to delay the release any longer.

ben

On Tue, Feb 22, 2011 at 2:45 PM, Mahadev Konar  wrote:

> Hi Vishal,
>   900 seems like a biigger change. I think just 880 should be fine, so that
> folks dont hit the thread blow up issue. BTW, all depends on Ben if he is
> willing to get 880 in 3.3.3 release. If not we'll have to wait for 3.4 or
> another release  like 3.3.4 (which i personally would like to avoid).
>
> thanks
> mahadev
>
> On Tue, Feb 22, 2011 at 1:09 PM, Vishal Kher  wrote:
>
>> Hi Mahadev,
>>
>> I can certainly work on getting 880 in the release. I would like to know
>> if 900 needs to go in 3.3.3 or not. If I remember correctly, merging patch
>> for 880  failed when I tired last time because the fix for 900 was not
>> committed to 3.3.If 900 is not needed, then I can do the fix only for 880.
>> Shouldn't take that long. Note - without the fix for 900, QCM can block
>> indefinitely. This can cause serious problems during leader election
>> (especially in a 3 node setup). Let me know.
>>
>> -Vishal
>>
>> btw, will there be another release before 3.4.0? We would like to have
>> patches to 
>> ZOOKEEPER-932and
>> ZOOKEEPER-975 released 
>> soon as well.
>>
>>
>> On Tue, Feb 22, 2011 at 1:53 PM, Mahadev Konar wrote:
>>
>>> Ben/Vishal,
>>>   Is there any possibility of getting ZOOKEEPER-880 in 3.3.3 release? The
>>> Hbase guys had been asking for it.
>>>
>>> thanks
>>> mahadev
>>>
>>>
>>> On Tue, Feb 22, 2011 at 9:38 AM, Flavio Junqueira wrote:
>>>
 I'm not sure why you say it is fine, Pat. If I try to compile with the
 candidate release, ant complains that build-contrib.xml is missing (and it
 is not where it is supposed to be). Compiling from trunk or one of the
 branches works fine, though.

 -Flavio

 On Feb 22, 2011, at 6:04 PM, Patrick Hunt wrote:

 I think it's fine - it's in src/contrib not contrib.

 On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed 
 wrote:

 i don't know why build-contrib.xml is missing. pat do you have any
 ideas?

 ant tar should grab it right?


 ben



 On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira >>> >wrote:


 Ben, I have a question. Even though the bookkeeper jar is there,

 build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails
 without

 it. Is it supposed to be this way?


 -Flavio



 On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:


 (the previous email had the URL slightly incorrect)


 after much struggle! i've created a candidate build for ZooKeeper 3.3.3.

 this is a bug fix

 release addressing 13 issues (two of them extremely critical) -- see the

 release notes for details.


 *** Please download, test and VOTE before the

 *** vote closes 11pm pacific time, Tuesday, February 22.***


 http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/


 one thing that has not been fixed in this release is that the docs still

 reference hadoop. this will be fixed in a future release.


 should we release this?


 ben


 ps - give that this is the first release there is more than likely

 something

 i missed and given the severity of issues addressed it would be nice to

 get

 it out quickly. please review ASAP.



  *flavio*

  *junqueira*


 research scientist


 f...@yahoo-inc.com

 direct +34 93-183-8828


 avinguda diagonal 177, 8th floor, barcelona, 08018, es

 phone (408) 349 3300fax (408) 349 3301






   *flavio*
 *junqueira*

 research scientist

 f...@yahoo-inc.com
 direct +34 93-183-8828

 avinguda diagonal 177, 8th floor, barcelona, 08018, es
 phone (408) 349 3300fax (408) 349 3301



>>>
>>
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Mahadev Konar]

Thanks Ben. Vishal, would you be able to upload the patch today/tomm?
I can review and commit.

thanks
mahadev

On Tue, Feb 22, 2011 at 7:38 PM, Benjamin Reed  wrote:
> sorry i didn't respond earlier. i've been off the grid today. (tahoe) since
> i have to roll a new release anyway. i'd be glad to put it in. i just don't
> want to delay the release any longer.
>
> ben
>
> On Tue, Feb 22, 2011 at 2:45 PM, Mahadev Konar  wrote:
>
>> Hi Vishal,
>>   900 seems like a biigger change. I think just 880 should be fine, so that
>> folks dont hit the thread blow up issue. BTW, all depends on Ben if he is
>> willing to get 880 in 3.3.3 release. If not we'll have to wait for 3.4 or
>> another release  like 3.3.4 (which i personally would like to avoid).
>>
>> thanks
>> mahadev
>>
>> On Tue, Feb 22, 2011 at 1:09 PM, Vishal Kher  wrote:
>>
>>> Hi Mahadev,
>>>
>>> I can certainly work on getting 880 in the release. I would like to know
>>> if 900 needs to go in 3.3.3 or not. If I remember correctly, merging patch
>>> for 880  failed when I tired last time because the fix for 900 was not
>>> committed to 3.3.If 900 is not needed, then I can do the fix only for 880.
>>> Shouldn't take that long. Note - without the fix for 900, QCM can block
>>> indefinitely. This can cause serious problems during leader election
>>> (especially in a 3 node setup). Let me know.
>>>
>>> -Vishal
>>>
>>> btw, will there be another release before 3.4.0? We would like to have
>>> patches to 
>>> ZOOKEEPER-932and
>>> ZOOKEEPER-975 released 
>>> soon as well.
>>>
>>>
>>> On Tue, Feb 22, 2011 at 1:53 PM, Mahadev Konar wrote:
>>>
 Ben/Vishal,
   Is there any possibility of getting ZOOKEEPER-880 in 3.3.3 release? The
 Hbase guys had been asking for it.

 thanks
 mahadev


 On Tue, Feb 22, 2011 at 9:38 AM, Flavio Junqueira 
 wrote:

> I'm not sure why you say it is fine, Pat. If I try to compile with the
> candidate release, ant complains that build-contrib.xml is missing (and it
> is not where it is supposed to be). Compiling from trunk or one of the
> branches works fine, though.
>
> -Flavio
>
> On Feb 22, 2011, at 6:04 PM, Patrick Hunt wrote:
>
> I think it's fine - it's in src/contrib not contrib.
>
> On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed 
> wrote:
>
> i don't know why build-contrib.xml is missing. pat do you have any
> ideas?
>
> ant tar should grab it right?
>
>
> ben
>
>
>
> On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira  >wrote:
>
>
> Ben, I have a question. Even though the bookkeeper jar is there,
>
> build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails
> without
>
> it. Is it supposed to be this way?
>
>
> -Flavio
>
>
>
> On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:
>
>
> (the previous email had the URL slightly incorrect)
>
>
> after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
>
> this is a bug fix
>
> release addressing 13 issues (two of them extremely critical) -- see the
>
> release notes for details.
>
>
> *** Please download, test and VOTE before the
>
> *** vote closes 11pm pacific time, Tuesday, February 22.***
>
>
> http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
>
>
> one thing that has not been fixed in this release is that the docs still
>
> reference hadoop. this will be fixed in a future release.
>
>
> should we release this?
>
>
> ben
>
>
> ps - give that this is the first release there is more than likely
>
> something
>
> i missed and given the severity of issues addressed it would be nice to
>
> get
>
> it out quickly. please review ASAP.
>
>
>
>  *flavio*
>
>  *junqueira*
>
>
> research scientist
>
>
> f...@yahoo-inc.com
>
> direct +34 93-183-8828
>
>
> avinguda diagonal 177, 8th floor, barcelona, 08018, es
>
> phone (408) 349 3300    fax (408) 349 3301
>
>
>
>
>
>
>   *flavio*
> *junqueira*
>
> research scientist
>
> f...@yahoo-inc.com
> direct +34 93-183-8828
>
> avinguda diagonal 177, 8th floor, barcelona, 08018, es
> phone (408) 349 3300    fax (408) 349 3301
>
>
>

>>>
>>
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Benjamin Reed]

in step 3 under building you say "Tar/GZ the release directory as
zookeeper-X.Y.Z.tar.gz". the release directory refers the directory you
untared the tar.gz file into in step 2. right?

ben

On Tue, Feb 22, 2011 at 9:02 AM, Patrick Hunt  wrote:

> Done. (hopefully this gives you some insight into why I've been
> pushing for maven, not perfect but it does alot of this for you).
>
> Patrick
>
> On Tue, Feb 22, 2011 at 7:58 AM, Benjamin Reed  wrote:
> > pat, do you mind updating the building section of
> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease
> > with
> > these three items. signing the jar files is very unclear in the original
> > doc. do i untar, sign, and retar? we don't do jarsigning?
> >
> > i'll do an rc1 this evening.
> >
> > ben
> >
> > On Mon, Feb 21, 2011 at 11:55 PM, Patrick Hunt  wrote:
> >
> >> -1, in general looks good but I did notice a few things:
> >>
> >> * the "zookeeper_version.h" file needs to be updated to version 3.3.3
> >> * same with configure.ac (
> >> http://wiki.apache.org/hadoop/ZooKeeper/HowToRelease)
> >> * the toplevel zk jar and all jars in dist-maven have not been signed,
> >> they need to be
> >>
> >> RAT passed so that's good.
> >>
> >> Patrick
> >>
> >> On Sat, Feb 19, 2011 at 6:27 AM, Benjamin Reed 
> wrote:
> >> > (the previous email had the URL slightly incorrect)
> >> >
> >> > after much struggle! i've created a candidate build for ZooKeeper
> 3.3.3.
> >> > this is a bug fix
> >> > release addressing 13 issues (two of them extremely critical) -- see
> the
> >> > release notes for details.
> >> >
> >> > *** Please download, test and VOTE before the
> >> > *** vote closes 11pm pacific time, Tuesday, February 22.***
> >> >
> >> > http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
> >> >
> >> > one thing that has not been fixed in this release is that the docs
> still
> >> > reference hadoop. this will be fixed in a future release.
> >> >
> >> > should we release this?
> >> >
> >> > ben
> >> >
> >> > ps - give that this is the first release there is more than likely
> >> something
> >> > i missed and given the severity of issues addressed it would be nice
> to
> >> get
> >> > it out quickly. please review ASAP.
> >> >
> >>
> >
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Flavio Junqueira]

The problem is that there is a path "zookeeper-3.3.3/contrib/bookkeeper" containing build.xml and source code. If you try to run from there, it will fail. I'm actually wondering why we have the source code both under contrib/ and under src/contrib/. The folder structure under contrib/ is different and it does look like it is not supposed to compile (hence my confusion), and I wonder why we need it in the release. -FlavioOn Feb 22, 2011, at 10:34 PM, Patrick Hunt wrote:On Tue, Feb 22, 2011 at 9:38 AM, Flavio Junqueira  wrote: I'm not sure why you say it is fine, Pat. If I try to compile with the candidate release, ant complains that build-contrib.xml is missing (and it is not where it is supposed to be). Compiling from trunk or one of the branches works fine, though. Hi Flavio, can you be more specific? Because it's working fine for me:cd zookeeper-3.3.3/src/contrib/bookkeeper ant jar...jar:      [echo] contrib: bookkeeperBUILD SUCCESSFULTotal time: 2 seconds -FlavioOn Feb 22, 2011, at 6:04 PM, Patrick Hunt wrote: I think it's fine - it's in src/contrib not contrib.On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed  wrote: i don't know why build-contrib.xml is missing. pat do you have any ideas?ant tar should grab it right? benOn Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira wrote: Ben, I have a question. Even though the bookkeeper jar is there, build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails withoutit. Is it supposed to be this way? -Flavio On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote: (the previous email had the URL slightly incorrect) after much struggle! i've created a candidate build for ZooKeeper 3.3.3.this is a bug fix release addressing 13 issues (two of them extremely critical) -- see the release notes for details.*** Please download, test and VOTE before the *** vote closes 11pm pacific time, Tuesday, February 22.*** http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/ one thing that has not been fixed in this release is that the docs still reference hadoop. this will be fixed in a future release. should we release this? benps - give that this is the first release there is more than likely somethingi missed and given the severity of issues addressed it would be nice to getit out quickly. please review ASAP.   *flavio* *junqueira*research scientist f...@yahoo-inc.com direct +34 93-183-8828 avinguda diagonal 177, 8th floor, barcelona, 08018, esphone (408) 349 3300    fax (408) 349 3301  flaviojunqueira  research scientist f...@yahoo-inc.com direct +34 93-183-8828 avinguda diagonal 177, 8th floor, barcelona, 08018, es phone (408) 349 3300fax (408) 349 3301   flaviojunqueira research scientist f...@yahoo-inc.comdirect +34 93-183-8828 avinguda diagonal 177, 8th floor, barcelona, 08018, esphone (408) 349 3300fax (408) 349 3301 

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Thomas Koch]

Flavio Junqueira:
> The problem is that there is a path "zookeeper-3.3.3/contrib/
> bookkeeper" containing build.xml and source code. If you try to run
> from there, it will fail. I'm actually wondering why we have the
> source code both under contrib/ and under src/contrib/. The folder
> structure under contrib/ is different and it does look like it is not
> supposed to compile (hence my confusion), and I wonder why we need it
> in the release.
> 
> -Flavio
The code dupliation of contrib and src/contrib is one of the annoyances when 
packaging ZooKeeper for Debian. You'd really do me a favor if you'd release a 
tarball without this duplication.
(The biggest annoyance is the shipment of binary .jar files in every java 
project, not only ZooKeeper. - But things are getting better slowly with 
maven.)

Best regards,

Thomas Koch, http://www.koch.ro

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Vishal Kher]

Yes, hopefully by EOD today.


On Wed, Feb 23, 2011 at 6:21 AM, Flavio Junqueira  wrote:

> The problem is that there is a path "zookeeper-3.3.3/contrib/bookkeeper"
> containing build.xml and source code. If you try to run from there, it will
> fail. I'm actually wondering why we have the source code both under contrib/
> and under src/contrib/. The folder structure under contrib/ is different and
> it does look like it is not supposed to compile (hence my confusion), and I
> wonder why we need it in the release.
>
> -Flavio
>
>
> On Feb 22, 2011, at 10:34 PM, Patrick Hunt wrote:
>
> On Tue, Feb 22, 2011 at 9:38 AM, Flavio Junqueira 
>  wrote:
>
>> I'm not sure why you say it is fine, Pat. If I try to compile with the
>> candidate release, ant complains that build-contrib.xml is missing (and it
>> is not where it is supposed to be). Compiling from trunk or one of the
>> branches works fine, though.
>>
>
> Hi Flavio, can you be more specific? Because it's working fine for me:
>
> cd zookeeper-3.3.3/src/contrib/bookkeeper
> ant jar
> ...
> jar:
>  [echo] contrib: bookkeeper
>
> BUILD SUCCESSFUL
> Total time: 2 seconds
>
>
>
>> -Flavio
>>
>> On Feb 22, 2011, at 6:04 PM, Patrick Hunt wrote:
>>
>> I think it's fine - it's in src/contrib not contrib.
>>
>> On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed 
>> wrote:
>>
>> i don't know why build-contrib.xml is missing. pat do you have any ideas?
>>
>> ant tar should grab it right?
>>
>>
>> ben
>>
>>
>>
>> On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira > >wrote:
>>
>>
>> Ben, I have a question. Even though the bookkeeper jar is there,
>>
>> build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails without
>>
>> it. Is it supposed to be this way?
>>
>>
>> -Flavio
>>
>>
>>
>> On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:
>>
>>
>> (the previous email had the URL slightly incorrect)
>>
>>
>> after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
>>
>> this is a bug fix
>>
>> release addressing 13 issues (two of them extremely critical) -- see the
>>
>> release notes for details.
>>
>>
>> *** Please download, test and VOTE before the
>>
>> *** vote closes 11pm pacific time, Tuesday, February 22.***
>>
>>
>> http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
>>
>>
>> one thing that has not been fixed in this release is that the docs still
>>
>> reference hadoop. this will be fixed in a future release.
>>
>>
>> should we release this?
>>
>>
>> ben
>>
>>
>> ps - give that this is the first release there is more than likely
>>
>> something
>>
>> i missed and given the severity of issues addressed it would be nice to
>>
>> get
>>
>> it out quickly. please review ASAP.
>>
>>
>>
>>  *flavio*
>>
>> *junqueira*
>>
>>
>> research scientist
>>
>>
>> f...@yahoo-inc.com
>>
>> direct +34 93-183-8828
>>
>>
>> avinguda diagonal 177, 8th floor, barcelona, 08018, es
>>
>> phone (408) 349 3300fax (408) 349 3301
>>
>>
>>
>>
>>
>>
>>   *flavio*
>> *junqueira*
>>
>> research scientist
>>
>> f...@yahoo-inc.com
>> direct +34 93-183-8828
>>
>> avinguda diagonal 177, 8th floor, barcelona, 08018, es
>> phone (408) 349 3300fax (408) 349 3301
>>
>> 
>>
>>
>
> *flavio*
> *junqueira*
>
> research scientist
>
> f...@yahoo-inc.com
> direct +34 93-183-8828
>
> avinguda diagonal 177, 8th floor, barcelona, 08018, es
> phone (408) 349 3300fax (408) 349 3301
>
>
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Vishal Kher]

Hi Mahadev,

I have submitted the patch to the jira.

-Vishal

On Tue, Feb 22, 2011 at 11:14 PM, Mahadev Konar  wrote:

> Thanks Ben. Vishal, would you be able to upload the patch today/tomm?
> I can review and commit.
>
> thanks
> mahadev
>
> On Tue, Feb 22, 2011 at 7:38 PM, Benjamin Reed  wrote:
> > sorry i didn't respond earlier. i've been off the grid today. (tahoe)
> since
> > i have to roll a new release anyway. i'd be glad to put it in. i just
> don't
> > want to delay the release any longer.
> >
> > ben
> >
> > On Tue, Feb 22, 2011 at 2:45 PM, Mahadev Konar 
> wrote:
> >
> >> Hi Vishal,
> >>   900 seems like a biigger change. I think just 880 should be fine, so
> that
> >> folks dont hit the thread blow up issue. BTW, all depends on Ben if he
> is
> >> willing to get 880 in 3.3.3 release. If not we'll have to wait for 3.4
> or
> >> another release  like 3.3.4 (which i personally would like to avoid).
> >>
> >> thanks
> >> mahadev
> >>
> >> On Tue, Feb 22, 2011 at 1:09 PM, Vishal Kher 
> wrote:
> >>
> >>> Hi Mahadev,
> >>>
> >>> I can certainly work on getting 880 in the release. I would like to
> know
> >>> if 900 needs to go in 3.3.3 or not. If I remember correctly, merging
> patch
> >>> for 880  failed when I tired last time because the fix for 900 was not
> >>> committed to 3.3.If 900 is not needed, then I can do the fix only for
> 880.
> >>> Shouldn't take that long. Note - without the fix for 900, QCM can block
> >>> indefinitely. This can cause serious problems during leader election
> >>> (especially in a 3 node setup). Let me know.
> >>>
> >>> -Vishal
> >>>
> >>> btw, will there be another release before 3.4.0? We would like to have
> >>> patches to ZOOKEEPER-932<
> https://issues.apache.org/jira/browse/ZOOKEEPER-932>and
> >>> ZOOKEEPER-975 
> >>> released
> soon as well.
> >>>
> >>>
> >>> On Tue, Feb 22, 2011 at 1:53 PM, Mahadev Konar  >wrote:
> >>>
>  Ben/Vishal,
>    Is there any possibility of getting ZOOKEEPER-880 in 3.3.3 release?
> The
>  Hbase guys had been asking for it.
> 
>  thanks
>  mahadev
> 
> 
>  On Tue, Feb 22, 2011 at 9:38 AM, Flavio Junqueira  >wrote:
> 
> > I'm not sure why you say it is fine, Pat. If I try to compile with
> the
> > candidate release, ant complains that build-contrib.xml is missing
> (and it
> > is not where it is supposed to be). Compiling from trunk or one of
> the
> > branches works fine, though.
> >
> > -Flavio
> >
> > On Feb 22, 2011, at 6:04 PM, Patrick Hunt wrote:
> >
> > I think it's fine - it's in src/contrib not contrib.
> >
> > On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed 
> > wrote:
> >
> > i don't know why build-contrib.xml is missing. pat do you have any
> > ideas?
> >
> > ant tar should grab it right?
> >
> >
> > ben
> >
> >
> >
> > On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira  > >wrote:
> >
> >
> > Ben, I have a question. Even though the bookkeeper jar is there,
> >
> > build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails
> > without
> >
> > it. Is it supposed to be this way?
> >
> >
> > -Flavio
> >
> >
> >
> > On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:
> >
> >
> > (the previous email had the URL slightly incorrect)
> >
> >
> > after much struggle! i've created a candidate build for ZooKeeper
> 3.3.3.
> >
> > this is a bug fix
> >
> > release addressing 13 issues (two of them extremely critical) -- see
> the
> >
> > release notes for details.
> >
> >
> > *** Please download, test and VOTE before the
> >
> > *** vote closes 11pm pacific time, Tuesday, February 22.***
> >
> >
> > http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
> >
> >
> > one thing that has not been fixed in this release is that the docs
> still
> >
> > reference hadoop. this will be fixed in a future release.
> >
> >
> > should we release this?
> >
> >
> > ben
> >
> >
> > ps - give that this is the first release there is more than likely
> >
> > something
> >
> > i missed and given the severity of issues addressed it would be nice
> to
> >
> > get
> >
> > it out quickly. please review ASAP.
> >
> >
> >
> >  *flavio*
> >
> >  *junqueira*
> >
> >
> > research scientist
> >
> >
> > f...@yahoo-inc.com
> >
> > direct +34 93-183-8828
> >
> >
> > avinguda diagonal 177, 8th floor, barcelona, 08018, es
> >
> > phone (408) 349 3300fax (408) 349 3301
> >
> >
> >
> >
> >
> >
> >   *flavio*
> > *junqueira*
> >
> > research scientist
> >
> > f...@yahoo-inc.com
> > direct +34 93-183-8828
> >
> 

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Mahadev Konar]

Thanks a lot Vishal.

I have reviewed the patch already. Ill let ben decide how/when to
commit to 3.3.3 branch. Ben let me know if you want me to commit the
patch to 3.3 branch.

thanks
mahadev

On Wed, Feb 23, 2011 at 10:33 AM, Vishal Kher  wrote:
> Hi Mahadev,
>
> I have submitted the patch to the jira.
>
> -Vishal
>
> On Tue, Feb 22, 2011 at 11:14 PM, Mahadev Konar  wrote:
>
>> Thanks Ben. Vishal, would you be able to upload the patch today/tomm?
>> I can review and commit.
>>
>> thanks
>> mahadev
>>
>> On Tue, Feb 22, 2011 at 7:38 PM, Benjamin Reed  wrote:
>> > sorry i didn't respond earlier. i've been off the grid today. (tahoe)
>> since
>> > i have to roll a new release anyway. i'd be glad to put it in. i just
>> don't
>> > want to delay the release any longer.
>> >
>> > ben
>> >
>> > On Tue, Feb 22, 2011 at 2:45 PM, Mahadev Konar 
>> wrote:
>> >
>> >> Hi Vishal,
>> >>   900 seems like a biigger change. I think just 880 should be fine, so
>> that
>> >> folks dont hit the thread blow up issue. BTW, all depends on Ben if he
>> is
>> >> willing to get 880 in 3.3.3 release. If not we'll have to wait for 3.4
>> or
>> >> another release  like 3.3.4 (which i personally would like to avoid).
>> >>
>> >> thanks
>> >> mahadev
>> >>
>> >> On Tue, Feb 22, 2011 at 1:09 PM, Vishal Kher 
>> wrote:
>> >>
>> >>> Hi Mahadev,
>> >>>
>> >>> I can certainly work on getting 880 in the release. I would like to
>> know
>> >>> if 900 needs to go in 3.3.3 or not. If I remember correctly, merging
>> patch
>> >>> for 880  failed when I tired last time because the fix for 900 was not
>> >>> committed to 3.3.If 900 is not needed, then I can do the fix only for
>> 880.
>> >>> Shouldn't take that long. Note - without the fix for 900, QCM can block
>> >>> indefinitely. This can cause serious problems during leader election
>> >>> (especially in a 3 node setup). Let me know.
>> >>>
>> >>> -Vishal
>> >>>
>> >>> btw, will there be another release before 3.4.0? We would like to have
>> >>> patches to ZOOKEEPER-932<
>> https://issues.apache.org/jira/browse/ZOOKEEPER-932>and
>> >>> ZOOKEEPER-975 
>> >>> released
>> soon as well.
>> >>>
>> >>>
>> >>> On Tue, Feb 22, 2011 at 1:53 PM, Mahadev Konar > >wrote:
>> >>>
>>  Ben/Vishal,
>>    Is there any possibility of getting ZOOKEEPER-880 in 3.3.3 release?
>> The
>>  Hbase guys had been asking for it.
>> 
>>  thanks
>>  mahadev
>> 
>> 
>>  On Tue, Feb 22, 2011 at 9:38 AM, Flavio Junqueira > >wrote:
>> 
>> > I'm not sure why you say it is fine, Pat. If I try to compile with
>> the
>> > candidate release, ant complains that build-contrib.xml is missing
>> (and it
>> > is not where it is supposed to be). Compiling from trunk or one of
>> the
>> > branches works fine, though.
>> >
>> > -Flavio
>> >
>> > On Feb 22, 2011, at 6:04 PM, Patrick Hunt wrote:
>> >
>> > I think it's fine - it's in src/contrib not contrib.
>> >
>> > On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed 
>> > wrote:
>> >
>> > i don't know why build-contrib.xml is missing. pat do you have any
>> > ideas?
>> >
>> > ant tar should grab it right?
>> >
>> >
>> > ben
>> >
>> >
>> >
>> > On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira > > >wrote:
>> >
>> >
>> > Ben, I have a question. Even though the bookkeeper jar is there,
>> >
>> > build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails
>> > without
>> >
>> > it. Is it supposed to be this way?
>> >
>> >
>> > -Flavio
>> >
>> >
>> >
>> > On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:
>> >
>> >
>> > (the previous email had the URL slightly incorrect)
>> >
>> >
>> > after much struggle! i've created a candidate build for ZooKeeper
>> 3.3.3.
>> >
>> > this is a bug fix
>> >
>> > release addressing 13 issues (two of them extremely critical) -- see
>> the
>> >
>> > release notes for details.
>> >
>> >
>> > *** Please download, test and VOTE before the
>> >
>> > *** vote closes 11pm pacific time, Tuesday, February 22.***
>> >
>> >
>> > http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
>> >
>> >
>> > one thing that has not been fixed in this release is that the docs
>> still
>> >
>> > reference hadoop. this will be fixed in a future release.
>> >
>> >
>> > should we release this?
>> >
>> >
>> > ben
>> >
>> >
>> > ps - give that this is the first release there is more than likely
>> >
>> > something
>> >
>> > i missed and given the severity of issues addressed it would be nice
>> to
>> >
>> > get
>> >
>> > it out quickly. please review ASAP.
>> >
>> >
>> >
>> >  *flavio*
>> >
>> >  *junqueira*
>> >
>> >
>> > research s

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Patrick Hunt]

On Wed, Feb 23, 2011 at 3:21 AM, Flavio Junqueira  wrote:

> The problem is that there is a path "zookeeper-3.3.3/contrib/bookkeeper"
> containing build.xml and source code. If you try to run from there, it will
> fail. I'm actually wondering why we have the source code both under contrib/
> and under src/contrib/. The folder structure under contrib/ is different and
> it does look like it is not supposed to compile (hence my confusion), and I
> wonder why we need it in the release.
>
>
We inherited that structure from hadoop back when ZK was initially moved to
apache (so it's been like this since 3.0.0). If I understand correctly the
intent is to have a "src" (src/contrib) and a "dest" (contrib) structure,
where dest includes both the source and binary. Notice contrib/bookeeper has
a bookeeper.jar in the release artifact. Perhaps we should just have
bookeeper.jar in there, and not the source... Another alternative is to just
not have contrib at all (the user would be required to compile the bk jar
say).

Really though I think we should focus on moving to something like maven.
Such that we can generate the src/bin/doc for each component and push
generated artifacts to the maven repo. At which point this is a non issue.

Patrick



> On Feb 22, 2011, at 10:34 PM, Patrick Hunt wrote:
>
> On Tue, Feb 22, 2011 at 9:38 AM, Flavio Junqueira 
>  wrote:
>
>> I'm not sure why you say it is fine, Pat. If I try to compile with the
>> candidate release, ant complains that build-contrib.xml is missing (and it
>> is not where it is supposed to be). Compiling from trunk or one of the
>> branches works fine, though.
>>
>
> Hi Flavio, can you be more specific? Because it's working fine for me:
>
> cd zookeeper-3.3.3/src/contrib/bookkeeper
> ant jar
> ...
> jar:
>  [echo] contrib: bookkeeper
>
> BUILD SUCCESSFUL
> Total time: 2 seconds
>
>
>
>> -Flavio
>>
>> On Feb 22, 2011, at 6:04 PM, Patrick Hunt wrote:
>>
>> I think it's fine - it's in src/contrib not contrib.
>>
>> On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed 
>> wrote:
>>
>> i don't know why build-contrib.xml is missing. pat do you have any ideas?
>>
>> ant tar should grab it right?
>>
>>
>> ben
>>
>>
>>
>> On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira > >wrote:
>>
>>
>> Ben, I have a question. Even though the bookkeeper jar is there,
>>
>> build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails without
>>
>> it. Is it supposed to be this way?
>>
>>
>> -Flavio
>>
>>
>>
>> On Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:
>>
>>
>> (the previous email had the URL slightly incorrect)
>>
>>
>> after much struggle! i've created a candidate build for ZooKeeper 3.3.3.
>>
>> this is a bug fix
>>
>> release addressing 13 issues (two of them extremely critical) -- see the
>>
>> release notes for details.
>>
>>
>> *** Please download, test and VOTE before the
>>
>> *** vote closes 11pm pacific time, Tuesday, February 22.***
>>
>>
>> http://people.apache.org/~breed/zookeeper-3.3.3-candidate-0/
>>
>>
>> one thing that has not been fixed in this release is that the docs still
>>
>> reference hadoop. this will be fixed in a future release.
>>
>>
>> should we release this?
>>
>>
>> ben
>>
>>
>> ps - give that this is the first release there is more than likely
>>
>> something
>>
>> i missed and given the severity of issues addressed it would be nice to
>>
>> get
>>
>> it out quickly. please review ASAP.
>>
>>
>>
>>  *flavio*
>>
>> *junqueira*
>>
>>
>> research scientist
>>
>>
>> f...@yahoo-inc.com
>>
>> direct +34 93-183-8828
>>
>>
>> avinguda diagonal 177, 8th floor, barcelona, 08018, es
>>
>> phone (408) 349 3300fax (408) 349 3301
>>
>>
>>
>>
>>
>>
>>   *flavio*
>> *junqueira*
>>
>> research scientist
>>
>> f...@yahoo-inc.com
>> direct +34 93-183-8828
>>
>> avinguda diagonal 177, 8th floor, barcelona, 08018, es
>> phone (408) 349 3300fax (408) 349 3301
>>
>> 
>>
>>
>
> *flavio*
> *junqueira*
>
> research scientist
>
> f...@yahoo-inc.com
> direct +34 93-183-8828
>
> avinguda diagonal 177, 8th floor, barcelona, 08018, es
> phone (408) 349 3300fax (408) 349 3301
>
>
>

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

[Patrick Hunt]

See my comments I just sent to Flavio. I agree, if we go with
something like maven we should be able to have a source only release
artifact, plus a number of binary artifacts (push to maven, a separate
binary artifact, etc...). I've proposed maven in the past, but not
gotten much interest. Now that addl people are participating in the RM
task there may be renewed interest. ;-)

Patrick

On Wed, Feb 23, 2011 at 4:55 AM, Thomas Koch  wrote:
> Flavio Junqueira:
>> The problem is that there is a path "zookeeper-3.3.3/contrib/
>> bookkeeper" containing build.xml and source code. If you try to run
>> from there, it will fail. I'm actually wondering why we have the
>> source code both under contrib/ and under src/contrib/. The folder
>> structure under contrib/ is different and it does look like it is not
>> supposed to compile (hence my confusion), and I wonder why we need it
>> in the release.
>>
>> -Flavio
> The code dupliation of contrib and src/contrib is one of the annoyances when
> packaging ZooKeeper for Debian. You'd really do me a favor if you'd release a
> tarball without this duplication.
> (The biggest annoyance is the shipment of binary .jar files in every java
> project, not only ZooKeeper. - But things are getting better slowly with
> maven.)
>
> Best regards,
>
> Thomas Koch, http://www.koch.ro
>